ChangeLog 1.4 MB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47
2011-01-13  Enrica Casucci  <enrica@apple.com>

        Reviewed by Darin Adler.

        WebKit2: Add support for drag and drop
        https://bugs.webkit.org/show_bug.cgi?id=52343
        <rdar://problem/7660558>
               
        This patch contains the changes required to support dropping content
        in WebKit on the Mac. The DragData class has been extended to provide
        additional context from the application (keyboard state, modal windows, etc.)
        as well as information of the drag pasteboard being used.
        The support for WebKit as drag source will be added with a separate patch.

        * Shared/DragControllerAction.h: Added.
        * UIProcess/API/mac/WKView.mm:
        Added implemention of the methods required to add suport for a drop target.
        To maintain asynchronous communication with the WebProcess, we always return
        the previous calculated value for the drag operation.
        (-[WKView _registerDraggedTypes]):
        (-[WKView initWithFrame:contextRef:pageGroupRef:]):
        (-[WKView applicationFlags:]):
        (-[WKView draggingEntered:]):
        (-[WKView draggingUpdated:]):
        (-[WKView draggingExited:]):
        (-[WKView prepareForDragOperation:]):
        (-[WKView performDragOperation:]):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy):
        (WebKit::WebPageProxy::performDragControllerAction):
        (WebKit::WebPageProxy::didPerformDragControllerAction):
        * UIProcess/WebPageProxy.h:
        (WebKit::WebPageProxy::dragOperation):
        (WebKit::WebPageProxy::resetDragOperation):
        * UIProcess/WebPageProxy.messages.in:
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/WebCoreSupport/WebDragClient.cpp:
        (WebKit::WebDragClient::willPerformDragDestinationAction):
        (WebKit::WebDragClient::willPerformDragSourceAction):
        (WebKit::WebDragClient::actionMaskForDrag):
        (WebKit::WebDragClient::dragSourceActionMaskForPoint):
        (WebKit::WebDragClient::startDrag):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::performDragControllerAction):
        * WebProcess/WebPage/WebPage.h:
        * WebProcess/WebPage/WebPage.messages.in:

48 49 50 51 52 53 54 55 56 57 58
2011-01-13  Dan Bernstein  <mitz@apple.com>

        Reviewed by John Sullivan.

        Incorrect assertion in DrawingAreaImpl::scroll()
        https://bugs.webkit.org/show_bug.cgi?id=52376

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::scroll): Changed to take the fast path if the rects have the same area.
        This made the assertion valid, but I removed it anyway.

kbalazs@webkit.org's avatar
kbalazs@webkit.org committed
59 60 61 62 63 64 65 66 67 68 69 70 71
2011-01-12  Balazs Kelemen  <kbalazs@webkit.org>

        Unreviewed.

        Getting rid of the unused 'viewportSize' argument in QWKPagePrivate:init.
        The argument is unused since http://trac.webkit.org/changeset/75468.

        * UIProcess/API/qt/qgraphicswkview.cpp:
        (QGraphicsWKView::QGraphicsWKView):
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::init):
        * UIProcess/API/qt/qwkpage_p.h:

72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement DrawingAreaImpl::scroll
        https://bugs.webkit.org/show_bug.cgi?id=52346

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::scroll):
        If there is already an active scroll, compute the area of both scroll rects and
        invalidate the smallest one. Compute a new dirty region if necessary and also
        add the scroll repaint region to the dirty region.

        (WebKit::DrawingAreaImpl::display):
        Reset the scroll area and scroll delta.

        * WebProcess/WebPage/DrawingAreaImpl.h:
        Add scroll area and scroll delta member variables.

91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Region improvements
        https://bugs.webkit.org/show_bug.cgi?id=52344

        * Platform/Region.cpp:
        (WebKit::Region::Shape::move):
        (WebKit::Region::move):
        Change Region::move to take an IntSize.

        * Platform/Region.h:
        (WebKit::intersect):
        (WebKit::subtract):
        (WebKit::move):
        Add convenience functions.

109 110 111 112 113 114
2011-01-12  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Qt build fix for r75661

        * Shared/WebEvent.h: Don't declare phase() on non-Mac platforms.

115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132
2011-01-12  Beth Dakin  <bdakin@apple.com>

        Reviewed by Anders Carlsson.

        Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309 
        Expose fixed layout through WebKit SPI
        -and corresponding-
        <rdar://problem/8844464>

        And now with getters!
        * UIProcess/API/C/WKPage.cpp:
        (WKPageUseFixedLayout):
        (WKPageFixedLayoutSize):
        * UIProcess/API/C/WKPage.h:
        * UIProcess/WebPageProxy.h:
        (WebKit::WebPageProxy::useFixedLayout):
        (WebKit::WebPageProxy::fixedLayoutSize):

133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153
2011-01-12  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=52337
        PlatformWheelEvent should know about the scroll phase on the Mac

        Add a phase parameter on Mac WebWheelEvent and pipe it down to PlatformWheelEvent.

        * Shared/WebEvent.h:
        (WebKit::WebWheelEvent::phase):
        * Shared/WebEventConversion.cpp:
        (WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
        * Shared/WebWheelEvent.cpp:
        (WebKit::WebWheelEvent::WebWheelEvent):
        (WebKit::WebWheelEvent::encode):
        (WebKit::WebWheelEvent::decode):
        * Shared/mac/WebEventFactory.mm:
        (WebKit::phaseForEvent):
        (WebKit::WebEventFactory::createWebWheelEvent):

154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Get rid of an unneeded parameter from DrawingArea::scroll
        https://bugs.webkit.org/show_bug.cgi?id=52336

        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::scroll):
        * WebProcess/WebCoreSupport/WebChromeClient.h:
        * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
        (WebKit::ChunkedUpdateDrawingArea::scroll):
        * WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
        * WebProcess/WebPage/DrawingArea.h:
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::scroll):
        * WebProcess/WebPage/DrawingAreaImpl.h:
        * WebProcess/WebPage/LayerBackedDrawingArea.cpp:
        (WebKit::LayerBackedDrawingArea::scroll):
        * WebProcess/WebPage/LayerBackedDrawingArea.h:
        * WebProcess/WebPage/TiledDrawingArea.cpp:
        (WebKit::TiledDrawingArea::scroll):
        * WebProcess/WebPage/TiledDrawingArea.h:

178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Get the new drawing area painting to the screen
        https://bugs.webkit.org/show_bug.cgi?id=52331

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
        Call setViewNeedsDisplay on all the update rects.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::setViewNeedsDisplay):
        Call through to the page client.

        (WebKit::WebPageProxy::processDidCrash):
        Null out the drawing area proxy.
        
        * UIProcess/mac/BackingStoreMac.mm:
        (WebKit::BackingStore::paint):
        Paint.

200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        More work on getting the drawing area proxy to paint
        https://bugs.webkit.org/show_bug.cgi?id=52328

        * UIProcess/API/mac/WKView.mm:
        (-[WKView drawRect:]):
        Handle the new drawing area.

        * UIProcess/BackingStore.cpp:
        (WebKit::BackingStore::BackingStore):
        Assert that the size isn't empty.
        
        * UIProcess/BackingStore.h:
        * UIProcess/mac/BackingStoreMac.mm:
        (WebKit::BackingStore::incorporateUpdate):
        Paint all update rects into the bitmap context.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::display):
        Create a handle so the shareable bitmap will actually be transferred over.

andersca@apple.com's avatar
andersca@apple.com committed
224 225 226 227 228 229 230
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Fix build.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::incorporateUpdate):

231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Begin stubbing out some more BackingStore member functions
        https://bugs.webkit.org/show_bug.cgi?id=52323

        * UIProcess/BackingStore.cpp:
        (WebKit::BackingStore::~BackingStore):
        This was accidentally made into a constructor; it should be a destructor.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::paint):
        Call the backing store.

        (WebKit::DrawingAreaProxyImpl::update):
        Incorporate the update.

        (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
        Create the backing store if needed and incorporate the update.

        * UIProcess/mac/BackingStoreMac.mm: Added.
        (WebKit::BackingStore::platformInitialize):
        Create a bitmap context.

        (WebKit::BackingStore::paint):
        (WebKit::BackingStore::incorporateUpdate):
        Add stubs.

        * WebKit2.xcodeproj/project.pbxproj:
        Add BackingStoreMac.mm

263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293
2011-01-12  Beth Dakin  <bdakin@apple.com>

        Reviewed by Anders Carlsson.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
        fixed layout through WebKit SPI
        -and corresponding-
        <rdar://problem/8844464>

        Store useFixedLayout and fixedLayoutSize in the 
        WebPageCreationParameters and the WebPageProxy.
        * Shared/WebPageCreationParameters.cpp:
        (WebKit::WebPageCreationParameters::encode):
        (WebKit::WebPageCreationParameters::decode):
        * Shared/WebPageCreationParameters.h:
        * UIProcess/API/C/WKPage.cpp:
        (WKPageSetUseFixedLayout):
        (WKPageSetFixedLayoutSize):
        * UIProcess/API/C/WKPage.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy):
        (WebKit::WebPageProxy::setUseFixedLayout):
        (WebKit::WebPageProxy::setFixedLayoutSize):
        (WebKit::WebPageProxy::creationParameters):
        * UIProcess/WebPageProxy.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::setUseFixedLayout):
        (WebKit::WebPage::setFixedLayoutSize):
        * WebProcess/WebPage/WebPage.h:
        * WebProcess/WebPage/WebPage.messages.in:

294 295 296 297 298 299 300 301 302 303 304 305 306
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Beth Dakin.

        Add BackingStore class
        https://bugs.webkit.org/show_bug.cgi?id=52318

        * UIProcess/BackingStore.cpp: Added.
        (WebKit::BackingStore::create):
        (WebKit::BackingStore::BackingStore):
        * UIProcess/BackingStore.h: Added.
        * WebKit2.xcodeproj/project.pbxproj:

307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363
2011-01-12  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/8837307>, <rdar://problem/8637038>, and https://bugs.webkit.org/show_bug.cgi?id=52248
        Back/forward list recovery after a WebProcess crash is crashy itself.

        Add an isEmpty() accessor so the WebProcess knows if it is actually restoring a session:
        * Shared/SessionState.cpp:
        (WebKit::SessionState::isEmpty):
        * Shared/SessionState.h:

        Keep track of the highest used itemID so a relaunched WebProcess can later be informed:
        * Shared/WebBackForwardListItem.cpp:
        (WebKit::WebBackForwardListItem::WebBackForwardListItem):
        (WebKit::WebBackForwardListItem::highedUsedItemID):
        * Shared/WebBackForwardListItem.h:
        * WebProcess/WebPage/WebBackForwardListProxy.cpp:
        (WebKit::generateHistoryItemID):
        (WebKit::WebBackForwardListProxy::setHighestItemIDFromUIProcess):
        (WebKit::WebBackForwardListProxy::addItemFromUIProcess): Remove a now-invalid ASSERT, as the UIProcess
          now tells the WebProcess that a previous WebProcess created.
        * WebProcess/WebPage/WebBackForwardListProxy.h:

        Encode/decode data relevant to restoring a session on WebPage creation:
        * Shared/WebPageCreationParameters.cpp:
        (WebKit::WebPageCreationParameters::encode):
        (WebKit::WebPageCreationParameters::decode):
        * Shared/WebPageCreationParameters.h:

        If the WebProcess has crashed since the last load, change reload and the various back/forward APIs to 
        update the current back/forward item (if necessary) then relaunch the process:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::reattachToWebProcessWithItem):
        (WebKit::WebPageProxy::reattachToWebProcess): Renamed from "relaunch()" and made private.
        (WebKit::WebPageProxy::initializeWebPage):
        (WebKit::WebPageProxy::loadURL):
        (WebKit::WebPageProxy::loadURLRequest):
        (WebKit::WebPageProxy::reload):
        (WebKit::WebPageProxy::goForward):
        (WebKit::WebPageProxy::goBack):
        (WebKit::WebPageProxy::goToBackForwardItem):
        (WebKit::WebPageProxy::creationParameters):
        * UIProcess/WebPageProxy.h:

        Rename "RestoreSession" to "RestoreSessionAndNavigateToCurrentItem"
        * WebProcess/WebPage/WebPage.messages.in:
        * UIProcess/cf/WebPageProxyCF.cpp:
        (WebKit::WebPageProxy::restoreFromSessionStateData):

        Restore a session on page creation if the parameters include it:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::WebPage): Call restoreSession if session state exists.
        (WebKit::WebPage::restoreSessionAndNavigateToCurrentItem):
        (WebKit::WebPage::restoreSession):
        * WebProcess/WebPage/WebPage.h:

364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Send Update and DidUpdate messages
        https://bugs.webkit.org/show_bug.cgi?id=52316

        * UIProcess/DrawingAreaProxy.h:
        (WebKit::DrawingAreaProxy::update):
        Add empty stub.

        * UIProcess/DrawingAreaProxy.messages.in:
        Add Update message.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::update):
        Just send back a DidUpdate message.

        * WebProcess/WebPage/DrawingArea.h:
        (WebKit::DrawingArea::didUpdate):
        Add empty stub.

        * WebProcess/WebPage/DrawingArea.messages.in:
        Add DidUpdate message.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::didUpdate):
        Call display().

        (WebKit::DrawingAreaImpl::display):
        Send an Update message.

396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Make the new drawing area actually draw something
        https://bugs.webkit.org/show_bug.cgi?id=52314

        * Shared/UpdateInfo.cpp:
        (WebKit::UpdateInfo::encode):
        (WebKit::UpdateInfo::decode):
        Encode and decode newly added fields.

        * Shared/UpdateInfo.h:
        Add a vector of update rects and a handle for the sharable bitmap.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::display):
        Get the individual rects from the region and paint them into the shareable bitmap.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::mainFrameHasCustomRepresentation):
        * WebProcess/WebPage/WebPage.h:
        Add helper function.

        * WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp:
        (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
        Use helper function.

424 425 426 427 428 429 430 431 432 433 434 435 436 437
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add UpdateInfo class
        https://bugs.webkit.org/show_bug.cgi?id=52306

        * Shared/UpdateInfo.cpp: Added.
        (WebKit::UpdateInfo::encode):
        (WebKit::UpdateInfo::decode):
        * Shared/UpdateInfo.h: Added.
        (WebKit::UpdateInfo::UpdateInfo):
        * WebKit2.xcodeproj/project.pbxproj:

438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        More work on the new drawing area implementation
        https://bugs.webkit.org/show_bug.cgi?id=52302

        * Platform/Region.cpp:
        (WebKit::Region::Shape::segments_end):
        segments_end could end up returning an iterator that is one element past the Vector data, so
        we can't use operator[] since that will assert.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::DrawingAreaImpl):
        Initialize the timer.

        (WebKit::DrawingAreaImpl::setNeedsDisplay):
        Unite the rect with the dirty region and schedule a display.

        (WebKit::DrawingAreaImpl::setSize):
        Tell the web page to resize.

        (WebKit::DrawingAreaImpl::scheduleDisplay):
        Start a display timer if needed.

        (WebKit::DrawingAreaImpl::display):
        Add a stub.

466 467 468 469 470 471 472 473
2011-01-12  Brent Fulgham  <bfulgham@webkit.org>

        Unreviewed build fix after r75527.  Rename 'BackingStoreCairo.cpp'
        to 'ShareableBitmapCairo.cpp' to match VS project changes.

        * Shared/cairo/BackingStoreCairo.cpp: Removed.
        * Shared/cairo/ShareableBitmapCairo.cpp: Copied from Shared/cairo/BackingStoreCairo.cpp.

474 475 476 477 478 479 480 481 482 483 484
2011-01-11  Jeff Miller  <jeffm@apple.com>

        Reviewed by John Sullivan.

        WebKit2: "Webpages not responding" dialog appears when <select> popup menu is showing
        https://bugs.webkit.org/show_bug.cgi?id=52242

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::showPopupMenu):
        On Windows, stop the responsiveness timer before calling showPopupMenu().

485 486 487 488 489 490 491 492 493 494 495
2011-01-11  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders Carlsson.

        UIProcess kills the WebProcess sometimes when detached frames exist
        https://bugs.webkit.org/show_bug.cgi?id=52227

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didSaveFrameToPageCache): Don't consider the message invalid
        if it came in for a detached frame.

andersca@apple.com's avatar
andersca@apple.com committed
496 497 498 499 500 501
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Build fix.

        * WebKit2.xcodeproj/project.pbxproj:

502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add a Region class which represents a graphical region
        https://bugs.webkit.org/show_bug.cgi?id=52255

        * Platform/Region.cpp: Added.
        (WebKit::Region::Region):
        (WebKit::Region::rects):
        (WebKit::Region::Shape::Shape):
        (WebKit::Region::Shape::appendSpan):
        (WebKit::Region::Shape::canCoalesce):
        (WebKit::Region::Shape::appendSpans):
        (WebKit::Region::Shape::appendSegment):
        (WebKit::Region::Shape::spans_begin):
        (WebKit::Region::Shape::spans_end):
        (WebKit::Region::Shape::segments_begin):
        (WebKit::Region::Shape::segments_end):
        (WebKit::Region::Shape::dump):
        (WebKit::Region::Shape::bounds):
        (WebKit::Region::Shape::move):
        (WebKit::Region::Shape::swap):
        (WebKit::Region::Shape::shapeOperation):
        (WebKit::Region::Shape::UnionOperation::trySimpleOperation):
        (WebKit::Region::Shape::unionShapes):
        (WebKit::Region::Shape::IntersectOperation::trySimpleOperation):
        (WebKit::Region::Shape::intersectShapes):
        (WebKit::Region::Shape::SubtractOperation::trySimpleOperation):
        (WebKit::Region::Shape::subtractShapes):
        (WebKit::Region::dump):
        (WebKit::Region::intersect):
        (WebKit::Region::unite):
        (WebKit::Region::subtract):
        (WebKit::Region::move):
        * Platform/Region.h: Added.
        (WebKit::Region::bounds):
        (WebKit::Region::isEmpty):
        (WebKit::Region::Span::Span):
        (WebKit::Region::Shape::isEmpty):
        * WebKit2.xcodeproj/project.pbxproj:

544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Add DidSetSize message
        https://bugs.webkit.org/show_bug.cgi?id=52254

        * DerivedSources.make:
        Add DrawingAReaProxy.messages.in.

        * Platform/CoreIPC/MessageID.h:
        Add DrawingAreaProxy message class.

        * UIProcess/DrawingAreaProxy.h:
        (WebKit::DrawingAreaProxy::didSetSize):
        Add CoreIPC message handler function.

        * UIProcess/DrawingAreaProxy.messages.in: Added.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::didSetSize):
        Add stub.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveMessage):
        Handle DrawingAreaProxy messages.

        * WebKit2.xcodeproj/project.pbxproj:
        Add new files.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::setSize):
        Send a DidSetSize message for now.

578 579 580 581 582 583 584 585 586 587 588 589 590
2011-01-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Fix spelling mistake. Sharable -> Shareable.

        * Shared/API/c/WKImage.h:
        * Shared/API/c/WKSharedAPICast.h:
        (WebKit::toImageOptions):
        * Shared/ImageOptions.h:
        * Shared/WebImage.cpp:
        (WebKit::WebImage::create):

591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add SetSize message
        https://bugs.webkit.org/show_bug.cgi?id=52247

        * DerivedSources.make:
        Add DrawingArea.messages.in

        * Platform/CoreIPC/MessageID.h:
        Add DrawingArea message class.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::sizeDidChange):
        Call sendSetSize.

        (WebKit::DrawingAreaProxyImpl::sendSetSize):
        Send a SetSize message.

        * UIProcess/DrawingAreaProxyImpl.h:
        Add setSize override.

        * WebKit2.xcodeproj/project.pbxproj:
        Add new files.

        * WebProcess/WebPage/DrawingArea.h:
        (WebKit::DrawingArea::setSize):
        Add setSize member function.

        * WebProcess/WebPage/DrawingArea.messages.in: Added.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        * WebProcess/WebPage/DrawingAreaImpl.h:
        Add setSize.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::didReceiveMessage):
        Handle drawing area messages.

631 632 633 634 635 636 637 638 639 640
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Replace ASSERTs with FIXMEs.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::sizeDidChange):
        (WebKit::DrawingAreaProxyImpl::setPageIsVisible):

641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add DrawingAreaImpl skeleton class
        https://bugs.webkit.org/show_bug.cgi?id=52246

        * UIProcess/API/mac/WKView.mm:
        (useNewDrawingArea):
        New function which controls which drawing area to use, through an environment variable.

        (-[WKView drawRect:]):
        Bail if we're using the new drawing area (for now).

        (-[WKView WebKit::]):
        Create a DrawingAreaProxyImpl when asked to.

        * WebKit2.xcodeproj/project.pbxproj:
        Add new files.

        * WebProcess/WebPage/DrawingArea.cpp:
        (WebKit::DrawingArea::create):
        Create a DrawingAreaImpl when asked to.

        * WebProcess/WebPage/DrawingAreaImpl.cpp: Added.
        * WebProcess/WebPage/DrawingAreaImpl.h: Added.
        Add DrawingAreaImpl class.

669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add Mac-only DrawingAreaProxyImpl class skeleton
        https://bugs.webkit.org/show_bug.cgi?id=52243

        This is the proxy side of a new drawing area implementation. This is Mac only for now
        while the design is being fleshed out.

        * Shared/DrawingAreaInfo.h:
        * UIProcess/API/mac/WKView.mm:
        (-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
        * UIProcess/DrawingAreaProxyImpl.cpp: Added.
        (WebKit::DrawingAreaProxyImpl::create):
        (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
        (WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl):
        (WebKit::DrawingAreaProxyImpl::didReceiveMessage):
        (WebKit::DrawingAreaProxyImpl::didReceiveSyncMessage):
        (WebKit::DrawingAreaProxyImpl::paint):
        (WebKit::DrawingAreaProxyImpl::sizeDidChange):
        (WebKit::DrawingAreaProxyImpl::setPageIsVisible):
        (WebKit::DrawingAreaProxyImpl::attachCompositingContext):
        (WebKit::DrawingAreaProxyImpl::detachCompositingContext):
        * UIProcess/DrawingAreaProxyImpl.h: Added.
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/WebPage/DrawingArea.cpp:
        (WebKit::DrawingArea::create):

andersca@apple.com's avatar
andersca@apple.com committed
698 699 700 701 702 703 704
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Fix Windows build.

        * WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
        (WebKit::WebPopupMenu::setUpPlatformData):

705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Rename ShareableBitmap::createSharable to createShareable
        https://bugs.webkit.org/show_bug.cgi?id=52234

        * Shared/ShareableBitmap.cpp:
        (WebKit::ShareableBitmap::createShareable):
        * Shared/ShareableBitmap.h:
        * Shared/WebImage.cpp:
        (WebKit::WebImage::create):
        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::geometryDidChange):
        * WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
        (WebKit::WebPopupMenu::setUpPlatformData):
        * WebProcess/WebPage/FindController.cpp:
        (WebKit::FindController::updateFindIndicator):

724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Rename BackingStore to ShareableBitmap
        https://bugs.webkit.org/show_bug.cgi?id=52228

        * GNUmakefile.am:
        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::geometryDidChange):
        * PluginProcess/PluginControllerProxy.h:
        * Shared/API/c/cg/WKImageCG.cpp:
        (WKImageCreateCGImage):
        * Shared/BackingStore.cpp: Removed.
        * Shared/BackingStore.h: Removed.
        * Shared/PlatformPopupMenuData.cpp:
        (WebKit::PlatformPopupMenuData::decode):
        * Shared/PlatformPopupMenuData.h:
        * Shared/ShareableBitmap.cpp: Copied from WebKit2/Shared/BackingStore.cpp.
        (WebKit::ShareableBitmap::create):
        (WebKit::ShareableBitmap::createSharable):
        (WebKit::ShareableBitmap::createHandle):
        (WebKit::ShareableBitmap::ShareableBitmap):
        (WebKit::ShareableBitmap::~ShareableBitmap):
        (WebKit::ShareableBitmap::resize):
        (WebKit::ShareableBitmap::data):
        * Shared/ShareableBitmap.h: Copied from WebKit2/Shared/BackingStore.h.
        * Shared/UserMessageCoders.h:
        (WebKit::UserMessageEncoder::baseEncode):
        (WebKit::UserMessageDecoder::baseDecode):
        * Shared/WebImage.cpp:
        (WebKit::WebImage::create):
        (WebKit::WebImage::WebImage):
        (WebKit::WebImage::~WebImage):
        (WebKit::WebImage::size):
        * Shared/WebImage.h:
        (WebKit::WebImage::bitmap):
        * Shared/cairo/BackingStoreCairo.cpp:
        (WebKit::ShareableBitmap::createGraphicsContext):
        (WebKit::ShareableBitmap::paint):
        * Shared/cg/BackingStoreCG.cpp: Removed.
        * Shared/cg/ShareableBitmapCG.cpp: Copied from WebKit2/Shared/cg/BackingStoreCG.cpp.
        (WebKit::ShareableBitmap::createGraphicsContext):
        (WebKit::ShareableBitmap::paint):
        * Shared/gtk/BackingStoreGtk.cpp: Removed.
        * Shared/gtk/ShareableBitmapGtk.cpp: Copied from WebKit2/Shared/gtk/BackingStoreGtk.cpp.
        (WebKit::ShareableBitmap::createGraphicsContext):
        (WebKit::ShareableBitmap::paint):
        * Shared/qt/BackingStoreQt.cpp: Removed.
        * Shared/qt/ShareableBitmapQt.cpp: Copied from WebKit2/Shared/qt/BackingStoreQt.cpp.
        (WebKit::ShareableBitmap::createGraphicsContext):
        (WebKit::ShareableBitmap::paint):
        * UIProcess/FindIndicator.cpp:
        (WebKit::FindIndicator::create):
        (WebKit::FindIndicator::FindIndicator):
        * UIProcess/FindIndicator.h:
        (WebKit::FindIndicator::contentImage):
        * WebKit2.pro:
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::geometryDidChange):
        * WebProcess/Plugins/PluginProxy.h:
        * WebProcess/WebPage/FindController.cpp:
        (WebKit::FindController::updateFindIndicator):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::snapshotInViewCoordinates):
        (WebKit::WebPage::snapshotInDocumentCoordinates):
        * win/WebKit2.vcproj:

793 794 795 796 797 798 799 800 801 802 803 804
2011-01-11  John Sullivan  <sullivan@apple.com>

        Reviewed by Anders Carlsson.

        [WKView setFrameSize:] derefs _page->drawingArea() without null check
        <https://bugs.webkit.org/show_bug.cgi?id=52231>

        * UIProcess/API/mac/WKView.mm:
        (-[WKView setFrameSize:]):
        Null check drawingArea(). This is OK because if it doesn't exist then it will be
        created later with the correct initial size.

805 806 807 808 809 810 811 812 813 814 815 816 817 818 819
2011-01-07  Enrica Casucci  <enrica@apple.com>

        Reviewed by Alexey Proskuryakov.

        Paste and drag and drop use different code paths to interact with the pasteboard.
        https://bugs.webkit.org/show_bug.cgi?id=52093
        The change consists in a refactoring of the code to have only one class that
        deals with the pasteboard on Mac.

        * WebProcess/WebCoreSupport/WebEditorClient.h:
        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: Added two methods to provide to WebCore functionality
        exposed by NSURLExtras.
        (WebKit::WebEditorClient::canonicalizeURL):
        (WebKit::WebEditorClient::canonicalizeURLString):

820 821 822 823 824 825 826 827 828 829 830
2011-01-11  Jessie Berlin  <jberlin@apple.com>

        Reviewed by Anders Carlsson and Sam Weinig.

        Fix crash on launch on Windows.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::onSizeEvent):
        The drawing area is no longer initialized before the WebView is created and the first
        onSize is receieved.

831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Automatically reinitialize the web page on relaunch
        https://bugs.webkit.org/show_bug.cgi?id=52224
        <rdar://problem/8765695>

        * UIProcess/API/mac/WKView.mm:
        (-[WKView _didRelaunchProcess]):
        Remove call to reinitializeWebPage.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::relaunch):
        Call initializeWebPage().

        (WebKit::WebPageProxy::initializeWebPage):
        Assert that the web page is valid here.

        * UIProcess/WebPageProxy.h:
        Remove reinitializeWebPage.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::didRelaunchProcess):
        Remove call to reinitializeWebPage.

857 858 859 860 861 862 863 864 865 866 867 868 869
2011-01-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Pass the view size to the DrawingAreaProxy constructor
        https://bugs.webkit.org/show_bug.cgi?id=52189

        * UIProcess/DrawingAreaProxy.cpp:
        (WebKit::DrawingAreaProxy::DrawingAreaProxy):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::viewSize):
        * UIProcess/WebPageProxy.h:

weinig@apple.com's avatar
weinig@apple.com committed
870 871 872 873
2011-01-11  Sam Weinig  <sam@webkit.org>

        Roll r75460 back in with build fix.

874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Andreas Kling.

        Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
        https://bugs.webkit.org/show_bug.cgi?id=52184

        Qt part made my Balazs Kelemen.

        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::createDrawingAreaProxy):
        Call -[WKView _createDrawingAreaProxy].

        (WebKit::PageClientImpl::setViewNeedsDisplay):
        Call setNeedsDisplayInRect on the WKView.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView initWithFrame:contextRef:pageGroupRef:]):
        No need to set the drawing area proxy anymore.

        (-[WKView _createDrawingAreaProxy]):
        Create a chunked update drawing area proxy for now.

        * UIProcess/API/qt/qgraphicswkview.cpp:
        Added a QGraphicsItem* member that is initialized in init to the accociated view.
        Implement the new functions. This is a temporary solution, in the long term the view
        and the page should be decoupled.
        (QGraphicsWKView::QGraphicsWKView):
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::QWKPagePrivate):
        (QWKPagePrivate::init):
        (QWKPagePrivate::createDrawingAreaProxy):
        (QWKPagePrivate::setViewNeedsDisplay):
        * UIProcess/API/qt/qwkpage.h:
        * UIProcess/API/qt/qwkpage_p.h:
        
        * UIProcess/PageClient.h:
        Add new pure virtual member functions.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::initializeWebPage):
        (WebKit::WebPageProxy::reinitializeWebPage):
        Set the new drawing area proxy.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::WebView):
        No need to set the drawing area proxy anymore.

        (WebKit::WebView::createDrawingAreaProxy):
        Create a chunked update drawing area proxy for now.

        (WebKit::WebView::setViewNeedsDisplay):
        Invalidate the window.

aroben@apple.com's avatar
aroben@apple.com committed
929 930 931 932 933 934
2011-01-11  Adam Roben  <aroben@apple.com>

        Fix a typo in a comment

        * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980
2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r75460.
        http://trac.webkit.org/changeset/75460
        https://bugs.webkit.org/show_bug.cgi?id=52191

        It broke Qt-WK2 build (Requested by Ossy on #webkit).

        * Shared/API/c/WKBase.h:
        * Shared/APIObject.h:
        * UIProcess/API/C/WKAPICast.h:
        * UIProcess/API/C/WKGeolocationPermissionRequest.cpp: Removed.
        * UIProcess/API/C/WKGeolocationPermissionRequest.h: Removed.
        * UIProcess/API/C/WKPage.h:
        * UIProcess/API/C/WebKit2.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage):
        * UIProcess/GeolocationPermissionRequestManagerProxy.cpp: Removed.
        * UIProcess/GeolocationPermissionRequestManagerProxy.h: Removed.
        * UIProcess/GeolocationPermissionRequestProxy.cpp: Removed.
        * UIProcess/GeolocationPermissionRequestProxy.h: Removed.
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy):
        (WebKit::WebPageProxy::close):
        (WebKit::WebPageProxy::processDidCrash):
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        * UIProcess/WebUIClient.cpp:
        * UIProcess/WebUIClient.h:
        * WebKit2.pro:
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp: Removed.
        * WebProcess/Geolocation/GeolocationPermissionRequestManager.h: Removed.
        * WebProcess/Geolocation/WebGeolocationManager.cpp:
        * WebProcess/Geolocation/WebGeolocationManager.h:
        * WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
        (WebKit::WebGeolocationClient::requestPermission):
        (WebKit::WebGeolocationClient::cancelPermissionRequest):
        * WebProcess/WebCoreSupport/WebGeolocationClient.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::WebPage):
        * WebProcess/WebPage/WebPage.h:
        * WebProcess/WebPage/WebPage.messages.in:
        * win/WebKit2.vcproj:
        * win/WebKit2Generated.make:

981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002
2011-01-10  Csaba Osztrogonác  <ossy@webkit.org>

        Unreviewed, rolling out r75459
        http://trac.webkit.org/changeset/75459

        Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
        https://bugs.webkit.org/show_bug.cgi?id=52184

        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        * UIProcess/API/mac/WKView.mm:
        * UIProcess/API/mac/WKViewInternal.h:
        * UIProcess/API/qt/qwkpage.cpp:
        * UIProcess/API/qt/qwkpage_p.h:
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::initializeWebPage):
        (WebKit::WebPageProxy::reinitializeWebPage):
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::WebView):
        * UIProcess/win/WebView.h:

1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019
2011-01-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Remove size parameter to WebPageProxy::initializeWebPage
        https://bugs.webkit.org/show_bug.cgi?id=52188

        * UIProcess/API/mac/WKView.mm:
        (-[WKView initWithFrame:contextRef:pageGroupRef:]):
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::init):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::initializeWebPage):
        * UIProcess/WebPageProxy.h:
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::WebView):

andersca@apple.com's avatar
andersca@apple.com committed
1020 1021 1022 1023 1024 1025 1026 1027
2011-01-10  Anders Carlsson  <andersca@apple.com>

        Didn't mean to land this.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::initializeWebPage):
        * UIProcess/WebPageProxy.h:

1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045
2011-01-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        WebPageProxy::creationParameters no longer needs to take a size
        https://bugs.webkit.org/show_bug.cgi?id=52187

        WebPageProxy::creationParameters can just ask the page client for the view size now.

        * UIProcess/WebInspectorProxy.cpp:
        (WebKit::WebInspectorProxy::createInspectorPage):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::initializeWebPage):
        (WebKit::WebPageProxy::reinitializeWebPage):
        (WebKit::WebPageProxy::createNewPage):
        (WebKit::WebPageProxy::creationParameters):
        * UIProcess/WebPageProxy.h:

1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068
2011-01-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Pass information about the view in the WebPageCreationParameters
        https://bugs.webkit.org/show_bug.cgi?id=52186

        * Shared/WebPageCreationParameters.cpp:
        (WebKit::WebPageCreationParameters::encode):
        (WebKit::WebPageCreationParameters::decode):
        Encode and decode the state flags.

        * Shared/WebPageCreationParameters.h:
        Add new state flags.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::creationParameters):
        Initialize the state flags.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::WebPage):
        Update the page state from the state flags.

1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120
2011-01-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Make Geolocation features work in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=52078

        Step 2 - Add support for requesting and granting permission for geolocation.

        * Shared/API/c/WKBase.h:
        * Shared/APIObject.h:
        * UIProcess/API/C/WebKit2.h:
        * UIProcess/API/C/WKAPICast.h:
        * UIProcess/API/C/WKGeolocationPermissionRequest.cpp: Added.
        * UIProcess/API/C/WKGeolocationPermissionRequest.h: Added.
        Add new API type, WKGeolocationPermissionRequestRef.

        * UIProcess/API/C/WKPage.h:
        Add new UIClient function for requesting permission.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage): 
        Stub out the UIClient.

        * UIProcess/GeolocationPermissionRequestManagerProxy.cpp: Added.
        * UIProcess/GeolocationPermissionRequestManagerProxy.h: Added.
        * UIProcess/GeolocationPermissionRequestProxy.cpp: Added.
        * UIProcess/WebPageProxy.cpp:
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        * UIProcess/WebUIClient.cpp:
        * UIProcess/WebUIClient.h:
        * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp: Added.
        * WebProcess/Geolocation/GeolocationPermissionRequestManager.h: Added.
        * WebProcess/Geolocation/WebGeolocationManager.cpp:
        * WebProcess/Geolocation/WebGeolocationManager.h:
        * WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
        * WebProcess/WebCoreSupport/WebGeolocationClient.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::WebPage):
        (WebKit::WebPage::didReceiveGeolocationPermissionDecision):
        * WebProcess/WebPage/WebPage.h:
        (WebKit::WebPage::geolocationPermissionRequestManager):
        * WebProcess/WebPage/WebPage.messages.in:
        Track the permission request through both sides of the process divide.

        * WebKit2.pro:
        * WebKit2.xcodeproj/project.pbxproj:
        * win/WebKit2.vcproj:
        * win/WebKit2Generated.make:
        Add new files.

1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165
2011-01-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
        https://bugs.webkit.org/show_bug.cgi?id=52184

        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::createDrawingAreaProxy):
        Call -[WKView _createDrawingAreaProxy].

        (WebKit::PageClientImpl::setViewNeedsDisplay):
        Call setNeedsDisplayInRect on the WKView.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView initWithFrame:contextRef:pageGroupRef:]):
        No need to set the drawing area proxy anymore.

        (-[WKView _createDrawingAreaProxy]):
        Create a chunked update drawing area proxy for now.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::createDrawingAreaProxy):
        (QWKPagePrivate::setViewNeedsDisplay):
        Add stubs.
    
        * UIProcess/PageClient.h:
        Add new pure virtual member functions.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::initializeWebPage):
        (WebKit::WebPageProxy::reinitializeWebPage):
        Set the new drawing area proxy.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::WebView):
        No need to set the drawing area proxy anymore.

        (WebKit::WebView::createDrawingAreaProxy):
        Create a chunked update drawing area proxy for now.

        (WebKit::WebView::setViewNeedsDisplay):
        Invalidate the window.

andersca@apple.com's avatar
andersca@apple.com committed
1166 1167 1168 1169 1170 1171 1172
2011-01-10  Anders Carlsson  <andersca@apple.com>

        Fix Windows build again.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::isViewWindowActive):

andersca@apple.com's avatar
andersca@apple.com committed
1173 1174 1175 1176 1177 1178 1179
2011-01-10  Anders Carlsson  <andersca@apple.com>

        Fix Windows build.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::onShowWindowEvent):

1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247
2011-01-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Use a pull model for view state changes
        https://bugs.webkit.org/show_bug.cgi?id=52175

        Instead of having the WKView call setFocused, setActive etc on the WebPageProxy, the
        WKView now simply informs the WebPageProxy what has changed, using the WebPageProxy::viewStateDidChange
        function. The WebPageProxy can then fetch the relevant information using newly added PageClient functions.

        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::viewSize):
        (WebKit::PageClientImpl::isViewWindowActive):
        (WebKit::PageClientImpl::isViewFocused):
        (WebKit::PageClientImpl::isViewVisible):
        (WebKit::PageClientImpl::isViewInWindow):
        * UIProcess/API/mac/WKView.mm:
        (-[WKView initWithFrame:contextRef:pageGroupRef:]):
        (-[WKView becomeFirstResponder]):
        (-[WKView resignFirstResponder]):
        (-[WKView viewDidMoveToWindow]):
        (-[WKView _windowDidBecomeKey:]):
        (-[WKView _windowDidResignKey:]):
        (-[WKView viewDidHide]):
        (-[WKView viewDidUnhide]):
        (-[WKView _isFocused]):
        (-[WKView _didRelaunchProcess]):
        * UIProcess/API/mac/WKViewInternal.h:
        * UIProcess/API/qt/qgraphicswkview.cpp:
        (QGraphicsWKView::focusInEvent):
        (QGraphicsWKView::focusOutEvent):
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::QWKPagePrivate):
        (QWKPagePrivate::viewSize):
        (QWKPagePrivate::isViewWindowActive):
        (QWKPagePrivate::isViewFocused):
        (QWKPagePrivate::isViewVisible):
        (QWKPagePrivate::isViewInWindow):
        * UIProcess/API/qt/qwkpage_p.h:
        * UIProcess/PageClient.h:
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::createWebPage):
        * UIProcess/WebContext.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::create):
        (WebKit::WebPageProxy::WebPageProxy):
        (WebKit::WebPageProxy::viewStateDidChange):
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::createWebPage):
        * UIProcess/WebProcessProxy.h:
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::WebView):
        (WebKit::WebView::onSetFocusEvent):
        (WebKit::WebView::onKillFocusEvent):
        (WebKit::WebView::onShowWindowEvent):
        (WebKit::WebView::updateActiveState):
        (WebKit::WebView::viewSize):
        (WebKit::WebView::isViewWindowActive):
        (WebKit::WebView::isViewFocused):
        (WebKit::WebView::isViewVisible):
        (WebKit::WebView::isViewInWindow):
        (WebKit::WebView::didRelaunchProcess):
        (WebKit::WebView::setIsInWindow):
        * UIProcess/win/WebView.h:

1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272
2011-01-10  Adam Roben  <aroben@apple.com>

        Don't pass a reference type to va_start

        C++ says this results in undefined behavior:

            The restrictions that ISO C places on the second parameter to the
            va_start() macro in header <stdarg.h> are different in this
            International Standard. The parameter parmN is the identifier of
            the rightmost parameter in the variable parameter list of the
            function definition (the one just before the ...).221) If the
            parameter parmN is declared with a function, array, or reference
            type, or with a type that is not compatible with the type that
            results when passing an argument for which there is no parameter,
            the behavior is undefined.

        Fixes <http://webkit.org/b/52168> Title of standalone image document
        includes bogus image dimensions

        Rubber-stamped by Eric Seidel.

        * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
        (WebKit::formatLocalizedString): Don't use a reference type for
        |format|.

1273 1274 1275 1276 1277 1278 1279 1280 1281
2011-01-10  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Eric Seidel.

        Support for ARM's RVCT(ARMCC) compiler in import/export directives
        https://bugs.webkit.org/show_bug.cgi?id=52146 

        * Shared/API/c/WKBase.h:

weinig@apple.com's avatar
weinig@apple.com committed
1282 1283 1284 1285 1286 1287 1288
2011-01-10  Sam Weinig  <sam@webkit.org>

        Fix the build.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::WebPage):

1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391
2011-01-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Make Geolocation features work in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=52078

        Step 1 - Add enough support to get position data from a provider.
        This does not include permission support.

        * Platform/CoreIPC/HandleMessage.h:
        Add #include of Arguments.h for CoreIPC::In and Out definitions.

        * Platform/CoreIPC/MessageID.h:
        Add new message types.

        * Shared/API/c/WKBase.h:
        * Shared/APIObject.h:
        Add new API types.

        * Shared/WebGeolocationPosition.cpp: Added.
        * Shared/WebGeolocationPosition.h: Added.
        Internal position representation.

        * UIProcess/API/C/WKAPICast.h:
        Add casts for new API types.

        * UIProcess/API/C/WKContext.cpp:
        * UIProcess/API/C/WKContext.h:
        * UIProcess/API/C/WKGeolocationManager.cpp: Added.
        * UIProcess/API/C/WKGeolocationManager.h: Added.
        * UIProcess/API/C/WKGeolocationPosition.cpp: Added.
        * UIProcess/API/C/WKGeolocationPosition.h: Added.
        * UIProcess/API/C/WebKit2.h:
        Add API to provide and control geolocation data.

        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::WebContext):
        (WebKit::WebContext::~WebContext):
        (WebKit::WebContext::processDidClose):
        (WebKit::WebContext::didReceiveMessage):
        * UIProcess/WebContext.h:
        (WebKit::WebContext::geolocationManagerProxy):
        * UIProcess/WebGeolocationManagerProxy.cpp: Added.
        (WebKit::WebGeolocationManagerProxy::create):
        (WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
        (WebKit::WebGeolocationManagerProxy::~WebGeolocationManagerProxy):
        (WebKit::WebGeolocationManagerProxy::invalidate):
        (WebKit::WebGeolocationManagerProxy::initializeProvider):
        (WebKit::WebGeolocationManagerProxy::providerDidChangePosition):
        (WebKit::WebGeolocationManagerProxy::providerDidFailToDeterminePosition):
        (WebKit::WebGeolocationManagerProxy::didReceiveMessage):
        (WebKit::WebGeolocationManagerProxy::startUpdating):
        (WebKit::WebGeolocationManagerProxy::stopUpdating):
        * UIProcess/WebGeolocationManagerProxy.h: Added.
        (WebKit::WebGeolocationManagerProxy::clearContext):
        (WebKit::WebGeolocationManagerProxy::type):
        * UIProcess/WebGeolocationManagerProxy.messages.in: Added.
        * UIProcess/WebGeolocationProvider.cpp: Added.
        (WebKit::WebGeolocationProvider::startUpdating):
        (WebKit::WebGeolocationProvider::stopUpdating):
        * UIProcess/WebGeolocationProvider.h: Added.
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::didReceiveMessage):
        * WebProcess/Geolocation: Added.
        * WebProcess/Geolocation/WebGeolocationManager.cpp: Added.
        (WebKit::WebGeolocationManager::WebGeolocationManager):
        (WebKit::WebGeolocationManager::~WebGeolocationManager):
        (WebKit::WebGeolocationManager::didReceiveMessage):
        (WebKit::WebGeolocationManager::registerWebPage):
        (WebKit::WebGeolocationManager::unregisterWebPage):
        (WebKit::WebGeolocationManager::didChangePosition):
        (WebKit::WebGeolocationManager::didFailToDeterminePosition):
        * WebProcess/Geolocation/WebGeolocationManager.h: Added.
        * WebProcess/Geolocation/WebGeolocationManager.messages.in: Added.
        * WebProcess/WebCoreSupport/WebGeolocationClient.cpp: Added.
        (WebKit::WebGeolocationClient::geolocationDestroyed):
        (WebKit::WebGeolocationClient::startUpdating):
        (WebKit::WebGeolocationClient::stopUpdating):
        (WebKit::WebGeolocationClient::setEnableHighAccuracy):
        (WebKit::WebGeolocationClient::lastPosition):
        (WebKit::WebGeolocationClient::requestPermission):
        (WebKit::WebGeolocationClient::cancelPermissionRequest):
        * WebProcess/WebCoreSupport/WebGeolocationClient.h: Added.
        (WebKit::WebGeolocationClient::WebGeolocationClient):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::WebPage):
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::WebProcess):
        (WebKit::WebProcess::didReceiveMessage):
        * WebProcess/WebProcess.h:
        (WebKit::WebProcess::geolocationManager):
        Pipe geolocation positions/errors from the UIProcess to the WebProcess.

        * DerivedSources.make:
        * DerivedSources.pro:
        * WebKit2.pro:
        * WebKit2.xcodeproj/project.pbxproj:
        * win/WebKit2.vcproj:
        * win/WebKit2Common.vsprops:
         * win/WebKit2Generated.make:
        Add new files.

1392 1393 1394 1395 1396 1397
2011-01-10  Martin Robinson  <mrobinson@igalia.com>

        GTK+ build fix. Continue to fix 'make dist.'

        * GNUmakefile.am: Remove more non-existent files from the WebKit2 build.

1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410
2011-01-10  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Remove webkit2 files that are still not added to the
        repository from the makefile
        https://bugs.webkit.org/show_bug.cgi?id=52145

        This change is required for the release, we can add the lines
        again to the makefiles with the patches adding the files.

        * GNUmakefile.am:

1411 1412 1413 1414 1415 1416 1417 1418 1419 1420
2011-01-10  Andreas Kling  <kling@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] [WK2] MiniBrowser does not load pages opened in new windows
        https://bugs.webkit.org/show_bug.cgi?id=52111

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::context): Implement this method.

1421 1422 1423 1424
2011-01-09  Dan Bernstein  <mitz@apple.com>

        Reviewed by Simon Fraser.

mitz@apple.com's avatar
mitz@apple.com committed
1425
        <rdar://problem/8839498> Assertion failure in KURL::KURL when calling WKURLRequestCreateWithWKURL with a non-parsed URL
1426 1427 1428 1429 1430 1431 1432
        https://bugs.webkit.org/show_bug.cgi?id=52132

        * Shared/API/c/WKURLRequest.cpp:
        (WKURLRequestCreateWithWKURL): Parse the URL.
        * Shared/WebString.h: Fixed a comment.
        * Shared/WebURL.h: Ditto.

1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459
2011-01-09  Amruth Raj  <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>

        Reviewed by Martin Robinson.

        Changes to add Process Launcher and Thread Launcher implementation to the WebKit2 GTK port.
        The main() implementation for WebKitWebProcess binary to launch Web process from UI process.
        https://bugs.webkit.org/show_bug.cgi?id=48511

        * UIProcess/Launcher/gtk: Added.
        * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: Added. GTK (UNIX_X11 specific) implementation
        (WebKit::ProcessLauncher::launchProcess):
        (WebKit::ProcessLauncher::terminateProcess):
        (WebKit::ProcessLauncher::platformInvalidate):
        * UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement.
        (WebKit::ThreadLauncher::createWebThread):
        * WebProcess/gtk: Added.
        * WebProcess/gtk/WebProcessGtk.cpp: Added. The stubbed implementations of virtual functions of WebProcess.h for GTK port.
        (WebKit::WebProcess::platformSetCacheModel):
        (WebKit::WebProcess::platformClearResourceCaches):
        (WebKit::WebProcess::platformInitializeWebProcess):
        (WebKit::WebProcess::platformShutdown):
        * WebProcess/gtk/WebProcessMainGtk.cpp: Added. The WebProcessMain call which initiates the Web Process for GTK port.
        (WebKit::WebProcessMainGtk):
        * WebProcess/gtk/WebProcessMainGtk.h: Added. The WebProcessMain declaration for Web Process for GTK port.
        * gtk/MainGtk.cpp: Added. The main function implementation for binary WebKitWebProcess.
        (main):

1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478
2011-01-07 Amruth Raj  <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>

        Reviewed by Martin Robinson.

        [GTK] WebKit2 GNUmakefile is out of date from trunk
        https://bugs.webkit.org/show_bug.cgi?id=51883

        * GNUmakefile.am: Updated sources list as per latest revision
        * Platform/gtk/RunLoopGtk.cpp:
        (RunLoop::TimerBase::start):
        * Platform/gtk/WorkQueueGtk.cpp:
        (WorkQueue::scheduleWorkAfterDelay):
        * Shared/gtk/BackingStoreGtk.cpp:
        (WebKit::BackingStore::paint):
        * WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
        (WebKit::InjectedBundle::load):
        * WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
        (WebKit::NetscapePlugin::platformInvalidate):

1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517
2011-01-08  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/8812759> In WebKit2, PDF view settings (mode and scale) do not stick
        https://bugs.webkit.org/show_bug.cgi?id=52118

        * Shared/WebPreferencesStore.cpp:
        (WebKit::WebPreferencesStore::encode): Encode the double values map.
        (WebKit::WebPreferencesStore::decode): Decode the double values map.
        (WebKit::defaultValueForKey): Added double instance.
        (WebKit::WebPreferencesStore::setDoubleValueForKey): Added.
        (WebKit::WebPreferencesStore::getDoubleValueForKey): Added.
        * Shared/WebPreferencesStore.h: Added PDFScaleFactor and PDFDisplayMode preferences.
        * UIProcess/API/mac/PDFViewController.mm:
        (-[WKPDFView initWithFrame:PDFViewController:WebKit::]): Initialize the _pdfViewController ivar.
        (-[WKPDFView invalidate]): Changed 'nil' to '0' in assignment to a non-Objective-C pointer.
        (-[WKPDFView setDocument:]): Added.
        (-[WKPDFView _applyPDFPreferences]): Added.
        (-[WKPDFView _updatePreferences:]): Added.
        (-[WKPDFView _updatePreferencesSoon]): Added.
        (-[WKPDFView _scaleOrDisplayModeOrPageChanged:]): Added.
        (-[WKPDFView viewDidMoveToWindow]): Added. Starts observing the PDF view for changes to scale
        and display mode.
        (-[WKPDFView viewWillMoveToWindow:]): Added. Stops observing for changes.
        (WebKit::PDFViewController::setPDFDocumentData): Changed to call throguh -[WKPDFView setDocument:].
        * UIProcess/WebPreferences.cpp:
        (WebKit::WebPreferences::updateDoubleValueForKey): Added.
        * UIProcess/WebPreferences.h:
        * UIProcess/cf/WebPreferencesCF.cpp:
        (WebKit::WebPreferences::platformUpdateDoubleValueForKey): Added empty implementation.
        * UIProcess/gtk/WebPreferencesGtk.cpp:
        (WebKit::WebPreferences::platformUpdateDoubleValueForKey): Added stub.
        * UIProcess/mac/WebPreferencesMac.mm:
        (WebKit::setDoubleValueIfInUserDefaults): Added.
        (WebKit::WebPreferences::platformUpdateDoubleValueForKey): Added.
        * UIProcess/qt/WebPreferencesQt.cpp:
        (WebKit::WebPreferences::platformUpdateDoubleValueForKey): Added.

1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562
2011-01-08  Dan Bernstein  <mitz@apple.com>

        Reviewed by Maciej Stachowiak.

        In WebKit2, page zooming does not work with PDF
        https://bugs.webkit.org/show_bug.cgi?id=52113

        * UIProcess/API/C/WKPage.cpp:
        (WKPageSupportsTextZoom): Added. Returns whether the page currently supports text-only zoom.
        * UIProcess/API/C/WKPage.h:
        * UIProcess/API/mac/PDFViewController.h: Made pdfDocumentClass() private and declared new
        member functions.
        * UIProcess/API/mac/PDFViewController.mm:
        (WebKit::PDFViewController::zoomFactor): Added.
        (WebKit::PDFViewController::setZoomFactor): Added.
        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::customRepresentationZoomFactor): Added. Calls through to the WKView.
        (WebKit::PageClientImpl::setCustomRepresentationZoomFactor): Ditto.
        * UIProcess/API/mac/WKView.mm:
        (-[WKView _customRepresentationZoomFactor]): Added. Calls through to the PDFViewController.
        (-[WKView _setCustomRepresentationZoomFactor:]): Ditto.
        * UIProcess/API/mac/WKViewInternal.h:
        * UIProcess/API/qt/qwkpage_p.h:
        (QWKPagePrivate::customRepresentationZoomFactor): Added.
        (QWKPagePrivate::setCustomRepresentationZoomFactor): Added.
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy): Coding style fix.
        (WebKit::WebPageProxy::supportsTextZoom): Added. Returns false if the main frame has a custom
        representation or is a standalone image, true otherwise.
        (WebKit::WebPageProxy::setTextZoomFactor): Bail out if the main frame has a custom representation.
        (WebKit::WebPageProxy::pageZoomFactor): If the main frame has a custom representation, get the
        zoom factor from the page client.
        (WebKit::WebPageProxy::setPageZoomFactor): If the main frame has a custom representation, have
        the client set the zoom factor.
        (WebKit::WebPageProxy::setPageAndTextZoomFactors): Ditto.
        * UIProcess/WebPageProxy.h:
        (WebKit::WebPageProxy::textZoomFactor): Changed to return 1 if the main frame has a custom
        representation.
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::customRepresentationZoomFactor): Added.
        (WebKit::WebView::setCustomRepresentationZoomFactor): Added.
        * UIProcess/win/WebView.h:

1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574
2011-01-08  Jeff Miller  <jeffm@apple.com>

        Reviewed by Jon Honeycutt.

        Add WKBundleFrameGetVisibleContentBounds().
        https://bugs.webkit.org/show_bug.cgi?id=52089

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameGetVisibleContentBounds):
        * WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
        Added WKBundleFrameGetVisibleContentBounds().

1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585
2011-01-08  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] QWKView does not propagate show and hide events to the drawing area
        https://bugs.webkit.org/show_bug.cgi?id=52108

        * UIProcess/API/qt/qgraphicswkview.cpp:
        (QGraphicsWKView::event): Call setPageIsVisible on the drawing area
        if the event is Show or Hide.

1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598
2011-01-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][Symbian] Make sure WebKit headers are included before platform headers on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=31273

        On Symbian PREPEND_INCLUDEPATH is the best way to make sure that WebKit headers
        are included before platform headers. On all other platforms continue to use
        INCLUDEPATH (as before).

        * WebKit2.pro:

1599 1600 1601 1602 1603 1604
2011-01-08  Csaba Osztrogonác  <ossy@webkit.org>

        [Qt][WK2] Unreviewed buildfix after r75313.

        * Scripts/generate-forwarding-headers.pl:

1605 1606 1607 1608 1609 1610 1611
2011-01-08  Adam Barth  <abarth@webkit.org>

        Moving WebCore changes the layout of the Qt build directory as well,
        which means we need to change where we look for these generated files.

        * DerivedSources.pro:

1612 1613 1614 1615 1616 1617 1618 1619 1620
2011-01-07  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move WebCore to Source
        https://bugs.webkit.org/show_bug.cgi?id=52050

        * WebKit2.pro:

1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696
2011-01-07  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Geoff Garen.

        <rdar://problem/8649617> Migrate memory tracking from Safari to WebKit
        https://bugs.webkit.org/show_bug.cgi?id=50799 Add Memory Sampler to WebKit
        
        Add a sampler for printing off process memory statistics.
        This tool can track:
                
                WebCore
                   - FastMalloc allocations bytes              (in use or committed)
                JavaScriptCore
                   - Garbage collector heap bytes              (in use or committed)
                   - Stack bytes                               (committed only!)
                   - JIT Code bytes                            (committed only!)
                Malloc zones
                   - In use bytes for the following zones:
                       * Default zone                          (in use or committed)
                       * DispCon zone                          (in use or committed)
                       * Purgable zone                         (in use or committed)
                Task Info
                   - Resident size memory (RSIZE)
        
                Data collected is dumped to a temporary file.
        
        Create a sandbox for a temporary file.
        * Shared/SandboxExtension.h:
        (WebKit::SandboxExtension::createHandleForTemporaryFile):
        * Shared/mac/SandboxExtensionMac.mm:
        (WebKit::SandboxExtension::createHandleForTemporaryFile):
        
        Memory Sampler files
        
        * Shared/WebMemorySampler.cpp: Added.
        (WebKit::WebMemorySampler::shared):
        (WebKit::WebMemorySampler::WebMemorySampler):
        (WebKit::WebMemorySampler::start):
        (WebKit::WebMemorySampler::initializeTimers):
        (WebKit::WebMemorySampler::stop):
        (WebKit::WebMemorySampler::isRunning):
        (WebKit::WebMemorySampler::initializeTempLogFile):
        (WebKit::WebMemorySampler::initializeSandboxedLogFile):
        (WebKit::WebMemorySampler::writeHeaders):
        (WebKit::WebMemorySampler::sampleTimerFired):
        (WebKit::WebMemorySampler::stopTimerFired):
        (WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):
        * Shared/WebMemorySampler.h: Added.
        * Shared/mac/WebMemorySampler.mac.mm: Added.
        (WebKit::WebMemorySampler::sampleSystemMalloc):
        (WebKit::WebMemorySampler::sampleProcessCommittedBytes):
        (WebKit::WebMemorySampler::processName):
        (WebKit::WebMemorySampler::sampleWebKit):
        
        API to start and stop UIProcess and WebProcess sampling.
        
        * UIProcess/API/C/WKContext.cpp:
        (WKContextStartMemorySampler):
        (WKContextStopMemorySampler):
        * UIProcess/API/C/WKContext.h:
        
        Send messages to WebProcess to start and stop memory sampling.
        
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::WebContext):
        (WebKit::WebContext::processDidFinishLaunching):
        (WebKit::WebContext::startMemorySampler):
        (WebKit::WebContext::stopMemorySampler):
        * UIProcess/WebContext.h:
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::startMemorySampler):
        (WebKit::WebProcess::stopMemorySampler):
        * WebProcess/WebProcess.h:
        * WebProcess/WebProcess.messages.in:

1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711
2011-01-07  Jessie Berlin  <jberlin@apple.com>

        Reviewed by Dan Bernstein.

        WebKit2: Need WKBundleFrameCopyProvisionalURL
        https://bugs.webkit.org/show_bug.cgi?id=52083

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameCopyProvisionalURL):
        * WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::provisionalURL):
        Grab the URL from the provisional document loader.
        * WebProcess/WebPage/WebFrame.h:

1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726
2011-01-07  James Robinson  <jamesr@chromium.org>

        Revert "Implement mozilla's animationTime property"
        https://bugs.webkit.org/show_bug.cgi?id=51952

        This approach isn't quite right.

        * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
        (WebKit::ChunkedUpdateDrawingArea::display):
        (WebKit::ChunkedUpdateDrawingArea::setSize):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::drawRect):
        * WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
        (WebKit::LayerBackedDrawingArea::syncCompositingLayers):

1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772
2011-01-07 Amruth Raj  <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>

        Reviewed by Martin Robinson.

        [GTK] WebKit2 GNUmakefile is out of date from trunk
        Adding new stub files for compiling on latest revision
        https://bugs.webkit.org/show_bug.cgi?id=51883

        * UIProcess/gtk: Added.
        * UIProcess/gtk/TextCheckerGtk.cpp: Added.
        (WebKit::TextChecker::state):
        (WebKit::TextChecker::isContinuousSpellCheckingAllowed):
        (WebKit::TextChecker::setContinuousSpellCheckingEnabled):
        (WebKit::TextChecker::setGrammarCheckingEnabled):
        (WebKit::TextChecker::uniqueSpellDocumentTag):
        (WebKit::TextChecker::closeSpellDocumentWithTag):
        (WebKit::TextChecker::checkTextOfParagraph):
        (WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
        (WebKit::TextChecker::getGuessesForWord):
        (WebKit::TextChecker::learnWord):
        (WebKit::TextChecker::ignoreWord):
        * UIProcess/gtk/WebInspectorGtk.cpp: Added.
        (WebKit::WebInspectorProxy::platformCreateInspectorPage):
        (WebKit::WebInspectorProxy::platformOpen):
        (WebKit::WebInspectorProxy::platformClose):
        (WebKit::WebInspectorProxy::inspectorPageURL):
        * UIProcess/gtk/WebPageProxyGtk.cpp: Added.
        (WebKit::WebPageProxy::standardUserAgent):
        * UIProcess/gtk/WebPreferencesGtk.cpp: Added.
        (WebKit::WebPreferences::platformInitializeStore):
        (WebKit::WebPreferences::platformUpdateStringValueForKey):
        (WebKit::WebPreferences::platformUpdateBoolValueForKey):
        (WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
        * WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp: Added.
        (WebKit::WebContextMenuClient::lookUpInDictionary):
        (WebKit::WebContextMenuClient::isSpeaking):
        (WebKit::WebContextMenuClient::speak):
        (WebKit::WebContextMenuClient::stopSpeaking):
        * WebProcess/WebCoreSupport/gtk/WebDatabaseManagerGtk.cpp: Added.
        (WebKit::WebDatabaseManager::databaseDirectory):
        * WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp: Added.
        (WebKit::WebPopupMenu::setUpPlatformData):
        * WebProcess/WebPage/gtk: Added.
        * WebProcess/WebPage/gtk/WebInspectorGtk.cpp: Added.
        (WebKit::WebInspector::localizedStringsURL):

1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794
2011-01-06  Adam Roben  <aroben@apple.com>

        Don't ever call ::SetCursor(0)

        Doing so makes the cursor disappear from the screen.

        Fixes <http://webkit.org/b/52024> Mouse cursor flashes when moving it
        around a WKView before the web process has finished launching

        Reviewed by Jon Honeycutt.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::onSetCursor): If we don't have a cursor to set, just
        let Windows do its default thing (which is to set the cursor to the
        window class's cursor, which in our case is the arrow cursor).
        (WebKit::WebView::cursorToShow): Just return 0 when the page has
        crashed so that we'll show the default cursor (which is the arrow
        cursor). This change has no visible effect, but seems slightly better
        conceptually.
        (WebKit::WebView::updateNativeCursor): Don't do anything if we don't
        have a cursor to set.

1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830
2011-01-06  Adam Roben  <aroben@apple.com>

        Fill the WKView with white when the web process hasn't drawn anything
        yet

        Fixes <http://webkit.org/b/52023> WKView accumulates pixel garbage
        before web process has had a chance to draw anything (if Aero is
        disabled)

        Reviewed by Jon Honeycutt.

        * UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
        (WebKit::ChunkedUpdateDrawingAreaProxy::paint):
        * UIProcess/ChunkedUpdateDrawingAreaProxy.h:
        * UIProcess/DrawingAreaProxy.h:
        * UIProcess/LayerBackedDrawingAreaProxy.cpp:
        (WebKit::LayerBackedDrawingAreaProxy::paint):
        * UIProcess/LayerBackedDrawingAreaProxy.h:
        * UIProcess/TiledDrawingAreaProxy.cpp:
        (WebKit::TiledDrawingAreaProxy::paint):
        * UIProcess/TiledDrawingAreaProxy.h:
        * UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
        (WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):
        * UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:
        (WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):
        * UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp:
        (WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):
        * UIProcess/win/LayerBackedDrawingAreaProxyWin.cpp:
        (WebKit::LayerBackedDrawingAreaProxy::paint):
        Changed these functions to return a boolean indicating whether we
        actually painted anything.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::onPaintEvent): Fill with white (and don't call
        didDraw) when the DrawingAreaProxy isn't able to paint.

1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847
2011-01-06  Jessie Berlin  <jberlin@apple.com>

        Reviewed by Jon Honeycutt.

        WebKit2: Need WKBundlePagePrivate equivalent of WebKit1's WebViewPrivate's setDefersCallbacks
        https://bugs.webkit.org/show_bug.cgi?id=52038

        The implementation of WebKit1's WebViewPrivate's setDefersCallbacks on both Windows and Mac
        calls WebCore::Page::setDefersLoading.

        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
        (WKBundlePageSetDefersLoading):
        * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::setDefersLoading):
        * WebProcess/WebPage/WebPage.h:

1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873
2011-01-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/8261624> and https://bugs.webkit.org/show_bug.cgi?id=47355
        Change WebKit2 session restoring to restore the full back/forward list.

        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::registerNewWebBackForwardListItem): Let the UIProcess register its own
          WebBackForwardListItems in its ID map upon creation.
        * UIProcess/WebProcessProxy.h:

        * UIProcess/cf/WebPageProxyCF.cpp:
        (WebKit::WebPageProxy::restoreFromSessionStateData): Register each new list entry in the
          UIProcess ID map.

        * WebProcess/WebPage/WebBackForwardListProxy.cpp:
        (WebKit::WebBackForwardListProxy::addItemFromUIProcess): Add this method to register UIProcess
          created items without doing any of the other work normally associated with adding a new back/forward item
          (such as notifying the UIProcess).
        * WebProcess/WebPage/WebBackForwardListProxy.h:

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::restoreSession): Map all of the back/forward list entries from the UIProcess then
          cause a load of the current entry.

1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890
2011-01-06  Adam Roben  <aroben@apple.com>

        Always show the arrow cursor when the web process has crashed

        Fixes <http://webkit.org/b/52006> WKView shows a stale cursor when the
        web process crashes

        Reviewed by Ada Chan.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::processDidCrash):
        (WebKit::WebView::didRelaunchProcess):
        Update the cursor to reflect the new state.

        (WebKit::WebView::cursorToShow): Always show the arrow cursor when the
        web process has crashed.

1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905
2011-01-06  Adam Roben  <aroben@apple.com>

        Reduce code duplication in WebView::updateNativeCursor

        Fixes <http://webkit.org/b/52005> It's not easy to add new behavior to
        WebView::updateNativeCursor

        Reviewed by Ada Chan.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::cursorToShow): Moved code to choose a cursor here...
        (WebKit::WebView::updateNativeCursor): ...from here.

        * UIProcess/win/WebView.h: Added cursorToShow.

1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928
2011-01-06  Adam Roben  <aroben@apple.com>

        Make WKView fill with white when the web process has crashed

        Previously we would just draw whatever we had last drawn into the
        WKView (i.e., a stale picture of the web page), which was confusing
        (because the web page would mysteriously not respond to input) and ugly
        (because it wouldn't behave properly if the window was resized).

        Fixes <http://webkit.org/b/52004> WKView keeps painting a stale
        picture of the web page when the web process crashes

        Reviewed by Ada Chan.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::onPaintEvent): Ported code from -[WKView drawRect:]
        to fill with white if the page is invalid or has no DrawingArea. As a
        bonus, also ported the call to WebPageProxy::didDraw from that method.

        (WebKit::WebView::processDidCrash):
        (WebKit::WebView::didRelaunchProcess):
        Invalidate our window so that we'll redraw with white or the new page.

1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941
2011-01-06  Adam Roben  <aroben@apple.com>

        Make WKViews work on Windows after a crashed web process gets relaunched

        Fixes <http://webkit.org/b/52001> Relaunching the web process fails to
        revivify WKViews on Windows

        Reviewed by Ada Chan.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::didRelaunchProcess): Implemented by porting code from
        -[WKView _didRelaunchProcess].

aroben@apple.com's avatar
aroben@apple.com committed
1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955
2011-01-06  Adam Roben  <aroben@apple.com>

        Remove WebView::m_rect

        It was only used in the constructor, and wasn't even kept up-to-date as
        the WebView's size changed.

        Fixes <http://webkit.org/b/52000> WebView::m_rect is unnecessary

        Reviewed by Ada Chan.

        * UIProcess/win/WebView.cpp:
        * UIProcess/win/WebView.h:

1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975
2011-01-05  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Ada Chan.

        WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
        https://bugs.webkit.org/show_bug.cgi?id=51969
        
        Add the ability to call into the injected bundle to ask if we should allow resource loads.
        If the injected bundle says we should cancel, we clear out the ResourceRequest that was
        passed into willSendRequest, which cancels the resource load.

        * WebProcess/InjectedBundle/API/c/WKBundlePage.h: Add the new callback for allowing/cancelling
            resource loads.
        * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
        (WebKit::InjectedBundlePageLoaderClient::shouldLoadResourceForFrame): Calls through to the client.
        * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::dispatchWillSendRequest): Ask the InjectedBundlePageLoaderClient if we
            should load the resource or not.

1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988
2011-01-06  Jeff Miller  <jeffm@apple.com>

        Reviewed by Darin Adler.

        WebKit2: Add APIs to WKBundleFrame to get content bounds and scroll offset
        https://bugs.webkit.org/show_bug.cgi?id=51968

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameGetContentBounds):
        (WKBundleFrameGetScrollOffset):
        * WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
        Add WKBundleFrameGetContentBounds() and WKBundleFrameGetScrollOffset().

1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005
2011-01-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Implement mozilla's animationTime property
        https://bugs.webkit.org/show_bug.cgi?id=51952

        Tells the page to clear the current animation time after producing a frame.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::drawRect):
        * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
        (WebKit::ChunkedUpdateDrawingArea::display):
        (WebKit::ChunkedUpdateDrawingArea::setSize):
        * WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
        (WebKit::LayerBackedDrawingArea::syncCompositingLayers):

2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018
2011-01-06  Darin Adler  <darin@apple.com>

        Redo the half-done rename from the last check-in.
        Sorry for the broken build last night.

        * WebProcess/WebPage/WebBackForwardListProxy.cpp:
        (WebKit::WebBackForwardListProxy::removeItem): Renamed.
        * WebProcess/WebPage/WebBackForwardListProxy.h: Updated
        for new name.
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::didRemoveBackForwardItem): Updated to
        use the new name.

2019 2020 2021 2022 2023 2024 2025 2026 2027 2028
2011-01-06  Maciej Stachowiak  <mjs@apple.com>

        Rubber stamped by Dan Bernstein.

        Fix build for Darin's previous change w/ the obvious renaming.

        * WebProcess/WebPage/WebBackForwardListProxy.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::didRemoveBackForwardItem):

2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084
2011-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        Back/Forward entries in WebKit2 leak
        https://bugs.webkit.org/show_bug.cgi?id=51983

        Besides fixing the leak, this also fixes a problem where
        all history items were sent over to the UI process, but
        we wanted to send only back/forward items.

        * UIProcess/WebBackForwardList.cpp:
        (WebKit::WebBackForwardList::pageClosed): Added.
        Tells the web process about all the back/forward
        items being removed.
        (WebKit::WebBackForwardList::addItem): Ditto.
        Also removed a redundant call to didChangeBackForwardList.
        (WebKit::WebBackForwardList::clear): Ditto.

        * UIProcess/WebBackForwardList.h: Added pageClosed.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::close): Added a call to pageClosed.
        (WebKit::WebPageProxy::backForwardRemovedItem): Added.
        Sends a message to the web page in the web process.

        * UIProcess/WebPageProxy.h: Added backForwardRemovedItem.

        * WebProcess/WebPage/WebBackForwardListProxy.cpp:
        (WebKit::updateBackForwardItem): Added an itemID argument,
        since callers will now be getting it and we don't want to
        get it twice. Removed the code to generate an ID. Also
        removed some local variables to make the code a little
        tighter and clearer.
        (WebKit::WK2NotifyHistoryItemChanged): Only call
        updateBackForwardItem for items that already have IDs.
        We don't want to send cross-process messages for every
        history item; just the ones that are top level back/forward
        items.
        (WebKit::WebBackForwardListProxy::removeItem):
        Added. For use when the UI process tells us to remove it.
        (WebKit::WebBackForwardListProxy::addItem): Added code to
        assign an ID and put this item into the maps. This is called
        exactly once on each back/forward item.

        * WebProcess/WebPage/WebBackForwardListProxy.h: Added
        removeItem.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::didRemoveBackForwardItem): Added.

        * WebProcess/WebPage/WebPage.h: Added didRemoveBackForwardItem.

        * WebProcess/WebPage/WebPage.messages.in: Added
        DidRemoveBackForwardItem message.

2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111
2011-01-05  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Debug and Release builds on Windows clobber each other
        https://bugs.webkit.org/show_bug.cgi?id=49185

        Changes the structure of WebKitBuild build products directory so we
        completely separate each build configuration into independent directories.
        
        Although we previously had per-configuration directories for obj, this change adds
        per-configuration directories for bin, lib, obj, and include. Each configuration's
        build products are stored within a directory inside of WebKitBuild.
        
        Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
        defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

        * win/WebKit2.make:
        * win/WebKit2.vcproj:
        * win/WebKit2Common.vsprops:
        * win/WebKit2Generated.make:
        * win/WebKit2GeneratedCommon.vsprops:
        * win/WebKit2WebProcessPostBuild.cmd:
        * win/WebKit2WebProcessPreBuild.cmd:
        * win/WebKitPostBuild.cmd:
        * win/WebKitPreBuild.cmd:

2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129
2011-01-05  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=51973
        Make main frame PDF printing work

        * UIProcess/API/mac/PDFViewController.h:
        * UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::makePrintOperation):
        Ask PDFDocument to create an NSPrintOperation.

        * UIProcess/API/mac/WKView.h:
        * UIProcess/API/mac/WKView.mm:
        (-[WKView printOperationWithPrintInfo:forFrame:]): Create a new NSPrintOperation, either
        from scratch or from a PDF view.
        (-[WKView canPrintHeadersAndFooters]): Report if the view can be re-paginated to add headers
        and footers.

andersca@apple.com's avatar
andersca@apple.com committed
2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/8750248>
        Need a way to create a new DownloadProxy from an arbitrary resource request

        <rdar://problem/8750465>
        Need a way to start a download in WKDownload
        
        <rdar://problem/8752204>
        WK2 Context Menus - "Save linked file" support

        * Shared/ContextMenuState.h: Added.
        Add a ContextMenuState struct which contains state for context menus.

        * UIProcess/API/C/WKContext.cpp:
        (WKContextDownloadURLRequest):
        Call WebContext::download.

        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::download):
        Send a DownloadRequest message to the web process.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::showContextMenu):
        Set the active context menu state.

        (WebKit::WebPageProxy::contextMenuItemSelected):
        Handle ContextMenuItemTagDownloadImageToDisk and ContextMenuItemTagDownloadLinkToDisk by calling
        WebContext::Download, passing the respective URLs.

        * UIProcess/WebPageProxy.messages.in:
        ShowContextMenu now takes state as well.

        * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
        (WebKit::WebContextMenuClient::downloadURL):
        Assert that this is never reached; downloads are handled in the UI process.

        * WebProcess/WebPage/WebContextMenu.cpp:
        (WebKit::WebContextMenu::show):
        Pass the context menu state along when sending the ShowContextMenu message.

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::downloadRequest):
        Call the shared DownloadManager.

        * WebProcess/WebProcess.messages.in:
        Add DownloadRequest message.

        * WebKit2.xcodeproj/project.pbxproj:
        * win/WebKit2.vcproj:
        Add ContextMenuState.h.

2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196
2011-01-05  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix.

        [Qt] [Symbian] Fix building NPAPI support

        NPEvent is mapped to QAction on Symbian. QAction has no
        default constructor, so toNP() fails to build. Add a case for
        Symbian behind the OS(SYMBIAN) guard.

        * WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
        (WebKit::toNP):

2197 2198 2199 2200 2201 2202 2203 2204 2205 2206
2011-01-05  Jeff Miller  <jeffm@apple.com>

        Reviewed by Dan Bernstein.

        Copy WKImageCG.h to include\WebKit2 in build output
        https://bugs.webkit.org/show_bug.cgi?id=51944

        * win/WebKit2Generated.make:
        Add xcopy command to copy WKImageCG.h.

2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239
2011-01-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        Part of <rdar://problem/8261624> and https://bugs.webkit.org/show_bug.cgi?id=47355
        Change WebKit2 session restoring to restore the full back/forward list

        Add a new message to tell the WebProcess to restore a session state:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::restoreSession):
        * WebProcess/WebPage/WebPage.h:
        * WebProcess/WebPage/WebPage.messages.in: Add the new message, AND fix the intentional misspellings.
        
        Also, Sam sucks.

        Change WebProcess back/forward list item ids to be odd (UIProcess's will be even):
        * WebProcess/WebPage/WebBackForwardListProxy.cpp:
        (WebKit::generateHistoryItemID):

        Provide accessors to the entries in the list to pass to the WebProcess:
        * UIProcess/WebBackForwardList.h:
        (WebKit::WebBackForwardList::entries):
        (WebKit::WebBackForwardList::currentIndex):

        Add decoding of the saved back/forward list itmes (we already encode them):
        * UIProcess/cf/WebBackForwardListCF.cpp:
        (WebKit::generateWebBackForwardItemID):
        (WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):

        Instead of loading the current URL, pass the entire last back to the WebProcess:
        * UIProcess/cf/WebPageProxyCF.cpp:
        (WebKit::WebPageProxy::restoreFromSessionStateData):

2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261
2011-01-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=51953
        Add a "SessionState" object for IPC messaging.

        This object includes all data necessary to restore a session state;
        For now, this is just the back/forward list to restore.

        * Shared/SessionState.cpp: Added.
        (WebKit::SessionState::SessionState):
        (WebKit::SessionState::encode):
        (WebKit::SessionState::decode):
        * Shared/SessionState.h: Added.
        (WebKit::SessionState::list):
        (WebKit::SessionState::currentIndex):

        * WebKit2.pro:
        * WebKit2.xcodeproj/project.pbxproj:
        * win/WebKit2.vcproj:

2262 2263 2264 2265 2266 2267 2268 2269 2270 2271
2011-01-05  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix.

        Include unistd.h for _exit() for non-Windows builds.

        Build break noticed on QtWebkit Symbian builds.

        * Shared/ChildProcess.cpp:

2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289
2011-01-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=51949
        Make WebBackForwardListItem shared, and add encoders and decoders

        * Shared/WebBackForwardListItem.cpp: Copied from UIProcess/WebBackForwardListItem.cpp.
        (WebKit::WebBackForwardListItem::encode):
        (WebKit::WebBackForwardListItem::decode):
        * Shared/WebBackForwardListItem.h: Copied from UIProcess/WebBackForwardListItem.h.
        * UIProcess/WebBackForwardListItem.cpp: Removed.
        * UIProcess/WebBackForwardListItem.h: Removed.

        * WebKit2.pro:
        * WebKit2.xcodeproj/project.pbxproj:
        * win/WebKit2.vcproj:

2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Handle smart insert/delete
        https://bugs.webkit.org/show_bug.cgi?id=51946

        * Shared/WebPageCreationParameters.cpp:
        (WebKit::WebPageCreationParameters::encode):
        (WebKit::WebPageCreationParameters::decode):
        * Shared/WebPageCreationParameters.h:
        Add isSmartInsertDelete enabled.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView validateUserInterfaceItem:]):
        Handle toggleSmartInsertDelete:.

        (-[WKView toggleSmartInsertDelete:]):
        Toggle the smart insert/delete state.

        * UIProcess/TextChecker.h:
        Add isSmartInsertDeleteEnabled and setSmartInsertDeleteEnabled.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy):
        Initialize m_isSmartInsertDeleteEnabled.

        (WebKit::WebPageProxy::contextMenuItemSelected):
        Handle ContextMenuItemTagSmartCopyPaste.

        (WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
        Update the state and send a SetSmartInsertDeleteEnabled message.

        (WebKit::WebPageProxy::creationParameters):
        Initialize isSmartInsertDeleteEnabled.

        * UIProcess/WebPageProxy.h:
        (WebKit::WebPageProxy::isSmartInsertDeleteEnabled):
        Return m_isSmartInsertDeleteEnabled.

        * UIProcess/mac/TextCheckerMac.mm:
        (WebKit::TextChecker::isSmartInsertDeleteEnabled):
        (WebKit::TextChecker::setSmartInsertDeleteEnabled):
        Store and fetch the smart insert delete state.

        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::smartInsertDeleteEnabled):
        Call WebPage::isSmartInsertDeleteEnabled.

        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
        (WebKit::WebEditorClient::toggleSmartInsertDelete):
        Assert that this is never called.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::WebPage):
        Initialize m_isSmartInsertDeleteEnabled

        * WebProcess/WebPage/WebPage.h:
        (WebKit::WebPage::isSmartInsertDeleteEnabled):
        (WebKit::WebPage::setSmartInsertDeleteEnabled):
        Add getter and setter.

        * WebProcess/WebPage/WebPage.messages.in:
        Add SetSmartInsertDeleteEnabled message.

andersca@apple.com's avatar
andersca@apple.com committed
2355 2356 2357 2358 2359 2360
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Fix Windows build.
        
        * WebProcess/WebPage/WebPage.cpp:

2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adele Peterson.

        Implement word transformation
        https://bugs.webkit.org/show_bug.cgi?id=51943

        * UIProcess/API/mac/WKView.mm:
        (-[WKView validateUserInterfaceItem:]):
        Handle the word transformation selectors.

        (-[WKView uppercaseWord:]):
        (-[WKView lowercaseWord:]):
        (-[WKView capitalizeWord:]):
        Call down to the WebPageProxy.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::uppercaseWord):
        (WebKit::WebPageProxy::lowercaseWord):
        (WebKit::WebPageProxy::capitalizeWord):
        Send messages to the WebPage.

        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
        (WebKit::changeWordCase):
        Add helper function.

        (WebKit::WebEditorClient::uppercaseWord):
        (WebKit::WebEditorClient::lowercaseWord):
        (WebKit::WebEditorClient::capitalizeWord):
        Call helper function.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::changeSpellingToWord):
        Call replaceSelectionWithText.

        (WebKit::WebPage::uppercaseWord):
        (WebKit::WebPage::lowercaseWord):
        (WebKit::WebPage::capitalizeWord):
        Call the editor functions.

        (WebKit::WebPage::replaceSelectionWithText):
        New helper function that replaces the selected string with another string.

        * WebProcess/WebPage/WebPage.messages.in:
        Add new messages.

ap@apple.com's avatar
ap@apple.com committed
2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417
2011-01-05  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=51935
        Add WebKit2 API for largest frame

        * UIProcess/API/C/WKPage.cpp:
        (WKPageGetFrameSetLargestFrame):
        * UIProcess/API/C/WKPage.h:

2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        More work on spelling
        https://bugs.webkit.org/show_bug.cgi?id=51939

        * UIProcess/API/mac/WKView.mm:
        (-[WKView validateUserInterfaceItem:]):
        Handle changeSpelling: as well.

        (-[WKView showGuessPanel:]):
        Show or hide the guess panel.

        (-[WKView checkSpelling:]):
        Pass false to advanceToNextMisspelling.

        (-[WKView changeSpelling:]):
        Call changeSpellingToWord.

        * UIProcess/TextChecker.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy):
        Initialize m_pendingLearnOrIgnoreWordMessageCount.

        (WebKit::WebPageProxy::contextMenuItemSelected):
        Handle smart toggles directly in the UI process, keep track of whether
        we're asked to learn or ignore a word.

        (WebKit::WebPageProxy::advanceToNextMisspelling):
        Pass the boolean through.

        (WebKit::WebPageProxy::changeSpellingToWord):
        Send a ChangeSpellingToWord message.

        (WebKit::WebPageProxy::learnWord):
        (WebKit::WebPageProxy::ignoreWord):
        Check that we do have a pending learn or ignore word message. Call through to
        the text checker.

        (WebKit::WebPageProxy::processDidCrash):
        Reset the m_pendingLearnOrIgnoreWordMessageCount variable.

        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        Add new messages.

        * UIProcess/mac/TextCheckerMac.mm:
        (WebKit::TextChecker::learnWord):
        (WebKit::TextChecker::ignoreWord):
        Implement in terms of NSSpellChecker.

        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::ignoreWordInSpellDocument):
        (WebKit::WebEditorClient::learnWord):
        Send IgnoreWord and LearnWord messages.

        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
        (WebKit::WebEditorClient::toggleAutomaticQuoteSubstitution):
        (WebKit::WebEditorClient::toggleAutomaticLinkDetection):
        (WebKit::WebEditorClient::toggleAutomaticDashSubstitution):
        (WebKit::WebEditorClient::toggleAutomaticTextReplacement):
        Add assertions.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::advanceToNextMisspelling):
        Pass the bool along to the Editor.

        (WebKit::WebPage::changeSpellingToWord):
        Replace the selected text.

        * WebProcess/WebPage/WebPage.messages.in:
        Add new ChangeSpellingToWord message and add a boolean to AdvanceToNextMisspelling.

2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Keep track of active text substitution preferences
        https://bugs.webkit.org/show_bug.cgi?id=51931

        * Shared/TextCheckerState.h:
        * UIProcess/API/mac/WKView.mm:
        (-[WKView validateUserInterfaceItem:]):
        Handle new selectors, mostly copied from WebKit1 code.

        (-[WKView orderFrontSubstitutionsPanel:]):
        Open the substitution panel.

        (-[WKView isAutomaticQuoteSubstitutionEnabled]):
        (-[WKView setAutomaticQuoteSubstitutionEnabled:]):
        (-[WKView toggleAutomaticQuoteSubstitution:]):
        (-[WKView isAutomaticDashSubstitutionEnabled]):
        (-[WKView setAutomaticDashSubstitutionEnabled:]):
        (-[WKView toggleAutomaticDashSubstitution:]):
        (-[WKView isAutomaticLinkDetectionEnabled]):
        (-[WKView setAutomaticLinkDetectionEnabled:]):
        (-[WKView toggleAutomaticLinkDetection:]):
        (-[WKView isAutomaticTextReplacementEnabled]):
        (-[WKView setAutomaticTextReplacementEnabled:]):
        (-[WKView toggleAutomaticTextReplacement:]):
        Call the text checker, and update the state in the web process if needed.

        * UIProcess/TextChecker.h:
        Add new flags.

        * UIProcess/mac/TextCheckerMac.mm:
        (WebKit::initializeState):
        Initialize flags from user defaults.

        (WebKit::TextChecker::setAutomaticQuoteSubstitutionEnabled):
        (WebKit::TextChecker::setAutomaticDashSubstitutionEnabled):
        (WebKit::TextChecker::setAutomaticLinkDetectionEnabled):
        (WebKit::TextChecker::setAutomaticTextReplacementEnabled):
        Update and save the flags.

        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
        (WebKit::WebEditorClient::isAutomaticQuoteSubstitutionEnabled):
        (WebKit::WebEditorClient::isAutomaticLinkDetectionEnabled):
        (WebKit::WebEditorClient::isAutomaticDashSubstitutionEnabled):
        (WebKit::WebEditorClient::isAutomaticTextReplacementEnabled):
        Get the text checker state.

2541 2542 2543 2544 2545 2546 2547 2548 2549