ChangeLog 351 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
2011-01-12  Enrica Casucci  <enrica@apple.com>

        Reviewed by Darin Adler.

        WebKit2: Add support for drag and drop
        https://bugs.webkit.org/show_bug.cgi?id=52343
        <rdar://problem/7660558>
        
        The DragData class has been extended to provide
        additional context from the application (keyboard state, modal windows, etc.)
        as well as information of the drag pasteboard being used.
        These are the changes to align the behavior for WebKit.

        * WebView/WebView.mm:
        (-[WebView applicationFlags:]): Added.
        (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
        (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
        (-[WebView draggingExited:]): Added parameter to the DragData constructor.
        (-[WebView performDragOperation:]): Added parameter to the DragData constructor.

21 22 23 24 25 26 27 28 29 30 31 32 33 34 35
2011-01-12  Beth Dakin  <bdakin@apple.com>

        Reviewed by Anders Carlsson.

        Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309 
        Expose fixed layout through WebKit SPI
        -and corresponding-
        <rdar://problem/8844464>

        And now with getters!
        * WebView/WebView.mm:
        (-[WebView _useFixedLayout]):
        (-[WebView _fixedLayoutSize]):
        * WebView/WebViewPrivate.h:

36 37 38 39 40 41 42 43 44 45 46 47 48 49
2011-01-12  Beth Dakin  <bdakin@apple.com>

        Reviewed by Anders Carlsson.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
        fixed layout through WebKit SPI
        -and corresponding-
        <rdar://problem/8844464>

        * WebView/WebView.mm:
        (-[WebView _setUseFixedLayout:]):
        (-[WebView _setFixedLayoutSize:]):
        * WebView/WebViewPrivate.h:

50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73
2011-01-07  Enrica Casucci  <enrica@apple.com>

        Reviewed by Alexey Proskuryakov.

        Paste and drag and drop use different code paths to interact with the pasteboard.
        https://bugs.webkit.org/show_bug.cgi?id=52093
        The change consists in a refactoring of the code to have only one class that
        deals with the pasteboard on Mac.

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
        exposed by NSURLExtras.
        (WebEditorClient::canonicalizeURL):
        (WebEditorClient::canonicalizeURLString):
        * WebCoreSupport/WebPasteboardHelper.h: Removed.
        * WebCoreSupport/WebPasteboardHelper.mm: Removed.
        * WebView/WebHTMLView.mm: Removed comment.
        * WebView/WebView.mm: The following methods have been changed to use the new DragData
        constructor that doesn't use the WebPasteboardHelper reference.
        (-[WebView draggingEntered:]):
        (-[WebView draggingUpdated:]):
        (-[WebView draggingExited:]):
        (-[WebView performDragOperation:]):

74 75 76 77 78 79 80 81 82
2011-01-09  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Forward declare some headers where possible
        https://bugs.webkit.org/show_bug.cgi?id=52133

        * WebView/WebFrame.mm:

83 84 85 86 87 88 89 90 91 92
2011-01-09  Xianzhu Wang <phnixwxz@gmail.com>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=41441
        createWindow method should only do window-creating without URL navigation

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::createWindow):

mitz@apple.com's avatar
mitz@apple.com committed
93 94 95 96 97 98
2011-01-08  Dan Bernstein  <mitz@apple.com>

        Try to fix the Leopard build.

        * WebView/WebFullScreenController.mm:

99 100 101 102 103 104 105 106
2011-01-07  Jer Noble  <jer.noble@apple.com>

        Yet another Leopard build fix: NSRect and CGRect are not inter-
        changable in 32-bit.  
        
        * WebView/WebFullScreenController.mm:
        (-[WebFullScreenController exitFullscreen]):

107 108 109 110 111 112 113 114 115 116 117
2011-01-07  Jer Noble  <jer.noble@apple.com>

        Fix the Leopard build: Replace CoreAnimation SL-only functions
        with Leopard equivalents.

        * WebView/WebFullScreenController.mm:
        (+[CATransaction setDisableActions:]):
        (+[CATransaction setAnimationDuration:]):
        (-[WebFullScreenController _animationDuration]):
        (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):

118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181
2010-12-21  Jer Noble  <jer.noble@apple.com>

        Reviewed by Simon Fraser.

        Implement WebKit Full Screen support.
        https://bugs.webkit.org/show_bug.cgi?id=49481
        rdar://problem/8247444

        Support the new fullscreen Chrome client requests.  WebView will pass
        through these requests to a WebFullscreenController.

        * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
        * WebView/WebView.mm:
        (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
        (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
        (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
        (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
        * WebView/WebViewData.h: Add ivar newFullscreenController.

2010-12-17  Jer Noble  <jer@kokode.apple.com>

        Reviewed by Simon Fraser.

        Implement WebKit Full Screen support.
        https://bugs.webkit.org/show_bug.cgi?id=49481
        rdar://problem/8247444
        
        This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
        Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
        window, and a custom CAAnimation animates that layer between the initial screen rect of the
        full screen element, to its final value. WebFullscreenController will swap the WebView out of
        its original window, and into the fullscreen window. The controller will replace the WebView
        with a placeholder view, so that if the placeholder moves or resized while the WebView is
        absent, the WebView will move back to the correct location when exiting fullscreen.

        * WebView/WebFullscreenController.h: Added.
        * WebView/WebFullscreenController.mm: Added.
        (-[WebFullscreenController windowDidExitFullscreen:]):  Close the fullscreen window.
        (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window. 
        (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
        (-[WebFullscreenController applicationDidResignActive:]):
        (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
            the new screen parameters.
        (-[WebFullscreenController enterFullscreen:]):  Set up the animation that will take the fullscreen element
            from its original screen rect into fullscreen.
        (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
            Set up the animation that will take the fullscreen element back into its original screen
            rect.
        (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine 
            whether to disable screensaver and sleep.
        (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
            looking for HTMLVideoElements; returns whether any are found to be playing.
        (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
            and shift keys.
        (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
        (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
        (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
        (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
        (-[WebFullscreenWindow setRendererLayer:]): Ditto.
        (-[WebFullscreenWindow backgroundLayer]): Ditto.
        (-[WebFullscreenWindow animationView]): Ditto.
        (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
        (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
        
182 183 184 185 186 187 188 189 190 191 192 193
2011-01-07  James Robinson  <jamesr@chromium.org>

        Revert "Implement mozilla's animationTime property"
        https://bugs.webkit.org/show_bug.cgi?id=51952

        This approach isn't quite right.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawRect:]):
        * WebView/WebView.mm:
        (layerSyncRunLoopObserverCallBack):

194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218
2011-01-06  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Bug 52035 - Unregistering DOMWrapperWorlds is unsafe

        The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
        destructor early, in order to release wrappers once we know we no longer intend to use them.
        Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
        lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
        A sequence of events that triggers the bug would look like this:

        (1) Create a DOMWrapperWorld.
        (2) Register a timer in the world.
        (3) Call unregisterWorld() on the world.
        (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
        (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
            called forgetWorld() none exists.
        (6) Attempt to add a wrapper to a NULL map.

        Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.

        * WebView/WebScriptWorld.mm:
        (-[WebScriptWorld unregisterWorld]):

219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240
2011-01-04  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Sam Weinig.

        WK2: Support Accessibility
        https://bugs.webkit.org/show_bug.cgi?id=51859

        Use rootObject() method to get top of AX tree.

        * WebCoreSupport/WebFrameLoaderClient.h:
        (WebFrameLoaderClient::accessibilityRemoteObject):
        * WebView/WebFrame.mm:
        (-[WebFrame setAccessibleName:]):
        (-[WebFrame accessibilityRoot]):
        * WebView/WebFrameInternal.h:
        * WebView/WebFramePrivate.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView accessibilityAttributeValue:]):
        (-[WebHTMLView accessibilityFocusedUIElement]):
        (-[WebHTMLView accessibilityHitTest:]):
        (-[WebHTMLView _accessibilityParentForSubview:]):

241 242 243 244 245 246 247 248 249 250 251 252 253 254 255
2011-01-04  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name

        Reviewed by Eric Carlson.

        This originally broke in r61581.  It is inside an
        ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
        build then.

        * WebCoreSupport/WebFrameLoaderClient.mm: Call
        (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
        use WebCore::PluginInfo.name instead of
        -[WebBasePluginPackage name].

256 257 258 259 260 261 262 263
2011-01-02  Dan Bernstein  <mitz@apple.com>

        Rubber-stamped by Simon Fraser.

        <rdar://problem/8812159> Update copyright strings

        * Info.plist:

264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280
2010-12-29  Dan Bernstein  <mitz@apple.com>

        Reviewed by Ada Chan.

        <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
        https://bugs.webkit.org/show_bug.cgi?id=51717

        Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
        protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.

        * WebView/WebDocumentInternal.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
        (-[WebHTMLView _findString:options:]):
        * WebView/WebView.mm:
        (findString):

281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299
2010-12-28  Daniel Bates  <dbates@rim.com>

        Reviewed by Sam Weinig.

        Substitute // MARK: for compiler-specific #pragma mark
        https://bugs.webkit.org/show_bug.cgi?id=51657

        For consistency, we should substitute "// MARK:" for compiler-
        specific "#pragma mark" in the source files for the Mac port.

        * History/WebHistory.mm:
        * Plugins/WebBaseNetscapePluginView.mm:
        * Plugins/WebNetscapePluginView.mm:
        * WebCoreSupport/WebInspectorClient.mm:
        * WebCoreSupport/WebSecurityOrigin.mm:
        * WebView/WebPDFView.mm:
        * WebView/WebVideoFullscreenController.mm:
        * WebView/WebVideoFullscreenHUDWindowController.mm:

300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318
2010-12-23  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by Darin Adler.

        WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
        https://bugs.webkit.org/show_bug.cgi?id=38535

        WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram.  As a result,
        if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
        WebScriptDebugger's callframe stack is wrong from this point.  That could cause crash if we trying to access the top
        call frame from this stack when an exception throws because the saved top frame could be invalid.

        To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
        callEvent and returnEvent.

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::willExecuteProgram):
        (WebScriptDebugger::didExecuteProgram):

319 320 321 322 323 324 325 326 327 328 329 330 331 332 333
2010-12-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        WebKit2 needs to mirror the frame tree in the UIProcess
        https://bugs.webkit.org/show_bug.cgi?id=51546

        - Add client functions to notify that a frame has been added or
          removed from the page cache.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::didSaveToPageCache):
        (WebFrameLoaderClient::didRestoreFromPageCache):

334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349
2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Editor.h doesn't need to include SelectionController.h
        https://bugs.webkit.org/show_bug.cgi?id=51441

        Renamed SelectionController::EDirection to SelectionDirection.

        * WebView/WebFrame.mm:
        (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
        Takes SelectionDirection instead of SelectionController::EDirection.
        * WebView/WebFrameInternal.h:
        * WebView/WebTextCompletionController.mm:
        (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.

350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384
2010-12-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Cache snapshots of plug-ins before painting, to avoid script running during painting
        https://bugs.webkit.org/show_bug.cgi?id=51493

        When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
        or when printing), plug-ins which otherwise use the CA rendering model
        are sent a paint event. Some plug-ins may run script while handling this event,
        or out of process plug-ins may process queued requests at this time. Running
        script while inside layout or painting can have bad consequences, because it
        can result in arbitrary changes to the render tree.
        
        This patch avoids sending plug-ins paint events inside of painting. Instead,
        we ask the plug-ins to cache a snapshot before we paint, and then the software
        paint simply draws that snapshot.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
        draw it. Also only send the snapshot message to the plugin proxy if we
        know we're snapshotting, since even if creating the snapshot image failed,
        we still don't want to call to the plug-in.

        * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
        (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
        to cache and clear the snapshots.

385 386 387 388 389 390 391 392 393 394 395 396
2010-12-21  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Darin Adler.

        -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
        https://bugs.webkit.org/show_bug.cgi?id=51431
        <rdar://problem/8791757>

        * Plugins/WebBasePluginPackage.mm:
        (-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
        it doesn't underflow.

397 398 399 400 401 402 403 404 405 406 407 408 409 410 411
2010-12-16  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Cameron Zwarich.

        REGRESSION(r74172): 125 java tests fail on Mac
        https://bugs.webkit.org/show_bug.cgi?id=51214

        The regression was caused by an incorrectly adding sizeof(struct fat_header)
        to a pointer for uint32_t as supposed to uint8_t.

        Fixed the bug by explicitly casting it to uint8_t* before the addition.

        * Plugins/WebBasePluginPackage.mm:
        (-[WebBasePluginPackage isNativeLibraryData:]):

412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428
2010-12-15  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Darin Adler.

        Clang -Wcast-align gives an error in WebBasePluginPackage.mm
        https://bugs.webkit.org/show_bug.cgi?id=51144

        Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
        we were calling it on a byte array 32 bits at a time. While this is okay in practice,
        since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
        inline storage is at the beginning of the Vector, it is still better to fix this
        and silence the warning.

        * Plugins/WebBasePluginPackage.mm:
        (swapIntsInHeader):
        (-[WebBasePluginPackage isNativeLibraryData:]):

429 430 431 432 433 434 435 436 437 438
2010-12-14  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig.

        <http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly
        always including the target in the output.

ap@apple.com's avatar
ap@apple.com committed
439 440 441 442 443 444 445 446 447
2010-12-13  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=50953
        DNS Prefetch should be an opt-in feature

        * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default to false.

448 449 450 451 452 453 454 455 456 457 458 459 460
2010-12-13  Mike Thole  <mthole@apple.com>

        Rubber-stamped by John Sullivan.

        https://bugs.webkit.org/show_bug.cgi?id=50956
        WebAuthenticationPanel.nib appears to have a cut-off sentence
        
        Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
        The contents of this text field are updated dynamically before the sheet is displayed.

        * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
        * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:

461 462 463 464 465 466 467 468 469 470 471 472 473 474
2010-12-13  Antti Koivisto  <antti@apple.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=50758
        <rdar://problem/8722094> 
        Defer loading print stylesheets
        
        Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.

        * WebView/WebView.mm:
        (+[WebView _setLoadResourcesSerially:forHost:]):
        * WebView/WebViewPrivate.h:

475 476 477 478 479 480 481 482 483
2010-12-09  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Adopt new CG API for canvas
        https://bugs.webkit.org/show_bug.cgi?id=50591

        * WebCoreSupport/WebSystemInterface.mm:

484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added asynchronous spell checking API to WebEditorClient using
        -[NSSpellChecker requestCheckingOfString].
        Note that WebEditorSpellCheckResponder is a small class to receive
        requested spell-checking result. Note that this feature is
        disabled at default.
        
        Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to 
        enable the feature from LayoutTestController.

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
        (-[WebEditorSpellCheckResponder perform]):
        (toCoreSpellingResult):
        (-[WebEditorSpellCheckResponder WTF::WebCore::]):
        (WebEditorClient::requestCheckingOfString):
        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
        (-[WebPreferences asynchronousSpellCheckingEnabled]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

516 517 518 519 520 521 522
2010-12-09  Anders Carlsson  <andersca@apple.com>

        Fix a bug uncovered by clang++.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):

andersca@apple.com's avatar
andersca@apple.com committed
523 524 525 526 527 528 529 530 531 532 533 534
2010-12-09  Anders Carlsson  <andersca@apple.com>

        Clang++ build fixes.

        Silence a couple of warnings.

        * WebView/WebFrame.mm:
        (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
        (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
        * WebView/WebTextCompletionController.mm:
        (-[WebTextCompletionController filterKeyDown:]):

535 536 537 538 539 540 541 542 543 544 545 546 547 548 549
2010-12-09  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
        writing-mode.  This first part of the patch just patches Mac WebKit 1 views.

        * WebView/WebFrameView.mm:
        (-[WebFrameView _isVerticalDocument]):
        (-[WebFrameView _isFlippedDocument]):
        (-[WebFrameView _scrollToEndOfDocument]):
        (-[WebFrameView _pageInBlockProgressionDirection:]):
        (-[WebFrameView scrollPageUp:]):
        (-[WebFrameView scrollPageDown:]):

550 551 552 553 554 555 556 557 558 559 560
2010-12-08  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        Enable pre-HTML5 parser quirks for Apple Mail.app
        https://bugs.webkit.org/show_bug.cgi?id=50727

        * WebView/WebView.mm:
        (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
        application is Mail.app.

561 562 563 564 565 566 567 568 569 570 571 572 573
2010-12-08  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by John Sullivan.

        REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
        https://bugs.webkit.org/show_bug.cgi?id=50683
        
        If our context menu item already has an action, don't overwrite the action with the context menu
        forwarder.

        * WebView/WebHTMLView.mm:
        (setMenuItemTarget):

574 575 576 577 578 579 580
2010-12-08  Anders Carlsson  <andersca@apple.com>

        Remove an unused variable.

        * WebView/WebDynamicScrollBarsView.mm:
        (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):

581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596
2010-12-07  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by John Sullivan.

        Layering Violation in ContextMenu - member variable of type HitTestResult
        https://bugs.webkit.org/show_bug.cgi?id=50586
        
        Update users of ContextMenu and ContextMenuController to match where the new functions 
        are located.

        * WebCoreSupport/WebContextMenuClient.mm:
        (WebContextMenuClient::getCustomMenuFromDefaultItems):
        (WebContextMenuClient::contextMenuItemSelected):
        * WebView/WebHTMLView.mm:
        (-[WebMenuTarget validateMenuItem:]):

597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620
2010-12-07  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by John Sullivan.

        Part of Layering Violation in ContextMenu
        https://bugs.webkit.org/show_bug.cgi?id=50586
        
        Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
        was a layering violation. Also, make sure we set the menu item targets for all menu
        items before showing them, because the ContextMenu constructor doesn't do that anymore.

        * WebView/WebHTMLView.mm:
        (+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
        (-[WebMenuTarget WebCore::]): Ditto.
        (-[WebMenuTarget setMenuController:WebCore::]): Ditto.
        (-[WebMenuTarget forwardContextMenuAction:]): Ditto.
        (-[WebMenuTarget validateMenuItem:]): Ditto.

        (setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
        (setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including
            submenus), and calls setMenuItemTarget on them.
        (-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding
            them to the menu.

621 622 623 624 625 626 627 628 629 630
2010-12-06  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Pass security origin to make local file decision correctly
        https://bugs.webkit.org/show_bug.cgi?id=48603

        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.

631 632 633 634 635 636 637 638 639 640 641
2010-12-07  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed, rolling out r73392.
        http://trac.webkit.org/changeset/73392
        https://bugs.webkit.org/show_bug.cgi?id=50489

        This commit caused crashes on the GTK+ bots

        * WebView/WebFrame.mm:
        (-[WebFrame _canProvideDocumentSource]):

642 643 644 645 646 647 648 649 650 651 652 653 654 655
2010-12-07  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        Let HTMLObjectElement be a form associated element
        https://bugs.webkit.org/show_bug.cgi?id=48821

        Modified to use FormAssociatedElement instead of HTMLFormControlElement.

        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use
        FormAssociatedElement instead of HTMLFormControlElement.
        (-[WebHTMLRepresentation controlsInForm:]): Ditto.

656 657 658 659 660 661 662 663 664 665
2010-12-06  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Update calls to DocumentWriter.
        https://bugs.webkit.org/show_bug.cgi?id=50489

        * WebView/WebFrame.mm:
        (-[WebFrame _canProvideDocumentSource]):

666 667 668 669 670 671 672 673 674 675 676 677 678
2010-12-06  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
        https://bugs.webkit.org/show_bug.cgi?id=49388

        Got rid of GraphicsLayer::nativeLayer() call, replacing it with 
        GraphicsLayer::platformLayer().

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::attachRootGraphicsLayer):

679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699
2010-12-04  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        WebKit part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range
        https://bugs.webkit.org/show_bug.cgi?id=50530

        * WebView/WebDocumentInternal.h: Added a DOMRange parameter to -countMatchesForText:options:limit:markMatches:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter,
        which is passed through to WebCore.
        * WebView/WebPDFView.mm:
        (isFrameInRange): Added this helper function.
        (-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter and
        a check if the frame is in the range.
        * WebView/WebView.mm:
        (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Now calls the inDOMRange: version.
        (-[WebView countMatchesForText:inDOMRange:options:highlight:limit:markMatches:]): Added DOMRange
        parameter, which is passed to document views' -countMatchesForText:inDOMRange:options:limit:markMatches:.
        * WebView/WebViewPrivate.h:

700 701 702 703 704 705 706 707 708 709 710
2010-12-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Maciej Stachowiak.

        Enable <a ping> for Mac/Windows/WebKit2 builds
        <rdar://problem/8504473>
        https://bugs.webkit.org/show_bug.cgi?id=50488

        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.

711 712 713 714 715 716 717 718 719 720 721 722 723 724 725
2010-12-03  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        Need to move all code that applies correction into correction panel callback.
        https://bugs.webkit.org/show_bug.cgi?id=50426
        <rdar://problem/8720832>

        * WebCoreSupport/WebEditorClient.h: Adopted new signature of dismissCorrectionPanel.

        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::~WebEditorClient): Adopted new signature of dismissCorrectionPanel.
        (WebEditorClient::showCorrectionPanel): Added more user dictionary learning code.
        (WebEditorClient::dismissCorrectionPanel): Adopted new signature of dismissCorrectionPanel.

726 727 728 729 730 731 732
2010-12-02  Simon Fraser  <simon.fraser@apple.com>

        Revert r73217 and r73227 because of continued bustage.

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::attachRootGraphicsLayer):

733 734 735 736 737 738 739 740 741 742 743 744 745
2010-12-02  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
        https://bugs.webkit.org/show_bug.cgi?id=49388

        Got rid of GraphicsLayer::nativeLayer() call, replacing it with 
        GraphicsLayer::platformLayer().

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::attachRootGraphicsLayer):

746 747 748 749 750 751 752 753 754
2010-12-02  Mark Rowe  <mrowe@apple.com>

        Reviewed by Beth Dakin.

        <rdar://problem/8708730> Objects reported as being leaked due to lack of autorelease pool

        * Misc/WebNSFileManagerExtras.m:
        (setMetaData): Create an autorelease pool for the duration of the thread body.

755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781
2010-12-02  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        Move requestGeolocationPermissionForFrame to GeolocationClient
        https://bugs.webkit.org/show_bug.cgi?id=50061

        This change facilitates client-based geolocation implementation by
        bringing together permission control into the geolocation client
        interface.

        Move method ChromeClient::requestGeolocationPermissionForFrame to
        GeolocationClient::requestPermission, and supporting class
        WebGeolocationPolicyListener. The moved code is unchanged except
        that requestPermission now takes only one argument (Geolocation*)
        and the Frame parameter is retrieved from the Geolocation object.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        * WebCoreSupport/WebGeolocationClient.h:
        (WebGeolocationClient::cancelPermissionRequest):
        * WebCoreSupport/WebGeolocationClient.mm:
        (WebGeolocationClient::requestPermission):
        (-[WebGeolocationPolicyListener initWithGeolocation:]):
        (-[WebGeolocationPolicyListener allow]):
        (-[WebGeolocationPolicyListener deny]):

782 783 784 785 786 787 788 789 790 791 792
2010-12-02  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Eric Carlson.

        Style Fixes in WebPluginController
        https://bugs.webkit.org/show_bug.cgi?id=50397

        * Plugins/WebPluginController.mm:
        (-[WebPluginController startAllPlugins]):
        (-[WebPluginController stopAllPlugins]):

793 794 795 796 797 798 799 800 801 802 803 804 805 806
2010-12-02  John Sullivan  <sullivan@apple.com>

        Reviewed by Adam Roben.
        
        Slightly speculative fix for:

        <rdar://problem/8712674>
        <https://bugs.webkit.org/show_bug.cgi?id=50393>
        setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]        

        * Panels/WebAuthenticationPanel.m:
        (-[WebAuthenticationPanel setUpForChallenge:]):
        If the realm is nil, use @"" instead.

807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824
2010-12-01  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        Support multiple correction candidates panel for misspelled word on Mac OS X.
        https://bugs.webkit.org/show_bug.cgi?id=50137
        <rdar://problem/8568059>

        This patch is for supporting multiple correction suggestion panel on Mac OS X.
        The behavior and implementation is similar to that of reversion candiate panel.

        * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.

        * WebCoreSupport/WebEditorClient.mm:  Adopted new signatures defined in base class.
          Added code to handle new multiple suggestion canidate panel type.
        (WebEditorClient::showCorrectionPanel):
        (WebEditorClient::getGuessesForWord):

825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848
2010-12-01  David Hyatt  <hyatt@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=46645
        
        Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
        recently added for horizontal RTL documents and applies it to writing modes as well.  Now the
        scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.
        
        This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
        makes them behave the same as the cross-platform code (allowing for cross-platform results to be
        landed).

        * WebView/WebDynamicScrollBarsView.mm:
        (-[WebDynamicScrollBarsView adjustForScrollOriginChange]):
        (-[WebDynamicScrollBarsView updateScrollers]):
        (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
        (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
        (-[WebDynamicScrollBarsView scrollOrigin]):
        * WebView/WebFrameView.mm:
        (-[WebFrameView _scrollToBeginningOfDocument]):
        (-[WebFrameView _scrollToEndOfDocument]):

849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886
2010-11-29  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        WebKit Mac part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
        https://bugs.webkit.org/show_bug.cgi?id=50038
        Based on a patch from Darin Adler.

        * WebView/WebDocumentInternal.h: Removed -markAllMatchesForText:caseSensitive:limit: and
        replaced -countMatchesForText:caseSensitive:limit:markMatches: with a WebFindOptions-based
        method. Declared a WebDocumentOptionsSearching protocol with a new -findString:options:
        method. Made WebHTMLView conform to the new protocol.
        * WebView/WebHTMLView.mm:
        (coreOptions): Added. Converts WebFindOptions to WebCore FindOptions.
        (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Changed to use
        -findString:options:.
        (-[WebHTMLView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
        (-[WebHTMLView findString:options:]): Added. Calls through to WebCore::Editor::findString().
        * WebView/WebPDFView.mm:
        (-[WebPDFView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
        * WebView/WebView.mm:
        (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Now calls through to
        -countMatchesForText:options:highlight:limit:markMatches.
        (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): Ditto.
        (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): Now calls through to
        -findString:options:.
        (incrementFrame): Changed to use WebFindOptions.
        (findString): Added this helper method that performs the search using the best supported
        method for the document view.
        (-[WebView findString:options:]): Changed -searchFor::::: into this.
        (-[WebView canMarkAllTextMatches]):
        (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Updated to use
        WebFindOptions.
        (-[WebView unmarkAllTextMatches]): Updated for change to incrementFrame.
        (-[WebView rectsForTextMatches]): Ditto.
        * WebView/WebViewPrivate.h: Added WebFindOptions, -findString:options:, and WebFindOptions version
        of countMatchesForText:.

887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911
2010-11-29  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by David Hyatt.

        Right-to-left pages should be scrollable to reveal left overflow.
        https://bugs.webkit.org/show_bug.cgi?id=23556

        Set and get the original x-axis scroll position and reset scroll position on HOME/END key press.
        Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for
        pages with a left overflow.

        * WebView/WebDynamicScrollBarsView.h:
        * WebView/WebDynamicScrollBarsView.mm:
        (-[WebDynamicScrollBarsView inProgramaticScroll]):
        (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]):
        (-[WebDynamicScrollBarsView updateScrollers]):
        (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
        (-[WebDynamicScrollBarsView setScrollOriginX:]):
        (-[WebDynamicScrollBarsView scrollOriginX]):
        * WebView/WebFrameView.mm:
        (-[WebFrameView _scrollToBeginningOfDocument]):
        (-[WebFrameView _scrollToEndOfDocument]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _frameOrBoundsChanged]):

912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927
2010-11-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        SelectionController::typingStyle() should return EditingStyle*
        https://bugs.webkit.org/show_bug.cgi?id=49813

        Changed the return value of SelectionController::typingStyle() to EditingStyle*.
        Also added SelectionController::copyTypingStyle() to copy the typing style
        as an instance of CSSMutableStyleDeclaration.

        No tests are added since this is no behavioral change.

        * WebView/WebFrame.mm:
        (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()

928 929 930 931 932 933 934 935
2010-11-19  Michael Saboff  <msaboff@apple.com>

        Reviewed by Sam Weinig

        Remove DOMSVGAnimatedPathData.h from all: target to fix build.

        * MigrateHeaders.make:

936 937 938 939 940 941 942 943 944
2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
        https://bugs.webkit.org/show_bug.cgi?id=49580

        * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.

945 946 947 948 949 950 951 952
2010-11-18  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Adam Roben.

        <rdar://problem/8602509&8602717&8602724> Enable compaction support.

        * Configurations/WebKit.xcconfig:

953 954 955 956 957 958 959 960 961 962 963
2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72288.
        http://trac.webkit.org/changeset/72288
        https://bugs.webkit.org/show_bug.cgi?id=49730

        'krit attempted to do that, but revert got stuck' (Requested
        by antonm on #webkit).

        * WebView/WebRenderLayer.mm:

964 965 966 967 968 969 970 971 972
2010-11-17  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
        https://bugs.webkit.org/show_bug.cgi?id=49580

        * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.

973 974 975 976 977 978 979 980 981 982 983 984 985
2010-11-16  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Geoff Garen.

        <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests

        Make a static provider for WebDeviceOrientationProviderMock.  The old code allocated a new WebDeviceOrientationProviderMock for 
        every WebView, and the WebKit API doesn't support that ownership model.

        * WebView/WebDeviceOrientationProviderMock.h:
        * WebView/WebDeviceOrientationProviderMock.mm:
        (+[WebDeviceOrientationProviderMock shared]):

986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019
2010-11-16  Dave Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=11004
        
        font-size:0 is ignored.  Remove the minimum font size of 1 in CSSStyleSelector.
        Change the pref value for minimum font size from 1 to 0.  Make sure to never use the NSFont's size,
        since it doesn't honor a size of 0.  Instead pass the size in to the FontPlatformData(NSFont*) version
        of the constructor rather than using [NSFont pointSize].

        https://bugs.webkit.org/show_bug.cgi?id=49582
        
        Negative leading is not handled correctly.  There are two bugs here.  The first is that
        maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
        set them before so that we can allow them to be < 0.
        
        The second issue is that we should understand where fonts will end up relative to
        our baseline (excluding line height), and only allow those boxes to impact ascent and
        descent if the actual font box (without factoring in line height) is above or below the
        root line box baseline.

        Added fast/css/negative-leading.html
        
        These two bug fixes have to land together to keep the Acid 3 test rendering correctly.

        * Misc/WebKitNSStringExtras.mm:
        (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
        (-[NSString _web_widthWithFont:]):
        * Misc/WebStringTruncator.mm:
        (fontFromNSFont):
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):

andersca@apple.com's avatar
andersca@apple.com committed
1020 1021 1022 1023 1024 1025
2010-11-16  Anders Carlsson  <andersca@apple.com>

        Fix clang++ build.

        * WebCoreSupport/WebFrameLoaderClient.mm:

1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036
2010-11-14  Kent Tamura  <tkent@chromium.org>

        Reviewed by Andreas Kling.

        KeyboardEvent::keyIdentifier() should return "const String&"
        https://bugs.webkit.org/show_bug.cgi?id=49426

        * WebCoreSupport/WebEditorClient.mm:
        (selectorForKeyEvent):
          Change the type of a variable to have keyIdentifier(); String -> const String&

1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056
2010-11-12  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        Rename GeolocationControllerClient to GeolocationClient.
        https://bugs.webkit.org/show_bug.cgi?id=49259

        * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h.
        (WebGeolocationClient::webView):
        (WebGeolocationClient::setEnableHighAccuracy):
        * WebCoreSupport/WebGeolocationClient.mm: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm.
        (WebGeolocationClient::WebGeolocationClient):
        (WebGeolocationClient::geolocationDestroyed):
        (WebGeolocationClient::startUpdating):
        (WebGeolocationClient::stopUpdating):
        (WebGeolocationClient::lastPosition):
        * WebKit.order:
        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070
2010-11-10  Beth Dakin  <bdakin@apple.com>

        Reviewed by Simon Fraser.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=49356 
        -[WebView _scaleWebView:] should take and origin and scroll the 
        document
        -and corresponding-
        <rdar://problem/8643921>

        * WebView/WebView.mm:
        (-[WebView _scaleWebView:atOrigin:]):
        * WebView/WebViewPrivate.h:

1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081
2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by David Hyatt.

        HTML5 Ruby support should be mandatory feature
        https://bugs.webkit.org/show_bug.cgi?id=49272

        Remove Ruby as optional feature.

        * Configurations/FeatureDefines.xcconfig:

1082 1083 1084 1085 1086 1087 1088 1089 1090 1091
2010-11-08  Ned Holbrook  <nholbrook@apple.com>

        Reviewed by Adam Barth.

        Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
        https://bugs.webkit.org/show_bug.cgi?id=48886

        * WebCoreSupport/WebSystemInterface.mm:
        (InitWebCoreSystemInterface):

1092 1093 1094 1095 1096 1097 1098 1099 1100
2010-11-08  Nate Chapin  <japhet@chromium.org>

        Unreviewed, build fix.

        Clumsy typo in r71562.

        * Plugins/Hosted/HostedNetscapePluginStream.mm:
        (WebKit::HostedNetscapePluginStream::start):

1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113
2010-11-08  Nate Chapin  <japhet@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Interface changes in https://bugs.webkit.org/show_bug.cgi?id=27165

        * Plugins/Hosted/HostedNetscapePluginStream.mm:
        (WebKit::HostedNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
        * Plugins/WebNetscapePluginStream.mm:
        (WebNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
        * WebView/WebView.mm:
        (-[WebView _dispatchPendingLoadRequests]): Use resourceLoadScheduler() instead of cache()->loader().

1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124
2010-11-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Plug-in views should not assume that plugins are RenderEmbeddedObjects
        https://bugs.webkit.org/show_bug.cgi?id=49196
        <rdar://problem/8638467>

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView pluginHostDied]):

ap@apple.com's avatar
ap@apple.com committed
1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137
2010-11-08  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=48685
        Notify UI process about focused frame

        Added an empty implementation of the new ChromeClient method.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::focusedFrameChanged):

andersca@apple.com's avatar
andersca@apple.com committed
1138 1139 1140 1141 1142 1143
2010-11-08  Anders Carlsson  <andersca@apple.com>

        Build fix.

        * MigrateHeaders.make:

1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157
2010-11-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Remove use of HIGetScaleFactor
        https://bugs.webkit.org/show_bug.cgi?id=49186
        <rdar://problem/8618410>

        Scale factors can vary on a display-by-display basis and it doesn't make sense
        to compute scale factor event coordinates like this.

        * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
        (getCarbonEvent):

1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172
2010-11-08  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        Allow applets to participate in accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=49117
        <rdar://problem/8625819>
        
        If Java is being loaded via the Netscape Plugin API, create a
        NetscapePluginWidget so that it has an implementation of platformLayer().
        
        Also clean up by using early returns.

        * WebCoreSupport/WebFrameLoaderClient.mm:

1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185
2010-11-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Rename Cache to MemoryCache
        https://bugs.webkit.org/show_bug.cgi?id=49159

        * Misc/WebCache.mm:
        (+[WebCache statistics]):
        * WebCoreSupport/WebDeviceOrientationClient.mm:
        (WebDeviceOrientationClient::setController):
        * WebView/WebView.mm:

1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196
2010-11-05  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=49100
        ASSERT([self window]) fails in -[WebBaseNetscapePluginView restartTimers]

        * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView restartTimers]):
        Removed the assertion. Multiple callers provide no guarantee that the plug-in is still alive
        (see bug comments), and there seems to be no harm in executing this function in that case.

1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207
2010-11-05  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Move resumeAnimations/suspendAnimations from Frame to AnimationController.
        https://bugs.webkit.org/show_bug.cgi?id=49073

        * WebView/WebFrame.mm:
        (-[WebFrame _suspendAnimations]):
        (-[WebFrame _resumeAnimations]):

ap@apple.com's avatar
ap@apple.com committed
1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230
2010-11-04  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=49008
        <rdar://problem/7906226> Frequent crashes on mail.yahoo.co.jp

        Callers of NetscapePluginInstanceProxy::waitForReply() are not prepared to be deleted during
        the call, unless it returns 0. There are two reasons for NetscapePluginInstanceProxy to be
        deleted during wait:
        - plugin crashed;
        - plugin was stopped (e.g. due to a DOM modification performed by another reply that came in
        while waiting).

        We didn't recognize the latter.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::waitForReply):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):

1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241
2010-11-05  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
        https://bugs.webkit.org/show_bug.cgi?id=46945

        * WebView/WebFrame.mm:
        (-[WebFrame _suspendAnimations]):
        (-[WebFrame _resumeAnimations]):

mitz@apple.com's avatar
mitz@apple.com committed
1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261
2010-11-04  Jia Pu  <jpu@apple.com>

        Reviewed by Dan Bernstein.

        reversion bubble in WebViews
        https://bugs.webkit.org/show_bug.cgi?id=47630
        <rdar://problem/8530960>

        This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.

        * WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
        * WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code
          change to use new reversion API in AppKit.
        (WebEditorClient::WebEditorClient):
        (WebEditorClient::~WebEditorClient):
        (WebEditorClient::respondToChangedSelection):
        (WebEditorClient::showCorrectionPanel):
        (WebEditorClient::dismissCorrectionPanel):
        (WebEditorClient::isShowingCorrectionPanel):

1262 1263 1264 1265 1266 1267 1268 1269 1270 1271
2010-11-04  Mike Thole  <mthole@apple.com>

        Reviewed by Dan Bernstein.

        Title for images should use localized numerals
        https://bugs.webkit.org/show_bug.cgi?id=49017

        * WebCoreSupport/WebPlatformStrategies.mm:
        (WebPlatformStrategies::imageTitle): Use localized numerals on Snow Leopard or newer.

1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285
2010-11-02  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Barth.

        For unnamed frames, window.name returns a generated name
        https://bugs.webkit.org/show_bug.cgi?id=6751

        Part 1 of 2.

        Substitute FrameTree::uniqueName() for FrameTree::name() in the Mac port. 

        * WebView/WebFrame.mm:
        (-[WebFrame name]):

1286 1287 1288 1289 1290 1291 1292 1293 1294 1295
2010-11-01  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders Carlsson.

        <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
        Context menu support for WebKit 2.

        * WebCoreSupport/WebChromeClient.h:
        (WebChromeClient::showContextMenu):

1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309
2010-10-29  Daniel Bates  <dbates@rim.com>

        No review, rolling out 70971.
        http://trac.webkit.org/changeset/70971
        https://bugs.webkit.org/show_bug.cgi?id=6751

        Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
        it caused layout test failures on all bots. In particular, the
        child count in a generated frame name differs after this patch. We need
        to look into this further.

        * WebView/WebFrame.mm:
        (-[WebFrame name]):

1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322
2010-10-28  Antonio Gomes  <agomes@rim.com>

        Reviewed by Ojan Vafai.

        Needs a "LinuxEditingBehavior", perhaps with a better name
        https://bugs.webkit.org/show_bug.cgi?id=36627

        Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.

        * WebView/WebFrame.mm:
        (core):
        * WebView/WebPreferencesPrivate.h:

1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334
2010-10-29  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Barth.

        For unnamed frames, window.name returns a generated name
        https://bugs.webkit.org/show_bug.cgi?id=6751

        Modified Mac-port to use FrameTree::uniqueName().

        * WebView/WebFrame.mm:
        (-[WebFrame name]):

1335 1336 1337 1338 1339 1340 1341 1342 1343 1344
2010-10-29  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
        https://bugs.webkit.org/show_bug.cgi?id=48574

        * History/WebBackForwardList.mm:
        Use BackForwardListImpl.

ap@apple.com's avatar
ap@apple.com committed
1345 1346 1347 1348 1349 1350 1351 1352 1353
2010-10-29  Alexey Proskuryakov  <ap@apple.com>

        Rubber-stamped by Sam Weinig.

        Comment for usesDocumentViews explains it backwards. This flag is true in ToT, and we do
        create views for subframes.

        * WebView/WebViewData.h: Double negation is better than a lie.

1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371
2010-10-27  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Full screen video in Safari (still) exits full-screen if you switch to another 
        app on a multi-display system.
        https://bugs.webkit.org/show_bug.cgi?id=47364
        <rdar://problem/8382299>
        
        The FullScreen window does not technically close when it deactivates, but the 
        two NSWindows that make up the FullScreen feature should not hide when deactivated.
        
        * WebView/WebVideoFullscreenController.mm:
        (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate.
        (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
        * WebView/WebVideoFullscreenHUDWindowController.mm:
        (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.

ap@apple.com's avatar
ap@apple.com committed
1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384
2010-10-29  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=48576
        Let WebKit2 client know when a frame is a frameset

        Added a blank implementation of the new FrameLoaderClient method.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidBecomeFrameset):

1385 1386 1387 1388 1389 1390 1391 1392 1393
2010-10-29  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Adam Roben and David Kilzer.

        Fix and cleanup of build systems
        https://bugs.webkit.org/show_bug.cgi?id=48342

        * Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX.

mitz@apple.com's avatar
mitz@apple.com committed
1394 1395 1396 1397 1398 1399 1400 1401 1402 1403
2010-10-28  Dan Bernstein  <mitz@apple.com>

        Reviewed by Mark Rowe.

        LLVM compiler build fix

        * Misc/WebDownload.mm:
        (-[WebDownload initWithRequest:delegate:]): Changed the delegate type from id to
        id<NSURLDownloadDelegate> to match the method signature in NSURLDownload.

1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425
2010-10-28  Ivan Krstić  <ike@apple.com>

        Reviewed by Mark Rowe.

        Remove unused experimental proxied panel interface.
        <rdar://problem/7237059>

        * Plugins/Hosted/NetscapePluginHostManager.h:
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::hostForPlugin):
        (WebKit::NetscapePluginHostManager::spawnPluginHost):
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:
        * WebCoreSupport/WebSystemInterface.mm:
        (InitWebCoreSystemInterface):
        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        * WebView/WebPreferencesPrivate.h:

1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437
2010-10-27  Pratik Solanki  <psolanki@apple.com>

        Reviewed by Darin Adler.

        Improve memSize calculation in [WebView _setCacheModel]
        https://bugs.webkit.org/show_bug.cgi?id=48484

        * WebView/WebView.mm:
        (roundUpToPowerOf2): Added. Utility function to calculate the nearest power of 2.
        (+[WebView _setCacheModel:]): Update memSize calculation to set it to the next
        bigger power of 2. Also update WebCore cache settings.

1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467
2010-10-26  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
        https://bugs.webkit.org/show_bug.cgi?id=42322
        rdar://problem/8193631

        WebKitTestRunner needs to support layoutTestController.clearBackForwardList
        https://bugs.webkit.org/show_bug.cgi?id=42333
        rdar://problem/8193643

        * History/WebBackForwardList.mm:
        (core): Return BackForwardListImpl.
        (kit): Take BackForwardListImpl.
        (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl.
        (-[WebBackForwardList dealloc]): Ditto.
        (-[WebBackForwardList finalize]): Ditto.
        (-[WebBackForwardList description]): Ditto.
        (-[WebBackForwardList setPageCacheSize:]): Ditto.
        (-[WebBackForwardList pageCacheSize]): Ditto.
        * History/WebBackForwardListInternal.h: Ditto.
        * WebView/WebFrameView.mm:
        (-[WebFrameView keyDown:]): Ditto.
        * WebView/WebView.mm:
        (-[WebView initWithCoder:]): Ditto.
        (-[WebView encodeWithCoder:]): Ditto.
        (-[WebView backForwardList]): Ditto.
        (-[WebView setMaintainsBackForwardList:]): Ditto.

1468 1469 1470 1471 1472 1473 1474 1475 1476
2010-10-27  Chris Rogers  <crogers@google.com>

        Reviewed by Chris Marrin.

        Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
        https://bugs.webkit.org/show_bug.cgi?id=48279

        * Configurations/FeatureDefines.xcconfig:

1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493
2010-10-27  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit 
        SPI to scale a WebView
        -and corresponding-
        <rdar://problem/8107667>

        This patch adds SPI to Mac WebKit that scales the page by the given 
        scale factor.

        * WebView/WebView.mm:
        (-[WebView _scaleWebView:]):
        (-[WebView _viewScaleFactor]):
        * WebView/WebViewPrivate.h:

1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507
2010-10-27  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70335): Incorrect article layout in Safari Reader
        https://bugs.webkit.org/show_bug.cgi?id=48436

        * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_GET_MATCHED_CSS_RULES_RESTRICTIONS.
        * WebView/WebView.mm:
        (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Added. Returns YES for Safari linked against
        versions of WebKit that did not have the cross-origin restrictions in getMatchedCSSRules().
        (-[WebView _preferencesChangedNotification:]): Call Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled()
        based on the above.

1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518
2010-10-18  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Safari fullscreen media element tickles when it should not.
        
        https://bugs.webkit.org/show_bug.cgi?id=47861

        * WebView/WebVideoFullscreenController.mm:
        (-[WebVideoFullscreenController updatePowerAssertions]):

1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533
2010-10-26  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Dmitry Titov.

        Resource tracking failure when trying to move a frame between documents
        https://bugs.webkit.org/show_bug.cgi?id=44713

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
        Empty method.
        (WebFrameLoaderClient::transferLoadingResourceFromPage):
        Update resource tracking for a resource load that has been transferred
        to a new page.

1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547
2010-10-25  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Remove exec and globalData arguments from jsNumber
        https://bugs.webkit.org/show_bug.cgi?id=48270

        Mechanical removal of exec parameter to jsNumber

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyInstance::numberValue):

1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562
2010-10-24  Dan Bernstein  <mitz@apple.com>

        Reviewed by Anders Carlsson.

        Expose HitTestResult::absoluteMediaURL() via WebKit API
        https://bugs.webkit.org/show_bug.cgi?id=48219

        * Misc/WebElementDictionary.mm:
        (+[WebElementDictionary initializeLookupTable]): Map WebElementMediaURLKey to
        _absoluteMediaURL.
        (-[WebElementDictionary _absoluteMediaURL]): Added. Returns absoluteMediaURL().
        * WebKit.exp: Export WebElementMediaURLKey.
        * WebView/WebView.mm: Define WebElementMediaURLKey.
        * WebView/WebViewPrivate.h: Declare WebElementMediaURLKey.

1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575
2010-10-24  Dan Bernstein  <mitz@apple.com>

        Reviewed by Simon Fraser.

        Removed deprecated methods from the WebHTMLHighlighter private protocol.

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::customHighlightRect): Call -highlightRectForLine:representedNode:
        unconditionally.
        (WebChromeClient::paintCustomHighlight): Call
        -paintHighlightForBox:onLine:behindText:entireLine:representedNode: unconditionally.
        * WebView/WebHTMLViewPrivate.h:

1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590
2010-10-23  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Sam Weinig.

        Unify globalData APIs
        https://bugs.webkit.org/show_bug.cgi?id=47969

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::evaluate):
        (WebKit::NetscapePluginInstanceProxy::invoke):
        (WebKit::NetscapePluginInstanceProxy::invokeDefault):
        (WebKit::NetscapePluginInstanceProxy::construct):
        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptCallFrame evaluateWebScript:]):

1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601
2010-10-23  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header

        Reviewed by Sam Weinig.

        The only method defined in WebHTMLRepresentationInternal.h is
        also defined in WebHTMLRepresentation.h, so use that instead.

        * WebView/WebHTMLRepresentationInternal.h: Removed.

ap@apple.com's avatar
ap@apple.com committed
1602 1603 1604 1605 1606 1607 1608 1609 1610
2010-10-23  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=48083
        <rdar://problem/8489082> Need WebKit2 API for private browsing (48083)

        * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize the new method.

1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625
2010-10-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        WebKit2 needs to pass the current event modifier flags when requesting a new window
        https://bugs.webkit.org/show_bug.cgi?id=48140

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::createWindow):
        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchCreatePage):
        Add NavigationAction parameter.

1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643
2010-10-21  Andy Estes  <aestes@apple.com>

        Reviewed by Eric Carlson.

        WebKit shouldn't load a plug-in based on file extension if a MIME type
        is specified.
        https://bugs.webkit.org/show_bug.cgi?id=48046

        If a MIME type is specified in an object or embed element, and that MIME
        type isn't supported by an installed plug-in, WebKit shouldn't attempt
        to find a plug-in based on the file extension of the url attribute.
        Doing so can lead to cases where a plug-in is loaded that can't handle
        resources of the MIME type specified by the author.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createPlugin): Only check for a pluginPackage by
        extension if MIME type is the empty string.

1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667
2010-10-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Composited elements drawn twice when WebView is layer-backed
        https://bugs.webkit.org/show_bug.cgi?id=48024
        <rdar://problem/7916580>
        
        When drawing content in a layer-backed WebView, WebFrame's test
        for drawing to a bitmap succeeded, causing us to paint flattened
        compositing layers into the view. They would also be rendered
        by the normal compositing path, resulting in double rendering.
        
        Fix this by detecting when the WebHTMLView is being drawn into
        a layer, and avoiding flattening in that case.

        * WebView/WebFrame.mm:
        (-[WebFrame _showFlattenedCompositingLayers:]):
        (-[WebFrame _drawRect:contentsOnly:]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawLayer:inContext:]):
        (-[WebHTMLView _web_isDrawingIntoLayer]):
        * WebView/WebHTMLViewInternal.h:

1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681
2010-10-20  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by David Levin.

        Repost the DatabaseTracker notifications to the main thread, if needed.
        https://bugs.webkit.org/show_bug.cgi?id=40655

        * Storage/WebDatabaseTrackerClient.mm:
        (DidModifyOriginData::dispatchToMainThread):
        (DidModifyOriginData::DidModifyOriginData):
        (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
        (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
        (WebDatabaseTrackerClient::dispatchDidModifyDatabase):

1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699
2010-10-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        REGRESSION(r67568-r67643): Some HTML/CSS renders upside down and backwards on Leopard
        https://bugs.webkit.org/show_bug.cgi?id=47369
        
        r46947 added code that limits the size of the layer-backed view on Leopard when
        the page height exceeds 4096px (later adjusted to 2048px in r48401).
        
        Later, r67576 altered the geometry flipping behavior to push the geometry flipping
        down into WebKit. However, the code that adjusts the hosting layer's sublayer transform
        to account for layer-backed view size-limiting was not fixed at the same time.
        This change corrects that.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _updateLayerHostingViewPosition]):

1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716
2010-10-19  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/8508422> Compositing layers aren't always displayed correctly in layer-backed WebViews
        
        AppKit has some special code to prevent it meddling with view's layers
        under layer-backed WebViews. When a layer-backed WebView became composited,
        this caused our layer to remain zero-sized. Fix this by manually
        setting the geometry for our layer, if the WebHTMLView has a layer.
        
        This does not seem to be a problem if the WebView becomes layer-backed, or
        stops being layer-backed after the WebView starts using compositing.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView attachRootLayer:]):

1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729
2010-10-20  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Merge ColorSpace and ImageColorSpace enums
        https://bugs.webkit.org/show_bug.cgi?id=47922

        Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
        to follow webkit style rules.

        * Misc/WebKitNSStringExtras.mm:
        (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):

ap@apple.com's avatar
ap@apple.com committed
1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744
2010-10-19  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=47933
        <rdar://problem/8494337> navigator.language doesn't work in WebKit2

        * Misc/WebNSUserDefaultsExtras.mm: Moved code for computing default language to WebCore.
        We need to keep _webkit_preferredLanguageCode for Safari.

        * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
        Initialize wkCopyCFLocalizationPreferredName.

        * WebCoreSupport/WebViewFactory.mm: Removed defaultLanguage. WebCore was the only caller.

ap@apple.com's avatar
ap@apple.com committed
1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765
2010-10-18  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=47864
        Convert WebNSUserDefaultsExtras.m to .mm

        Also, fixed some issues in the process:
        - removed locking, which was only necessary when this code was in Foundation;
        - fixed notification center observer to actually work (previously, it picked up changes
        when application preferences changed, not when system language did);
        - removed unused NSString category;
        - updated style.

        * Misc/WebNSUserDefaultsExtras.m: Removed.
        * Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m.
        (createHTTPStyleLanguageCode):
        (+[NSUserDefaults _webkit_defaultsDidChange]):
        (addLanguageChangeObserver):
        (+[NSUserDefaults _webkit_preferredLanguageCode]):

1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780
2010-10-18  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Eric Seidel.

        Switch to using the new Carbon NPAPI event declarations, and remove
        the old ones.

        https://bugs.webkit.org/show_bug.cgi?id=40784

        * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
        (WebNetscapePluginEventHandlerCarbon::mouseEntered):
        (WebNetscapePluginEventHandlerCarbon::mouseExited):
        (WebNetscapePluginEventHandlerCarbon::mouseMoved):
        (WebNetscapePluginEventHandlerCarbon::focusChanged):

1781 1782 1783 1784 1785 1786 1787 1788 1789 1790
2010-10-18  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: disable private browsing for inspector
        https://bugs.webkit.org/show_bug.cgi?id=47827

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController init]):

1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811
2010-10-14  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: inspector settings/properties/states management
        should be extracted into separate class.

        We have a lot of flags/values in InspectorController.
        Some flags are persisting into profile.
        Others are part of inspector state for frontend.
        All these flags should keep their values after navigation.
        It'd be better to extract these flags/values into separate
        class which will care about theirs lifetime.

        https://bugs.webkit.org/show_bug.cgi?id=47275

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController showWindow:]):
        (-[WebInspectorWindowController attach]):
        (-[WebInspectorWindowController detach]):

1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822
2010-10-13  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=43987
        Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
        to construct their internal result string.  Remove ScriptString (this is now
        redundant).

        * WebCoreSupport/WebFrameLoaderClient.mm:

1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835
2010-10-12  Andy Estes  <aestes@apple.com>

        Rubber-stamped by Darin Adler.

        Check in some cleanup from the previous commit.

        * WebView/WebView.mm:
        (leakMailQuirksUserScriptPath): Renamed to indicate that this function
        leaks an NSString.
        (-[WebView _injectMailQuirksScript]): Moved a static initialization from
        a separate class method into the only method that used it and removed
        the now-unnecessary class method.

1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852
2010-10-12  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION (new parser): Leopard/Tiger Mail <head>/<body> quirk is gone
        https://bugs.webkit.org/show_bug.cgi?id=45693

        Re-implement this former WebCore parser quirk as a
        Mac-only userscript-based quirk.  As far as I can tell
        from Darin's description this should satisfy Mail's needs.

        * Misc/MailQuirksUserScript.js: Added.
        * WebView/WebView.mm:
        (+[WebView _mailQuirksUserScript]):
        (-[WebView _injectMailQuirksScript]):
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866
2010-10-12  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        Add 'didDraw' callback for framerate tracking
        https://bugs.webkit.org/show_bug.cgi?id=47478

        Add a callback at the end of -[WebHTMLView drawRect:] so
        a delegate can get notified when a draw happens.
        
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawRect:]):
        * WebView/WebUIDelegatePrivate.h:

1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881
2010-10-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Remove WebIconFetcher from WebKit and IconFetcher from WebCore
        https://bugs.webkit.org/show_bug.cgi?id=47523

        Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.

        * Misc/WebIconFetcher.h: Removed.
        * Misc/WebIconFetcher.mm: Removed.
        * Misc/WebIconFetcherInternal.h: Removed.
        * WebView/WebFrame.mm:
        * WebView/WebFramePrivate.h:

1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893
2010-10-11  Jessie Berlin  <jberlin@apple.com>

        Reviewed by Darin Adler.

        Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
        representation of a WebKit1 WebSerializedJSValue.
        https://bugs.webkit.org/show_bug.cgi?id=47439

        * WebView/WebSerializedJSValue.mm:
        (-[WebSerializedJSValue internalRepresentation]):
        * WebView/WebSerializedJSValuePrivate.h:

1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907
2010-10-07  Jessie Berlin  <jberlin@apple.com>

        Reviewed by Sam Weinig.

        Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
        representation of a WebKit2 WebSerializedScriptValue.
        https://bugs.webkit.org/show_bug.cgi?id=47390

        * WebView/WebSerializedJSValue.mm:
        (-[WebSerializedJSValue initWithInternalRepresentation:]):
        Set the WebSerializedJSValuePrivate's WebCore::SerializedScriptValue to be the passed in
        internal representation.
        * WebView/WebSerializedJSValuePrivate.h: Added.

1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926
2010-10-07  Antonio Gomes  <agomes@rim.com>

        Reviewed by Simon Fraser.

        [Mac] [DRT] implement setSpatialNavigationEnabled
        https://bugs.webkit.org/show_bug.cgi?id=47291

        Added the needed bits to make it possible to enabled spatial navigation
        for the Mac port. For now it is being only used by DRT.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences isSpatialNavigationEnabled]):
        (-[WebPreferences setSpatialNavigationEnabled:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

1927 1928 1929 1930 1931 1932 1933 1934
2010-10-07  Jer Noble  <jer.noble@apple.com>

        Fix the Leopard 64-bit build.

        * Configurations/WebKit.xcconfig: Add CoreServices.framework/Frameworks to the 
            framework search path.
        * WebView/WebVideoFullscreenController.mm: Explicitly import <OSStatus/Power.h>.

1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953
2010-10-06  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Screensaver starts while watching fullscreen playback.
        https://bugs.webkit.org/show_bug.cgi?id=47299
        <rdar://problem/8478956>

        To disable the Screen Saver, we need to periodically call UpdateSystemActivity().  

        * WebView/WebVideoFullscreenController.h: Added _tickleTimer.
        * WebView/WebVideoFullscreenController.mm:
        (-[WebVideoFullscreenController dealloc]): Invalidate _tickleTimer.
        (-[WebVideoFullscreenController _enableTickleTimer]): Create _tickleTimer. 
        (-[WebVideoFullscreenController _disableTickleTimer]): Invalidate _tickleTimer.
        (-[WebVideoFullscreenController _tickleTimerFired]): Call UpdateSystemActivity().
        (-[WebVideoFullscreenController updatePowerAssertions]): Call _enableTickleTimer 
            or _disableTickleTimer.

1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968
2010-10-05  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        check for ENABLE(GLIB_SUPPORT) in WebView
        https://bugs.webkit.org/show_bug.cgi?id=46788

        Use ENABLE(GLIB_SUPPORT) in WebView to guard the glib runloop observer.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        (-[WebView _close]):
        * WebView/WebViewData.h:
        * WebView/WebViewInternal.h:

andersca@apple.com's avatar
andersca@apple.com committed
1969 1970 1971 1972 1973 1974 1975
2010-10-01  Anders Carlsson  <andersca@apple.com>

        Fix Snow Leopard build.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::getProxy):

1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990
2010-10-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
        https://bugs.webkit.org/show_bug.cgi?id=47022
        <rdar://problem/8504712>

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::getProxy):
        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView getVariable:forURL:value:length:]):

1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003
2010-09-30  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Remove remaining calls to deprecatedParseURL
        https://bugs.webkit.org/show_bug.cgi?id=26599

        * DOM/WebDOMOperations.mm:
        (-[DOMDocument URLWithAttributeString:]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createPlugin):
        Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.

2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017
2010-09-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        -[DOMDocument _documentRange] throws an exception if there is no document element
        https://bugs.webkit.org/show_bug.cgi?id=46934
        <rdar://problem/8169260>

        If there is no document element, just return an empty range. Otherwise we'll try to call
        Range::selectNode with a null Node which will throw a NOT_FOUND exception.

        * DOM/WebDOMOperations.mm:
        (-[DOMDocument _documentRange]):

2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028
2010-09-30  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Make 2D accelerated canvas rendering build on Mac
        https://bugs.webkit.org/show_bug.cgi?id=46007
        
        Added ACCELERATED_2D_CANVAS to FeatureDefines

        * Configurations/FeatureDefines.xcconfig:

2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039
2010-09-30  Dan Bernstein  <mitz@apple.com>

        Reviewed by John Sullivan.

        Add printing SPI allowing full control over shrink-to-fit
        https://bugs.webkit.org/show_bug.cgi?id=46877

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Added.
        * WebView/WebHTMLViewPrivate.h:

2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056
2010-09-28  Johnny Ding  <jnd@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=41292
        Some windowed plugins did not handle events through EventHandler, so we
        never set right gesture state for those events.
        This change is to set right allowPopupsFromPlugin flag to current
        execution frame, so WeKit can always get right gesture state on Mac.
        From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
        process, that process passes the allowPopupsFromPlugin flag to
        WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in
        NetscapePluginInstanceProxy::evaluate.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView sendEvent:isDrawRect:]):

2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067
2010-09-28  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Dmitry Titov.

        Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
        https://bugs.webkit.org/show_bug.cgi?id=46663

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::didTransferChildFrameToNewDocument):

2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088
2010-09-26  Antonio Gomes  <agomes@rim.com>

        Reviewed by Kenneth Rohde Christiansen.

        DRT/Mac nodesFromRect support

        [Mac][DRT] Implement LayoutTestController::nodesFromRect
        https://bugs.webkit.org/show_bug.cgi?id=46580

        Implement nodesFromRect as a private method to access non-exposed Document
        methods, similarly to computedStyleIncludingVisitedInfo.

        * WebView/WebView.mm: Added JSDocument.h and JSNodeList.h to the include list.
        These headers makes it possible to:
        1) Get a Document off of a JSDocument;
        2) Call toJS function, defined in JSNodeList.cpp|h so we can convert RefPtr<NodeList>
        gotten from Document::nodesFromRect to JS bindings.
        (-[WebView _nodesFromRect:forDocument:x:y:hPadding:vPadding:ignoreClipping:]):
        * WebView/WebViewPrivate.h: Added nodesFromRect method to access methods of the
        Document class not exposed to JavaScript. It works similarly to computedStyleIncludingVisitedInfo.

2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100
2010-09-24  Jia Pu  <jpu@apple.com>

        Reviewed by Dan Bernstein.

        automaticSpellingCorrectionEnabled isn't updated.
        https://bugs.webkit.org/show_bug.cgi?id=46486
        <rdar://problem/8475212>

        * WebView/WebView.mm:
        (+[WebView initialize]): Should update "automaticSpellingCorrectionEnabled"
          instead of "automaticTextReplacementEnabled".

ap@apple.com's avatar
ap@apple.com committed
2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112
2010-09-23  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=46380
        REGRESSION: Crash when downloading a file

        Downloading cannot be tested in DRT.

        * Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
        Don't copy null strings.

2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130
2010-09-24  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: CRASH at node highlight on MAC Safari.
        1) run-safari --debug
        2) open inspector
        3) open elements panel
        4) hover mouse over elements panel items multiple times
        5) CRASH
        Looks like it is a race condition. WebNodeHighlightView doesn't check
        the pointer to WebNodeHighligh object and it can be nil.

        https://bugs.webkit.org/show_bug.cgi?id=46261

        * WebInspector/WebNodeHighlightView.mm:
        (-[WebNodeHighlightView drawRect:]):

2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149
2010-09-23  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r61285): some Dashboard widgets are always invisible due to
        HTML parser changes.
        https://bugs.webkit.org/show_bug.cgi?id=46435

        Enable pre-HTML5 parser quirks if Dashboard is in backward compatibility
        mode.

        * WebView/WebView.mm:
        (-[WebView _needsPreHTML5ParserQuirks]): Renamed from
        shouldUsePreHTML5ParserQuirks(). Return true if
        WebCore::Settings::usesDashboardCompatibilityMode() is true.
        (-[WebView _preferencesChangedNotification:]):
        (-[WebView _setDashboardBehavior:to:]): Enable pre-HTML5 parser quirks
        if Dashboard behavior is set to backward compatibility mode.

2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160
2010-09-23  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Reduce minimum DOMTimer interval
        https://bugs.webkit.org/show_bug.cgi?id=45362

        * WebView/WebView.mm:
        Updating set interval call to use Settings' static version inside
        one time init block.

2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176
2010-09-22  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r61285): Microsoft Entourage 2008 does not invoke My Day window
        https://bugs.webkit.org/show_bug.cgi?id=46334

        Microsoft My Day loads scripts using self-closing script tags, markup
        which is incompatible with the HTML5 parser. Enable parser quirks for
        this application.

        * WebView/WebView.mm:
        (shouldUsePreHTML5ParserQuirks): Return true if the application is
        Microsoft My Day and was linked against a version of WebKit prior to the
        introduction of the HTML5 parser.

2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193
2010-09-23  Nate Chapin  <japhet@chromium.org>

        Reviewed by Darin Fisher.

        Add hyperlink auditing settings (i.e., <a ping>).
        https://bugs.webkit.org/show_bug.cgi?id=30458

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences setMemoryInfoEnabled:]):
        (-[WebPreferences hyperlinkAuditingEnabled]):
        (-[WebPreferences setHyperlinkAuditingEnabled:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

ap@apple.com's avatar
ap@apple.com committed
2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206
2010-09-22  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=43667
        ASSERT failure in NetscapePluginInstanceProxy::disconnectStream

        Test: plugins/get-javascript-url.html

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Add the stream to m_streams, just
        like any other one.

2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218
2010-09-21  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Fix some Objective-C GC problems and use RetainPtr instead of HardRetain/Release
        https://bugs.webkit.org/show_bug.cgi?id=46220

        * Misc/WebNSFileManagerExtras.m:
        (setMetaData): Use CFRelease instead of HardRelease.
        (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Use CFStringCreateCopy
        instead of -[NSObject copy] combined with HardRetainWithNSRelease.

2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230
2010-09-22  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        PluginStrategy should satisfy the needs of Qt
        https://bugs.webkit.org/show_bug.cgi?id=45857
        No new functionality so no new tests.

        * WebCoreSupport/WebPlatformStrategies.h:
        * WebCoreSupport/WebPlatformStrategies.mm:
        (WebPlatformStrategies::getPluginInfo):

2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242
2010-09-22  Paul Knight  <pknight@apple.com>

        Reviewed by Simon Fraser.

        -[WebView _scheduleCompositingLayerSync] should wake the run loop
        https://bugs.webkit.org/show_bug.cgi?id=46226

        Call CFRunLoopWakeUp to make sure the run loop is not sleeping, which could delay layer painting.

        * WebView/WebView.mm:
        (-[WebView _scheduleCompositingLayerSync]):

2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262
2010-09-21  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
        https://bugs.webkit.org/show_bug.cgi?id=46134

        AIM clients linked against versions of WebKit prior to the introduction
        of the HTML5 parser contain markup incompatible with the new parser.
        Enable parser quirks in this case to remain compatible with these
        clients.

        * WebView/WebView.mm:
        (shouldUsePreHTML5ParserQuirks): Returns true if the embedding
        application is AIM and was linked against a version of WebKit prior to
        the introduction of the HTML5 parser, or if the
        WebKitPreHTML5ParserQuirks WebPreference is enabled.
        (-[WebView _preferencesChangedNotification:]): Call
        WebCore::Set