ChangeLog 1.07 MB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
2013-10-01  Nadav Rotem  <nrotem@apple.com>

        Consolidate multiple OSRExit calls into one.
        https://bugs.webkit.org/show_bug.cgi?id=122168

        Reviewed by Filip Pizlo.

        * ftl/FTLLowerDFGToLLVM.cpp:
        (JSC::FTL::LowerDFGToLLVM::compileArithMul):
        (JSC::FTL::LowerDFGToLLVM::compileArithDiv):
        (JSC::FTL::LowerDFGToLLVM::compileArithMod):

13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29
2013-09-30  Filip Pizlo  <fpizlo@apple.com>

        SpeculativeJIT::m_arguments/m_variables are vestiges of a time long gone
        https://bugs.webkit.org/show_bug.cgi?id=122140

        Reviewed by Darin Adler.
        
        Just killing code.

        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::SpeculativeJIT::SpeculativeJIT):
        (JSC::DFG::SpeculativeJIT::compileInlineStart):
        (JSC::DFG::SpeculativeJIT::compileCurrentBlock):
        (JSC::DFG::SpeculativeJIT::checkArgumentTypes):
        * dfg/DFGSpeculativeJIT.h:
        (JSC::DFG::SpeculativeJIT::recordSetLocal):

30 31 32 33 34 35 36 37 38 39
2013-10-01  Daniel Bates  <dabates@apple.com>

        [iOS] JavaScriptCore fails to build with newer versions of clang
        https://bugs.webkit.org/show_bug.cgi?id=122162

        Reviewed by Darin Adler.

        * runtime/GCActivityCallback.cpp: Add !PLATFORM(IOS)-guard around constant pagingTimeOut
        as we don't compile the code that uses it on iOS.

40 41 42 43 44 45 46 47 48
2013-09-30  Sam Weinig  <sam@webkit.org>

        Remove support for DOMFileSystem
        https://bugs.webkit.org/show_bug.cgi?id=122137

        Reviewed by Anders Carlsson.

        * Configurations/FeatureDefines.xcconfig:

49 50 51 52 53 54 55 56 57 58 59
2013-09-30  Dan Bernstein  <mitz@apple.com>

        <rdar://problem/15114974> Assertion failure under -[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:] if no classes conform to JSExport
        https://bugs.webkit.org/show_bug.cgi?id=122124

        Reviewed by Darin Adler.

        * API/JSWrapperMap.mm: Defined an empty class that conforms to the JSExport protocol, to
        ensure that the protocol is always registered with the runtime by the time
        getJSExportProtocol() is called.

60 61 62 63 64 65 66 67 68
2013-09-30  Benjamin Poulain  <benjamin@webkit.org>

        Remove the code guarded by STYLE_SCOPED
        https://bugs.webkit.org/show_bug.cgi?id=122123

        Reviewed by Anders Carlsson.

        * Configurations/FeatureDefines.xcconfig:

69 70 71 72 73 74 75 76 77 78
2013-09-30  Andreas Kling  <akling@apple.com>

        Pass VM instead of ExecState to ObjectPrototype constructor.
        <https://webkit.org/b/122116>

        Reviewed by Geoffrey Garen.

        The ObjectPrototype constructor was only using the ExecState to get
        to the VM.

79 80 81 82 83 84 85 86 87 88
2013-09-30  Andreas Kling  <akling@apple.com>

        Pass VM instead of JSGlobalObject to MathObject constructor.
        <https://webkit.org/b/122119>

        Reviewed by Geoffrey Garen.

        The MathObject constructor was only using the global object to get
        to the VM. finishCreation() still uses it to set up functions.

89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185
2013-09-30  Filip Pizlo  <fpizlo@apple.com>

        Get rid of the AlreadyInJSStack recoveries since they are totally redundant with the DisplacedInJSStack recoveries
        https://bugs.webkit.org/show_bug.cgi?id=122065

        Reviewed by Mark Hahnenberg.
        
        This mostly just kills a bunch of code.
        
        But incidentaly while killing that code, I uncovered a bug in our FTL OSR entrypoint
        creation phase. The phase inserts a sequence of SetLocal(ExtractOSREntryLocal) nodes.
        If we hoist some type check into the local, then we might inject a conversion node
        between the ExtractOSREntryLocal and the SetLocal - for example we might put in a
        Int32ToDouble node. But currently the FixupPhase will make all conversion nodes placed
        on an edge of a SetLocal use forward exit. This then confuses the OSR exit machinery.
        When OSR exit sees a forward exit, it tries to "roll forward" execution from the exiting
        node to the first node that has a different CodeOrigin. This only works if the nodes
        after the forward exit are MovHints or other tnings that the OSR exit compiler can
        forward-execute. But here, it will see a bunch of SetLocal and ExtractOSREntryLocal
        nodes for the same bytecode index. Two possible solutions exist. We could teach the
        forward-execution logic how to deal with multiple SetLocals and ExtractOSREntryLocals.
        This would be a lot of complexity; right now it just needs to deal with exactly one
        SetLocal-like operation. The alternative is to make sure that the conversion node that
        we inject ends up exiting *backward* rather than forward.
        
        But making the conversion nodes exit backward is somewhat tricky. Before this patch,
        conversion nodes always exit forward for SetLocals and backwards otherwise. It turns out
        that the solution is to rationalize how we choose the speculation direciton for a
        conversion node. The conversion node's speculation direction should be the same as the
        speculation direction of the node for which it is doing a conversion. Since SetLocal's
        already exit forward by default, this policy preserves our previous behavior. But it
        also allows the OSR entrypoint creation phase to make its SetLocals exit backward
        instead.
        
        Of course, if the SetLocal(ExtractOSREntryLocal) sequences exit backward, then we need
        to make sure that the OSR exit machine knows that the local variables are indeed live.
        Consider that if we have:
        
            a: ExtractOSREntryLocal(loc1)
            b: SetLocal(@a, loc1)
            c: ExtractOSRentryLocal(loc2)
            d: SetLocal(@c, loc2)
        
        Without additional magic, the exit at @b will think that loc2 is dead and the OSR exit
        compiler will clobber loc2 with Undefined. So we need to make sure that we actually
        emit code like:
        
            a: ExtractOSREntryLocal(loc1)
            b: ExtractOSREntryLocal(loc2)
            c: SetLocal(@a, loc1)
            d: SetLocal(@b, loc2)
            e: SetLocal(@a, loc1)
            f: SetLocal(@b, loc2)

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * Target.pri:
        * bytecode/CodeOrigin.h:
        * bytecode/ValueRecovery.cpp: Added.
        (JSC::ValueRecovery::recover):
        (JSC::ValueRecovery::dumpInContext):
        (JSC::ValueRecovery::dump):
        * bytecode/ValueRecovery.h:
        * dfg/DFGFixupPhase.cpp:
        (JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
        (JSC::DFG::FixupPhase::fixEdge):
        * dfg/DFGJITCode.cpp:
        (JSC::DFG::JITCode::reconstruct):
        * dfg/DFGNode.h:
        (JSC::DFG::Node::speculationDirection):
        (JSC::DFG::Node::setSpeculationDirection):
        * dfg/DFGOSREntrypointCreationPhase.cpp:
        (JSC::DFG::OSREntrypointCreationPhase::run):
        * dfg/DFGOSRExitCompiler32_64.cpp:
        (JSC::DFG::OSRExitCompiler::compileExit):
        * dfg/DFGOSRExitCompiler64.cpp:
        (JSC::DFG::OSRExitCompiler::compileExit):
        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::SpeculativeJIT::compileInlineStart):
        (JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
        * dfg/DFGSpeculativeJIT.h:
        (JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
        * dfg/DFGValueSource.h:
        (JSC::DFG::ValueSource::valueRecovery):
        * dfg/DFGVariableEventStream.cpp:
        (JSC::DFG::VariableEventStream::reconstruct):
        * ftl/FTLLowerDFGToLLVM.cpp:
        (JSC::FTL::LowerDFGToLLVM::speculate):
        (JSC::FTL::LowerDFGToLLVM::speculateMachineInt):
        * interpreter/Register.h:
        (JSC::Register::unboxedStrictInt52):
        * runtime/Arguments.cpp:
        (JSC::Arguments::tearOff):
        * runtime/Arguments.h:

186 187 188 189 190 191 192 193 194 195
2013-09-30  Alex Christensen  <alex.christensen@flexsim.com>

        Win64 compile fix after r1256490.
        https://bugs.webkit.org/show_bug.cgi?id=122117

        Reviewed by Michael Saboff.

        * jit/JITStubsMSVC64.asm:
        Implemented getHostCallReturnValue for Windows x86_64 processors.

196 197 198 199 200 201 202 203 204 205 206 207 208
2013-09-30  Andreas Kling  <akling@apple.com>

        Pass VM instead of JSGlobalObject to RegExp constructor.
        <https://webkit.org/b/122113>

        Reviewed by Darin Adler.

        RegExps don't need anything from the global object during their
        construction and only use it to get to the VM. Reduce loads by
        simply passing the VM around instead.

        JSC release binary size -= 120 bytes(!)

209 210 211 212 213 214 215 216 217 218 219 220
2013-09-30  Patrick Gansterer  <paroga@webkit.org>

        Fix compilation for COMPILER(MSVC) && !CPU(X86) after r156490.
        https://bugs.webkit.org/show_bug.cgi?id=122102

        Reviewed by Geoffrey Garen.

        _AddressOfReturnAddress() is supported for all platforms of
        ths Microsoft compiler, so we can use it for !CPU(X86) too.

        * jit/JITOperationWrappers.h:

221 222 223 224 225 226 227
2013-09-30  Gabor Rapcsanyi  <rgabor@webkit.org>

        Unreviewed. Build fix for DEBUG_VERBOSE mode after r156511.

        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::SpeculativeJIT::compileCurrentBlock):

228 229 230 231 232 233 234
2013-09-30  Gabor Rapcsanyi  <rgabor@webkit.org>

        Unreviewed. Speculative build fix on ARMv7 Thumb2 after r156490.

        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::fmodAsDFGOperation):

235 236 237 238 239 240 241 242 243 244 245
2013-09-29  Nadav Rotem  <nrotem@apple.com>

        FTL: refactor compileAdd and compileArithSub into one function.
        https://bugs.webkit.org/show_bug.cgi?id=122081

        Reviewed by Geoffrey Garen.

        * ftl/FTLLowerDFGToLLVM.cpp:
        (JSC::FTL::LowerDFGToLLVM::compileNode):
        (JSC::FTL::LowerDFGToLLVM::compileAddSub):

246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261
2013-09-29  Andreas Kling  <akling@apple.com>

        Pass VM instead of JSGlobalObject to function constructors.
        <https://webkit.org/b/122082>

        Reviewed by Darin Adler.

        Functions don't need anything from the global object during their
        construction and only use it to get to the VM. Reduce loads by
        simply passing the VM around instead.

        This patch is mostly mechanical, I just changed the signature of
        InternalFunction and worked my way from there until it built.

        JSC release binary size -= 4840 bytes.

262 263 264 265 266 267 268 269 270 271
2013-09-29  Andreas Kling  <akling@apple.com>

        Pass VM instead of JSGlobalObject to ArrayPrototype constructor.
        <https://webkit.org/b/122079>

        Reviewed by Geoffrey Garen.

        ArrayPrototype doesn't need the global object for anything during
        construction, so reduce the amount of loads by just passing the VM.

272 273 274 275 276 277 278 279 280 281 282
2013-09-29  Andreas Kling  <akling@apple.com>

        Pass VM instead of ExecState to simple builtin constructors.
        <https://webkit.org/b/122077>

        Reviewed by Sam Weinig.

        None of the simple builtins need the ExecState for anything during
        their construction, so reduce the amount of loads by just passing
        the VM around instead.

283 284 285 286 287 288 289 290 291 292 293 294
2013-09-29  Nadav Rotem  <nrotem@apple.com>

        Refactor code for finding x86 scratch register.
        https://bugs.webkit.org/show_bug.cgi?id=122072

        Reviewed by Geoffrey Garen.

        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::getUnusedRegister):
        (JSC::MacroAssemblerX86Common::store8):
        (JSC::MacroAssemblerX86Common::store16):

295 296 297 298 299 300 301 302 303
2013-09-28  Mark Rowe  <mrowe@apple.com>

        Take Xcode's advice and enable some extra warnings.

        Reviewed by Sam Weinig.

        * Configurations/Base.xcconfig:
        * JavaScriptCore.xcodeproj/project.pbxproj:

304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320
2013-09-28  Andreas Kling  <akling@apple.com>

        Pass VM instead of ExecState to JSFunction constructors.
        <https://webkit.org/b/122014>

        Reviewed by Geoffrey Garen.

        JSFunction doesn't need the ExecState for anything during its
        construction, so reduce the amount of loads by just passing the
        VM around instead.

        Factored out putDirectNonIndexAccessor() from the existing
        putDirectAccessor() to avoid snowballing the patch (and because
        it's kinda neat to avoid the extra branch.)

        JSC release binary size -= 9680 bytes.

321 322 323 324 325 326 327 328 329 330 331 332
2013-09-28  Mark Rowe  <mrowe@apple.com>

        JavaScriptCore fails to build with newer versions of clang.

        Reviewed by Sam Weinig.

        * interpreter/Interpreter.cpp: Remove an unused function.
        * parser/SourceProvider.cpp: Ditto.
        * runtime/GCActivityCallback.cpp: #if a constant that's only used on non-CF platforms.
        * runtime/JSCJSValue.cpp: Remove an unused constant.
        * runtime/JSString.cpp: Ditto.

333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383
2013-09-27  Filip Pizlo  <fpizlo@apple.com>

        Get rid of SetMyScope/SetCallee; use normal variables for the scope and callee of inlined call frames of closures
        https://bugs.webkit.org/show_bug.cgi?id=122047

        Reviewed by Oliver Hunt.
        
        Currently we have the DFG reserve space for inline call frames at exactly the same stack
        offsets that you would have gotten if the baseline interpreter/JIT had made the calls.
        We need to get rid of that. One of the weirder parts of this is that we have special DFG
        operations for accessing these inlined call frame headers. It's really hard for any
        analysis of DFG IR to see what the liveness of any of those frame header "variables" is;
        the liveness behaves like flushed arguments (it's all live until end of the inlinee) but
        we don't have anything like a Flush node for those special variables.
        
        This patch gets rid of the special operations for accessing inline call frame headers.
        GetMyScope and GetCallee still remain, and are only for accessing the machine call
        frame's scope/callee entries. The inline call frame's scope/callee now behave like
        normal variables, and have Flush behavior just like inline arguments.

        * dfg/DFGAbstractInterpreterInlines.h:
        (JSC::DFG::::executeEffects):
        * dfg/DFGByteCodeParser.cpp:
        (JSC::DFG::ByteCodeParser::getDirect):
        (JSC::DFG::ByteCodeParser::get):
        (JSC::DFG::ByteCodeParser::setDirect):
        (JSC::DFG::ByteCodeParser::set):
        (JSC::DFG::ByteCodeParser::setLocal):
        (JSC::DFG::ByteCodeParser::setArgument):
        (JSC::DFG::ByteCodeParser::flush):
        (JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
        (JSC::DFG::ByteCodeParser::handleInlining):
        (JSC::DFG::ByteCodeParser::getScope):
        * dfg/DFGCSEPhase.cpp:
        (JSC::DFG::CSEPhase::getCalleeLoadElimination):
        (JSC::DFG::CSEPhase::getMyScopeLoadElimination):
        (JSC::DFG::CSEPhase::performNodeCSE):
        * dfg/DFGClobberize.h:
        (JSC::DFG::clobberize):
        * dfg/DFGFixupPhase.cpp:
        (JSC::DFG::FixupPhase::fixupNode):
        * dfg/DFGNodeType.h:
        * dfg/DFGPredictionPropagationPhase.cpp:
        (JSC::DFG::PredictionPropagationPhase::propagate):
        * dfg/DFGSafeToExecute.h:
        (JSC::DFG::safeToExecute):
        * dfg/DFGSpeculativeJIT32_64.cpp:
        (JSC::DFG::SpeculativeJIT::compile):
        * dfg/DFGSpeculativeJIT64.cpp:
        (JSC::DFG::SpeculativeJIT::compile):

384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403
2013-09-27  Filip Pizlo  <fpizlo@apple.com>

        Deoptimize 32-bit deoptimization
        https://bugs.webkit.org/show_bug.cgi?id=122025

        Reviewed by Oliver Hunt.
        
        Just simplifying a bunch of code. I don't want the old, super-complicated,
        deoptimization code to get in the way of changes I'll be making to DFG stack layout.

        * bytecode/ValueRecovery.h:
        (JSC::ValueRecovery::inGPR):
        (JSC::ValueRecovery::isInRegisters):
        (JSC::ValueRecovery::gpr):
        (JSC::ValueRecovery::dumpInContext):
        * dfg/DFGOSRExitCompiler32_64.cpp:
        (JSC::DFG::OSRExitCompiler::compileExit):
        * dfg/DFGOSRExitCompiler64.cpp:
        (JSC::DFG::OSRExitCompiler::compileExit):

404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420
2013-09-27  Alex Christensen  <alex.christensen@flexsim.com>

        Fixed Win64 build after r156184.
        https://bugs.webkit.org/show_bug.cgi?id=121994

        Reviewed by Oliver Hunt.

        * jit/CCallHelpers.h:
        (JSC::CCallHelpers::setupTwoStubArgsGPR):
        (JSC::CCallHelpers::setupTwoStubArgsFPR):
        Renamed from setupTwoStubArgs.
        Visual Studio x64 compiler fails to see that this is an overloaded template function.
        (JSC::CCallHelpers::setupStubArguments):
        (JSC::CCallHelpers::setupArguments):
        (JSC::CCallHelpers::setupArgumentsWithExecState):
        Use setupTwoStubArgsGPR or setupTwoStubArgsFPR instead of setupTwoStubArgs.

421 422 423 424 425 426 427 428 429 430 431
2013-09-27  Gabor Rapcsanyi  <rgabor@webkit.org>

        LLInt alignment problem on ARM in debug mode
        https://bugs.webkit.org/show_bug.cgi?id=122012

        Reviewed by Michael Saboff.

        Force GCC to put the LLInt code to .text section.

        * llint/LowLevelInterpreter.cpp:

432 433 434 435 436 437 438 439 440 441 442
2013-09-06  Jer Noble  <jer.noble@apple.com>

        [Mac] Implement the media controls in JavaScript.
        https://bugs.webkit.org/show_bug.cgi?id=120895

        Reviewed by Dean Jackson.

        Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.

        * Configurations/FeatureDefines.xcconfig:

443 444 445 446 447 448 449 450 451 452
2013-09-27  Andreas Kling  <akling@apple.com>

        Pass VM instead of ExecState to JSDateMath functions.
        <https://webkit.org/b/121997>

        Reviewed by Geoffrey Garen.

        The JSC date math functions only need the VM, so pass that from
        callers instead of the whole ExecState.

453 454 455 456 457 458 459 460 461 462 463 464
2013-09-26  Andreas Kling  <akling@apple.com>

        GetterSetter construction should take a VM instead of ExecState.
        <https://webkit.org/b/121993>

        Reviewed by Sam Weinig.

        Pass VM& instead of ExecState* to GetterSetter. Updated surrounding
        code at touched sites to cache VM in a local for fewer loads.

        JSC release binary size -= 4120 bytes.

oliver@apple.com's avatar
oliver@apple.com committed
465 466 467 468 469 470
2013-09-26  Oliver Hunt  <oliver@apple.com>

        Make GCC happy

        * parser/Parser.h:

471 472 473 474 475 476 477 478 479
2013-09-25  Oliver Hunt  <oliver@apple.com>

        Implement prefixed-destructuring assignment
        https://bugs.webkit.org/show_bug.cgi?id=121930

        Reviewed by Mark Hahnenberg.

        Relanding with fix after rollout

480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563
2013-09-26  Michael Saboff  <msaboff@apple.com>

        VirtualRegister should be a class
        https://bugs.webkit.org/show_bug.cgi?id=121732

        Reviewed by Geoffrey Garen.

        This is a refactoring change.  Changed VirtualRegister from an enum to a class.
        Moved Operands::operandIsArgument(), operandToArgument(), argumentToOperand()
        and the similar functions for locals to VirtualRegister class.

        This is in preparation for changing the offset for the first local register from
        0 to -1.  This is needed since most native calling conventions have the architected
        frame pointer (e.g. %rbp for X86) point at the slot that stores the previous frame
        pointer.  Local values start below that address.

        * bytecode/CodeBlock.cpp:
        * bytecode/CodeBlock.h:
        * bytecode/Instruction.h:
        * bytecode/LazyOperandValueProfile.h:
        * bytecode/MethodOfGettingAValueProfile.cpp:
        * bytecode/Operands.h:
        * bytecode/UnlinkedCodeBlock.cpp:
        * bytecode/UnlinkedCodeBlock.h:
        * bytecode/ValueRecovery.h:
        * bytecode/VirtualRegister.h:
        * bytecompiler/BytecodeGenerator.cpp:
        * bytecompiler/BytecodeGenerator.h:
        * bytecompiler/RegisterID.h:
        * debugger/DebuggerCallFrame.cpp:
        * dfg/DFGAbstractHeap.h:
        * dfg/DFGAbstractInterpreterInlines.h:
        * dfg/DFGArgumentPosition.h:
        * dfg/DFGArgumentsSimplificationPhase.cpp:
        * dfg/DFGByteCodeParser.cpp:
        * dfg/DFGCFGSimplificationPhase.cpp:
        * dfg/DFGCPSRethreadingPhase.cpp:
        * dfg/DFGCapabilities.cpp:
        * dfg/DFGConstantFoldingPhase.cpp:
        * dfg/DFGFlushLivenessAnalysisPhase.cpp:
        * dfg/DFGGraph.cpp:
        * dfg/DFGGraph.h:
        * dfg/DFGJITCode.cpp:
        * dfg/DFGNode.h:
        * dfg/DFGOSREntry.cpp:
        * dfg/DFGOSREntrypointCreationPhase.cpp:
        * dfg/DFGOSRExit.h:
        * dfg/DFGOSRExitCompiler32_64.cpp:
        * dfg/DFGOSRExitCompiler64.cpp:
        * dfg/DFGRegisterBank.h:
        * dfg/DFGScoreBoard.h:
        * dfg/DFGSpeculativeJIT.cpp:
        * dfg/DFGSpeculativeJIT.h:
        * dfg/DFGSpeculativeJIT32_64.cpp:
        * dfg/DFGSpeculativeJIT64.cpp:
        * dfg/DFGValidate.cpp:
        * dfg/DFGValueRecoveryOverride.h:
        * dfg/DFGVariableAccessData.h:
        * dfg/DFGVariableEvent.h:
        * dfg/DFGVariableEventStream.cpp:
        * dfg/DFGVirtualRegisterAllocationPhase.cpp:
        * ftl/FTLExitArgumentForOperand.h:
        * ftl/FTLLink.cpp:
        * ftl/FTLLowerDFGToLLVM.cpp:
        * ftl/FTLOSREntry.cpp:
        * ftl/FTLOSRExit.cpp:
        * ftl/FTLOSRExit.h:
        * ftl/FTLOSRExitCompiler.cpp:
        * interpreter/CallFrame.h:
        * interpreter/Interpreter.cpp:
        * jit/AssemblyHelpers.h:
        * jit/JIT.h:
        * jit/JITCall.cpp:
        * jit/JITCall32_64.cpp:
        * jit/JITInlines.h:
        * jit/JITOpcodes.cpp:
        * jit/JITOpcodes32_64.cpp:
        * jit/JITPropertyAccess32_64.cpp:
        * jit/JITStubs.cpp:
        * llint/LLIntSlowPaths.cpp:
        * profiler/ProfilerBytecodeSequence.cpp:
        * runtime/CommonSlowPaths.cpp:
        * runtime/JSActivation.cpp:

564 565 566 567 568 569 570
2013-09-26  Anders Carlsson  <andersca@apple.com>

        Work around another MSVC bug.

        * runtime/PrototypeMap.cpp:
        (JSC::PrototypeMap::emptyObjectStructureForPrototype):

571 572 573 574 575 576 577
2013-09-26  Anders Carlsson  <andersca@apple.com>

        Attempt to fix the FTL build.

        * ftl/FTLAbstractHeap.cpp:
        (JSC::FTL::IndexedAbstractHeap::atSlow):

578 579 580 581 582 583 584 585 586 587 588 589 590
2013-09-26  Andreas Kling  <akling@apple.com>

        Pass VM instead of ExecState to many finishCreation() functions.
        <https://webkit.org/b/121975>

        Reviewed by Sam Weinig.

        Reduce unnecessary loads by passing the VM to object creation
        functions that don't need the ExecState.

        There are tons of opportunities in this area, I'm just scratching
        the surface.

591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642
2013-09-26  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r156464 and r156480.
        http://trac.webkit.org/changeset/156464
        http://trac.webkit.org/changeset/156480
        https://bugs.webkit.org/show_bug.cgi?id=121981

        Leaking too much and killing buildbot. (Requested by xenon on
        #webkit).

        * bytecode/UnlinkedCodeBlock.cpp:
        (JSC::UnlinkedFunctionExecutable::paramString):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::BytecodeGenerator):
        * bytecompiler/BytecodeGenerator.h:
        (JSC::BytecodeGenerator::emitExpressionInfo):
        * bytecompiler/NodesCodegen.cpp:
        (JSC::ForInNode::emitBytecode):
        (JSC::FuncExprNode::emitBytecode):
        * parser/ASTBuilder.h:
        (JSC::ASTBuilder::createFormalParameterList):
        (JSC::ASTBuilder::createForInLoop):
        (JSC::ASTBuilder::addVar):
        * parser/NodeConstructors.h:
        (JSC::CommaNode::CommaNode):
        (JSC::ParameterNode::ParameterNode):
        (JSC::ForInNode::ForInNode):
        * parser/Nodes.cpp:
        (JSC::FunctionParameters::create):
        (JSC::FunctionParameters::FunctionParameters):
        (JSC::FunctionParameters::~FunctionParameters):
        * parser/Nodes.h:
        (JSC::CommaNode::append):
        (JSC::ParameterNode::ident):
        (JSC::FunctionParameters::at):
        (JSC::FunctionParameters::identifiers):
        * parser/Parser.cpp:
        (JSC::::Parser):
        (JSC::::parseVarDeclaration):
        (JSC::::parseVarDeclarationList):
        (JSC::::parseForStatement):
        (JSC::::parseFormalParameters):
        (JSC::::parseAssignmentExpression):
        * parser/Parser.h:
        (JSC::Scope::declareParameter):
        * parser/SyntaxChecker.h:
        (JSC::SyntaxChecker::createFormalParameterList):
        (JSC::SyntaxChecker::createForInLoop):
        (JSC::SyntaxChecker::operatorStackPop):
        * runtime/JSONObject.cpp:
        * runtime/JSONObject.h:

643 644 645 646 647 648 649 650
2013-09-26  Anders Carlsson  <andersca@apple.com>

        Try to fix the Windows build.

        * jit/JITThunks.cpp:
        (JSC::JITThunks::hostFunctionStub):
        * jit/JITThunks.h:

651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676
2013-09-26  Anders Carlsson  <andersca@apple.com>

        Change a couple of HashMap value types from OwnPtr to std::unique_ptr
        https://bugs.webkit.org/show_bug.cgi?id=121973

        Reviewed by Andreas Kling.

        * API/JSClassRef.cpp:
        (OpaqueJSClassContextData::OpaqueJSClassContextData):
        (OpaqueJSClass::contextData):
        * API/JSClassRef.h:
        * bytecode/SamplingTool.h:
        * ftl/FTLAbstractHeap.h:
        * parser/Parser.cpp:
        (JSC::::parseFunctionInfo):
        * parser/SourceProviderCache.cpp:
        (JSC::SourceProviderCache::add):
        * parser/SourceProviderCache.h:
        * parser/SourceProviderCacheItem.h:
        (JSC::SourceProviderCacheItem::create):
        * profiler/ProfilerCompilation.cpp:
        (JSC::Profiler::Compilation::executionCounterFor):
        (JSC::Profiler::Compilation::toJS):
        * profiler/ProfilerCompilation.h:
        * runtime/JSGlobalObject.h:

677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777
2013-09-26  Mark Lam  <mark.lam@apple.com>

        Move DFG inline caching logic into jit/.
        https://bugs.webkit.org/show_bug.cgi?id=121749.

        Reviewed by Geoffrey Garen.

        Relanding http://trac.webkit.org/changeset/156235 after rebasing to latest
        revision and fixing build breakages on Windows.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * Target.pri:
        * bytecode/CallLinkInfo.cpp:
        (JSC::CallLinkInfo::unlink):
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::resetStubInternal):
        * bytecode/StructureStubInfo.h:
        * dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
        (JSC::DFG::CallArrayAllocatorSlowPathGenerator::CallArrayAllocatorSlowPathGenerator):
        (JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):
        * dfg/DFGJITCompiler.h:
        * dfg/DFGOSRExitCompiler.h:
        * dfg/DFGOperations.cpp:
        (JSC::DFG::operationPutByValInternal):
        * dfg/DFGOperations.h:
        (JSC::DFG::operationNewTypedArrayWithSizeForType):
        (JSC::DFG::operationNewTypedArrayWithOneArgumentForType):
        * dfg/DFGRegisterSet.h: Removed.
        * dfg/DFGRepatch.cpp: Removed.
        * dfg/DFGRepatch.h: Removed.
        * dfg/DFGScratchRegisterAllocator.h: Removed.
        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
        (JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
        (JSC::DFG::SpeculativeJIT::compare):
        * dfg/DFGSpeculativeJIT.h:
        (JSC::DFG::SpeculativeJIT::callOperation):
        * dfg/DFGSpeculativeJIT32_64.cpp:
        (JSC::DFG::SpeculativeJIT::cachedPutById):
        (JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
        (JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
        (JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
        (JSC::DFG::SpeculativeJIT::compile):
        * dfg/DFGSpeculativeJIT64.cpp:
        (JSC::DFG::SpeculativeJIT::cachedPutById):
        (JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
        (JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
        (JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
        (JSC::DFG::SpeculativeJIT::compile):
        * dfg/DFGThunks.cpp:
        * dfg/DFGThunks.h:
        * ftl/FTLIntrinsicRepository.h:
        * ftl/FTLLowerDFGToLLVM.cpp:
        (JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
        * ftl/FTLOSRExitCompiler.h:
        * jit/AssemblyHelpers.h:
        (JSC::AssemblyHelpers::writeBarrier):
        * jit/JIT.cpp:
        (JSC::JIT::linkFor):
        (JSC::JIT::linkSlowCall):
        * jit/JITCall.cpp:
        (JSC::JIT::compileCallEvalSlowCase):
        (JSC::JIT::compileOpCallSlowCase):
        (JSC::JIT::privateCompileClosureCall):
        * jit/JITCall32_64.cpp:
        (JSC::JIT::compileCallEvalSlowCase):
        (JSC::JIT::compileOpCallSlowCase):
        (JSC::JIT::privateCompileClosureCall):
        * jit/JITOperationWrappers.h: Copied from Source/JavaScriptCore/jit/JITOperationWrappers.h.
        * jit/JITOperations.cpp: Copied from Source/JavaScriptCore/jit/JITOperations.cpp.
        (JSC::getHostCallReturnValueWithExecState):
        * jit/JITOperations.h: Copied from Source/JavaScriptCore/jit/JITOperations.h.
        * jit/RegisterSet.h: Copied from Source/JavaScriptCore/jit/RegisterSet.h.
        * jit/Repatch.cpp: Copied from Source/JavaScriptCore/jit/Repatch.cpp.
        (JSC::tryBuildGetByIDList):
        * jit/Repatch.h: Copied from Source/JavaScriptCore/jit/Repatch.h.
        * jit/ScratchRegisterAllocator.h: Copied from Source/JavaScriptCore/jit/ScratchRegisterAllocator.h.
        * jit/ThunkGenerators.cpp:
        (JSC::oldStyleGenerateSlowCaseFor):
        (JSC::oldStyleLinkForGenerator):
        (JSC::oldStyleLinkCallGenerator):
        (JSC::oldStyleLinkConstructGenerator):
        (JSC::oldStyleLinkClosureCallGenerator):
        (JSC::oldStyleVirtualForGenerator):
        (JSC::oldStyleVirtualCallGenerator):
        (JSC::oldStyleVirtualConstructGenerator):
        (JSC::emitPointerValidation):
        (JSC::throwExceptionFromCallSlowPathGenerator):
        (JSC::slowPathFor):
        (JSC::linkForThunkGenerator):
        (JSC::linkCallThunkGenerator):
        (JSC::linkConstructThunkGenerator):
        (JSC::linkClosureCallThunkGenerator):
        (JSC::virtualForThunkGenerator):
        (JSC::virtualCallThunkGenerator):
        (JSC::virtualConstructThunkGenerator):
        * jit/ThunkGenerators.h:

andersca@apple.com's avatar
andersca@apple.com committed
778 779 780 781 782 783 784 785 786 787 788 789 790 791
2013-09-26  Anders Carlsson  <andersca@apple.com>

        Remove PassWeak.h
        https://bugs.webkit.org/show_bug.cgi?id=121971

        Reviewed by Geoffrey Garen.

        * GNUmakefile.list.am:
        * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
        * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * heap/PassWeak.h: Removed.
        * heap/WeakInlines.h:

andersca@apple.com's avatar
andersca@apple.com committed
792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824
2013-09-26  Anders Carlsson  <andersca@apple.com>

        Stop using PassWeak
        https://bugs.webkit.org/show_bug.cgi?id=121968

        Reviewed by Sam Weinig.

        * heap/Weak.h:
        Remove all knowledge of PassWeak.

        (JSC::Weak::Weak):
        These constructors don't need to be explicit.

        * heap/WeakInlines.h:
        (JSC::weakAdd):
        Change Value to be an rvalue reference and use std::forward.

        * jit/JITThunks.cpp:
        (JSC::JITThunks::hostFunctionStub):
        Remove PassWeak.

        * runtime/RegExpCache.cpp:
        (JSC::RegExpCache::lookupOrCreate):
        Use Weak instead of PassWeak.

        * runtime/SimpleTypedArrayController.cpp:
        Change add and set to take Weak by value and std::move into place.

        * runtime/WeakGCMap.h:
        (JSC::WeakGCMap::get):
        (JSC::WeakGCMap::set):
        (JSC::WeakGCMap::add):

825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099
2013-09-26  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r156474.
        http://trac.webkit.org/changeset/156474
        https://bugs.webkit.org/show_bug.cgi?id=121966

        Broke the builds. (Requested by xenon on #webkit).

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::registerName):
        (JSC::CodeBlock::dumpBytecode):
        (JSC::CodeBlock::CodeBlock):
        (JSC::CodeBlock::createActivation):
        (JSC::CodeBlock::nameForRegister):
        * bytecode/CodeBlock.h:
        (JSC::unmodifiedArgumentsRegister):
        (JSC::CodeBlock::isKnownNotImmediate):
        (JSC::CodeBlock::setThisRegister):
        (JSC::CodeBlock::thisRegister):
        (JSC::CodeBlock::setArgumentsRegister):
        (JSC::CodeBlock::argumentsRegister):
        (JSC::CodeBlock::uncheckedArgumentsRegister):
        (JSC::CodeBlock::setActivationRegister):
        (JSC::CodeBlock::activationRegister):
        (JSC::CodeBlock::uncheckedActivationRegister):
        (JSC::CodeBlock::usesArguments):
        (JSC::CodeBlock::isCaptured):
        * bytecode/Instruction.h:
        * bytecode/LazyOperandValueProfile.h:
        (JSC::LazyOperandValueProfileKey::LazyOperandValueProfileKey):
        (JSC::LazyOperandValueProfileKey::operator!):
        (JSC::LazyOperandValueProfileKey::hash):
        (JSC::LazyOperandValueProfileKey::operand):
        (JSC::LazyOperandValueProfileKey::isHashTableDeletedValue):
        (JSC::LazyOperandValueProfile::LazyOperandValueProfile):
        * bytecode/MethodOfGettingAValueProfile.cpp:
        (JSC::MethodOfGettingAValueProfile::fromLazyOperand):
        (JSC::MethodOfGettingAValueProfile::getSpecFailBucket):
        * bytecode/Operands.h:
        (JSC::localToOperand):
        (JSC::operandIsLocal):
        (JSC::operandToLocal):
        (JSC::operandIsArgument):
        (JSC::operandToArgument):
        (JSC::argumentToOperand):
        (JSC::Operands::operand):
        (JSC::Operands::hasOperand):
        (JSC::Operands::setOperand):
        (JSC::Operands::operandForIndex):
        (JSC::Operands::setOperandFirstTime):
        * bytecode/UnlinkedCodeBlock.cpp:
        (JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
        * bytecode/UnlinkedCodeBlock.h:
        (JSC::UnlinkedCodeBlock::setThisRegister):
        (JSC::UnlinkedCodeBlock::setActivationRegister):
        (JSC::UnlinkedCodeBlock::setArgumentsRegister):
        (JSC::UnlinkedCodeBlock::usesArguments):
        (JSC::UnlinkedCodeBlock::argumentsRegister):
        (JSC::UnlinkedCodeBlock::usesGlobalObject):
        (JSC::UnlinkedCodeBlock::setGlobalObjectRegister):
        (JSC::UnlinkedCodeBlock::globalObjectRegister):
        (JSC::UnlinkedCodeBlock::thisRegister):
        (JSC::UnlinkedCodeBlock::activationRegister):
        * bytecode/ValueRecovery.h:
        (JSC::ValueRecovery::displacedInJSStack):
        (JSC::ValueRecovery::virtualRegister):
        (JSC::ValueRecovery::dumpInContext):
        * bytecode/VirtualRegister.h:
        (WTF::printInternal):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::generate):
        (JSC::BytecodeGenerator::addVar):
        (JSC::BytecodeGenerator::BytecodeGenerator):
        (JSC::BytecodeGenerator::createLazyRegisterIfNecessary):
        (JSC::BytecodeGenerator::newRegister):
        (JSC::BytecodeGenerator::emitLoadGlobalObject):
        (JSC::BytecodeGenerator::emitGetArgumentsLength):
        (JSC::BytecodeGenerator::emitGetArgumentByVal):
        (JSC::BytecodeGenerator::createArgumentsIfNecessary):
        (JSC::BytecodeGenerator::emitReturn):
        * bytecompiler/BytecodeGenerator.h:
        (JSC::BytecodeGenerator::registerFor):
        * bytecompiler/RegisterID.h:
        (JSC::RegisterID::RegisterID):
        (JSC::RegisterID::setIndex):
        (JSC::RegisterID::index):
        * debugger/DebuggerCallFrame.cpp:
        (JSC::DebuggerCallFrame::thisObject):
        * dfg/DFGAbstractHeap.h:
        (JSC::DFG::AbstractHeap::Payload::Payload):
        * dfg/DFGAbstractInterpreterInlines.h:
        (JSC::DFG::::executeEffects):
        (JSC::DFG::::clobberCapturedVars):
        * dfg/DFGArgumentPosition.h:
        (JSC::DFG::ArgumentPosition::dump):
        * dfg/DFGArgumentsSimplificationPhase.cpp:
        (JSC::DFG::ArgumentsSimplificationPhase::run):
        (JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
        (JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):
        * dfg/DFGByteCodeParser.cpp:
        (JSC::DFG::ByteCodeParser::newVariableAccessData):
        (JSC::DFG::ByteCodeParser::getDirect):
        (JSC::DFG::ByteCodeParser::get):
        (JSC::DFG::ByteCodeParser::setDirect):
        (JSC::DFG::ByteCodeParser::set):
        (JSC::DFG::ByteCodeParser::getLocal):
        (JSC::DFG::ByteCodeParser::setLocal):
        (JSC::DFG::ByteCodeParser::getArgument):
        (JSC::DFG::ByteCodeParser::setArgument):
        (JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
        (JSC::DFG::ByteCodeParser::findArgumentPosition):
        (JSC::DFG::ByteCodeParser::flush):
        (JSC::DFG::ByteCodeParser::flushDirect):
        (JSC::DFG::ByteCodeParser::getToInt32):
        (JSC::DFG::ByteCodeParser::getThis):
        (JSC::DFG::ByteCodeParser::addCall):
        (JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
        (JSC::DFG::ByteCodeParser::handleCall):
        (JSC::DFG::ByteCodeParser::emitFunctionChecks):
        (JSC::DFG::ByteCodeParser::emitArgumentPhantoms):
        (JSC::DFG::ByteCodeParser::handleInlining):
        (JSC::DFG::ByteCodeParser::handleMinMax):
        (JSC::DFG::ByteCodeParser::handleIntrinsic):
        (JSC::DFG::ByteCodeParser::handleTypedArrayConstructor):
        (JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
        (JSC::DFG::ByteCodeParser::handleGetByOffset):
        (JSC::DFG::ByteCodeParser::handleGetById):
        (JSC::DFG::ByteCodeParser::parseBlock):
        (JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
        (JSC::DFG::ByteCodeParser::parse):
        * dfg/DFGCFGSimplificationPhase.cpp:
        * dfg/DFGCPSRethreadingPhase.cpp:
        (JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocal):
        (JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocal):
        (JSC::DFG::CPSRethreadingPhase::canonicalizeSetArgument):
        * dfg/DFGCapabilities.cpp:
        (JSC::DFG::capabilityLevel):
        * dfg/DFGConstantFoldingPhase.cpp:
        (JSC::DFG::ConstantFoldingPhase::isCapturedAtOrAfter):
        * dfg/DFGFlushLivenessAnalysisPhase.cpp:
        (JSC::DFG::FlushLivenessAnalysisPhase::setForNode):
        * dfg/DFGGraph.cpp:
        (JSC::DFG::Graph::dump):
        * dfg/DFGGraph.h:
        (JSC::DFG::Graph::argumentsRegisterFor):
        (JSC::DFG::Graph::uncheckedArgumentsRegisterFor):
        (JSC::DFG::Graph::uncheckedActivationRegisterFor):
        (JSC::DFG::Graph::valueProfileFor):
        * dfg/DFGJITCode.cpp:
        (JSC::DFG::JITCode::reconstruct):
        * dfg/DFGNode.h:
        (JSC::DFG::Node::Node):
        (JSC::DFG::Node::convertToGetLocalUnlinked):
        (JSC::DFG::Node::hasVirtualRegister):
        (JSC::DFG::Node::virtualRegister):
        (JSC::DFG::Node::setVirtualRegister):
        * dfg/DFGOSREntry.cpp:
        (JSC::DFG::prepareOSREntry):
        * dfg/DFGOSREntrypointCreationPhase.cpp:
        (JSC::DFG::OSREntrypointCreationPhase::run):
        * dfg/DFGOSRExit.h:
        * dfg/DFGOSRExitCompiler32_64.cpp:
        (JSC::DFG::OSRExitCompiler::compileExit):
        * dfg/DFGOSRExitCompiler64.cpp:
        (JSC::DFG::OSRExitCompiler::compileExit):
        * dfg/DFGRegisterBank.h:
        (JSC::DFG::RegisterBank::tryAllocate):
        (JSC::DFG::RegisterBank::allocateSpecific):
        (JSC::DFG::RegisterBank::retain):
        (JSC::DFG::RegisterBank::isInUse):
        (JSC::DFG::RegisterBank::dump):
        (JSC::DFG::RegisterBank::releaseAtIndex):
        (JSC::DFG::RegisterBank::allocateInternal):
        (JSC::DFG::RegisterBank::MapEntry::MapEntry):
        * dfg/DFGScoreBoard.h:
        (JSC::DFG::ScoreBoard::allocate):
        (JSC::DFG::ScoreBoard::use):
        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::SpeculativeJIT::SpeculativeJIT):
        (JSC::DFG::SpeculativeJIT::checkConsistency):
        (JSC::DFG::SpeculativeJIT::compileMovHint):
        (JSC::DFG::SpeculativeJIT::compileInlineStart):
        (JSC::DFG::SpeculativeJIT::compileCurrentBlock):
        * dfg/DFGSpeculativeJIT.h:
        (JSC::DFG::SpeculativeJIT::allocate):
        (JSC::DFG::SpeculativeJIT::fprAllocate):
        (JSC::DFG::SpeculativeJIT::silentSpillAllRegistersImpl):
        (JSC::DFG::SpeculativeJIT::flushRegisters):
        (JSC::DFG::SpeculativeJIT::isFlushed):
        (JSC::DFG::SpeculativeJIT::argumentSlot):
        (JSC::DFG::SpeculativeJIT::argumentTagSlot):
        (JSC::DFG::SpeculativeJIT::argumentPayloadSlot):
        (JSC::DFG::SpeculativeJIT::valueSourceForOperand):
        (JSC::DFG::SpeculativeJIT::setNodeForOperand):
        (JSC::DFG::SpeculativeJIT::valueSourceReferenceForOperand):
        (JSC::DFG::SpeculativeJIT::recordSetLocal):
        (JSC::DFG::SpeculativeJIT::generationInfoFromVirtualRegister):
        (JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
        * dfg/DFGSpeculativeJIT64.cpp:
        (JSC::DFG::SpeculativeJIT::compile):
        * dfg/DFGValidate.cpp:
        (JSC::DFG::Validate::validate):
        (JSC::DFG::Validate::validateCPS):
        (JSC::DFG::Validate::checkOperand):
        (JSC::DFG::Validate::reportValidationContext):
        * dfg/DFGValueRecoveryOverride.h:
        (JSC::DFG::ValueRecoveryOverride::ValueRecoveryOverride):
        * dfg/DFGVariableAccessData.h:
        (JSC::DFG::VariableAccessData::operand):
        (JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
        (JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):
        (JSC::DFG::VariableAccessData::flushFormat):
        * dfg/DFGVariableEvent.h:
        (JSC::DFG::VariableEvent::spill):
        (JSC::DFG::VariableEvent::setLocal):
        * dfg/DFGVariableEventStream.cpp:
        (JSC::DFG::VariableEventStream::reconstruct):
        * dfg/DFGVirtualRegisterAllocationPhase.cpp:
        (JSC::DFG::VirtualRegisterAllocationPhase::run):
        * ftl/FTLExitArgumentForOperand.h:
        (JSC::FTL::ExitArgumentForOperand::ExitArgumentForOperand):
        (JSC::FTL::ExitArgumentForOperand::operand):
        * ftl/FTLLink.cpp:
        (JSC::FTL::link):
        * ftl/FTLLowerDFGToLLVM.cpp:
        (JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
        (JSC::FTL::LowerDFGToLLVM::compileGetArgument):
        (JSC::FTL::LowerDFGToLLVM::compileExtractOSREntryLocal):
        (JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
        (JSC::FTL::LowerDFGToLLVM::appendOSRExit):
        (JSC::FTL::LowerDFGToLLVM::observeMovHint):
        (JSC::FTL::LowerDFGToLLVM::addressFor):
        (JSC::FTL::LowerDFGToLLVM::payloadFor):
        (JSC::FTL::LowerDFGToLLVM::tagFor):
        * ftl/FTLOSREntry.cpp:
        (JSC::FTL::prepareOSREntry):
        * ftl/FTLOSRExit.cpp:
        (JSC::FTL::OSRExit::convertToForward):
        * ftl/FTLOSRExit.h:
        * ftl/FTLOSRExitCompiler.cpp:
        (JSC::FTL::compileStub):
        * interpreter/CallFrame.h:
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::dumpRegisters):
        (JSC::unwindCallFrame):
        (JSC::Interpreter::unwind):
        * jit/AssemblyHelpers.h:
        (JSC::AssemblyHelpers::addressFor):
        (JSC::AssemblyHelpers::tagFor):
        (JSC::AssemblyHelpers::payloadFor):
        (JSC::AssemblyHelpers::argumentsRegisterFor):
        * jit/JIT.h:
        * jit/JITCall.cpp:
        (JSC::JIT::compileLoadVarargs):
        * jit/JITInlines.h:
        (JSC::JIT::emitGetVirtualRegister):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_tear_off_arguments):
        (JSC::JIT::emit_op_get_pnames):
        (JSC::JIT::emit_op_enter):
        (JSC::JIT::emit_op_create_arguments):
        (JSC::JIT::emitSlow_op_get_argument_by_val):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::emit_op_enter):
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):
        * llint/LLIntSlowPaths.cpp:
        (JSC::LLInt::LLINT_SLOW_PATH_DECL):
        * profiler/ProfilerBytecodeSequence.cpp:
        (JSC::Profiler::BytecodeSequence::BytecodeSequence):
        * runtime/CommonSlowPaths.cpp:
        (JSC::SLOW_PATH_DECL):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::argumentsGetter):

oliver@apple.com's avatar
oliver@apple.com committed
1100 1101 1102 1103 1104 1105 1106 1107 1108
2013-09-26  Oliver Hunt  <oliver@apple.com>

        Attempt to fix MSVC build

        * parser/Parser.cpp:
        (JSC::::createBindingPattern):
        (JSC::::parseDeconstructionPattern):
        * parser/Parser.h:

1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120
2013-09-26  Julien Brianceau  <jbriance@cisco.com>

        [sh4] JSValue* exception is unused since r70703 in JITStackFrame.
        https://bugs.webkit.org/show_bug.cgi?id=121962

        This is a cosmetic change, but it could avoid people reading sh4 part to
        waste time to understand why there is a JSValue* here.

        Reviewed by Darin Adler.

        * jit/JITStubs.h:

1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131
2013-09-26  Anders Carlsson  <andersca@apple.com>

        WeakGCMap should not inherit from HashMap
        https://bugs.webkit.org/show_bug.cgi?id=121964

        Reviewed by Geoffrey Garen.

        Add the HashMap as a member variable instead and implement the missing member functions.

        * runtime/WeakGCMap.h:

1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212
2013-09-25  Michael Saboff  <msaboff@apple.com>

        VirtualRegister should be a class
        https://bugs.webkit.org/show_bug.cgi?id=121732

        Reviewed by Geoffrey Garen.

        This is a refactoring change.  Changed VirtualRegister from an enum to a class.
        Moved Operands::operandIsArgument(), operandToArgument(), argumentToOperand()
        and the similar functions for locals to VirtualRegister class.

        This is in preparation for changing the offset for the first local register from
        0 to -1.  This is needed since most native calling conventions have the architected
        frame pointer (e.g. %rbp for X86) point at the slot that stores the previous frame
        pointer.  Local values start below that address.

        * bytecode/CodeBlock.cpp:
        * bytecode/CodeBlock.h:
        * bytecode/Instruction.h:
        * bytecode/LazyOperandValueProfile.h:
        * bytecode/MethodOfGettingAValueProfile.cpp:
        * bytecode/Operands.h:
        * bytecode/UnlinkedCodeBlock.cpp:
        * bytecode/UnlinkedCodeBlock.h:
        * bytecode/ValueRecovery.h:
        * bytecode/VirtualRegister.h:
        * bytecompiler/BytecodeGenerator.cpp:
        * bytecompiler/BytecodeGenerator.h:
        * bytecompiler/RegisterID.h:
        * debugger/DebuggerCallFrame.cpp:
        * dfg/DFGAbstractHeap.h:
        * dfg/DFGAbstractInterpreterInlines.h:
        * dfg/DFGArgumentPosition.h:
        * dfg/DFGArgumentsSimplificationPhase.cpp:
        * dfg/DFGByteCodeParser.cpp:
        * dfg/DFGCFGSimplificationPhase.cpp:
        * dfg/DFGCPSRethreadingPhase.cpp:
        * dfg/DFGCapabilities.cpp:
        * dfg/DFGConstantFoldingPhase.cpp:
        * dfg/DFGFlushLivenessAnalysisPhase.cpp:
        * dfg/DFGGraph.cpp:
        * dfg/DFGGraph.h:
        * dfg/DFGJITCode.cpp:
        * dfg/DFGNode.h:
        * dfg/DFGOSREntry.cpp:
        * dfg/DFGOSREntrypointCreationPhase.cpp:
        * dfg/DFGOSRExit.h:
        * dfg/DFGOSRExitCompiler32_64.cpp:
        * dfg/DFGOSRExitCompiler64.cpp:
        * dfg/DFGRegisterBank.h:
        * dfg/DFGScoreBoard.h:
        * dfg/DFGSpeculativeJIT.cpp:
        * dfg/DFGSpeculativeJIT.h:
        * dfg/DFGSpeculativeJIT64.cpp:
        * dfg/DFGValidate.cpp:
        * dfg/DFGValueRecoveryOverride.h:
        * dfg/DFGVariableAccessData.h:
        * dfg/DFGVariableEvent.h:
        * dfg/DFGVariableEventStream.cpp:
        * dfg/DFGVirtualRegisterAllocationPhase.cpp:
        * ftl/FTLExitArgumentForOperand.h:
        * ftl/FTLLink.cpp:
        * ftl/FTLLowerDFGToLLVM.cpp:
        * ftl/FTLOSREntry.cpp:
        * ftl/FTLOSRExit.cpp:
        * ftl/FTLOSRExit.h:
        * ftl/FTLOSRExitCompiler.cpp:
        * interpreter/CallFrame.h:
        * interpreter/Interpreter.cpp:
        * jit/AssemblyHelpers.h:
        * jit/JIT.h:
        * jit/JITCall.cpp:
        * jit/JITInlines.h:
        * jit/JITOpcodes.cpp:
        * jit/JITOpcodes32_64.cpp:
        * jit/JITStubs.cpp:
        * llint/LLIntSlowPaths.cpp:
        * profiler/ProfilerBytecodeSequence.cpp:
        * runtime/CommonSlowPaths.cpp:
        * runtime/JSActivation.cpp:

1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230
2013-09-26  Anders Carlsson  <andersca@apple.com>

        Weak should have a move constructor and move assignment operator
        https://bugs.webkit.org/show_bug.cgi?id=121963

        Reviewed by Oliver Hunt.

        This is the first step towards getting rid of PassWeak.

        * API/JSClassRef.cpp:
        (OpaqueJSClass::prototype):
        * heap/Weak.h:
        * heap/WeakInlines.h:
        (JSC::::Weak):
        (JSC::::leakImpl):
        * runtime/SimpleTypedArrayController.cpp:
        (JSC::SimpleTypedArrayController::toJS):

1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279
2013-09-26  Mark Hahnenberg  <mhahnenberg@apple.com>

        op_to_this shouldn't use value profiling
        https://bugs.webkit.org/show_bug.cgi?id=121920

        Reviewed by Geoffrey Garen.

        Currently it's the only opcode that uses m_singletonValue, which is unnecessary. Our current plan is 
        to remove m_singletonValue so that GenGC can have a simpler story for handling CodeBlocks/FunctionExecutables 
        during nursery collections.

        This patch adds an inline cache for the Structure of to_this so it no longer depends on the ValueProfile's
        m_singletonValue. Since nobody uses m_singletonValue now, this patch also removes m_singletonValue from
        ValueProfile.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::CodeBlock):
        (JSC::CodeBlock::finalizeUnconditionally):
        (JSC::CodeBlock::stronglyVisitStrongReferences):
        (JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
        (JSC::CodeBlock::updateAllValueProfilePredictions):
        (JSC::CodeBlock::updateAllPredictions):
        (JSC::CodeBlock::shouldOptimizeNow):
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::updateAllValueProfilePredictions):
        (JSC::CodeBlock::updateAllPredictions):
        * bytecode/LazyOperandValueProfile.cpp:
        (JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):
        * bytecode/LazyOperandValueProfile.h:
        * bytecode/ValueProfile.h:
        (JSC::ValueProfileBase::ValueProfileBase):
        (JSC::ValueProfileBase::briefDescription):
        (JSC::ValueProfileBase::dump):
        (JSC::ValueProfileBase::computeUpdatedPrediction):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::BytecodeGenerator):
        * dfg/DFGByteCodeParser.cpp:
        (JSC::DFG::ByteCodeParser::parseBlock):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_to_this):
        (JSC::JIT::emitSlow_op_to_this):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::emit_op_to_this):
        (JSC::JIT::emitSlow_op_to_this):
        * llint/LowLevelInterpreter32_64.asm:
        * llint/LowLevelInterpreter64.asm:
        * runtime/CommonSlowPaths.cpp:
        (JSC::SLOW_PATH_DECL):

1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379
2013-09-25  Oliver Hunt  <oliver@apple.com>

        Implement prefixed-destructuring assignment
        https://bugs.webkit.org/show_bug.cgi?id=121930

        Reviewed by Mark Hahnenberg.

        This is mostly simple - the semantics of deconstruction are already
        present in the language, so most of the complexity (if you call it
        that) is addition of new AST nodes, and parsing the syntax.

        In order to get correct semantics for the parameter lists, FunctionParameters
        now needs to store refcounted references to the parameter patterns.
        There's also a little work to ensure that variable creation and assignment
        occurs in the correct order while the BytecodeGenerator is being constructed. 

        * bytecode/UnlinkedCodeBlock.cpp:
        (JSC::UnlinkedFunctionExecutable::paramString):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::BytecodeGenerator):
        * bytecompiler/BytecodeGenerator.h:
        (JSC::BytecodeGenerator::emitExpressionInfo):
        * bytecompiler/NodesCodegen.cpp:
        (JSC::ForInNode::emitBytecode):
        (JSC::DeconstructingAssignmentNode::emitBytecode):
        (JSC::DeconstructionPatternNode::~DeconstructionPatternNode):
        (JSC::ArrayPatternNode::emitBytecode):
        (JSC::ArrayPatternNode::emitDirectBinding):
        (JSC::ArrayPatternNode::toString):
        (JSC::ArrayPatternNode::collectBoundIdentifiers):
        (JSC::ObjectPatternNode::toString):
        (JSC::ObjectPatternNode::emitBytecode):
        (JSC::ObjectPatternNode::collectBoundIdentifiers):
        (JSC::BindingNode::emitBytecode):
        (JSC::BindingNode::toString):
        (JSC::BindingNode::collectBoundIdentifiers):
        * parser/ASTBuilder.h:
        (JSC::ASTBuilder::createFormalParameterList):
        (JSC::ASTBuilder::createForInLoop):
        (JSC::ASTBuilder::addVar):
        (JSC::ASTBuilder::createDeconstructingAssignment):
        (JSC::ASTBuilder::createArrayPattern):
        (JSC::ASTBuilder::appendArrayPatternSkipEntry):
        (JSC::ASTBuilder::appendArrayPatternEntry):
        (JSC::ASTBuilder::createObjectPattern):
        (JSC::ASTBuilder::appendObjectPatternEntry):
        (JSC::ASTBuilder::createBindingLocation):
        * parser/NodeConstructors.h:
        (JSC::CommaNode::CommaNode):
        (JSC::ParameterNode::ParameterNode):
        (JSC::ForInNode::ForInNode):
        (JSC::DeconstructionPatternNode::DeconstructionPatternNode):
        (JSC::ArrayPatternNode::ArrayPatternNode):
        (JSC::ArrayPatternNode::create):
        (JSC::ObjectPatternNode::ObjectPatternNode):
        (JSC::ObjectPatternNode::create):
        (JSC::BindingNode::create):
        (JSC::BindingNode::BindingNode):
        (JSC::DeconstructingAssignmentNode::DeconstructingAssignmentNode):
        * parser/Nodes.cpp:
        (JSC::FunctionParameters::create):
        (JSC::FunctionParameters::FunctionParameters):
        (JSC::FunctionParameters::~FunctionParameters):
        * parser/Nodes.h:
        (JSC::ExpressionNode::isDeconstructionNode):
        (JSC::ArrayNode::elements):
        (JSC::CommaNode::append):
        (JSC::ParameterNode::pattern):
        (JSC::FunctionParameters::at):
        (JSC::FunctionParameters::patterns):
        (JSC::DeconstructionPatternNode::isBindingNode):
        (JSC::DeconstructionPatternNode::emitDirectBinding):
        (JSC::ArrayPatternNode::appendIndex):
        (JSC::ObjectPatternNode::appendEntry):
        (JSC::ObjectPatternNode::Entry::Entry):
        (JSC::BindingNode::boundProperty):
        (JSC::BindingNode::isBindingNode):
        (JSC::DeconstructingAssignmentNode::bindings):
        (JSC::DeconstructingAssignmentNode::isLocation):
        (JSC::DeconstructingAssignmentNode::isDeconstructionNode):
        * parser/Parser.cpp:
        (JSC::::Parser):
        (JSC::::parseVarDeclaration):
        (JSC::::parseVarDeclarationList):
        (JSC::::createBindingPattern):
        (JSC::::parseDeconstructionPattern):
        (JSC::::parseForStatement):
        (JSC::::parseFormalParameters):
        (JSC::::parseAssignmentExpression):
        * parser/Parser.h:
        (JSC::Scope::declareBoundParameter):
        (JSC::Parser::declareBoundParameter):
        * parser/SyntaxChecker.h:
        (JSC::SyntaxChecker::createFormalParameterList):
        (JSC::SyntaxChecker::addVar):
        (JSC::SyntaxChecker::operatorStackPop):
        * runtime/JSONObject.cpp:
        (JSC::escapeStringToBuilder):
        * runtime/JSONObject.h:

1380 1381 1382 1383 1384 1385 1386 1387 1388
2013-09-25  Brady Eidson  <beidson@apple.com>

        Enable the IndexedDB build on Mac, but leave the feature non-functional
        https://bugs.webkit.org/show_bug.cgi?id=121918

        Reviewed by Alexey Proskuryakov.

        * Configurations/FeatureDefines.xcconfig:

1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399
2013-09-25  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r156432.
        http://trac.webkit.org/changeset/156432
        https://bugs.webkit.org/show_bug.cgi?id=121932

        some integer conversion things that need brady to fix
        (Requested by thorton on #webkit).

        * Configurations/FeatureDefines.xcconfig:

1400 1401 1402 1403 1404 1405 1406 1407 1408
2013-09-25  Anders Carlsson  <andersca@apple.com>

        Move KeyValuePairTraits inside HashMap
        https://bugs.webkit.org/show_bug.cgi?id=121931

        Reviewed by Sam Weinig.

        * tools/ProfileTreeNode.h:

1409 1410 1411 1412 1413 1414 1415 1416 1417
2013-09-25  Brady Eidson  <beidson@apple.com>

        Enable the IndexedDB build on Mac, but leave the feature non-functional
        https://bugs.webkit.org/show_bug.cgi?id=121918

        Reviewed by Alexey Proskuryakov.

        * Configurations/FeatureDefines.xcconfig:

1418 1419 1420 1421 1422 1423 1424 1425 1426
2013-09-25  Brady Eidson  <beidson@apple.com>

        FeatureDefine.xcconfig cleanup (They should all be identical).
        https://bugs.webkit.org/show_bug.cgi?id=121921

        Reviewed by Mark Rowe.

        * Configurations/FeatureDefines.xcconfig:

1427 1428 1429 1430 1431 1432 1433 1434 1435
2013-09-25  Patrick Gansterer  <paroga@webkit.org>

        Build fix for WinCE after r155098.

        Windows CE does not support getenv().

        * jsc.cpp:
        (main):

1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471
2013-09-24  Mark Hahnenberg  <mhahnenberg@apple.com>

        op_get_callee shouldn't use value profiling
        https://bugs.webkit.org/show_bug.cgi?id=121821

        Reviewed by Filip Pizlo.

        Currently it's one of the two opcodes that uses m_singletonValue, which is unnecessary. 
        Our current plan is to remove m_singletonValue so that GenGC can have a simpler story 
        for handling CodeBlocks/FunctionExecutables during nursery collections.

        Instead of using a ValueProfile op_get_callee now has a simple inline cache of the most 
        recent JSFunction that we saw.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::CodeBlock):
        (JSC::CodeBlock::finalizeUnconditionally):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitCreateThis):
        * dfg/DFGByteCodeParser.cpp:
        (JSC::DFG::ByteCodeParser::parseBlock):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompileSlowCases):
        * jit/JIT.h:
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_get_callee):
        (JSC::JIT::emitSlow_op_get_callee):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::emit_op_get_callee):
        (JSC::JIT::emitSlow_op_get_callee):
        * llint/LowLevelInterpreter32_64.asm:
        * llint/LowLevelInterpreter64.asm:
        * runtime/CommonSlowPaths.cpp:
        (JSC::SLOW_PATH_DECL):
        * runtime/CommonSlowPaths.h:

1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551
2013-09-24  Mark Lam  <mark.lam@apple.com>

        Change JSC debug hooks to pass a CallFrame* instead of a DebuggerCallFrame.
        https://bugs.webkit.org/show_bug.cgi?id=121867.

        Reviewed by Geoffrey Garen.

        1. Removed the need for passing the line and column info to the debug hook
           callbacks. We now get the line and column info from the CallFrame.

        2. Simplify BytecodeGenerator::emitDebugHook() to only take 1 line number
           argument. The caller can determine whether to pass in the first or last
           line number of the block of source code as appropriate.
           Note: we still need to pass in the line and column info to emitDebugHook()
           because it uses this info to emit expression info which is later used by
           the StackVisitor to determine the line and column info for its "pc".

        3. Pass the exceptionValue explicitly to the exception() debug hook
           callback. It should not be embedded in the CallFrame / DebuggerCallFrame.

        4. Change the op_debug opcode size to 2 (from 5) since we've removing 3 arg
           values. Update the LLINT and JIT code to handle this.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::dumpBytecode):
        (JSC::CodeBlock::CodeBlock):
        * bytecode/Opcode.h:
        (JSC::padOpcodeName):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitDebugHook):
        * bytecompiler/BytecodeGenerator.h:
        * bytecompiler/NodesCodegen.cpp:
        (JSC::ConstStatementNode::emitBytecode):
        (JSC::EmptyStatementNode::emitBytecode):
        (JSC::DebuggerStatementNode::emitBytecode):
        (JSC::ExprStatementNode::emitBytecode):
        (JSC::VarStatementNode::emitBytecode):
        (JSC::IfElseNode::emitBytecode):
        (JSC::DoWhileNode::emitBytecode):
        (JSC::WhileNode::emitBytecode):
        (JSC::ForNode::emitBytecode):
        (JSC::ForInNode::emitBytecode):
        (JSC::ContinueNode::emitBytecode):
        (JSC::BreakNode::emitBytecode):
        (JSC::ReturnNode::emitBytecode):
        (JSC::WithNode::emitBytecode):
        (JSC::SwitchNode::emitBytecode):
        (JSC::LabelNode::emitBytecode):
        (JSC::ThrowNode::emitBytecode):
        (JSC::TryNode::emitBytecode):
        (JSC::ProgramNode::emitBytecode):
        (JSC::EvalNode::emitBytecode):
        (JSC::FunctionBodyNode::emitBytecode):
        * debugger/Debugger.h:
        * debugger/DebuggerCallFrame.cpp:
        (JSC::LineAndColumnFunctor::operator()):
        (JSC::LineAndColumnFunctor::line):
        (JSC::LineAndColumnFunctor::column):
        (JSC::DebuggerCallFrame::DebuggerCallFrame):
        (JSC::DebuggerCallFrame::clear):
        * debugger/DebuggerCallFrame.h:
        (JSC::DebuggerCallFrame::line):
        (JSC::DebuggerCallFrame::column):
        * interpreter/Interpreter.cpp:
        (JSC::unwindCallFrame):
        (JSC::UnwindFunctor::UnwindFunctor):
        (JSC::UnwindFunctor::operator()):
        (JSC::Interpreter::unwind):
        (JSC::Interpreter::debug):
        * interpreter/Interpreter.h:
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_debug):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::emit_op_debug):
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):
        * llint/LLIntSlowPaths.cpp:
        (JSC::LLInt::LLINT_SLOW_PATH_DECL):
        * llint/LowLevelInterpreter.asm:

1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567
2013-09-24  Filip Pizlo  <fpizlo@apple.com>

        Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
        https://bugs.webkit.org/show_bug.cgi?id=121844

        Reviewed by Mark Hahnenberg.
        
        Fix some int52 bugs that caused this.

        * bytecode/ValueRecovery.h:
        (JSC::ValueRecovery::dumpInContext): There's no such thing as int53.
        * dfg/DFGSpeculativeJIT.h:
        (JSC::DFG::SpeculativeJIT::spill): Actually spill int52's, instead of hitting an assert and crashing.
        * dfg/DFGSpeculativeJIT64.cpp:
        (JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal): Use the right format (from before when we clobber it).

1568 1569 1570 1571 1572 1573 1574 1575
2013-09-24  Mark Rowe  <mrowe@apple.com>

        <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8

        Reviewed by Dan Bernstein.

        * Configurations/Base.xcconfig:

1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588
2013-09-23  Patrick Gansterer  <paroga@webkit.org>

        use NOMINMAX instead of #define min min
        https://bugs.webkit.org/show_bug.cgi?id=73563

        Reviewed by Brent Fulgham.

        Use NOMINMAX instead of #define min/max as a cleaner
        way of ensuring that Windows system header files don't
        define min/max as macro in the first place.

        * config.h:

1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672
2013-09-23  Filip Pizlo  <fpizlo@apple.com>

        Never use ReturnPC for exception handling and quit using exception check indices as a lame replica of the CodeOrigin index
        https://bugs.webkit.org/show_bug.cgi?id=121734

        Reviewed by Mark Hahnenberg.
        
        Exception handling can deduce where the exception was thrown from by looking at the
        code origin that was stored into the call frame header. There is no need to pass any
        additional meta-data into the exception throwing logic. But the DFG was still doing it
        anyway.
        
        This removes all of the logic to pass extra meta-data into lookupExceptionHandler()
        and friends. It simplifies a lot of code.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * Target.pri:
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::shrinkToFit):
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::codeOrigins):
        (JSC::CodeBlock::hasCodeOrigins):
        (JSC::CodeBlock::canGetCodeOrigin):
        (JSC::CodeBlock::codeOrigin):
        * bytecode/CodeOrigin.h:
        (JSC::InlineCallFrame::InlineCallFrame):
        * bytecode/InlineCallFrameSet.cpp: Added.
        (JSC::InlineCallFrameSet::InlineCallFrameSet):
        (JSC::InlineCallFrameSet::~InlineCallFrameSet):
        (JSC::InlineCallFrameSet::add):
        (JSC::InlineCallFrameSet::shrinkToFit):
        * bytecode/InlineCallFrameSet.h: Added.
        (JSC::InlineCallFrameSet::isEmpty):
        (JSC::InlineCallFrameSet::size):
        (JSC::InlineCallFrameSet::at):
        * dfg/DFGArgumentsSimplificationPhase.cpp:
        (JSC::DFG::ArgumentsSimplificationPhase::run):
        * dfg/DFGByteCodeParser.cpp:
        (JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
        * dfg/DFGCommonData.cpp:
        (JSC::DFG::CommonData::addCodeOrigin):
        (JSC::DFG::CommonData::shrinkToFit):
        * dfg/DFGCommonData.h:
        * dfg/DFGDesiredWriteBarriers.cpp:
        (JSC::DFG::DesiredWriteBarrier::DesiredWriteBarrier):
        (JSC::DFG::DesiredWriteBarrier::trigger):
        * dfg/DFGDesiredWriteBarriers.h:
        (JSC::DFG::DesiredWriteBarriers::add):
        (JSC::DFG::initializeLazyWriteBarrierForInlineCallFrameExecutable):
        (JSC::DFG::initializeLazyWriteBarrierForInlineCallFrameCallee):
        * dfg/DFGGraph.cpp:
        (JSC::DFG::Graph::Graph):
        * dfg/DFGGraph.h:
        * dfg/DFGJITCompiler.cpp:
        (JSC::DFG::JITCompiler::JITCompiler):
        (JSC::DFG::JITCompiler::compileExceptionHandlers):
        (JSC::DFG::JITCompiler::link):
        (JSC::DFG::JITCompiler::compileFunction):
        * dfg/DFGJITCompiler.h:
        (JSC::DFG::JITCompiler::emitStoreCodeOrigin):
        (JSC::DFG::JITCompiler::exceptionCheck):
        (JSC::DFG::JITCompiler::fastExceptionCheck):
        * dfg/DFGOperations.cpp:
        * dfg/DFGOperations.h:
        * dfg/DFGRepatch.cpp:
        (JSC::DFG::tryBuildGetByIDList):
        * dfg/DFGSpeculativeJIT.h:
        (JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
        (JSC::DFG::SpeculativeJIT::appendCallSetResult):
        (JSC::DFG::SpeculativeJIT::appendCall):
        * dfg/DFGSpeculativeJIT32_64.cpp:
        (JSC::DFG::SpeculativeJIT::emitCall):
        * dfg/DFGSpeculativeJIT64.cpp:
        (JSC::DFG::SpeculativeJIT::emitCall):
        * dfg/DFGVirtualRegisterAllocationPhase.cpp:
        (JSC::DFG::VirtualRegisterAllocationPhase::run):
        * ftl/FTLLowerDFGToLLVM.cpp:
        (JSC::FTL::LowerDFGToLLVM::callPreflight):
        * jit/AssemblyHelpers.h:
        (JSC::AssemblyHelpers::emitExceptionCheck):

1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686
2013-09-23  Oliver Hunt  <oliver@apple.com>

        CodeLoad performance regression

        Reviewed by Filip Pizlo.

        Temporarily remove the ExpressionInfo compression until we can
        work out how to make it not clobber performance.

        * bytecode/UnlinkedCodeBlock.cpp:
        (JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
        (JSC::UnlinkedCodeBlock::addExpressionInfo):
        * bytecode/UnlinkedCodeBlock.h:

1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700
2013-09-23  Patrick Gansterer  <paroga@webkit.org>

        Cleanup CMake files in JavaScriptCore
        https://bugs.webkit.org/show_bug.cgi?id=121762

        Reviewed by Gyuyoung Kim.

        Sort files and unify style.

        * CMakeLists.txt:
        * shell/CMakeLists.txt:
        * shell/PlatformBlackBerry.cmake:
        * shell/PlatformEfl.cmake:

1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716
2013-09-22  Filip Pizlo  <fpizlo@apple.com>

        Get rid of CodeBlock::RareData::callReturnIndexVector and most of the evil that it introduced
        https://bugs.webkit.org/show_bug.cgi?id=121766

        Reviewed by Andreas Kling.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::shrinkToFit):
        * bytecode/CodeBlock.h:
        * dfg/DFGJITCompiler.cpp:
        (JSC::DFG::JITCompiler::compileExceptionHandlers):
        (JSC::DFG::JITCompiler::link):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompile):

1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759
2013-09-21  Filip Pizlo  <fpizlo@apple.com>

        Interpreter::unwind() has no need for the bytecodeOffset
        https://bugs.webkit.org/show_bug.cgi?id=121755

        Reviewed by Oliver Hunt.
        
        It was only using the bytecodeOffset for some debugger stuff, but the debugger could
        just get the bytecodeOffset the same way the rest of the machinery does: by using the
        CallFrame's location.
        
        It turns out that a lot of really ugly code was in place just to supply this
        bytecodeOffset. This patch kills most of that code, and allows us to kill even more
        code in a future patch - though most likely that killage will involve further
        refactorings as well, see https://bugs.webkit.org/show_bug.cgi?id=121734.

        * dfg/DFGOperations.cpp:
        * interpreter/CallFrame.cpp:
        (JSC::CallFrame::bytecodeOffset):
        (JSC::CallFrame::codeOrigin):
        * interpreter/CallFrame.h:
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::unwind):
        * interpreter/Interpreter.h:
        * jit/JITExceptions.cpp:
        (JSC::genericUnwind):
        * jit/JITExceptions.h:
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):
        (JSC::cti_vm_handle_exception):
        * llint/LLIntExceptions.cpp:
        (JSC::LLInt::doThrow):
        (JSC::LLInt::returnToThrow):
        (JSC::LLInt::callToThrow):
        * llint/LLIntExceptions.h:
        * llint/LLIntSlowPaths.cpp:
        (JSC::LLInt::LLINT_SLOW_PATH_DECL):
        * runtime/CommonSlowPaths.cpp:
        (JSC::SLOW_PATH_DECL):
        * runtime/CommonSlowPathsExceptions.cpp:
        (JSC::CommonSlowPaths::interpreterThrowInCaller):
        * runtime/CommonSlowPathsExceptions.h:

1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853
2013-09-21  Darin Adler  <darin@apple.com>

        Add ExecState::uncheckedArgument and use where possible to shrink a bit
        https://bugs.webkit.org/show_bug.cgi?id=121750

        Reviewed by Andreas Kling.

        * interpreter/CallFrame.h:
        (JSC::ExecState::uncheckedArgument): Added. Like argument, but with an
        assertion rather than a runtime check.

        * API/APICallbackFunction.h:
        (JSC::APICallbackFunction::call): Use uncheckedArgument because we are
        already in a loop over arguments, so don't need a range check.
        * API/JSCallbackConstructor.cpp:
        (JSC::constructJSCallback): Ditto.
        * API/JSCallbackObjectFunctions.h:
        (JSC::JSCallbackObject::construct): Ditto.
        (JSC::JSCallbackObject::call): Ditto.
        * jsc.cpp:
        (functionPrint): Ditto.
        (functionRun): Ditto.
        (functionSetSamplingFlags): Ditto.
        (functionClearSamplingFlags): Ditto.
        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncConcat): Ditto.
        (JSC::arrayProtoFuncPush): Use uncheckedArgument because there is already
        code that explicitly checks argumentCount.
        (JSC::arrayProtoFuncSplice): Ditto.
        (JSC::arrayProtoFuncUnShift): Ditto.
        (JSC::arrayProtoFuncReduce): Ditto.
        (JSC::arrayProtoFuncReduceRight): Ditto.
        (JSC::arrayProtoFuncLastIndexOf): Ditto.
        * runtime/DatePrototype.cpp:
        (JSC::fillStructuresUsingTimeArgs): Ditto.
        (JSC::fillStructuresUsingDateArgs): Ditto.
        * runtime/JSArrayBufferConstructor.cpp:
        (JSC::constructArrayBuffer): Ditto.
        * runtime/JSArrayBufferPrototype.cpp:
        (JSC::arrayBufferProtoFuncSlice): Ditto.
        * runtime/JSBoundFunction.cpp:
        (JSC::boundFunctionCall): Ditto.
        (JSC::boundFunctionConstruct): Ditto.
        * runtime/JSDataViewPrototype.cpp:
        (JSC::getData): Ditto.
        (JSC::setData): Ditto.
        * runtime/JSGenericTypedArrayViewConstructorInlines.h:
        (JSC::constructGenericTypedArrayView): Ditto.
        * runtime/JSGenericTypedArrayViewPrototypeInlines.h:
        (JSC::genericTypedArrayViewProtoFuncSet): Ditto.
        (JSC::genericTypedArrayViewProtoFuncSubarray): Ditto.
        * runtime/JSONObject.cpp:
        (JSC::JSONProtoFuncParse): Ditto.
        (JSC::JSONProtoFuncStringify): Ditto.
        * runtime/JSPromiseConstructor.cpp:
        (JSC::constructPromise): Ditto.
        (JSC::JSPromiseConstructorFuncFulfill): Ditto.
        (JSC::JSPromiseConstructorFuncResolve): Ditto.
        (JSC::JSPromiseConstructorFuncReject): Ditto.
        * runtime/MathObject.cpp:
        (JSC::mathProtoFuncMax): Ditto.
        (JSC::mathProtoFuncMin): Ditto.

        * runtime/NameConstructor.cpp:
        (JSC::constructPrivateName): Removed unneeded check of argumentCout
        that simply repeats what argument already does.
        * runtime/NativeErrorConstructor.cpp:
        (JSC::Interpreter::constructWithNativeErrorConstructor): Ditto.
        (JSC::Interpreter::callNativeErrorConstructor): Ditto.

        * runtime/NumberConstructor.cpp:
        (JSC::constructWithNumberConstructor): Use uncheckedArgument since
        there is already code that explicitly checks argument count.
        (JSC::callNumberConstructor): Ditto.

        * runtime/ObjectConstructor.cpp:
        (JSC::objectConstructorCreate): Small refactoring to not call argument(0)
        three times.

        * runtime/SetConstructor.cpp:
        (JSC::constructSet): Use uncheckedArgument since we are already in a loop
        over arguments.

        * runtime/StringConstructor.cpp:
        (JSC::stringFromCharCodeSlowCase): In a loop.
        (JSC::stringFromCharCode): Already checked count.
        (JSC::constructWithStringConstructor): Ditto.
        (JSC::callStringConstructor): Ditto.
        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncConcat): Already checked count.
        * runtime/TestRunnerUtils.cpp:
        (JSC::numberOfDFGCompiles): Ditto.
        (JSC::setNeverInline): Ditto.

1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865
2013-09-21  Filip Pizlo  <fpizlo@apple.com>

        Remove the notion that a CallFrame can have a pointer to an InlineCallFrame, since that doesn't happen anymore
        https://bugs.webkit.org/show_bug.cgi?id=121753

        Reviewed by Darin Adler.

        * interpreter/CallFrame.cpp:
        (JSC::CallFrame::bytecodeOffsetFromCodeOriginIndex):
        * interpreter/CallFrame.h:
        * interpreter/Register.h:

fpizlo@apple.com's avatar
fpizlo@apple.com committed
1866 1867 1868 1869 1870 1871
2013-09-21  Filip Pizlo  <fpizlo@apple.com>

        Unreviewed, fix the revert.

        * dfg/DFGRepatch.cpp:

1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026
2013-09-21  Filip Pizlo  <fpizlo@apple.com>

        Unreviewed, revert http://trac.webkit.org/changeset/156235. It won't work on Windows.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * Target.pri:
        * bytecode/CallLinkInfo.cpp:
        (JSC::CallLinkInfo::unlink):
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::resetStubInternal):
        * bytecode/StructureStubInfo.h:
        * dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
        (JSC::DFG::CallArrayAllocatorSlowPathGenerator::CallArrayAllocatorSlowPathGenerator):
        (JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):
        * dfg/DFGJITCompiler.h:
        * dfg/DFGOSRExitCompiler.h:
        * dfg/DFGOperations.cpp:
        (JSC::DFG::operationPutByValInternal):
        * dfg/DFGOperations.h:
        (JSC::DFG::operationNewTypedArrayWithSizeForType):
        (JSC::DFG::operationNewTypedArrayWithOneArgumentForType):
        * dfg/DFGRegisterSet.h: Added.
        (JSC::DFG::RegisterSet::RegisterSet):
        (JSC::DFG::RegisterSet::asPOD):
        (JSC::DFG::RegisterSet::copyInfo):
        (JSC::DFG::RegisterSet::set):
        (JSC::DFG::RegisterSet::setGPRByIndex):
        (JSC::DFG::RegisterSet::clear):
        (JSC::DFG::RegisterSet::get):
        (JSC::DFG::RegisterSet::getGPRByIndex):
        (JSC::DFG::RegisterSet::getFreeGPR):
        (JSC::DFG::RegisterSet::setFPRByIndex):
        (JSC::DFG::RegisterSet::getFPRByIndex):
        (JSC::DFG::RegisterSet::setByIndex):
        (JSC::DFG::RegisterSet::getByIndex):
        (JSC::DFG::RegisterSet::numberOfSetGPRs):
        (JSC::DFG::RegisterSet::numberOfSetFPRs):
        (JSC::DFG::RegisterSet::numberOfSetRegisters):
        (JSC::DFG::RegisterSet::setBit):
        (JSC::DFG::RegisterSet::clearBit):
        (JSC::DFG::RegisterSet::getBit):
        * dfg/DFGRepatch.cpp: Added.
        (JSC::DFG::repatchCall):
        (JSC::DFG::repatchByIdSelfAccess):
        (JSC::DFG::addStructureTransitionCheck):
        (JSC::DFG::replaceWithJump):
        (JSC::DFG::emitRestoreScratch):
        (JSC::DFG::linkRestoreScratch):
        (JSC::DFG::generateProtoChainAccessStub):
        (JSC::DFG::tryCacheGetByID):
        (JSC::DFG::repatchGetByID):
        (JSC::DFG::getPolymorphicStructureList):
        (JSC::DFG::patchJumpToGetByIdStub):
        (JSC::DFG::tryBuildGetByIDList):
        (JSC::DFG::buildGetByIDList):
        (JSC::DFG::appropriateGenericPutByIdFunction):
        (JSC::DFG::appropriateListBuildingPutByIdFunction):
        (JSC::DFG::emitPutReplaceStub):
        (JSC::DFG::emitPutTransitionStub):
        (JSC::DFG::tryCachePutByID):
        (JSC::DFG::repatchPutByID):
        (JSC::DFG::tryBuildPutByIdList):
        (JSC::DFG::buildPutByIdList):
        (JSC::DFG::tryRepatchIn):
        (JSC::DFG::repatchIn):
        (JSC::DFG::linkSlowFor):
        (JSC::DFG::linkFor):
        (JSC::DFG::linkClosureCall):
        (JSC::DFG::resetGetByID):
        (JSC::DFG::resetPutByID):
        (JSC::DFG::resetIn):
        * dfg/DFGRepatch.h: Added.
        (JSC::DFG::resetGetByID):
        (JSC::DFG::resetPutByID):
        (JSC::DFG::resetIn):
        * dfg/DFGScratchRegisterAllocator.h: Added.
        (JSC::DFG::ScratchRegisterAllocator::ScratchRegisterAllocator):
        (JSC::DFG::ScratchRegisterAllocator::lock):
        (JSC::DFG::ScratchRegisterAllocator::allocateScratch):
        (JSC::DFG::ScratchRegisterAllocator::allocateScratchGPR):
        (JSC::DFG::ScratchRegisterAllocator::allocateScratchFPR):
        (JSC::DFG::ScratchRegisterAllocator::didReuseRegisters):
        (JSC::DFG::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
        (JSC::DFG::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
        (JSC::DFG::ScratchRegisterAllocator::desiredScratchBufferSize):
        (JSC::DFG::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
        (JSC::DFG::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):
        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::SpeculativeJIT::writeBarrier):
        (JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
        (JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
        (JSC::DFG::SpeculativeJIT::compare):
        * dfg/DFGSpeculativeJIT.h:
        (JSC::DFG::SpeculativeJIT::callOperation):
        * dfg/DFGSpeculativeJIT32_64.cpp:
        (JSC::DFG::SpeculativeJIT::cachedPutById):
        (JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
        (JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
        (JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
        (JSC::DFG::SpeculativeJIT::compile):
        * dfg/DFGSpeculativeJIT64.cpp:
        (JSC::DFG::SpeculativeJIT::cachedPutById):
        (JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
        (JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
        (JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
        (JSC::DFG::SpeculativeJIT::compile):
        * dfg/DFGThunks.cpp:
        (JSC::DFG::emitPointerValidation):
        (JSC::DFG::throwExceptionFromCallSlowPathGenerator):
        (JSC::DFG::slowPathFor):
        (JSC::DFG::linkForThunkGenerator):
        (JSC::DFG::linkCallThunkGenerator):
        (JSC::DFG::linkConstructThunkGenerator):
        (JSC::DFG::linkClosureCallThunkGenerator):
        (JSC::DFG::virtualForThunkGenerator):
        (JSC::DFG::virtualCallThunkGenerator):
        (JSC::DFG::virtualConstructThunkGenerator):
        * dfg/DFGThunks.h:
        * ftl/FTLIntrinsicRepository.h:
        * ftl/FTLLowerDFGToLLVM.cpp:
        (JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
        * ftl/FTLOSRExitCompiler.h:
        * jit/AssemblyHelpers.h:
        * jit/JIT.cpp:
        (JSC::JIT::linkFor):
        (JSC::JIT::linkSlowCall):
        * jit/JITCall.cpp:
        (JSC::JIT::compileCallEvalSlowCase):
        (JSC::JIT::compileOpCallSlowCase):
        (JSC::JIT::privateCompileClosureCall):
        * jit/JITCall32_64.cpp:
        (JSC::JIT::compileCallEvalSlowCase):
        (JSC::JIT::compileOpCallSlowCase):
        (JSC::JIT::privateCompileClosureCall):
        * jit/JITOperationWrappers.h: Removed.
        * jit/JITOperations.cpp: Removed.
        * jit/JITOperations.h: Removed.
        * jit/RegisterSet.h: Removed.
        * jit/Repatch.cpp: Removed.
        * jit/Repatch.h: Removed.
        * jit/ScratchRegisterAllocator.h: Removed.
        * jit/ThunkGenerators.cpp:
        (JSC::generateSlowCaseFor):
        (JSC::linkForGenerator):
        (JSC::linkCallGenerator):
        (JSC::linkConstructGenerator):
        (JSC::linkClosureCallGenerator):
        (JSC::virtualForGenerator):
        (JSC::virtualCallGenerator):
        (JSC::virtualConstructGenerator):
        * jit/ThunkGenerators.h:

2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203
2013-09-21  Filip Pizlo  <fpizlo@apple.com>

        Move DFG inline caching logic into jit/
        https://bugs.webkit.org/show_bug.cgi?id=121749

        Rubber stamped by Sam Weinig.
        
        We want to get rid of the baseline JIT's inline caching machinery and have it use the
        DFG's instead. But before we do that we need to move the DFG's inline caching machine
        out from behind its ENABLE(DFG_JIT) guards and make it available to the whole system.
        This patch does that:
        
        - dfg/DFGRepatch becomes jit/Repatch.
        
        - The thunks used by the DFG IC go into jit/ThunkGenerators, instead of dfg/DFGThunks.
        
        - The operations used by the DFG IC go into jit/JITOperations, instead of
          dfg/DFGOperations.
        
        - The old JIT's thunk generators for calls are renamed to reduce confusion. Previously
          it was easy to know which generators belong to which JIT because the old JIT used
          JSC::virtualCallBlah and the DFG used JSC::DFG::virtualCallBlah, but that's not the
          case anymore. Note that the old JIT's thunk generators will die in a future patch.
        
        No functional changes beyond those moves.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * Target.pri:
        * bytecode/CallLinkInfo.cpp:
        (JSC::CallLinkInfo::unlink):
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::resetStubInternal):
        * bytecode/StructureStubInfo.h:
        * dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
        (JSC::DFG::CallArrayAllocatorSlowPathGenerator::CallArrayAllocatorSlowPathGenerator):
        (JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):
        * dfg/DFGJITCompiler.h:
        * dfg/DFGOSRExitCompiler.h:
        * dfg/DFGOperations.cpp:
        (JSC::DFG::operationPutByValInternal):
        * dfg/DFGOperations.h:
        (JSC::DFG::operationNewTypedArrayWithSizeForType):
        (JSC::DFG::operationNewTypedArrayWithOneArgumentForType):
        * dfg/DFGRegisterSet.h: Removed.
        * dfg/DFGRepatch.cpp: Removed.
        * dfg/DFGRepatch.h: Removed.
        * dfg/DFGScratchRegisterAllocator.h: Removed.
        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
        (JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
        (JSC::DFG::SpeculativeJIT::compare):
        * dfg/DFGSpeculativeJIT.h:
        (JSC::DFG::SpeculativeJIT::callOperation):
        * dfg/DFGSpeculativeJIT32_64.cpp:
        (JSC::DFG::SpeculativeJIT::cachedPutById):
        (JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
        (JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
        (JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
        (JSC::DFG::SpeculativeJIT::compile):
        * dfg/DFGSpeculativeJIT64.cpp:
        (JSC::DFG::SpeculativeJIT::cachedPutById):
        (JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
        (JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
        (JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
        (JSC::DFG::SpeculativeJIT::compile):
        * dfg/DFGThunks.cpp:
        * dfg/DFGThunks.h:
        * ftl/FTLIntrinsicRepository.h:
        * ftl/FTLLowerDFGToLLVM.cpp:
        (JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
        * jit/AssemblyHelpers.h:
        (JSC::AssemblyHelpers::writeBarrier):
        * jit/JIT.cpp:
        (JSC::JIT::linkFor):
        (JSC::JIT::linkSlowCall):
        * jit/JITCall.cpp:
        (JSC::JIT::compileCallEval):
        (JSC::JIT::compileCallEvalSlowCase):
        (JSC::JIT::compileOpCallSlowCase):
        (JSC::JIT::privateCompileClosureCall):
        * jit/JITCall32_64.cpp:
        (JSC::JIT::compileCallEvalSlowCase):
        (JSC::JIT::compileOpCallSlowCase):
        (JSC::JIT::privateCompileClosureCall):
        * jit/JITOperationWrappers.h: Added.
        * jit/JITOperations.cpp: Added.
        * jit/JITOperations.h: Added.
        * jit/RegisterSet.h: Added.
        (JSC::RegisterSet::RegisterSet):
        (JSC::RegisterSet::asPOD):
        (JSC::RegisterSet::copyInfo):
        (JSC::RegisterSet::set):
        (JSC::RegisterSet::setGPRByIndex):
        (JSC::RegisterSet::clear):
        (JSC::RegisterSet::get):
        (JSC::RegisterSet::getGPRByIndex):
        (JSC::RegisterSet::getFreeGPR):
        (JSC::RegisterSet::setFPRByIndex):
        (JSC::RegisterSet::getFPRByIndex):
        (JSC::RegisterSet::setByIndex):
        (JSC::RegisterSet::getByIndex):
        (JSC::RegisterSet::numberOfSetGPRs):
        (JSC::RegisterSet::numberOfSetFPRs):
        (JSC::RegisterSet::numberOfSetRegisters):
        (JSC::RegisterSet::setBit):
        (JSC::RegisterSet::clearBit):
        (JSC::RegisterSet::getBit):
        * jit/Repatch.cpp: Added.
        (JSC::repatchCall):
        (JSC::repatchByIdSelfAccess):
        (JSC::addStructureTransitionCheck):
        (JSC::replaceWithJump):
        (JSC::emitRestoreScratch):
        (JSC::linkRestoreScratch):
        (JSC::generateProtoChainAccessStub):
        (JSC::tryCacheGetByID):
        (JSC::repatchGetByID):
        (JSC::getPolymorphicStructureList):
        (JSC::patchJumpToGetByIdStub):
        (JSC::tryBuildGetByIDList):
        (JSC::buildGetByIDList):
        (JSC::appropriateGenericPutByIdFunction):
        (JSC::appropriateListBuildingPutByIdFunction):
        (JSC::emitPutReplaceStub):
        (JSC::emitPutTransitionStub):
        (JSC::tryCachePutByID):
        (JSC::repatchPutByID):
        (JSC::tryBuildPutByIdList):
        (JSC::buildPutByIdList):
        (JSC::tryRepatchIn):
        (JSC::repatchIn):
        (JSC::linkSlowFor):
        (JSC::linkFor):
        (JSC::linkClosureCall):
        (JSC::resetGetByID):
        (JSC::resetPutByID):
        (JSC::resetIn):
        * jit/Repatch.h: Added.
        (JSC::resetGetByID):
        (JSC::resetPutByID):
        (JSC::resetIn):
        * jit/ScratchRegisterAllocator.h: Added.
        (JSC::ScratchRegisterAllocator::ScratchRegisterAllocator):
        (JSC::ScratchRegisterAllocator::lock):
        (JSC::ScratchRegisterAllocator::allocateScratch):
        (JSC::ScratchRegisterAllocator::allocateScratchGPR):
        (JSC::ScratchRegisterAllocator::allocateScratchFPR):
        (JSC::ScratchRegisterAllocator::didReuseRegisters):
        (JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
        (JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
        (JSC::ScratchRegisterAllocator::desiredScratchBufferSize):
        (JSC::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
        (JSC::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):
        * jit/ThunkGenerators.cpp:
        (JSC::oldStyleGenerateSlowCaseFor):
        (JSC::oldStyleLinkForGenerator):
        (JSC::oldStyleLinkCallGenerator):
        (JSC::oldStyleLinkConstructGenerator):
        (JSC::oldStyleLinkClosureCallGenerator):
        (JSC::oldStyleVirtualForGenerator):
        (JSC::oldStyleVirtualCallGenerator):
        (JSC::oldStyleVirtualConstructGenerator):
        (JSC::emitPointerValidation):
        (JSC::throwExceptionFromCallSlowPathGenerator):
        (JSC::slowPathFor):
        (JSC::linkForThunkGenerator):
        (JSC::linkCallThunkGenerator):
        (JSC::linkConstructThunkGenerator):
        (JSC::linkClosureCallThunkGenerator):
        (JSC::virtualForThunkGenerator):
        (JSC::virtualCallThunkGenerator):
        (JSC::virtualConstructThunkGenerator):
        * jit/ThunkGenerators.h:

andersca@apple.com's avatar
andersca@apple.com committed
2204 2205 2206 2207 2208 2209 2210 2211 2212
2013-09-21  Anders Carlsson  <andersca@apple.com>

        Fix the non-DFG build.

        * interpreter/Interpreter.cpp:
        (JSC::unwindCallFrame):
        * interpreter/StackVisitor.cpp:
        (JSC::StackVisitor::Frame::r):

2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239
2013-09-21  Filip Pizlo  <fpizlo@apple.com>

        Get rid of IsInlinedCodeTag and its associated methods since it's unused
        https://bugs.webkit.org/show_bug.cgi?id=121737

        Reviewed by Sam Weinig.
        
        This was meant to be easy, but I kept wondering if it was safe to remove the
        inline call frame check in Arguments::tearOff(). The check was clearly dead
        since the bit wasn't being set anywhere.
        
        It turns out that the unwindCallFrame() function was relying on tearOff()
        doing the right thing for inlined code, but it wasn't even passing it an
        inline call frame. I fixed this by having unwindCallFrame() inlining check,
        while also making sure that the code uses the right operand index for the
        arguments register.

        * interpreter/CallFrame.h:
        * interpreter/CallFrameInlines.h:
        * interpreter/Interpreter.cpp:
        (JSC::unwindCallFrame):
        * interpreter/StackVisitor.cpp:
        (JSC::StackVisitor::Frame::r):
        * interpreter/StackVisitor.h:
        * runtime/Arguments.cpp:
        (JSC::Arguments::tearOff):

2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253
2013-09-20  Mark Hahnenberg  <mhahnenberg@apple.com>

        (un)shiftCountWithAnyIndexingType will start over in the middle of copying if it sees a hole
        https://bugs.webkit.org/show_bug.cgi?id=121717

        Reviewed by Oliver Hunt.

        This bug caused the array to become corrupted. We now check for holes before we start moving things, 
        and start moving things only once we've determined that there are none.

        * runtime/JSArray.cpp:
        (JSC::JSArray::shiftCountWithAnyIndexingType):
        (JSC::JSArray::unshiftCountWithAnyIndexingType):

2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267
2013-09-20  Filip Pizlo  <fpizlo@apple.com>

        REGRESSION(r156047): WebCore hangs inside JSC::toInt32(double)
        https://bugs.webkit.org/show_bug.cgi?id=121648

        Reviewed by Mark Hahnenberg.
        
        The Int52<->StrictInt52 conversion did the opposite fill() than what it was
        supposed to. For example when converting a Int52 to a StrictInt52 it would fill
        as Int52, and vice-versa.

        * dfg/DFGSpeculativeJIT64.cpp:
        (JSC::DFG::SpeculativeJIT::fillSpeculateInt52):

2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280
2013-09-20  Oliver Hunt  <oliver@apple.com>

        REGRESSION(r153215): New iCloud site crashes
        https://bugs.webkit.org/show_bug.cgi?id=121710

        Reviewed by Filip Pizlo.

        Don't claim to be able to rely on the arguments structure, use the Arguments
        speculation type

        * dfg/DFGAbstractInterpreterInlines.h:
        (JSC::DFG::::executeEffects):

2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293
2013-09-20  Mark Hahnenberg  <mhahnenberg@apple.com>

        Clobberize phase forgets to indicate that it writes GCState for several node types
        https://bugs.webkit.org/show_bug.cgi?id=121702

        Reviewed by Oliver Hunt.

        Added read and write for GCState to the nodes that could end up allocating (and thereby
        cause a garbage collection).

        * dfg/DFGClobberize.h:
        (JSC::DFG::clobberize):

fpizlo@apple.com's avatar