ChangeLog 487 KB
Newer Older
1 2 3 4 5 6 7 8 9 10
2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>

        Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
        https://bugs.webkit.org/show_bug.cgi?id=122183

        Reviewed by Timothy Hatcher.

        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
        (BuildbotIteration.prototype.update):

11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30
2013-10-01  Timothy Hatcher  <timothy@apple.com>

        Tweaks to the Buildbot Dashboard

        https://bugs.webkit.org/show_bug.cgi?id=122169

        Reviewed by Alexey Proskuryakov.

        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
        (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
        (BuildbotQueueView.prototype.revisionLinksForIteration):
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
        (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
        (WebKitBuildbot.prototype.buildLogURLForIteration):
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:

31 32 33 34 35 36 37 38 39 40 41 42
2013-10-01  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r156725.
        http://trac.webkit.org/changeset/156725
        https://bugs.webkit.org/show_bug.cgi?id=122176

        broke all the mismatch tests again (Requested by thorton on
        #webkit).

        * WebKitTestRunner/mac/PlatformWebViewMac.mm:
        (WTR::PlatformWebView::PlatformWebView):

43 44 45 46 47 48 49 50 51 52 53 54
2013-10-01  Alex Christensen  <achristensen@webkit.org>

        Implemented createWebViewWithRequest in WinLauncher.
        https://bugs.webkit.org/show_bug.cgi?id=122069

        Reviewed by Brent Fulgham.

        * WinLauncher/PrintWebUIDelegate.cpp:
        (PrintWebUIDelegate::createWebViewWithRequest): Added.
        * WinLauncher/PrintWebUIDelegate.h:
        Removed createWebViewWithRequest stub.

55 56 57 58 59 60 61 62 63 64 65 66 67 68 69
2013-10-01  Tim Horton  <timothy_horton@apple.com>

        [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
        https://bugs.webkit.org/show_bug.cgi?id=122006
        <rdar://problem/15095197>

        Reviewed by Dean Jackson.

        * WebKitTestRunner/mac/PlatformWebViewMac.mm:
        (WTR::PlatformWebView::PlatformWebView):
        Layer-back the root view in WebKitTestRunner's window, to work around a bug
        where the window server snapshot API returns blank snapshots.

        Re-landing after r156724, this should not break everything now.

70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88
2013-10-01  Tim Horton  <timothy_horton@apple.com>

        [mac] 1x emulation on Retina hardware shouldn't use SPI
        https://bugs.webkit.org/show_bug.cgi?id=122152
        <rdar://problem/15119384>

        Reviewed by Anders Carlsson.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (createWebViewAndOffscreenWindow):
        (main):
        * DumpRenderTree/mac/DumpRenderTreeWindow.h:
        * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
        * WebKitTestRunner/mac/PlatformWebViewMac.mm:
        (WTR::PlatformWebView::PlatformWebView):
        * WebKitTestRunner/mac/main.mm:
        (main):
        Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.

89 90 91 92 93 94 95 96 97 98
2013-09-30  Sam Weinig  <sam@webkit.org>

        check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
        https://bugs.webkit.org/show_bug.cgi?id=116474

        Reviewed by Ryosuke Niwa.

        * Scripts/webkitpy/style/checkers/cpp.py:
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:

99 100 101 102 103 104 105 106 107 108 109 110 111 112
2013-09-30  Sam Weinig  <sam@webkit.org>

        Remove support for DOMFileSystem
        https://bugs.webkit.org/show_bug.cgi?id=122137

        Reviewed by Anders Carlsson.

        * Scripts/webkitperl/FeatureList.pm:
        * Scripts/webkitpy/style/checkers/cpp.py:
        (check_spacing):
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (CppStyleTest.test_spacing_for_binary_ops):
        * qmake/mkspecs/features/features.pri:

113 114 115 116 117 118 119
2013-09-30  Mark Rowe  <mrowe@apple.com>

        More build fixage for builds with SDKs.

        * WebKitTestRunner/Configurations/Base.xcconfig:
        * WebKitTestRunner/Configurations/BaseTarget.xcconfig:

120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160
2013-09-30  Timothy Hatcher  <timothy@apple.com>

        Add initial version of a new Buildbot dashboard view.

        https://bugs.webkit.org/show_bug.cgi?id=122131

        Reviewed by Alexey Proskuryakov.

        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.

161 162 163 164 165 166 167 168 169 170 171 172
2013-09-30  Benjamin Poulain  <benjamin@webkit.org>

        Remove the code guarded by STYLE_SCOPED
        https://bugs.webkit.org/show_bug.cgi?id=122123

        Reviewed by Anders Carlsson.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * Scripts/webkitperl/FeatureList.pm:
        * qmake/mkspecs/features/features.pri:

173 174 175 176 177 178 179 180 181 182 183
2013-09-30  Mark Rowe  <mrowe@apple.com>

        Fix the build when building against an SDK.

        Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
        the compiler command lines. It can't know to do this for the system framework search paths
        we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.

        * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
        * WebKitTestRunner/Configurations/BaseTarget.xcconfig:

184 185 186 187 188 189 190 191 192 193 194 195
2013-09-30  Brent Fulgham  <bfulgham@apple.com>

        [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.

        A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
        it to be double-freed.

        * WinLauncher/WinLauncher.cpp:
        (EditProc): Be explicit about type passed to loadURL.
        (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
        that reallocating the BSTR is done with the knowledge of the smart pointer.

196 197 198 199 200 201 202 203 204 205 206 207
2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        [Qt] Fix force_static_libs_as_shared in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=121961

        Reviewed by Csaba Osztrogonác.

        Get rid of the unused WebKit2QML library

        * qmake/mkspecs/features/webkit_modules.prf:
        * qmake/mkspecs/modules/webkit2qml.prf: Removed.

208 209 210 211 212 213 214 215 216 217 218 219
2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>

        [EFL] Fix incorrect click counting in EventSenderProxy
        https://bugs.webkit.org/show_bug.cgi?id=122098

        Reviewed by Gyuyoung Kim.

        Previously used two types of recording time, which conflicted with each other.

        * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
        (WTR::EventSenderProxy::mouseUp):

220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240
2013-09-30  Zan Dobersek  <zdobersek@igalia.com>

        [webkitpy] Make the Xvfb screen depth overridable
        https://bugs.webkit.org/show_bug.cgi?id=122089

        Reviewed by Gyuyoung Kim.

        Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
        was set. The default value that's used if the variable wasn't set is 24.

        * Scripts/webkitpy/port/xvfbdriver.py:
        (XvfbDriver._xvfb_screen_depth):
        (XvfbDriver._start):
        * Scripts/webkitpy/port/xvfbdriver_unittest.py:
        (XvfbDriverTest.make_driver):
        (XvfbDriverTest.test_start_no_pixel_tests):
        (XvfbDriverTest.test_start_pixel_tests):
        (XvfbDriverTest.test_start_arbitrary_worker_number):
        (XvfbDriverTest.test_next_free_display):
        (XvfbDriverTest.test_start_next_worker):

mrowe@apple.com's avatar
mrowe@apple.com committed
241 242 243 244 245 246 247 248 249
2013-09-29  Mark Rowe  <mrowe@apple.com>

        Fix the Lion build.

        Ensure that C++ and Objective-C++ files build with the right compiler flags.

        * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
        * WebKitTestRunner/Configurations/BaseTarget.xcconfig:

250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273
2013-09-28  Mark Rowe  <mrowe@apple.com>

        Fix some failures with newer versions of clang.

        Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
        usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
        as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
        flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
        in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.

        Reviewed by Dan Bernstein.

        * DumpRenderTree/mac/Configurations/Base.xcconfig:
        * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
        * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
        * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
        * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
        * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
        * WebKitTestRunner/Configurations/Base.xcconfig:
        * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
        * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
        * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
        * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:

274 275 276 277 278 279 280 281 282 283 284 285
2013-09-27  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r156569.
        http://trac.webkit.org/changeset/156569
        https://bugs.webkit.org/show_bug.cgi?id=122035

        broke a lot of mismatch tests (Requested by thorton on
        #webkit).

        * WebKitTestRunner/mac/PlatformWebViewMac.mm:
        (WTR::PlatformWebView::PlatformWebView):

286 287 288 289 290 291 292 293 294 295
2013-09-27  Alexey Proskuryakov  <ap@apple.com>

        Don't retry failures on Apple MountainLion Release WK1 tester
        https://bugs.webkit.org/show_bug.cgi?id=122026

        Reviewed by Mark Rowe.

        * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
        on this bot.

296 297 298 299 300 301 302 303 304 305 306 307 308 309
2013-09-27  Alexey Proskuryakov  <ap@apple.com>

        Don't hardcode builder specific configuration in buildbot master.cfg
        https://bugs.webkit.org/show_bug.cgi?id=122023

        Reviewed by Mark Rowe.

        * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
        property to Qt Mountain Lion Release, making it run pixel tests.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (RunWebKitTests.start): Use additionalArguments.
        (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.

310 311 312 313 314 315 316 317 318 319 320 321 322
2013-09-27  Tim Horton  <timothy_horton@apple.com>

        [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
        https://bugs.webkit.org/show_bug.cgi?id=122006
        <rdar://problem/15095197>

        Reviewed by Dean Jackson.

        * WebKitTestRunner/mac/PlatformWebViewMac.mm:
        (WTR::PlatformWebView::PlatformWebView):
        Layer-back the root view in WebKitTestRunner's window, to work around a bug
        where the window server snapshot API returns blank snapshots.

323 324 325 326 327 328 329 330 331 332 333 334 335 336 337
2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>

        [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=106924

        Reviewed by Chris Fleizach.

        Consider headings levels as values to be returned in intValue()
        both in DRT and WKTR, so we can share more tests with other ports.

        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
        (AccessibilityUIElement::intValue): Consider headings too.
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        (WTR::AccessibilityUIElement::intValue): Ditto.

darin@apple.com's avatar
darin@apple.com committed
338 339 340 341 342 343 344 345 346
2013-09-26  Darin Adler  <darin@apple.com>

        rename KURL to URL
        https://bugs.webkit.org/show_bug.cgi?id=16214

        Reviewed by Andreas Kling.

        * many files: Renamed, using script.

347 348 349 350 351 352 353 354
2013-09-27  Darin Adler  <darin@apple.com>

        Fix Python scripts test failures.

        * Scripts/webkitpy/style/checkers/cpp.py:
        (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
        now, not by the checker itself.

355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371
2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>

        [GTK][WK2] Logging of accessibility events is not disabled between tests
        https://bugs.webkit.org/show_bug.cgi?id=121957

        Reviewed by Mario Sanchez Prada.

        Fixed an issue in AccessibilityNotificationHandler where the destructor
        was not disconnecting accessibility event callbacks if logging was on.
        The decision of disconnecting events can solely rely on the existence of
        notification handlers because logging uses the global notification
        handler.

        * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
        (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
        disconnection when logging is on.

372 373 374 375 376 377 378 379 380 381 382 383 384 385
2013-09-27  Patrick Gansterer  <paroga@webkit.org>

        Add general CMakeLists.txt for DRT
        https://bugs.webkit.org/show_bug.cgi?id=119268

        Reviewed by Gyuyoung Kim.

        The new file allows better sharing between ports.

        * CMakeLists.txt:
        * DumpRenderTree/CMakeLists.txt: Added.
        * DumpRenderTree/PlatformEfl.cmake: Added.
        * DumpRenderTree/efl/CMakeLists.txt: Removed.

386 387 388 389 390 391 392 393 394 395 396
2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        [Qt] Fix force_static_libs_as_shared in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=121961

        Reviewed by Csaba Osztrogonác.

        Reenable force_static_libs_as_shared when building WebKit2.

        * qmake/mkspecs/features/default_post.prf:

397 398 399 400 401 402 403 404 405 406 407 408
2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        [Qt] Mock implementations of positioning and orientation not used
        https://bugs.webkit.org/show_bug.cgi?id=121956

        Reviewed by Csaba Osztrogonác.

        Move production_build checks to sanitizeFeatures where its value is actually known.

        * qmake/mkspecs/features/features.prf:
        * qmake/mkspecs/features/features.pri:

409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490
2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>

        [ATK] Normalize checks in entry points for DRT and WKTR
        https://bugs.webkit.org/show_bug.cgi?id=121959

        Reviewed by Chris Fleizach.

        Always check if we have a proper instance of AtkObject,
        implementing the interfaces that we might need for each case, at
        the entry point of every method of AccessibilityUIElement for ATK,
        and do those checks in an uniform way across DRT and WKTR, to
        avoid confusion and issues when modifying these files in the future.

        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
        (AccessibilityUIElement::getChildren): Use normalized checks.
        (AccessibilityUIElement::getChildrenWithRange): Ditto.
        (AccessibilityUIElement::rowCount): Ditto.
        (AccessibilityUIElement::columnCount): Ditto.
        (AccessibilityUIElement::childrenCount): Ditto.
        (AccessibilityUIElement::elementAtPoint): Ditto.
        (AccessibilityUIElement::getChildAtIndex): Ditto.
        (AccessibilityUIElement::allAttributes): Ditto.
        (AccessibilityUIElement::titleUIElement): Ditto.
        (AccessibilityUIElement::parentElement): Ditto.
        (AccessibilityUIElement::attributesOfChildren): Ditto.
        (AccessibilityUIElement::role): Ditto.
        (AccessibilityUIElement::title): Ditto.
        (AccessibilityUIElement::description): Ditto.
        (AccessibilityUIElement::stringValue): Ditto.
        (AccessibilityUIElement::language): Ditto.
        (AccessibilityUIElement::x): Ditto.
        (AccessibilityUIElement::y): Ditto.
        (AccessibilityUIElement::width): Ditto.
        (AccessibilityUIElement::height): Ditto.
        (AccessibilityUIElement::orientation): Ditto.
        (AccessibilityUIElement::intValue): Ditto.
        (AccessibilityUIElement::minValue): Ditto.
        (AccessibilityUIElement::maxValue): Ditto.
        (indexRangeInTable): Ditto.
        (AccessibilityUIElement::cellForColumnAndRow): Ditto.
        (AccessibilityUIElement::stringAttributeValue): Ditto.
        (alterCurrentValue): Ditto.
        (AccessibilityUIElement::press): Ditto.
        (AccessibilityUIElement::documentEncoding): Ditto.
        (AccessibilityUIElement::documentURI): Ditto.
        (AccessibilityUIElement::hasPopup): Ditto.

        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        (WTR::indexRangeInTable): Use normalized checks.
        (WTR::alterCurrentValue): Ditto.
        (WTR::AccessibilityUIElement::getChildren): Ditto.
        (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
        (WTR::AccessibilityUIElement::childrenCount): Ditto.
        (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
        (WTR::AccessibilityUIElement::indexOfChild): Ditto.
        (WTR::AccessibilityUIElement::childAtIndex): Ditto.
        (WTR::AccessibilityUIElement::titleUIElement): Ditto.
        (WTR::AccessibilityUIElement::parentElement): Ditto.
        (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
        (WTR::AccessibilityUIElement::allAttributes): Ditto.
        (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
        (WTR::AccessibilityUIElement::role): Ditto.
        (WTR::AccessibilityUIElement::title): Ditto.
        (WTR::AccessibilityUIElement::description): Ditto.
        (WTR::AccessibilityUIElement::orientation): Ditto.
        (WTR::AccessibilityUIElement::stringValue): Ditto.
        (WTR::AccessibilityUIElement::language): Ditto.
        (WTR::AccessibilityUIElement::x): Ditto.
        (WTR::AccessibilityUIElement::y): Ditto.
        (WTR::AccessibilityUIElement::width): Ditto.
        (WTR::AccessibilityUIElement::height): Ditto.
        (WTR::AccessibilityUIElement::intValue): Ditto.
        (WTR::AccessibilityUIElement::minValue): Ditto.
        (WTR::AccessibilityUIElement::maxValue): Ditto.
        (WTR::AccessibilityUIElement::rowCount): Ditto.
        (WTR::AccessibilityUIElement::columnCount): Ditto.
        (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
        (WTR::AccessibilityUIElement::press): Ditto.
        (WTR::AccessibilityUIElement::documentEncoding): Ditto.
        (WTR::AccessibilityUIElement::documentURI): Ditto.
        (WTR::AccessibilityUIElement::hasPopup): Ditto.

491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507
2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>

        [ATK] accessibility/aria-sort.html is failing after r156409
        https://bugs.webkit.org/show_bug.cgi?id=121947

        Reviewed by Chris Fleizach.

        Implement AccessibilityUIElement::isSupported for the ATK
        platforms, just by checking whether we have an associated object
        attribute exposed for the wrapper object matching the required
        attribute in the layout test (e.g "AXSortDirection" -> "sort").

        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
        (AccessibilityUIElement::isAttributeSupported): Implemented.
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.

508 509 510 511 512 513 514 515 516 517 518
2013-09-26  Eric Carlson  <eric.carlson@apple.com>

        [MediaStream] make MediaStream testable
        https://bugs.webkit.org/show_bug.cgi?id=121967

        Reviewed by Dean Jackson.

        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
            user media request policy delegate.

519 520 521 522 523 524 525 526 527 528 529 530
2013-09-26  Brian J. Burg  <burg@cs.washington.edu>

        build-webkit --inspector-frontend should copy WebInspectorUI files
        https://bugs.webkit.org/show_bug.cgi?id=117851

        Reviewed by Joseph Pecoraro.

        Change the --inspector-frontend build option to additionally build/copy 
        WebInspectorUI by setting it as the only project that needs to be built.

        * Scripts/build-webkit:

531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550
2013-09-26  Zan Dobersek  <zdobersek@igalia.com>

        XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
        https://bugs.webkit.org/show_bug.cgi?id=121951

        Reviewed by Carlos Garcia Campos.

        Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
        software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
        500 layout tests that trigger accelerated compositing to be used.

        * Scripts/webkitpy/port/xvfbdriver.py:
        (XvfbDriver._start):
        * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
        (XvfbDriverTest.test_start_no_pixel_tests):
        (XvfbDriverTest.test_start_pixel_tests):
        (XvfbDriverTest.test_start_arbitrary_worker_number):
        (XvfbDriverTest.test_next_free_display):
        (XvfbDriverTest.test_start_next_worker):

551 552 553 554 555 556 557 558 559 560 561 562
2013-09-26  Tim Horton  <timothy_horton@apple.com>

        Tiled drawing should not imply threaded scrolling
        https://bugs.webkit.org/show_bug.cgi?id=121874
        <rdar://problem/15071494>

        Reviewed by Sam Weinig.

        * WebKitTestRunner/mac/PlatformWebViewMac.mm:
        (WTR::PlatformWebView::PlatformWebView):
        The existing tiled-drawing layout tests require threaded scrolling to be enabled.

563 564 565 566 567 568 569 570 571 572 573
2013-09-26  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r156457.
        http://trac.webkit.org/changeset/156457
        https://bugs.webkit.org/show_bug.cgi?id=121960

        Broke webkitpy tests. (Requested by kling on #webkit).

        * Scripts/webkitpy/port/xvfbdriver.py:
        (XvfbDriver._start):

574 575 576 577 578 579 580 581 582 583 584 585 586 587
2013-09-26  Zan Dobersek  <zdobersek@igalia.com>

        XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
        https://bugs.webkit.org/show_bug.cgi?id=121951

        Reviewed by Carlos Garcia Campos.

        Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
        software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
        500 layout tests that trigger accelerated compositing to be used.

        * Scripts/webkitpy/port/xvfbdriver.py:
        (XvfbDriver._start):

588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603
2013-09-25  Alex Christensen  <achristensen@webkit.org>

        Removed check for Apple Application Support directory in WinCairo port.
        https://bugs.webkit.org/show_bug.cgi?id=121869

        Reviewed by Brent Fulgham.

        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
        * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
        * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
        Use DLLLauncherWinCairo.props for WinCairo ports.
        * win/DLLLauncher/DLLLauncherMain.cpp:
        (wWinMain):
        Don't call modifyPath to check for AAS in the WinCairo port.
        * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.

604 605 606 607 608 609 610 611 612 613 614 615 616 617 618
2013-09-25  Alex Christensen  <achristensen@webkit.org>

        Enabled AssembleBuildLogs on WinCairo port.
        https://bugs.webkit.org/show_bug.cgi?id=121923

        Reviewed by Brent Fulgham.

        * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
        Fixed reference to README, added WinCairo configurations.
        * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
        Fixed reference to README.
        * win/AssembleBuildLogs/AssembleLogs.cmd:
        Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
        * win/AssembleBuildLogs/README: Fixed spelling.

619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634
2013-09-25  Patrick Gansterer  <paroga@webkit.org>

        [WIN] Fix MSVC C4146 compiler warning
        https://bugs.webkit.org/show_bug.cgi?id=121838

        Reviewed by Brent Fulgham.

        Fix some variables from unsinged to int to fix the compiler warning
        "unary minus operator applied to unsigned type, result still unsigned".

        * DumpRenderTree/WorkQueueItem.h:
        (BackItem::BackItem):
        (ForwardItem::ForwardItem):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (createWebViewAndOffscreenWindow):

635 636 637 638 639 640 641 642 643 644 645 646
2013-09-25  Zan Dobersek  <zdobersek@igalia.com>

        [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
        https://bugs.webkit.org/show_bug.cgi?id=121256

        Reviewed by Martin Robinson.

        Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
        The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666
2013-09-25  Patrick Gansterer  <paroga@webkit.org>

        Add style checker for CMake lists
        https://bugs.webkit.org/show_bug.cgi?id=121764

        Reviewed by Ryosuke Niwa.

        Add an additional check to make sure that list of files are sorted.
        Exclude lists of include directories for now, since the order
        can be importent for compilation of some files.

        * Scripts/webkitpy/style/checkers/cmake.py:
        (CMakeChecker.check):
        (CMakeChecker._check_indent):
        (CMakeChecker):
        (CMakeChecker._check_list_order):
        (CMakeChecker._list_item_path):
        * Scripts/webkitpy/style/checkers/cmake_unittest.py:
        (CMakeCheckerTest.test_check):

667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691
2013-09-25  Patrick Gansterer  <paroga@webkit.org>

        CMakeChecker takes unusually long time to run
        https://bugs.webkit.org/show_bug.cgi?id=105662

        Reviewed by Ryosuke Niwa.

        Move the caching mechanism for regular expression of the C++ checker into
        a common file and use it for the CMake and ChangeLog checkers too.

        * Scripts/webkitpy/style/checkers/changelog.py:
        (ChangeLogChecker.check_entry):
        * Scripts/webkitpy/style/checkers/cmake.py:
        (CMakeChecker._process_line):
        (CMakeChecker._check_no_space_cmds):
        (CMakeChecker._check_one_space_cmds):
        (CMakeChecker._check_non_lowercase_cmd):
        * Scripts/webkitpy/style/checkers/common.py:
        (match):
        (search):
        (searchIgnorecase):
        (sub):
        (subn):
        * Scripts/webkitpy/style/checkers/cpp.py:

692 693 694 695 696 697 698 699 700 701 702 703 704
2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        [Qt] Fix build with Qt 5.2 QtPosition module
        https://bugs.webkit.org/show_bug.cgi?id=121089

        Reviewed by Simon Hausmann.

        QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
        that might depend on them.

        * qmake/mkspecs/features/default_pre.prf:
        * qmake/mkspecs/features/features.prf:

705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733
2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>

        [ATK] Fix style issues in AccessibilityUIElementAtk
        https://bugs.webkit.org/show_bug.cgi?id=121898

        Reviewed by Chris Fleizach.

        Avoid the '.f' suffix for float literals and use G_VALUE_INIT
        instead of { 0, { { 0 } } } to initialize a GValue.

        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
        (AccessibilityUIElement::clickPointX): Remove suffix.
        (AccessibilityUIElement::clickPointY): Ditto.
        (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
        (AccessibilityUIElement::minValue): Ditto.
        (AccessibilityUIElement::maxValue): Ditto.
        (AccessibilityUIElement::numberAttributeValue): Remove suffix.
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
        (WTR::AccessibilityUIElement::x): Ditto.
        (WTR::AccessibilityUIElement::y): Ditto.
        (WTR::AccessibilityUIElement::width): Ditto.
        (WTR::AccessibilityUIElement::height): Ditto.
        (WTR::AccessibilityUIElement::clickPointX): Ditto.
        (WTR::AccessibilityUIElement::clickPointY): Ditto.
        (WTR::AccessibilityUIElement::intValue): Ditto.
        (WTR::AccessibilityUIElement::minValue): Ditto.
        (WTR::AccessibilityUIElement::maxValue): Ditto.

734 735 736 737 738 739 740 741 742 743 744 745 746
2013-09-25  Krzysztof Czech  <k.czech@samsung.com>

        [EFL] accessibility/loading-iframe-sends-notification.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=112003

        Reviewed by Mario Sanchez Prada.

        Enabled addNotificationListener and removeNotificationListener for EFL port.

        * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
        (WTR::AccessibilityController::removeNotificationListener):

747 748 749 750 751 752 753 754 755
2013-09-24  Filip Pizlo  <fpizlo@apple.com>

        Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
        https://bugs.webkit.org/show_bug.cgi?id=121844

        Reviewed by Mark Hahnenberg.

        * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.

756 757 758 759 760 761 762 763 764 765 766
2013-09-24  Alexey Proskuryakov  <ap@apple.com>

        [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
        https://bugs.webkit.org/show_bug.cgi?id=121854

        Reviewed by Anders Carlsson.

        * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
        (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
        settings in underlying frameworks.

767 768 769 770 771 772 773 774 775 776 777 778
2013-09-24  Mark Rowe  <mrowe@apple.com>

        <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8

        Reviewed by Dan Bernstein.

        * DumpRenderTree/mac/Configurations/Base.xcconfig:
        * MiniBrowser/Configurations/Base.xcconfig:
        * TestWebKitAPI/Configurations/Base.xcconfig:
        * WebKitLauncher/Configurations/Base.xcconfig:
        * WebKitTestRunner/Configurations/Base.xcconfig:

779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804
2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>

        [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
        https://bugs.webkit.org/show_bug.cgi?id=121674

        Reviewed by Mario Sanchez Prada.

        Implemented the global notification listener for
        AccessibilityController. The signal is generated by
        AXObjectCache::postPlatformNotification() and received by
        axObjectEventListener(). axObjectEventListener will then invoke
        JSObjectCallAsFunction() with the respective callback function.

        There is no additional test for this patch since its implementation will
        be tested by an accessibility layout test that is currently failing
        (accessibility/loading-iframe-sends-notification.html).

        * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
        stub implementations of addNotificationListener and
        removeNotificationListener for the GTK port.
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
        (WTR::AccessibilityController::addNotificationListener): Creates the
        notification handler and sets the notification function callback.
        (WTR::AccessibilityController::removeNotificationListener): Removes the
        global handler.

805 806 807 808 809 810 811 812 813 814 815 816
2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>

        [GTK] fast/images/exif-orientation-composited.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=119731

        Reviewed by Carlos Garcia Campos.

        Add handling respect image orientation property in DRT.

        * DumpRenderTree/gtk/TestRunnerGtk.cpp:
        (TestRunner::overridePreference):

817 818 819 820 821 822 823 824 825 826
2013-09-24  Zan Dobersek  <zdobersek@igalia.com>

        [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
        https://bugs.webkit.org/show_bug.cgi?id=121787

        Reviewed by Gustavo Noronha Silva.

        * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
        with the Wayland target enabled to version 3.10.0.

827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844
2013-09-23  Patrick Gansterer  <paroga@webkit.org>

        use NOMINMAX instead of #define min min
        https://bugs.webkit.org/show_bug.cgi?id=73563

        Reviewed by Brent Fulgham.

        Use NOMINMAX instead of #define min/max as a cleaner
        way of ensuring that Windows system header files don't
        define min/max as macro in the first place.

        * DumpRenderTree/DumpRenderTreePrefix.h:
        * DumpRenderTree/cg/ImageDiffCG.cpp:
        * DumpRenderTree/config.h:
        * DumpRenderTree/win/ImageDiffCairo.cpp:
        * WebKitTestRunner/WebKitTestRunnerPrefix.h:
        * WebKitTestRunner/config.h:

845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894
2013-09-23  Benjamin Poulain  <benjamin@webkit.org>

        Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
        https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>

        Reviewed by Alexey Proskuryakov.

        Previously, initalizing a WebPreference would change the cache model
        to WebCacheModelDocumentBrowser. That behavior was due to a stale
        preference file on disk.

        This patch fixes the tests by resetting the default, and using the proper
        default values after initializing WebPreference.

        * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
        (TestWebKitAPI::TEST): Use the proper initial value, unrelated
        to the previous runs.

        * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
        (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
        cache model to the one required.

        * TestWebKitAPI/ios/mainIOS.mm:
        (main): Reset the preferences before testing.
        * TestWebKitAPI/mac/mainMac.mm:
        (main): Ditto.

2013-09-23  Benjamin Poulain  <benjamin@webkit.org>

        Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
        https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>

        Reviewed by Alexey Proskuryakov.

        Previously, initalizing a WebPreference would change the cache model
        to WebCacheModelDocumentBrowser. That behavior was due to a stale
        preference file on disk.

        This patch fixes the tests by resetting the default, and using the proper
        default values after initializing WebPreference.

        * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
        (TestWebKitAPI::TEST): Use the proper initial value, unrelated
        to the previous runs.

        * TestWebKitAPI/ios/mainIOS.mm:
        (main): Reset the preferences before testing.
        * TestWebKitAPI/mac/mainMac.mm:
        (main): Ditto.

895 896 897 898 899 900 901 902 903 904 905
2013-09-23  Anders Carlsson  <andersca@apple.com>

        ListHashSet should work with move-only types
        https://bugs.webkit.org/show_bug.cgi?id=121802

        Reviewed by Andreas Kling.

        * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
        (TestWebKitAPI::TEST):
        Add a test for move-only types.

906 907 908 909 910 911 912 913 914 915 916 917
2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>

        Added --64-bit option for Windows build.
        https://bugs.webkit.org/show_bug.cgi?id=121799

        Reviewed by Brent Fulgham.

        * Scripts/webkitdirs.pm:
        (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
        (isWin64): Added.
        (determineIsWin64): Added.

918 919 920 921 922 923 924 925 926 927 928 929
2013-09-23  Anders Carlsson  <andersca@apple.com>

        ListHashSet should use std::reverse_iterator for reverse iterators
        https://bugs.webkit.org/show_bug.cgi?id=121795

        Reviewed by Antti Koivisto.

        Add test for reverse iterators.

        * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
        (TestWebKitAPI::TEST):

930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948
2013-09-23  Krzysztof Czech  <k.czech@samsung.com>

        [EFL] accessibility/aria-invalid is failing
        https://bugs.webkit.org/show_bug.cgi?id=111986

        Reviewed by Mario Sanchez Prada.

        Adds possibility to retrieve JS context.
        This is part of the implementation of AccessibilityUIElement::addNotificationListener
        from 119883 and 120421.

        * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
        (axObjectEventListener):
        (addAccessibilityNotificationHandler):
        (removeAccessibilityNotificationHandler):
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
        (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
        (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):

949 950 951 952 953 954 955 956 957 958 959
2013-09-20  Mark Rowe  <mrowe@apple.com>

        <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date

        Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.

        Reviewed by David Kilzer.

        * Scripts/webkitdirs.pm:
        (checkRequiredSystemConfig):

960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985
2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>

        [ATK] Do not expose aria-help in ATK based platforms
        https://bugs.webkit.org/show_bug.cgi?id=121675

        Reviewed by Chris Fleizach.

        Remove the implementations for AccessibilityUIElement::helpText()
        from DRT and WKTR for GTK and EFL, since they are based on the
        AccessibilityObject::helpText() method and the 'aria-help'
        attributes, which is wrong since they should not depend on that
        but in ATK specific API (see also http://webkit.org/b/121684).

        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
        (AccessibilityUIElement::helpText): Added a new and empty
        implementation, now that we are no longer using this in ATK.
        * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
        as the only function provided here was helpText().
        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
        * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
        removed from the list of sources to compile.
        * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        (WTR::AccessibilityUIElement::helpText): Replaced old implementation
        based in DumpRenderTreeSupportGtk with an empty one.

986 987 988 989 990 991 992 993 994 995 996 997 998 999
2013-09-20  Dan Bernstein  <mitz@apple.com>

        Make extract-localizable-strings available to WebCore clients
        https://bugs.webkit.org/show_bug.cgi?id=121699

        Reviewed by Darin Adler.

        * Scripts/extract-localizable-strings: Copied to
        Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
        executes the script from its new location. This is a temporary measure until certain code
        that is external to WebKit is adapted to the new location.
        * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
        from its new location.

1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016
2013-09-20  Patrick Gansterer  <paroga@webkit.org>

        Nuke remaining VS2005 tools from the tree.
        https://bugs.webkit.org/show_bug.cgi?id=121691

        Reviewed by Brent Fulgham.

        * CLWrapper/CLWrapper.cpp: Removed.
        * CLWrapper/CLWrapper.sln: Removed.
        * CLWrapper/CLWrapper.vcproj: Removed.
        * MIDLWrapper/MIDLWrapper.cpp: Removed.
        * MIDLWrapper/MIDLWrapper.sln: Removed.
        * MIDLWrapper/MIDLWrapper.vcproj: Removed.
        * Scripts/parallelcl: Removed.
        * vcbin/cl.exe: Removed.
        * vcbin/midl.exe: Removed.

1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030
2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>

        [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
        https://bugs.webkit.org/show_bug.cgi?id=121294

        Reviewed by Martin Robinson.

        Provide a new patch to deal with the issue in the GTK+ module from
        the internal jhbuild environment. This issue has been reported
        upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).

        * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
        * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.

1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044
2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>

        [ATK][WTR] accessibility/aria-invalid.html times out
        https://bugs.webkit.org/show_bug.cgi?id=121668

        Reviewed by Mario Sanchez Prada.

        Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
        false in case of aria-invalid event with empty value.

        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
        case of aria-invalid event with empty value.

1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116
2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>

        [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
        https://bugs.webkit.org/show_bug.cgi?id=120421

        Reviewed by Mario Sanchez Prada.

        Implemented the notification listener for AccessibilityUIElement for
        WebKitTestRunner. The signal is generated by
        AXObjectCache::postPlatformNotification() and received by
        axObjectEventListener(). axObjectEventListener() will then invoke
        JSObjectCallAsFunction() with the respective callback function. The
        notification handlers are stored in HashMap in
        AccessibilityNotificationHandlerAtk.cpp.

        Moved ATK signal handling (printAccessibilityEvent and
        axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.

        * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
        include path.
        * WebKitTestRunner/GNUmakefile.am:
        Added AccessibilityNotificationHandlerAtk.cpp/h.
        * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
        listener IDs to AccessibilityNotificationHandlerAtk.cpp.
        * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
        listener IDs to AccessibilityNotificationHandlerAtk.cpp.
        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
        notification handler for GTK+ and EFL.
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
        Moved printAccessibilityEvent and axObjectEventListener to
        AccessibilityNotificationHandlerAtk.cpp.
        (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
        IDs to AccessibilityNotificationHandlerAtk.cpp.
        (WTR::AccessibilityController::resetToConsistentState): Moved listener
        IDs to AccessibilityNotificationHandlerAtk.cpp.
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
        (WTR::printAccessibilityEvent): Prints accessibility events. This
        function was moved from AccessibilityControllerAtk.cpp.
        (WTR::axObjectEventListener): Callback for signals. This function was
        moved from AccessibilityControllerAtk.cpp.
        (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
        Initialize element and function callback.
        (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
        Removes handler from HashMap and disconnects callbacks if necessary.
        (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
        logging mode and connects callbacks.
        (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
        Sets the notification callback and connects callback to signals.
        (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
        Removes the notification callback from HashMap.
        (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
        Connects axObjectEventListener to ATK signals.
        (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
        Disconnects callback.
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
        (WTR::AccessibilityNotificationHandler::create): Creates a new instance
        of AccessibilityNotificationHandler.
        (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
        element.
        (WTR::AccessibilityNotificationHandler::platformElement): Gets the
        element.
        (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
        Gets the notification callback.
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        (WTR::AccessibilityUIElement::addNotificationListener): Creates
        notification handler, set the platform element and the notification
        callback.
        (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
        notification handler.
        * WebKitTestRunner/PlatformEfl.cmake:
        Added AccessibilityNotificationHandlerAtk.cpp.

allan.jensen@digia.com's avatar
allan.jensen@digia.com committed
1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127
2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        Update features.pri
        https://bugs.webkit.org/show_bug.cgi?id=121670

        Reviewed by Jocelyn Turcotte.

        Remove feature flags that no longer exists and new ones added to FeatureList.pm

        * qmake/mkspecs/features/features.pri:

1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138
2013-09-20  Krzysztof Czech  <k.czech@samsung.com>

        [GTK][WK2] accessibility/selection-states.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=116972

        Reviewed by Mario Sanchez Prada.

        isSelectable() was not exposed in Accessibility.

        * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:

1139 1140 1141 1142 1143 1144
2013-09-19  Dan Bernstein  <mitz@apple.com>

        Attempted build fix after r156114.

        * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.

1145 1146 1147 1148 1149 1150 1151 1152 1153 1154
2013-09-19  Alexey Proskuryakov  <ap@apple.com>

        REGRESSION (r129451): run-safari --no-saved-state is broken
        https://bugs.webkit.org/show_bug.cgi?id=121566

        Undo a last minute change that doesn't actually work.

        * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
        via command line, <rdar://problem/15032886>.

1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168
2013-09-19  Dan Bernstein  <mitz@apple.com>

        Add a style guideline regarding spacing in range-based for loops
        https://bugs.webkit.org/show_bug.cgi?id=121620

        Reviewed by Anders Carlsson.

        * Scripts/webkitpy/style/checkers/cpp.py:
        (check_spacing): Added checking that there are spaces around the colon in a range-based for
        loop.
        (CppChecker): Added whitespace/colon to the categories set.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (WebKitStyleTest.test_spacing): Added two tests for the new check.

1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187
2013-09-18  Sam Weinig  <sam@webkit.org>

        Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
        https://bugs.webkit.org/show_bug.cgi?id=121588

        Reviewed by Anders Carlsson.

        * DumpRenderTree/TestRunner.cpp:
        * ImageDiff/efl/ImageDiff.cpp:
        * TestWebKitAPI/JavaScriptTest.cpp:
        * TestWebKitAPI/PlatformUtilities.cpp:
        * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
        * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        * WebKitTestRunner/StringFunctions.h:
        * WebKitTestRunner/TestInvocation.cpp:
        * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
        * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231
2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>

        W3C Test Import script reformats test HTML
        https://bugs.webkit.org/show_bug.cgi?id=119159

        Reviewed by Dirk Pranke.

        Completely rewrite the test conversion process to minimize
        reformatting when adding prefixes, etc. This isn't 100% perfect, there
        are still places where it will end up changing the formatting, but it
        is much better than before. Most notably, the public interface to the
        test converter has changed: now one calls a method instead of creating
        an instance of the test converter class. This is because the test
        converter class now has state, so one really needs a new instance for
        each test.

        Note that this also lays some simple groundwork for being able to use
        a MockHost in the tests.

        * Scripts/webkitpy/w3c/test_converter.py:
        (convert_for_webkit):
        (_W3CTestConverter):
        (_W3CTestConverter.__init__):
        (_W3CTestConverter.output):
        (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
        (_W3CTestConverter.convert_style_data):
        (_W3CTestConverter.convert_attributes_if_needed):
        (_W3CTestConverter.handle_starttag):
        (_W3CTestConverter.handle_endtag):
        (_W3CTestConverter.handle_startendtag):
        (_W3CTestConverter.handle_data):
        (_W3CTestConverter.handle_entityref):
        (_W3CTestConverter.handle_charref):
        (_W3CTestConverter.handle_comment):
        (_W3CTestConverter.handle_decl):
        (_W3CTestConverter.handle_pi):
        * Scripts/webkitpy/w3c/test_converter_unittest.py:
        (W3CTestConverterTest):
        (W3CTestConverterTest.fake_dir_path):
        (W3CTestConverterTest.test_read_prefixed_property_list):
        (verify_no_conversion_happened):
        * Scripts/webkitpy/w3c/test_importer.py:
        (TestImporter.import_tests):

1232 1233 1234 1235 1236 1237 1238 1239 1240
2013-09-18  Filip Pizlo  <fpizlo@apple.com>

        Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
        https://bugs.webkit.org/show_bug.cgi?id=121578

        Rubber stamped by Geoffrey Garen.

        * Scripts/run-layout-jsc:

1241 1242 1243 1244 1245 1246
2013-09-18  Filip Pizlo  <fpizlo@apple.com>

        Unreviewed, fix for Ruby 1.8.

        * Scripts/run-jsc-stress-tests:

1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266
2013-09-17  Filip Pizlo  <fpizlo@apple.com>

        run-jsc-stress-tests should make it easier to look at error spew from tests
        https://bugs.webkit.org/show_bug.cgi?id=121531

        Reviewed by Mark Hahnenberg.
        
        This makes two changes:
        
        - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
        
        - The same spew also goes to the console but is prefixed by the test's name.
        
        This required some tee and awk hacks, and then some sh hacks to work around the fact
        that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
        operator will only see a failure of bar failed. So to pass output to tee and awk, I
        needed to do weird things.

        * Scripts/run-jsc-stress-tests:

1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277
2013-09-18  Alexey Proskuryakov  <ap@apple.com>

        REGRESSION (r129451): run-safari --no-saved-state is broken
        https://bugs.webkit.org/show_bug.cgi?id=121566

        Reviewed by Mark Rowe.

        * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
        Check arguments, not the newly created empty array. Pass a value that silences warnings.
        While at it, removed a check for Snow Leopard.

1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290
2013-09-18  Alex Christensen  <achristensen@webkit.org>

        Improved WinLauncher's URL handling.
        https://bugs.webkit.org/show_bug.cgi?id=121535

        Reviewed by Brent Fulgham.

        * WinLauncher/WinLauncher.cpp:
        (EditProc):
        Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
        (loadURL):
        Prepend "http://" to URLs with no scheme.

1291 1292 1293 1294 1295 1296 1297 1298 1299
2013-09-18  Filip Pizlo  <fpizlo@apple.com>

        DFG should support Int52 for local variables
        https://bugs.webkit.org/show_bug.cgi?id=121064

        Reviewed by Oliver Hunt.

        * Scripts/run-jsc-stress-tests:

1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313
2013-09-18  peavo@outlook.com  <peavo@outlook.com>

        [Win] TestWebKitAPI does not compile.
        https://bugs.webkit.org/show_bug.cgi?id=121485

        Reviewed by Brent Fulgham.

        It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
        Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
        to return null, which is the case we want to test.

        * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
        (TestWebKitAPI::TEST):

1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332
2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>

        [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
        https://bugs.webkit.org/show_bug.cgi?id=121495

        Reviewed by Chris Fleizach.

        Adapted DRT and WKTR to deal with the new names for the ATK object
        attributes being exposed for 'aria-haspopup' and 'aria-sort'.

        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
        (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
        (AccessibilityUIElement::stringAttributeValue): Ditto.
        (AccessibilityUIElement::hasPopup): Ditto.
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
        (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
        (WTR::AccessibilityUIElement::hasPopup): Ditto.

1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343
2013-09-18  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r156019 and r156020.
        http://trac.webkit.org/changeset/156019
        http://trac.webkit.org/changeset/156020
        https://bugs.webkit.org/show_bug.cgi?id=121540

        Broke tests (Requested by ap on #webkit).

        * Scripts/run-jsc-stress-tests:

1344 1345 1346 1347 1348 1349
2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>

        Unreviewed. Add myself as a committer.

        * Scripts/webkitpy/common/config/contributors.json:

1350 1351 1352 1353 1354 1355
2013-09-17  Jae Hyun Park  <jae.park@company100.net>

        Unreviewed. Add myself as a committer.

        * Scripts/webkitpy/common/config/contributors.json:

1356 1357 1358 1359 1360 1361 1362 1363 1364
2013-09-17  Filip Pizlo  <fpizlo@apple.com>

        DFG should support Int52 for local variables
        https://bugs.webkit.org/show_bug.cgi?id=121064

        Reviewed by Oliver Hunt.

        * Scripts/run-jsc-stress-tests:

1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380
2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>

        Added back and forward buttons to WinLauncher.
        https://bugs.webkit.org/show_bug.cgi?id=121212

        Reviewed by Brent Fulgham.

        * WinLauncher/WinLauncher.cpp:
        (resizeSubViews):
        Move new back and forward buttons to correct positions before URL bar.
        (dllLauncherEntryPoint): 
        Store the default button window procedure and replace with my button procedures.
        (EditProc): Updated style and renamed from MyEditProc.
        (BackButtonProc): Added.
        (ForwardButtonProc): Added.

1381 1382 1383 1384 1385 1386 1387 1388
2013-09-17  Michael Saboff  <msaboff@apple.com>

        Unreviewed typo fix after r155999

        Changed en_US.UTB-8 to en_US.UTF-8

        * Scripts/run-javascriptcore-tests:

1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399
2013-09-17  Michael Saboff  <msaboff@apple.com>

        run-jsc-stress-tests fails with ruby version 2
        https://bugs.webkit.org/show_bug.cgi?id=121521

        Reviewed by Jessie Berlin.

        Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.

        * Scripts/run-javascriptcore-tests:

1400 1401 1402 1403 1404 1405 1406
2013-09-17  Brent Fulgham  <bfulgham@apple.com>

        [Windows] Unreviewed build fix after r155963.

        * DumpRenderTree/win/TestRunnerWin.cpp:
        (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.

andersca@apple.com's avatar
andersca@apple.com committed
1407 1408 1409 1410 1411 1412 1413
2013-09-17  Anders Carlsson  <andersca@apple.com>

        Fix a typo.

        * TestWebKitAPI/Tests/WTF/HashMap.cpp:
        (TestWebKitAPI::TEST):

1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424
2013-09-16  Anders Carlsson  <andersca@apple.com>

        HashMap should work with move-only keys
        https://bugs.webkit.org/show_bug.cgi?id=121310

        Reviewed by Darin Adler.

        * TestWebKitAPI/Tests/WTF/HashMap.cpp:
        (TestWebKitAPI::TEST):
        Add test.

berto@igalia.com's avatar
berto@igalia.com committed
1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435
2013-09-17  YuTeh Shen  <shenyute@hotmail.com>

        BrowserMarshal.h build fail
        https://bugs.webkit.org/show_bug.cgi?id=102938

        Reviewed by Carlos Garcia Campos.

        Fix variable name.

        * MiniBrowser/gtk/GNUmakefile.am:

1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457
2013-09-16  Brent Fulgham  <bfulgham@apple.com>

        [Windows] Clean up WinLauncher by using smart pointers
        https://bugs.webkit.org/show_bug.cgi?id=121467

        Reviewed by Anders Carlsson.

        * WinLauncher/PrintWebUIDelegate.cpp:
        (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
        * WinLauncher/WinLauncher.cpp:
        (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
        (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
        (showLastVisitedSites): Smart pointer updates.
        (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
        (setToDefaultPreferences): Ditto.
        (dllLauncherEntryPoint): Ditto.
        (PrintView): Ditto.
        (LaunchInspector): Ditto.
        (NavigateToHistory): Ditto.
        (MyEditProc): Ditto.
        (loadURL): Ditto.

1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480
2013-09-16  Brent Fulgham  <bfulgham@apple.com>

        [Windows] Add rudimentary history to WinLauncher.
        https://bugs.webkit.org/show_bug.cgi?id=121463

        Reviewed by Anders Carlsson.

        * WinLauncher/WinLauncher.cpp:
        (updateMenuItemForHistoryItem): Added
        (showLastVisitedSites): Added
        (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
        a new page has been visited.
        (dllLauncherEntryPoint): Deallocate history on exit.
        (NavigateToHistory): Added
        (WndProc): Add handler for history entries
        * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
        up to 10 history slots.
        * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
        Windows utility library to allow use of _bstr_t type.
        * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
        to hold up to 10 history slots.
        * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.

1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499
2013-09-16  Gustavo Noronha Silva  <gns@gnome.org>

        [GTK] Make symbol export filter more strict, and disable for dev/test builds
        https://bugs.webkit.org/show_bug.cgi?id=120586

        Reviewed by Martin Robinson.

        * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
        makefiles, so they can be included unconditionally.
        * GtkLauncher/GNUmakefile.am: added.
        * Scripts/webkitdirs.pm:
        (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
        to configure, since we consider builds done through build-webkit to be development
        and test builds.
        * gtk/GNUmakefile.am: added.
        * gtk/common.py: do not use the Scripts directory as a reference to the top path;
        it's not necessary and it will not work now that the Scripts directory is not
        shipped in the tarball.

1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510
2013-09-16  Anders Carlsson  <andersca@apple.com>

        WTF::Deque should work with move only types
        https://bugs.webkit.org/show_bug.cgi?id=121446

        Reviewed by Andreas Kling.

        * TestWebKitAPI/Tests/WTF/Deque.cpp:
        (TestWebKitAPI::TEST):
        Add a test.

1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527
2013-09-16  Wojciech Bielawski  <w.bielawski@samsung.com>

        [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
        https://bugs.webkit.org/show_bug.cgi?id=98410

        Reviewed by Darin Adler.

        Add implementation of click() method of objects returned by eventSender.contextClick().

        * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
        (MenuItemPrivateData):
        (WTR::menuItemClickCallback):
        (WTR::getMenuItemTitleCallback):
        (WTR::staticMenuItemFinalize):
        (WTR::getMenuItemClass):
        (WTR::EventSendingController::contextClick):

1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545
2013-09-15  Zan Dobersek  <zdobersek@igalia.com>

        Make the GDB webkit.py script compatible with Python v3
        https://bugs.webkit.org/show_bug.cgi?id=121395

        Reviewed by Ryosuke Niwa.

        GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
        uses of xrange() in the script are replaced with range(), and the print statements are changed into
        the print() function invocations.

        * gdb/webkit.py:
        (guess_string_length):
        (ustring_to_string):
        (lstring_to_string):
        (WTFCStringPrinter.to_string):
        (PrintPathToRootCommand.invoke):

1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594
2013-09-15  Zan Dobersek  <zdobersek@igalia.com>

        [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
        https://bugs.webkit.org/show_bug.cgi?id=119631

        Reviewed by Ryosuke Niwa.

        The perf profiler is attached to the test runner after the test runner has been launched,
        but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
        UIProcess, meaning that WebProcess operations will not be profiled.

        To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
        This is done in the scope of already present support for wrapper scripts (such as valgrind)
        that are settable through the --wrapper option. This causes the perf profiler to correctly
        continue profiling the WebProcess after it was spawned.

        When the profiler is launched, a wait process is launched with the profiler's pid as the
        argument. This ensures we can check that the profiler exited normally. If it did not, its
        output can be corrupted and can cause problems when that output is examined. The after-exit
        report is avoided in that case.

        * Scripts/webkitpy/common/system/profiler.py:
        (Profiler.wrapper_arguments): The method returns an empty list by default.
        (Perf.__init__): Remove unnecessary member variables.
        (Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
        (Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
        the method returns a list of arguments that should be used as a wrapper for the test runner.
        The arguments specify the 'perf record' command, with the output file and the instruction to
        construct the call graph given as well.
        (Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
        whitespace in the profile lines.
        (Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
        running. If it is running even after that, or if the profiler process produced a non-zero exit
        code, the method reports the profiling failure and returns. Otherwise it continues on reporting
        the top 10 lines of the profile and how to examine the profile further.
        * Scripts/webkitpy/port/driver.py:
        (Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
        as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
        or an empty list otherwise.
        (Driver.cmd_line):
        * Scripts/webkitpy/port/driver_unittest.py:
        (DriverTest.make_port): Adjusted so mock host or options objects can be specified
        for the testing-specific Port object.
        (DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
        as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
        a parameter.
        (DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
        when profiling on the Linux platform with the perf profiler.

1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606
2013-09-14  Dan Bernstein  <mitz@apple.com>

        [mac] Check For Framework Include Consistency build phase checks the wrong framework
        https://bugs.webkit.org/show_bug.cgi?id=121215

        Reviewed by Mark Rowe.

        * Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
        WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
        public and private headers folder paths. Also tweaked the error messages’ format to make
        Xcode recognize them as errors.

1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619
2013-09-14  Alberto Garcia  <berto@igalia.com>

        [GTK] Fails to compile if the build directory is in a different partition
        https://bugs.webkit.org/show_bug.cgi?id=121296

        Reviewed by Martin Robinson.

        Instead of using os.symlink() to install the gtk-doc templates,
        use os.link() first and fall back to os.symlink() if it fails.

        * gtk/gtkdoc.py:
        (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):

1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633
2013-09-14  Alberto Garcia  <berto@igalia.com>

        [GTK] WebKitGTK+ is linking against libxslt in too many places
        https://bugs.webkit.org/show_bug.cgi?id=121356

        Reviewed by Martin Robinson.

        TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
        so we don't need to link against it.

        * MiniBrowser/gtk/GNUmakefile.am:
        * TestWebKitAPI/GNUmakefile.am:
        * WebKitTestRunner/GNUmakefile.am:

1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644
2013-09-14  Ross Burton  <ross.burton@intel.com>

        Uses gtk-doc tools even when --disable-gtk-doc passed
        https://bugs.webkit.org/show_bug.cgi?id=91239

        Reviewed by Martin Robinson.

        Don't run generate-gtkdoc on install if gtk-doc is disabled.

        * GNUmakefile.am:

1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657
2013-09-14  Alberto Garcia  <berto@igalia.com>

        [GTK] Fails to compile if the build directory is in a different partition
        https://bugs.webkit.org/show_bug.cgi?id=121296

        Reviewed by Carlos Garcia Campos.

        Use symlinks instead of hard links to support building on a
        different file system.

        * gtk/gtkdoc.py:
        (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):

1658 1659 1660 1661 1662 1663 1664 1665 1666
2013-09-13  Darin Adler  <darin@apple.com>

        Use a better name than m_invertibleCTM
        https://bugs.webkit.org/show_bug.cgi?id=121341

        Reviewed by Andreas Kling.

        * Scripts/do-webcore-rename: Updated to do this replace as we do.

1667 1668 1669 1670 1671 1672 1673 1674 1675 1676
2013-09-13  Anders Carlsson  <andersca@apple.com>

        Pick the correct overload when a const reference is passed to appendSlowCase.
        https://bugs.webkit.org/show_bug.cgi?id=121326

        Reviewed by Darin Adler.

        * TestWebKitAPI/Tests/WTF/Vector.cpp:
        (TestWebKitAPI::TEST):

1677 1678 1679 1680 1681 1682 1683 1684 1685
2013-09-13  Darin Adler  <darin@apple.com>

        Rename confusingly named "runtimeObject" functions
        https://bugs.webkit.org/show_bug.cgi?id=121339

        Reviewed by Sam Weinig.

        * Scripts/do-webcore-rename: Updated to do this replace as usual.

1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696
2013-09-13  Filip Pizlo  <fpizlo@apple.com>

        DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
        https://bugs.webkit.org/show_bug.cgi?id=121330

        Reviewed by Mark Hahnenberg and Oliver Hunt.

        We should run tests even if they don't have expected files yet.
        
        * Scripts/run-layout-jsc:

1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708
2013-09-13  Anders Carlsson  <andersca@apple.com>

        Use nullptr instead of 0 in calls to HashMap::add
        https://bugs.webkit.org/show_bug.cgi?id=121322

        Reviewed by Sam Weinig.

        * DumpRenderTree/mac/TestRunnerMac.mm:
        (TestRunner::evaluateScriptInIsolatedWorld):
        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        (WTR::TestRunner::evaluateScriptInIsolatedWorld):

1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725
2013-09-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>

        [GTK] Move to the new web inspector
        https://bugs.webkit.org/show_bug.cgi?id=120647

        Reviewed by Carlos Garcia Campos.

        * GtkLauncher/main.c:
        (main): no longer set WEBKIT_INSPECTOR_PATH.
        * MiniBrowser/gtk/main.c:
        (main): ditto.
        * Scripts/old-run-webkit-tests:
        (openDumpTool): ditto.
        * Scripts/run-gtk-tests: ditto.
        * Scripts/webkitpy/port/gtk.py:
        (GtkPort.setup_environ_for_server): ditto.

1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737
2013-09-13  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        [Qt] REGRESSION(r154444): xss-DENIED test results changed
        https://bugs.webkit.org/show_bug.cgi?id=120595

        Reviewed by Jocelyn Turcotte.

        Avoid overwriting Qt meta properties, which we identify by them being undeletable.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (DumpRenderTree::initJSObjects):

1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748
2013-09-13  Darin Adler  <darin@apple.com>

        Give actions in Range class NON_SHOUTING_NAMES
        https://bugs.webkit.org/show_bug.cgi?id=121280

        Reviewed by Andreas Kling.

        * Scripts/do-webcore-rename: Updated to do this replace, keeping with
        the tradition of checking in the last one we did, along with other
        rename ideas for the future.

1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760
2013-09-12  Lucas Forschler  <lforschler@apple.com>

        Create short build logs for errors and warnings.
        https://bugs.webkit.org/show_bug.cgi?id=120614

        Reviewed by Ryosuke Niwa.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
            -include StringIO 
        (CompileWebKit.createSummary):
            -add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing

1761 1762 1763 1764 1765 1766 1767
2013-09-12  Roger Fong  <roger_fong@apple.com>

        Update cygwin downloader to search for packages in the right location.

        * CygwinDownloader/cygwin-downloader.py:
        * CygwinDownloader/cygwin-downloader.zip:

1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778
2013-09-12  Anders Carlsson  <andersca@apple.com>

        Add rudimentary support for move-only types as values in HashMap
        https://bugs.webkit.org/show_bug.cgi?id=121226

        Reviewed by Andreas Kling.

        * TestWebKitAPI/Tests/WTF/HashMap.cpp:
        (TestWebKitAPI::TEST):
        Add a HashMap<unsigned, MoveOnly> test.

1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816
2013-09-12  Gabor Abraham  <abrhm@inf.u-szeged.hu>

        Auto GDB backtrace generation for EFL/GTK/Qt bots.
        https://bugs.webkit.org/show_bug.cgi?id=119338

        Reviewed by Csaba Osztrogonác.

        * Scripts/webkitpy/port/efl.py:
        (EflPort.check_sys_deps):
        (EflPort):
        (EflPort._get_crash_log):
        * Scripts/webkitpy/port/efl_unittest.py:
        (EflPortTest.test_show_results_html_file):
        (EflPortTest):
        (EflPortTest.test_get_crash_log):
        * Scripts/webkitpy/port/gtk.py:
        (GtkPort._get_crash_log):
        * Scripts/webkitpy/port/gtk_unittest.py:
        (GtkPortTest.test_get_crash_log):
        * Scripts/webkitpy/port/linux_get_crash_log.py: Added.
        (GDBCrashLogGenerator):
        (GDBCrashLogGenerator.__init__):
        (GDBCrashLogGenerator._get_gdb_output):
        (GDBCrashLogGenerator.generate_crash_log):
        (GDBCrashLogGenerator.generate_crash_log.match_filename):
        * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
        (GDBCrashLogGeneratorTest):
        (GDBCrashLogGeneratorTest.test_generate_crash_log):
        (_mock_gdb_output):
        * Scripts/webkitpy/port/qt.py:
        (QtPort.default_child_processes):
        (QtPort):
        (QtPort._get_crash_log):
        * Scripts/webkitpy/port/qt_unittest.py:
        (QtPortTest.test_check_sys_deps):
        (QtPortTest):
        (QtPortTest.test_get_crash_log):

1817 1818 1819 1820 1821 1822
2013-09-12  Peter Gal  <galpeter@inf.u-szeged.hu>

        Unreviewed. Moving myself to the commiters list.

        * Scripts/webkitpy/common/config/contributors.json:

1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835
2013-09-12  ChangSeok Oh  <changseok.oh@collabora.com>

        [GTK] Add jhbuild-wayland.modules
        https://bugs.webkit.org/show_bug.cgi?id=120455

        Reviewed by Gustavo Noronha Silva.

        Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
        With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
        WEBKIT_EXTRA_MODULESETS.

        * gtk/jhbuild-wayland.modules: Added.

1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850
2013-09-12  Mario Sanchez Prada  <mario.prada@samsung.com>

        [GTK][WK2] a11y tests unconditionally launching a11y daemons
        https://bugs.webkit.org/show_bug.cgi?id=120299

        Reviewed by Carlos Garcia Campos.

        Use the right variable name to store a reference to the at-spi2
        bus launcher process, so we can be sure we are terminating it when
        calling _tear_down_testing_environment().

        * Scripts/run-gtk-tests:
        (TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
        instead of _ally_bus_launcher.

1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872
2013-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
        https://bugs.webkit.org/show_bug.cgi?id=121218

        Reviewed by Philippe Normand.

        Skipping the entire suite was added to skip tests when they can't
        be run because of the environment, for example to skip the a11y
        tests when the at-spi daemons fail to start. This is no longer
        true for all the cases, so we can disable the tests that are
        impossible to run instead of skipping them.

        * Scripts/run-gtk-tests:
        (TestRunner.__init__): Initialize the skipped tests list.
        (TestRunner._setup_testing_environment): Add
        TestWebKitAccessibility path to the list of disabled tests when
        at-spi daemon fail to start.
        (TestRunner._should_run_test_program): Check first if the test
        program is disabled and then whether it's skipped honoring the
        skipped command line option.

1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886
2013-09-12  Samuel White  <samuel_white@apple.com>

        <meter> element text value exposed as AXTitle; should be exposing AXValueDescription
        https://bugs.webkit.org/show_bug.cgi?id=117651

        Reviewed by Mario Sanchez Prada.

        Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.

        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::valueDescription):
        * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
        (WTR::AccessibilityUIElement::valueDescription):

1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924
2013-09-12  Denis Nomiyama  <d.nomiyama@samsung.com>

        REGRESSION(r154781): accessibility/notification-listeners.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=120669

        Reviewed by Chris Fleizach.

        Fixed 4 problems that were causing notification-listeners.html to fail.

        Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
        implemented in axObjectEventListener().

        A notification for AXFocusedUIElementChanged was incorrectly sent when
        the element lost focus.

        Global notification was not dispatched if an element notification was
        present in the HashMap.

        connectAccessibilityCallbacks() was connecting signals to callbacks
        multiple times because it was not checking if
        disconnectAccessibilityCallbacks() had an early return if there were
        active handlers.

        * DumpRenderTree/atk/AccessibilityCallbacks.h: Modified
        disconnectAccessibilityCallbacks() to inform if the callbacks were
        successfully disconnected.
        * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
        (axObjectEventListener): Implemented notifications for
        AXFocusedUIElementChanged and AXValueChanged. Fixed the global
        notification, which was not dispatched if an element notification
        existed. Fixed the notification for AXFocusedUIElementChanged that was
        incorrectly sent when the element lost focus. In addition, fixed a typo
        where TRUE should be true.
        (connectAccessibilityCallbacks): Added early return if
        disconnectAccessibilityCallbacks() did not disconnect the callbacks.
        (disconnectAccessibilityCallbacks): Added a return value to inform if
        callbacks were successfully disconnected.

andersca@apple.com's avatar
andersca@apple.com committed
1925 1926 1927 1928 1929 1930
2013-09-11  Anders Carlsson  <andersca@apple.com>

        Try to fix GCC builds.

        * TestWebKitAPI/Tests/WTF/MoveOnly.h:

andersca@apple.com's avatar
andersca@apple.com committed
1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943
2013-09-11  Anders Carlsson  <andersca@apple.com>

        Try to fix the build.

        Move MoveOnly.h to Tests/WTF and fix the broken Xcode project that caused me to add the header
        file in the Tests/ directory in the first place.

        * TestWebKitAPI/CMakeLists.txt:
        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WTF/MoveOnly.h: Renamed from Tools/TestWebKitAPI/Tests/MoveOnly.h.

1944 1945 1946 1947 1948 1949 1950 1951 1952
2013-09-11  Brent Fulgham  <bfulgham@apple.com>

        [Windows] Build fix for MoveOnly

        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Add
        Tests to include search path.
        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
        Ditto.

andersca@apple.com's avatar
andersca@apple.com committed
1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964
2013-09-11  Anders Carlsson  <andersca@apple.com>

        Add HashSet::take
        https://bugs.webkit.org/show_bug.cgi?id=121192

        Reviewed by Darin Adler.

        Add a test for HashSet::take.

        * TestWebKitAPI/Tests/WTF/HashSet.cpp:
        (TestWebKitAPI::TEST):

1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982
2013-09-11  Anders Carlsson  <andersca@apple.com>

        HashSet should work with move only types
        https://bugs.webkit.org/show_bug.cgi?id=121188

        Reviewed by Geoffrey Garen.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/MoveOnly.h: Added.
        Move the MoveOnly class from Vector out into its own header.

        * TestWebKitAPI/Tests/WTF/HashSet.cpp:
        (TestWebKitAPI::TEST):
        Add aHashSet<MoveOnly> test.

        * TestWebKitAPI/Tests/WTF/Vector.cpp:
        Include MoveOnly.h.

1983 1984 1985 1986 1987 1988 1989 1990 1991 1992
2013-09-11  Brent Fulgham  <bfulgham@apple.com>

        [Windows] Avoid converting from IntSize->SIZE->IntSize
        https://bugs.webkit.org/show_bug.cgi?id=121180

        Reviewed by Anders Carlsson.

        * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
        (TestWebKitAPI::TEST): Use IntSize instead of SIZE struct.

1993 1994 1995 1996 1997 1998 1999 2000 2001 2002
2013-09-11  Dan Bernstein  <mitz@apple.com>

        REGRESSION (r155561): extract-localizable-strings can miss strings
        https://bugs.webkit.org/show_bug.cgi?id=121184

        Reviewed by Darin Adler.

        * Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing
        parenthesis or bracket.

2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013
2013-09-11  Dan Bernstein  <mitz@apple.com>

        update-webkit-localizable-strings is at least 5.8x slower than it should be
        https://bugs.webkit.org/show_bug.cgi?id=121178

        Reviewed by Darin Adler.

        * Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.
        Note that this does not change functionality, because the script already does not understand
        the line continuation sequence (backslash followed by a newline).

2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025
2013-09-11  Anders Carlsson  <andersca@apple.com>

        Vector::append doesn't work if element type has overloaded operator&
        https://bugs.webkit.org/show_bug.cgi?id=121175

        Reviewed by Brent Fulgham.

        Add a test case.

        * TestWebKitAPI/Tests/WTF/Vector.cpp:
        (TestWebKitAPI::TEST):

2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037
2013-09-11  Anders Carlsson  <andersca@apple.com>

        Implement Vector::append for move-only types
        https://bugs.webkit.org/show_bug.cgi?id=120805

        Reviewed by Sam Weinig.

        Add a test for Vector<MoveOnly>::append.

        * TestWebKitAPI/Tests/WTF/Vector.cpp:
        (TestWebKitAPI::TEST):

2038 2039 2040 2041 2042 2043 2044 2045 2046
2013-09-11  Csaba Osztrogonác  <ossy@webkit.org>

        Unreviewed. Fix the indentation after r105848. Typo fix after r155523.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (RunAndUploadPerfTests):
        (RunAndUploadPerfTests.start):
        (RunAndUploadPerfTests.getText2):

2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059
2013-09-11  Anders Carlsson  <andersca@apple.com>

        The style checker shouldn't complain about returning or passing OwnPtr
        https://bugs.webkit.org/show_bug.cgi?id=121163

        Reviewed by Antti Koivisto.

        * Scripts/webkitpy/style/checkers/cpp.py:
        (check_function_definition_and_pass_ptr):
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (PassPtrTest.test_pass_ref_ptr_return_value):
        (PassPtrTest.test_own_ptr_parameter_value):

2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071
2013-09-11  Mario Sanchez Prada  <mario.prada@samsung.com>

        [GTK] Remove Gail dependency from build system for GTK3
        https://bugs.webkit.org/show_bug.cgi?id=119673

        Reviewed by Gustavo Noronha Silva.

        * EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
        * Scripts/webkitpy/port/gtk.py:
        (GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
        * TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.

2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084
2013-09-11  Gabor Abraham  <abrhm@inf.u-szeged.hu>

        Performance tester bots should report the number of failing tests
        https://bugs.webkit.org/show_bug.cgi?id=120462

        Reviewed by Csaba Osztrogonác.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (RunAndUploadPerfTests.start.getText):
        (RunAndUploadPerfTests.start):
        (RunAndUploadPerfTests):
        (RunAndUploadPerfTests.start.getText2):

2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098
2013-09-11  Krzysztof Czech  <k.czech@samsung.com>

        [ATK] Adds mapping MenuItemRadioRole to ATK
        https://bugs.webkit.org/show_bug.cgi?id=121149

        Reviewed by Mario Sanchez Prada.

        Adds mapping MenuItemRadioRole to ATK.

        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
        (roleToString):
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        (WTR::roleToString):

2099 2100 2101 2102 2103 2104 2105 2106 2107
2013-09-10  Csaba Osztrogonác  <ossy@webkit.org>

        Unreviewed fix after the unreviewed r155498 to unbreak the failure
        counter of run-javascriptcore-tests build step on build.webkit.org.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (RunJavaScriptCoreTests.commandComplete):
        * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

2108 2109 2110 2111 2112 2113 2114
2013-09-10  Filip Pizlo  <fpizlo@apple.com>

        Unreviewed, be a bit more clear about what we mean by 'js' tests. I think this
        got a bit overlooked from the fast/js->js refactoring.

        * Scripts/run-javascriptcore-tests:

2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132
2013-09-10  Daniel Bates  <dabates@apple.com>

        [iOS] Upstream text autosizing
        https://bugs.webkit.org/show_bug.cgi?id=121111

        Reviewed by Andy Estes and Sam Weinig.

        Implement infrastructure to test the iOS text autosizing code.

        * DumpRenderTree/TestRunner.cpp:
        (setTextAutosizingEnabledCallback): Added.
        (TestRunner::staticFunctions):
        * DumpRenderTree/TestRunner.h:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/mac/TestRunnerMac.mm:
        (TestRunner::setTextAutosizingEnabled): Added.

2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144
2013-09-10  Mark Hahnenberg  <mhahnenberg@apple.com>

        run-jsc-stress-tests should have a mode for always running the copy phase
        https://bugs.webkit.org/show_bug.cgi?id=121128

        Reviewed by Geoffrey Garen.

        This will increase test coverage of the copying phase, which might not always get 
        triggered normally with our default parameters for required Heap/CopiedBlock utilization.

        * Scripts/run-jsc-stress-tests:

2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158
2013-09-10  Sergio Correia  <sergio.correia@openbossa.org>

        [EFL][JHBUILD] Use a tarball for libseccomp, instead of git
        https://bugs.webkit.org/show_bug.cgi?id=121114

        Reviewed by Christophe Dumez.

        Use a tarball for libseccomp instead of git to avoid network issues on
        the buildbots while checking out the git repo. Using tarballs has the
        advantage of them being cached if the checksum matches, in which case
        there will be no need to download them again.

        * efl/jhbuild.modules:

2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173
2013-09-10  Mark Lam  <mark.lam@apple.com>

        Replace remaining "fast js" names in scripts.
        https://bugs.webkit.org/show_bug.cgi?id=120899.

        Rubber stamped by Filip Pizlo.

        * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
        (test_layout_failure_new_output):
        (test_layout_crash_new_output):
        (test_mozilla_and_layout_failure_new_output):
        * Scripts/run-fast-jsc: Removed.
        * Scripts/run-javascriptcore-tests:
        * Scripts/run-layout-jsc: Copied from Tools/Scripts/run-fast-jsc.

2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195
2013-09-10  Zan Dobersek  <zdobersek@igalia.com>

        Enable JSC stress tests for the rest of non-Windows platforms
        https://bugs.webkit.org/show_bug.cgi?id=121021

        Reviewed by Filip Pizlo.

        The JSC stress tests can already be enabled on Linux-based ports.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (RunJavaScriptCoreTests.commandComplete): Reformulate the regular expressions used to find the number of regressed
        JSC tests of various test suites. The expressions now look for the suite-specific report compartment over the
        complete output, with the number of failing or crashing tests properly extracted.
        * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a couple of unit tests and expand the tested
        output in other unit tests testing the parsing of the output in the new format.
        (test_jsc_stress_failure_new_output):
        (test_fast_js_crashes_and_jsc_stress_failures_new_output):
        * Scripts/run-javascriptcore-tests: Enable the JSC stress tests on all but the Apple Win port.
        * Scripts/run-jsc-stress-tests: `sysctl -n hw.availcpu` doesn't work on Linux-based ports but the numProcesses
        variable is still gracefully assigned a zero value. In that case, try running `nproc --all` to gather the number
        of available CPUs so the stress tests can be run in parallel.

2196 2197 2198 2199 2200 2201 2202 2203 2204 2205
2013-09-10  Chris Fleizach  <cfleizach@apple.com>

        AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
        https://bugs.webkit.org/show_bug.cgi?id=120552

        Unreviewed build fix.

        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (AccessibilityUIElement::classList):

2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233
2013-09-10  Chris Fleizach  <cfleizach@apple.com>

        AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
        https://bugs.webkit.org/show_bug.cgi?id=120552

        Reviewed by Darin Adler.

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (getClassListCallback):
        (AccessibilityUIElement::getJSClass):
        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
        (AccessibilityUIElement::classList):
        * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
        (AccessibilityUIElement::classList):
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::classList):
        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (AccessibilityUIElement::classList):
        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
        (WTR::AccessibilityUIElement::classList):
        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
        * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        (WTR::AccessibilityUIElement::classList):
        * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
        (WTR::AccessibilityUIElement::classList):

2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246
2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>

        [GTK] accessibility/loading-iframe-sends-notification.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=98370

        Reviewed by Chris Fleizach.

        Added AXLayoutComplete for the GTK platform.

        * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
        (axObjectEventListener): Added notification AXLayoutComplete for
        layout-complete signal.

2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261
2013-09-09  Brent Fulgham  <bfulgham@apple.com>

        [Windows] Change from using OwnPtr<GDI Stuff> to new GDIObject.
        https://bugs.webkit.org/show_bug.cgi?id=120778

        Reviewed by Anders Carlsson.

        * DumpRenderTree/win/PixelDumpSupportWin.cpp:
        (createBitmapContextFromWebView): Use GDIObject.
        * Scripts/webkitpy/style/checkers/cpp.py:
        (check_for_leaky_patterns): Update for GDIObject instead of adoptPtr and OwnPtr.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (LeakyPatternTest.test_create_dc): Update for GDIObject instead of adoptPtr/OwnPtr.
        (LeakyPatternTest.test_create_compatible_dc): Ditto.

2262 2263 2264 2265 2266 2267
2013-09-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>

        Unreviewed. Add myself as a committer.