ChangeLog 782 KB
Newer Older
sheridan's avatar
sheridan committed
1 2
=== Alexander-33 ===

darin's avatar
darin committed
3 4 5 6 7 8 9 10 11
2002-11-20  Darin Adler  <darin@apple.com>

        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
	Unescape the string before executing it, so we don't suffer from bug 3083043
	here in the javascript: URLs that come from plug-ins.

        * English.lproj/StringsNotToBeLocalized.txt: Update.

12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30
2002-11-20  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3079134 - Throttle plug-ins while in background

        * Plugins.subproj/WebBaseNetscapePluginView.h:
        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView sendNullEvent]): new
        (-[WebBaseNetscapePluginView stopNullEvents]): stops timer
        (-[WebBaseNetscapePluginView restartNullEvents]): stops timer if there is one, and starts a new one based on window activation state
        (-[WebBaseNetscapePluginView start]): call restartNullEvents
        (-[WebBaseNetscapePluginView stop]): call stopNullEvents
        (-[WebBaseNetscapePluginView windowBecameKey:]): call restartNullEvents
        (-[WebBaseNetscapePluginView windowResignedKey:]): call restartNullEvents
        (-[WebBaseNetscapePluginView windowDidMiniaturize:]): call stopNullEvents
        (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): call restartNullEvents
        * Plugins.subproj/WebNetscapePluginNullEventSender.h: Removed. No need for another class, use a timer.
        * Plugins.subproj/WebNetscapePluginNullEventSender.m: Removed. No need for another class, use a timer.
        * WebKit.pbproj/project.pbxproj:

31 32 33 34 35 36 37 38
2002-11-20  Richard Williamson   <rjw@apple.com>

        Fixed 3107007.  Letter-spacing is causing width to be miscalculated.
        This also fixed some selection problems.
        
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]):

39 40 41 42 43 44 45 46 47
2002-11-20  Richard Williamson   <rjw@apple.com>

        Fixed mono spaced fonts to always render with mono spacing! (3078065)
        
        * WebCoreSupport.subproj/WebTextRenderer.h:
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (widthForGlyph):
        (-[WebTextRenderer initWithFont:]):

48 49 50 51 52 53 54
2002-11-20  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3074926 - crash in BitsToPix() trying to print cnet page

        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView drawRect:]): disable experimental plug-in printing code.

55 56 57 58 59 60 61 62 63 64 65 66 67 68
2002-11-20  Chris Blumenberg  <cblu@apple.com>

	Minor clean-up, logging and more error checking in plug-in code.

        * Plugins.subproj/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream setResponse:]):
        (-[WebBaseNetscapePluginStream receivedData:]):
        (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
        * Plugins.subproj/npapi.m:
        (NPN_UserAgent):
        (NPN_MemFree):
        (NPN_MemFlush):
        (NPN_ReloadPlugins):

69 70 71 72 73 74 75
2002-11-20  Chris Blumenberg  <cblu@apple.com>
	
	Fixed: 3061174 - javascript: URLs sent by plugins don't work

        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):

darin's avatar
darin committed
76 77 78 79
2002-11-20  Darin Adler  <darin@apple.com>

        * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

80 81 82 83 84 85 86
2002-11-19  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3106061 - REGRESSION: Copy in text view copies all text not just selection

        * Misc.subproj/WebSearchableTextView.m:
        (-[WebSearchableTextView copy:]):

87 88 89 90 91 92 93 94 95 96
2002-11-19  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3092588 - redraw errors in QT controller if window is in background

	We need to send update events after we activate/deactivate after all.

        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView windowBecameKey:]):
        (-[WebBaseNetscapePluginView windowResignedKey:]):

97 98 99 100 101 102 103
2002-11-19  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3020720 - dropping a folder in the page address makes the folder open in Finder, empties the field

        * Misc.subproj/WebNSPasteboardExtras.m:
        (-[NSPasteboard _web_bestURL]): Don't accept directories.

104 105 106 107 108 109 110
2002-11-19  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3068112 - extra line breaks when copying from source window

        * Misc.subproj/WebSearchableTextView.m:
        (-[WebSearchableTextView copy:]): Convert CRLF to LF

111 112 113 114 115 116 117 118 119 120
2002-11-19  David Hyatt  <hyatt@apple.com>

	Make sure that if the scrollers are shown/hidden that we
	force an immediate layout, since if we don't, an intervening
	display can cause us to show scrollbars when they really
	shouldn't be there.
	
        * WebView.subproj/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView updateScrollers]):

121 122 123 124 125 126 127
2002-11-19  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3100597 - repro NSArray exception using contextual menu

        * Misc.subproj/WebNSPasteboardExtras.m:
        (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): more error checking

trey's avatar
WebKit:  
trey committed
128 129 130 131 132 133 134
2002-11-19  Trey Matteson  <trey@apple.com>

	Just a tweak to the description printout.

        * History.subproj/WebHistoryItem.m:
        (-[WebHistoryItem description]):

135 136 137 138
2002-11-18  Chris Blumenberg  <cblu@apple.com>

	Real fix for: 3104183 - Assert loading www.louisvuitton.com

139 140
	Since we don't consider plug-in content as a subresource, attaching plug-in streams to the datasource has no affect on the loading state of the datasource. Both stopLoading on WebFrame and _stopLoading datasource, would not stop plug-ins streams after th
e data source was done loading. Because of this, I've decided to not keep a list of plug-in streams attached to the data source and pulled my previous change. To fix this bug, WebBaseResourceHandleDelegate now retains the controller.
141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161

        * Plugins.subproj/WebNetscapePluginStream.m:
        (-[WebNetscapePluginStream start]):
        (-[WebNetscapePluginStream cancel]):
        (-[WebNetscapePluginStream handleDidFinishLoading:]):
        (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
        * WebView.subproj/WebBaseResourceHandleDelegate.h:
        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate _releaseResources]):
        (-[WebBaseResourceHandleDelegate setDataSource:]):
        (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):
        (-[WebBaseResourceHandleDelegate handleDidFinishLoading:]):
        (-[WebBaseResourceHandleDelegate handle:didFailLoadingWithError:]):
        (-[WebBaseResourceHandleDelegate _cancelWithError:]):
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _stopLoading]):
        (-[WebDataSource _makeHandleDelegates:deferCallbacks:]):
        (-[WebDataSource _defersCallbacksChanged]):

162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181
2002-11-18  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3104183 - Assert loading www.louisvuitton.com

	We need to treat plug-in streams like subresources except they don't change the loading state of the data source.

        * Plugins.subproj/WebNetscapePluginStream.m:
        (-[WebNetscapePluginStream start]): call _addPluginStream
        (-[WebNetscapePluginStream cancel]): call _removePluginStream
        (-[WebNetscapePluginStream handleDidFinishLoading:]): call _removePluginStream
        (-[WebNetscapePluginStream handle:didFailLoadingWithError:]): call _removePluginStream
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSourcePrivate dealloc]): release pluginStreams
        (-[WebDataSource _addPluginStream:]): just like addSubresourceClient except don't change the loading state.
        (-[WebDataSource _removePluginStream:]): just like removeSubresourceClient except don't change the loading state.
        (-[WebDataSource _stopLoading]): stop plug-ins streams
        (-[WebDataSource _makeHandleDelegates:deferCallbacks:]): 
        (-[WebDataSource _defersCallbacksChanged]): call _makeHandleDelegates:deferCallbacks: for subresources and plug-in streams.

182 183 184 185 186 187 188
2002-11-18  Richard Williamson   <rjw@apple.com>

        Check for usesBackForwardList was excluding all load types.
        
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted]):

189 190 191 192 193 194 195 196 197
2002-11-18  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3098767 - REGRESSION: standalone quicktime content just shows blank window

	Check the instance not the class for the class type.

        * Plugins.subproj/WebNetscapePluginRepresentation.m:
        (-[WebNetscapePluginRepresentation receivedData:withDataSource:]):

kocienda's avatar
WebKit:  
kocienda committed
198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222
2002-11-18  Ken Kocienda  <kocienda@apple.com>

	Added feature to import bookmarks/favorites from MSIE. This
	fixes Radar 2961230 (import Mac IE bookmarks).

        * Bookmarks.subproj/WebBookmarkImporter.h: Added.
        * Bookmarks.subproj/WebBookmarkImporter.m: Added.
        (_breakStringIntoLines):
        (_HREFRangeFromSpec):
        (_HREFTextFromSpec):
        (_linkTextRangeFromSpec):
        (_linkTextFromSpec):
        (-[WebBookmarkImporter initWithPath:group:]):
        (-[WebBookmarkImporter topBookmark]):
        (-[WebBookmarkImporter error]):
        (-[WebBookmarkImporter dealloc]):
        * Bookmarks.subproj/WebBookmarkList.m:
        (-[WebBookmarkList init]): Create the bookmark list object. This
	was not created with the -init initializer, causing bookmark lists
	to fail.
        * English.lproj/Localizable.strings:
        * English.lproj/StringsNotToBeLocalized.txt:
        * WebKit.exp:
        * WebKit.pbproj/project.pbxproj:

223 224 225 226 227 228 229 230 231 232
2002-11-17  Trey Matteson  <trey@apple.com>

	Code cleanup to make some internal methods return autoreleased objects.

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _addBackForwardItemClippedAtTarget:]):
        (-[WebFrame _createItem]):
        (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):
        (-[WebFrame _transitionToCommitted]):

233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257
2002-11-17  Trey Matteson  <trey@apple.com>

	Fixed 3102076 - REGRESSION: infinite recursion involving bridge end
	Fixed 3100929 - REGRESSION: serverRedirectedForDataSource: not sent on server redirects
	Fixed 3103381 - REGRESSION: Going back from anchor doesn't restore scroll position

        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):  Return the copy of the
	request that we make instead of the original.
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:willSendRequest:]):  Call super after we make our mods
	to the request, so the copy that super makes for us includes those mods.

        * WebView.subproj/WebFramePrivate.h:  Added new state, WebFrameStateCompleting.
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToLayoutAcceptable]):  Completing state is a NOP.
        (-[WebFrame _transitionToCommitted]):  Completing state is a NOP.
        (-[WebFrame _isLoadComplete]):  Go to Completing state before calling [bridge end].
	Go to Completed state afterwards, only if no new loads started in the meantime.
        (-[WebFrame _loadItem:fromItem:withLoadType:]):  When doing anchor nav to get to the
	item, save and restore scroll state, and set the current item.
        (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]):
	Reorder the steps so the right scroll state gets saved to the right place.  Also, don't
	add a backForward item if we're doing a client redirect to an anchor.

258 259 260 261 262 263 264 265
2002-11-17  David Hyatt  <hyatt@apple.com>

	Back out my previous fix.  I have a better one that is
	confined to WebCore.
	
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _isLoadComplete]):

266 267 268 269 270 271 272 273 274
2002-11-17  David Hyatt  <hyatt@apple.com>

	The needsdisplay is necessary even for HTML documents.
	I over-optimized here.  Fixes the directory.apple.com
	regression and the santa clara library regression.
	
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _isLoadComplete]):

darin's avatar
darin committed
275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306
2002-11-17  Darin Adler  <darin@apple.com>

	- update for change to WebCore API so it never uses NSURL

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge createWindowWithURL:frameName:]): Take NSString instead of NSURL.
        (-[WebBridge startLoadingResource:withURL:]): Ditto.
        (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): Ditto.
        (-[WebBridge reportClientRedirectToURL:delay:fireDate:]): Ditto.
        (-[WebBridge setIconURL:]): Ditto.
        (-[WebBridge setIconURL:withType:]): Ditto.
        (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]): Ditto.
        (-[WebBridge postWithURL:data:contentType:triggeringEvent:]): Ditto.
        (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Ditto.
        (-[WebBridge userAgentForURL:]): Ditto.
        (-[WebBridge requestedURL]): Return NSString instead of NSURL.
        (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): Take NSString instead of NSURL.
        (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): Take NSString instead of NSURL.

        * WebCoreSupport.subproj/WebCookieAdapter.m:
        (-[WebCookieAdapter cookiesForURL:]): Take NSString instead of NSURL.
        (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]): Ditto.

        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _commitIfReady]): Pass NSString instead of NSURL.
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]): Pass NSString instead of NSURL
        (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Turn bridge URL into NSURL so we
	can call _web_URLByRemovingFragment on it.
        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLView _elementAtPoint:]): Convert NSString to NSURL when making the WebKit element dictionary.

mjs's avatar
mjs committed
307 308 309 310 311 312 313 314 315 316 317 318 319
2002-11-17  Maciej Stachowiak  <mjs@apple.com>

	- fixed 2949193 - implement onKeyDown, onKeyPress, and onKeyUp event handlers
	
        * WebView.subproj/WebHTMLViewPrivate.h:
        * WebView.subproj/WebHTMLViewPrivate.m:
        (+[WebHTMLView load]): Pose as NSWindow too now.
        (-[WebHTMLView _interceptKeyEvent:toView:]): Pass event to WebCore and
	see if WebCore wants to block it.
        (-[WebNSWindow sendEvent:]): For all key events that would go to a
	subview of a WebHTMLView, let the WebHTMLView take a first crack
	at it.

320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338
2002-11-15  Darin Adler  <darin@apple.com>

	- fixed 3079214 -- text/plain page shows up slowly, a few pages at a time

        * WebView.subproj/WebTextView.m:
        (-[WebTextView initWithFrame:]): Remove unneeded setWidthTracksTextView:, because
	that's the default.
        (-[WebTextView dataSourceUpdated:]): Replace the thing each time in the RTF case.
        (-[WebTextView viewDidMoveToSuperview]): Here's where we resize, but only the width.
	Resizing the height was causing the bug.
        (-[WebTextView layout]): Do nothing.
        (-[WebTextView setAcceptsDrags:]): Update to new name. Since we weren't
	importing WebDocument.h, we never noticed that this file got out of sync.
        (-[WebTextView acceptsDrags]): Ditto.
        (-[WebTextView setAcceptsDrops:]): Ditto.
        (-[WebTextView acceptsDrops]): Ditto.

        * WebView.subproj/WebDocument.h: Fix typo. It said setAcceptsDrags: twice.

339 340 341 342
2002-11-15  Darin Adler  <darin@apple.com>

        * WebView.subproj/WebFramePrivate.m: Removed a bunch of tabs and fixed indenting.

343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359
2002-11-15  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3102016 - REGRESSION: Command-clicking on a link can open _two_ windows.
	
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _setJustOpenedForTargetedLink:]):
        (-[WebDataSource _justOpenedForTargetedLink]):
        * WebView.subproj/WebFrame.m:
        (-[WebFrame findOrCreateFramedNamed:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueAfterNavigationPolicy:]):
        (-[WebFrame _loadDataSource:withLoadType:]):
        (-[WebFrame _downloadRequest:toPath:]):
        (-[WebFrame _setJustOpenedForTargetedLink:]):

darin's avatar
darin committed
360 361 362 363 364 365
2002-11-15  Darin Adler  <darin@apple.com>

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
	Give the listener a slightly longer lifetime, to make this API a bit more foolproof.

366 367 368 369 370 371 372 373
2002-11-15  Maciej Stachowiak  <mjs@apple.com>

	Fix world leak I introduced, and also add an early return when needed.
	
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]):
        (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):

mjs's avatar
WebKit:  
mjs committed
374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400
2002-11-15  Maciej Stachowiak  <mjs@apple.com>

	Make navigation policy asynchronous for real.
	
        * WebKit.pbproj/project.pbxproj:
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebControllerPolicyDelegate.m:
        (-[WebPolicyDecisionListenerPrivate initWithTarget:action:]):
        (-[WebPolicyDecisionListenerPrivate dealloc]):
        (-[WebPolicyDecisionListener usePolicy:]):
        (-[WebPolicyDecisionListener _initWithTarget:action:]):
        (-[WebPolicyDecisionListener dealloc]):
        (-[WebPolicyDecisionListener _invalidate]):
        * WebView.subproj/WebControllerPolicyDelegatePrivate.h: Added.
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
        * WebView.subproj/WebFrame.m:
        (-[WebFrame stopLoading]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFramePrivate dealloc]):
        (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]):
        (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
        (-[WebFrame _continueAfterNavigationPolicy:]):
        (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
        (-[WebFrame _loadDataSource:withLoadType:]):

401 402 403 404 405 406 407 408 409 410
2002-11-15  Maciej Stachowiak  <mjs@apple.com>

	Wrap content policy invocation to look asynchronous.
	
        * WebView.subproj/WebBaseResourceHandleDelegate.h:
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient continueAfterContentPolicy:response:]):
        (-[WebMainResourceClient checkContentPolicyForResponse:andCallSelector:]):
        (-[WebMainResourceClient handle:didReceiveResponse:]):

411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430
2002-11-15  Maciej Stachowiak  <mjs@apple.com>

	Refactor so that all invocations of navigation policy are set up
	to be asynchronous. However, the actually delegate method is not
	async yet.
	
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
        (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]):
        (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
        (-[WebFrame _continueLoadRequestAfterNavigationPolicy:request:]):
        (-[WebFrame _loadDataSource:withLoadType:]):
        * WebView.subproj/WebMainResourceClient.h:
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient stopLoadingForPolicyChange]):
        (-[WebMainResourceClient continueAfterNavigationPolicy:request:]):
        (-[WebMainResourceClient handle:willSendRequest:]):
        (-[WebMainResourceClient handle:didReceiveResponse:]):

431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448
2002-11-14  Maciej Stachowiak  <mjs@apple.com>

	Refactor things a bit so all loads bottleneck through a single
	method (_loadDataSource:withLoadType:).
	
        * WebView.subproj/WebFrame.m:
        (-[WebFrame loadRequest:]):
        (-[WebFrame reload]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _loadItem:fromItem:withLoadType:]):
        (-[WebFrame _loadRequest:triggeringAction:loadType:]):
        (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
        (-[WebFrame _postWithURL:data:contentType:triggeringEvent:]):
        (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]):
        (-[WebFrame _loadDataSource:withLoadType:]):
        (-[WebFrame _downloadRequest:toPath:]):

mjs's avatar
WebKit:  
mjs committed
449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487
2002-11-14  Maciej Stachowiak  <mjs@apple.com>

	Change things so the public interface to loading is loadRequest:
	and everything else is private.
	
        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
        * Plugins.subproj/WebPluginController.m:
        (-[WebPluginController showURL:inFrame:]):
        * WebView.subproj/WebController.h:
        * WebView.subproj/WebController.m:
        (-[WebController init]):
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _createFrameNamed:inParent:allowsScrolling:]):
        (-[WebController _downloadURL:toPath:]):
        * WebView.subproj/WebFrame.h:
        * WebView.subproj/WebFrame.m:
        (-[WebFrame init]):
        (-[WebFrame initWithName:webView:controller:]):
        (-[WebFrame loadRequest:]):
        (-[WebFrame reload]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _timedLayout:]):
        (-[WebFrame _clearProvisionalDataSource]):
        (-[WebFrame _loadItem:fromItem:withLoadType:]):
        (-[WebFrame _loadRequest:triggeringAction:]):
        (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]):
        (-[WebFrame _itemForRestoringDocState]):
        (-[WebFrame _setProvisionalDataSource:]):
        (-[WebFrame _startLoading]):
        (-[WebFrame _downloadRequest:toPath:]):
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:willSendRequest:]):
        (-[WebMainResourceClient stopLoadingAfterContentPolicy]):
        (-[WebMainResourceClient handle:didReceiveResponse:]):
        * WebView.subproj/WebView.m:
        (-[WebView concludeDragOperation:]):

488 489 490 491 492 493 494 495 496 497 498
2002-11-14  David Hyatt  <hyatt@apple.com>

	Move text measurement and layout beyond onload.  This
	shoudl speed up i-bench substantially and morrison's
	PLT test slightly.  Note that the adjustFrames layout
	stuff has been removed from isLoadComplete.
	
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _timedLayout:]):
        (-[WebFrame _isLoadComplete]):

darin's avatar
darin committed
499 500 501 502 503 504
2002-11-14  Darin Adler  <darin@apple.com>

        * English.lproj/Localizable.strings: Updated to include the new
	error messages that Maciej just added. I wonder what effect this
	will have if we see those errors in Alex-32?

sheridan's avatar
sheridan committed
505 506
=== Alexander-32 ===

507 508 509 510 511 512 513
2002-11-14  Don Melton  <gramps@apple.com>

        * WebView.subproj/WebControllerPolicyDelegate.h:

	Added missing semi-colon in definition of WebPolicyDecisionListener to
	fix build error.

mjs's avatar
WebKit:  
mjs committed
514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533
2002-11-14  Maciej Stachowiak  <mjs@apple.com>

	Combined file URL policy with content policy. We don't actually
	bother to ask earlier for file URLs yet, since that will make
	things more complicated.
	
        * Misc.subproj/WebKitErrors.h:
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _handleUnimplementablePolicy:errorCode:forURL:]):
        (-[WebFrame _continueAfterNavigationPolicyForRequest:dataSource:]):
        * WebView.subproj/WebMainResourceClient.h:
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient stopLoadingAfterContentPolicy]):
        (-[WebMainResourceClient handle:didReceiveResponse:]):
        * WebView.subproj/WebView.m:
        (+[WebView initialize]):

darin's avatar
darin committed
534 535 536 537 538 539 540 541 542 543 544 545 546
2002-11-14  Darin Adler  <darin@apple.com>

	- fixed 3099240 -- REGRESSION: repro assert d->m_doc->parsing

	Make the reload flag pass across the bridge.

        * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):
	Pass a reload flag, based on the load type, to the bridge.
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Pass a
	reload flag of NO in the anchor case. Preserve reload load types even when
	doing client redirects (have to talk with Trey about this tomorrow).

darin's avatar
darin committed
547 548 549 550 551 552 553
2002-11-14  Darin Adler  <darin@apple.com>

	- fixed 3100235 -- nil-deference in khtml::RenderTable at money.cnn.com

        * WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
	If the WebCore side needs layout, then do layout before trying to draw.

554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575
2002-11-13  Trey Matteson  <trey@apple.com>

	Fixed client redirects, some more.  The upshot is that they do not
	generate two items in the back-forward list.  iBench still works.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge reportClientRedirectTo:delay:fireDate:]):  Call straight to the frame for all impl.
        (-[WebBridge reportClientRedirectCancelled]):  Call straight to the frame for all impl.
        (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]):
	clientRedirect param removed when sending _loadURL: to frame.
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
	clientRedirect param  removed. Check our own ivar to know if we are in client redirect case.
        (-[WebFrame _loadURL:intoChild:]):
	clientRedirect param removed when sending _loadURL: .
        (-[WebFrame _clientRedirectedTo:delay:fireDate:]):
	Note that we are doing a redirect if time=0 and we're not completed.  Also includes
	previous impl moved from Bridge.
        (-[WebFrame _clientRedirectCancelled]):  Previous impl moved from Bridge.


mjs's avatar
WebKit:  
mjs committed
576 577 578 579 580 581 582 583 584 585
2002-11-13  Maciej Stachowiak  <mjs@apple.com>

	Pass mime type instead of full response to content policy delegate
	method, in preparation for merging it with the file URL policy.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:didReceiveResponse:]):

darin's avatar
darin committed
586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610
2002-11-13  Darin Adler  <darin@apple.com>

	- fixed 3083982 -- Logging into AOL gives null view

	Turns out AOL was using a refresh header, which we were not supporting.

        * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):
	Call openURL: and pass headers in.

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:isFormSubmission:]):
	Pass nil for headers in this case, since we know it's just an anchor change.

	- other things

        * WebCoreSupport.subproj/WebBridge.h: Remove dataSourceChanged and dataSource
	methods. We try to keep the bridge methods down to actual bridging.
        * WebCoreSupport.subproj/WebBridge.m: Remove dataSourceChanged altogether,
	and move dataSource up in the file.

        * WebView.subproj/WebHTMLRepresentation.m:
        (-[WebHTMLRepresentation setDataSource:]): Keep the data source around, so we
	don't need to ask the bridge for it.
        (-[WebHTMLRepresentation documentSource]): Use it here.

611 612 613 614 615 616 617 618 619 620 621
2002-11-13  Trey Matteson  <trey@apple.com>

	Fixed 3100084 - REGRESSION: web page is not first responder after visiting web page

        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _commitIfReady]):  Make the rep before _transitionToCommitted.  This is the way it used to be.
        (-[WebDataSource _makeRepresentation]):  Don't make the docView here.

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted]):  Make the docView here, after we save the scroll state but before notifying the delegate.

622 623 624 625 626 627 628 629 630 631
2002-11-13  Darin Adler  <darin@apple.com>

	- fixed 3100013 -- REGRESSION: Can't get results from i-Bench anymore

        * WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]):
	Don't set the state to WebFrameStateComplete if it has already been set
	to WebFrameStateProvisional. If it has, that means we already began a new
	load; that one is not yet complete.

2002-11-13  John Sullivan  <sullivan@apple.com>
632 633 634 635 636 637 638 639 640 641 642

	- fixed 3099922 -- REGRESSION: Back button always pops up menu

        * Misc.subproj/WebNSViewExtras.h:
        * Misc.subproj/WebNSViewExtras.m:
        (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]:
	Fixed a copy/paste error I made yesterday -- this method was never
	noticing the mouse-up events because it was checking the event type
	against the wrong number. Also changed the hysteresis values from
	unsigneds to floats (unsigned was just wrong).

mjs's avatar
mjs committed
643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672
2002-11-13  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3050447 - Policy handlers have no way of telling client
	that the proposed navigation is a form post

	Now we pass form submissions through all the normal policy steps.
	
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]):
        (-[WebBridge postWithURL:data:contentType:triggeringEvent:]):
        (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _setTriggeringAction:]):
        (-[WebDataSource _triggeringAction]):
        (-[WebDataSource _lastCheckedRequest]):
        (-[WebDataSource _setLastCheckedRequest:]):
        * WebView.subproj/WebFrame.m:
        (-[WebFrame setProvisionalDataSource:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _shouldShowRequest:]):
        (-[WebFrame _loadRequest:triggeringAction:]):
        (-[WebFrame _actionInformationForNavigationType:event:]):
        (-[WebFrame _continueAfterNavigationPolicyForRequest:dataSource:]):
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:isFormSubmission:]):
        (-[WebFrame _loadURL:intoChild:]):
        (-[WebFrame _postWithURL:data:contentType:triggeringEvent:]):

mjs's avatar
WebKit:  
mjs committed
673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688
2002-11-12  Maciej Stachowiak  <mjs@apple.com>

	Combine click policy and URL policy into navigation policy.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate navigationPolicyForAction:andRequest:inFrame:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _shouldShowRequest:]):
        (-[WebFrame _actionInformationForNavigationType:event:]):
        (-[WebFrame _continueAfterFileURLPolicyForRequest:]):
        (-[WebFrame _continueAfterNavigationPolicyForRequest:event:]):
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):

689 690 691 692 693 694 695 696 697 698 699
2002-11-12  Trey Matteson  <trey@apple.com>

	fixed 3096030 - Crash in -[WebBackForwardList goToEntry:] when playing with SnapBack and dictionary.com

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _isLoadComplete]):  Set state=completed only after we tell the bridge to
	end the load.  This allows client redirects to be processed before we think we're complete.
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):
	Only process client redirects as such if we are not already complete.  This makes JS driven
	navigations after load-time work like the user would expect, as normal navigations.

700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719
2002-11-12  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3099487 - REGRESSION: dragging an image always puts it in
	the download directory
	
        * WebView.subproj/WebControllerPrivate.h:
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _downloadURL:]): Call _downloadURL:toPath: with nil path.
	(-[WebController _downloadURL:toPath:]): New method that
	predetermines the path to download to (needed for DnD).
        * WebView.subproj/WebHTMLView.m:
	(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use
	_downloadURL:toPath:
        * WebView.subproj/WebImageView.m:
	(-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): Use
	_downloadURL:toPath:
        * WebView.subproj/WebMainResourceClient.m:
	(-[WebMainResourceClient handle:didReceiveResponse:]): Don't ask
	delegate for download path if we already have one.

720 721 722 723 724 725 726 727
2002-11-12  Richard Williamson  <rjw@apple.com>

        Fixed likely cause of 3099047 (and others).  Width buffer could underrun in
        some situations.
        
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]):

sullivan's avatar
WebKit:  
sullivan committed
728 729 730 731 732 733 734 735 736
2002-11-12  John Sullivan  <sullivan@apple.com>

        * Misc.subproj/WebNSViewExtras.h:
        * Misc.subproj/WebNSViewExtras.m:
        (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]):
	new method
        (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:]):
	now calls the new method, passing the default hysteresis values

737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752
2002-11-12  Richard Williamson  <rjw@apple.com>

        Implemented letter-spacing and word-spacing CSS properties.

        * Misc.subproj/WebStringTruncator.m:
        (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
        (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
        * WebCoreSupport.subproj/WebTextRenderer.h:
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer widthForCharacters:length:]):
        (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:letterSpacing:wordSpacing:]):
        (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]):
        (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]):
        (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:letterSpacing:wordSpacing:]):
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]):

mjs's avatar
WebKit:  
mjs committed
753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778
2002-11-12  Maciej Stachowiak  <mjs@apple.com>

	Removed policy classes and instead use the policy enums directly,
	since we no longer hold the path in the enum.
	
        * Downloads.subproj/WebDownloadHandler.m:
        * WebKit.exp:
        * WebKit.pbproj/project.pbxproj:
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebControllerPolicyDelegate.m:
        * WebView.subproj/WebControllerPolicyDelegatePrivate.h: Removed.
        * WebView.subproj/WebControllerPrivate.m:
        * WebView.subproj/WebDefaultPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (+[WebDefaultPolicyDelegate defaultURLPolicyForRequest:]):
        (-[WebDefaultPolicyDelegate URLPolicyForRequest:inFrame:]):
        (-[WebDefaultPolicyDelegate fileURLPolicyForMIMEType:andRequest:inFrame:]):
        (-[WebDefaultPolicyDelegate unableToImplementPolicy:error:forURL:inFrame:]):
        (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame handleUnimplementablePolicy:errorCode:forURL:]):
        (-[WebFrame _shouldShowRequest:]):
        (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:didReceiveResponse:]):

779 780 781 782 783 784 785 786 787 788
2002-11-12  Maciej Stachowiak  <mjs@apple.com>

	Keep the triggering event around on the data source, so it can be
	used with redirects.

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _loadRequest:triggeringEvent:]):
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):
        (-[WebFrame _postWithURL:data:contentType:]):

darin's avatar
darin committed
789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804
2002-11-12  Darin Adler  <darin@apple.com>

	- improved the code that manages observing the window and superview

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView addSuperviewObservers]): Added.
        (-[WebHTMLView removeSuperviewObservers]): Added.
        (-[WebHTMLView addWindowObservers]): Added.
        (-[WebHTMLView removeWindowObservers]): Added.
        (-[WebHTMLView viewWillMoveToSuperview:]): Call removeSuperviewObservers.
        (-[WebHTMLView viewDidMoveToSuperview]): Call addSuperviewObservers.
        (-[WebHTMLView viewWillMoveToWindow:]): Call removeWindowObservers and
	removeSuperviewObservers.
        (-[WebHTMLView viewDidMoveToWindow]): Call addWindowObservers and
	addSuperviewObservers.

mjs's avatar
WebKit:  
mjs committed
805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833
2002-11-11  Maciej Stachowiak  <mjs@apple.com>

	Remove contentPolicy parameter from _downloadURL, and remove
	remaining traces of path from policy object.

        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebControllerPolicyDelegate.m:
        (-[WebPolicyPrivate dealloc]):
        (+[WebURLPolicy webPolicyWithURLAction:]):
        (+[WebFileURLPolicy webPolicyWithFileAction:]):
        (+[WebContentPolicy webPolicyWithContentAction:]):
        (+[WebClickPolicy webPolicyWithClickAction:]):
        * WebView.subproj/WebControllerPolicyDelegatePrivate.h:
        * WebView.subproj/WebControllerPrivate.h:
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _downloadURL:]):
        * WebView.subproj/WebDefaultContextMenuDelegate.m:
        (-[WebDefaultContextMenuDelegate downloadURL:]):
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
        * WebView.subproj/WebImageView.m:
        (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]):
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:didReceiveResponse:]):

darin's avatar
darin committed
834 835 836 837 838 839 840 841
2002-11-11  Darin Adler  <darin@apple.com>

        * Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
        Use fileSystemRepresentationWithPath, not cString, to turn a path into something
        to pass to FSPathMakeRef.

        * English.lproj/StringsNotToBeLocalized.txt: Update.

darin's avatar
darin committed
842 843 844 845 846 847 848 849 850 851 852 853 854 855 856
2002-11-11  Darin Adler  <darin@apple.com>

	- tighten up cursor handling a bit more

        * WebView.subproj/WebDynamicScrollBarsView.m:
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView addMouseMovedObserver]): Call _frameOrBoundsChanged
	so we emit a mouse moved event right away.
        (-[WebHTMLView viewWillMoveToSuperview:]): Remove the colon since I
	removed the parameter from _frameOrBoundsChanged.

        * WebView.subproj/WebHTMLViewPrivate.h: Declare _frameOrBoundsChanged.
        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLView _frameOrBoundsChanged]): Remove parameter.

857 858 859 860 861 862 863 864
2002-11-11  Trey Matteson  <trey@apple.com>

        Fixed 3015884 - Reloading a page should remember the scroll position

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted]):  Save scroll position on reload
        (-[WebFrame _isLoadComplete]):  Restore position on reload

865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953
2002-11-11  Trey Matteson  <trey@apple.com>

        * History.subproj/WebBackForwardList.m:
        (-[WebBackForwardList addEntry:]):  Yank code to avoid adding a duplicate entry, to catch the
	refresh case.  That's dealt with in WebFramePrivate now.
        (-[WebBackForwardList description]):  Enhanced to print more info.

        * History.subproj/WebHistoryItem.h:
	History items now hold an array of subitems to mirror the frame tree.  One item in the tree
	is designated the target of the navigation.
        * History.subproj/WebHistoryItem.m:
        (-[WebHistoryItem dealloc]):  Release new ivars.
        (-[WebHistoryItem isTargetItem]):
        (-[WebHistoryItem setIsTargetItem:]):
	New setter and setter.
        (-[WebHistoryItem _recurseToFindTargetItem]):
        (-[WebHistoryItem targetItem]):
	Search the tree to find the target item.
        (-[WebHistoryItem children]):
        (-[WebHistoryItem addChildItem:]):
        (-[WebHistoryItem childItemWithName:]):
	Maintain and search new child item list.
        (-[WebHistoryItem description]):
	Enhanced to print out the tree of items.
        (-[WebHistoryItem dictionaryRepresentation]):
        (-[WebHistoryItem initFromDictionaryRepresentation:]):
	Save and load the new state.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge generateFrameName]):  New call from KWQ, just forwards to Frame.
        (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
	Call new frame method dedicated to this case.
        (-[WebBridge saveDocumentState:]):
        (-[WebBridge documentState]):
	Call frame methods to get the right item to save/restore to/from.

        * WebView.subproj/WebController.m:
        (-[WebController _goToItem:withLoadType:]):  Stop any current loading before going to a new item.
        (-[WebController goBack]):
        (-[WebController goForward]):
        (-[WebController goBackOrForwardToItem:]):  Name change of private method (for consistency)

        * WebView.subproj/WebDataSourcePrivate.h:
	ProvisionalItem and PreviousItem are moved back up to WebFrame, where we know more about the
	state transitions that happen during loading.
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSourcePrivate dealloc]): Don't release removed ivars.
        (-[WebDataSource _commitIfReady]): Make the view representations -after- the transition to committed.
	This allows us to save away the scroll location successfully, since making the view was resetting it.
        * WebView.subproj/WebFrame.h:
        * WebView.subproj/WebFrame.m:
        (-[WebFrame setProvisionalDataSource:]):  Saving the scroll location has moved elsewhere to handle frames.
        (-[WebFrame stopLoading]):  Skip all the work if we're already state=complete.

        * WebView.subproj/WebFramePrivate.h:
	The frame now holds a ref to the current, previous and provisional back-forward items.
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFramePrivate dealloc]):  Release new state.
        (-[WebFramePrivate setProvisionalItem:]):
        (-[WebFramePrivate setPreviousItem:]):
        (-[WebFramePrivate setCurrentItem:]):	New setters (1 line getters were missed by script)
        (-[WebFrame _addBackForwardItemClippedAtTarget:]):  Adds a BF item to the top of the BF list.
        (-[WebFrame _createItem]):  Create a single BF item.
        (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):  Create a tree of BF items, which
	mirror the frame tree.
        (-[WebFrame _immediateChildFrameNamed:]):  New frame search utility (doesn't recurse)
        (-[WebFrame _detachFromParent]):  Save the scroll position when detaching a frame.
        (-[WebFrame _transitionToCommitted]):  Maintain new item ivars.  Save scroll position when
	appropriate.  Hook up items for child frames to their parent, as they are created.
        (-[WebFrame _setState:]):  Clear previousItem whenever we reach committed.
        (-[WebFrame _isLoadComplete]):  Clear previousItem if we are committed.
        (-[WebFrame _childFramesMatchItem:]):  Does the frame's frame tree match the one held by the item?
        (-[WebFrame _loadItem:fromItem:withLoadType:]):  Only do simple anchor navigation if the frame
	has no children (fixes oddball corner case with a frame reloading itself).  Set provisional item.
        (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):  Heart of returning to an item that had
	frames.  We either find that the existing content is good, or initiate a load.
        (-[WebFrame _goToItem:withLoadType:]):  Adjust the BF list cursor, and recurse to do the work.
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):  Only do anchor-style nav if
	the destination URL has a fragment.  Save scroll position.
        (-[WebFrame _loadURL:intoChild:]):  If returning to an item with frames, possibly replace the
	new content with the stuff that was there at the time, substituting the URL.
        (-[WebFrame _saveScrollPositionToItem:]):  Don't croak on nil item or view.
        (-[WebFrame _restoreScrollPosition]):  Do croak (ASSERT) on nil item.
        (-[WebFrame _scrollToTop]):  Nit cleanup.
        (-[WebFrame _addFramePathToString:]):  Add a component for our frame to the frame name we're generating.
        (-[WebFrame _generateFrameName]):  Generate a frame name that is repeatable.
        (-[WebFrame _itemForSavingDocState]):  Returns correct item to use for formstate save.
        (-[WebFrame _itemForRestoringDocState]):  Returns correct item to use for formstate restore

mjs's avatar
WebKit:  
mjs committed
954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980
2002-11-11  Maciej Stachowiak  <mjs@apple.com>

	Store path and the fact that we're downloading in the data source,
	instead of storing the content policy.
	
        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler cleanUpAfterFailure]):
        (-[WebDownloadHandler createFileIfNecessary]):
        (-[WebDownloadHandler finishedLoading]):
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _downloadURL:withContentPolicy:]):
        * WebView.subproj/WebDataSource.h:
        * WebView.subproj/WebDataSource.m:
        (+[WebDataSource registerRepresentationClass:forMIMEType:]):
        (-[WebDataSource isDownloading]):
        (-[WebDataSource downloadPath]):
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _commitIfReady]):
        (-[WebDataSource _setIsDownloading:]):
        (-[WebDataSource _setDownloadPath:]):
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient receivedError:]):
        (-[WebMainResourceClient handle:didReceiveResponse:]):
        (-[WebMainResourceClient handleDidFinishLoading:]):

mjs's avatar
WebKit:  
mjs committed
981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996
2002-11-11  Maciej Stachowiak  <mjs@apple.com>

	Don't ask for the content policy any more if the previous policies
	said to save - in effect this means to ask only if the previous
	policies said to use the content policy. Also, remove now-useless
	previous content policy parameter from content policy delegate.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
	(-[WebDataSource _setContentPolicy:]): Retain new policy before
	releasing the old one.
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        * WebView.subproj/WebMainResourceClient.m:
	(-[WebMainResourceClient handle:didReceiveResponse:]): Don't ask
	for content policy if the delegate already decided to save.

mjs's avatar
WebKit:  
mjs committed
997 998 999 1000 1001 1002 1003 1004 1005 1006 1007
2002-11-11  Maciej Stachowiak  <mjs@apple.com>

	Added new policy delegate callback to get the filename - this
	won't be up to the content policy any more.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate saveFilenameForResponse:andRequest:]):
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:didReceiveResponse:]):

darin's avatar
darin committed
1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041
2002-11-11  Darin Adler  <darin@apple.com>

	- made some improvements to cursor setting for greater speed and correctness

        * WebView.subproj/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView setCursor:]): Just use setDocumentCursor: instead of
	our own logic. This allows us to remove code and may fix some bugs or anomalies as well.
        (-[WebDynamicScrollBarsView dealloc]): Release the cursor. I think we were leaking before.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView viewWillMoveToSuperview:]): Use _frameOrBoundsChanged: method now, which
	has been moved into the private file.
        (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Don't bother finding
	topmost WebHTMLView to call _updateMouseoverWithEvent: on; now it works fine no matter
	which level it's called at.

        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLView _frameOrBoundsChanged:]): Moved the code here that was formerly in the
	_setNeedsLayoutIfSizeChanged method, also added code that does _updateMouseoverWithEvent:
	so that we get properly updated cursor when we scroll.
        (-[WebHTMLView _updateMouseoverWithEvent:]): Remove unneeded assert. This method works
	equally well no matter which WebHTMLView calls it; everything is done at the window and
	controller level.

        * WebView.subproj/WebControllerPrivate.h: Added lastElementWasNotNil field and
	_mouseDidMoveOverElement:modifierFlags: method.
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _mouseDidMoveOverElement:modifierFlags:]): Call through to the delegate,
	but don't do multiple calls if they are all nil.

        * WebCoreSupport.subproj/WebBridge.m: Remove unused modifierTrackingEnabled method.
        * WebView.subproj/WebHTMLViewPrivate.h: Remove unused _setModifierTrackingEnabled and
	_modifierTrackingEnabled methods.

darin's avatar
darin committed
1042 1043 1044 1045
2002-11-10  Darin Adler  <darin@apple.com>

        * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

cblu's avatar
cblu committed
1046 1047 1048 1049 1050 1051 1052 1053 1054
2002-11-10  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3021681 - downloaded files' creation and modification dates are not set

        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler createFileIfNecessary]): call [response creationDate] and [response lastModifiedDate] when setting file attributes.
        * Plugins.subproj/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream setResponse:]): call [response lastModifiedDate] when giving content to plug-ins.

1055 1056 1057 1058
2002-11-10  Darin Adler  <darin@apple.com>

        * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077
2002-11-09  Darin Adler  <darin@apple.com>

	- fixed 3095156 -- reproducible leak of WebDataSource due to bad URL in stylesheet

        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
	Check for errors by looking at the return value from loadWithRequest: rather than
	making a separate call to canInitWithRequest.

        * WebView.subproj/WebBaseResourceHandleDelegate.h: Add boolean success/failure result
	loadWithRequest:.
        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate loadWithRequest:]): Return NO if we fail to make a handle.

        * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]):
	Check result of loadWithRequest: and complain if it's NO.

        * WebView.subproj/WebMainResourceClient.m: Tweak whitespace.

cblu's avatar
WebKit:  
cblu committed
1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099
2002-11-09  Chris Blumenberg  <cblu@apple.com>

	Fixed: 2991610 - Alexander should support services, including Speech

        * WebView.subproj/WebHTMLView.m:
        (+[WebHTMLView initialize]): register for service types
        (-[WebHTMLView dealloc]): moved to top of file
        (-[WebHTMLView copy:]): call _writeSelectionToPasteboard
        (-[WebHTMLView writeSelectionToPasteboard:types:]): call _writeSelectionToPasteboard
        (-[WebHTMLView validRequestorForSendType:returnType:]): return self for our pboard types
        * WebView.subproj/WebHTMLViewPrivate.h:
        * WebView.subproj/WebHTMLViewPrivate.m:
        (+[WebHTMLView _pasteboardTypes]): new, returns the array of supported pboard types 
        (-[WebHTMLView _writeSelectionToPasteboard:]): new, adds data to pboard
        * WebView.subproj/WebImageView.m:
        (-[WebImageView initialize]): register for service types
        (-[WebImageView validateUserInterfaceItem:]): respond to copy
        (-[WebImageView validRequestorForSendType:returnType:]): return self for images
        (-[WebImageView writeImageToPasteboard:]): writes image data to pboard
        (-[WebImageView copy:]): calls writeImageToPasteboard
        (-[WebImageView writeSelectionToPasteboard:types:]): calls writeImageToPasteboard

darin's avatar
darin committed
1100 1101 1102 1103 1104 1105 1106 1107
2002-11-08  Darin Adler  <darin@apple.com>

        * History.subproj/WebHistoryItem.m:
        (-[WebHistoryItem setTitle:]): Use display title if it matches, so
	we don't end up with two identical strings, as when reading from
	the property list.
        (-[WebHistoryItem setDisplayTitle:]): The same thing, the other way round.

1108 1109 1110 1111 1112 1113 1114 1115 1116 1117
2002-11-08  Darin Adler  <darin@apple.com>

	- fixed 3095078 -- image loop counts still not handled right

        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer blockHasGIFExtensionSignature:length:]): Look for the tag
	"NETSCAPE2.0", not "NETSCAPE1.0".
        (-[WebImageRenderer nextFrame:]): Remove special handling for last frames with
	a duration of 0. That was just a misunderstanding.

1118 1119 1120 1121 1122
2002-11-08  Darin Adler  <darin@apple.com>

        * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]):
	Slightly better fix. Essentially just take out the assert.

darin's avatar
darin committed
1123 1124 1125 1126 1127 1128
2002-11-08  Darin Adler  <darin@apple.com>

	- fixed an assert I am seeing a lot

        * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]): Oops.

1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139
2002-11-08  Richard Williamson   <rjw@apple.com>

        Solved missing glyph problem, but it's very slow, so
        it's disabled for now.  I'll turn back on after extending
        the character to glyph map in each renderer to include
        substituted font.
        
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer substituteFontForString:]):
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177
2002-11-08  Darin Adler  <darin@apple.com>

	- separate WebBaseNetscapePluginStream more cleanly from its subclasses
	by making most fields private

        * Plugins.subproj/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream setResponse:]):
        * Plugins.subproj/WebNetscapePluginStream.h:
        * Plugins.subproj/WebNetscapePluginStream.m:
        (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]):
        (-[WebNetscapePluginStream dealloc]):
        (-[WebNetscapePluginStream start]):
        (-[WebNetscapePluginStream handle:didReceiveData:]):
        (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (-[WebSubresourceClient handle:didReceiveResponse:]):
        (-[WebSubresourceClient handle:didReceiveData:]):
        (-[WebSubresourceClient handleDidFinishLoading:]):
        (-[WebSubresourceClient handle:didFailLoadingWithError:]):
        (-[WebSubresourceClient cancel]):
        * WebView.subproj/WebBaseResourceHandleDelegate.h:
        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):
        (-[WebBaseResourceHandleDelegate handle:didFailLoadingWithError:]):
        (-[WebBaseResourceHandleDelegate _cancelWithError:]):
        (-[WebBaseResourceHandleDelegate cancel]):
        (-[WebBaseResourceHandleDelegate cancelQuietly]):
        (-[WebBaseResourceHandleDelegate cancelledError]):
        (-[WebBaseResourceHandleDelegate notifyDelegatesOfInterruptionByPolicyChange]):
        * WebView.subproj/WebMainResourceClient.h:
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient cancel]):
        (-[WebMainResourceClient handle:willSendRequest:]):
        (-[WebMainResourceClient notifyDelegatesOfInterruptionByPolicyChange]):
        (-[WebMainResourceClient handle:didReceiveResponse:]):
        (-[WebMainResourceClient handle:didReceiveData:]):
        (-[WebMainResourceClient handleDidFinishLoading:]):

darin's avatar
Tools:  
darin committed
1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211
2002-11-08  Darin Adler  <darin@apple.com>

	- changed persistent dictionaries to use NSString instead of NSURL
	because of impact on memory footprint

	Also changed WebIconDatabase code to verify what it reads from disk,
	and ignore it if it can't verify the format.

        * Misc.subproj/WebIconDatabase.m:
        (-[WebIconDatabase iconForSiteURL:withSize:cache:]):
        (-[WebIconDatabase retainIconForSiteURL:]):
        (-[WebIconDatabase releaseIconForSiteURL:]):
        (-[WebIconDatabase _iconDictionariesAreGood]):
        (-[WebIconDatabase _loadIconDictionaries]):
        (-[WebIconDatabase _updateFileDatabase]):
        (-[WebIconDatabase _hasIconForSiteURL:]):
        (-[WebIconDatabase _iconsForIconURLString:]):
        (-[WebIconDatabase _setIcon:forIconURL:]):
        (-[WebIconDatabase _setIconURL:forSiteURL:]):
        (-[WebIconDatabase _setBuiltInIconAtPath:forHost:]):
        (-[WebIconDatabase _retainIconForIconURLString:]):
        (-[WebIconDatabase _releaseIconForIconURLString:]):
        (-[WebIconDatabase _retainFutureIconForSiteURL:]):
        (-[WebIconDatabase _releaseFutureIconForSiteURL:]):
        (-[WebIconDatabase _retainOriginalIconsOnDisk]):
        (-[WebIconDatabase _releaseOriginalIconsOnDisk]):
        (-[NSEnumerator _web_isAllStrings]):
        * Panels.subproj/WebStandardPanels.m:
        (-[WebStandardPanels didStartLoadingURL:inWindow:]):
        (-[WebStandardPanels didStopLoadingURL:inWindow:]):
        (-[WebStandardPanels _didStartLoadingURL:inController:]):
        (-[WebStandardPanels _didStopLoadingURL:inController:]):
        (-[WebStandardPanels frontmostWindowLoadingURL:]):

1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231
2002-11-08  Darin Adler  <darin@apple.com>

	- fixed crash on boot that Don was seeing

        * History.subproj/WebHistoryItem.m:
        (-[WebHistoryItem URL]): Make this work when _URLString is nil.
        (-[WebHistoryItem initFromDictionaryRepresentation:]): Make this work for nil URL.

	- my own private war on the cString method

        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler initWithDataSource:]): Use %@ in LOG to avoid cString.
        (-[WebDownloadHandler finishedLoading]): Ditto.
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _commitIfReady]): Ditto.
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _timedLayout:]): Ditto.
        (-[WebFrame _setState:]): More of the same.
        (-[WebFrame _isLoadComplete]): Ditto.

1232 1233 1234 1235 1236 1237 1238 1239 1240
2002-11-08  Ken Kocienda  <kocienda@apple.com>

	Fix deployment build breaker: a variable was used only in a 
	LOG statement, causing the variable to become usused when
	building with the Deployment build style. 

        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler finishedLoading])

1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260
2002-11-07  Darin Adler  <darin@apple.com>

        * History.subproj/WebHistoryItem.h: Replace _URL with _URLString.

        * History.subproj/WebHistoryItem.m:
        (-[WebHistoryItem _retainIconInDatabase:]): Get the URL with [self URL].
        (-[WebHistoryItem initWithURL:target:parent:title:]): Set up _URLString.
        (-[WebHistoryItem dealloc]): Release _URLString.
        (-[WebHistoryItem URL]): Make a URL from _URLString.
        (-[WebHistoryItem icon]): Use [self URL] instead of _URL.
        (-[WebHistoryItem setURL:]): Store a URL string.
        (-[WebHistoryItem hash]): Use the URL string's hash.
        (-[WebHistoryItem isEqual:]): Compare the URL strings.
        (-[WebHistoryItem description]): Use _URLString.
        (-[WebHistoryItem dictionaryRepresentation]): Use _URLString.
        (-[WebHistoryItem initFromDictionaryRepresentation:]): Call through to
	the other init functions so we have only one designated initializer.
	Leave the date as nil if there's no date in the dictionary instead of
	setting the date to 0.

mjs's avatar
WebKit:  
mjs committed
1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274
2002-11-07  Maciej Stachowiak  <mjs@apple.com>

	Removed SaveAndOpenExternally policy.
	
        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler finishedLoading]):
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient receivedError:]):
        (-[WebMainResourceClient handle:didReceiveResponse:]):
        (-[WebMainResourceClient handleDidFinishLoading:]):

cblu's avatar
WebKit:  
cblu committed
1275 1276 1277 1278
2002-11-07  Chris Blumenberg  <cblu@apple.com>

        * WebKit.pbproj/project.pbxproj:

rjw's avatar
rjw committed
1279 1280 1281 1282 1283
2002-11-07  Richard Williamson  <rjw@apple.com>

        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer stopAnimation]):

1284 1285 1286 1287 1288 1289 1290 1291 1292 1293
2002-11-07  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3095628 - REGRESSION: exception when clicking on link to load content into iframe
	
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _actionInformationForNavigationType:event:]): Get the
	element info from the HTML view where the click originally
	happened, not the current document view. Add some asserts to make
	sure this is working.

1294 1295 1296

2002-11-07  Richard Williamson  <rjw@apple.com>

rjw's avatar
rjw committed
1297 1298
        Tweaks
        
1299 1300 1301 1302
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer convertCharacters:length:toGlyphs:skipControlCharacters:]):
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

sheridan's avatar
sheridan committed
1303 1304
=== Alexander-31 ===

1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315
2002-11-07  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3094778 - REGRESSION: Assert on logout from schwab.com

	(probably fixed it anyway - I'm flying blind on this one)
	
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge createWindowWithURL:frameName:]): Use a nil request
	if the URL was nil, instead of making a request that contains a
	nil URL.

mjs's avatar
WebKit:  
mjs committed
1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339
2002-11-07  Maciej Stachowiak  <mjs@apple.com>

	Changed things so that creating a window takes a request rather
	than a URL and referrer.
	
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge createWindowWithURL:frameName:]):
        * WebView.subproj/WebControllerPrivate.h:
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _openNewWindowWithRequest:behind:]):
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _setTriggeringEvent:]):
        (-[WebDataSource _triggeringEvent]):
        * WebView.subproj/WebDefaultContextMenuDelegate.m:
        (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
        * WebView.subproj/WebFrame.m:
        (-[WebFrame setProvisionalDataSource:]):
        (-[WebFrame findOrCreateFramedNamed:]):
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
        * WebView.subproj/WebWindowOperationsDelegate.h:

1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351
2002-11-06  Darin Adler  <darin@apple.com>

	- fixed problem where files small enough to fit entirely in the buffer
	(8K or less) would not be decoded

        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler decodeData:]): Added. Moved most of the code from
	receivedData into here.
        (-[WebDownloadHandler receivedData:]): Changed to call decodeData.
        (-[WebDownloadHandler finishedLoading]): Call decodeData on any remaining
	bytes rather than writing them straight out to the data fork.

1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367
2002-11-06  Richard Williamson  <rjw@apple.com>

        More work on rendering scripts. Now most complex scripts render correctly.
        Working new features include:
        bidi, diacriticals, cursive forms, and arabic ligatures.
        Selection of text rendered in these scripts, is however, not working. 
        Also, line height is incorrect when renderering combined below glyphs.
        ajami is, sadly, horrendously broken.

        * Misc.subproj/WebUnicode.m:
        (glyphVariantLogical):
        (shapedString):
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]):
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

sullivan's avatar
WebKit:  
sullivan committed
1368 1369 1370 1371 1372 1373
2002-11-06  John Sullivan  <sullivan@apple.com>

        * Bookmarks.subproj/WebBookmark.m:
        (+[WebBookmark bookmarkOfType:]):
	made this handle WebBookmarkTypeProxy

1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384
2002-11-06  Darin Adler  <darin@apple.com>

	- fixed bug that affected BinHex-encoded files with no resource fork

        * Downloads.subproj/WebBinHexDecoder.m:
        (-[WebBinHexDecoder decodeData:dataForkData:resourceForkData:]):
	Don't decode the resource fork unless done with the data fork.

        * Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedData:]):
	Set the forks to nil before calling through.

1385 1386 1387 1388 1389 1390 1391
2002-11-06  Darin Adler  <darin@apple.com>

        * Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]):
	Fix == 129 check that was supposed to be <= 129.

        * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

1392 1393 1394 1395 1396 1397 1398
2002-11-06  Darin Adler  <darin@apple.com>

        * Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeIntoBuffer:size:]):
	Fix an off-by-one error handling repeat counts.

        * WebKit.pbproj/project.pbxproj: Fix group name I accidentally mangled.

1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419
2002-11-06  Darin Adler  <darin@apple.com>

	- added a BinHex decoder and did a little work on the MacBinary decoder
        
        I'm not supposed to be working on this, but I didn't feel like doing "real" work.

        * Downloads.subproj/WebBinHexDecoder.h: Added.
        * Downloads.subproj/WebBinHexDecoder.m: Added.
        * WebKit.pbproj/project.pbxproj: Added WebBinHexDecoder.

        * Downloads.subproj/WebDownloadDecoder.h: Added WEB_DOWNLOAD_DECODER_MINIMUM_HEADER_LENGTH.
        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler closeFile]): Check to be sure we don't close the same file twice.

        * Downloads.subproj/WebMacBinaryDecoder.h: Added _scriptCode.
        * Downloads.subproj/WebMacBinaryDecoder.m:
        (+[WebMacBinaryDecoder canDecodeHeaderData:]): Added check of MacBinary version field.
        (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Added MacBinary III
	part that gets the script code.
        (-[WebMacBinaryDecoder filename]): Use the script code.

mjs's avatar
WebKit:  
mjs committed
1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435
2002-11-06  Maciej Stachowiak  <mjs@apple.com>

	Took URL field out of click policy - open in new window policy
	will always open the request URL.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebControllerPolicyDelegate.m:
        (-[WebPolicyPrivate dealloc]):
        (+[WebURLPolicy webPolicyWithURLAction:]):
        (+[WebFileURLPolicy webPolicyWithFileAction:]):
        (+[WebContentPolicy webPolicyWithContentAction:andPath:]):
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueAfterClickPolicyForEvent:request:]):

1436 1437 1438 1439 1440 1441 1442
2002-11-06  Chris Blumenberg  <cblu@apple.com>

	Support MacBinary I by checking that bytes 99-127 are 0. Also check byte 82 for all formats.

        * Downloads.subproj/WebMacBinaryDecoder.m:
        (+[WebMacBinaryDecoder canDecodeHeaderData:]):

kocienda's avatar
kocienda committed
1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454
2002-11-06  Ken Kocienda  <kocienda@apple.com>

	Call new WebHTTPResourceRequest method to set the amount of time
	to cache a 404 response when trying to fetch a favicon.

	This change helps to fix this bug:

	Radar 3004422 (Loader should cache misses)

        * Misc.subproj/WebIconLoader.m:
        (-[WebIconLoader startLoading])

mjs's avatar
WebKit:  
mjs committed
1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468
2002-11-05  Maciej Stachowiak  <mjs@apple.com>

	Reworked clickPolicy arguments to be closer to proposed version.
	
        * WebKit.exp:
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebControllerPolicyDelegate.m:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _actionInformationForNavigationType:event:]):
        (-[WebFrame _continueAfterClickPolicyForEvent:request:]):

1469 1470 1471 1472 1473
2002-11-05  Darin Adler  <darin@apple.com>

        * WebCoreSupport.subproj/WebTextRenderer.m: Made a slightly simpler and faster
	version of the new "lose precision" CEIL_TO_INT macro.

1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484
2002-11-05  Richard Williamson  <rjw@apple.com>

        Fixed a couple of issues that Dave highlighted w/ his whitespace
        fixes.  CG sometimes introduces very small 'error' in metrics, specifically
        we saw character widths of 20.0000019 that should have been 20.  As a 
        work-around we loose precision beyond the 1000th place.  Also, always
        ceil spaces.
                
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

1485 1486 1487 1488 1489 1490 1491 1492 1493
2002-11-05  Darin Adler  <darin@apple.com>

	- fixed 3084704 -- crash in HTMLTokenizer on page with JavaScript
	HTMLDocument::Close inside a <script>

        * WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]):
	We need to stop loading here. Otherwise we might do loading after closeURL,
	which could lead to a problem like the one above.

1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507
2002-11-05  Darin Adler  <darin@apple.com>

	- changed our MacBinary decoding to not pay any attention to the comment

	Before we would "fail to decode" if the comment was truncated, now we just
	don't worry about it.

        * Downloads.subproj/WebMacBinaryDecoder.h: Remove _commentLength and _commentEnd.
        * Downloads.subproj/WebMacBinaryDecoder.m:
        (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Remove code
	to get _commentLength and code to compute _commentEnd.
        (-[WebMacBinaryDecoder finishDecoding]): Check offset against the resource fork
	end rather than the comment end to see if we got enough data.

sullivan's avatar
WebKit:  
sullivan committed
1508 1509 1510 1511 1512 1513 1514
2002-11-05  John Sullivan  <sullivan@apple.com>

        * Resources/url_icon.tiff:
	reverted generic URL icon back to the one that
	looks like a document until we get something from
	HI that SJ likes

cblu's avatar
WebKit:  
cblu committed
1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545
2002-11-05  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3074108 - Decode macbinary files during download

        * Downloads.subproj/WebDownloadDecoder.h:
        * Downloads.subproj/WebDownloadHandler.h:
        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler initWithDataSource:]):
        (-[WebDownloadHandler dealloc]):
        (-[WebDownloadHandler decodeHeaderData:dataForkData:resourceForkData:]):
        (-[WebDownloadHandler decodeData:dataForkData:resourceForkData:]):
        (-[WebDownloadHandler closeFile]):
        (-[WebDownloadHandler cleanUpAfterFailure]):
        (-[WebDownloadHandler createFileIfNecessary]):
        (-[WebDownloadHandler writeData:toFork:]):
        (-[WebDownloadHandler writeDataForkData:resourceForkData:]):
        (-[WebDownloadHandler dataIfDoneBufferingData:]):
        (-[WebDownloadHandler receivedData:]):
        (-[WebDownloadHandler finishDecoding]):
        (-[WebDownloadHandler finishedLoading]):
        (-[WebDownloadHandler cancel]):
        * Downloads.subproj/WebMacBinaryDecoder.h:
        * Downloads.subproj/WebMacBinaryDecoder.m:
        (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]):
        (-[WebMacBinaryDecoder fileAttributes]):
        (-[WebMacBinaryDecoder filename]):
        * Misc.subproj/WebKitErrors.h: added new errors
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:didReceiveResponse:]): don't send response to download handler
        (-[WebMainResourceClient handle:didReceiveData:]): watch for decoding errors

kocienda's avatar
kocienda committed
1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558
2002-11-05  Ken Kocienda  <kocienda@apple.com>

	Fix for this bug:

	Radar 3092747 (javascript cookieEnabled property returns incorrect value)

	Now, we return "true" for navigator.cookieEnabled when 
	"Only accept cookies from the same domain as the current page" option
	is selected is user preferences.

        * WebCoreSupport.subproj/WebCookieAdapter.m:
        (-[WebCookieAdapter cookiesEnabled])

sullivan's avatar
WebKit:  
sullivan committed
1559 1560 1561 1562 1563 1564 1565 1566
2002-11-05  John Sullivan  <sullivan@apple.com>

	- fixed 3091271 -- missing plug-in icon is on white
	background, not transparent.

        * Resources/nullplugin.tiff: Photoshopped the white away. It's
	still ugly, but that's a separate bug (3091274)

1567 1568 1569 1570 1571 1572 1573 1574 1575 1576
2002-11-05  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3083732 - SJ: window comes out blank on samsung site
	
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
	Don't start loading if the URL is exactly the same as the parent
	URL. We may need a more stringent check, but this seems to match
	the tolerance of other browsers OK.

mjs's avatar
WebKit:  
mjs committed
1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588
2002-11-05  Maciej Stachowiak  <mjs@apple.com>

	Added request and frame to click policy callback.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate clickPolicyForElement:button:modifierFlags:request:inFrame:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):

1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610
2002-11-04  Richard Williamson  <rjw@apple.com>

        Changes to support cursive letter forms.  It works, but I've
        disabled it for now.  It's buggy and needs cleanup.
        Arabic now renders correctly except for ligature substitution.
        
        * Misc.subproj/WebUnicode.h:
        * Misc.subproj/WebUnicode.m:
        (_unicodeIsMark):
        (getShape):
        (prevChar):
        (nextChar):
        (prevLogicalCharJoins):
        (nextLogicalCharJoins):
        (glyphVariantLogical):
        (shapedString):
        * Misc.subproj/WebUnicodeTables.m:
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]):
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):
        * WebKitPrefix.h:

1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628
2002-11-04  Maciej Stachowiak  <mjs@apple.com>

	Changes to send NSEvents all the way through WebCore and then pass
	them back out to WebKit, so that click policy can have a
	WebResourceRequest added.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge loadURL:reload:triggeringEvent:]):
        (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueAfterClickPolicyForEvent:]):
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView mouseUp:]):
        * WebView.subproj/WebHTMLViewPrivate.h:
        * WebView.subproj/WebHTMLViewPrivate.m:

1629 1630 1631 1632 1633 1634 1635 1636 1637 1638
2002-11-04  Chris Blumenberg  <cblu@apple.com>

	Fixed - 3091658: REGRESSION: cmd-left for back doesn't work in plain-text viewer

	We now pass text field key events to the next responder which would be WebView in this case.

        * WebView.subproj/WebTextView.m:
        (-[WebTextView keyDown:]):
        (-[WebTextView keyUp:]):

1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670
2002-11-04  Darin Adler  <darin@apple.com>

	- fixed 3090257 -- "leak the world" using the Wallace and Gromit "console"

        * Plugins.subproj/WebNetscapePluginStream.m: Update for changes to the base delegate.
        (-[WebNetscapePluginStream start]): Use loadWithRequest:.
        (-[WebNetscapePluginStream stop]): Call cancel instead of just canceling the handle
	directly. This fixes the world leak.
        (-[WebNetscapePluginStream cancel]): Do some of the work that was formerly in "stop".

        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:willSendRequest:]): Call the "stop loading URL" whenever
	we cancel I/O, so we don't leak the world.
        (-[WebMainResourceClient handle:didReceiveResponse:]): Ditto.

        * WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:response:size:]):
        * WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:]):
        * WebView.subproj/WebControllerPrivate.h:
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _finishedLoadingResourceFromDataSource:]):
	Fix a typo in the word "finished".

        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): Tweak.
        (-[WebBaseResourceHandleDelegate cancel]): Tweak.

        * Panels.subproj/WebStandardPanels.m:
        (-[WebStandardPanels didStartLoadingURL:inWindow:]): Add assertions.
        (-[WebStandardPanels didStopLoadingURL:inWindow:]): Ditto.
        (-[WebStandardPanels _didStartLoadingURL:inController:]): Ditto.
        (-[WebStandardPanels _didStopLoadingURL:inController:]): Ditto.

1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688
2002-11-04  Darin Adler  <darin@apple.com>

        * Downloads.subproj/WebMacBinaryDecoder.h: Removed many unneeded fields.
        * Downloads.subproj/WebMacBinaryDecoder.m:
        (+[WebMacBinaryDecoder canDecodeHeaderData:]): Added comments. Changed maximum filename
	length to 63 as the format supports, rather than the 31 that's based on historical
	HFS limitations. Fix endian dependency in CRC check.
        (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Simplified this,
	and removed the state machine and the accumulator. Also added some asserts. Fixed endian
	dependency in the code to extract the header.
        (-[WebMacBinaryDecoder finishDecoding]): New simpler check now that we don't have a
	_streamComplete boolean.
        (-[WebMacBinaryDecoder fileAttributes]): Rewrote to take advantage of the above changes,
	and also to use kCFAbsoluteTimeIntervalSince1904 rather than parsing a date string.

        * Downloads.subproj/crc16.h: Tweaks.
        * Downloads.subproj/crc16.m: Tweaks.

darin's avatar
WebKit:  
darin committed
1689 1690 1691 1692 1693
2002-11-04  Darin Adler  <darin@apple.com>

        * WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer dealloc]):
	Replaced a useless call to stopAnimation with a couple of asserts.

sullivan's avatar
WebKit:  
sullivan committed
1694 1695 1696 1697 1698 1699
2002-11-04  John Sullivan  <sullivan@apple.com>

        * Resources/url_icon.tiff:
	new "generic URL" icon from HI -- this one looks like
	a red ribbon (!)

darin's avatar
WebKit:  
darin committed
1700 1701 1702 1703 1704 1705
2002-11-03  Darin Adler  <darin@apple.com>

        * Plugins.subproj/WebPluginError.h:
        * Plugins.subproj/WebPluginError.m:
	Not __MyCompanyName__, but rather Apple Computer.

darin's avatar
darin committed
1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716
2002-11-03  Darin Adler  <darin@apple.com>

        * Plugins.subproj/WebPlugin.h: Fix comment.

        * Plugins.subproj/WebPluginError.m: (-[WebPluginErrorPrivate dealloc]):
	Fix leak by calling [super dealloc].

        * WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): Remove the
	timer invalidate since, as Trey pointed out, it's pointless to invalidate a
	timer in dealloc if it's retaining this object while valid.

cblu's avatar
WebKit:  
cblu committed
1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735
2002-11-03  Chris Blumenberg  <cblu@apple.com>

	- Added MacBinary decoding code. Not yet used.

        * Downloads.subproj/WebMacBinaryDecoder.h: Added.
        * Downloads.subproj/WebMacBinaryDecoder.m: Added.
        (+[WebMacBinaryDecoder canDecodeHeaderData:]):
        (-[WebMacBinaryDecoder init]):
        (-[WebMacBinaryDecoder dealloc]):
        (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]):
        (-[WebMacBinaryDecoder finishDecoding]):
        (-[WebMacBinaryDecoder fileAttributes]):
        * Downloads.subproj/crc16.h: Added.
        * Downloads.subproj/crc16.m: Added.
        (CRC16):
        * Plugins.subproj/WebPluginPackage.m:
        (-[WebPluginPackage isLoaded]): 
        * WebKit.pbproj/project.pbxproj:

darin's avatar
Tools:  
darin committed
1736 1737 1738 1739 1740
2002-11-03  Darin Adler  <darin@apple.com>

        * English.lproj/StringsNotToBeLocalized.txt: Update for recent
	changes both to the code here and to the extract script.

darin's avatar
darin committed
1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751
2002-11-03  Darin Adler  <darin@apple.com>

	- fixed 3091300 -- "prelighting" on local page is still slow, despite recent bug fix

	Turns out all updating would be slow if any resources on the page failed to load.

        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
	Call the new reportError instead of cancel.
        (-[WebSubresourceClient handle:didFailLoadingWithError:]): Ditto.

1752 1753 1754 1755 1756
2002-11-02  Darin Adler  <darin@apple.com>

        * Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]):
	Do the previous fix one better by using _web_hostWithPort.

1757 1758 1759 1760 1761 1762 1763
2002-11-02  Darin Adler  <darin@apple.com>

	- fixed bug where the address of an NSNumber object would be used for the port number

        * Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]):
	Call intValue on the object returned from [NSURL port].

1764 1765 1766 1767 1768
2002-11-01  Darin Adler  <darin@apple.com>

        * Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]):
	Fixed uninitialized variable problem.

1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795
2002-11-01  Darin Adler  <darin@apple.com>

	- fixed 3090239 -- crash on window close

        * WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): Nil out the bridge and
	release it so we don't close the URL twice.

	- fixed 3058598 -- animated gif animates repeatedly in Alex, but only once in other browsers

        * WebCoreSupport.subproj/WebImageRenderer.h: Added fields used by bug workaround.
        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer blockHasGIFExtensionSignature:length:]): Helper method for bug workaround.
        (-[WebImageRenderer checkDataForGIFExtensionSignature:]): Checks incoming data for the GIF
	extension signatures.
        (-[WebImageRenderer initWithData:]): Override to call checkDataForGIFExtensionSignature.
        (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): Call checkDataForGIFExtensionSignature.
        (-[WebImageRenderer repetitionCount]): Return 1 if we were going to return 0, but we didn't see a
	GIF extension signature. This workaround can be removed once we require a system new enough to have
	the bug fix for bug 3090341.
        (-[WebImageRenderer nextFrame:]): Stop on last frame, don't wrap around to first.

        * WebCoreSupport.subproj/WebImageRendererFactory.h: Update for changes to WebCore.
        * WebCoreSupport.subproj/WebImageRendererFactory.m: Tweaks.

        * WebView.subproj/WebImageRepresentation.m: Update imports.
        * WebView.subproj/WebImageView.m: Update imports.

rjw's avatar
rjw committed
1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815
2002-11-01  Richard Williamson   <rjw@apple.com>

        Implemented rendering of diacriticals.
        
        * Misc.subproj/WebUnicode.h:
        * Misc.subproj/WebUnicode.m:
        (_unicodeDigitValue):
        (_unicodeCategory):
        (_unicodeDirection):
        (_unicodeJoining):
        (_unicodeDecompositionTag):
        (_unicodeMirrored):
        (_unicodeCombiningClass):
        (_unicodeLower):
        (_unicodeUpper):
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]):
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):
        (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]):

darin's avatar
darin committed
1816 1817 1818 1819
2002-11-01  Darin Adler  <darin@apple.com>

        * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

cblu's avatar
WebKit:  
cblu committed
1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841
2002-11-01  Chris Blumenberg  <cblu@apple.com>

	Check that the plug-in is loaded before calling it.

        * Plugins.subproj/WebBaseNetscapePluginStream.h:
        * Plugins.subproj/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream dealloc]):
        (-[WebBaseNetscapePluginStream setPluginPointer:]):
        (-[WebBaseNetscapePluginStream setResponse:]):
        (-[WebBaseNetscapePluginStream receivedData:]):
        (-[WebBaseNetscapePluginStream destroyStreamWithReason:]):
        (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
        * Plugins.subproj/WebBasePluginPackage.h:
        * Plugins.subproj/WebBasePluginPackage.m:
        (-[WebBasePluginPackage isLoaded]):
        * Plugins.subproj/WebNetscapePluginDocumentView.m:
        (-[WebNetscapePluginDocumentView setDataSource:]):
        * Plugins.subproj/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage isLoaded]):
        * Plugins.subproj/WebNetscapePluginRepresentation.m:
        (-[WebNetscapePluginRepresentation receivedData:withDataSource:]):

cblu's avatar
cblu committed
1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876
2002-11-01  Chris Blumenberg  <cblu@apple.com>

	- Moved plug-in error handling to WebResourceLoadDelegate
	- Report plug-in load failure, java load failure, and plug-in not found errors.
	- Added WebPluginError, subclass of WebError.
	- Attempted fix: 3090675 - Standalone WMP (Window Media Player) content crashes Alexander

        * English.lproj/Localizable.strings:
        * Misc.subproj/WebKitErrors.h:
        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView sendEvent:]): don't send event to null function
        * Plugins.subproj/WebNetscapePluginDocumentView.m:
        (-[WebNetscapePluginDocumentView setDataSource:]): report plug-in load failure
        * Plugins.subproj/WebNullPluginView.h:
        * Plugins.subproj/WebNullPluginView.m: take a WebPluginError
        (-[WebNullPluginView dealloc]):
        (-[WebNullPluginView viewDidMoveToWindow]):
        * Plugins.subproj/WebPluginError.h: Added.
        * Plugins.subproj/WebPluginError.m: Added.
        (-[WebPluginErrorPrivate dealloc]):
        (-[WebPluginError dealloc]):
        (-[WebPluginError pluginPageURL]):
        (-[WebPluginError pluginName]):
        (-[WebPluginError MIMEType]):
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): report plug-in load failure
        (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): report plug-in load failure
        * WebKit.pbproj/project.pbxproj:
        * WebView.subproj/WebController.m:
        (-[WebResourceLoadDelegate pluginFailedWithError:dataSource:]): added, does nothing
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebResourceLoadDelegate.h:
        * WebView.subproj/WebView.m:
        (+[WebView initialize]): added new error strings

sullivan's avatar
WebKit:  
sullivan committed
1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895
2002-11-01  John Sullivan  <sullivan@apple.com>

	- some weaning of WebBookmark API from WebBookmarkGroup

        * Bookmarks.subproj/WebBookmark.m:
        (-[WebBookmark dealloc]):
	set group to nil instead of asserting that it's non-nil

        * Bookmarks.subproj/WebBookmarkGroup.h:
	removed obsolete ivar _bookmarksByID
        * Bookmarks.subproj/WebBookmarkGroup.m:
        (-[WebBookmarkGroup initWithFile:]):
	removed obsolete ivar _bookmarksByID
        (-[WebBookmarkGroup dealloc]):
	removed obsolete ivar _bookmarksByID
        (-[WebBookmarkGroup removeBookmark:]):
	removed this unnecessary method; callers need to use
	[[bookmark parent] removeChild:bookmark] instead

1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931
2002-11-01  Trey Matteson  <trey@apple.com>

	Moved involved code for loading URLs from WebBridge up to WebFrame, with a little
	consolidation along the way.  I need to get all this stuff in one place in prep
	for doing back-forward properly with frames.  There should be no change in
	functionality as a result of these changes.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge loadURL:reload:]):
        (-[WebBridge postWithURL:data:contentType:]):
        (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
	Much of the guts of these is moved to WebFramePrivate.
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _setIsClientRedirect:]):
        (-[WebDataSource _isClientRedirect]):
	Keep state of whether we're processing a redirect in DataSource.  I had previously
	to do this with a loadType, but that failed because cliRedir is orthogonal.
        * WebView.subproj/WebFramePrivate.h:
	WebFrameLoadTypeClientRedirect is gone.
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFramePrivate init]):
	Initialize loadType explicitly.
        (-[WebFrame _transitionToCommitted]):
	Test [dataSource _isClientRedirect] instead of looking at loadType.
        (-[WebFrame _isLoadComplete]):
	Nuke WebFrameLoadTypeClientRedirect
        (-[WebFrame _goToItem:withFrameLoadType:]):
	Nuke WebFrameLoadTypeClientRedirect.
        (-[WebFrame _loadRequest:]):
	Helper method moved from WebBridge.
        (-[WebFrame _loadURL:loadType:clientRedirect:]):
	Core impl moved up from WebBridge.
        (-[WebFrame _postWithURL:data:contentType:]):
	Core impl moved up from WebBridge.

darin's avatar
darin committed
1932 1933 1934 1935 1936 1937 1938 1939 1940
2002-11-01  Darin Adler  <darin@apple.com>

	- implemented loop counts

        * WebCoreSupport.subproj/WebImageRenderer.h: Added repetitionsComplete field.
        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer repetitionCount]): Get NSImageLoopCount.
        (-[WebImageRenderer nextFrame:]): Check repetitionCount and stop once we hit it.

1941 1942 1943 1944 1945
2002-10-31  Darin Adler  <darin@apple.com>

        * WebView.subproj/WebFrame.m: (-[WebFrame setController:]): Add an assert,
	hoping to catch a reported bug earlier or disprove one theory.

1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983
2002-10-31  Trey Matteson  <trey@apple.com>

	Added API to support 3072505 - SnapBack for user-entered page address
	Refixed 3041616 - Extra page added in back button history
	Previous fix was stepped on by a later checkin.  Re-established that fix, then
	went on to make sure we have the final URL and title in the BF item in the
	case of a client redirect.  Also handles redirects that happen within frames.
	Fixed 3078560 - div added to "back" list

        * History.subproj/WebBackForwardList.h:
        * History.subproj/WebBackForwardList.m:
        (-[WebBackForwardList containsEntry:]):
	Added new API for 3072505.
        * WebCoreSupport.subproj/WebBridge.h:
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge reportClientRedirectTo:delay:fireDate:]):
        (-[WebBridge reportClientRedirectCancelled]):
        (-[WebBridge loadURL:reload:]):
	Added logging.  Renamed flag.  Establish the right loadtype and set BF items
	from the old dataSource onto the new dataSource in the case of a client redirect.
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _setRequest:]):
	Add logging.
        (-[WebDataSource _addBackForwardItem:]):
        (-[WebDataSource _addBackForwardItems:]):
        (-[WebDataSource _backForwardItems]):
	New setters/getters to support setting up the new dataSource of a client redirect.
        * WebView.subproj/WebFramePrivate.h:
	New loadType WebFrameLoadTypeClientRedirect.
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted]):
	Update the URL in the BF list in the client redirect case.
        (-[WebFrame _isLoadComplete]):
	NOP case for WebFrameLoadTypeClientRedirect
        (-[WebFrame _goToItem:withFrameLoadType:]):
	ASSERT_NOT_REACHED case for WebFrameLoadTypeClientRedirect

1984 1985 1986 1987 1988 1989 1990 1991 1992 1993
2002-10-31  Richard Williamson  <rjw@apple.com>

        Corrected extern definitions of lookup tables.
        
        * Misc.subproj/WebUnicode.h:
        * Misc.subproj/WebUnicode.m:
        (_unicodeDirection):
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (+[WebTextRenderer initialize]):

1994
=== Alexander-30 ===
sheridan's avatar
sheridan committed
1995

1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021
2002-10-30  Richard Williamson  <rjw@apple.com>

        More work on bidi and contextual forms.
        Table lookup code for unicode characters attributes.

        * Misc.subproj/WebUnicode.h: Added.
        * Misc.subproj/WebUnicode.m: Added.
        (_unicodeDigitValue):
        (_unicodeCategory):
        (_unicodeDirection):
        (_unicodeJoining):
        (_unicodeDecompositionTag):
        (_unicodeMirrored):
        (_unicodeMirroredChar):
        (_unicodeCombiningClass):
        (_unicodeLower):
        (_unicodeUpper):
        (WebKitInitializeUnicode):
        * Misc.subproj/WebUnicodeTables.m: Added.
        * WebKit.pbproj/project.pbxproj:

        Additional logging parameter.
        
        * Misc.subproj/WebKitLogging.h:
        * Misc.subproj/WebKitLogging.m:

mjs's avatar
WebKit:  
mjs committed
2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034
2002-10-30  Maciej Stachowiak  <mjs@apple.com>

	Pass WebResourceRequest rather than just NSURL to URL policy
	delegate method.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (+[WebDefaultPolicyDelegate defaultURLPolicyForRequest:]):
        (-[WebDefaultPolicyDelegate URLPolicyForRequest:inFrame:]):
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _shouldShowRequest:]):

darin's avatar
darin committed
2035 2036 2037 2038
2002-10-30  Darin Adler  <darin@apple.com>

        * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

2039 2040 2041 2042 2043 2044 2045
2002-10-30  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3088122 - Assertion failure/crash closing window with QuickTime streaming in

        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _setMainDocumentError:]): call receivedError on the representation.

2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059
2002-10-30  Darin Adler  <darin@apple.com>

	- fixed memory leaks in plugin package creation code

        * Plugins.subproj/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage initWithPath:]): Rearrange this code, and make sure
	that it does a [self release] if it's going to return nil instead of self.
        (-[WebNetscapePluginPackage unload]): Set bundle to 0 when we release it.
        (-[WebNetscapePluginPackage dealloc]): Release the bundle if it's not 0.

        * Plugins.subproj/WebPluginPackage.m:
        (-[WebPluginPackage initWithPath:]): Rearrange this code, and make sure
	that it does a [self release] if it's going to return nil instead of self.

darin's avatar
darin committed
2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073
2002-10-30  Darin Adler  <darin@apple.com>

	- fixed 3086564 -- REGRESSION: meta-refresh to the same page doesn't refresh

	The key is to respect the new reload: parameter from the bridge.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge loadURL:reload:]): Don't ever treat a reload as a redirect.
	Set the cache policy to WebRequestCachePolicyLoadFromOrigin if it's a reload.

	- fixed 3087214 -- REGRESSION: <WebKit/WebKit.h> contains #import of non-existent header

        * Misc.subproj/WebKit.h: Removed import of WebControllerSets.h, which is private.

mjs's avatar
WebKit:  
mjs committed
2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089
2002-10-30  Maciej Stachowiak  <mjs@apple.com>

	Another step towards the policy API change - add request argument
	to file URL policy and remove isDirectory argument.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate fileURLPolicyForMIMEType:andRequest:inFrame:]):
        * WebView.subproj/WebFrame.m:
        (-[WebFrame setProvisionalDataSource:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _shouldShowRequest:]):
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:willSendRequest:]):

mjs's avatar
WebKit:  
mjs committed
2090 2091 2092 2093 2094 2095 2096 2097 2098 2099
2002-10-29  Maciej Stachowiak  <mjs@apple.com>

	First step towards policy API change. Pass request instead of URL
	to content policy delegate method.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:didReceiveResponse:]):

2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111
2002-10-29  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3087548 - REGRESSION: two windows open for netflix confirmation
	
        * WebView.subproj/WebControllerPrivate.h:
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _findFrameInThisWindowNamed:]): Added this function back,
	and added check for top-level frame name.
        (-[WebController _findFrameNamed:]): Use
	_findFrameInThisWindowNamed: to make sure top-level frame names
	get checked.

2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129
2002-10-29  Chris Blumenberg  <cblu@apple.com>

	Created Downloads.subproj to hold the to-be-implemented download decoders.

        * Downloads.subproj/WebDownloadDecoder.h: Added.
        * Downloads.subproj/WebDownloadHandler.h: Added.
        * Downloads.subproj/WebDownloadHandler.m: Added.
        (-[WebDownloadHandler initWithDataSource:]):
        (-[WebDownloadHandler dealloc]):
        (-[WebDownloadHandler errorWithCode:]):
        (-[WebDownloadHandler receivedResponse:]):
        (-[WebDownloadHandler receivedData:]):
        (-[WebDownloadHandler finishedLoading]):
        (-[WebDownloadHandler cancel]):
        * Misc.subproj/WebDownloadHandler.h: Removed.
        * Misc.subproj/WebDownloadHandler.m: Removed.
        * WebKit.pbproj/project.pbxproj:

darin's avatar
darin committed
2130 2131 2132 2133 2134 2135 2136 2137
2002-10-28  Darin Adler  <darin@apple.com>

	- fixed crash I just introduced

        * Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]):
	Remove the release call here. When I added the autorelease, I didn't realize that
	the caller was doing a release.

2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156
2002-10-28  Trey Matteson  <trey@apple.com>

	Fixed 3041616 - Extra page added in back button history

	Client-side redirects would always put an extra item in the backforward list.
	According to Darin this is a regression all the way back from functionality moving
	from WebBrowser to WebKit.	

        * WebCoreSupport.subproj/WebBridge.h:
	Added state to know if we're doing an "internal" type of load
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge reportClientRedirectTo:delay:fireDate:]):
	Set internalLoad bit if delay==0
        (-[WebBridge reportClientRedirectCancelled]):
	Clear internalLoad
        (-[WebBridge loadURL:]):
	Set frame's loadType if doing an internal load (similar to what we do when loading
	child frames)

darin's avatar
darin committed
2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170
2002-10-28  Darin Adler  <darin@apple.com>

	- fixed storage leak of WebNetscapePluginPackage objects

        * Plugins.subproj/WebBasePluginPackage.m:
        (+[WebBasePluginPackage pluginWithPath:]): Add missing autorelease.

        * Plugins.subproj/WebBasePluginPackage.h:
        * Plugins.subproj/WebPluginController.h:
        * Plugins.subproj/WebPluginController.m:
        * Plugins.subproj/WebPluginPackage.h:
        * Plugins.subproj/WebPluginPackage.m:
	Not __MyCompanyName__, but rather Apple Computer.

darin's avatar
darin committed
2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203
2002-10-28  Darin Adler  <darin@apple.com>

	- fixed bug that caused us to leak all WebResourceHandles used for subresources

        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (-[WebSubresourceClient dealloc]): Remove bogus "currentURL == nil" assert.
        (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
	Use the new loadWithRequest: call instead of making handle and doing loadWithDelegate:.
	This is where the leak was, because no one ever released the handle, but releasing it
	right away would be too soon.

        * WebView.subproj/WebBaseResourceHandleDelegate.h: Added defersCallbacks field,
	loadWithRequest: method, and setDefersCallbacks: method. Removed handle method.
        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate loadWithRequest:]): New method. Sets up the handle,
	set the defersCallbacks state on it, and calls loadWithDelegate:.
        (-[WebBaseResourceHandleDelegate setDefersCallbacks:]): Stores defersCallbacks state,
	and also sets it on the handle, if any.
        (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): Remove code to set up
	the handle, since we now do that at loadWithRequest: time.

        * WebView.subproj/WebDataSourcePrivate.h: Remove mainHandle field.
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSourcePrivate dealloc]): Don't release mainHandle.
        (-[WebDataSource _setPrimaryLoadComplete:]): Ditto.
        (-[WebDataSource _startLoading]): Use loadWithRequest: on the client, no need to deal
	with the handle directly at all.
        (-[WebDataSource _addSubresourceClient:]): Call setDefersCallbacks: on the client.
        (-[WebDataSource _defersCallbacksChanged]): Ditto.

        * WebView.subproj/WebControllerPrivate.m: Remove unneeded include.
        * WebView.subproj/WebMainResourceClient.m: Ditto.

cblu's avatar
cblu committed
2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218
2002-10-28  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3056726 - View Source window always displays the source in current system encoding
	Fixed: 3019352 - Text encoding is not handled when viewing plain text

        * WebView.subproj/WebDataSource.h:
        * WebView.subproj/WebDataSource.m:
        (-[WebDataSource stringWithData:]): added, creates a string using the specified encoding.
        * WebView.subproj/WebHTMLRepresentation.m:
        (-[WebHTMLRepresentation documentSource]): uses the bridge specified encoding when creating the string
        * WebView.subproj/WebTextView.h:
        * WebView.subproj/WebTextView.m:
        (-[WebTextView dataSourceUpdated:]): use stringWithData: 
        (-[WebTextView supportsTextEncoding]): Yup

rjw's avatar
rjw committed
2219 2220 2221 2222 2223 2224 2225
2002-10-28  Richard Williamson   <rjw@apple.com>

        Fixed crasher.
        
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

sullivan's avatar
WebKit:  
sullivan committed
2226 2227 2228 2229 2230 2231 2232
2002-10-28  John Sullivan  <sullivan@apple.com>

        * Bookmarks.subproj/WebBookmark.h:
        * Bookmarks.subproj/WebBookmark.m:
        (-[WebBookmark contentMatches:]): new method, returns YES if
	two bookmarks are the same, ignoring group and parent.

trey's avatar
WebKit:  
trey committed
2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272
2002-10-28  Trey Matteson  <trey@apple.com>

	Finished 2998200 - access to most-recent in submenu of back & forward buttons

        * WebView.subproj/WebDataSourcePrivate.h:
	The BF items we are going to and from were moved here from
	WebFrame because of timing problems among multiple data sources
	when using the BF buttons during a load.
	In addition, the datasource has a list of relevant BF items for
	which it keeps their titles up to date.
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSourcePrivate dealloc]):
	Free new state.
        (-[WebDataSource _setTitle:]):
	Update titles of BF items.
        (-[WebDataSource _provisionalBackForwardItem]):
        (-[WebDataSource _setProvisionalBackForwardItem:]):
        (-[WebDataSource _previousBackForwardItem]):
        (-[WebDataSource _setPreviousBackForwardItem:]):
        (-[WebDataSource _addBackForwardItem:]):
	Maintain new state.
        (-[WebDataSource _commitIfReady]):
	Free up previous and provisional BF items after commit.
        * WebCoreSupport.subproj/WebBridge.m: