ChangeLog 3.05 MB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19
2011-09-23  Varun Jain  <varunjain@google.com>

        Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests 
        https://bugs.webkit.org/show_bug.cgi?id=68198

        Reviewed by Dimitri Glazkov.

        Tests: fast/dom/scroll-element-to-rect-centered.html
               fast/dom/scroll-element-to-rect.html

        * WebCore.exp.in:
        * page/FrameView.cpp:
        (WebCore::FrameView::scrollElementToRect):
        * page/FrameView.h:
        * testing/Internals.cpp:
        (WebCore::Internals::scrollElementToRect):
        * testing/Internals.h:
        * testing/Internals.idl:

20 21 22 23 24 25 26 27 28 29 30 31 32 33 34
2011-09-23  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed, rolling out r95860.
        http://trac.webkit.org/changeset/95860
        https://bugs.webkit.org/show_bug.cgi?id=68648

        Breaks overhang rendering on Chromium Mac

        * platform/chromium/ScrollbarThemeChromium.cpp:
        * platform/chromium/ScrollbarThemeChromium.h:
        * platform/chromium/ScrollbarThemeChromiumMac.h:
        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
        (WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57
2011-09-23  Dean Jackson  <dino@apple.com>

        Add -webkit-filter to CSSPropertyNames
        https://bugs.webkit.org/show_bug.cgi?id=68675

        Reviewed by Simon Fraser.

        Add property and rudimentary parsing for -webkit-filter. The
        property value isn't preserved anywhere yet. Add
        stub definition for computed style.

        Test: css3/filters/filter-property.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFilter):
        * css/CSSParser.h:
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):

58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79
2011-09-23  Antoine Labour  <piman@chromium.org>

        Remove preserves3D() from CCLayerDelegate, replacing it by setting the
        value explicitly after creating a layer, or setting its delegate.
        https://bugs.webkit.org/show_bug.cgi?id=68295

        Reviewed by James Robinson.

        Covered by compositing/ layeout tests.

        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::setContentsToCanvas):
        (WebCore::GraphicsLayerChromium::setContentsToMedia):
        (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
        (WebCore::GraphicsLayerChromium::setupContentsLayer):
        * platform/graphics/chromium/GraphicsLayerChromium.h:
        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::LayerChromium):
        * platform/graphics/chromium/LayerChromium.h:
        (WebCore::LayerChromium::setPreserves3D):
        (WebCore::LayerChromium::preserves3D):

80 81 82 83 84 85 86 87 88 89 90
2011-09-23  Julien Chaffraix  <jchaffraix@webkit.org>

        Implicit conversion double to float in ShadowBlur::adjustBlurRadius
        https://bugs.webkit.org/show_bug.cgi?id=68722

        Reviewed by Simon Fraser.

        * platform/graphics/ShadowBlur.cpp:
        (WebCore::ShadowBlur::adjustBlurRadius): Added 2 explicit
        conversions.

91 92 93 94 95 96 97 98 99 100 101 102 103 104
2011-09-23  Dan Bernstein  <mitz@apple.com>

        <rdar://problem/10178576> REGRESSION (r95391): Crash in -[WebCascadeList objectAtIndex:] when a font-family list contains missing fonts
        https://bugs.webkit.org/show_bug.cgi?id=68737

        Reviewed by Darin Adler.

        Test: fast/text/combining-character-sequence-fallback-crash.html

        * platform/graphics/mac/ComplexTextControllerCoreText.mm:
        (-[WebCascadeList initWithFont:WebCore::character:]): Changed to intialize _count to the exact
        number of FontData instances in the fallback list rather than the number of font families in the
        font description.

105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130
2011-09-23  David Reveman  <reveman@chromium.org>

        [Chromium] Fix CSS 3D corner anti-aliasing.
        https://bugs.webkit.org/show_bug.cgi?id=68087

        Reviewed by James Robinson.

        Render sharp corners more correctly by adding bounding box
        edges to anti-aliasing shaders.

        Test: platform/chromium/compositing/3d-corners.html

        * platform/graphics/chromium/ShaderChromium.cpp:
        (WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
        (WebCore::FragmentShaderRGBATexClampAlphaAA::getShaderString):
        (WebCore::FragmentShaderRGBATexClampSwizzleAlphaAA::getShaderString):
        (WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):
        * platform/graphics/chromium/cc/CCRenderSurface.cpp:
        (WebCore::CCRenderSurface::drawLayer):
        (WebCore::CCRenderSurface::drawSurface):
        * platform/graphics/chromium/cc/CCRenderSurface.h:
        * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
        (WebCore::CCTiledLayerImpl::draw):
        (WebCore::CCTiledLayerImpl::drawTiles):
        * platform/graphics/chromium/cc/CCTiledLayerImpl.h:

131 132 133 134 135 136 137 138 139 140 141 142 143 144
2011-09-23  Oliver Hunt  <oliver@apple.com>

        Make write barriers actually do something when enabled
        https://bugs.webkit.org/show_bug.cgi?id=68717

        Reviewed by Geoffrey Garen.

        Add a forwarding header, and fix an evaluation ordering
        issue that shows up if you try to use write barriers.

        * ForwardingHeaders/heap/CardSet.h: Added.
        * bindings/js/JSEventListener.h:
        (WebCore::JSEventListener::jsFunction):

145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162
2011-09-23  James Robinson  <jamesr@chromium.org>

        Avoid updating compositing state during paint
        https://bugs.webkit.org/show_bug.cgi?id=68727

        Reviewed by Simon Fraser.

        We shouldn't update our compositing state in the middle of a paint. The call to
        updateCompositingAndLayerListsIfNeeded() was added to RenderLayer::paintLayer in r45715, which was intended to
        fix this exact issue. Based off the ChangeLog entries, I think that this was just a typo.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateCompositingLayers):
        * rendering/RenderLayerCompositor.h:

163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180
2011-09-23  Fady Samuel  <fsamuel@chromium.org>

        Refactor paintOverhangAreas to allow non-Mac Chromium platforms to reuse code
        https://bugs.webkit.org/show_bug.cgi?id=68648

        Reviewed by Dimitri Glazkov.

        No new tests because there's no change in functionality (yet).

        * platform/chromium/ScrollbarThemeChromium.cpp:
        (WebCore::ScrollbarThemeChromium::ScrollbarThemeChromium):
        (WebCore::ScrollbarThemeChromium::~ScrollbarThemeChromium):
        (WebCore::ScrollbarThemeChromium::paintOverhangAreas):
        * platform/chromium/ScrollbarThemeChromium.h:
        * platform/chromium/ScrollbarThemeChromiumMac.h:
        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):

181 182 183 184 185 186 187 188 189 190 191 192 193 194 195
2011-09-23  Ojan Vafai  <ojan@chromium.org>

        remove physical flex-flow values to match the updated spec
        https://bugs.webkit.org/show_bug.cgi?id=68728

        Reviewed by Tony Chang.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator EFlexFlow):
        * css/CSSValueKeywords.in:
        * rendering/style/RenderStyleConstants.h:

196 197 198 199 200 201 202 203 204 205 206 207 208 209
2011-09-23  Abhishek Arya  <inferno@chromium.org>

        Style not updated for :before, :after content
        in ruby text.
        https://bugs.webkit.org/show_bug.cgi?id=68625

        Reviewed by Dave Hyatt.

        Test: fast/ruby/ruby-text-before-after-content.html

        * rendering/RenderRubyText.cpp:
        (WebCore::RenderRubyText::updateBeforeAfterContent):
        * rendering/RenderRubyText.h:

210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259
2011-09-22  Ojan Vafai  <ojan@chromium.org>

        refactor RenderFlexibleBox to use flex-flow aware methods
        https://bugs.webkit.org/show_bug.cgi?id=68665

        Reviewed by Tony Chang.

        This is just a refactor. Just move the all the code that needs to
        be flow aware into helper functions. Actually making them flow-aware
        can be done in a followup patch.

        * rendering/RenderBlock.cpp:
        * rendering/RenderBlock.h:
        Moved setLogicalLocationForChild into RenderFlexibleBox since that was the only caller.
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::hasOrthogonalFlow):
        (WebCore::RenderFlexibleBox::isHorizontalFlow):
        (WebCore::RenderFlexibleBox::isLeftToRightFlow):
        (WebCore::RenderFlexibleBox::setFlowAwareLogicalHeight):
        (WebCore::RenderFlexibleBox::flowAwareLogicalHeightForChild):
        (WebCore::RenderFlexibleBox::flowAwareLogicalWidthForChild):
        (WebCore::RenderFlexibleBox::flowAwareLogicalHeight):
        (WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
        (WebCore::RenderFlexibleBox::flowAwareAvailableLogicalWidth):
        (WebCore::RenderFlexibleBox::flowAwareBorderStart):
        (WebCore::RenderFlexibleBox::flowAwareBorderBefore):
        (WebCore::RenderFlexibleBox::flowAwareBorderAfter):
        (WebCore::RenderFlexibleBox::flowAwarePaddingStart):
        (WebCore::RenderFlexibleBox::flowAwarePaddingBefore):
        (WebCore::RenderFlexibleBox::flowAwarePaddingAfter):
        (WebCore::RenderFlexibleBox::flowAwareMarginStartForChild):
        (WebCore::RenderFlexibleBox::flowAwareMarginBeforeForChild):
        (WebCore::RenderFlexibleBox::flowAwareMarginAfterForChild):
        (WebCore::RenderFlexibleBox::setFlowAwareMarginStartForChild):
        (WebCore::RenderFlexibleBox::setFlowAwareMarginEndForChild):
        (WebCore::RenderFlexibleBox::setFlowAwareLogicalLocationForChild):
        (WebCore::RenderFlexibleBox::logicalBorderAndPaddingWidthForChild):
        (WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
        (WebCore::RenderFlexibleBox::marginStartStyleForChild):
        (WebCore::RenderFlexibleBox::marginEndStyleForChild):
        (WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
        (WebCore::RenderFlexibleBox::layoutInlineDirection):
        (WebCore::RenderFlexibleBox::logicalPositiveFlexForChild):
        (WebCore::RenderFlexibleBox::logicalNegativeFlexForChild):
        (WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
        (WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
        (WebCore::RenderFlexibleBox::setLogicalOverrideSize):
        (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
        * rendering/RenderFlexibleBox.h:

260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290
2011-09-23  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=68719
        
        Push through multiple regions when an object doesn't fit in any of them. Unlike with pages and
        columns, when regions have a non-uniform height, we may need to push through multiple regions
        in order to find one that fits.
        
        Added an optimization for quickly noticing if regions do have a uniform height so that we can
        treat them like columns and pages if so.

        Also fixed the end line matchup to properly null out endLine when no next line box exists. The new
        layout tests I wrote to cover this feature exposed this crasher, so fixing it in order to land
        the new tests.

        Reviewed by Anders Carlsson.

        Added new tests in fast/regions.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::adjustForUnsplittableChild):
        (WebCore::RenderBlock::pushToNextPageWithMinimumLogicalHeight):
        (WebCore::RenderBlock::adjustLinePositionForPagination):
        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::matchedEndLine):
        * rendering/RenderFlowThread.cpp:
        (WebCore::RenderFlowThread::RenderFlowThread):
        (WebCore::RenderFlowThread::layout):
        * rendering/RenderFlowThread.h:

291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345
2011-09-23  Konstantin Scheglov  <scheglov@google.com>

        Redrawing dirty parts of a large table is very slow
        https://bugs.webkit.org/show_bug.cgi?id=64546

        Reviewed by David Hyatt.

        Move CollapsedBorderValues into RenderTable.h.
        Calculate collapsed borders only once and re-use during paintObject().
        Invalidate cache when cell, row, row group, col, col group or table border is changed.

        Tests: fast/table/border-collapsing/cached-cell-append.html
               fast/table/border-collapsing/cached-cell-remove.html
               fast/table/border-collapsing/cached-change-cell-border-color.html
               fast/table/border-collapsing/cached-change-cell-border-width.html
               fast/table/border-collapsing/cached-change-col-border-color.html
               fast/table/border-collapsing/cached-change-col-border-width.html
               fast/table/border-collapsing/cached-change-colgroup-border-color.html
               fast/table/border-collapsing/cached-change-colgroup-border-width.html
               fast/table/border-collapsing/cached-change-row-border-color.html
               fast/table/border-collapsing/cached-change-row-border-width.html
               fast/table/border-collapsing/cached-change-table-border-color.html
               fast/table/border-collapsing/cached-change-table-border-width.html
               fast/table/border-collapsing/cached-change-tbody-border-color.html
               fast/table/border-collapsing/cached-change-tbody-border-width.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::RenderTable):
        (WebCore::RenderTable::styleDidChange): Invalidate cache on border change.
        (WebCore::RenderTable::layout): Invalidate cache if layout changed.
        (WebCore::RenderTable::recalcCollapsedBorders): Ensures that cache is valid.
        (WebCore::RenderTable::paintObject): Use cached collapsed borders.
        * rendering/RenderTable.h:
        (WebCore::RenderTable::invalidateCollapsedBorders): Accessor to mark cache invalid.
        (WebCore::RenderTable::currentBorderValue): Rename to use word "value".
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::styleDidChange): If border changed, invalidate cache.

        Rename to use word "value".
        (WebCore::addBorderStyle):
        (WebCore::RenderTableCell::collectBorderValues):
        (WebCore::compareBorderValuesForQSort):
        (WebCore::RenderTableCell::sortBorderValues):
        (WebCore::RenderTableCell::paintCollapsedBorder):
        * rendering/RenderTableCell.h:
        
        If border changed, invalidate cache.
        * rendering/RenderTableCol.cpp:
        (WebCore::RenderTableCol::styleDidChange):
        * rendering/RenderTableCol.h:
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::styleDidChange):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::styleDidChange):

346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451
2011-09-23  Mark Hahnenberg  <mhahnenberg@apple.com>

        Add static version of JSCell::visitChildren
        https://bugs.webkit.org/show_bug.cgi?id=68404

        Reviewed by Darin Adler.

        No new tests.

        In this patch we just extract the bodies of the virtual visitChildren methods
        throughout the JSCell inheritance hierarchy out into static methods, which are 
        now called from the virtual methods.  This is an intermediate step in trying to 
        move the virtual-ness of visitChildren into our own custom vtable stored in 
        ClassInfo.  We need to convert the methods to static methods in order to be 
        able to more easily store and refer to them in our custom vtable since normal 
        member methods store some implicit information in their types, making it 
        impossible to store them generically in ClassInfo.

        * WebCore.exp.in:
        * bindings/js/JSAttrCustom.cpp:
        (WebCore::JSAttr::visitChildrenVirtual):
        (WebCore::JSAttr::visitChildren):
        * bindings/js/JSAudioContextCustom.cpp:
        (WebCore::JSAudioContext::visitChildrenVirtual):
        (WebCore::JSAudioContext::visitChildren):
        * bindings/js/JSCSSRuleCustom.cpp:
        (WebCore::JSCSSRule::visitChildrenVirtual):
        (WebCore::JSCSSRule::visitChildren):
        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::JSCSSStyleDeclaration::visitChildrenVirtual):
        (WebCore::JSCSSStyleDeclaration::visitChildren):
        * bindings/js/JSCanvasRenderingContextCustom.cpp:
        (WebCore::JSCanvasRenderingContext::visitChildrenVirtual):
        (WebCore::JSCanvasRenderingContext::visitChildren):
        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::visitChildrenVirtual):
        (WebCore::JSDOMGlobalObject::visitChildren):
        * bindings/js/JSDOMGlobalObject.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::visitChildrenVirtual):
        (WebCore::JSDOMWindow::visitChildren):
        * bindings/js/JSDOMWindowShell.cpp:
        (WebCore::JSDOMWindowShell::visitChildrenVirtual):
        (WebCore::JSDOMWindowShell::visitChildren):
        * bindings/js/JSDOMWindowShell.h:
        * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
        (WebCore::JSJavaScriptAudioNode::visitChildrenVirtual):
        (WebCore::JSJavaScriptAudioNode::visitChildren):
        * bindings/js/JSMessageChannelCustom.cpp:
        (WebCore::JSMessageChannel::visitChildrenVirtual):
        (WebCore::JSMessageChannel::visitChildren):
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::visitChildrenVirtual):
        (WebCore::JSMessagePort::visitChildren):
        * bindings/js/JSNamedNodeMapCustom.cpp:
        (WebCore::JSNamedNodeMap::visitChildrenVirtual):
        (WebCore::JSNamedNodeMap::visitChildren):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::visitChildrenVirtual):
        (WebCore::JSNode::visitChildren):
        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::JSNodeFilter::visitChildrenVirtual):
        (WebCore::JSNodeFilter::visitChildren):
        * bindings/js/JSNodeIteratorCustom.cpp:
        (WebCore::JSNodeIterator::visitChildrenVirtual):
        (WebCore::JSNodeIterator::visitChildren):
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::visitChildrenVirtual):
        (WebCore::JSSVGElementInstance::visitChildren):
        * bindings/js/JSSharedWorkerCustom.cpp:
        (WebCore::JSSharedWorker::visitChildrenVirtual):
        (WebCore::JSSharedWorker::visitChildren):
        * bindings/js/JSStyleSheetCustom.cpp:
        (WebCore::JSStyleSheet::visitChildrenVirtual):
        (WebCore::JSStyleSheet::visitChildren):
        * bindings/js/JSTreeWalkerCustom.cpp:
        (WebCore::JSTreeWalker::visitChildrenVirtual):
        (WebCore::JSTreeWalker::visitChildren):
        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::JSWebGLRenderingContext::visitChildrenVirtual):
        (WebCore::JSWebGLRenderingContext::visitChildren):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::visitChildrenVirtual):
        (WebCore::JSWorkerContext::visitChildren):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::visitChildrenVirtual):
        (WebCore::JSXMLHttpRequest::visitChildren):
        * bindings/js/JSXPathResultCustom.cpp:
        (WebCore::JSXPathResult::visitChildrenVirtual):
        (WebCore::JSXPathResult::visitChildren):
        * bindings/scripts/CodeGeneratorJS.pm:
        (GenerateHeader):
        (GenerateImplementation):
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::JSTestObj::visitChildrenVirtual):
        (WebCore::JSTestObj::visitChildren):
        * bindings/scripts/test/JS/JSTestObj.h:
        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtRuntimeObject::visitChildrenVirtual):
        (JSC::Bindings::QtRuntimeObject::visitChildren):
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtRuntimeMetaMethod::visitChildrenVirtual):
        (JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
        * bridge/qt/qt_runtime.h:
        * workers/WorkerContext.h:

452 453 454 455 456 457 458 459 460
2011-09-23  Mario Sanchez Prada  <msanchez@igalia.com>

        [GTK] Remove extra space at the beginning of the last line.
        https://bugs.webkit.org/show_bug.cgi?id=68710

        Reviewed by Gustavo Noronha Silva.

        * platform/network/soup/SocketStreamHandleSoup.cpp:

461 462 463 464 465 466 467 468 469 470 471 472
2011-09-23  Mario Sanchez Prada  <msanchez@igalia.com>

        [GTK] Fix coding style issues in ResourceRequestSoup.cpp
        https://bugs.webkit.org/show_bug.cgi?id=68707

        Reviewed by Xan Lopez.

        This patch fixes some issues as reported by check-webkit-style.

        * platform/network/soup/ResourceRequestSoup.cpp:
        (WebCore::ResourceRequest::updateFromSoupMessage):

473 474 475 476 477 478 479 480 481 482 483 484
2011-09-22  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>

        Unreviewed: [Qt] Workaround MSVC2010 problems when linking QtWebKit

        Include MSVC2010 in the list of compilers where incremental
        build is disabled (INCREMENTAL:NO).

        Change suggested by Simo Falt <simo.falt@nokia.com>, already present
        in the Qt-4.8 repository where the problem was identified.

        * WebCore.pri:

485 486 487 488 489 490 491 492
2011-09-23  Darin Adler  <darin@apple.com>

        Try to fix warning seen in some 32-bit builds.

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::backgroundRectAdjustedForBleedAvoidance):
        Use an explicit cast for the conversion from a double to a LayoutUnit.

493 494 495 496 497 498 499 500 501 502 503 504
2011-09-23  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Clicking on error doesn't point on the correct line if user searched something
        https://bugs.webkit.org/show_bug.cgi?id=68627

        Reviewed by Yury Semikhatsky.

        * inspector/front-end/SearchController.js:
        (WebInspector.SearchController.prototype.disableSearchUntilExplicitAction):
        * inspector/front-end/inspector.js:
        (WebInspector._showAnchorLocationInPanel):

505 506 507 508 509 510 511 512 513 514 515 516
2011-09-23  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: InspectorStyleSheet should use stylesheet's original url, not final one.
        https://bugs.webkit.org/show_bug.cgi?id=68631

        Reviewed by Yury Semikhatsky.

        Test: http/tests/inspector/styles/styles-redirected-css.html

        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::resourceStyleSheetText):

517 518 519 520 521 522 523 524 525 526 527 528
2011-09-23  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: XHRs requests with the same url as main resource should have correct category.
        https://bugs.webkit.org/show_bug.cgi?id=68646

        Reviewed by Yury Semikhatsky.

        Test: http/tests/inspector/network/network-xhr-same-url-as-main-resource.html

        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::didReceiveResponse):

529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546
2011-09-23  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Add context menu action to navigate from resources panel resource to network panel.
        https://bugs.webkit.org/show_bug.cgi?id=68657

        Reviewed by Yury Semikhatsky.

        * English.lproj/localizedStrings.js:
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype.showAnchorLocation):
        (WebInspector.NetworkPanel.prototype.revealAndHighlightResource):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
        (WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction):
        * inspector/front-end/inspector.js:
        (WebInspector.openInNetworkPanelLabel):
        (WebInspector.openRequestInNetworkPanel):

547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562
2011-09-23  Deepak Sherveghar  <bpwv64@motorola.com>

        [Gtk] Title attribute is not respected on option elements.
        https://bugs.webkit.org/show_bug.cgi?id=68615

        Reviewed by Martin Robinson.

        Set tooltip on PopupMenuGtk items created from GtkActions.

        * platform/gtk/GtkPopupMenu.cpp:
        (WebCore::GtkPopupMenu::appendItem): Added a call to gtk_widget_set_tooltip_text()
            to set the tooltip on menuitem. Tooltip text is retrieved from GtkAction.
        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenuGtk::createGtkActionForMenuItem): Pass the tooltip text
            from client when creating a GtkAction.

563 564 565 566 567 568 569 570 571 572 573 574 575 576 577
2011-09-23  Yael Aharon  <yael.aharon@nokia.com>

        [Qt][Gtk] Wrong state when pausing a video in the "playing" event handler
        https://bugs.webkit.org/show_bug.cgi?id=68589

        Reviewed by Philippe Normand.

        Test: media/video-playing-and-pause.html

        As suggested by Alexis Menard on IRC, query gstreamer's state instead of using a cached value
        in MediaPlayerGstreamerPrivate::paused(). 

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::paused):

578 579 580 581 582 583 584 585 586 587 588 589 590
2011-09-15  Pavel Podivilov  <podivilov@chromium.org>

        Web Inspector: skip overlapping scripts when displaying concatenated content.
        https://bugs.webkit.org/show_bug.cgi?id=68144

        Dynamically appended script tags have wrong offsets and cause troubles building concatenated content.

        Reviewed by Pavel Feldman.

        * inspector/front-end/SourceFile.js:
        (WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
        (WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):

591 592 593 594 595 596 597 598 599 600
2011-09-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel.
        https://bugs.webkit.org/show_bug.cgi?id=68312

        Reviewed by Yury Semikhatsky.

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._createFileSelector):

601 602 603 604 605 606 607 608 609 610 611 612
2011-09-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r95383.
        http://trac.webkit.org/changeset/95383
        https://bugs.webkit.org/show_bug.cgi?id=68690

        It broke WebInspector.Timeline.LoadFromFile feature.
        (Requested by loislo on #webkit).

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._createFileSelector):

613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630
2011-09-23  Rob Buis  <rbuis@rim.com>

        use after free in WebCore::SVGTRefElement::updateReferencedText
        https://bugs.webkit.org/show_bug.cgi?id=67555

        Reviewed by Nikolas Zimmermann.

        Event listeners can outlive the tref element that created them when
        the tref is cloned and then garbage collected, causing a dangling pointer to the
        tref. To fix this do not install event listener until the tref is inserted into the document.

        Test: svg/custom/tref-clone-crash.html

        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::svgAttributeChanged):
        (WebCore::SVGTRefElement::insertedIntoDocument):
        * svg/SVGTRefElement.h:

631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648
2011-09-23  Vsevolod Vlasov  <vsevik@chromium.org>

        ASSERTION FAILED: documentLoader in WebKit/Source/WebCore/inspector/InspectorInstrumentation.cpp(597)
        https://bugs.webkit.org/show_bug.cgi?id=68291

        Reviewed by Tony Chang.

        * dom/Document.cpp:
        (WebCore::Document::finishedParsing):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
        (WebCore::InspectorInstrumentation::loadEventFiredImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::domContentLoadedEventFired):
        (WebCore::InspectorInstrumentation::loadEventFired):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchLoadEvent):

649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687
2011-09-22  Tony Chang  <tony@chromium.org>

        implement -webkit-flex-order
        https://bugs.webkit.org/show_bug.cgi?id=67432

        Reviewed by Ojan Vafai.

        flex-order can be an int (including negative), but we disallow the two
        smallest values so we can put the numbers into a hash set.

        Also, create two iterators: one that goes in render tree order (we use
        this for the first pass and to collect the possible flex order values)
        and one that goes in flex order.

        Test: css3/flexbox/flex-order.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::FlexOrderHashTraits::emptyValue):
        (WebCore::FlexOrderHashTraits::constructDeletedValue):
        (WebCore::FlexOrderHashTraits::isDeletedValue):
        (WebCore::RenderFlexibleBox::TreeOrderIterator::TreeOrderIterator): A simple iterator
            that goes in render tree order.
        (WebCore::RenderFlexibleBox::TreeOrderIterator::next):
        (WebCore::RenderFlexibleBox::TreeOrderIterator::reset):
        (WebCore::RenderFlexibleBox::TreeOrderIterator::flexOrderValues):
        (WebCore::RenderFlexibleBox::FlexOrderIterator::FlexOrderIterator): An iterator that
            goes in flex-order order.  Creating this involves sorting, so only create it once
            and pass it around.
        (WebCore::RenderFlexibleBox::FlexOrderIterator::first):
        (WebCore::RenderFlexibleBox::FlexOrderIterator::next):
        (WebCore::RenderFlexibleBox::FlexOrderIterator::reset):
        (WebCore::RenderFlexibleBox::layoutHorizontalBlock):
        (WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
        (WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
        (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
        * rendering/RenderFlexibleBox.h:

688 689 690 691 692 693 694 695 696 697 698 699
2011-09-22  Darin Adler  <darin@apple.com>

        Use AffineTransform scale functions in ShadowBlur::adjustBlurRadius
        https://bugs.webkit.org/show_bug.cgi?id=68667

        Reviewed by Simon Fraser.

        * platform/graphics/ShadowBlur.cpp:
        (WebCore::ShadowBlur::adjustBlurRadius): Use AffineTransform::xScale and
        AffineTransform::yScale instead of the custom code here that seems to do
        the same thing.

700 701 702 703 704 705 706 707 708 709 710 711
2011-09-22  Darin Adler  <darin@apple.com>

        Remove unneeded type conversion from background bleed code
        https://bugs.webkit.org/show_bug.cgi?id=68669

        Reviewed by Geoffrey Garen.

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::backgroundRectAdjustedForBleedAvoidance): Use ceil instead of ceilf
        and eliminate superflous conversion to float and use of FloatSize. Also added
        a "why" comment.

712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729
2011-09-22  Darin Adler  <darin@apple.com>

        Refactor checks for antialiasing lines to share a single function
        https://bugs.webkit.org/show_bug.cgi?id=68666

        Reviewed by Dan Bernstein.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintColumnRules): Call shouldAntialiasLines.
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBorder): Ditto.
        (WebCore::RenderBoxModelObject::shouldAntialiasLines): Added.
        * rendering/RenderBoxModelObject.h: Added shouldAntialiasLines function.
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::paintOutlineForLine): Call shouldAntialiasLines.
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paintCollapsedBorder): Ditto.

730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745
2011-09-22  Antoine Labour  <piman@chromium.org>

        Remove unused members from LayerChromium.
        These members are never set, and never used.
        Other members that are set but not used have been left (we may use them
        later, e.g. m_opaque).
        https://bugs.webkit.org/show_bug.cgi?id=68297

        Reviewed by James Robinson.

        No functional change, no new test needed.

        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::LayerChromium):
        * platform/graphics/chromium/LayerChromium.h:

746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763
2011-09-22  Tom Sepez  <tsepez@chromium.org>

        Make XSSAuditor extract meaningful snippet from script blocks for comparison
        against the URL when checking for reflection.  Avoids getting caugh up in
        trailing comments.
        https://bugs.webkit.org/show_bug.cgi?id=68094

        Reviewed by Adam Barth.

        Tests: http/tests/security/xssAuditor/script-tag-with-trailing-comment.html
               http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html
               http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html

        * html/parser/XSSAuditor.cpp:
        (WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
        (WebCore::XSSAuditor::extractCodeFragment):
        * html/parser/XSSAuditor.h:

764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805
2011-09-22  Nate Chapin  <japhet@chromium.org>

        Remove didReceiveAuthenticationChallenge() from SubresourceLoaderClient.
        Instead, add a load-specific policy for showing the user authentication
        challenge down to ResourceLoaderOptions and enforce it in ResourceLoader.
        https://bugs.webkit.org/show_bug.cgi?id=65330

        Reviewed by Alexey Proskuryakov.

        No new tests, refactor only.

        * loader/DocumentThreadableLoader.cpp:
        * loader/DocumentThreadableLoader.h:
        * loader/MainResourceLoader.cpp:
        * loader/NetscapePlugInStreamLoader.cpp:
        * loader/ResourceLoadScheduler.h:
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
           For resource types that always send a challenge to the embedder,
           this patch doesn't change anything. For those that don't, we will
           always try to continue without credentials when they are forbidden
           and the platform supports it.
           When continuing without credentials was initially implemented in
           DocumentThreadableLoader, we sent the ThreadableLoaderClient a didFail(),
           then canceled the SubresourceLoader. This was necessary because of the
           quirks of ThreadableLoader cancellation (we sever the client/loader connections
           before the load actually cancels), but a simple didFail() should suffice at
           the ResourceLoader layer.
        * loader/ResourceLoaderOptions.h:
        * loader/SubresourceLoader.cpp:
        * loader/SubresourceLoader.h:
        * loader/SubresourceLoaderClient.h:
        * loader/cache/CachedResource.cpp:
        * loader/cache/CachedResourceLoader.cpp:
        * loader/cache/CachedResourceLoader.h:
        * loader/icon/IconLoader.cpp: The ResourceLoader implementation of
            didReceiveAuthenticationChallege means that IconLoader will now
            try to continue with credentials on platforms that support it,
            rather than just canceling outright. We still will never prompt
            for authentication for icons.
        * loader/icon/IconLoader.h:

dino@apple.com's avatar
dino@apple.com committed
806 807 808 809 810 811 812 813 814
2011-09-22  Dean Jackson  <dino@apple.com>

        Add ENABLE_CSS_FILTERS
        https://bugs.webkit.org/show_bug.cgi?id=68652

        Reviewed by Simon Fraser.

        * Configurations/FeatureDefines.xcconfig:

815 816 817 818 819 820 821 822 823 824 825 826 827 828
2011-09-22  Anders Carlsson  <andersca@apple.com>

        Make sure to update scrollbars in ScrollView::setFrameRect
        https://bugs.webkit.org/show_bug.cgi?id=68663

        Reviewed by Sam Weinig.

        Call updateScrollbars after setting the frame rect. This was previously done by the
        call to setBoundsSize from RenderWidget::setWidgetGeometry but setBoundsSize was removed
        completely in http://trac.webkit.org/changeset/95725.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::setFrameRect):

829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848
2011-09-22  Jon Lee  <jonlee@apple.com>

        Progress control gets cropped on the bottom
        https://bugs.webkit.org/show_bug.cgi?id=68302
        <rdar://problem/10069915>

        Reviewed by Kent Tamura.

        As it turns out the smaller control type does not get rendered either, so this patch
        fixes both.

        * manual-tests/dom/progressbar.html: Altered to show both sizes of controls
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm: Added methods to inflate the drawing rect
        (WebCore::RenderThemeMac::progressBarSizes):
        (WebCore::RenderThemeMac::progressBarMargins):
        (WebCore::RenderThemeMac::minimumProgressBarHeight):
        (WebCore::RenderThemeMac::paintProgressBar): Inflate the rect based on minimum desired
        control height and glow margin.

849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874
2011-09-22  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=68658

        Make matchedEndLine smart enough to not match lines that have moved to new
        regions with different available content logical widths. When this happens, we go ahead and treat
        the line as failing to match.

        Reviewed by Anders Carlsson.

        Added new tests in fast/regions.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
        * rendering/RenderBlock.h:
        Enhanced to take an optional delta, so that you can check a new position without having to move
        the line box.

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
        New function that refactors checking for line width changes from region movement as well as the
        float checks. Since the float checks were duplicated twice, this is a nice refactoring.

        (WebCore::RenderBlock::matchedEndLine):
        Changed to call the new helper function that will check both floats and pagination.

875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896
2011-09-22  Gavin Barraclough  <barraclough@apple.com>

        Implement Function.prototype.bind
        https://bugs.webkit.org/show_bug.cgi?id=26382

        Reviewed by Sam Weinig.

        Test: fast/js/function-bind.html

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::objectToStringFunctionGetter):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::nonCachingStaticFunctionGetter):
        * bindings/js/JSHistoryCustom.cpp:
        (WebCore::nonCachingStaticBackFunctionGetter):
        (WebCore::nonCachingStaticForwardFunctionGetter):
        (WebCore::nonCachingStaticGoFunctionGetter):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::nonCachingStaticReplaceFunctionGetter):
        (WebCore::nonCachingStaticReloadFunctionGetter):
        (WebCore::nonCachingStaticAssignFunctionGetter):
            - Function::create no longer requires functionStructure() to be passed.
897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968
2011-09-22  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=68650
        
        Make determineStartPosition smart enough to not skip over clean lines that have moved to a new
        region with a different available content logical width. When this happens, we go ahead and treat
        the line as dirty.

        Reviewed by Sam Weinig.

        Covered by existing fast/regions tests.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):
        Disable region fitting if we detect that the regions all have uniform widths. In this case we know
        the content width can't vary, so there's no reason to waste time worrying about it.

        (WebCore::RenderBlock::computeLogicalLocationForFloat):
        Pull the content width checking code into computeLogicalLocationForFloat, since we've incorporated
        region fitting into the fixed offsets now rather than the line functions.

        (WebCore::RenderBlock::positionNewFloats):
        Changed because more code moved from here into computeLogicalLocationForFloat.
        
        (WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
        No changes. Just moved the function above the left offset function.

        (WebCore::RenderBlock::logicalLeftOffsetForContent):
        (WebCore::RenderBlock::logicalRightOffsetForContent):
        Added. These new functions give the fixed left and right offsets for lines in a particular region.
        When no regions are present or when all the regions have a uniform width, they are identical
        to the versions of the functions that take no arguments.

        (WebCore::RenderBlock::logicalRightOffsetForLine):
        Changed to no longer do region fitting, since that's built into logicalRightOffsetForContent now.

        (WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
        New function that takes a root line box and compares its cached old content width with the width
        available at the line's new location.
    
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::logicalRightOffsetForLine):
        (WebCore::RenderBlock::logicalLeftOffsetForLine):
        Modified to call the logicalXXXOffsetForContent functions that take a block direction position.

        (WebCore::RenderBlock::logicalRightOffsetForContent):
        (WebCore::RenderBlock::logicalLeftOffsetForContent):
        Added the new functions that take a position so that they can fit to the correct region.

        (WebCore::RenderBlock::availableLogicalWidthForContent):
        New helper function that calls right - left (similar to the corresponding line function that includes
        floats).

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::determineStartPosition):
        Patched to check if a line has moved to a place with a different available content width. If so, the line
        is dirtied so that line layout can re-run.

        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::RootInlineBox):
        (WebCore::RootInlineBox::alignBoxesInBlockDirection):
        Sets the paginated line width from the current block logical height.

        * rendering/RootInlineBox.h:
        (WebCore::RootInlineBox::paginationStrut):
        (WebCore::RootInlineBox::setPaginationStrut):
        Fixed paginationStrut to be LayoutUnit instead of int.

        (WebCore::RootInlineBox::paginatedLineWidth):
        (WebCore::RootInlineBox::setPaginatedLineWidth):
        Added paginatedLineWidth getter/setter for caching the content width for a given root line.

969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992
2011-09-21  Anders Carlsson  <andersca@apple.com>

        Remove Widget::beforeMouseDown and Widget::afterMouseDown
        https://bugs.webkit.org/show_bug.cgi?id=68570

        Reviewed by Darin Adler.

        These two member functions were originally added to avoid crashes due to removing NSViews while they were
        being tracked by AppKit. Since they were added, we've moved away from NSViews for form controls, and the bugs in
        AppKit that lead to crashes have been fixed.

        This patch was rolled out in r95743 because it broke a bunch of tests. The patch accidentally removed setting back
        m_sendingEventToSubview to false.

        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::passMouseDownEventToWidget):
        * platform/Widget.h:
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::Widget):
        (WebCore::Widget::removeFromSuperview):

        * rendering/RenderWidget.cpp:
        Change widgetHierarchyUpdateSuspendCount to be an unsigned integer instead of a size_t.

993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013
2011-09-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r95335 and r95645.
        http://trac.webkit.org/changeset/95335
        http://trac.webkit.org/changeset/95645
        https://bugs.webkit.org/show_bug.cgi?id=68649

        Wrong fix (Requested by rniwa on #webkit).

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::saveTypingStyleState):
        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::removeStyleAddedByNode):
        * editing/EditingStyle.h:
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
        * editing/markup.cpp:
        (WebCore::StyledMarkupAccumulator::serializeNodes):
        (WebCore::ancestorToRetainStructureAndAppearance):
        * editing/markup.h:

1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027
2011-09-22  Ryosuke Niwa  <rniwa@webkit.org>

        Revert r95673 since it caused hundreds of tests to fail on Leopard / Snow Leopard.

        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::passMouseDownEventToWidget):
        * platform/Widget.h:
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::Widget):
        (WebCore::Widget::removeFromSuperview):
        (WebCore::Widget::beforeMouseDown):
        (WebCore::Widget::afterMouseDown):
        * rendering/RenderWidget.cpp:

1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042
2011-09-22  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=68638
        
        Make RenderFlowThread cache whether or not it has regions of varying widths. This will
        be relevant for performance as we begin adding code to do custom block painting and
        layout based off regions not having the same width.

        Reviewed by Dan Bernstein and Adam Roben.

        * rendering/RenderFlowThread.cpp:
        (WebCore::RenderFlowThread::RenderFlowThread):
        (WebCore::RenderFlowThread::layout):
        * rendering/RenderFlowThread.h:

1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058
2011-09-22  Anders Carlsson  <andersca@apple.com>

        FrameView::invalidateRect and FrameView::setFrameRect shouldn't take LayoutRects
        https://bugs.webkit.org/show_bug.cgi?id=68639

        Reviewed by David Hyatt.

        FrameView::invalidateRect and FrameView::setFrameRect override Widget and ScrollView
        member functions that take IntRects, and Widget coordinates are currently defined in terms of
        IntRects (and probably always should since we want them to be pixel-aligned).

        * page/FrameView.cpp:
        (WebCore::FrameView::invalidateRect):
        (WebCore::FrameView::setFrameRect):
        * page/FrameView.h:

1059 1060 1061 1062 1063 1064 1065
2011-09-22  Tim Horton  <timothy_horton@apple.com>

        Unreviewed build fix (fixes warning about too many parens).

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::computePositionedLogicalWidthReplaced):

1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076
2011-09-22  Anders Carlsson  <andersca@apple.com>

        Widget::frameRect shouldn't be virtual
        https://bugs.webkit.org/show_bug.cgi?id=68637

        Reviewed by Sam Weinig.

        Nobody overrides Widget::frameRect and nobody should.

        * platform/Widget.h:

1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093
2011-09-22  Sergey Glazunov  <serg.glazunov@gmail.com>

        Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback
        https://bugs.webkit.org/show_bug.cgi?id=68630

        Reviewed by Adam Barth.

        Test: fast/canvas/webgl/shader-deleted-by-accessor.html

        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::JSWebGLRenderingContext::getAttachedShaders):
        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getAttachedShaders):
        * html/canvas/WebGLRenderingContext.h:

1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131
2011-09-05  Robert Hogan  <robert@webkit.org>

        CSS 2.1 failure: abspos-non-replaced-width-margin-000, abspos-replaced-width-margin-000
        https://bugs.webkit.org/show_bug.cgi?id=47148

        Reviewed by David Hyatt.

        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::startOffsetForLine): Return offset from right, rather than offset from left + logicalwidth
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::startAlignedOffsetForLine): 
              Return the correct alignment for RTL blocks too. Looks like neither FF or Opera do this correctly.
              Covered by new test left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html
        * rendering/RenderBox.cpp:
        (WebCore::computeInlineStaticDistance):
            - The CSS 2.1 tests now require UAs to use the parent block's direction (rather than the
              containing block's direction) when computing static distance. The container block's direction
              is still used in the other width and offset related calculations.
            - In the context of this function, the logicalRight value is just an element that will be used later to calculate 
              the correct logicalLeft position for the RTL block. So whereas an LTR block can substract containerBlock->borderLogicalLeft() 
              in this function directly, an RTL block has to add it here so that will be later subtracted from availableSpace to get 
              logicalLeft in computePositionedLogicalWidthUsing().

        (WebCore::RenderBox::computePositionedLogicalWidth):
           - Update comments and use the container block's direction except when calculating the static distance.
           - Remove the notion of a quirks mode in this function and for calculating the position of replaced and non-replaced
             blocks generally. This is in line with both FF4 and Opera - neither of which have a quirks mode for them.
        (WebCore::RenderBox::computePositionedLogicalWidthUsing):
           - Update comments and use the container block's direction except when calculating the static distance.
        (WebCore::RenderBox::computePositionedLogicalHeight):
           - Update comments.
        (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
           - Update comments and use the container block's direction except when calculating the static distance.
           - If the containing block is RTL, always assume that values are over-constrained.
        (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
           - Update comments.

1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168
2011-09-22  Anders Carlsson  <andersca@apple.com>

        Get rid of Widget::setBoundsSize
        https://bugs.webkit.org/show_bug.cgi?id=68491

        Reviewed by Sam Weinig.

        This basically reverts http://trac.webkit.org/changeset/79167 and http://trac.webkit.org/changeset/75897
        which were added to make zoom gestures work with WebKit1, but since we don't support zoom gestures in WebKit1
        anymore, it's better for code cleanliness to get rid of Widget::setBoundsSize and the associated code. While this
        will unfortunately break transformed iframes in WebKit1, but Simon says that it's an acceptable tradeoff.

        * WebCore.exp.in:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::open):
        * page/FrameView.cpp:
        (WebCore::FrameView::create):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::visibleContentRect):
        (WebCore::ScrollView::updateScrollbars):
        (WebCore::ScrollView::wheelEvent):
        * platform/ScrollView.h:
        * platform/Widget.cpp:
        * platform/Widget.h:
        (WebCore::Widget::resize):
        * platform/chromium/PopupContainer.cpp:
        (WebCore::PopupContainer::refresh):
        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::visibleContentRect):
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::paint):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::setWidgetGeometry):
        (WebCore::RenderWidget::setWidget):
        (WebCore::RenderWidget::updateWidgetPosition):
        * rendering/RenderWidget.h:

1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185
2011-09-21  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=68590
        
        Floats pushed to next page, column or region don't reposition properly if the amount of
        available logical width at the new position changes. Refactor the code so that we can
        run the float placement algorithm again when this happens.

        Covered by an existing regions test that exposes the issue.

        Reviewed by Adam Roben.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::computeLogicalLocationForFloat):
        (WebCore::RenderBlock::positionNewFloats):
        * rendering/RenderBlock.h:

1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202
2011-09-22  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Fire TextInput events on speech input, but not set/add any inputMethod attribute.
        https://bugs.webkit.org/show_bug.cgi?id=60451

        Reviewed by Ryosuke Niwa.

        Introduce code to dispatch TextInput events when text is introduced via
        the speech input feature. Handle also the cases where speech input is
        started programmatically from the LayoutTestController.

        Test: fast/speech/input-ontextinput-event.html

        * dom/TextEventInputType.h:
        * html/shadow/TextControlInnerElements.cpp:
        (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217
2011-09-20  Jason Liu  <jason.liu@torchmobile.com.cn>

        Reviewed by Simon Fraser.

        CSS outline property on a narrow element has rabbit ear artifacts
        https://bugs.webkit.org/show_bug.cgi?id=36793

        Patch by Jason Liu  <jason.liu@torchmobile.com.cn>
        Patch updated by Robert Hogan <robert@webkit.org>

        Test: fast/css/outline-narrowLine.html

        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::paintOutlineForLine):

1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231
2011-09-22  Wajahat Siddiqui  <mdwajahatali.siddiqui@motorola.com>

        [GTK]Popup drop-down menu contains extra empty spaces at beginning and 
        occupies whole screen when items in popup reaches the height of display device.
        https://bugs.webkit.org/show_bug.cgi?id=68533

        When implementing the GTK+ menu position function, set pushIn to false, which tell
        GTK+ not create a menu that is as big as the entire screen.

        Reviewed by Martin Robinson.

        * platform/gtk/GtkPopupMenu.cpp:
        (WebCore::GtkPopupMenu::menuPositionFunction): Set pushIn to false in the menu position function.

1232 1233 1234 1235 1236 1237 1238 1239 1240
2011-09-22  Alpha Lam  <hclam@chromium.org>

        Define export symbol correctly due to rename of pageScaleFactor to
        frameScaleFactor.

        Not reviewed. Build fix.

        * WebCore.exp.in:

1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264
2011-09-22  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Console is always scrolled to the top
        https://bugs.webkit.org/show_bug.cgi?id=67483

        Reviewed by Pavel Feldman.

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.wasShown):
        (WebInspector.ConsoleView.prototype.storeScrollPositions):
        (WebInspector.ConsoleView.prototype.restoreScrollPositions):
        (WebInspector.ConsoleView.prototype.onResize):
        (WebInspector.ConsoleView.prototype._immediatelyScrollIntoView):
        (WebInspector.ConsoleView.prototype._cancelScheduledScrollIntoView):
        (WebInspector.ConsoleView.prototype._consoleCleared):
        * inspector/front-end/Drawer.js:
        (WebInspector.Drawer.prototype.hide):
        (WebInspector.Drawer.prototype.resize):
        (WebInspector.Drawer.prototype._startStatusBarDragging):
        (WebInspector.Drawer.prototype._statusBarDragging):
        * inspector/front-end/inspector.js:
        (WebInspector.animateStyle):
        (WebInspector.animateStyle.forceComplete):

1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304
2011-09-22  Alpha Lam  <hclam@chromium.org>

        https://bugs.webkit.org/show_bug.cgi?id=68081
        Fix scroll in page scaling mode.

        Reviewed by Simon Fraser.

        The following things are done in this patch:
        1. Rename Frame::pageScaleFactor() to Frame::frameScaleFactor() to better
           reflect its purpose.
        2. Frame::frameScaleFactor() returns the scale factor of this frame with
           respect to the container. So for the main frame it'll return the scale
           factor of the page, inner frames will return 1.0
        3. scrollBy(), scrollX() and scrollY() to take into account of the frame
           scale factor, causing incorrect coordinates reported to Javascript.

        Tests: fast/events/scale-and-scroll-body.html
               fast/events/scale-and-scroll-iframe-body.html
               fast/events/scale-and-scroll-iframe-window.html
               fast/events/scale-and-scroll-window.html

        * html/HTMLBodyElement.cpp:
        (WebCore::adjustForZoom):
        (WebCore::HTMLBodyElement::setScrollLeft):
        (WebCore::HTMLBodyElement::setScrollTop):
        * loader/HistoryController.cpp:
        (WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::scrollX):
        (WebCore::DOMWindow::scrollY):
        (WebCore::DOMWindow::scrollTo):
        * page/Frame.cpp:
        (WebCore::Frame::frameScaleFactor): Return page's scale factor if this is
                                            main frame, otherwise 1.0
        * page/Frame.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::applyOverflowToViewport):
        (WebCore::FrameView::scrollXForFixedPosition):
        (WebCore::FrameView::scrollYForFixedPosition):

1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329
2011-09-22  Andreas Kling  <kling@webkit.org>

        CSS: Implement 'font' property in CSSComputedStyle.
        https://bugs.webkit.org/show_bug.cgi?id=66666

        Reviewed by Antti Koivisto.

        Test: fast/css/getComputedStyle/computed-style-font.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::fontFamilyFromStyle): Factored out of getPropertyCSSValue().
        This function will always return a CSSValueList, as opposed to the previous
        implementation which would return a CSSPrimitiveValue if there was only one family.
        getCSSPropertyValue() will return the first element of the list for 1-element lists
        to preserve the current behavior of getPropertyCSSValue('font-family').

        (WebCore::lineHeightFromStyle): Factored out of getPropertyCSSValue().
        (WebCore::fontSizeFromStyle): Ditto.
        (WebCore::fontStyleFromStyle): Ditto.
        (WebCore::fontVariantFromStyle): Ditto.
        (WebCore::fontWeightFromStyle): Ditto.

        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
        implementation of the computed 'font' property (CSSPropertyFont.)

1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342
2011-09-22  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        [Qt] Redirection overflow errors have wrong error domain
        https://bugs.webkit.org/show_bug.cgi?id=68612

        Reviewed by Andreas Kling.

        Redirection overflow currently puts the URL hostname in the errorDomain field.
        Now redirection overflow errors will be classified as "HTTP" errors.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::redirect):

1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393
2011-09-22  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r95699.
        http://trac.webkit.org/changeset/95699
        https://bugs.webkit.org/show_bug.cgi?id=67417

        Makes many chromium compositor tests crash

        * platform/CrossThreadCopier.h:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::~LayerRendererChromium):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::enabled):
        * platform/graphics/chromium/cc/CCLayerImpl.cpp:
        (WebCore::CCLayerImpl::CCLayerImpl):
        (WebCore::CCLayerImpl::~CCLayerImpl):
        * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
        (WebCore::CCLayerTreeHost::CCLayerTreeHost):
        (WebCore::CCLayerTreeHost::commitTo):
        (WebCore::CCLayerTreeHost::setNeedsRedraw):
        * platform/graphics/chromium/cc/CCLayerTreeHost.h:
        (WebCore::CCSettings::CCSettings):
        * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
        (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
        (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
        * platform/graphics/chromium/cc/CCProxy.h:
        * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
        (WebCore::CCSingleThreadProxy::finishAllRendering):
        (WebCore::CCSingleThreadProxy::setNeedsCommit):
        (WebCore::CCSingleThreadProxy::commitIfNeeded):
        * platform/graphics/chromium/cc/CCThreadProxy.cpp:
        (WebCore::CCThreadProxy::CCThreadProxy):
        (WebCore::CCThreadProxy::~CCThreadProxy):
        (WebCore::CCThreadProxy::compositeAndReadback):
        (WebCore::CCThreadProxy::finishAllRendering):
        (WebCore::CCThreadProxy::isStarted):
        (WebCore::CCThreadProxy::initializeLayerRenderer):
        (WebCore::CCThreadProxy::setNeedsCommit):
        (WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
        (WebCore::CCThreadProxy::setNeedsRedraw):
        (WebCore::CCThreadProxy::start):
        (WebCore::CCThreadProxy::stop):
        (WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
        (WebCore::CCThreadProxy::beginFrameAndCommit):
        (WebCore::CCThreadProxy::commitOnCCThread):
        (WebCore::CCThreadProxy::drawLayersOnCCThread):
        (WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
        (WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
        (WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
        * platform/graphics/chromium/cc/CCThreadProxy.h:

1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447
2011-09-22  Nat Duca  <nduca@chromium.org>

        [chromium] Make CCThreadProxy draw
        https://bugs.webkit.org/show_bug.cgi?id=67417

        Update the CCThreadProxy to correctly implement the CCProxy
        interface, do all the right committing and updating steps, and
        draw a picture on the screen.

        Reviewed by James Robinson.

        * platform/graphics/IntRect.h:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::~LayerRendererChromium):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::enabled):
        * platform/graphics/chromium/cc/CCLayerImpl.cpp:
        (WebCore::CCLayerImpl::CCLayerImpl):
        (WebCore::CCLayerImpl::~CCLayerImpl):
        * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
        (WebCore::CCLayerTreeHost::CCLayerTreeHost):
        (WebCore::CCLayerTreeHost::commitTo):
        (WebCore::CCLayerTreeHost::commitComplete):
        (WebCore::CCLayerTreeHost::setNeedsRedraw):
        * platform/graphics/chromium/cc/CCLayerTreeHost.h:
        * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
        (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
        (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
        * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
        (WebCore::CCSingleThreadProxy::finishAllRendering):
        (WebCore::CCSingleThreadProxy::setNeedsCommit):
        (WebCore::CCSingleThreadProxy::commitIfNeeded):
        * platform/graphics/chromium/cc/CCThreadProxy.cpp:
        (WebCore::CCThreadProxy::CCThreadProxy):
        (WebCore::CCThreadProxy::~CCThreadProxy):
        (WebCore::CCThreadProxy::compositeAndReadback):
        (WebCore::CCThreadProxy::drawLayersAndReadbackOnCCThread):
        (WebCore::CCThreadProxy::finishAllRendering):
        (WebCore::CCThreadProxy::isStarted):
        (WebCore::CCThreadProxy::setNeedsCommit):
        (WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
        (WebCore::CCThreadProxy::setNeedsRedraw):
        (WebCore::CCThreadProxy::start):
        (WebCore::CCThreadProxy::stop):
        (WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
        (WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
        (WebCore::CCThreadProxy::beginFrameAndCommit):
        (WebCore::CCThreadProxy::commitOnCCThread):
        (WebCore::CCThreadProxy::scheduleDrawTaskOnCCThread):
        (WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
        (WebCore::CCThreadProxy::drawLayersOnCCThread):
        (WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):
        * platform/graphics/chromium/cc/CCThreadProxy.h:

1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481
2011-09-21  Beth Dakin  <bdakin@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=67415
        Text drawn via -webkit-background-clip:text is blurry at device scale factors >1.0
        -and corresponding-
        <rdar://problem/10060379>

        Reviewed by Darin Adler.

        New helper function RenderBoxModelObject scales the mask image by the 
        deviceScaleFactor to get an image of the appropriate resolution. It also scales 
        the image's GraphicsContext so that the clip is set up on the same scale. Back in 
        paintFillLayerExtended() we still clip the image to the original maskRect to get 
        everything scaled back to the appropriate size.
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::createDeviceScaledImageBuffer):
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):

        Make the deviceScaleFactor convenience function just a namespace-level function in 
        Page rather than a static member or Page.
        * page/Page.cpp:
        (WebCore::deviceScaleFactor):
        * page/Page.h:
        
        Pre-existing callers of Page::deviceScaleFactor(Frame*) must now use 
        WebCore::deviceScaleFactor(Frame*)
        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::createDeletionUI):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageSizeForError):
        (WebCore::RenderImage::paintReplaced):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::drawPlatformResizerImage):

1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497
2011-09-21  Tim Horton  <timothy_horton@apple.com>

        [CG] ImageBufferData::getData has an invariant comparison in the inner part of a loop which doesn't get optimized out
        https://bugs.webkit.org/show_bug.cgi?id=68588
        <rdar://problem/10164955>

        Reviewed by Simon Fraser.

        Factor the unmultiplied check out of the inner loop, resulting in a
        speed bump in ImageBufferData::getData.

        No new tests, performance improvement.

        * platform/graphics/cg/ImageBufferDataCG.cpp:
        (WebCore::ImageBufferData::getData):

1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512
2011-09-21  Sameer Patil  <mkrp87@motorola.com>

        :hover selector fails when hovering over a child select element with size attribute
        https://bugs.webkit.org/show_bug.cgi?id=67594

        Reviewed by Darin Adler.

        Test: fast/css/hover-affects-ancestor.html

        This patch addresses the problem of deactivation of the ancestor element :hover rules
        when hovered its contained elements.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateHoverActiveState):

1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524
2011-09-21  Sergey Glazunov  <serg.glazunov@gmail.com>

        [Chromium] Protect message ports from being deleted in V8MessageEvent::portsAccessorGetter
        https://bugs.webkit.org/show_bug.cgi?id=68584

        Reviewed by Adam Barth.

        Test: fast/dom/message-port-deleted-by-accessor.html

        * bindings/v8/custom/V8MessageEventCustom.cpp:
        (WebCore::V8MessageEvent::portsAccessorGetter):

1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537
2011-09-21  Anders Carlsson  <andersca@apple.com>

        Add back protection against the NSView going away while handling mouseDown
        https://bugs.webkit.org/show_bug.cgi?id=68585

        Reviewed by Darin Adler.

        Add calls to RenderWidget::suspendWidgetHierarchyUpdates() and RenderWidget::resumeWidgetHierarchyUpdates(),
        as a followup fix to https://bugs.webkit.org/show_bug.cgi?id=68570.

        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::passMouseDownEventToWidget):

1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589
2011-09-21  Julien Chaffraix  <jchaffraix@webkit.org>

        Crash in RenderBox::paintMaskImages when GraphicsContext's painting is disabled
        https://bugs.webkit.org/show_bug.cgi?id=68133

        Reviewed by Darin Adler.

        Tests: fast/css/webkit-mask-crash-fieldset-legend.html
               fast/css/webkit-mask-crash-figure.html
               fast/css/webkit-mask-crash-table.html
               fast/css/webkit-mask-crash-td-2.html
               fast/css/webkit-mask-crash-td.html

        GraphicsContext::getCTM crashes if called with a GraphicsContext that has painting
        disabled. RenderBox::paintMaskImages would thus crash if called in this condition.

        This change just modifies the different GraphicsContext::getCTM method to bail early
        if painting is disabled on the GraphicsContext. The rest of the change is exposing
        paintControlTints that exposes this.

        * WebCore.exp.in: Added symbols of the newly export window.internals function.

        * page/FrameView.cpp:
        (WebCore::FrameView::updateControlTints): Split this function in 2 so that
        I can expose the internal paintControlTints.

        (WebCore::FrameView::paintControlTints):
        This is the one exposed to Internals as we want to be testable regardless of
        whether the platform supports control tints.

        * page/FrameView.h: Added paintControlTints.

        * testing/Internals.cpp:
        (WebCore::Internals::paintControlTints):
        * testing/Internals.h:
        * testing/Internals.idl:
        Added a way to force a fake painting so that we can easily reproduce the bugs.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::getCTM):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::getCTM):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::getCTM):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::getCTM):
        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::GraphicsContext::getCTM):
        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::getCTM):
        Fixed all our back-end to exit early if painting is disabled.

1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603
2011-09-19  Jer Noble  <jer.noble@apple.com>

        Add settings to control the availability of the Web Audio API to WebKit and WebKit2.
        https://bugs.webkit.org/show_bug.cgi?id=68382

        Reviewed by Darin Adler.

        Only create a AudioContext object if the Web Audio feature is runtime-enabled in Settings.

        No new tests, as this feature is not yet enabled by default.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::webkitAudioContext):

1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621
2011-09-21  Anders Carlsson  <andersca@apple.com>

        Remove checks for Leopard-only Objective-C APIs
        https://bugs.webkit.org/show_bug.cgi?id=68579

        Reviewed by Sam Weinig.

        We can always assume that OBJC_API_VERSION is at least 2, it's been 2 since Leopard.

        * bridge/objc/objc_class.mm:
        (JSC::Bindings::ObjcClass::methodsNamed):
        (JSC::Bindings::ObjcClass::fieldNamed):
        * bridge/objc/objc_instance.mm:
        (allocateAutoReleasePool):
        * bridge/objc/objc_runtime.mm:
        (JSC::Bindings::ObjcField::ObjcField):
        * page/mac/EventHandlerMac.mm:

1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642
2011-09-21  Anders Carlsson  <andersca@apple.com>

        Remove Widget::beforeMouseDown and Widget::afterMouseDown
        https://bugs.webkit.org/show_bug.cgi?id=68570

        Reviewed by Sam Weinig.

        These two member functions were originally added to avoid crashes due to removing NSViews while they were
        being tracked by AppKit. Since they were added, we've moved away from NSViews for form controls, and the bugs in
        AppKit that lead to crashes have been fixed.

        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::passMouseDownEventToWidget):
        * platform/Widget.h:
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::Widget):
        (WebCore::Widget::removeFromSuperview):

        * rendering/RenderWidget.cpp:
        Change widgetHierarchyUpdateSuspendCount to be an unsigned integer instead of a size_t.

1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662
2011-09-21  Abhishek Arya  <inferno@chromium.org>

        Not use anonymousContainer on beforeChild calculation
        and let later code handle it. Fix style update on block-level
        anonymous objects.
        https://bugs.webkit.org/show_bug.cgi?id=67656

        Reviewed by David Hyatt.

        Test: fast/table/quote-text-around-iframe.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::addChild):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::styleDidChange):
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::addChild):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::propagateStyleToAnonymousChildren):

1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688
2011-09-21  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=68562
        
        Pagination struts don't update properly when collapsing margin estimates are wrong.
        
        Refactor the pagination adjustments that happen during block layout to allow for
        a 3-pass layout system instead of just a 2-pass layout system. The basic idea is
        to come up with an estimate that includes collapsing, clearance and pagination.
        
        If the estimate only with collapsing and clearance was wrong, then we lay out again
        using the correct collapsing margin values and clearance before applying pagination breaks.
        
        After this second layout, the normal code that runs when unpaginated compares estimates
        and lays out a third time to account for adjustments as a result of pagination movement.

        Reviewed by Sam Weinig.

        Added fast/regions/text-regions-split-small-pagination.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::estimateLogicalTopPosition):
        (WebCore::RenderBlock::layoutBlockChild):
        (WebCore::RenderBlock::adjustBlockChildForPagination):
        * rendering/RenderBlock.h:

1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704
2011-09-21  James Robinson  <jamesr@chromium.org>

        [chromium] SharedGraphicsContext3D's context should not be destroyed during atexit
        https://bugs.webkit.org/show_bug.cgi?id=68558

        Reviewed by Stephen White.

        The SharedGraphicsContext3D's internal context is lazily created and then leaked intentionally, but since the
        last ref is in a function-static RefPtr<> it ends up being destroyed at process exit time.  This is bad, since
        by the time we get this far in process shutdown we can't actually cleanly run the destruction logic and we
        crash.  Since we are explicitly leaking this for the lifetime of the process there's no point in keeping it in a
        RefPtr<>

        * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
        (WebCore::SharedGraphicsContext3D::get):

1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716
2011-09-21  Sergey Glazunov  <serg.glazunov@gmail.com>

        [Chromium] Protect the Frame in V8HTMLDocument::openCallback
        https://bugs.webkit.org/show_bug.cgi?id=68555

        Reviewed by Nate Chapin.

        Test: fast/dom/frame-deleted-in-document-open.html

        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
        (WebCore::V8HTMLDocument::openCallback):

adamk@chromium.org's avatar
adamk@chromium.org committed
1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746
2011-09-21  Adam Klein  <adamk@chromium.org>

        Clean up CSS Counter code
        https://bugs.webkit.org/show_bug.cgi?id=68492

        Reviewed by Tony Chang.

        Several cleanups/fixes:
        - Make Counter::listStyle() return the actual list style string,
          rather than empty string.
        - Handle a specified list style of "none" correctly when generating
          cssText and in Counter::listStyle().
        - Use StringBuilder when generating cssText.

        Test: fast/css/counters/getCounterValue.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseCounterContent):
        Simplify processing (moving conversion to CSSStyleSelector),
        pass a CSS_IDENT as the listStyle to Counter::create.
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::cssText):
        Use StringBuilder.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        Convert from a CSS_IDENT to an EListStyleType.
        * css/Counter.h:
        (WebCore::Counter::listStyleIdent):
        Renamed from listStyleNumber to match its new functionality.

1747 1748 1749 1750 1751 1752 1753 1754
2011-09-21  Chris Marrin  <cmarrin@apple.com>

        Check in WebCore.vcproj file unchanged but written like MSDev likes it

        Unreviewed.

        * WebCode.vcproj/WebCore.vcproj:

1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781
2011-09-21  Stephen White  <senorblanco@chromium.org>

        [chromium] Optimize ImageBuffer constructor when accelerated
        https://bugs.webkit.org/show_bug.cgi?id=68501

        If the accelerated rendering mode is passed in to ImageBuffer, instead
        of creating a bitmap PlatformCanvas and subsequently replacing its
        device with an SkGpuDevice, create an SkCanvas and SkGpuDevice first,
        and fall back to raster creation only failure.  This saves on system
        RAM for the backing store (and possibly GDI resources).

        Reviewed by James Robinson.

        Covered by existing tests.

        * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
        (WebCore::SharedGraphicsContext3D::get):
        * platform/graphics/gpu/SharedGraphicsContext3D.h:
        Rename "SharedGraphicsContext3D::create()" to "get()" to more
        accurately reflect its function.
        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::createAcceleratedCanvas):
        Refactor creation of accelerated ImageBuffer.
        (WebCore::ImageBuffer::ImageBuffer):
        Attempt creation of accelerated ImageBuffer first, and only fall back
        to bitmap-backed canvas creation if it fails.

1782 1783 1784 1785 1786 1787 1788 1789 1790 1791
2011-09-21  Dan Bernstein  <mitz@apple.com>

        WebCore part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
        https://bugs.webkit.org/show_bug.cgi?id=68451

        Reviewed by Darin Adler.

        * WebCore.xcodeproj/project.pbxproj: Added a script build phase that invokes
        check-for-inappropriate-objc-class-names, allowing only class names prefixed with "DOM" or "Web".

1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805
2011-09-21  Dan Bernstein  <mitz@apple.com>

        <rdar://problem/9768483> REGRESSION: Crash in RenderBlock::removeFloatingObjectsBelow()
        https://bugs.webkit.org/show_bug.cgi?id=68550

        Reviewed by Darin Adler.

        Test: fast/multicol/null-lastFloat-in-removeFloatingObjectsBelow.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeFloatingObjectsBelow): Break out of the while() loop when the
        floating object set is empty, which can happen if there were no floats on previous lines
        (in which case, lastFloat is 0).

1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820
2011-09-21  ChangSeok Oh  <shivamidow@gmail.com>

        [GTK] Fix build break when enabling webgl on r95593
        https://bugs.webkit.org/show_bug.cgi?id=68502

        Reviewed by Martin Robinson.

        Add PassOwnPtr.h to GC3DPrivate.h and remove useless one from GC3DGtk.cpp & GC3DPrivate.cpp

        No tests required.

        * platform/graphics/gtk/GraphicsContext3DGtk.cpp:
        * platform/graphics/gtk/GraphicsContext3DPrivate.cpp:
        * platform/graphics/gtk/GraphicsContext3DPrivate.h:

1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832
2011-09-21  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: clear resource agent resource cache upon resource agent's disable.
        https://bugs.webkit.org/show_bug.cgi?id=67995

        Reviewed by Pavel Feldman.

        Test: http/tests/inspector/network/network-disabling-check-no-memory-leak.html

        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::disable):

1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857
2011-09-21  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=68543
        
        Make sure that when regions change dimensions we recompute pagination slices.

        Reviewed by Simon Fraser.

        Added new tests in fast/regions.

        * rendering/LayoutState.cpp:
        (WebCore::LayoutState::LayoutState):
        * rendering/LayoutState.h:
        * rendering/RenderFlowThread.cpp:
        (WebCore::RenderFlowThread::layout):
        (WebCore::RenderFlowThread::renderRegionForLine):
        (WebCore::RenderFlowThread::regionLogicalWidthForLine):
        * rendering/RenderRegion.cpp:
        (WebCore::RenderRegion::layout):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::pushLayoutState):
        * rendering/RenderView.h:
        (WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
        (WebCore::LayoutStateMaintainer::push):

1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871
2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>

        Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
        https://bugs.webkit.org/show_bug.cgi?id=68206

        Reviewed by Tony Chang.

        Added two new wtf headers into ForwardingHeaders/wtf to make
        #include <wtf/...h> cross-platform.
        No new tests needed.

        * ForwardingHeaders/wtf/MetaAllocator.h: Added.
        * ForwardingHeaders/wtf/RedBlackTree.h: Added.

1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882
2011-09-21  David Delaune  <david.delaune@googlemail.com>

        [WinCairo] IconDatabase::defaultIcon always fails for non-CAN_THEME_URL_ICON builds.
        https://bugs.webkit.org/show_bug.cgi?id=67469

        Reviewed by Brent Fulgham.

        No new functionality added in this change.

        * loader/icon/IconDatabase.cpp: defining CAN_THEME_URL_ICON for the WIN_CAIRO

1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904
2011-09-20  Ryosuke Niwa  <rniwa@webkit.org>

        Span element gets produced using backspace/delete to merge header with paragraph
        https://bugs.webkit.org/show_bug.cgi?id=68413

        Reviewed by Darin Adler.

        Add p element to the list of elements to retain appearance. Also modified removeStyleFromNode
        (and renamed to removeStyleFromRules) not to remove inline style declarations because
        inline styles need to stay on copy.

        Test: editing/deleting/merge-paragraph-from-p-with-style.html

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::saveTypingStyleState):
        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::removeStyleFromRules): Renamed from removeStyleFromNode.
        * editing/EditingStyle.h:
        * editing/markup.cpp:
        (WebCore::isBlockNodeToRetainAppearance):
        (WebCore::StyledMarkupAccumulator::serializeNodes):

1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920
2011-09-21  Alice Boxhall  <aboxhall@chromium.org>

        Report AXValueChanged when value changes in element with role=textbox.
        https://bugs.webkit.org/show_bug.cgi?id=68201

        Reviewed by Chris Fleizach.

        Test: platform/mac/accessibility/textbox-role-reports-notifications.html

        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::isARIATextControl):
        * accessibility/AccessibilityObject.h:
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::contentChanged):
        (WebCore::AccessibilityRenderObject::childrenChanged):

1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932
2011-09-21  Pavel Feldman  <pfeldman@google.com>

        Web Inspector: introduce Page.enable and Page.disable
        https://bugs.webkit.org/show_bug.cgi?id=68530

        Otherwise protocol is violating the contract of not sending
        notifications by default.

        Reviewed by Yury Semikhatsky.

        * inspector/Inspector.json:

1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945
2011-09-21  Pavel Feldman  <pfeldman@google.com>

        Web Inspector: add minimal error handling to the DOM breakpoints.
        https://bugs.webkit.org/show_bug.cgi?id=68537

        Reviewed by Yury Semikhatsky.

        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDOMDebuggerAgent.cpp:
        (WebCore::domTypeForName):
        (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
        (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):

1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960
2011-09-21  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: make WebInspector a bit more timeline friendly.
        https://bugs.webkit.org/show_bug.cgi?id=68534

        I found that the maximum captured stack frame depth tracked by timeline is not
        very convenient because the average depth of call stack considerably more than five.
        Another useful trick is console.timeStamp for all backend calls.

        Reviewed by Yury Semikhatsky.

        * inspector/CodeGeneratorInspector.pm:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):

1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978
2011-09-21  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        [Qt][WK2] Implement Download support in WebProcess
        https://bugs.webkit.org/show_bug.cgi?id=68153

        Reviewed by Andreas Kling.

        Refactored QNetworkReplyHandler::finish() in order to add
        and use the static function QNetworkReplyHandler::errorForReply().
        This will be used by our Download implementation in WebKit2 (WebProcess)
        when handling ResourceError.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::finish):
        (WebCore::QNetworkReplyHandler::errorForReply):
        * platform/network/qt/QNetworkReplyHandler.h:
        * platform/network/qt/ResourceRequest.h:

1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004
2011-09-21  Pavel Feldman  <pfeldman@google.com>

        Web Inspector: paint box model colors in Metrics sidebar at all times, do not draw box outlines.
        https://bugs.webkit.org/show_bug.cgi?id=68240

        Today we paint backgrounds in Metrics box model on hover only - should be painted at all
        times for the reference. Outlining boxes is highlight is wrong since outlines are outside
        the corresponding box regions. We've seen few reports on that + Firebug does not do borders
        for that reason.

        Reviewed by Yury Semikhatsky.

        * inspector/DOMNodeHighlighter.cpp:
        * inspector/DOMNodeHighlighter.h:
        * inspector/Inspector.json:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::setHighlightDataFromConfig):
        * inspector/front-end/Color.js:
        * inspector/front-end/MetricsSidebarPane.js:
        (WebInspector.MetricsSidebarPane.prototype._highlightDOMNode):
        (WebInspector.MetricsSidebarPane.prototype._updateMetrics):
        * inspector/front-end/inspector.css:
        (.metrics .label):
        * inspector/front-end/inspector.js:
        (WebInspector.buildHighlightConfig):

2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027
2011-09-21  Andreas Kling  <kling@webkit.org>

        Protect against misuse of EventListenerIterator.
        https://bugs.webkit.org/show_bug.cgi?id=68364

        Reviewed by Darin Adler.

        In debug mode, keep track of the number of active EventListenerIterators
        on an EventListenerMap, and assert that there are no iterators when the
        map is being modified.

        * dom/EventListenerMap.cpp:
        (WebCore::EventListenerMap::EventListenerMap):
        (WebCore::EventListenerMap::clear):
        (WebCore::EventListenerMap::add):
        (WebCore::EventListenerMap::remove):
        (WebCore::EventListenerMap::find):
        (WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
        (WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
        (WebCore::EventListenerIterator::EventListenerIterator):
        (WebCore::EventListenerIterator::~EventListenerIterator):
        * dom/EventListenerMap.h:

2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041
2011-09-21  Pavel Feldman  <pfeldman@google.com>

        Web Inspector: minor fixes in the DOM domain of the protocol.
        https://bugs.webkit.org/show_bug.cgi?id=68517

        Reviewed by Yury Semikhatsky.

        * inspector/Inspector.json:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::setAttributesAsText):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode.prototype.setAttribute):

2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062
2011-09-16  Pavel Feldman  <pfeldman@google.com>

        Web Inspector: limit the use of "Resource" term in the protocol.
        https://bugs.webkit.org/show_bug.cgi?id=68250

        Reviewed by Yury Semikhatsky.

        * inspector/Inspector.json:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::markResourceAsCached):
        (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
        (WebCore::InspectorResourceAgent::setExtraHTTPHeaders):
        (WebCore::InspectorResourceAgent::getResponseBody):
        * inspector/InspectorResourceAgent.h:
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkManager.prototype.requestContent):
        (WebInspector.NetworkDispatcher.prototype.requestServedFromCache):
        (WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):

2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089
2011-09-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r95608.
        http://trac.webkit.org/changeset/95608
        https://bugs.webkit.org/show_bug.cgi?id=68521

        breaks GTK and Windows builds. Please check EWS next time.
        (Requested by philn-tp on #webkit).

        * html/HTMLBodyElement.cpp:
        (WebCore::adjustForZoom):
        (WebCore::HTMLBodyElement::setScrollLeft):
        (WebCore::HTMLBodyElement::setScrollTop):
        * loader/HistoryController.cpp:
        (WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::scrollX):
        (WebCore::DOMWindow::scrollY):
        (WebCore::DOMWindow::scrollTo):
        * page/Frame.cpp:
        (WebCore::Frame::pageScaleFactor):
        * page/Frame.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::applyOverflowToViewport):
        (WebCore::FrameView::scrollXForFixedPosition):
        (WebCore::FrameView::scrollYForFixedPosition):

2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101
2011-09-21  Pavel Feldman  <pfeldman@google.com>

        Web Inspector: console panel's scroller is not properly aligned.
        https://bugs.webkit.org/show_bug.cgi?id=68448

        Reviewed by Yury Semikhatsky.

        * inspector/front-end/inspector.css:
        (#console-view):
        (#console-messages):
        (#drawer #console-messages):

2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141
2011-09-20  Alpha Lam  <hclam@chromium.org>

        https://bugs.webkit.org/show_bug.cgi?id=68081
        Fix scroll in page scaling mode.

        Reviewed by Simon Fraser.

        The following things are done in this patch:
        1. Rename Frame::pageScaleFactor() to Frame::frameScaleFactor() to better
           reflect its purpose.
        2. Frame::frameScaleFactor() returns the scale factor of this frame with
           respect to the container. So for the main frame it'll return the scale
           factor of the page, inner frames will return 1.0
        3. scrollBy(), scrollX() and scrollY() to take into account of the frame
           scale factor, causing incorrect coordinates reported to Javascript.

        Tests: fast/events/scale-and-scroll-body.html
               fast/events/scale-and-scroll-iframe-body.html
               fast/events/scale-and-scroll-iframe-window.html
               fast/events/scale-and-scroll-window.html

        * html/HTMLBodyElement.cpp:
        (WebCore::adjustForZoom):
        (WebCore::HTMLBodyElement::setScrollLeft):
        (WebCore::HTMLBodyElement::setScrollTop):
        * loader/HistoryController.cpp:
        (WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::scrollX):
        (WebCore::DOMWindow::scrollY):
        (WebCore::DOMWindow::scrollTo):
        * page/Frame.cpp:
        (WebCore::Frame::frameScaleFactor): Return page's scale factor if this is
                                            main frame, otherwise 1.0
        * page/Frame.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::applyOverflowToViewport):
        (WebCore::FrameView::scrollXForFixedPosition):
        (WebCore::FrameView::scrollYForFixedPosition):

2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154
2011-09-21  Andras Becsi  <andras.becsi@nokia.com>

        [Qt] Remove Qt specific code from css/SelectorChecker.cpp
        https://bugs.webkit.org/show_bug.cgi?id=67702

        Reviewed by Csaba Osztrogonác.

        No new tests needed.

        * css/SelectorChecker.cpp: Move Qt-specific code to the Qt-specific WebPlatformStrategies.
        (WebCore::SelectorChecker::determineLinkStateSlowCase):
        * platform/VisitedLinkStrategy.h:

2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188
2011-09-16  MORITA Hajime  <morrita@google.com>

        Style changes on forwarded shadow children should trigger shadow renderer reconstruction.
        https://bugs.webkit.org/show_bug.cgi?id=68228

        Reviewed by Dimitri Glazkov.

        Currently style changes on forwarded shadow child triggers
        Node::reattach() only for the forwarded node. But it should
        invalidate whole renderers on the shadow tree because
        ShadowContentElement expects its inclusions to be attached and to
        create renderers in the inclusion order. But single node
        reattach() violates the expectation and possibly creates
        inconsistent render tree.

        This change makes NodeRenderingContext to go
        AttachContentForwarded, where the ShadowContentElement::attach()
        happens, only during ShadowRoot::attach(), not for style-change
        triggered Node::attach() on the forwarded nodes.

        Note that the altering phase AttachContentLight doesn't create
        renderers for the forwarded nodes. Instead of that, it possibly
        triggers shadow subtree reconstruction on
        NodeRenderingContext::hostChildrenChanged().

        No new tests. This is a defensive change. There is no visible
        difference at this time.

        * dom/NodeRenderingContext.cpp:
        (WebCore::NodeRenderingContext::NodeRenderingContext):
        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::isInclusionSelectorActive):
        * dom/ShadowRoot.h:

2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211
2011-09-20  MORITA Hajime  <morrita@google.com>

        <meter> doesn't update rendering when its value is changed.
        https://bugs.webkit.org/show_bug.cgi?id=67614

        Reviewed by Dimitri Glazkov.

        It lacks repaint() when the value is changed. 
        
        For non-native appearance it works because the indicator is
        implemented in shadow DOM, for native appearance, repainting should be
        handled explicitly.
        
        Test: fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html

        * html/HTMLMeterElement.cpp:
        (WebCore::HTMLMeterElement::didElementStateChange):
        * rendering/RenderMeter.cpp:
        (WebCore::RenderMeter::updateFromElement):
        * rendering/RenderMeter.h:
        * rendering/RenderProgress.cpp:
        (WebCore::RenderProgress::updateAnimationState):

2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225
2011-09-20  Kent Tamura  <tkent@chromium.org>

        Move RenderObject::markContainingBlocksForLayout() to RenderObject.cpp.
        https://bugs.webkit.org/show_bug.cgi?id=67989

        Reviewed by Ryosuke Niwa.

        No new tests because of no behavior change.

        * rendering/RenderObject.cpp:
        (WebCore::objectIsRelayoutBoundary): Moved from RenderObject.h.
        (WebCore::RenderObject::markContainingBlocksForLayout): Moved from RenderObject.h
        * rendering/RenderObject.h:

2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252
2011-09-20  Rachel Blum  <groby@chromium.org>

        Support for multiple <link rel="icon"> favicon elements.
        https://bugs.webkit.org/show_bug.cgi?id=65564

        Reviewed by Darin Fisher.

        No tests - purely an API change. (And API is not exposed to LayoutTests)

        * dom/Document.cpp:
        (WebCore::Document::iconURLs):
        (WebCore::Document::addIconURL):
        * dom/Document.h:
        * dom/IconURL.cpp:
        (WebCore::toIconIndex):
        * dom/IconURL.h:
        (WebCore::IconURL::IconURL):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
        * loader/LinkLoader.cpp:
        (WebCore::LinkLoader::loadLink):
        * loader/LinkLoader.h:
        * loader/icon/IconController.cpp:
        (WebCore::IconController::urlsForTypes):
        (WebCore::IconController::appendToIconURLs):
        (WebCore::IconController::defaultURL):

2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269
2011-09-20  Ojan Vafai  <ojan@chromium.org>

        [css3-flexbox] cleanup padding width calculations
        https://bugs.webkit.org/show_bug.cgi?id=68490

        Reviewed by Tony Chang.

        No new tests. Existing tests cover the refactor.

        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::logicalBorderAndPaddingWidthForChild):
        (WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
        (WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
        (WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
        (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
        * rendering/RenderFlexibleBox.h:

2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283
2011-09-19  Jer Noble  <jer.noble@apple.com>

        Fix clang compile errors in Web Audio
        https://bugs.webkit.org/show_bug.cgi?id=68384

        Reviewed by David Levin.

        No new tests; no net change in functionality.

        * platform/graphics/MediaPlayer.h: Forward declare (instead of including directly)
            AudioSourceProvider.
        * webaudio/AudioChannelMerger.cpp:
        (WebCore::AudioChannelMerger::checkNumberOfChannelsForInput): Remove unused parameter name.

2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298
2011-09-20  John Gregg  <johnnyg@google.com>

        Directory Upload: parent path can truncate first char of the correct path
        https://bugs.webkit.org/show_bug.cgi?id=66695

        In some cases, if the parent path we compute ends with a separator
        character like '/' or 'C:\', by adding one in an attempt to grab the
        subsequent separator we actually grab a character of the real path,
        which is incorrect.

        Reviewed by Darin Fisher.

        * html/FileInputType.cpp:
        (WebCore::FileInputType::setFileList):

2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309
2011-09-20  Jochen Eisinger  <jochen@chromium.org>

        Invoke CachedResourceLoader::canRequest for all URLs in a redirect chain
        https://bugs.webkit.org/show_bug.cgi?id=68279

        Reviewed by Adam Barth.

        * loader/cache/CachedResourceLoader.h:
        * loader/cache/CachedResourceRequest.cpp:
        (WebCore::CachedResourceRequest::willSendRequest):

2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341
2011-09-18  Ojan Vafai  <ojan@chromium.org>

        change RenderFlexibleBox to act on logical coordinates
        https://bugs.webkit.org/show_bug.cgi?id=68129

        Reviewed by David Hyatt.

        This makes RenderFlexibleBox respect direction and writing-mode.
        We now properly support the default flex-flow value of "row".

        Test: css3/flexbox/writing-modes.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::setLogicalLocationForChild):
        * rendering/RenderBlock.h:
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock):
        (WebCore::RenderFlexibleBox::logicalBorderWidthForChild):
        (WebCore::RenderFlexibleBox::logicalPaddingWidthForChild):
        (WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
        (WebCore::RenderFlexibleBox::marginStartStyleForChild):
        (WebCore::RenderFlexibleBox::marginEndStyleForChild):
        (WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
        (WebCore::RenderFlexibleBox::layoutInlineDirection):
        (WebCore::RenderFlexibleBox::logicalPositiveFlexForChild):
        (WebCore::RenderFlexibleBox::logicalNegativeFlexForChild):
        (WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
        (WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
        (WebCore::RenderFlexibleBox::setLogicalOverrideSize):
        (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
        * rendering/RenderFlexibleBox.h:

2342 2343 2344 2345 2346 2347 2348 2349 2350 2351
2011-09-20  Marshall Greenblatt  <marshall@chromium.org>

        Use DEFINE_STATIC_LOCAL to intentionally leak the static RefCountedHFONT object returned from
        FontPlatformData::hashTableDeletedFontValue() to avoid global destructor ordering problems.
        https://bugs.webkit.org/show_bug.cgi?id=67906

        Reviewed by Adam Barth.

        * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:

2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369
2011-09-20  Ryosuke Niwa  <rniwa@webkit.org>

        Hit testing on margins of body and head elements doesn't recur
        https://bugs.webkit.org/show_bug.cgi?id=40753

        Reviewed by Darin Adler.

        The bug was caused by positionForPointRespectingEditingBoundaries's comparing the editability
        of head/body and html elements when hit testing was done inside margins of head and body elements.

        Fixed the bug by special-casing html element since margins of head and body elements are special.

        Tests: editing/selection/click-on-body-margin.html
               editing/selection/click-on-head-margin.html

        * rendering/RenderBlock.cpp:
        (WebCore::positionForPointRespectingEditingBoundaries):

2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396
2011-09-20  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=68480
        
        De-virtualize containingBlock() and make RenderView return 0 instead
        of itself to make the construction of normal loops that terminate via
        a null-check possible.

        Fix the only two places in the tree that needed null checks.

        Eliminating RenderTableCell::containingBlock() is fine since the base class
        does the same thing anyway.

        Reviewed by Simon Fraser.

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::lineDirectionPointForBlockDirectionNavigation):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::containingBlock):
        * rendering/RenderObject.h:
        * rendering/RenderTableCell.cpp:
        * rendering/RenderTableCell.h:
        * rendering/RenderTreeAsText.cpp:
        (WebCore::RenderTreeAsText::writeRenderObject):
        * rendering/RenderView.cpp:
        * rendering/RenderView.h:

2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414
2011-09-20  Anders Carlsson  <andersca@apple.com>

        Remove ScrollView::platformContentsSize
        https://bugs.webkit.org/show_bug.cgi?id=68188

        Reviewed by Darin Adler.

        Since ScrollView keeps track of the contents size in ScrollView::m_contentsSize, we never
        have to ask the underlying platform scroll view for contents size since it should always just
        be equal to m_contentsSize.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::contentsSize):
        (WebCore::ScrollView::wheelEvent):
        * platform/ScrollView.h:
        * platform/mac/ScrollViewMac.mm:
        * platform/wx/ScrollViewWx.cpp:

2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450
2011-09-20  Alexis Menard  <alexis.menard@openbossa.org>

        [Qt] [WK2] Implement a persistent cookie storage.
        https://bugs.webkit.org/show_bug.cgi?id=65309

        Reviewed by Chang Shu.

        Implement a cookie storage for the Qt port on WebKit2.
        The implementation is using a SQLite database to store the cookies
        and restore them. It uses a static object as CookieJar is not an
        object but a set of global functions. The actual saving/restoring is on
        the WebProcess side where our network stack lives.

        Existing tests cover the new implementation. Unfortunately there is one
        case that we can't easily simulate : login in a website, make sure that the webprocess
        is not running and then going back to this website and see that we are logged.

        * WebCore.pri:
        * WebCore.pro:
        * platform/qt/CookieJarQt.cpp:
        (WebCore::getHostnamesWithCookies):
        (WebCore::deleteCookiesForHostname):
        (WebCore::deleteAllCookies):
        (WebCore::SharedCookieJarQt::shared):
        (WebCore::SharedCookieJarQt::create):
        (WebCore::SharedCookieJarQt::destroy):
        (WebCore::SharedCookieJarQt::getHostnamesWithCookies):
        (WebCore::SharedCookieJarQt::deleteCookiesForHostname):
        (WebCore::SharedCookieJarQt::deleteAllCookies):
        (WebCore::SharedCookieJarQt::SharedCookieJarQt):
        (WebCore::SharedCookieJarQt::~SharedCookieJarQt):
        (WebCore::SharedCookieJarQt::setCookiesFromUrl):
        (WebCore::SharedCookieJarQt::ensureDatabaseTable):
        (WebCore::SharedCookieJarQt::loadCookies):
        * platform/qt/CookieJarQt.h: Added.

2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462