ChangeLog 1.58 MB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
2011-11-19  Alice Boxhall  <aboxhall@chromium.org>

        Modify dashboard_base.js to optionally accept version 4 results json.

        Reviewed by Ojan Vafai.

        * TestResultServer/static-dashboards/dashboard_base.js:
        (ADD_RESULTS):
        (flattenTrie):
        * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
        (testFlattenTrie):

13 14 15 16 17 18 19 20 21 22
2011-11-19  Ojan Vafai  <ojan@chromium.org>

        Stop storing results files as jsonp in the test results server
        https://bugs.webkit.org/show_bug.cgi?id=72814

        Reviewed by Adam Barth.

        * TestResultServer/model/jsonresults.py:
        * TestResultServer/model/jsonresults_unittest.py:

23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42
2011-11-19  Ojan Vafai  <ojan@chromium.org>

        Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
        https://bugs.webkit.org/show_bug.cgi?id=72813

        Reviewed by Adam Barth.

        Once this lands, we can start storing pure json in the test results server and then
        we can delete the code with all the FIXMEs added here.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        Only add jsonp for full_results.json.
        * TestResultServer/model/jsonresults.py:
        * TestResultServer/model/jsonresults_unittest.py:
        Accept pure json uploads.
        * TestResultServer/static-dashboards/dashboard_base.js:
        (appendJSONScriptElementFor):
        Use the callback parameter so that the server can start returning pure json if it's left out.

43 44 45 46 47 48 49 50 51 52 53 54 55 56 57
2011-11-19  Ojan Vafai  <ojan@chromium.org>

        Allow json NRWT downloads to be pure json and not jsonp
        https://bugs.webkit.org/show_bug.cgi?id=72809

        Reviewed by Adam Barth.

        I'm moving the server to storing and serving up raw json instead of jsonp.
        You can still get the jsonp by passing a "callback" parameter, but there's no
        need for run-webkit-tests to get jsonp when all it wants is the raw json.

        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        Make the wrapper stripping only happen if the json is actually wrapped.
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
2011-11-18  Daniel Bates  <dbates@rim.com>

        Add CMake build infrastructure for the BlackBerry port
        https://bugs.webkit.org/show_bug.cgi?id=72768

        Reviewed by Antonio Gomes.

        Add optional --blackberry command line argument to build-webkit to build the
        BlackBerry port.

        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:
        (determineBaseProductDir):
        (argumentsForConfiguration):
        (builtDylibPathForName):
        (determineIsQt):
        (isBlackBerry): Added.
        (determineIsBlackBerry): Added.
        (blackberryTargetArchitecture): Added.
        (isAppleWebKit):

79 80 81 82 83 84 85 86 87 88 89
2011-11-18  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r100835.
        http://trac.webkit.org/changeset/100835
        https://bugs.webkit.org/show_bug.cgi?id=72778

        Broke some page scale tests

        * DumpRenderTree/chromium/EventSender.cpp:
        (EventSender::scalePageBy):

90 91 92 93 94 95 96 97 98 99 100
2011-11-18  Adam Barth  <abarth@webkit.org>

        Prepare to move manual-tests out of WebCore
        https://bugs.webkit.org/show_bug.cgi?id=72782

        Reviewed by Eric Seidel.

        Update this file to refer to the new location of ManualTests.

        * Scripts/webkitpy/common/config/build.py:

101 102 103 104 105 106 107 108 109 110 111 112
2011-11-18  James Robinson  <jamesr@chromium.org>

        [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
        https://bugs.webkit.org/show_bug.cgi?id=72778

        Reviewed by Kenneth Russell.

        Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.

        * DumpRenderTree/chromium/EventSender.cpp:
        (EventSender::scalePageBy):

113 114 115 116 117 118 119 120 121 122 123 124
2011-11-18  Scott Graham  <scottmg@chromium.org>

        IDL changes for gamepad support
        https://bugs.webkit.org/show_bug.cgi?id=71753

        Reviewed by Adam Barth.

        Runtime enable gamepad in chromium test shell.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):

125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142
2011-10-27  Darin Fisher  <darin@chromium.org>

        [chromium] Improve fullscreen API
        https://bugs.webkit.org/show_bug.cgi?id=70477

        Reviewed by Adam Barth.

        Implement enter/exitFullScreen.  The implementation is asynchronous,
        via postDelayedTask, to simulate how the browser actually behaves.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::enterFullScreen):
        (WebViewHost::exitFullScreen):
        (WebViewHost::setAddressBarURL):
        (WebViewHost::enterFullScreenNow):
        (WebViewHost::exitFullScreenNow):
        * DumpRenderTree/chromium/WebViewHost.h:

143 144 145 146 147 148 149 150 151 152
2011-11-18  Adam Roben  <aroben@apple.com>

        Ignore an ANGLE leak that is not WebKit's fault

        * Scripts/old-run-webkit-tests:
        (countAndPrintLeaks):
        * Scripts/webkitpy/layout_tests/port/leakdetector.py:
        (LeakDetector._callstacks_to_exclude_from_leaks):
        Added ScanFromString to the call stacks to exclude on all OS versions.

153 154 155 156 157 158 159 160 161 162
2011-11-18  Adam Roben  <aroben@apple.com>

        Ignore another Lion-specific leak that is not WebKit's fault

        * Scripts/old-run-webkit-tests:
        (countAndPrintLeaks):
        * Scripts/webkitpy/layout_tests/port/leakdetector.py:
        (LeakDetector._callstacks_to_exclude_from_leaks):
        Added SecTransformExecute to the call stacks to exclude.

163 164 165 166 167 168 169 170 171 172 173 174 175 176
2011-11-18  Yuta Kitamura  <yutak@chromium.org>

        [Qt] Enable WebSocket hybi tests
        https://bugs.webkit.org/show_bug.cgi?id=72687

        Reviewed by Simon Hausmann.

        Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::resetSettings):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::overridePreference):

177 178 179 180 181 182 183 184 185 186 187 188
2011-11-18  Sergio Villar Senin  <svillar@igalia.com>

        [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=72707

        Reviewed by Philippe Normand.

        Make new-run-webkit-tests use the right path to locate the test
        plugin used by WebKitTestRunner.

        * Scripts/webkitpy/layout_tests/port/gtk.py:

189 190 191 192 193 194 195 196 197 198 199 200 201
2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
        https://bugs.webkit.org/show_bug.cgi?id=72697

        Reviewed by Kenneth Rohde Christiansen.

        * Tools.pro: Make WTR linux only for the moment.
        * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
        * WebKitTestRunner/Target.pri: Ditto.
        * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
        with ELF visibility on Linux. Instead we're temporarily using an LD version script.

202 203 204 205 206 207 208 209 210 211 212 213
2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        [Qt] Change default size of the MiniBrowser

        Reviewed by Simon Hausmann.

        As we lay out desktop pages using the width of 980, change our default
        size to 980x735 so that we are not scaling down by default.

        * MiniBrowser/qt/MiniBrowserApplication.h:
        (WindowOptions::WindowOptions):

214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229
2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>

        [EFL] Clean up the use of DATA_DIR in the buildsystem
        https://bugs.webkit.org/show_bug.cgi?id=72681

        Reviewed by Daniel Bates.

        Instead of adding -DDATA_DIR in all scopes, only define it in
        WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
        it.

        We can then define DATA_DIR to the generated theme directory for
        EWebLauncher, since it's what we want here.

        * CMakeListsEfl.txt:

230 231 232 233 234 235 236 237 238 239 240 241 242
2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>

        [EFL] Move platform includes last in DRT's include directories.
        https://bugs.webkit.org/show_bug.cgi?id=72684

        Reviewed by Daniel Bates.

        This is the first step in fixing the build when a platform include (in
        this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
        is included instead of WebKit's.

        * DumpRenderTree/efl/CMakeLists.txt:

243 244 245 246 247 248 249 250 251 252 253 254 255 256 257
2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>

        fuzzy_match doesn't recognize "Dan B" or "hyatt"
        https://bugs.webkit.org/show_bug.cgi?id=72636

        Reviewed by Eric Seidel.

        Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
        and user names of email addreses such as rniwa in rniwa@webkit.org.

        Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.

        * Scripts/webkitpy/common/config/committers.py:
        * Scripts/webkitpy/common/config/committers_unittest.py:

258 259 260 261 262 263 264 265 266 267 268 269 270
2011-11-17  Eric Seidel  <eric@webkit.org>

        Remove support for running check-webkit-style w/o a webkit checkout
        https://bugs.webkit.org/show_bug.cgi?id=72678

        Reviewed by Adam Barth.

        After talking to Dave Levin we've decided to remove this
        code.  I know of no users of check-webkit-style w/o a webkit checkout
        and this needlessly adds complexity.

        * Scripts/webkitpy/style/main.py:

271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290
2011-11-17  Eric Seidel  <eric@webkit.org>

        Remove more direct uses of os.path
        https://bugs.webkit.org/show_bug.cgi?id=72677

        Reviewed by Adam Barth.

        Remove more uses of os.path, including refactoring
        CommitterValidator to use a Host object instead of
        manual hacks to emulate what SCM and FileSystem provide.

        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/config/committervalidator.py:
        * Scripts/webkitpy/common/config/committervalidator_unittest.py:
        * Scripts/webkitpy/common/system/filesystem_mock.py:
         - Turns out none of our unittests actually looked at this path.
           now I've made it be a valid path.
        * Scripts/webkitpy/tool/bot/feeders.py:
        * Scripts/webkitpy/tool/commands/queues.py:

291 292 293 294 295 296 297 298 299 300 301 302 303 304 305
2011-11-17  Eric Seidel  <eric@webkit.org>

        Teach TextFileReader about FileSystem
        https://bugs.webkit.org/show_bug.cgi?id=72673

        Reviewed by Adam Barth.

        Unfortunately TextFileReader doesn't use FileSystem
        everywhere yet, so we can't move the unittests to
        using MockFileSystem, but we're close.

        * Scripts/webkitpy/style/filereader.py:
        * Scripts/webkitpy/style/filereader_unittest.py:
        * Scripts/webkitpy/style/main.py:

306 307 308 309 310 311 312 313 314 315 316 317 318 319
2011-11-17  Eric Seidel  <eric@webkit.org>

        Give check-webkit-style a Host
        https://bugs.webkit.org/show_bug.cgi?id=72670

        Reviewed by Adam Barth.

        * Scripts/webkitpy/common/checkout/scm/detection.py:
        * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
         - We don't run these unittests, but this one was looking for the wrong exception.
        * Scripts/webkitpy/style/main.py:
        * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
         - This was create a new scm object even though it already had one?

320 321 322 323 324 325 326 327 328 329 330
2011-11-17  Eric Seidel  <eric@webkit.org>

        Move check-webkit-style change_directory code to more modern mocks
        https://bugs.webkit.org/show_bug.cgi?id=72664

        Reviewed by Adam Barth.

        * Scripts/check-webkit-style:
        * Scripts/webkitpy/style/main.py:
        * Scripts/webkitpy/style/main_unittest.py:

331 332 333 334 335 336 337 338 339 340 341 342 343 344
2011-11-17  Zan Dobersek  <zandobersek@gmail.com>

        [GTK] enable ref tests
        https://bugs.webkit.org/show_bug.cgi?id=72601

        Re-enable ref tests. Run the driver under evenly numbered display if performing
        pixel tests or under oddly numbered display otherwise. This prevents the ref tests
        being run in an already used Xvfb instance if pixel tests are disabled.

        Reviewed by Tony Chang.

        * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
        after the process is killed

345 346 347 348 349 350 351 352 353 354 355 356 357 358 359
2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
        https://bugs.webkit.org/show_bug.cgi?id=72620

        Reviewed by David Levin.

        Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
        adding the suffix the cpp file. One example of false positive
        https://bugs.webkit.org/show_bug.cgi?id=72319#c12.

        * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
        basename contains the cpp's basename.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:

360 361 362 363 364 365 366 367 368 369
2011-11-17  Eric Seidel  <eric@webkit.org>

        Move check-webkit-style's guts into webkitpy/style/main.py
        https://bugs.webkit.org/show_bug.cgi?id=72657

        Reviewed by Adam Barth.

        * Scripts/check-webkit-style:
        * Scripts/webkitpy/style/main.py:

370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391
2011-11-17  Eric Seidel  <eric@webkit.org>

        new-run-webkit-tests is locale dependent
        https://bugs.webkit.org/show_bug.cgi?id=68691

        Reviewed by Adam Barth.

        Make NRWT use a clean environment, just like ORWT did.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
        * Scripts/webkitpy/layout_tests/port/efl.py:
        * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/qt.py:
        * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/win.py:

392 393 394 395 396 397 398 399 400
2011-11-17  Dirk Pranke  <dpranke@chromium.org>

        Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
        https://bugs.webkit.org/show_bug.cgi?id=72615

        Reviewed by James Robinson.

        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

401 402 403 404 405 406 407 408 409 410 411 412 413 414 415
2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
        https://bugs.webkit.org/show_bug.cgi?id=72595

        Reviewed by Noam Rosenthal.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
        ensure the registration of the DRTNode JS bindings.
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
        registration of QWebElement (now done implicitly through QWebPage ->
        QtWebElementRunTime::initialize code path)

416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431
2011-11-17  Adam Roben  <aroben@apple.com>

        Fix a crash-inducing typo I introduced in r100648

        Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
        handling a crashing test

        Reviewed by Adam Barth.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        (ChromiumDriver.run_test): Get the driver name from the port.

        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
        right crashed process name.

432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450
2011-11-17  Adam Roben  <aroben@apple.com>

        Fix NRWT's parsing of the number of excluded leaks

        Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
        leaks were excluded

        Reviewed by Adam Barth.

        * Scripts/webkitpy/layout_tests/port/leakdetector.py:
        (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
        regular expression match, not the entire matched string.

        * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
        (LeakDetectorTest): Added some example output that shows how things look when leaks are
        excluded.
        (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
        correctly.

451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486
2011-11-17  Adam Roben  <aroben@apple.com>

        Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process

        Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
        when web process crashes, but WebProcess crash log should get saved instead

        Reviewed by Eric Seidel.

        * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
        (write_test_result): Simplified a little to share more code between the case where we
        crashed when running the test and where we crashed when checking the expected rendering for
        a reftest. Changed to pass the crashed process name down to write_crash_report.
        (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
        along to CrashLogs.find_newest_log rather than always using the driver name.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
        crashed.

        * Scripts/webkitpy/layout_tests/port/test.py:
        (TestInstance.__init__): Initialize new web_process_crash attribute.
        (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
        test this patch adds.
        (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
        specifies that the driver crashed or the web process crashed.

        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
        (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
        which we pretend the web process crashed rather than the driver process.

        (MainTest.test_run_singly_actually_runs_tests):
        (MainTest.test_unexpected_failures):
        (EndToEndTest.test_end_to_end):
        Updated magic numbers to account for new unexpected failing test added to unit_test_list.

487 488 489 490 491 492 493 494 495 496 497 498 499
2011-11-17  Tony Chang  <tony@chromium.org>

        [chromium] stop spamming features warning on every build
        https://bugs.webkit.org/show_bug.cgi?id=72629

        Reviewed by Ojan Vafai.

        We toggle $blobSupport on if $mediaStreamSupport is on.  Since
        $mediaStreamSupport is on by default for chromium, make the default
        for $blobSupport also on.

        * Scripts/build-webkit:

500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516
2011-11-17  Adam Roben  <aroben@apple.com>

        Remove extra quoting of call stacks and types passed to run-leaks by NRWT

        Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
        that are supposed to be ignored

        Reviewed by Adam Barth.

        * Scripts/webkitpy/layout_tests/port/leakdetector.py:
        (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
        required when passing arguments via the shell (which we aren't doing here). It is not
        required by Perl's option-parsing code (as the comment I removed mistakenly claimed).

        * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
        (LeakDetectorTest.test_leaks_args): Updated expectations.

517 518 519 520 521 522
2011-11-17  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, run-bindings-tests fix after r91028.

        * Scripts/run-bindings-tests: Use scm.detection module.

523 524 525 526 527 528 529 530 531 532
2011-11-17  Jochen Eisinger  <jochen@chromium.org>

        Silence a warning about control reaching the end of a non-void function
        https://bugs.webkit.org/show_bug.cgi?id=72616

        Reviewed by Tony Gentilcore.

        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::verticalScrollbar):

533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554
2011-11-17  Adam Roben  <aroben@apple.com>

        Ignore some leaks in frameworks we link against on Lion

        Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
        aren't WebKit's fault

        Reviewed by Antti Koivisto.

        * Scripts/old-run-webkit-tests:
        (countAndPrintLeaks):
        * Scripts/webkitpy/layout_tests/port/leakdetector.py:
        (LeakDetector._callstacks_to_exclude_from_leaks):
        Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.

        * Scripts/webkitpy/layout_tests/port/mac.py:
        (MacPort.is_lion): Added.

        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
        methods.

philn@webkit.org's avatar
philn@webkit.org committed
555 556 557 558 559 560 561 562 563 564
2011-11-17  Philippe Normand  <pnormand@igalia.com>

        [GTK] Disable ref tests
        https://bugs.webkit.org/show_bug.cgi?id=72599

        Reviewed by Xan Lopez.

        * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
        tests to avoid massive flakiness.

565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587
2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that

        A new extension object has been added to QQuickWebView (the same approach should be used
        for other API classes that need experimental APIs). The QML extension mechanism is then
        built on top of the experimental object.

        https://bugs.webkit.org/show_bug.cgi?id=72522

        Reviewed by Simon Hausmann.

        * MiniBrowser/qt/BrowserWindow.cpp:
        (BrowserWindow::BrowserWindow):
        (BrowserWindow::webView):
        * MiniBrowser/qt/BrowserWindow.h:
        * MiniBrowser/qt/UrlLoader.cpp:
        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
        * qmake/mkspecs/features/default_post.prf:
        * qmake/mkspecs/features/default_pre.prf:
        * qmake/mkspecs/features/qtwebkit-private.prf: Added.
        * qmake/mkspecs/features/qtwebkit.prf:

588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604
2011-11-17  Adam Barth  <abarth@webkit.org>

        Move test_results_uploader.py out of layout_package
        https://bugs.webkit.org/show_bug.cgi?id=72590

        Reviewed by Eric Seidel.

        Most of the lines of code in this file are wrong, but I've restrained
        myself and only changed a few of them to generalized this class to the
        common package.

        This is part of a series of patches to remove layout_package.

        * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.

605 606 607 608 609 610
2011-11-17  Adam Barth  <abarth@webkit.org>

        Unreviewed. Fix style nits in printing.py.

        * Scripts/webkitpy/layout_tests/views/printing.py:

611 612 613 614 615 616 617 618 619 620 621 622
2011-11-17  Adam Barth  <abarth@webkit.org>

        Minor style nits in run_webkit_tests.py
        https://bugs.webkit.org/show_bug.cgi?id=72583

        Reviewed by Eric Seidel.

        This patch just fixes some minor style issues as I work my way back
        into this code.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

623 624 625 626 627 628 629 630 631 632 633 634 635 636
2011-11-17  Adam Barth  <abarth@webkit.org>

        Move test_result_writer out of layout_package
        https://bugs.webkit.org/show_bug.cgi?id=72586

        Rubber-stamped by Eric Seidel.

        This is part of a series of patches to remove layout_package.

        * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
        * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
        * Scripts/webkitpy/tool/commands/rebaseline.py:

637 638 639 640 641 642 643 644 645 646 647 648 649 650
2011-11-17  Adam Barth  <abarth@webkit.org>

        svn-apply shouldn't magically move files into Source anymore
        https://bugs.webkit.org/show_bug.cgi?id=72579

        Reviewed by Eric Seidel.

        The Source directory has existed for long enough that we don't need
        svn-apply to magically re-write old-style patches anymore.

        * Scripts/VCSUtils.pm:
        (parseGitDiffHeader):
        (parseSvnDiffHeader):

651 652 653 654 655 656 657 658 659 660 661 662
2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>

        Add a list of contribution areas
        https://bugs.webkit.org/show_bug.cgi?id=72566

        Reviewed by Eric Seidel.

        Added ContributionAreas class.

        * Scripts/webkitpy/common/config/contributionareas.py: Added.
        * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.

663 664 665 666 667 668 669 670 671 672 673
2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>

        Refactor ChangeLogTest.test_parse_reviewer_text
        https://bugs.webkit.org/show_bug.cgi?id=72572

        Reviewed by Eric Seidel.

        Refactored the test code by introduing two helper functions.

        * Scripts/webkitpy/common/checkout/changelog_unittest.py:

674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708
2011-11-16  Eric Seidel  <eric@webkit.org>

        Add SCMDetector object to make scm detection mockable
        https://bugs.webkit.org/show_bug.cgi?id=72247

        Reviewed by Adam Barth.

        I think SCM detection may eventually be rolled into Checkout,
        but this patch at least makes it possible to mock code-paths
        which rely on scm detection.
        In the process of replacing callers of these free-functions
        I found that one of the functions was no longer used,
        and that one of the callers could instead just use the SCM
        object it already had access to through port.host.scm().
        I also discovered that I was not calling Host._initialize_scm()
        and thus host.scm() was always returning None!

        * Scripts/check-webkit-style:
        * Scripts/webkitpy/common/checkout/checkout_unittest.py:
        * Scripts/webkitpy/common/checkout/deps.py:
        * Scripts/webkitpy/common/checkout/scm/__init__.py:
        * Scripts/webkitpy/common/checkout/scm/detection.py:
        * Scripts/webkitpy/common/checkout/scm/git.py:
        * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
        * Scripts/webkitpy/common/checkout/scm/svn.py:
        * Scripts/webkitpy/common/host.py:
        * Scripts/webkitpy/common/host_mock.py:
        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/mock_drt.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/tool/servers/rebaselineserver.py:

mrowe@apple.com's avatar
mrowe@apple.com committed
709 710 711 712 713 714 715 716 717 718 719
2011-11-16  Mark Rowe  <mrowe@apple.com>

        Fix the build.

        The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
        Apply the workaround that we use in other projects to WebKitTestRunner.

        * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
        * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
        * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.

720 721 722 723 724 725 726 727 728 729
2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        [Qt] Fix build after WTR AX support
        https://bugs.webkit.org/show_bug.cgi?id=72560

        Reviewed by Geoffrey Garen.

        * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
        * WebKitTestRunner/InjectedBundle/Target.pri:

730 731 732 733 734 735 736 737 738 739 740 741 742 743 744
2011-11-16  Tony Chang  <tony@chromium.org>

        repurpose the flexbox bot for grid layout
        https://bugs.webkit.org/show_bug.cgi?id=72557

        Reviewed by Ryosuke Niwa.

        Since new flexbox is enabled everywhere, we don't need this bot
        anymore.  However, work on grid layout has begun, so we can use this
        bot to compile with ENABLE_CSS_GRID_LAYOUT.

        * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
        the bot on the waterfall, I will change the slave config to enable
        the compile flag and tests.

745 746 747 748 749 750 751 752 753 754 755 756
2011-11-11  Adrienne Walker  <enne@google.com>

        [chromium] Expose mock scrollbars to window.internals
        https://bugs.webkit.org/show_bug.cgi?id=72195

        Reviewed by James Robinson.

        Because mock scrollbars are a global setting, reset between runs.

        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::applyTo):

757 758 759 760 761 762 763 764 765 766
2011-11-16  James Robinson  <jamesr@chromium.org>

        [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
        https://bugs.webkit.org/show_bug.cgi?id=72562

        Reviewed by Dirk Pranke.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::runFileTest):

767 768 769 770 771 772 773 774 775 776 777
2011-11-16  Tony Chang  <tony@chromium.org>

        [NRWT] speculative fix for multiple subprocess test on cygwin
        https://bugs.webkit.org/show_bug.cgi?id=72518

        Reviewed by Adam Barth.

        * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
            tries to emulate posix fd behavior.
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

778 779 780 781 782 783 784
2011-11-16  Dirk Pranke  <dpranke@chromium.org>

        Revert r100509; change was committed twice (first time as r100491).
        Unreviewed, build fix.

        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

785 786 787 788 789 790 791 792 793
2011-11-16  Dirk Pranke  <dpranke@chromium.org>

        Run a dummy test in the gpu configurations if there's nothing to do.
        https://bugs.webkit.org/show_bug.cgi?id=72498

        Reviewed by James Robinson.

        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

794 795 796 797 798 799 800 801 802 803 804 805 806 807 808
2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>

        contributors_by_fuzzy_match is super slow
        https://bugs.webkit.org/show_bug.cgi?id=72540

        Reviewed by Eric Seidel.

        Make contributors_by_name do case insensitive search using a dictionary.

        Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
        because that's the most common case.

        * Scripts/webkitpy/common/config/committers.py:
        * Scripts/webkitpy/common/config/committers_unittest.py:

809 810 811 812 813 814 815 816 817 818
2011-11-16  David Levin  <levin@chromium.org>

        check-webkit-style should recognize functions even if they have OVERRIDE after them.
        https://bugs.webkit.org/show_bug.cgi?id=72515

        Reviewed by Adam Barth.

        * Scripts/webkitpy/style/checkers/cpp.py:
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:

819 820 821 822 823 824 825 826 827 828 829 830 831 832
2011-11-16  Tony Chang  <tony@chromium.org>

        [NRWT] refactor drivers to require pixel_tests param
        https://bugs.webkit.org/show_bug.cgi?id=72517

        Reviewed by Ojan Vafai.

        No tests, just a refactoring.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

833 834 835 836 837 838 839 840 841
2011-11-16  Dirk Pranke  <dpranke@chromium.org>

        Run a dummy test in the gpu configurations if there's nothing to do.
        https://bugs.webkit.org/show_bug.cgi?id=72498

        Reviewed by James Robinson.

        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174
2011-11-16  Chris Fleizach  <cfleizach@apple.com>

        WebKitTestRunner needs to support accessibility-related DRT APIs
        https://bugs.webkit.org/show_bug.cgi?id=42131

        Reviewed by Beth Dakin.

        Port the AX code in DRT to WKTestRunner by using IDL.

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (horizontalScrollbarCallback):
        (verticalScrollbarCallback):
        (AccessibilityUIElement::horizontalScrollbar):
        (AccessibilityUIElement::verticalScrollbar):
        (AccessibilityUIElement::getJSClass):
        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::horizontalScrollbar):
        (AccessibilityUIElement::verticalScrollbar):
        * WebKitTestRunner/DerivedSources.make:
        * WebKitTestRunner/GNUmakefile.am:
        * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
        (WTR::AccessibilityController::create):
        (WTR::AccessibilityController::AccessibilityController):
        (WTR::AccessibilityController::~AccessibilityController):
        (WTR::AccessibilityController::makeWindowObject):
        (WTR::AccessibilityController::wrapperClass):
        (WTR::AccessibilityController::rootElement):
        (WTR::AccessibilityController::focusedElement):
        (WTR::AccessibilityController::elementAtPoint):
        * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
        (WTR::AccessibilityController::logFocusEvents):
        (WTR::AccessibilityController::logValueChangeEvents):
        (WTR::AccessibilityController::logScrollingStartEvents):
        (WTR::AccessibilityController::logAccessibilityEvents):
        (WTR::AccessibilityController::addNotificationListener):
        (WTR::AccessibilityController::notificationReceived):
        (WTR::AccessibilityController::resetToConsistentState):
        * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
        (WTR::AccessibilityTextMarker::create):
        (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
        (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
        (WTR::AccessibilityTextMarker::platformTextMarker):
        (WTR::AccessibilityTextMarker::wrapperClass):
        * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
        (WTR::AccessibilityTextMarker::isEqual):
        * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
        (WTR::AccessibilityTextMarkerRange::create):
        (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
        (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
        (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
        (WTR::AccessibilityTextMarkerRange::wrapperClass):
        * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
        (WTR::AccessibilityTextMarkerRange::isEqual):
        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
        (WTR::AccessibilityUIElement::create):
        (WTR::AccessibilityUIElement::wrapperClass):
        (WTR::AccessibilityUIElement::isValid):
        (WTR::AccessibilityUIElement::AccessibilityUIElement):
        (WTR::AccessibilityUIElement::~AccessibilityUIElement):
        (WTR::AccessibilityUIElement::isEqual):
        (WTR::AccessibilityUIElement::elementAtPoint):
        (WTR::AccessibilityUIElement::childAtIndex):
        (WTR::AccessibilityUIElement::indexOfChild):
        (WTR::AccessibilityUIElement::childrenCount):
        (WTR::AccessibilityUIElement::titleUIElement):
        (WTR::AccessibilityUIElement::parentElement):
        (WTR::AccessibilityUIElement::takeFocus):
        (WTR::AccessibilityUIElement::takeSelection):
        (WTR::AccessibilityUIElement::addSelection):
        (WTR::AccessibilityUIElement::removeSelection):
        (WTR::AccessibilityUIElement::allAttributes):
        (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
        (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
        (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
        (WTR::AccessibilityUIElement::attributesOfChildren):
        (WTR::AccessibilityUIElement::parameterizedAttributeNames):
        (WTR::AccessibilityUIElement::increment):
        (WTR::AccessibilityUIElement::decrement):
        (WTR::AccessibilityUIElement::showMenu):
        (WTR::AccessibilityUIElement::press):
        (WTR::AccessibilityUIElement::stringAttributeValue):
        (WTR::AccessibilityUIElement::uiElementAttributeValue):
        (WTR::AccessibilityUIElement::numberAttributeValue):
        (WTR::AccessibilityUIElement::boolAttributeValue):
        (WTR::AccessibilityUIElement::isAttributeSupported):
        (WTR::AccessibilityUIElement::isAttributeSettable):
        (WTR::AccessibilityUIElement::isActionSupported):
        (WTR::AccessibilityUIElement::role):
        (WTR::AccessibilityUIElement::subrole):
        (WTR::AccessibilityUIElement::roleDescription):
        (WTR::AccessibilityUIElement::title):
        (WTR::AccessibilityUIElement::description):
        (WTR::AccessibilityUIElement::language):
        (WTR::AccessibilityUIElement::stringValue):
        (WTR::AccessibilityUIElement::accessibilityValue):
        (WTR::AccessibilityUIElement::helpText):
        (WTR::AccessibilityUIElement::orientation):
        (WTR::AccessibilityUIElement::x):
        (WTR::AccessibilityUIElement::y):
        (WTR::AccessibilityUIElement::width):
        (WTR::AccessibilityUIElement::height):
        (WTR::AccessibilityUIElement::intValue):
        (WTR::AccessibilityUIElement::minValue):
        (WTR::AccessibilityUIElement::maxValue):
        (WTR::AccessibilityUIElement::valueDescription):
        (WTR::AccessibilityUIElement::insertionPointLineNumber):
        (WTR::AccessibilityUIElement::selectedTextRange):
        (WTR::AccessibilityUIElement::isEnabled):
        (WTR::AccessibilityUIElement::isRequired):
        (WTR::AccessibilityUIElement::isFocused):
        (WTR::AccessibilityUIElement::isFocusable):
        (WTR::AccessibilityUIElement::isSelected):
        (WTR::AccessibilityUIElement::isSelectable):
        (WTR::AccessibilityUIElement::isMultiSelectable):
        (WTR::AccessibilityUIElement::setSelectedChild):
        (WTR::AccessibilityUIElement::selectedChildrenCount):
        (WTR::AccessibilityUIElement::selectedChildAtIndex):
        (WTR::AccessibilityUIElement::isExpanded):
        (WTR::AccessibilityUIElement::isChecked):
        (WTR::AccessibilityUIElement::isVisible):
        (WTR::AccessibilityUIElement::isOffScreen):
        (WTR::AccessibilityUIElement::isCollapsed):
        (WTR::AccessibilityUIElement::isIgnored):
        (WTR::AccessibilityUIElement::hasPopup):
        (WTR::AccessibilityUIElement::hierarchicalLevel):
        (WTR::AccessibilityUIElement::clickPointX):
        (WTR::AccessibilityUIElement::clickPointY):
        (WTR::AccessibilityUIElement::documentEncoding):
        (WTR::AccessibilityUIElement::documentURI):
        (WTR::AccessibilityUIElement::url):
        (WTR::AccessibilityUIElement::speak):
        (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
        (WTR::AccessibilityUIElement::attributesOfRowHeaders):
        (WTR::AccessibilityUIElement::attributesOfColumns):
        (WTR::AccessibilityUIElement::attributesOfRows):
        (WTR::AccessibilityUIElement::attributesOfVisibleCells):
        (WTR::AccessibilityUIElement::attributesOfHeader):
        (WTR::AccessibilityUIElement::indexInTable):
        (WTR::AccessibilityUIElement::rowIndexRange):
        (WTR::AccessibilityUIElement::columnIndexRange):
        (WTR::AccessibilityUIElement::rowCount):
        (WTR::AccessibilityUIElement::columnCount):
        (WTR::AccessibilityUIElement::selectedRowAtIndex):
        (WTR::AccessibilityUIElement::disclosedByRow):
        (WTR::AccessibilityUIElement::disclosedRowAtIndex):
        (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
        (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
        (WTR::AccessibilityUIElement::ariaIsGrabbed):
        (WTR::AccessibilityUIElement::ariaDropEffects):
        (WTR::AccessibilityUIElement::lineForIndex):
        (WTR::AccessibilityUIElement::rangeForLine):
        (WTR::AccessibilityUIElement::boundsForRange):
        (WTR::AccessibilityUIElement::setSelectedTextRange):
        (WTR::AccessibilityUIElement::stringForRange):
        (WTR::AccessibilityUIElement::attributedStringForRange):
        (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
        (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
        (WTR::AccessibilityUIElement::cellForColumnAndRow):
        (WTR::AccessibilityUIElement::horizontalScrollbar):
        (WTR::AccessibilityUIElement::verticalScrollbar):
        (WTR::AccessibilityUIElement::addNotificationListener):
        (WTR::AccessibilityUIElement::removeNotificationListener):
        (WTR::AccessibilityUIElement::textMarkerRangeForElement):
        (WTR::AccessibilityUIElement::textMarkerRangeLength):
        (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
        (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
        (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
        (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
        (WTR::AccessibilityUIElement::textMarkerForPoint):
        (WTR::AccessibilityUIElement::previousTextMarker):
        (WTR::AccessibilityUIElement::nextTextMarker):
        (WTR::AccessibilityUIElement::stringForTextMarkerRange):
        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
        (WTR::AccessibilityUIElement::platformUIElement):
        * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
        * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
        * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
        * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::beginTesting):
        * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
        (WTR::InjectedBundle::accessibilityController):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::didClearWindowForFrame):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
        * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
        (WTR::LayoutTestController::platformName):
        * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
        (WTR::AccessibilityTextMarker::isEqual):
        * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
        (WTR::AccessibilityTextMarkerRange::isEqual):
        * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
        (+[NSString stringWithJSStringRef:]):
        (-[NSString createJSStringRef]):
        (-[AccessibilityNotificationHandler initWithPlatformElement:]):
        (-[AccessibilityNotificationHandler dealloc]):
        (-[AccessibilityNotificationHandler _notificationReceived:]):
        (-[AccessibilityNotificationHandler setCallback:]):
        (WTR::AccessibilityUIElement::AccessibilityUIElement):
        (WTR::AccessibilityUIElement::~AccessibilityUIElement):
        (WTR::AccessibilityUIElement::isEqual):
        (WTR::descriptionOfValue):
        (WTR::attributesOfElement):
        (WTR::concatenateAttributeAndValue):
        (WTR::convertNSArrayToVector):
        (WTR::descriptionOfElements):
        (WTR::AccessibilityUIElement::getLinkedUIElements):
        (WTR::AccessibilityUIElement::getDocumentLinks):
        (WTR::AccessibilityUIElement::getChildren):
        (WTR::AccessibilityUIElement::getChildrenWithRange):
        (WTR::AccessibilityUIElement::childrenCount):
        (WTR::AccessibilityUIElement::elementAtPoint):
        (WTR::AccessibilityUIElement::indexOfChild):
        (WTR::AccessibilityUIElement::childAtIndex):
        (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
        (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
        (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
        (WTR::AccessibilityUIElement::disclosedRowAtIndex):
        (WTR::AccessibilityUIElement::selectedChildAtIndex):
        (WTR::AccessibilityUIElement::selectedChildrenCount):
        (WTR::AccessibilityUIElement::selectedRowAtIndex):
        (WTR::AccessibilityUIElement::titleUIElement):
        (WTR::AccessibilityUIElement::parentElement):
        (WTR::AccessibilityUIElement::disclosedByRow):
        (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
        (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
        (WTR::AccessibilityUIElement::attributesOfChildren):
        (WTR::AccessibilityUIElement::allAttributes):
        (WTR::AccessibilityUIElement::stringAttributeValue):
        (WTR::AccessibilityUIElement::numberAttributeValue):
        (WTR::AccessibilityUIElement::uiElementAttributeValue):
        (WTR::AccessibilityUIElement::boolAttributeValue):
        (WTR::AccessibilityUIElement::isAttributeSettable):
        (WTR::AccessibilityUIElement::isAttributeSupported):
        (WTR::AccessibilityUIElement::parameterizedAttributeNames):
        (WTR::AccessibilityUIElement::role):
        (WTR::AccessibilityUIElement::subrole):
        (WTR::AccessibilityUIElement::roleDescription):
        (WTR::AccessibilityUIElement::title):
        (WTR::AccessibilityUIElement::description):
        (WTR::AccessibilityUIElement::orientation):
        (WTR::AccessibilityUIElement::stringValue):
        (WTR::AccessibilityUIElement::language):
        (WTR::AccessibilityUIElement::helpText):
        (WTR::AccessibilityUIElement::x):
        (WTR::AccessibilityUIElement::y):
        (WTR::AccessibilityUIElement::width):
        (WTR::AccessibilityUIElement::height):
        (WTR::AccessibilityUIElement::clickPointX):
        (WTR::AccessibilityUIElement::clickPointY):
        (WTR::AccessibilityUIElement::intValue):
        (WTR::AccessibilityUIElement::minValue):
        (WTR::AccessibilityUIElement::maxValue):
        (WTR::AccessibilityUIElement::valueDescription):
        (WTR::AccessibilityUIElement::insertionPointLineNumber):
        (WTR::AccessibilityUIElement::isActionSupported):
        (WTR::AccessibilityUIElement::isEnabled):
        (WTR::AccessibilityUIElement::isRequired):
        (WTR::AccessibilityUIElement::isFocused):
        (WTR::AccessibilityUIElement::isSelected):
        (WTR::AccessibilityUIElement::isExpanded):
        (WTR::AccessibilityUIElement::isChecked):
        (WTR::AccessibilityUIElement::hierarchicalLevel):
        (WTR::AccessibilityUIElement::speak):
        (WTR::AccessibilityUIElement::ariaIsGrabbed):
        (WTR::AccessibilityUIElement::ariaDropEffects):
        (WTR::AccessibilityUIElement::lineForIndex):
        (WTR::AccessibilityUIElement::rangeForLine):
        (WTR::AccessibilityUIElement::boundsForRange):
        (WTR::AccessibilityUIElement::stringForRange):
        (WTR::AccessibilityUIElement::attributedStringForRange):
        (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
        (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
        (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
        (WTR::AccessibilityUIElement::attributesOfRowHeaders):
        (WTR::AccessibilityUIElement::attributesOfColumns):
        (WTR::AccessibilityUIElement::attributesOfRows):
        (WTR::AccessibilityUIElement::attributesOfVisibleCells):
        (WTR::AccessibilityUIElement::attributesOfHeader):
        (WTR::AccessibilityUIElement::rowCount):
        (WTR::AccessibilityUIElement::columnCount):
        (WTR::AccessibilityUIElement::indexInTable):
        (WTR::AccessibilityUIElement::rowIndexRange):
        (WTR::AccessibilityUIElement::columnIndexRange):
        (WTR::AccessibilityUIElement::cellForColumnAndRow):
        (WTR::AccessibilityUIElement::horizontalScrollbar):
        (WTR::AccessibilityUIElement::verticalScrollbar):
        (WTR::AccessibilityUIElement::selectedTextRange):
        (WTR::AccessibilityUIElement::setSelectedTextRange):
        (WTR::AccessibilityUIElement::increment):
        (WTR::AccessibilityUIElement::decrement):
        (WTR::AccessibilityUIElement::showMenu):
        (WTR::AccessibilityUIElement::press):
        (WTR::AccessibilityUIElement::setSelectedChild):
        (WTR::AccessibilityUIElement::accessibilityValue):
        (WTR::AccessibilityUIElement::documentEncoding):
        (WTR::AccessibilityUIElement::documentURI):
        (WTR::AccessibilityUIElement::url):
        (WTR::AccessibilityUIElement::addNotificationListener):
        (WTR::AccessibilityUIElement::removeNotificationListener):
        (WTR::AccessibilityUIElement::isFocusable):
        (WTR::AccessibilityUIElement::isSelectable):
        (WTR::AccessibilityUIElement::isMultiSelectable):
        (WTR::AccessibilityUIElement::isVisible):
        (WTR::AccessibilityUIElement::isOffScreen):
        (WTR::AccessibilityUIElement::isCollapsed):
        (WTR::AccessibilityUIElement::isIgnored):
        (WTR::AccessibilityUIElement::hasPopup):
        (WTR::AccessibilityUIElement::takeFocus):
        (WTR::AccessibilityUIElement::takeSelection):
        (WTR::AccessibilityUIElement::addSelection):
        (WTR::AccessibilityUIElement::removeSelection):
        (WTR::AccessibilityUIElement::textMarkerRangeForElement):
        (WTR::AccessibilityUIElement::textMarkerRangeLength):
        (WTR::AccessibilityUIElement::previousTextMarker):
        (WTR::AccessibilityUIElement::nextTextMarker):
        (WTR::AccessibilityUIElement::stringForTextMarkerRange):
        (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
        (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
        (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
        (WTR::AccessibilityUIElement::textMarkerForPoint):
        (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
        * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
        (WTR::LayoutTestController::platformName):
        * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
        (WTR::LayoutTestController::platformName):
        * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
        (WTR::LayoutTestController::platformName):
        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
        * WebKitTestRunner/win/InjectedBundle.vcproj:

1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195
2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        [Qt] Fix use of config.tests

        We were checking @buildArgs to determine if the optional argument was
        passed or not, but this is not the right way to do that in Perl. The
        right way is to not use a prototype for the function, and to pass
        the list as a reference (to avoid list expansion). That way we can
        check the number of arguments, and choose the right code path based
        on that.

        We were also missing a default-value of 0 for any feature that's not
        set in features.prf.

        Reviewed by Kenneth Rohde Christiansen.

        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:
        (qtFeatureDefaults):
        (buildQMakeProject):

1196 1197 1198 1199 1200 1201 1202 1203 1204 1205
2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        [Qt] Prospective fix for broken plugin tests

        Don't hide symbols for the NPAPI test plugin

        Rubber-stamped by Andreas Kling.

        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228
2011-11-16  Adam Roben  <aroben@apple.com>

        Move filenames/line numbers off to the right edge in Leaks Viewer

        Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
        because filenames/line numbers are right next to function names

        Reviewed by Andreas Kling.

        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
        (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
        function name. Use the filename as the profile node's URL (we don't have enough info to
        compute a real URL currently) and the line number as the profile node's line number so the
        Inspector code will put them on the right side of the callstack graph.

        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
        (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
        passed here, just filenames.

        (WebInspector.linkifyURLAsNode):
        (WebInspector.linkifyResourceAsNode):
        Copied and slightly modified from inspector.js.

1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240
2011-11-16  Adam Roben  <aroben@apple.com>

        Make Leaks Viewer load builds from the new Lion Leaks bot

        Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds

        Reviewed by Andreas Kling.

        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
        (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
        SnowLeopard one.

1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257
2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>

        [EFL] Clean up the offline apps-related functions in ewk_settings.
        https://bugs.webkit.org/show_bug.cgi?id=72132

        Reviewed by Kenneth Rohde Christiansen.

        `ewk_settings_cache' and `ewk_view_setting_cache' are too common
        prefixes for code that is related only to the HTML5 app cache
        features.

        Use `ewk_settings_application_cache' and
        `ewk_view_setting_application_cache' instead.

        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
        (DumpRenderTreeChrome::resetDefaultsToConsistentValues):

1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268
2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions

        Reviewed by Tor Arne Vestbø.

        * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
        magic here where we handle all TEMPLATE = lib .pro files (except plugins).
        * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
        removes the .so.0.0.0 and just produces .so.

1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281
2011-11-16  Peter Beverloo  <peter@chromium.org>

        Explicitly include unistd.h in TestNetscapePlugIn
        https://bugs.webkit.org/show_bug.cgi?id=72385

        This is needed for the sleep() call in the indicateTestFailure method,
        which seems to be implicitly available for other platforms. This is not
        the case on Android.

        Reviewed by Steve Block.

        * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296
2011-11-16  Peter Beverloo  <peter@chromium.org>

        [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
        https://bugs.webkit.org/show_bug.cgi?id=72384

        Update to Android NDK r7, which was released last Friday. This adds
        support for RTTI and the -mimplicit-it gcc flag, which are required to
        respectively build ICU and Skia.

        Reviewed by Steve Block.

        * Scripts/update-webkit-chromium:
        * Scripts/webkitdirs.pm:
        (buildChromiumMakefile):

1297 1298 1299 1300 1301 1302 1303 1304 1305
2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>

        Unreviewed, rolling out r100266.
        http://trac.webkit.org/changeset/100266

        Broke WTR.

        * qmake/mkspecs/features/default_post.prf:

1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318
2011-11-16  Eric Seidel  <eric@webkit.org>

        check-webkit-style broken by r99773: "Could not determine the port"
        https://bugs.webkit.org/show_bug.cgi?id=72275

        Reviewed by Adam Barth.

        I will continue engaging hacks, until windows improves.

        * Scripts/webkitpy/common/host.py:
         - Host uses self.executive instead of self._executive like Port does.
         - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.

1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334
2011-11-16  Eric Seidel  <eric@webkit.org>

        check-webkit-style broken by r99773: "Could not determine the port"
        https://bugs.webkit.org/show_bug.cgi?id=72275

        Reviewed by Adam Barth.

        Engage windows hacks harder.

        This is a speculative fix for ChromiumWin.  We're now
        creating an SCM object much earlier, so we need to
        engage our "awesome" windows hacks earlier.

        * Scripts/webkitpy/common/host.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:

1335 1336 1337 1338 1339 1340 1341 1342 1343 1344
2011-11-15  Darin Adler  <darin@apple.com>

        DRT's uiElementAttributeValueCallback function is leaky
        https://bugs.webkit.org/show_bug.cgi?id=72453

        Reviewed by Dan Bernstein.

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.

1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371
2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>

        Implement edit-distance based reviewer recognition algorithm
        https://bugs.webkit.org/show_bug.cgi?id=72351

        Reviewed by Eric Seidel.

        Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
        its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
        Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
        "build fix" to a reviewer's name (e.g. with with edit distance 9).

        This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
        the edit distance is implemented in edit_distance.py.

        Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
        on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.

        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/checkout/changelog_unittest.py:
        * Scripts/webkitpy/common/config/committers.py:
        * Scripts/webkitpy/common/config/committers_unittest.py:
        * Scripts/webkitpy/common/editdistance.py: Added.
        * Scripts/webkitpy/common/editdistance_unittest.py: Added.
        * Scripts/webkitpy/tool/steps/validatereviewer.py:
        * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.

1372 1373 1374 1375 1376 1377
2011-11-15  Tony Chang  <tony@chromium.org>

        Skip a failing webkitpy test on cygwin.

        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401
2011-11-15  Sam Weinig  <sam@webkit.org>

        TestWebKitAPI should not put its resources in the root products directory
        https://bugs.webkit.org/show_bug.cgi?id=72446

        Reviewed by Anders Carlsson.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        Change the copy resources phase to place the resources in a TestWebKitAPI.resources
        directory.

        * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
        (TEST_F):
        * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
        (TestWebKitAPI::TEST):
        * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
        (TestWebKitAPI::DeviceScaleFactorOnBack::url):
        * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
        (TestWebKitAPI::DynamicDeviceScaleFactor::url):
        * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
        (TestWebKitAPI::Util::createURLForResource):
        Update calls to retrieve files from the bundle to look in the newly
        created subdirectory.

1402 1403 1404 1405 1406 1407
2011-11-15  Tony Chang  <tony@chromium.org>

        Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.

        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

1408 1409 1410 1411 1412 1413 1414 1415
2011-11-15  Tony Chang  <tony@chromium.org>

        Unreviewed, fix test-webkitpy tests.  Move the check for image results
        earlier.

        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

1416 1417 1418 1419 1420 1421 1422 1423 1424
2011-11-15  James Robinson  <jamesr@chromium.org>

        [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
        https://bugs.webkit.org/show_bug.cgi?id=72444

        Reviewed by Adam Barth.

        * DumpRenderTree/chromium/DumpRenderTree.cpp:

1425 1426 1427 1428 1429 1430 1431 1432 1433
2011-11-15  Tony Chang  <tony@chromium.org>

        Unreviewed, better fix for ref tests failures on SL Intel bot.
        Revert the previous change and return None if pixel results from
        either the test page or the expected page is missing.

        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465
2011-11-15  James Robinson  <jamesr@chromium.org>

        [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
        https://bugs.webkit.org/show_bug.cgi?id=72402

        Reviewed by Dirk Pranke.

        Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
        triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
        and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
        and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
        the normal compositing triggers since we currently run the compositing tests in only one configuration - with
        compositing enabled.

        Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
        patch should not impact any tests.

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (main):
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        (TestShell::resetWebSettings):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell::setAcceleratedCompositingForVideoEnabled):
        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::reset):
        (WebPreferences::applyTo):
        * DumpRenderTree/chromium/WebPreferences.h:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

1466 1467 1468 1469 1470 1471 1472
2011-11-15  Tony Chang  <tony@chromium.org>

        Unreviewed, try to fix ref tests failures on SL Intel bot.
        It looks like ImageDiff isn't returning an image diff.

        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:

1473 1474 1475 1476 1477 1478 1479
2011-11-15  Tony Chang  <tony@chromium.org>

        Unreviewed fix of ref-tests on GTK+.
        If a driver is never started, _xvfb_process is never set.

        * Scripts/webkitpy/layout_tests/port/gtk.py:

1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500
2011-11-14  Tony Chang  <tony@chromium.org>

        [NRWT] Reftests should run even when pixel tests are disabled.
        https://bugs.webkit.org/show_bug.cgi?id=60605

        Reviewed by Dirk Pranke.

        * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
            Also add an assert to make sure we get image hashes back when running ref tests.
        * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
        * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
            of starting a pixel driver if needed.  It handles the logic of sending the test
            to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.

1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514
2011-11-15  David Kilzer  <ddkilzer@apple.com>

        Don't use File::Slurp for run-leaks unit tests
        <http://webkit.org/b/72356>

        Reviewed by Daniel Bates.

        * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
        * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
        Extracted common package logic into RunLeaks.pm.  Fixed call to
        RunLeaks::parseLeaksOutput().
        * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
        * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.

1515 1516 1517 1518 1519 1520 1521 1522 1523 1524
2011-11-15  Peter Kasting  <pkasting@google.com>

        Handle svn 1.7 when detecting whether a directory is in an svn checkout.
        https://bugs.webkit.org/show_bug.cgi?id=72349

        Reviewed by Adam Roben.

        * Scripts/VCSUtils.pm:
        (isSVNDirectory):

1525 1526 1527 1528 1529 1530 1531 1532 1533
2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions

        Reviewed by Tor Arne Vestbø.

        * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
        magic here where we handle all TEMPLATE = lib .pro files.

1534 1535 1536 1537 1538 1539 1540
2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Unreviewed prospective --minimal build fix.

        * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
        and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.

1541 1542 1543 1544 1545 1546 1547 1548
2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Unreviewed --minimal build fix.

        * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
        a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
        to make moc's preprocessor abort.

1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562
2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>

        build-webkit: Accept --cmakearg to pass additional arguments to CMake.
        https://bugs.webkit.org/show_bug.cgi?id=72156

        Reviewed by Daniel Bates.

        Similar to --makearg and --qmakearg, --cmakearg lets one pass
        additional arguments to CMake (eg. --cmakearg="-DFOO=bar").

        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:
        (generateBuildSystemFromCMakeProject):

1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575
2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>

        Improve ChangeLogEntry's reviewer parsing algorithm part 2
        https://bugs.webkit.org/show_bug.cgi?id=72340

        Reviewed by Eric Seidel.

        This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
        and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.

        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/checkout/changelog_unittest.py:

1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592
2011-11-14  Eric Seidel  <eric@webkit.org>

        check-webkit-style broken by r99773: "Could not determine the port"
        https://bugs.webkit.org/show_bug.cgi?id=72275

        Reviewed by Adam Barth.

        The TestExpectationsChecker was using a generic try/except block
        which caught all exceptions, so we didn't notice that failing
        to pass a Host to PortFactory was causing an exception in port instantiation.
        I've factored out the "lookup the port" logic into a separate function
        which I've now unittested.  This should fix the bug and prevent
        others like it from occuring the the future.

        * Scripts/webkitpy/style/checkers/test_expectations.py:
        * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

1593 1594 1595 1596 1597 1598 1599 1600 1601 1602
2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>

        Add --css-grid-layout to build-webkit and the build systems
        https://bugs.webkit.org/show_bug.cgi?id=72320

        Reviewed by Ojan Vafai.

        * Scripts/build-webkit:
        Added the option.

1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614
2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r100192.
        http://trac.webkit.org/changeset/100192
        https://bugs.webkit.org/show_bug.cgi?id=72328

        Caused infinite tests to fail (Requested by abarth on
        #webkit).

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:

1615 1616 1617 1618 1619 1620 1621 1622 1623
2011-11-14  Tony Chang  <tony@chromium.org>

        Remove the CSS3_FLEXBOX compile time flag and enable on all ports
        https://bugs.webkit.org/show_bug.cgi?id=72196

        Reviewed by Ojan Vafai.

        * Scripts/build-webkit:

1624 1625 1626 1627 1628 1629 1630 1631 1632
2011-11-14  John Yani  <vanuan@gmail.com>

        new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
        Override LOCALE to en_US.

        Reviewed by Eric Seidel.

        * Scripts/webkitpy/layout_tests/port/base.py:

1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644
2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>

        [Chromium] build-webkit silently drops the features flags
        https://bugs.webkit.org/show_bug.cgi?id=72293

        Reviewed by Tony Chang.

        Chromium still ignores @features but now we give a warning!

        * Scripts/build-webkit: Check if one of the features is different
        from the default and print a warning in this case.

1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664
2011-11-14  David Kilzer  <ddkilzer@apple.com>

        run-leaks does not work on Lion?
        <http://webkit.org/b/71059>
        <rdar://problem/10428527>

        Reviewed by Adam Roben.

        The output of leaks(1) changed again in Lion to move the
        "leaks Report Version: 2.0" line from the first line of the
        output to just above the "Process " lines that run-leaks is
        interested in parsing.  This required using a more generic
        algorithm to find the start of the "Process " lines.

        * Scripts/run-leaks:
        (parseLeaksOutput): Make the code to skip headers more generic.
        * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
        * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
        * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.

1665 1666 1667 1668 1669 1670 1671 1672 1673
2011-11-14  Lei Zhang  <thestig@chromium.org>

        Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
        https://bugs.webkit.org/show_bug.cgi?id=72088

        Reviewed by Tony Chang.

        * DumpRenderTree/chromium/AccessibilityUIElement.h:

1674 1675 1676 1677 1678 1679 1680 1681 1682
2011-11-14  Andrew Scherkus  <scherkus@chromium.org>

        [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
        https://bugs.webkit.org/show_bug.cgi?id=72147

        Reviewed by Adam Barth.

        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

1683 1684 1685 1686 1687 1688 1689 1690
2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs

        Reviewed by Simon Hausmann.

        * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.

1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702
2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Disable plugins on X11 for WK2

        Reviewed by Kenneth Rohde Christiansen.

        Currently plugins are in-process and they crash in the likely case of
        a plugin installation that uses Qt 4, which beautifully clashes with the
        Qt 5 based QtWebProcess.

        * qmake/mkspecs/features/features.prf:

1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718
2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        [Qt] Add support for config tests for Qt 5

        This allows us to build and run configure-tests at build
        time to determine if a given platform feature is available.

        Reviewed by Simon Hausmann.

        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:
        (qtFeatureDefaults):
        * qmake/configure.pro: Added.
        * qmake/mkspecs/features/features.prf:
        * qmake/sync.profile: Added.

1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739
2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>

        [Qt] Remove the QStyle dependency in Qt's mobile theme
        https://bugs.webkit.org/show_bug.cgi?id=67773

        This refactoring splits up RenderThemeQt with two
        subclasses, a QStyle-backed one, and a Mobile version
        that uses the old mobile theme for now.

        QStyle availability is detected at compile time, and
        its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
        environment variable.

        Reviewed by Simon Hausmann.

        * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
        (WTR::activateFonts):
        * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
        based on availability of QtWidgets.
        * qmake/mkspecs/features/webcore.prf: cleanup.

1740 1741 1742 1743 1744 1745 1746 1747 1748
2011-11-14  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed, rolling out r100116.
        http://trac.webkit.org/changeset/100116

        r100104 was rolled out, so no longer needed

        * Scripts/run-bindings-tests:

1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774
2011-11-14  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed, rolling out r100104.
        http://trac.webkit.org/changeset/100104
        https://bugs.webkit.org/show_bug.cgi?id=72247

        broke windows builds

        * Scripts/check-webkit-style:
        * Scripts/webkitpy/common/checkout/checkout_unittest.py:
        * Scripts/webkitpy/common/checkout/deps.py:
        * Scripts/webkitpy/common/checkout/scm/__init__.py:
        * Scripts/webkitpy/common/checkout/scm/detection.py:
        * Scripts/webkitpy/common/checkout/scm/git.py:
        * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
        * Scripts/webkitpy/common/checkout/scm/svn.py:
        * Scripts/webkitpy/common/host.py:
        * Scripts/webkitpy/common/host_mock.py:
        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/mock_drt.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/tool/servers/rebaselineserver.py:

1775 1776 1777 1778 1779 1780
2011-11-14  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, build fix after r100104. run-binding-tests broke.

        * Scripts/run-bindings-tests: Explicitely use scm.detection.

1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815
2011-11-13  Eric Seidel  <eric@webkit.org>

        Add SCMDetector object to make scm detection mockable
        https://bugs.webkit.org/show_bug.cgi?id=72247

        Reviewed by Adam Barth.

        I think SCM detection may eventually be rolled into Checkout,
        but this patch at least makes it possible to mock code-paths
        which rely on scm detection.
        In the process of replacing callers of these free-functions
        I found that one of the functions was no longer used,
        and that one of the callers could instead just use the SCM
        object it already had access to through port.host.scm().
        I also discovered that I was not calling Host._initialize_scm()
        and thus host.scm() was always returning None!

        * Scripts/check-webkit-style:
        * Scripts/webkitpy/common/checkout/checkout_unittest.py:
        * Scripts/webkitpy/common/checkout/deps.py:
        * Scripts/webkitpy/common/checkout/scm/__init__.py:
        * Scripts/webkitpy/common/checkout/scm/detection.py:
        * Scripts/webkitpy/common/checkout/scm/git.py:
        * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
        * Scripts/webkitpy/common/checkout/scm/svn.py:
        * Scripts/webkitpy/common/host.py:
        * Scripts/webkitpy/common/host_mock.py:
        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/mock_drt.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/tool/servers/rebaselineserver.py:

1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828
2011-11-13  Gavin Peters  <gavinp@chromium.org>

        command line control of webcore log channels in chromium DumpRenderTree
        https://bugs.webkit.org/show_bug.cgi?id=72126
        
        The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
        what chromium takes.

        Reviewed by Kent Tamura.

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (main):

1829 1830 1831 1832 1833 1834 1835 1836 1837
2011-11-12  Ariya Hidayat  <ariya@sencha.com>

        [Qt] Fix minor config typo in the build tool documentation
        https://bugs.webkit.org/show_bug.cgi?id=72194

        Reviewed by Andreas Kling.

        * qmake/README:

1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855
2011-11-11  Stephen Chenney  <schenney@chromium.org>

        [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
        https://bugs.webkit.org/show_bug.cgi?id=49257

        Adds the remaining missing layout test functionality for printing.

        Reviewed by Darin Fisher.

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController): Add bindings for new JS methods
        (parsePageNumber): Method to parse JS arguments for a page number
        (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
        (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
        (LayoutTestController::isPageBoxVisible): get the visibility status for printing
        (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
        * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods

1856 1857 1858 1859 1860 1861 1862 1863 1864 1865
2011-11-11  Darin Adler  <darin@apple.com>

        Remove all releaseRef implementations except for RetainPtr
        https://bugs.webkit.org/show_bug.cgi?id=71423

        Reviewed by Julien Chaffraix.

        * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
        (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.

1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880
2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>

        Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
        https://bugs.webkit.org/show_bug.cgi?id=72090

        Reviewed by Eric Seidel.

        Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
        ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.

        yay! r100002.

        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/checkout/changelog_unittest.py:

1881 1882 1883 1884 1885 1886 1887
2011-11-11  Tony Chang  <tony@chromium.org>

        Remove --force from gclient sync.  The bots seem to have made it past
        the update step.

        * Scripts/update-webkit:

1888 1889 1890 1891 1892 1893 1894
2011-11-11  Tony Chang  <tony@chromium.org>

        Add --force to gclient sync. Once the cq bots cycle, we can remove
        this since it slows down the normal sync.

        * Scripts/update-webkit:

1895 1896 1897 1898 1899 1900 1901 1902 1903
2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>

        When --force is used, also use --reset
        https://bugs.webkit.org/show_bug.cgi?id=72129

        Reviewed by Dimitri Glazkov.

        * Scripts/update-webkit-chromium:

1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918
2011-11-11  Tony Chang  <tony@chromium.org>

        allow two chromium drivers to run at the same time in NRWT
        https://bugs.webkit.org/show_bug.cgi?id=72067

        Reviewed by Dirk Pranke.

        * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
            posix prevents the subprocesses from sharing the same fd for stdin.
            Sharing the same fd prevents us from closing the files unless all references
            to the fd are closed.
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
            to adding a test for this, speed up a test (from 3sec to 0) by fixing
            the timeout override. It looks like it regressed in r95875.

1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931
2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r99964.
        http://trac.webkit.org/changeset/99964
        https://bugs.webkit.org/show_bug.cgi?id=72124

        Broke too many Qt tests (Requested by tronical_ on #webkit).

        * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
        (WTR::activateFonts):
        * qmake/mkspecs/features/features.prf:
        * qmake/mkspecs/features/webcore.prf:

1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952
2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>

        [Qt] Remove the QStyle dependency in Qt's mobile theme
        https://bugs.webkit.org/show_bug.cgi?id=67773

        This refactoring splits up RenderThemeQt with two
        subclasses, a QStyle-backed one, and a Mobile version
        that uses the old mobile theme for now.

        QStyle availability is detected at compile time, and
        its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
        environment variable.

        Reviewed by Simon Hausmann.

        * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
        (WTR::activateFonts):
        * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
        based on availability of QtWidgets.
        * qmake/mkspecs/features/webcore.prf: cleanup.

1953 1954 1955 1956 1957 1958 1959 1960
2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        [Qt] Add missing include to PlatformWebViewQt

        Reviewed by Simon Hausmann.

        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:

1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982
2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        [Qt] Fix incremental builds on Windows after buildsystem refactor

        The qmake rules to ensure that we run make on the derived sources
        before running qmake on the target were inside a unix-scope, which
        resulted in flakey builds on Windows.

        We now generate a rule on all platforms that ensures that "make qmake"
        will always run make on the derived sources. In addition, on platforms
        that have GNU make (where "make incremental" does not run "make qmake",
        but only "make"), we add a similar rule that ensures that any time the
        target makefile is regenerated we first run qmake and make on the derived
        sources. This rule relies on GNU make's order-only-prerequisites to
        not trigger a qmake-run of the target every time we run make.

        https://bugs.webkit.org/show_bug.cgi?id=71778

        Reviewed by Simon Hausmann.

        * qmake/mkspecs/features/functions.prf:

1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995
2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt][WK2] Remove QWebNavigationController
        https://bugs.webkit.org/show_bug.cgi?id=72113

        Reviewed by Andreas Kling.

        Adapt to the move of the QWebNavigationController functions/properties to
        QQuickWebView.

        * MiniBrowser/qt/MiniBrowserApplication.cpp:
        * MiniBrowser/qt/qml/BrowserWindow.qml:

hausmann@webkit.org's avatar
hausmann@webkit.org committed
1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006
2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Build system tweak

        Reviewed by Tor Arne Vestbø.

        Be a good qmake citizen, return true from our linkStaticLibrary
        "test" function.

        * qmake/mkspecs/features/functions.prf:

2007 2008 2009 2010 2011 2012 2013 2014
2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Add support for QT += webkit-private

        Reviewed by Tor Arne Vestbø.

        * qmake/qt_webkit.pri: Declare private headers.

2015 2016 2017 2018 2019 2020 2021
2011-11-11  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, build fix attempt after r99907. Since that revision
        GTK layout tests were not running at all...

        * Scripts/webkitpy/layout_tests/port/gtk.py:

2022 2023 2024 2025 2026 2027 2028 2029 2030
2011-11-10  Andrew Scherkus  <scherkus@chromium.org>

        [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=72001

        Reviewed by Dirk Pranke.

        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064
2011-11-05  Filip Pizlo  <fpizlo@apple.com>

        bencher script should support remote benchmarking
        https://bugs.webkit.org/show_bug.cgi?id=71618

        Rubber-stamped by Geoff Garen.
        
        Added the following features:
        
        - Benchmark report tells you the hostname and machine model (according to
          'sysctl hw.model') of the machine you did the run on, and svn revision number
          (according to 'svn info') of the VMs you're testing.
        
        - The --remote option. You give this an ssh-style hostname (i.e. user@host is
          acceptable, in addition to just host, in which case your username is used)
          and it automatically packages the build directories of the VMs you're testing,
          sends them to the remote machine along with your copy of the bencher script
          and all of the options you passed.  This pretty much seamlessly allows you
          to run a set of benchmarks on any machine that is sufficiently compatible with
          yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
          must now include a tempPath setting that tells bencher where to put files
          when that machine is used as a slave in a remote benchmarking run.
          
        - Added yet another way of specifying which benchmarks to run. This was sort of
          necessary for --remote to work as expected. Previously, you either said what
          suites to exclude (for example --exclude-sunspider) or that you only wanted
          to run one suite to the exclusion of others (--sunspider-only). But it's
          often better to just be able to specify the list of suites you want. This is
          now supported. You can say, for example, --v8 --sunspider, which means, just
          run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
          still supported.

        * Scripts/bencher:

2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079
2011-11-10  Tony Chang  <tony@chromium.org>

        Lazily start DRT instances in NRWT
        https://bugs.webkit.org/show_bug.cgi?id=72038

        Reviewed by Eric Seidel.

        Just a refactoring, no new tests.

        * Scripts/webkitpy/layout_tests/controllers/worker.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091
2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>

        ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
        https://bugs.webkit.org/show_bug.cgi?id=72057

        Reviewed by Eric Seidel.

        Make the regular expression more explicit.

        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/checkout/changelog_unittest.py:

2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107
2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>

        [Qt] X11 plugins need to be reworked for Qt5
        https://bugs.webkit.org/show_bug.cgi?id=70023

        Reviewed by Simon Hausmann.

        Rework our basic plugin support in a way that does
        not need a bridge between Qt and X. The solution is
        based on getting the content drawed by the plugin
        from the server as an image and creating a QImage
        from it.

        * qmake/mkspecs/features/features.prf: Enable X11
        plugins if Qt is built with the xcb-xlib backend.

2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119
2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Fix keyboard related layout tests after API refactoring

        Reviewed by Tor Arne Vestbø.

        Send key events to the handling page item, not the view.

        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
        (WTR::PlatformWebView::sendEvent):
        (WTR::PlatformWebView::postEvent):

2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130
2011-11-10  Alexandre Mazari  <amazari@igalia.com>

        [GTK] Make the ENABLE(FEATURE) macro work in DRT
        https://bugs.webkit.org/show_bug.cgi?id=71940

        Reviewed by Philippe Normand.

        * GNUmakefile.am:
        Add webcore_cppflags to Programs_DumpRenderTree_CPP so
        ENABLE_* variables are part of the environment.

2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143
2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Fix focus related layout tests after API refactoring

        Reviewed by Tor Arne Vestbø.

        Make sure the focus is set on the page now, not on the view
        (which doesn't actually handle the focus).

        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
        (WTR::WrapperWindow::WrapperWindow):
        (WTR::WrapperWindow::handleStatusChanged):

2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167
2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>

        [Qt] Merge QTouchWebView and QDesktopWebView into one class
        https://bugs.webkit.org/show_bug.cgi?id=71355

        Reviewed by Kenneth Rohde Christiansen.

        Make MiniBrowser and WebKitTestRunner work again after the
        merge.

        * MiniBrowser/qt/BrowserWindow.cpp:
        (BrowserWindow::BrowserWindow):
        (BrowserWindow::webView):
        * MiniBrowser/qt/MiniBrowser.pro:
        * MiniBrowser/qt/MiniBrowser.qrc:
        * MiniBrowser/qt/MiniBrowserApplication.cpp:
        * MiniBrowser/qt/main.cpp:
        * MiniBrowser/qt/qml/BrowserWindow.qml:
        * MiniBrowser/qt/qml/DesktopView.qml: Removed.
        * MiniBrowser/qt/qml/TouchView.qml: Removed.
        * WebKitTestRunner/PlatformWebView.h:
        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
        (WTR::PlatformWebView::PlatformWebView):

2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183
2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        [Qt] Change semantics of the haveQt() function to match API promises

        Having Qt 5 does not imply that we have Qt 4, from an API point of
        view, as a major version can in theory break BC/SC. Our minimum
        version of Qt 4 will always be the latest released version of Qt 4,
        so the only place we should use haveQt(4, x) is when checking for
        the minimum requirements.

        Reviewed by Simon Hausmann.

        * qmake/mkspecs/features/default_pre.prf:
        * qmake/mkspecs/features/features.prf:
        * qmake/mkspecs/features/functions.prf:

sergio@webkit.org's avatar
sergio@webkit.org committed
2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213
2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>

        [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
        https://bugs.webkit.org/show_bug.cgi?id=69411

        Reviewed by Martin Robinson.

        * WebKitTestRunner/EventSenderProxy.h:
        * WebKitTestRunner/InjectedBundle/EventSendingController.h:
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
        use the EventSender instead of WebProcess Event Simulation.
        * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
        (WTR::WTREventQueueItem::WTREventQueueItem):
        (WTR::EventSenderProxy::EventSenderProxy):
        (WTR::getMouseButtonModifiers):
        (WTR::eventSenderButtonToGDKButton):
        (WTR::EventSenderProxy::createMouseButtonEvent):
        (WTR::EventSenderProxy::updateClickCountForButton):
        (WTR::EventSenderProxy::replaySavedEvents):
        (WTR::EventSenderProxy::sendOrQueueEvent):
        (WTR::webkitModifiersToGDKModifiers):
        (WTR::getGDKKeySymForKeyRef):
        (WTR::EventSenderProxy::keyDown):
        (WTR::EventSenderProxy::mouseDown):
        (WTR::EventSenderProxy::mouseUp):
        (WTR::EventSenderProxy::mouseMoveTo):
        (WTR::EventSenderProxy::mouseScrollBy):
        (WTR::EventSenderProxy::leapForward):

2214 2215 2216 2217 2218 2219 2220 2221 2222 2223
2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Enable exports and constructor functions in static libs

        Reviewed by Tor Arne Vestbø.

        * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
        mac/win32-msvc equivalents when linking static libraries into a shared
        library or executable.

2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236
2011-11-09  Hayato Ito  <hayato@chromium.org>

        [NRWT] Make results.html aware of reference filename in reftests.
        https://bugs.webkit.org/show_bug.cgi?id=71574

        Reviewed by Ryosuke Niwa.

        If a reference filename is different from the default one, include that in result summary
        so results.html can link to the correct reference file.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248
2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>

        [wx] Unreviewed build fix. Update project files and
        add LTC stubs for new methods.

        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::addChromeInputField):
        (LayoutTestController::removeChromeInputField):
        (LayoutTestController::focusWebView):
        (LayoutTestController::setBackingScaleFactor):
        * waf/build/settings.py:

2249 2250 2251 2252 2253 2254
2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>

        [wx] Unreviewed build fix. Support XCode 4 when building deps.

        * wx/install-unix-extras:

2255 2256 2257 2258 2259 2260 2261 2262 2263
2011-11-09  Eric Seidel  <eric@webkit.org>

        Remove the concept of platform-dependent unittests
        https://bugs.webkit.org/show_bug.cgi?id=71963

        Unreviewed.  Fix test-webkitpy on cygwin.

        * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275
2011-11-09  Dana Jansens  <danakj@chromium.org>

        Add cc-bugs group to watch changes in chromium graphics
        https://bugs.webkit.org/show_bug.cgi?id=71690

        Reviewed by David Levin.

        * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
        * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
        * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
        * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.

2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290
2011-11-09  Eric Seidel  <eric@webkit.org>

        Remove more platform-dependent unittests
        https://bugs.webkit.org/show_bug.cgi?id=71971

        Reviewed by Adam Barth.

        Tests which only run on a couple platforms will break.
        All tests should run on all platforms where possible.

        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
        * Scripts/webkitpy/layout_tests/port/config_unittest.py:
        * Scripts/webkitpy/layout_tests/port/factory_unittest.py:

2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305
2011-11-09  Ojan Vafai  <ojan@chromium.org>

        Merge in results to the test results server even if build numbers conflict
        https://bugs.webkit.org/show_bug.cgi?id=71967

        Reviewed by Tony Chang.

        This was initially meant to be a sanity check that we don't
        enter duplicate runs, but it turns out that we can reasonably get
        in these situations when a builder is clobbered (e.g. the build
        numbers start over again from 0).

        * TestResultServer/model/jsonresults.py:
        * TestResultServer/model/jsonresults_unittest.py:

2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337
2011-11-09  Eric Seidel  <eric@webkit.org>

        Remove the concept of platform-dependent unittests
        https://bugs.webkit.org/show_bug.cgi?id=71963

        Reviewed by Adam Barth.

        These have been the source of never-ending sadness.
        We'd change behavior and forget to update results in
        some unittests because they were only run on certain platforms.
        This change removes a large source of these platform-dependent
        unittests, which was caused by the port_maker stuff.

        It's possible that this change will break test-webkitpy
        on some platforms, but that will be a one-time cost.
        I will fix the breakage by removing the platform-dependantness
        of any such broken tests.

        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
        * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
        * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
        * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
        * Scripts/webkitpy/layout_tests/port/win_unittest.py: