ChangeLog 751 KB
Newer Older
antti@apple.com's avatar
antti@apple.com committed
1
2
3
4
5
6
7
8
2011-01-25  Antti Koivisto  <antti@apple.com>

        Not reviewed.
        
        Try to fix windows build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
2011-01-25  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver Hunt.

        REGRESSION: Leak in JSParser::Scope::copyCapturedVariablesToVector()
        https://bugs.webkit.org/show_bug.cgi?id=53061
         
        Cache did not know about the subclass so failed to fully delete the items. 
        Got rid of the subclass and moved the classes to separate files.

        * CMakeLists.txt:
        * GNUmakefile.am:
        * JavaScriptCore.exp:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * parser/JSParser.cpp:
        (JSC::JSParser::Scope::saveFunctionInfo):
        (JSC::JSParser::Scope::restoreFunctionInfo):
        (JSC::JSParser::findCachedFunctionInfo):
        (JSC::JSParser::parseFunctionInfo):
        * parser/SourceProvider.h:
        * parser/SourceProviderCache.cpp: Added.
        (JSC::SourceProviderCache::~SourceProviderCache):
        (JSC::SourceProviderCache::byteSize):
        * parser/SourceProviderCache.h: Added.
        (JSC::SourceProviderCache::SourceProviderCache):
        (JSC::SourceProviderCache::add):
        (JSC::SourceProviderCache::get):
        * parser/SourceProviderCacheItem.h: Added.
        (JSC::SourceProviderCacheItem::SourceProviderCacheItem):
        (JSC::SourceProviderCacheItem::approximateByteSize):
        (JSC::SourceProviderCacheItem::closeBraceToken):

44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
2011-01-25  Marcilio Mendonca  <mamendonca@rim.com>

        Reviewed by Darin Adler.

        Bug 53087: Refactoring: replaced a hanging "else" with a "return"
        statement
        https://bugs.webkit.org/show_bug.cgi?id=53087.

        Refactoring work: Replaced a hanging "else" within an #if PLATFORM(M
        with a "return" so that the code is more readable and less error pro
        (e.g., "else" doesn't use braces so adding extra lines to the else
        block won't have any effect; even worse, code still compiles
        successfully.

        * wtf/Assertions.cpp:

60
61
62
63
64
65
66
67
68
2011-01-24  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Eric Seidel.

        Change ENABLE_3D_CANVAS to ENABLE_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=53041

        * Configurations/FeatureDefines.xcconfig:

69
70
71
72
73
74
2011-01-25  Adam Roben  <aroben@apple.com>

        Windows Production build fix

        * JavaScriptCore.vcproj/JavaScriptCore.make: Added a missing "set".

75
76
77
78
79
80
81
82
83
2011-01-25  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Add missing defines for COMPILER(RVCT) && CPU(ARM_THUMB2)
        https://bugs.webkit.org/show_bug.cgi?id=52949

        * jit/JITStubs.cpp:

84
85
86
87
88
89
2011-01-24  Adam Roben  <aroben@apple.com>

        Windows Production build fix

        * JavaScriptCore.vcproj/JavaScriptCore.make: Update for move of JavaScriptCore into Source.

90
91
92
93
94
95
96
97
98
99
100
101
102
2011-01-24  Peter Varga  <pvarga@webkit.org>

        Reviewed by Oliver Hunt.

        Optimize regex patterns which contain empty alternatives
        https://bugs.webkit.org/show_bug.cgi?id=51395

        Eliminate the empty alternatives from the regex pattern and convert it to do
        the matching in an easier way.

        * yarr/YarrPattern.cpp:
        (JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):

103
104
105
106
107
108
109
110
111
112
113
2011-01-24  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Move project files into Source
        https://bugs.webkit.org/show_bug.cgi?id=52891

        * JavaScriptCore.pri:
        * JavaScriptCore.pro:
        * jsc.pro:

mrowe@apple.com's avatar
mrowe@apple.com committed
114
115
116
117
118
119
120
121
122
123
124
125
2011-01-23  Mark Rowe  <mrowe@apple.com>

        Follow-up to r76477.

        Fix the scripts that detect problematic code such as static initializers
        and destructors, weak vtables, inappropriate files in the framework wrappers,
        and public headers including private headers. These had all been broken
        since the projects were moved in to the Source directory as the paths to the
        scripts were not updated at that time.

        * JavaScriptCore.xcodeproj/project.pbxproj:

126
127
128
129
130
131
132
133
134
135
136
137
138
2011-01-23  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Use WTF::StringHasher in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=52934

        Add an additional function to calculate the hash
        of data with a runtimedependent size.

        * wtf/StringHasher.h:
        (WTF::StringHasher::createBlobHash):

139
140
141
142
143
144
145
146
147
148
2011-01-23  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by David Kilzer.

        Fix comment in String::ascii()
        https://bugs.webkit.org/show_bug.cgi?id=52980

        * wtf/text/WTFString.cpp:
        (WTF::String::ascii):

149
150
151
152
153
154
155
156
157
158
159
2011-01-23  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by David Kilzer.

        Add String::containsOnlyLatin1()
        https://bugs.webkit.org/show_bug.cgi?id=52979

        * wtf/text/WTFString.h:
        (WTF::String::containsOnlyLatin1):
        (WTF::charactersAreAllLatin1):

160
161
162
163
164
165
166
167
168
169
170
171
2011-01-23  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Oliver Hunt.

        Remove obsolete JSVALUE32 code
        https://bugs.webkit.org/show_bug.cgi?id=52948

        r70111 removed support for JSVALUE32.
        ARM, MIPS and X86 support JSVALUE32_64 only.

        * jit/JITStubs.cpp:

172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
2011-01-22  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Dan Bernstein.

        ASSERT running run-webkit-tests --threaded.
        https://bugs.webkit.org/show_bug.cgi?id=52971
        
        SunSpider and v8 report no change.

        * runtime/ConservativeSet.cpp:
        (JSC::ConservativeSet::grow):
        (JSC::ConservativeSet::add):
        * runtime/ConservativeSet.h: Tweaked the inline capacity to 128, and
        the growth policy to 2X, to make SunSpider and v8 happy.
        (JSC::ConservativeSet::ConservativeSet):
        (JSC::ConservativeSet::~ConservativeSet):
        (JSC::ConservativeSet::mark): Use OSAllocator directly, instead of malloc.
        Malloc is forbidden during a multi-threaded mark phase because it can
        cause deadlock.

192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
2011-01-22  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Geoffrey Garen.

        Rubber-stamped by Maciej Stachowiak.

        A few of Maciej's review suggestions for my last patch.
        https://bugs.webkit.org/show_bug.cgi?id=52946        

        SunSpider reports no change.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj: Updated build systems.

        * runtime/ConservativeSet.cpp: Added.
        (JSC::isPointerAligned):
        (JSC::ConservativeSet::add):
        * runtime/ConservativeSet.h: Added.
        (JSC::ConservativeSet::ConservativeSet):
        (JSC::ConservativeSet::mark): Split ConservativeSet out into its own
        file, and moved the conservative check into ConservativeSet::add, making
        ConservativeSet's responsibility clearer.

        * runtime/Heap.cpp:
        (JSC::Heap::markRoots):
        * runtime/MachineStackMarker.cpp:
        (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
        (JSC::MachineStackMarker::markOtherThreadConservatively):
        * runtime/MachineStackMarker.h:
        * runtime/MarkStack.h: Updated for changes above.

228
229
230
231
232
233
234
2011-01-22  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r76430.

        * runtime/MachineStackMarker.cpp:
        (JSC::swapIfBackwards):

235
236
237
238
239
240
241
242
243
244
245
246
2011-01-21  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Beth Dakin.

        Reorganized MarkedSpace, making many of its functions private.

        * runtime/JSCell.h:
        (JSC::JSCell::Heap::heap):
        * runtime/MarkedSpace.h:
        (JSC::MarkedSpace::globalData):
        (JSC::MarkedSpace::heap):

247
248
249
250
251
252
253
2011-01-21  Geoffrey Garen  <ggaren@apple.com>

        Try to fix build: moved helper function out of #ifdef.

        * runtime/MachineStackMarker.cpp:
        (JSC::swapIfBackwards):

254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
2011-01-21  Geoffrey Garen  <ggaren@apple.com>

        Rubber-stamped by Maciej Stachowiak.

        A few of Maciej's review suggestions for my last patch.
        https://bugs.webkit.org/show_bug.cgi?id=52946        

        SunSpider reports no change.

        * runtime/MachineStackMarker.cpp:
        (JSC::swapIfBackwards): Added a helper function for handling platforms
        where the stack can grow in any direction.

        (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
        (JSC::MachineStackMarker::markOtherThreadConservatively): Use the helper
        function.

        (JSC::isPointerAligned): Use "!" instead of "==0" because a robot told me to.

        (JSC::MachineStackMarker::markConservatively): Changed to use a more
        standard looping idiom, and to use the helper function above.

        * runtime/MarkedSpace.h:
        (JSC::MarkedSpace::isCellAligned): Use "!" instead of "==0" because a robot told me to.

279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
2011-01-21  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.

        Cleaned up some conservative marking code.
        https://bugs.webkit.org/show_bug.cgi?id=52946
        
        SunSpider reports no change.

        * interpreter/RegisterFile.h: No need for a special marking function,
        since we already expose a start() and end().

        * runtime/Heap.cpp:
        (JSC::Heap::registerFile):
        (JSC::Heap::markRoots):
        * runtime/Heap.h:
        (JSC::Heap::contains): Migrated markConservatively() to the machine stack
        marker class. Now, Heap just provides a contains() function, which the
        machine stack marker uses for checking whether a pointer points into the heap.

        * runtime/MachineStackMarker.cpp:
        (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
        (JSC::MachineStackMarker::markOtherThreadConservatively):
        (JSC::isPointerAligned):
        (JSC::MachineStackMarker::markConservatively):
        * runtime/MachineStackMarker.h: Move the conservative marking code here.

        * runtime/MarkStack.h:
        (JSC::ConservativeSet::add):
        (JSC::ConservativeSet::mark): Changed to using a vector instead of hash
        set. Vector seems to be a bit faster, and it generates smaller code.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::containsSlowCase):
        * runtime/MarkedSpace.h:
        (JSC::MarkedSpace::isCellAligned):
        (JSC::MarkedSpace::isPossibleCell):
        (JSC::MarkedSpace::contains): Kept the code for determining whether a
        pointer pointed into marked space, and moved the code for marking
        a set of conservative pointers into the machine stack marker.

        * wtf/HashSet.h:
        (WTF::::add): Added two missing inlines that I noticed while testing
        vector vs hash set.

324
325
326
327
328
329
330
331
332
333
334
335
2011-01-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig.

        Work around a Clang bug <rdar://problem/8876150> that leads to it incorrectly emitting an access
        control warning when a client tries to use operator bool exposed above via "using PageBlock::operator bool".

        * wtf/PageAllocation.h:
        (WTF::PageAllocation::operator bool):
        * wtf/PageReservation.h:
        (WTF::PageReservation::operator bool):

336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
2011-01-21  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        [RegexFuzz] Hang with forward assertion
        https://bugs.webkit.org/show_bug.cgi?id=52825
        <rdar://problem/8894332>

        The backtrackTo label from the first term in a list of terms is
        being overwritten by processing of subsequent terms.  Changed
        copyBacktrackToLabel() to check for an existing bcaktrackTo label
        before copying and renamed it to propagateBacktrackToLabel() since
        it no longer copies.

        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::BacktrackDestination::propagateBacktrackToLabel):
        (JSC::Yarr::YarrGenerator::generateParenthesesSingle):

354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
2011-01-21  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Moved the mark stack from global data to the heap, since it pertains
        to the heap, and not the virtual machine as a whole.
        https://bugs.webkit.org/show_bug.cgi?id=52930
        
        SunSpider reports no change.

        * runtime/Heap.cpp:
        (JSC::Heap::Heap):
        (JSC::Heap::markRoots):
        * runtime/Heap.h:
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        * runtime/JSGlobalData.h:

372
373
374
375
376
377
378
379
380
381
382
383
2011-01-21  Peter Gal  <galpeter@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        REGRESSION(r76177): All JavaScriptCore tests fail on ARM
        https://bugs.webkit.org/show_bug.cgi?id=52814

        Get the approximateByteSize value before releasing the OwnPtr.

        * parser/JSParser.cpp:
        (JSC::JSParser::parseFunctionInfo):

384
385
386
387
388
389
390
391
392
2011-01-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Remove unnecessary <stdio.h> include
        https://bugs.webkit.org/show_bug.cgi?id=52884

        * jit/JIT.cpp: remove unnecessary include.

393
394
395
396
397
398
399
400
2011-01-20  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Maciej Stachowiak.

        Added OwnPtrCommon.h because OwnArrayPtr::set calls deleteOwnedPtr.

        * wtf/OwnArrayPtr.h:

401
402
403
404
405
406
407
408
409
410
411
412
413
2011-01-20  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Oliver Hunt.

        [WINCE] Remove obsolete JSVALUE32 code
        https://bugs.webkit.org/show_bug.cgi?id=52450

        Remove the "offset hack" in create_jit_stubs, since we
        only support JSVALUE32_64 in the meantime.

        * create_jit_stubs: Removed offset argument
        * jit/JITStubs.cpp:

414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
2011-01-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        When marking conservatively, guard against reviving dead objects.
        https://bugs.webkit.org/show_bug.cgi?id=52840
        
        SunSpider and v8 say no change.

        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::markCallFrames): Updated to use the ConservativeSet API.

        * runtime/Heap.cpp:
        (JSC::Heap::recordExtraCost): No need to guard against conservative
        marking reviving dead objects anymore, since the conservative marking
        mechanism guards against this now.

        (JSC::Heap::markConservatively):
        (JSC::Heap::markProtectedObjects):
        (JSC::Heap::markTempSortVectors): Don't drain the mark stack inside a
        marking function. We want to establish a separation of concerns between
        visiting roots and draining the mark stack.

        (JSC::Heap::markRoots): Gather the set of conservative references before
        clearning mark bits, because conservative marking now uses the mark bits
        to determine if a reference is valid, and avoid reviving dead objects.

        (JSC::Heap::collectAllGarbage): No need to guard against conservative
        marking reviving dead objects anymore, since the conservative marking
        mechanism guards against this now.

        * runtime/Heap.h: Updated to use the ConservativeSet API.

        * runtime/MachineStackMarker.cpp:
        (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
        (JSC::MachineStackMarker::markCurrentThreadConservatively):
        (JSC::MachineStackMarker::markOtherThreadConservatively):
        (JSC::MachineStackMarker::markMachineStackConservatively):
        * runtime/MachineStackMarker.h: Ditto.

        * runtime/MarkStack.h:
        (JSC::ConservativeSet::add):
        (JSC::ConservativeSet::mark): Added ConservativeSet, for gathering the
        set of conservative references. This is different from MarkStack, since
        we don't mark the set until it is completely gathered.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::freeBlock):
        (JSC::MarkedSpace::resizeBlocks):
        (JSC::MarkedSpace::markConservatively):
        * runtime/MarkedSpace.h: When marking conservatively, guard against
        reviving dead objects.

467
468
469
470
471
472
473
474
475
476
2011-01-20  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Geoffrey Garen.

        [Symbian] Fix StackBounds::initialize()
        https://bugs.webkit.org/show_bug.cgi?id=52842

        * wtf/StackBounds.cpp:
        (WTF::StackBounds::initialize): Use TThreadStackInfo.iLimit for stack limit

477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
2011-01-20  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/8890203> [RegexFuzz] Crash in generated code (52773)
        https://bugs.webkit.org/show_bug.cgi?id=52773

        Fixed case where an existing DataLabelPtr is overwritten.  The
        replacing DataLabelPtr is now resolved immediately in
        linkDataLabelToBacktrackIfExists().  Cleanup - eliminated bool
        return value for the routine as it was never used.

        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):

492
493
494
495
496
497
498
499
500
501
502
2011-01-20  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][WK2] WebKit2 enabled build fails to link

        Work around undefined reference linking issues until the buildsystem gets redesigned.
        These issues first occured in minimal builds (see BUG 50519).

        * JavaScriptCore.pri: link as whole-archive for WebKit2 builds

503
504
505
506
507
508
509
510
511
512
513
514
515
2011-01-20  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Csaba Osztrogonác.

        Refactoring of the custom allocation framework
        https://bugs.webkit.org/show_bug.cgi?id=49897

        Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
        The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
        equivalent macro implementation at the necessary places.

        * wtf/FastAllocBase.h: Turn FastAllocBase's implementation into a macro.

516
517
518
519
520
521
522
523
524
525
526
527
528
2011-01-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej Stachowiak.

        Follow-up to r75766 / <rdar://problem/5469576>.

        We were failing to initialize the key, causing all sorts of unexpected behavior.

        * wtf/FastMalloc.cpp:
        (WTF::setThreadHeap):
        (WTF::TCMalloc_ThreadCache::GetThreadHeap):
        (WTF::TCMalloc_ThreadCache::InitTSD): Ensure that the key is initialized.

529
530
531
532
533
534
535
536
537
538
539
540
541
542
2011-01-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Rolled back in r76078, with crash fixed.
        https://bugs.webkit.org/show_bug.cgi?id=52668
        
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::markChildren): Account for the fact that the global
        object moves its variables into and out of the register file. While out
        of the register file, the symbol table's size is not an accurate count
        for the size of the register array, since the BytecodeGenerator might
        be compiling, adding items to the symbol table.
        
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
2011-01-18  Darin Adler  <darin@apple.com>

        Reviewed by Geoffrey Garen.

        Stack overflow when converting an Error object to string
        https://bugs.webkit.org/show_bug.cgi?id=46410

        * Android.mk: Added StringRecursionChecker.cpp and
        StringRecursionChecker.h.
        * CMakeLists.txt: Ditto.
        * GNUmakefile.am: Ditto.
        * JavaScriptCore.gypi: Ditto.
        * JavaScriptCore.pro: Ditto.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
        * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.

        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncToString): Use StringRecursionChecker instead
        of the older hand-written code to do the same thing.
        (JSC::arrayProtoFuncToLocaleString): Ditto.
        (JSC::arrayProtoFuncJoin): Ditto.

        * runtime/ErrorPrototype.cpp:
        (JSC::errorProtoFuncToString): Use StringRecursionChecker.

        * runtime/JSGlobalData.h: Renamed arrayVisitedElements to
        stringRecursionCheckVisitedObjects.

        * runtime/RegExpPrototype.cpp:
        (JSC::regExpProtoFuncToString): Use StringRecursionChecker.

        * runtime/StringRecursionChecker.cpp: Added.
        * runtime/StringRecursionChecker.h: Added.

577
578
579
580
581
582
583
584
585
586
587
588
589
590
2011-01-19  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Remove non-spec support for callable RegExp
        https://bugs.webkit.org/show_bug.cgi?id=28285

        Remove support for callable regexps.  If it breaks sites we can
        just roll this out.

        * runtime/RegExpObject.cpp:
        * runtime/RegExpObject.h:
        * tests/mozilla/expected.html: update results.

591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
2011-01-19  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver Hunt.

        Cache function offsets to speed up javascript parsing
        https://bugs.webkit.org/show_bug.cgi?id=52622
        
        Use cache to save function offsets and some other info.
        This avoids quite a bit of work when reparsing the source.

        * parser/ASTBuilder.h:
        * parser/JSParser.cpp:
        (JSC::JSParser::CachedFunctionInfo::CachedFunctionInfo):
        (JSC::JSParser::CachedFunctionInfo::approximateByteSize):
        (JSC::JSParser::CachedFunctionInfo::closeBraceToken):
        (JSC::JSParser::Scope::copyCapturedVariablesToVector):
        (JSC::JSParser::Scope::saveFunctionInfo):
        (JSC::JSParser::Scope::restoreFunctionInfo):
        (JSC::JSParser::findCachedFunctionInfo):
        (JSC::JSParser::JSParser):
        (JSC::JSParser::parseProgram):
        (JSC::JSParser::parseFunctionInfo):
        * parser/Lexer.h:
        (JSC::Lexer::setOffset):
        (JSC::Lexer::setLineNumber):
        (JSC::Lexer::sourceProvider):
        * parser/SourceProvider.h:
        (JSC::SourceProviderCache::SourceProviderCache):
        (JSC::SourceProviderCache::~SourceProviderCache):
        (JSC::SourceProviderCache::byteSize):
        (JSC::SourceProviderCache::add):
        (JSC::SourceProviderCache::get):
        (JSC::SourceProvider::SourceProvider):
        (JSC::SourceProvider::~SourceProvider):
        (JSC::SourceProvider::cache):
        (JSC::SourceProvider::notifyCacheSizeChanged):
        (JSC::SourceProvider::cacheSizeChanged):
        * parser/SyntaxChecker.h:

630
631
632
633
634
635
636
637
2011-01-19  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin Adler.

        Follow-up to r75766 / <rdar://problem/5469576>.

        * DerivedSources.make: Evaluate the SDKROOT variable correctly.

638
639
640
641
642
643
644
645
646
647
648
649
650
651
2011-01-19  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        [jsfunfuzz] Defining a function called __proto__ inside an eval triggers an assertion
        https://bugs.webkit.org/show_bug.cgi?id=52672

        Rather than coming up with a somewhat convoluted mechanism to ensure that
        developers can override the global objects prototype with a function named
        __proto__ and expect it to work, we just disallow it at the syntax level.

        * parser/JSParser.cpp:
        (JSC::JSParser::parseFunctionInfo):

652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
2011-01-19  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/8882994> Regression: Simple nested backtrack hangs
        https://bugs.webkit.org/show_bug.cgi?id=52675

        The changeset (r76076) for https://bugs.webkit.org/show_bug.cgi?id=52540
        broke simple backtracking in some cases.  Reworked that change to 
        link both jumps and labels.

        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::BacktrackDestination::hasBacktrackToLabel):
        (JSC::Yarr::YarrGenerator::TermGenerationState::propagateBacktrackingFrom):
        (JSC::Yarr::YarrGenerator::generateParenthesesSingle):

668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
2011-01-19  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [JSC] scripts have incorrect starting line (always 1).
        https://bugs.webkit.org/show_bug.cgi?id=52721

        * debugger/Debugger.cpp:
        (JSC::Debugger::recompileAllJSFunctions):
        * debugger/Debugger.h:
        * parser/Parser.h:
        (JSC::Parser::parse):
        * parser/SourceCode.h:
        (JSC::SourceCode::SourceCode):
        * parser/SourceProvider.h:
        (JSC::SourceProvider::startPosition):

685
686
687
688
689
690
691
692
693
2011-01-19  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Laszlo Gombos and Tor Arne Vestbø.

        [Qt] Remove unnecessary "../Source" from paths
        after moving source files into Source is finished.

        * JavaScriptCore.pri:

694
695
696
697
698
699
700
701
702
703
2011-01-19  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Darin Adler.

        Don't return void from void function String::split
        https://bugs.webkit.org/show_bug.cgi?id=52684

        * wtf/text/WTFString.cpp:
        (WTF::String::split):

704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
2011-01-18  Kenneth Russell  <kbr@google.com>

        Unreviewed, rolling out r76078.
        http://trac.webkit.org/changeset/76078
        https://bugs.webkit.org/show_bug.cgi?id=52668

        Caused crashes of fast/canvas/webgl/constants.html,
        fast/canvas/webgl/gl-enum-tests.html, and possibly other layout
        test crashes in Release mode. WebGL crashes were observed with
        "run-webkit-tests fast/canvas/webgl". It was necessary to run
        multiple tests to provoke the crash.

        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::markGlobals):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::markChildren):
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::markChildren):

723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
2011-01-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        [jsfunfuzz] Assertion asking activation for arguments when arguments is overridden
        https://bugs.webkit.org/show_bug.cgi?id=52690

        Clean up code to retrieve arguments from activation and function objects.
        Remove the incorrect assertion from JSActivation's argumentsGetter.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::retrieveArguments):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::argumentsGetter):

738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
2011-01-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Removed RegisterFile::markGlobals because it was obtuse, and it
        unnecessarily relied on conservative marking.
        https://bugs.webkit.org/show_bug.cgi?id=52668

        * interpreter/RegisterFile.h: Removed markGlobals.

        * runtime/JSActivation.cpp:
        (JSC::JSActivation::markChildren): Added a comment explaning why some
        JSActivations don't always mark their registers arrays.

        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::markChildren): Instead of calling markGlobals, mark
        the registers array directly.

756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
2011-01-18  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/8875432> Regression: Some text-only e-mails cause hang beneath RegExp::match (52540)
        https://bugs.webkit.org/show_bug.cgi?id=52540
        https://bugs.webkit.org/show_bug.cgi?id=52662

        Directly use backtrack label with parentheses nested under a
        non-capturing parentheses.  Also linked current parentheses
        tail code object for possible parens nested within a non-capturing
        parentheses.

        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::BacktrackDestination::linkBacktrackToLabel):
        (JSC::Yarr::YarrGenerator::generateParenthesesSingle):

773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
2011-01-18  Daniel Bates  <dbates@rim.com>

        Reviewed by Gavin Barraclough.

        Only use moving memory model assumption in ExecutableAllocator::intializePageSize() for Symbian OS
        https://bugs.webkit.org/show_bug.cgi?id=52517

        Patch by David Tapuska

        Currently, we compile code with respect to the Symbian-specific moving memory model
        assumption for all ARMv5 or lower architectures. Instead, we should only compile
        such code when building for Symbian OS on those architectures because this model
        is Symbian-specific.

        * jit/ExecutableAllocator.cpp:
        (JSC::ExecutableAllocator::intializePageSize):

790
791
792
793
794
795
796
797
798
799
800
801
802
803
2011-01-18  Dimitry Andric  <dim@freebsd.org>

        Reviewed by Andreas Kling.

        Fix linking JavaScriptCore on FreeBSD/amd64
        https://bugs.webkit.org/show_bug.cgi?id=52591

        Linking of JavaScriptCore on FreeBSD/amd64 fails, for the same reason as
        in bug 28422: cti_vm_throw needs a "@plt" suffix, otherwise the linker
        complains about the relocation type.

        * jit/JITStubs.cpp: use @plt suffix on x86_64 platforms, for both Linux
        and FreeBSD.

804
805
806
807
808
809
810
811
812
813
814
815
816
2011-01-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Antti Koivisto.

        [jsfunfuzz] Assertion in codegen for array of NaN constants
        https://bugs.webkit.org/show_bug.cgi?id=52643

        Don't cache NaN literals in the code generator, as NaN doesn't compare
        as equal to itself it causes problems when rehashing the number cache.

        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitLoad):

817
818
819
820
821
822
823
824
825
826
827
828
829
2011-01-17  Jarred Nicholls  <jarred@sencha.com>

        Reviewed by Csaba Osztrogonác.

        REGRESSION(r75709): Return value of fscanf() shouldn't be ignored.
        https://bugs.webkit.org/show_bug.cgi?id=52585
        
        gcc 4.4.4+ has warn_unused_value attribute on fscanf, so we should check
        the return value to get around the gcc warning

        * jit/ExecutableAllocatorFixedVMPool.cpp:
        (JSC::maybeModifyVMPoolSize):

830
831
832
833
834
835
836
837
838
839
840
841
842
2011-01-17  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        [regexfuzz] Crash running regex with lookahead
        https://bugs.webkit.org/show_bug.cgi?id=52548

        Eliminated agressive chaining of backtracks.  This code was overwriting
        already valid backtrack information.

        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::ParenthesesTail::processBacktracks):

843
844
845
846
847
848
849
850
851
2011-01-17  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix some headers with missing or misspelled #ifndef guards
        https://bugs.webkit.org/show_bug.cgi?id=52545

        * wtf/RefPtrHashMap.h:

852
853
854
855
856
857
858
859
2011-01-17  Dan Bernstein  <mitz@apple.com>

        Rubber-stamped by Mark Rowe.

        Update xcodeproj svn:ignore to include xcuserdata.

        * JavaScriptCore.xcodeproj: Modified property svn:ignore.

860
861
862
863
864
865
866
867
868
2011-01-16  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move WebKit into Source
        https://bugs.webkit.org/show_bug.cgi?id=52530

        * JavaScriptCore.gyp/JavaScriptCore.gyp:

869
870
871
872
873
874
875
876
877
878
879
880
881
2011-01-16  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        [jsfunfuzz] Parser doesn't correctly validate for-loop syntax
        https://bugs.webkit.org/show_bug.cgi?id=52516

        Ensure that we always check for a semicolon after encountering
        multiple declarations in the initialiser portion of a for-loop.

        * parser/JSParser.cpp:
        (JSC::JSParser::parseForStatement):

882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
2011-01-16  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Strict mode restrictions on arguments and eval usage aren't complete
        https://bugs.webkit.org/show_bug.cgi?id=52528

        Fix a few bugs in strict mode where we incorrect allow mutation of
        arguments and eval in the parser.

        Alas the "optimisation" used by the syntax checker for validating
        binary and unary expressions was too aggressive: we do actually need
        a stack for operations and operands although it needn't be as complete
        as that used for the full AST builder.

        Also disallow assignment to arguments in all cases as allowing arguments
        to be assignable is always an error in strict mode, regardless of context.

        * parser/ASTBuilder.h:
        (JSC::ASTBuilder::BinaryExprContext::BinaryExprContext):
        (JSC::ASTBuilder::UnaryExprContext::UnaryExprContext):
        * parser/JSParser.cpp:
        (JSC::JSParser::parseAssignmentExpression):
        (JSC::JSParser::parseBinaryExpression):
        (JSC::JSParser::parseUnaryExpression):
        * parser/SyntaxChecker.h:
        (JSC::SyntaxChecker::BinaryExprContext::BinaryExprContext):
        (JSC::SyntaxChecker::BinaryExprContext::~BinaryExprContext):
        (JSC::SyntaxChecker::UnaryExprContext::UnaryExprContext):
        (JSC::SyntaxChecker::UnaryExprContext::~UnaryExprContext):
        (JSC::SyntaxChecker::appendBinaryExpressionInfo):
        (JSC::SyntaxChecker::operatorStackPop):

915
916
917
918
919
920
921
922
923
924
925
926
927
928
2011-01-15  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Rolled back in r75886.
        https://bugs.webkit.org/show_bug.cgi?id=52527
        
        r75886 broke the GTK Linux bot because Linux was -- quite surprisingly --
        set up to use the constants for embedded devices.

        * jit/ExecutableAllocatorFixedVMPool.cpp:
        (JSC::maybeModifyVMPoolSize): Separated Linux constants from embedded
        constants.

929
930
931
932
933
934
935
936
937
938
2011-01-15  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r75886.
        http://trac.webkit.org/changeset/75886
        https://bugs.webkit.org/show_bug.cgi?id=52526

        "Broke GTK+ 64bit" (Requested by xan_ on #webkit).

        * jit/ExecutableAllocatorFixedVMPool.cpp:

939
940
941
942
943
944
945
946
947
2011-01-15  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/8870429> Shrink the executable pool on embedded devices

        * jit/ExecutableAllocatorFixedVMPool.cpp: Dropped the pool size from 32MB
        to 16MB.

948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
2011-01-15  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Incorrect behavior changing attributes of an accessor
        https://bugs.webkit.org/show_bug.cgi?id=52515

        defineProperty doesn't correctly handle changing attributes of an accessor
        property.  This is because we don't pass the full descriptor to the 
        putDescriptor helper function, which means we have insufficient information
        to do the right thing. Once that's passed the correct behavior is relatively
        simple to implement.

        * runtime/JSObject.cpp:
        (JSC::putDescriptor):
        (JSC::JSObject::defineOwnProperty):

965
966
967
968
969
970
971
972
973
974
975
976
977
2011-01-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        [jsfunfuzz] Incorrect handling of consecutive duplicate labels
        https://bugs.webkit.org/show_bug.cgi?id=52505

        Compare StringImpl*'s instead of Identifier*'s when looking for duplicate
        labels.

        * parser/JSParser.cpp:
        (JSC::JSParser::parseExpressionOrLabelStatement):

978
979
980
981
982
983
984
985
986
2011-01-14  Simon Fraser  <simon.fraser@apple.com>

        No review.
        
        Initialize m_operationInProgress after r75855.

        * runtime/Heap.cpp:
        (JSC::Heap::Heap):

987
988
989
990
991
992
993
2011-01-14  Geoffrey Garen  <ggaren@apple.com>

        Reverted accidentally committed code from my last checkin.

        * runtime/Heap.cpp:
        (JSC::Heap::markRoots):

ggaren@apple.com's avatar
ggaren@apple.com committed
994
995
996
997
998
999
1000
1001
1002
1003
1004
2011-01-14  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.
        
        Try to fix the GTK bot.

        * runtime/Heap.cpp:
        (JSC::Heap::Heap):
        (JSC::Heap::markRoots): Kids, remember to initialize your data members.
        Knowing is half the battle.

1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
2011-01-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Stephanie Lewis.

        [jsfunfuzz] We should be clearing the lexers temporary character buffers when switching to strict mode
        https://bugs.webkit.org/show_bug.cgi?id=52501

        Clear the temporary character buffers used for reading escaped characters and
        numbers.

        * parser/Lexer.h:
        (JSC::Lexer::setOffset):

1018
1019
1020
1021
1022
1023
2011-01-14  Geoffrey Garen  <ggaren@apple.com>

        Try to fix non-Dtrace builds: #include Tracing.h instead of TracingDtrace.h.

        * runtime/Heap.cpp:

1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
2011-01-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Split out a MarkedSpace strategy object from Heap.
        https://bugs.webkit.org/show_bug.cgi?id=52421
        
        SunSpider reports no change.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj: Updated our 7 build systems. Which is cool.

        * runtime/Heap.cpp:
        (JSC::Heap::Heap):
        (JSC::Heap::destroy):
        (JSC::Heap::recordExtraCost):
        (JSC::Heap::allocate):
        (JSC::Heap::markConservatively):
        (JSC::Heap::markRoots):
        (JSC::Heap::objectCount):
        (JSC::Heap::statistics):
        (JSC::Heap::size):
        (JSC::Heap::isBusy):
        (JSC::Heap::collectAllGarbage):
        (JSC::Heap::primaryHeapBegin):
        (JSC::Heap::primaryHeapEnd):
        * runtime/Heap.h:
        (JSC::Heap::globalData):
        (JSC::Heap::markedSpace):
        (JSC::Heap::isCellMarked):
        (JSC::Heap::checkMarkCell):
        (JSC::Heap::markCell): Moved all code pertaining to managing chunks of
        collector memory out of this class. Heap now just delegates to MarkedSpace.

        * runtime/JSCell.h:
        (JSC::JSCell::Heap::heap): Updated for MarkedSpace delegation.

        * runtime/JSValue.h: Moved the ValueStringPair typedef to help with #includes.

        * runtime/MarkedSpace.cpp: Copied from runtime/Heap.cpp.
        (JSC::MarkedSpace::MarkedSpace):
        (JSC::MarkedSpace::destroy):
        (JSC::MarkedSpace::allocateBlock):
        (JSC::MarkedSpace::freeBlock):
        (JSC::MarkedSpace::allocate):
        (JSC::MarkedSpace::resizeBlocks):
        (JSC::MarkedSpace::growBlocks):
        (JSC::MarkedSpace::shrinkBlocks):
        (JSC::MarkedSpace::markConservatively):
        (JSC::MarkedSpace::clearMarkBits):
        (JSC::MarkedSpace::markedCells):
        (JSC::MarkedSpace::sweep):
        (JSC::MarkedSpace::objectCount):
        (JSC::MarkedSpace::addToStatistics):
        (JSC::MarkedSpace::statistics):
        (JSC::MarkedSpace::size):
        (JSC::MarkedSpace::reset):
        (JSC::MarkedSpace::primaryHeapBegin):
        (JSC::MarkedSpace::primaryHeapEnd):
        * runtime/MarkedSpace.h: Copied from runtime/Heap.h.
        (JSC::MarkedSpace::globalData):
        (JSC::MarkedSpace::didShrink):
        (JSC::MarkedSpace::cellBlock):
        (JSC::MarkedSpace::cellOffset):
        (JSC::MarkedSpace::isCellMarked):
        (JSC::MarkedSpace::checkMarkCell):
        (JSC::MarkedSpace::markCell): Moved all code pertaining to managing chunks of
        collector memory into this class.

        * runtime/MemoryStatistics.cpp:
        (JSC::heapStatistics):
        * runtime/MemoryStatistics.h: Updated for MarkedSpace delegation.

1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
2011-01-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        [jsfunfuzz] parser doesn't enforce continue restrictions correctly.
        https://bugs.webkit.org/show_bug.cgi?id=52493

        This patch reworks handling of break, continue and label statements
        to correctly handle all the valid and invalid cases.  Previously certain
        errors would be missed by the parser in strict mode, but the bytecode 
        generator needed to handle those cases for non-strict code so nothing
        failed, it simply became non-standard behaviour.

        Now that we treat break and continue errors as early faults in non-strict
        mode as well that safety net has been removed so the parser bugs result in
        crashes at codegen time.

        * parser/JSParser.cpp:
        (JSC::JSParser::ScopeLabelInfo::ScopeLabelInfo):
        (JSC::JSParser::next):
        (JSC::JSParser::nextTokenIsColon):
        (JSC::JSParser::continueIsValid):
            Continue is only valid in loops so we can't use breakIsValid()
        (JSC::JSParser::pushLabel):
            We now track whether the label is for a loop (and is therefore a
            valid target for continue.
        (JSC::JSParser::popLabel):
        (JSC::JSParser::getLabel):
            Replace hasLabel with getLabel so that we can validate the target
            when parsing continue statements.
        (JSC::JSParser::Scope::continueIsValid):
        (JSC::JSParser::Scope::pushLabel):
        (JSC::JSParser::Scope::getLabel):
        (JSC::JSParser::JSParser):
        (JSC::JSParser::parseBreakStatement):
        (JSC::JSParser::parseContinueStatement):
        (JSC::LabelInfo::LabelInfo):
        (JSC::JSParser::parseExpressionOrLabelStatement):
            Consecutive labels now get handled iteratively so that we can determine
            whether they're valid targets for continue.
        * parser/Lexer.cpp:
        (JSC::Lexer::nextTokenIsColon):
        * parser/Lexer.h:
        (JSC::Lexer::setOffset):

1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
2011-01-14  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
        https://bugs.webkit.org/show_bug.cgi?id=45186

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::scheduleScavenger): Added missing this pointer to CreateTimerQueueTimer().

1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
2011-01-14  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
        https://bugs.webkit.org/show_bug.cgi?id=45186

        r75819 accidentally changed the initial state of the scavenge timer.

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::initializeScavenger): Changed initial state of m_scavengingSuspended to true.

1169
1170
1171
1172
1173
1174
1175
2011-01-14  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed Windows Release build fix.

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::scavengerTimerFired):

1176
1177
1178
1179
1180
1181
1182
2011-01-14  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed Windows Release build fix.

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::scavengerTimerFired):

1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
2011-01-14  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
        https://bugs.webkit.org/show_bug.cgi?id=45186

        Use CreateTimerQueueTimer() to start periodicScavenge() and stop it with DeleteTimerQueueTimer().

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::initializeScavenger):
        (WTF::TCMalloc_PageHeap::isScavengerSuspended):
        (WTF::TCMalloc_PageHeap::scheduleScavenger):
        (WTF::TCMalloc_PageHeap::rescheduleScavenger):
        (WTF::TCMalloc_PageHeap::suspendScavenger):
        (WTF::scavengerTimerFired):
        (WTF::TCMalloc_PageHeap::periodicScavenge):
        (WTF::TCMalloc_PageHeap::signalScavenger):

1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
2011-01-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Align import/export directives
        https://bugs.webkit.org/show_bug.cgi?id=52208

        * API/JSBase.h: Align import/export directives with
        WebKit2/Shared/API/c/WKBase.h

1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
2011-01-14  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        Incorrect backtracking for nested alternatives
        https://bugs.webkit.org/show_bug.cgi?id=52387

        In the process of propigating a datalabel it wasn't getting connected
        to a destination when the destination was an indirect jump.  Added
        code to recognize a direct backtrack destination that was an indirect
        jump and added mechanism to associate DataLabelPtrs with indirect
        jump entries.
        Removed dead method
        BacktrackDestination::linkDataLabelToHereIfExists()

        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::IndirectJumpEntry::IndirectJumpEntry):
        (JSC::Yarr::YarrGenerator::IndirectJumpEntry::addDataLabel):
        (JSC::Yarr::YarrGenerator::GenerationState::addIndirectJumpEntry):
        (JSC::Yarr::YarrGenerator::GenerationState::emitIndirectJumpTable):
        Changes to link indirect jumps with DataLabelPtr's.
        (JSC::Yarr::YarrGenerator::BacktrackDestination::clearSubDataLabelPtr):
        (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists): 
        Updated to handle immediate linking of indirect jumps to
        DataLabelPtr.
        (JSC::Yarr::YarrGenerator::generateParenthesesDisjunction): Changed to
        reflect updated linkDataLabelToBacktrackIfExists().

1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
2011-01-14  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: provide script column offset to frontend.
        https://bugs.webkit.org/show_bug.cgi?id=52377

        * parser/SourceCode.h:
        (JSC::SourceCode::SourceCode):
        (JSC::SourceCode::firstColumn):

1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
2011-01-13  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        <rdar://problem/5469576> Use __PTK_FRAMEWORK_JAVASCRIPTCORE_KEY0 if available.

        * DerivedSources.make: Create a header file, HeaderDetection.h, that tells
        us whether pthread_machdep.h is available.
        * wtf/FastMalloc.cpp: If __PTK_FRAMEWORK_JAVASCRIPTCORE_KEY0 is available, then
        don't do the pthread_getspecific_function_pointer trick.
        (WTF::setThreadHeap): Ditto, but set thread-specific data.
        (WTF::TCMalloc_ThreadCache::GetThreadHeap): Ditto, but get rather than set.

1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
2011-01-13  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gavin Barraclough.

        JIT requires VM overcommit (particularly on x86-64), Linux does not by default support this without swap?
        https://bugs.webkit.org/show_bug.cgi?id=42756

        The FixedVMPool Allocator does not work well on systems where
        allocating very large amounts of memory upfront is not reasonable,
        like Linux without overcommit enabled. As a workaround, on Linux,
        default to the values used in embedded environments (in the MB
        range), and only jump to the GB range if we detect at runtime that
        overcommit is enabled. Should fix crashes on Linux/x86_64 with
        less than 3 or 4GB of RAM.

        * jit/ExecutableAllocatorFixedVMPool.cpp:
        (JSC::FixedVMPoolAllocator::free): use new variables for VM pool
        size and coalesce limit.
        (JSC::ExecutableAllocator::isValid): swap the variables from
        embedded to generic values at runtime, on linux, if overcommit is
        enabled.
        (JSC::ExecutableAllocator::underMemoryPressure): use new variables
        for VM pool size and coalesce limit.

1288
1289
1290
1291
1292
1293
1294
1295
2011-01-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Add new Yarr.h header to the list file.

        * GNUmakefile.am: ditto.

1296
1297
1298
1299
1300
1301
1302
1303
2011-01-12  Martin Robinson  <mrobinson@igalia.com>

        Missing Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h in WebKitGtk tarball
        https://bugs.webkit.org/show_bug.cgi?id=52299

        * GNUmakefile.am: Fix the GTK+ build on ARMv7 by including missing source
        files in the source list.

1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
2011-01-12  Peter Varga  <pvarga@webkit.org>

        Reviewed by Gavin Barraclough.

        Add Yarr.h to YARR
        https://bugs.webkit.org/show_bug.cgi?id=51021

        Move other common constants and functions from YARR's different files
        to Yarr.h.
        Use Yarr.h header instead of including other YARR headers where it
        is possible.

        * JavaScriptCore.gypi:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/RegExp.cpp:
        * yarr/Yarr.h: Added.
        * yarr/YarrInterpreter.cpp:
        * yarr/YarrInterpreter.h:
        * yarr/YarrJIT.cpp:
        (JSC::Yarr::jitCompile):
        (JSC::Yarr::execute):
        * yarr/YarrJIT.h:
        * yarr/YarrParser.h:
        * yarr/YarrPattern.cpp:
        (JSC::Yarr::YarrPattern::compile):
        (JSC::Yarr::YarrPattern::YarrPattern):
        * yarr/YarrPattern.h:

1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r75595.
        http://trac.webkit.org/changeset/75595
        https://bugs.webkit.org/show_bug.cgi?id=52286

        It broke fast/regex/pcre-test-1.html (Requested by Ossy on
        #webkit).

        * JavaScriptCore.gypi:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/RegExp.cpp:
        * yarr/Yarr.h: Removed.
        * yarr/YarrInterpreter.cpp:
        * yarr/YarrInterpreter.h:
        * yarr/YarrJIT.cpp:
        (JSC::Yarr::jitCompile):
        * yarr/YarrJIT.h:
        (JSC::Yarr::execute):
        * yarr/YarrParser.h:
        * yarr/YarrPattern.cpp:
        (JSC::Yarr::compile):
        (JSC::Yarr::YarrPattern::YarrPattern):
        * yarr/YarrPattern.h:

1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
2011-01-12  Peter Varga  <pvarga@webkit.org>

        Reviewed by Gavin Barraclough.

        Add Yarr.h to YARR
        https://bugs.webkit.org/show_bug.cgi?id=51021

        Move other common constants and functions from YARR's different files
        to Yarr.h.
        Use Yarr.h header instead of including other YARR headers where it
        is possible.

        * JavaScriptCore.gypi:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/RegExp.cpp:
        * yarr/Yarr.h: Added.
        * yarr/YarrInterpreter.cpp:
        * yarr/YarrInterpreter.h:
        * yarr/YarrJIT.cpp:
        (JSC::Yarr::jitCompile):
        (JSC::Yarr::execute):
        * yarr/YarrJIT.h:
        * yarr/YarrParser.h:
        * yarr/YarrPattern.cpp:
        (JSC::Yarr::YarrPattern::compile):
        (JSC::Yarr::YarrPattern::YarrPattern):
        * yarr/YarrPattern.h:

1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
2011-01-11  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Missing call to popTempSortVector() for exception case in JSArray::sort.
        https://bugs.webkit.org/show_bug.cgi?id=50718

        Fix to patch of 50718 that added pushTempSortVector() and 
        popTempSortVector() to JSArray::sort() to mark elements during sort.
        Need to add popTempSortVector() for the return case if toString()
        had an exception.

        * runtime/JSArray.cpp:
        (JSC::JSArray::sort): Added popTempSortVector()

1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
2011-01-11  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Darin Adler.

        Microoptimization in ~JSString
        https://bugs.webkit.org/show_bug.cgi?id=52222

        The case where m_fibers is 0 seems to be the most common one
        (almost 1/2 of the time, followed at some distance by m_fibers = 1
        in 1/4 of the cases in a typical SunSpider execution). We can save
        one comparison in this common case by doing a bit of refactoring
        in the JSString destructor; overall a 0.3% progression, but only
        the string tests show improvement.

        * runtime/JSString.h:
        (JSC::RopeBuilder::~JSString):

1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
2011-01-10  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        ASSERTION Failure in JSC::binaryChop
        https://bugs.webkit.org/show_bug.cgi?id=25614

        Changed JITStubs::cti_register_file_check() to use the current stack's
        return PC to find the bytecode for handling the exception in the prior
        frame.  Also added the appropriate arrity check routine call to the
        JIT to bytecode vector (m_callReturnIndexVector) in the CodeBlock.

        * jit/JIT.cpp:
        (JSC::JIT::privateCompile): Changed the arrity check call location
        so that it gets added to the m_calls list so that it's included in
        CodeBlock::m_callReturnIndexVector.
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION): Use the current call frame's return PC.

1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
2011-01-10  Daniel Bates  <dbates@rim.com>

        Reviewed by Martin Robinson.

        Remove extraneous COMPILER(GCC) condition when checking GCC_VERSION_AT_LEAST()
        https://bugs.webkit.org/show_bug.cgi?id=52178

        It is sufficient to test GCC_VERSION_AT_LEAST() instead of both COMPILER(GCC) and
        GCC_VERSION_AT_LEAST(). Notice GCC_VERSION_AT_LEAST() is defined to be 0 when we
        are not compiling with GCC.

        Fixes style issues at the callsites (i.e. replace comma with comma-space in
        macro function argument list). Also, makes a spelling correction in a comment.

        * jit/ExecutableAllocator.h:
        (JSC::ExecutableAllocator::cacheFlush):
        * wtf/Platform.h:

1457
1458
1459
1460
1461
1462
1463
1464
2011-01-10  Geoffrey Garen  <ggaren@apple.com>

        Build fix: removed some uses of nextNumber that I missed last time.

        * runtime/Heap.cpp:
        (JSC::Heap::reset):
        (JSC::Heap::collectAllGarbage):

1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
2011-01-10  Daniel Bates  <dbates@rim.com>

        Reviewed by Darin Adler.

        Use __builtin_expect when compiling using RVCT in GNU mode
        https://bugs.webkit.org/show_bug.cgi?id=51866

        We should only use __builtin_expect if we are compiling with GCC or RVCT 3 or higher in GNU mode
        as pointed out by Siddharth Mathur per <http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0202h/Cjabddedbde.html>.

        * wtf/AlwaysInline.h:
        * wtf/Platform.h: Removed define WTF_COMPILER_RVCT4_OR_GREATER. Instead added macro
        function RVCT_VERSION_AT_LEAST so that we can test for an arbitrary minimum RVCT
        version.

1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
2011-01-10  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Moved Collector.* => Heap.*, since the file contains a class named "Heap".

        * API/JSCallbackObject.cpp:
        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * interpreter/Interpreter.cpp:
        * interpreter/RegisterFile.h:
        * jit/JITStubs.cpp:
        * runtime/Collector.cpp: Removed.
        * runtime/Collector.h: Removed.
        * runtime/CollectorHeapIterator.h:
        * runtime/GCActivityCallbackCF.cpp:
        * runtime/Heap.cpp: Copied from JavaScriptCore/runtime/Collector.cpp.
        * runtime/Heap.h: Copied from JavaScriptCore/runtime/Collector.h.
        * runtime/InitializeThreading.cpp:
        * runtime/JSCell.h:
        * runtime/JSGlobalData.cpp:
        * runtime/JSGlobalData.h:
        * runtime/JSLock.cpp:
        * runtime/JSNumberCell.h:
        * runtime/MachineStackMarker.cpp:
        * runtime/MemoryStatistics.h:
        * runtime/Protect.h:
        * runtime/UString.cpp:
        * runtime/WeakGCMap.h:
        * runtime/WeakGCPtr.h:

1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
2011-01-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gavin Barraclough.

        Remove unused isString() case in JSString::toPrimitiveString()
        https://bugs.webkit.org/show_bug.cgi?id=52167

        We never call toPrimitiveString() with strings, so remove the
        check and add an ASSERT ensuring this never happens. 0.7% overall
        progression in sunspider, since one of the call sites is very hot.

        * runtime/JSString.h:
        (JSC::JSValue::toPrimitiveString):

1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
2011-01-10  Peter Varga  <pvarga@inf.u-szeged.hu>

        Reviewed by Gavin Barraclough.

        Rename the existing YARR files and classes
        https://bugs.webkit.org/show_bug.cgi?id=51872

        Replace the "Regex" prefix with "Yarr" in the name of YARR files and classes.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/RegExp.cpp:
        (JSC::RegExp::compile):
        (JSC::RegExp::match):
        (JSC::RegExp::printTraceData):
        * yarr/YarrInterpreter.cpp: Renamed from Source/JavaScriptCore/yarr/RegexInterpreter.cpp.
        (JSC::Yarr::Interpreter::appendParenthesesDisjunctionContext):
        (JSC::Yarr::Interpreter::popParenthesesDisjunctionContext):
        (JSC::Yarr::Interpreter::DisjunctionContext::DisjunctionContext):
        (JSC::Yarr::Interpreter::DisjunctionContext::operator new):
        (JSC::Yarr::Interpreter::allocDisjunctionContext):
        (JSC::Yarr::Interpreter::freeDisjunctionContext):
        (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext):
        (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::operator new):
        (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::restoreOutput):
        (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::getDisjunctionContext):
        (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext):
        (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
        (JSC::Yarr::Interpreter::InputStream::InputStream):
        (JSC::Yarr::Interpreter::InputStream::next):
        (JSC::Yarr::Interpreter::InputStream::rewind):
        (JSC::Yarr::Interpreter::InputStream::read):
        (JSC::Yarr::Interpreter::InputStream::readPair):
        (JSC::Yarr::Interpreter::InputStream::readChecked):
        (JSC::Yarr::Interpreter::InputStream::reread):
        (JSC::Yarr::Interpreter::InputStream::prev):
        (JSC::Yarr::Interpreter::InputStream::getPos):
        (JSC::Yarr::Interpreter::InputStream::setPos):
        (JSC::Yarr::Interpreter::InputStream::atStart):
        (JSC::Yarr::Interpreter::InputStream::atEnd):
        (JSC::Yarr::Interpreter::InputStream::checkInput):
        (JSC::Yarr::Interpreter::InputStream::uncheckInput):
        (JSC::Yarr::Interpreter::InputStream::isNotAvailableInput):
        (JSC::Yarr::Interpreter::testCharacterClass):
        (JSC::Yarr::Interpreter::checkCharacter):
        (JSC::Yarr::Interpreter::checkCasedCharacter):
        (JSC::Yarr::Interpreter::checkCharacterClass):
        (JSC::Yarr::Interpreter::tryConsumeBackReference):
        (JSC::Yarr::Interpreter::matchAssertionBOL):
        (JSC::Yarr::Interpreter::matchAssertionEOL):
        (JSC::Yarr::Interpreter::matchAssertionWordBoundary):
        (JSC::Yarr::Interpreter::backtrackPatternCharacter):
        (JSC::Yarr::Interpreter::backtrackPatternCasedCharacter):
        (JSC::Yarr::Interpreter::matchCharacterClass):
        (JSC::Yarr::Interpreter::backtrackCharacterClass):
        (JSC::Yarr::Interpreter::matchBackReference):
        (JSC::Yarr::Interpreter::backtrackBackReference):
        (JSC::Yarr::Interpreter::recordParenthesesMatch):
        (JSC::Yarr::Interpreter::resetMatches):
        (JSC::Yarr::Interpreter::parenthesesDoBacktrack):
        (JSC::Yarr::Interpreter::matchParenthesesOnceBegin):
        (JSC::Yarr::Interpreter::matchParenthesesOnceEnd):
        (JSC::Yarr::Interpreter::backtrackParenthesesOnceBegin):
        (JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
        (JSC::Yarr::Interpreter::matchParenthesesTerminalBegin):
        (JSC::Yarr::Interpreter::matchParenthesesTerminalEnd):
        (JSC::Yarr::Interpreter::backtrackParenthesesTerminalBegin):
        (JSC::Yarr::Interpreter::backtrackParenthesesTerminalEnd):
        (JSC::Yarr::Interpreter::matchParentheticalAssertionBegin):
        (JSC::Yarr::Interpreter::matchParentheticalAssertionEnd):
        (JSC::Yarr::Interpreter::backtrackParentheticalAssertionBegin):
        (JSC::Yarr::Interpreter::backtrackParentheticalAssertionEnd):
        (JSC::Yarr::Interpreter::matchParentheses):
        (JSC::Yarr::Interpreter::backtrackParentheses):
        (JSC::Yarr::Interpreter::lookupForBeginChars):
        (JSC::Yarr::Interpreter::matchDisjunction):
        (JSC::Yarr::Interpreter::matchNonZeroDisjunction):
        (JSC::Yarr::Interpreter::interpret):
        (JSC::Yarr::Interpreter::Interpreter):
        (JSC::Yarr::ByteCompiler::ParenthesesStackEntry::ParenthesesStackEntry):
        (JSC::Yarr::ByteCompiler::ByteCompiler):
        (JSC::Yarr::ByteCompiler::compile):
        (JSC::Yarr::ByteCompiler::checkInput):
        (JSC::Yarr::ByteCompiler::assertionBOL):
        (JSC::Yarr::ByteCompiler::assertionEOL):
        (JSC::Yarr::ByteCompiler::assertionWordBoundary):
        (JSC::Yarr::ByteCompiler::atomPatternCharacter):
        (JSC::Yarr::ByteCompiler::atomCharacterClass):
        (JSC::Yarr::ByteCompiler::atomBackReference):
        (JSC::Yarr::ByteCompiler::atomParenthesesOnceBegin):
        (JSC::Yarr::ByteCompiler::atomParenthesesTerminalBegin):
        (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
        (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin):
        (JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd):
        (JSC::Yarr::ByteCompiler::popParenthesesStack):
        (JSC::Yarr::ByteCompiler::dumpDisjunction):
        (JSC::Yarr::ByteCompiler::closeAlternative):
        (JSC::Yarr::ByteCompiler::closeBodyAlternative):
        (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):
        (JSC::Yarr::ByteCompiler::atomParenthesesOnceEnd):
        (JSC::Yarr::ByteCompiler::atomParenthesesTerminalEnd):
        (JSC::Yarr::ByteCompiler::regexBegin):
        (JSC::Yarr::ByteCompiler::regexEnd):
        (JSC::Yarr::ByteCompiler::alternativeBodyDisjunction):
        (JSC::Yarr::ByteCompiler::alternativeDisjunction):
        (JSC::Yarr::ByteCompiler::emitDisjunction):
        (JSC::Yarr::byteCompile):
        (JSC::Yarr::interpret):
        * yarr/YarrInterpreter.h: Renamed from Source/JavaScriptCore/yarr/RegexInterpreter.h.
        (JSC::Yarr::ByteTerm::ByteTerm):
        (JSC::Yarr::ByteTerm::BOL):
        (JSC::Yarr::ByteTerm::CheckInput):
        (JSC::Yarr::ByteTerm::EOL):
        (JSC::Yarr::ByteTerm::WordBoundary):
        (JSC::Yarr::ByteTerm::BackReference):
        (JSC::Yarr::ByteTerm::BodyAlternativeBegin):
        (JSC::Yarr::ByteTerm::BodyAlternativeDisjunction):
        (JSC::Yarr::ByteTerm::BodyAlternativeEnd):
        (JSC::Yarr::ByteTerm::AlternativeBegin):
        (JSC::Yarr::ByteTerm::AlternativeDisjunction):
        (JSC::Yarr::ByteTerm::AlternativeEnd):
        (JSC::Yarr::ByteTerm::SubpatternBegin):
        (JSC::Yarr::ByteTerm::SubpatternEnd):
        (JSC::Yarr::ByteTerm::invert):
        (JSC::Yarr::ByteTerm::capture):
        (JSC::Yarr::ByteDisjunction::ByteDisjunction):
        (JSC::Yarr::BytecodePattern::BytecodePattern):
        (JSC::Yarr::BytecodePattern::~BytecodePattern):
        * yarr/YarrJIT.cpp: Renamed from Source/JavaScriptCore/yarr/RegexJIT.cpp.
        (JSC::Yarr::YarrGenerator::optimizeAlternative):
        (JSC::Yarr::YarrGenerator::matchCharacterClassRange):
        (JSC::Yarr::YarrGenerator::matchCharacterClass):
        (JSC::Yarr::YarrGenerator::jumpIfNoAvailableInput):
        (JSC::Yarr::YarrGenerator::jumpIfAvailableInput):
        (JSC::Yarr::YarrGenerator::checkInput):
        (JSC::Yarr::YarrGenerator::atEndOfInput):
        (JSC::Yarr::YarrGenerator::notAtEndOfInput):
        (JSC::Yarr::YarrGenerator::jumpIfCharEquals):
        (JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
        (JSC::Yarr::YarrGenerator::readCharacter):
        (JSC::Yarr::YarrGenerator::storeToFrame):
        (JSC::Yarr::YarrGenerator::storeToFrameWithPatch):
        (JSC::Yarr::YarrGenerator::loadFromFrame):
        (JSC::Yarr::YarrGenerator::loadFromFrameAndJump):
        (JSC::Yarr::YarrGenerator::IndirectJumpEntry::IndirectJumpEntry):
        (JSC::Yarr::YarrGenerator::IndirectJumpEntry::addJump):
        (JSC::Yarr::YarrGenerator::AlternativeBacktrackRecord::AlternativeBacktrackRecord):
        (JSC::Yarr::YarrGenerator::GenerationState::GenerationState):
        (JSC::Yarr::YarrGenerator::GenerationState::addIndirectJumpEntry):
        (JSC::Yarr::YarrGenerator::GenerationState::emitIndirectJumpTable):
        (JSC::Yarr::YarrGenerator::GenerationState::incrementParenNestingLevel):
        (JSC::Yarr::YarrGenerator::GenerationState::decrementParenNestingLevel):
        (JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail):
        (JSC::Yarr::YarrGenerator::GenerationState::emitParenthesesTail):
        (JSC::Yarr::YarrGenerator::GenerationState::addJumpToNextInteration):
        (JSC::Yarr::YarrGenerator::GenerationState::addJumpsToNextInteration):
        (JSC::Yarr::YarrGenerator::GenerationState::addDataLabelToNextIteration):
        (JSC::Yarr::YarrGenerator::GenerationState::linkToNextIteration):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::BacktrackDestination):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::clear):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::clearDataLabel):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::hasDestination):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::isStackOffset):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::isLabel):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::isJumpList):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::hasDataLabel):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::copyTarget):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::copyTo):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::addBacktrackJump):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::setStackOffset):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::setLabel):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::setNextBacktrackLabel):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::copyBacktrackToLabel):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::setBacktrackToLabel):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::setBacktrackJumpList):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::setBacktrackSourceLabel):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::setDataLabel):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::setSubDataLabelPtr):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::linkToNextBacktrack):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::getStackOffset):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::getLabel):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::getBacktrackJumps):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::getDataLabel):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::jumpToBacktrack):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::linkDataLabelToHereIfExists):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::plantJumpToBacktrackIfExists):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::linkAlternativeBacktracks):
        (JSC::Yarr::YarrGenerator::BacktrackDestination::linkAlternativeBacktracksTo):
        (JSC::Yarr::YarrGenerator::TermGenerationState::TermGenerationState):
        (JSC::Yarr::YarrGenerator::TermGenerationState::resetAlternative):
        (JSC::Yarr::YarrGenerator::TermGenerationState::alternativeValid):
        (JSC::Yarr::YarrGenerator::TermGenerationState::nextAlternative):
        (JSC::Yarr::YarrGenerator::TermGenerationState::alternative):
        (JSC::Yarr::YarrGenerator::TermGenerationState::isLastAlternative):
        (JSC::Yarr::YarrGenerator::TermGenerationState::resetTerm):
        (JSC::Yarr::YarrGenerator::TermGenerationState::termValid):
        (JSC::Yarr::YarrGenerator::TermGenerationState::nextTerm):
        (JSC::Yarr::YarrGenerator::TermGenerationState::term):
        (JSC::Yarr::YarrGenerator::TermGenerationState::isLastTerm):
        (JSC::Yarr::YarrGenerator::TermGenerationState::getSubParenNum):
        (JSC::Yarr::YarrGenerator::TermGenerationState::isMainDisjunction):
        (JSC::Yarr::YarrGenerator::TermGenerationState::setParenthesesTail):
        (JSC::Yarr::YarrGenerator::TermGenerationState::getParenthesesTail):
        (JSC::Yarr::YarrGenerator::TermGenerationState::lookaheadTerm):
        (JSC::Yarr::YarrGenerator::TermGenerationState::isSinglePatternCharacterLookaheadTerm):
        (JSC::Yarr::YarrGenerator::TermGenerationState::inputOffset):
        (JSC::Yarr::YarrGenerator::TermGenerationState::clearBacktrack):
        (JSC::Yarr::YarrGenerator::TermGenerationState::jumpToBacktrack):
        (JSC::Yarr::YarrGenerator::TermGenerationState::plantJumpToBacktrackIfExists):
        (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):
        (JSC::Yarr::YarrGenerator::TermGenerationState::addBacktrackJump):
        (JSC::Yarr::YarrGenerator::TermGenerationState::setBacktrackDataLabel):
        (JSC::Yarr::YarrGenerator::TermGenerationState::setBackTrackStackOffset):
        (JSC::Yarr::YarrGenerator::TermGenerationState::setBacktrackLabel):
        (JSC::Yarr::YarrGenerator::TermGenerationState::linkAlternativeBacktracks):
        (JSC::Yarr::YarrGenerator::TermGenerationState::linkAlternativeBacktracksTo):
        (JSC::Yarr::YarrGenerator::TermGenerationState::setBacktrackLink):
        (JSC::Yarr::YarrGenerator::TermGenerationState::chainBacktracks):
        (JSC::Yarr::YarrGenerator::TermGenerationState::chainBacktrackJumps):
        (JSC::Yarr::YarrGenerator::TermGenerationState::getBacktrackDestination):
        (JSC::Yarr::YarrGenerator::TermGenerationState::propagateBacktrackingFrom):
        (JSC::Yarr::YarrGenerator::ParenthesesTail::ParenthesesTail):
        (JSC::Yarr::YarrGenerator::ParenthesesTail::processBacktracks):
        (JSC::Yarr::YarrGenerator::ParenthesesTail::setNextIteration):
        (JSC::Yarr::YarrGenerator::ParenthesesTail::addAfterParenJump):
        (JSC::Yarr::YarrGenerator::ParenthesesTail::generateCode):
        (JSC::Yarr::YarrGenerator::generateAssertionBOL):
        (JSC::Yarr::YarrGenerator::generateAssertionEOL):
        (JSC::Yarr::YarrGenerator::matchAssertionWordchar):
        (JSC::Yarr::YarrGenerator::generateAssertionWordBoundary):
        (JSC::Yarr::YarrGenerator::generatePatternCharacterSingle):
        (JSC::Yarr::YarrGenerator::generatePatternCharacterPair):
        (JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
        (JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
        (JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy):
        (JSC::Yarr::YarrGenerator::generateCharacterClassSingle):
        (JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
        (JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
        (JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy):
        (JSC::Yarr::YarrGenerator::generateParenthesesDisjunction):
        (JSC::Yarr::YarrGenerator::generateParenthesesSingle):
        (JSC::Yarr::YarrGenerator::generateParenthesesGreedyNoBacktrack):
        (JSC::Yarr::YarrGenerator::generateParentheticalAssertion):
        (JSC::Yarr::YarrGenerator::generateTerm):
        (JSC::Yarr::YarrGenerator::generateDisjunction):
        (JSC::Yarr::YarrGenerator::generateEnter):
        (JSC::Yarr::YarrGenerator::generateReturn):
        (JSC::Yarr::YarrGenerator::YarrGenerator):
        (JSC::Yarr::YarrGenerator::generate):
        (JSC::Yarr::YarrGenerator::compile):
        (JSC::Yarr::jitCompile):
        * yarr/YarrJIT.h: Renamed from Source/JavaScriptCore/yarr/RegexJIT.h.
        (JSC::Yarr::YarrCodeBlock::YarrCodeBlock):
        (JSC::Yarr::YarrCodeBlock::~YarrCodeBlock):
        (JSC::Yarr::YarrCodeBlock::setFallBack):
        (JSC::Yarr::YarrCodeBlock::isFallBack):
        (JSC::Yarr::YarrCodeBlock::set):
        (JSC::Yarr::YarrCodeBlock::execute):
        (JSC::Yarr::YarrCodeBlock::getAddr):
        (JSC::Yarr::execute):
        * yarr/YarrParser.h: Renamed from Source/JavaScriptCore/yarr/RegexParser.h.
        (JSC::Yarr::Parser::CharacterClassParserDelegate::CharacterClassParserDelegate):
        (JSC::Yarr::Parser::CharacterClassParserDelegate::begin):
        (JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter):
        (JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass):
        (JSC::Yarr::Parser::CharacterClassParserDelegate::end):
        (JSC::Yarr::Parser::CharacterClassParserDelegate::assertionWordBoundary):
        (JSC::Yarr::Parser::CharacterClassParserDelegate::atomBackReference):
        (JSC::Yarr::Parser::Parser):
        (JSC::Yarr::Parser::parseEscape):
        (JSC::Yarr::Parser::parseAtomEscape):
        (JSC::Yarr::Parser::parseCharacterClassEscape):
        (JSC::Yarr::Parser::parseCharacterClass):
        (JSC::Yarr::Parser::parseParenthesesBegin):
        (JSC::Yarr::Parser::parseParenthesesEnd):
        (JSC::Yarr::Parser::parseQuantifier):
        (JSC::Yarr::Parser::parseTokens):
        (JSC::Yarr::Parser::parse):
        (JSC::Yarr::Parser::saveState):
        (JSC::Yarr::Parser::restoreState):
        (JSC::Yarr::Parser::atEndOfPattern):
        (JSC::Yarr::Parser::peek):
        (JSC::Yarr::Parser::peekIsDigit):
        (JSC::Yarr::Parser::peekDigit):
        (JSC::Yarr::Parser::consume):
        (JSC::Yarr::Parser::consumeDigit):
        (JSC::Yarr::Parser::consumeNumber):
        (JSC::Yarr::Parser::consumeOctal):
        (JSC::Yarr::Parser::tryConsume):
        (JSC::Yarr::Parser::tryConsumeHex):
        (JSC::Yarr::parse):
        * yarr/YarrPattern.cpp: Renamed from Source/JavaScriptCore/yarr/RegexPattern.cpp.
        (JSC::Yarr::CharacterClassConstructor::CharacterClassConstructor):
        (JSC::Yarr::CharacterClassConstructor::reset):
        (JSC::Yarr::CharacterClassConstructor::append):
        (JSC::Yarr::CharacterClassConstructor::putChar):
        (JSC::Yarr::CharacterClassConstructor::isUnicodeUpper):
        (JSC::Yarr::CharacterClassConstructor::isUnicodeLower):
        (JSC::Yarr::CharacterClassConstructor::putRange):
        (JSC::Yarr::CharacterClassConstructor::charClass):
        (JSC::Yarr::CharacterClassConstructor::addSorted):
        (JSC::Yarr::CharacterClassConstructor::addSortedRange):
        (JSC::Yarr::BeginCharHelper::BeginCharHelper):
        (JSC::Yarr::BeginCharHelper::addBeginChar):
        (JSC::Yarr::BeginCharHelper::merge):
        (JSC::Yarr::BeginCharHelper::addCharacter):
        (JSC::Yarr::BeginCharHelper::linkHotTerms):
        (JSC::Yarr::YarrPatternConstructor::YarrPatternConstructor):
        (JSC::Yarr::YarrPatternConstructor::~YarrPatternConstructor):
        (JSC::Yarr::YarrPatternConstructor::reset):
        (JSC::Yarr::YarrPatternConstructor::assertionBOL):
        (JSC::Yarr::YarrPatternConstructor::assertionEOL):
        (JSC::Yarr::YarrPatternConstructor::assertionWordBoundary):
        (JSC::Yarr::YarrPatternConstructor::atomPatternCharacter):
        (JSC::Yarr::YarrPatternConstructor::atomBuiltInCharacterClass):
        (JSC::Yarr::YarrPatternConstructor::atomCharacterClassBegin):
        (JSC::Yarr::YarrPatternConstructor::atomCharacterClassAtom):
        (JSC::Yarr::YarrPatternConstructor::atomCharacterClassRange):
        (JSC::Yarr::YarrPatternConstructor::atomCharacterClassBuiltIn):
        (JSC::Yarr::YarrPatternConstructor::atomCharacterClassEnd):
        (JSC::Yarr::YarrPatternConstructor::atomParenthesesSubpatternBegin):
        (JSC::Yarr::YarrPatternConstructor::atomParentheticalAssertionBegin):
        (JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):
        (JSC::Yarr::YarrPatternConstructor::atomBackReference):
        (JSC::Yarr::YarrPatternConstructor::copyDisjunction):
        (JSC::Yarr::YarrPatternConstructor::copyTerm):
        (JSC::Yarr::YarrPatternConstructor::quantifyAtom):
        (JSC::Yarr::YarrPatternConstructor::disjunction):
        (JSC::Yarr::YarrPatternConstructor::regexBegin):
        (JSC::Yarr::YarrPatternConstructor::regexEnd):
        (JSC::Yarr::YarrPatternConstructor::regexError):
        (JSC::Yarr::YarrPatternConstructor::setupAlternativeOffsets):
        (JSC::Yarr::YarrPatternConstructor::setupDisjunctionOffsets):
        (JSC::Yarr::YarrPatternConstructor::setupOffsets):
        (JSC::Yarr::YarrPatternConstructor::checkForTerminalParentheses):
        (JSC::Yarr::YarrPatternConstructor::optimizeBOL):
        (JSC::Yarr::YarrPatternConstructor::addBeginTerm):
        (JSC::Yarr::YarrPatternConstructor::setupDisjunctionBeginTerms):
        (JSC::Yarr::YarrPatternConstructor::setupAlternativeBeginTerms):
        (JSC::Yarr::YarrPatternConstructor::setupBeginChars):
        (JSC::Yarr::compile):
        (JSC::Yarr::YarrPattern::YarrPattern):
        * yarr/YarrPattern.h: Renamed from Source/JavaScriptCore/yarr/RegexPattern.h.
        (JSC::Yarr::CharacterRange::CharacterRange):
        (JSC::Yarr::CharacterClassTable::create):
        (JSC::Yarr::CharacterClassTable::CharacterClassTable):
        (JSC::Yarr::CharacterClass::CharacterClass):
        (JSC::Yarr::PatternTerm::PatternTerm):
        (JSC::Yarr::PatternTerm::ForwardReference):
        (JSC::Yarr::PatternTerm::BOL):
        (JSC::Yarr::PatternTerm::EOL):
        (JSC::Yarr::PatternTerm::WordBoundary):
        (JSC::Yarr::PatternTerm::invert):
        (JSC::Yarr::PatternTerm::capture):
        (JSC::Yarr::PatternTerm::quantify):
        (JSC::Yarr::PatternAlternative::PatternAlternative):
        (JSC::Yarr::PatternAlternative::lastTerm):
        (JSC::Yarr::PatternAlternative::removeLastTerm):
        (JSC::Yarr::PatternAlternative::setOnceThrough):
        (JSC::Yarr::PatternAlternative::onceThrough):
        (JSC::Yarr::PatternDisjunction::PatternDisjunction):
        (JSC::Yarr::PatternDisjunction::~PatternDisjunction):
        (JSC::Yarr::PatternDisjunction::addNewAlternative):
        (JSC::Yarr::TermChain::TermChain):
        (JSC::Yarr::BeginChar::BeginChar):
        (JSC::Yarr::YarrPattern::~YarrPattern):
        (JSC::Yarr::YarrPattern::reset):
        (JSC::Yarr::YarrPattern::containsIllegalBackReference):
        (JSC::Yarr::YarrPattern::newlineCharacterClass):
        (JSC::Yarr::YarrPattern::digitsCharacterClass):
        (JSC::Yarr::YarrPattern::spacesCharacterClass):
        (JSC::Yarr::YarrPattern::wordcharCharacterClass):
        (JSC::Yarr::YarrPattern::nondigitsCharacterClass):
        (JSC::Yarr::YarrPattern::nonspacesCharacterClass):
        (JSC::Yarr::YarrPattern::nonwordcharCharacterClass):

barraclough@apple.com's avatar
barraclough@apple.com committed
1910
1911
1912
1913
1914
1915
2011-01-10  Gavin Barraclough  <barraclough@apple.com>

        Windows build fix.

        * parser/SyntaxChecker.h:

1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
2011-01-10  Dave Tapuska  <dtapuska@rim.com>

        Reviewed by Gavin Barraclough.

        Add CTI ASM versions for RVCT ARM THUMB2 mode.

        https://bugs.webkit.org/show_bug.cgi?id=52154

        * jit/JITStubs.cpp:
        (JSC::ctiTrampoline):
        (JSC::ctiVMThrowTrampoline):
        (JSC::ctiOpThrowNotCaught):

barraclough@apple.com's avatar
barraclough@apple.com committed
1929
1930
1931
1932
1933
1934
2011-01-10  Gavin Barraclough  <barraclough@apple.com>

        Qt build fix.

        * JavaScriptCore.pro:

1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2011-01-10  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Bug 52079 - Syntax errors should be early errors.

        From chapter 16 the spec:
            An implementation must report most errors at the time the relevant ECMAScript language construct is
            evaluated. An early error is an error that can be detected and reported prior to the evaluation of
            any construct in the Program containing the error. An implementation must report early errors in a
            Program prior to the first evaluation of that Program. Early errors in eval code are reported at
            the time eval is called but prior to evaluation of any construct within the eval code. All errors
            that are not early errors are runtime errors.

            An implementation must treat any instance of the following kinds of errors as an early error:
                * Any syntax error."

        * JavaScriptCore.xcodeproj/project.pbxproj:
            Added new files.
        * bytecode/CodeBlock.cpp:
            Removed op_throw_syntax_error.
        * bytecode/Opcode.h:
            Removed op_throw_syntax_error.
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::generate):
            If m_expressionTooDeep then throw a runtime error.
        (JSC::BytecodeGenerator::BytecodeGenerator):
            Initialize m_expressionTooDeep.
        (JSC::BytecodeGenerator::emitThrowExpressionTooDeepException):
            Sets m_expressionTooDeep.
        * bytecompiler/BytecodeGenerator.h:
            Added m_expressionTooDeep, removed emitThrowSyntaxError.
        * bytecompiler/NodesCodegen.cpp:
        (JSC::RegExpNode::emitBytecode):
        (JSC::ContinueNode::emitBytecode):
        (JSC::BreakNode::emitBytecode):
        (JSC::ReturnNode::emitBytecode):
        (JSC::LabelNode::emitBytecode):
            Conditions that threw syntax error are now handled during parsing;
            during bytecompilation these are now just ASSERTs.
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        * jit/JIT.h:
        * jit/JITOpcodes.cpp:
        * jit/JITOpcodes32_64.cpp:
        * jit/JITStubs.cpp:
        * jit/JITStubs.h:
            Removed op_throw_syntax_error.
        * parser/ASTBuilder.h:
        (JSC::ASTBuilder::createRegExp):
            Renamed; added syntax check.
        * parser/JSParser.cpp:
        (JSC::JSParser::breakIsValid):
        (JSC::JSParser::hasLabel):
        (JSC::JSParser::Scope::Scope):
        (JSC::JSParser::Scope::setIsFunction):
        (JSC::JSParser::Scope::isFunctionBoundary):
        (JSC::JSParser::ScopeRef::hasContainingScope):
        (JSC::JSParser::ScopeRef::containingScope):
        (JSC::JSParser::AutoPopScopeRef::AutoPopScopeRef):
        (JSC::JSParser::AutoPopScopeRef::~AutoPopScopeRef):
        (JSC::JSParser::AutoPopScopeRef::setPopped):
        (JSC::JSParser::popScopeInternal):
        (JSC::JSParser::popScope):
        (JSC::jsParse):
        (JSC::JSParser::JSParser):
        (JSC::JSParser::parseProgram):
        (JSC::JSParser::parseBreakStatement):
        (JSC::JSParser::parseContinueStatement):
        (JSC::JSParser::parseReturnStatement):
        (JSC::JSParser::parseTryStatement):
        (JSC::JSParser::parseFunctionInfo):
        (JSC::JSParser::parseExpressionOrLabelStatement):
        (JSC::JSParser::parsePrimaryExpression):
        * parser/JSParser.h:
        * parser/Nodes.h:
        * parser/Parser.cpp:
        (JSC::Parser::parse):
        * parser/SyntaxChecker.h:
        (JSC::SyntaxChecker::createRegExp):
            Renamed; added syntax check.
        * runtime/ExceptionHelpers.cpp:
        (JSC::createOutOfMemoryError):
        (JSC::throwOutOfMemoryError):
        * runtime/ExceptionHelpers.h:
            Broke out createOutOfMemoryError.
        * runtime/Executable.cpp:
        (JSC::EvalExecutable::compileInternal):
        (JSC::ProgramExecutable::compileInternal):
        (JSC::FunctionExecutable::compileForCallInternal):
        (JSC::FunctionExecutable::compileForConstructInternal):
            Add check for exception after bytecode generation.
        * runtime/RegExpConstructor.cpp:
        (JSC::constructRegExp):
        * runtime/RegExpPrototype.cpp:
        (JSC::regExpProtoFuncCompile):
            RegExp error prefixes not included in error string.
        * yarr/RegexParser.h:
        (JSC::Yarr::Parser::parse):
            Removed regexBegin/regexEnd/regexError.
        * yarr/RegexPattern.cpp:
        (JSC::Yarr::RegexPatternConstructor::regexBegin):
            Removed regexEnd/regexError.
        (JSC::Yarr::compileRegex):
            Add call to regexBegin (no longer called from the parser).
        * yarr/YarrSyntaxChecker.cpp: Added.
        (JSC::Yarr::SyntaxChecker::assertionBOL):
        (JSC::Yarr::SyntaxChecker::assertionEOL):
        (JSC::Yarr::SyntaxChecker::assertionWordBoundary):
        (JSC::Yarr::SyntaxChecker::atomPatternCharacter):
        (JSC::Yarr::SyntaxChecker::atomBuiltInCharacterClass):
        (JSC::Yarr::SyntaxChecker::atomCharacterClassBegin):
        (JSC::Yarr::SyntaxChecker::atomCharacterClassAtom):
        (JSC::Yarr::SyntaxChecker::atomCharacterClassRange):
        (JSC::Yarr::SyntaxChecker::atomCharacterClassBuiltIn):
        (JSC::Yarr::SyntaxChecker::atomCharacterClassEnd):
        (JSC::Yarr::SyntaxChecker::atomParenthesesSubpatternBegin):
        (JSC::Yarr::SyntaxChecker::atomParentheticalAssertionBegin):
        (JSC::Yarr::SyntaxChecker::atomParenthesesEnd):
        (JSC::Yarr::SyntaxChecker::atomBackReference):
        (JSC::Yarr::SyntaxChecker::quantifyAtom):
        (JSC::Yarr::SyntaxChecker::disjunction):
        (JSC::Yarr::checkSyntax):
        * yarr/YarrSyntaxChecker.h: Added.
            Check RegExp syntax.

aroben@apple.com's avatar
aroben@apple.com committed
2063
2064
2065
2066
2067
2068
2069
2070
2071
2011-01-10  Adam Roben  <aroben@apple.com>

        Roll out r75289

        It was causing assertion failures. See <http://webkit.org/b/52156>.

        * wtf/StackBounds.cpp:
        (WTF::StackBounds::initialize):

2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2011-01-08  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Unify string table adding in AtomicString
        https://bugs.webkit.org/show_bug.cgi?id=51927

        Move code for adding a string into a separate function.
        This removes multiple occurrence of the same logic.

        * wtf/text/AtomicString.cpp:
        (WTF::addToStringTable): Added.
        (WTF::AtomicString::add): Use addToStringTable().
        (WTF::AtomicString::fromUTF8): Ditto.

2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2011-01-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Gavin Barraclough.

        Split machine stack marking functions into their own class (MachineStackMarker)
        https://bugs.webkit.org/show_bug.cgi?id=52088

        * API/APIShims.h:
        (JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock): Moved registerThread()
        call behind an #ifdef because we shouldn't be registering threads at all
        if we don't support usage on multiple threads.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj: Updated projects.

        * runtime/Collector.cpp:
        (JSC::Heap::Heap):
        (JSC::Heap::destroy):
        (JSC::Heap::markRoots):
        * runtime/Collector.h:
        (JSC::Heap::machineStackMarker): Moved code to machineStackMarker.

        * runtime/JSGlobalData.h:
        (JSC::JSGlobalData::makeUsableFromMultipleThreads): Removed an unnecessary
        level of indirection, to make Heap less of a God class.

        * runtime/MachineStackMarker.h: Copied from Source/JavaScriptCore/runtime/Collector.h.
        * runtime/MachineStackMarker.cpp: Copied from Source/JavaScriptCore/runtime/Collector.cpp.
        (JSC::MachineStackMarker::MachineStackMarker):
        (JSC::MachineStackMarker::~MachineStackMarker):
        (JSC::MachineStackMarker::makeUsableFromMultipleThreads):
        (JSC::MachineStackMarker::registerThread):
        (JSC::MachineStackMarker::unregisterThread):
        (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
        (JSC::MachineStackMarker::markCurrentThreadConservatively):
        (JSC::MachineStackMarker::markOtherThreadConservatively):
        (JSC::MachineStackMarker::markMachineStackConservatively): Moved code from Heap.

2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2011-01-07  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Bug 26276 - Need a mechanism to determine stack extent on WINDOWS, SOLARIS, OPENBSD, SYMBIAN, HAIKU, WINCE platforms

        Fix for win32.  The base of the stack is stored in the "deallocation stack" field of the
        Thread Information Block - see: http://en.wikipedia.org/wiki/Win32_Thread_Information_Block
        for more information!

        * wtf/StackBounds.cpp:
        (WTF::StackBounds::initialize):

2143
2144
2145
2146
2147
2148
2011-01-07  Adam Roben  <aroben@apple.com>

        Update react-to-vsprops-changes.py after r74855

        * JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:

2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2011-01-07  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Port scrollbar painting to GtkStyleContext
        https://bugs.webkit.org/show_bug.cgi?id=52051

        * wtf/gobject/GTypedefs.h: Add GtkStyleContext forward
        declaration.

2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2011-01-07  Daniel Bates  <dbates@rim.com>

        Reviewed by Martin Robinson.

        Enable PCRE computed gotos when compiling with RCVT 4.0 or greater in GNU mode
        https://bugs.webkit.org/show_bug.cgi?id=52034

        Derived from a patch by Eli Fidler.

        RVCT 4 or greater in GNU mode supports the computed goto GNU language extension
        as per <http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/ch03s07s12.html>.

        * pcre/pcre_exec.cpp: Modified to check for feature, HAVE(COMPUTED_GOTO), instead
        of hardcoding the GCC compiler.
        * wtf/Platform.h: Define WTF_COMPILER_RVCT4_OR_GREATER if __ARMCC_VERSION >= 400000.

2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2011-01-06  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Bug 52035 - Unregistering DOMWrapperWorlds is unsafe

        The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
        destructor early, in order to release wrappers once we know we no longer intend to use them.
        Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
        lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
        A sequence of events that triggers the bug would look like this:

        (1) Create a DOMWrapperWorld.
        (2) Register a timer in the world.
        (3) Call unregisterWorld() on the world.
        (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
        (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
            called forgetWorld() none exists.
        (6) Attempt to add a wrapper to a NULL map.

        Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.

        * runtime/WeakGCMap.h:
        (JSC::WeakGCMap::clear):

2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2011-01-06  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Darin Adler.

        Bug 52021 - zeroDouble broken on ARMv7

        The bug here is that zeroDouble was working incorrectly,
        leading to op_loop_if_true failing - specifically in the
        case where the value being checked is 0.0 encoded as a
        double (rather than an integer immediate).

        Additionally this patch removes a redundant duplicate compare
        in some (many) case.

        * assembler/ARMv7Assembler.h:
        (JSC::ARMv7Assembler::vcmp_F64):
        (JSC::ARMv7Assembler::vcmpz_F64):
        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::branchDoubleNonZero):
        (JSC::MacroAssemblerARM::branchDoubleZeroOrNaN):
        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::branchDouble):
        (JSC::MacroAssemblerARMv7::branchDoubleNonZero):
        (JSC::MacroAssemblerARMv7::branchDoubleZeroOrNaN):
        (JSC::MacroAssemblerARMv7::compare32):
        * assembler/MacroAssemblerMIPS.h:
        (JSC::MacroAssemblerMIPS::branchDoubleNonZero):
        (JSC::MacroAssemblerMIPS::branchDoubleZeroOrNaN):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::branchDoubleNonZero):
        (JSC::MacroAssemblerX86Common::branchDoubleZeroOrNaN):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::emit_op_jfalse):
        (JSC::JIT::emit_op_jtrue):

2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2011-01-06  Michael Saboff  <msaboff@apple.com>

        Reviewed by Gavin Barraclough.

        Added debug code to compare the results of JIT regexp with 
        interpreted regexp and displays discrepencies.  This debug code is
        controlled by the ENABLE_YARR_JIT_DEBUG macro in wtf/Platform.h and
        is only valid if ENABLE_YARR_JIT is enabled.

        Fixed a discovered problem in RegExp::printTraceData, changing
        m_pattern to the getter pattern().
        Also deleted an extraneous semicolon.

        Enhancement: Add Regexp Debug Compare between JIT and Interpreter
        https://bugs.webkit.org/show_bug.cgi?id=51834

        * runtime/RegExp.cpp:
        (JSC::RegExp::compile):
        (JSC::RegExp::match):
        (JSC::RegExp::printTraceData):
        * wtf/Platform.h:

2257
2258
2259
2260
2261
2262
2263
2264
2265
2011-01-06  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        [WINCE] Remove JSC::g_stackBase
        https://bugs.webkit.org/show_bug.cgi?id=51779

        * wtf/StackBounds.cpp:

2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2011-01-06  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Eric Seidel.

        WML Parser should treat line/column number in a consistent way
        https://bugs.webkit.org/show_bug.cgi?id=51601

        Add the equality operators to TextPosition class.

        * wtf/text/TextPosition.h:
        (WTF::TextPosition::operator==): Added.
        (WTF::TextPosition::operator!=): Added.
        (WTF::TextPosition::belowRangePosition): Use belowBase() instead of base().
        (WTF::ZeroBasedNumber::operator==): Added.
        (WTF::ZeroBasedNumber::operator!=): Added.
        (WTF::OneBasedNumber::operator==): Added.
        (WTF::OneBasedNumber::operator!=): Added.

2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2011-01-06  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Gavin Barraclough.

        [WINCE] Determine stack extent
        https://bugs.webkit.org/show_bug.cgi?id=26276

        Scan the stack for writeable pages and use the limits.

        * wtf/StackBounds.cpp:
        (WTF::detectGrowingDownward):
        (WTF::isPageWritable):
        (WTF::getLowerStackBound):
        (WTF::getUpperStackBound):
        (WTF::StackBounds::initialize):

sfalken@apple.com's avatar
sfalken@apple.com committed
2300
2301
2302
2303
2304
2305
2011-01-05  Steve Falkenburg  <sfalken@apple.com>

        Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Revert change to additional library search path needed to find ICU.

2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2011-01-05  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Debug and Release builds on Windows clobber each other
        https://bugs.webkit.org/show_bug.cgi?id=49185
        
        Changes the structure of WebKitBuild build products directory so we
        completely separate each build configuration into independent directories.
        
        Although we previously had per-configuration directories for obj, this change adds
        per-configuration directories for bin, lib, obj, and include. Each configuration's
        build products are stored within a directory inside of WebKitBuild.
        
        Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
        defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
        
        For PGO, $(ConfigurationBuildDir) points to the same directory (Release_PGO) to allow
        for proper operation of the instrumentation/optimization scripts.

        * JavaScriptCore.vcproj/JavaScriptCore.make:
        * JavaScriptCore.vcproj/JavaScriptCore.sln:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePGOOptimize.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePostBuild.cmd:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePreBuild.cmd:
        * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
        * JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:
        * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
        * JavaScriptCore.vcproj/WTF/WTFPostBuild.cmd:
        * JavaScriptCore.vcproj/WTF/WTFPreBuild.cmd:
        * JavaScriptCore.vcproj/jsc/jsc.vcproj:
        * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
        * JavaScriptCore.vcproj/jsc/jscPostBuild.cmd:
        * JavaScriptCore.vcproj/jsc/jscPreBuild.cmd:
        * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
        * JavaScriptCore.vcproj/testapi/testapiPostBuild.cmd:
        * JavaScriptCore.vcproj/testapi/testapiPreBuild.cmd:

bfulgham@webkit.org's avatar
bfulgham@webkit.org committed
2351
2352
2353
2354
2355
2356
2357
2011-01-05  Brent Fulgham  <bfulgham@webkit.org>

        Unreviewed build fix.

        * wtf/Encoder.h: Add <stdint.h> include for systems that
        do not natively know about uint8_t, etc.

2358
2359
2360
2361
2362
2363
2364
2365
2366
2011-01-05  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Fix the usage of SOURCE_GROUP
        https://bugs.webkit.org/show_bug.cgi?id=51739

        * CMakeLists.txt:

2367
2368
2369
2370
2371
2372
2373
2374
2011-01-05  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][V8] Fix the build after recent changes.

        * pcre/pcre.pri: Correct the path after Source was introduced.

2375
2376
2377
2378
2379
2380
2011-01-04  Steve Falkenburg  <sfalken@apple.com>

        Build fix. Update path to FindSafari after source code reorganization.

        * JavaScriptCore.vcproj/JavaScriptCore.sln:

2381
2382
2383
2384
2385
2386
2387
2388
2011-01-04  Daniel Bates  <dbates@rim.com>

        Fix the Android build after changeset 74975 <http://trac.webkit.org/changeset/74975>
        (https://bugs.webkit.org/show_bug.cgi?id=51855).

        * wtf/ThreadingPthreads.cpp: Add include of PassOwnPtr.h.
        (WTF::runThreadWithRegistration): Use -> instead of . to dereference pointer.

2389
2390
2391
2392
2393
2394
2011-01-04  Martin Robinson  <mrobinson@igalia.com>

        Try to fix the EFL build.

        * wtf/CMakeLists.txt: Remove PlatformRefPtr from the CMake source list.

2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2011-01-04  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Adler.

        StackBounds initialization in WTFThreadData should be guarded by #if USE(JSC)
        https://bugs.webkit.org/show_bug.cgi?id=51881

        The StackBounds class is only used by JavaScriptCore.

        * wtf/WTFThreadData.cpp:
        (WTF::WTFThreadData::WTFThreadData):
        * wtf/WTFThreadData.h:
        (WTF::WTFThreadData::resetCurrentIdentifierTable):

2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2011-01-03  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Darin Adler.

        Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
        https://bugs.webkit.org/show_bug.cgi?id=51846

        * GNUmakefile.am: Remove PlatformRefPtr.h from the sources list.
        * JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
        * jit/ExecutableAllocator.h: Change references to PlatformRefPtr to RefPtr.
        (JSC::ExecutableAllocator::cacheFlush): Ditto.
        * wtf/PlatformRefPtr.h: Removed.
        * wtf/RandomNumber.cpp: Change references to PlatformRefPtr to RefPtr.
        (WTF::randomNumber): Ditto.
        * wtf/brew/RefPtrBrew.h: Ditto.
        (WTF::refIfNotNull): Added.
        (WTF::derefIfNotNull): Added.
        * wtf/brew/ShellBrew.h: Change references to PlatformRefPtr to RefPtr.
        (WTF::createRefPtrInstance): Modified to return a RefPtr.
        * wtf/gobject/GRefPtr.cpp: 
        (WTF::refGPtr): Moved from PlatformRefPtr here.
        (WTF::derefGPtr): Ditto.
        * wtf/gobject/GRefPtr.h: Ditto.
        (WTF::GRefPtr::GRefPtr): Ditto.
        (WTF::GRefPtr::~GRefPtr): Ditto.
        (WTF::GRefPtr::clear): Ditto.
        (WTF::GRefPtr::isHashTableDeletedValue): Ditto.
        (WTF::GRefPtr::get): Ditto.
        (WTF::GRefPtr::operator*): Ditto.
        (WTF::GRefPtr::operator->): Ditto.
        (WTF::GRefPtr::operator!): Ditto.
        (WTF::GRefPtr::operator UnspecifiedBoolType): Ditto.
        (WTF::GRefPtr::hashTableDeletedValue): Ditto.
        (WTF::::operator): Ditto.
        (WTF::::swap): Ditto.
        (WTF::swap): Ditto.
        (WTF::operator==): Ditto.
        (WTF::operator!=): Ditto.
        (WTF::static_pointer_cast): Ditto.
        (WTF::const_pointer_cast): Ditto.
        (WTF::getPtr): Ditto.
        (WTF::adoptGRef): Ditto.
        (WTF::refGPtr): Ditto.
        (WTF::derefGPtr): Ditto.

2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2011-01-04  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Roben.

        LEAK: Deallocate instance of ThreadFunctionInvocation if thread creation fails
        https://bugs.webkit.org/show_bug.cgi?id=51860

        * wtf/ThreadingWin.cpp:
        (WTF::createThreadInternal):

2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2011-01-04  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt][Symbian] Make sure that WebKit headers are included before platform headers on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=31273

        On Symbian PREPEND_INCLUDEPATH is the best way to make sure that WebKit headers
        are included before platform headers. On all other platforms continue to use
        INCLUDEPATH (as before). This is a continuation of r65877.

        No new tests as there is no new functionality.

        * JavaScriptCore.pri:

darin@apple.com's avatar
darin@apple.com committed
2479
2480
2481
2482
2483
2484
2485
2486
2487
2011-01-04  Darin Adler  <darin@apple.com>

        Try to fix Windows build.

        * wtf/ThreadingWin.cpp: Added include of PassOwnPtr.h. Fixed paragraphing
        of conditional includes.
        (WTF::wtfThreadEntryPoint): Use -> instead of . to dereference pointer.
        (WTF::createThreadInternal): Tweaked #if to not need separate macro.

2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2011-01-04  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Roben.

        Extract ThreadFunctionInvocation into separate file and share between Apple Windows and Android
        https://bugs.webkit.org/show_bug.cgi?id=51855

        Both the Apple Windows and Android ports implement a similar adapter structure,
        called ThreadFunctionInvocation and ThreadData respectively, as part of
        their thread creation process. Instead, we should share such an adapter
        structure and remove duplicate code.

        * JavaScriptCore.gypi: Added header wtf/ThreadFunctionInvocation.h.
        * wtf/ThreadFunctionInvocation.h: Added.
        (WTF::ThreadFunctionInvocation::ThreadFunctionInvocation):
        * wtf/ThreadingPthreads.cpp: Removed Android-specific structure ThreadData; Instead, use ThreadFunctionInvocation.
        (WTF::runThreadWithRegistration):
        (WTF::createThreadInternal): 
        * wtf/ThreadingWin.cpp: Moved structure ThreadFunctionInvocation to its own file so that
        it can be shared with the Android implementation of createThreadInternal().
        (WTF::wtfThreadEntryPoint): Use OwnPtr to hold passed instance of ThreadFunctionInvocation.

2510
2011-01-04  Daniel Bates  <dbates@rim.com>
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520

        Reviewed by Darin Adler.

        Use __builtin_expect when compiling using RVCT in GNU mode
        https://bugs.webkit.org/show_bug.cgi?id=51866

        Derived from a patch by Dave Tapuska.

        * wtf/AlwaysInline.h:

2521
2522
2523
2524
2525
2526
2011-01-03  Darin Adler  <darin@apple.com>

        Reviewed by Brady Eidson.

        * wtf/Forward.h: Added Decoder and Encoder.

2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2011-01-03  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        Add Encode/Decode machinery Darin and I plan to work with for back/forward stuff in WebKit2.

        Starting out with a pure virtual interface to be implemented in WK2, but we might change that later.

        * GNUmakefile.am:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/CMakeLists.txt:

        * wtf/Decoder.h: Added.
        * wtf/Encoder.h: Added.

2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2011-01-03  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix.

        [Qt] Add NullPtr.cpp introduced in r71155 to the Qt build system.

        This fix is required for builds where HAVE(NULLPTR) is false
        (e.g. some MSVC and Symbian builds).

        * wtf/wtf.pri:

2554
2555
2556
2557
2558
2559
2560
2561
2011-01-02  Dan Bernstein  <mitz@apple.com>

        Rubber-stamped by Simon Fraser.

        <rdar://problem/8812159> Update copyright strings

        * Info.plist:

ossy@webkit.org's avatar
ossy@webkit.org committed
2562
2563
2564
2565
2566
2567
2568
2569
2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>

        Fix GTK+ build after r74855.

        Reviewed by Xan Lopez.

        * GNUmakefile.am: Fix include pathes.

2570
2571
2572
2573
2574
2575
2011-01-02  Adam Barth  <abarth@webkit.org>

        One more .. missing in the Qt build.

        * jsc.pro:

xan@webkit.org's avatar
xan@webkit.org committed
2576
2577
2578
2579
2580
2581
2582
2583
2011-01-02  Xan Lopez  <xlopez@igalia.com>

        Fix GTK+ build.

        * GNUmakefile.am: add -I$(srcdir)/Source to the JSC cppflags so
        that anyone can include its headers without adding the prefix
        'Source/'.

2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2595
2596
2011-01-02  Carl Lobo  <carllobo@gmail.com>

        Reviewed by Adam Barth.

        Fix Windows Build for non-production where VSPropsRedirectionDir is not defined.
        https://bugs.webkit.org/show_bug.cgi?id=51797

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.vcproj/jsc/jsc.vcproj:
        * JavaScriptCore.vcproj/testapi/testapi.vcproj:

2597
2598
2599
2600
2601
2602
2603
2011-01-01  Adam Barth  <abarth@webkit.org>

        Fix relative include paths in an attempt to fix the Qt build.

        * JavaScriptCore.pri:
        * JavaScriptCore.pro:

2604
2605
2606
2607
2608
2609
2011-01-01  Adam Barth  <abarth@webkit.org>

        Another speculative build fix for GTK.

        * GNUmakefile.am:

2610
2611
2612
2613
2614
2615
2616
2011-01-01  Adam Barth  <abarth@webkit.org>

        Speculative build fix for GTK.  Update the paths in GNUmakefile to
        include "Source".

        * GNUmakefile.am:

2617
2618
2619
2620
2621
2622
2623
2011-01-01  Adam Barth  <abarth@webkit.org>

        Update relative paths in JavaScriptCore.gyp to account for the extra
        level of directories.

        * JavaScriptCore.gyp/JavaScriptCore.gyp:

2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2010-12-31  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Add a fast case for ASCII strings in HashAndUTF8CharactersTranslator::equal
        https://bugs.webkit.org/show_bug.cgi?id=50517

        This change shows about 2% performance win on the xml-parser benchmark.

        * wtf/text/AtomicString.cpp:
        (WTF::HashAndUTF8CharactersTranslator::equal):

2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2010-12-30  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Ariya Hidayat.

        [CMake] Add WTF_HEADERS
        https://bugs.webkit.org/show_bug.cgi?id=51741

        Add the WTF headers to show them in Visual Studio.

        * wtf/CMakeLists.txt:
        * wtf/CMakeListsWinCE.txt:

2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>

        Reviewed by David Kilzer.

        [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
        used
        https://bugs.webkit.org/show_bug.cgi?id=51672

        * wtf/wtf.pri: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1

2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2010-12-30  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Use OS(WINDOWS) instead of COMPILER(MSVC) in FastMalloc.cpp
        https://bugs.webkit.org/show_bug.cgi?id=51743

        Most of the ifdefs belong to windows and not to the MSVC compiler.

        * wtf/FastMalloc.cpp:

2669
2670
2671
2672
2673
2674
2675
2676
2677
2010-12-29  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig.

        Bug 51724 - In strict mode string literals should allow \0, but disallow \8 and \9.

        * parser/Lexer.cpp:
        (JSC::Lexer::parseString):

2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2010-12-29  Helder Correia  <helder@sencha.com>

        Reviewed by Eric Seidel.

        <VT> and <FF> are not valid JSON whitespace characters
        https://bugs.webkit.org/show_bug.cgi?id=51671

        Vertical Tab and Form Feed are not allowed white spaces by the JSON
        RFC 4627: http://www.ietf.org/rfc/rfc4627.txt (2. JSON Grammar).

        Tests: ietestcenter/Javascript/15.12.1.1-0-2.html
               ietestcenter/Javascript/15.12.1.1-0-3.html

        * runtime/LiteralParser.cpp:
        (JSC::isJSONWhiteSpace):
        (JSC::LiteralParser::Lexer::lex):

2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2706
2707
2010-12-28  Helder Correia  <helder@sencha.com>

        Reviewed by Eric Seidel.

        JSON.stringify must exist as a function taking 3 parameters
        https://bugs.webkit.org/show_bug.cgi?id=51667

        The reported function length is 1 instead.

        Test: ietestcenter/Javascript/15.12.3-0-2.html

        * runtime/JSONObject.cpp:

2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2010-12-28  Helder Correia  <helder@sencha.com>

        Reviewed by Sam Weinig.

        JSON.parse must exist as a function taking 2 parameters
        https://bugs.webkit.org/show_bug.cgi?id=51666

        Support for revivers was introduced in bug 26591, but the function
        length has since remained unchanged.

        Test: ietestcenter/Javascript/15.12.2-0-2.html

        * runtime/JSONObject.cpp:

2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2746
2747
2748
2749
2750
2751
2752
2753
2010-12-27  Jake Helfert  <jake@jakeonthenet.com>

        Reviewed and reworked by Darin Adler.

        Building WebKit with Visual Studio 2010 fails due
        to ambiguous assignment operator errors.
        https://bugs.webkit.org/show_bug.cgi?id=51116

        * wtf/NullPtr.h: Added a HAVE(NULLPTR) definition for use with
        Platform.h HAVE macro, and included the Visual Studio 2010 compiler
        as one of the ones that has nullptr.
        * wtf/NullPtr.cpp: Updated condition to match.
        
        * wtf/PassOwnArrayPtr.h: Don't include the operator=(nullptr_t)
        overload if we are compiling in loose mode and the compiler has
        nullptr, because assignment of 0 will otherwise encounter
        ambiguitity with this overload and the overload for loose mode
        that takes a raw pointer. The conditional can be removed when we
        get rid of loose mode.
        * wtf/PassOwnPtr.h: Ditto.

        * wtf/PassRefPtr.h: Don't include the operator=(nullptr_t) overload
        if the compiler has nullptr, because assignment of 0 would be
        ambiguous with the overload that takes a raw pointer. The conditional
        can be removed if we ever decide we no longer need to support
        assigning 0, but might need a way to catch that usage on older compilers.
        * wtf/RefPtr.h: Ditto.
        * wtf/RetainPtr.h: Ditto

        * JavaScriptCore.xcodeproj/project.pbxproj: Added NullPtr.cpp,
        accidentally omitted when the file was first added.

2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2010-12-26  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Add standalone target for JSC
        https://bugs.webkit.org/show_bug.cgi?id=51607

        * GNUmakefile.am: add convenience target to only build jsc and its
        dependencies.

2764
2765
2766
2767
2768
2769
2770
2771
2772
2773
2774
2010-12-24  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        [WINCE] Add CPU(MIPS) detection
        https://bugs.webkit.org/show_bug.cgi?id=51342

        WinCE usually defines MIPS and _MIPS_.

        * wtf/Platform.h:

2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2010-12-23  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig.

        Rename RegexCompiler.cpp to RegexPattern.cpp.
        Implicitly call compileRegex from RegexPattern's constructor.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/RegExp.cpp:
        (JSC::RegExp::compile):
        * yarr/RegexCompiler.cpp: Removed.
        * yarr/RegexCompiler.h: Removed.
        * yarr/RegexInterpreter.cpp:
        * yarr/RegexJIT.cpp:
        * yarr/RegexPattern.cpp: Copied from JavaScriptCore/yarr/RegexCompiler.cpp.
        (JSC::Yarr::compileRegex):
        (JSC::Yarr::RegexPattern::RegexPattern):
        * yarr/RegexPattern.h:

2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2010-12-23  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed build fix for WinCE after r74360.

        Move the OS(WINDOWS) section after the OS(WINCE) section
        and add missing argument to the getStackMax call.

        * wtf/StackBounds.cpp:
        (WTF::StackBounds::initialize):

2810
2811
2812
2813
2814
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2010-12-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix.

        [Symbian] Make sure OSAllocatorSymbian builds

        This patch only addresses the build problem.

        https://bugs.webkit.org/show_bug.cgi?id=51128 tracks the full
        (re)implementation of the Symbian allocator.

        * wtf/OSAllocatorSymbian.cpp:
        (WTF::OSAllocator::reserveUncommitted):
        (WTF::OSAllocator::reserveAndCommit):
        (WTF::OSAllocator::commit):

mitz@apple.com's avatar
mitz@apple.com committed
2826
2827
2828
2829
2830
2831
2010-12-22  Dan Bernstein  <mitz@apple.com>

        Changed WebKitTools to Tools.

        * JavaScriptCore.vcproj/JavaScriptCore.sln:

2832
2833
2834
2835
2836
2837
2838
2839
2010-12-22  Dan Bernstein  <mitz@apple.com>

        Rubber-stamped by Mark Rowe.

        Changed WebKitTools to Tools in script build phases.

        * JavaScriptCore.xcodeproj/project.pbxproj:

2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2010-12-22  Andrei Popescu  <andreip@google.com>

        Unreviewed build fix.

        Fix Chromium Linux shared library build.
        [Chromium] r74431 broke the Chromium Linux shared library build
        https://bugs.webkit.org/show_bug.cgi?id=51462

        * JavaScriptCore.gyp/JavaScriptCore.gyp:
        * JavaScriptCore.gypi:

2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2010-12-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74462.
        http://trac.webkit.org/changeset/74462
        https://bugs.webkit.org/show_bug.cgi?id=51449

        broke chromium win (Requested by tonyg-cr on #webkit).

        * JavaScriptCore.gypi:

2861
2862
2863
2864
2865
2866
2867
2868
2869
2010-12-21  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        [chromium] Build fix after r74431
        https://bugs.webkit.org/show_bug.cgi?id=51447

        * JavaScriptCore.gypi:

barraclough@apple.com's avatar
barraclough@apple.com committed
2870
2871
2872
2873
2874
2875
2010-12-21  Gavin Barraclough  <barraclough@apple.com>

        Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

barraclough@apple.com's avatar
barraclough@apple.com committed
2876
2877
2878
2879
2880
2881
2010-12-21  Gavin Barraclough  <barraclough@apple.com>

        Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

barraclough@apple.com's avatar
barraclough@apple.com committed
2882
2883
2884
2885
2886
2887
2888
2010-12-21  Gavin Barraclough  <barraclough@apple.com>

        Speculative build fix.

        * jit/ExecutableAllocator.cpp:
        (JSC::ExecutableAllocator::underMemoryPressure):