ChangeLog 1.42 MB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>

        [jhbuild] Correctly specify an alternate number of make jobs.
        https://bugs.webkit.org/show_bug.cgi?id=113396

        Reviewed by Philippe Normand.

        So far, we were using the `MAKEFLAGS' environment variable to pass the
        number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
        other hand, prefers to use the `jobs' variable from jhbuildrc for that.

        We now behave more closely to the rest of the WebKit tools by first
        checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
        not set, just letting jhbuild itself figure out how many jobs to use.

        * efl/jhbuildrc:
        * gtk/jhbuildrc:

19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
2013-03-27  Zeno Albisser  <zeno@webkit.org>

        [Qt] Remove Qt specific WorkQueueItem definitions.
        https://bugs.webkit.org/show_bug.cgi?id=112891

        This patch is preparation work for removing
        WorkQueue related code from TestRunnerQt and
        replacing it with generic TestRunner code.

        Reviewed by Benjamin Poulain.

        * DumpRenderTree/qt/TestRunnerQt.cpp:
        (TestRunnerQt::queueBackNavigation):
        (TestRunnerQt::queueForwardNavigation):
        (TestRunnerQt::queueLoadHTMLString):
        (TestRunnerQt::queueReload):
        (TestRunnerQt::queueLoadingScript):
        (TestRunnerQt::queueNonLoadingScript):
        (TestRunner::queueLoad):
        * DumpRenderTree/qt/TestRunnerQt.h:
        (TestRunnerQt):
        * DumpRenderTree/qt/WorkQueueItemQt.cpp:
        (LoadItem::invoke):
        (LoadHTMLStringItem::invoke):
        (LoadAlternateHTMLStringItem::invoke):
        (ReloadItem::invoke):
        (ScriptItem::invoke):
        (BackForwardItem::invoke):
        * DumpRenderTree/qt/WorkQueueItemQt.h:
        (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
        (LoadAlternateHTMLStringItem):

51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
2013-03-26  Julie Parent  <jparent@chromium.org>

        Flakiness dashboard: simplify logic around which tests to show.
        https://bugs.webkit.org/show_bug.cgi?id=113250

        Reviewed by Ojan Vafai.
        
        The different filters for showing results are only used for layout
        tests, otherwise, we show everything.
        
        Change the defaults to false (what layout tests used), and only
        look at the values when viewing layout tests.

        * TestResultServer/static-dashboards/flakiness_dashboard.js:
        (htmlForTestsWithExpectationsButNoFailures):
        (shouldHideTest):

68
69
70
71
72
73
74
75
76
2013-03-26  Isaac Levy  <ilevy@google.com>

        Update bots on test-results.appspot
        https://bugs.webkit.org/show_bug.cgi?id=113333

        Reviewed by Ojan Vafai.

        * TestResultServer/static-dashboards/builders.jsonp:

77
78
79
80
81
82
83
2013-03-26  Zan Dobersek  <zdobersek@igalia.com>

        Unreviewed GTK gardening.

        * Scripts/run-gtk-tests:
        (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.

84
85
86
87
88
89
90
91
92
93
2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>

        [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=113287

        Reviewed by Jocelyn Turcotte.

        * Scripts/run-qtwebkit-tests:
        (Options.__init__):

94
95
96
97
98
99
100
101
102
103
2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>

        [EFL] Enable IndexedDB by default
        https://bugs.webkit.org/show_bug.cgi?id=107248

        Reviewed by Laszlo Gombos.

        * Scripts/webkitperl/FeatureList.pm:
        Enable IndexedDB by default on EFL.

104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
2013-03-26  Alan Cutter  <alancutter@chromium.org>

        Sheriffbot should explain rollout failures in a human readable form.
        https://bugs.webkit.org/show_bug.cgi?id=107092

        Reviewed by Ryosuke Niwa.

        Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).

        * Scripts/webkitpy/tool/bot/irc_command.py:
        (Rollout._check_diff_failure):
        (Rollout.execute):
        * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
        (IRCCommandTest.test_rollout):

119
120
121
122
123
124
125
2013-03-26  Zan Dobersek  <zdobersek@igalia.com>

        Unreviewed GTK gardening.

        * Scripts/run-gtk-tests:
        (TestRunner): Skipping a failing unit test after r146518.

rniwa@webkit.org's avatar
rniwa@webkit.org committed
126
127
128
129
130
131
132
133
134
135
136
2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>

        Remove Lion leaks builder
        https://bugs.webkit.org/show_bug.cgi?id=113252

        Reviewed by Andreas Kling.

        Removed.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

137
138
139
140
141
142
143
144
145
146
147
148
149
150
2013-03-25  Kent Tamura  <tkent@chromium.org>

        Rename ENABLE_INPUT_TYPE_DATETIME
        https://bugs.webkit.org/show_bug.cgi?id=113254

        Reviewed by Kentaro Hara.

        Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
        Actually I'd like to remove the code, but we shouldn't remove it yet
        because we shipped products with it on some platforms.

        * Scripts/webkitperl/FeatureList.pm:
        * qmake/mkspecs/features/features.pri:

151
152
153
154
155
156
157
2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>

        Remove one more line that was intended to be removed in r146657.

        * Scripts/webkitpy/layout_tests/models/test_run_results.py:
        (summarize_results):

158
159
160
161
162
163
164
165
166
167
2013-03-25  Roger Fong  <roger_fong@apple.com>

        No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
        Re-enable WinEWS tests.

        * Scripts/webkitpy/common/config/ports.py:
        (WinPort.run_bindings_tests_command):
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (WinEWS):

168
169
170
171
172
173
174
175
176
177
178
2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r146793.
        http://trac.webkit.org/changeset/146793
        https://bugs.webkit.org/show_bug.cgi?id=113248

        Fix did not work (Requested by rfong on #webkit).

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (WinEWS):

179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>

        REGRESSION(r146657): Test failures reported incorrectly
        https://bugs.webkit.org/show_bug.cgi?id=113223

        Reviewed by Dirk Pranke.

        The bug was caused by BuildBotPrinter not taking the new behavior into account.

        Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
        treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager.run):

        * Scripts/webkitpy/layout_tests/models/test_run_results.py:
        (RunDetails.__init__):
        (summarize_results): Remove the line I intended to remove in r146657.

        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
        (logging_run): Return details instead of the exit code.
        (run_and_capture): Ditto.

        (RunTest.test_full_results_html):
        (RunTest.test_hung_thread):
        (RunTest.test_no_tests_found):
        (RunTest.test_no_tests_found_2):
        (RunTest.test_repeat_each_iterations_num_tests):
        (RunTest.test_run_singly_actually_runs_tests):
        (RunTest.test_test_list):
        (RunTest.test_missing_and_unexpected_results):
        (RunTest.test_pixel_test_directories):
        (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
        (RunTest.test_crash_with_stderr):
        (RunTest.test_no_image_failure_with_image_diff):
        (RunTest.test_crash_log):
        (RunTest.test_exit_after_n_failures_upload):
        (RunTest.test_results_directory_absolute):
        (RunTest.test_results_directory_relative):
        (RunTest.test_retrying_and_flaky_tests):
        (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
        (RunTest.test_retrying_uses_retries_directory):
        (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
        (RunTest.test_output_diffs):
        (EndToEndTest.test_reftest_with_two_notrefs):
        (RebaselineTest.test_reset_results):
        (RebaselineTest.test_missing_results):
        (RebaselineTest.test_new_baseline):

        * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
        (BuildBotPrinter.print_results):
        (BuildBotPrinter.print_unexpected_results):
        (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
        when we forced pixel tests in retry (i.e. pixel test was initially disabled).

234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
2013-03-25  Julie Parent  <jparent@chromium.org>

        Dashboard refactor: Move cross dashboard history related code into history.js.
        https://bugs.webkit.org/show_bug.cgi?id=113104

        Reviewed by Ojan Vafai.

        All functions relating to cross dashboard behavior move from being
        globals to methods on the history.History object. Names stay the same,
        except many are made private, ones that should have been constants now
        are, and the long standing TODO to change "currentState" to 
        dashboardSpecificState is done.
        
        We now create a global history object in dashboard_base, as an 
        intermediate measure.  Once the dashboard specific code is
        added to history, each DB will need to create its own, and this
        global will be eliminated.
        
        * TestResultServer/static-dashboards/aggregate_results.js:
        (handleValidHashParameter):
        (htmlForBuilder):
        (rawValuesHTML):
        * TestResultServer/static-dashboards/dashboard_base.js:
        (parseDashboardSpecificParameters):
        (defaultValue):
        (currentBuilderGroupCategory):
        (currentBuilderGroupName):
        (handleLocationChange):
        (expectationsMap):
        * TestResultServer/static-dashboards/flakiness_dashboard.js:
        (generatePage):
        (.switch.return):
        (platformAndBuildType):
        (individualTests):
        (substringList):
        (processMissingAndExtraExpectations):
        (pathToFailureLog):
        (showPopupForBuild):
        (htmlForTestsWithExpectationsButNoFailures):
        (shouldHideTest):
        (isCrossBuilderView):
        (tableHeaders):
        (htmlForSingleTestRow):
        (htmlForTableColumnHeader):
        (generatePageForExpectationsUpdate):
        (handleUpdate):
        (nextUpdate):
        (setUpdateIndex):
        (htmlForIndividualTestOnAllBuildersWithResultsLinks):
        (.appendExpectationsItem):
        (loadExpectations):
        (.dummyNode.onload):
        (loadExpectationsLayoutTests):
        (appendExpectations):
        (htmlForNavBar):
        (checkBoxToToggleState):
        (linkHTMLToToggleState):
        (generatePageForBuilder):
        (isInvalidKeyForCrossBuilderView):
        (handleQueryParameterChange):
        (showLegend):
        * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
        (resetGlobals):
        (test):
        * TestResultServer/static-dashboards/history.js:
        (.):
        * TestResultServer/static-dashboards/history_unittests.js:
        * TestResultServer/static-dashboards/loader.js:
        (.):
        * TestResultServer/static-dashboards/loader_unittests.js:
        * TestResultServer/static-dashboards/timeline_explorer.js:
        (generatePage):
        (initCurrentBuilderTestResults):
        (selectBuild):
        (showResultsDelta):
        * TestResultServer/static-dashboards/treemap.js:
        (generatePage):
        (.switch.return):
        (handleFocus):
        * TestResultServer/static-dashboards/ui.js:

315
316
317
318
319
320
321
2013-03-25  Roger Fong  <roger_fong@apple.com>

        Unreviewed. Enable WinEWS tests again.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (WinEWS):

322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>

        [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
        https://bugs.webkit.org/show_bug.cgi?id=112166

        HarfBuzz 0.9.14 merged my patch for icu detection without
        pkg-config files, as needed by for example Ubuntu 12.04.
        This obsoletes our local workaround. Removed it for GTK and EFL.

        Reviewed by Martin Robinson.

        * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
        * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
        * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
        * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.

338
339
340
341
342
343
2013-03-22  Kiran Muppala  <cmuppala@apple.com>

        Unreviewed.  Move self from contributor to committer list.

        * Scripts/webkitpy/common/config/committers.py:

344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>

        EWS should use a human readable port name when uploading layout test archives
        https://bugs.webkit.org/show_bug.cgi?id=113099

        Reviewed by Dirk Pranke.

        Use new port's object's name() method to report human readable port names.
        This will also help us resolving the bug to apply layout test results posted by EWS.

        * Scripts/webkitpy/tool/bot/botinfo.py:
        (BotInfo.__init__): Take port's name.
        (BotInfo.summary_text):

        * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
        (BotInfoTest.test_summary_text):

        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.

        * Scripts/webkitpy/tool/commands/queues.py:
        (PatchProcessingQueue.__init__): Initialize self._port.
        (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
        and use that for the attachment filename and the comment posted.

        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
        "mac-snowleopard" as expected for TestPort.

373
374
375
376
377
378
379
380
2013-03-22  Roger Fong  <roger_fong@apple.com>

        Unreviewed. Turn off EWS test on Win again.
        The battle continues.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (WinEWS):

381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>

        NRWT: Enable pixel tests when retrying tests
        https://bugs.webkit.org/show_bug.cgi?id=112898

        Reviewed by Dirk Pranke.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
        if we've forced pixel tests in the retry.
        (Manager._run_tests):
        (Manager._clean_up_run): Fixed the capitalizations.
        (Manager._force_pixel_tests_if_needed): Added.

        * Scripts/webkitpy/layout_tests/models/test_run_results.py:
        (_interpret_test_failures): Now that this function maybe called multiple times, only set
        'image_diff_percent' if it doesn't already exist.

        (summarize_results): When the first attempt resulted in a text failure and the second attempt
        resulted in image and text failures and we've forced to run pixel tests in the retry run,
        treat this as a regular regression instead of a flakiness.

        Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
        run had image diffs.

        * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
        (summarized_results):

        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
        (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
        Also removed some dead code.

        (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
        pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
        is set and pixel_tests_enabled is set to false.
        (EndToEndTest.test_reftest_with_two_notrefs):

418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
2013-03-22  Tim Horton  <timothy_horton@apple.com>

        Make it possible to run layout tests on Retina MBP
        https://bugs.webkit.org/show_bug.cgi?id=93673

        Reviewed by Ryosuke Niwa.

        Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
        windows on 2x machines still run at 1x.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (createWebViewAndOffscreenWindow):
        Reset the window resolution to 1x on creation.
        * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
        * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
        (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
        * WebKitTestRunner/mac/PlatformWebViewMac.mm:
        (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
        (WTR::PlatformWebView::PlatformWebView):
        Add NSWindow details, reset the window resolution to 1x on creation.

rniwa@webkit.org's avatar
rniwa@webkit.org committed
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>

        Leak bots shouldn't build
        https://bugs.webkit.org/show_bug.cgi?id=112774

        Reviewed by Simon Fraser.

        Since leak bots use regular debug builds, there is no need to build on these bots.
        Simply downloading builds will dramatically improve the cycle time of these bots.

        * BuildSlaveSupport/build.webkit.org-config/config.json:
        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
        TestFactory instead of BuildAndTestFactory.

454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>

        [Qt] Fix the TestWebKitAPI build
        https://bugs.webkit.org/show_bug.cgi?id=113044

        Reviewed by Tor Arne Vestbø.

        The generate-forwarding-headers script would only be run
        after the targets in InjectedBundle.pri since the second
        addStrictSubdirOrderBetween call in
        Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
        the derived_sources -> injected_bundle order in SUBDIRS.

        Fix it by only moving the dependent target at the end of
        SUBDIRS, don't touch its dependency.

        * qmake/mkspecs/features/functions.prf:

472
473
474
475
476
477
478
479
480
481
482
483
484
485
2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>

        [EFL][WK2] View is not focused when fullscreen mode toggled
        https://bugs.webkit.org/show_bug.cgi?id=113009

        Reviewed by Laszlo Gombos.

        Set focus on view when fullscreen mode enabled/disabled
        by FullScreen API.

        * MiniBrowser/efl/main.c:
        (on_fullscreen_accept):
        (on_fullscreen_deny):

486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
2013-03-21  Dirk Pranke  <dpranke@chromium.org>

        nrwt is no longer saving retry results in the retries/ subdirectory
        https://bugs.webkit.org/show_bug.cgi?id=112995

        Reviewed by Ojan Vafai.

        I think this has been broken a long time, unfortunately. This
        patch should fix that.

        In order to do so, I had to pass the directory to use from
        the Worker object through the SingleTestWriter to the
        TestResultWriter. While I was plumbing that through, I rationalized
        the order of the parameter arguments a bit ...

        * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
        (Worker._run_single_test):
        * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
        (run_single_test):
        (SingleTestRunner.__init__):
        (SingleTestRunner._run_compare_test):
        (SingleTestRunner._run_rebaseline):
        (SingleTestRunner._run_reftest):
        * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
        (write_test_result):
        * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
        (TestResultWriterTest.test_reftest_diff_image):
        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
        (RunTest.test_retrying_uses_retries_directory):

516
517
518
519
520
521
522
523
524
2013-03-21  Filip Pizlo  <fpizlo@apple.com>

        JSC profiler should have an at-a-glance report of the success of DFG optimization
        https://bugs.webkit.org/show_bug.cgi?id=112988

        Reviewed by Geoffrey Garen.

        * Scripts/display-profiler-output:

525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
2013-03-21  Dirk Pranke  <dpranke@chromium.org>

        [chromium] Linux ASAN WebKit canary is running out of memory
        https://bugs.webkit.org/show_bug.cgi?id=112978

        Reviewed by Tony Chang.

        Running the AddressSanitizer on a crash takes a lot of
        memory, so we should serialize access to it to avoid running
        out of memory on a machine.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        (ChromiumPort._get_crash_log):
        * Scripts/webkitpy/layout_tests/port/http_lock.py:
        (HttpLock.__init__):
        (HttpLock.wait_for_httpd_lock):

542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
2013-03-21  Min Qin  <qinmin@chromium.org>

        Cleanup android media layout test code
        https://bugs.webkit.org/show_bug.cgi?id=112944

        Reviewed by Adam Barth.

        Chromium change: https://codereview.chromium.org/12892010/
        The current android layout tests are using WebmediaPlayerInProcessAndroid class.
        The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
        It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
        Instead, we should switch to use content shell for layout tests.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetTestController):

558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
2013-03-21  Dirk Pranke  <dpranke@chromium.org>

        [chromium] add missing project dependencies to DRT to fix Mac Valgrind
        https://bugs.webkit.org/show_bug.cgi?id=112953

        Reviewed by Tony Chang.

        When I created the DumpRenderTree_resources target in r144863 I
        forgot to declare the needed dependencies on the other resource
        targets. Due to a quirk of ordering, this appears to have been fine
        w/ ninja but not w/ Xcode (which is still being used on the chromium
        mac valgrind bots). Declaring the dependencies fixes the build
        failures.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

574
575
576
577
578
579
580
581
582
583
584
2013-03-21  Brent Fulgham  <bfulgham@webkit.org>

        [WinCairo] Correct assert in Empty BitmapImage Test.
        https://bugs.webkit.org/show_bug.cgi?id=112934

        Reviewed by Tim Horton.

        * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
        (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
        to avoid ref counting assertion when leaving test scope.

585
586
587
588
589
590
591
592
593
594
595
596
597
598
2013-03-21  Zan Dobersek  <zdobersek@igalia.com>

        [GTK] generate-feature-defines-files is incompatible with Python3
        https://bugs.webkit.org/show_bug.cgi?id=112956

        Reviewed by Martin Robinson.

        Make the generate-feature-defines-files compatible with Python3 by calling the items()
        method on the dictionary objects when iterating through said dictionaries.

        * gtk/generate-feature-defines-files:
        (write_feature_defines_header):
        (write_flattened_feature_defines_file):

599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>

        kill-old-processes spits out error messages on Mac
        https://bugs.webkit.org/show_bug.cgi?id=112878

        Reviewed by Jessie Berlin.

        Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
        included in the list of options grep --help shows.

        Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.

        * BuildSlaveSupport/kill-old-processes:
        (main):

614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
2013-03-21  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
        https://bugs.webkit.org/show_bug.cgi?id=112597

        Reviewed by Xan Lopez.

        These were introduced for the Chromium port in r105295. We need
        dummy implementations in order to compile the BlackBerry port.

        * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
        (AccessibilityUIElement::scrollToMakeVisible):
        (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
        (AccessibilityUIElement::scrollToGlobalPoint):

629
630
631
632
633
634
635
2013-03-21  Roger Fong  <roger_fong@apple.com>

        Re-enable WinEWS tests following r146376.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (WinEWS):

636
637
638
639
640
641
2013-03-21  Zoltan Horvath  <zoltan@webkit.org>

        Unreviewed. Add Bem Jones-Bey to the list of contributors.

        * Scripts/webkitpy/common/config/committers.py:

642
643
644
645
646
647
648
649
650
2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>

        [GTK] Missing atk in install-dependencies script
        https://bugs.webkit.org/show_bug.cgi?id=112272

        Reviewed by Gustavo Noronha Silva.

        * gtk/install-dependencies: Add missing atk dependency.

651
652
653
654
655
656
657
658
659
660
2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>

        [GTK] Missing backslash in install-dependencies script
        https://bugs.webkit.org/show_bug.cgi?id=112907

        Reviewed by Philippe Normand.

        * gtk/install-dependencies: Add missing backslash to dependencies
        list.

661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>

        EWS bots have stopped uploading results to bugzilla
        https://bugs.webkit.org/show_bug.cgi?id=101091

        Reviewed by Adam Barth.

        The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
        to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
        this relative file path resoled to a file inside a non-existent directory for "zip".

        Fixed the bug by resolving both test results directory and zip archive paths in
        LayoutTestResultsReader.archive.

        Also made workspace.create_zip print the source_path so that we may debug these issues more easily
        in the future.

        * Scripts/webkitpy/common/system/filesystem_mock.py:
        (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".

        * Scripts/webkitpy/common/system/workspace.py:
        (Workspace.create_zip): Log the source path when "zip" failed.

        * Scripts/webkitpy/common/system/workspace_mock.py:
        (MockWorkspace.create_zip): Record zip_path and source_path for testing.

        * Scripts/webkitpy/common/system/workspace_unittest.py:
        (WorkspaceTest.test_create_zip_exception): Test that.

        * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
        (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
        This is the actual bug fix.

        * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
        (test_archive_last_layout_test_results_with_relative_path): Added a test case.

697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
2013-03-20  Jochen Eisinger  <jochen@chromium.org>

        [chromium] move WebThemeEngine implementations to TestRunner library
        https://bugs.webkit.org/show_bug.cgi?id=112751

        Reviewed by Adam Barth.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
        (WebKit):
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
        (WebTestRunner::TestInterfaces::themeEngine):
        (WebTestRunner):
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
        (WebKit):
        (TestInterfaces):
        * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
        (WebTestRunner::WebTestInterfaces::themeEngine):
        (WebTestRunner):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
        (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
        (WebTestRunner):
        (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
        (WebTestRunner::WebTestThemeControlWin::box):
        (WebTestRunner::WebTestThemeControlWin::line):
        (WebTestRunner::WebTestThemeControlWin::triangle):
        (WebTestRunner::WebTestThemeControlWin::roundRect):
        (WebTestRunner::WebTestThemeControlWin::oval):
        (WebTestRunner::WebTestThemeControlWin::circle):
        (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
        (WebTestRunner::WebTestThemeControlWin::markState):
        (WebTestRunner::WebTestThemeControlWin::draw):
        (WebTestRunner::WebTestThemeControlWin::drawTextField):
        (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
        (WebTestRunner):
        (WebTestThemeControlWin):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
        (WebTestRunner):
        (WebTestThemeEngineMac):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
        (+[FakeActiveWindow alwaysActiveWindow]):
        (+[FakeActiveWindow alwaysInactiveWindow]):
        (-[FakeActiveWindow initWithActiveControls:]):
        (-[FakeActiveWindow _hasActiveControls]):
        (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
        (WebTestRunner):
        (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
        (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
        (WebTestRunner::WebTestThemeEngineWin::paintButton):
        (WebTestRunner):
        (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
        (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
        (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
        (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
        (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
        (WebTestRunner::WebTestThemeEngineWin::paintTextField):
        (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
        (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
        (WebTestRunner::WebTestThemeEngineWin::getSize):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
        (WebTestRunner):
        (WebTestThemeEngineWin):
        (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::initialize):
        * DumpRenderTree/chromium/TestShell.h:
        (WebKit):
        * DumpRenderTree/chromium/TestShellMac.mm:
        (platformInit):
        * DumpRenderTree/chromium/TestShellWin.cpp:
        (platformInit):
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.

773
774
775
776
777
778
779
780
781
782
783
784
2013-03-20  Brent Fulgham  <bfulgham@webkit.org>

        [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010

        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
        New property sheet that does not link against CoreFoundation and
        CFNetwork.
        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
        Use new TestWebKitAPICommonWinCairo property sheet.
        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
        Ditto.

785
786
787
788
789
790
791
792
793
794
795
796
797
798
2013-03-20  Brent Fulgham  <bfulgham@webkit.org>

        [WinCairo] Unreviewed build fix for VS2010.

        Had to add WinCairo-specific property sheets to deal with some
        library and path differences with the main Apple port.

        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
        * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
        * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
        * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.

799
800
801
802
803
804
805
806
807
808
809
2013-03-20  Benjamin Poulain  <bpoulain@apple.com>

        [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=112849

        Reviewed by Sam Weinig.

        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        * WebKitTestRunner/InjectedBundle/TestRunner.h:

810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
2013-03-20  Brent Fulgham  <bfulgham@webkit.org>

        [WinCairo] Build WebKit Tools under VS2010
        https://bugs.webkit.org/show_bug.cgi?id=112821

        Reviewed by Tim Horton.

        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
        Add WinCairo-specific build target.
        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
        * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
        Add WinCairo-specific build target.
        * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
        * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
        Add WinCairo-specific build target.
        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
        WinCairo-specific build target.
        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
        * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
        specific build target.
        * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
        WinCairo-specific build target.
        * win/record-memory/record-memory.vcxproj: Add WinCairo target.
        * win/record-memory/record-memoryDebugWinCairo.props: Added.
        * win/record-memory/record-memoryReleaseWinCairo.props: Added.

840
841
842
843
844
845
846
847
848
2013-03-20  Roger Fong  <roger_fong@apple.com>

        API test gardening AppleWin port.

        The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.

        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
        * TestWebKitAPI/win/TestWebKitAPI.vcproj:

849
850
851
852
853
854
2013-03-20  Roger Fong  <roger_fong@apple.com>

        Test fix for Win EWS bots, catch various errors and restart script if necessary.

        * EWSTools/start-queue-win.sh:

855
856
857
858
2013-03-20  Sami Kyostila  <skyostil@chromium.org>

        Unreviewed, add myself to committers.py.

859
860
861
862
863
864
2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Unreviewed. Adding another email for me.

        * Scripts/webkitpy/common/config/committers.py:

865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
2013-03-20  Justin Novosad  <junov@google.com>

        [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
        https://bugs.webkit.org/show_bug.cgi?id=112605

        Reviewed by James Robinson.

        Deleting all the code that was used for propagating and supporting
        the Chromium setting for disabling deferred 2d canvas rendering.

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (main):
        * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
        * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
        (WebTestRunner::WebPreferences::reset):
        (WebTestRunner::WebPreferences::applyTo):
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        (TestShell::resetWebSettings):
        (TestShell::runFileTest):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell):

888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>

        [Qt] Qt 4.8 tool related stuff removal from webkitpy.
        https://bugs.webkit.org/show_bug.cgi?id=112699.

        Reviewed by Adam Barth.

        * Scripts/webkitpy/layout_tests/port/qt.py:
        (QtPort._search_paths):
        (QtPort._port_specific_expectations_files):
        * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
        (QtPortTest):
        (QtPortTest._assert_search_path):
        (QtPortTest._assert_expectations_files):

903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        [Qt] Enable kerning by default
        https://bugs.webkit.org/show_bug.cgi?id=112704

        Reviewed by Jocelyn Turcotte.

        Disable kerning by default, since some reference test expectations
        expect kerning to be default off.

        * DumpRenderTree/qt/TestRunnerQt.cpp:
        (TestRunnerQt::reset):
        * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
        (WTR::activateFonts):

918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
2013-03-20  Zeno Albisser  <zeno@webkit.org>

        [Qt] Remove empty function stubs from TestRunnerQt.
        https://bugs.webkit.org/show_bug.cgi?id=112799

        We are reducing the code in TestRunnerQt step by step,
        in order to finally replace all of it with the generic
        TestRunner implementation.
        This patch removes several simple function stubs that
        currently do not implement any actual functionality.

        Reviewed by Kenneth Rohde Christiansen.

        * DumpRenderTree/qt/TestRunnerQt.cpp:
        * DumpRenderTree/qt/TestRunnerQt.h:
        (TestRunnerQt):

935
936
937
938
939
940
941
942
943
944
945
946
2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>

        [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
        https://bugs.webkit.org/show_bug.cgi?id=112687

        Reviewed by Kenneth Rohde Christiansen.

        Hide the SearchBar by default on window creation.

        * MiniBrowser/efl/main.c:
        (window_create):

947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r146304.
        http://trac.webkit.org/changeset/146304
        https://bugs.webkit.org/show_bug.cgi?id=112788

        to many expectations to update (Requested by antonm on
        #webkit).

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
        (WebKit):
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
        (TestInterfaces):
        * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::initialize):
        * DumpRenderTree/chromium/TestShell.h:
        (WebKit):
        * DumpRenderTree/chromium/TestShellMac.mm:
        (platformInit):
        * DumpRenderTree/chromium/TestShellWin.cpp:
        (platformInit):
        * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
        (WebThemeControlDRTWin::WebThemeControlDRTWin):
        (WebThemeControlDRTWin::~WebThemeControlDRTWin):
        (WebThemeControlDRTWin::box):
        (WebThemeControlDRTWin::line):
        (WebThemeControlDRTWin::triangle):
        (WebThemeControlDRTWin::roundRect):
        (WebThemeControlDRTWin::oval):
        (WebThemeControlDRTWin::circle):
        (WebThemeControlDRTWin::nestedBoxes):
        (WebThemeControlDRTWin::markState):
        (WebThemeControlDRTWin::draw):
        (WebThemeControlDRTWin::drawTextField):
        (WebThemeControlDRTWin::drawProgressBar):
        * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
        (WebThemeControlDRTWin):
        * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
        (WebThemeEngineDRTMac):
        * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
        (+[FakeActiveWindow alwaysActiveWindow]):
        (+[FakeActiveWindow alwaysInactiveWindow]):
        (-[FakeActiveWindow initWithActiveControls:]):
        (-[FakeActiveWindow _hasActiveControls]):
        (WebThemeEngineDRTMac::paintScrollbarThumb):
        (stateToHIEnableState):
        (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
        (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
        (webRectToSkIRect):
        (drawControl):
        (drawTextField):
        (drawProgressBar):
        (WebThemeEngineDRTWin::paintButton):
        (WebThemeEngineDRTWin::paintMenuList):
        (WebThemeEngineDRTWin::paintScrollbarArrow):
        (WebThemeEngineDRTWin::paintScrollbarThumb):
        (WebThemeEngineDRTWin::paintScrollbarTrack):
        (WebThemeEngineDRTWin::paintSpinButton):
        (WebThemeEngineDRTWin::paintTextField):
        (WebThemeEngineDRTWin::paintTrackbar):
        (WebThemeEngineDRTWin::paintProgressBar):
        (WebThemeEngineDRTWin::getSize):
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
        (WebThemeEngineDRTWin):
        (WebThemeEngineDRTWin::WebThemeEngineDRTWin):

1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        [Qt] Support -webkit-font-smoothing
        https://bugs.webkit.org/show_bug.cgi?id=106009

        Reviewed by Jocelyn Turcotte.

        Set shouldUseFontSmoothing to false to match WebKitTestRunner.

        * DumpRenderTree/qt/TestRunnerQt.cpp:
        (TestRunnerQt::reset):

1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
2013-03-20  Krzysztof Czech  <k.czech@samsung.com>

        [GTK] accessibility/aria-scrollbar-role.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=98358

        Reviewed by Martin Robinson.

        Adds support for checking accessibility object's orientation.
        Orientation is checked by retrieving proper state of accessibility object.

        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
        (checkElementState):
        (AccessibilityUIElement::orientation):
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        (WTR::AccessibilityUIElement::orientation):

1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
2013-03-19  Jochen Eisinger  <jochen@chromium.org>

        [chromium] move WebThemeEngine implementations to TestRunner library
        https://bugs.webkit.org/show_bug.cgi?id=112751

        Reviewed by Adam Barth.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
        (WebKit):
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
        (WebTestRunner::TestInterfaces::themeEngine):
        (WebTestRunner):
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
        (WebKit):
        (TestInterfaces):
        * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
        (WebTestRunner::WebTestInterfaces::themeEngine):
        (WebTestRunner):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
        (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
        (WebTestRunner):
        (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
        (WebTestRunner::WebTestThemeControlWin::box):
        (WebTestRunner::WebTestThemeControlWin::line):
        (WebTestRunner::WebTestThemeControlWin::triangle):
        (WebTestRunner::WebTestThemeControlWin::roundRect):
        (WebTestRunner::WebTestThemeControlWin::oval):
        (WebTestRunner::WebTestThemeControlWin::circle):
        (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
        (WebTestRunner::WebTestThemeControlWin::markState):
        (WebTestRunner::WebTestThemeControlWin::draw):
        (WebTestRunner::WebTestThemeControlWin::drawTextField):
        (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
        (WebTestRunner):
        (WebTestThemeControlWin):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
        (WebTestRunner):
        (WebTestThemeEngineMac):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
        (+[FakeActiveWindow alwaysActiveWindow]):
        (+[FakeActiveWindow alwaysInactiveWindow]):
        (-[FakeActiveWindow initWithActiveControls:]):
        (-[FakeActiveWindow _hasActiveControls]):
        (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
        (WebTestRunner):
        (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
        (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
        (WebTestRunner::WebTestThemeEngineWin::paintButton):
        (WebTestRunner):
        (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
        (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
        (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
        (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
        (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
        (WebTestRunner::WebTestThemeEngineWin::paintTextField):
        (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
        (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
        (WebTestRunner::WebTestThemeEngineWin::getSize):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
        (WebTestRunner):
        (WebTestThemeEngineWin):
        (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::initialize):
        * DumpRenderTree/chromium/TestShell.h:
        (WebKit):
        * DumpRenderTree/chromium/TestShellMac.mm:
        (platformInit):
        * DumpRenderTree/chromium/TestShellWin.cpp:
        (platformInit):
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.

1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
2013-03-19  Tony Chang  <tony@chromium.org>

        Move testRunner.setTouchDragDropEnabled to internals.settings
        https://bugs.webkit.org/show_bug.cgi?id=112739

        Reviewed by Adam Barth.

        * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
        (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
        * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
        (TestRunner): Remove unnecessary code.
        * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
        (WebTestRunner::WebPreferences::reset):
        (WebTestRunner::WebPreferences::applyTo): Always set to false.

1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>

        [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
        https://bugs.webkit.org/show_bug.cgi?id=112754

        Reviewed by Darin Fisher.

        Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
        now that it's always defined.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        * DumpRenderTree/chromium/WebViewHost.h:
        (WebViewHost):

1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
2013-03-19  Kenneth Russell  <kbr@google.com>

        Unreviewed, rolling out r146290.
        http://trac.webkit.org/changeset/146290
        https://bugs.webkit.org/show_bug.cgi?id=112751

        Broke Chromium Mac build.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
        (WebKit):
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
        (TestInterfaces):
        * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::initialize):
        * DumpRenderTree/chromium/TestShell.h:
        (WebKit):
        * DumpRenderTree/chromium/TestShellMac.mm:
        (platformInit):
        * DumpRenderTree/chromium/TestShellWin.cpp:
        (platformInit):
        * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
        (WebThemeControlDRTWin::WebThemeControlDRTWin):
        (WebThemeControlDRTWin::~WebThemeControlDRTWin):
        (WebThemeControlDRTWin::box):
        (WebThemeControlDRTWin::line):
        (WebThemeControlDRTWin::triangle):
        (WebThemeControlDRTWin::roundRect):
        (WebThemeControlDRTWin::oval):
        (WebThemeControlDRTWin::circle):
        (WebThemeControlDRTWin::nestedBoxes):
        (WebThemeControlDRTWin::markState):
        (WebThemeControlDRTWin::draw):
        (WebThemeControlDRTWin::drawTextField):
        (WebThemeControlDRTWin::drawProgressBar):
        * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
        (WebThemeControlDRTWin):
        * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
        (WebThemeEngineDRTMac):
        * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
        (+[FakeActiveWindow alwaysActiveWindow]):
        (+[FakeActiveWindow alwaysInactiveWindow]):
        (-[FakeActiveWindow initWithActiveControls:]):
        (-[FakeActiveWindow _hasActiveControls]):
        (WebThemeEngineDRTMac::paintScrollbarThumb):
        (stateToHIEnableState):
        (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
        (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
        (webRectToSkIRect):
        (drawControl):
        (drawTextField):
        (drawProgressBar):
        (WebThemeEngineDRTWin::paintButton):
        (WebThemeEngineDRTWin::paintMenuList):
        (WebThemeEngineDRTWin::paintScrollbarArrow):
        (WebThemeEngineDRTWin::paintScrollbarThumb):
        (WebThemeEngineDRTWin::paintScrollbarTrack):
        (WebThemeEngineDRTWin::paintSpinButton):
        (WebThemeEngineDRTWin::paintTextField):
        (WebThemeEngineDRTWin::paintTrackbar):
        (WebThemeEngineDRTWin::paintProgressBar):
        (WebThemeEngineDRTWin::getSize):
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
        (WebThemeEngineDRTWin):
        (WebThemeEngineDRTWin::WebThemeEngineDRTWin):

1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
2013-03-19  Krzysztof Czech  <k.czech@samsung.com>

        [EFL] canvas-fallback-content.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=111998

        Reviewed by Chris Fleizach.

        Adds support for getting platform name.

        * DumpRenderTree/TestRunner.cpp:
        (TestRunner::staticValues):
        * DumpRenderTree/TestRunner.h:
        (TestRunner):
        * DumpRenderTree/efl/TestRunnerEfl.cpp:
        (TestRunner::platformName):

1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
2013-03-19  Jochen Eisinger  <jochen@chromium.org>

        [chromium] move WebThemeEngine implementations to TestRunner library
        https://bugs.webkit.org/show_bug.cgi?id=112751

        Reviewed by Adam Barth.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
        (WebKit):
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
        (WebTestRunner::TestInterfaces::themeEngine):
        (WebTestRunner):
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
        (WebKit):
        (TestInterfaces):
        * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
        (WebTestRunner::WebTestInterfaces::themeEngine):
        (WebTestRunner):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
        (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
        (WebTestRunner):
        (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
        (WebTestRunner::WebTestThemeControlWin::box):
        (WebTestRunner::WebTestThemeControlWin::line):
        (WebTestRunner::WebTestThemeControlWin::triangle):
        (WebTestRunner::WebTestThemeControlWin::roundRect):
        (WebTestRunner::WebTestThemeControlWin::oval):
        (WebTestRunner::WebTestThemeControlWin::circle):
        (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
        (WebTestRunner::WebTestThemeControlWin::markState):
        (WebTestRunner::WebTestThemeControlWin::draw):
        (WebTestRunner::WebTestThemeControlWin::drawTextField):
        (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
        (WebTestRunner):
        (WebTestThemeControlWin):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
        (WebTestRunner):
        (WebTestThemeEngineMac):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
        (+[FakeActiveWindow alwaysActiveWindow]):
        (+[FakeActiveWindow alwaysInactiveWindow]):
        (-[FakeActiveWindow initWithActiveControls:]):
        (-[FakeActiveWindow _hasActiveControls]):
        (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
        (WebTestRunner):
        (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
        (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
        (WebTestRunner::WebTestThemeEngineWin::paintButton):
        (WebTestRunner):
        (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
        (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
        (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
        (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
        (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
        (WebTestRunner::WebTestThemeEngineWin::paintTextField):
        (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
        (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
        (WebTestRunner::WebTestThemeEngineWin::getSize):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
        (WebTestRunner):
        (WebTestThemeEngineWin):
        (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::initialize):
        * DumpRenderTree/chromium/TestShell.h:
        (WebKit):
        * DumpRenderTree/chromium/TestShellMac.mm:
        (platformInit):
        * DumpRenderTree/chromium/TestShellWin.cpp:
        (platformInit):
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.

1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>

        [EFL][WK2] Separate WebView further from EwkView
        https://bugs.webkit.org/show_bug.cgi?id=111591

        Reviewed by Caio Marcelo de Oliveira Filho.

        Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
        PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
        since we can afford it having EWKViewGetWKView() private API to access WKView.

        * TestWebKitAPI/PlatformWebView.h:
        * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
        (TestWebKitAPI::TEST):
        * TestWebKitAPI/efl/PlatformWebView.cpp:
        (TestWebKitAPI::PlatformWebView::PlatformWebView):
        (TestWebKitAPI::PlatformWebView::~PlatformWebView):
        (TestWebKitAPI::PlatformWebView::resizeTo):
        (TestWebKitAPI::PlatformWebView::page):
        (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
        (TestWebKitAPI::PlatformWebView::simulateMouseMove):
        (TestWebKitAPI::PlatformWebView::simulateRightClick):
        * WebKitTestRunner/PlatformWebView.h:
        * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
        (WTR::EventSenderProxy::dispatchEvent):
        (WTR::EventSenderProxy::keyDown):
        (WTR::EventSenderProxy::sendTouchEvent):
        (WTR::EventSenderProxy::setTouchModifier):
        * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
        (WTR::PlatformWebView::PlatformWebView):
        (WTR::PlatformWebView::~PlatformWebView):
        (WTR::PlatformWebView::resizeTo):
        (WTR::PlatformWebView::page):
        (WTR::PlatformWebView::focus):
        (WTR::PlatformWebView::windowSnapshotImage):

1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
2013-03-19  Roger Fong  <roger_fong@apple.com>

        Changes to VS2010 project files should only trigger builds on Windows bots.
        https://bugs.webkit.org/show_bug.cgi?id=112731

        Reviewed by Timothy Horton.

        * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
        (_should_file_trigger_build):

1361
1362
1363
1364
1365
1366
1367
1368
1369
2013-03-19  Roger Fong  <roger_fong@apple.com>

        Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.

        * Scripts/webkitpy/tool/steps/runtests.py:
        (RunTests.run):
        * Scripts/webkitpy/tool/steps/runtests_unittest.py:
        (RunTestsTest.test_webkit_run_unit_tests):

1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
2013-03-19  Julie Parent  <jparent@chromium.org>

        Dashboards: Introduce history namespace and unit tests.
        https://bugs.webkit.org/show_bug.cgi?id=112645

        Reviewed by Ojan Vafai.
        
        Laying the framework for introducing the new history object and
        namespace.  This moves only static functions into the history
        namespace, and moves corresponding unit tests into seperate
        unit test file.

        * TestResultServer/static-dashboards/aggregate_results.html:
        * TestResultServer/static-dashboards/dashboard_base.js:
        (parseCrossDashboardParameters):
        (parseDashboardSpecificParameters):
        (parseParameters):
        * TestResultServer/static-dashboards/flakiness_dashboard.html:
        * TestResultServer/static-dashboards/flakiness_dashboard.js:
        (.switch.return):
        * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
        * TestResultServer/static-dashboards/history.js: Added.
        * TestResultServer/static-dashboards/history_unittests.js: Added.
        * TestResultServer/static-dashboards/loader.js:
        (.):
        * TestResultServer/static-dashboards/run-embedded-unittests.html:
        * TestResultServer/static-dashboards/run-unittests.html:
        * TestResultServer/static-dashboards/timeline_explorer.html:
        * TestResultServer/static-dashboards/timeline_explorer.js:
        * TestResultServer/static-dashboards/treemap.html:
        * TestResultServer/static-dashboards/treemap.js:
        (.switch.return):
        * TestResultServer/static-dashboards/ui.js:

1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
2013-03-19  Daniel Bates  <dbates@webkit.org>

        svn-apply has trouble applying a patch that adds a Windows newline to EOF
        https://bugs.webkit.org/show_bug.cgi?id=112732

        Reviewed by Eric Seidel.

        Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
        of an existing file cannot be applied.

        In particular, svn-{apply, unapply} compensate for differences in line endings
        by converting the line endings in a diff to match the line endings in the target
        file. The diff(1) command precedes the last line of a diff that adds a newline
        character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
        Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
        to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
        when applying this modified diff. Instead, svn-{apply, unapply} should not modify
        the newline characters in this special character sequence to match the line endings
        in the target file.

        * Scripts/VCSUtils.pm:
        (parseDiff):
        * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
        Added tests:
            - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
            - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
            - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
            - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
        (escapeNewLineCharacters): Added.
        (toMacLineEndings): Added.

1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
2013-03-19  James Robinson  <jamesr@chromium.org>

        [chromium] Remove compositor settings that don't go through WebKit
        https://bugs.webkit.org/show_bug.cgi?id=112718

        Reviewed by Adam Barth.

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (main):
        * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
        * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
        (WebTestRunner::WebPreferences::reset):
        (WebTestRunner::WebPreferences::applyTo):
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        (TestShell::resetWebSettings):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell):

1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
2013-03-19  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, rolling out r146101.
        https://bugs.webkit.org/show_bug.cgi?id=111884

        re-enable custom freetype on asan; this needs to be on
        now that the bot is running lucid.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
2013-03-19  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] Enable USE_SYSTEM_MALLOC by default
        https://bugs.webkit.org/show_bug.cgi?id=112365

        Reviewed by Benjamin Poulain.

        Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
        harcoding it in wtf/Platform.h

        * Scripts/webkitperl/FeatureList.pm:

1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        [Qt] Make ImageDiff similar to Chromium's ImageDiff
        https://bugs.webkit.org/show_bug.cgi?id=94782

        Based on patch by Csaba Osztrogonác.
        Reviewed by Jocelyn Turcotte.

        The diff image is generated with bright red indicating errors, but letting the base image
        shine through so the context of the error-pixel can be identified.

        * DumpRenderTree/qt/ImageDiff.cpp:
        (main):

1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
2013-03-18  Andras Becsi  <andras.becsi@digia.com>

        [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt

        Rubber-stamped by Csaba Osztrogonác.

        Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
        since the latter might not cover the former.

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::print):

1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
2013-03-18  Simon Fraser  <simon.fraser@apple.com>

        Style tweeks to default.css.
        
        Rubber-stamped by David Kilzer.
        
        Give visited links a different color to other links, so you can
        see which builds you've viewed.
        
        Make the <small> text less tiny.

        * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
        (small):
        (a:link,a:visited,a:active):
        (a:visited):

1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>

        Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
        https://bugs.webkit.org/show_bug.cgi?id=112494

        Reviewed by Dirk Pranke.

        Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
        Also merged two pairs of methods to cleanup the code.

        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
        (PerfTestsRunner.run): Merged _upload_and_show_results.
        (PerfTestsRunner._generate_results): Merged _generate_output_files.

1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
2013-03-18  Dirk Pranke  <dpranke@chromium.org>

        [chromium] build xdisplaycheck when building DRT
        https://bugs.webkit.org/show_bug.cgi?id=112636

        Reviewed by Tony Chang.

        It appears that we need xdisplaycheck to be built in order for
        Xvfb to be started correctly on the bots, and DRT was missing
        a dependency on it. This may be the cause of the ASAN bot not
        starting up properly (it only builds DRT).

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
2013-03-18  David Levin  <levin@chromium.org>

        Implement icon change notification dump for Chromium's test shell.
        https://bugs.webkit.org/show_bug.cgi?id=112614

        This was previously implemented for some other platforms in r58111
        and r116547.

        In r122806, fast/dom/icon-url-property.html stopped using it, but
        it is useful for tests, so I plan to re-add it to that test again.

        Reviewed by Jochen Eisinger.

        * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
        (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
         icon change notifications from WebKit may be logged in test output.
        * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
        (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
        (WebTestRunner::TestRunner::reset): Clear the new dump variable.
        (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
        (WebTestRunner):
        (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
        * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
        (TestRunner):
        * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
        (WebTestRunner::WebTestProxyBase::didChangeIcon):
        (WebTestRunner):
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::didChangeIcon): Add the output about changing the icon.
        * DumpRenderTree/chromium/WebViewHost.h:
        (WebViewHost):

1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
2013-03-18  Julie Parent  <jparent@chromium.org>

        Cleanup: Move js for treemap and aggregate_results into own js files.
        https://bugs.webkit.org/show_bug.cgi?id=112618

        Reviewed by Dirk Pranke.
        
        No functional changes, just moving the code into separate js file
        rather than inlined in the html, so we can test it, make it more
        modular, etc.  Other dashboard types are already done this way.

        * TestResultServer/static-dashboards/aggregate_results.html:
        * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
        (generatePage):
        (handleValidHashParameter):
        (htmlForBuilder):
        (rawValuesHTML):
        (chartHTML):
        (filteredValues):
        (chart):
        (htmlForRevisionRows):
        (wrapHTMLInTable):
        (htmlForSummaryTable):
        (valuesPerExpectation):
        (htmlForTestType):
        (htmlForTableRow):
        (extendedEncode):
        * TestResultServer/static-dashboards/treemap.html:
        * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
        (humanReadableTime):
        (convertToWebTreemapFormat):
        (reverseSortByAverage):
        (generatePage):
        (focusPath):
        (.switch.return):
        (handleQueryParameterChange):
        (extractName):
        (fullName):
        (handleFocus.):
        (handleFocus):

1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
2013-03-18  Zan Dobersek  <zdobersek@igalia.com>

        [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
        https://bugs.webkit.org/show_bug.cgi?id=112622

        Reviewed by Dirk Pranke.

        * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
        (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.

1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
2013-03-18  Zan Dobersek  <zdobersek@igalia.com>

        [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
        https://bugs.webkit.org/show_bug.cgi?id=112619

        Reviewed by Dirk Pranke.

        When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
        directory and then fall back to the generic LayoutTests/platform/gtk directory.

        * Scripts/webkitpy/layout_tests/port/gtk.py:
        (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
        Port._webkit_baseline_path method.
        * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
        (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
        (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
        * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
        (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
        that are expected based on the builder name.

1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>

        [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
        https://bugs.webkit.org/show_bug.cgi?id=112571

        Reviewed by Adam Barth.

        Update function declarations for new WebFileSystemType enum. (All
        changes are behind an #ifdef so we can sync required changes in embedders.)

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::openFileSystem):
        (WebViewHost::deleteFileSystem):
        * DumpRenderTree/chromium/WebViewHost.h:
        (WebViewHost):

1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
2013-03-18  Julie Parent  <jparent@chromium.org>

        Cleanup: Move timeline_exporer js out of html file into js.
        https://bugs.webkit.org/show_bug.cgi?id=112188

        Reviewed by Dirk Pranke.
        
        Moves the javascript out of the html file and into a new js file.
        This follows the format of flakiness_dashboard.{html|js}.
        
        Also moves code from dashboard_base that is used only by this one
        dashboard, and makes it private to the dashboard.

        * TestResultServer/static-dashboards/dashboard_base.js:
        * TestResultServer/static-dashboards/timeline_explorer.html:
        * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
        (generatePage):
        (initCurrentBuilderTestResults):
        (shouldShowWebKitRevisionsOnly):
        (updateTimelineForBuilder.):
        (updateTimelineForBuilder):
        (selectBuild):
        (updateBuildIndicator):
        (.addRow):
        (.addNumberRow):
        (.inspectorNode.getElementsByTagName.0.onclick):
        (.inspectorNode.getElementsByTagName.1.onclick):
        (.inspectorNode.getElementsByTagName.2.onclick):
        (updateBuildInspector):
        (showResultsDelta):
        (decompressResults.addFlakyDelta):
        (decompressResults):

1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
2013-03-18  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, rolling out r145272.
        http://trac.webkit.org/changeset/145272
        https://bugs.webkit.org/show_bug.cgi?id=111884

        Turns out the ASAN build is still broken; possibly there's
        something still setting LD_LIBRARY_PATH, or possibly there's
        something else wrong. In the meantime, we need it to work again.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>

        delete-stale-build-files is too aggressive
        https://bugs.webkit.org/show_bug.cgi?id=112595

        Reviewed by Tim Horton.

        It appears that whitelisting file extensions to keep is not a good idea.
        Blacklist files to delete instead, and only delete .o files for now.
        We can add more file extensions as needed.

        * BuildSlaveSupport/delete-stale-build-files:

1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
2013-03-18  Simon Fraser  <simon.fraser@apple.com>

        Disable accessibility notifications after each test
        https://bugs.webkit.org/show_bug.cgi?id=112579

        Reviewed by Tim Horton.
        
        In WebKitTestRunner, if any tests triggered accessibility notifications,
        the global notification handler would thereafter be active, and fire
        notifications for all subsequent tests.
        
        Fix by implementing AccessibilityController::resetToConsistentState() for
        Mac, and using it to clear the global notification handler.

        * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
        * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
        (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
        (WTR::AccessibilityController::removeNotificationListener): Explicitly call
        -stopObserving so that unregistering the observer doesn't rely on object lifetimes
        (e.g. because of -autorelease).
        (WTR::AccessibilityController::logAccessibilityEvents): Stub.
        (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
        if there is one.
        * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
        Add -stopObserving
        * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
        (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
        (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
        center.

1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
2013-03-18  Dana Jansens  <danakj@chromium.org>

        [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
        https://bugs.webkit.org/show_bug.cgi?id=112392

        Reviewed by James Robinson.

        Removes the command line flag option from DRT.

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (main):

1765
1766
1767
1768
1769
1770
1771
1772
1773
2013-03-18  Zan Dobersek  <zdobersek@igalia.com>

        [GTK] plugins/plugin-clip-subframe.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=112570

        Reviewed by Martin Robinson.

        * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.

1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
2013-03-17  Morten Stenshorne  <mstensho@opera.com>

        Add reload button (and F5 accelerator) to the GtkLauncher toolbar
        https://bugs.webkit.org/show_bug.cgi?id=112442

        Reviewed by Gustavo Noronha Silva.

        * GtkLauncher/main.c:
        (reloadCb):
        (createToolbar):
        (createWindow):

1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
2013-03-15  Simon Fraser  <simon.fraser@apple.com>

        REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
        https://bugs.webkit.org/show_bug.cgi?id=112205

        Disable this API test until Geoff can fix it.

        * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
        (TestWebKitAPI::TEST):

1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
2013-03-15  Jochen Eisinger  <jochen@chromium.org>

        plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
        https://bugs.webkit.org/show_bug.cgi?id=112478

        Reviewed by Tony Chang.

        There is nothing that ensures that the log messages from the plugin
        come in before the layout test finished loading.

        * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
        (PassDifferentNPPStruct::NPP_SetWindow):
        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (NPP_SetWindow):

1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
2013-03-15  Simon Fraser  <simon.fraser@apple.com>

        Have the mac port support per_test_timeout in webkitpy
        https://bugs.webkit.org/show_bug.cgi?id=112466

        Reviewed by Dirk Pranke.
        
        Both WTR and DRT handle --timeout arguments, so we can
        have the scripts pass the timeout values down to the tools.

        * Scripts/webkitpy/layout_tests/port/mac.py:
        (MacPort.supports_per_test_timeout):

1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>

        Remove setAsynchronousSpellCheckingEnabled from test runners
        https://bugs.webkit.org/show_bug.cgi?id=112362

        Reviewed by Tony Chang.

        Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
        in internals.settings, so all ports can share it.

        * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
        * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
        * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
        * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
        * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
        * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
        * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
        * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
        * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
        * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
        * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
        * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.

1847
1848
1849
1850
1851
1852
1853
2013-03-15  Simon Fraser  <simon.fraser@apple.com>

        Fix the stupid unit tests.

        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        (test_sample_process):

1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
2013-03-14  Simon Fraser  <simon.fraser@apple.com>

        Collect samples for unresponsive web processes
        https://bugs.webkit.org/show_bug.cgi?id=112409

        Reviewed by Tim Horton.
        
        When we detect that a subprocess was unresponsive, run the 'sample'
        tool on that process, for the Mac port.
        
        The sample will be linked to from the results.html page, next
        to the crash log link.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager._look_for_new_crash_logs): Before looking for crash logs,
        look for samples on disk.
        * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
        (TestResultWriter):
        (TestResultWriter.copy_sample_file): Teach TestResultWriter about
        -sample.txt files, and have it copy their contents to a new file
        next to the test that spawned them (as we do for crash logs).
        * Scripts/webkitpy/layout_tests/port/base.py:
        (Port.look_for_new_samples): Base class does nothing for sampling.
        * Scripts/webkitpy/layout_tests/port/driver.py:
        (Driver._check_for_driver_crash): Kick off a sample if we detected
        that the subprocess was unresponsive.
        * Scripts/webkitpy/layout_tests/port/mac.py:
        (MacPort.sample_file_path): Utility to generate the file path
        to the generated sample files at the top level of layout-test-results.
        (MacPort.look_for_new_crash_logs): Fix typo
        (MacPort.look_for_new_samples): New function to find sample files.
        (MacPort.sample_process): Use the utility function to get the file path.

1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
2013-03-15  Zeno Albisser  <zeno@webkit.org>

        [Qt] Remove simple getters and setters from TestRunnerQt
        https://bugs.webkit.org/show_bug.cgi?id=112343

        Reviewed by Benjamin Poulain.

        The removed functions and boolean members
        are being replaced by the implementations in the
        generic TestRunner.h.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (DumpRenderTree::dumpFrameScrollPosition):
        (DumpRenderTree::dumpFramesAsText):
        (DumpRenderTree::dump):
        (DumpRenderTree::titleChanged):
        (DumpRenderTree::dumpDatabaseQuota):
        (DumpRenderTree::dumpApplicationCacheQuota):
        (DumpRenderTree::statusBarMessage):
        (DumpRenderTree::createWindow):
        * DumpRenderTree/qt/TestRunnerQt.cpp:
        (TestRunnerQt::reset):
        * DumpRenderTree/qt/TestRunnerQt.h:
        (TestRunnerQt):

1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>

        Update the link on build.webkit.org to refer to perf.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=112416

        Reviewed by Philip Rogers.

        Updated the link. Also updated the template to use HTML5 DOCTYPE.

        * BuildSlaveSupport/build.webkit.org-config/templates/root.html:

1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>

        Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
        https://bugs.webkit.org/show_bug.cgi?id=112394

        Reviewed by Philippe Normand.

        * GtkLauncher/main.c:
        (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER

1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
2013-03-14  Andreas Kling  <akling@apple.com>

        REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
        <http://webkit.org/b/111815>
        <rdar://problem/13380145>

        Reviewed by Anders Carlsson.

        Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
        after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
        will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.

        * WebKitTestRunner/PlatformWebView.h:
        (PlatformWebView):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::createOtherPage):
        (WTR::TestController::createWebViewWithOptions):
        * WebKitTestRunner/mac/PlatformWebViewMac.mm:
        (WTR::PlatformWebView::didInitializeClients):

1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>

        [EFL][MiniBrowser] Add a search field to the MiniBrowser
        https://bugs.webkit.org/show_bug.cgi?id=112122

        Reviewed by Kenneth Rohde Christiansen.

        Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.

        * MiniBrowser/efl/main.c:
        (_Browser_Window):
        (search_box_show):
        (search_box_hide):
        (on_key_down):
        (on_url_changed):
        (on_search_field_aborted):
        (on_search_field_activated):
        (on_search_field_clicked):
        (on_search_backward_button_clicked):
        (on_search_forward_button_clicked):
        (window_create):

1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2013-03-14  Julie Parent  <jparent@chromium.org>

        Cleanup: Remove g_resourceLoader.
        https://bugs.webkit.org/show_bug.cgi?id=112305

        Reviewed by Dirk Pranke.
        
        Removing another global.
        
        Now, each dashboard creates its own loader, rather than having
        a general global one.
        
        Remove usage of g_resourceLoader.isLoadingComplete from 
        handleLocationChange by ensuring that handleLocationChange is
        never called before the loader is done.  It was called in two
        places before: 1 was from the callback when the loader is done,
        so that was obviously true, and the other was from onhashchange,
        where it would just return rather than running.  Instead, lets
        only register the onhashchange handler once the loader is
        setup, so the check is no longer necessary.
        
        Remove isLoadingComplete since it is now unused.
        
        Callback for loader is now initializeHistory, rather than just
        handleLocationChange which will set up the hashchange handler now.
        This will all eventually be moving to a new History object.

        * TestResultServer/static-dashboards/aggregate_results.html:
        * TestResultServer/static-dashboards/dashboard_base.js:
        (handleLocationChange):
        (intializeHistory):
        (decompressResults):
        * TestResultServer/static-dashboards/flakiness_dashboard.js:
        (generatePage):
        * TestResultServer/static-dashboards/loader.js:
        (.):
        * TestResultServer/static-dashboards/loader_unittests.js:
        * TestResultServer/static-dashboards/timeline_explorer.html:
        * TestResultServer/static-dashboards/treemap.html:

2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>

        Add selectTrailingWhitespaceEnabled setting to WebCore::Page
        https://bugs.webkit.org/show_bug.cgi?id=109404

        Reviewed by Tony Chang.

        Removes all the code related to smartInsertDeleteEnabled and
        selectTrailingWhitespaceEnabled settings as they will be managed from
        internals from now on.

        * DumpRenderTree/TestRunner.cpp:
        (TestRunner::staticFunctions):
        * DumpRenderTree/TestRunner.h:
        (TestRunner):
        * DumpRenderTree/blackberry/DumpRenderTree.cpp:
        (WebKit):
        (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
        * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
        (DumpRenderTree):
        * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
        * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
        (WebTestRunner::WebTestProxy::didStopLoading):
        * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
        (WebTestRunner::TestRunner::TestRunner):
        (WebTestRunner::TestRunner::reset):
        * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
        (TestRunner):
        * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
        (WebTestRunner::WebPreferences::applyTo): Set default values for
        smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
        Chromium DRT default values are different from Chromium browser.
        * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
        * DumpRenderTree/chromium/WebViewHost.cpp:
        * DumpRenderTree/chromium/WebViewHost.h:
        (WebViewHost):
        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
        (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
        * DumpRenderTree/efl/TestRunnerEfl.cpp:
        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/gtk/TestRunnerGtk.cpp:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/mac/TestRunnerMac.mm:
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::resetSettings):
        * DumpRenderTree/qt/TestRunnerQt.cpp:
        * DumpRenderTree/qt/TestRunnerQt.h:
        (TestRunnerQt):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/win/TestRunnerWin.cpp:
        * DumpRenderTree/wx/TestRunnerWx.cpp:

2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>

        [Qt] Disable DRT on Windows

        Reviewed by Jocelyn Turcotte.

        We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.

        * qmake/mkspecs/features/configure.prf:

2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>

        [EFL][WK2] Add an API for adding and removing user style sheets from a page group
        https://bugs.webkit.org/show_bug.cgi?id=110728

        Reviewed by Gyuyoung Kim.

        Use the page group to create the view object.

        * MiniBrowser/efl/main.c:
        (window_create):

2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>

        [Qt] Improve the handling of mock geolocation, device orientation and motion clients

        Reviewed by Tor Arne Vestbø.

        The mock versions of these web facing features should be instantiated when
        running in DumpRenderTree only. In order for them to work, no extra Qt modules
        such as QtLocation are actually needed.

        This patch decouples enabling device orientation/motion and geolocation from
        the underlying Qt modules and makes them available in developer builds
        (!production_build) and backed by mock backends when running in drt.

        So if the Qt 5 modules are available, they'll be used (unless drtRun). For
        developers the web facing features are always enabled (although requests will
        time out) and the mock backends are enabled inside DRT, allowing for the layout
        tests to run with less dependencies.

        In addition this also enables the mock device motion client, which was
        previously never instantiated.

        * qmake/mkspecs/features/features.prf:

2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2013-03-14  Zeno Albisser  <zeno@webkit.org>

        [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
        https://bugs.webkit.org/show_bug.cgi?id=112340

        Reviewed by Simon Hausmann.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (DumpRenderTree::dump):
            Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
        (DumpRenderTree::dumpApplicationCacheQuota):
        * DumpRenderTree/qt/TestRunnerQt.cpp:
        (TestRunnerQt::reset):
        * DumpRenderTree/qt/TestRunnerQt.h:
        (TestRunnerQt):

2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2013-03-14  Zeno Albisser  <zeno@webkit.org>

        [Qt] Port DRT to use TestRunner::dumpAsText()
        https://bugs.webkit.org/show_bug.cgi?id=112260

        Reviewed by Benjamin Poulain.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::open):
        (WebCore::methodNameStringForFailedTest):
            Change parameter from type TestRunnerQt* to TestRunner*.
        (WebCore::DumpRenderTree::dump):
            TestRunnerQt::shouldDumpPixels() always returned true in our case.
            Instead we should rely on TestRunner::generatePixelResults().
        * DumpRenderTree/qt/TestRunnerQt.cpp:
        (TestRunnerQt::reset):
        * DumpRenderTree/qt/TestRunnerQt.h:
        (TestRunnerQt):

2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>

        Implement FontLoader interface
        https://bugs.webkit.org/show_bug.cgi?id=98395

        Reviewed by Eric Seidel.

        Enable FontLoadEvents runtime flag for TestShell.

        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
        (WebTestRunner::TestInterfaces::TestInterfaces):

2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2013-03-13  Julie Parent  <jparent@chromium.org>

        CLeanup: remove unnecessary call to parseParameters.
        https://bugs.webkit.org/show_bug.cgi?id=112309

        Reviewed by Ojan Vafai.
        
        We call parseCrossDashboardParameters when the dashboard initially
        loads to set the state required for loadBuildersList, and then we
        call it again once we are fully done with loading, so there is no
        reason to call it in the middle of the loading process here.

        * TestResultServer/static-dashboards/loader.js:
        (.):

2178
2179
2180
2181
2182
2183
2013-03-13  Elliott Sprehn  <esprehn@chromium.org>

        Unreviewed. Now I'm a reviewer :)

        * Scripts/webkitpy/common/config/committers.py:

2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>

        Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
        https://bugs.webkit.org/show_bug.cgi?id=112277

        Reviewed by Adam Barth.

        * Scripts/webkitperl/FeatureList.pm:
        * qmake/mkspecs/features/features.pri:

2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2013-03-13  Adam Barth  <abarth@webkit.org>

        run-perf-tests should support content_shell
        https://bugs.webkit.org/show_bug.cgi?id=112291

        Reviewed by Eric Seidel.

        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
        (PerfTestsRunner._parse_args):

2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2013-03-13  Oliver Hunt  <oliver@apple.com>

        Simplify Checked<> multiplication
        https://bugs.webkit.org/show_bug.cgi?id=112286

        Reviewed by James Robinson.

        Add tests for multiplication by zero and max to ensure we don't
        mess them up should we ever make changes to Checked<> in future.

        * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
        (TestWebKitAPI):

2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>

        [Qt] Unreviewed prospective Windows build fix

        Do the usual thing, include the moc generated code in the .cpp file instead
        of compiling it standalone, to ensure that config.h is included, too, and
        NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.

        * DumpRenderTree/qt/EventSenderQt.cpp:

2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>

        [Qt] Port TestRunner::findString to shared interface
        https://bugs.webkit.org/show_bug.cgi?id=112147

        Reviewed by Jocelyn Turcotte.

        This patch also removes DumpRenderTree and some other helper classes from
        the WebCore namespace, to which they do not really belong.

        * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
        (main):
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (DumpRenderTree::DumpRenderTree):
        (DumpRenderTree::~DumpRenderTree):
        (DumpRenderTree::instance):
        (DumpRenderTree::setShouldTimeout):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        (DumpRenderTree):
        * DumpRenderTree/qt/EventSenderQt.cpp:
        (EventSender::contextClick):
        (EventSender::sendEvent):
        (EventSender::postEvent):
        * DumpRenderTree/qt/EventSenderQt.h:
        (EventSender::isGraphicsBased):
        * DumpRenderTree/qt/TestRunnerQt.cpp:
        (TestRunnerQt::TestRunnerQt):
        (TestRunner::findString):
        (TestRunnerQt::setMockDeviceOrientation):
        (TestRunnerQt::setGeolocationPermission):
        (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
        (TestRunnerQt::setMockGeolocationPositionUnavailableError):
        (TestRunnerQt::setMockGeolocationPosition):
        * DumpRenderTree/qt/TestRunnerQt.h:
        (TestRunnerQt):

2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>

        [Chromium] Rename android_build_type to android_webview_build in .gyp files.
        https://bugs.webkit.org/show_bug.cgi?id=112129

        Reviewed by Adam Barth.

        Following Chromium
        http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
        this is being renamed to better explain what it does.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

2276
2277
2278
2279
2280
2281
2282
2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>

        [Qt] Unreviewed trivial typo fix

        * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
        TextRunner.h. Thanks Zeno :)

2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>

        [Qt] Prepare DRT for transition to shared TestRunner interface
        https://bugs.webkit.org/show_bug.cgi?id=112144

        Reviewed by Benjamin Poulain.

        Prepare Qt's DRT for a transition from the QObject based TestRunner to
        the JSC C API based one.

        This is impplemented by instantiating the QObject based testRunner in
        the global object, then instantiating the JSC C based TestRunner
        separately and placing it "behind" the QObject based testRunner through
        injection of the individual functions through proxies. (prototype
        chaining doesn't work due to the this object and Function.prototype.bind
        doesn't work due to the native function)

        This allows for porting over method by method by removing the method
        from the QObject TestRunnerQt and implementing it in the JSC C based
        TestRunner.

        In order for this to link and run dummy implementations of all the
        necessary TestRunner functions are provided.

        * DumpRenderTree/qt/DumpRenderTree.pro:
        * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        (WebCore::DumpRenderTree::initJSObjects):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        (DumpRenderTree):
        * DumpRenderTree/qt/TestRunnerQt.cpp:
        (TestRunner::~TestRunner):
        (TestRunner::addDisallowedURL):
        (TestRunner::queueLoad):
        (TestRunner::removeAllVisitedLinks):
        (TestRunner::setAcceptsEditing):
        (TestRunner::simulateLegacyWebNotificationClick):
        (TestRunner::setWindowIsKey):
        (TestRunner::setAlwaysAcceptCookies):
        (TestRunner::addOriginAccessWhitelistEntry):
        (TestRunner::setWebViewEditable):
        (TestRunner::clearAllApplicationCaches):
        (TestRunner::setTextDirection):
        (TestRunner::notifyDone):
        (TestRunner::numberOfPendingGeolocationPermissionRequests):
        (TestRunner::overridePreference):
        (TestRunner::pathToLocalResource):
        (TestRunner::removeAllWebNotificationPermissions):
        (TestRunner::simulateWebNotificationClick):
        (TestRunner::closeIdleLocalStorageDatabases):
        (TestRunner::focusWebView):
        (TestRunner::setBackingScaleFactor):
        (TestRunner::removeChromeInputField):
        (TestRunner::addChromeInputField):
        (TestRunner::originsWithLocalStorage):
        (TestRunner::deleteAllLocalStorage):
        (TestRunner::deleteLocalStorageForOrigin):
        (TestRunner::observeStorageTrackerNotifications):
        (TestRunner::syncLocalStorage):
        (TestRunner::windowCount):
        (TestRunner::setWaitToDump):
        (TestRunner::waitForPolicyDelegate):
        (TestRunner::webHistoryItemCount):
        (TestRunner::showWebInspector):
        (TestRunner::closeWebInspector):
        (TestRunner::evaluateInWebInspector):
        (TestRunner::setSerializeHTTPLoads):
        (TestRunner::apiTestNewWindowDataLoadBaseURL):
        (TestRunner::setCustomPolicyDelegate):
        (TestRunner::setDatabaseQuota):
        (TestRunner::setDomainRelaxationForbiddenForURLScheme):
        (TestRunner::resetPageVisibility):
        (TestRunner::keepWebHistory):
        (TestRunner::goBack):
        (TestRunner::originsWithApplicationCache):
        (TestRunner::applicationCacheDiskUsageForOrigin):
        (TestRunner::display):
        (TestRunner::dispatchPendingLoadRequests):
        (TestRunner::clearPersistentUserStyleSheet):
        (TestRunner::callShouldCloseOnWebView):
        (TestRunner::copyDecodedHostName):
        (TestRunner::clearBackForwardList):
        (TestRunner::clearAllDatabases):
        (TestRunner::clearApplicationCacheForOrigin):
        (TestRunner::apiTestGoToCurrentBackForwardItem):
        (TestRunner::authenticateSession):
        (TestRunner::abortModal):
        (TestRunner::setStorageDatabaseIdleInterval):
        (TestRunner::setAsynchronousSpellCheckingEnabled):
        (TestRunner::setXSSAuditorEnabled):
        (TestRunner::setSpatialNavigationEnabled):
        (TestRunner::setScrollbarPolicy):
        (TestRunner::setJavaScriptCanAccessClipboard):
        (TestRunner::setAutomaticLinkDetectionEnabled):
        (TestRunner::setUserStyleSheetEnabled):
        (TestRunner::setUserStyleSheetLocation):
        (TestRunner::setUseDashboardCompatibilityMode):
        (TestRunner::setTabKeyCyclesThroughElements):
        (TestRunner::setSmartInsertDeleteEnabled):
        (TestRunner::setSelectTrailingWhitespaceEnabled):
        (TestRunner::setPrivateBrowsingEnabled):
        (TestRunner::setPluginsEnabled):
        (TestRunner::setPopupBlockingEnabled):
        (TestRunner::setMockSpeechInputDumpRect):
        (TestRunner::setPersistentUserStyleSheetLocation):
        (TestRunner::setMockGeolocationPosition):
        (TestRunner::setMockGeolocationPositionUnavailableError):
        (TestRunner::setMockDeviceOrientation):
        (TestRunner::setMainFrameIsFirstResponder):
        (TestRunner::setIconDatabaseEnabled):
        (TestRunner::setGeolocationPermission):
        (TestRunner::setDefersLoading):
        (TestRunner::setCacheModel):
        (TestRunner::setAuthorAndUserStylesEnabled):
        (TestRunner::setAllowFileAccessFromFileURLs):
        (TestRunner::setAppCacheMaximumSize):
        (TestRunner::setAllowUniversalAccessFromFileURLs):
        (TestRunner::setApplicationCacheOriginQuota):
        (TestRunner::denyWebNotificationPermission):
        (TestRunner::grantWebNotificationPermission):
        (TestRunner::setValueForUser):
        (TestRunner::setViewModeMediaFeature):
        (TestRunner::setPageVisibility):
        (TestRunner::addMockSpeechInputResult):
        (TestRunner::removeOriginAccessWhitelistEntry):
        (TestRunner::addUserScript):
        (TestRunner::isCommandEnabled):
        (TestRunner::evaluateScriptInIsolatedWorld):
        (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
        (TestRunner::copyEncodedHostName):
        (TestRunner::addUserStyleSheet):
        (TestRunner::findString):
        (TestRunner::execCommand):
        (TestRunner::localStorageDiskUsageForOrigin):

2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2013-03-12  Julie Parent  <jparent@chromium.org>

        Cleanup: Move flatten-trie to loader.
        https://bugs.webkit.org/show_bug.cgi?id=112196

        Reviewed by Dirk Pranke.

        flatten-trie is used only by the loader, so move it there and make it
        private, rather than global in dashbaord_base. Moved the corresponding
        unit test from flakiness_dashboard_unittests to loader_unittests.
        
        * TestResultServer/static-dashboards/dashboard_base.js:
        * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
        * TestResultServer/static-dashboards/loader.js:
        (.):
        * TestResultServer/static-dashboards/loader_unittests.js:

oliver@apple.com's avatar
oliver@apple.com committed
2436
2437
2438
2439
2440
2441
2442
2013-03-12  Oliver Hunt  <oliver@apple.com>

        Unbreak api tests

        * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
        (TestWebKitAPI):

2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2013-03-12  Tim Horton  <timothy_horton@apple.com>

        Unreviewed, disabling tests for Win EWS.

        win-ews obviously cannot keep up with running tests, it's >300 behind.
        Probably doesn't help that its (likely) running tests serially.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (WinEWS):

2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2013-03-12  Tim Horton  <timothy_horton@apple.com>

        Add a --build-directory argument to delete-stale-build-files
        https://bugs.webkit.org/show_bug.cgi?id=112198

        Reviewed by Ryosuke Niwa.

        * BuildSlaveSupport/delete-stale-build-files:
        (main): Add --build-directory argument.

oliver@apple.com's avatar
oliver@apple.com committed
2463
2464
2465
2466
2467
2468
2469
2013-03-12  Oliver Hunt  <oliver@apple.com>

        Appease MSVC

        * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
        (TestWebKitAPI):

oliver@apple.com's avatar
oliver@apple.com committed
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2013-03-12  Oliver Hunt  <oliver@apple.com>

        Add more Checked<> tests
        https://bugs.webkit.org/show_bug.cgi?id=112190

        Reviewed by Geoffrey Garen.

        Tests!

        * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
        (TestWebKitAPI):

2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2013-03-12  Julie Parent  <jparent@chromium.org>

        Cleanup: Move loading complete function into callback, rather than global.
        https://bugs.webkit.org/show_bug.cgi?id=112167

        Reviewed by Dirk Pranke.
        
        Stop calling global functions, pass in proper handler to Loader
        constructor. Note that the callback is optional, as tests, and
        some potential dashboards, do not need one.

        * TestResultServer/static-dashboards/dashboard_base.js:
        * TestResultServer/static-dashboards/loader.js:
        (.):
        * TestResultServer/static-dashboards/loader_unittests.js:

2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>

        [EFL][WK2] Add popup menu support to MiniBrowser
        https://bugs.webkit.org/show_bug.cgi?id=108934

        Reviewed by Kenneth Rohde Christiansen.

        Implement popup menu support in MiniBrowser by handling popup_menu_show
        and popup_menu_hide smart functions on the view and using the Ewk popup
        menu API.

        * MiniBrowser/efl/main.c:
        (_Browser_Window):
        (on_popup_menu_discarded):
        (on_popup_menu_item_clicked):
        (popup_menu_populate):
        (on_popup_menu_show):
        (on_popup_menu_hide):
        (window_create): Use calloc() instead of malloc() to allocate memory for
        Browser_Window. This makes sure all the structs members are initialized
        to 0 (such as the new elm_popup_menu pointer).

2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2013-03-12  Zan Dobersek  <zdobersek@igalia.com>

        [GTK] Set up the libPlatformGtk.la library
        https://bugs.webkit.org/show_bug.cgi?id=111738

        Reviewed by Martin Robinson.

        * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
        Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
        * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.

2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2013-03-12  Zan Dobersek  <zdobersek@igalia.com>

        [GTK] Enable Web Audio in development builds
        https://bugs.webkit.org/show_bug.cgi?id=111831

        Reviewed by Philippe Normand.

        Web Audio is already quite well supported on the GTK port but still has a few issues
        that must be addressed before it is enabled by default. Despite that it should be enabled
        in development builds just so we are up-to-date with future feature infrastructure changes.
        The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
        that's an obvious goal before enabling the feature in release builds.

        * Scripts/webkitperl/FeatureList.pm:

2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2013-03-11  Andreas Kling  <akling@apple.com>

        [Mac][WK1] Add support for alert() in MiniBrowser.
        <http://webkit.org/b/112090>

        Reviewed by Anders Carlsson.

        * MiniBrowser/mac/WK1BrowserWindowController.m:
        (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):

2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2013-03-11  Julie Parent  <jparent@chromium.org>

        Dashboard cleanup: Create ui.Errors
        https://bugs.webkit.org/show_bug.cgi?id=111785

        Reviewed by Ojan Vafai.
        
        Create ui.Errors for handling errors the dashboards
        encounter. Loader now has a Error object that it can add to,
        and individual dashboards can show errors when desired.
        Currently, only flakiness_db shows errors, but this is 
        generic and there is no reason why other dbs wouldn't want to
        show errors.

        * TestResultServer/static-dashboards/dashboard_base.js:
        (resourceLoadingComplete):
        * TestResultServer/static-dashboards/flakiness_dashboard.js:
        (generatePage):
        * TestResultServer/static-dashboards/loader.js:
        (.):
        * TestResultServer/static-dashboards/ui.js:
        (.):

2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2013-03-08  Geoffrey Garen  <ggaren@apple.com>

        Some StringHasher tests are broken because of missing null termination
        https://bugs.webkit.org/show_bug.cgi?id=111284

        Reviewed by Darin Adler.

        * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
        (TestWebKitAPI): Added null termination since C strings are null-terminated.
        (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
        the bug caught by it is now fixed.

2591
2592
2593
2594
2595
2596
2597
2598
2599
2600
2601
2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r145200.
        http://trac.webkit.org/changeset/145200
        https://bugs.webkit.org/show_bug.cgi?id=112063

        Broke a couple of unit tests (Requested by zdobersek on
        #webkit).

        * Scripts/webkitperl/FeatureList.pm:

2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2013-03-11  Zan Dobersek  <zdobersek@igalia.com>

        [GTK] WebKit2-only build fails
        https://bugs.webkit.org/show_bug.cgi?id=112033

        Reviewed by Gustavo Noronha Silva.

        * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
        generic part, WebKit1-specific part and WebKit2-specific part.
        * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
        as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
        directly.

2615
2616
2617
2618
2619
2620
2621
2622
2013-03-11  Dima Gorbik  <dgorbik@apple.com>

        Adding myself to the committers list.

        Unreviewed.

        * Scripts/webkitpy/common/config/committers.py:

2623
2624
2625
2626
2627
2628
2629
2630
2631
2013-03-11  Jeff Rogers  <jrogers@rim.com>

        [BlackBerry] Disable MathML support
        https://bugs.webkit.org/show_bug.cgi?id=111929

        Reviewed by Rob Buis.

        * Scripts/webkitperl/FeatureList.pm:

2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>

        [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
        https://bugs.webkit.org/show_bug.cgi?id=111970

        Reviewed by Chris Fleizach.

        Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
        or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
        undefined symbol.

        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        (WTR::AccessibilityUIElement::supportedActions):
        (WTR):

2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2013-03-11  Chris Hopman  <cjhopman@chromium.org>

        [chromium] Android apk targets should depend directly on Java library targets
        https://bugs.webkit.org/show_bug.cgi?id=111746

        Reviewed by Eric Seidel.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
        Make DumpRenderTree_apk depend directly on base_java and net_java.
        * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
        Make TestWebKitAPI_apk depend directly on base_java.

2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2013-03-11  Jochen Eisinger  <jochen@chromium.org>

        [chromium] remove obsolete user gesture methods from WebFrame
        https://bugs.webkit.org/show_bug.cgi?id=111696

        Reviewed by Adam Barth.

        * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
        (WebTestRunner::TestPlugin::handleInputEvent):
        * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

2670
2671
2672
2673
2674
2675
2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>

        Unreviewed, add myself to commiters.py.

        * Scripts/webkitpy/common/config/committers.py:

2676
2677
2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2013-03-08  Julie Parent  <jparent@chromium.org>

        Cleanup: Remove dead code.
        https://bugs.webkit.org/show_bug.cgi?id=111900

        Reviewed by Dirk Pranke.
        
        Treemap overrides a global function that used to be in 
        dashboard_base, but was removed months ago in
        https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
        no caller. 

        * TestResultServer/static-dashboards/treemap.html:

2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2013-03-08  Harald Alvestrand  <hta@chromium.org>

        Implemented new API for RTCStatsReport object.
        https://bugs.webkit.org/show_bug.cgi?id=110333

        Reviewed by Adam Barth.

        * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
        (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):

2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2013-03-08  Dirk Pranke  <dpranke@chromium.org>

        [chromium] use custom freetype on linux asan builds again
        https://bugs.webkit.org/show_bug.cgi?id=111884

        Reviewed by Tony Chang.

        We no longer need the workaround after chromium r186540.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>

        Warning about the user not having edit rights on Bugzilla is confusing new contributors
        https://bugs.webkit.org/show_bug.cgi?id=111798

        Reviewed by Dirk Pranke.

        Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.

        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2013-03-08  James Robinson  <jamesr@chromium.org>

        [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
        https://bugs.webkit.org/show_bug.cgi?id=111632

        Reviewed by Adrienne Walker.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::initializeLayerTreeView):
        * DumpRenderTree/chromium/WebViewHost.h:
        (WebViewHost):

2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2013-03-08  Benjamin Poulain  <benjamin@webkit.org>

        [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
        https://bugs.webkit.org/show_bug.cgi?id=111297

        Reviewed by Kenneth Rohde Christiansen.

        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        (WTR::TestRunner::setViewModeMediaFeature):

2744
2745
2746
2747
2748
2749
2750
2751
2752
2753
2754
2755
2756
2757
2758
2759
2760
2013-03-08  Chris Fleizach  <cfleizach@apple.com>

        [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
        https://bugs.webkit.org/show_bug.cgi?id=111814

        Reviewed by Ryosuke Niwa.

        Add the needed supportedActions() attribute to WKTestRunner.

        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
        (WTR::AccessibilityUIElement::supportedActions):
        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
        (AccessibilityUIElement):
        * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
        * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
        (WTR::AccessibilityUIElement::supportedActions):

2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>

        [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
        https://bugs.webkit.org/show_bug.cgi?id=111851

        Reviewed by Kenneth Rohde Christiansen.

        * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
        (TestWebKitAPI::TEST):

            Fixed WKURLRef instance leaking.

2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>

        [EFL] [WK2] Some authentication tests fail in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=106407

        Reviewed by Kenneth Rohde Christiansen.

        Add patch from upstream for libsoup 2.40 to fix several authentication
        test cases.

        * efl/jhbuild.modules:
        * efl/patches/libsoup-2.40-auth-fix.patch: Added.

2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2013-03-08  Zan Dobersek  <zdobersek@igalia.com>

        [GTK] Enable Web Audio in development builds
        https://bugs.webkit.org/show_bug.cgi?id=111831

        Reviewed by Philippe Normand.

        Web Audio is already quite well supported on the GTK port but still has a few issues
        that must be addressed before it is enabled by default. Despite that it should be enabled
        in development builds just so we are up-to-date with future feature infrastructure changes.
        The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
        that's an obvious goal before enabling the feature in release builds.

        * Scripts/webkitperl/FeatureList.pm:

2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
2812
2813
2814
2013-03-07  Jochen Eisinger  <jochen@chromium.org>

        [chromium] delay clearing the TestRunners until the main view was deleted
        https://bugs.webkit.org/show_bug.cgi?id=111823

        Reviewed by Eric Seidel.

        During WebViewHost::shutdown, we navigate the WebView to about:blank.
        This may call into the test runners which assume that the delegate is
        always non-NULL.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::~TestShell):

2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
2829
2013-03-07  Alan Cutter  <alancutter@chromium.org>

        Sheriffbot whois command can't search by full name
        https://bugs.webkit.org/show_bug.cgi?id=111825

        Reviewed by Eric Seidel.

        Allowed multiple arguments to Sheriffbot's whois command.
        Updated test expectations.

        * Scripts/webkitpy/tool/bot/irc_command.py:
        (Whois.execute):
        * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
        (IRCCommandTest.test_whois):

2830
2831
2832
2833
2834
2835
2836
2837
2838
2013-03-07  Nils Barth  <nbarth@chromium.org>

        Add Nils Barth and Koji Hara to committers.py
        https://bugs.webkit.org/show_bug.cgi?id=111806

        Reviewed by Eric Seidel.

        * Scripts/webkitpy/common/config/committers.py:

2839
2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2013-03-07  Glenn Adams  <glenn@skynav.com>

        run-pert-tests should have a --test-runner-count option
        https://bugs.webkit.org/show_bug.cgi?id=111726

        Reviewed by Ryosuke Niwa.

        Add --test-runner-count option to run-perf-tests, with default value of 4.
        This option allows command line configuration of the number of times to invoke
        the test runner (serially, not in parallel) when running a specific test in
        a test set.

        * Scripts/webkitpy/performance_tests/perftest.py:
        (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
        (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
        (PerfTest.run): Rename process_run_count to test_runner_count.
        (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
        (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
        (ReplayPerfTest.__init__): Add test_runner_count optional argument.
        (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
        (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
        (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
        * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
        (MainTest._test_run_with_json_output): Add optional compare_logs argument.
        (MainTest.test_run_with_repeat):
        (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
        * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
        (MainTest.test_default_args): Add test for default option argument values.
        (MainTest.test_parse_args): Add test for test-runner-count option parsing.

2870
2871
2872
2873
2874
2875
2876
2877
2878
2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>

        Add myself to reviewers.py
        https://bugs.webkit.org/show_bug.cgi?id=111757

        Reviewed by Eric Seidel.

        * Scripts/webkitpy/common/config/committers.py:

2879
2880
2881
2882
2883
2884
2885
2886
2887
2888
2889
2890
2891
2892
2893
2894
2895
2896
2897
2898
2899
2900
2901
2902
2903
2904
2905
2906
2907
2908
2909
2910
2013-03-07  Glenn Adams  <glenn@skynav.com>

        run-perf-tests should have a --repeat option
        https://bugs.webkit.org/show_bug.cgi?id=100030

        Reviewed by Ryosuke Niwa.

        Add --repeat option to run-perf-tests, with default value of 1. When greater
        than 1, runs test set specified number of times. Note that multiple runs are
        not aggregated for statistical purposes.

        Incidentally fixed typo: s/suceeds/succeeds/.

        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
        (PerfTestsRunner._parse_args): Add repeat option.
        (PerfTestsRunner.run): Add outer repeat loop.
        (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
        (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
        * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
        (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
        (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
        (MainTest.test_run_with_json_output): Fix typo.
        (MainTest.test_run_with_description): Fix typo.
        (MainTest.test_run_respects_no_results): Fix typo.
        (MainTest.test_run_with_slave_config_json): Fix typo.
        (MainTest.test_run_with_multiple_repositories): Fix typo.
        (MainTest.test_run_with_upload_json): Fix typo.
        (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
        (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
        * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
        (MainTest.test_parse_args): Add test for repeat option parsing.

jparent@chromium.org's avatar