ChangeLog 3.85 MB
Newer Older
1 2 3 4 5 6 7 8
2010-01-27  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] For package builds use the .def files on Symbian

        * WebCore.pro:

9 10 11 12 13 14 15 16 17 18
2010-01-27  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Timothy Hatcher.

        Avoid watch expressions duplication
        https://bugs.webkit.org/show_bug.cgi?id=33996

        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSidebarPane.prototype._settingsLoaded):

19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41
2010-01-27  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Dimitri Glazkov.

        Adds EventSource bindings for V8
        https://bugs.webkit.org/show_bug.cgi?id=33695

        No new tests (existing layout tests for EventSource should pass).

        * Android.v8bindings.mk:
        * WebCore.gypi:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/DOMObjectsInclude.h:
        * bindings/v8/DerivedSourcesAllInOne.cpp:
        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/V8DOMWrapper.h:
        * bindings/v8/V8Index.cpp:
        * bindings/v8/V8Index.h:
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8EventSourceConstructor.cpp: Added.
        * bindings/v8/custom/V8EventSourceCustom.cpp: Added.

42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59
2010-01-27  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Meta-methods can't be introspected using ES5 API
        https://bugs.webkit.org/show_bug.cgi?id=34087

        Add getOwnPropertyDescriptor() and getOwnPropertyNames() reimplementations.

        Tests are in WebKit/qt/tests/qwebframe

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
        (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyNames):
        (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):
        (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyNames):
        * bridge/qt/qt_runtime.h:

60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79
2010-01-27  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        Fix a crash when trying to indent a block element that was contained
        in a list.  This was happening because enclosingBlock() in
        htmlediting.cpp can return the current the same Node when a block
        element (like an <hr> or a <table>) is passed in.  This causes
        the indent command to think that it is not in a list item.

        Work around this by checking to see if enclosingBlock returned the
        same Node.

        https://bugs.webkit.org/show_bug.cgi?id=32390

        Test: editing/execCommand/indent-block-in-list.html

        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::tryIndentingAsListItem):

80 81 82 83 84 85 86 87
2010-01-27  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Add the "d" suffix to QtWebKit's dll on Windows.

        * WebCore.pro:

88 89 90 91 92 93 94 95 96 97 98 99 100
2010-01-27  Matt Perry  <mpcomplete@chromium.org>

        Reviewed by Eric Seidel.

        Fix a bug where dispatchDocumentElementAvailable was fired for fragment parsing on XML documents.
        https://bugs.webkit.org/show_bug.cgi?id=33920

        Tests: userscripts/script-not-run-for-fragments.html
               userscripts/script-run-at-start.html

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::startElementNs):

101 102 103 104
2010-01-27  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122
        Web Inspector: Improve SourceHTMLTokenizer so that it treats script tag well.

        https://bugs.webkit.org/show_bug.cgi?id=34177

        * inspector/front-end/SourceHTMLTokenizer.js:
        (WebInspector.SourceHTMLTokenizer):
        (WebInspector.SourceHTMLTokenizer.prototype._isAttribute):
        (WebInspector.SourceHTMLTokenizer.prototype._isAttributeValue):
        (WebInspector.SourceHTMLTokenizer.prototype._setAttributeValue):
        (WebInspector.SourceHTMLTokenizer.prototype._setAttribute):
        (WebInspector.SourceHTMLTokenizer.prototype._stringToken):
        (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
        * inspector/front-end/SourceHTMLTokenizer.re2js:

2010-01-26  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139
        Web Inspector: nuke quarantine wrappers.

        https://bugs.webkit.org/show_bug.cgi?id=34203

        * Android.jscbindings.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSInspectedObjectWrapper.cpp: Removed.
        * bindings/js/JSInspectedObjectWrapper.h: Removed.
        * bindings/js/JSInspectorCallbackWrapper.cpp: Removed.
        * bindings/js/JSInspectorCallbackWrapper.h: Removed.
        * bindings/js/JSQuarantinedObjectWrapper.cpp: Removed.
        * bindings/js/JSQuarantinedObjectWrapper.h: Removed.

140 141
2010-01-27  Alexey Proskuryakov  <ap@apple.com>

ap@apple.com's avatar
ap@apple.com committed
142
        Revert r53899 (HashMap<AtomicStringImpl*, Value> key checks) and subsequent build fixes,
143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198
        because they make SVG tests crash in release builds.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSRuleSet::getIDRules):
        (WebCore::CSSRuleSet::getClassRules):
        (WebCore::CSSRuleSet::getTagRules):
        (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
        * dom/CheckedRadioButtons.cpp:
        (WebCore::CheckedRadioButtons::checkedButtonForGroup):
        (WebCore::CheckedRadioButtons::removeButton):
        * dom/ContainerNodeAlgorithms.h:
        (WebCore::removeAllChildrenInContainer):
        * dom/Document.cpp:
        (WebCore::Document::getElementById):
        (WebCore::Document::removeElementById):
        (WebCore::Document::removeImageMap):
        (WebCore::Document::getImageMap):
        (WebCore::Document::nameCollectionInfo):
        * dom/Document.h:
        (WebCore::Document::collectionInfo):
        * editing/markup.cpp:
        (WebCore::shouldAddNamespaceAttr):
        (WebCore::appendNamespace):
        (WebCore::appendStartMarkup):
        * html/CollectionCache.cpp:
        * html/CollectionCache.h:
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::namedItems):
        (WebCore::HTMLCollection::nextNamedItem):
        * html/HTMLFormCollection.cpp:
        (WebCore::HTMLFormCollection::formCollectionInfo):
        * html/HTMLSelectElement.h:
        (WebCore::HTMLSelectElement::collectionInfo):
        * loader/loader.cpp:
        (WebCore::Loader::load):
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::nonCacheRequestInFlight):
        (WebCore::Loader::nonCacheRequestComplete):
        (WebCore::Loader::cancelRequests):
        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::clearRenderer):
        (WebCore::CompositeAnimation::updateKeyframeAnimations):
        (WebCore::CompositeAnimation::animate):
        (WebCore::CompositeAnimation::getAnimatedStyle):
        (WebCore::CompositeAnimation::setAnimating):
        (WebCore::CompositeAnimation::timeToNextService):
        (WebCore::CompositeAnimation::getAnimationForProperty):
        (WebCore::CompositeAnimation::suspendAnimations):
        (WebCore::CompositeAnimation::resumeAnimations):
        (WebCore::CompositeAnimation::isAnimatingProperty):
        (WebCore::CompositeAnimation::pauseAnimationAtTime):
        (WebCore::CompositeAnimation::numberOfActiveAnimations):
        * platform/TreeShared.h:
        (WebCore::TreeShared::~TreeShared):
        (WebCore::TreeShared::deref):

199 200 201 202 203 204 205 206 207 208 209 210 211 212
2010-01-25  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Seidel.

        autobuffer value not forwarded media element to MediaPlayer
        https://bugs.webkit.org/show_bug.cgi?id=33889

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::loadResource): Forward autobuffer
        value to MediaPlayer instance.
        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::load): Forward autobuffer and
        preservesPitch values to newly created platform media player instance.

213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232
2010-01-25  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Seidel.

        [Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots
        https://bugs.webkit.org/show_bug.cgi?id=34086

        Cache media duration and fix didEnd() in case of reverse
        playback. When EOS was reached but in case of reverse playback the
        position is not always 0. So to not confuse the HTMLMediaElement
        we synchronize position and duration values.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::duration):
        (WebCore::MediaPlayerPrivate::updateStates):
        (WebCore::MediaPlayerPrivate::didEnd):
        (WebCore::MediaPlayerPrivate::durationChanged):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

233 234 235 236 237
2010-01-27  Alexey Proskuryakov  <ap@apple.com>

        * WebCore.xcodeproj/project.pbxproj: Actually land the change to add ContainerNodeAlgorithms.h
        (it's "svn resolved", not "svn revert"!).

ap@apple.com's avatar
ap@apple.com committed
238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308
2010-01-26  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=34150
        WebKit needs a mechanism to catch stale HashMap entries

        * WebCore.xcodeproj/project.pbxproj: Added ContainerNodeAlgorithms.h to the project to make
        it easier to search for.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSRuleSet::getIDRules):
        (WebCore::CSSRuleSet::getClassRules):
        (WebCore::CSSRuleSet::getTagRules):
        (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
        * dom/CheckedRadioButtons.cpp:
        (WebCore::CheckedRadioButtons::checkedButtonForGroup):
        (WebCore::CheckedRadioButtons::removeButton):
        * dom/Document.cpp:
        (WebCore::Document::getElementById):
        (WebCore::Document::removeElementById):
        (WebCore::Document::removeImageMap):
        (WebCore::Document::getImageMap):
        (WebCore::Document::nameCollectionInfo):
        * dom/Document.h:
        (WebCore::Document::collectionInfo):
        * editing/markup.cpp:
        (WebCore::shouldAddNamespaceAttr):
        (WebCore::appendNamespace):
        (WebCore::appendStartMarkup):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::namedItems):
        (WebCore::HTMLCollection::nextNamedItem):
        * html/HTMLFormCollection.cpp:
        (WebCore::HTMLFormCollection::formCollectionInfo):
        * html/HTMLSelectElement.h:
        (WebCore::HTMLSelectElement::collectionInfo):
        * loader/loader.cpp:
        (WebCore::Loader::load):
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::nonCacheRequestInFlight):
        (WebCore::Loader::nonCacheRequestComplete):
        (WebCore::Loader::cancelRequests):
        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::clearRenderer):
        (WebCore::CompositeAnimation::updateKeyframeAnimations):
        (WebCore::CompositeAnimation::animate):
        (WebCore::CompositeAnimation::getAnimatedStyle):
        (WebCore::CompositeAnimation::setAnimating):
        (WebCore::CompositeAnimation::timeToNextService):
        (WebCore::CompositeAnimation::getAnimationForProperty):
        (WebCore::CompositeAnimation::suspendAnimations):
        (WebCore::CompositeAnimation::resumeAnimations):
        (WebCore::CompositeAnimation::isAnimatingProperty):
        (WebCore::CompositeAnimation::pauseAnimationAtTime):
        (WebCore::CompositeAnimation::numberOfActiveAnimations):
        Added checkConsistency checks before lookups in HashMaps with AtomicStringImpl* keys.

        * dom/ContainerNodeAlgorithms.h: (WebCore::removeAllChildrenInContainer): Be sure to notify
        about removed child nodes that can be deleted immediately.

        * html/CollectionCache.cpp:
        (WebCore::CollectionCache::checkConsistency):
        * html/CollectionCache.h:
        Added a checkConsistency() method that checks both HashMaps in the cache.

        * platform/TreeShared.h:
        (WebCore::TreeShared::~TreeShared): Assert that m_refCount is null. Since Nodes can be
        destroyed with operator delete (as done in ContainerNodeAlgorithms), this is important to check.
        (WebCore::TreeShared::deref): Assert that m_refCount isn't already negative.

309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329
2010-01-26  Daniel Bates  <dbates@webkit.org>

        Reviewed by Tor Arne Vestbø.

        https://bugs.webkit.org/show_bug.cgi?id=29564

        [Qt] Fixes an issue where the height of <button>- and
        <input type="button">- elements are fixed to the height of the
        button label font plus padding. That is, the CSS height property
        is being ignored.

        Instead, we should honor the user-specified height, if appropriate
        for the platform and context. Notice, the Mac ports do not honor the
        height for <input type="button"> elements unless a border and/or
        background is also specified.

        Test: fast/css/button-height.html

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::adjustButtonStyle):

330 331 332 333 334 335 336 337 338 339
2010-01-26  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Timothy Hatcher.

        Enable the Audits panel via a shortcut (Cmd/Ctrl+Alt+A)
        https://bugs.webkit.org/show_bug.cgi?id=34158

        * inspector/front-end/inspector.js:
        (WebInspector.documentKeyDown):

340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367
2010-01-26  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        HTMLInputElement::valueAsNumber support except type=datetime-local.
        https://bugs.webkit.org/show_bug.cgi?id=32696

        Tests: fast/forms/input-valueasnumber-date.html
               fast/forms/input-valueasnumber-datetime.html
               fast/forms/input-valueasnumber-month.html
               fast/forms/input-valueasnumber-number.html
               fast/forms/input-valueasnumber-range.html
               fast/forms/input-valueasnumber-time.html
               fast/forms/input-valueasnumber-unsupported.html
               fast/forms/input-valueasnumber-week.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::valueAsNumber):
          According to the specification, we should return NaN for invalid values.
        (WebCore::HTMLInputElement::setValueAsNumber):
          According to the specification, throws NOT_SUPPORTED_ERR for Infinitiy or NaN,
          and throws INVALID_STATE_ERR for unsupported types.
        (WebCore::HTMLInputElement::formStringToDouble):
          According to the step 14 of Real Number in the specification, we
          should round -0 to 0.
        * html/HTMLInputElement.h: Declare valueAsNumber() and setValueAsNumber().
        * html/HTMLInputElement.idl: Add valueAsNumber.

368 369 370 371 372 373 374 375 376 377
2010-01-26  Dave Hyatt  <hyatt@apple.com>

        Reviewed by Oliver Hunt.

        Make sure there is a lock on serialize in SerializedScriptValueData, since type errors can be created when
        exceptions are thrown.

        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::SerializedScriptValueData::serialize):

378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393
2010-01-26  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Add Date type support for Objective-C binding.
        https://bugs.webkit.org/show_bug.cgi?id=32810

        The Date type in IDLs is mapped to NSTimeInterval in Objective-C.

        * bindings/objc/DOMInternal.h: Add kit() and core() for NSTimeInterval.
        * bindings/scripts/CodeGenerator.pm: Make Date a primitive type.
        * bindings/scripts/CodeGeneratorJS.pm: Move some code for the CodeGeenrator.pm change.
        * bindings/scripts/CodeGeneratorObjC.pm:
        * bindings/scripts/CodeGeneratorV8.pm: Move some code for the CodeGeenrator.pm change.
        * html/HTMLInputElement.idl: Remove Objective-C exclusion for valueAsDate.

394 395 396 397 398 399 400
2010-01-26  Dmitry Titov  <dimich@chromium.org>

        Not reviewed, attempt to fix Tiger build.

        * rendering/RenderTreeAsText.cpp:
        (WebCore::write): Use UNUSED_PARAM macros to prevent compiler warning on targets without accelerated compositing.

401 402 403 404 405 406 407 408 409 410 411 412
2010-01-26  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Darin Adler.

        Incorrect boolean expression in isMailBlockquote() (WebCore/htmlediting.cpp)
        https://bugs.webkit.org/show_bug.cgi?id=34156

        No new tests (minor code change).

        * editing/htmlediting.cpp:
        (WebCore::isMailBlockquote):

413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431
2010-01-26  Peter Kasting  <pkasting@google.com>

        Reviewed by David Levin.

        Handle broken images more correctly in the open-source image decoders.
        https://bugs.webkit.org/show_bug.cgi?id=33747

        No tests since Safari doesn't use these decoders and there's already a
        broken-image test in the tree.

        * platform/graphics/ImageSource.cpp:
        (WebCore::ImageSource::createFrameAtIndex): No need to check isSizeAvailable() since size() is now always safe.
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageDecoder::size): Don't assert that the bitmap is valid; we don't need a complete successful decode to be able to give info about the size.
        * platform/image-decoders/qt/RGBA32BufferQt.cpp:
        (WebCore::RGBA32Buffer::setSize): Don't set the frame to complete on failure, since it's not complete, but empty, and callers can better handle empty frames.
        * platform/image-decoders/skia/ImageDecoderSkia.cpp:
        (WebCore::RGBA32Buffer::setSize): Don't set the frame to complete on failure, since it's not complete, but empty, and callers can better handle empty frames.

432 433 434 435 436 437 438
2010-01-26  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Synchronize Qt/Gtk build systems with Mac/Win, should fix Qt compilation. Gtk results still pending.

        * GNUmakefile.am:
        * WebCore.pro:

439 440
2010-01-26  Nikolas Zimmermann  <nzimmermann@rim.com>

441 442 443 444 445 446 447
        Not reviewed. Attempt to fix V8 - change SetterMethod function signatures, just like it has been done for JSSVGPODTypeWrapper.

        * bindings/v8/V8SVGPODTypeWrapper.h:

2010-01-26  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Revert Base.xcconfig changes, was not meant to be committed.
448 449 450

        * Configurations/Base.xcconfig:

451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790
2010-01-26  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Oliver Hunt.

        SVG consumes way too much memory to store animated properties in the DOM
        https://bugs.webkit.org/show_bug.cgi?id=34188

        Shrink WebCore library size to 75% (measured in debug builds) and reduce SVG memory usage to <25%.
        Adding Oliver testcase as manual-tests/svg-node-count-vs-scroll.xhtml, which creates an arbitary number of
        rects (50.000 <rect> elements added to the DOM by default) - memory usage down to 111M from 503M (RPRVT).
        The SVG DOM side is almost fine, still some optimizations possible, that will be implemented soon - next
        target is the SVG render tree, there are plenty of possibilities to reduce memory usage there.

        Redesign the way we store animated properties in the individual SVG*Element files. Short story: In order
        to support SVG DOM through the bindings (e.g. JS) we need to associate SVGAnimatedProperty objects with
        the SVGElement object that created it - we used to store this pointer directly in the SVGAnimatedProperty.
        This means, every SVGAnimatedProperty stored in a SVGRectElement, stored a pointer to the SVGRectElement, resulting
        in excessive memory usage. This is now properly implemented, without wasting tons of memory. Unfortunately this
        requires touching all SVG*Element files.

        Detailed list of changes:
        - Remove template bloat by not specializing class templates for each attributeName/tagName combination. Instead
          SVGAnimatedProperty is a non-specialized template class now, only depending on the AnimatedType (ie. SVGLength for SVGAnimatedLength)
          -> This heavily reduces the generated code, thus shrinking WebCore size. I hope we can build windows again without SVGAllInOne.cpp

        - Remove "exportStrings" / "exportString" handling from make_names.pl - SVG defined string literals for each QualifiedName,
          in order to use template specialization based on "const char*" parameters. All that bloat is gone, so there's no need for it anymore.

        - Redesign SVGAnimatedProperty so it does not need any back-pointers to the SVGElement that created it

        - Don't actually store the XML DOM attribute name associated with a SVG DOM property in SVGAnimatedProperty, move the associatedAttributeName()
          function inside the macro declaration and just return the passed macro parameter DOMAttribute there, storing is inefficient and useless.

        - Remove SynchronizablePropertyController, which was living in SVGElement as member variable, keeping a HashMap<AttributeName, SVGAnimatedProperty>.
          It was needed before to lookup a SVGAnimatedProperty for a XML DOM attribute, in order to synchronize SVG <-> XML dom properties/attributes.
          Instead just add a "synchronizeProperty(const QualifiedName&)" method to all SVG*Element classes. As each SVG*Element class knows about its
          animated properties it can just ask them to synchronize themselves - no need for any dynamic lookups anymore.

        - Remove SynchronizableTypeWrapper which added more complexity for the sake of SVG <-> XML DOM synchronization, all replaced by synchronizeProperty.

        - Pass around any POD objects as const references, instead of copying them for no reason.

        - Clean up SVGAnimatedProperty, splitting up into SVGAnimatedProperty/PropertySynchronizer/PropertyTraits.

        - Remove baseValue/setBaseValue code from SVGDocumentExtensions, not needed anymore.

        ... and tons of changes to all SVG*Element classes, adapting to the new way of handling animated properties.

        * GNUmakefile.am: Remove Synchronizable* from build, add new SVGAnimatedPropertySynchronizer/Traits files
        * WebCore.gypi: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * bindings/js/JSSVGPODTypeWrapper.h: Change synchronization callback signatures, as we pass around const-references now.
        * dom/Element.cpp: Let updateAnimatedSVGAttribute take a QualifiedName instead of pure Strings.
        (WebCore::Element::getAttribute):
        (WebCore::Element::hasAttributes):
        * dom/Element.h:
        (WebCore::Element::updateAnimatedSVGAttribute):
        (WebCore::Element::attributes):
        * dom/make_names.pl: Remove SVG specific "exportString" / "exportStrings" functionality, see above.
        * html/HTMLAttributeNames.in: Remove "exportString" tag from "className" attribute.
        * manual-tests/svg-node-count-vs-scroll.xhtml: Added. Can be used to verify memory consumption with a lot of DOM objects.
        * mathml/mathattrs.in: MathML doesn't need "exportStrings" - remove it.
        * mathml/mathtags.in: Ditto.
        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::SVGAElement):
        (WebCore::SVGAElement::synchronizeProperty):
        * svg/SVGAElement.h:
        * svg/SVGAllInOne.cpp: Remove SynchronizablePropertyController.cpp
        * svg/SVGAltGlyphElement.cpp:
        (WebCore::SVGAltGlyphElement::SVGAltGlyphElement):
        (WebCore::SVGAltGlyphElement::synchronizeProperty):
        * svg/SVGAltGlyphElement.h:
        * svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
        * svg/SVGAnimatedProperty.h: Rewritten, see above for details.
        (WebCore::SVGAnimatedPropertyTearOff::create):
        (WebCore::SVGAnimatedPropertyTearOff::setBaseVal):
        (WebCore::SVGAnimatedPropertyTearOff::setAnimVal):
        (WebCore::SVGAnimatedPropertyTearOff::baseVal):
        (WebCore::SVGAnimatedPropertyTearOff::animVal):
        (WebCore::SVGAnimatedPropertyTearOff::associatedAttributeName):
        (WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff):
        (WebCore::SVGAnimatedPropertyTearOff::~SVGAnimatedPropertyTearOff):
        (WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):
        (WebCore::SVGAnimatedProperty::SVGAnimatedProperty):
        (WebCore::SVGAnimatedProperty::value):
        (WebCore::SVGAnimatedProperty::baseValue):
        (WebCore::SVGAnimatedProperty::setValue):
        (WebCore::SVGAnimatedProperty::setBaseValue):
        (WebCore::SVGAnimatedProperty::shouldSynchronize):
        (WebCore::SVGAnimatedProperty::setShouldSynchronize):
        * svg/SVGAnimatedPropertySynchronizer.h: Added.
        (WebCore::):
        * svg/SVGAnimatedPropertyTraits.h: Added.
        (WebCore::):
        * svg/SVGAnimatedTemplate.h: Move SVGAnimatedPropertyTraits into its own file.
        (WebCore::SVGAnimatedTemplate::forgetWrapper):
        (WebCore::lookupOrCreateWrapper):
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::SVGAnimationElement):
        (WebCore::SVGAnimationElement::synchronizeProperty):
        * svg/SVGAnimationElement.h:
        * svg/SVGCircleElement.cpp:
        (WebCore::SVGCircleElement::SVGCircleElement):
        (WebCore::SVGCircleElement::synchronizeProperty):
        * svg/SVGCircleElement.h:
        * svg/SVGClipPathElement.cpp:
        (WebCore::SVGClipPathElement::SVGClipPathElement):
        (WebCore::SVGClipPathElement::synchronizeProperty):
        * svg/SVGClipPathElement.h:
        * svg/SVGComponentTransferFunctionElement.cpp:
        (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
        (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
        (WebCore::SVGComponentTransferFunctionElement::synchronizeProperty):
        * svg/SVGComponentTransferFunctionElement.h:
        * svg/SVGCursorElement.cpp:
        (WebCore::SVGCursorElement::SVGCursorElement):
        (WebCore::SVGCursorElement::synchronizeProperty):
        * svg/SVGCursorElement.h:
        * svg/SVGDefsElement.cpp:
        (WebCore::SVGDefsElement::SVGDefsElement):
        (WebCore::SVGDefsElement::synchronizeProperty):
        * svg/SVGDefsElement.h:
        * svg/SVGDocumentExtensions.h:
        * svg/SVGElement.cpp: Adapt to synchronization changes: use synchronizeProperty() call, instead of SynchronizablePropertyController.
        (WebCore::SVGElement::updateAnimatedSVGAttribute):
        * svg/SVGElement.h: Don't store SynchronizablePropertyController anymore, it's gone.
        (WebCore::SVGElement::synchronizeProperty):
        (WebCore::SVGElement::setSynchronizedSVGAttributes):
        * svg/SVGEllipseElement.cpp:
        (WebCore::SVGEllipseElement::SVGEllipseElement):
        (WebCore::SVGEllipseElement::synchronizeProperty):
        * svg/SVGEllipseElement.h:
        * svg/SVGExternalResourcesRequired.cpp:
        * svg/SVGExternalResourcesRequired.h:
        * svg/SVGFEBlendElement.cpp:
        (WebCore::SVGFEBlendElement::SVGFEBlendElement):
        (WebCore::SVGFEBlendElement::synchronizeProperty):
        * svg/SVGFEBlendElement.h:
        * svg/SVGFEColorMatrixElement.cpp:
        (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
        (WebCore::SVGFEColorMatrixElement::synchronizeProperty):
        * svg/SVGFEColorMatrixElement.h:
        * svg/SVGFEComponentTransferElement.cpp:
        (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
        (WebCore::SVGFEComponentTransferElement::synchronizeProperty):
        * svg/SVGFEComponentTransferElement.h:
        * svg/SVGFECompositeElement.cpp:
        (WebCore::SVGFECompositeElement::SVGFECompositeElement):
        (WebCore::SVGFECompositeElement::parseMappedAttribute):
        (WebCore::SVGFECompositeElement::synchronizeProperty):
        * svg/SVGFECompositeElement.h:
        * svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
        (WebCore::SVGFEDiffuseLightingElement::synchronizeProperty):
        * svg/SVGFEDiffuseLightingElement.h:
        * svg/SVGFEDisplacementMapElement.cpp:
        (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
        (WebCore::SVGFEDisplacementMapElement::synchronizeProperty):
        * svg/SVGFEDisplacementMapElement.h:
        * svg/SVGFEGaussianBlurElement.cpp:
        (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
        (WebCore::SVGFEGaussianBlurElement::synchronizeProperty):
        * svg/SVGFEGaussianBlurElement.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::SVGFEImageElement):
        (WebCore::SVGFEImageElement::synchronizeProperty):
        * svg/SVGFEImageElement.h:
        * svg/SVGFELightElement.cpp:
        (WebCore::SVGFELightElement::SVGFELightElement):
        (WebCore::SVGFELightElement::synchronizeProperty):
        * svg/SVGFELightElement.h:
        * svg/SVGFEMergeNodeElement.cpp:
        (WebCore::SVGFEMergeNodeElement::SVGFEMergeNodeElement):
        (WebCore::SVGFEMergeNodeElement::synchronizeProperty):
        * svg/SVGFEMergeNodeElement.h:
        * svg/SVGFEMorphologyElement.cpp:
        (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement):
        (WebCore::SVGFEMorphologyElement::synchronizeProperty):
        * svg/SVGFEMorphologyElement.h:
        * svg/SVGFEOffsetElement.cpp:
        (WebCore::SVGFEOffsetElement::SVGFEOffsetElement):
        (WebCore::SVGFEOffsetElement::synchronizeProperty):
        * svg/SVGFEOffsetElement.h:
        * svg/SVGFESpecularLightingElement.cpp:
        (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement):
        (WebCore::SVGFESpecularLightingElement::synchronizeProperty):
        * svg/SVGFESpecularLightingElement.h:
        * svg/SVGFETileElement.cpp:
        (WebCore::SVGFETileElement::SVGFETileElement):
        (WebCore::SVGFETileElement::synchronizeProperty):
        * svg/SVGFETileElement.h:
        * svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
        (WebCore::SVGFETurbulenceElement::synchronizeProperty):
        * svg/SVGFETurbulenceElement.h:
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::SVGFilterElement):
        (WebCore::SVGFilterElement::synchronizeProperty):
        * svg/SVGFilterElement.h:
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes):
        (WebCore::SVGFilterPrimitiveStandardAttributes::synchronizeProperty):
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        * svg/SVGFitToViewBox.cpp:
        * svg/SVGFitToViewBox.h:
        * svg/SVGFontElement.cpp:
        (WebCore::SVGFontElement::SVGFontElement):
        (WebCore::SVGFontElement::synchronizeProperty):
        * svg/SVGFontElement.h:
        * svg/SVGForeignObjectElement.cpp:
        (WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
        (WebCore::SVGForeignObjectElement::synchronizeProperty):
        * svg/SVGForeignObjectElement.h:
        * svg/SVGGElement.cpp:
        (WebCore::SVGGElement::SVGGElement):
        (WebCore::SVGGElement::synchronizeProperty):
        * svg/SVGGElement.h:
        * svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::SVGGradientElement):
        (WebCore::SVGGradientElement::synchronizeProperty):
        * svg/SVGGradientElement.h:
        * svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::SVGImageElement):
        (WebCore::SVGImageElement::synchronizeProperty):
        * svg/SVGImageElement.h:
        * svg/SVGLineElement.cpp:
        (WebCore::SVGLineElement::SVGLineElement):
        (WebCore::SVGLineElement::synchronizeProperty):
        * svg/SVGLineElement.h:
        * svg/SVGLinearGradientElement.cpp:
        (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
        (WebCore::SVGLinearGradientElement::synchronizeProperty):
        * svg/SVGLinearGradientElement.h:
        * svg/SVGList.h: Adapt to const-reference changes.
        (WebCore::SVGPODListItem::setValue):
        * svg/SVGMPathElement.cpp:
        (WebCore::SVGMPathElement::SVGMPathElement):
        (WebCore::SVGMPathElement::synchronizeProperty):
        * svg/SVGMPathElement.h:
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::SVGMarkerElement):
        (WebCore::SVGMarkerElement::synchronizeProperty):
        * svg/SVGMarkerElement.h:
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::SVGMaskElement):
        (WebCore::SVGMaskElement::synchronizeProperty):
        * svg/SVGMaskElement.h:
        * svg/SVGPathElement.cpp:
        (WebCore::SVGPathElement::SVGPathElement):
        (WebCore::SVGPathElement::synchronizeProperty):
        * svg/SVGPathElement.h:
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::SVGPatternElement):
        (WebCore::SVGPatternElement::synchronizeProperty):
        * svg/SVGPatternElement.h:
        * svg/SVGPolyElement.cpp:
        (WebCore::SVGPolyElement::SVGPolyElement):
        (WebCore::SVGPolyElement::svgAttributeChanged):
        (WebCore::SVGPolyElement::synchronizeProperty):
        * svg/SVGPolyElement.h:
        * svg/SVGRadialGradientElement.cpp:
        (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
        (WebCore::SVGRadialGradientElement::synchronizeProperty):
        * svg/SVGRadialGradientElement.h:
        * svg/SVGRectElement.cpp:
        (WebCore::SVGRectElement::SVGRectElement):
        (WebCore::SVGRectElement::synchronizeProperty):
        * svg/SVGRectElement.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::SVGSVGElement):
        (WebCore::SVGSVGElement::synchronizeProperty):
        * svg/SVGSVGElement.h:
        * svg/SVGScriptElement.cpp:
        (WebCore::SVGScriptElement::SVGScriptElement):
        (WebCore::SVGScriptElement::synchronizeProperty):
        * svg/SVGScriptElement.h:
        * svg/SVGStopElement.cpp:
        (WebCore::SVGStopElement::SVGStopElement):
        (WebCore::SVGStopElement::synchronizeProperty):
        * svg/SVGStopElement.h:
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::SVGStyledElement):
        (WebCore::SVGStyledElement::parseMappedAttribute):
        (WebCore::SVGStyledElement::synchronizeProperty):
        * svg/SVGStyledElement.h:
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
        (WebCore::SVGStyledTransformableElement::synchronizeProperty):
        * svg/SVGStyledTransformableElement.h:
        * svg/SVGSwitchElement.cpp:
        (WebCore::SVGSwitchElement::SVGSwitchElement):
        (WebCore::SVGSwitchElement::synchronizeProperty):
        * svg/SVGSwitchElement.h:
        * svg/SVGSymbolElement.cpp:
        (WebCore::SVGSymbolElement::SVGSymbolElement):
        (WebCore::SVGSymbolElement::synchronizeProperty):
        * svg/SVGSymbolElement.h:
        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::SVGTRefElement):
        (WebCore::SVGTRefElement::synchronizeProperty):
        * svg/SVGTRefElement.h:
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::SVGTextContentElement):
        (WebCore::SVGTextContentElement::synchronizeProperty):
        * svg/SVGTextContentElement.h:
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::SVGTextElement):
        (WebCore::SVGTextElement::synchronizeProperty):
        * svg/SVGTextElement.h:
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::SVGTextPathElement):
        (WebCore::SVGTextPathElement::synchronizeProperty):
        * svg/SVGTextPathElement.h:
        * svg/SVGTextPositioningElement.cpp:
        (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
        (WebCore::SVGTextPositioningElement::synchronizeProperty):
        * svg/SVGTextPositioningElement.h:
        * svg/SVGURIReference.cpp:
        * svg/SVGURIReference.h:
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::SVGUseElement):
        (WebCore::SVGUseElement::synchronizeProperty):
        * svg/SVGUseElement.h:
        * svg/SVGViewElement.cpp:
        (WebCore::SVGViewElement::SVGViewElement):
        (WebCore::SVGViewElement::synchronizeProperty):
        * svg/SVGViewElement.h:
        * svg/SVGViewSpec.cpp:
        (WebCore::SVGViewSpec::SVGViewSpec):
        * svg/SVGViewSpec.h:
        (WebCore::SVGViewSpec::contextElement):
        * svg/SynchronizablePropertyController.cpp: Removed.
        * svg/SynchronizablePropertyController.h: Removed.
        * svg/SynchronizableTypeWrapper.h: Removed.
        * svg/svgattrs.in: Remove "exportStrings" tag.
        * svg/svgtags.in: Ditto.
        * svg/xlinkattrs.in:

791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809
2010-01-26  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/7169464> REGRESSION (r47444): PLT is 1% slower due to implementation of :valid and :invalid CSS selectors
        https://bugs.webkit.org/show_bug.cgi?id=34029

        If we never hit the valid or invalid selectors for a particular document, 
        then we'll skip the validity checks when deciding about style sharing.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::canShareStyleWithElement):
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
        
        * dom/Document.cpp: (WebCore::Document::Document):
        * dom/Document.h:
        (WebCore::Document::considerValidity):
        (WebCore::Document::setConsiderValidity):

810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827
2010-01-26  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Simon Fraser.

        Revert 53797 as it seems to be causing crashes.
        https://bugs.webkit.org/show_bug.cgi?id=34153

        * page/FrameView.cpp:
        (WebCore::FrameView::useSlowRepaints):
        (WebCore::FrameView::useSlowRepaintsIfNotOverlapped):
        * page/FrameView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollContents):
        * platform/ScrollView.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::styleWillChange):
        (WebCore::RenderObject::destroy):

828 829 830 831 832 833 834 835 836 837 838 839 840
2010-01-26  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Steve Falkenburg.

        DumpRenderTree silently crashes at the end of the run because geolocationControllerClient pointer is 0.
        https://bugs.webkit.org/show_bug.cgi?id=34191

        * page/GeolocationController.cpp:
        (WebCore::GeolocationController::~GeolocationController): Add check for m_client being 0.
        (WebCore::GeolocationController::addObserver): Ditto.
        (WebCore::GeolocationController::removeObserver): Ditto.
        (WebCore::GeolocationController::lastPosition): Ditto.

841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867
2010-01-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adele Peterson.

        Enhance externalRepresentation() to make it more useful for layer debugging
        https://bugs.webkit.org/show_bug.cgi?id=34143

        Enhance externalRepresentation() to output additional information about layers when certain flags are passed.
        The new flags allow you to show all layers (not just those that would paint), to the structure of the z-order
        and normal flow lists, and to show which layers are composited.

        * WebCore.base.exp: The signature of externalRepresentation() changed.

        * platform/text/TextStream.h: Add operator<<(void*)
        * platform/text/TextStream.cpp: Implement operator<<(void*)

        * rendering/RenderLayer.h:
        * rendering/RenderLayer.cpp:
        (showLayerTree): New method outside the WebCore namespace, for ease of calling from gdb.

        * rendering/RenderTreeAsText.h: New behavior flags for externalRepresentation().
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write): Output compositing information if requested. Also clean up some -1/1 magic
        numbers with an enum.
        (WebCore::writeLayers): If requested, show layer nesting via the z-order and normal flow lists.
        (WebCore::externalRepresentation): New arguments

mitz@apple.com's avatar
mitz@apple.com committed
868 869 870 871 872 873 874 875 876
2010-01-26  Dan Bernstein  <mitz@apple.com>

        Reviewed by Simon Fraser.

        Fixed an off-by-one error.

        * rendering/break_lines.cpp:
        (WebCore::shouldBreakAfter):

877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902
2010-01-26  Dmitry Titov  <dimich@chromium.org>

        Reviewed by David Levin.

        Avoid reloading iframe on re-parenting between documents.
        https://bugs.webkit.org/show_bug.cgi?id=32848

        Achieved by setting a flag on iframe element when it is a target of document.adoptNode(node) operation.
        The flag prevents unload/load cycle and is reset once element is attached to a new document.
        If iframe is adopted but not actually inserted into the tree, it gets unloaded by async timer
        once JS yields, to avoid having active content in non-attached iframe.

        Test: fast/frames/iframe-reparenting.html

        * dom/Document.cpp:
        (WebCore::Document::adoptNode): If the adopted node is iframe, set a remainsAliveOnRemovalFromTree on it.
        * html/HTMLFrameElementBase.h:
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
        (WebCore::HTMLFrameElementBase::attach): Skip actual loading of the frame if it has remainsAliveOnRemovalFromTree flag. Reset the flag.
        (WebCore::HTMLFrameElementBase::willRemove): Skip unloading the frame if it has remainsAliveOnRemovalFromTree flag set.
        (WebCore::HTMLFrameElementBase::setRemainsAliveOnRemovalFromTree): Set the flag, start the async timer to check if the frame was actually attached.
        (WebCore::HTMLFrameElementBase::checkAttachedTimerFired):
        * html/HTMLFrameOwnerElement.h:
        (WebCore::HTMLFrameOwnerElement::willRemove): Move from private to protected, since it is conditionally called in HTMLFrameElementBase::willRemove now.

903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941
2010-01-26  Adam Roben  <aroben@apple.com>

        No review, rolling out r53861.
        http://trac.webkit.org/changeset/53861
        https://bugs.webkit.org/show_bug.cgi?id=33224

        Caused 2 regression tests to fail.

        * dom/Document.cpp:
        (WebCore::Document::detach):
        (WebCore::Document::registerHistoryItem):
        (WebCore::Document::unregisterHistoryItem):
        * dom/Document.h:
        * history/BackForwardList.cpp:
        (WebCore::BackForwardList::pushStateItem):
        * history/BackForwardListChromium.cpp:
        (WebCore::BackForwardList::pushStateItem):
        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::HistoryItem):
        (WebCore::HistoryItem::~HistoryItem):
        (WebCore::HistoryItem::setStateObject):
        (WebCore::HistoryItem::setDocument):
        (WebCore::HistoryItem::documentDetached):
        * history/HistoryItem.h:
        (WebCore::HistoryItem::document):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::navigateWithinDocument):
        (WebCore::FrameLoader::loadItem):
        * loader/HistoryController.cpp:
        (WebCore::HistoryController::updateBackForwardListForFragmentScroll):
        (WebCore::HistoryController::pushState):
        (WebCore::HistoryController::replaceState):
        * loader/RedirectScheduler.cpp:
        (WebCore::RedirectScheduler::scheduleHistoryNavigation):
        * page/History.cpp:
        (WebCore::History::stateObjectAdded):
        * page/Page.cpp:
        (WebCore::Page::goToItem):

942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961
2010-01-26  Dan Bernstein  <mitz@apple.com>

        Reviewed by Beth Dakin.

        <rdar://problem/7576663> Crash caused by anonymous list item
        https://bugs.webkit.org/show_bug.cgi?id=34183

        Test: fast/lists/anonymous-items.html

        enclosingList() and previousListItem() were DOM-based, but in order to work with anonymous
        list items, they need to work with rthe render tree.

        * rendering/RenderListItem.cpp:
        (WebCore::isList): Factored out.
        (WebCore::enclosingList): Added this variant that takes a RenderObject.
        (WebCore::previousListItem): Changed to travers the render tree.
        (WebCore::RenderListItem::calcValue): Use the RenderObject version of enclosingList()
        (WebCore::RenderListItem::setExplicitValue): Added an assertion.
        (WebCore::RenderListItem::clearExplicitValue): Ditto.

962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987
2010-01-26  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Jon Honeycutt.

        Crash in WebKit!WebCore::RenderMenuList::itemStyle
        https://bugs.webkit.org/show_bug.cgi?id=34182
        <rdar://7087757>
        
        Added bounds checks in RenderMenuList to make sure we are
        not making an out of bounds check in a vector once an option
        element has been deleted. If we are out of bounds, we fall back to
        a default value and return early, and in the case of itemStyle, we use a 
        previous option's style, if it is available.

        * manual-tests/select-delete-item.html: Added.
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::itemText): If out of bounds check, return early.
        (WebCore::RenderMenuList::itemToolTip): Ditto.
        (WebCore::RenderMenuList::itemIsEnabled): Ditto.
        (WebCore::RenderMenuList::itemStyle): If out of bounds check, try using the 0th index
            option style, then fall back to the select's style if that option doesn't exist.
        (WebCore::RenderMenuList::itemBackgroundColor): If out of bounds check, return early.
        (WebCore::RenderMenuList::itemIsSeparator): Ditto.
        (WebCore::RenderMenuList::itemIsLabel): Ditto.
        (WebCore::RenderMenuList::itemIsSelected): Ditto.

barraclough@apple.com's avatar
barraclough@apple.com committed
988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010
2010-01-25  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Anders Carlsson.

        Some methods in JSC JNI bridge need more error checking of results from JNI.
        https://bugs.webkit.org/show_bug.cgi?id=34149

        In JNIUtility.h, callJNIMethodV<jobject> might return null (from CallObjectMethodV, via
        JNICaller<jobject>::callV) if an exception is thrown.  All clients of callJNIMethodV<jobject>
        that are calling methods on the returned object should null check first.

        * bridge/jni/JNIBridge.cpp:
        (JavaField::JavaField):
        (JavaMethod::JavaMethod):
        * bridge/jni/JNIUtility.h:
        (JSC::Bindings::):
        * bridge/jni/jni_jsobject.mm:
        (JavaJSObject::convertJObjectToValue):
        * bridge/jni/jsc/JavaClassJSC.cpp:
        (JavaClass::JavaClass):
        * bridge/jni/jsc/JavaInstanceJSC.cpp:
        (JavaInstance::stringValue):

1011 1012 1013 1014 1015 1016 1017 1018 1019 1020
2010-01-26  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Oliver Hunt.

        Windows build references non-existent include paths
        https://bugs.webkit.org/show_bug.cgi?id=34175

        * WebCore.vcproj/QTMovieWin.vcproj:
        * WebCore.vcproj/WebCoreCommon.vsprops:

1021
2010-01-26  Darin Fisher  <darin@chromium.org>
1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070

        Reviewed by Brady Eidson.

        Chains of history items representing same-document navigation need to
        always remember that association

        https://bugs.webkit.org/show_bug.cgi?id=33224

        Replace HistoryItem's Document pointer with a DocumentSequenceNumber.
        During session history traversal, if the current HistoryItem and the
        target HistoryItem have the same DocumentSequenceNumber, then it means
        that the current Document should remain.

        NOTE: To support Chromium's serialization of HistoryItems, I generate
        DocumentSequenceNumbers that are unique across application launches.
        DocumentSequenceNumbers are generated using a counter initialized with
        the time of day.

        Test: fast/loader/stateobjects/document-destroyed-navigate-back.html

        * dom/Document.cpp:
        (WebCore::Document::detach):
        * dom/Document.h:
        * history/BackForwardList.cpp:
        (WebCore::BackForwardList::pushStateItem):
        * history/BackForwardListChromium.cpp:
        (WebCore::BackForwardList::pushStateItem):
        * history/HistoryItem.cpp:
        (WebCore::generateDocumentSequenceNumber):
        (WebCore::HistoryItem::HistoryItem):
        (WebCore::HistoryItem::~HistoryItem):
        (WebCore::HistoryItem::setStateObject):
        * history/HistoryItem.h:
        (WebCore::HistoryItem::setDocumentSequenceNumber):
        (WebCore::HistoryItem::documentSequenceNumber):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::navigateWithinDocument):
        (WebCore::FrameLoader::loadItem):
        * loader/HistoryController.cpp:
        (WebCore::HistoryController::updateBackForwardListForFragmentScroll):
        (WebCore::HistoryController::pushState):
        (WebCore::HistoryController::replaceState):
        * loader/RedirectScheduler.cpp:
        (WebCore::RedirectScheduler::scheduleHistoryNavigation):
        * page/History.cpp:
        (WebCore::History::stateObjectAdded):
        * page/Page.cpp:
        (WebCore::Page::goToItem):

1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129
2010-01-26  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Add ability for image maps to be focused via tabbing
        https://bugs.webkit.org/show_bug.cgi?id=17513

        Test: fast/events/tab-imagemap.html

        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::focusedImageMapUIElement):
        (WebCore::AXObjectCache::focusedUIElementForPage):
        * accessibility/AXObjectCache.h:
        * accessibility/AccessibilityImageMapLink.h:
        (WebCore::AccessibilityImageMapLink::areaElement):
        (WebCore::AccessibilityImageMapLink::mapElement):
        (WebCore::AccessibilityImageMapLink::isImageMapLink):
        * accessibility/AccessibilityObject.h:
        (WebCore::AccessibilityObject::isImageMapLink):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
        * html/HTMLAreaElement.cpp:
        (WebCore::HTMLAreaElement::getPath):
        (WebCore::HTMLAreaElement::getRect):
        (WebCore::HTMLAreaElement::imageElement):
        (WebCore::HTMLAreaElement::isKeyboardFocusable):
        (WebCore::HTMLAreaElement::isFocusable):
        (WebCore::HTMLAreaElement::dispatchBlurEvent):
        (WebCore::HTMLAreaElement::updateFocusAppearance):
        (WebCore::HTMLAreaElement::supportsFocus):
        * html/HTMLAreaElement.h:
        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::imageElement):
        * html/HTMLMapElement.h:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/haiku/GraphicsContextHaiku.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/mac/GraphicsContextMac.mm:
        (WebCore::drawFocusRingToContext):
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/win/GraphicsContextCGWin.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/wince/GraphicsContextWince.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint):
        (WebCore::RenderImage::paintFocusRings):
        (WebCore::RenderImage::imageMap):
        * rendering/RenderImage.h:
        * rendering/RenderReplaced.h:

1130 1131
2010-01-26  Pavel Feldman  <pfeldman@chromium.org>

1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201
        Reviewed by Timothy Hatcher.

        Web Inspector: add support for breakpoints, messages and search into the SourceFrame2.

        https://bugs.webkit.org/show_bug.cgi?id=34165

        * inspector/front-end/SourceFrame2.js:
        (WebInspector.SourceFrame2):
        (WebInspector.SourceFrame2.prototype.get executionLine):
        (WebInspector.SourceFrame2.prototype.set executionLine):
        (WebInspector.SourceFrame2.prototype.revealLine):
        (WebInspector.SourceFrame2.prototype.addBreakpoint):
        (WebInspector.SourceFrame2.prototype.removeBreakpoint):
        (WebInspector.SourceFrame2.prototype.sizeToFitContentHeight):
        (WebInspector.SourceFrame2.prototype.setContent):
        (WebInspector.SourceFrame2.prototype.findSearchMatches):
        (WebInspector.SourceFrame2.prototype.setSelection):
        (WebInspector.SourceFrame2.prototype._addMessageToSource):
        (WebInspector.SourceFrame2.prototype._addExistingBreakpointsToSource):
        (WebInspector.SourceFrame2.prototype._addBreakpointToSource):
        (WebInspector.SourceFrame2.prototype._removeBreakpointFromSource):
        (WebInspector.SourceFrame2.prototype._contextMenu.addConditionalBreakpoint):
        (WebInspector.SourceFrame2.prototype._contextMenu):
        (WebInspector.SourceFrame2.prototype._toggleBreakpoint):
        (WebInspector.SourceFrame2.prototype._editBreakpointCondition.committed):
        (WebInspector.SourceFrame2.prototype._editBreakpointCondition.dismissed):
        (WebInspector.SourceFrame2.prototype._editBreakpointCondition):
        (WebInspector.SourceFrame2.prototype._showBreakpointConditionPopup):
        (WebInspector.SourceFrame2.prototype._createConditionElement):
        (WebInspector.SourceFrame2.prototype._keyDown):
        (WebInspector.SourceFrame2.prototype._evalSelectionInCallFrame):
        (WebInspector.SourceFrame2.prototype._breakpointChanged):
        (WebInspector.SourceFrame2.prototype.resize):
        (WebInspector.BreakpointLineNumberDecorator.prototype.decorate):
        (WebInspector.BreakpointLineNumberDecorator.prototype._paintBreakpoint):
        (WebInspector.BreakpointLineNumberDecorator.prototype.mouseDown):
        (WebInspector.BreakpointLineNumberDecorator.prototype.contextMenu):
        (WebInspector.ExecutionLineDecorator.prototype.decorate):
        * inspector/front-end/TextEditor.js:
        (WebInspector.TextEditor):
        (WebInspector.TextEditor.prototype.set mimeType):
        (WebInspector.TextEditor.prototype.set readOnly):
        (WebInspector.TextEditor.prototype.setDivDecoration):
        (WebInspector.TextEditor.prototype.reveal):
        (WebInspector.TextEditor.prototype.packAndRepaintAll):
        (WebInspector.TextEditor.prototype._updateSize):
        (WebInspector.TextEditor.prototype.updateCanvasSize):
        (WebInspector.TextEditor.prototype.repaintAll):
        (WebInspector.TextEditor.prototype._paintLinesContinuation):
        (WebInspector.TextEditor.prototype._repaintOnScroll):
        (WebInspector.TextEditor.prototype._mouseDown):
        (WebInspector.TextEditor.prototype._contextMenu):
        (WebInspector.TextEditor.prototype._caretForMouseEvent):
        (WebInspector.TextEditor.prototype._columnForOffset):
        (WebInspector.TextEditor.prototype._handleNavigationKey):
        (WebInspector.TextEditor.prototype._positionDivDecoration):
        (WebInspector.TextEditor.prototype._replaceSelectionWith):
        (WebInspector.TextEditor.prototype.setCoalescingUpdate):
        (WebInspector.TextEditor.prototype._handleUndo):
        (WebInspector.TextEditor.prototype._handleRedo):
        (WebInspector.TextEditor.prototype._changeFont):
        * inspector/front-end/TextEditorHighlighter.js:
        (WebInspector.TextEditorHighlighter):
        (WebInspector.TextEditorHighlighter.prototype.set mimeType):
        * inspector/front-end/inspector.css:
        * inspector/front-end/textEditor.css:

2010-01-26  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.
1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220

        Web Inspector: add methods for getting resource content from within frontend.

        https://bugs.webkit.org/show_bug.cgi?id=34163

        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::getResourceContent):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::didGetResourceContent):
        * inspector/InspectorFrontend.h:
        * inspector/InspectorFrontendHost.cpp:
        * inspector/InspectorFrontendHost.h:
        * inspector/InspectorFrontendHost.idl:
        * inspector/front-end/InspectorBackendStub.js:
        (.WebInspector.InspectorBackendStub.prototype.getResourceContent):
        * inspector/front-end/InspectorFrontendHostStub.js:

1221 1222 1223 1224 1225 1226 1227
2010-01-26  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: added null check into the timeline agent getter.

        * inspector/InspectorTimelineAgent.h:
        (WebCore::InspectorTimelineAgent::retrieve):

1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252
2010-01-26  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        Moves JSC-specific classes from bridge/jni/JNIBridge to bridge/jni/jsc/JNIBridgeJSC
        https://bugs.webkit.org/show_bug.cgi?id=33958

        This allows bridge/jni/JNIBridge to be used with both JSC and V8.
        A later change will add the V8 equivalent of these JSC-specific classes.

        No new tests, refactoring only.

        * Android.jscbindings.mk: Modified. Added JNIBridgeJSC.cpp
        * GNUmakefile.am: Modified. Added JNIBridgeJSC.h
        * WebCore.xcodeproj/project.pbxproj: Modified. Added JNIBridgeJSC.[cpp|h]
        * bridge/jni/JNIBridge.cpp: Modified. Moved JavaField and JavaArray to JNIBridgeJSC.cpp
        (appendClassName): Modfied. Guard calls to JSLock
        (JavaMethod::signature): Modfied. Guard calls to JSLock
        * bridge/jni/JNIBridge.h: Modified. Moved JavaField and JavaArray to JNIBridgeJSC.h
        * bridge/jni/jsc/JNIBridgeJSC.cpp: Copied from WebCore/bridge/jni/JNIBridge.cpp.
        * bridge/jni/jsc/JNIBridgeJSC.h: Copied from WebCore/bridge/jni/JNIBridge.h.
        * bridge/jni/jsc/JNIUtilityPrivate.cpp: Modified. Include JNIBridgeJSC.h
        * bridge/jni/jsc/JavaClassJSC.h: Modified. Include JNIBridgeJSC.h
        * bridge/jni/jsc/JavaInstanceJSC.cpp: Modified. Include JNIBridgeJSC.h

1253 1254 1255 1256 1257 1258 1259 1260 1261
2010-01-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Unreviewed build fix.

        [Qt] Fix Windows build when sqlite is not available.

        * WebCore.pri:
        * WebCore.pro:

1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273
2010-01-26  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon Hausmann.

        [Qt] JavaScript prompt is currently broken.
        https://bugs.webkit.org/show_bug.cgi?id=30914

        Remove the manual test case in favor of an automated
        test case in WebKit/qt/tests/qwebpage.

        * manual-tests/qt/java-script-prompt.html: Removed.

1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314
2010-01-26  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Implement HTML and CSS highlighters.

        https://bugs.webkit.org/show_bug.cgi?id=34144

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/JavaScriptTokenizer.js: Removed.
        * inspector/front-end/JavaScriptTokenizer.re2js: Removed.
        * inspector/front-end/SourceCSSTokenizer.js: Added.
        (WebInspector.SourceCSSTokenizer):
        (WebInspector.SourceCSSTokenizer.prototype._stringToken):
        (WebInspector.SourceCSSTokenizer.prototype._isPropertyValue):
        (WebInspector.SourceCSSTokenizer.prototype.nextToken):
        * inspector/front-end/SourceCSSTokenizer.re2js: Added.
        * inspector/front-end/SourceHTMLTokenizer.js: Added.
        (WebInspector.SourceHTMLTokenizer):
        (WebInspector.SourceHTMLTokenizer.prototype._stringToken):
        (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
        * inspector/front-end/SourceHTMLTokenizer.re2js: Added.
        * inspector/front-end/SourceJavaScriptTokenizer.js: Added.
        (WebInspector.SourceJavaScriptTokenizer):
        (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
        * inspector/front-end/SourceJavaScriptTokenizer.re2js: Added.
        * inspector/front-end/TextEditorHighlighter.js:
        (WebInspector.TextEditorHighlighter):
        (WebInspector.TextEditorHighlighter.prototype._highlightLines):
        (WebInspector.TextEditorHighlighter.Tokenizer):
        (WebInspector.TextEditorHighlighter.Tokenizer.prototype.set line):
        (WebInspector.TextEditorHighlighter.Tokenizer.prototype.set condition):
        (WebInspector.TextEditorHighlighter.Tokenizer.prototype.get condition):
        (WebInspector.TextEditorHighlighter.Tokenizer.prototype.hasCondition):
        (WebInspector.TextEditorHighlighter.Tokenizer.prototype.getLexCondition):
        (WebInspector.TextEditorHighlighter.Tokenizer.prototype.setLexCondition):
        (WebInspector.TextEditorHighlighter.Tokenizer.prototype._charAt):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331
2010-01-26  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Holger Freyther.

        REGRESSION(r53835): Fix editing/pasteboard/paste-noscript-xhtml.xhtml
        https://bugs.webkit.org/show_bug.cgi?id=34157

        Pass the FragmentScriptingPermission correctly through to the DOM
        and disallow scripting elements in parseEndElement(), similar to
        the libxml tokenizer change in r53835.

        * dom/XMLTokenizerQt.cpp:
        (WebCore::handleElementNamespaces):
        (WebCore::handleElementAttributes):
        (WebCore::XMLTokenizer::parseStartElement):
        (WebCore::XMLTokenizer::parseEndElement):

1332 1333 1334 1335 1336 1337 1338 1339 1340
2010-01-26  Garret Kelly  <gdk@chromium.org>

        Reviewed by Eric Seidel.

        Add missing declaration for the feMorphology SVG element.
        https://bugs.webkit.org/show_bug.cgi?id=34151

        * bindings/v8/V8DOMWrapper.cpp:

zoltan@webkit.org's avatar
zoltan@webkit.org committed
1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352
2010-01-26  Andras Becsi  <abecsi@inf.u-szeged.hu>

        Unreviewed build fix.

        [Qt] Build fix after API changes in r53835.

        No new tests needed.

        * dom/XMLTokenizerQt.cpp:
        (WebCore::XMLTokenizer::XMLTokenizer):
        (WebCore::parseXMLDocumentFragment):

1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386
2010-01-22  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Adler.

        Make storage events match the spec.
        https://bugs.webkit.org/show_bug.cgi?id=30546

        This meat of the patch I just posted is very simple.  It's just making events
        asynchronous, not posting them to the frame that generated them, passing a null
        for the key when issuing a clear storage event, and making the events
        non-cancelable/non-bubbleable...all of which are clearly stated in the spec.

        The asynchronous and not posting to the frame that generated them forced me to
        re-write all the layout tests that dealt with storage events.  There's a lot of
        code there, but I tried to be fairly careful to ensure that test coverage did
        not shrink in any area.

        Tests: storage/domstorage/events/basic-body-attribute.html
               storage/domstorage/events/basic-setattribute.html
               storage/domstorage/events/basic.html
               storage/domstorage/events/case-sensitive.html
               storage/domstorage/events/documentURI.html

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::enqueueStorageEvent):
        (WebCore::Document::storageEventTimerFired):
        * dom/Document.h:
        * storage/StorageEvent.cpp:
        (WebCore::StorageEvent::StorageEvent):
        * storage/StorageEvent.idl:
        * storage/StorageEventDispatcher.cpp:
        (WebCore::StorageEventDispatcher::dispatch):

1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406
2010-01-25  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/7573493> Error with line break inside ?&raquo; pair of characters.
        https://bugs.webkit.org/show_bug.cgi?id=17475

        Test: fast/text/line-break-after-question-mark.html

        Instead of unconditionally allowing lines to break after a question mark, which was intended
        to mimic Internet Explorer, apply the Unicode line breaking behavior after a question mark,
        with one exception in the ASCII range to match IE, namely not allowing a line break between
        a question mark and a vertical line.

        * rendering/break_lines.cpp:
        (WebCore::shouldBreakAfter): Added a next character parameter. Changed to consult a table
        for the question mark case in order to keep it fast and not require a text break iterator in
        the ASCII case.
        (WebCore::nextBreakablePosition): Pass the next character to shouldBreakAfter.

1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418
2010-01-25  Peter Kasting  <pkasting@google.com>

        Reviewed by Dan Bernstein.

        Mac scrollbar thumbs were drawn with the wrong size.
        https://bugs.webkit.org/show_bug.cgi?id=34049

        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::ScrollbarThemeChromiumMac::paint):
        * platform/mac/ScrollbarThemeMac.mm:
        (WebCore::ScrollbarThemeMac::paint):

1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441
2010-01-25  Enrica Casucci  <enrica@apple.com>

        Reviewed by Darin Adler.

        Cleanup unwanted tags after pasting.
        https://bugs.webkit.org/show_bug.cgi?id=34148
        
        Test: editing/pasteboard/paste-noscript-xhtml.xhtml

        * dom/Element.cpp:
        (WebCore::Element::setAttributeNS):
        * dom/Element.h:
        * dom/XMLTokenizer.h:
        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::XMLTokenizer):
        (WebCore::handleElementNamespaces):
        (WebCore::handleElementAttributes):
        (WebCore::XMLTokenizer::startElementNs):
        (WebCore::XMLTokenizer::endElementNs):
        (WebCore::parseXMLDocumentFragment):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::createContextualFragment):

1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452
2010-01-25  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Simon Fraser.

        A WebGeolocationControllerClient is leaked for every WebView
        https://bugs.webkit.org/show_bug.cgi?id=34145

        * page/GeolocationController.cpp:
        (WebCore::GeolocationController::~GeolocationController):
        * page/GeolocationControllerClient.h:

1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464
2010-01-25  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Fixed bug in positioning of scroll layer within the
        parent root layer.
        https://bugs.webkit.org/show_bug.cgi?id=33847
        
        * platform/graphics/win/WKCACFLayerRenderer.cpp:
        (WebCore::WKCACFLayerRenderer::setScrollFrame):
        (WebCore::WKCACFLayerRenderer::createRenderer):

1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477
2010-01-25  Alexey Proskuryakov  <ap@apple.com>

        Rubber-stamped by Geoffrey Garen.

        https://bugs.webkit.org/show_bug.cgi?id=34076
        An image remains accessible via form.property syntax after being removed from document.

        Fix crashing regression tests (tables/mozilla/bugs/bug4527.html et al.)

        * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::insertedIntoTree): Remove incorrect
        assertions added in the previous patch - it's mot true that m_for is always a parent; table
        parsing can reparent the image element, but m_form still needs to be set.

ap@apple.com's avatar
ap@apple.com committed
1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498
2010-01-25  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Geoffrey Garen.

        https://bugs.webkit.org/show_bug.cgi?id=34076
        An image remains accessible via form.property syntax after being removed from document.

        Tests: fast/forms/removed-image-as-property.html
               fast/forms/reparented-image-as-property.html

        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::~HTMLImageElement): This is called during GC - not a good time
        to make observable changes to DOM.
        (WebCore::HTMLImageElement::insertedIntoTree): This is the right place to do any work that
        depends on connectedness to some ancestor. We still allow for m_form to be set via constructor,
        which happens during parsing.
        (WebCore::HTMLImageElement::removedFromTree): Ditto.

        * html/HTMLImageElement.h: Added removedFromTree/insertedIntoTree, moved removedFromDocument
        and insertedIntoDocument to private section, as they shouldn't be called directly.

1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642
2010-01-25  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=34073

        Fixes misspelled words in comments.

        * accessibility/AccessibilityListBox.cpp:
        (WebCore::AccessibilityListBox::addChildren):
        (WebCore::AccessibilityListBox::doAccessibilityHitTest):
        * accessibility/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper detach]):
        (AXAttributeStringSetElement):
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::completeURL):
        * bindings/js/JSDOMWindowBase.cpp:
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::getOwnPropertySlot):
        * bindings/js/JSSVGPODTypeWrapper.h:
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::evaluateInWorld):
        * bridge/NP_jsobject.cpp:
        (_NPN_SetException):
        * bridge/jni/jsc/JavaInstanceJSC.cpp:
        (JavaInstance::invokeMethod):
        (JObjectWrapper::JObjectWrapper):
        * bridge/objc/objc_instance.mm:
        (ObjcInstance::setValueOfUndefinedField):
        (ObjcInstance::getValueOfUndefinedField):
        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::CSSStyleSelector::sortMatchedRules):
        (WebCore::CSSStyleSelector::applyDeclarations):
        (WebCore::CSSStyleSelector::applyProperty):
        * dom/Document.cpp:
        (WebCore::Document::updateLayoutIgnorePendingStylesheets):
        (WebCore::Document::detach):
        * dom/Document.h:
        * dom/Element.cpp:
        (WebCore::Element::updateFocusAppearance):
        * dom/Element.h:
        * dom/MessagePortChannel.h:
        * dom/MouseRelatedEvent.cpp:
        (WebCore::MouseRelatedEvent::receivedTarget):
        * dom/Node.cpp:
        (WebCore::Node::isFocusable):
        (WebCore::Node::shadowAncestorNode):
        * dom/Node.h:
        * dom/Position.cpp:
        (WebCore::Position::upstream):
        * dom/Position.h:
        * dom/Range.cpp:
        (WebCore::Range::processContents):
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::addCSSColor):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::StyleChange::reconcileTextDecorationProperties):
        (WebCore::StyleChange::extractTextStyles):
        (WebCore::prepareEditingStyleToApplyAt):
        * editing/DeleteButtonController.cpp:
        (WebCore::isDeletableElement):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializeStartEnd):
        * editing/Editor.cpp:
        (WebCore::Editor::learnSpelling):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleMessage.prototype._format):
        * loader/Cache.cpp:
        (WebCore::Cache::pruneLiveResources):
        (WebCore::Cache::pruneDeadResources):
        * loader/Cache.h:
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::makePurgeable):
        * loader/CachedResource.h:
        * loader/CachedResourceHandle.h:
        * loader/DocumentLoader.h:
        * loader/FTPDirectoryParser.cpp:
        (WebCore::parseOneFTPLine):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::didExplicitOpen):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::didCancel):
        * loader/WorkerThreadableLoader.h:
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::spaceNeeded):
        * notifications/NotificationPresenter.h:
        (WebCore::NotificationPresenter::):
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationController::updateAnimations):
        * platform/LinkHash.cpp:
        (WebCore::cleanPath):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::calculateDrawingMode):
        * platform/graphics/cg/PatternCG.cpp:
        (WebCore::Pattern::createPlatformPattern):
        * platform/graphics/mac/ComplexTextController.cpp:
        (WebCore::ComplexTextController::offsetForPosition):
        * platform/graphics/mac/GraphicsLayerCA.h:
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::ensureStructuralLayer):
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::doSeek):
        (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
        (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writePlainText):
        (WebCore::Pasteboard::writeURL):
        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::registerExtendedEncodingNames):
        * platform/text/TextEncodingDetectorICU.cpp:
        (WebCore::detectTextEncoding):
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::calcEffectiveWidth):
        (WebCore::AutoTableLayout::layout):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcAbsoluteHorizontalValues):
        (WebCore::RenderBox::calcAbsoluteVerticalValues):
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
        (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollByRecursively):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::hitTestLayer):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::destroy):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::setInnerTextValue):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::stateChanged):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::mapLocalToContainer):
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::buildTextChunks):
        * rendering/TransformState.cpp:
        (WebCore::TransformState::flattenWithTransform):
        * wml/WMLInputElement.cpp:
        (WebCore::WMLInputElement::dispatchBlurEvent):
        (WebCore::WMLInputElement::suggestedValue):

ggaren@apple.com's avatar
ggaren@apple.com committed
1643 1644 1645 1646 1647 1648 1649 1650 1651 1652
2010-01-25  Geoffrey Garen  <ggaren@apple.com>

        Suggested by Darin Adler.

        Fixed a spelling error, tightened up some grammar.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::forgetDOMObject):
        (WebCore::forgetDOMNode):

1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665
2010-01-25  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Timothy Hatcher.

        Instead of adding inspector methods to the inspected global objects
        use private implementation visible from inspector code only.
        https://bugs.webkit.org/show_bug.cgi?id=34089

        Test: inspector/inspected-objects-not-overriden.html

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):

1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687
2010-01-25  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: don't show headers/content tabs in scripts view.

        https://bugs.webkit.org/show_bug.cgi?id=34083

        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView):
        (WebInspector.ResourceView.prototype.set headersVisible):
        (WebInspector.ResourceView.prototype._selectContentTab):
        (WebInspector.ResourceView.prototype._innerSelectContentTab):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.show):
        (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
        (WebInspector.ResourcesPanel.prototype.showResource):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.show):
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        * inspector/front-end/inspector.css:

1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699
2010-01-25  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Reduce the size of the library when compiling for Maemo5
        https://bugs.webkit.org/show_bug.cgi?id=34050

        Exclude the Web Inspector's qrc file in the Maemo5 build, just
        like we do for the Symbian build. Saves about ~900k.

        * WebCore.pro:

1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737
2010-01-25  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] In the StyledPainter determine the style from the Render and Scrollbar theme instead of from the paint device
        https://bugs.webkit.org/show_bug.cgi?id=34054

        Getting the style from the painter's paint device is a hack that breaks when
        the paint device's style is different than the style that is used when
        calculating the metries earlier when there is no painter available.

        This change moves us closer to always using the same style.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::StylePainter::StylePainter):
        (WebCore::StylePainter::init):
        (WebCore::RenderThemeQt::paintButton):
        (WebCore::RenderThemeQt::paintTextField):
        (WebCore::RenderThemeQt::paintMenuList):
        (WebCore::RenderThemeQt::paintMenuListButton):
        (WebCore::RenderThemeQt::paintSliderTrack):
        (WebCore::RenderThemeQt::paintMediaMuteButton):
        (WebCore::RenderThemeQt::paintMediaPlayButton):
        (WebCore::RenderThemeQt::paintMediaSliderTrack):
        (WebCore::RenderThemeQt::paintMediaSliderThumb):
        * platform/qt/RenderThemeQt.h:
        * platform/qt/ScrollbarThemeQt.cpp:
        (WebCore::ScrollbarThemeQt::paint):
        (WebCore::ScrollbarThemeQt::hitTest):
        (WebCore::ScrollbarThemeQt::shouldCenterOnThumb):
        (WebCore::ScrollbarThemeQt::scrollbarThickness):
        (WebCore::ScrollbarThemeQt::thumbLength):
        (WebCore::ScrollbarThemeQt::trackPosition):
        (WebCore::ScrollbarThemeQt::trackLength):
        (WebCore::ScrollbarThemeQt::paintScrollCorner):
        (WebCore::ScrollbarThemeQt::style):
        * platform/qt/ScrollbarThemeQt.h:

1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748
2010-01-25  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] In RenderThemeQt determine the QStyle from the page client instead of the page's view
        https://bugs.webkit.org/show_bug.cgi?id=34053

        * platform/qt/QWebPageClient.h: Add function to return the style.
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::qStyle): Determine the style from the page client instead of the page's view.

1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763
2010-01-25  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Kenneth Christiansen.

        [Qt] Clean up code to determine palette from page client in RenderThemeQt
        https://bugs.webkit.org/show_bug.cgi?id=34052

        Use the RenderTheme's associated page instead of going through the
        render tree and the document.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
        (WebCore::RenderThemeQt::initializeCommonQStyleOptions):
        * platform/qt/RenderThemeQt.h:

1764 1765 1766 1767 1768 1769 1770 1771 1772
2010-01-25  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Simon Hausmann.

        [Qt] Phone backup support for QtWebkit for Symbian devices.
        https://bugs.webkit.org/show_bug.cgi?id=34077

        * WebCore.pro:

1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797
2010-01-25  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Antti Koivisto.

        Do not render the full frame when there is some elements with fixed positioning
        https://bugs.webkit.org/show_bug.cgi?id=33150

        Do not render the full frame when there is some elements with fixed positioning
        https://bugs.webkit.org/show_bug.cgi?id=33150

        * page/FrameView.cpp:
        (WebCore::FrameView::useSlowRepaints):
        (WebCore::FrameView::useSlowRepaintsIfNotOverlapped):
        (WebCore::FrameView::registerFixedPositionedObject):
        (WebCore::FrameView::unregisterFixedPositionedObject):
        (WebCore::FrameView::scrollContentsFastPath):
        * page/FrameView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollContents):
        (WebCore::ScrollView::scrollContentsFastPath):
        * platform/ScrollView.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::styleWillChange):
        (WebCore::RenderObject::destroy):

1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837
2010-01-24  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Add support for addMessage/clearMessages to SourceFrame2.

        https://bugs.webkit.org/show_bug.cgi?id=33904

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/SourceFrame2.js:
        (WebInspector.SourceFrame2):
        (WebInspector.SourceFrame2.prototype.addMessage):
        (WebInspector.SourceFrame2.prototype.clearMessages):
        (WebInspector.SourceFrame2.prototype._incrementMessageRepeatCount):
        (WebInspector.SourceFrame2.prototype._addExistingMessagesToSource):
        (WebInspector.SourceFrame2.prototype._addMessageToSource):
        (WebInspector.SourceFrame2.prototype.resize):
        * inspector/front-end/TextEditor.js:
        (WebInspector.TextEditor):
        (WebInspector.TextEditor.prototype.setDivDecoration):
        (WebInspector.TextEditor.prototype._lineHeight):
        (WebInspector.TextEditor.prototype._highlightChanged):
        (WebInspector.TextEditor.prototype.packAndRepaintAll):
        (WebInspector.TextEditor.prototype._updateSize):
        (WebInspector.TextEditor.prototype._repaintAll):
        (WebInspector.TextEditor.prototype._paint):
        (WebInspector.TextEditor.prototype._paintLinesContinuation):
        (WebInspector.TextEditor.prototype._mouseOut):
        (WebInspector.TextEditor.prototype._updateDivDecorations):
        (WebInspector.TextEditor.prototype._positionDivDecoration):
        (WebInspector.TextEditor.prototype._paintSelection):
        (WebInspector.TextEditor.prototype._replaceSelectionWith):
        * inspector/front-end/TextEditorHighlighter.js:
        (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:
        * inspector/front-end/textEditor.css: Added.

1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868
2010-01-24  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Replace split pane with tabbed pane in resource
        contents view.

        https://bugs.webkit.org/show_bug.cgi?id=32453

        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView):
        (WebInspector.ResourceView.prototype.attach):
        (WebInspector.ResourceView.prototype.show):
        (WebInspector.ResourceView.prototype._selectTab):
        (WebInspector.ResourceView.prototype._selectHeadersTab):
        (WebInspector.ResourceView.prototype._selectContentTab):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.show):
        (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
        (WebInspector.ResourcesPanel.prototype.showResource):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.show):
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings.prototype._load):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._loaded):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView):
        * inspector/front-end/inspector.css:

1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881
2010-01-24  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        Media element duration changes to zero after playing in reverse
        https://bugs.webkit.org/show_bug.cgi?id=34041

        Test: media/video-reverse-play-duration.html

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::didEnd): QTKit's ended notification fires at time zero when 
        playing in reverse, so don't reset duration in that case.

1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904
2010-01-24  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Content with heavily nested residual style is so slow, it seems like a hang
        https://bugs.webkit.org/show_bug.cgi?id=34059
        <rdar://problem/7292906>
        
        Test cast: fast/parser/residual-style-hang.html

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
        Limit the number of iterations of the main loop to 5.
        
        The reason this limit is necessary is that otherwise, N misnested open tags followed
        by N misnested close tags will cause O(N^2) of work due to cloning and attaching subtrees;
        at a fixed limit, the cost is at worst O(N).
        
        The code that was in the loop originally ran exactly once - the loop was added in
        r21472 to fix <https://bugs.webkit.org/show_bug.cgi?id=13603>. I have verified that
        with the iteration limit, the bug is still fixed, both with the original test case
        and with the layout tests tht were added.

1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926
2010-01-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        HTMLInputElement::valueAsDate setter support for type=week.
        https://bugs.webkit.org/show_bug.cgi?id=33986

        Introduce ISODateTime::setMillisecondsSinceEpochForWeek() and add
        Week type support to ISODateTime::toString().

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::valueAsDate): Avoid default:.
        (WebCore::HTMLInputElement::setValueAsDate):
          Add WEEK type handling and avoid default:.
        * html/ISODateTime.cpp:
        (WebCore::offsetTo1stWeekStart):
        (WebCore::ISODateTime::setMillisecondsSinceEpochForWeek):
        (WebCore::ISODateTime::millisecondsSinceEpoch):
        (WebCore::ISODateTime::toString):
          Add Week type support and avoid default:.
        * html/ISODateTime.h:

1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953
2010-01-24  Oliver Hunt  <oliver@apple.com>

        Reviewed by Darin Adler.

        Object Serialization assumes deserialization will always occur in the context of a webpage
        https://bugs.webkit.org/show_bug.cgi?id=34056
        rdar://7573833

        Added ClassInfo to JSDOMGlobalObject and make the window and worker class info
        inherit from it.  With this in place we're able to determine whether a given
        global object is a DOMGlobalObject, and then use that information to avoid
        attempting to deserialize types that require the presence of the DOM.

        No test as all global objects in webkit inherit from JSDOMGlobalObject.

        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::):
        * bindings/js/JSDOMGlobalObject.h:
        (WebCore::JSDOMGlobalObject::classInfo):
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::):
        * bindings/js/JSWorkerContextBase.cpp:
        (WebCore::):
        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::DeserializingTreeWalker::DeserializingTreeWalker):
        (WebCore::DeserializingTreeWalker::convertIfTerminal):

1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971
2010-01-24  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=34047
        <rdar://problem/7573699>
        Media element "endedPlayback" logic doesn't match spec

        Test: media/video-timeupdate-reverse-play.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::ended): The 'ended' attribute should only be true when playback
        rate is positive.
        (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Always schedule a 'timeupdate' event when
        the media engine signals a time discontinuity, scheduleTimeupdateEvent will only queue an event
        if one hasn't already been posted for the current movie time.
        (WebCore::HTMLMediaElement::endedPlayback): Update to match the spec logic.

1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995
2010-01-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Video that loads inside reflection doesn't get reflected
        https://bugs.webkit.org/show_bug.cgi?id=34046
        
        ensureCloneLayers() made an incorrect assumption that if a clone of the primaryLayer
        exists already, then the structural layer and content layer can just be returned.
        However, this doesn't account for the situation where a content layer may have
        been create after the clone tree was last updated.
        
        Fix by always creating the structural and clone layers on demand.

        Test: compositing/reflections/load-video-in-reflection.html

        * platform/graphics/mac/GraphicsLayerCA.h: Added utility method, findOrMakeClone().
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::findOrMakeClone): Utility that efficiently finds
        or creates a layer in a LayerMap.
        (WebCore::GraphicsLayerCA::ensureCloneLayers): Always look for or clone the
        structural and content layers, rather than relying on whether there's a primary
        layer clone already.

1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023
2010-01-23  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Implement support for FileList cloning in postMessage
        https://bugs.webkit.org/show_bug.cgi?id=34048

        Support passing FileList through postMessage APIs.  Basically
        mechanical task in line with other terminals in the object
        graph.

        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::SerializedFileList::create):
        (WebCore::SerializedFileList::length):
        (WebCore::SerializedFileList::item):
        (WebCore::SerializedFileList::SerializedFileList):
        (WebCore::SerializedScriptValueData::SerializedScriptValueData):
        (WebCore::SharedSerializedData::asFileList):
        (WebCore::SerializingTreeWalker::convertIfTerminal):
        (WebCore::DeserializingTreeWalker::convertIfTerminal):
        (WebCore::TeardownTreeWalker::convertIfTerminal):
            Rearrange these functions to not use 'default:' handling
            so that the compiler will actually tell us when we're
            not handling cases.
        * bindings/js/SerializedScriptValue.h:
        (WebCore::SerializedScriptValueData::):
        (WebCore::SerializedScriptValueData::asFileList):

2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140
2010-01-23  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Inject inspector script directly into the inspected context. All the
        communication between the script and the frontend is serialized into
        JSON strings. It allows to get rid of object quarantines in Web Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=32554

        Test: inspector/console-log-before-inspector-open.html

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::databaseForId):
        (WebCore::JSInjectedScriptHost::currentCallFrame):
        (WebCore::JSInjectedScriptHost::nodeForId):
        (WebCore::JSInjectedScriptHost::pushNodePathToFrontend):
        (WebCore::JSInjectedScriptHost::selectDatabase):
        (WebCore::JSInjectedScriptHost::selectDOMStorage):
        * bindings/js/ScriptCallStack.h:
        (WebCore::ScriptCallStack::globalState):
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::mainWorldScriptState):
        * bindings/js/ScriptController.h:
        * bindings/js/ScriptObject.h:
        (WebCore::ScriptObject::scriptState):
        * bindings/js/ScriptValue.cpp:
        * bindings/js/ScriptValue.h:
        * bindings/v8/ScriptCallStack.h:
        (WebCore::ScriptCallStack::globalState):
        * bindings/v8/ScriptObject.h:
        (WebCore::ScriptObject::scriptState):
        * bindings/v8/ScriptValue.h:
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        (WebCore::ConsoleMessage::addToConsole):
        (WebCore::ConsoleMessage::isEqual):
        * inspector/ConsoleMessage.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptHost.idl:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::setInjectedScriptSource):
        (WebCore::InspectorBackend::dispatchOnInjectedScript):
        (WebCore::InspectorBackend::releaseWrapperObjectGroup):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::clearConsoleMessages):
        (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
        (WebCore::InspectorController::windowScriptObjectAvailable):
        (WebCore::InspectorController::scriptObjectReady):
        (WebCore::InspectorController::setFrontendProxyObject):
        (WebCore::InspectorController::close):
        (WebCore::InspectorController::resetScriptObjects):
        (WebCore::InspectorController::didPause):
        (WebCore::InspectorController::injectedScriptForNodeId):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addConsoleMessage):
        (WebCore::InspectorFrontend::pausedScript):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/AuditsPanel.js:
        (WebInspector.AuditsPanel.prototype._reloadResources):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.requestClearMessages):
        (WebInspector.ConsoleView.prototype.doEvalInWindow):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):
        (WebInspector.CSSStyleDeclaration):
        (WebInspector.CSSStyleDeclaration.parseRule):
        * inspector/front-end/Database.js:
        (WebInspector.Database.prototype.executeSql):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged.InjectedScriptAccess.get addInspectedNode):
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
        (WebInspector.ElementsPanel.prototype.setDocument):
        (WebInspector.ElementsPanel.prototype.searchCanceled):
        (WebInspector.ElementsPanel.prototype.performSearch):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
        * inspector/front-end/EventListenersSidebarPane.js:
        ():
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        (injectedScriptConstructor.):
        * inspector/front-end/InjectedScriptAccess.js:
        (InjectedScriptAccess):
        (InjectedScriptAccess.getDefault):
        (get InjectedScriptAccess):
        (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName):
        (InjectedScriptAccess._installHandler):
        * inspector/front-end/MetricsSidebarPane.js:
        (WebInspector.MetricsSidebarPane):
        (WebInspector.MetricsSidebarPane.prototype.update.inlineStyleCallback):
        * inspector/front-end/ObjectPropertiesSection.js:
        * inspector/front-end/ObjectProxy.js:
        (WebInspector.ObjectProxy):
        * inspector/front-end/PropertiesSidebarPane.js:
        (WebInspector.PropertiesSidebarPane.prototype.update.callback):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
        * inspector/front-end/ScriptsPanel.js:
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype):
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSection.prototype.update):
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):
        (WebInspector.pausedScript):
        (WebInspector.addConsoleMessage):
        (WebInspector.log.logMessage):
        (WebInspector.log):

2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179
2010-01-22  Alex Milowski  <alex@milowski.com>

        Reviewed by David Hyatt.

        Added support for RenderMathMLBlock base object and isRenderMathMLBlock()
        method on RenderObject. 

        Added support for text elements and updated tag and attribute names

        Also, updated the stylesheet added files to the project

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * css/mathml.css:
        * mathml/MathMLInlineContainerElement.cpp:
        (WebCore::MathMLInlineContainerElement::createRenderer):
        * mathml/MathMLTextElement.cpp: Added.
        (WebCore::MathMLTextElement::MathMLTextElement):
        (WebCore::MathMLTextElement::create):
        (WebCore::MathMLTextElement::createRenderer):
        * mathml/MathMLTextElement.h: Added.
        * mathml/RenderMathMLBlock.cpp: Added.
        (WebCore::RenderMathMLBlock::RenderMathMLBlock):
        (WebCore::RenderMathMLBlock::styleDidChange):
        (WebCore::RenderMathMLBlock::isChildAllowed):
        (WebCore::RenderMathMLBlock::makeBlockStyle):
        (WebCore::RenderMathMLBlock::nonOperatorHeight):
        (WebCore::RenderMathMLBlock::stretchToHeight):
        * mathml/RenderMathMLBlock.h: Added.
        (WebCore::RenderMathMLBlock::isRenderMathMLBlock):
        (WebCore::RenderMathMLBlock::isRenderMathMLOperator):
        (WebCore::RenderMathMLBlock::isRenderMathMLRow):
        (WebCore::RenderMathMLBlock::isRenderMathMLMath):
        (WebCore::RenderMathMLBlock::hasBase):
        (WebCore::toRenderMathMLBlock):
        * mathml/mathattrs.in: Added.
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isRenderMathMLBlock):

2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212
2010-01-22  James Robinson  <jamesr@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Ensures that the 'selected' attribute of an <option> is correct
        https://bugs.webkit.org/show_bug.cgi?id=32641

        Adds a check in OptionElement::selected() that checks if list items need to be recalculated and does so if needed,
        so the attribute is up to date more often.  Also gets rid of most of the recalcStyle() side effects.

         Our behavior now matches Firefox 3.5 and IE8 after the </select> is parsed.

         Tests: fast/forms/HTMLOptionElement_selected2.html
                fast/forms/HTMLOptionElement_selected3.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::setOptionsChangedOnRenderer):
        (WebCore::SelectElement::setRecalcListItems):
        (WebCore::SelectElement::recalcListItems):
        (WebCore::SelectElement::restoreFormControlState):
        (WebCore::SelectElement::reset):
        (WebCore::SelectElement::typeAheadFind):
        * dom/SelectElement.h:
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::selected):
        (WebCore::HTMLOptionElement::insertedIntoTree):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::recalcStyle):
        (WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
        * html/HTMLSelectElement.h:
        * wml/WMLSelectElement.cpp:
        (WebCore::WMLSelectElement::recalcStyle):

2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223
2010-01-22  Chris Rogers  <crogers@google.com>

        Reviewed by Eric Seidel.

        Need to handle WebGLUnsignedByteArray as method argument for V8 binding
        https://bugs.webkit.org/show_bug.cgi?id=33929

        V8 code generator does not have associated tests

        * bindings/scripts/CodeGeneratorV8.pm:

2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245
2010-01-22  Elliot Glaysher  <erg@chromium.org>

        Reviewed by David Levin.

        Chromium: theme selection colors to match gtk theme
        Add functions to RenderThemeChromiumLinux to change the selection color
        according to the current GTK+ theme.

        Since the change is to the Chromium WebKit API layer, testing is done
        in Chromium's test shell (see Chromium side of this patch:
        http://codereview.chromium.org/554004)

        https://bugs.webkit.org/show_bug.cgi?id=33921

        * rendering/RenderThemeChromiumLinux.cpp:
        (WebCore::RenderThemeChromiumLinux::platformActiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumLinux::platformInactiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumLinux::platformActiveSelectionForegroundColor):
        (WebCore::RenderThemeChromiumLinux::platformInactiveSelectionForegroundColor):
        (WebCore::RenderThemeChromiumLinux::setSelectionColors):
        * rendering/RenderThemeChromiumLinux.h: Adds static members.

2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257
2010-01-22  Kevin Watters  <kevinwatters@gmail.com>

        Reviewed by Kevin Ollivier.

        [wx] Remove the Bakefile build system, which is no longer being used.
        
        https://bugs.webkit.org/show_bug.cgi?id=34022

        * WebCoreSources.bkl: Removed.
        * webcore-base.bkl: Removed.
        * webcore-wx.bkl: Removed.

2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289
2010-01-22  Peter Kasting  <pkasting@google.com>

        Reviewed by Darin Adler.

        Remove unnecessary copy of zlib.
        https://bugs.webkit.org/show_bug.cgi?id=34028

        * platform/image-decoders/zlib: Removed.
        * platform/image-decoders/zlib/adler32.c: Removed.
        * platform/image-decoders/zlib/compress.c: Removed.
        * platform/image-decoders/zlib/crc32.c: Removed.
        * platform/image-decoders/zlib/crc32.h: Removed.
        * platform/image-decoders/zlib/deflate.c: Removed.
        * platform/image-decoders/zlib/deflate.h: Removed.
        * platform/image-decoders/zlib/gzio.c: Removed.
        * platform/image-decoders/zlib/infback.c: Removed.
        * platform/image-decoders/zlib/inffast.c: Removed.
        * platform/image-decoders/zlib/inffast.h: Removed.
        * platform/image-decoders/zlib/inffixed.h: Removed.
        * platform/image-decoders/zlib/inflate.c: Removed.
        * platform/image-decoders/zlib/inflate.h: Removed.
        * platform/image-decoders/zlib/inftrees.c: Removed.
        * platform/image-decoders/zlib/inftrees.h: Removed.
        * platform/image-decoders/zlib/mozzconf.h: Removed.
        * platform/image-decoders/zlib/trees.c: Removed.
        * platform/image-decoders/zlib/trees.h: Removed.
        * platform/image-decoders/zlib/uncompr.c: Removed.
        * platform/image-decoders/zlib/zconf.h: Removed.
        * platform/image-decoders/zlib/zlib.h: Removed.
        * platform/image-decoders/zlib/zutil.c: Removed.
        * platform/image-decoders/zlib/zutil.h: Removed.

2290 2291 2292 2293 2294 2295 2296 2297 2298 2299
2010-01-22  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=34025
        Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.

        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.make:

2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327
2010-01-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Carlson.

        Race condition in video setup can force videos into software mode
        https://bugs.webkit.org/show_bug.cgi?id=34034

        We used to call setUpVideoRendering() unconditionally from
        acceleratedRenderingStateChanged(); this could happen before the movie had any
        data, and thus force the movie into software rendering mode.
        
        Fix by returning early from setUpVideoRendering() if isReadyForRendering() returns false,
        which also allows us to remove some other checks for being ready to render.
        
        Timing dependent, hard to make a test for.

        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::setContentsToMedia): Optimize to do an early return
        if passing in the same layer that is already being used.
        
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::setUpVideoRendering): Return without doing anything
        if not ready to render.
        (WebCore::MediaPlayerPrivate::updateStates): No need to call isReadyForRendering()
        any more, since setUpVideoRendering() does that.
        (WebCore::MediaPlayerPrivate::setVisible): No need to check the ready state; this
        is equivalent to the check inside of setUpVideoRendering().

2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352
2010-01-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION (r53110): Find My iPhone message dialog is offset from original position once it gets focus
        https://bugs.webkit.org/show_bug.cgi?id=33821

        Fix an issue with the geometry of fixed position, composited layers inside other
        composited layers. If we called convertToLayerCoords() on a fixed layer with an ancestor
        layer which is not the root, then we assumed that the fixed layer had a positioning root.
        However, this is not always the case, since the fixed layer may have a compositing ancestor
        which is not a fixed container.
        
        Test: compositing/geometry/fixed-in-composited.html

        * rendering/RenderLayer.cpp:
        (WebCore::isFixedPositionedContainer): Utility function to test whether a layer acts
        as a fixed position container.
        
        (WebCore::RenderLayer::convertToLayerCoords): When called on a fixed position layer
        for an ancestor layer that is not the root, compute the correct offsets by looking for
        the fixed position container, and computing offsets relative to that. If the ancestorLayer
        is the fixed position container, fall through to the existing code that is shared
        with absolutely positioned layers.

2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368
2010-01-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        webkitConvertPointFromNodeToPage doesn't take into account most recent transform style
        https://bugs.webkit.org/show_bug.cgi?id=34023

        Be sure to call updateLayoutIgnorePendingStylesheets() before doing point mapping,
        to apply any style changes since the last layout.

        Test: fast/dom/Window/webkitConvertPointUpdateLayout.html

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::webkitConvertPointFromNodeToPage): Call updateLayoutIgnorePendingStylesheets().
        (WebCore::DOMWindow::webkitConvertPointFromPageToNode): Ditto.

2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389
2010-01-22  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Roben.

        Use stale cache data when going back and forward but not using WebCore’s page cache
        https://bugs.webkit.org/show_bug.cgi?id=33993
        <rdar://problem/7383392>

        No tests since this is a performance change.

        * loader/CachePolicy.h:
        (WebCore::): Add CachePolicyAllowStale.
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::checkForReload): Never reload in the case of
        CachePolicyAllowStale.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::subresourceCachePolicy): Return CachePolicyAllowStale
        if the main resource is being loaded to allow stale data.
        (WebCore::FrameLoader::addExtraFieldsToRequest): Use ReturnCacheDataElseLoad
        on back/forward loads - needed when going back of forward to a page with frames.

2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403
2010-01-22  Kelly Norton  <knorton@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: JavaScript Error in DOMAgent.js:375 (_attributesUpdated)
        https://bugs.webkit.org/show_bug.cgi?id=33915

        Errors were caused by the fact that Element::attributes calls Element::setAttribute to
        synchronized the styleAttr. The fix is to simply check the synchronizing style attribute
        flag.

        * dom/Element.cpp:
        (WebCore::Element::setAttribute): Checked for case where styleAttr is being synchronized.

2404 2405 2406 2407 2408 2409 2410 2411 2412
2010-01-22  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        Update r53711 for GraphicsLayer method rename.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::createLayerForMovie): Rename from change setContentsToVideo.

2413 2414 2415 2416 2417 2418 2419 2420 2421
2010-01-22  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Adler.

        Add BlobConstructor to DOMWindow.
        https://bugs.webkit.org/show_bug.cgi?id=33982

        * page/DOMWindow.idl:

2422 2423 2424 2425 2426 2427 2428 2429 2430 2431
2010-01-22  Brian Weinstein  <bweinstein@apple.com>

        Rubber-stamped by Adam Roben.
        
        Commit files that were supposed to be part of r53696, but weren't
        landed.

        * English.lproj/localizedStrings.js:
        * manual-tests/debugger-caught-uncaught-exceptions.html: Added.

2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450
2010-01-22  Peter Kasting  <pkasting@google.com>

        Reviewed by David Hyatt.

        When scrolling by page, hold back 1/8th of the visible size instead of
        40 px.
        https://bugs.webkit.org/show_bug.cgi?id=32595

        * editing/EditorCommand.cpp:
        (WebCore::verticalScrollDistance):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::updateScrollbars):
        (WebCore::ScrollView::wheelEvent):
        * platform/Scrollbar.h:
        * platform/wx/ScrollViewWx.cpp:
        (WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateScrollInfoAfterLayout):

pkasting@chromium.org's avatar
pkasting@chromium.org committed
2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484
2010-01-22  Peter Kasting  <pkasting@google.com>

        Not reviewed, backout.

        Back out r52673, which caused several regressions.
        https://bugs.webkit.org/show_bug.cgi?id=32533

        * platform/PopupMenuClient.h:
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::hidePopup):
        (WebCore::PopupListBox::handleKeyEvent):
        (WebCore::PopupListBox::abandon):
        (WebCore::PopupListBox::acceptIndex):
        (WebCore::PopupListBox::selectIndex):
        (WebCore::PopupListBox::clearSelection):
        (WebCore::PopupListBox::hidePopup):
        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenu::menuUnmapped):
        * platform/mac/PopupMenuMac.mm:
        (WebCore::PopupMenu::show):
        * platform/qt/QtAbstractWebPopup.cpp:
        (WebCore::QtAbstractWebPopup::popupDidHide):
        * platform/qt/QtAbstractWebPopup.h:
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::hide):
        * platform/wx/PopupMenuWx.cpp:
        (WebCore::PopupMenu::OnMenuItemSelected):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::popupDidHide):
        * rendering/RenderMenuList.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::popupDidHide):
        * rendering/RenderTextControlSingleLine.h:

2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500
2010-01-22  Dan Bernstein  <mitz@apple.com>

        Rubber-stamped by Darin Adler.

        Revert r53693 because it broke scrolling of pages with fixed elements on
        Mac OS X.

        * page/FrameView.cpp:
        * page/FrameView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollContents):
        * platform/ScrollView.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::styleWillChange):
        (WebCore::RenderObject::destroy):

ap@apple.com's avatar
ap@apple.com committed
2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534
2010-01-22  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=34008
        Assertion failure in KURL::setProtocol when running DOM Fuzzer

        Test: fast/dom/Window/invalid-protocol.html

        * bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setProtocol): Raise an exception
        if KURL::setProtocol fails.

        * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setProtocol): Move argument
        tweaking logic into KURL. This way, the ':' trick applies to both JSLocation and
        HTMLAnchorElement, matching IE (but not Firefox). IE behavior is more permissive, and even
        more logical in my opinion.

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): Assert that setting protocol
        succeeded.