ChangeLog 855 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
2013-04-09  Jacky Jiang  <zhajiang@rim.com>

        [BlackBerry] Main page is rendered at wrong large scale after back from any zooming article at read.thestar.com
        https://bugs.webkit.org/show_bug.cgi?id=114296

        Reviewed by Rob Buis.

        PR: 308655
        We were relying on the load state Committed to reset m_userPerformedManualZoom
        and m_userPerformedManualScroll; however, the main resources of the
        articles on read.thestar.com were preloaded and the WebPage didn't get
        any load state change callbacks when going back to the main page from
        the articles. Therefore, m_userPerformedManualZoom had never been reset
        in this case and we picked up the wrong scale when restoring the main page.
        Rset m_userPerformedManualScroll and m_userPerformedManualScroll when
        we are going back or forward.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPage::goBackOrForward):

21 22 23 24 25 26 27 28 29 30 31 32
2013-04-09  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] InputHandler: fix calls to HTMLInputElement methods
        https://bugs.webkit.org/show_bug.cgi?id=114283

        Reviewed by Rob Buis.

        Fix calls with wrong names.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::convertInputType):

benjamin@webkit.org's avatar
benjamin@webkit.org committed
33 34 35 36 37 38 39 40 41
2013-04-08  Benjamin Poulain  <benjamin@webkit.org>

        Remove HTML Notification
        https://bugs.webkit.org/show_bug.cgi?id=114231

        Reviewed by Ryosuke Niwa.

        * WebCoreSupport/AboutDataEnableFeatures.in:

42 43 44 45 46 47 48 49 50 51 52 53 54
2013-04-08  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] WebPage: fix build due to type mismatches
        https://bugs.webkit.org/show_bug.cgi?id=114148

        Reviewed by Darin Adler.

        Add explicit conversions between LayoutUnit and int, and between
        LayoutRect and IntRect.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::rectForNode):

55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86
2013-04-08  Jeff Rogers  <jrogers@rim.com>

        [BlackBerry] Update BlackBerry JavaScript API
        https://bugs.webkit.org/show_bug.cgi?id=114065

        Reviewed by Rob Buis.

        Internal PR 317350
        Add new API for determining if user gesture is being processed.
        Remove obsolete files.
        Properly expose JSC global context.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
        (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
        (BlackBerry::WebKit::WebPage::globalContext):
        (BlackBerry::WebKit::WebPage::isProcessingUserGesture):
        (WebKit):
        * Api/WebPage.h:
        * Api/WebPageClient.h:
        * Api/WebPage_p.h:
        (WebPagePrivate):
        * WebCoreSupport/ChromeClientBlackBerry.cpp:
        * WebCoreSupport/ChromeClientBlackBerry.h:
        (ChromeClientBlackBerry):
        * WebCoreSupport/ClientExtension.cpp: Removed.
        * WebCoreSupport/ClientExtension.h: Removed.
        * WebCoreSupport/ExternalExtension.cpp: Removed.
        * WebCoreSupport/ExternalExtension.h: Removed.
        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):

87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109
2013-04-08  Jakob Petsovits  <jpetsovits@blackberry.com>

        [BlackBerry] More null checks for m_mainFrame
        https://bugs.webkit.org/show_bug.cgi?id=114172

        Reviewed by Rob Buis.

        After r147744, some unit tests were crashing on WebPage
        shutdown, because BackingStorePrivate::repaint() now uses
        pixelContentsRect() (accessing m_webPage->contentsRect())
        instead of BackingStoreClient::contentsRect(). In m_webPage,
        m_mainFrame had already been set to 0.

        Make us more robust against these errors by checking
        the existence of m_mainFrame more diligently.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
        (BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
        (BlackBerry::WebKit::WebPagePrivate::contentsSize):
        (BlackBerry::WebKit::WebPagePrivate::absoluteVisibleOverflowSize):
        (BlackBerry::WebKit::WebPagePrivate::setViewMode):

110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125
2013-04-08  Iris Wu  <shuwu@blackberry.com>

        [BlackBerry] Force horizontal list to be horizontal scrollable.
        https://bugs.webkit.org/show_bug.cgi?id=114173

        Reviewed by Rob Buis.

        Force content to be horizontal/vertical overscrollable if it
        scrolls in horizontal/vertical way.

        PR 237440
        Internally Reviewed by Arvid Nilsson.

        * WebKitSupport/InRegionScrollableArea.cpp:
        (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151
2013-04-08  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] WebPage: misc build fixes
        https://bugs.webkit.org/show_bug.cgi?id=114152

        Reviewed by Carlos Garcia Campos.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::shouldPluginEnterFullScreen):
        (BlackBerry::WebKit::WebPagePrivate::didPluginExitFullScreen):
        (BlackBerry::WebKit::WebPagePrivate::onPluginStartBackgroundPlay):
        (BlackBerry::WebKit::WebPagePrivate::onPluginStopBackgroundPlay):
        Remove unused parameters.

        (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
        (BlackBerry::WebKit::WebPage::blockZoom):
        Replace TAAUTO with TASTART (this changed in r120495).

        (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
        Rename m_fullscreenVideoNode to m_fullscreenNode (this changed in
        r142220).

        (BlackBerry::WebKit::WebPagePrivate::compositorDrawsRootLayer):
        Rename paintingGoesToWindow() to paintsIntoWindow() (this changed in
        r113514).

152 153 154 155 156 157 158 159 160 161
2013-04-07  David Kilzer  <ddkilzer@apple.com>

        Remove the rest of SVG_DOM_OBJC_BINDINGS
        <http://webkit.org/b/114112>

        Reviewed by Geoffrey Garen.

        * WebCoreSupport/AboutDataEnableFeatures.in:
        - Remove reference to SVG_DOM_OBJC_BINDINGS.

162 163 164 165 166 167 168 169 170
2013-04-06  Zan Dobersek  <zdobersek@igalia.com>

        Remove the USE(SKIA_ON_MAC_CHROMIUM) guards
        https://bugs.webkit.org/show_bug.cgi?id=114084

        Reviewed by Ryosuke Niwa.

        * WebCoreSupport/AboutDataUseFeatures.in: Remove the SKIA_ON_MAC_(CHROME|CHROMIUM) reference.

171 172 173 174 175 176 177 178 179 180 181 182 183 184 185
2013-04-05  Tiancheng Jiang  <tijiang@rim.com>

        [BlackBerry] FatFingers Don't check the shadow tree for all elements.
        https://bugs.webkit.org/show_bug.cgi?id=114066

        Reviewed by Rob Buis.

        BlackBerry PR 263078
        Internally reviewed by Genevieve Mak.

        No need to check shadow tree since sliders use touch events.

        * WebKitSupport/FatFingers.cpp:
        (BlackBerry::WebKit::FatFingers::isElementClickable):

186 187 188 189 190 191 192 193 194
2013-04-05  Zan Dobersek  <zdobersek@igalia.com>

        Remove WTF_USE_GOOGLEURL-guarded code
        https://bugs.webkit.org/show_bug.cgi?id=114028

        Reviewed by Ryosuke Niwa.

        * WebCoreSupport/AboutDataUseFeatures.in: Remove GOOGLEURL from the list.

195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211
2013-04-04  Jacky Jiang  <zhajiang@rim.com>

        [BlackBerry] Blitting wrong rect during history navigations
        https://bugs.webkit.org/show_bug.cgi?id=113963

        Reviewed by Rob Buis.
        Internally reviewed by Jakob Petsovits.

        On www.bbc.com/news, we blit wrong rect during the second restoration
        of the view states when we navigate back from stories to the main page.
        Update the contents size and scroll position before we render and blit
        if we failed to zoomAboutPoint so that UI thread can still get the
        correct rect during blit.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):

212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280
2013-04-05  Jakob Petsovits  <jpetsovits@blackberry.com>

        [BlackBerry] Replace map{From,To}Transformed() with ViewportAccessor
        https://bugs.webkit.org/show_bug.cgi?id=113449

        Reviewed by Rob Buis.

        This removes the WebPage/BackingStoreClient family of coordinate
        transformation functions, which were widely disliked for their
        naming, with ViewportAccessor API that had previously been
        introduced for limited use cases. This commit takes care of the
        remaining call sites and leaves us with a single API to use.

        No new tests, only a clean-up/refactor of existing code & functionality.

        * Api/BackingStore.cpp:
        (BlackBerry::WebKit::BackingStorePrivate::repaint):
        (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
        (BlackBerry::WebKit::BackingStorePrivate::visibleContentsRect):
        (BlackBerry::WebKit::BackingStorePrivate::unclippedVisibleContentsRect):
        (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
        (BlackBerry::WebKit::BackingStorePrivate::expandedContentsSize):
        * Api/InRegionScroller.cpp:
        (BlackBerry::WebKit::InRegionScrollerPrivate::clipToRect):
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::init):
        (BlackBerry::WebKit::WebPagePrivate::scrollPosition):
        (BlackBerry::WebKit::WebPagePrivate::maximumScrollPosition):
        (BlackBerry::WebKit::WebPagePrivate::setScrollPosition):
        (BlackBerry::WebKit::WebPagePrivate::viewportSize):
        (BlackBerry::WebKit::WebPagePrivate::actualVisibleSize):
        (BlackBerry::WebKit::WebPagePrivate::layoutFinished):
        (BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
        (BlackBerry::WebKit::WebPagePrivate::updateCursor):
        (BlackBerry::WebKit::WebPagePrivate::focusNodeRect):
        (BlackBerry::WebKit::WebPagePrivate::contextNode):
        (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
        (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
        (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
        (BlackBerry::WebKit::WebPage::blockZoom):
        * Api/WebPage_p.h:
        (WebPagePrivate):
        * WebKitSupport/BackingStoreClient.cpp:
        (BlackBerry::WebKit::BackingStoreClient::transformedScrollPosition):
        (BlackBerry::WebKit::BackingStoreClient::transformedMaximumScrollPosition):
        (BlackBerry::WebKit::BackingStoreClient::actualVisibleSize):
        (BlackBerry::WebKit::BackingStoreClient::transformedActualVisibleSize):
        * WebKitSupport/BackingStoreClient.h:
        (BackingStoreClient):
        * WebKitSupport/FatFingers.cpp:
        (BlackBerry::WebKit::FatFingers::fingerRectForPoint):
        (BlackBerry::WebKit::FatFingers::FatFingers):
        (BlackBerry::WebKit::FatFingers::findBestPoint):
        (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
        (BlackBerry::WebKit::FatFingers::getNodesFromRect):
        * WebKitSupport/InRegionScrollableArea.cpp:
        (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
        * WebKitSupport/TouchEventHandler.cpp:
        (BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint):
        (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
        (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
        * WebKitSupport/WebKitThreadViewportAccessor.cpp:
        (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelContentsSize):
        (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelScrollPosition):
        (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentViewportSize):

281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306
2013-04-05  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] Remove unused parameters from notifyAnimationStarted() and paintContents()
        https://bugs.webkit.org/show_bug.cgi?id=114022

        Reviewed by Carlos Garcia Campos.

        Naming the 'time' and 'inClip' unused parameters only produces
        compiler warnings.

        * Api/WebOverlay_p.h:
        (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
        (WebOverlayPrivateWebKitThread):
        * Api/WebPage_p.h:
        (BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted):
        (BlackBerry::WebKit::WebPagePrivate::paintContents):
        * WebKitSupport/DefaultTapHighlight.h:
        (BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):
        * WebKitSupport/InspectorOverlayBlackBerry.cpp:
        (BlackBerry::WebKit::InspectorOverlay::paintContents):
        * WebKitSupport/InspectorOverlayBlackBerry.h:
        (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
        (InspectorOverlay):
        * WebKitSupport/SelectionOverlay.h:
        (BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):

307 308 309 310 311 312 313 314 315 316 317 318
2013-04-05  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] WebOverlay: fix access to m_client
        https://bugs.webkit.org/show_bug.cgi?id=114003

        Reviewed by Rob Buis.

        m_client was replace by m_overlay in r146058.

        * Api/WebOverlay.cpp:
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):

319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339
2013-04-05  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] WebOverlayPrivate: remove showDebugBorders() and showRepaintCounter()
        https://bugs.webkit.org/show_bug.cgi?id=114009

        Reviewed by Carlos Garcia Campos.

        These methods were removed in r133517 but were accidentally
        introduced again in r145968.
        The previous patch didn't remove them all.

        * WebKitSupport/DefaultTapHighlight.cpp:
        * WebKitSupport/DefaultTapHighlight.h:
        (DefaultTapHighlight):
        * WebKitSupport/InspectorOverlayBlackBerry.cpp:
        * WebKitSupport/InspectorOverlayBlackBerry.h:
        (InspectorOverlay):
        * WebKitSupport/SelectionOverlay.cpp:
        * WebKitSupport/SelectionOverlay.h:
        (SelectionOverlay):

340 341 342 343 344 345 346 347 348 349 350 351 352
2013-04-05  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] WebOverlayPrivate: remove showDebugBorders() and showRepaintCounter()
        https://bugs.webkit.org/show_bug.cgi?id=114009

        Reviewed by Carlos Garcia Campos.

        These methods were removed in r133517 but were accidentally
        introduced again in r145968.

        * Api/WebOverlay_p.h:
        (WebOverlayPrivateWebKitThread):

353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368
2013-04-05  Anthony Scian  <ascian@blackberry.com>

        [BlackBerry] WebOverlay: check if platformContext is null
        https://bugs.webkit.org/show_bug.cgi?id=114005

        Reviewed by Carlos Garcia Campos.

        RIM PR 256522
        Internally reviewed by Mike Lattanzio.

        The pointer returned by lockBufferDrawable can be null, so it
        needs to be checked first before being used.

        * Api/WebOverlay.cpp:
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):

369 370 371 372 373 374 375 376 377
2013-04-05  Benjamin Poulain  <bpoulain@apple.com>

        Remove WTFURL from WebKit
        https://bugs.webkit.org/show_bug.cgi?id=113994

        Reviewed by Ryosuke Niwa.

        * WebCoreSupport/AboutDataUseFeatures.in:

378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397
2013-04-04  Andrew Lo  <anlo@rim.com>

        [BlackBerry] DOMSupport::isFixedPositionOrHasFixedPositionAncestor stops traversing render tree when it hits an iframe element
        https://bugs.webkit.org/show_bug.cgi?id=113944

        Reviewed by Rob Buis.
        Internally reviewed by Mike Fenton.

        Internal PR 320732.
        When checking whether a RenderObject is fixed position or has a fixed position
        ancestor, we traverse the render tree upwards.

        When we reach the root of the tree, check whether the root is an
        iframe and has an element owner. If so, we also need to continue iterating
        up the tree from the owner to see if the iframe is a descendant of a fixed
        position element.

        * WebKitSupport/DOMSupport.cpp:
        (BlackBerry::WebKit::DOMSupport::isFixedPositionOrHasFixedPositionAncestor):

398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419
2013-04-04  Tiancheng Jiang  <tijiang@rim.com>

        [BlackBerry] Adjust fatfinger result priority
        https://bugs.webkit.org/show_bug.cgi?id=113957

        Reviewed by Rob Buis.

        RIM PR 224781
        Internally Reviewed by Genevieve Mak.

        Change fatfigner algorithm, return the clickable element rather than
        its parent anchor. Modify taphighlight and context menu node selection
        accordingly.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::webContext):
        * WebKitSupport/FatFingers.cpp:
        (BlackBerry::WebKit::FatFingers::findBestPoint):
        * WebKitSupport/FatFingers.h:
        * WebKitSupport/TouchEventHandler.cpp:
        (BlackBerry::WebKit::elementForTapHighlight):

420 421 422 423 424 425 426 427 428 429 430 431 432 433
2013-04-03  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] Remove defaultViewportArguments check from call site of recomputeVirtualViewportFromViewportArguments
        https://bugs.webkit.org/show_bug.cgi?id=113872

        Reviewed by Carlos Garcia Campos.

        Carlos pointed out that recomputeVirtualViewportFromViewportArguments
        already contains the check, and returns an empty IntSize if it fails.
        So pick up on that to make the code a bit more DRY.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::setViewportSize):

434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461
2013-04-03  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] Decouple layout viewport from visual viewport
        https://bugs.webkit.org/show_bug.cgi?id=113829

        Reviewed by Carlos Garcia Campos.

        Setting the visual viewport would force the layout viewport equal to
        the visual viewport. Decouple the viewports by allowing the user to
        specify a layout viewport when setting the viewport(s). The layout
        viewport could be the exact same value passed for visual viewport, if
        the old behavior is desired.

        Also reevaluate any viewport arguments when (only) the layout viewport
        changes in WebPage::setDefaultLayoutSize() since the layout viewport is
        used as input to the calculation.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::setScreenOrientation):
        (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
        (BlackBerry::WebKit::WebPage::setViewportSize):
        (WebKit):
        (BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
        (BlackBerry::WebKit::WebPage::defaultLayoutSize):
        * Api/WebPage.h:
        * Api/WebPage_p.h:
        (WebPagePrivate):

462 463 464 465 466 467 468 469 470 471 472 473
2013-04-02  Maxim Mogilnitsky  <mmogilnitsky@rim.com>

        [BlackBerry] API update for IntRect
        https://bugs.webkit.org/show_bug.cgi?id=113824

        Reviewed by Rob Buis.

        Modifing IntRect and FloatRect API.

        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::regionForTextQuads):

474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491
2013-04-02  Nima Ghanavatian  <nghanavatian@blackberry.com>

        [BlackBerry] Create a selection from two points irregardless of the caret position.
        https://bugs.webkit.org/show_bug.cgi?id=113795

        Reviewed by Rob Buis.

        Internally reviewed by Mike Fenton.

        PR276577
        If we are to set both the base and extent of a selection, we should maintain the base upon setting the extent.
        This prevents us from overwriting the previous calculation when setting extent.
        Further, instead of setting and manipulating the selection, simply set up start and end VisiblePositions and
        create a new directional selection so as to set the base and extent simultaneously.

        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::setSelection):

492 493 494 495 496 497 498 499 500
2013-04-01  Konrad Piascik  <kpiascik@blackberry.com>

        [BlackBerry] Move Path into it's own header
        https://bugs.webkit.org/show_bug.cgi?id=113724

        Reviewed by Rob Buis.

        * WebKitSupport/DefaultTapHighlight.cpp:

501 502 503 504 505 506 507 508 509 510 511 512 513
2013-03-29  Charles Wei  <charles.wei@torchmobile.com.cn>

        [BlackBerry] Cleanup the CONTEXT_MENUS in BlackBerry porting
        https://bugs.webkit.org/show_bug.cgi?id=113562

        Reviewed by George Staikos.
        Internally reviewed by Mike Fenton and Gen Mak.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::init):
        * WebCoreSupport/ContextMenuClientBlackBerry.cpp:
        * WebCoreSupport/ContextMenuClientBlackBerry.h:

514 515 516 517 518 519 520 521 522 523 524 525 526 527 528
2013-03-29  Charles Wei  <charles.wei@torchmobile.com.cn>

        [BlackBerry] Context menu doesn't showup anymore after rebase.
        https://bugs.webkit.org/show_bug.cgi?id=113570

        Reviewed by George Staikos.

        The upstreaming patch for bug: 103058, reverses the return value of 
        Node::dispatchMouseEvent() to be consistent with Node::dispatchEvent(),
        so we should reverse our logic in webkit part that calls it also.

        This only applys to master_41 which is a new rebase, don't apply it to master_40.
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::webContext):

529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544
2013-03-28  Iris Wu  <shuwu@blackberry.com>

        [BlackBerry] Don't cross editing boundary when touch hold selection expands
        https://bugs.webkit.org/show_bug.cgi?id=113537

        Reviewed by Rob Buis.

        Set editing boundary crossing rule to make sure it won't cross
        editing boundary when selection expands.

        Reviewed Internally By Genevieve Mak and Mike Fenton.

        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
        (BlackBerry::WebKit::SelectionHandler::findNextAnimationOverlayRegion):

545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569
2013-03-28  Jakob Petsovits  <jpetsovits@blackberry.com>

        [BlackBerry] Don't use WebKit thread scale information in WebPageCompositor.
        https://bugs.webkit.org/show_bug.cgi?id=113447
        Internal PR 313452

        Reviewed by Rob Buis.

        Potential threading problems are avoided by moving from
        WebPage members and mapToTransformed() to the web page
        client's userInterfaceViewportAccessor().

        As part of this cleaning effort, the WebPageCompositor's
        render() method is changed to now take document instead of
        pixel coordinates.

        * Api/BackingStore.cpp:
        (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
        * Api/WebPageCompositor.cpp:
        (BlackBerry::WebKit::WebPageCompositorPrivate::render):
        (BlackBerry::WebKit::WebPageCompositor::render):
        * Api/WebPageCompositor.h:
        * Api/WebPageCompositor_p.h:
        (WebPageCompositorPrivate):

570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587
2013-03-28  Matt Falkenhagen  <falken@chromium.org>

        Refactoring: Replace Element::disabled and isEnabledFormControl with isDisabledFormControl
        https://bugs.webkit.org/show_bug.cgi?id=113273

        Reviewed by Kent Tamura.

        Element::disabled is about form controls and Element::isEnabledFormControl
        is redundant with it, so replace them with a single function
        Element::isDisabledFormControl.

        * WebCoreSupport/CredentialTransformData.cpp:
        (WebCore::CredentialTransformData::findPasswordFormFields):
        * WebKitSupport/DOMSupport.cpp:
        (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::openSelectPopup):

588 589 590 591 592 593 594 595 596 597 598 599 600
2013-03-27  Eli Fidler <efidler@blackberry.com>

        [BlackBerry] Show compositing on the Inspector timeline properly
        https://bugs.webkit.org/show_bug.cgi?id=113416

        Reviewed by Rob Buis.

        The call to willComposite was too early and encompased the paint calls
        as well.  Moving it lower will no longer encompass the paints.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):

601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616
2013-03-27  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] Populate the mime type of the WebContext for images
        https://bugs.webkit.org/show_bug.cgi?id=113272

        Reviewed by George Staikos.

        PR 278967

        Populate the mime type using the file extension reported by the image
        decoder. This way we benefit from file type sniffing, instead of
        relying on the mime type reported by the resource response.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::webContext):

617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632
2013-03-26  Hayato Ito  <hayato@chromium.org>

        Allow ShadowContents in HitTests by default.
        https://bugs.webkit.org/show_bug.cgi?id=113171

        Reviewed by Dimitri Glazkov.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
        * WebKitSupport/FatFingers.cpp:
        (BlackBerry::WebKit::FatFingers::getNodesFromRect):
        * WebKitSupport/ProximityDetector.cpp:
        (BlackBerry::WebKit::ProximityDetector::findBestPoint):
        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652
2013-03-26  Xiaobo Wang  <xbwang@torchmobile.com.cn>

        [BlackBerry] Memory leak in WebPagePrivate.cpp - NavigatorContentUtilsClientBlackBerry
        https://bugs.webkit.org/show_bug.cgi?id=112996

        Reviewed by Rob Buis.

        PR 312552
        Internally Reviewed by Anthony Scian.

        NavigatorContentUtilsClientBlackBerry is new'ed in WebPagePrivate::init(),
        but not deleted anywhere. Fixed by creating an OwnPtr for it.
        Also fixed some webkit-style errors.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::init):
        * Api/WebPage_p.h:
        (WebCore):
        (WebPagePrivate):

653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669
2013-03-26  Mike Lattanzio  <mlattanzio@blackberry.com>

        [BlackBerry] Include accelerated compositing layers in screen captures.
        https://bugs.webkit.org/show_bug.cgi?id=113335

        Reviewed by Rob Buis.

        PR# 280374
        Include accelerated compositing layers in screen captures.
        Reviewed Internally By: Jakob Petsovits

        * Api/BackingStore.cpp:
        (BlackBerry::WebKit::BackingStorePrivate::render):
        (BlackBerry::WebKit::BackingStorePrivate::renderContents):
        (BlackBerry::WebKit::BackingStore::drawContents):
        * Api/BackingStore_p.h:

670 671 672 673 674 675 676 677 678 679 680 681 682 683
2013-03-26  Tiancheng Jiang  <tijiang@rim.com>

        [BlackBerry] Set mouse document position for mouse event in updateCursor
        https://bugs.webkit.org/show_bug.cgi?id=109094

        Reviewed by Rob Buis.

        Internally Reviewed by Jakob Petsovits.

        Mouse content position should be in document coordinate.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::updateCursor):

684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724
2013-03-26  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] Scrolling up and down can cause the screen to flash black
        https://bugs.webkit.org/show_bug.cgi?id=113269

        Reviewed by Rob Buis.

        PR 296106

        Various flaws in the code could conspire to make the screen cleared to
        black before rendering the web page. This only happened when the
        BackingStore was inactive, and the LayerTiler takes on the job of
        drawing the root layer. When tiles are missing, this made the
        "checkerboard" effect especially noticeable since black color was seen
        where the tile should have been. It would be better to clear to the web
        page background color.

        This was actually the intent of the code, but when the document
        background color was invalid, we would still use it instead of the
        background color from settings. Also, the LayerRenderer would clear to
        black when WebPageCompositorPrivate::drawsRootLayer() was true.

        Fixed by falling back to the settings background color when the
        document background color is invalid, and removing the clearing code
        from the LayerRenderer entirely. The appropriate clear already happens
        near the beginning of BackingStorePrivate::blitVisibleContents().

        Also slightly cleaned up the code for managing the background color.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::setLoadState):
        (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
        (BlackBerry::WebKit::WebPagePrivate::updateBackgroundColor):
        (WebKit):
        (BlackBerry::WebKit::WebPagePrivate::documentBackgroundColor):
        * Api/WebPageCompositor.cpp:
        * Api/WebPageCompositor_p.h:
        (WebPageCompositorPrivate):
        * Api/WebPage_p.h:
        (WebPagePrivate):

725 726 727 728 729 730 731 732 733 734 735 736 737 738 739
2013-03-26  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] WebOverlay::pixelViewportRect() should return pixel viewport coordinates
        https://bugs.webkit.org/show_bug.cgi?id=113263

        Reviewed by Rob Buis.

        PR 312404

        Fixed by returning pixel viewport coordinates instead of window
        coordinates.

        * Api/WebOverlay.cpp:
        (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):

740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755
2013-03-26  Xiaobo Wang  <xbwang@torchmobile.com.cn>

        [BlackBerry] Memory leak in UserMediaClientImpl
        https://bugs.webkit.org/show_bug.cgi?id=112998

        Reviewed by Rob Buis.

        PR 312559
        Internally Reviewed by Anthony Scian.

        Should destroy itself in UserMediaClientImpl::pageDestroyed(), as other
        XXClientBlackBerry did, like GeolocationClientBlackBerry::geolocationDestroyed().

        * WebCoreSupport/UserMediaClientImpl.cpp:
        (WebCore::UserMediaClientImpl::pageDestroyed):

756 757 758 759 760 761 762 763 764 765 766 767 768
2013-03-25  Kent Tamura  <tkent@chromium.org>

        Rename ENABLE_INPUT_TYPE_DATETIME
        https://bugs.webkit.org/show_bug.cgi?id=113254

        Reviewed by Kentaro Hara.

        Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
        Actually I'd like to remove the code, but we shouldn't remove it yet
        because we shipped products with it on some platforms.

        * WebCoreSupport/AboutDataEnableFeatures.in:

769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789
2013-03-25  Mary Wu  <mary.wu@torchmobile.com.cn>

        [BlackBerry] add needReferer in WebPage load() api
        https://bugs.webkit.org/show_bug.cgi?id=113167

        Reviewed by Rob Buis.

        PR310175, internally reviewed by Joe Mason.
        Sometimes when client load request, it need to add referer with current frame like
        save link/image in option menu, so we add needRef in load() interface in webpage.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::load):
        (BlackBerry::WebKit::WebPage::load):
        (BlackBerry::WebKit::WebPage::loadExtended):
        (BlackBerry::WebKit::WebPage::loadFile):
        (BlackBerry::WebKit::WebPage::download):
        * Api/WebPage.h:
        * Api/WebPage_p.h:
        (WebPagePrivate):

790 791 792 793 794 795 796 797 798 799
2013-03-22  Nima Ghanavatian  <nghanavatian@blackberry.com>

        [BlackBerry] Build fix in InputHandler
        https://bugs.webkit.org/show_bug.cgi?id=113092

        Reviewed by Rob Buis.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::setElementUnfocused):

800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818
2013-03-22  Nima Ghanavatian  <nghanavatian@blackberry.com>

        Check focused node reference when traversing through history
        https://bugs.webkit.org/show_bug.cgi?id=113082

        Reviewed by Rob Buis.

        PR312101
        Check if we have a valid node and document before attempting to access its frame and
        frame selection. This is causing issues when going back to a page after a redirect
        where a stale pointer is used.
        Further, the focused node should be changed after the frame is fully loaded.

        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::setElementUnfocused):
        (BlackBerry::WebKit::InputHandler::restoreViewState):

819 820 821 822 823 824 825 826 827 828 829 830 831
2013-03-22  Genevieve Mak  <gmak@rim.com>

        [BlackBerry] Hit Test doesn't need to be active
        https://bugs.webkit.org/show_bug.cgi?id=113072

        Reviewed by Rob Buis.

        Reviewed Internally By Mike Lattanzio.
        PR #306074

        * WebKitSupport/ProximityDetector.cpp:
        (BlackBerry::WebKit::ProximityDetector::findBestPoint):

832 833 834 835 836 837 838 839 840 841 842 843 844 845 846
2013-03-22  Andrew Lo  <anlo@rim.com>

        [BlackBerry] Selection overlay clipped incorrectly
        https://bugs.webkit.org/show_bug.cgi?id=113069

        Reviewed by George Staikos.
        Internally reviewed by Arvid Nilsson.

        As a follow-up to r146278, the clip rect also needs to be
        adjusted by the parent's offset when drawing the
        selection overlay.

        * WebKitSupport/SelectionOverlay.cpp:
        (BlackBerry::WebKit::SelectionOverlay::paintContents):

847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892
2013-03-22  Carlos Garcia Campos  <cgarcia@igalia.com>

        [BlackBerry] Add custom BackForwardList client implementation
        https://bugs.webkit.org/show_bug.cgi?id=113024

        Reviewed by Rob Buis.

        PR 310030
        Internally reviewed by Joe Mason.

        Adds a new class BackForwardListBlackBerry that implements
        BackForwardList client and wraps the BackForwardListImpl including
        the BlackBerry specific changes to notify the API layer when the
        BackForwardList changes.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::init): Create a
        BackForwardListBlackBerry.
        (BlackBerry::WebKit::WebPage::getBackForwardList): Use
        BackForwardListBlackBerry instead of BackForwardListImpl.
        (BlackBerry::WebKit::WebPage::clearBackForwardList): Ditto.
        * WebCoreSupport/BackForwardListBlackBerry.cpp: Added.
        (WebCore):
        (WebCore::BackForwardListBlackBerry::BackForwardListBlackBerry):
        (WebCore::BackForwardListBlackBerry::~BackForwardListBlackBerry):
        (WebCore::BackForwardListBlackBerry::current):
        (WebCore::BackForwardListBlackBerry::notifyBackForwardListChanged):
        (WebCore::BackForwardListBlackBerry::addItem):
        (WebCore::BackForwardListBlackBerry::goToItem):
        (WebCore::BackForwardListBlackBerry::itemAtIndex):
        (WebCore::BackForwardListBlackBerry::backListCount):
        (WebCore::BackForwardListBlackBerry::forwardListCount):
        (WebCore::BackForwardListBlackBerry::isActive):
        (WebCore::BackForwardListBlackBerry::close):
        (WebCore::BackForwardListBlackBerry::clear):
        (WebCore::BackForwardListBlackBerry::entries):
        (WebCore::BackForwardListBlackBerry::currentItem):
        * WebCoreSupport/BackForwardListBlackBerry.h: Added.
        (WebKit):
        (WebCore):
        (BackForwardListBlackBerry):
        (WebCore::BackForwardListBlackBerry::create):
        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        * WebCoreSupport/FrameLoaderClientBlackBerry.h:
        (FrameLoaderClientBlackBerry):

893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911
2013-03-21  Iris Wu  <shuwu@blackberry.com>

        [BlackBerry] Last paragraph can't be selected by touch hold selection if there is no new line after it in subframe.
        https://bugs.webkit.org/show_bug.cgi?id=112966

        Reviewed by Rob Buis.

        PR 312044
        Reviewed Internally By Genevieve Mak.

        If selection reaches the bottom of content, ignore scroll margin
        so the text on the bottom can be selected.
        Stop expanding selection only if the end of document is selected
        or touch is released.

        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::expandSelection):
        (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):

912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931
2013-03-21  Otto Derek Cheung  <otcheung@rim.com>

        [BlackBerry] addSearchProvider shouldn't match the full host, only the server
        https://bugs.webkit.org/show_bug.cgi?id=112960

        Reviewed by Rob Buis.
        Internally Reviewed by Jeff Rogers.

        Remove full host matching. only check if domains are from the same server.

        Also, check user gesture before dispatching the addSearchProvider event to the browser.

        * WebCoreSupport/ChromeClientBlackBerry.cpp:
        (WebCore::ChromeClientBlackBerry::addSearchProvider):
        (WebCore::ChromeClientBlackBerry::isSearchProviderInstalled):
        * WebCoreSupport/ChromeClientBlackBerry.h:
        (ChromeClientBlackBerry):
        * WebCoreSupport/ExternalExtension.cpp:
        (IsSearchProviderInstalledMethod):

932 933 934 935 936 937 938 939 940 941 942 943 944 945
2013-03-19  Andrew Lo  <anlo@rim.com>

        [BlackBerry] Selection overlay is sometimes in wrong position.
        https://bugs.webkit.org/show_bug.cgi?id=112748

        Reviewed by Rob Buis.
        Internally reviewed by Arvid Nilsson.

        Internal PR 305384.
        Translate by parent's offset when drawing selection overlay.

        * WebKitSupport/SelectionOverlay.cpp:
        (BlackBerry::WebKit::SelectionOverlay::paintContents):

946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964
2013-03-19  Iris Wu  <shuwu@blackberry.com>

        [BlackBerry] Hook up scroll position to proximity detector
        https://bugs.webkit.org/show_bug.cgi?id=112743

        Reviewed by Rob Buis.

        PR 243385
        Reviewed Internally By Genevieve Mak.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
        (BlackBerry::WebKit::WebPage::adjustDocumentScrollPosition):
        (WebKit):
        * Api/WebPage.h:
        * Api/WebPage_p.h:
        (WebPagePrivate):

965 966 967 968 969 970 971 972 973 974 975 976 977 978
2013-03-19  Chris Hutten-Czapski  <chutten@blackberry.com>

        [BlackBerry] Don't handle keyboard scrolling shortcuts in webkit
        https://bugs.webkit.org/show_bug.cgi?id=112716

        Informally Reviewed by Mike Fenton (mifenton@rim.com)
        Reviewed by Rob Buis.

        The comment is right, this isn't the correct place to handle keyboard
        scrolling shortcuts. That's what we have clients for.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPage::keyEvent):

979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998
2013-03-19  Andy Chen  <andchen@blackberry.com>

        [BlackBerry] When selecting an object, assign focus to new node instead of clearing previous focused node
        https://bugs.webkit.org/show_bug.cgi?id=112707

        Reviewed by Rob Buis.

        In SelectionHandler, when selecting a new object, we should set focus
        to the anchor node of selection instead of removing it from the old input.
        In InputHandler, when focusedNodeChanged is called, if the new node is
        not an Element node, we need to set focus to its Element parent node,
        instead of removing focus from the old node.
        PR 304631
        Internally reviewed by Mike Fenton.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::selectObject):

999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010
2013-03-18  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] Prevent text selection inside Colour and Date/Time input fields
        https://bugs.webkit.org/show_bug.cgi?id=111733

        Reviewed by Rob Buis.

        Fix missing brace.

        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026
2013-03-18  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] Add Proximity Detector.
        https://bugs.webkit.org/show_bug.cgi?id=112278

        Reviewed by Rob Buis.

        Fix variable names so they actually match the function
        declarations.

        Fix call to rectForPoint(), which was moved from HitTestResult to
        HitTestLocation in r117091 and r126859.

        * WebKitSupport/ProximityDetector.cpp:
        (BlackBerry::WebKit::ProximityDetector::findBestPoint):

1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039
2013-03-18  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] EditorClientBlackBerry: fix access to WebPage attribute
        https://bugs.webkit.org/show_bug.cgi?id=112556

        Reviewed by Rob Buis.

        This changed in r145849 and broke the BlackBerry build.

        * WebCoreSupport/EditorClientBlackBerry.cpp:
        (WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
        (WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):

1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072
2013-03-18  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] Detach overlays from page when compositor is detached
        https://bugs.webkit.org/show_bug.cgi?id=112424

        Reviewed by Rob Buis.

        PR 309160

        If not detached properly, the overlays would have a dangling pointer to
        the page.

        * Api/WebOverlay.cpp:
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
        (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
        (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
        * Api/WebOverlay_p.h:
        (BlackBerry::WebKit::WebOverlayPrivate::setClient):
        (WebOverlayLayerCompositingThreadClient):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlay):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlayDestroyed):
        (WebOverlayPrivateCompositingThread):
        * Api/WebPageCompositor.cpp:
        (BlackBerry::WebKit::WebPageCompositorPrivate::detach):
        (BlackBerry::WebKit::WebPageCompositorPrivate::setPage):
        (WebKit):
        (BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
        * Api/WebPageCompositor_p.h:
        (BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
        (BlackBerry::WebKit::WebPageCompositorPrivate::detachOverlays):
        (WebPageCompositorPrivate):

1073 1074 1075 1076 1077 1078 1079 1080 1081 1082
2013-03-18  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] BackingStoreClient: remove unnecessary call to toElement()
        https://bugs.webkit.org/show_bug.cgi?id=112547

        Reviewed by Carlos Garcia Campos.

        * WebKitSupport/BackingStoreClient.cpp:
        (BlackBerry::WebKit::BackingStoreClient::absoluteRect):

1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163
2013-03-15  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] BlackBerry::Platform::Graphics::GraphicsContext integration related changes in Source/WebKit/blackberry
        https://bugs.webkit.org/show_bug.cgi?id=112467

        Reviewed by Rob Buis.

        PR 293208

        This patch contains contributions from many members of the BlackBerry
        WebKit team:

        Mike Lattanzio
        Arvid Nilsson
        Jakob Petsovits
        Konrad Piascik
        Jeff Rogers
        Filip Spacek

        * Api/BackingStore.cpp:
        (BlackBerry::WebKit::BackingStorePrivate::render):
        (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
        (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
        (BlackBerry::WebKit::BackingStorePrivate::tileSize):
        * Api/WebOverlay.cpp:
        (BlackBerry::WebKit::WebOverlayPrivate::drawContents):
        (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::paintContents):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToImage):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::clearUploadedContents):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
        (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
        (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeFromParent):
        (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
        * Api/WebOverlay.h:
        * Api/WebOverlayClient.h:
        * Api/WebOverlay_p.h:
        (WebOverlayPrivate):
        (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showDebugBorders):
        (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showRepaintCounter):
        (WebOverlayLayerCompositingThreadClient):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::image):
        (WebOverlayPrivateCompositingThread):
        * Api/WebPageCompositor.cpp:
        (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
        * WebKitSupport/BackingStoreTile.cpp:
        (BlackBerry::WebKit::TileBuffer::~TileBuffer):
        (BlackBerry::WebKit::TileBuffer::nativeBuffer):
        (BlackBerry::WebKit::TileBuffer::paintBackground):
        * WebKitSupport/DefaultTapHighlight.cpp:
        (BlackBerry::WebKit::DefaultTapHighlight::paintContents):
        (BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
        (WebKit):
        (BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):
        * WebKitSupport/DefaultTapHighlight.h:
        (DefaultTapHighlight):
        * WebKitSupport/InspectorOverlayBlackBerry.cpp:
        (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
        (WebKit):
        (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
        * WebKitSupport/InspectorOverlayBlackBerry.h:
        (InspectorOverlay):
        * WebKitSupport/SelectionOverlay.cpp:
        (BlackBerry::WebKit::SelectionOverlay::draw):
        (BlackBerry::WebKit::SelectionOverlay::hide):
        (BlackBerry::WebKit::SelectionOverlay::paintContents):
        (BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
        (WebKit):
        (BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):
        * WebKitSupport/SelectionOverlay.h:
        (SelectionOverlay):
        * WebKitSupport/SurfacePool.cpp:
        (BlackBerry::WebKit::SurfacePool::createPlatformGraphicsContext):
        (BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
        (BlackBerry::WebKit::SurfacePool::waitForBuffer):
        (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
        (BlackBerry::WebKit::SurfacePool::destroyPlatformSync):
        * WebKitSupport/SurfacePool.h:

1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197
2013-03-15  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] Expose the compositing thread layer's draw rectangle to aid hit testing
        https://bugs.webkit.org/show_bug.cgi?id=112255

        Reviewed by Rob Buis.

        PR 308284.
        Reviewed internally by Yongxin Dai.

        The cached draw rectangle is useful for hit testing. Add a getter for
        this compositing thread layer property to the public WebOverlay API.
        We name this getter using terminology familiar from the
        ViewportAccessor interface, to clarify which coordinate system the
        getter uses (pixel coordinates relative to the viewport).

        Note that WebKit-thread flavor of WebOverlay is not currently used by
        any API client and is marked obsolete. It is used internally in WebKit,
        but for that case using GraphicsLayer directly works well. This will
        allow the complexity of WebOverlay to be significantly reduced in the
        future, by removing the WebKit-thread flavor entirely.

        * Api/WebOverlay.cpp:
        (BlackBerry::WebKit::WebOverlay::pixelViewportRect):
        (WebKit):
        (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::pixelViewportRect):
        (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
        * Api/WebOverlay.h:
        (WebKit):
        * Api/WebOverlay_p.h:
        (WebOverlayPrivate):
        (WebOverlayPrivateWebKitThread):
        (WebOverlayPrivateCompositingThread):

1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246
2013-03-15  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] Allow an embedder to position child windows using window coordinates
        https://bugs.webkit.org/show_bug.cgi?id=112236

        Reviewed by Rob Buis.

        PR 232752

        Child windows used to always be positioned in document coordinates,
        which requires the
        BlackBerry::Platform::Graphics::Window::virtualRect() of the parent
        window to be kept in sync with the document visible content rect.
        This is easy if there's a one-to-one correspondence between windows
        and scrollable frames.

        However, for an embedder that can display an entire scene graph (where
        the web page is just one of the nodes) in one window, several
        scrollable nodes may be present in that window, and it's difficult to
        know which scrollable node to sync the virtualRect with. It could also
        lead to conflicts, if two scrollable nodes have child windows.

        For the latter scenario, it makes more sense to use window coordinates
        to place child windows.

        The internal default is to use document coordinates, for legacy
        reasons.

        When an external WebPageCompositor is attached, we switch to using
        window coordinates instead of document coordinates by default. The
        behavior is still configurable using the new public
        setChildWindowPlacement method.

        * Api/WebPageCompositor.cpp:
        (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
        (BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
        (BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
        (BlackBerry::WebKit::WebPageCompositorPrivate::render):
        (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
        (BlackBerry::WebKit::WebPageCompositorPrivate::shouldClearSurfaceBeforeCompositing):
        (WebKit):
        (BlackBerry::WebKit::WebPageCompositorPrivate::shouldChildWindowsUseDocumentCoordinates):
        (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
        (BlackBerry::WebKit::WebPageCompositor::setChildWindowPlacement):
        * Api/WebPageCompositor.h:
        * Api/WebPageCompositor_p.h:
        (BlackBerry::WebKit::WebPageCompositorPrivate::setChildWindowPlacement):
        (WebPageCompositorPrivate):

1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258
2013-03-15  Nate Chapin  <japhet@chromium.org>

        Hide MainResourceLoader from the outside world
        https://bugs.webkit.org/show_bug.cgi?id=109971

        Reviewed by Adam Barth.

        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
        * WebCoreSupport/FrameLoaderClientBlackBerry.h:
        (FrameLoaderClientBlackBerry):

1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276
2013-03-15  Abhishek Arya  <inferno@chromium.org>

        Replace static_casts with to* helper functions.
        https://bugs.webkit.org/show_bug.cgi?id=112401

        Reviewed by Stephen Chenney.

        to* helper functions are preferred over static_cast calls since they
        help to catch bad casts easily on the testing infrastructure.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::frameForNode):
        (BlackBerry::WebKit::needsLayoutRecursive):
        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin):
        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):

1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293
2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>

        Add selectTrailingWhitespaceEnabled setting to WebCore::Page
        https://bugs.webkit.org/show_bug.cgi?id=109404

        Reviewed by Tony Chang.

        Use new settings for smartInsertDeleteEnabled and
        selectTrailingWhitespaceEnabled.

        Remove code related to DRT as it is not needed anymore.

        * Api/DumpRenderTreeClient.h:
        * WebCoreSupport/EditorClientBlackBerry.cpp:
        (WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
        (WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):

1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327
2013-03-14  Abhishek Arya  <inferno@chromium.org>

        Replace static_casts with to* helper functions.
        https://bugs.webkit.org/show_bug.cgi?id=112296

        Reviewed by Kentaro Hara.

        to* helper functions are preferred over static_cast calls since they
        help to catch bad casts easily on the testing infrastructure.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::webContext):
        (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
        (BlackBerry::WebKit::WebPage::setNodeFocus):
        (BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):
        * WebCoreSupport/EditorClientBlackBerry.cpp:
        (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
        (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
        * WebKitSupport/BackingStoreClient.cpp:
        (BlackBerry::WebKit::BackingStoreClient::absoluteRect):
        * WebKitSupport/DOMSupport.cpp:
        (BlackBerry::WebKit::DOMSupport::toTextControlElement):
        (BlackBerry::WebKit::DOMSupport::selectionContainerElement):
        * WebKitSupport/FatFingers.cpp:
        (BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):
        (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
        (BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
        * WebKitSupport/TouchEventHandler.cpp:
        (BlackBerry::WebKit::elementForTapHighlight):

1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339
2013-03-14  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] InRegionScrollableArea: fix call to visibleContentRect()
        https://bugs.webkit.org/show_bug.cgi?id=112244

        Reviewed by Rob Buis.

        Since r143295 visibleContentRect() receives an enum, not a boolean.

        * WebKitSupport/InRegionScrollableArea.cpp:
        (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357
2013-03-13  Iris Wu  <shuwu@blackberry.com>

        [BlackBerry] Do not do scroll position adjustment if selecting in a subframe
        https://bugs.webkit.org/show_bug.cgi?id=112290

        Reviewed by Rob Buis.

        PR 267394

        In SelectionHandler::ensureSelectedTextVisible(), scroll position
        animation is based on main frame. If selecting in a subframe, don't
        do animation.

        Internally Reviewed By Genevieve Mak.

        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):

1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378
2013-03-13  Genevieve Mak  <gmak@rim.com>

        [BlackBerry] Add Proximity Detector.
        https://bugs.webkit.org/show_bug.cgi?id=112278

        Reviewed by Rob Buis.

        Internally Reviewed by Mike Lattanzio.
        PR #243385

        * WebKitSupport/ProximityDetector.cpp: Added.
        (WebKit):
        (BlackBerry::WebKit::getPriorityLevel):
        (BlackBerry::WebKit::ProximityDetector::ProximityDetector):
        (BlackBerry::WebKit::ProximityDetector::~ProximityDetector):
        (BlackBerry::WebKit::ProximityDetector::findBestPoint):
        * WebKitSupport/ProximityDetector.h: Added.
        (WebCore):
        (WebKit):
        (ProximityDetector):

1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404
2013-03-13  Iris Wu  <shuwu@blackberry.com>

        [BlackBerry] Touch Hold selection does not scroll text area or other subframe until selection reaches bottom of the page.
        https://bugs.webkit.org/show_bug.cgi?id=112259

        Reviewed by Rob Buis.

        PR 267394

        While selecting in a subframe, check that the selection reaches
        the bottom of the current subframe instead of the page.

        Internally Reviewed by Genevieve Mak.

        * Api/InRegionScroller.cpp:
        (BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
        (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
        (BlackBerry::WebKit::SelectionHandler::selectionViewportRect):
        (WebKit):
        (BlackBerry::WebKit::SelectionHandler::expandSelectionToGranularity):
        * WebKitSupport/SelectionHandler.h:
        (BlackBerry::WebKit::SelectionHandler::setSelectionViewportRect):
        (SelectionHandler):

1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423
2013-03-12  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Prevent text selection inside Colour and Date/Time input fields
        https://bugs.webkit.org/show_bug.cgi?id=111733

        Reviewed by Rob Buis.

        PR 305194.

        Skip rendering of selection if it is in a popup driven
        input field.  This covers situations where EditorClientBlackBerry::shouldChangeSelectedRange
        is either not called or focus is not complete when called.

        Informally reviewed by Gen Mak.

        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
        (WebKit):

1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448
2013-03-12  Genevieve Mak  <gmak@rim.com>

        [BlackBerry] Notify client if the selection is in a subframe when started.
        https://bugs.webkit.org/show_bug.cgi?id=112065

        Reviewed by Rob Buis.

        PR #278490
        Internally Reviewed by Mike Fenton.

        * Api/InRegionScroller.cpp:
        (BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
        (WebKit):
        * Api/InRegionScroller_p.h:
        (InRegionScrollerPrivate):
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::updateSelectionScrollView):
        (WebKit):
        * Api/WebPageClient.h:
        * Api/WebPage_p.h:
        (WebPagePrivate):
        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::cancelSelection):
        (BlackBerry::WebKit::SelectionHandler::setSelection):

1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462
2013-03-12  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] SelectionHandler: fix truncated line
        https://bugs.webkit.org/show_bug.cgi?id=112133

        Reviewed by Carlos Garcia Campos.

        One of the calls to fatFingersResult.nodeAsElementIfApplicable()
        was somehow truncated when the selection start animation was
        upstreamed in r144640.

        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::selectAtPoint):

1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476
2013-03-12  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] Fix visible_units.h includes
        https://bugs.webkit.org/show_bug.cgi?id=112131

        Reviewed by Carlos Garcia Campos.

        This file was renamed to VisibleUnits.h in r144911.

        * WebKitSupport/DOMSupport.cpp:
        * WebKitSupport/InputHandler.cpp:
        * WebKitSupport/SelectionHandler.cpp:
        * WebKitSupport/SpellingHandler.cpp:

1477 1478 1479 1480 1481 1482 1483 1484 1485 1486
2013-03-11  Jochen Eisinger  <jochen@chromium.org>

        Rename DefinitelyProcessingUserGesture to DefinitelyProcessingNewUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=111959

        Reviewed by Alexey Proskuryakov.

        * WebKitSupport/NotificationManager.cpp:
        (BlackBerry::WebKit::NotificationManager::notificationClicked):

1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515
2013-03-11  Genevieve Mak  <gmak@rim.com>

        [BlackBerry] Add a method to find the ScrollView for a text selection.
        https://bugs.webkit.org/show_bug.cgi?id=112061

        Reviewed by Rob Buis.

        Internally reviewed by Mike Fenton and Jakob Petsovits.
        PR #278490

        Refactor the code in InRegionScroller so that we can add a method to find
        the InRegionScrollableArea for a text selection.

        * Api/InRegionScroller.cpp:
        (BlackBerry::WebKit::InRegionScrollerPrivate::clipToRect):
            - Pull out recursive clipping code into its own function.
        (WebKit):
        (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
        (BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
            - This new method allows us to get just the first scrollable region instead of looking
              for more nested ones. We may want to refactor in the future because some of the code is
              very similar to calculateInRegionScrollableAreasForPoint.
        (BlackBerry::WebKit::InRegionScrollerPrivate::clipAndCreateInRegionScrollableArea):
            - Add a convenience method for the previous function
        * Api/InRegionScroller.h:
        (WebKit):
        * Api/InRegionScroller_p.h:
        (InRegionScrollerPrivate):

1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528
2013-03-11  Genevieve Mak  <gmak@rim.com>

        [BlackBerry] Set the documentViewportRect and viewport size.
        https://bugs.webkit.org/show_bug.cgi?id=112056

        Reviewed by Rob Buis.

        Internally reviewed by Mike Fenton and Jakob Petsovits.
        PR #278490

        * WebKitSupport/InRegionScrollableArea.cpp:
        (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541
2013-03-11  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] SelectionHandler: bring back m_lastSelection attribute
        https://bugs.webkit.org/show_bug.cgi?id=111972

        Reviewed by Rob Buis.

        This was removed in r144515 but is still needed by
        SelectionHandler::selectionPositionChanged().

        * WebKitSupport/SelectionHandler.h:
        (SelectionHandler):

1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553
2013-03-07  Otto Derek Cheung  <otcheung@rim.com>

        [BlackBerry] RefCounting ParsedCookie to avoid SegFaults
        https://bugs.webkit.org/show_bug.cgi?id=111761

        Reviewed by Rob Buis.

        Making necessary changes to ref-count the ParsedCookie object.

        * Api/WebCookieJar.cpp:
        (BlackBerry::WebKit::WebCookieJar::cookies):

1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569
2013-03-07  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Prevent text selection inside Colour and Date/Time input fields
        https://bugs.webkit.org/show_bug.cgi?id=111733

        Reviewed by Rob Buis.

        PR 305194.

        Prevent selection for popup input fields as they are buttons.

        Informally Reviewed Gen Mak.

        * WebCoreSupport/EditorClientBlackBerry.cpp:
        (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):

1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589
2013-03-06  Nima Ghanavatian  <nghanavatian@rim.com>

        [BlackBerry] Selection handles don't drag to expand correctly for RTL languages
        https://bugs.webkit.org/show_bug.cgi?id=111618

        Reviewed by Rob Buis.

        PR 303712
        If we are using a RTL language, we should ensure that the selection handles are angled the right way.
        Further, when expanding the selection, the start and end handles should be appropriately set so that
        expansion in the natural direction is possible.

        Internally reviewed by Mike Fenton.

        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::SelectionHandler):
        (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
        * WebKitSupport/SelectionHandler.h:
        (SelectionHandler):

1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602
2013-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>

        [BlackBerry] Use the new authenticationChallenge API in WebPage
        https://bugs.webkit.org/show_bug.cgi?id=111542

        Reviewed by Rob Buis.

        Use the new API that expects requestURL and isProxy parameters.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
        * Api/WebPageClient.h:

1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617
2013-03-05  Geoffrey Garen  <ggaren@apple.com>

        Removed some dead code in the page cache
        https://bugs.webkit.org/show_bug.cgi?id=111525

        Reviewed by Alexey Proskuryakov.

        Page cache autorelease doesn't exist anymore, so there's no need to keep
        around these olds hacks.

        * Api/BlackBerryGlobal.cpp:
        (BlackBerry::WebKit::clearMemoryCaches):
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPage::destroy):

1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630
2013-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>

        [BlackBerry] Use CachedResource::resourceBuffer() instead of CachedResource::data()
        https://bugs.webkit.org/show_bug.cgi?id=111555

        Reviewed by Rob Buis.

        CachedResource::data() was renamed to
        CachedResource::resourceBuffer() in r130947.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::webContext):

1631 1632 1633 1634 1635 1636 1637 1638 1639 1640
2013-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>

        [BlackBerry] Remove some unneeded header includes
        https://bugs.webkit.org/show_bug.cgi?id=111545

        Reviewed by Rob Buis.

        * WebCoreSupport/CredentialTransformData.cpp:
        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654
2013-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>

        [BlackBerry] Use hasTagName instead of hasLocalName in CredentialTransformData
        https://bugs.webkit.org/show_bug.cgi?id=111544

        Reviewed by Rob Buis.

        hasLocalName() expects an AtomicString, but we are passing a
        HTMLName which is a QualifiedName.

        * WebCoreSupport/CredentialTransformData.cpp:
        (WebCore::CredentialTransformData::findPasswordFormFields): Use
        hasTagName() instead of hasLocalName().

1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677
2013-03-05  Otto Derek Cheung  <otcheung@rim.com>

        [BlackBerry] Authentication credentials lost when opening a new tab
        https://bugs.webkit.org/show_bug.cgi?id=111445

        PR 286627

        Reviewed by Rob Buis.
        Internally Reviewed by Lianghui Chen.

        Prevent changing the private mode boolean value in didChangeSettings if the value
        hasn't changed.

        Setting the private mode value of credentialstorage every time didChangeSettings gets
        called causes the session credential mapping to be cleared on every tab change in
        non-private mode.

        Tested changing tabs after logging into a site using the HTTP Basic Auth protocol to see
        if the credentials are cleared. Also ensured the functionality of private mode is not changed.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695
2013-03-05  Tiancheng Jiang  <tijiang@rim.com>

        [BlackBerry] FatFinger pairs the wrong element with fatfinger rect part.
        https://bugs.webkit.org/show_bug.cgi?id=111444

        Reviewed by Rob Buis.

        Internal PR 266214
        Internally reviewed by Genevieve Mak.

        Instead of subtracting with the element region, we should get the remaining
        rect by find the intersect region of element region and fatfinger detection
        region.


        * WebKitSupport/FatFingers.cpp:
        (BlackBerry::WebKit::FatFingers::checkForClickableElement):

1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724
2013-03-05  Andrew Lo  <anlo@rim.com>

        [BlackBerry] Clean up animated scroll/zoom code in WebPagePrivate
        https://bugs.webkit.org/show_bug.cgi?id=111373

        Reviewed by Rob Buis.

        Internally reviewed by Jakob Petsovits.
        Internal PR 285468.

        Have WebPageClient pass the final scale and position to WebPage when a zoom/scroll
        animation finishes, rather than keeping those values as instance variables in
        WebPagePrivate.

        Rename some functions & variables to reflect that they are used for both block zoom
        and generic zoom/scroll animations.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
        (BlackBerry::WebKit::WebPage::zoomAnimationFinished):
        (BlackBerry::WebKit::WebPagePrivate::resetBlockZoom):
        (BlackBerry::WebKit::WebPage::blockZoom):
        (BlackBerry::WebKit::WebPagePrivate::animateToScaleAndDocumentScrollPosition):
        * Api/WebPage.h:
        * Api/WebPageClient.h:
        * Api/WebPage_p.h:
        (WebPagePrivate):

1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768
2013-03-04  Iris Wu  <shuwu@rim.com>

        [BlackBerry] Upstream selection start animation.
        https://bugs.webkit.org/show_bug.cgi?id=111335

        Reviewed by Rob Buis.

        PR 219960

        To indicate selection starts, we draw an overlay rect larger than
        the selected word at the start of selection. Then shrink it down
        to the actual size.

        Reviewed Internally by Genevieve Mak and Andrew Lo and Mike Fenton.

        * Api/WebAnimation.cpp:
        (BlackBerry::WebKit::WebAnimation::shrinkAnimation):
        (WebKit):
        * Api/WebAnimation.h:
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::init):
        (BlackBerry::WebKit::WebPage::selectionHighlight):
        (WebKit):
        * Api/WebPage.h:
        * Api/WebPage_p.h:
        (WebPagePrivate):
        * Api/WebTapHighlight.h:
        * WebKitSupport/DefaultTapHighlight.cpp:
        (WebKit):
        (BlackBerry::WebKit::shrinkAnimationName):
        (BlackBerry::WebKit::DefaultTapHighlight::draw):
        * WebKitSupport/DefaultTapHighlight.h:
        (DefaultTapHighlight):
        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::cancelSelection):
        (BlackBerry::WebKit::textGranularityFromSelectionExpansionType):
        (WebKit):
        (BlackBerry::WebKit::SelectionHandler::selectNodeIfFatFingersResultIsLink):
        (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
        * WebKitSupport/SelectionHandler.h:
        (SelectionHandler):
        * WebKitSupport/TouchEventHandler.cpp:
        (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779
2013-03-02  Benjamin Poulain  <bpoulain@apple.com>

        Move computedStyleIncludingVisitedInfo from TestRunner to Internals
        https://bugs.webkit.org/show_bug.cgi?id=109772

        Reviewed by Andreas Kling.

        * WebKitSupport/DumpRenderTreeSupport.cpp:
        * WebKitSupport/DumpRenderTreeSupport.h:
        (DumpRenderTreeSupport):

1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823
2013-03-01  Iris Wu  <shuwu@rim.com>

        [BlackBerry] Upstream smart selection
        https://bugs.webkit.org/show_bug.cgi?id=111226

        Reviewed by Rob Buis.

        1.  Extend the touch hold text selection to next paragraph.
        2.  Draw and expand overlay over text as touch hold selection expands.
            Select paragraph when it's entirely covered by overlay.
        3.  Start scrolling at a constant rate when the end of
            next pargraph is not in the viewport.

        Reviewed Internally By Genevieve Mak and Mike Fenton.
        PR 217897 238485 258279 279042 299779

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPage::selectAtDocumentPoint):
        (BlackBerry::WebKit::WebPage::expandSelection):
        (WebKit):
        (BlackBerry::WebKit::WebPage::setOverlayExpansionPixelHeight):
        (BlackBerry::WebKit::WebPagePrivate::setOverlayExpansionPixelHeight):
        (BlackBerry::WebKit::WebPage::setParagraphExpansionPixelScrollMargin):
        * Api/WebPage.h:
        * Api/WebPageClient.h:
        * Api/WebPage_p.h:
        (WebPagePrivate):
        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::cancelSelection):
        (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
        (BlackBerry::WebKit::isInvalidLine):
        (WebKit):
        (BlackBerry::WebKit::isInvalidParagraph):
        (BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
        (BlackBerry::WebKit::SelectionHandler::drawOverlay):
        (BlackBerry::WebKit::SelectionHandler::findNextOverlayRegion):
        (BlackBerry::WebKit::SelectionHandler::expandSelection):
        (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
        (BlackBerry::WebKit::SelectionHandler::setParagraphExpansionScrollMargin):
        (BlackBerry::WebKit::SelectionHandler::expandSelectionToGranularity):
        * WebKitSupport/SelectionHandler.h:
        (SelectionHandler):
        (BlackBerry::WebKit::SelectionHandler::setOverlayExpansionHeight):

1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846
2013-03-01  Jacky Jiang  <zhajiang@rim.com>

        [BlackBerry] Screen went black while navigating back/forward on the reddit.com page
        https://bugs.webkit.org/show_bug.cgi?id=111192

        Reviewed by Rob Buis.
        Internally reviewed by Jakob Petsovits.

        PR: 299783
        When going back to the previous reddit.com page, the actual contents
        size was much less than the history contents size. However, we expanded
        the actual contents size to history contents size which caused a huge
        black area below the actual contents.
        To fix that, don't restore the contents size from history contents size
        and scroll back to the valid contents area if we are about to overscroll.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
        * Api/WebPage_p.h:
        (WebPagePrivate):
        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::restoreViewState):

1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864
2013-03-01  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Improve input bounds clipping for search fields.
        https://bugs.webkit.org/show_bug.cgi?id=111204

        Reviewed by Rob Buis.

        PR 292673.

        Use the standardized InputHandler function to get the
        bounds of an input field so that search fields are
        truncated smaller to account for the X.

        Reviewed Internally by Gen Mak.

        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::setCaretPosition):

1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879
2013-03-01  Nima Ghanavatian  <nghanavatian@rim.com>

        [BlackBerry] Reverse the base and extent of a selection when reversing its handles
        https://bugs.webkit.org/show_bug.cgi?id=111098

        Reviewed by Yong Li.

        PR283969
        Swap the base and extent if base does not come first, and set the new selection.

        Internally reviewed by Mike Fenton

        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::setSelection):

1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892
2013-03-01  Alberto Garcia  <albgarcia@rim.com>

        Fix definition of DatePickerClient::setValue()
        https://bugs.webkit.org/show_bug.cgi?id=110336

        Reviewed by Carlos Garcia Campos.

        The definition of DatePickerClient::setValue() introduced in
        r142987 does not match the prototype.

        * WebCoreSupport/DatePickerClient.cpp:
        (WebCore::DatePickerClient::setValue):

1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910
2013-02-28  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Maintain the directionality of the selection after modifying the selection using key events.
        https://bugs.webkit.org/show_bug.cgi?id=111078

        Reviewed by Yong Li.

        PR 295224.

        When using the key navigation to modify the selection, reset the
        directionality of the selection to the original to prevent
        changing the anchor.

        Reviewed Internally by Nima Ghanavatian.

        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):

1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926
2013-02-28  Lianghui Chen  <liachen@rim.com>

        [BlackBerry] Disable auto-filling password in forms when auto-form-filling is not enabled.
        https://bugs.webkit.org/show_bug.cgi?id=111006

        Internal PR: 295181
        Internal reviewed by Joe Mason.

        Reviewed by Yong Li.

        Check WebSettings::isFormAutofillEnabled() before doing user credential form fill stuff.

        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
        (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):

1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944
2013-02-28  Alberto Garcia  <albgarcia@rim.com>

        [BlackBerry] Misc build fixes
        https://bugs.webkit.org/show_bug.cgi?id=110448

        Reviewed by Rob Buis.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
        WebString was replaced with BlackBerry::Platform::String in r131316.
        (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
        Some webdatabase APIs are encapuslated in DatabaseManager since r137520.
        (BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
        Document::isPendingStyleRecalc() was renamed to hasPendingStyleRecalc() in r129844.
        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::updateFormState):
        Add closing brace that was missing in r142482.

1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959
2013-02-28  Xan Lopez  <xlopez@rim.com>

        [BlackBerry] DumpRenderTreeSupport: update the set position methods
        https://bugs.webkit.org/show_bug.cgi?id=110578

        Reviewed by Rob Buis.

        TestRunner::setMockGeolocationPosition() changed in r130416:
        http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h

        * WebKitSupport/DumpRenderTreeSupport.cpp:
        (DumpRenderTreeSupport::setMockGeolocationPosition):
        * WebKitSupport/DumpRenderTreeSupport.h:
        (DumpRenderTreeSupport):

1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990
2013-02-27  Andrew Lo  <anlo@rim.com>

        [BlackBerry] Need WebPage API for animating scroll position & zoom changes
        https://bugs.webkit.org/show_bug.cgi?id=110912

        Reviewed by Rob Buis.

        Internally reviewed by Jakob Petsovits.
        Internal PR 285468.

        Add an API to WebPage for animated scroll position & zoom level
        adjustments.

        Have InputHandler use the new API.

        Rename some variables to reflect the fact that they are not only
        used by block zoom now.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
        (BlackBerry::WebKit::WebPage::blockZoom):
        (BlackBerry::WebKit::WebPagePrivate::animateToScaleAndDocumentScrollPosition):
        (WebKit):
        (BlackBerry::WebKit::WebPage::animateToScaleAndDocumentScrollPosition):
        * Api/WebPage.h:
        * Api/WebPage_p.h:
        (WebPagePrivate):
        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011
2013-02-27  Lianghui Chen  <liachen@rim.com>

        [BlackBerry] User credentials is not correctly handled
        https://bugs.webkit.org/show_bug.cgi?id=110994

        Reviewed by Yong Li.

        Following change are made:
            Remove url from CredentialTransformData, as url is not used anymore.
            Adapt to updated CredentialBackingStore API about removing url.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
        * WebCoreSupport/CredentialManager.cpp:
        (WebCore::CredentialManager::autofillPasswordForms):
        (WebCore::CredentialManager::saveCredentialIfConfirmed):
        * WebCoreSupport/CredentialTransformData.cpp:
        (WebCore::CredentialTransformData::CredentialTransformData):
        * WebCoreSupport/CredentialTransformData.h:
        (CredentialTransformData):

2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025
2013-02-27  John Griggs  <jgriggs@rim.com>

        2013-02-27  John Griggs  <jgriggs@rim.com>

        Fix bug in HTML5 Fullscreen API implementation that was preventing YouTube HTML5 media controls fullscreen button from working properly.
        https://bugs.webkit.org/show_bug.cgi?id=110905

        Reviewed by Yong Li.

        Return true from ChromeClientBlackBerry::supportsFullScreenForElement instead of the negation of the boolean flag (withKeyboard) passed in.

        * WebCoreSupport/ChromeClientBlackBerry.cpp:
        (WebCore::ChromeClientBlackBerry::supportsFullScreenForElement):

2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051
2013-02-27  Sean Wang  <Xuewen.Wang@torchmobile.com.cn>

        [BlackBerry] Context menu cannot be invoked after doing text selection in landscape mode
        https://bugs.webkit.org/show_bug.cgi?id=110860

        Reviewed by Yong Li.

        PR 290248 Internally reviewed by Mike Fenton

        Add a parameter to notify the webpage client which parts of selection have
        changed in visual or in its selected DOM content. Refactor the selection details
        parameter to platform repo.

        The reason of this issue is that when javascript triggers webpage layout, the selection
        will update its apperance event when the selected content is not changed. We want
        to hide the context menu only when the selected content is changed not when only its
        visual is changed.

* Api/WebPageClient.h:
        (Platform):
        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::cancelSelection):
        (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
        * WebKitSupport/SelectionHandler.h:
        (SelectionHandler):

2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075
2013-02-27  Sean Wang  <Xuewen.Wang@torchmobile.com.cn>

        [BlackBerry] The virtual keyboard hides part of Signing In dialog
        https://bugs.webkit.org/show_bug.cgi?id=110836

        Reviewed by Yong Li.

        PR # 283427 Internally reviewed by Mike Fenton.

        Store form credentials before javascript "onSubmit" event and notify
        webpage client to save credentials after that event since javascript
        may check credentials and stop the submission in its event handler.

        * WebCoreSupport/CredentialTransformData.cpp:
        (WebCore::CredentialTransformData::CredentialTransformData):
        (WebCore):
        * WebCoreSupport/CredentialTransformData.h:
        (CredentialTransformData):
        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
        (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
        * WebCoreSupport/FrameLoaderClientBlackBerry.h:
        (FrameLoaderClientBlackBerry):

2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095
2013-02-27  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Accept key events even when composing region is active.
        https://bugs.webkit.org/show_bug.cgi?id=110617

        Reviewed by Rob Buis.

        PR 293598.

        Fix a regression in the previous patch caused
        by an unhandled Alt key down being sent through
        by IMF.

        Reviewed Internally by Nima Ghanavatian.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::updateFormState):
        * WebKitSupport/InputHandler.h:
        (InputHandler):

2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108
2013-02-26  Yong Li  <yoli@rim.com>

        [BlackBerry] Use APIEntryShim when making JS call
        https://bugs.webkit.org/show_bug.cgi?id=110787

        Reviewed by Rob Buis.

        PR# 301451.
        Use APIEntryShim to fix an assert and ensure it is thread-safe.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):

2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152
2013-02-26  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] Upstream the datalist support UI
        https://bugs.webkit.org/show_bug.cgi?id=110736

        Reviewed by Rob Buis.

        Original code by Otto Derek Cheung <otcheung@rim.com>

        * WebCoreSupport/SuggestionBoxElement.cpp: Added.
        (WebCore):
        (WebCore::SuggestionBoxElement::SuggestionBoxElement):
        (WebCore::SuggestionBoxElement::~SuggestionBoxElement):
        (WebCore::SuggestionBoxElement::create):
        (WebCore::SuggestionBoxElement::defaultEventHandler):
        * WebCoreSupport/SuggestionBoxElement.h: Added.
        (WebCore):
        (SuggestionBoxElement):
        * WebCoreSupport/SuggestionBoxHandler.cpp: Added.
        (WebCore):
        (WebCore::SuggestionBoxHandler::SuggestionBoxHandler):
        (WebCore::SuggestionBoxHandler::~SuggestionBoxHandler):
        (WebCore::SuggestionBoxHandler::create):
        (WebCore::SuggestionBoxHandler::setInputElementAndUpdateDisplay):
        (WebCore::SuggestionBoxHandler::showDropdownBox):
        (WebCore::SuggestionBoxHandler::hideDropdownBox):
        (WebCore::SuggestionBoxHandler::changeInputElementInnerTextValue):
        (WebCore::SuggestionBoxHandler::parseSuggestions):
        (WebCore::SuggestionBoxHandler::insertSuggestionsToDropdownBox):
        (WebCore::adjustDropdownBoxPosition):
        (WebCore::SuggestionBoxHandler::buildDropdownBoxTree):
        * WebCoreSupport/SuggestionBoxHandler.h: Added.
        (WebCore):
        (SuggestionBoxHandler):
        (WebCore::SuggestionBoxHandler::focusedElement):
        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::setElementUnfocused):
        (BlackBerry::WebKit::InputHandler::updateFormState):
        * WebKitSupport/InputHandler.h:
        (WebCore):
        (InputHandler):
        * WebKitSupport/TouchEventHandler.cpp:
        (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172
2013-02-25  Yongxin Dai  <yodai@rim.com>

        [BlackBerry] Add isInputMode() method to WebPage class.
        https://bugs.webkit.org/show_bug.cgi?id=110754

        Reviewed by Rob Buis.

        PR #262569.

        There is a case we need to know if the active node is content editable
        from TouchHandlerWebKitThread class. WebPage::isInputMode() just delegates
        InputHandler::isInputMode().

        Reviewed Internally by Mike Fenton.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPage::isInputMode):
        (WebKit):
        * Api/WebPage.h:

2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189
2013-02-25  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Force form submission when implicit submission fails.
        https://bugs.webkit.org/show_bug.cgi?id=110627

        Reviewed by Rob Buis.

        PR 286023.

        When implicit form submission does not submit the form
        do a direct submission of the form.

        Reviewed Internally by Nima Ghanavatian.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::updateFormState):

2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201
2013-02-25  Tiancheng Jiang  <tijiang@rim.com>

        [BlackBerry]Adjust fatfinger detection rect size.
        https://bugs.webkit.org/show_bug.cgi?id=108678

        Reviewed by Rob Buis.

        Fix a typo in function names.

        * WebKitSupport/FatFingers.cpp:
        (BlackBerry::WebKit::FatFingers::getNodesFromRect):

2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214
2013-02-25  Alberto Garcia  <albgarcia@rim.com>

        [BlackBerry] ChromeClientBlackBerry: fix variable names
        https://bugs.webkit.org/show_bug.cgi?id=110562

        Reviewed by Rob Buis.

        manager was incorrectly renamed back to tracker in r138696:
        http://trac.webkit.org/changeset/138696/trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp

        * WebCoreSupport/ChromeClientBlackBerry.cpp:
        (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):

2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226
2013-02-24  Alberto Garcia  <albgarcia@rim.com>

        [BlackBerry] GeolocationClientBlackBerry: add missing headers
        https://bugs.webkit.org/show_bug.cgi?id=110563

        Reviewed by Benjamin Poulain.

        Frame.h and SecurityOrigin.h are necessary since r136969.
        GeolocationPosition.h since r132360.

        * WebCoreSupport/GeolocationClientBlackBerry.cpp:

2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239
2013-02-24  Alberto Garcia  <albgarcia@rim.com>

        [BlackBerry] FatFingers: move rectForPoint() from HitTestResult to HitTestLocation
        https://bugs.webkit.org/show_bug.cgi?id=110570

        Reviewed by Allan Sandfeld Jensen.

        HitTestResult is no longer a HitTestLocation:
        http://trac.webkit.org/changeset/135710/trunk/Source/WebCore/rendering/HitTestResult.h

        * WebKitSupport/FatFingers.cpp:
        (BlackBerry::WebKit::FatFingers::fingerRectForPoint):

2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260
2013-02-22  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Eliminate invalid clipping for content editable selections
        https://bugs.webkit.org/show_bug.cgi?id=110630

        Reviewed by Rob Buis.

        PR 284629.

        Remove selection clipping for content editable
        fields as the bounds aren't valid and cause
        clipping based on starting node rather than the
        union of nodes.

        Reviewed Internally by Nima Ghanavatian.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::updateFormState):
        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):

2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279
2013-02-22  Tiancheng Jiang  <tijiang@rim.com>

        [BlackBerry]Adjust fatfinger detection rect size
        https://bugs.webkit.org/show_bug.cgi?id=108678.

        Reviewed by Antonio Gomes.

        Changing HitTestRequest::IgnoreClipping does not solve the problem that
        FatFinger rect detect the element out of the viewport. We have to clip
        the fatfinger rect according to the current viewport size to avoid picking
        the element out of the viewport.

        * WebKitSupport/FatFingers.cpp:
        (BlackBerry::WebKit::FatFingers::fingerRectForPoint):
        (BlackBerry::WebKit::FatFingers::findBestPoint):
        (BlackBerry::WebKit::FatFingers::getAdjustedPaddings):
        (BlackBerry::WebKit::FatFingers::getNodesFromRect):
        * WebKitSupport/FatFingers.h:

2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297
2013-02-22  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Accept key events even when composing region is active.
        https://bugs.webkit.org/show_bug.cgi?id=110617

        Reviewed by Rob Buis.

        PR 293598.

        Don't reject key events that arrive when composing region is active,
        this can prevent navigation events from firing, instead end
        the composition and process the key.

        Reviewed Internally by Nima Ghanavatian.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::updateFormState):

2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311
2013-02-22  Carlos Garcia Campos  <cargarcia@rim.com>

        [BlackBerry] Rename first/second to key/value in HashMap iterators
        https://bugs.webkit.org/show_bug.cgi?id=110577

        Reviewed by Rob Buis.

        Iterators were renamed to key/value in r130612.

        * WebKitSupport/NotificationManager.cpp:
        (BlackBerry::WebKit::NotificationManager::show):
        (BlackBerry::WebKit::NotificationManager::clearNotifications):
        (BlackBerry::WebKit::NotificationManager::removeNotificationFromContextMap):

2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325
2013-02-22  Carlos Garcia Campos  <cargarcia@rim.com>

        [BlackBerry] Remove ProtocolHandler methods from ChromeClientBlackBerry
        https://bugs.webkit.org/show_bug.cgi?id=110567

        Reviewed by Rob Buis.

        They were removed from ChromeClient in r122810 and are now
        implemented in NavigatorContentUtilsClientBlackBerry since r131056.

        * WebCoreSupport/ChromeClientBlackBerry.cpp:
        * WebCoreSupport/ChromeClientBlackBerry.h:
        (ChromeClientBlackBerry):

2326 2327 2328 2329 2330 2331 2332 2333 2334 2335
2013-02-22  Xan Lopez  <xlopez@rim.com>

        [BlackBerry] DomSupport: use NodeTraversal APIs
        https://bugs.webkit.org/show_bug.cgi?id=110467

        Reviewed by Antonio Gomes.

        * WebKitSupport/DOMSupport.cpp:
        (BlackBerry::WebKit::DOMSupport::visibleTextQuads):

2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346
2013-02-21  Grzegorz Czajkowski  <g.czajkowski@samsung.com>

        Allow to retrieve the request data from abstract TextCheckingRequest to be accessible for WK2
        https://bugs.webkit.org/show_bug.cgi?id=110208

        Reviewed by Hajime Morrita.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
        Extract the request data as it is the member of 'TextCheckingRequest'.

2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361
2013-02-21  Andrew Lo  <anlo@rim.com>

        [BlackBerry] WebPagePrivate::load should not check new window policy
        https://bugs.webkit.org/show_bug.cgi?id=110403

        Reviewed by Rob Buis.

        Based on my understanding of changeset 135952, we should
        not check the new window policy in WebPagePrivate::load.

        None of the other ports seem to do this, except for plugins.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::load):

2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374
2013-02-21  Alberto Garcia  <albgarcia@rim.com>

        [BlackBerry] BackingStore: replace instrument{Begin,Cancel}Frame with did{Begin,Cancel}Frame
        https://bugs.webkit.org/show_bug.cgi?id=110460

        Reviewed by Rob Buis.

        This was renamed incorrectly in r142879.

        * Api/BackingStore.cpp:
        (BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
        (BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):

2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389
2013-02-21  Carlos Garcia Campos  <cargarcia@rim.com>

        [BlackBerry] Extra ResourceRequest parameter in FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload
        https://bugs.webkit.org/show_bug.cgi?id=110451

        Reviewed by Rob Buis.

        Remove the extra ResourceRequest parameter from
        FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload.

        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
        * WebCoreSupport/FrameLoaderClientBlackBerry.h:
        (FrameLoaderClientBlackBerry):

2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411
2013-02-21  Xan Lopez  <xlopez@rim.com>

        [BlackBerry] Adapt to name changes in WebCore::ViewPortArguments
        https://bugs.webkit.org/show_bug.cgi?id=110469

        Reviewed by Rob Buis.

        This changed in r134765.

        * Api/WebViewportArguments.cpp:
        (BlackBerry::WebKit::WebViewportArguments::zoom):
        (BlackBerry::WebKit::WebViewportArguments::setZoom):
        (BlackBerry::WebKit::WebViewportArguments::minZoom):
        (BlackBerry::WebKit::WebViewportArguments::setMinZoom):
        (BlackBerry::WebKit::WebViewportArguments::maxZoom):
        (BlackBerry::WebKit::WebViewportArguments::setMaxZoom):
        (BlackBerry::WebKit::WebViewportArguments::userZoom):
        (BlackBerry::WebKit::WebViewportArguments::setUserZoom):
        * Api/WebViewportArguments.h:
        * WebCoreSupport/ChromeClientBlackBerry.cpp:
        (WebCore::ChromeClientBlackBerry::didSetSVGZoomAndPan):

2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437
2013-02-21  Jakob Petsovits  <jpetsovits@rim.com>

        [BlackBerry] Move posting and scrollbar updates to the page client.
        https://bugs.webkit.org/show_bug.cgi?id=110256
        Internal PR 297099

        Reviewed by Rob Buis.

        In blitVisibleContents(), we were calling the WebKit thread
        functions BackingStorePrivate::isScrollingOrZooming() and
        WebPage::isVisible(). This is not the right spot to do it.
        Furthermore, we want to