ChangeLog 692 KB
Newer Older
1 2 3 4 5 6 7 8 9
2011-09-08  Daniel Bates  <dbates@webkit.org>

        Fix the GTK build after <http://trac.webkit.org/changeset/94810>
        (https://bugs.webkit.org/show_bug.cgi?id=67807).

        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_encoding): Substitute DocumentWriter::deprecatedFrameEncoding() for
        DocumentWriter::encoding().

10 11 12 13 14 15 16 17 18 19
2011-09-06  Ryosuke Niwa  <rniwa@webkit.org>

        Rename confirmCompositionWithoutDisturbingSelection to cancelComposition
        https://bugs.webkit.org/show_bug.cgi?id=67569

        Reviewed by Antonio Gomes.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::respondToChangedSelection):

20 21 22 23 24 25 26 27 28 29 30 31 32 33 34
2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r94142, r94144, r94145, and r94148.
        http://trac.webkit.org/changeset/94142
        http://trac.webkit.org/changeset/94144
        http://trac.webkit.org/changeset/94145
        http://trac.webkit.org/changeset/94148
        https://bugs.webkit.org/show_bug.cgi?id=67262

        Broke isindex element (Requested by rniwa on #webkit).

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::setAutofilled):
        (DumpRenderTreeSupportGtk::setValueForUser):

rniwa@webkit.org's avatar
rniwa@webkit.org committed
35 36 37 38 39 40 41 42
2011-08-30  Ryosuke Niwa  <rniwa@webkit.org>

        GTK build fix after r94142.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::setAutofilled):
        (DumpRenderTreeSupportGtk::setValueForUser):

43 44 45 46 47 48 49 50 51 52 53
2011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>

        The unused ScrollView* argument can and should be removed from
        scrollRectIntoView.
        https://bugs.webkit.org/show_bug.cgi?id=67117

        Reviewed by Darin Adler.

        * WebCoreSupport/ChromeClientGtk.h:
        (WebKit::ChromeClient::scrollRectIntoView):

54 55 56 57 58 59
2011-08-26  Gustavo Noronha Silva  <gns@gnome.org>

        Minor style fix in the sample code for WebKitWebFrame.

        * webkit/webkitwebframe.cpp:

60 61 62 63 64 65 66 67 68 69 70
2011-08-17  Alejandro G. Castro  <alex@igalia.com>

        [GTK] Fix compilation problems with deprecations in gtk+
        https://bugs.webkit.org/show_bug.cgi?id=66073

        Reviewed by Martin Robinson.

        * WebCoreSupport/FullscreenVideoController.cpp:
        (FullscreenVideoController::createHud): Added gtk_box_new
        conditional compilation for gtk+-3.

71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87
2011-08-18  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        [GTK] Change webview API tests to use "load-status" signal instead of "load-progress"
        https://bugs.webkit.org/show_bug.cgi?id=66243

        Reviewed by Martin Robinson.

        The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
        call it only when the "load-status" change.

        This change is important in the context of bug 28851, which aims to change the
        order in which "progress finished" and "load finished" callbacks are called. In
        this new scenario, at the progress callback the load will never be finished.

        * tests/testwebview.c:
        (test_webkit_web_view_grab_focus):

88 89 90 91 92 93 94 95 96 97 98 99 100
2011-08-17  Adam Roben  <aroben@apple.com>

        Make WebCore keep track of the current device scale factor

        Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
        device scale factor

        Reviewed by Darin Adler.

        * WebCoreSupport/ChromeClientGtk.cpp:
        * WebCoreSupport/ChromeClientGtk.h:
        Removed deviceScaleFactor.

101 102 103 104 105 106 107 108
2011-08-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>

        Add javascriptcoregtk to the introspection build, to fix it.

        Reviewed by Xan Lopez.

        * GNUmakefile.am:

109 110 111 112 113 114 115 116 117 118 119
2011-08-15  Dmitry Titov  <dimich@chromium.org>

        FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
        https://bugs.webkit.org/show_bug.cgi?id=66165

        Reviewed by Darin Fisher.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::transferLoadingResourceFromPage):
        * WebCoreSupport/FrameLoaderClientGtk.h:

120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136
2011-08-10  Adam Roben  <aroben@apple.com>

        Clear up scale factor terminology

        WebKit by and large deals with two scale factors: one intrinsic to the device on which the
        software is running, and one that is per-Page and can be controlled via API calls. This
        patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
        code use those names. It should introduce no behavior changes.

        Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
        device scale factor

        Reviewed by Simon Fraser.

        * WebCoreSupport/ChromeClientGtk.cpp:
        * WebCoreSupport/ChromeClientGtk.h:

137 138 139 140 141 142 143 144
2011-08-11  Gustavo Noronha Silva  <gns@gnome.org>

        Add the javascript core dynamic library for gtk-doc's introspection helper.

        Reviewed by Xan Lopez.

        * docs/GNUmakefile.am:

145 146 147 148 149 150 151 152
2011-08-11  Xan Lopez  <xlopez@igalia.com>

        [GTK] Update NEWS and configure.ac for 1.5.2 release

        Reviewed by Gustavo Noronha.

        * NEWS: update for release.

153 154 155 156 157 158 159 160 161
2011-08-10  Gustavo Noronha Silva  <gns@gnome.org>

        [GTK] wrong annotation for the return value of webkit_web_view_get_hit_test_results()
        https://bugs.webkit.org/show_bug.cgi?id=65985

        Reviewed by Xan Lopez.

        * webkit/webkitwebview.cpp:

162 163 164 165 166 167 168 169 170 171
2011-08-03  Pavel Feldman  <pfeldman@google.com>

        Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
        https://bugs.webkit.org/show_bug.cgi?id=65510

        Reviewed by Yury Semikhatsky.

        * webkit/webkitwebview.cpp:
        (paintWebView):

172 173 174 175 176 177 178 179 180 181 182
2011-08-03  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: remove Node parameter from the InspectorClient::highlight
        https://bugs.webkit.org/show_bug.cgi?id=65549

        Reviewed by Yury Semikhatsky.

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::highlight):
        * WebCoreSupport/InspectorClientGtk.h:

183 184 185 186 187 188 189 190 191
2011-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Reorganize pkg-config files
        https://bugs.webkit.org/show_bug.cgi?id=65548

        Reviewed by Martin Robinson.

        * GNUmakefile.am: Remove javascriptcore pc file references.

192 193 194 195 196 197 198 199 200 201 202
2011-07-30  Patrick Gansterer  <paroga@webkit.org>

        Remove inclusion of MainThread.h from Threading.h
        https://bugs.webkit.org/show_bug.cgi?id=65081

        Reviewed by Darin Adler.

        Add missing include statements for MainThread.

        * webkit/webkitglobals.cpp:

203 204 205 206 207 208 209 210 211 212 213
2011-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>

        Add support for download='filename' attribute in anchors.
        https://bugs.webkit.org/show_bug.cgi?id=64580

        Reviewed by Adam Barth.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::startDownload):
        * WebCoreSupport/FrameLoaderClientGtk.h:

214 215 216 217 218 219 220 221 222 223 224 225 226
2011-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Remove header webkitwebviewcommon.h
        https://bugs.webkit.org/show_bug.cgi?id=65177

        Reviewed by Martin Robinson.

        Move webkitwebviewcommon.h contents back to webkitwebview.h.

        * GNUmakefile.am: Remove webkitwebviewcommon.h
        * webkit/webkitwebview.h:
        * webkit/webkitwebviewcommon.h: Removed.

227 228 229 230 231 232 233 234 235 236 237 238 239 240
2011-06-07  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
        https://bugs.webkit.org/show_bug.cgi?id=62252

        Added an undocumented self-scrolling property to WebKitWebView which
        communicates to WebCore whether or not this widget is expected to draw
        its own main frame scrollbars or not.

        * webkit/webkitwebview.cpp: Add the self-scrolling property.
        * webkit/webkitwebviewprivate.h: Add the selfScrolling private member.

241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271
2011-07-11  Gustavo Noronha Silva  <gns@gnome.org>

        [GTK] Google Calendar thinks we're mobile
        https://bugs.webkit.org/show_bug.cgi?id=63994

        Reviewed by Xan Lopez.

        Further special-case Google Calendar, for it thinks WebKit+Linux
        means mobile, so we also have to spoof the OS.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::userAgent): use the new WebKitGTK+
        private API that centralizes the logic now.
        * tests/testwebsettings.c: Add tests to make sure the Google
        special-cases only apply for the expected domains and when quirks
        special-casing is enabled.
        (test_non_quirky_user_agents):
        (test_webkit_web_settings_user_agent):
        * webkit/webkitwebsettings.cpp:
        (webkitUserAgent): make it static.
        (safariUserAgent): returns a fake Safari in Mac OS X User-Agent.
        (initializeDomainsList): moved from FrameLoaderClientGtk.
        (isGoogleDomain):ditto.
        (isGoogleCalendar): ditto.
        (userAgentForURL): ditto.
        (webkitWebSettingsUserAgentForUri): centralize the whole
        user agent spoofing logic in this new private API that can be used
        by the browser to know what's going to happen for a specific URI
        and also allows our API testing.
        * webkit/webkitwebsettingsprivate.h:

272 273 274 275 276 277 278 279 280 281 282
2011-07-15  Dan Bernstein  <mitz@apple.com>

        REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
        https://bugs.webkit.org/show_bug.cgi?id=64615

        Reviewed by Anders Carlsson.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.
        * WebCoreSupport/ChromeClientGtk.h:

283 284 285 286 287 288 289 290 291
2011-07-15  Martin Robinson  <mrobinson@igalia.com>

        Build fixes for WebKit2. Ensure that all generated sources are
        on nodist primaries, that they are on forward declared variables
        so that BUILT_SOURCES is calculated properly and that zlib is 
        included during linking (for WOFF support).

        * GNUmakefile.am:

292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309
2011-07-14  Lukasz Slachciak  <l.slachciak@samsung.com>

        Reviewed by Gustavo Noronha.

        [GTK] Fix GTK unit tests failures when WebKit is build outside repository directory.
        https://bugs.webkit.org/show_bug.cgi?id=62935

        WebKit can be build with WEBKITOUTPUTDIR env variable set using build-webkit script.
        In this case WEBKITOUTPUDIR may be outside repository structure. This causes testmimehandling and testwebview
        to fail because they use external test files in WebKit Source directory.
        This bug fixes this issue introducing optional environment variable WEBKITREPODIR
        Also coding style in existing functions is fixed.


        * tests/test_utils.c: Coding style fixes.
        (testutils_relative_chdir): If WEBKITREPODIR is set, change current directory to it.
        * tests/test_utils.h: Coding style fixes.

310 311 312 313 314 315 316 317 318 319 320
2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>

        ApplicationCache update should not immediately fail when reaching per-origin quota
        https://bugs.webkit.org/show_bug.cgi?id=64177

        Reviewed by Alexey Proskuryakov.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::reachedApplicationCacheOriginQuota):
        * WebCoreSupport/ChromeClientGtk.h:

321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340
2011-06-14  Mike Stegeman  <mrstegeman@gmail.com>

        Add API to WebKit-GTK to allow setting localStorage database path
        https://bugs.webkit.org/show_bug.cgi?id=62091

        Reviewed by Martin Robinson and Gustavo Noronha.

        Expose the path of the localStorage databases through a setting
        to allow HTML5 localStorage to be persistent. New setting is:
        html5-local-storage-database-path

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        * webkit/webkitwebsettingsprivate.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):
        (webkit_web_view_settings_notify):

341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360
2011-07-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>

        [GTK] testwebview API test fails after http://trac.webkit.org/changeset/90471
        https://bugs.webkit.org/show_bug.cgi?id=64159

        Rework the icon-uri change test so that the condition for quitting
        the mainloop is the icon-uri change itself, along with a timeout
        to avoid taking too long in case of failure. Since the conditions
        for considering a page loaded were changed we can't rely on that
        for this test anymore.

        Reviewed by Xan Lopez.

        * tests/testwebview.c:
        (timeout_cb): error out if it takes too long for the icon-uri
        change to happen.
        (icon_uri_changed_cb): quit the loop here instead of waiting on
        the page being loaded.
        (test_webkit_web_view_icon_uri):

361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391
2011-07-01  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Add DeviceOrientation feature
        https://bugs.webkit.org/show_bug.cgi?id=63720

        Add empty implementation of DeviceMotionClient and DeviceOrientationClient callback methods.

        * GNUmakefile.am:
        * WebCoreSupport/DeviceMotionClientGtk.cpp: Added.
        (WebCore::DeviceMotionClientGtk::DeviceMotionClientGtk):
        (WebCore::DeviceMotionClientGtk::~DeviceMotionClientGtk):
        (WebCore::DeviceMotionClientGtk::deviceMotionControllerDestroyed):
        (WebCore::DeviceMotionClientGtk::setController):
        (WebCore::DeviceMotionClientGtk::startUpdating):
        (WebCore::DeviceMotionClientGtk::stopUpdating):
        (WebCore::DeviceMotionClientGtk::currentDeviceMotion):
        * WebCoreSupport/DeviceMotionClientGtk.h: Added.
        * WebCoreSupport/DeviceOrientationClientGtk.cpp: Added.
        (WebCore::DeviceOrientationClientGtk::DeviceOrientationClientGtk):
        (WebCore::DeviceOrientationClientGtk::~DeviceOrientationClientGtk):
        (WebCore::DeviceOrientationClientGtk::deviceOrientationControllerDestroyed):
        (WebCore::DeviceOrientationClientGtk::setController):
        (WebCore::DeviceOrientationClientGtk::startUpdating):
        (WebCore::DeviceOrientationClientGtk::stopUpdating):
        (WebCore::DeviceOrientationClientGtk::lastOrientation):
        * WebCoreSupport/DeviceOrientationClientGtk.h: Added.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_init):

392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408
2011-06-28  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Allow to build WebKitGtk+ with accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=63404

        WebKitGtk+ needs to implement accelerated compositing for running CSS3 3D transforms 
        and animation through GPU acceleration. We could implement GraphicsLayer using Clutter.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::attachRootGraphicsLayer): not implemented yet.
        (WebKit::ChromeClient::setNeedsOneShotDrawingSynchronization): Ditto.
        (WebKit::ChromeClient::scheduleCompositingLayerSync): Ditto.
        (WebKit::ChromeClient::allowedCompositingTriggers): Ditto.
        * WebCoreSupport/ChromeClientGtk.h:

409 410 411 412 413 414 415 416 417 418 419 420
2011-06-27  ChangSeok Oh  <shivamidow@gmail.com>

        Reviewed by Martin Robinson.

        [GTK] Fix build break to support webgl
        https://bugs.webkit.org/show_bug.cgi?id=63425

        A member variable enableWebGL in WebKitWebSettingsPrivate is changed to enableWebgl

        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):

421 422 423 424 425 426 427 428 429 430 431 432 433
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        Remove shadow-DOM related methods from GTK DRT API. These are not
        required any more.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

434 435 436 437 438 439 440 441 442 443
2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        FileChooser should be only created when we need to choose files.
        https://bugs.webkit.org/show_bug.cgi?id=63039

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::runOpenPanel): Changed to use settings.

444 445 446 447 448 449 450 451 452 453 454 455 456
2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Make sure libsoup password manager macro is defined before including libsoup in webkitsoupauthdialog
        https://bugs.webkit.org/show_bug.cgi?id=63124

        Fixes a crash when building with --enable-debug.

        * webkit/webkitsoupauthdialog.h: Define
        LIBSOUP_I_HAVE_READ_BUG_594377_AND_KNOW_SOUP_PASSWORD_MANAGER_MIGHT_GO_AWAY
        before including libsoup.h.

457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473
2011-06-10  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] webkit_web_settings_copy does not copy all settings
        https://bugs.webkit.org/show_bug.cgi?id=62424

        Instead of trying to keep webkit_web_settings_copy up to date with
        property additions, create the object copy by dynamically initializing
        all webkit_web_settings properties at once.

        * tests/testwebsettings.c:
        (test_webkit_web_settings_copy): Create a test for webkit_web_settings copy.
        (main): Run the new test.
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_copy): Dynamically initialize all properties of the copy.

474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491
2011-06-20  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Clean up unecessary boilerplate from WebKitWebSettings and make private members meet WebKit style guidelines
        https://bugs.webkit.org/show_bug.cgi?id=61972

        Rename all private members of WebKitWebSettings to meet WebKit style guidelines and
        put the private struct definition in webkitwebsettingsprivate.h so it can be
        accessed from webkitwebview.cpp. This cuts down on the boilerplate immensely.

        * webkit/webkitwebsettings.cpp: Rename private members to meet WebKit style guidelines
        and allocate the private section with new/delete. This allows for using CString and removes
        the need for manual string memory management.
        * webkit/webkitwebsettingsprivate.h: Move the private struct definition here.
        * webkit/webkitwebview.cpp: Update to reflect new struct names. Remove boilerplate
        and other very small code cleanups.

492 493 494 495 496 497 498 499 500
2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Split libWebCore into two libWebCore and libWebCoreGtk
        https://bugs.webkit.org/show_bug.cgi?id=60539

        * GNUmakefile.am: Link to libWebCoreGtk.la too.

501 502 503 504 505 506 507 508 509 510 511
2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Separate concerns of loading file icons and choosing files.
        https://bugs.webkit.org/show_bug.cgi?id=62931

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::loadIconForFiles): Renamed.
        * WebCoreSupport/ChromeClientGtk.h:

512 513 514 515 516 517 518 519 520 521 522 523 524 525
2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Replace GdkRectangle by cairo_rectangle_int_t
        https://bugs.webkit.org/show_bug.cgi?id=60687

        Replace GdkRectangle by cairo_rectangle_int_t.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
        (DumpRenderTreeSupportGtk::firstRectForCharacterRange):
        (DumpRenderTreeSupportGtk::rectangleForSelection):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h: Ditto.

526 527 528 529 530 531 532 533 534 535 536 537 538
2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89026.
        http://trac.webkit.org/changeset/89026
        https://bugs.webkit.org/show_bug.cgi?id=62804

        These patches were likely correct.  I'll investigate the
        browser_test failures. (Requested by abarth on #webkit).

        * WebCoreSupport/FullscreenVideoController.cpp:
        (FullscreenVideoController::play):
        (FullscreenVideoController::pause):

539 540 541 542 543 544 545 546
2011-06-16  Vitaly Repeshko  <vitalyr@chromium.org>

        Unreviewed.

        Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
        https://bugs.webkit.org/show_bug.cgi?id=62796

        The patches broke chromium browser tests.
547 548 549 550 551 552 553 554 555 556 557
2011-06-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove HTMLVideoElement::processingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=62784

        * WebCoreSupport/FullscreenVideoController.cpp:
        (FullscreenVideoController::play):
        (FullscreenVideoController::pause):

558 559 560 561 562 563 564 565 566 567
2011-06-15  Claudio Saavedra  <csaavedra@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Fix the build with introspection enabled
        https://bugs.webkit.org/show_bug.cgi?id=62705

        * GNUmakefile.am: Remove include of *.c files, since
        there are no such files anymore.

568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638
2011-06-14  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Remove G_CONST_RETURN usage
        https://bugs.webkit.org/show_bug.cgi?id=62673

        Change G_CONST_RETURN for a simple "const" throughout the
        codebase, since G_CONST_RETURN is deprecated now. This should be
        totally equivalent since for all practical purposes the macro is
        always expanded to const.

        * webkit/webkitapplicationcache.cpp:
        (webkit_application_cache_get_database_directory_path): use const
        instead of G_CONST_RETURN.
        * webkit/webkitapplicationcache.h:
        * webkit/webkiticondatabase.cpp:
        (webkit_icon_database_get_path): ditto.
        * webkit/webkiticondatabase.h:
        * webkit/webkitnetworkrequest.cpp:
        (webkit_network_request_get_uri): ditto.
        * webkit/webkitnetworkrequest.h:
        * webkit/webkitnetworkresponse.cpp:
        (webkit_network_response_get_uri): ditto.
        * webkit/webkitnetworkresponse.h:
        * webkit/webkitsecurityorigin.cpp:
        (webkit_security_origin_get_protocol): ditto.
        (webkit_security_origin_get_host): ditto.
        * webkit/webkitsecurityorigin.h:
        * webkit/webkitwebdatabase.cpp:
        (webkit_web_database_get_name): ditto.
        (webkit_web_database_get_display_name): ditto.
        (webkit_web_database_get_filename): ditto.
        (webkit_get_web_database_directory_path): ditto.
        * webkit/webkitwebdatabase.h:
        * webkit/webkitwebdatasource.cpp:
        (webkit_web_data_source_get_encoding): ditto.
        (webkit_web_data_source_get_unreachable_uri): ditto.
        * webkit/webkitwebdatasource.h:
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_get_title): ditto.
        (webkit_web_frame_get_uri): ditto.
        (webkit_web_frame_get_name): ditto.
        * webkit/webkitwebframe.h:
        * webkit/webkitwebhistoryitem.cpp:
        (webkit_web_history_item_get_title): ditto.
        (webkit_web_history_item_get_alternate_title): ditto.
        (webkit_web_history_item_get_uri): ditto.
        (webkit_web_history_item_get_original_uri): ditto.
        (webkit_web_history_item_get_target): ditto.
        * webkit/webkitwebhistoryitem.h:
        * webkit/webkitwebhistoryitemprivate.h:
        * webkit/webkitwebnavigationaction.cpp:
        (webkit_web_navigation_action_get_target_frame): ditto.
        * webkit/webkitwebnavigationaction.h:
        * webkit/webkitwebresource.cpp:
        (webkit_web_resource_get_uri): ditto.
        (webkit_web_resource_get_mime_type): ditto.
        (webkit_web_resource_get_encoding): ditto.
        (webkit_web_resource_get_frame_name): ditto.
        * webkit/webkitwebresource.h:
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_get_user_agent): ditto.
        * webkit/webkitwebsettings.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_title): ditto.
        (webkit_web_view_get_uri): ditto.
        (webkit_web_view_get_icon_uri): ditto.
        * webkit/webkitwebview.h:
        * webkit/webkitwebviewcommon.h:

639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658
2011-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
        https://bugs.webkit.org/show_bug.cgi?id=62626

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::windowToScreen): Update to use
        convertWidgetPointToScreenPoint()
        (WebKit::ChromeClient::screenToWindow): Ditto.
        * webkit/webkitwebview.cpp: Remove globalPointForClientPoint()
        since it does the same than convertWidgetPointToScreenPoint().
        (webkit_web_view_popup_menu_handler): Use
        convertWidgetPointToScreenPoint() instead of globalPointForClientPoint().
        (doDragLeaveLater): Ditto.
        (webkit_web_view_drag_motion): Ditto.
        (webkit_web_view_drag_data_received): Ditto.
        (webkit_web_view_drag_drop): Ditto.

659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682
2011-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Support authentication dialogs in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=62366

        Move the common code of webkitsoupauthdialog to a common C++ class
        in WebCore so that it can be used by WebKit2 too. The file has
        been converted into a C++ file.

        * GNUmakefile.am: Rename webkitsoupauthdialog.c to
        webkitsoupauthdialog.cpp.
        * webkit/webkitsoupauthdialog.c: Removed.
        * webkit/webkitsoupauthdialog.cpp: Added.
        (webkit_soup_auth_dialog_class_init):
        (webkit_soup_auth_dialog_init):
        (webkit_soup_auth_dialog_session_feature_init):
        (sessionAuthenticate): Use GtkAuthenticationDialog object from
        WebCore.
        (attach):
        (detach):
        * webkit/webkitsoupauthdialog.h:

683 684 685 686 687 688 689 690 691 692 693
2011-06-13  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Add configure option to enable/disable register protocol handler
        https://bugs.webkit.org/show_bug.cgi?id=62534

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::registerProtocolHandler): Added.
        * WebCoreSupport/ChromeClientGtk.h: Add the registerProtocolHandler method defintion.

694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711
2011-06-13  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        Update gtkdoc files and inline documentation to reduce gtkdoc errors
        and ensure complete documentation output.

        * docs/webkitgtk-sections.txt: Add missing sections to the list and remove
        unneeded sections.
        * docs/webkitgtk.types: Update the types list.
        * webkit/webkithittestresult.cpp: Fix inline documentation errors.
        (webkit_hit_test_result_class_init): Ditto.
        * webkit/webkiticondatabase.cpp: Ditto.
        * webkit/webkitwebsettings.cpp: Ditto.
        (webkit_web_settings_class_init): Ditto.
        * webkit/webkitwebview.cpp: Ditto.
        (webkit_web_view_class_init): Ditto.

712 713 714 715 716 717 718 719 720
2011-06-13  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        Update the list of ignored GTK+ header files for the documentation
        generation.

        * docs/GNUmakefile.am: Update ignored header list.

721 722 723 724 725 726 727 728
2011-06-13  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Update NEWS for 1.5.1 release.

        * NEWS: update.

xan@webkit.org's avatar
xan@webkit.org committed
729 730 731 732 733 734 735 736
2011-06-13  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Distcheck fixes.

        * GNUmakefile.am:

737 738 739 740 741 742 743 744 745 746 747 748
2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Export an API similar to WebKit1
        https://bugs.webkit.org/show_bug.cgi?id=57820

        * GNUmakefile.am: Add webkitwebviewcommon.h to public header list.
        * webkit/webkitwebview.h: Move declarations common to WebKit2 to
        webkitwebviewcommon.h.
        * webkit/webkitwebviewcommon.h: Added.

749 750 751 752 753 754 755 756 757 758 759
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
        * WebCoreSupport/FrameLoaderClientGtk.h:

760 761 762 763 764 765 766 767 768 769 770 771 772
2011-06-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Remove webkit_web_view_get_selected_text
        https://bugs.webkit.org/show_bug.cgi?id=62512

        It's no longer used and it's a private method, so it can be
        removed.

        * webkit/webkitwebview.cpp: kill it.
        * webkit/webkitwebviewprivate.h: ditto.

773 774 775 776 777 778 779 780 781 782 783 784 785 786
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Remove trival "forward-to-client" member functions from FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=62510

        Update to call the FrameLoaderClient directly.  Also, remove cargo-cult
        code that checks whether FrameLoader is null.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_stop_loading):
        (webkit_web_view_can_show_mime_type):

787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806
2011-06-09  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
        https://bugs.webkit.org/show_bug.cgi?id=55603

        Added DumpRenderTreeSupport methods to support hasMarkedText and markedRange.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::setComposition): Use start and length rather than start and
        end. This matches other ports. Only use GLib style early returns when checking the
        validity of GObjects.
        (DumpRenderTreeSupportGtk::hasComposition):  Added.
        (DumpRenderTreeSupportGtk::compositionRange): Added.
        (DumpRenderTreeSupportGtk::confirmComposition): Cleanup as described above.
        (DumpRenderTreeSupportGtk::firstRectForCharacterRange): Cleanup as described above.
        (DumpRenderTreeSupportGtk::selectedRange): Cleanup as described above.
        * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added new declarations.

807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849
2011-06-08  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add WebKitSpellChecker interface and implementations
        https://bugs.webkit.org/show_bug.cgi?id=61787

        Expose the spell checking functionality to the UAs through a
        generic interface, and provide a default Enchant-based
        implementation. On top of allowing UAs to use this functionality
        this makes it possible to change the spell checking backend at
        runtime.

        * GNUmakefile.am: add new files.
        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::EditorClient): set the spell checker using
        the new classes.
        * WebCoreSupport/TextCheckerClientEnchant.cpp: Removed.
        * WebCoreSupport/TextCheckerClientGtk.cpp: Added
        (WebKit::TextCheckerClientGtk::TextCheckerClientGtk): just
        chain up to the WebKitSpellChecker.
        (WebKit::TextCheckerClientGtk::~TextCheckerClientGtk): ditto.
        (WebKit::TextCheckerClientGtk::ignoreWordInSpellDocument): ditto.
        (WebKit::TextCheckerClientGtk::learnWord): ditto.
        (WebKit::TextCheckerClientGtk::checkSpellingOfString): ditto.
        (WebKit::TextCheckerClientGtk::getAutoCorrectSuggestionForMisspelledWord): ditto.
        (WebKit::TextCheckerClientGtk::getGuessesForWord): ditto.
        (WebKit::TextCheckerClientGtk::updateSpellCheckingLanguage): ditto.
        * WebCoreSupport/TextCheckerClientGtk.h: store a reference to
        the WebKitSpellChecker.
        * webkit/webkit.h: the webkitspellchecker.h header is public.
        * webkit/webkitdefines.h: defines for spell checker interface.
        * webkit/webkitglobals.cpp: Add APIs to get and set the global
        spell checker.
        (webkit_get_spell_checker): get API.
        (webkit_set_spell_checker): set API.
        * webkit/webkitglobals.h:
        * webkit/webkitspellchecker.cpp: Added. Spell checking interface.
        * webkit/webkitspellchecker.h: Added.
        * webkit/webkitspellcheckerenchant.cpp: Added. Default
        implemention, uses Enchant library.
        * webkit/webkitspellcheckerenchant.h: Added.

850 851 852 853 854 855 856 857 858
2011-06-07  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] "webkithittestresult.h" is malformed
        https://bugs.webkit.org/show_bug.cgi?id=62117

        * webkit/webkithittestresult.h: fix typo in GET_CLASS macro.

859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880
2011-05-31  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Ryosuke Niwa.

        [GTK] Support smart replace for the pasteboard
        https://bugs.webkit.org/show_bug.cgi?id=61734

        Add the EditorClient and DumpRenderTreeSupportGtk hooks for enabling
        smart replace in the tests.

        * WebCoreSupport/DragClientGtk.cpp:
        (WebKit::DragClient::startDrag): targeListForDataObject now takes another
        parameter determining whether or not to add smart paste support. Add it here.
        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::setSmartInsertDeleteEnabled): Added.
        * WebCoreSupport/DumpRenderTreeSupportGtk.h: Add new method definition.
        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::toggleSmartInsertDelete): Added implementation.
        (WebKit::EditorClient::smartInsertDeleteEnabled): Added.
        (WebKit::EditorClient::EditorClient):
        * WebCoreSupport/EditorClientGtk.h: Add new method definition.

881 882 883 884 885 886 887 888 889 890 891 892 893 894
2011-06-03  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Unref the SoupSession used by WebKitGtk+ at exit
        https://bugs.webkit.org/show_bug.cgi?id=60165

        WebKitGtk+ creates a SoupSession instance to handle network stuff
        that is never freed. We should unref that object at exit time.

        * webkit/webkitglobals.cpp:
        (webkitExit):
        (webkitInit):

895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926
2011-05-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Remove PastboardHelperGtk
        https://bugs.webkit.org/show_bug.cgi?id=61690

        Remove PasteboardHelperGtk and talk directly to WebCore for pasteboard
        activity. This change moves the PasteboardHelper singleton from WebKit
        to WebCore.

        * GNUmakefile.am: Remove PasteboardHelperGtk from the source list.
        * WebCoreSupport/AssertMatchingEnums.cpp: Added assertions verifying that the
        WebCore versions of the GtkClipboard enums match those in the WebKit API.
        * WebCoreSupport/DragClientGtk.cpp:
        (WebKit::DragClient::startDrag): Access the pasteboard helper via a static method.
        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::setSelectionPrimaryClipboardIfNeeded): Ditto. Call into the helper to specify
        that the current clipboard is selection primary now.
        * WebCoreSupport/PasteboardHelperGtk.cpp: Removed.
        * webkit/webkitglobals.cpp: Remove function to set and get the pasteboard helper.
        * webkit/webkitglobalsprivate.h: Ditto.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_button_press_event): Access the pasteboard helper via a static method.
        (webkit_web_view_drag_data_get): Ditto.
        (webkit_web_view_drag_motion): Ditto.
        (webkit_web_view_drag_data_received): Ditto.
        (webkit_web_view_init): Ditto.
        (webkit_web_view_get_copy_target_list): Ditto.
        (webkit_web_view_get_paste_target_list): Ditto.
        * webkit/webkitwebviewprivate.h: Ditto.

927 928 929 930 931 932 933 934 935 936 937 938 939
2011-06-02  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Only load dictionaries if spell check is enabled
        https://bugs.webkit.org/show_bug.cgi?id=32879

        We don't need to call enchant if enable-spell-checking is false.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings): Skip loading dictionaries when enable-spell-checking is false. 
        (webkit_web_view_settings_notify): Ditto.

940 941 942 943 944 945 946 947 948 949
2011-06-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Explictly request the size of a pointer in malloc. Otherwise this
        explodes in 64bit architectures, at least.

        * webkit/webkitwebplugin.cpp:
        (webkit_web_plugin_get_mimetypes): ditto.

950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966
2011-06-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Utility methods for UA spellchecking
        https://bugs.webkit.org/show_bug.cgi?id=61788

        Adds a couple of utility methods needed to implement some aspects
        of spell checking support in a browser.

        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_replace_selection): method to replace the current
        selection with a string of text.
        (webkit_web_frame_get_range_for_word_around_caret): returns the DOM
        range for the word where the caret/selection currently is.
        * webkit/webkitwebframe.h: declare new methods.

967 968 969 970 971 972 973 974 975 976
2011-05-31  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] gtkdoc run produces many warnings about missing declarations
        https://bugs.webkit.org/show_bug.cgi?id=61797

        * docs/webkitgtk-sections.txt: Remove inexistent symbols from this file
        to reduce the number of gtkdoc warnings.

977 978 979 980 981 982 983 984 985
2011-05-31  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Provide custom DOM bindings methods to check if input/textareas have been edited
        https://bugs.webkit.org/show_bug.cgi?id=61791

        * GNUmakefile.am: add new files.

986 987 988 989 990 991 992 993 994
2011-05-27  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Data directory is webkitgtk-x.y not webkit-x.y
        https://bugs.webkit.org/show_bug.cgi?id=61642

        * GNUmakefile.am: updated data directory.

995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011
2011-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Audit all uses of KURL::prettyURL
        https://bugs.webkit.org/show_bug.cgi?id=61201

        Update callers of prettyURL to just call string.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::mouseDidMoveOverElement):
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
        (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_icon_uri):

1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023
2011-05-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>

        Reviewed by Martin Robinson.

        Cleanup postCommitFrameViewSetup parameters which are no longer
        necessary after the adjustments handling refactoring.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::postCommitFrameViewSetup):
        (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame):
        (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):

1024 1025 1026 1027 1028 1029
2011-05-22  Adam Barth  <abarth@webkit.org>

        Build fix.  More public destructors needed to play nice with OwnPtr.

        * WebCoreSupport/InspectorClientGtk.cpp:

1030 1031 1032 1033 1034 1035 1036
2011-05-22  Adam Barth  <abarth@webkit.org>

        Build fix.  InspectorFrontendClient needs a public destructor so that
        we can properly track ownership using OwnPtr.

        * WebCoreSupport/InspectorClientGtk.h:

1037 1038 1039 1040 1041 1042 1043 1044
2011-05-22  Adam Barth  <abarth@webkit.org>

        Strict PassOwnPtr build fix.

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::openInspectorFrontend):
        (WebKit::InspectorFrontendClient::InspectorFrontendClient):

1045 1046 1047 1048 1049 1050 1051
2011-05-22  Adam Barth  <abarth@webkit.org>

        Strict PassOwnPtr build fix.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::addUserStyleSheet):

1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063
2011-05-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        numberOfActiveAnimations() can include animations from documents in the page cache
        https://bugs.webkit.org/show_bug.cgi?id=53641

        Pass the Frame's document as the one to count animations on.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::numberOfActiveAnimations):

1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079
2011-05-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Scrolling in Twitter is broken after r86102
        https://bugs.webkit.org/show_bug.cgi?id=60922

        Fix adjustment handling for pages that trigger the slow scrolling path.
        The slow scrolling path is triggered by WebCore when it determines that
        doing a simple invalidation is quicker than doing a normal scroll. This
        typically happens when there are large elements with fixed positions.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::invalidateContentsForSlowScroll): Poke the adjustment
        watcher to update its adjustments when a page triggers the slow scrolling path.

1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090
2011-05-13  Jon Lee  <jonlee@apple.com>

        Reviewed by Simon Fraser.

        Can't horizontally scroll iframes and overflow because wheel events are always accepted
        https://bugs.webkit.org/show_bug.cgi?id=60779

        * WebCoreSupport/ChromeClientGtk.h:
        (WebKit::ChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
        (WebKit::ChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method

1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102
2011-05-13  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Prune #includes from FrameView.h (Part 2)
        https://bugs.webkit.org/show_bug.cgi?id=60748

        - Update files that were depending on FrameView.h #including Frame.h or
          Page.h.

        * WebCoreSupport/GtkAdjustmentWatcher.cpp:

1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119
2011-05-13  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59765

        Use the new KeyBindingTranslator class from WebCore/platform/gtk. With this utility
        class we can now share the code with WebKit2.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::executePendingEditorCommands): Updated to reflect the fact that
        the command vector now contains WTF::string.
        (WebKit::EditorClient::handleKeyboardEvent): Use the new helper utility class.
        (WebKit::EditorClient::EditorClient): 
        * WebCoreSupport/EditorClientGtk.h: Remove unnecessary member. Add the utility class.

1120 1121 1122 1123 1124 1125 1126 1127
2011-05-12  Martin Robinson  <mrobinson@igalia.com>

        Attempt to fix the GTK+ unit test testwebview on the 32-bit Release
        bot which appears to be more sensitive to timing issues than the
        other bots.

        * tests/testwebview.c: Add another short pause waiting for adjustments to update.

1128 1129 1130 1131 1132 1133 1134 1135 1136
2011-05-09  Martin Robinson  <mrobinson@igalia.com>

        Fix a test after r86102. Scrollbars update asynchronously, so we
        must check the adjustments after a short delay.

        * tests/testwebview.c:
        (quit_after_short_delay_cb): Add a short delay before checking adjustments.
        (test_webkit_web_view_grab_focus): Ditto.

1137 1138 1139 1140 1141 1142 1143 1144 1145
2011-05-09  Xan Lopez  <xlopez@igalia.com>

        Unreviewed build fix.

        Fix build, for real.

        * webkit/webkitwebview.cpp:
        (getHorizontalAdjustment):

1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156
2011-05-09  Xan Lopez  <xlopez@igalia.com>

        Unreviewed build fix..

        Fix GTK+3.x build.

        * webkit/webkitwebview.cpp:
        (getHorizontalAdjustment): the adjustment is in
        adjustmentWatcher() now.
        (getVerticalAdjustment): ditto.

1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205
2011-04-29  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Untangle GtkAdjustments from WebCore
        https://bugs.webkit.org/show_bug.cgi?id=59821

        Have ChromeClient manage the GtkAdjustments of the parent widget instead of passing
        them to WebCore to manage. This simplifies the code quite a bit and should be less
        crash prone in the future.

        * GNUmakefile.am: Added new GtkAdjustmentWatcher class to the sources list.
        * WebCoreSupport/ChromeClientGtk.cpp: Added new GtkAdjustmentWatcher member.
        (WebKit::ChromeClient::ChromeClient) Initialize the new member.
        (WebKit::ChromeClient::scroll): Poke the adjustment watcher to update the adjustments.
        (WebKit::ChromeClient::contentsSizeChanged): Ditto.
        (WebKit::ChromeClient::scrollbarsModeDidChange): This may now be called at a time when there
        is no main frame, so do an early return in that case.
        * WebCoreSupport/ChromeClientGtk.h: Add the new member.
        (WebKit::ChromeClient::adjustmentWatcher): Add this getter for WebKitWebView.
        * WebCoreSupport/FrameLoaderClientGtk.cpp: Remove calls which pushed the adjustments into
        WebCore.
        (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame):
        (WebKit::postCommitFrameViewSetup):
        * WebCoreSupport/GtkAdjustmentWatcher.cpp: Added.
        (WebKit::GtkAdjustmentWatcher::GtkAdjustmentWatcher):
        (WebKit::updateAdjustmentFromScrollbar):
        (WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbars):
        (WebKit::updateAdjustmentCallback):
        (WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater):
        (WebKit::adjustmentValueChangedCallback):
        (WebKit::setAdjustment):
        (WebKit::GtkAdjustmentWatcher::setHorizontalAdjustment):
        (WebKit::GtkAdjustmentWatcher::setVerticalAdjustment):
        (WebKit::GtkAdjustmentWatcher::adjustmentValueChanged):
        * WebCoreSupport/GtkAdjustmentWatcher.h: Added.
        (WebKit::GtkAdjustmentWatcher::horizontalAdjustment):
        (WebKit::GtkAdjustmentWatcher::verticalAdjustment):
        * webkit/webkitwebview.cpp:
        (setHorizontalAdjustment):
        (setVerticalAdjustment): Remove the adjustment member. Call into the adjustment watcher.
        (getHorizontalAdjustment): Ditto.
        (getVerticalAdjustment): Ditto.
        (webkit_web_view_size_allocate): Ditto.
        (webkit_web_view_set_scroll_adjustments): Ditto.
        (webkit_web_view_dispose): Ditto.
        (webkit_web_view_init): Ditto.
        * webkit/webkitwebviewprivate.h: Ditto.

1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217
2011-05-06  Kent Tamura  <tkent@chromium.org>

        Reviewed by Ryosuke Niwa.

        Eliminate WebCore/dom/InputElement.{cpp,h}
        https://bugs.webkit.org/show_bug.cgi?id=60262

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::setAutofilled):
          Follow the return type change of Node::toInputElement().
        (DumpRenderTreeSupportGtk::setValueForUser): ditto.

1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231
2011-05-06  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] [WebKit2] WebView::windowToScreen needs an implementation
        https://bugs.webkit.org/show_bug.cgi?id=55960

        Abstract the code to translate from widget space to screen space into
        a helper method in WebCore.

        * WebCoreSupport/ChromeClientGtk.cpp: Use the new helper method from GtkUtilities.
        (WebKit::ChromeClient::windowToScreen):
        (WebKit::ChromeClient::screenToWindow):

philn@webkit.org's avatar
Tools:  
philn@webkit.org committed
1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242
2011-05-04  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Dimitri Glazkov.

        Implement LayoutTestController::pseudoShadowId()
        https://bugs.webkit.org/show_bug.cgi?id=60034

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::shadowPseudoId):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

1243 1244 1245 1246 1247 1248 1249 1250 1251 1252
2011-05-05  Bharathwaaj Srinivasan  <bharathwaaj.s@gmail.com>

        Reviewed by Holger Freyther.

        Fix build-webkit --minimal.
        https://bugs.webkit.org/show_bug.cgi?id=60257

        * webkit/webkitglobals.cpp:
        (webkitInit):

1253 1254 1255 1256 1257 1258 1259 1260 1261 1262
2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Rename SelectionController to FrameSelection
        https://bugs.webkit.org/show_bug.cgi?id=60234

        * webkit/webkitwebview.cpp:
        (getLocationForKeyboardGeneratedContextMenu):

1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274
2011-05-04  Ryosuke Niwa  <rniwa@webkit.org>

        GTK build fix attempt after r85823

        * WebCoreSupport/ChromeClientGtk.h:
        (WebKit::ChromeClient::webView):
        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::imContextCommitted):
        (WebKit::imContextPreeditChanged):
        * webkit/webkitwebview.cpp:
        (WebKit::kit):

1275 1276 1277 1278 1279 1280 1281 1282 1283 1284
2011-05-04  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Expose WebView directly through ChromeClient.
        https://bugs.webkit.org/show_bug.cgi?id=49902

        * WebCoreSupport/ChromeClientGtk.h:
        (WebKit::ChromeClient::webView):

1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297
2011-05-04  Tao Bai  <michaelbai@chromium.org>

        Reviewed by David Kilzer.

        Populate touch-icon url to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=59143

        Respect the interface change in FrameLoaderClient.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidChangeIcons):
        * WebCoreSupport/FrameLoaderClientGtk.h:

1298 1299 1300 1301 1302 1303 1304 1305 1306
2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Dimitri Glazkov.

        Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
        https://bugs.webkit.org/show_bug.cgi?id=58703

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Added #include for ShadowRoot.h.

1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326
2011-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk+] Crash when navigating back
        https://bugs.webkit.org/show_bug.cgi?id=59799

        The innerNode management in WebKitHitTestResult was relying on the
        old DOM bindings behavior where every DOM objects had to be
        disposed by the caller. Now the objects are garbage collected by
        WebKit when either the parent frame or document dies, so this is
        not needed anymore. Update the code to simply take ownership of
        the node, which effectively correctly balances the reference
        count.

        * webkit/webkithittestresult.cpp:
        (webkit_hit_test_result_dispose): call C++ dtors in private data.
        (webkit_hit_test_result_get_property): adatp to GRefPtr API.
        (webkit_hit_test_result_init): call C++ ctors in private data.

1327 1328 1329 1330 1331 1332
2011-04-28  Xan Lopez  <xlopez@igalia.com>

        Unreviewed build fix.

        * GNUmakefile.am:

1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344
2011-04-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Split JSC and WebCore builds
        https://bugs.webkit.org/show_bug.cgi?id=19428

        Add a pkg-config file for JavaScriptCoreGTK+.

        * GNUmakefile.am: take care of the pkg-config file.
        * javascriptcoregtk.pc.in: Added.

1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356
2011-04-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Split JSC and WebCore builds
        https://bugs.webkit.org/show_bug.cgi?id=19428

        Build JavaScriptCore as a libtool shared library instead of a
        private convenience library.

        * GNUmakefile.am: adapt to new name for javascriptcore target.

1357 1358 1359 1360 1361 1362 1363 1364 1365
2011-04-28  ojab  <ojab@ojab.ru>

        Reviewed by Martin Robinson.

        Webkit-gtk build failure, no type/member 'Page' in namespace 'WebCore'
        https://bugs.webkit.org/show_bug.cgi?id=59585

        * webkit/webkitwebviewprivate.h:

1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385
2011-04-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Click counting logic should be shared between WebKit1 and WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59715

        Switch WebKit1 to use the new GtkClickCounter for counting > 3 clicks in a row.
        This allows the code to be shared between WebKit1 and WebKit2.

        * WebCoreSupport/DragClientGtk.cpp:
        (WebKit::DragClient::startDrag): Call GtkClickCounter::reset instead of fiddling
        the WebView private data directly.
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::postCommitFrameViewSetup): Ditto.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_button_press_event): Call into GtkClickCounter now.
        (webkit_web_view_init): Remove private member intialization.
        * webkit/webkitwebviewprivate.h: Remove unneeded private members.

1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399
2011-04-27  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Menulists do not follow text direction when rendering options with right-to-left text
        https://bugs.webkit.org/show_bug.cgi?id=54038

        Fix rendering of menulists that contain right-to-left text. Text direction
        inside a menulist now follows the alignment of its contents.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::selectItemWritingDirectionIsNatural): Return false instead of true.
        (WebKit::ChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Return true instead of false.

1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411
2011-04-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84987.
        http://trac.webkit.org/changeset/84987
        https://bugs.webkit.org/show_bug.cgi?id=59618

        Caused crashes on the GTK+ debug bots. (Requested by mrobinson
        on #webkit).

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::exceededDatabaseQuota):

1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425
2011-04-26  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] flaky crash  storage/open-database-set-empty-version.html
        https://bugs.webkit.org/show_bug.cgi?id=58988

        Construct the security origin directly instead of getting it from the WebKitWebFrame object.
        This prevents failing to create the WebKitSecurityOrigin in cases where the frame is in
        some inconsistent state.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::exceededDatabaseQuota): Construct the origin directly.

1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436
2011-04-22  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] fast/events/overflow-viewport-renderer-deleted.html crashes
        https://bugs.webkit.org/show_bug.cgi?id=58976

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::getInnerText): Guard against situations when the documentElement
        method of the document returns null.

1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        Remove remaining uses of deprecated version of toJS
        https://bugs.webkit.org/show_bug.cgi?id=59170

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::shadowRoot):
        (DumpRenderTreeSupportGtk::ensureShadowRoot):
        Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.

1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461
2011-04-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] DRT: implement eventSender.scalePageBy
        https://bugs.webkit.org/show_bug.cgi?id=59082

        Added support in DRT for webview scaling.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::scale):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::canCopyCut):
        (WebKit::EditorClient::canPaste):
        * WebCoreSupport/EditorClientGtk.h:

1474 1475 1476 1477 1478 1479 1480 1481 1482 1483
2011-04-21  Martin Robinson  <mrobinson@igalia.com>

        [GTK] DRT: implement eventSender.scalePageBy
        https://bugs.webkit.org/show_bug.cgi?id=59082

        Rolling out r84507 since it broke many GTK+ tests.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496
2011-04-21  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] missing LayoutTestController::callShouldCloseOnWebView()
        https://bugs.webkit.org/show_bug.cgi?id=59086

        DRT::shouldClose(), used by the LayoutController.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::shouldClose):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509
2011-04-21  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] DRT: implement eventSender.scalePageBy
        https://bugs.webkit.org/show_bug.cgi?id=59082

        Added support in DRT for webview scaling.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::scalePageBy):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523
2011-04-20  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        layoutTestController can create and destroy shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59058

        Support for new methods in GTK DRT.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::ensureShadowRoot):
        (DumpRenderTreeSupportGtk::removeShadowRoot):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536
2011-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Build libWebCore with the gtk sources too
        https://bugs.webkit.org/show_bug.cgi?id=58968

        In some cases webcore files are compiled twice, so it improves the
        build time.

        * GNUmakefile.am: Remove webcore gtk sources from libwebkitgtk
        sources.

1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549
2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
        https://bugs.webkit.org/show_bug.cgi?id=58883

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidReceiveContentLength):
        * WebCoreSupport/FrameLoaderClientGtk.h:
        * webkit/webkitdownload.cpp:
        (DownloadClient::didReceiveData):

1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563
2011-04-18  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Martin Robinson.

        [GTK] Need support for dumping focus rectangles in pixel results
        https://bugs.webkit.org/show_bug.cgi?id=53647

        Add a support function that returns the rectangle of the current
        selection in frame.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::rectangleForSelection):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

1564 1565 1566 1567 1568 1569
2011-04-12  Xan Lopez  <xlopez@igalia.com>

        Unreviewed build fix.

        * webkit/webkitwebhistoryitem.cpp:

1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580
2011-04-12  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=58280
        <rdar://problem/9252824> javascript in an inconsistent state due to serialization returning an un-handled exception.

        Add a header include.  Fallout from untangling some header files in WebCore.

        * webkit/webkitwebhistoryitem.cpp:

1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595
2011-02-03  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] The GTK+ DRT needs an implementation of the PlainTextController
        https://bugs.webkit.org/show_bug.cgi?id=53605

        Added jsValueToDOMRange to DumpRenderTreeSupportGtk. This static method can convert
        a JSValueRef to a WebKitDOMRange. When it's possible to do this with the public
        API, we can remove this method.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::jsValueToDOMRange): Added.
        * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added declaration.

1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608
2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [Gtk] Implement support for Embedded Objects
        https://bugs.webkit.org/show_bug.cgi?id=52148

        New accessibility unit test for embedded objects.

        * tests/testatk.c:
        (testWebkitAtkEmbeddedObjects): New unit test.
        (main): Added the new unit test.

1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619
2011-04-08  Dominic Cooney  <dominicc@google.com>

        Reviewed by Adam Roben.

        Make layoutTestController.shadowRoot return null, not undefined,
        when its argument is invalid.
        https://bugs.webkit.org/show_bug.cgi?id=58121

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::shadowRoot):

1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630
2011-04-08  Dominic Cooney  <dominicc@google.com>

        Reviewed by Kent Tamura.

        layoutTestController.shadowRoot should return undefined if its
        argument is not an element.
        https://bugs.webkit.org/show_bug.cgi?id=58119

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::shadowRoot):

1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647
2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
        https://bugs.webkit.org/show_bug.cgi?id=58039

        Implemented missing functions in GTK's DRT.

        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (modifyAccessibilityValue): Helper function to increment or decrement
        the current value for an object through the AccessibilityObject's API.
        (DumpRenderTreeSupportGtk::incrementAccessibilityValue): New function,
        to be used from GTK's DRT.
        (DumpRenderTreeSupportGtk::decrementAccessibilityValue): Ditto.

1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661
2011-04-06  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Martin Robinson.

        [GTK] Need a way to get the path to a WebKitWebPlugin
        https://bugs.webkit.org/show_bug.cgi?id=57968

        Expose the path of the plugin through the WebKitWebPlugin object.

        * webkit/webkitwebplugin.cpp:
        (webkit_web_plugin_get_path):
        * webkit/webkitwebplugin.h:
        * webkit/webkitwebpluginprivate.h:

1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673
2011-04-07  Alice Boxhall  <aboxhall@chromium.org>

        Reviewed by Ryosuke Niwa.

        Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
        https://bugs.webkit.org/show_bug.cgi?id=57921

        * webkit/webkitwebview.cpp:
        (webkit_web_view_forward_context_menu_event):
        Call subframeForHitTestResult rather than subframeForTargetNode as the targetNode()
        method has moved on to EventHandler.

1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690
2011-04-05  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [Cairo] Better separate the concerns of GraphicsContextCairo
        https://bugs.webkit.org/show_bug.cgi?id=55150

        Add a PlatformContextCairo which right now stores the cairo_t* for a
        GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
        and image masking layers into this PlatformContextCairo class.

        * webkit/webkitwebframe.cpp:
        (draw_page_callback):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_expose_event):
        (webkit_web_view_draw):

1691 1692 1693 1694 1695 1696 1697 1698 1699 1700
2011-04-04  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
        https://bugs.webkit.org/show_bug.cgi?id=56085

        * WebCoreSupport/TextCheckerClientEnchant.h:
        (WebKit::TextCheckerClientEnchant::requestCheckingOfString):

1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717
2011-04-04  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] WebGL support
        https://bugs.webkit.org/show_bug.cgi?id=31517

        Add support for toggling WebGL at runtime when it's enabled.

        * webkit/webkitwebsettings.cpp: Add the enable-webgl property. When ENABLE_WEBGL
        is not enabled, it's a no-op.
        (webkit_web_settings_class_init): Update to support enable-webgl.
        (webkit_web_settings_set_property): Ditto.
        (webkit_web_settings_get_property): Ditto.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings): Ditto.

ap@apple.com's avatar
ap@apple.com committed
1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728
2011-04-04  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=51230
        <rdar://problem/8780989>

        * webkit/webkitwebview.cpp: (webkit_web_view_key_release_event): Moved Caps Lock handling from
        WebKits to WebCore, because WebKit shouldn't be smart.

1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744
2011-04-04  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] webkit_web_view_popup_menu_handler should call SelectionController::localCaretRect
        https://bugs.webkit.org/show_bug.cgi?id=54633

        Remove use of legacy editing positions when positioning keyboard-driven context
        menus. Simplify the code greatly.

        * webkit/webkitwebview.cpp:
        (getLocationForKeyboardGeneratedContextMenu): Added this helper which calculates
        the context menu position.
        (webkit_web_view_popup_menu_handler): Simplify code preventing the menu from bumping
        into the edges of the view. Remove (0,-1) hack as it no longer seems to be important.

1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755
2011-04-02  Dominic Cooney  <dominicc@google.com>

        Reviewed by Martin Robinson.

        Add layoutTestController.shadowRoot to GTK DumpRenderTree.
        https://bugs.webkit.org/show_bug.cgi?id=57551

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::shadowRoot):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767
2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82721.
        http://trac.webkit.org/changeset/82721
        https://bugs.webkit.org/show_bug.cgi?id=57687

        This patch introduced assertion failures on the GTK+ bots.
        (Requested by mrobinson on #webkit).

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778
2011-04-01  Dominic Cooney  <dominicc@google.com>

        Reviewed by Martin Robinson.

        Add layoutTestController.shadowRoot to GTK DumpRenderTree.
        https://bugs.webkit.org/show_bug.cgi?id=57551

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::shadowRoot):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

1779 1780 1781 1782 1783 1784 1785 1786 1787
2011-03-31  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Link explicitly with XRender on Linux/Unix
        https://bugs.webkit.org/show_bug.cgi?id=57558

        * GNUmakefile.am: add XRender LIBS.

1788 1789 1790 1791 1792 1793 1794
2011-03-31  Evan Martin  <evan@chromium.org>

        Build fix from previous change.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):

1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808
2011-03-31  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        <title> should support dir attribute
        https://bugs.webkit.org/show_bug.cgi?id=50961

        Update to new FrameLoaderClient interface.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
        (WebKit::FrameLoaderClient::setTitle):
        * WebCoreSupport/FrameLoaderClientGtk.h:

1809 1810 1811 1812 1813 1814 1815
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, disable an assert in testwebview due to
        https://bugs.webkit.org/show_bug.cgi?id=57315

        * tests/testwebview.c:

adele@apple.com's avatar
adele@apple.com committed
1816 1817 1818 1819 1820 1821 1822
2011-03-28  Adele Peterson  <adele@apple.com>

        Build fix.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker):

1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837
2011-03-28  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fullscreen tests failing after r82084
        https://bugs.webkit.org/show_bug.cgi?id=57219

        Added the withKeyboard parameter to supportsFullScreenForElement
        method in ChromeClient. Fullscreen will be disabled for keyboard
        access by default.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::supportsFullScreenForElement):
        * WebCoreSupport/ChromeClientGtk.h:

1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851
2011-03-25  Andy Estes  <aestes@apple.com>

        Reviewed by Adele Peterson.

        REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
        https://bugs.webkit.org/show_bug.cgi?id=49016

        Update objectContentType() implementation to handle the
        shouldPreferPlugInsForImages flag.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::objectContentType):
        * WebCoreSupport/FrameLoaderClientGtk.h:

1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862
2011-03-25  Priit Laes  <plaes@plaes.org>

        Reviewed by Martin Robinson.

        [GTK] [PATCH] Avoid critical warning when free-ing list of plugins
        https://bugs.webkit.org/show_bug.cgi?id=57025

        * webkit/webkitwebplugindatabase.cpp:
        (webkit_web_plugin_database_plugins_list_free):
        Use regular check and return instead of g_return_if_fail.

1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876
2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81916 and r81917.
        http://trac.webkit.org/changeset/81916
        http://trac.webkit.org/changeset/81917
        https://bugs.webkit.org/show_bug.cgi?id=57071

        broke a test on platforms that do not have QuickTime installed
        (Requested by estes on #webkit).

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::objectContentType):
        * WebCoreSupport/FrameLoaderClientGtk.h:

1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
        https://bugs.webkit.org/show_bug.cgi?id=49016

        Update objectContentType() implementation to handle the
        shouldPreferPlugInsForImages flag.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::objectContentType):
        * WebCoreSupport/FrameLoaderClientGtk.h:

1891 1892 1893 1894 1895 1896 1897 1898 1899 1900
2011-03-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        Change IconDatabase opening to allow for arbitrary filenames
        https://bugs.webkit.org/show_bug.cgi?id=56977

        * webkit/webkiticondatabase.cpp:
        (webkit_icon_database_set_path):

1901 1902 1903 1904 1905 1906 1907 1908 1909 1910
2011-03-22  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Xan Lopez.

        Applications that include WebKit headers fail to build when using strict warnings
        because the signature for webkit_application_cache_get_maximum_size is missing a
        'void' to make it explicit it takes no arguments.

        * webkit/webkitapplicationcache.h:

1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921
2011-03-21  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] 1.3.13 release bump
        https://bugs.webkit.org/show_bug.cgi?id=56795

        Version bump for 1.3.13 and updated NEWS file with release notes.

        * NEWS:

1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937
2011-03-21  Chang Shu  <cshu@webkit.org>

        Reviewed by Alexey Proskuryakov.

        REGRESSION (r79953): Can't type in MS Outlook 2011
        https://bugs.webkit.org/show_bug.cgi?id=56665

        r79953 removed the WebView level editablity which is persistent no matter whether
        underlying document itself is changed and editability gets lost. The resolution is to
        set this WebView editable value to WebCore. This avoids the callback from WebCore to
        WebKit which was the main goal in r79953 to improve performance.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_editable):
        (webkit_web_view_set_editable):

1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948
2011-03-21  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] [Stable] AtkHypertext exposes wrong offsets for links placed inside <span> nodes
        https://bugs.webkit.org/show_bug.cgi?id=56737

        * tests/testatk.c:
        (testWebkitAtkHypertextAndHyperlinks): Updated unit test to also
        check offsets for hyperlinks inside <span> nodes.

xan@webkit.org's avatar
xan@webkit.org committed
1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960
2011-03-18  David Keijser  <keijser@gmail.com> and Xan Lopez <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] On-demand event-listeners for DOM event signals
        https://bugs.webkit.org/show_bug.cgi?id=49649

        * tests/testdomdomwindow.c: update unit tests for new APIs.
        (load_event_callback): ditto.
        (test_dom_domview_signals): ditto.
        (load_status_callback): ditto.

1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974
2011-03-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=56425
        More groundwork for WebKit2 IconDatabase

        Update already-used function names:
        * webkit/webkiticondatabase.cpp:
        (webkit_icon_database_get_icon_uri):
        (webkit_icon_database_get_icon_pixbuf):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_icon_uri):

1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988
2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        Viewport no longer allows an auto value for "user-scalable"
        https://bugs.webkit.org/show_bug.cgi?id=55416

        Make the default value for userScalable be true.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): update test output to include userScalable.
        * webkit/webkitviewportattributes.cpp:
        (webkitViewportAttributesRecompute):

1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999
2011-03-15  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Tony Chang.

        Autofilled form elements are assigned fixed background color but not text color
        https://bugs.webkit.org/show_bug.cgi?id=48382

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::setAutofilled): Added.
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011
2011-03-14  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Martin Robinson.

        [GTK] Possible leaks after splitting TextCheckerClientEnchant.
        https://bugs.webkit.org/show_bug.cgi?id=55989

        Convert gchar* to GOwnPtr<gchar> and refactor the code.

        * WebCoreSupport/TextCheckerClientEnchant.cpp:
        (WebKit::TextCheckerClientEnchant::checkSpellingOfString):

2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028
2011-03-11  Marco Peereboom  <marco@peereboom.us>

        Reviewed by Gustavo Noronha Silva.

        Provide a knob to enable/disable DNS prefetching.
        DNS prefetching is enabled by default.
        https://bugs.webkit.org/show_bug.cgi?id=55973

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):
        (webkit_web_view_settings_notify):

2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039
2011-03-08  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] close-web-view emitted on disposed WebView
        https://bugs.webkit.org/show_bug.cgi?id=55932

        * WebCoreSupport/ChromeClientGtk.cpp:
        (ChromeClient::chromeDestroyed): Remove the closeSoonTimer glib
        source before destruction of the ChromeClient.

2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061
2011-03-11  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Ryosuke Niwa.

        Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/
        https://bugs.webkit.org/show_bug.cgi?id=55570

        Add a virtual function toInputElement() to Node that has a default
        implementation of returning 0.
        For HTMLInputElement and WMLInputElement (which derive from InputElement)
        override this to return the object.
        Change all calling sites of the old toInputElement to use the new member
        function. This also allows us to save some casts.

        No new tests (refactoring).

        * src/WebInputElement.cpp:
        (WebKit::toWebInputElement):

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::setValueForUser):

2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080
2011-03-10  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] unittests/testapplicationcache crashes
        https://bugs.webkit.org/show_bug.cgi?id=56083

        Removed the webkit_application_cache_get_database_directory_path
        API as the underlying ApplicationCacheStorage doesn't allow
        setting the cache path multiple times.

        * tests/testapplicationcache.c:
        (main):
        * webkit/webkitapplicationcache.cpp:
        (webkit_application_cache_get_database_directory_path):
        * webkit/webkitapplicationcache.h:
        * webkit/webkitglobals.cpp:
        (webkitInit):

2081 2082 2083 2084 2085 2086 2087 2088 2089 2090
2011-03-09  Peter Kasting  <pkasting@google.com>

        Reviewed by Mihai Parparita.

        Unify Windows version checks.
        https://bugs.webkit.org/show_bug.cgi?id=55979

        * webkit/webkitwebsettings.cpp:
        (webkitOSVersion):

2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112
2011-03-08  Christian Dywan  <christian@lanedo.com>

        Reviewed by Martin Robinson.

        [GTK] provide an API to control the IconDatabase
        https://bugs.webkit.org/show_bug.cgi?id=32510

        * GNUmakefile.am:
        * WebCoreSupport/FrameLoaderClientGtk.cpp: Emit signals on
            the icon database for new icons.
        * webkit/webkit.h:
        * webkit/webkitdefines.h:
        * webkit/webkitglobals.cpp:
        * webkit/webkitglobals.h: Add a function to obtain the global
            icon database.
        * webkit/webkiticondatabase.cpp:
        * webkit/webkiticondatabase.h: Implement public icon database
            object with methods for obtaining icon URLs, pixbufs, clearing
            waiting for new icons.
        * webkit/webkitwebview.cpp:
        * webkit/webkitwebview.h: Add a method to obtain an icon pixbuf
            for the web view.
2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125
2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add layoutTestController.setValueForUser() after r80412
        https://bugs.webkit.org/show_bug.cgi?id=55862

        Add setValueForUser method to DumpRenderTreeSupportGTK.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::setValueForUser):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139
2011-03-07  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
        https://bugs.webkit.org/show_bug.cgi?id=55827

        Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
        and pass the entire response, instead of just the MIMEType.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse):
        * WebCoreSupport/FrameLoaderClientGtk.h:

2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150
2011-03-01  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Windowless plugins override the view cursor
        https://bugs.webkit.org/show_bug.cgi?id=55531

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::setCursor): Moved the implementation of setCursor here
        which is more fitting since it sets the cursor for the entire window.

2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163
2011-03-03  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=55721
        Global IconDatabase should be returned by reference, not as a pointer

        * webkit/webkitglobals.cpp:
        (closeIconDatabaseOnExit):
        (WebKit::setIconDatabaseEnabled):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_icon_uri):

2164 2165 2166 2167 2168 2169 2170
2011-03-03  Alexey Proskuryakov  <ap@apple.com>

        Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
        via ChromeClient.h

        * WebCoreSupport/ChromeClientGtk.h:

ap@apple.com's avatar
ap@apple.com committed
2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183
2011-03-02  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
        https://bugs.webkit.org/show_bug.cgi?id=55633
        <rdar://problem/8963023>

        * WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::keyboardUIMode):
        * WebCoreSupport/ChromeClientGtk.h:
        Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
        this platform doesn't observe or have full keyboard access state.

2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199
2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>

        Reviewed by Xan Lopez.

        [GTK] Extended application cache database API and added unit tests file.
        https://bugs.webkit.org/show_bug.cgi?id=55335

        * GNUmakefile.am: Add testapplicationcache.c and remove webkitapplicationcacheprivate.h.
        * tests/testapplicationcache.c: Added.
        (test_applicationcache_maximum_size): Tests if application cache storage is set/get correctly.
        (test_applicationcache_database_directory_path): Tests if application cache directory path is set/get correctly.
        (main):
        * webkit/webkitapplicationcache.cpp:
        (webkit_application_cache_get_maximum_size): New API for getting application cache maximum storage size.
        * webkit/webkitapplicationcache.h: Declaration of API for getting/setting application cache maximum storage size.
        * webkit/webkitapplicationcacheprivate.h: Removed.
2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210
2011-03-03  Peter Kasting  <pkasting@google.com>

        Reviewed by James Robinson.

        Drop redundant "Windows; " from the Windows-specific User Agent string.
        https://bugs.webkit.org/show_bug.cgi?id=54567

        * webkit/webkitwebsettings.cpp:
        (webkitPlatform):
        (webkitUserAgent):

2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226
2011-03-02  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        Do a bit of cleanup in ChromeClientGtk. Instead of always fetching the
        WebKitWebView from the frame, simply get it from the member variable of
        the ChromeClientGtk instance itself.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::scrollbarsVisible):
        (WebKit::ChromeClient::exceededDatabaseQuota):
        (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
        (WebKit::ChromeClient::cancelGeolocationPermissionRequestForFrame):
        (WebKit::ChromeClient::enterFullscreenForNode):
        (WebKit::ChromeClient::exitFullscreenForNode):

2227 2228 2229 2230 2231 2232 2233 2234 2235
2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
        * webkit/webkitviewportattributes.cpp:
        (webkitViewportAttributesRecompute):

2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247
2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        Viewport Warning/Error Messages Are Now Inaccurate
        https://bugs.webkit.org/show_bug.cgi?id=53707

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): pass a Document into computeViewportAttributes for warnings to be reported to.
        * webkit/webkitviewportattributes.cpp:
        (webkitViewportAttributesRecompute): pass a Document into computeViewportAttributes for warnings to be reported to.

2248 2249 2250 2251 2252 2253