ChangeLog 1.14 MB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
2010-04-05  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde-Christiansen.

        [Qt] Fix infinite redirection loop in QNetworkReplyHandler

        Qt enters an infinite loop if a redirect response redirects to itself.

        Fixes http/tests/xmlhttprequest/connection-error-sync.html

        https://bugs.webkit.org/show_bug.cgi?id=37097

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44
2010-04-05  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed, revert r57078.

        * Android.jscbindings.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::reportError):
        * bindings/js/JSEventListener.h:
        * bindings/js/JSWorkerContextErrorHandler.cpp: Removed.
        * bindings/js/JSWorkerContextErrorHandler.h: Removed.
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8WorkerContextErrorHandler.cpp: Removed.
        * bindings/v8/V8WorkerContextErrorHandler.h: Removed.
        * bindings/v8/V8WorkerContextEventListener.cpp:
        (WebCore::V8WorkerContextEventListener::reportError):
        * bindings/v8/V8WorkerContextEventListener.h:
        * dom/EventListener.h:
        (WebCore::EventListener::reportError):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::WorkerContext):
        (WebCore::WorkerContext::reportException):
        * workers/WorkerContext.h:

45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64
2010-04-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Style update done due to mutation event dispatching in textarea can be
        used to corrupt the render tree.
        https://bugs.webkit.org/show_bug.cgi?id=36864

        Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html
               fast/forms/select-change-popup-to-listbox-roundtrip.html
               fast/forms/textarea-and-mutation-events.html

        * dom/Node.cpp:
        (WebCore::Node::dispatchGenericEvent): Removed invocation of
            Document::updateStyleForAllDocuments
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit
            recalc to ensure accuracy of representation, especially for
            menuList/listBox switches.

65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94
2010-04-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Dave Hyatt.

        iframe flattening doesn't flatten
        https://bugs.webkit.org/show_bug.cgi?id=36798

        Fixed to the iframe flattening code so that the iframes on
        http://www.samisite.com/test-csb2nf/id43.htm are actually
        flattened.

        Covered by current tests.

        * page/FrameView.cpp: Propagate contents changes of iframes
        and subframes in framesets to the parent so that it is relayouted
        (WebCore::FrameView::setContentsSize):
        (WebCore::FrameView::adjustViewSize):
        (WebCore::FrameView::scheduleRelayout):
        * rendering/RenderPart.cpp: HTMLIFrameElement do not inherit from
        HTMLFrameElement, but HTMLFrameElementBase, correct cast. Correct
        the use of inset border values. Avoid a sometimes unnecessary
        relayout.
        (WebCore::RenderPart::layoutWithFlattening):
        * rendering/RenderPartObject.cpp: Make the calcHeight and calcWidth
        return the right values, considering scrolling and fixed width/height
        (WebCore::RenderPartObject::flattenFrame):
        (WebCore::RenderPartObject::calcHeight):
        (WebCore::RenderPartObject::calcWidth):
        (WebCore::RenderPartObject::layout):

95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175
2010-04-05  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Yury Semikhatsky.

        [V8] Extend the set of types supported by SerializedScriptValue
        https://bugs.webkit.org/show_bug.cgi?id=37052

        New types include sparse arrays, Uint32, Date, and ImageData.

        Serialization process became more flexible. A state can either
        directly write primitive values (instead of returning them like
        iterator) or construct a new state for serializing complex values
        that will return to the current state when done.

        Deserialization process now avoids exposing the tags using a set
        of factory functions for complex objects instead.

        Internal buffer type changed to uint8_t to be independent of
        whether char is signed or not.

        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::):
        (WebCore::Writer::Writer):
        (WebCore::Writer::writeString):
        (WebCore::Writer::writeUint32):
        (WebCore::Writer::writeDate):
        (WebCore::Writer::writeNumber):
        (WebCore::Writer::writeImageData):
        (WebCore::Writer::writeArray):
        (WebCore::Writer::writeObject):
        (WebCore::Writer::writeSparseArray):
        (WebCore::Writer::doWriteUint32):
        (WebCore::Writer::doWriteNumber):
        (WebCore::Writer::append):
        (WebCore::Writer::fillHole):
        (WebCore::Writer::byteAt):
        (WebCore::Serializer::Serializer):
        (WebCore::Serializer::serialize):
        (WebCore::Serializer::writeArray):
        (WebCore::Serializer::writeObject):
        (WebCore::Serializer::writeSparseArray):
        (WebCore::Serializer::StateBase::StateBase):
        (WebCore::Serializer::ErrorState::ErrorState):
        (WebCore::Serializer::ErrorState::advance):
        (WebCore::Serializer::State::composite):
        (WebCore::Serializer::State::State):
        (WebCore::Serializer::ArrayState::ArrayState):
        (WebCore::Serializer::ArrayState::advance):
        (WebCore::Serializer::AbstractObjectState::AbstractObjectState):
        (WebCore::Serializer::AbstractObjectState::advance):
        (WebCore::Serializer::ObjectState::ObjectState):
        (WebCore::Serializer::ObjectState::objectDone):
        (WebCore::Serializer::SparseArrayState::SparseArrayState):
        (WebCore::Serializer::SparseArrayState::objectDone):
        (WebCore::Serializer::push):
        (WebCore::Serializer::pop):
        (WebCore::Serializer::handleError):
        (WebCore::Serializer::checkComposite):
        (WebCore::Serializer::writeString):
        (WebCore::Serializer::writeImageData):
        (WebCore::Serializer::newArrayState):
        (WebCore::Serializer::newObjectState):
        (WebCore::Serializer::doSerialize):
        (WebCore::Reader::Reader):
        (WebCore::Reader::read):
        (WebCore::Reader::readString):
        (WebCore::Reader::readUint32):
        (WebCore::Reader::readDate):
        (WebCore::Reader::readNumber):
        (WebCore::Reader::readImageData):
        (WebCore::Reader::doReadUint32):
        (WebCore::Reader::doReadNumber):
        (WebCore::Deserializer::Deserializer):
        (WebCore::Deserializer::createArray):
        (WebCore::Deserializer::createObject):
        (WebCore::Deserializer::createSparseArray):
        (WebCore::Deserializer::initializeObject):
        (WebCore::Deserializer::doDeserialize):
        (WebCore::Deserializer::stackDepth):
        (WebCore::SerializedScriptValue::deserialize):

176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221
2010-04-05  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Refactored error reporting mechanizm on Worker Global Objects.
        Unlike other event listeners which accept single argument(Event)
        onerror handler on worker global object should be a function
        accepting three arguments. This error reporting was implementedas
        EventListener::reportError method which had custom implementations
        for v8 and JSC. This patch removes EventListener::reportError and
        moves its functionality into custom bindings(V8WorkerContextErrorHandler
        and JSWorkerContextErrorHandler) that implement EventListener inerface
        for the onerror handler.

        This patch also makes uncaught exceptions that happen in the onerror
        listener be reported to the Worker's onerror handler.

        https://bugs.webkit.org/show_bug.cgi?id=36375

        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventListener.cpp:
        * bindings/js/JSEventListener.h:
        * bindings/js/JSWorkerContextErrorHandler.cpp: Added.
        (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler):
        (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler):
        (WebCore::JSWorkerContextErrorHandler::handleEvent):
        * bindings/js/JSWorkerContextErrorHandler.h: Added.
        (WebCore::JSWorkerContextErrorHandler::create):
        (WebCore::createJSWorkerContextErrorHandler):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8WorkerContextErrorHandler.cpp: Added.
        (WebCore::V8WorkerContextErrorHandler::V8WorkerContextErrorHandler):
        (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
        * bindings/v8/V8WorkerContextErrorHandler.h: Added.
        (WebCore::V8WorkerContextErrorHandler::create):
        * bindings/v8/V8WorkerContextEventListener.cpp:
        * bindings/v8/V8WorkerContextEventListener.h:
        * dom/EventListener.h: Removed reportError method that was used only for reporting worker errors.
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::WorkerContext):
        (WebCore::WorkerContext::reportException):
        * workers/WorkerContext.h:

222 223 224 225 226 227 228 229 230 231 232 233
2010-04-05  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Darin Adler.

        Fix some  "explicit braces to avoid ambiguous 'else'" warnings
        https://bugs.webkit.org/show_bug.cgi?id=37088

        * dom/Node.cpp:
        (WebCore::Node::dispatchGenericEvent):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchEvent):

234 235 236 237 238 239 240 241 242 243 244 245 246
2010-04-05  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Consolidate the definition of SKIP_STATIC_CONSTRUCTORS_ON_GCC

        Instead of defining and undefining it later, let's not
        define SKIP_STATIC_CONSTRUCTORS_ON_GCC for WINSCW.

        No new tests as there is no new functionality.

        * config.h:

247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265
2010-04-05  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] [Symbian] Remove obsolete build flags for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=37083

        Symbian port of QtWebKit port does not use icu, so it does 
        not need U_HAVE_* defines.

        Symbian now has inttypes.h as part of OpenC.

        stdio.h, limits.h and MathExtras.h are already included in
        more appropriate locations.

        No new tests as there is no new functionality.

        * config.h:

266 267 268 269 270 271 272 273
2010-04-05  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: chromium build fix.

        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
        (WebCore::V8InspectorFrontendHost::platformCallback):
        (WebCore::V8InspectorFrontendHost::portCallback):

274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292
2010-04-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [REGRESSION] platform detection in Chromium
        has regressed to unknown.

        https://bugs.webkit.org/show_bug.cgi?id=37081

        * bindings/js/JSInspectorFrontendHostCustom.cpp:
        (WebCore::JSInspectorFrontendHost::platform):
        (WebCore::JSInspectorFrontendHost::port):
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
        (WebCore::V8InspectorFrontendHost::platform):
        (WebCore::V8InspectorFrontendHost::port):
        * inspector/InspectorFrontendHost.cpp:
        * inspector/InspectorFrontendHost.h:
        * inspector/InspectorFrontendHost.idl:

293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313
2010-04-05  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Remove logging of successful XHR and worker's importScript()
        to inspector console
        https://bugs.webkit.org/show_bug.cgi?id=37078

        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::importScripts):
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        (WebCore::V8WorkerContext::importScriptsCallback):
        * workers/DedicatedWorkerContext.cpp:
        (WebCore::DedicatedWorkerContext::importScripts):
        * workers/DedicatedWorkerContext.h:
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::importScripts):
        * workers/WorkerContext.h:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::didFinishLoading):

314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331
2010-04-04  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Rolling out chromium changes r57028 and r57032
        for breaking chromium layout tests.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * platform/chromium/DragImageChromium.cpp: Added.
        (WebCore::dragImageSize):
        (WebCore::deleteDragImage):
        (WebCore::scaleDragImage):
        (WebCore::dissolveDragImageToFraction):
        (WebCore::createDragImageFromImage):
        (WebCore::createDragImageIconForCachedImage):
        * platform/chromium/DragImageChromiumMac.cpp: Removed.
        * platform/chromium/DragImageChromiumSkia.cpp: Removed.
        * platform/chromium/DragImageRef.h:

332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366
2010-03-29  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Simon Fraser.
        Patch by Antonio Gomes <tonikitoo@webkit.org>

        Spatial Navigation: Initial code simplification in FocusController.cpp and SpatialNavigation.cpp

        WebCore::distanceInDirection method was handling much of the logic not
        strictly only related to the distance between nodes acquisition. This
        method was simplified and renamed to 'WebCore::distanceDataForNode'.
        The latter is now responsible for only getting the distance and alignment
        data, while all assignement logic previously in distanceInDirection method
        was moved place to updateFocusCandidateIfCloser.

        Parent document distance and alignment acquisitions, in turn, have also
        changed location: they are both got from deepFindFocusableNodeInDirection,
        and passed in a recursive call to findFocusableNodeInDirection via the
        candidateParent variable (optional parameter). In addition, the need for
        the 'focusCandidateCopy' variable in deepFindFocusableNodeInDirection method
        was removed, making the code much cleaner.

        No behaviour change at this point. Mostly moving code around to the place
        where it should live in.

        * page/FocusController.cpp:
        (WebCore::FocusController::advanceFocusDirectionally):
        (WebCore::updateFocusCandidateIfCloser):
        (WebCore::FocusController::findFocusableNodeInDirection):
        (WebCore::FocusController::deepFindFocusableNodeInDirection):
        * page/FocusController.h:
        * page/SpatialNavigation.cpp:
        (WebCore::distanceDataForNode):
        (WebCore::renderRectRelativeToRootDocument):
        * page/SpatialNavigation.h:

367 368 369 370 371 372 373 374 375 376 377
2010-04-04  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: In the inherited styles, do not render non-inherited properties as overriden.

        https://bugs.webkit.org/show_bug.cgi?id=37072

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):

378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393
2010-04-03  yael aharon  <yael.aharon@nokia.com>

        Reviewed by Darin Adler.

        Enable HTMLProgressElement for Safari on OSX
        https://bugs.webkit.org/show_bug.cgi?id=36961

        * Configurations/FeatureDefines.xcconfig:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
        (WebCore::RenderThemeMac::animationDurationForProgressBar):
        (WebCore::RenderThemeMac::adjustProgressBarStyle):
        (WebCore::RenderThemeMac::paintProgressBar):

394 395 396 397 398 399 400 401
2010-04-03  Jakub Wieczorek  <jwieczorek@webkit.org>

        Unreviewed.

        Fix debug build with GCC >= 4.3.

        * platform/graphics/GraphicsLayer.cpp: Include stdio.h explicitly.

402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443
2010-04-03  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
        https://bugs.webkit.org/show_bug.cgi?id=36574

        Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
        points causing them to throw exceptions rather than synthesize GL
        errors. Fixed the implementations to synthesize INVALID_VALUE
        rather than INVALID_OPERATION to comply to the WebGL spec. Updated
        uniform-location-expected.txt to incorporate the correct error.
        Tested in Safari and Chromium.

        Test: fast/canvas/webgl/null-uniform-location.html

        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        (WebCore::V8WebGLRenderingContext::getUniformCallback):
        (WebCore::vertexAttribAndUniformHelperf):
        (WebCore::uniformHelperi):
        (WebCore::uniformMatrixHelper):
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::uniform1f):
        (WebCore::WebGLRenderingContext::uniform1fv):
        (WebCore::WebGLRenderingContext::uniform1i):
        (WebCore::WebGLRenderingContext::uniform1iv):
        (WebCore::WebGLRenderingContext::uniform2f):
        (WebCore::WebGLRenderingContext::uniform2fv):
        (WebCore::WebGLRenderingContext::uniform2i):
        (WebCore::WebGLRenderingContext::uniform2iv):
        (WebCore::WebGLRenderingContext::uniform3f):
        (WebCore::WebGLRenderingContext::uniform3fv):
        (WebCore::WebGLRenderingContext::uniform3i):
        (WebCore::WebGLRenderingContext::uniform3iv):
        (WebCore::WebGLRenderingContext::uniform4f):
        (WebCore::WebGLRenderingContext::uniform4fv):
        (WebCore::WebGLRenderingContext::uniform4i):
        (WebCore::WebGLRenderingContext::uniform4iv):
        (WebCore::WebGLRenderingContext::uniformMatrix2fv):
        (WebCore::WebGLRenderingContext::uniformMatrix3fv):
        (WebCore::WebGLRenderingContext::uniformMatrix4fv):

444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496
2010-04-02  Andy Estes  <aestes@apple.com>

        Reviewed by Adam Barth.

        The previous mechanism for testing whether an event was due to a user
        gesture only checked the event type, not the source of the event.  This
        allowed scripts to defeat popup blocking by programatically emitting
        certain types of events.

        Change the user gesture detection to check for a flag that is only set
        when the event in question was generated through the platform and not
        through the DOM.

        https://bugs.webkit.org/show_bug.cgi?id=37008

        Tests: fast/events/popup-allowed-from-gesture-initiated-event.html
               fast/events/popup-blocked-from-fake-button-click.html
               fast/events/popup-blocked-from-fake-focus.html

        * Android.mk: Add UserGestureIndicator.{cpp, h}.
        * GNUmakefile.am: Same.
        * WebCore.gypi: Same.
        * WebCore.pro: Same.
        * WebCore.vcproj/WebCore.vcproj: Same.
        * WebCore.xcodeproj/project.pbxproj: Same.
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::processingUserGesture): Check the value of
        UserGesureIndicator::processingUserGesture().
        * dom/Document.cpp:
        (WebCore::Document::createEvent): Remove call to
        Event::setCreatedByDOM().
        * dom/Event.cpp:
        (WebCore::Event::Event): Remove initializers for m_createdByDOM.
        (WebCore::Event::fromUserGesture): Check the value of
        UserGestureIndicator::processingUserGesture().
        * dom/Event.h: Remove m_createdByDOM.
        * dom/UserGestureIndicator.cpp: Added.
        (WebCore::UserGestureIndicator::UserGestureIndicator): Save the previous
        value of s_processingUserGesture before setting it to true.
        (WebCore::UserGestureIndicator::~UserGestureIndicator): Restore
        s_processingUserGesture to its previous value.
        * dom/UserGestureIndicator.h: Added.
        (WebCore::UserGestureIndicator::processingUserGesture): Return the value
        of s_processingUserGesture.
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEvent): Instantiate a
        UserGestureIndicator object on the stack to indicate a user gesture is
        being processed.
        (WebCore::EventHandler::handleMouseDoubleClickEvent): Same.
        (WebCore::EventHandler::handleMouseReleaseEvent): Same.
        (WebCore::EventHandler::keyEvent): Same.
        (WebCore::EventHandler::handleTouchEvent): Same.

497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515
2010-04-02  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Alexey Proskuryakov.

        XHR allows arbitrary XSRF across domains 
        https://bugs.webkit.org/show_bug.cgi?id=36843

        Added a one-line change to prevent bypassing the XDC check on
        synchronous preflighted requests. Added layout tests to cover
        variations of this problem.

        Tests: http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html
               http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html
               http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html
               http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html

        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::preflightFailure):

516 517 518 519 520 521 522 523 524 525 526 527 528 529 530
2010-04-02  Nayan Kumar K  <nayankk@gmail.com>

        Reviewed by Eric Seidel.

        Fix for WML enabled build failure.

        https://bugs.webkit.org/show_bug.cgi?id=36648

        * wml/WMLOptionElement.cpp:
        (WebCore::WMLOptionElement::disabled):
        * wml/WMLOptionElement.h:
        * wml/WMLSelectElement.cpp:
        (WebCore::WMLSelectElement::listBoxSelectItem):
        * wml/WMLSelectElement.h:

531 532 533 534 535 536 537 538 539 540 541 542
2010-04-02  MORITA Hajime  <morrita@google.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=37011
        Position::primaryDirection() should not use its own accessor.

        No new tests. This is small clenaup with no behaviour change.

        * dom/Position.cpp:
        (WebCore::Position::primaryDirection):

543 544 545 546 547 548 549 550 551 552 553 554
2010-04-02  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by Brady Eidson.

        window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5.  This is caused by a SecurityOrigin pointer comparison that I should have switched to be a hash comparison in r56293 [bug 34991].
        https://bugs.webkit.org/show_bug.cgi?id=36671

        No new tests.  Requires testing on Safari on Windows.

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Convert a pointer comparison to use SecurityOriginHash::hash() instead, and move it to the end of the clause for speed in the easy-out case.

555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572
2010-04-02  Michael Nordman  <michaeln@google.com>

        Reviewed by Nate Chapin.

        Set the close policy used by the DatabaseCloseTask in a constructor argument
        instead of hard coding it.
        https://bugs.webkit.org/show_bug.cgi?id=37037

        No new tests, new new functionality.

        * storage/Database.cpp: This callsite passes in DoNotRemoveFromDatabaseContext to retain its current behavior.
        (WebCore::Database::markAsDeletedAndClose):
        * storage/DatabaseTask.cpp:
        (WebCore::DatabaseCloseTask::DatabaseCloseTask):
        (WebCore::DatabaseCloseTask::doPerformTask):
        * storage/DatabaseTask.h:
        (WebCore::DatabaseCloseTask::create):

573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588
2010-04-02  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Remove an ASSERT that sometimes flakes due to time dependent animations
        https://bugs.webkit.org/show_bug.cgi?id=37048

        The outline repaint rectangle for a layer might change between two calls
        if there are animations involved, even if nothing in the DOM has actually
        changed between the calls.

        No change in behavior, no new tests.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):

589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612
2010-04-02  Evan Stade  <estade@chromium.org>

        Reviewed by Adam Barth.

        [chromium] need DragImage implementation
        https://bugs.webkit.org/show_bug.cgi?id=35811

        Add two files that failed to get added in my previous patch.

        * platform/chromium/DragImageChromiumMac.cpp: Added.
        (WebCore::dragImageSize):
        (WebCore::deleteDragImage):
        (WebCore::scaleDragImage):
        (WebCore::dissolveDragImageToFraction):
        (WebCore::createDragImageFromImage):
        (WebCore::createDragImageIconForCachedImage):
        * platform/chromium/DragImageChromiumSkia.cpp: Added.
        (WebCore::dragImageSize):
        (WebCore::deleteDragImage):
        (WebCore::scaleDragImage):
        (WebCore::dissolveDragImageToFraction):
        (WebCore::createDragImageFromImage):
        (WebCore::createDragImageIconForCachedImage):

613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629
2010-04-02  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Configure multi-language movies: when QuickTime has sufficiently loaded
        the movie, call into wkQTMovieSelectPreferredAlternates to select the
        movie's alternate tracks according to the user's language preferences.

        https://bugs.webkit.org/show_bug.cgi?id=36624

        * WebCore.base.exp:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: 
        (WebCore::MediaPlayerPrivate::updateStates): If the movie is sufficiently loaded,
        call wkQTMovieSelectPreferredAlternates to set up the alternate tracks.
        * platform/mac/WebCoreSystemInterface.h: Declare WKQTMovieSelectPreferredAlternates.
        * platform/mac/WebCoreSystemInterface.mm: Add WKQTMovieSelectPreferredAlternates.

630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655
2010-04-02  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Adler.

        Splits RenderBlock::layoutInline into smaller functions
        https://bugs.webkit.org/show_bug.cgi?id=36921

        RenderBlock::layoutInlineChildren is 351 lines long and very difficult
        to comprehend or edit safely. This patch splits it up into a few
        slightly smaller functions.  Most of the code is now in the 241 line
        layoutRunsAndFloats() which is a slight improvement.

        Perf neutral on the page cyclers.  This doesn't introduce any function
        calls into the hottest layout paths inside layoutRunsAndFloats and
        findNextLineBreak.

        No change in behavior, no new tests.

        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::FloatWithRect::FloatWithRect):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::layoutReplacedElements):
        (WebCore::RenderBlock::createLineBoxesForResolver):
        (WebCore::RenderBlock::layoutRunsAndFloats):
        (WebCore::RenderBlock::layoutInlineChildren):

656 657 658 659 660 661 662 663 664 665 666 667 668 669 670
2010-04-02  Evan Stade  <estade@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] need DragImage implementation
        https://bugs.webkit.org/show_bug.cgi?id=35811

        Basic implementation using SkBitmap. Transformations are not supported
        yet. No implementation for mac.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * platform/chromium/DragImageChromium.cpp:
        * platform/chromium/DragImageRef.h:

671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697
2010-04-02  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] font fallback for generic fonts picks wrong font
        https://bugs.webkit.org/show_bug.cgi?id=37033

        When a page specifies the generic "monospace" font and the user's
        browser-configured monospace font doesn't exist, we previously relied
        on getLastResortFallbackFont to eventually pick a monospace font for us.

        But that doesn't quite work: WebKit first falls back to the user's
        "preferred standard font" before hitting the last resort code path.
        So if the above conditions hold but this font exists, we'll end up
        never hitting the last resort codepath.

        The fix is to allow OS-level font fallback when first attempting to
        resolve monospace.  The existing code tried to do this, but the logic
        was wrong.  We would eventually fall back to the correct font anyway
        so we didn't notice the logic was wrong.

        This code is all handling cases where particular fonts aren't installed,
        so I can't think of a way to test it; existing tests should still pass.

        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::createFontPlatformData):

698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713
2010-04-02  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson and Eric Seidel.

        Don't stop the playback event timer when media resource loading has suspended.
        https://bugs.webkit.org/show_bug.cgi?id=37003

        When a user agent decides to suspend media resource loading and enters the
        NETWORK_IDLE state we are supposed to only stop the progress event timer but
        keep the playback timer running.

        Test: http/tests/media/video-play-suspend.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setNetworkState): Only stop the progress event timer.

714 715 716 717 718 719 720 721
2010-04-02  Darin Adler  <darin@apple.com>

        Fix mispelling that broke the build.

        * html/canvas/CanvasRenderingContext2D.cpp:
        * html/canvas/CanvasRenderingContext2D.h:
        Dashbard -> Dashboard.

722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762
2010-04-02  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        (non-generated) code should only use CanvasRenderingContext::canvas as a CanvasSurface.
        https://bugs.webkit.org/show_bug.cgi?id=36906

        * dom/CanvasSurface.cpp: Added methods for items that depended on
        CanvasRenderingContext::canvas() being an HTMLElement(), so that this usage
        can be dealt with in one place.
        (WebCore::CanvasSurface::securityOrigin): Only used by methods that are
        only run in the document context.
        (WebCore::CanvasSurface::renderBox): Will likely return 0 in a worker context.
        (WebCore::CanvasSurface::computedStyle): Used by setFont. Return value is TBD for
        the worker context.
        (WebCore::CanvasSurface::styleSelector): Ditto.
        * dom/CanvasSurface.h:
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext): Passing in information into
        the CanvasRenderingContext2D constructor to eliminate some uses of document
        inside of the CanvasRenderingContext2D class.
        * html/HTMLCanvasElement.h:
        (WebCore::HTMLCanvasElement::renderBox): Added to disambiguate between the
        two parent class versions of the method.
        (WebCore::HTMLCanvasElement::computedStyle): Ditto.
        * html/canvas/CanvasRenderingContext2D.cpp: All of these changes are about
        removing document usage either by using a bool that is set in the constructor or
        by calling one of the new methods added to CanvasSurface.
        (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
        (WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode):
        (WebCore::CanvasRenderingContext2D::checkOrigin):
        (WebCore::CanvasRenderingContext2D::prepareGradientForDashboard):
        (WebCore::CanvasRenderingContext2D::createPattern):
        (WebCore::CanvasRenderingContext2D::setFont):
        (WebCore::CanvasRenderingContext2D::drawTextInternal):
        * html/canvas/CanvasRenderingContext2D.h:
        * html/canvas/WebGLRenderingContext.cpp: Removed some duplicate includes.
        (WebCore::WebGLRenderingContext::markContextChanged): Reduced calls to renderBox
         as it may become slightly more expensive in the future.
        (WebCore::WebGLRenderingContext::reshape): Ditto.

763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796
2010-04-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Eric Seidel.

        Implement and test new framebuffer object attachment behavior.
        https://bugs.webkit.org/show_bug.cgi?id=35611

        Test: fast/canvas/webgl/framebuffer-object-attachment.html

        * html/canvas/WebGLFramebuffer.cpp: Keep track of attached stencil/depth renderbuffers in WebGLFramebuffer.
        (WebCore::WebGLFramebuffer::WebGLFramebuffer):
        (WebCore::WebGLFramebuffer::setIsAttached):
        * html/canvas/WebGLFramebuffer.h: Ditto.
        (WebCore::WebGLFramebuffer::isDepthAttached):
        (WebCore::WebGLFramebuffer::isStencilAttached):
        (WebCore::WebGLFramebuffer::isDepthStencilAttached):
        * html/canvas/WebGLRenderbuffer.cpp: Keep track of internalformat.
        (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
        * html/canvas/WebGLRenderbuffer.h: Ditto.
        (WebCore::WebGLRenderbuffer::setInternalformat):
        (WebCore::WebGLRenderbuffer::getInternalformat):
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Detect stencil/depth buffer conflicts.
        (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Handling DEPTH_STENCIL case.
        (WebCore::WebGLRenderingContext::getRenderbufferParameter): Get correct WebGL internalformat.
        (WebCore::WebGLRenderingContext::renderbufferStorage): Detect illegal enums.
        * html/canvas/WebGLRenderingContext.idl: Add DEPTH_STENCIL enums.
        * platform/graphics/GraphicsContext3D.h: Add DEPTH_STENCIL enums.
        (WebCore::GraphicsContext3D::):
        * platform/graphics/mac/GraphicsContext3DMac.cpp: Map to correct DEPTH_STENCIL format.
        (WebCore::GraphicsContext3D::framebufferRenderbuffer):
        (WebCore::GraphicsContext3D::renderbufferStorage):
        (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):

797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820
2010-04-02  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Form control state shouldn't be restored for hidden inputs.
        https://bugs.webkit.org/show_bug.cgi?id=26241

        To fix this issue, we don't save values if it is not changed from
        the default value.

        Updating the value IDL attribute of some controls such as
        type=hidden also updates the value content attribute, and it's
        impossible to distinguish the initial value and the current
        value. The values of such controls are not saved. It won't be a
        problem because we want to save and restore user-edited values.

        Test: fast/forms/state-restore-to-non-edited-controls.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::saveFormControlState):
          Do not save the value if it is same as the default value.
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::saveFormControlState): ditto.

821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850
2010-04-02  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Forms with autocomplete=off should not consume saved state
        https://bugs.webkit.org/show_bug.cgi?id=36762
        
        Introduce Element::shouldSaveAndRestoreFormControlState() to check
        if we should save and restore control state.

        Test: fast/forms/state-restore-to-non-autocomplete-form.html

        * dom/Document.cpp:
        (WebCore::Document::formElementsState): Check shouldSaveAndRestoreFormControlState().
        * dom/Element.h:
        (WebCore::Element::shouldSaveAndRestoreFormControlState): Added. It just returns true.
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElementWithState::autoComplete):
          Added. It return autocomplete state of the form.
        (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState):
          Added. It returns the result of autoComplete().
        (WebCore::HTMLFormControlElementWithState::finishParsingChildren):
          Do not restore state if shouldSaveAndRestoreFormControlState() is false.
        * html/HTMLFormControlElement.h: Declare autoComplete() and overriding methods.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::autoComplete):
          Reduce code by using autoComplete() of the parent class.
        (WebCore::HTMLInputElement::saveFormControlState):
          Remove the autoComplete() check. Document::formElementsState() does equivalent check.

851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869
2010-04-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Very bad scrolling-performance with the Trackpad at http://www.apple.com/ipad/app-store/
        https://bugs.webkit.org/show_bug.cgi?id=36978

        When we update compositing layers (which can happen on scrolling, when there are fixed position elements
        on the page), we can end up redundantly setting images as layer contents if we have to color-correct
        the image. This is because we call CGImageCreateCopyWithColorSpace(), which hands back a new image
        every time.
        
        Avoid this by storing a reference to the original uncorrected image, which is used to then
        avoid work if the image does not change.

        * platform/graphics/mac/GraphicsLayerCA.h:
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::setContentsToImage):

870 871 872 873 874 875 876 877 878 879 880 881 882 883 884
2010-04-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Avoid doing work in FrameView::scrollPositionChanged() if there are no fixed position elements
        https://bugs.webkit.org/show_bug.cgi?id=36994
        
        r55890 added knowledge to FrameView about whether it contains any fixed-position elements. We can
        use this to avoid updating widget positions, and compositing layer positions when possible.

        * page/FrameView.cpp:
        (WebCore::FrameView::scrollPositionChanged):
        * page/FrameView.h:
        (WebCore::FrameView::hasFixedObjects):

885 886 887 888 889 890 891 892 893 894
2010-04-02  Nate Chapin  <japhet@chromium.org>

        Rubber-stamped by Dimitri Glazkov.

        http://trac.webkit.org/changeset/57004 caused
        fast/dom/console-log-stack-overflow.html to fail for Chromium.
        Add check for empty wrappers before using them to create a hidden reference.

        * bindings/scripts/CodeGeneratorV8.pm:

895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933
2010-04-01  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Generalize (and generate!) the creation of hidden references
        between JS wrappers.
        
        https://bugs.webkit.org/show_bug.cgi?id=36777

        * Android.v8bindings.mk:
        * WebCore.gypi:
        * bindings/scripts/CodeGeneratorV8.pm: Generate calls to setHiddenReference() in
        attribute getters.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::setHiddenReference): Split common logic out of hidden setHiddenWindowReference
        (WebCore::V8DOMWrapper::setHiddenWindowReference): Now contains logic specific to putting a 
        hidden reference on a global object.
        (WebCore::globalObjectPrototypeIsDOMWindow): Be more thorough in the COMPILE_ASSERTs.
        (WebCore::V8DOMWrapper::convertEventTargetToV8Object): Cleanup: Remove a duplicate if statement.
        * bindings/v8/V8DOMWrapper.h:
        * bindings/v8/WrapperTypeInfo.h:
        * bindings/v8/custom/V8BarInfoCustom.cpp: Removed.
        * bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
        (WebCore::toV8):
        * bindings/v8/custom/V8DOMSelectionCustom.cpp: Removed.
        * bindings/v8/custom/V8HistoryCustom.cpp:
        * bindings/v8/custom/V8LocationCustom.cpp:
        * bindings/v8/custom/V8MessageChannelConstructor.cpp:
        (WebCore::V8MessageChannel::constructorCallback):
        * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
        (WebCore::toV8):
        * bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
        * bindings/v8/custom/V8ScreenCustom.cpp: Removed.
        * bindings/v8/custom/V8StyleSheetCustom.cpp:
        (WebCore::toV8):
        * loader/appcache/DOMApplicationCache.h:
        (WebCore::DOMApplicationCache::frame): Add frame() accessor.


934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966
2010-04-01  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: start editing DOM and styles on click-and-pause.

        https://bugs.webkit.org/show_bug.cgi?id=36965

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.onattach):
        (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
        (WebInspector.ElementsTreeElement.prototype.ondblclick):
        (WebInspector.ElementsTreeElement.prototype._handleClickAndPause):
        (WebInspector.ElementsTreeElement.prototype._startEditingTarget):
        (WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
        (WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
        (WebInspector.ElementsTreeElement.prototype._startEditingTagName):
        (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):
        (WebInspector.StylePropertiesSection.prototype._handleSelectorClick):
        (WebInspector.StylePropertiesSection.prototype._handleSelectorClickAndPause):
        (WebInspector.StylePropertiesSection.prototype._handleSelectorDoubleClick):
        (WebInspector.StylePropertiesSection.prototype._startEditingOnMouseEvent):
        (WebInspector.StylePropertyTreeElement.prototype.onattach):
        (WebInspector.StylePropertyTreeElement.prototype):
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.js:
        * inspector/front-end/treeoutline.js:
        (TreeElement.prototype._attach):
        (TreeElement.treeElementMouseDown):
        (TreeElement.prototype.selectOnMouseDown):

967 968 969 970 971 972 973 974 975
2010-04-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix when building --no-svg.

        Build fix after r56941. Add ENABLE(SVG) guard.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):

976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008
2010-04-02  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Implement InspectorFrontendHost::showContextMenu for Chromium.
 
        Move inspector frontend context menu code from InspectorFrontendClient to InspectorFrontendHost as it's platform independent.
 
        https://bugs.webkit.org/show_bug.cgi?id=36817

        * WebCore.Inspector.exp:
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
        (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
        * inspector/InspectorFrontendClient.h:
        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
        (WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal):
        (WebCore::InspectorFrontendClientLocal::windowObjectCleared):
        * inspector/InspectorFrontendClientLocal.h:
        * inspector/InspectorFrontendHost.cpp:
        (WebCore::FrontendMenuProvider::create):
        (WebCore::FrontendMenuProvider::disconnect):
        (WebCore::FrontendMenuProvider::FrontendMenuProvider):
        (WebCore::FrontendMenuProvider::~FrontendMenuProvider):
        (WebCore::FrontendMenuProvider::populateContextMenu):
        (WebCore::FrontendMenuProvider::contextMenuItemSelected):
        (WebCore::FrontendMenuProvider::contextMenuCleared):
        (WebCore::InspectorFrontendHost::InspectorFrontendHost):
        (WebCore::InspectorFrontendHost::disconnectClient):
        (WebCore::InspectorFrontendHost::showContextMenu):
        * inspector/InspectorFrontendHost.h:
        (WebCore::InspectorFrontendHost::create):

1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027
2010-04-02  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Timeline Overview pane should support short records filtering.
        https://bugs.webkit.org/show_bug.cgi?id=37020

        * English.lproj/localizedStrings.js:
        * inspector/front-end/TimelineOverviewPane.js:
        (WebInspector.TimelineOverviewPane.prototype.update.markTimeline):
        (WebInspector.TimelineOverviewPane.prototype.update):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
        (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked):
        (WebInspector.TimelinePanel.prototype._refresh):
        (WebInspector.TimelinePanel.prototype._addToRecordsWindow):
        (WebInspector.TimelinePanel.FormattedRecord.prototype.isLong):

1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040
2010-04-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        Accept XHTML-MP content type as XHTML content
        https://bugs.webkit.org/show_bug.cgi?id=34262

        Enable processing XHTML-MP mime type as an XHTML document
        even if XHTML-MP support is not enabled.

        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeSupportedNonImageMimeTypes):

1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081
2010-04-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Make XSSAuditor go fast with large POST data
        https://bugs.webkit.org/show_bug.cgi?id=36694

        There were two things slowing down this bechmark:

        1) Searching the large POST data for each inline event handler.  To
           make this faster, we now use a suffix tree to fast-reject strings
           that don't appear as substrings of the POST data.

        2) The next largest cost was flattening the form data into a string.
           To make this fater, we now use the form data object itself as a key
           and only flatten once.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::CachingURLCanonicalizer::canonicalizeURL):
        (WebCore::XSSAuditor::CachingURLCanonicalizer::clear):
        (WebCore::XSSAuditor::XSSAuditor):
        (WebCore::XSSAuditor::findInRequest):
        * page/XSSAuditor.h:
        (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer):
        (WebCore::XSSAuditor::CachingURLCanonicalizer::generation):
        * platform/text/SuffixTree.h: Added.
        (WebCore::UnicodeCodebook::codeWord):
        (WebCore::UnicodeCodebook::):
        (WebCore::ASCIICodebook::codeWord):
        (WebCore::ASCIICodebook::):
        (WebCore::SuffixTree::SuffixTree):
        (WebCore::SuffixTree::mightContain):
        (WebCore::SuffixTree::Node::Node):
        (WebCore::SuffixTree::Node::~Node):
        (WebCore::SuffixTree::Node::at):
        (WebCore::SuffixTree::build):

1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102
2010-04-02  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Eric Seidel.

        Bug 36741 -  Duplicate, slightly divergent implementation of Position[Iterator]::isCandidate()
        https://bugs.webkit.org/show_bug.cgi?id=36741
        
        Patch: change Position::isCandididate() to call the PositionIterator::isCandidate() version.
        Update PositionIterator::isCandidate() to mirror Position::isCandidate().

        Rationale: PositionIterator::isCandidate() is called in a tight loop within
        next/previousCandidate(). Also, creation of a PositionIterator from a Position
        is cheaper than vice-versa.

        Tests: ran all tests in 'editing'.

        * dom/Position.cpp:
        (WebCore::Position::isCandidate):
        * dom/PositionIterator.cpp:
        (WebCore::PositionIterator::isCandidate):

1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123
2010-04-02  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Dan Bernstein.

        Database code falsely returns errors due to errant pointer check
        https://bugs.webkit.org/show_bug.cgi?id=37014

        r56943 introduced a check to see if there were any unprocessed
        SQL commands after calling sqlite3_prepare16_v2.

        Accessing the remaining data via pointer wasn't possible since
        the query string is deallocated immediately after the
        query runs. The String returned from strippedWhiteSpace
        goes out of scope at that point.

        Fix is to store the strippedWhiteSpace in a temporary String
        so we can access it via character ptr later in the function.

        * platform/sql/SQLiteStatement.cpp:
        (WebCore::SQLiteStatement::prepare):

1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139
2010-04-01  MORITA Hajime  <morrita@google.com>

        Reviewed by Darin Adler.

        setting document.title doesn't change document.title value 
        https://bugs.webkit.org/show_bug.cgi?id=36802

        An entity of "value" argument on HTMLTitleElement::setTitle() could be
        Document::m_title and be changed during HTMLTitleElement::setText(). 
        Fix copying the argument to keep the original value.
        
        Test: fast/dom/Document/title-with-multiple-children.html

        * html/HTMLTitleElement.cpp:
        (WebCore::HTMLTitleElement::setText):

1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156
2010-04-01  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Maemo5 theme - <select multiple> custom rendering
        https://bugs.webkit.org/show_bug.cgi?id=36369

        Customizing rendering of <select multiple> elements in Maemo5.

        * platform/qt/Maemo5Webstyle.cpp:
        (Maemo5WebStyle::drawMultipleComboButton):
        (Maemo5WebStyle::drawSimpleComboButton):
        (Maemo5WebStyle::getButtonImageSize):
        (Maemo5WebStyle::findComboButton):
        (Maemo5WebStyle::drawComplexControl):
        * platform/qt/Maemo5Webstyle.h:

1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201
2010-04-01  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Dmitry Titov.

        Add FileThread for async file operation support in FileReader and FileWriter
        https://bugs.webkit.org/show_bug.cgi?id=36896

        Add FileThread for async file operation support for FileReader and
        FileWriter.  The patch also adds ENABLE_FILE_READER or
        ENABLE_FILE_WRITER build flags/defines.  Both flags are disabled
        by default.

        No new tests, will add ones when after adding modules which use the thread.

        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/ScriptExecutionContext.cpp:
        (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
        (WebCore::ScriptExecutionContext::fileThread):
        * dom/ScriptExecutionContext.h:
        * html/FileThread.cpp: Added.
        (WebCore::FileThread::FileThread):
        (WebCore::FileThread::~FileThread):
        (WebCore::FileThread::start):
        (WebCore::FileThread::stop):
        (WebCore::FileThread::postTask):
        (WebCore::SameFilePredicate::SameFilePredicate):
        (WebCore::SameFilePredicate::operator()):
        (WebCore::FileThread::removeTask):
        (WebCore::FileThread::fileThreadStart):
        (WebCore::FileThread::runLoop):
        * html/FileThread.h: Added.
        (WebCore::FileThread::create):
        (WebCore::FileThread::Task::Task):
        (WebCore::FileThread::Task::~Task):
        (WebCore::FileThread::Task::fileHandle):
        * platform/Logging.cpp:
        (WebCore::):
        (WebCore::getChannelFromName):
        * platform/Logging.h:

1202 1203 1204 1205 1206 1207 1208 1209
2010-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed. Rollout of http://trac.webkit.org/changeset/56930
        https://bugs.webkit.org/show_bug.cgi?id=36977

        * accessibility/AccessibilityImageMapLink.cpp:
        (WebCore::AccessibilityImageMapLink::accessibilityDescription):

1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234
2010-04-01  MORITA Hajime  <morrita@google.com>

        Reviewed by Darin Adler.

        WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer
        https://bugs.webkit.org/show_bug.cgi?id=31680
        Ownerless nodes leads a crash on DOMSelection APIs
        https://bugs.webkit.org/show_bug.cgi?id=36800

        Added guards nodes from foreign documents to DOMSelection APIs.

        Tests: editing/selection/DOMSelection-DocumentType.html
               editing/selection/DOMSelection-crossing-document.html

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::canonicalPosition):
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::collapse):
        (WebCore::DOMSelection::setBaseAndExtent):
        (WebCore::DOMSelection::setPosition):
        (WebCore::DOMSelection::extend):
        (WebCore::DOMSelection::containsNode):
        (WebCore::DOMSelection::isValidForPosition):
        * page/DOMSelection.h:

1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253
2010-04-01  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Fix a NULL pointer crash if @import fails to load a stylesheet.

        https://bugs.webkit.org/show_bug.cgi?id=36804

        Test: fast/xsl/xslt-bad-import-uri.html

        * xml/XSLStyleSheetLibxslt.cpp:
        (WebCore::XSLStyleSheet::parseString):
          Handle an empty string gracefully. An empty string has a NULL
          buffer, which we pass in to xmlCreateMemoryParserCtxt(). It returns
          NULL if it is passed a NULL buffer.
          In the top-level XSL case, the current code does not crash "by luck"
          because the other APIs used can handle a NULL argument. In the
          @import case, additional code runs which will deference the NULL.

ap@apple.com's avatar
ap@apple.com committed
1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267
2010-04-01  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=36854
        <rdar://problem/7811668> REGRESSION (r47291): Body from cross origin preflight response
        is prepended to the actual response body

        Tests: http/tests/xmlhttprequest/access-control-response-with-body-sync.html
               http/tests/xmlhttprequest/access-control-response-with-body.html

        * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveData):
        Don't send data to the client when handling a preflight request.

1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281
2010-04-01  Ada Chan  <adachan@apple.com>

        Reviewed by Darin Adler.
        
        Change DatabaseTracker::deleteOrigin() to return true if there are no errors in deleting the origin.
        Ditto for DatabaseTracker::deleteDatabase().
        
        https://bugs.webkit.org/show_bug.cgi?id=36988

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::deleteOrigin):
        (WebCore::DatabaseTracker::deleteDatabase):
        * storage/DatabaseTracker.h:

1282 1283 1284 1285 1286 1287 1288 1289 1290 1291
2010-04-01  Simon Fraser  <simon.fraser@apple.com>

        No review.

        Remove some casts that I indended to remove before committing r56948.

        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeRenderObject):
        (WebCore::write):

1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318
2010-04-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Assertion failure (willBeComposited == needsToBeComposited(layer)) in
        RenderLayerCompositor::computeCompositingRequirements() on hulu.com
        https://bugs.webkit.org/show_bug.cgi?id=36516
        
        Fix assertions added in r56017. That changed replaced calls to needsToBeComposited()
        with use of the local 'willBeComposited' variable, but that fails to take into
        account the fact that needsToBeComposited() also tests layer->isSelfPaintingLayer().
        
        Fix by adding a canBeComposited() method that we call before testing
        whether the layer should go into compositing mode.

        Test: compositing/self-painting-layers2.html

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::calculateCompositedBounds): Repace use of isSelfPaintingLayer()
        with a call to canBeComposited().
        (WebCore::RenderLayerCompositor::computeCompositingRequirements): Call canBeComposited() to ensure
        that we only toggle 'willBeComposited' for layers that can.
        (WebCore::RenderLayerCompositor::needsToBeComposited): Call canBeComposited().
        (WebCore::RenderLayerCompositor::canBeComposited): Test if compositing is enabled, and whether
        the layer is self-painting.
        * rendering/RenderLayerCompositor.h: Add canBeComposited().

1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338
2010-04-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=36980
        Add object addresses to debug showLayerTree() output.
        
        Add the ability to print RenderLayer and RenderObject addresses in the showLayerTree()
        output.

        * platform/text/TextStream.cpp:
        (WebCore::TextStream::operator<<):
        * platform/text/TextStream.h:
        * rendering/RenderLayer.cpp:
        (showLayerTree):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeRenderObject):
        (WebCore::write):
        * rendering/RenderTreeAsText.h:

1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351
2010-03-29  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Dimitri Glazkov.

        Changing SQLiteStatement::prepare() to return an error when it's
        given a string that has more than one statement in it. Currently,
        everything past the first statement is silently ignored.

        Test: storage/executesql-accepts-only-one-statement.html

        * platform/sql/SQLiteStatement.cpp:
        (WebCore::SQLiteStatement::prepare):

1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382
2010-04-01  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Keeps a transient optimistic offset to the root in RenderLayer::updateLayerPositions
        https://bugs.webkit.org/show_bug.cgi?id=33520

        RenderLayer::updateLayerPositions() makes a recursive walk through all RenderLayers and updates the repaint rectangles on each.
        These rectangles have to be calculated in the repaint container's coordinates using RenderObject::mapLocalToContainer to walk
        up to the repaint container.  This patch keeps track of the offset to the root and uses that offset instead of walking back up to
        the root every time.

        Tests: fast/layers/nested-layers-1.html
               fast/layers/nested-layers-2.html
               fast/layers/nested-layers-3.html
               fast/layers/nested-layers-4.html

        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::outlineBoundsForRepaint):
        * rendering/RenderBox.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):
        * rendering/RenderLayer.h:
        * rendering/RenderObject.h:
        (WebCore::RenderObject::outlineBoundsForRepaint):
        * rendering/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
        * rendering/RenderSVGModelObject.h:

1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403
2010-04-01  Daniel Bates  <dbates@rim.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=36901

        Removed functions Range::operator == and Range::operator != as they
        were using C++ code that was not sound and hence may have undefined
        behavior.

        Test case: manual-tests/crash-on-find-with-no-selection.html

        * dom/Range.cpp:
        (WebCore::areRangesEqual): Added.
        * dom/Range.h:
        * editing/markup.cpp:
        (WebCore::createMarkup): Modified to call WebCore::areRangesEqual.
        * manual-tests/crash-on-find-with-no-selection.html: Added.
        * page/Frame.cpp:
        (WebCore::Frame::findString): Modified to call WebCore::areRangesEqual.

1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439
2010-04-01  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Synchronous rendering when setting form control values slows down JavaScript
        https://bugs.webkit.org/show_bug.cgi?id=36967

        This patch basically reverts http://trac.webkit.org/changeset/19006.
        
        Dan asked me to investigate why 19006 is no longer needed. I have two answers:

            (1) I was also able to remove the synchronous call to updateFromElement().
            That call was the proximate cause of the crash that 19006 fixed.

            (2) updateFromElement() no longer calls HTMLElement::setInnerText()
            in the way that it used to. (However, it doesn't seem prudent to
            rely on this happy coincidence.)

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setValue): Simplified some logic here. Moved
        setNeedsValidityCheck() outside of individual 'if' clauses, since they all
        called it.
        
        Removed call to updateStyleIfNeeded(), which does rendering synchronously,
        since that was the performance problem. (setNeedsStyleRecalc() ensures
        that rendering will happen asynchronously.) Also removed comment about
        ordering dangers introduced by updateStyleIfNeeded().
        
        Removed call to updateFromElement(), since it's dangerous and also a minor
        performance problem. (setNeedsStyleRecalc() ensures that updateFromElement()
        will happen asynchronously, too.)

        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::setNonDirtyValue): Ditto. Here, I had to
        add a call to setNeedsStyleRecalc(), since there wasn't one before.

1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455
2010-04-01  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Sometimes js code can detach page from it's frame and in that case
        Dispatch Events will stay in the TimelineAgent's events stack. Only immediate events will
        appear at frontend.
        https://bugs.webkit.org/show_bug.cgi?id=36890

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::callFunction):
        * dom/Node.cpp:
        (WebCore::Node::dispatchGenericEvent):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchEvent):

1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467
2010-04-01  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        Bug 36977 - aria-label doesn't work on image map area
        https://bugs.webkit.org/show_bug.cgi?id=36977

        Test: platform/mac/accessibility/area-with-aria-label.html

        * accessibility/AccessibilityImageMapLink.cpp:
        (WebCore::AccessibilityImageMapLink::accessibilityDescription):

1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487
2010-04-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Assertion failure: !repaintContainer || repaintContainer == this
        https://bugs.webkit.org/show_bug.cgi?id=36672
        
        RenderText's implementation of clippedOverflowRectForRepaint() uses containingBlock()
        to get the renderer to use for computing the repaint rect. However, the renderer returned
        by containingBlock() may be an ancestor of the repaintContainer, and containingBlock()
        doesn't have the 'repaintContainerSkipped' logic that container() has.
        
        So in this case, check to see whether repaintContainer is actually a descendant of the
        containing block, and in that case just repaint the entire repaintContainer.

        Test: compositing/repaint/inline-repaint-container.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::clippedOverflowRectForRepaint):

1488 1489 1490 1491 1492 1493 1494 1495 1496 1497
2010-04-01  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Jian Li.

        [Qt] REGRESSION(r56869): Windows build is broken
        https://bugs.webkit.org/show_bug.cgi?id=36929

        * WebCore.pro: LIBS += -lOle32 added.
        * platform/UUID.cpp: Define ARRAYSIZE macro if it isn't defined before.

1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512
2010-04-01  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        Bug 36968 - 1 crash in Safari at com.apple.WebCore: WebCore::Element::getAttribute const
        https://bugs.webkit.org/show_bug.cgi?id=36968

        Test: accessibility/crash-with-noelement-selectbox.html

        When a <select> element had no options, the selectedIndex == -1 and that was being
        used to index into an empty array.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::stringValue):

1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529
2010-04-01  MORITA Hajime  <morrita@google.com>

        Reviewed by Shinichiro Hamaji.

        https://bugs.webkit.org/show_bug.cgi?id=36948
        Refactoring: Position::primaryDirection() should be extracted.

        No new tests. No functinal change.

        * dom/Position.cpp:
        (WebCore::Position::getInlineBoxAndOffset):
        (WebCore::Position::primaryDirection): Added
        * dom/Position.h:
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
        (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):

1530 1531 1532 1533 1534 1535 1536 1537 1538 1539
2010-04-01  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Audits: fix parsing of injected script-evaluated result for CssInHeadRule
        https://bugs.webkit.org/show_bug.cgi?id=36952

        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun):

1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563
2010-03-31  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Misc IndexedDatabase cleanup
        https://bugs.webkit.org/show_bug.cgi?id=36889

        No functional changes.

        * bindings/v8/custom/V8CustomIDBCallbacks.h:  
        (WebCore::V8CustomIDBCallbacks::onSuccess):
        (WebCore::V8CustomIDBCallbacks::onError):
        (WebCore::V8CustomIDBCallbacks::V8CustomIDBCallbacks):
            Get rid of 2 largely redundant bools

        * storage/IndexedDatabase.h:
        * storage/IndexedDatabaseImpl.cpp:
        (WebCore::IndexedDatabaseImpl::open):
        * storage/IndexedDatabaseImpl.h:
        * storage/IndexedDatabaseRequest.cpp:
        (WebCore::IndexedDatabaseRequest::open):
        * storage/IndexedDatabaseRequest.h:
            Plumb the Frame* and style cleanups.

1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613
2010-03-31  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        REGRESSION: document.documentElement.getScreenCTM() returns incorrect matrix.
        https://bugs.webkit.org/show_bug.cgi?id=27183

        Rewrite getCTM() / getScreenCTM() handling in an iterative way, fixing all known problems/limitations.
        The bug mentioned above is actually not a regression, getScreenCTM() only worked before, because we
        did not handle non-SVG CSS box parents properly. When support was added to handle those cases, the
        getScreenCTM() handling was completly off, causing a lot of trouble in real-life SVG applications (carto.net for instance)

        Tests: svg/custom/svgsvgelement-ctm.xhtml (fixed typo, missing unit identifier in CSS 'height' property, leading to incorrect results)
               svg/custom/svgsvgelement-ctm2.xhtml
               svg/custom/svgsvgelement-ctm3.xhtml
               svg/custom/svgsvgelement-ctm4.xhtml
               svg/custom/svgsvgelement-ctm5.xhtml

        * svg/SVGLocatable.cpp:
        (WebCore::SVGLocatable::getBBox):
        (WebCore::SVGLocatable::computeCTM):
        * svg/SVGLocatable.h:
        (WebCore::SVGLocatable::localCoordinateSpaceTransform):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::localCoordinateSpaceTransform):
        (WebCore::SVGSVGElement::createRenderer):
        * svg/SVGSVGElement.h:
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::localCoordinateSpaceTransform):
        * svg/SVGStyledElement.h:
        * svg/SVGStyledLocatableElement.cpp:
        (WebCore::SVGStyledLocatableElement::getCTM):
        (WebCore::SVGStyledLocatableElement::getScreenCTM):
        * svg/SVGStyledLocatableElement.h:
        (WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform):
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::getCTM):
        (WebCore::SVGStyledTransformableElement::getScreenCTM):
        * svg/SVGStyledTransformableElement.h:
        (WebCore::SVGStyledTransformableElement::localCoordinateSpaceTransform):
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::getCTM):
        (WebCore::SVGTextElement::getScreenCTM):
        * svg/SVGTextElement.h:
        (WebCore::SVGTextElement::localCoordinateSpaceTransform):
        * svg/SVGTransformable.cpp:
        (WebCore::SVGTransformable::SVGTransformable):
        * svg/SVGTransformable.h:
        (WebCore::SVGTransformable::localCoordinateSpaceTransform):

1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625
2010-04-01  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Darin Fisher.

        [V8] Quick fix for failure in SerializedScriptValue
        https://bugs.webkit.org/show_bug.cgi?id=36943

        This allows the web worker layout tests to pass again.

        * bindings/v8/SerializedScriptValue.h:
        (WebCore::SerializedScriptValue::deserializeAndSetProperty):

1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643
2010-03-31  MORITA Hajime  <morrita@google.com>
        
        Reviewed by Darin Adler.

        Crash when writing into a detached TITLE element
        https://bugs.webkit.org/show_bug.cgi?id=25567
        
        Document::setTitle() invoked HTMLTitleElement::setText(), which
        contains DOM tree modification, even when setTitle() is called
        from HTMLTitleElement::childrenChanged().  Fix to skip setText()
        when setTitle() is called childrenChanged() to avoid cascading
        DOM mutations between Document and HTMLTitleElement.

        Test: fast/dom/title-content-write-set.html

        * dom/Document.cpp:
        (WebCore::Document::setTitle):

1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658
2010-04-01  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Darin Adler.

        Bug 36803 - 'Inline-table' workaround for <ruby> broken with ruby support
        https://bugs.webkit.org/show_bug.cgi?id=36803

        Don't use ruby rendering if the underlying 'display' property has been
        changed into a value other than 'inline' or 'block' (such as 'inline-table').

        Test: fast/ruby/ruby-inline-table.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createObject):

1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676
2010-03-31  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Crash submitting display:none textarea in a form
        https://bugs.webkit.org/show_bug.cgi?id=36905

        Test: fast/forms/textarea-submit-crash.html

        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::appendFormData): Do update layout before
        asking our renderer for its text, since we can't rely on our renderer's
        text if layout is needed.

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::textWithHardLineBreaks): Don't update layout
        while being asked for our text, since doing so may delete us, causing a crash.

1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694
2010-03-31  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Bug 36845 - AX: need a way to set the label of a AXWebArea through WebKit
        https://bugs.webkit.org/show_bug.cgi?id=36845

        Provide a way through WebKit to set an accessible label that describes the web area.

        Test: platform/mac/accessibility/html-with-aria-label.html

        * accessibility/AccessibilityObject.h:
        (WebCore::AccessibilityObject::setAccessibleName):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::accessibilityDescription):
        (WebCore::AccessibilityRenderObject::setAccessibleName):
        * accessibility/AccessibilityRenderObject.h:

1695 1696 1697 1698 1699 1700 1701 1702 1703 1704
2010-03-31  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin Adler.

        <http://webkit.org/b/36878> REGRESSION: Trailing colon on hostnames (with no port specified) causes "Not allowed to use restricted network port"

        * platform/KURL.cpp:
        (WebCore::KURL::port): Explicitly handle the case of a colon being present in the URL after the host name but with
        no port number before the path.  This is handled in the same manner as the colon and port being omitted completely.

1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737
2010-03-31  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Remove dependency on TextBreakIterator from StringImpl.cpp,
        and from member methods of String.

        Make 'numGraphemeClusters' & 'numCharactersInGraphemeClusters'
        global function defined in PlatformString.h, rather than
        member methods on String (these can be implemented purely
        using the characters() and length() public interface),
        and make 'makeCapitalized' a static function in RenderText.cpp.

        * dom/InputElement.cpp:
        (WebCore::InputElement::sanitizeUserInputValue):
        (WebCore::InputElement::handleBeforeTextInsertedEvent):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::tooLong):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
        (WebCore::HTMLTextAreaElement::sanitizeUserInputValue):
        (WebCore::HTMLTextAreaElement::tooLong):
        * platform/text/PlatformString.h:
        (WebCore::String::makeSecure):
        * platform/text/String.cpp:
        (WebCore::numGraphemeClusters):
        (WebCore::numCharactersInGraphemeClusters):
        * platform/text/StringImpl.cpp:
        * platform/text/StringImpl.h:
        * rendering/RenderText.cpp:
        (WebCore::makeCapitalized):
        (WebCore::RenderText::setTextInternal):

1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765
2010-03-31  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by David Levin.

        [V8] SerializedScriptValue must be deserialized only once and in the right context
        https://bugs.webkit.org/show_bug.cgi?id=36892

        See also https://bugs.webkit.org/show_bug.cgi?id=34227 for the
        corresponding JSC change.

        General idea: SerializedScriptValue must be deserialized only once
        and in the context of the intended MessageEvent recepient. The
        approach we take for now is to eagerly deserialize when a
        JavaScript wrapper for MessageEvent is created.

        A better fix would be to keep a reference to the context in
        MessageEvent and use it when lazily deserializing. It's harder to
        do since the API doesn't have a clean method to have such a reference.

        Tested by fast/dom/Window/window-postmessage-clone-frames.html. This
        test still fails but only for the types which we can't serialize yet.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/SerializedScriptValue.h:
        (WebCore::SerializedScriptValue::deserializeAndSetProperty):
        * bindings/v8/custom/V8MessageEventCustom.cpp:
        (WebCore::V8MessageEvent::initMessageEventCallback):

1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823
2010-03-31  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        Cleanup RedirectScheduler
        https://bugs.webkit.org/show_bug.cgi?id=36874

        Removed the nutty ScheduledRedirection struct in favor of a hierarchy
        of classes to represent the various kinds of scheduled redirects.
        Doing this lets us get rid of the pseudo RTTI switch statements on
        "type" in favour of calling virtual functions.

        No new tests because this change should be API identical with the
        existing RedirectScheduler.

        * loader/RedirectScheduler.cpp:
        (WebCore::ScheduledNavigation::ScheduledNavigation):
        (WebCore::ScheduledNavigation::~ScheduledNavigation):
        (WebCore::ScheduledNavigation::isLocationChange):
        (WebCore::ScheduledNavigation::shouldStartTimer):
        (WebCore::ScheduledNavigation::didStartTimer):
        (WebCore::ScheduledNavigation::didStopTimer):
        (WebCore::ScheduledNavigation::delay):
        (WebCore::ScheduledNavigation::lockHistory):
        (WebCore::ScheduledNavigation::lockBackForwardList):
        (WebCore::ScheduledNavigation::wasDuringLoad):
        (WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
        (WebCore::ScheduledURLNavigation::fire):
        (WebCore::ScheduledURLNavigation::didStartTimer):
        (WebCore::ScheduledURLNavigation::didStopTimer):
        (WebCore::ScheduledURLNavigation::url):
        (WebCore::ScheduledURLNavigation::referrer):
        (WebCore::ScheduledURLNavigation::wasUserGesture):
        (WebCore::ScheduledRedirect::ScheduledRedirect):
        (WebCore::ScheduledRedirect::isLocationChange):
        (WebCore::ScheduledRedirect::shouldStartTimer):
        (WebCore::ScheduledLocationChange::ScheduledLocationChange):
        (WebCore::ScheduledRefresh::ScheduledRefresh):
        (WebCore::ScheduledRefresh::fire):
        (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
        (WebCore::ScheduledHistoryNavigation::fire):
        (WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
        (WebCore::ScheduledFormSubmission::fire):
        (WebCore::RedirectScheduler::redirectScheduledDuringLoad):
        (WebCore::RedirectScheduler::clear):
        (WebCore::RedirectScheduler::scheduleRedirect):
        (WebCore::RedirectScheduler::mustLockBackForwardList):
        (WebCore::RedirectScheduler::scheduleLocationChange):
        (WebCore::RedirectScheduler::scheduleFormSubmission):
        (WebCore::RedirectScheduler::scheduleRefresh):
        (WebCore::RedirectScheduler::locationChangePending):
        (WebCore::RedirectScheduler::scheduleHistoryNavigation):
        (WebCore::RedirectScheduler::timerFired):
        (WebCore::RedirectScheduler::schedule):
        (WebCore::RedirectScheduler::startTimer):
        (WebCore::RedirectScheduler::cancel):
        * loader/RedirectScheduler.h:

1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849
2010-03-31  Zhenyao Mo  <zmo@google.com>

        Reviewed by Darin Fisher.

        Hook up WebGLContextAttributes to OpenGL context creation code
        https://bugs.webkit.org/show_bug.cgi?id=33416

        Test: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html

        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Fix an index bug.
        (WebCore::V8HTMLCanvasElement::getContextCallback):
        * platform/graphics/GraphicsContext3D.h: Add members/functions for multisampling/stencil buffer purpose.
        * platform/graphics/mac/Canvas3DLayer.h: Add GraphicsContext3D as a member of Canvas3DLayer.
        * platform/graphics/mac/Canvas3DLayer.mm: Add multisampling support.
        (-[Canvas3DLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]):
        * platform/graphics/mac/GraphicsContext3DMac.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Mac.
        (WebCore::GraphicsContext3D::GraphicsContext3D):
        (WebCore::GraphicsContext3D::~GraphicsContext3D):
        (WebCore::GraphicsContext3D::validateAttributes):
        (WebCore::GraphicsContext3D::reshape):
        (WebCore::GraphicsContext3D::prepareTexture):
        (WebCore::GraphicsContext3D::bindFramebuffer):
        (WebCore::GraphicsContext3D::readPixels):
        * platform/graphics/mac/GraphicsLayerCA.mm: Adjust to modified Canvas3DLayer init call.
        (WebCore::GraphicsLayerCA::setContentsToGraphicsContext3D):

1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865
2010-03-31  Jian Li  <jianli@chromium.org>

        Reviewed by Dmitry Titov.

        Add support to create UUID string.
        https://bugs.webkit.org/show_bug.cgi?id=36472

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/UUID.cpp: Added.
        (WebCore::createCanonicalUUIDString):
        * platform/UUID.h: Added.

1866 1867 1868 1869
2010-03-31  Darin Adler  <darin@apple.com>

        * rendering/RenderThemeChromiumWin.h: Fix inconsistent line endings.

1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906
2010-03-31  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Maemo5 theme - form controls style
        https://bugs.webkit.org/show_bug.cgi?id=36370

        Adjusting Mameo5 form elements rendering.

        * WebCore.pri:
        * WebCore.pro:
        * css/themeQtMaemo5.css: Added.
        (select):
        (select:disabled):
        (select:active):
        (select:active:disabled):
        (textarea):
        (textarea:disabled):
        (textarea:active):
        * platform/qt/Maemo5Webstyle.cpp: Added.
        (Maemo5WebStyle::Maemo5WebStyle):
        (drawRectangularControlBackgorund):
        (Maemo5WebStyle::drawChecker):
        (Maemo5WebStyle::findChecker):
        (Maemo5WebStyle::drawRadio):
        (Maemo5WebStyle::findRadio):
        (Maemo5WebStyle::drawControl):
        (Maemo5WebStyle::drawComplexControl):
        * platform/qt/Maemo5Webstyle.h: Added.
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::RenderThemeQt):
        (WebCore::RenderThemeQt::isControlStyled):
        (WebCore::RenderThemeQt::popupInternalPaddingBottom):
        (WebCore::RenderThemeQt::extraDefaultStyleSheet):
        (WebCore::RenderThemeQt::adjustMenuListButtonStyle):
        * platform/qt/RenderThemeQt.h:

1907 1908 1909 1910 1911 1912 1913 1914 1915 1916
2010-03-31  Alexey Proskuryakov  <ap@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=36897
        <rdar://problem/7804018> REGRESSION (r56429): Flash ads are clipped when main page is scrolled (boxofficemojo.com)

        Addressing additional review comments.

        * rendering/RenderWidget.cpp: Removed an unneeded include.
        * rendering/RenderWidget.h: Reworded the new comment.

ap@apple.com's avatar
ap@apple.com committed
1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936
2010-03-31  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=36897
        <rdar://problem/7804018> REGRESSION (r56429): Flash ads are clipped when main page is scrolled (boxofficemojo.com)

        * manual-tests/plugin-in-iframe-scroll.html: Added.
        * manual-tests/resources/plugin-in-iframe-scroll-iframe.html: Added.

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::setWidgetGeometry): This method isn't called when an iframe containing
        the widget moves, so we should store a value that is not dependent on current scroll offset.
        (WebCore::RenderWidget::windowClipRect): Apply scroll offset and window clip now.

        * rendering/RenderWidget.h: Renamed m_windowClipRect to m_clipRect, because it is no longer
        in window coordinates.

        * WebCore.base.exp: Export RenderWidget::windowClipRect(), since it's no longer inline.

kenneth@webkit.org's avatar
kenneth@webkit.org committed
1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951
2010-03-31  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Unreviewed crash fix.

        Crash with frame flattening on after r56854
        https://bugs.webkit.org/show_bug.cgi?id=36894

        Solution tested by Greg Bolsinga, thanks.

        * page/FrameView.cpp:
        (WebCore::FrameView::avoidScrollbarCreation):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::setHasHorizontalScrollbar):
        (WebCore::ScrollView::setHasVerticalScrollbar):

1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978
2010-03-31  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Antti Koivisto.

        iframe flattening doesn't flatten
        https://bugs.webkit.org/show_bug.cgi?id=36798

        Do not draw scrollbars for subframes when frame flattening is
        enabled. Implemented using a virtual method in ScrollView as
        suggested by Dave Hyatt.

        Do not suppress scrollbars as that is wrong according to
        Dave Hyatt.

        Covered by current tests.

        * page/FrameView.cpp:
        (WebCore::FrameView::avoidScrollbarCreation):
        * page/FrameView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::setHasHorizontalScrollbar):
        (WebCore::ScrollView::setHasVerticalScrollbar):
        * platform/ScrollView.h:
        (WebCore::ScrollView::avoidScrollbarCreation):
        * rendering/RenderPart.cpp:
        (WebCore::RenderPart::layoutWithFlattening):

1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996
2010-03-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Antti Koivisto.

        iframe flattening doesn't flatten
        https://bugs.webkit.org/show_bug.cgi?id=36798

        Fix wrongly reversing logic in frame flattening check.

        Tests:
        fast/frames/flattening/iframe-flattening-fixed-height.html
        fast/frames/flattening/iframe-flattening-fixed-width.html
        fast/frames/flattening/iframe-flattening-fixed-width-and-height.html
        fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html

        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::flattenFrame):

1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015
2010-03-31  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Implements cancelGeolocationPermissionRequestForFrame.
        Similar to requestGeolocationPermissionForFrame(), passes Geolocation* to cancelGeolocationPermissionRequestForFrame(),
        so that the embedder can identify which Geolocation object is cancelling the pending permission request.
        Calls cancelGeolocationPermissionRequestForFrame() before stopUpdating() so it better matches the startUpdating() / requestPermission() flow.
        https://bugs.webkit.org/show_bug.cgi?id=35031

        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::cancelGeolocationPermissionRequestForFrame):
        * page/Chrome.cpp:
        (WebCore::Chrome::cancelGeolocationPermissionRequestForFrame):
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/Geolocation.cpp:
        (WebCore::Geolocation::disconnectFrame):

2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049
2010-03-31  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antti Koivisto.

        Add animation to progress element
        https://bugs.webkit.org/show_bug.cgi?id=36664

        Add a timer to control the animation. The timer is started after painting
        or a state change in the progress bar, to prevent animation from running
        when the progress bar is not visible.

        * html/HTMLProgressElement.cpp:
        (WebCore::HTMLProgressElement::createRenderer):
        * manual-tests/dom: Added.
        * manual-tests/dom/progressbar.html: Added.
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::animationRepeatIntervalForProgressBar):
        (WebCore::RenderThemeQt::animationDurationForProgressBar):
        (WebCore::RenderThemeQt::paintProgressBar):
        * platform/qt/RenderThemeQt.h:
        * rendering/RenderProgress.cpp:
        (WebCore::RenderProgress::RenderProgress):
        (WebCore::RenderProgress::layout):
        (WebCore::RenderProgress::updateFromElement):
        (WebCore::RenderProgress::animationProgress):
        (WebCore::RenderProgress::animationTimerFired):
        (WebCore::RenderProgress::paint):
        (WebCore::RenderProgress::updateAnimationState):
        * rendering/RenderProgress.h:
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::animationRepeatIntervalForProgressBar):
        (WebCore::RenderTheme::animationDurationForProgressBar):
        * rendering/RenderTheme.h:

2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061
2010-03-31  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Rolling out r56829 since it broke chromium layout tests.

        [REGRESSION] Inspector tests started crashing since r56829
        https://bugs.webkit.org/show_bug.cgi?id=36888

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8Utilities.cpp:
        * bindings/v8/V8Utilities.h:
        * loader/FrameLoaderClient.h:

2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092
2010-03-31  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: creating new style bugfixing.

        https://bugs.webkit.org/show_bug.cgi?id=36884

        - InspectorDOMAgent should clear internal state upon reset (we are re-using
          single dom agent instance throughout entire inspector controller lifetime) 
        - Brought back blank style 'refresh' processing logic - remove it by mistake earlier
        - Blocked couple of click handlers so that double-click to edit was not
          expanding / collapsing the pane
        - There is no need to reach out for matched rules upon 'refresh' update -
          getting computed style is sufficient.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::matchRulesForList):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::discardBindings):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype.update.getStylesCallback):
        (WebInspector.StylesSidebarPane.prototype.update.getComputedStyleCallback):
        (WebInspector.StylesSidebarPane.prototype.update):
        (WebInspector.StylesSidebarPane.prototype._refreshUpdate):
        (WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
        (WebInspector.StylesSidebarPane.prototype._refreshStyleRules):
        (WebInspector.StylesSidebarPane.prototype.addBlankSection):
        (WebInspector.StylePropertiesSection.prototype._dblclickEmptySpace):
        (WebInspector.StylePropertiesSection.prototype._clickSelector):

2093 2094 2095 2096 2097 2098 2099 2100 2101
2010-03-31  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Chromium build fix: create missing v8::HandleScope.

        https://bugs.webkit.org/show_bug.cgi?id=36828

        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::canAccessInspectedWindow):

2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119
2010-03-31  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Check that injected script can still access inspected window object when wrapping console object. When the window cannot be access serialize objects as strings. Also don't call InjectedScript.dispatch if the window cannot be accessed (due to frame navigation).

        https://bugs.webkit.org/show_bug.cgi?id=36828

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::canAccessInspectedWindow):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::canAccessInspectedWindow):
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::wrapForConsole):
        * inspector/InjectedScriptHost.h:
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):

2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135
2010-03-31  Mattias Nissler  <mnissler@google.com>

        Reviewed by Pavel Feldman.

        Allow generic resource URLs for cookie handling in the inspector. This
        enables display of all cookies, not only those that are associated
        with resources accessed through http, https or file.
        https://bugs.webkit.org/show_bug.cgi?id=36877

        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.Cookies.cookieMatchesResourceURL):
        * inspector/front-end/inspector.js:
        (WebInspector.updateResource):

2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163
2010-03-30  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        IndexedDB: Finish hooking up bindings for IndexedDatabaseRequest
        https://bugs.webkit.org/show_bug.cgi?id=36830

        Still not enough hooked up to test.  Soon!

        * WebCore.gypi:
        * bindings/v8/custom/V8CustomIDBCallback.h: Removed.
        * bindings/v8/custom/V8CustomIDBCallbacks.h: Added.
        (WebCore::V8CustomIDBCallbacks::create):
        (WebCore::V8CustomIDBCallbacks::~V8CustomIDBCallbacks):
        (WebCore::V8CustomIDBCallbacks::onSuccess):
        (WebCore::V8CustomIDBCallbacks::onError):
        (WebCore::V8CustomIDBCallbacks::V8CustomIDBCallbacks):
        * bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:
        (WebCore::V8IndexedDatabaseRequest::openCallback):
        * storage/IDBDatabaseRequest.cpp: Added.
        (WebCore::IDBDatabaseRequest::IDBDatabaseRequest):
        (WebCore::IDBDatabaseRequest::~IDBDatabaseRequest):
        * storage/IDBDatabaseRequest.h:
        (WebCore::IDBDatabaseRequest::create):
        * storage/IndexedDatabaseRequest.cpp:
        (WebCore::IndexedDatabaseRequest::open):
        * storage/IndexedDatabaseRequest.h:

2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175
2010-03-31  Zhenyao Mo  <zmo@google.com>

        Reviewed by Darin Fisher.

        Implement memmove behavior for WebGLArray set()
        https://bugs.webkit.org/show_bug.cgi?id=35619

        New test cases are added to fast/canvas/webgl/array-setters.html.

        * html/canvas/WebGLArray.cpp: Use memmove instead of memcpy; with memmove, copying takes place as if an intermediate buffer was used, allowing the destination and source to overlap.
        (WebCore::WebGLArray::setImpl):

2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188
2010-03-31  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Darin Adler.

        tryLayoutDoingPositionedMovementOnly does not have to be in RenderObject or be virtual
        https://bugs.webkit.org/show_bug.cgi?id=36810

        Move tryLayoutDoingPositionedMovementOnly as a regular method of RenderBox

        * rendering/RenderBox.h:
        (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
        * rendering/RenderObject.h:

2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204
2010-03-31  John Gregg  <johnnyg@google.com>

        Reviewed by Darin Fisher.

        [chromium] add logging of cross-frame property accesses for site isolation
        https://bugs.webkit.org/show_bug.cgi?id=35773

        No new tests as no new functionality.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8Utilities.cpp:
        (WebCore::logPropertyAccess):
        * bindings/v8/V8Utilities.h:
        * loader/FrameLoaderClient.h:
        (WebCore::FrameLoaderClient::logCrossFramePropertyAccess):

2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418
2010-03-30  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=36866
        Move CString to WTF

        * Android.mk:
        * ForwardingHeaders/wtf/text: Added.
        * ForwardingHeaders/wtf/text/CString.h: Added.
        * GNUmakefile.am:
        * WebCore.base.exp:
        * WebCore.gypi:
        * WebCore.order:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        * bindings/js/JSDOMWindowBase.cpp:
        * bindings/js/ScheduledAction.cpp:
        * bindings/js/ScriptController.cpp:
        * bindings/v8/ScriptController.cpp:
        * bindings/v8/V8Binding.cpp:
        * bindings/v8/V8DOMWindowShell.cpp:
        * bridge/jni/JNIBridge.cpp:
        * bridge/jni/v8/JavaStringV8.h:
        (JSC::Bindings::JavaStringImpl::init):
        * css/CSSParser.cpp:
        * dom/CharacterData.cpp:
        * dom/Document.cpp:
        * dom/Element.cpp:
        * dom/Node.cpp:
        * dom/Position.cpp:
        * dom/Range.cpp:
        * dom/Text.cpp:
        * dom/XMLTokenizer.cpp:
        * dom/XMLTokenizerLibxml2.cpp:
        * dom/XMLTokenizerQt.cpp:
        * editing/SelectionController.cpp:
        * editing/VisiblePosition.cpp:
        * editing/VisibleSelection.cpp:
        * history/CachedFrame.cpp:
        * history/HistoryItem.cpp:
        * history/qt/HistoryItemQt.cpp:
        * html/FormDataList.h:
        (WebCore::FormDataList::appendData):
        (WebCore::FormDataList::Item::Item):
        (WebCore::FormDataList::Item::data):
        * html/HTMLDocument.cpp:
        * html/PreloadScanner.cpp:
        * inspector/InspectorController.cpp:
        * inspector/InspectorDOMAgent.cpp:
        * loader/DocLoader.cpp:
        * loader/FTPDirectoryDocument.cpp:
        * loader/FrameLoader.cpp:
        * loader/HistoryController.cpp:
        * loader/ProgressTracker.cpp:
        * loader/appcache/ApplicationCacheStorage.cpp:
        * loader/archive/cf/LegacyWebArchive.cpp:
        * loader/icon/wince/IconDatabaseWince.cpp:
        * loader/loader.cpp:
        * page/Console.cpp:
        * page/DOMWindow.cpp:
        * page/SecurityOrigin.cpp:
        * page/XSSAuditor.cpp:
        * page/animation/AnimationBase.cpp:
        * platform/ContextMenu.cpp:
        * platform/FileSystem.h:
        * platform/KURL.cpp:
        * platform/KURLGoogle.cpp:
        * platform/KURLGooglePrivate.h:
        * platform/Pasteboard.h:
        * platform/android/FileSystemAndroid.cpp:
        * platform/android/TemporaryLinkStubs.cpp:
        * platform/brew/KURLBrew.cpp:
        * platform/cf/FileSystemCF.cpp:
        * platform/chromium/MIMETypeRegistryChromium.cpp:
        * platform/efl/FileSystemEfl.cpp:
        * platform/efl/PasteboardEfl.cpp:
        * platform/efl/PlatformKeyboardEventEfl.cpp:
        * platform/efl/PlatformScreenEfl.cpp:
        * platform/efl/RenderThemeEfl.cpp:
        * platform/efl/ScrollbarEfl.cpp:
        * platform/efl/SharedBufferEfl.cpp:
        * platform/efl/WidgetEfl.cpp:
        * platform/graphics/GlyphPageTreeNode.cpp:
        * platform/graphics/cairo/FontPlatformDataCairo.cpp:
        * platform/graphics/cg/ImageBufferCG.cpp:
        * platform/graphics/chromium/FontCacheLinux.cpp:
        * platform/graphics/chromium/FontPlatformDataLinux.h:
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        * platform/graphics/gtk/FontPlatformDataPango.cpp:
        * platform/graphics/gtk/IconGtk.cpp:
        * platform/graphics/gtk/ImageGtk.cpp:
        * platform/graphics/haiku/GraphicsContextHaiku.cpp:
        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        * platform/graphics/mac/GraphicsLayerCA.mm:
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        * platform/graphics/qt/ImageBufferQt.cpp:
        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        * platform/graphics/skia/GraphicsLayerSkia.cpp:
        * platform/graphics/win/GraphicsLayerCACF.cpp:
        * platform/graphics/win/WKCACFLayer.cpp:
        * platform/graphics/wx/FontPlatformData.h:
        * platform/gtk/ClipboardGtk.cpp:
        * platform/gtk/ContextMenuItemGtk.cpp:
        * platform/gtk/DataObjectGtk.h:
        * platform/gtk/FileChooserGtk.cpp:
        * platform/gtk/FileSystemGtk.cpp:
        * platform/gtk/GeolocationServiceGtk.cpp:
        * platform/gtk/KURLGtk.cpp:
        * platform/gtk/Language.cpp:
        * platform/gtk/LocalizedStringsGtk.cpp:
        * platform/gtk/PasteboardGtk.cpp:
        * platform/gtk/PopupMenuGtk.cpp:
        * platform/gtk/RenderThemeGtk.cpp:
        * platform/gtk/SharedBufferGtk.cpp:
        * platform/haiku/FileSystemHaiku.cpp:
        * platform/haiku/PlatformKeyboardEventHaiku.cpp:
        * platform/network/CredentialStorage.cpp:
        * platform/network/FormData.cpp:
        * platform/network/FormData.h:
        * platform/network/FormDataBuilder.cpp:
        * platform/network/FormDataBuilder.h:
        * platform/network/HTTPParsers.cpp:
        * platform/network/android/ResourceHandleAndroid.cpp:
        * platform/network/cf/FormDataStreamCFNet.cpp:
        * platform/network/cf/ResourceHandleCFNet.cpp:
        * platform/network/chromium/ResourceResponse.h:
        * platform/network/curl/FormDataStreamCurl.cpp:
        * platform/network/curl/ResourceHandleManager.cpp:
        * platform/network/curl/ResourceHandleManager.h:
        * platform/network/mac/FormDataStreamMac.mm:
        * platform/network/mac/ResourceHandleMac.mm:
        * platform/network/qt/QNetworkReplyHandler.cpp:
        * platform/network/soup/CookieJarSoup.cpp:
        * platform/network/soup/ResourceHandleSoup.cpp:
        * platform/network/soup/ResourceRequestSoup.cpp:
        * platform/network/soup/ResourceResponseSoup.cpp:
        * platform/network/win/ResourceHandleWin.cpp:
        * platform/posix/FileSystemPOSIX.cpp:
        * platform/qt/FileSystemQt.cpp:
        * platform/qt/KURLQt.cpp:
        * platform/qt/TemporaryLinkStubs.cpp:
        * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
        * platform/text/CString.cpp: Removed.
        * platform/text/CString.h: Removed.
        * platform/text/PlatformString.h:
        * platform/text/String.cpp:
        * platform/text/StringImpl.cpp:
        * platform/text/TextCodec.h:
        * platform/text/TextCodecICU.cpp:
        * platform/text/TextCodecLatin1.cpp:
        * platform/text/TextCodecUTF16.cpp:
        * platform/text/TextCodecUserDefined.cpp:
        * platform/text/TextEncoding.cpp:
        * platform/text/TextEncoding.h:
        * platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp:
        * platform/text/gtk/TextCodecGtk.cpp:
        * platform/text/haiku/StringHaiku.cpp:
        * platform/text/mac/TextCodecMac.cpp:
        * platform/text/qt/TextCodecQt.cpp:
        * platform/text/wx/StringWx.cpp:
        * platform/win/ClipboardUtilitiesWin.cpp:
        * platform/win/ClipboardWin.cpp:
        * platform/win/ContextMenuItemWin.cpp:
        * platform/win/ContextMenuWin.cpp:
        * platform/win/FileSystemWin.cpp:
        * platform/win/GDIObjectCounter.cpp:
        * platform/win/Language.cpp:
        * platform/win/PasteboardWin.cpp:
        * platform/wince/FileSystemWince.cpp:
        * platform/wince/KeygenWince.cpp:
        * platform/wince/PasteboardWince.cpp:
        * platform/wx/FileSystemWx.cpp:
        * platform/wx/LoggingWx.cpp:
        * plugins/PluginDebug.h:
        * plugins/PluginPackage.cpp:
        * plugins/PluginStream.cpp:
        * plugins/PluginStream.h:
        * plugins/PluginView.h:
        * plugins/gtk/PluginPackageGtk.cpp:
        * plugins/mac/PluginPackageMac.cpp:
        * plugins/qt/PluginPackageQt.cpp:
        * plugins/symbian/PluginPackageSymbian.cpp:
        * plugins/win/PluginPackageWin.cpp:
        * rendering/RenderLayer.cpp:
        * rendering/RenderLayerCompositor.cpp:
        * rendering/RenderTreeAsText.cpp:
        * storage/Database.cpp:
        * storage/SQLTransactionCoordinator.cpp:
        * storage/SQLTransactionCoordinator.h:
        * storage/StorageAreaSync.cpp:
        * storage/StorageSyncManager.cpp:
        * storage/chromium/DatabaseTrackerChromium.cpp:
        * storage/chromium/QuotaTracker.cpp:
        * storage/chromium/QuotaTracker.h:
        * svg/SVGFontFaceElement.cpp:
        * svg/SVGStyledElement.cpp:
        * svg/SVGUseElement.cpp:
        * websockets/WebSocket.cpp:
        * websockets/WebSocketChannel.cpp:
        * websockets/WebSocketHandshake.cpp:
        * wml/WMLErrorHandling.cpp:
        * wml/WMLGoElement.cpp:
        * wml/WMLPageState.cpp:
        * wml/WMLPostfieldElement.cpp:
        * wml/WMLSelectElement.cpp:
        * xml/XMLHttpRequest.cpp:
        * xml/XSLStyleSheetLibxslt.cpp:
        * xml/XSLTProcessorLibxslt.cpp:

2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441
2010-03-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Brady Eidson.

        REGRESSION (r56439) - Crash when a renderer for a file upload control
        with a selected file is recreated
        https://bugs.webkit.org/show_bug.cgi?id=36723

        RenderFileUploadControl::chooseIconForFiles was called before
        m_fileChooser was initialized.

        * platform/FileChooser.cpp:
        (WebCore::FileChooser::FileChooser): Introduce m_isInitializing flag to
          avoid FileChooserClient::repaint() call.
        (WebCore::FileChooser::loadIcon):
        (WebCore::FileChooser::iconLoaded):
        * platform/FileChooser.h: Add a FielChooser parameter to
          FileChooserClient::chooseIconForFiles().
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::chooseIconForFiles):
        (WebCore::RenderFileUploadControl::paintObject): Add an assertion.
        * rendering/RenderFileUploadControl.h:

2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453
2010-03-30  Stanislav Paltis  <Stanislav.Paltis@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] qmake/symbian build failure
        https://bugs.webkit.org/show_bug.cgi?id=36745

        Fix build break in Symbian build introduced in r56714,
        by modifying comment escape character from ";" to "#".

        * WebCore.pro:

2454 2455 2456 2457 2458 2459 2460
2010-03-30  Kevin Ollivier  <kevino@theolliviers.com>

        [wx] Build fix after new localized string addition.

        * platform/wx/LocalizedStringsWx.cpp:
        (WebCore::missingPluginText):

weinig@apple.com's avatar
weinig@apple.com committed
2461 2462 2463 2464 2465 2466 2467 2468
2010-03-30  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Add missing export.

        * WebCore.base.exp:

2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484
2010-03-30  Enrica Casucci  <enrica@apple.com>

        Reviewed by Darin Adler.

        Incorrect insertion position after typing THAI CHARACTER SARA AM = 0E33.
        <rdar://problem/7810749>
        https://bugs.webkit.org/show_bug.cgi?id=36858

        Test: fast/text/multiglyph-characters.html

        Characters with multiple glyph were not supported correctly.
        Computing the advance width was producing a division by zero.
        
        * platform/graphics/mac/ComplexTextController.cpp:
        (WebCore::ComplexTextController::advance):

2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498
2010-03-30  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Taint the canvas if an SVG-derived pattern is rendered into it.

        https://bugs.webkit.org/show_bug.cgi?id=36838

        Test: fast/canvas/svg-taint.html

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::createPattern):
          Take into account the image's hasSingleSecurityOrigin() property.

ap@apple.com's avatar
ap@apple.com committed
2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517
2010-03-30  Alexey Proskuryakov  <ap@apple.com>