ChangeLog 1010 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29
2010-12-10  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        [Chromium] Implement mocks for client-based geolocation
        https://bugs.webkit.org/show_bug.cgi?id=46895

        * WebKit.gyp:
        * public/WebGeolocationClientMock.h: Added.
        (WebKit::WebGeolocationClientMock::~WebGeolocationClientMock):
        (WebKit::WebGeolocationClientMock::WebGeolocationClientMock):
        * src/WebGeolocationClientMock.cpp: Added.
        (WebKit::WebGeolocationClientMock::create):
        (WebKit::WebGeolocationClientMock::initialize):
        (WebKit::WebGeolocationClientMock::reset):
        (WebKit::WebGeolocationClientMock::setMockGeolocationPosition):
        (WebKit::WebGeolocationClientMock::setMockGeolocationError):
        (WebKit::WebGeolocationClientMock::setMockGeolocationPermission):
        (WebKit::WebGeolocationClientMock::resetMock):
        (WebKit::WebGeolocationClientMock::startUpdating):
        (WebKit::WebGeolocationClientMock::stopUpdating):
        (WebKit::WebGeolocationClientMock::setEnableHighAccuracy):
        (WebKit::WebGeolocationClientMock::geolocationDestroyed):
        (WebKit::WebGeolocationClientMock::setController):
        (WebKit::WebGeolocationClientMock::lastPosition):
        (WebKit::WebGeolocationClientMock::requestPermission):
        (WebKit::WebGeolocationClientMock::cancelPermissionRequest):
        * src/WebGeolocationServiceMock.cpp:

30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87
2010-12-10  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        [chromium] Implement client based geolocation bindings
        https://bugs.webkit.org/show_bug.cgi?id=45752

        Implements the necessary plumbing to expose client-based geolocation in Chromium
        webkit. The plan is to remove the non-client-based geolocation code (GeolocationService*)
        in the future.

        * WebKit.gyp:
        * public/WebGeolocationClient.h: Added.
        (WebKit::WebGeolocationClient::~WebGeolocationClient):
        * public/WebGeolocationController.h: Added.
        (WebKit::WebGeolocationController::WebGeolocationController):
        (WebKit::WebGeolocationController::reset):
        * public/WebGeolocationError.h:
        * public/WebGeolocationPermissionRequest.h: Added.
        (WebKit::WebGeolocationPermissionRequest::WebGeolocationPermissionRequest):
        (WebKit::WebGeolocationPermissionRequest::geolocation):
        * public/WebGeolocationPermissionRequestManager.h: Added.
        (WebKit::WebGeolocationPermissionRequestManager::WebGeolocationPermissionRequestManager):
        (WebKit::WebGeolocationPermissionRequestManager::~WebGeolocationPermissionRequestManager):
        * public/WebGeolocationPosition.h:
        * public/WebViewClient.h:
        (WebKit::WebViewClient::geolocationClient):
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
        (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
        * src/GeolocationClientProxy.cpp: Added.
        (WebKit::GeolocationClientProxy::GeolocationClientProxy):
        (WebKit::GeolocationClientProxy::~GeolocationClientProxy):
        (WebKit::GeolocationClientProxy::setController):
        (WebKit::GeolocationClientProxy::geolocationDestroyed):
        (WebKit::GeolocationClientProxy::startUpdating):
        (WebKit::GeolocationClientProxy::stopUpdating):
        (WebKit::GeolocationClientProxy::setEnableHighAccuracy):
        (WebKit::GeolocationClientProxy::lastPosition):
        (WebKit::GeolocationClientProxy::requestPermission):
        (WebKit::GeolocationClientProxy::cancelPermissionRequest):
        * src/GeolocationClientProxy.h: Added.
        * src/WebGeolocationController.cpp: Added.
        (WebKit::WebGeolocationController::positionChanged):
        (WebKit::WebGeolocationController::errorOccurred):
        (WebKit::WebGeolocationController::controller):
        * src/WebGeolocationPermissionRequest.cpp: Added.
        (WebKit::WebGeolocationPermissionRequest::securityOrigin):
        (WebKit::WebGeolocationPermissionRequest::setIsAllowed):
        * src/WebGeolocationPermissionRequestManager.cpp: Added.
        (WebGeolocationPermissionRequestManager::add):
        (WebGeolocationPermissionRequestManager::remove):
        (WebGeolocationPermissionRequestManager::init):
        (WebGeolocationPermissionRequestManager::reset):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        * src/WebViewImpl.h:

88 89 90 91 92 93 94 95 96 97 98 99 100 101 102
2010-12-10  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Numeric keys are floats.
        https://bugs.webkit.org/show_bug.cgi?id=50674

        Represent numeric keys as floating point values.

        * public/WebIDBKey.h:
        (WebKit::WebIDBKey::WebIDBKey):
        * src/WebIDBKey.cpp:
        (WebKit::WebIDBKey::assign):
        (WebKit::WebIDBKey::number):

103 104 105 106 107 108 109 110 111 112 113 114 115 116
2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r73616.
        http://trac.webkit.org/changeset/73616
        https://bugs.webkit.org/show_bug.cgi?id=50772

        Breaks chromium win build (Requested by hwennborg on #webkit).

        * public/WebIDBKey.h:
        (WebKit::WebIDBKey::WebIDBKey):
        * src/WebIDBKey.cpp:
        (WebKit::WebIDBKey::assign):
        (WebKit::WebIDBKey::number):

117 118 119 120 121 122 123 124 125 126 127 128 129 130 131
2010-12-09  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Numeric keys are floats.
        https://bugs.webkit.org/show_bug.cgi?id=50674

        Represent numeric keys as floating point values.

        * public/WebIDBKey.h:
        (WebKit::WebIDBKey::WebIDBKey):
        * src/WebIDBKey.cpp:
        (WebKit::WebIDBKey::assign):
        (WebKit::WebIDBKey::number):

132 133 134 135 136 137 138 139 140 141 142 143 144 145
2010-12-07  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by John Sullivan.

        Layering Violation in ContextMenu - member variable of type HitTestResult
        https://bugs.webkit.org/show_bug.cgi?id=50586
        
        Update users of ContextMenu and ContextMenuController to match where the new functions 
        are located.

        * src/ContextMenuClientImpl.cpp:
        (WebKit::selectMisspelledWord):
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

146 147 148 149 150 151 152 153 154 155 156 157 158 159 160
2010-12-06  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Pass security origin to make local file decision correctly
        https://bugs.webkit.org/show_bug.cgi?id=48603

        * src/ApplicationCacheHost.cpp:
        (WebCore::ApplicationCacheHost::selectCacheWithManifest): Pass security origin.
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchCreatePage): Ditto.
        (WebKit::FrameLoaderClientImpl::createFrame): Ditto.
        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::loadFrameRequest): Ditto.

161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183
2010-12-07  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed, rolling out r73392.
        http://trac.webkit.org/changeset/73392
        https://bugs.webkit.org/show_bug.cgi?id=50489

        This commit caused crashes on the GTK+ bots

        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::finishedLoading):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::encoding):
        (WebKit::WebFrameImpl::loadJavaScriptURL):
        * src/WebPageSerializerImpl.cpp:
        (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
        (WebKit::WebPageSerializerImpl::serialize):
        * src/WebSearchableFormData.cpp:
        (WebCore::GetFormEncoding):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::pageEncoding):

184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201
2010-12-07  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        Let HTMLObjectElement be a form associated element
        https://bugs.webkit.org/show_bug.cgi?id=48821

        Modified to use FormAssociatedElement instead of HTMLFormControlElement.

        * src/WebFormElement.cpp: 
        (WebKit::WebFormElement::getFormControlElements): Modified to use
        FormAssociatedElement instead of HTMLFormControlElement.
        * src/WebPasswordFormUtils.cpp:
        (WebKit::findPasswordFormFields): Ditto.
        * src/WebSearchableFormData.cpp:
        (WebCore::GetButtonToActivate): Ditto.
        (WebCore::HasSuitableTextElement): Ditto.

202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223
2010-12-06  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Update calls to DocumentWriter.
        https://bugs.webkit.org/show_bug.cgi?id=50489

        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::finishedLoading):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::encoding):
        (WebKit::WebFrameImpl::loadJavaScriptURL):
        * src/WebPageSerializerImpl.cpp:
        (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
        (WebKit::WebPageSerializerImpl::serialize):
        * src/WebSearchableFormData.cpp:
        (WebCore::GetFormEncoding):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::pageEncoding):

224 225 226 227 228 229 230 231 232 233 234 235 236
2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r73302.
        http://trac.webkit.org/changeset/73302
        https://bugs.webkit.org/show_bug.cgi?id=50499

        Causes crashes in debug LayoutTests (Requested by xan_ on
        #webkit).

        * public/WebAccessibilityObject.h:
        * src/WebAccessibilityObject.cpp:
        (WebKit::WebAccessibilityObject::parentObject):

237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252
2010-12-01  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Inspector protocol cleanup task.

        The patch has just small renames and adjustments for the protocol things.
        'handler' keyword in idl file was replaced with 'domain'.
        'domain' property was assigned for the each backend to frontend messages.
        At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.

        https://bugs.webkit.org/show_bug.cgi?id=50337

        * src/WebDevToolsFrontendImpl.cpp:
        (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

253 254 255 256 257 258 259 260 261 262 263 264
2010-12-03  Chris Guillory  <chris.guillory@google.com>

        Reviewed by Chris Fleizach.

        Include the FrameView widget of a RenderWidget in the accessibility tree.
        https://bugs.webkit.org/show_bug.cgi?id=49106

        * public/WebAccessibilityObject.h:
        * src/WebAccessibilityObject.cpp:
        (WebKit::WebAccessibilityObject::equals):
        (WebKit::WebAccessibilityObject::parentObject):

265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284
2010-11-29  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Clean up IndexedDB 2 sided roll bits
        https://bugs.webkit.org/show_bug.cgi?id=50160

        * public/WebIDBDatabase.h:
        (WebKit::WebIDBDatabase::version):
        (WebKit::WebIDBDatabase::objectStoreNames):
        (WebKit::WebIDBDatabase::deleteObjectStore):
        * public/WebIDBFactory.h:
        (WebKit::WebIDBFactory::open):
        * public/WebIDBKeyRange.h:
        * public/WebIDBObjectStore.h:
        (WebKit::WebIDBObjectStore::deleteFunction):
        * src/IDBDatabaseProxy.cpp:
        * src/IDBDatabaseProxy.h:
        * src/WebIDBKeyRange.cpp:

285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300
2010-12-02  Chris Rogers  <crogers@google.com>

        Reviewed by Darin Fisher.

        Fine-tune chromium WebKit API for loading audio resources
        https://bugs.webkit.org/show_bug.cgi?id=50406

        * public/WebAudioBus.h:
        (WebKit::WebAudioBus::~WebAudioBus):
        * public/WebKitClient.h:
        (WebKit::WebKitClient::loadAudioResource):
        * src/ChromiumBridge.cpp:
        (WebCore::ChromiumBridge::decodeAudioFileData):
        * src/WebAudioBus.cpp:
        (WebKit::WebAudioBus::reset):

301 302 303 304 305 306 307 308
2010-12-02  Darin Fisher  <darin@chromium.org>

        Fix the Windows multi-dll build.  Do not export functions that are
        implemented inline!

        * public/WebFormControlElement.h:
        (WebKit::WebFormControlElement::assign):

309 310 311 312 313 314
2010-12-02  Tony Chang  <tony@chromium.org>

        Unreviewed, roll chromium deps to r67980.

        * DEPS:

315 316 317 318 319 320 321 322 323 324
2010-12-01  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
        Enable resource export to HAR for Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=45663

        * src/js/DevTools.js: Preferences.resourceExportEnabled = true

325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342
2010-12-02  Vincent Scheib  <scheib@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] histograms api updated in WebKitClient/ChromiumBridge and histogram "GPU.setIsAcceleratedCompositingActive" added.
        https://bugs.webkit.org/show_bug.cgi?id=50285

        Test by loading "about:histograms" after navigating to accelerated pages.

        * public/WebKitClient.h:
        (WebKit::WebKitClient::histogramCustomCounts): api update.
        (WebKit::WebKitClient::histogramEnumeration): api update.
        * src/ChromiumBridge.cpp:
        (WebCore::ChromiumBridge::histogramCustomCounts): api update.
        (WebCore::ChromiumBridge::histogramEnumeration): api update.
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): "GPU.setIsAcceleratedCompositingActive" added.

343 344 345 346 347 348 349 350 351 352 353 354 355 356
2010-12-01  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        Support multiple correction candidates panel for misspelled word on Mac OS X.
        https://bugs.webkit.org/show_bug.cgi?id=50137
        <rdar://problem/8568059>

        Adopted new function signature defined in base class.

        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::getGuessesForWord):
        * src/EditorClientImpl.h:

357 358 359 360 361 362 363 364 365 366 367 368
2010-12-01  Alexey Marinichev  <amarinichev@chromium.org>

        Reviewed by James Robinson.

        [chromium] renderer does not realize hardware compositing is disabled and crashes
        https://bugs.webkit.org/show_bug.cgi?id=50264

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setRootGraphicsLayer): repaint always
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): null check
        (WebKit::WebViewImpl::reallocateRenderer):

369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387
2010-11-30  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Darin Fisher.

        Get the value of the accelerated compositing triggers from the Settings
        class.  This allows setting the triggers via command line flags.
        https://bugs.webkit.org/show_bug.cgi?id=50301

        * public/WebSettings.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::allowedCompositingTriggers):
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setAcceleratedCompositingFor3DTransformsEnabled):
        (WebKit::WebSettingsImpl::setAcceleratedCompositingForVideoEnabled):
        (WebKit::WebSettingsImpl::setAcceleratedCompositingForPluginsEnabled):
        (WebKit::WebSettingsImpl::setAcceleratedCompositingForCanvasEnabled):
        (WebKit::WebSettingsImpl::setAcceleratedCompositingForAnimationEnabled):
        * src/WebSettingsImpl.h:

388 389 390 391 392 393
2010-12-01  Tony Chang  <tony@chromium.org>

        Unreviewed, rolling chromium deps to r67811.

        * DEPS:

394 395 396 397 398 399 400 401 402
2010-12-01  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: disable cookies tab in network resource view by default, enable for chromium
        https://bugs.webkit.org/show_bug.cgi?id=50249

        * src/js/DevTools.js:

403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
        https://bugs.webkit.org/show_bug.cgi?id=50288

        2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
        Reviewed by Darin Adler.
        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
        https://bugs.webkit.org/show_bug.cgi?id=50182
        A display-isolated URL can only be displayed (e.g., put in an iframe,
        hyperlinked to) by documents from that scheme. In a sense, this is a
        generalization of some of the protections we give file URLs, but
        instead of lumping them all together into one "local" bucket, this
        patch creates a separate bucket for each scheme.
        For a while, I tried using a separate bucket for each origin. That
        would have played nicely with what Blob URLs are trying to do, but some
        "chrome" URL pages rely on being able to display other chrome URL
        pages, even in different origins. For example, the New Tab Page shows
        thumbnails from the "thumbnail" host.
        This patch also removes a bunch of unused code. I've also propagated
        the "deprecated" status of deprecatedCanDisplay to
        deprecatedShouldTreatURLAsLocal because that method has no other
        callers and is really asking for uppercase/lowercase bugs. I dream of
        someday removing these functions.
        2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
        Reviewed by Darin Adler.
        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
         https://bugs.webkit.org/show_bug.cgi?id=50182
        This patch adds a Chromium API for registering schemes as
        display-isolated. In a subsequent patch, I'll change the "chrome"
        scheme in Chrome to be display isolated instead of local. That will
        prevent file URLs from linking to chrome URLs.

        * public/WebSecurityPolicy.h:
        * src/WebSecurityPolicy.cpp:

439 440 441 442 443 444 445 446 447 448 449 450 451
2010-11-30  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Update yasm entry in DEPS to match downstream
        https://bugs.webkit.org/show_bug.cgi?id=50274

        http://src.chromium.org/viewvc/chrome?view=rev&revision=67540 changed the downstream DEPS rule
        for yasm to pull unconditionally rather than pulling in each deps_os.  This changes the WebKit
        chromium DEPS to match.

        * DEPS:

452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467
2010-11-29  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Simon Fraser.

        Provide more fine grained control to ports over when to turn on accelerated
        compositing.
        https://bugs.webkit.org/show_bug.cgi?id=49998

        As part of this change, the old hasAcceleratedCompositing method on the ChromeClient
        has now been replaced by allowedCompositingTriggers which returns a bitfield of
        all the features which can trigger the compositor.

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::allowedCompositingTriggers):
        * src/ChromeClientImpl.h:

468 469 470 471 472 473 474 475 476 477 478 479
2010-11-30  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] pass webframe to web frame client's cookieJar
        https://bugs.webkit.org/show_bug.cgi?id=50148

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::cookieJar):
        * src/ChromiumBridge.cpp:
        (WebCore::getCookieJar):

480 481 482 483 484 485
2010-11-30  Jochen Eisinger  <jochen@chromium.org>

        Unreviewed. Roll chromium 67532:67541.

        * DEPS:

486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501
2010-11-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
        https://bugs.webkit.org/show_bug.cgi?id=50182

        This patch adds a Chromium API for registering schemes as
        display-isolated.  In a subsequent patch, I'll change the "chrome"
        scheme in Chrome to be display isolated instead of local.  That will
        prevent file URLs from linking to chrome URLs.

        * public/WebSecurityPolicy.h:
        * src/WebSecurityPolicy.cpp:
        (WebKit::WebSecurityPolicy::registerURLSchemeAsDisplayIsolated):

502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519
2010-11-29  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Add substitution parameters to WebKitClient::queryLocalizedString()
        https://bugs.webkit.org/show_bug.cgi?id=50053

        * public/WebKitClient.h:
        (WebKit::WebKitClient::queryLocalizedString): Add overload functions with
          substitution string parameters, and remove the integer parameter overload.
        * src/LocalizedStrings.cpp:
        (WebCore::query): Add string parameter overloads, and remove the integer parameter overload.
        (WebCore::multipleFileUploadText): Call the string parameter query().
        (WebCore::validationMessageTooLongText): Pass the parameters to query().
        (WebCore::validationMessageRangeUnderflowText): ditto.
        (WebCore::validationMessageRangeOverflowText): ditto.
        (WebCore::validationMessageStepMismatchText): ditto.

520 521 522 523 524 525
2010-11-29  Dimitri Glazkov  <dglazkov@chromium.org>

        Remove Build directory that was erroneously added in r72103.

        * Build: Removed.

526 527 528 529 530 531 532 533 534 535 536 537 538
2010-11-29  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Darin Fisher.

        Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
        Added WebDevToolsAgent::inspect()
        https://bugs.webkit.org/show_bug.cgi?id=49727

        * public/WebDevToolsAgent.h:
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::inspectNode):
        * src/WebDevToolsAgentImpl.h:

539 540 541 542 543 544
2010-11-29  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Remove python_24 dependency, because it is no longer necessary.

        * DEPS: Removed python_24 dependency.

545 546 547 548 549 550 551 552 553 554 555 556
2010-11-29  Bernhard Bauer  <bauerb@chromium.org>

        Reviewed by Jeremy Orlow.

        Remove databaseFileName from WebIDBFactory
        https://bugs.webkit.org/show_bug.cgi?id=50150

        * WebKit.gyp:
        * public/WebIDBFactory.h:
        (WebKit::WebIDBFactory::open):
        * src/WebIDBFactory.cpp: Removed.

557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585
2010-11-26  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        IDBDatabase and IDBObjectStore remove* methods should be renamed to delete*
        https://bugs.webkit.org/show_bug.cgi?id=50113

        * public/WebIDBDatabase.h:
        (WebKit::WebIDBDatabase::deleteObjectStore):
        (WebKit::WebIDBDatabase::removeObjectStore):
        * public/WebIDBObjectStore.h:
        (WebKit::WebIDBObjectStore::remove):
        (WebKit::WebIDBObjectStore::deleteFunction):
        (WebKit::WebIDBObjectStore::deleteIndex):
        * src/IDBDatabaseProxy.cpp:
        (WebCore::IDBDatabaseProxy::deleteObjectStore):
        * src/IDBDatabaseProxy.h:
        * src/IDBObjectStoreProxy.cpp:
        (WebCore::IDBObjectStoreProxy::deleteFunction):
        (WebCore::IDBObjectStoreProxy::deleteIndex):
        * src/IDBObjectStoreProxy.h:
        * src/WebIDBDatabaseImpl.cpp:
        (WebKit::WebIDBDatabaseImpl::deleteObjectStore):
        * src/WebIDBDatabaseImpl.h:
        * src/WebIDBObjectStoreImpl.cpp:
        (WebKit::WebIDBObjectStoreImpl::deleteFunction):
        (WebKit::WebIDBObjectStoreImpl::deleteIndex):
        * src/WebIDBObjectStoreImpl.h:

586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607
2010-11-26  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Make IDBKeyRange match the spec
        https://bugs.webkit.org/show_bug.cgi?id=50105

        Remove flags and instead add two booleans for being open.
        Change left to lower and right to upper everywhere.

        * public/WebIDBKeyRange.h:
        (WebKit::WebIDBKeyRange::WebIDBKeyRange):
        * src/WebIDBKeyRange.cpp:
        (WebKit::WebIDBKeyRange::assign):
        (WebKit::WebIDBKeyRange::left):
        (WebKit::WebIDBKeyRange::right):
        (WebKit::WebIDBKeyRange::lower):
        (WebKit::WebIDBKeyRange::upper):
        (WebKit::WebIDBKeyRange::lowerOpen):
        (WebKit::WebIDBKeyRange::upperOpen):
        (WebKit::WebIDBKeyRange::flags):

608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630
2010-11-25  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Clean up IDBDatabase.transaction and add checks to IDBTransaction.objectStore
        https://bugs.webkit.org/show_bug.cgi?id=50081

        Plumb IDBTransaction.objectStore's exception code.

        * public/WebIDBTransaction.h:
        (WebKit::WebIDBTransaction::objectStore):
        * src/IDBDatabaseProxy.cpp:
        (WebCore::IDBDatabaseProxy::transaction):
        * src/IDBTransactionBackendProxy.cpp:
        (WebCore::IDBTransactionBackendProxy::objectStore):
        * src/IDBTransactionBackendProxy.h:
        * src/WebIDBDatabaseImpl.cpp:
        (WebKit::WebIDBDatabaseImpl::createObjectStore):
        (WebKit::WebIDBDatabaseImpl::transaction):
        * src/WebIDBTransactionImpl.cpp:
        (WebKit::WebIDBTransactionImpl::objectStore):
        * src/WebIDBTransactionImpl.h:

631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649
2010-11-26  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames
        https://bugs.webkit.org/show_bug.cgi?id=50102

        Rename as per the spec: http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#database-interface

        * public/WebIDBDatabase.h:
        (WebKit::WebIDBDatabase::objectStores):
        (WebKit::WebIDBDatabase::objectStoreNames):
        * src/IDBDatabaseProxy.cpp:
        (WebCore::IDBDatabaseProxy::objectStoreNames):
        * src/IDBDatabaseProxy.h:
        * src/WebIDBDatabaseImpl.cpp:
        (WebKit::WebIDBDatabaseImpl::objectStoreNames):
        * src/WebIDBDatabaseImpl.h:

andreip@google.com's avatar
andreip@google.com committed
650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670
2010-11-26  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        IDBFactory::open should not have a description argument.
        https://bugs.webkit.org/show_bug.cgi?id=50087

        * public/WebIDBDatabase.h:
        (WebKit::WebIDBDatabase::description):
        * public/WebIDBFactory.h:
        (WebKit::WebIDBFactory::open):
        * src/IDBFactoryBackendProxy.cpp:
        (WebCore::IDBFactoryBackendProxy::open):
        * src/IDBFactoryBackendProxy.h:
        * src/WebIDBDatabaseImpl.cpp:
        * src/WebIDBDatabaseImpl.h:
        * src/WebIDBFactory.cpp:
        * src/WebIDBFactoryImpl.cpp:
        (WebKit::WebIDBFactoryImpl::open):
        * src/WebIDBFactoryImpl.h:

671 672 673 674 675 676
2010-11-25  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Roll chromium 67004:67404.

        * DEPS:

677 678 679 680 681 682 683 684 685 686
2010-11-25  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Add exception code to WebIDBTransaction::objectStore
        https://bugs.webkit.org/show_bug.cgi?id=50030

        * public/WebIDBTransaction.h:
        (WebKit::WebIDBTransaction::objectStore):

687 688 689 690 691 692 693 694 695 696 697 698 699 700 701
2010-11-24  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        [Chromium][Windows] TestShell flakily crashes with EventSender.contextClick()
        https://bugs.webkit.org/show_bug.cgi?id=50052
        
        makeStringArrayImpl() assumed wtf::StringImpl data is
        null-terminated. But it is not.
        Changed the code to pass the string length explicitly instead of
        making it computed by v8::String::New().

        * src/WebBindings.cpp:
        (WebKit::makeStringArrayImpl):

702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724
2010-11-24  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by David Levin.

        [Chromium] Implement FileWriterSync
        https://bugs.webkit.org/show_bug.cgi?id=49940

        Added waitForOperationToComplete, delegating to the bridge.
        * src/WorkerAsyncFileWriterChromium.cpp:
        * src/WorkerAsyncFileWriterChromium.h:

        Added waitForOperationToComplete and some debug-only code to make sure it's working properly.
        * src/WorkerFileWriterCallbacksBridge.cpp:
        (WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
        (WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
        (WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
        (WebKit::WorkerFileWriterCallbacksBridge::WorkerFileWriterCallbacksBridge):
        (WebKit::WorkerFileWriterCallbacksBridge::didWriteOnWorkerThread):
        (WebKit::WorkerFileWriterCallbacksBridge::didFailOnWorkerThread):
        (WebKit::WorkerFileWriterCallbacksBridge::didTruncateOnWorkerThread):
        (WebKit::WorkerFileWriterCallbacksBridge::waitForOperationToComplete):
        * src/WorkerFileWriterCallbacksBridge.h:

725 726 727 728 729 730 731 732 733 734 735 736
2010-11-24  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        [chromium] Disable antialiasing for compositor
        https://bugs.webkit.org/show_bug.cgi?id=50039

        * src/WebViewImpl.cpp:
        (WebCore::getCompositorContextAttributes):
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
        (WebKit::WebViewImpl::graphicsContext3D):

737 738 739 740 741 742 743 744 745
2010-11-24  Satish Sampath  <satish@chromium.org>

        Reviewed by Steve Block.

        Remove API migration code which is no longer used.
        https://bugs.webkit.org/show_bug.cgi?id=50013

        * public/WebSpeechInputControllerMock.h:

746 747 748 749 750 751 752 753 754 755 756 757 758
2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72628.
        http://trac.webkit.org/changeset/72628
        https://bugs.webkit.org/show_bug.cgi?id=49994

        This patch is causing layout-test failtures on GTK Linux
        64-bit Debug (Requested by ctguil on #webkit).

        * public/WebAccessibilityObject.h:
        * src/WebAccessibilityObject.cpp:
        (WebKit::WebAccessibilityObject::parentObject):

759 760 761 762 763 764 765 766 767 768 769 770
2010-11-23  Chris Guillory  <chris.guillory@google.com>

        Reviewed by Dimitri Glazkov.

        Include the FrameView widget of a RenderWidget in the accessibility tree.
        https://bugs.webkit.org/show_bug.cgi?id=49106

        * public/WebAccessibilityObject.h:
        * src/WebAccessibilityObject.cpp:
        (WebKit::WebAccessibilityObject::equals):
        (WebKit::WebAccessibilityObject::parentObject):

771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799
2010-11-23  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Introduce wrapper types for WebCore::GeolocationError, WebCore::GeolocationPosition.
        https://bugs.webkit.org/show_bug.cgi?id=49735

        Introduce WebKit API types so that the browser implementation can feed
        position and error updates to the WebCore::GeolocationController.

        * WebKit.gyp:
        * public/WebGeolocationError.h: Added.
        (WebKit::WebGeolocationError::WebGeolocationError):
        (WebKit::WebGeolocationError::~WebGeolocationError):
        * public/WebGeolocationPosition.h: Added.
        (WebKit::WebGeolocationPosition::WebGeolocationPosition):
        (WebKit::WebGeolocationPosition::~WebGeolocationPosition):
        * src/WebGeolocationError.cpp: Added.
        (WebKit::WebGeolocationError::assign):
        (WebKit::WebGeolocationError::reset):
        (WebKit::WebGeolocationError::WebGeolocationError):
        (WebKit::WebGeolocationError::operator=):
        (WebKit::WebGeolocationError::operator WTF::PassRefPtr<WebCore::GeolocationError>):
        * src/WebGeolocationPosition.cpp: Added.
        (WebKit::WebGeolocationPosition::assign):
        (WebKit::WebGeolocationPosition::reset):
        (WebKit::WebGeolocationPosition::operator=):
        (WebKit::WebGeolocationPosition::operator PassRefPtr<WebCore::GeolocationPosition>):

800 801 802 803 804 805 806 807 808 809 810 811 812
2010-11-23  Jonathan Backer  <backer@chromium.org>

        Reviewed by Kenneth Russell.

        Renderer is resizing IOSurfaces when accelerated compositing is disabled.
        https://bugs.webkit.org/show_bug.cgi?id=49827

        - IOSurfaces are only presented when accelerated compositing is enabled.
        - Slight performance increase (and clean-up for using this path for Linux and Windows).

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::resize):

813 814 815 816 817 818 819 820 821 822
2010-11-23  Grace Kloba  <klobag@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Accumulated scroll damage rect should be in the content space
        https://bugs.webkit.org/show_bug.cgi?id=49842

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::scrollRootLayerRect): Adjust the previous scroll damage with the scroll delta before union it with the new damage rect.

823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851
2010-11-18  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add a mechanism for creating a WebURLLoader that is associated with a
        particular WebFrame.
        https://bugs.webkit.org/show_bug.cgi?id=49764

        This will be used by code that calls webKitClient()->createURLLoader()
        from within the Chromium source tree.

        An associated WebURLLoader should be treated like a subresource of the
        WebFrame's document.

        * WebKit.gyp:
        * public/WebFrame.h:
        * src/AssociatedURLLoader.cpp: Added.
        (WebKit::AssociatedURLLoader::AssociatedURLLoader):
        (WebKit::AssociatedURLLoader::~AssociatedURLLoader):
        (WebKit::AssociatedURLLoader::loadSynchronously):
        (WebKit::AssociatedURLLoader::loadAsynchronously):
        (WebKit::AssociatedURLLoader::cancel):
        (WebKit::AssociatedURLLoader::setDefersLoading):
        (WebKit::AssociatedURLLoader::PrepareRequest):
        * src/AssociatedURLLoader.h: Added.
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::createAssociatedURLLoader):
        * src/WebFrameImpl.h:

852 853 854 855 856 857 858
2010-11-23  Satish Sampath  <satish@chromium.org>

        Unreviewed, chromium build fix.

        * public/WebSpeechInputControllerMock.h:
        (WebKit::WebSpeechInputControllerMock::setMockRecognitionResult):

859 860 861 862 863 864 865 866 867 868 869 870 871 872
2010-11-18  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        For speech input event, send an event object containing all the recognition results and metadata.
        https://bugs.webkit.org/show_bug.cgi?id=49736

        Updated mock object's method to new signature.

        * public/WebSpeechInputControllerMock.h:
        * src/WebSpeechInputControllerMockImpl.cpp:
        (WebKit::WebSpeechInputControllerMockImpl::addMockRecognitionResult):
        * src/WebSpeechInputControllerMockImpl.h:

873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891
2010-11-22  Alexey Marinichev  <amarinichev@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Implement Extensions3DChromium::getGraphicsResetStatusARB
        https://bugs.webkit.org/show_bug.cgi?id=49946

        * public/WebGraphicsContext3D.h: added isContextLost()
        * src/Extensions3DChromium.cpp:
        (WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::isContextLost):
        * src/GraphicsContext3DInternal.h:
        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::isContextLost):
        * src/WebGraphicsContext3DDefaultImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::reallocateRenderer): ensure root layer repaining

892 893 894 895 896 897 898 899 900 901
2010-11-22  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        Don't create an external popup menu when there are no items to show.
        https://bugs.webkit.org/show_bug.cgi?id=49937

        * src/ExternalPopupMenu.cpp:
        (WebKit::ExternalPopupMenu::show):

902 903 904 905 906 907 908 909 910 911 912
2010-11-22  Nat Duca  <nduca@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Send didActivateAcceleratedCompositing when compositor
        initializes but does not create the shared context3d.
        https://bugs.webkit.org/show_bug.cgi?id=49930

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

913 914 915 916 917 918
2010-11-22  Tony Chang  <tony@chromium.org>

        Unreviewed, roll Chromium DEPS to r67004.

        * DEPS:

919 920 921 922 923 924 925
2010-11-22  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Partially roll out r72282.
        It should not have modified devtools files.

        * src/js/devTools.css:

926 927 928 929 930 931 932 933 934 935
2010-11-19  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Darin Fisher.

        Expose default value of maxLength in Chromium API
        https://bugs.webkit.org/show_bug.cgi?id=49723

        * public/WebInputElement.h: Added constant defaultMaximumLength
        * src/WebInputElement.cpp:

936 937 938 939 940 941 942 943 944 945
2010-11-18  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        GraphicsContext3D::reshape is clearing using current clear color instead of transparent
        https://bugs.webkit.org/show_bug.cgi?id=44064

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::reshape): Use 0 as clear values.

946 947 948 949 950 951
2010-11-19  Tony Chang  <tony@chromium.org>

        Unreviewed, updating Chromium DEPS to try and fix the chromium win build.

        * DEPS: r66792

952 953 954 955 956 957 958 959 960 961 962 963 964
2010-11-19  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Enable webkit's TestNetscapePlugIn for DRT on win and linux
        https://bugs.webkit.org/show_bug.cgi?id=49706

        It is enabled simply by copying the plugin into
        {Debug,Release}/plugins.  This change also rolls in a version of
        Chromium that disables the old plugin.

        * WebKit.gyp:

965 966 967 968 969 970 971 972 973 974 975 976
2010-11-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72399.
        http://trac.webkit.org/changeset/72399
        https://bugs.webkit.org/show_bug.cgi?id=49805

        Broke Chromium build (Requested by antonm_ on #webkit).

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::popupOpened):
        * src/ChromeClientImpl.h:

977 978 979 980 981 982 983 984 985 986 987
2010-11-19  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        Removing unused code to show popup externally on Mac.
        https://bugs.webkit.org/show_bug.cgi?id=49747

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::popupOpened):
        * src/ChromeClientImpl.h:

988 989 990 991 992 993
2010-11-19  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: flip chromium version to mitigate two-sided patch impact.

        * DEPS:

994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024
2010-11-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: provide response code and status text as a part
        of raw headers data.
        https://bugs.webkit.org/show_bug.cgi?id=49668

        * WebKit.gyp:
        * public/WebHTTPLoadInfo.h: Renamed from WebKit/chromium/public/WebResourceRawHeaders.h.
        (WebKit::WebHTTPLoadInfo::WebHTTPLoadInfo):
        (WebKit::WebHTTPLoadInfo::~WebHTTPLoadInfo):
        (WebKit::WebHTTPLoadInfo::operator =):
        * public/WebURLResponse.h:
        * src/WebHTTPLoadInfo.cpp: Renamed from WebKit/chromium/src/WebResourceRawHeaders.cpp.
        (WebKit::WebHTTPLoadInfo::initialize):
        (WebKit::WebHTTPLoadInfo::reset):
        (WebKit::WebHTTPLoadInfo::assign):
        (WebKit::WebHTTPLoadInfo::WebHTTPLoadInfo):
        (WebKit::WebHTTPLoadInfo::operator WTF::PassRefPtr<WebCore::ResourceRawHeaders>):
        (WebKit::WebHTTPLoadInfo::responseCode):
        (WebKit::WebHTTPLoadInfo::setResponseCode):
        (WebKit::WebHTTPLoadInfo::statusText):
        (WebKit::WebHTTPLoadInfo::setStatusText):
        (WebKit::addHeader):
        (WebKit::WebHTTPLoadInfo::addRequestHeader):
        (WebKit::WebHTTPLoadInfo::addResponseHeader):
        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponse::httpLoadInfo):
        (WebKit::WebURLResponse::setHTTPLoadInfo):

1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041
2010-11-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Tony Chang.

        Add more validation message functions
        https://bugs.webkit.org/show_bug.cgi?id=49716

        Add implementations of new functions and symbols for new messages.

        * public/WebLocalizedString.h:
        * src/LocalizedStrings.cpp:
        (WebCore::validationMessageValueMissingForCheckboxText):
        (WebCore::validationMessageValueMissingForFileText):
        (WebCore::validationMessageValueMissingForMultipleFileText):
        (WebCore::validationMessageValueMissingForRadioText):
        (WebCore::validationMessageValueMissingForSelectText):

1042 1043 1044 1045 1046 1047
2010-11-18  Tony Chang  <tony@chromium.org>

        Unreviewed, fix chromium compile.  We need ipc and openssl now.

        * DEPS:

1048 1049 1050 1051 1052 1053 1054 1055 1056
2010-11-18  James Robinson  <jamesr@chromium.org>

        Reviewed by David Levin.

        [chromium] Update chromium DEPS to r66658 to pick up skia roll
        https://bugs.webkit.org/show_bug.cgi?id=49754

        * DEPS:

1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079
2010-11-18  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] IndexedDB API cleanup
        https://bugs.webkit.org/show_bug.cgi?id=49733

        Make it so that you can't directly instantiate our "interface"
        classes.  Remove some code for 2 sided merges.

        * public/WebIDBCursor.h:
        (WebKit::WebIDBCursor::WebIDBCursor):
        * public/WebIDBDatabase.h:
        (WebKit::WebIDBDatabase::WebIDBDatabase):
        * public/WebIDBIndex.h:
        (WebKit::WebIDBIndex::WebIDBIndex):
        * public/WebIDBObjectStore.h:
        (WebKit::WebIDBObjectStore::WebIDBObjectStore):
        * public/WebIDBTransaction.h:
        (WebKit::WebIDBTransaction::WebIDBTransaction):
        * src/IDBTransactionBackendProxy.cpp:
        (WebCore::IDBTransactionBackendProxy::IDBTransactionBackendProxy):

1080 1081 1082 1083 1084 1085 1086 1087 1088 1089
2010-11-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chrome DevTools: minify front-end JavaScript.
        https://bugs.webkit.org/show_bug.cgi?id=49657

        * scripts/concatenate_js_files.py:
        * scripts/jsmin.py: Added.

1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113
2010-11-18  Chris Rogers  <crogers@google.com>

        Reviewed by Dimitri Glazkov.

        Add loadPlatformAudioResource() and decodeAudioFileData() to ChromiumBridge
        https://bugs.webkit.org/show_bug.cgi?id=49557

        * WebKit.gyp:
        * public/WebAudioBus.h: Added.
        (WebKit::WebAudioBus::WebAudioBus):
        * public/WebKitClient.h:
        (WebKit::WebKitClient::decodeAudioFileData):
        * src/ChromiumBridge.cpp:
        (WebCore::ChromiumBridge::loadPlatformAudioResource):
        (WebCore::ChromiumBridge::decodeAudioFileData):
        * src/WebAudioBus.cpp: Added.
        (WebKit::WebAudioBus::~WebAudioBus):
        (WebKit::WebAudioBus::initialize):
        (WebKit::WebAudioBus::numberOfChannels):
        (WebKit::WebAudioBus::length):
        (WebKit::WebAudioBus::sampleRate):
        (WebKit::WebAudioBus::channelData):
        (WebKit::WebAudioBus::release):

1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128
2010-11-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72228.
        http://trac.webkit.org/changeset/72228
        https://bugs.webkit.org/show_bug.cgi?id=49712

        Caused many >10 regressions on Win and Linux gpu layout test
        runs. (Requested by dave_levin on #webkit).

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::bytesPerComponent):
        (WebKit::componentsPerPixel):
        (WebKit::imageSizeInBytes):
        (WebKit::WebGraphicsContext3DDefaultImpl::texImage2D):

1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139
2010-11-17  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Converge means of querying a parent node into one way, which is Node::parentNode.
        https://bugs.webkit.org/show_bug.cgi?id=49686

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::insertStyleText): Changed to use parentNode.
        (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection): Ditto.

1140 1141 1142 1143 1144 1145 1146 1147 1148
2010-11-16  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        WebGLRenderingContext needs to zero textures and renderbuffers
        https://bugs.webkit.org/show_bug.cgi?id=49355

        * src/WebGraphicsContext3DDefaultImpl.cpp: Don't deal with texture initialization at this level.

1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160
2010-11-17  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Clear the speech input mock explicitly before each test.
        https://bugs.webkit.org/show_bug.cgi?id=49660

        * public/WebSpeechInputControllerMock.h:
        * src/WebSpeechInputControllerMockImpl.cpp:
        (WebKit::WebSpeechInputControllerMockImpl::clearResults): Added method to clear results.
        * src/WebSpeechInputControllerMockImpl.h:

1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180
2010-11-17  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by David Levin.

        [Chromium] implementation of async FileWriter for workers
        https://bugs.webkit.org/show_bug.cgi?id=47681

        Tests are in a separate changelist.

        Added new files.
        * WebKit.gyp:

        * src/WorkerAsyncFileSystemChromium.cpp: Added WorkerAsyncFileWriterChromium construction.
        * src/WorkerAsyncFileWriterChromium.cpp: Added.
        * src/WorkerAsyncFileWriterChromium.h: Added.

        This class bridges between the context and main threads for the WorkerAsyncFileWriterChromium.
        * src/WorkerFileWriterCallbacksBridge.cpp: Added.
        * src/WorkerFileWriterCallbacksBridge.h: Added.

1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192
2010-11-17  John Mellor  <johnme@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Expose frame flattening setting in WebSettings.
        https://bugs.webkit.org/show_bug.cgi?id=49621

        * public/WebSettings.h:
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setFrameFlatteningEnabled):
        * src/WebSettingsImpl.h:

1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204
2010-11-17  Jonathan Backer  <backer@chromium.org>

        Reviewed by Kenneth Russell.

        [Chromium] Resize initiated by renderer.
        https://bugs.webkit.org/show_bug.cgi?id=49617

        To address synchronization issues with resizing, make resize work like DARWIN.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::resize):

1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220
2010-11-17  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix click count for mouse-up events.
        - clickCount for mouse up was lost in conversion from NSEvent
        - clickCount was also lost when disptaching events through the
        plugin mouse capture event codepath.

        https://bugs.webkit.org/show_bug.cgi?id=49290

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::handleInputEvent):
        * src/mac/WebInputEventFactory.mm:
        (WebKit::WebInputEventFactory::mouseEvent):

1221 1222 1223 1224 1225 1226 1227 1228 1229 1230
2010-11-11  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=47196

        * src/WebImageDecoder.cpp:
        (WebKit::WebImageDecoder::init): Add ignoreGammaAndColorProfile parameter.

1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243
2010-11-12  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Refactor GL backend flags
        https://bugs.webkit.org/show_bug.cgi?id=49460

        * public/WebGraphicsContext3D.h: Remove GL flag queries at this level.
        * src/GraphicsContext3DChromium.cpp: Ditto.
        * src/GraphicsContext3DInternal.h: Ditto.
        * src/WebGraphicsContext3DDefaultImpl.cpp: Ditto.
        * src/WebGraphicsContext3DDefaultImpl.h: Ditto.

1244 1245 1246 1247 1248 1249 1250 1251 1252
2010-11-16  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Chromium build fix.

        * WebKit.gyp:
        * scripts/concatenate_css_files.py: Renamed from WebKit/chromium/Build/concatenate_css_files.py.
        * scripts/concatenate_js_files.py: Renamed from WebKit/chromium/Build/concatenate_js_files.py.
        * scripts/generate_devtools_html.py: Renamed from WebKit/chromium/Build/generate_devtools_html.py.

1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265
2010-11-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chrome DevTools: concatenate CSS files, do not link
        missing JS files in release mode.
        https://bugs.webkit.org/show_bug.cgi?id=49586

        * Build/concatenate_css_files.py: Added.
        * Build/concatenate_js_files.py: Added.
        * Build/generate_devtools_html.py: Added.
        * WebKit.gyp:

1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282
2010-11-15  Nat Duca  <nduca@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Make WebWidget actively notify client when compositing enables.
        https://bugs.webkit.org/show_bug.cgi?id=49396

        * public/WebWidgetClient.h:
        (WebKit::WebWidgetClient::didAcceleratedCompositingEnable):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::resize):
        (WebKit::WebViewImpl::paint):
        (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
        (WebKit::WebViewImpl::scrollRootLayerRect):
        (WebKit::WebViewImpl::invalidateRootLayerRect):
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302
2010-11-15  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Remove assumption that GL functions are function pointers
        https://bugs.webkit.org/show_bug.cgi?id=49486

        Added appropriate extension queries and no longer assume that GL
        function names are function pointers which can be tested.

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
        (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
        (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
        (WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::reshape):
        (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap):
        (WebKit::WebGraphicsContext3DDefaultImpl::getString):
        * src/WebGraphicsContext3DDefaultImpl.h:

1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323
2010-11-15  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Kent Tamura.

        Add capability for displaying warnings to autofill popup
        Warnings are displayed in dark gray italic.
        https://bugs.webkit.org/show_bug.cgi?id=49291
        http://code.google.com/p/chromium/issues/detail?id=58509

        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::canRemoveSuggestionAtIndex):
          Updated logic -- can only remove Autocomplete suggestions, which have unique ID 0.
        (WebKit::AutoFillPopupMenuClient::itemIsEnabled): False for warnings.
        (WebKit::AutoFillPopupMenuClient::itemStyle): Dark gray italic for warnings.
        (WebKit::AutoFillPopupMenuClient::menuStyle): Variable name changed.
        (WebKit::AutoFillPopupMenuClient::itemIsWarning): True for unique ID < 0.
        (WebKit::AutoFillPopupMenuClient::initialize): Updated cached styles (see above).
        * src/AutoFillPopupMenuClient.h: Added itemIsEnabled(), variable to cache warning style.
        * src/WebViewImpl.cpp: Minor cleanup.
        (WebKit::WebViewImpl::applyAutoFillSuggestions): 

1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340
2010-11-14  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Improve API for form validation message strings
        https://bugs.webkit.org/show_bug.cgi?id=34945

        * public/WebLocalizedString.h:
        * src/LocalizedStrings.cpp:
        (WebCore::validationMessageTypeMismatchForEmailText):
        (WebCore::validationMessageTypeMismatchForMultipleEmailText):
        (WebCore::validationMessageTypeMismatchForURLText):
        (WebCore::validationMessageTooLongText):
        (WebCore::validationMessageRangeUnderflowText):
        (WebCore::validationMessageRangeOverflowText):
        (WebCore::validationMessageStepMismatchText):

1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351
2010-11-13  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] print doesn't work on http://nodejs.org/api.html
        https://bugs.webkit.org/show_bug.cgi?id=49304

        * src/WebFrameImpl.cpp:
        (WebKit::ChromePrintContext::begin):
        (WebKit::WebFrameImpl::printBegin):

1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363
2010-11-12  James Simonsen  <simonjam@chromium.org>

        Reviewed by Darin Fisher.

        [Web Timing] Rename interfaces:
        - Navigation -> PerformanceNavigation
        - Timing -> PerformanceTiming
        https://bugs.webkit.org/show_bug.cgi?id=48919

        * src/WebPerformance.cpp:
        (WebKit::WebPerformance::navigationType):

1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375
2010-11-12  Zhenyao Mo  <zmo@google.com>

        Reviewed by James Robinson.

        WebGraphicsContext3DDefaultImpl does not run on top of OpenGL ES 2.0 implementations
        https://bugs.webkit.org/show_bug.cgi?id=48282

        Simple fix for a regression introduced in r71793.

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::initialize):

1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388
2010-11-12  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Eric Seidel.

        Remove some trailing whitespace
        https://bugs.webkit.org/show_bug.cgi?id=49433

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::createPopupMenu):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::scrollRootLayerRect):
        (WebKit::WebViewImpl::invalidateRootLayerRect):

1389 1390 1391 1392 1393 1394 1395
2010-11-11  MORITA Hajime  <morrita@google.com>

        Unreviewed another attempt to fx windows build.

        * src/WebBindings.cpp:
        (WebKit::makeStringArrayImpl):

1396 1397 1398 1399 1400 1401 1402
2010-11-11  MORITA Hajime <morrita@google.com>

        Unreviewed attempt to fx windows build.

        * src/WebBindings.cpp:
        (WebKit::makeStringArrayImpl):

1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416
2010-11-11  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        editing/selection/context-menu-on-text.html fails on chromium
        https://bugs.webkit.org/show_bug.cgi?id=45898

        Added makeStringArray(), that is used by DumpRenderTree.
        
        * public/WebBindings.h:
        * src/WebBindings.cpp:
        (WebKit::makeStringArrayImpl): Added.
        (WebKit::WebBindings::makeStringArray): Added.

1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443
2010-11-11  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Nate Chapin.

        [chromium] Convert WebPerformance doubles to seconds
        https://bugs.webkit.org/show_bug.cgi?id=49232

        This makes them suitable for passing to Time::FromDoubleT().

        * src/WebPerformance.cpp:
        (WebKit::millisecondsToSeconds):
        (WebKit::WebPerformance::navigationStart):
        (WebKit::WebPerformance::unloadEventEnd):
        (WebKit::WebPerformance::redirectStart):
        (WebKit::WebPerformance::redirectEnd):
        (WebKit::WebPerformance::fetchStart):
        (WebKit::WebPerformance::domainLookupStart):
        (WebKit::WebPerformance::domainLookupEnd):
        (WebKit::WebPerformance::connectStart):
        (WebKit::WebPerformance::connectEnd):
        (WebKit::WebPerformance::requestStart):
        (WebKit::WebPerformance::requestEnd):
        (WebKit::WebPerformance::responseStart):
        (WebKit::WebPerformance::responseEnd):
        (WebKit::WebPerformance::loadEventStart):
        (WebKit::WebPerformance::loadEventEnd):

1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458
2010-11-11  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: signal IDBFactoryBackendInterface destruction to embedder
        https://bugs.webkit.org/show_bug.cgi?id=49313

        Implement ChromiumBridge::idbShutdown(), passing through to the
        WebKitClient.

        * public/WebKitClient.h:
        (WebKit::WebKitClient::idbShutdown):
        * src/ChromiumBridge.cpp:
        (WebCore::ChromiumBridge::idbShutdown):

1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471
2010-11-10  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Clean up gfx::GetGLImplementation calls in WebGraphicsContext3DDefaultImpl
        https://bugs.webkit.org/show_bug.cgi?id=49336

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
        (WebKit::WebGraphicsContext3DDefaultImpl::reshape):
        (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv):

1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486
2010-11-10  Evan Stade  <estade@chromium.org>

        Reviewed by Tony Chang.

        [chromium] menu key doesn't work when capslock or numslock is on
        https://bugs.webkit.org/show_bug.cgi?id=49289

        Add a special bitmask for the "input" modifier keys (shift, alt, crtl, meta). The Modifier
        enum has grown to something that might be better termed State, but changing the nomenclature
        now is difficult. The bitmask gets its name from the related function getWebInputModifiers.

        * public/WebInputEvent.h: add InputModifiers mask for true modifier keys
        * src/WebViewImpl.cpp: disregard non-modifier keys
        (WebKit::WebViewImpl::keyEvent):

1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497
2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by David Hyatt.

        HTML5 Ruby support should be mandatory feature
        https://bugs.webkit.org/show_bug.cgi?id=49272

        Remove Ruby as optional feature.

        * features.gypi:

1498 1499 1500 1501 1502 1503 1504 1505
2010-11-10  Tony Chang  <tony@chromium.org>

        Unreviewed, add libvpx as a chromium dependency.

        This should fix the chromium linux build.

        * DEPS:

1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519
2010-11-10  Peter Rybin  <peter.rybin@gmail.com>

        Reviewed by Adam Barth.

        HTML parser should provide script column position within HTML document to JavaScript engine
        https://bugs.webkit.org/show_bug.cgi?id=45271

        Replaces script line number with TextPosition structure.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::executeScript):
        (WebKit::WebFrameImpl::executeScriptInIsolatedWorld):
        (WebKit::WebFrameImpl::executeScriptAndReturnValue):

1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546
2010-11-09  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        WebGraphicsContext3DDefaultImpl does not run on top of OpenGL ES 2.0 implementations
        https://bugs.webkit.org/show_bug.cgi?id=48282

        Fixed assumptions in WebGraphicsContext3DDefaultImpl that it was
        running on top of desktop GL.

        Tested various WebGL demos on Windows with ANGLE and
        --in-process-webgl --disable-accelerated-compositing; all are now
        working. Verified that --use-gl=desktop continues to work in the
        same configuration.

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
        (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
        (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
        (WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::isGLES2Compliant):
        (WebKit::WebGraphicsContext3DDefaultImpl::reshape):
        (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv):
        (WebKit::WebGraphicsContext3DDefaultImpl::angleValidateShaderSource):
        * src/WebGraphicsContext3DDefaultImpl.h:

1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564
2010-11-09  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Add form validation message support to WebLocalizedString.h
        https://bugs.webkit.org/show_bug.cgi?id=49239

        * DEPS: Roll Chromium revision to r65502 to have crrev.com/65502
        * public/WebLocalizedString.h: Add new symbols
        * src/LocalizedStrings.cpp: Call query() with the new symbols in the following functions.
        (WebCore::validationMessageValueMissingText):
        (WebCore::validationMessageTypeMismatchText):
        (WebCore::validationMessagePatternMismatchText):
        (WebCore::validationMessageTooLongText):
        (WebCore::validationMessageRangeUnderflowText):
        (WebCore::validationMessageRangeOverflowText):
        (WebCore::validationMessageStepMismatchText):

1565 1566 1567 1568 1569 1570
2010-11-09  Tony Chang  <tony@chromium.org>

        Unreviewed, rolling chromium DEPS.

        * DEPS: Roll to r65462.

1571 1572 1573 1574 1575 1576 1577 1578 1579 1580
2010-11-09  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium Windows build fix.

        Add isDisplayNone to the PopupMenuStyle constructor call in
        PopupMenuTest (necessary after r71618).

        * tests/PopupMenuTest.cpp:
        (WebKit::TestPopupMenuClient::itemStyle):

1581 1582 1583 1584 1585 1586 1587 1588 1589 1590
2010-11-09  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] display:none has no effect on <option> element
        https://bugs.webkit.org/show_bug.cgi?id=49169

        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::initialize):

1591 1592 1593 1594 1595 1596 1597 1598 1599 1600
2010-11-09  James Simonsen  <simonjam@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Web Timing] Remove requestEnd
        https://bugs.webkit.org/show_bug.cgi?id=48924

        * public/WebPerformance.h:
        * src/WebPerformance.cpp:

1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611
2010-11-08  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        Convert to and from DOMTimeStamp with converter functions
        https://bugs.webkit.org/show_bug.cgi?id=49066

        * src/WebDataSourceImpl.cpp:
        (WebKit::WebDataSourceImpl::triggeringEventTime):


1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626
2010-11-08  Pierre-Antoine LaFayette  <pierre.lafayette@gmail.com>

        Reviewed by Darin Fisher.

        [chromium] Adding hasUserGesture flag to the ResourceRequest
        https://bugs.webkit.org/show_bug.cgi?id=37057

        This flag is to be used on the browser side to indicate when a
        download has been user initiated.

        * public/WebURLRequest.h:
        * src/WebURLRequest.cpp:
        (WebKit::WebURLRequest::hasUserGesture):
        (WebKit::WebURLRequest::setHasUserGesture):

1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639
2010-11-08  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Darin Fisher.

        Add an API to WebViewClient that report the load progress for a frame.
        https://bugs.webkit.org/show_bug.cgi?id=49137

        * public/WebViewClient.h:
        (WebKit::WebViewClient::didChangeLoadProgress):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::postProgressEstimateChangedNotification):

 2010-11-08  Alexey Proskuryakov  <ap@apple.com>
ap@apple.com's avatar
ap@apple.com committed
1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=48685
        Notify UI process about focused frame

        Added an empty implementation of the new ChromeClient method.

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::focusedFrameChanged):
        * src/ChromeClientImpl.h:

1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663
2010-11-08  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Only call WebInspector_syncDispatch if it's actually a function.
        https://bugs.webkit.org/show_bug.cgi?id=49180

        * src/WebDevToolsFrontendImpl.cpp:
        (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
        (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
        * src/WebDevToolsFrontendImpl.h:

1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678
2010-11-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Rename Cache to MemoryCache
        https://bugs.webkit.org/show_bug.cgi?id=49159

        * public/WebCache.h:
        * src/WebCache.cpp:
        (WebKit::ToResourceTypeStat):
        (WebKit::WebCache::setCapacities):
        (WebKit::WebCache::clear):
        (WebKit::WebCache::getUsageStats):
        (WebKit::WebCache::getResourceTypeStats):

1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690
2010-11-07  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Kent Tamura.

        Fixing a crasher with the select popup on Mac that happens when a
        page removes the select node when the select changes.
        https://bugs.webkit.org/show_bug.cgi?id=49108

        * src/ExternalPopupMenu.cpp:
        (WebKit::ExternalPopupMenu::didAcceptIndex):
        (WebKit::ExternalPopupMenu::didCancel):

1691 1692 1693 1694 1695 1696 1697 1698
2010-11-06  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Chromium DevTools: disable filesystem inspection
        until polished.
        https://bugs.webkit.org/show_bug.cgi?id=48963

        * src/js/DevTools.js:

1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710
2010-11-05  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Simon Fraser.

        Querying selection start and end should be const
        https://bugs.webkit.org/show_bug.cgi?id=48786

        * public/WebInputElement.h:
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::selectionStart):
        (WebKit::WebInputElement::selectionEnd):

1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721
2010-11-05  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Move resumeAnimations/suspendAnimations from Frame to AnimationController.
        https://bugs.webkit.org/show_bug.cgi?id=49073

        * src/WebAnimationControllerImpl.cpp:
        (WebKit::WebAnimationControllerImpl::suspendAnimations):
        (WebKit::WebAnimationControllerImpl::resumeAnimations):

1722 1723 1724 1725 1726 1727 1728 1729 1730
2010-11-04  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Need to simulate DEPTH_STENCIL in framebufferRenderbuffer / getFramebufferAttachmentParameter
        https://bugs.webkit.org/show_bug.cgi?id=49020

        * src/WebGraphicsContext3DDefaultImpl.cpp: Remove DEPTH_STENCIL_ATTACHMENT emulation at this level.

1731 1732 1733 1734 1735 1736
2010-11-05  Darin Fisher  <darin@chromium.org>

        Pull chromium@65229 to fix the build.

        * DEPS:

1737 1738 1739 1740 1741 1742 1743 1744 1745 1746
2010-11-05  Darin Fisher  <darin@chromium.org>

        Reviewed by Nate Chapin.

        Replace deprecated TargetIsSub{Frame,Resource} with TargetIsSub{frame,resource}.
        https://bugs.webkit.org/show_bug.cgi?id=49074

        * public/WebURLRequest.h:
        * src/FrameLoaderClientImpl.cpp:

1747 1748 1749 1750 1751 1752 1753 1754 1755
2010-11-05  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Fisher.

        WebFrame::previousHistoryItem() should return last committed item.
        https://bugs.webkit.org/show_bug.cgi?id=48809

        * src/WebFrameImpl.cpp:

1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770
2010-10-27  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Clean up IDBTransactionBackend/Coordinator
        https://bugs.webkit.org/show_bug.cgi?id=48425

        Remove obsolete ::id() method.

        * public/WebIDBTransaction.h:
        * src/IDBTransactionBackendProxy.cpp:
        * src/IDBTransactionBackendProxy.h:
        * src/WebIDBTransactionImpl.cpp:
        * src/WebIDBTransactionImpl.h:

1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784
2010-11-04  usaini  <usaini08@gmail.com>

        Reviewed by Antonio Gomes.

        WebWindowFeatures has a faulty constructor for WebCore::WindowFeatures
        https://bugs.webkit.org/show_bug.cgi?id=48035

        * public/WebWindowFeatures.h:
        (WebKit::WebWindowFeatures::WebWindowFeatures): updated the constructor
        that takes in a WebCore::WindowFeature and had it copy all the variables
        over properly so that after calling the constructor WebWindowFeatures is
        always in a valid state. Before, the x,y,width,height booleans may be true, but
        the corresponding int values would not be updated.

1785 1786 1787 1788 1789 1790 1791 1792 1793 1794
2010-11-04  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Remove IMPLEMENTATION_COLOR_READ_FORMAT and TYPE
        https://bugs.webkit.org/show_bug.cgi?id=48938

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv):

1795 1796 1797 1798 1799 1800 1801 1802 1803
2010-11-04  Kavita Kanetkar  <kkanetkar@chromium.org>

        Reviewed by Adam Barth.

        Web Inspector: Enable files ystem UI for chromium
        https://bugs.webkit.org/show_bug.cgi?id=48963

        * src/js/DevTools.js:

1804 1805 1806 1807 1808 1809 1810
2010-11-03  Adam Barth  <abarth@webkit.org>

        Roll Chromium DEPS
        https://bugs.webkit.org/show_bug.cgi?id=48978

        * DEPS:

1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829
2010-11-03  Vincent Scheib  <scheib@chromium.org>

        Reviewed by James Robinson.

        [chromium] GraphicsContext3D creation attributes include canRecoverFromContextLoss option
        https://bugs.webkit.org/show_bug.cgi?id=48850

        Implementations of GraphicsContext3D may respect the creation attribute
        canRecoverFromContextLoss being false, and then only succeeding initialization if
        the context can satisfy that request of never being lost. DX9 on XP can not satisfy
        such a request.

        Test by use of accelerated canvas 2d in Chromium with ANGLE on XP machines.

        * public/WebGraphicsContext3D.h:
        (WebKit::WebGraphicsContext3D::Attributes::Attributes):
        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::initialize):

1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844
2010-11-03  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Dmitry Titov.

        Chromium: Update resource tracking when moving a frame between documents
        https://bugs.webkit.org/show_bug.cgi?id=48363

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::removeIdentifierForRequest):
        Added
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::transferLoadingResourceFromPage):
        Notify current WebFrameClient of the resource and remove from
        former WebFrameClient.

1845 1846 1847 1848 1849 1850 1851
2010-11-03  Adam Barth  <abarth@webkit.org>

        Roll Chromium DEPs
        https://bugs.webkit.org/show_bug.cgi?id=48959

        * DEPS:

1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905
2010-11-03  Kenneth Russell  <kbr@google.com>

        Reviewed by Chris Marrin.

        Redesign extension mechanism in GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=46894

        Upon request, factored out extension support from GraphicsContext3D
        into a new Extensions3D class. (The plural was chosen because the
        class and subclasses hold multiple extensions.)

        Unlike GraphicsContext3D, Extensions3D contains only pure virtual
        methods. This was done because Extensions3D's inheritance diagram
        and usage pattern is very different from that of GraphicsContext3D,
        and the concrete subclasses need to decide how to implement the
        various entry points. Requiring them to be placed at the
        Extensions3D level will cause implementation details to leak into
        the base class, which is highly undesirable. Any virtual call
        overhead to these entry points will be negligible.

        Changed call sites utilizing these extensions to call through the
        Extensions3D object or its subclasses.

        Tested:
         - Chromium on Linux with accelerated 2D canvas and HTML5 video
         - Chromium on Mac OS X with WebGL and CSS 3D content
         - Safari on Mac OS X with WebGL and CSS 3D content

        No new tests. Covered by existing tests.

        * WebKit.gyp:
        * public/WebGraphicsContext3D.h:
        * src/Extensions3DChromium.cpp: Added.
        (WebCore::Extensions3DChromium::Extensions3DChromium):
        (WebCore::Extensions3DChromium::~Extensions3DChromium):
        (WebCore::Extensions3DChromium::supports):
        (WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
        (WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
        (WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
        (WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
        (WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
        (WebCore::Extensions3DChromium::copyTextureToParentTextureCHROMIUM):
        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::getExtensions):
        (WebCore::GraphicsContext3DInternal::supportsExtension):
        * src/GraphicsContext3DInternal.h:
        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::copyTextureToParentTextureCHROMIUM):
        (WebKit::WebGraphicsContext3DDefaultImpl::getString):
        * src/WebGraphicsContext3DDefaultImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::composite):

1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917
2010-11-03  Daniel Bates  <dbates@rim.com>

        For unnamed frames, window.name returns a generated name
        https://bugs.webkit.org/show_bug.cgi?id=6751

        Part 1 of 2.

        Substitute FrameTree::uniqueName() for FrameTree::name() in the Chromium port.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::name):

1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935
2010-11-02  Al Patrick  <apatrick@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Plugin instances can propagate the ID of the OpenGL texture they render to.

        https://bugs.webkit.org/show_bug.cgi?id=48032

        * public/WebPlugin.h:
        (WebKit::WebPlugin::getBackingTextureId):
        * public/WebPluginContainer.h:
        (WebKit::WebPluginContainer::commitBackingTexture):
        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::commitBackingTexture):
        (WebKit::WebPluginContainerImpl::platformLayer):
        (WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
        * src/WebPluginContainerImpl.h:

1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946
2010-11-02  Kavita Kanetkar  <kkanetkar@chromium.org>

        Reviewed by Dumitru Daniliuc.

        [FileSystem] Support not creating directories when queried by inspector.
        https://bugs.webkit.org/show_bug.cgi?id=48169

        * src/LocalFileSystemChromium.cpp:
        (WebCore::LocalFileSystem::readFileSystem):
        (WebCore::LocalFileSystem::requestFileSystem):

1947 1948 1949 1950 1951 1952 1953 1954 1955 1956
2010-11-02  Chris Guillory  <chris.guillory@google.com>

        Reviewed by Chris Fleizach.

        Chromium: Propagate a document value changed notification on scroll.
        https://bugs.webkit.org/show_bug.cgi?id=48817

        * src/WebAccessibilityObject.cpp:
        (WebKit::WebAccessibilityObject::boundingBoxRect):

1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968
2010-10-29  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        [chromium]: Allow plugins to use optimized scrolling
        https://bugs.webkit.org/show_bug.cgi?id=48660

        * public/WebPluginContainer.h:
        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::scrollRect):
        * src/WebPluginContainerImpl.h:

1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979
2010-11-02  Marc-Antoine Ruel  <maruel@chromium.org>

        Reviewed by Dimitri Glazkov.

        Disable incremental linking for webkit_unit_test and DumpRenderTRee on x86 Windows on chromium build.
        https://bugs.webkit.org/show_bug.cgi?id=48836

        It fails to link otherwise due to lack of virtual address space.

        * WebKit.gyp:

1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991
2010-11-02  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Kent Tamura.

        Expose the sendChangeEvent parameter in WebInputElement::setValue() API,
        primarily so that chromium form autofill can fire the onChange event.
        https://bugs.webkit.org/show_bug.cgi?id=48177

        * public/WebInputElement.h:
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::setValue):

1992 1993 1994 1995 1996 1997 1998 1999 2000
2010-11-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: make properties and event listeners look consistent with the styles section.
        https://bugs.webkit.org/show_bug.cgi?id=48827

        * src/js/devTools.css:

2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012
2010-11-01  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Compile TestNetscapePlugin on chromium win
        https://bugs.webkit.org/show_bug.cgi?id=48802

        It creates npTestNetscapePlugin.dll in the build directory, so
        it's not yet loaded by DRT or test_shell.

        * WebKit.gyp:

2013 2014 2015 2016 2017 2018 2019 2020 2021 2022
2010-11-01  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders Carlsson.

        <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
        Context menu support for WebKit 2.

        * src/ChromeClientImpl.h:
        (WebKit::ChromeClientImpl::showContextMenu):

2023 2024 2025 2026 2027 2028 2029
2010-11-01  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: Chromium build fix.

        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl):

2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040
2010-11-01  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: remove old resources panel.
        https://bugs.webkit.org/show_bug.cgi?id=45657

        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):
        * src/WebDevToolsAgentImpl.h:

2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053
2010-11-01  Leandro Gracia Gil  <leandrogracia@google.com>

        Reviewed by Jeremy Orlow.

        This is the last part of a 4-sided patch for the language attribute
        in speech text buttons. This patch removes what now is dead code
        and re-enables the layout test introduced by bug 47089.
        https://bugs.webkit.org/show_bug.cgi?id=47420

        * public/WebSpeechInputControllerMock.h:
        * src/WebSpeechInputControllerMockImpl.cpp:
        * src/WebSpeechInputControllerMockImpl.h:

2054 2055 2056 2057 2058 2059 2060 2061 2062 2063
2010-10-31  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: unhide new network and resources panels.
        https://bugs.webkit.org/show_bug.cgi?id=48725

        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):

2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077
2010-10-29  Daniel Bates  <dbates@rim.com>

        No review, rolling out 70971.
        http://trac.webkit.org/changeset/70971
        https://bugs.webkit.org/show_bug.cgi?id=6751

        Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
        it caused layout test failures on all bots. In particular, the
        child count in a generated frame name differs after this patch. We need
        to look into this further.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::name):

2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089
2010-10-28  Antonio Gomes  <agomes@rim.com>

        Reviewed by Ojan Vafai.

        Needs a "LinuxEditingBehavior", perhaps with a better name
        https://bugs.webkit.org/show_bug.cgi?id=36627

        Added the corresponding Chromium setting to WebCore's EditingUnixBehavior: EditingBehaviorUnix.

        * public/WebSettings.h:
        * src/AssertMatchingEnums.cpp:

2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101
2010-10-29  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Barth.

        For unnamed frames, window.name returns a generated name
        https://bugs.webkit.org/show_bug.cgi?id=6751

        Modified Chromium-port to use FrameTree::uniqueName().

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::name):

2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114
2010-10-29  Kavita Kanetkar  <kkanetkar@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: FileSystem integration
        https://bugs.webkit.org/show_bug.cgi?id=45982

        * public/WebFileUtilities.h:
        (WebKit::WebFileUtilities::revealFolderInOS):
        * src/ChromiumBridge.cpp:
        (WebCore::ChromiumBridge::revealFolderInOS):


2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125
2010-10-29  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
        https://bugs.webkit.org/show_bug.cgi?id=48574

        * src/BackForwardListClientImpl.h: Use BackForwardListImpl.h.
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl): Cast to BackForwardList* before calling setClient.

2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136
2010-10-28  Michael Nordman  <michaeln@google.com>

        Reviewed by ap.

        [Chrome] Fix an appcache regression introduced in r69226
        https://bugs.webkit.org/show_bug.cgi?id=48592
        Provide a noop method body ApplicationCacheHost::maybeLoadMainResourceForRedirect.

        * src/ApplicationCacheHost.cpp:
        (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):

2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152
2010-10-29  Aaron Colwell  <acolwell@chromium.org>

        Reviewed by James Robinson.

        Fix globalAlpha support when using drawImage() to copy a video frame
        to a 2D canvas context.
        https://bugs.webkit.org/show_bug.cgi?id=48094

        This fix applies the globalAlpha value to the canvas before passing it
        down to the lower layers that don't have access to the graphics
        context. This makes sure that any drawing on the canvas will have the
        proper global alpha value applied.

        * src/WebMediaPlayerClientImpl.cpp:
        (WebKit::WebMediaPlayerClientImpl::paint):

ap@apple.com's avatar
ap@apple.com committed
2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165
2010-10-29  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=48576
        Let WebKit2 client know when a frame is a frameset

        Added a blank implementation of the new FrameLoaderClient method.

        * src/FrameLoaderClientImpl.h:
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidBecomeFrameset):

2166 2167 2168 2169 2170 2171 2172 2173 2174 2175
2010-10-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: add close button to network view, make tests pass
        for resource manager on all ports.
        https://bugs.webkit.org/show_bug.cgi?id=48628

        * src/js/Tests.js:

2176 2177 2178 2179 2180 2181 2182 2183 2184
2010-10-29  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Adam Roben and David Kilzer.

        Fix and cleanup of build systems
        https://bugs.webkit.org/show_bug.cgi?id=48342

        * features.gypi: Remove unnecessary ENABLE_SANDBOX.

2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215
2010-10-29  Leandro Gracia Gil  <leandrogracia@google.com>

        Reviewed by Jeremy Orlow.

        Patch the current speech input implementation to use the nearest
        language tag. The language is now passed to the startRecognition
        methods so that language-specific recognition could be used. Also added
        a second parameter to setMockSpeechInputResult for the language used in
        speech recognition.
        https://bugs.webkit.org/show_bug.cgi?id=47089

        This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
        details see http://codereview.chromium.org/3615005/show,
        http://codereview.chromium.org/3595018/show and
        https://bugs.webkit.org/show_bug.cgi?id=47420.

        * public/WebSpeechInputController.h:
        (WebKit::WebSpeechInputController::startRecognition):
        * public/WebSpeechInputControllerMock.h:
        * src/SpeechInputClientImpl.cpp:
        (WebKit::SpeechInputClientImpl::create):
        (WebKit::SpeechInputClientImpl::startRecognition):
        * src/SpeechInputClientImpl.h:
        * src/WebSpeechInputControllerMockImpl.cpp:
        (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult):
        (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
        * src/WebSpeechInputControllerMockImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        * src/WebViewImpl.h:

2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228
2010-10-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel, Peter Kasting, and Darin Fisher.
        (Eric reviewed the CoreGraphics interactions, Peter reviewed the image
        decoder interaction, and Darin Fisher SGTMed the policy decision.)

        [chromium] Chromium Mac should use WebKit's image decoders
        https://bugs.webkit.org/show_bug.cgi?id=47974

        Enable WebKit's image decoders.

        * features.gypi:

2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253
2010-10-28  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Darin Adler.

        [Chromium] History related tests REGRESSED after r70723
        https://bugs.webkit.org/show_bug.cgi?id=48513

        Since r70723 made BackForwardList::currentItem no longer be virtual,
        we were not reaching the implementation in Chromium's 
        BackForwardListClientImpl, and for Chromium currentItem is not the same
        as itemAtIndex(0).
        
        The fix is to make itemAtIndex(0) have the currentItem() behavior, which
        lets us keep currentItem as non-virtual (and remove its implementation
        from the Chromium side).
        
        This also switches Chromium to use the default implementation of 
        backItem() and forwardItem() (vs. the old stubs that just had
        ASSERT_NOT_REACHED) since they're actually reacheable with Chromium
        code thanks to the calls in FrameLoader::checkDidPerformFirstNavigation.

        * src/BackForwardListClientImpl.cpp:
        (WebKit::BackForwardListClientImpl::itemAtIndex):
        * src/BackForwardListClientImpl.h:

2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267
2010-10-28  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        [Chromium] Support FileSystem in chromium DRT
        https://bugs.webkit.org/show_bug.cgi?id=47643
        Update the chromium DEPS to pick up corresponding webkit_support change.
        Also add a temporary glue implementation with FIXME comment to
        WebFrameClient::openFileSystem.

        * DEPS:
        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::openFileSystem):

2268 2269 2270 2271 2272 2273 2274 2275 2276 2277
2010-10-28  Satish Sampath  <satish@chromium.org>

        Reviewed by Steve Block.

        Remove obsolete public/API methods in chromium port
        https://bugs.webkit.org/show_bug.cgi?id=48504

        * public/WebSpeechInputController.h:
        (WebKit::WebSpeechInputController::startRecognition):

2278 2279 2280 2281 2282 2283 2284 2285 2286