ChangeLog 2.13 MB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
2013-08-21  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r154416.
        http://trac.webkit.org/changeset/154416
        https://bugs.webkit.org/show_bug.cgi?id=120147

        Broke Windows builds (Requested by rniwa on #webkit).

        * WebCore.vcxproj/WebCoreGenerated.make:
        * WebCore.vcxproj/WebCoreGeneratedWinCairo.make:
        * WebCore.vcxproj/WebCoreGeneratedWinCairoCommon.props:
        * WebCore.vcxproj/build-generated-files.sh:
        * WebCore.vcxproj/copyForwardingHeaders.cmd:
        * WebCore.vcxproj/copyWebCoreResourceFiles.cmd:

16
17
18
19
20
21
22
2013-08-21  Ryuan Choi  <ryuan.choi@samsung.com>

        [EFL] Unreviewed build fix after r154430.

        * rendering/style/StyleRareNonInheritedData.cpp:
        (WebCore::StyleRareNonInheritedData::hasFilters): Added CSS_FILTERS guard.

23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
2013-08-21  Simon Fraser  <simon.fraser@apple.com>

        Setting -webkit-filter: in :active selector causes failure to redraw
        https://bugs.webkit.org/show_bug.cgi?id=120135

        Reviewed by Jer Noble.
        
        When removing a filter on an inline child of a compositing layer,
        the inline loses its RenderLayer and compositing layer, but we fail to
        repaint the compositing layer that the inline is now painting into.
        
        This worked correctly for opacity, because opacity toggles cause
        layouts (which then paint the correct layer), so do the same for filters.

        Test: css3/filters/remove-filter-repaint.html

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::changeRequiresLayout): Return true if we toggled
        between having filters and not. Drive-by cleanup, making use of new convenience
        function for hasOpacity().
        * rendering/style/StyleRareNonInheritedData.cpp:
        (WebCore::StyleRareNonInheritedData::hasFilters): Returns true if we have any
        filters.
        * rendering/style/StyleRareNonInheritedData.h:
        (WebCore::StyleRareNonInheritedData::hasOpacity): Convenience function that
        returns true if opacity is < 1.

50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
2013-08-21  Gavin Barraclough  <barraclough@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=120139
        PropertyDescriptor argument to define methods should be const

        Rubber stamped by Sam Weinig.

        This should never be modified, and this way we can use rvalues.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::defineOwnProperty):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::defineOwnProperty):
        (WebCore::JSLocationPrototype::defineOwnProperty):
        * bindings/scripts/CodeGeneratorJS.pm:
        (GenerateHeader):
            - make PropertyDescriptor const

68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
2013-08-21  Jacky Jiang  <zhajiang@blackberry.com>

        <https://webkit.org/b/120123> [BlackBerry] Incorrect origin of indexOfTile in LayerTiler can cause unnecessary texture jobs and waste memory

        Reviewed by Yong Li.
        Internally reviewed by Arvid Nilsson.

        JIRA 481356
        The origin of indexOfTile(origin) is incorrect in these two places. For
        example, if the maxXMaxYCorner of the rect is (768, 768), there can be
        three other redundant indexOfTile (0, 1), (1, 0), (1, 1) which can cause
        unnecessary texture jobs and waste memory.
        The origin should be the top left of the bottom right pixel of a rect.

        * platform/graphics/blackberry/LayerTiler.cpp:
        (WebCore::LayerTiler::updateTextureContentsIfNeeded):
        (WebCore::LayerTiler::processTextureJob):

86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
2013-08-21  Simon Fraser  <simon.fraser@apple.com>

        <https://webkit.org/b/116901> ASSERTION FAILED: !m_visibleDescendantStatusDirty on twitter

        Reviewed by Beth Dakin.
        
        In order to make decisions about compositing, the m_hasVisibleDescendant bit on RenderLayers
        needs to be up-to-date when RenderLayerCompositor::computeCompositingRequirements is recursing
        over the RenderLayer tree.
        
        However, was possible for computeCompositingRequirements() to hit a layer whose m_visibleDescendantStatusDirty
        bit was set; we only clear this bit from collectLayers() (when updating z-order lists), and from styleChanged()
        which requires that style changed on the layer itself.
        
        Fix by always calling updateDescendantDependentFlags() from computeCompositingRequirements().

        Wasn't able to easily get a reduced testcase.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::computeCompositingRequirements):

107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
2013-08-21  Alex Christensen  <achristensen@apple.com>

        <https://webkit.org/b/120137> Separating Win32 and Win64 builds.

        Reviewed by Brent Fulgham.

        * WebCore.vcxproj/WebCoreGenerated.make:
        * WebCore.vcxproj/WebCoreGeneratedWinCairo.make:
        Pass PlatformArchitecture as a command line parameter to bash scripts
        and use PlatformArchitecture to determine which directory to delete
        while cleaning (obj32 or obj64).
        * WebCore.vcxproj/WebCoreGeneratedWinCairoCommon.props:
        Export PlatformArchitecture to be used by make and cmd scripts.
        * WebCore.vcxproj/build-generated-files.sh:
        Use PlatformArchitecture from command line to determine which object directory to use (obj32 or obj64).
        * WebCore.vcxproj/copyForwardingHeaders.cmd:
        * WebCore.vcxproj/copyWebCoreResourceFiles.cmd:
        Use PlatformArchitecture to determine which directory to copy to (obj32 or obj64).

126
127
128
129
130
131
132
133
134
135
136
137
138
2013-08-21  Tim Horton  <timothy_horton@apple.com>

        revalidateTiles and ensureTilesForRect can share a lot of code
        https://bugs.webkit.org/show_bug.cgi?id=119282

        Missed the review comments, whoops.

        * platform/graphics/ca/mac/TileController.h:
        * platform/graphics/ca/mac/TileController.mm:
        (WebCore::TileController::prepopulateRect):
        (WebCore::TileController::revalidateTiles):
        (WebCore::TileController::ensureTilesForRect):

139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
2013-08-21  Andreas Kling  <akling@apple.com>

        <https://webkit.org/b/120115> SVG elements always have custom style resolve callbacks.

        Reviewed by Antti Koivisto.

        Simplify SVGElement construction by making them opt in to custom style resolve callbacks
        by default, and removing the ability to pass a custom ConstructionType to some subclass
        constructors.

        * dom/Node.h:

            Add HasCustomStyleResolveCallbacksFlag to the CreateSVGElement mask.

        * svg/SVGElement.cpp:
        (WebCore::SVGElement::SVGElement):
        * svg/SVGElement.h:
        * svg/SVGGElement.cpp:
        (WebCore::SVGGElement::SVGGElement):
        * svg/SVGGElement.h:
        * svg/SVGGraphicsElement.cpp:
        (WebCore::SVGGraphicsElement::SVGGraphicsElement):
        * svg/SVGGraphicsElement.h:
        * svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::SVGImageElement):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::SVGStyledElement):
        * svg/SVGStyledElement.h:

            Remove calls to setHasCustomStyleResolveCallbacks() in SVGElement and subclasses.
            Also remove unnecessary ConstructionType argument from subclasses since nobody
            overrides it and everyone just uses CreateSVGElement.

172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
2013-08-21  Tim Horton  <timothy_horton@apple.com>

        revalidateTiles and ensureTilesForRect can share a lot of code
        https://bugs.webkit.org/show_bug.cgi?id=119282

        Reviewed by Simon Fraser.

        No new tests, just a refactoring.

        The bodies of ensureTilesForRect and revalidateTiles are nearly equivalent.

        * platform/graphics/ca/mac/TileController.h:
        Add an enum, NewTileType, to note whether the tiles created by ensureTilesForRect will
        be primary coverage tiles or secondary out-of-view tiles.

        * platform/graphics/ca/mac/TileController.mm:
        (WebCore::TileController::prepopulateRect):
        Move the code to see if we already have the requisite tiles in the
        primary coverage rect, as well as our call to updateTileCoverageMap,
        out into prepopulateRect, to generalize ensureTilesForRect.

        (WebCore::TileController::revalidateTiles):
        Make use of ensureTilesForRect. The platformCALayerDidCreateTiles call will happen there, now.

        (WebCore::TileController::ensureTilesForRect):
        Make ensureTilesForRect return the rect that it created tiles for, and only put
        tiles in a cohort if we're creating secondary tiles.

200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
2013-08-21  Tim Horton  <timothy_horton@apple.com>

        isReplacementObscured is wrong when the indicator is clipped by an iframe
        https://bugs.webkit.org/show_bug.cgi?id=120031
        <rdar://problem/14606819>

        Reviewed by Simon Fraser.

        Hit-test for plugin obscurity in the root document. To do this, we also need
        to convert the indicator rectangle into root view coordinates before
        hit testing its edges.

        This resolves the case where an iframe which clips its content was reporting
        the indicator as not obscured, despite the fact that it was obscured from the
        point of view of the user.

        Updated test plugins/unavailable-plugin-indicator-obscurity.html

        * rendering/RenderEmbeddedObject.cpp:
        (WebCore::RenderEmbeddedObject::isReplacementObscured):

221
222
223
224
225
226
227
228
2013-08-21  Andreas Kling  <akling@apple.com>

        <https://webkit.org/b/120132> Frame::navigationScheduler() should return a reference.

        Reviewed by Anders Carlzon.

        Frame::m_navigationScheduler is an inline member, not a pointer.

229
230
231
232
233
234
235
236
237
238
239
240
241
2013-08-21  Tim Horton  <timothy_horton@apple.com>

        REGRESSION(r154399): broke Mac ML debug WK1 tests > 50 crashes (Requested by thorton on #webkit).
        https://bugs.webkit.org/show_bug.cgi?id=120129

        Rolling out http://trac.webkit.org/changeset/154399.

        * rendering/RenderBlock.cpp:
        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
        * rendering/RenderBox.h:

242
243
244
245
246
247
248
249
250
251
2013-08-21  Andreas Kling  <akling@apple.com>

        <https://webkit.org/b/120118> Frame::animation() should return a reference.

        Reviewed by Anders Carlsson.

        Frame::m_animationController is never null.
        Also changed RenderObject::animation() to return a reference since it's just a wrapper
        around RenderObject::frame()->animation() with no null checking of frame().

252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
2013-08-21  Simon Fraser  <simon.fraser@apple.com>

        Allow opacity to apply to custom scrollbars
        https://bugs.webkit.org/show_bug.cgi?id=120104

        Reviewed by David Hyatt.
        
        Opacity was ignored custom scrollbar pseudoelements because custom scrollbar
        renderers never create layers, and opacity is normally handled by the RenderLayer code.
        
        Fix by having RenderScrollbarTheme and RenderScrollbarPart do the transparency
        layers necessary for opacity. RenderScrollbarPart handles opacity for individual
        parts.
        
        Because ScrollbarThemeComposite::paint() renders the parts on after another (with
        no nesting), opacity handling for the entire scrollbar needs special-casing.
        This is done by willPaintScrollbar()/didPaintScrollbar() on the theme.
        RenderScrollbarTheme consults the opacity the scrollbar (which we get from
        the ScrollbarBGPart renderer) to decide whether to set up a transparency layer.

        Test: scrollbars/scrollbar-parts-opacity.html

        * platform/ScrollbarThemeComposite.cpp:
        (WebCore::ScrollbarThemeComposite::paint):
        * platform/ScrollbarThemeComposite.h:
        (WebCore::ScrollbarThemeComposite::willPaintScrollbar):
        (WebCore::ScrollbarThemeComposite::didPaintScrollbar):
        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::opacity):
        * rendering/RenderScrollbar.h:
        * rendering/RenderScrollbarPart.cpp:
        (WebCore::RenderScrollbarPart::paintIntoRect):
        * rendering/RenderScrollbarTheme.cpp:
        (WebCore::RenderScrollbarTheme::willPaintScrollbar):
        (WebCore::RenderScrollbarTheme::didPaintScrollbar):
        * rendering/RenderScrollbarTheme.h:

289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
2013-08-21  Robert Hogan  <robert@webkit.org>

        REGRESSION(r127163): Respect clearance set on ancestors when placing floats
        https://bugs.webkit.org/show_bug.cgi?id=119979

        Reviewed by David Hyatt.

        If a float has a self-collapsing ancestor with clearance then it needs to respect
        that clearance when placing itself on the line.

        Test: fast/block/margin-collapse/self-collapsing-block-with-float-descendant.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::marginOffsetForSelfCollapsingBlock):
        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::previousInFlowSiblingBox):

309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
2013-08-21  Brent Fulgham  <bfulgham@apple.com>

        <https://webkit.org/b/120113> [Windows] Enable CSS_IMAGE_SET

        Reviewed by Anders Carlsson.

        We can now activate:
        fast/css/image-set-parsing.html
        fast/css/image-set-parsing-invalid.html

        * WebCore.vcxproj/WebCore.vcxproj: Add missing image set implementation files.
        * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
        * css/CSSAllInOne.cpp: Add missing CSSImageSetValue.cpp
        * rendering/style/StyleAllInOne.cpp: Add missing StyeCachedImageSet.cpp

324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
2013-08-21  Robert Hogan  <robert@webkit.org>

        In RenderTableCell::paintCollapsedBorders() check surrounding cells using physical rather than logical direction
        https://bugs.webkit.org/show_bug.cgi?id=120074

        Reviewed by David Hyatt.

        No new tests, covered by existing tests.

        The functions cellAbove(), cellBelow() etc. check the logical rather than the physical direction but they're being
        used to decide the painting of the physical borders of the cell. As we paint all four sides of every cell, and
        the borders of adjoining cells twice over, this has no impact on painting currently but making the check consistent
        in its treatment of physical and logical direction will help with webkit.org/b/119759 and make the code less confusing
        to the next guy.

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::cellAtLeft):
        (WebCore::RenderTableCell::cellAtRight):
        (WebCore::RenderTableCell::cellAtTop):
        (WebCore::RenderTableCell::cellAtBottom):
        (WebCore::RenderTableCell::paintCollapsedBorders):
        * rendering/RenderTableCell.h:

347
348
349
350
351
352
353
354
355
356
2013-08-21  Róbert Sipka  <sipka@inf.u-szeged.hu>

        <https://webkit.org/b/120109> [curl] only include WebCoreBundleWin on Windows

        Reviewed by Brent Fulgham.

        The WebCoreBundleWin is a windows specific file, it is only needed on Windows.

        * platform/network/curl/ResourceHandleManager.cpp:

357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
2013-08-21  Jae Hyun Park  <jae.park@company100.net>

        [Qt] Remove unused code path in PluginView
        https://bugs.webkit.org/show_bug.cgi?id=113173

        Reviewed by Anders Carlsson.

        m_platformLayer in PluginView has been removed in r121710, but there are
        still some leftover code path related to m_platformLayer. This patch
        removes unused code path.

        No new tests, removing unused code paths.

        * plugins/PluginView.h:
        (PluginView):
        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::updatePluginWidget):
        (WebCore::PluginView::paint):

376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
2013-08-21  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        Font’s fast code path doesn’t handle partial runs correctly when kerning or ligatures are enabled 
        https://bugs.webkit.org/show_bug.cgi?id=100050

        Reviewed by Antti Koivisto.

        Always let WidthIterator iterate over an entire TextRun to avoid problems
        with pixel rounding or shaping on partial runs.

        This fix is necessary for Qt because the complex font-path can not disable
        shaping, leading to the complex path painting slighly different from the
        fast path, which messes up selection painting.

        No change in functionality, no new tests.

        * platform/graphics/Font.cpp:
        (WebCore::Font::drawText):
        (WebCore::Font::drawEmphasisMarks):
        (WebCore::Font::selectionRectForText):
        (WebCore::Font::offsetForPosition):
        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::getGlyphsAndAdvancesForSimpleText):
        (WebCore::Font::selectionRectForSimpleText):
        (WebCore::Font::offsetForPositionForSimpleText):
        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::add):
        (GlyphBuffer):
        * platform/graphics/WidthIterator.cpp:
        (WebCore::WidthIterator::advanceInternal):
        * platform/graphics/WidthIterator.h:
        (WidthIterator): Removed now unused advanceOneCharacter method.

409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
2013-08-20  Antonio Gomes  <a1.gomes@sisa.samsung.com>

        Harden RenderBox::canBeScrolledAndHasScrollableArea logic
        https://bugs.webkit.org/show_bug.cgi?id=104373

        Reviewed by Simon Fraser.

        Previously if a say div has a overflown content on 'y' but is
        styled as "overflow-x: auto; overflow-y: hidden", RenderBox::canBeProgramaticallyScrolled
        would still return true. It interfers, among other things, with the way
        autoscroll works.

        Patch fixes it by adding two helper methods to RenderBox class in order to verify a box'
        scrollability in a given axis (x or y); They are used when checking if a given box is in
        fact programatically scrollable.

        Test: fast/events/autoscroll-overflow-hidden-longhands.html

        WebKit autoscroll behavior now matches Firefox and Opera12 (pre-blink)
        in that sense.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::canBeProgramaticallyScrolled):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::hasScrollableOverflowX):
        (WebCore::RenderBox::hasScrollableOverflowY):

436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
2013-08-19  Antonio Gomes  <a1.gomes@sisa.samsung.com>

        Text dragging can scroll overflow:hidden boxes
        https://bugs.webkit.org/show_bug.cgi?id=119760

        Reviewed by Darin Adler.

        Consider the case of the following HTML:
        <div style="overflow:hidden; width: 100px; height: 100px" >
          <input id="input" type="text" size=10 value="any text here!"/>
          <button style="position:relative; top: 100px; left: 100px"/>
        </div>

        If ones starts a text selection by dragging the mouse from within the input
        field, and continues to drag beyong the outer div boundary, the latter will
        be scrolled no matter its overflow:hidden style.
        That happens because when the autoscroll has started, it gets propagated up
        to the current layer's parent layer, instead of the to current layer's enclosing
        scrollable layer.

        Patch fixes the issue by hardening the way scrolling is
        propagated upwards when autoscroll is being performed.

        RenderLayer::enclosingScrollableLayer method also got rewritten
        in terms of RenderLayer tree traversing, instead of RenderObject tree.
        The rewrite adds support for cross frame upwards traversal.

        Test: fast/events/autoscroll-upwards-propagation.html

        * rendering/RenderLayer.cpp:
        (WebCore::parentLayerCrossFrame):
        (WebCore::RenderLayer::enclosingScrollableLayer):
        (WebCore::RenderLayer::scrollRectToVisible):

470
471
472
473
474
475
476
477
478
479
480
481
482
2013-08-20  Jer Noble  <jer.noble@apple.com>

        <https://webkit.org/b/120101> [Mac] Suspended HTMLMediaElements can still hold power assertion after playback stops.

        Reviewed by Eric Carlson.

        Call updateDisplaySleep() when we clear our MediaPlayer, as doing so may kill any in-flight
        rateChanged() notifications.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::clearMediaPlayer):
        (WebCore::HTMLMediaElement::stop):

483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
2013-08-20  David Barr <davidbarr@chromium.org>, Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        <https://webkit.org/b/92330> [CSS] Pass an image orientation data to drawImage()

        Reviewed by Beth Dakin.

        In support of ongoing css3-images image-orientation implementation. This patch passes
        an imageOrientationDescription object to drawImage() function as a argument. The drawImage()
        can know information of image orientation by the argument.

        Spec: http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::paint):
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawImage):
        (WebCore::drawImageToContext):
        * platform/graphics/ImageOrientation.h: Add setter functions.
        (WebCore::ImageOrientationDescription::setRespectImageOrientation):
        (WebCore::ImageOrientationDescription::setImageOrientationEnum):
        * platform/graphics/texmap/TextureMapperImageBuffer.cpp:
        (WebCore::BitmapTextureImageBuffer::updateContents):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintNinePieceImage):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintReplaced):
        (WebCore::RenderImage::paintIntoRect):
        * rendering/RenderSnapshottedPlugIn.cpp:
        (WebCore::RenderSnapshottedPlugIn::paintSnapshot):

513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
2013-08-20  Gavin Barraclough  <barraclough@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=120093
        Remove getOwnPropertyDescriptor trap

        Reviewed by Geoff Garen.

        All implementations of this method are now called via the method table, and equivalent in behaviour.
        Remove all duplicate implementations (and the method table trap), and add a single member function implementation on JSObject.

        * WebCore.exp.in:
        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        (GenerateHeader):
        (GenerateImplementation):
        (GenerateConstructorDeclaration):
        (GenerateConstructorHelperMethods):
        * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
        * bindings/scripts/test/JS/JSTestActiveDOMObject.h:
        * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
        * bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
        * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
        * bindings/scripts/test/JS/JSTestEventConstructor.h:
        * bindings/scripts/test/JS/JSTestEventTarget.cpp:
        * bindings/scripts/test/JS/JSTestEventTarget.h:
        * bindings/scripts/test/JS/JSTestException.cpp:
        * bindings/scripts/test/JS/JSTestException.h:
        * bindings/scripts/test/JS/JSTestInterface.cpp:
        * bindings/scripts/test/JS/JSTestInterface.h:
        * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
        * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
        * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
        * bindings/scripts/test/JS/JSTestNamedConstructor.h:
        * bindings/scripts/test/JS/JSTestNode.cpp:
        * bindings/scripts/test/JS/JSTestNode.h:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        * bindings/scripts/test/JS/JSTestObj.h:
        * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
        * bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
        * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
        * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
        * bindings/scripts/test/JS/JSTestTypedefs.cpp:
        * bindings/scripts/test/JS/JSTestTypedefs.h:
        * bridge/jsc/BridgeJSC.h:
        (JSC::Bindings::Instance::getOwnPropertySlot):
        * bridge/objc/objc_runtime.h:
        * bridge/objc/objc_runtime.mm:
        * bridge/runtime_array.cpp:
        * bridge/runtime_array.h:
        * bridge/runtime_method.cpp:
        * bridge/runtime_method.h:
        * bridge/runtime_object.cpp:
        * bridge/runtime_object.h:
            - remove getOwnPropertyDescriptor

568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
2013-08-20  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/120071> Replace NodeRenderingContext with Node* as childShouldCreateRenderer() argument

        Reviewed by Darin Adler.

        This simplifies the code. NodeRenderingContext was basically only used for getting the Node.

        * dom/ContainerNode.h:
        (WebCore::ContainerNode::childShouldCreateRenderer):
        * dom/Element.cpp:
        (WebCore::Element::childShouldCreateRenderer):
        * dom/Element.h:
        * dom/NodeRenderingContext.cpp:
        (WebCore::NodeRenderingContext::shouldCreateRenderer):
        * dom/NodeRenderingContext.h:
        
            Move isOnEncapsulationBoundary() to InsertionPoint.h and call it hasShadowRootOrActiveInsertionPointParent().
            Move isOnUpperEncapsulationBoundary() to ShadowRoot.h and call it hasShadowRootParent().

        * dom/ShadowRoot.h:
        (WebCore::hasShadowRootParent):
        * html/HTMLDetailsElement.cpp:
        (WebCore::HTMLDetailsElement::childShouldCreateRenderer):
        * html/HTMLDetailsElement.h:
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::validationMessageShadowTreeContains):
        * html/HTMLFormControlElement.h:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::childShouldCreateRenderer):
        * html/HTMLMediaElement.h:
        * html/HTMLMeterElement.cpp:
        (WebCore::HTMLMeterElement::childShouldCreateRenderer):
        * html/HTMLMeterElement.h:
        * html/HTMLOptGroupElement.h:
        (WebCore::isHTMLOptGroupElement):
        * html/HTMLOptionElement.h:
        (WebCore::isHTMLOptionElement):
        * html/HTMLProgressElement.cpp:
        (WebCore::HTMLProgressElement::childShouldCreateRenderer):
        * html/HTMLProgressElement.h:
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::childShouldCreateRenderer):
        * html/HTMLSelectElement.h:
        * html/HTMLSummaryElement.cpp:
        (WebCore::HTMLSummaryElement::childShouldCreateRenderer):
        * html/HTMLSummaryElement.h:
        * html/HTMLTextFormControlElement.cpp:
        (WebCore::HTMLTextFormControlElement::childShouldCreateRenderer):
        (WebCore::enclosingTextFormControl):
        * html/HTMLTextFormControlElement.h:
        * html/ValidationMessage.cpp:
        (WebCore::ValidationMessage::shadowTreeContains):
        * html/ValidationMessage.h:
        * html/shadow/InsertionPoint.cpp:
        (WebCore::InsertionPoint::rendererIsNeeded):
        * html/shadow/InsertionPoint.h:
        (WebCore::isActiveInsertionPoint):
        
            Remove isShadowBoundary() as it was equivalent to isActive(). 
            Remove isLowerEncapsulationBoundary() as it was equivalent to isActiveInsertionPoint().

        (WebCore::hasShadowRootOrActiveInsertionPointParent):
        
            Moved and renamed from NodeRenderingContext::isOnEncapsulationBoundary().

        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::childShouldCreateRenderer):
        * svg/SVGAElement.h:
        * svg/SVGAltGlyphElement.cpp:
        (WebCore::SVGAltGlyphElement::childShouldCreateRenderer):
        * svg/SVGAltGlyphElement.h:
        * svg/SVGDocument.cpp:
        (WebCore::SVGDocument::childShouldCreateRenderer):
        * svg/SVGDocument.h:
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::childShouldCreateRenderer):
        * svg/SVGElement.h:
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::childShouldCreateRenderer):
        * svg/SVGFilterElement.h:
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        * svg/SVGForeignObjectElement.cpp:
        (WebCore::SVGForeignObjectElement::childShouldCreateRenderer):
        * svg/SVGForeignObjectElement.h:
        * svg/SVGSVGElement.h:
        (WebCore::toSVGSVGElement):
        * svg/SVGSwitchElement.cpp:
        (WebCore::SVGSwitchElement::childShouldCreateRenderer):
        * svg/SVGSwitchElement.h:
        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::childShouldCreateRenderer):
        * svg/SVGTRefElement.h:
        * svg/SVGTSpanElement.cpp:
        (WebCore::SVGTSpanElement::childShouldCreateRenderer):
        * svg/SVGTSpanElement.h:
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::childShouldCreateRenderer):
        * svg/SVGTextElement.h:
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::childShouldCreateRenderer):
        * svg/SVGTextPathElement.h:

671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
2013-08-20  Benjamin Poulain  <benjamin@webkit.org>

        <https://webkit.org/b/120050> Don't bother using a Vector for the ouput of querySelector, just return the first element found

        Reviewed by Ryosuke Niwa.

        Simplify the case of querySelector. Instead of using the same output type as querySelectorAll,
        simply use a trait to define what to do in the loop.

        * dom/SelectorQuery.cpp:
        (WebCore::AllElementExtractorSelectorQueryTrait::appendOutputForElement):
        (WebCore::SelectorDataList::queryAll):
        (WebCore::SingleElementExtractorSelectorQueryTrait::appendOutputForElement):
        (WebCore::SelectorDataList::queryFirst):
        (WebCore::SelectorDataList::executeFastPathForIdSelector):
        (WebCore::elementsForLocalName):
        (WebCore::anyElement):
        (WebCore::SelectorDataList::executeSingleTagNameSelectorData):
        (WebCore::SelectorDataList::executeSingleClassNameSelectorData):
        (WebCore::SelectorDataList::executeSingleSelectorData):
        (WebCore::SelectorDataList::executeSingleMultiSelectorData):
        (WebCore::SelectorDataList::execute):
        * dom/SelectorQuery.h:

695
696
697
698
2013-08-20  Antti Koivisto  <antti@apple.com>

        Rollout the previous patch for landing with the correct ChangeLog.

699
700
701
702
703
704
705
706
707
708
013-08-20  Jacky Jiang  <zhajiang@blackberry.com>

        <https://webkit.org/b/120082> [BlackBerry] Remove unused previousTextureRect in LayerTiler

        Reviewed by Rob Buis.
        Internally reviewed by Mike Lattanzio and Jakob Petsovits.

        * platform/graphics/blackberry/LayerTiler.cpp:
        (WebCore::LayerTiler::updateTextureContentsIfNeeded):

709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
2013-08-20  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/120078> Replace NodeRenderingContext with RenderStyle& as shouldCreateRenderer() argument

        Reviewed by Darin Adler.

        This simplifies the code. NodeRenderingContext was only used for getting the RenderStyle.

        * dom/Element.cpp:
        (WebCore::Element::rendererIsNeeded):
        * dom/Element.h:
        * dom/NodeRenderingContext.cpp:
        (WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
        (WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
        * dom/PseudoElement.cpp:
        (WebCore::PseudoElement::rendererIsNeeded):
        * dom/PseudoElement.h:
        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::rendererIsNeeded):
        * html/HTMLAppletElement.h:
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::rendererIsNeeded):
        * html/HTMLElement.h:
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::rendererIsNeeded):
        * html/HTMLEmbedElement.h:
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::rendererIsNeeded):
        * html/HTMLFormElement.h:
        * html/HTMLFrameElement.cpp:
        (WebCore::HTMLFrameElement::rendererIsNeeded):
        * html/HTMLFrameElement.h:
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::rendererIsNeeded):
        * html/HTMLFrameSetElement.h:
        * html/HTMLIFrameElement.cpp:
        (WebCore::HTMLIFrameElement::rendererIsNeeded):
        * html/HTMLIFrameElement.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::rendererIsNeeded):
        * html/HTMLInputElement.h:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::rendererIsNeeded):
        * html/HTMLMediaElement.h:
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::rendererIsNeeded):
        * html/HTMLObjectElement.h:
        * html/HTMLOptGroupElement.h:
        * html/HTMLOptionElement.h:
        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::rendererIsNeeded):
        * html/HTMLVideoElement.h:
        * html/shadow/DetailsMarkerControl.cpp:
        (WebCore::DetailsMarkerControl::rendererIsNeeded):
        * html/shadow/DetailsMarkerControl.h:
        * html/shadow/InsertionPoint.cpp:
        (WebCore::InsertionPoint::rendererIsNeeded):
        * html/shadow/InsertionPoint.h:
        * html/shadow/MeterShadowElement.cpp:
        (WebCore::MeterShadowElement::rendererIsNeeded):
        (WebCore::MeterInnerElement::rendererIsNeeded):
        * html/shadow/MeterShadowElement.h:
        * html/shadow/ProgressShadowElement.cpp:
        (WebCore::ProgressShadowElement::rendererIsNeeded):
        (WebCore::ProgressInnerElement::rendererIsNeeded):
        * html/shadow/ProgressShadowElement.h:
        * svg/SVGDescElement.h:
        * svg/SVGElement.h:
        (WebCore::SVGElement::rendererIsNeeded):
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        * svg/SVGFontElement.h:
        * svg/SVGForeignObjectElement.cpp:
        (WebCore::SVGForeignObjectElement::rendererIsNeeded):
        * svg/SVGForeignObjectElement.h:
        * svg/SVGGElement.cpp:
        (WebCore::SVGGElement::rendererIsNeeded):
        * svg/SVGGElement.h:
        * svg/SVGGlyphElement.h:
        * svg/SVGGlyphRefElement.h:
        * svg/SVGHKernElement.h:
        * svg/SVGMarkerElement.h:
        * svg/SVGMissingGlyphElement.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::rendererIsNeeded):
        * svg/SVGSVGElement.h:
        * svg/SVGStopElement.cpp:
        (WebCore::SVGStopElement::rendererIsNeeded):
        * svg/SVGStopElement.h:
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::rendererIsNeeded):
        * svg/SVGStyledElement.h:
        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::rendererIsNeeded):
        * svg/SVGTRefElement.h:
        * svg/SVGTSpanElement.cpp:
        (WebCore::SVGTSpanElement::rendererIsNeeded):
        * svg/SVGTSpanElement.h:
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::rendererIsNeeded):
        * svg/SVGTextPathElement.h:
        * svg/SVGTitleElement.h:
        * svg/SVGVKernElement.h:
        * svg/SVGViewElement.h:

815
816
817
818
819
820
821
822
823
824
825
826
2013-08-20  Daniel Bates  <dabates@apple.com>

        <https://webkit.org/b/120088> Define Clipboard::hasData() only when building with drag support

        Reviewed by Darin Adler.

        Clipboard::hasData() is specific to drag-and-drop support. We should only define it when
        such support is enabled.

        * dom/Clipboard.cpp: Move hasData() to DRAG_SUPPORT section of the file.
        * dom/Clipboard.h: Ditto.

827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
2013-08-20  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/120078> Replace NodeRenderingContext with RenderStyle& as shouldCreateRenderer() argument

        Reviewed by Darin Adler.

        This simplifies the code. NodeRenderingContext was only used for getting the RenderStyle.

        * dom/Element.cpp:
        (WebCore::Element::rendererIsNeeded):
        * dom/Element.h:
        * dom/NodeRenderingContext.cpp:
        (WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
        (WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
        * dom/PseudoElement.cpp:
        (WebCore::PseudoElement::rendererIsNeeded):
        * dom/PseudoElement.h:
        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::rendererIsNeeded):
        * html/HTMLAppletElement.h:
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::rendererIsNeeded):
        * html/HTMLElement.h:
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::rendererIsNeeded):
        * html/HTMLEmbedElement.h:
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::rendererIsNeeded):
        * html/HTMLFormElement.h:
        * html/HTMLFrameElement.cpp:
        (WebCore::HTMLFrameElement::rendererIsNeeded):
        * html/HTMLFrameElement.h:
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::rendererIsNeeded):
        * html/HTMLFrameSetElement.h:
        * html/HTMLIFrameElement.cpp:
        (WebCore::HTMLIFrameElement::rendererIsNeeded):
        * html/HTMLIFrameElement.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::rendererIsNeeded):
        * html/HTMLInputElement.h:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::rendererIsNeeded):
        * html/HTMLMediaElement.h:
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::rendererIsNeeded):
        * html/HTMLObjectElement.h:
        * html/HTMLOptGroupElement.h:
        * html/HTMLOptionElement.h:
        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::rendererIsNeeded):
        * html/HTMLVideoElement.h:
        * html/shadow/DetailsMarkerControl.cpp:
        (WebCore::DetailsMarkerControl::rendererIsNeeded):
        * html/shadow/DetailsMarkerControl.h:
        * html/shadow/InsertionPoint.cpp:
        (WebCore::InsertionPoint::rendererIsNeeded):
        * html/shadow/InsertionPoint.h:
        * html/shadow/MeterShadowElement.cpp:
        (WebCore::MeterShadowElement::rendererIsNeeded):
        (WebCore::MeterInnerElement::rendererIsNeeded):
        * html/shadow/MeterShadowElement.h:
        * html/shadow/ProgressShadowElement.cpp:
        (WebCore::ProgressShadowElement::rendererIsNeeded):
        (WebCore::ProgressInnerElement::rendererIsNeeded):
        * html/shadow/ProgressShadowElement.h:
        * svg/SVGDescElement.h:
        * svg/SVGElement.h:
        (WebCore::SVGElement::rendererIsNeeded):
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        * svg/SVGFontElement.h:
        * svg/SVGForeignObjectElement.cpp:
        (WebCore::SVGForeignObjectElement::rendererIsNeeded):
        * svg/SVGForeignObjectElement.h:
        * svg/SVGGElement.cpp:
        (WebCore::SVGGElement::rendererIsNeeded):
        * svg/SVGGElement.h:
        * svg/SVGGlyphElement.h:
        * svg/SVGGlyphRefElement.h:
        * svg/SVGHKernElement.h:
        * svg/SVGMarkerElement.h:
        * svg/SVGMissingGlyphElement.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::rendererIsNeeded):
        * svg/SVGSVGElement.h:
        * svg/SVGStopElement.cpp:
        (WebCore::SVGStopElement::rendererIsNeeded):
        * svg/SVGStopElement.h:
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::rendererIsNeeded):
        * svg/SVGStyledElement.h:
        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::rendererIsNeeded):
        * svg/SVGTRefElement.h:
        * svg/SVGTSpanElement.cpp:
        (WebCore::SVGTSpanElement::rendererIsNeeded):
        * svg/SVGTSpanElement.h:
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::rendererIsNeeded):
        * svg/SVGTextPathElement.h:
        * svg/SVGTitleElement.h:
        * svg/SVGVKernElement.h:
        * svg/SVGViewElement.h:

933
934
935
936
937
938
939
940
941
942
943
944
945
946
2013-08-20  Tim Horton  <timothy_horton@apple.com>

        <https://webkit.org/b/105988> [Mac] Some inspector tests intermittently assert in InspectorOverlay::paint
        <rdar://problem/12958038>

        Reviewed by Joseph Pecoraro.

        Update the inspector overlay's layout before painting, if it is stale.

        No new tests; fixes an intermittent assertion failure in some existing tests.

        * inspector/InspectorOverlay.cpp:
        (WebCore::InspectorOverlay::paint):

947
948
949
950
951
952
953
2013-08-20  Daniel Bates  <dabates@apple.com>

        Build fix after <http://trac.webkit.org/changeset/154260> (https://webkit.org/b/119949);
        declare Clipboard::hasData() when building with and without drag support

        * dom/Clipboard.h:

954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
2013-08-20  Hans Muller  <hmuller@adobe.com>

        <https://webkit.org/b/119849> [CSS Shapes] Complete RasterShape::firstIncludedIntervalLogicalTop()

        Reviewed by Alexandru Chiculita.

        Completed the implementation of RasterShape::firstIncludedIntervalLogicalTop(). The
        method now computes first logical top location where a line segment can be laid
        out within a RasterShape, i.e. a shape derived from an image valued URL resource.

        A detailed description of the algorithm can be found in
        http://hansmuller-webkit.blogspot.com/2013/08/first-fit-location-for-image-shapes.html.

        The new tests exposed a bug in the existing getIncludedIntervals() method. A shape
        with a vertical gap that spans the entire line now causes the method to short circuit
        and return an empty interval list.

        Tests: fast/shapes/shape-inside/shape-inside-image-003.html
               fast/shapes/shape-inside/shape-inside-image-004.html
               fast/shapes/shape-inside/shape-inside-image-005.html

        * rendering/shapes/RasterShape.cpp:
        (WebCore::RasterShapeIntervals::firstIncludedIntervalY):
        (WebCore::RasterShapeIntervals::getIncludedIntervals):
        (WebCore::RasterShape::firstIncludedIntervalLogicalTop):
        * rendering/shapes/RasterShape.h:

981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
2013-08-20  Pratik Solanki  <psolanki@apple.com>

        <https://webkit.org/b/120029> Document::markers() should return a reference

        Reviewed by Andreas Kling.

        Document::m_markers is never NULL so return a reference from Document::markers(). Also mark
        m_markers as const and initialize it in member initialization.

        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:
        (WebCore::Document::markers):
        * editing/AlternativeTextController.cpp:
        (WebCore::AlternativeTextController::isSpellingMarkerAllowed):
        (WebCore::AlternativeTextController::applyAlternativeTextToRange):
        (WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):
        (WebCore::AlternativeTextController::handleAlternativeTextUIResult):
        (WebCore::AlternativeTextController::respondToChangedSelection):
        (WebCore::AlternativeTextController::respondToAppliedEditing):
        (WebCore::AlternativeTextController::respondToUnappliedEditing):
        (WebCore::AlternativeTextController::markReversed):
        (WebCore::AlternativeTextController::markCorrection):
        (WebCore::AlternativeTextController::recordSpellcheckerResponseForModifiedCorrection):
        (WebCore::AlternativeTextController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand):
        (WebCore::AlternativeTextController::processMarkersOnTextToBeReplacedByResult):
        (WebCore::AlternativeTextController::applyDictationAlternative):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
        * editing/DictationCommand.cpp:
        (WebCore::DictationMarkerSupplier::addMarkersToTextNode):
        * editing/Editor.cpp:
        (WebCore::Editor::ignoreSpelling):
        (WebCore::Editor::learnSpelling):
        (WebCore::Editor::advanceToNextMisspelling):
        (WebCore::Editor::clearMisspellingsAndBadGrammar):
        (WebCore::Editor::markAndReplaceFor):
        (WebCore::Editor::changeBackToReplacedString):
        (WebCore::Editor::updateMarkersForWordsAffectedByEditing):
        (WebCore::Editor::countMatchesForText):
        (WebCore::Editor::setMarkedTextMatchesAreHighlighted):
        (WebCore::Editor::respondToChangedSelection):
        (WebCore::Editor::selectionStartHasMarkerFor):
        * editing/SpellChecker.cpp:
        (WebCore::SpellChecker::didCheckSucceed):
        * editing/SplitTextNodeCommand.cpp:
        (WebCore::SplitTextNodeCommand::doApply):
        (WebCore::SplitTextNodeCommand::doUnapply):
        * editing/TextCheckingHelper.cpp:
        (WebCore::TextCheckingHelper::findFirstMisspelling):
        (WebCore::TextCheckingHelper::findFirstGrammarDetail):
        * page/FrameView.cpp:
        (WebCore::FrameView::getTickmarks):
        (WebCore::FrameView::paintContents):
        * page/Page.cpp:
        (WebCore::Page::unmarkAllTextMatches):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::spellingToolTip):
        (WebCore::HitTestResult::replacedString):
        (WebCore::HitTestResult::dictationAlternatives):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintDocumentMarkers):
        * rendering/svg/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
        * testing/Internals.cpp:
        (WebCore::Internals::markerCountForNode):
        (WebCore::Internals::markerAt):
        (WebCore::Internals::addTextMatchMarker):

1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
2013-08-20  Pratik Solanki  <psolanki@apple.com>

        <https://webkit.org/b/119875> localeToScriptCodeForFontSelection should use hash tables with larger default capacity

        Reviewed by Darin Adler.

        The two static hash tables used in this file have 106 and 198 entries. Set a minimumTableSize for
        these hash tables so we don't have to expand them during initialization.

        No new tests because no functional changes.

        * platform/text/LocaleToScriptMappingDefault.cpp:
        (WebCore::scriptNameToCode):
        (WebCore::localeToScriptCodeForFontSelection):

1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
2013-08-20  Eric Carlson  <eric.carlson@apple.com>

        <https://webkit.org/b/120068> Media controls can be attached lazily

        Reviewed by Jer Noble.

        Merge https://chromium.googlesource.com/chromium/blink/+/28a995486a675992f2e72f81bfabdfff05688a31.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::createMediaControls): Add AttachLazily to appendChild().

1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
2013-08-20  Daniel Bates  <dabates@apple.com>

        <https://webkit.org/b/120072> Use nullAtom instead of defining static local in
        Accessibility{Object, RenderObject}::actionVerb()

        Reviewed by Chris Fleizach.

        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::actionVerb):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::actionVerb):

1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
2013-08-20  Daniel Bates  <dabates@apple.com>

        <https://webkit.org/b/119914> [iOS] Upstream changes to WebCore/accessibility

        Reviewed by Darin Adler and Chris Fleizach.

        * accessibility/AccessibilityMenuList.cpp:
        (WebCore::AccessibilityMenuList::press):
        (WebCore::AccessibilityMenuList::isCollapsed):
        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::headingElementForNode):
        (WebCore::AccessibilityObject::actionVerb):
        * accessibility/AccessibilityObject.h:
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
        (WebCore::AccessibilityRenderObject::actionVerb):
        * accessibility/AccessibilityTableColumn.cpp:
        (WebCore::AccessibilityTableColumn::computeAccessibilityIsIgnored):
        * accessibility/AccessibilityTableHeaderContainer.cpp:
        (WebCore::AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored):
        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
2013-08-20  Bruno de Oliveira Abinader  <bruno.d@partner.samsung.com>

        [css3-text] Implement CSS3 text-decoration shorthand
        https://bugs.webkit.org/show_bug.cgi?id=92000

        Reviewed by Darin Adler.

        Implements the text-decoration shorthand (with -webkit- prefix), as specified by the CSS3 Text Decoration specification:
        http://dev.w3.org/csswg/css-text-decor-3/#text-decoration-property

        Backported from Blink:
        https://src.chromium.org/viewvc/blink?revision=156266&view=revision

        Tests: fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-shorthand-ordering.html
               fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-shorthand.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::ComputedStyleExtractor::propertyValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::addTextDecorationProperty):
        (WebCore::CSSParser::parseTextDecoration):
        * css/CSSProperty.cpp:
        (WebCore::CSSProperty::isInheritedProperty):
        * css/CSSPropertyNames.in:
        * css/StylePropertyShorthand.cpp:
        (WebCore::webkitTextDecorationShorthand):
        (WebCore::shorthandForProperty):
        (WebCore::matchingShorthandsForLonghand):
        * css/StylePropertyShorthand.h:

1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
2013-08-20  Gavin Barraclough  <barraclough@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=120054
        Remove some dead code following getOwnPropertyDescriptor cleanup

        Reviewed by Oliver Hunt.

        * bindings/js/JSPluginElementFunctions.cpp:
        * bindings/js/JSPluginElementFunctions.h:
            - remove runtimeObjectCustomGetOwnPropertyDescriptor, pluginElementCustomGetOwnPropertyDescriptor

1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
2013-08-20  Alex Christensen  <achristensen@apple.com>

        Use PlatformArchitecture to distinguish between 32-bit and 64-bit builds on Windows.
        https://bugs.webkit.org/show_bug.cgi?id=119512

        Reviewed by Brent Fulgham.

        * WebCore.vcxproj/WebCore.vcxproj:
        * WebCore.vcxproj/WebCore.vcxproj.filters:
        * WebCore.vcxproj/WebCoreCommon.props:
        * WebCore.vcxproj/WebCoreGeneratedCommon.props:
        * WebCore.vcxproj/WebCoreTestSupport.vcxproj:
        * WebCore.vcxproj/WebCoreTestSupport.vcxproj.filters:
        Replaced obj32, bin32, and lib32 with macros for 64-bit build.

1169
1170
1171
1172
1173
1174
1175
1176
2013-08-20  Jessie Berlin  <jberlin@apple.com>

        Remove a string no longer used after r154251.

        Rubber-stamped by Brady Eidson.

        * English.lproj/Localizable.strings:

1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
2013-08-20  Jakob Petsovits  <jpetsovits@blackberry.com>

        [BlackBerry] Avoid an assertion from calling releaseBufferDrawable(nullptr)
        https://bugs.webkit.org/show_bug.cgi?id=119862
        JIRA 470760

        Reviewed by Antonio Gomes.

        destroyBuffer() finds a null pointer valid but
        releaseBufferDrawable() does not. Fix by adding a
        null pointer check.

        No new tests, caught by existing layout test runs.

        * platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
        (WebCore::ImageBuffer::~ImageBuffer):

1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
2013-08-19  Gustavo Noronha Silva  <gns@gnome.org>

        <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings

        Reviewed by Martin Robinson.

        No new tests, these are just stubs for the DOM bindings API.

        * bindings/gobject/WebKitDOMCustom.cpp:
        (webkit_dom_bar_info_get_property):
        (webkit_dom_bar_info_class_init):
        (webkit_dom_bar_info_init):
        (webkit_dom_bar_info_get_visible):
        (webkit_dom_console_get_memory):
        (webkit_dom_css_style_declaration_get_property_css_value):
        (webkit_dom_document_get_webkit_hidden):
        (webkit_dom_document_get_webkit_visibility_state):
        (webkit_dom_html_document_open):
        (webkit_dom_html_element_set_item_id):
        (webkit_dom_html_element_get_item_id):
        (webkit_dom_html_element_get_item_ref):
        (webkit_dom_html_element_get_item_prop):
        (webkit_dom_html_element_set_item_scope):
        (webkit_dom_html_element_get_item_scope):
        (webkit_dom_html_element_get_item_type):
        (webkit_dom_html_properties_collection_get_property):
        (webkit_dom_html_properties_collection_class_init):
        (webkit_dom_html_properties_collection_init):
        (webkit_dom_html_properties_collection_item):
        (webkit_dom_html_properties_collection_named_item):
        (webkit_dom_html_properties_collection_get_length):
        (webkit_dom_html_properties_collection_get_names):
        (webkit_dom_node_get_attributes):
        (webkit_dom_node_has_attributes):
        (webkit_dom_memory_info_get_property):
        (webkit_dom_memory_info_class_init):
        (webkit_dom_memory_info_init):
        (webkit_dom_memory_info_get_total_js_heap_size):
        (webkit_dom_memory_info_get_used_js_heap_size):
        (webkit_dom_memory_info_get_js_heap_size_limit):
        (webkit_dom_micro_data_item_value_class_init):
        (webkit_dom_micro_data_item_value_init):
        (webkit_dom_performance_get_memory):
        (webkit_dom_property_node_list_get_property):
        (webkit_dom_property_node_list_class_init):
        (webkit_dom_property_node_list_init):
        (webkit_dom_property_node_list_item):
        (webkit_dom_property_node_list_get_length):
        * bindings/gobject/WebKitDOMCustom.h:

1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
2013-08-20  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/120017> Remove NodeRenderingTraversal::ParentDetails

        Reviewed by Andreas Kling.

        Remove this oddly factored type that is used to optionally collect some data during ComposedShadowTreeWalker parent traversal.
        
        Also removed support for reset-style-inheritance attribute in InsertionPoint. We don't use or expose it.

        * css/StyleResolver.cpp:
        (WebCore::StyleResolver::State::initForStyleResolve):
        (WebCore::StyleResolver::styleForElement):
        * css/StyleResolver.h:
        (WebCore::StyleResolver::State::State):
        (WebCore::StyleResolver::State::elementLinkState):
        
            Remove m_distributedToInsertionPoint State field. We never hit the cases where it was used.

        * dom/ComposedShadowTreeWalker.cpp:
        (WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
        (WebCore::ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents):
        (WebCore::ComposedShadowTreeWalker::traverseParent):
        
            Return null instead of setting childWasOutOfComposition to details object. That's what would happen anyway in the caller.

        (WebCore::ComposedShadowTreeWalker::traverseParentInCurrentTree):
        (WebCore::ComposedShadowTreeWalker::traverseParentBackToShadowRootOrHost):
        * dom/ComposedShadowTreeWalker.h:
        * dom/Node.cpp:
        (WebCore::Node::insertionParentForBinding):
        * dom/NodeRenderingContext.cpp:
        (WebCore::NodeRenderingContext::NodeRenderingContext):
        (WebCore::NodeRenderingContext::isOnEncapsulationBoundary):
        
            Make this look up InsertionPoint directly intead of relying it being populated in m_parentDetails. The function is used only in
            a few non-performance critical places.

        (WebCore::NodeRenderingContext::resetStyleInheritance):
        
            Return parent ShadowRoots resetStyleInheritance() flag instead of using m_parentDetails.

        * dom/NodeRenderingContext.h:
        * dom/NodeRenderingTraversal.cpp:
        (WebCore::NodeRenderingTraversal::parentSlow):
        * dom/NodeRenderingTraversal.h:
        (WebCore::NodeRenderingTraversal::parent):
        
            Remove ParentDetails.

        * html/HTMLAttributeNames.in:
        * html/shadow/InsertionPoint.cpp:
        
            Remove unused resetStyleInheritance attribute.

        (WebCore::InsertionPoint::removedFrom):
        (WebCore::findInsertionPointOf):
        
            Renamed for clarity.

        * html/shadow/InsertionPoint.h:
        * testing/Internals.cpp:
        (WebCore::Internals::includerFor):

1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
2013-08-20  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/120025> REGRESSION (r154254): fast/frames/frameset-frameborder-inheritance.html failing on Apple MountainLion Debug WK1 (Tests)

        Reviewed by Anders Carlsson.

        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::isFrameSet):
        * html/HTMLFrameElement.cpp:
        (WebCore::HTMLFrameElement::didAttachRenderers):
        
            Make helper public in HTMLFrameSetElement.

        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::findContaining):
        
            Static function for finding containing frameset, if any.

        (WebCore::HTMLFrameSetElement::willAttachRenderers):
        
            This broke in refactoring. We should exit the loop when the first containing frameset is found. Fix by refactoring more.

        * html/HTMLFrameSetElement.h:
        (WebCore::isHTMLFrameSetElement):
        (WebCore::toHTMLFrameSetElement):
        
            Add casting functions.

        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::frameSet):

1339
1340
1341
1342
1343
1344
1345
1346
1347
2013-08-20  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/120023> REGRESSION(r154257): svg/custom/bug78807.svg and svg/custom/use-invalid-style.svg failing

        Reviewed by Andreas Kling.

        * xml/XMLErrors.cpp:
        (WebCore::XMLErrors::insertErrorMessageBlock): "reattach" had accidentally turned into "detach" in refactoring.

1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
2013-08-20  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/119969> REGRESSION (r154232): Crash on the japantimes.co.jp

        Reviewed by Andreas Kling.
        
        PseudoElement no longer has parent and calling Element::insertedInto for them crashes as it tries to access it.

        Normally there are no pseudo elements when Element::insertedInto() is invoked as they get detached and attached
        along with rendering. However in this case the page inserts a <style> that uses ::before along with an element
        that it applies to. Stylesheet insertion triggers synchronous style recalc that attaches rendering to all newly
        insered elements. Later Element::insertedInto gets called for the element that has pseudo element and we crash.

        Test: fast/css-generated-content/insert-stylesheet-and-pseudo-crash.html

        * dom/Element.cpp:
        (WebCore::Element::insertedInto):
        (WebCore::Element::removedFrom):
        
            Remove calls to insertedInto/removedFrom for pseudo elements. They are not considered to be in document.
            When they are added normally during render tree attach these calls don't happen either.

1370
1371
1372
1373
1374
1375
1376
2013-08-20  Ryosuke Niwa  <rniwa@webkit.org>

        Windows build fix after r154314.

        * platform/graphics/cg/PathCG.cpp:
        (WebCore::Path::platformAddPathForRoundedRect):

1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
2013-08-19  Hurnjoo Lee  <hurnjoo.lee@samsung.com>

        [Cairo] Canvas putImageData is not working as expected
        https://bugs.webkit.org/show_bug.cgi?id=119992

        Reviewed by Darin Adler.

        ImageBufferCairo::putImageArray didn't perform pre-multiply in case of zero alpha value.
        If the alpha value is not 255, image data should always be pre-multiplied.

        Test: fast/canvas/canvas-putImageData-zero-alpha.html

        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (WebCore::ImageBuffer::putByteArray):

1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
2013-08-19  Santosh Mahto  <santosh.ma@samsung.com>

        <https://webkit.org/b/119991> change usage of calculateUTCOffset()/calculateDSTOffset  to calculateLocalTimeOffset

        Reviewed by Darin Adler.

        Resolving code error.

        * html/BaseDateAndTimeInputType.cpp:
        (WebCore::BaseDateAndTimeInputType::defaultValueForStepUp):
        * html/MonthInputType.cpp:
        (WebCore::MonthInputType::defaultValueForStepUp):
        * html/TimeInputType.cpp:
        (WebCore::TimeInputType::defaultValueForStepUp):

1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
2013-08-19  Ryosuke Niwa  <rniwa@webkit.org>

        <https://webkit.org/b/120049> Delete code for Snow Leopard

        Reviewed by Benjamin Poulain.

        Delete all the code for Mac OS 10.6. Nobody builds on Snow Leopard at this point.

        * WebCore.exp.in:
        * WebCore.xcodeproj/project.pbxproj:
        * editing/mac/EditorMac.mm:
        (WebCore::Editor::pasteWithPasteboard):
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::populate):
        * platform/LocalizedStrings.cpp:
        (WebCore::truncatedStringForLookupMenuItem):
        (WebCore::contextMenuItemTagSearchWeb):
        (WebCore::contextMenuItemTagLookUpInDictionary):
        * platform/MemoryPressureHandler.cpp:
        * platform/audio/mac/AudioBusMac.mm:
        (WebCore::AudioBus::loadPlatformResource):
        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
        * platform/graphics/ca/PlatformCALayer.h:
        * platform/graphics/ca/mac/PlatformCALayerMac.mm:
        (PlatformCALayer::acceleratesDrawing):
        (PlatformCALayer::setAcceleratesDrawing):
        (PlatformCALayer::contentsScale):
        (PlatformCALayer::setContentsScale):
        (PlatformCALayer::synchronouslyDisplayTilesInRect):
        * platform/graphics/ca/mac/TileController.mm:
        (WebCore::TileController::setScale):
        (WebCore::TileController::setAcceleratesDrawing):
        (WebCore::TileController::createTileLayer):
        * platform/graphics/cg/ImageBufferDataCG.cpp:
        (WebCore::ImageBufferData::getData):
        (WebCore::ImageBufferData::putData):
        * platform/graphics/cg/ImageBufferDataCG.h:
        * platform/graphics/cg/PathCG.cpp:
        (WebCore::Path::platformAddPathForRoundedRect):
        * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::setFont):
        * platform/graphics/mac/FontMac.mm:
        (WebCore::showGlyphsWithAdvances):
        * platform/graphics/mac/GraphicsContextMac.mm:
        (WebCore::GraphicsContext::drawLineForDocumentMarker):
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::createQTMovie):
        (WebCore::MediaPlayerPrivateQTKit::layerHostChanged):
        * platform/graphics/mac/WebLayer.mm:
        (drawLayerContents):
        * platform/mac/CursorMac.mm:
        (WebCore::Cursor::ensurePlatformCursor):
        * platform/mac/EmptyProtocolDefinitions.h: Removed.
        * platform/mac/MemoryPressureHandlerMac.mm:
        (WebCore::MemoryPressureHandler::releaseMemory):
        * platform/mac/NSScrollerImpDetails.h:
        * platform/mac/PlatformEventFactoryMac.mm:
        (WebCore::momentumPhaseForEvent):
        (WebCore::phaseForEvent):
        * platform/mac/ScrollAnimatorMac.mm:
        * platform/mac/SharedTimerMac.mm:
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
        * platform/network/mac/ResourceHandleMac.mm:
        * platform/network/mac/ResourceRequestMac.mm:
        (WebCore::ResourceRequest::doUpdateResourceRequest):
        (WebCore::ResourceRequest::doUpdatePlatformRequest):
        * platform/text/cf/HyphenationCF.cpp:
        * platform/text/mac/HyphenationMac.mm: Removed.
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::containsPaintedContent):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):

1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
2013-08-19  Ryosuke Niwa  <rniwa@webkit.org>

        <https://webkit.org/b/120041> Remove superfluous min calls in RenderBlock::computeOverflow

        Reviewed by Simon Fraser.

        Merge https://chromium.googlesource.com/chromium/blink/+/29cad35d6b4642804e6b7c1a30f0b4435dd7a71d

        They are contained in an "if" statement that ensures that textIndent < 0 and so the min will never be 0.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::computeOverflow):

1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
2013-08-19  Ryosuke Niwa  <rniwa@webkit.org>

        <https://webkit.org/b/119930> input[type=range]: Fix a crash by changing input type in 'input' event handler

        Reviewed by Kent Tamura.

        Merge https://chromium.googlesource.com/chromium/blink/+/99afc9b55ce176b4f5fe053070e19dbebc1891a5

        In SliderThumbElement::setPositionFromPoint, renderer() can be NULL after HTMLInputElement::setValueFromRenderer,
        which dispatches 'input' event. Also, make a local vairable 'input' a RefPtr just in case.

        Also add null-poinetr checks for the host element as SliderThumbElement only weakly holds onto the host element.

        Test: fast/forms/range/range-type-change-oninput.html

        * html/shadow/SliderThumbElement.cpp:
        (WebCore::SliderThumbElement::isDisabledFormControl):
        (WebCore::SliderThumbElement::matchesReadOnlyPseudoClass):
        (WebCore::SliderThumbElement::matchesReadWritePseudoClass):
        (WebCore::SliderThumbElement::setPositionFromPoint):
        (WebCore::SliderThumbElement::hostInput):

1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
2013-08-19  Alexey Proskuryakov  <ap@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=120028
        ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
        when navigating to an uncached subframe

        Reviewed by Brady Eidson.

        Test: http/tests/navigation/post-frames-goback1-uncached.html

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame):
        Set m_requestedHistoryItem in a code path that doesn't go through FrameLoader::loadItem.

        * loader/HistoryController.cpp: (WebCore::HistoryController::restoreDocumentState):
        Now that we always set m_requestedHistoryItem, there is no need to traverse frame
        tree to see if this document is being loaded as part of b/f navigation (which was
        add in bug 90870).

1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
2013-08-19  Gavin Barraclough  <barraclough@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=120034
        Remove custom getOwnPropertyDescriptor for global objects

        Reviewed by Geoff Garen.

        Fix attributes of JSC SynbolTableObject entries, ensure that cross frame access is safe, and suppress prototype chain walk.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::getOwnPropertySlot):
            - Remove custom getOwnPropertyDescriptor implementation, on cross-frame access ensure
              all properties are marked as read-only, non-configurable to prevent defineProperty.

1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
2013-08-19  Gavin Barraclough  <barraclough@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=119995
        Start removing custom implementations of getOwnPropertyDescriptor

        Reviewed by Sam Weinig.

        This can now typically implemented in terms of getOwnPropertySlot.
        Add a macro to PropertyDescriptor to define an implementation of GOPD in terms of GOPS.
        Switch over most classes in JSC & the WebCore bindings generator to use this.

        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        * bindings/js/JSHTMLAppletElementCustom.cpp:
        * bindings/js/JSHTMLEmbedElementCustom.cpp:
        * bindings/js/JSHTMLObjectElementCustom.cpp:
        * bindings/js/JSHistoryCustom.cpp:
        (WebCore::JSHistory::getOwnPropertySlotDelegate):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::getOwnPropertySlotDelegate):
        * bindings/js/JSWorkerGlobalScopeCustom.cpp:
            - Remove getOwnPropertyDescriptorDelegate methods,
              Change attributes of cross-frame access properties in JSHistory/JSLocation to prevent properties from being redefined.
        * bindings/scripts/CodeGeneratorJS.pm:
        (GenerateHeader):
        (GenerateImplementation):
        (GenerateConstructorHelperMethods):
            - Implement getOwnPropertySlot in terms of GET_OWN_PROPERTY_DESCRIPTOR_IMPL.
        * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
        * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
        * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
        * bindings/scripts/test/JS/JSTestEventTarget.cpp:
        * bindings/scripts/test/JS/JSTestException.cpp:
        * bindings/scripts/test/JS/JSTestInterface.cpp:
        * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
        * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
        * bindings/scripts/test/JS/JSTestNode.cpp:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
        * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
        * bindings/scripts/test/JS/JSTestTypedefs.cpp:
            - Update test expectations.

1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
2013-08-19  Benjamin Poulain  <benjamin@webkit.org>

        <https://webkit.org/b/119936> Fix some encapsulation issues of RuleSet

        Reviewed by Darin Adler.

        None of the attributes of RuleSet should be modified directly.

        * css/DocumentRuleSets.cpp:
        (WebCore::DocumentRuleSets::initUserStyle):
        * css/ElementRuleCollector.cpp:
        (WebCore::ElementRuleCollector::collectMatchingRulesForRegion):
        * css/RuleSet.h:
        (WebCore::RuleSet::RuleSetSelectorPair::RuleSetSelectorPair):
        (WebCore::RuleSet::regionSelectorsAndRuleSets):
        (WebCore::RuleSet::ruleCount):
        * css/StyleResolver.cpp:
        (WebCore::StyleResolver::checkRegionStyle):

1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
2013-08-19  Benjamin Poulain  <benjamin@webkit.org>

        <https://webkit.org/b/119937> Remove ElementRuleCollector's m_behaviorAtBoundary

        Reviewed by Darin Adler.

        The value DoesNotCrossBoundary is the default behavior boundary of SelectorChecker,
        and it is never changed by ElementRuleCollector.

        * css/ElementRuleCollector.cpp:
        (WebCore::ElementRuleCollector::collectMatchingRules):
        (WebCore::ElementRuleCollector::ruleMatches):
        * css/ElementRuleCollector.h:
        (WebCore::ElementRuleCollector::ElementRuleCollector):

1626
1627
1628
1629
1630
1631
1632
1633
2013-08-19  Benjamin Poulain  <benjamin@webkit.org>

        <https://webkit.org/b/119934> Remove a repeated "private:" from ElementRuleCollector

        Reviewed by Darin Adler.

        * css/ElementRuleCollector.h:

1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
2013-08-19  Pratik Solanki  <psolanki@apple.com>

        <https://webkit.org/b/120019> Document::visitedLinkState() should return a reference

        Reviewed by Andreas Kling.

        Document::m_visitedLinkState is never NULL so we can just return a reference. Also make it a const.

        * css/StyleResolver.cpp:
        (WebCore::StyleResolver::State::initElement):
        * dom/Document.h:
        (WebCore::Document::visitedLinkState):
        * history/CachedPage.cpp:
        (WebCore::CachedPage::restore):
        * page/Page.cpp:
        (WebCore::Page::allVisitedStateChanged):
        (WebCore::Page::visitedStateChanged):

1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
2013-08-19  Ryosuke Niwa  <rniwa@webkit.org>

        ASSERTION FAILED: !node || node->isShadowRoot() in WebCore::EventRetargeter::eventTargetRespectingTargetRules
        https://bugs.webkit.org/show_bug.cgi?id=119720

        Reviewed by Andy Estes.

        Merge https://chromium.googlesource.com/chromium/blink/+/4ce9bfbf54410179cd0f18b3d1a912045fc0ec3d

        * dom/EventRetargeter.h:
        (WebCore::EventRetargeter::eventTargetRespectingTargetRules):

1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
2013-08-19  Darin Adler  <darin@apple.com>

        <https://webkit.org/b/120013> Tighten up logic in HTMLTableRowsCollection

        Reviewed by Andy Estes.

        I was looking for incorrect uses of hasLocalName in places where hasTagName should be used.
        The use in HTMLTableRowsCollection looked like that kind of mistake, but when I tried to
        make a test case to show the mistake, I found I could not. So I wrote assertions to restate
        what I learned, and removed an unneeded null check and tightened up the code a bit. This
        should make code size slightly smaller.

        * html/HTMLTableRowsCollection.cpp:
        (WebCore::assertRowIsInTable): Added. Asserts that the row's position in the table is consistent
        with the invariants of how the collection class works. A row that is processed here would have
        to be an immediate child of the table, or an immediate child of a table section that in turn is
        an immediate child of the table.
        (WebCore::isInSection): Added. Replaces the three more-specific helper functions. Unlike those,
        this does not do a null check.
        (WebCore::HTMLTableRowsCollection::rowAfter): Changed to use the two new functions.

1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2013-08-19  Pratik Solanki  <psolanki@apple.com>

        <https://webkit.org/b/119918> Frame::selection() should return a reference

        Reviewed by Darin Adler.

        m_selection is never NULL so return a reference from Frame::selection(). Also removed some
        unnecessary null checks and assert diff ts exposed as a result.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::selection):
        (WebCore::AccessibilityRenderObject::setSelectedTextRange):
        (WebCore::AccessibilityRenderObject::isFocused):
        (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
        (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
        (-[WebAccessibilityObjectWrapper accessibilityModifySelection:increase:]):
        (-[WebAccessibilityObjectWrapper accessibilityMoveSelectionToMarker:]):
        (-[WebAccessibilityObjectWrapper _convertToNSRange:]):
        (-[WebAccessibilityObjectWrapper _convertToDOMRange:]):
        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
        (-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
        * css/SelectorChecker.cpp:
        (WebCore::SelectorChecker::isFrameFocused):
        * dom/CharacterData.cpp:
        (WebCore::CharacterData::setDataAndUpdate):
        * dom/Document.cpp:
        (WebCore::Document::nodeChildrenWillBeRemoved):
        (WebCore::Document::nodeWillBeRemoved):
        * dom/Element.cpp:
        (WebCore::Element::updateFocusAppearance):
        * editing/AlternativeTextController.cpp:
        (WebCore::AlternativeTextController::stopPendingCorrection):
        (WebCore::AlternativeTextController::applyAlternativeTextToRange):
        (WebCore::AlternativeTextController::applyAutocorrectionBeforeTypingIfAppropriate):
        (WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):
        (WebCore::AlternativeTextController::timerFired):
        (WebCore::AlternativeTextController::respondToChangedSelection):
        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::respondToChangedSelection):
        (WebCore::DeleteButtonController::enable):
        (WebCore::DeleteButtonController::deleteTarget):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
        * editing/DictationCommand.cpp:
        (WebCore::DictationCommand::insertText):
        * editing/EditCommand.cpp:
        (WebCore::EditCommand::EditCommand):
        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::mergeTypingStyle):
        * editing/Editor.cpp:
        (WebCore::Editor::selectionForCommand):
        (WebCore::Editor::canEdit):
        (WebCore::Editor::canEditRichly):
        (WebCore::Editor::canDHTMLCut):
        (WebCore::Editor::canDHTMLCopy):
        (WebCore::Editor::canCopy):
        (WebCore::Editor::canDelete):
        (WebCore::Editor::canSmartCopyOrDelete):
        (WebCore::Editor::deleteWithDirection):
        (WebCore::Editor::deleteSelectionWithSmartDelete):
        (WebCore::Editor::replaceSelectionWithFragment):
        (WebCore::Editor::selectedRange):
        (WebCore::Editor::tryDHTMLCopy):
        (WebCore::Editor::tryDHTMLCut):
        (WebCore::Editor::hasBidiSelection):
        (WebCore::Editor::selectionUnorderedListState):
        (WebCore::Editor::selectionOrderedListState):
        (WebCore::Editor::increaseSelectionListLevel):
        (WebCore::Editor::increaseSelectionListLevelOrdered):
        (WebCore::Editor::increaseSelectionListLevelUnordered):
        (WebCore::Editor::decreaseSelectionListLevel):
        (WebCore::Editor::findEventTargetFromSelection):
        (WebCore::Editor::applyStyle):
        (WebCore::Editor::applyParagraphStyle):
        (WebCore::Editor::applyStyleToSelection):
        (WebCore::Editor::applyParagraphStyleToSelection):
        (WebCore::Editor::selectionStartHasStyle):
        (WebCore::Editor::selectionHasStyle):
        (WebCore::Editor::selectionStartCSSPropertyValue):
        (WebCore::Editor::appliedEditing):
        (WebCore::Editor::insertTextWithoutSendingTextEvent):
        (WebCore::Editor::insertLineBreak):
        (WebCore::Editor::insertParagraphSeparator):
        (WebCore::Editor::cut):
        (WebCore::Editor::copy):
        (WebCore::Editor::paste):
        (WebCore::Editor::baseWritingDirectionForSelectionStart):
        (WebCore::Editor::selectComposition):
        (WebCore::Editor::setComposition):
        (WebCore::Editor::ignoreSpelling):
        (WebCore::Editor::learnSpelling):
        (WebCore::Editor::advanceToNextMisspelling):
        (WebCore::Editor::misspelledWordAtCaretOrRange):
        (WebCore::Editor::isSelectionUngrammatical):
        (WebCore::Editor::guessesForMisspelledOrUngrammatical):
        (WebCore::Editor::markMisspellingsAfterTypingToWord):
        (WebCore::Editor::isSpellCheckingEnabledInFocusedNode):
        (WebCore::Editor::markAndReplaceFor):
        (WebCore::Editor::updateMarkersForWordsAffectedByEditing):
        (WebCore::Editor::revealSelectionAfterEditingOperation):
        (WebCore::Editor::getCompositionSelection):
        (WebCore::Editor::transpose):
        (WebCore::Editor::changeSelectionAfterCommand):
        (WebCore::Editor::selectedText):
        (WebCore::Editor::computeAndSetTypingStyle):
        (WebCore::Editor::findString):
        (WebCore::Editor::respondToChangedSelection):
        (WebCore::Editor::selectionStartHasMarkerFor):
        (WebCore::Editor::toggleOverwriteModeEnabled):
        * editing/EditorCommand.cpp:
        (WebCore::executeToggleStyleInList):
        (WebCore::expandSelectionToGranularity):
        (WebCore::stateTextWritingDirection):
        (WebCore::executeDelete):
        (WebCore::executeDeleteToMark):
        (WebCore::executeMoveBackward):
        (WebCore::executeMoveBackwardAndModifySelection):
        (WebCore::executeMoveDown):
        (WebCore::executeMoveDownAndModifySelection):
        (WebCore::executeMoveForward):
        (WebCore::executeMoveForwardAndModifySelection):
        (WebCore::executeMoveLeft):
        (WebCore::executeMoveLeftAndModifySelection):
        (WebCore::executeMovePageDown):
        (WebCore::executeMovePageDownAndModifySelection):
        (WebCore::executeMovePageUp):
        (WebCore::executeMovePageUpAndModifySelection):
        (WebCore::executeMoveRight):
        (WebCore::executeMoveRightAndModifySelection):
        (WebCore::executeMoveToBeginningOfDocument):
        (WebCore::executeMoveToBeginningOfDocumentAndModifySelection):
        (WebCore::executeMoveToBeginningOfLine):
        (WebCore::executeMoveToBeginningOfLineAndModifySelection):
        (WebCore::executeMoveToBeginningOfParagraph):
        (WebCore::executeMoveToBeginningOfParagraphAndModifySelection):
        (WebCore::executeMoveToBeginningOfSentence):
        (WebCore::executeMoveToBeginningOfSentenceAndModifySelection):
        (WebCore::executeMoveToEndOfDocument):
        (WebCore::executeMoveToEndOfDocumentAndModifySelection):
        (WebCore::executeMoveToEndOfSentence):
        (WebCore::executeMoveToEndOfSentenceAndModifySelection):
        (WebCore::executeMoveToEndOfLine):
        (WebCore::executeMoveToEndOfLineAndModifySelection):
        (WebCore::executeMoveToEndOfParagraph):
        (WebCore::executeMoveToEndOfParagraphAndModifySelection):
        (WebCore::executeMoveParagraphBackwardAndModifySelection):
        (WebCore::executeMoveParagraphForwardAndModifySelection):
        (WebCore::executeMoveUp):
        (WebCore::executeMoveUpAndModifySelection):
        (WebCore::executeMoveWordBackward):
        (WebCore::executeMoveWordBackwardAndModifySelection):
        (WebCore::executeMoveWordForward):
        (WebCore::executeMoveWordForwardAndModifySelection):
        (WebCore::executeMoveWordLeft):
        (WebCore::executeMoveWordLeftAndModifySelection):
        (WebCore::executeMoveWordRight):
        (WebCore::executeMoveWordRightAndModifySelection):
        (WebCore::executeMoveToLeftEndOfLine):
        (WebCore::executeMoveToLeftEndOfLineAndModifySelection):
        (WebCore::executeMoveToRightEndOfLine):
        (WebCore::executeMoveToRightEndOfLineAndModifySelection):
        (WebCore::executeSelectAll):
        (WebCore::executeSelectToMark):
        (WebCore::executeSetMark):
        (WebCore::executeSwapWithMark):
        (WebCore::executeUnselect):
        (WebCore::enabledInRichlyEditableText):
        (WebCore::enabledRangeInEditableText):
        (WebCore::enabledRangeInRichlyEditableText):
        (WebCore::valueFormatBlock):
        * editing/FrameSelection.cpp:
        (WebCore::FrameSelection::setSelection):
        (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply):
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::doApply):
        * editing/ModifySelectionListLevel.cpp:
        (WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel):
        (WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel):
        * editing/RemoveFormatCommand.cpp:
        (WebCore::RemoveFormatCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/SetSelectionCommand.cpp:
        (WebCore::SetSelectionCommand::doApply):
        (WebCore::SetSelectionCommand::doUnapply):
        * editing/SpellingCorrectionCommand.cpp:
        (WebCore::SpellingCorrectionCommand::doApply):
        * editing/TextInsertionBaseCommand.cpp:
        (WebCore::TextInsertionBaseCommand::applyTextInsertionCommand):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteSelection):
        (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection):
        (WebCore::TypingCommand::insertText):
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        * editing/ios/EditorIOS.mm:
        (WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
        (WebCore::styleForSelectionStart):
        (WebCore::Editor::fontForSelection):
        * editing/mac/EditorMac.mm:
        (WebCore::styleForSelectionStart):
        (WebCore::Editor::fontForSelection):
        (WebCore::Editor::canCopyExcludingStandaloneImages):
        (WebCore::Editor::readSelectionFromPasteboard):
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::defaultEventHandler):
        (WebCore::HTMLAnchorElement::setActive):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::updateFocusAppearance):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::updateFocusAppearance):
        (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
        * html/HTMLTextFormControlElement.cpp:
        (WebCore::HTMLTextFormControlElement::setSelectionRange):
        (WebCore::HTMLTextFormControlElement::computeSelectionStart):
        (WebCore::HTMLTextFormControlElement::computeSelectionEnd):
        (WebCore::HTMLTextFormControlElement::computeSelectionDirection):
        (WebCore::HTMLTextFormControlElement::selectionChanged):
        * html/TextFieldInputType.cpp:
        (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::clear):
        * loader/archive/cf/LegacyWebArchive.cpp:
        (WebCore::LegacyWebArchive::createFromSelection):
        * page/ContextMenuController.cpp:
        (WebCore::insertUnicodeCharacter):
        (WebCore::ContextMenuController::contextMenuItemSelected):
        (WebCore::selectionContainsPossibleWord):
        (WebCore::ContextMenuController::populate):
        (WebCore::ContextMenuController::checkOrEnableIfNeeded):
        * page/DOMSelection.cpp:
        (WebCore::selectionShadowAncestor):
        (WebCore::DOMSelection::visibleSelection):
        (WebCore::DOMSelection::isCollapsed):
        (WebCore::DOMSelection::type):
        (WebCore::DOMSelection::rangeCount):
        (WebCore::DOMSelection::collapse):
        (WebCore::DOMSelection::collapseToEnd):
        (WebCore::DOMSelection::collapseToStart):
        (WebCore::DOMSelection::empty):
        (WebCore::DOMSelection::setBaseAndExtent):
        (WebCore::DOMSelection::setPosition):
        (WebCore::DOMSelection::modify):
        (WebCore::DOMSelection::extend):
        (WebCore::DOMSelection::getRangeAt):
        (WebCore::DOMSelection::removeAllRanges):
        (WebCore::DOMSelection::addRange):
        (WebCore::DOMSelection::deleteFromDocument):
        (WebCore::DOMSelection::containsNode):
        (WebCore::DOMSelection::toString):
        * page/DragController.cpp:
        (WebCore::DragController::dragIsMove):
        (WebCore::setSelectionToDragCaret):
        (WebCore::DragController::concludeEditDrag):
        (WebCore::DragController::draggableElement):
        (WebCore::selectElement):
        (WebCore::dragLocForSelectionDrag):
        (WebCore::DragController::startDrag):
        * page/DragController.h:
        * page/EventHandler.cpp:
        (WebCore::setSelectionIfNeeded):
        (WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
        (WebCore::EventHandler::handleMousePressEventDoubleClick):
        (WebCore::EventHandler::handleMousePressEventSingleClick):
        (WebCore::EventHandler::updateSelectionForMouseDrag):
        (WebCore::EventHandler::lostMouseCapture):
        (WebCore::EventHandler::handleMouseReleaseEvent):
        (WebCore::nodeIsNotBeingEdited):
        (WebCore::EventHandler::selectCursor):
        (WebCore::EventHandler::handleMousePressEvent):
        (WebCore::EventHandler::handleMouseDoubleClickEvent):
        (WebCore::EventHandler::dispatchMouseEvent):
        (WebCore::EventHandler::sendContextMenuEvent):
        (WebCore::EventHandler::sendContextMenuEventForKey):
        (WebCore::handleKeyboardSelectionMovement):
        (WebCore::EventHandler::handleDrag):
        * page/FocusController.cpp:
        (WebCore::FocusController::setFocusedFrame):
        (WebCore::FocusController::setFocused):
        (WebCore::FocusController::advanceFocusInDocumentOrder):
        (WebCore::clearSelectionIfNeeded):
        (WebCore::FocusController::setActive):
        * page/Frame.cpp:
        (WebCore::Frame::dragImageForSelection):
        * page/Frame.h:
        (WebCore::Frame::selection):
        * page/FrameView.cpp:
        (WebCore::FrameView::performPostLayoutTasks):
        (WebCore::FrameView::paintContentsForSnapshot):
        * page/Page.cpp:
        (WebCore::Page::findString):
        (WebCore::Page::findStringMatchingRanges):
        (WebCore::Page::selection):
        * page/mac/FrameMac.mm:
        (WebCore::Frame::dragImageForSelection):
        * page/mac/FrameSnapshottingMac.mm:
        (WebCore::selectionImage):
        * page/win/FrameWin.cpp:
        (WebCore::imageFromSelection):
        (WebCore::Frame::dragImageForSelection):
        * platform/ios/PasteboardIOS.mm:
        (WebCore::Pasteboard::documentFragmentForPasteboardItemAtIndex):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::isSelected):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintCaret):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintAreaElementFocusRing):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollTo):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintItemForeground):
        (WebCore::RenderListBox::paintItemBackground):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::selectionBackgroundColor):
        (WebCore::RenderObject::selectionColor):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::isFocused):
        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::adjustSearchFieldStyle):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeSelection):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::setSelection):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::deselectAll):
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::selectSubString):
        * testing/Internals.cpp:
        (WebCore::Internals::absoluteCaretBounds):
        (WebCore::Internals::selectionBounds):

2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2013-08-19  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>

        <https://webkit.org/b/119679> Remove the cast-align warnings for ARM

        Reviewed by Darin Adler.

        While compiling WebKitGTK+ for ARM a lot of warnings of this form
        where shown (gcc 4.7.3):

        ../../Source/WebCore/css/StylePropertySet.h: In member function 'const WebCore::StylePropertyMetadata* WebCore::ImmutableStylePropertySet::metadataArray() const':
../../Source/WebCore/css/StylePropertySet.h:179:142: warning: cast from 'const char*' to 'const WebCore::StylePropertyMetadata*' increases required alignment of target type [-Wcast-align]

        This patch changes reinterpret_cast<>() for reinterpret_cast_ptr<>()
        which is part of WTF for this purpose, silencing the compiler.

        * css/StylePropertySet.h:
        (WebCore::ImmutableStylePropertySet::metadataArray):

2040
2041
2042
2043
2044
2045
2046
2047
2048
2013-08-19  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/120014> REGRESSION(r154268): Some stylesheet media attribute tests failing

        Reviewed by Dan Bernstein.

        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::parseAttribute): Always set the media on InlineStyleSheetOwner.

2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2013-08-19  Chris Fleizach  <cfleizach@apple.com>

        <https://webkit.org/b/119916> AX: WebKit is not exposing AXLanguage correctly

        Reviewed by Darin Adler.

        Expose the AXLanguage attribute for all objects.

        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
        (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

2060
2061
2062
2063
2064
2065
2066
2013-08-19  Brent Fulgham  <bfulgham@apple.com>

        [Windows] Unreviewed gardening.

        * WebCore.vcxproj/WebCore.vcxproj: Add missing header for easy access/editing.
        * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.

2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2013-08-19  Mario Sanchez Prada  <mario.prada@samsung.com>

        <https://webkit.org/b/119882> Speed up moving cursor/selection up or down past non-rendered elements.

        Reviewed by Darin Adler.

        This is a port from Blink originally written by Dominic Mazzoni:
        https://src.chromium.org/viewvc/blink?revision=154977&view=revision

        From the original commit:

        Skips calling firstPositionInOrBeforeNode when a node doesn't have a
        renderer, since there couldn't possibly be a visible position there.
        This was particularly wasteful when trying to move the cursor up when at
        the beginning of a document, as it did a O(n^2) scan through the document head.

        Test: editing/execCommand/move-up-down-should-skip-hidden-elements.html

        * editing/VisibleUnits.cpp:
        (WebCore::previousRootInlineBoxCandidatePosition): Updated.
        (WebCore::nextRootInlineBoxCandidatePosition): Updates.

2089
2090
2091
2092
2093
2094
2095
2096
2013-08-19  Andreas Kling  <akling@apple.com>

        <https://webkit.org/b/120000> Chrome::client() should return a reference.

        Reviewed by Antti Koivisto.

        Chrome::m_client should never be null.

2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2013-08-19  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/120004> Rename StyleElement to InlineStyleSheetOwner and stop inheriting from it

        Reviewed by Andreas Kling.
        
        Saner names and class relations.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * Target.pri:
        * WebCore.vcxproj/WebCore.vcxproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/DOMAllInOne.cpp:
        * dom/InlineStyleSheetOwner.cpp: Copied from Source/WebCore/dom/StyleElement.cpp.
        (WebCore::InlineStyleSheetOwner::InlineStyleSheetOwner):
        (WebCore::InlineStyleSheetOwner::~InlineStyleSheetOwner):
        (WebCore::InlineStyleSheetOwner::insertedIntoDocument):
        (WebCore::InlineStyleSheetOwner::removedFromDocument):
        (WebCore::InlineStyleSheetOwner::clearDocumentData):
        (WebCore::InlineStyleSheetOwner::childrenChanged):
        (WebCore::InlineStyleSheetOwner::finishParsingChildren):
        (WebCore::InlineStyleSheetOwner::createSheetFromTextContents):
        (WebCore::InlineStyleSheetOwner::clearSheet):
        (WebCore::InlineStyleSheetOwner::createSheet):
        (WebCore::InlineStyleSheetOwner::isLoading):
        (WebCore::InlineStyleSheetOwner::sheetLoaded):
        (WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):
        * dom/InlineStyleSheetOwner.h: Copied from Source/WebCore/dom/StyleElement.h.
        * dom/StyleElement.cpp: Removed.
        * dom/StyleElement.h: Removed.
        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::HTMLStyleElement):
        (WebCore::HTMLStyleElement::~HTMLStyleElement):
        (WebCore::HTMLStyleElement::parseAttribute):
        (WebCore::HTMLStyleElement::finishParsingChildren):
        (WebCore::HTMLStyleElement::insertedInto):
        (WebCore::HTMLStyleElement::removedFrom):
        (WebCore::HTMLStyleElement::childrenChanged):
        * html/HTMLStyleElement.h:
        * svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::SVGStyleElement):
        (WebCore::SVGStyleElement::~SVGStyleElement):
        (WebCore::SVGStyleElement::parseAttribute):
        (WebCore::SVGStyleElement::finishParsingChildren):
        (WebCore::SVGStyleElement::insertedInto):
        (WebCore::SVGStyleElement::removedFrom):
        (WebCore::SVGStyleElement::childrenChanged):
        * svg/SVGStyleElement.h:

2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        [Qt] QtWebKit (using the Arora browser) displays the border radii (radius) of a button very ugly
        https://bugs.webkit.org/show_bug.cgi?id=28113

        Reviewed by Jocelyn Turcotte.

        StylePainter::init() was called twice making it clobber the previous antialiasing setting.

        This patch cleans up the construction so we only have one constructor with init inlined.

        * platform/qt/RenderThemeQStyle.cpp:
        (WebCore::StylePainterQStyle::StylePainterQStyle):
        (WebCore::StylePainterQStyle::setupStyleOption):
        * platform/qt/RenderThemeQStyle.h:
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::StylePainter::StylePainter):
        * platform/qt/RenderThemeQt.h:
        * platform/qt/RenderThemeQtMobile.cpp:
        (WebCore::StylePainterMobile::StylePainterMobile):

2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2013-08-19  Julien Brianceau  <jbrianceau@nds.com>

        <https://webkit.org/b/119998> [Qt] Build fix (broken since r154257).

        Reviewed by Andreas Kling.

        Element::attach() doesn't exist anymore since r154257.

        * xml/parser/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::parseStartElement):

2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2013-08-19  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/120001> Clean up StyleElement

        Reviewed by Andreas Kling.

        - Make it non-virtual so we don't use virtual multiple inheritance
        - Improve names
        - Improve code clarity

        * dom/StyleElement.cpp:
        (WebCore::StyleElement::StyleElement):
        (WebCore::StyleElement::insertedIntoDocument):
        (WebCore::StyleElement::clearDocumentData):
        (WebCore::StyleElement::childrenChanged):
        (WebCore::StyleElement::finishParsingChildren):
        (WebCore::StyleElement::createSheetFromTextContents):
        (WebCore::isValidCSSContentType):
        (WebCore::StyleElement::createSheet):
        (WebCore::StyleElement::isLoading):
        * dom/StyleElement.h:
        (WebCore::StyleElement::setStyleSheetContentType):
        (WebCore::StyleElement::setStyleSheetMedia):
        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::parseAttribute):
        * html/HTMLStyleElement.h:
        * svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::isSupportedAttribute):
        (WebCore::SVGStyleElement::parseAttribute):
        * svg/SVGStyleElement.h:

2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2013-08-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        <https://webkit.org/b/119990> Add toSVGStopElement(Node* node) to clean-up a static_cast<SVGStopElement*>

        Reviewed by Darin Adler.

        Clean up remained static_cast<SVGStopElement*> using toSVGStopElement(toSVGElement()).

        * rendering/svg/SVGRenderTreeAsText.cpp:
        (WebCore::writeSVGGradientStop):

2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2013-08-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        <https://webkit.org/b/119996> Introduce toSVGAnimateElement(), and use it

        Reviewed by Andreas Kling.

        As a step to clean-up static_cast<SVGXXX>, static_cast<SVGAnimateElement*> also can be changed
        with toSVGAnimateElement().

        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        * svg/SVGAnimateElement.h:
        (WebCore::toSVGAnimateElement):
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):

2237
2238
2239
2240
2241
2242
2243
2244
2013-08-19  Andreas Kling  <akling@apple.com>

        <https://webkit.org/b/119997> Page::progress() should return a reference.

        Reviewed by Antti Koivisto.

        Page::m_progress is never null.

2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2013-08-18  Darin Adler  <darin@apple.com>

        <https://webkit.org/b/119989> Make use of Node::ownerDocument a compile time error

        Reviewed by Sam Weinig.

        * dom/Element.h: Deleted the ownerDocument function. For compilers that don't support
        deleted functions, it is instead overrides the base class function with one that is
        private and not defined, which accomplishes almost the same thing: An error, either
        at compile time or link time.

        * bindings/js/JSHTMLElementCustom.cpp:
        (WebCore::JSHTMLElement::pushEventHandlerScope): Use document instead of ownerDocument.
        * dom/Document.cpp:
        (WebCore::Document::~Document): Added a comment about this clearly-incorrect code.
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::didPushShadowRoot): Use document instead of ownerDocument.
        (WebCore::InspectorInstrumentation::willPopShadowRoot): Ditto.
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheetForInlineStyle::setStyleText): Ditto.
        * plugins/PluginView.cpp:
        (WebCore::getFrame): Removed ineffective call to ownerDocument after document when it
        returns 0. It will never return anything other than 0 in that case.
        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::calculateIntrinsicSize): Use document instead of ownerDocument.
        Did not remove the null check at this time, although I'm pretty sure it's bogus. We can
        fix that when/if we change the return type of Element::document to a reference.
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::requestImageResource): Use document instead of ownerDocument.

2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2013-08-18  Darin Adler  <darin@apple.com>

        <https://webkit.org/b/119993> Remove most remaining platform-specific code from Clipboard class

        Reviewed by Sam Weinig.

        * GNUmakefile.list.am: Removed ClipboardGtk.cpp.
        * PlatformEfl.cmake: Removed ClipboardEfl.cpp.
        * PlatformGTK.cmake: Removed ClipboardGtk.cpp.
        * PlatformWinCE.cmake: Removed ClipboardWin.cpp.
        * Target.pri: Removed ClipboardQt.cpp.
        * WebCore.vcxproj/WebCore.vcxproj: Removed ClipboardWin.cpp and ClipboardWin.h.
        * WebCore.vcxproj/WebCore.vcxproj.filters: Removed ClipboardWin.cpp and ClipboardWin.h.

        * dom/Clipboard.cpp:
        (WebCore::Clipboard::createDragImage): Added. Version that works for all platforms
        other than Mac, identical to the old one used in GTK and Qt, and close to the one used
        on Windows.

        * platform/mac/ClipboardMac.mm: Trimmed includes down, and added a FIXME about next steps.

        * platform/qt/DataTransferItemListQt.h: Removed "friend class ClipboardQt", which refers
        to a now-nonexistent class.

        * platform/efl/ClipboardEfl.cpp: Removed.
        * platform/gtk/ClipboardGtk.cpp: Removed.
        * platform/qt/ClipboardQt.cpp: Removed.
        * platform/win/ClipboardWin.cpp: Removed.

2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2013-08-17  Darin Adler  <darin@apple.com>

        <https://webkit.org/b/119949> Factor Clipboard into drag and non-drag parts

        Reviewed by Sam Weinig.

        * dom/Clipboard.cpp:
        (WebCore::Clipboard::Clipboard): Move the ClipboardType argument to go after the pasteboard.
        Initialize strings more efficiently. Put drag-specific data members inside an if statement.
        Replace m_clipboardType with m_forDrag.
        (WebCore::Clipboard::createForCopyAndPaste): Moved function up to be close to constructor.
        Removed explicit clipboard type since constructor now defaults to copy and paste style.
        (WebCore::Clipboard::setAccessPolicy): Tweaked comment.
        (WebCore::Clipboard::getData): Put drag-specific code inside #if ENABLE(DRAG_SUPPORT).
        (WebCore::Clipboard::setData): Ditto.
        (WebCore::Clipboard::files): Ditto.
        (WebCore::Clipboard::dropEffect): Added trivial non-drag versions of these functions to
        be used when !ENABLE(DRAG_SUPPORT).
        (WebCore::Clipboard::setDropEffect): Ditto.
        (WebCore::Clipboard::effectAllowed): Ditto.
        (WebCore::Clipboard::setEffectAllowed): Ditto.
        (WebCore::Clipboard::createForDragAndDrop): Renamed Clipboard::create that takes DragData
        to this, and kep the overload that does not as well. Made the DragData argument a const&.
        (WebCore::Clipboard::canSetDragImage): Moved down here since it is drag-specific.
        (WebCore::Clipboard::updateDragImage): Use m_shouldUpdateDragImage directly insted of
        calling a dragStarted function.
        (WebCore::dragOpFromIEOp): Moved this function down here to the drag-specific section.
        (WebCore::IEOpFromDragOp): Ditto.
        (WebCore::Clipboard::sourceOperation): Ditto.
        (WebCore::Clipboard::destinationOperation): Ditto.
        (WebCore::Clipboard::setSourceOperation): Ditto.
        (WebCore::Clipboard::setDestinationOperation): Ditto.

        * dom/Clipboard.h: Removed unneeded include of "Node.h" and added and removed forward
        class declarations as required. Removed non-helpful comment. Made ClipboardType a private
        implementation detail. Moved functions that are not part of the DOM API down to a separate
        section lower down in the class, and sorted the functions to match the order they appear
        in the IDL file. Removed isForCopyAndPaste and isForDragAndDrop. Changed dropEffect and
        effectAllowed to not be inlined. Moved the long comment before canSetDragImage into the
        implementation since it's an implementation detail. Since this class is no longer polymorphic,
        use only private, not protected. Make m_dragImageElement an Element, not a Node.

        * dom/Clipboard.idl: Removed flags to tell bindings how to deal with null strings, since
        these string properties can never return null strings anyway.

        * page/DragController.cpp:
        (WebCore::DragController::dragExited): Updated to call the new createForDragAndDrop function.
        (WebCore::DragController::performDrag): Ditto.
        (WebCore::DragController::tryDHTMLDrag): Ditto.

        * platform/mac/ClipboardMac.mm: Added now-needed include of Element.h since Clipboard.h no
        longer includes it.

2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2013-08-18  David Kilzer  <ddkilzer@apple.com>

        WebCore fails to build with trunk clang: error: 'register' storage class specifier is deprecated [-Werror,-Wdeprecated-register]
        <http://webkit.org/b/119932>
        <rdar://problem/14764085>

        Reviewed by Darin Adler.

        Add pragma statements to ignore -Wdeprecated-register warnings
        in generated code.  Also ignore -Wunknown-pragmas so this
        doesn't cause a build failure in older versions of clang.

        * css/makeprop.pl:
        (WebCore::findProperty): Remove register hints from parameters.
        * css/makevalues.pl:
        (WebCore::findValue): Ditto.
        * platform/ColorData.gperf:
        (WebCore::findColor): Ditto.

2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2013-08-18  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/119987> Make Element::attach standalone function

        Reviewed by Andreas Kling.

        This patch turns Element::attach() and the related functions into standalone functions.

        * dom/ContainerNode.cpp:
        (WebCore::attachChild):
        (WebCore::detachChild):
        * dom/ContainerNode.h:
        * dom/Document.cpp:
        (WebCore::Document::attach):
        (WebCore::Document::detach):
        * dom/Element.cpp:
        (WebCore::Element::~Element):
        (WebCore::Element::lazyReattach):
        (WebCore::Element::removeShadowRoot):
        
            Shadow root should be detached by now. Remove the detach call.

        (WebCore::Element::updateFocusAppearanceAfterAttachIfNeeded):
        (WebCore::Element::updatePseudoElement):
        (WebCore::Element::clearStyleDerivedDataBeforeDetachingRenderer):
        (WebCore::Element::clearHoverAndActiveStatusBeforeDetachingRenderer):
        
            Factor some parts of former Element::attach/detach() into member functions.

        * dom/Element.h:
        * dom/ElementRareData.h:
        (WebCore::ElementRareData::releasePseudoElement):
        * dom/NodeRenderingContext.cpp:
        (WebCore::NodeRenderingContext::NodeRenderingContext):
        * dom/NodeRenderingContext.h:
        * dom/ShadowRoot.cpp:
        * dom/ShadowRoot.h:
        * html/HTMLDetailsElement.cpp:
        (WebCore::HTMLDetailsElement::parseAttribute):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::updateType):
        (WebCore::HTMLInputElement::parseAttribute):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::renderFallbackContent):
        * html/HTMLPlugInImageElement.cpp:
        (WebCore::HTMLPlugInImageElement::willRecalcStyle):
        (WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::parseAttribute):
        (WebCore::HTMLSelectElement::parseMultipleAttribute):
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::createContainingTable):
        (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
        (WebCore::HTMLViewSourceDocument::addLine):
        (WebCore::HTMLViewSourceDocument::finishLine):
        (WebCore::HTMLViewSourceDocument::addBase):
        (WebCore::HTMLViewSourceDocument::addLink):
        * html/parser/HTMLConstructionSite.cpp:
        (WebCore::executeTask):
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
        * html/shadow/InsertionPoint.cpp:
        (WebCore::InsertionPoint::willAttachRenderers):
        (WebCore::InsertionPoint::willDetachRenderers):
        * loader/PlaceholderDocument.cpp:
        (WebCore::PlaceholderDocument::attach):
        * style/StyleResolveTree.cpp:
        (WebCore::Style::createRendererIfNeeded):
        
            From Element::createRendererIfNeeded()

        (WebCore::Style::attachShadowRoot):
        
            From ShadowRoot::attach()

        (WebCore::Style::childAttachedAllowedWhenAttachingChildren):
        (WebCore::Style::attachChildren):
        
            From Element::attachChildren()

        (WebCore::Style::attachRenderTree):
        
            From Element::attach()

        (WebCore::Style::detachShadowRoot):
        
            From ShadowRoot::detach()

        (WebCore::Style::detachChildren):
        
            From Element::detachChildren()

        (WebCore::Style::detachRenderTree):
        
            From Element::deatach()

        (WebCore::Style::reattachRenderTree):
        
             From Element::reattach()

        (WebCore::Style::resolveLocal):
        * style/StyleResolveTree.h:
        (WebCore::Style::AttachContext::AttachContext):
        
            From Element::AttachContext

        * svg/SVGTests.cpp:
        (WebCore::SVGTests::handleAttributeChange):
        * xml/XMLErrors.cpp:
        (WebCore::XMLErrors::insertErrorMessageBlock):
        * xml/parser/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::startElementNs):

2489
2490
2491
2492
2493
2494
2495
2496
2497
2013-08-18  Antti Koivisto  <antti@apple.com>

        Fix crashing plugin tests caused by a logic error in the previous patch.
        
        Not reviewed.

        * html/HTMLPlugInImageElement.cpp:
        (WebCore::HTMLPlugInImageElement::willDetachRenderers):

2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2013-08-18  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/119982> Make Element::attach non-virtual

        Reviewed by Andreas Kling.

        This will give us more future refactoring options.

        * dom/Element.cpp:
        (WebCore::Element::attach):
        (WebCore::Element::detach):
        
            Make non-virtual. Call element type specific custom functions as needed.

        (WebCore::Element::styleForRenderer):
        (WebCore::Element::willRecalcStyle):
        (WebCore::Element::didRecalcStyle):
        (WebCore::Element::willAttachRenderers):
        (WebCore::Element::didAttachRenderers):
        (WebCore::Element::willDetachRenderers):
        (WebCore::Element::didDetachRenderers):
        
            Add virtual custom callbacks.

        (WebCore::Element::customStyleForRenderer):
        * dom/Element.h:
        * dom/Node.h:
        (WebCore::Node::pseudoId):
        (WebCore::Node::hasCustomStyleResolveCallbacks):
        (WebCore::Node::setHasCustomStyleResolveCallbacks):
        
            Use the existing bit as it largely overlaps. Rename for clarity.

        (WebCore::Node::customPseudoId):
        * dom/PseudoElement.cpp:
        (WebCore::PseudoElement::PseudoElement):
        (WebCore::PseudoElement::didAttachRenderers):
        * dom/PseudoElement.h:
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::HTMLCanvasElement):
        (WebCore::HTMLCanvasElement::willAttachRenderers):
        * html/HTMLCanvasElement.h:
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::HTMLFormControlElement):
        (WebCore::HTMLFormControlElement::didAttachRenderers):
        * html/HTMLFormControlElement.h:
        * html/HTMLFrameElement.cpp:
        (WebCore::HTMLFrameElement::HTMLFrameElement):
        (WebCore::HTMLFrameElement::didAttachRenderers):
        * html/HTMLFrameElement.h:
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
        (WebCore::HTMLFrameElementBase::didAttachRenderers):
        * html/HTMLFrameElementBase.h:
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
        (WebCore::HTMLFrameSetElement::willAttachRenderers):
        * html/HTMLFrameSetElement.h:
        * html/HTMLIFrameElement.cpp:
        (WebCore::HTMLIFrameElement::HTMLIFrameElement):
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::HTMLImageElement):
        (WebCore::HTMLImageElement::didAttachRenderers):
        * html/HTMLImageElement.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::HTMLInputElement):
        (WebCore::HTMLInputElement::willAttachRenderers):
        (WebCore::HTMLInputElement::didAttachRenderers):
        (WebCore::HTMLInputElement::didDetachRenderers):
        * html/HTMLInputElement.h:
        * html/HTMLLIElement.cpp:
        (WebCore::HTMLLIElement::HTMLLIElement):
        (WebCore::HTMLLIElement::didAttachRenderers):
        * html/HTMLLIElement.h:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement):
        (WebCore::HTMLMediaElement::willAttachRenderers):
        (WebCore::HTMLMediaElement::didAttachRenderers):
        * html/HTMLMediaElement.h:
        * html/HTMLOptGroupElement.cpp:
        (WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
        (WebCore::HTMLOptGroupElement::didAttachRenderers):
        (WebCore::HTMLOptGroupElement::willDetachRenderers):
        * html/HTMLOptGroupElement.h:
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::HTMLOptionElement):
        (WebCore::HTMLOptionElement::didAttachRenderers):
        (WebCore::HTMLOptionElement::willDetachRenderers):
        * html/HTMLOptionElement.h:
        * html/HTMLPlugInElement.cpp:
        (WebCore::HTMLPlugInElement::HTMLPlugInElement):
        (WebCore::HTMLPlugInElement::willDetachRenderers):
        * html/HTMLPlugInElement.h:
        * html/HTMLPlugInImageElement.cpp:
        (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
        (WebCore::HTMLPlugInImageElement::didAttachRenderers):
        (WebCore::HTMLPlugInImageElement::willDetachRenderers):
        * html/HTMLPlugInImageElement.h:
        * html/HTMLProgressElement.cpp:
        (WebCore::HTMLProgressElement::HTMLProgressElement):
        (WebCore::HTMLProgressElement::didAttachRenderers):
        * html/HTMLProgressElement.h:
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
        (WebCore::HTMLTextAreaElement::didAttachRenderers):
        * html/HTMLTextAreaElement.h:
        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::HTMLVideoElement):
        (WebCore::HTMLVideoElement::didAttachRenderers):
        * html/HTMLVideoElement.h:
        * html/shadow/InsertionPoint.cpp:
        (WebCore::InsertionPoint::InsertionPoint):
        (WebCore::InsertionPoint::willAttachRenderers):
        (WebCore::InsertionPoint::willDetachRenderers):
        * html/shadow/InsertionPoint.h:
        * html/shadow/SliderThumbElement.cpp:
        (WebCore::SliderThumbElement::SliderThumbElement):
        (WebCore::SliderThumbElement::willDetachRenderers):
        * html/shadow/SliderThumbElement.h:
        * html/shadow/SpinButtonElement.cpp:
        (WebCore::SpinButtonElement::SpinButtonElement):
        (WebCore::SpinButtonElement::willDetachRenderers):
        * html/shadow/SpinButtonElement.h:
        * html/shadow/TextControlInnerElements.cpp:
        (WebCore::TextControlInnerElement::TextControlInnerElement):
        (WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
        (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
        (WebCore::SearchFieldCancelButtonElement::willDetachRenderers):
        (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
        (WebCore::InputFieldSpeechButtonElement::willAttachRenderers):
        (WebCore::InputFieldSpeechButtonElement::willDetachRenderers):
        * html/shadow/TextControlInnerElements.h:
        * style/StyleResolveTree.cpp:
        (WebCore::Style::resolveTree):
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::SVGElement):
        * svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::SVGImageElement):
        (WebCore::SVGImageElement::didAttachRenderers):
        * svg/SVGImageElement.h:
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::SVGUseElement):

2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
2013-08-18  Gavin Barraclough  <barraclough@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=119972
        Add attributes field to PropertySlot

        Reviewed by Geoff Garen.

        For all JSC types, this makes getOwnPropertyDescriptor redundant.
        There will be a bit more hacking required in WebCore to remove GOPD whilst maintaining current behaviour.
        (Current behaviour is in many ways broken, particularly in that GOPD & GOPS are inconsistent, but we should fix incrementally).

        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::JSCSSStyleDeclaration::getOwnPropertySlotDelegate):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::getOwnPropertySlot):
        (WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
        (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
        * bindings/js/JSHistoryCustom.cpp:
        (WebCore::JSHistory::getOwnPropertySlotDelegate):
        (WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::getOwnPropertySlotDelegate):
        (WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
        * bindings/js/JSPluginElementFunctions.cpp:
        (WebCore::runtimeObjectCustomGetOwnPropertySlot):
        (WebCore::runtimeObjectCustomGetOwnPropertyDescriptor):
        * bindings/scripts/CodeGeneratorJS.pm:
        (GenerateGetOwnPropertySlotBody):
        (GenerateGetOwnPropertyDescriptorBody):
        (GenerateImplementation):
        * bridge/runtime_array.cpp:
        (JSC::RuntimeArray::getOwnPropertySlot):
        (JSC::RuntimeArray::getOwnPropertyDescriptor):
        (JSC::RuntimeArray::getOwnPropertySlotByIndex):
        * bridge/runtime_method.cpp:
        (JSC::RuntimeMethod::getOwnPropertySlot):
        (JSC::RuntimeMethod::getOwnPropertyDescriptor):
        * bridge/runtime_object.cpp:
        (JSC::Bindings::RuntimeObject::getOwnPropertySlot):
        (JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
            - Pass attributes to PropertySlot::set* methods.

2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2013-08-18  Ryosuke Niwa  <rniwa@webkit.org>

        <https://webkit.org/b/119917> Pasting multiple lines into a textarea can introduce extra new lines

        Reviewed by Darin Adler.

        Inspired by https://chromium.googlesource.com/chromium/blink/+/6152a12f7ace27beea4d284ff8416631e8aa5217.

        The bug was caused by createFragmentFromText's falsely assuming that the newline were not preserved
        if the first node's renderer didn't exist.

        Fixed the bug by obtaining the renderer of the container of the first visible position in the context.

        Test: editing/pasteboard/paste-into-textarea-with-new-line.html

        * editing/markup.cpp:
        (WebCore::contextPreservesNewline):
        (WebCore::createFragmentFromText):

2702
2703
2704
2705
2706
2707
2708
2709
2710
2013-08-18  Andreas Kling  <akling@apple.com>

        <https://webkit.org/b/119983> Add two missing RefPtr::release() in HTMLLinkElement.

        Reviewed by Antti Koivisto.

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::setCSSStyleSheet):

2711
2712
2713
2714
2715
2716
2717
2718
2013-08-18  Andreas Kling  <akling@apple.com>

        <https://webkit.org/b/119981> Move ElementData & co to their own files.

        Reviewed by Antti Koivisto.

        I like to move it move it.

2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2013-08-18  David Kilzer  <ddkilzer@apple.com>

        BUILD FIX (r153990): Add UNUSED_PARAM for heightChanged when CSS_SHAPES is disabled

        Fixes the following build failure:

            WebCore/rendering/RenderBlock.cpp:1529:53: error: unused parameter 'heightChanged' [-Werror,-Wunused-parameter]
            void RenderBlock::updateShapesAfterBlockLayout(bool heightChanged)
                                                                ^
            1 error generated.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateShapesAfterBlockLayout): Add
        UNUSED_PARAM(heightChanged) when CSS_SHAPES is disabled.

2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2746
2013-08-18  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>

        [EFL] minor method name fix for the textTrackOffMenuItemText method
        https://bugs.webkit.org/show_bug.cgi?id=119978

        the method textTrackOffMenuItemText was renamed in
        https://bugs.webkit.org/show_bug.cgi?id=113822

        Reviewed by Christophe Dumez.

        * platform/efl/LocalizedStringsEfl.cpp:
        (WebCore::textTrackOffMenuItemText):

2747
2748
2749
2750
2751
2752
2753
2754
2755
2756
2757
2758
2759
2760
2013-08-17  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/119963> Use TextNodeTraversal for getting sheet text in StyleElement

        Reviewed by Andreas Kling.

        * dom/StyleElement.cpp:
        (WebCore::StyleElement::process):
        
            Use TextNodeTraversal::contentsAsString for the sheet text. The overflow check is removed as StringBuilder 
            (which is used by contentsAsString) does that itself. The behavior in case of overflow changes from empty
            sheet to CRASH(). Thats what we do elsewhere in similar situations too (scripts for example). Continuing
            with > 4GB of style sheet text nodes is probably not going to go well anyway.

2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2013-08-17  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/119960> Remove some optimizations made obsolete by use of StringBuilder

        Reviewed by Andreas Kling.

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::scriptContent):
        
            StringBuilder already optimizes for the single string case. If there is only one the original string is returned.

        * dom/Text.cpp:
        (WebCore::Text::wholeText):
        
            No need to traverse twice to compute the capacity. StringBuilder handles this efficiently. 
            Also in the common case there is only one string and the optimization here is actually hurting by disabling the StringBuilder one.

2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
2812
2813
2814
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2013-08-17  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/119959> Add TextNodeTraversal

        Reviewed by Andreas Kling.

        Add TextNodeTraversal for cleaner and more compact traversal of Text nodes.
        
        Use it where appropriate.

        * WebCore.xcodeproj/project.pbxproj:
        * dom/Attr.cpp:
        (WebCore::Attr::childrenChanged):
        * dom/NodeTraversal.h:
        (WebCore::NodeTraversal::next):
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::scriptContent):
        * dom/Text.cpp:
        (WebCore::Text::wholeText):
        * dom/Text.h:
        (WebCore::toText):
        * dom/TextNodeTraversal.cpp: Added.
        (WebCore::TextNodeTraversal::appendContents):
        (WebCore::TextNodeTraversal::contentsAsString):
        
            Helpers for getting text content of a subtree.

        * dom/TextNodeTraversal.h: Added.
        (WebCore::TextNodeTraversal::firstTextChildTemplate):
        (WebCore::TextNodeTraversal::firstChild):
        (WebCore::TextNodeTraversal::firstTextWithinTemplate):
        (WebCore::TextNodeTraversal::firstWithin):
        (WebCore::TextNodeTraversal::traverseNextTextTemplate):
        (WebCore::TextNodeTraversal::next):
        (WebCore::TextNodeTraversal::nextSibling):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::joinChildTextNodes):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::defaultValue):
        (WebCore::HTMLTextAreaElement::setDefaultValue):
        * html/HTMLTitleElement.cpp:
        (WebCore::HTMLTitleElement::text):
        * html/track/TextTrackCue.cpp:
        (WebCore::TextTrackCue::determineTextDirection):
        * page/Frame.cpp:
        (WebCore::Frame::searchForLabelsAboveCell):
        * xml/XPathUtil.cpp:
        (WebCore::XPath::stringValue):

2827
2828
2829
2830
2831
2832
2833
2834
2835
2836
2837
2013-08-17  Andreas Kling  <akling@apple.com>

        <https://webkit.org/b/119957> Page::contextMenuController() should return a reference.

        Reviewed by Antti Koivisto.

        Page::m_contextMenuController is never null.

        * page/Page.h:
        (WebCore::Page::contextMenuController):

2838
2839
2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2013-08-17  Andreas Kling  <akling@apple.com>

        <https://webkit.org/b/119954> Page::dragCaretController() should return a reference.

        Reviewed by Antti Koivisto.

        Page::m_dragCaretController is never null.

        * dom/Document.cpp:
        (WebCore::Document::nodeChildrenWillBeRemoved):
        (WebCore::Document::nodeWillBeRemoved):
        * page/DragController.cpp:
        (WebCore::DragController::cancelDrag):
        (WebCore::DragController::dragEnded):
        (WebCore::DragController::tryDocumentDrag):
        (WebCore::DragController::dispatchTextInputEventFor):
        (WebCore::DragController::concludeEditDrag):
        (WebCore::DragController::placeDragCaret):
        * page/Page.h:
        (WebCore::Page::dragCaretController):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintCaret):

2861
2862
2863
2864
2865
2866
2867
2868
2869
2870
2871
2013-08-17  Andreas Kling  <akling@apple.com>

        <https://webkit.org/b/119952> Simplify Editor's back-pointer to the Frame.

        Reviewed by Antti Koivisto.

        Remove Editor's inheritance from FrameDestructionObserver. Editor is owned by Frame and
        has no interest in observing frame destruction since its own destruction will soon follow.

        Editor::m_frame is now a reference instead of a pointer. Removed some null checking.

2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2882
2883
2884
2885
2886
2887
2888
2013-08-17  Andreas Kling  <akling@apple.com>

        <https://webkit.org/b/119950> Remove unused EditorClient::frameWillDetachPage() callback.

        Reviewed by Antti Koivisto.

        This callback was only used by the Chromium port.

        * editing/Editor.h:
        * editing/Editor.cpp:

            Remove override of FrameDestructionObserver::willDetachPage().

        * page/EditorClient.h:

            Remove frameWillDetachPage(). This is repeated in every EditorClient subclass.

2889
2890
2891
2892
2893
2894
2895
2896
2897
2898
2899
2900
2901
2902
2903
2904
2905
2906
2907
2908
2909
2910
2911
2912
2913
2914
2915
2916
2917
2918
2919
2920
2921
2922
2923
2924
2925
2926
2013-08-16  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/119886> PseudoElement is abusing parent node pointer

        Reviewed by Darin Adler.

        PseudoElement sets its host node as its parent. This is confusing and wrong as it breaks
        the basic tree consistency (a node is a child node of its parent node).
        
        This patch adds an explicit host pointer PseudoElement and switches the call sites over. Memory
        impact is negligible as there are not that many ::befores and ::afters.

        * dom/ComposedShadowTreeWalker.cpp:
        (WebCore::ComposedShadowTreeWalker::traverseParent):
        * dom/EventPathWalker.cpp:
        (WebCore::EventPathWalker::moveToParent):
        * dom/EventRetargeter.h:
        (WebCore::EventRetargeter::eventTargetRespectingTargetRules):
        * dom/Node.cpp:
        (WebCore::Node::~Node):
        
            Add consistency assertions. Remove unnecessary clearing of sibling pointers. They should be cleared already.

        (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc):
        * dom/PseudoElement.cpp:
        (WebCore::PseudoElement::PseudoElement):
        (WebCore::PseudoElement::customStyleForRenderer):
        * dom/PseudoElement.h:
        (WebCore::toPseudoElement):
        
            Add casting functions.

        * inspector/InspectorLayerTreeAgent.cpp:
        (WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::setInnerNode):
        (WebCore::HitTestResult::setInnerNonSharedNode):

2927
2928
2929
2930
2931
2932
2933
2934
2935
2936
2937
2938
2939
2940
2941
2013-08-17  Darin Adler  <darin@apple.com>

        <https://webkit.org/b/119948> Change drag-specific clipboard writing in DragController to go straight to Pasteboard, not forward through Clipboard

        Reviewed by Andreas Kling.

        * dom/Clipboard.cpp: Removed writeRange, writePlainText, and writeURL functions.
        All three are just unneeded forwarding to pasteboard.
        * dom/Clipboard.h: Ditto.

        * page/DragController.cpp:
        (WebCore::DragController::startDrag): Move the logic in here. Later we might
        want to straighten this out a bit, perhaps using functions in Editor, but it's
        not much code so fine to just have it here for now.

2942
2943
2944
2945
2946
2947
2948
2949
2950
2951
2952
2953
2954
2013-08-17  Darin Adler  <darin@apple.com>

        <https://webkit.org/b/119947> Remove LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS

        Reviewed by Andreas Kling.

        * dom/Clipboard.cpp:
        (WebCore::Clipboard::Clipboard):
        (WebCore::Clipboard::~Clipboard):
        * dom/Clipboard.h:
        Remove LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS, LEGACY_VIRTUAL, and LEGACY_PURE.
        Keep only the !USE(LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS) side of all conditionals.

2955
2956
2957
2958
2959
2960
2961
2962
2963
2964
2965
2966
2967
2968
2969
2970
2971
2972
2973
2974
2975
2976
2977
2013-08-17  Darin Adler  <darin@apple.com>

        <https://webkit.org/b/119946> Move some code used only by EventHandler from Clipboard to EventHandler

        Reviewed by Andreas Kling.

        Later it would be good to move this all to DragController, but there is no reason to have
        these functions as member functions of the DOM-exposed Clipboard class.

        * dom/Clipboard.cpp: Deleted hasFileOfType, hasStringOfType, convertDropZoneOperationToDragOperation,
        convertDragOperationToDropZoneOperation.
        * dom/Clipboard.h: Ditto.

        * page/EventHandler.cpp:
        (WebCore::convertDropZoneOperationToDragOperation): Moved here.
        (WebCore::convertDragOperationToDropZoneOperation): Moved here. Also changed to use ASCIILiteral.
        (WebCore::hasFileOfType): Moved here and made a free function instead of a member function. Removed
        canReadTypes check because Clipboard::files already takes care of that.
        (WebCore::hasStringOfType): Moved here and made a free function instead of a member function.
        Added a check for the null string because HashSet::contains will not work on a null string.
        (WebCore::hasDropZoneType): Moved here and made a free function instead of a member function.
        (WebCore::findDropZone): Call the hasDropZoneType function instead of Clipboard::hasDropZoneType.

2978
2979
2980
2981
2982
2983
2984
2985
2986
2987
2988
2989
2990
2991
2992
2993
2994
2995
2996
2997
2998
2999
3000
3001
3002
3003
3004
3005
3006
3007
3008
2013-08-17  Darin Adler  <darin@apple.com>

        <https://webkit.org/b/119943> Clean up the Document class a bit

        Reviewed by Antti Koivisto.

        * dom/Document.cpp:
        (WebCore::Document::~Document): Fixed typo in comment.
        (WebCore::Document::suggestedMIMEType): Use ASCIILiteral for literals.
        Also name local variable just loader rather than documentLoader.
        (WebCore::Document::updateTitle): Call loader rather than going indirectly
        through frame to get to the loader.
        (WebCore::Document::setTitleElement): Fixed formatting (add braces).
        (WebCore::Document::removeTitle): Iterate elements instead of nodes.
        (WebCore::Document::isPageBoxVisible): Use ensureStyleResolver to call
        styleForPage to avoid the need for a simple forwarding function. Also
        eliminated local variable to increase clarity.
        (WebCore::Document::pageSizeAndMarginsInPixels): Use ensureStyleResolver
        to call styleForPage to avoid the need for a simple forwarding function.
        (WebCore::Document::setIsViewSource): Renamed a local variable.

        * dom/Document.h: Removed unneeded childNeedsAndNotInStyleRecalc and
        styleForPage functions.

        * loader/FrameLoader.cpp: Removed unnneeded setTitle function.
        * loader/FrameLoader.h: Ditto.

        * page/PrintContext.cpp:
        (WebCore::PrintContext::pageProperty): Use ensureStyleResolver to call
        styleForPage to avoid the need for a simple forwarding function.

3009
3010
3011
3012
3013
3014
3015
3016
3017
3018
3019
3020
3021
3022
3023
3024
3025
3026
3027
3028
3029
3030
3031
3032
3033
3034
3035
3036
3037
3038
3039
2013-08-17  Darin Adler  <darin@apple.com>

        <https://webkit.org/b/119939> Remove some unused clipboard and pasteboard code

        Reviewed by Andreas Kling.

        * PlatformWinCE.cmake: Removed EditorWin.cpp.
        * WebCore.vcxproj/WebCore.vcxproj: Removed EditorWin.cpp.
        * WebCore.vcxproj/WebCore.vcxproj.filters: Removed EditorWin.cpp.
        * WebCore.xcodeproj/project.pbxproj: Removed ClipboardIOS.h and
        ClipboardIOS.mm, and also let Xcode edit/reorder this file.

        * editing/Editor.cpp:
        (WebCore::Editor::dispatchCPPEvent): Removed some LEGACY_STYLE_ABSTRACT_CLIPBOARD
        class code. Will remove the rest later.

        * editing/Editor.h: Removed declaration of newGeneralClipboard.

        * platform/Pasteboard.h: Removed declaration of writeClipboard. Also updated a
        comment to make it clearer.

        * platform/blackberry/PasteboardBlackBerry.cpp: Removed Pasteboard::writeClipboard.
        * platform/efl/PasteboardEfl.cpp: Ditto.
        * platform/ios/PasteboardIOS.mm: Ditto.
        * platform/win/PasteboardWin.cpp: Ditto.

        * platform/ios/ClipboardIOS.h: Removed. Was an empty file.
        * platform/ios/ClipboardIOS.mm: Removed. Was an empty file.
        * platform/win/EditorWin.cpp: Removed. Had only newGeneralClipboard in the file,
        a function that is never called.

3040
3041
3042
3043
3044
3045
3046
3047
3048
3049
3050
3051
3052
3053
3054
3055
3056
3057
3058
3059
3060
2013-08-17  Darin Adler  <darin@apple.com>

        <https://webkit.org/b/119940> Rename Clipboard::m_dragLoc to m_dragLocation

        Reviewed by Andreas Kling.

        * dom/Clipboard.h: Removed unused dragLocation member function.
        Renamed m_dragLoc to m_dragLocation.

        * dom/Clipboard.cpp:
        (WebCore::Clipboard::setDragImage):
        * platform/gtk/ClipboardGtk.cpp:
        (WebCore::Clipboard::createDragImage):
        * platform/mac/ClipboardMac.mm:
        (WebCore::Clipboard::createDragImage):
        * platform/qt/ClipboardQt.cpp:
        (WebCore::Clipboard::createDragImage):
        * platform/win/ClipboardWin.cpp:
        (WebCore::Clipboard::createDragImage):
        Updated for new name.

3061
3062
3063
3064
3065
3066
3067
3068
3069
3070
3071
3072
3073
3074
3075
3076
3077
3078
3079
3080
3081
3082
3083
3084
3085
3086
3087
3088
3089
3090
3091
3092
3093
3094
3095
3096
3097
3098
3099
2013-08-17  Darin Adler  <darin@apple.com>

        <https://webkit.org/b/119942> Remove unnecessary uses of Element::ownerDocument

        Reviewed by Andreas Kling.

        The Element::document is a simpler faster alternative to Element::ownerDocument.
        The only behavior difference between the two is that ownerDocument returns 0 when
        called on a Document.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::supportsFocus): Call document instead of ownerDocument.
        (WebCore::HTMLMediaElement::mediaPlayerOwningDocument): Removed null checking of
        document and call to ownerDocument, since ownerDocument will never return non-null
        if document returns null.
        (WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks): Call document instead
        of ownerDocument.

        * inspector/DOMEditor.cpp:
        (WebCore::DOMEditor::SetOuterHTMLAction::perform): Call document instead of ownerDocument.

        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getMatchedStylesForNode): Call document instead of ownerDocument.
        (WebCore::InspectorCSSAgent::forcePseudoState): Call document instead of ownerDocument.
        (WebCore::InspectorCSSAgent::resetPseudoStates): Call document instead of ownerDocument.

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::setOuterHTML): Call document instead of expression that
        does the same thing in a roundabout way.
        (WebCore::InspectorDOMAgent::focusNode): Call document instead of ownerDocument.
        (WebCore::InspectorDOMAgent::resolveNode): Call document instead of expression that
        does the same thing in a roundabout way.

        * page/DragController.cpp:
        (WebCore::DragController::concludeEditDrag): Call document instead of ownerDocument.

        * svg/SVGElementInstance.cpp:
        (WebCore::SVGElementInstance::ownerDocument): Call document instead of ownerDocument.

3100
3101
3102
3103
3104
3105
3106
3107
3108
3109
3110
3111
3112
3113
3114
3115
3116
3117
3118
2013-08-17  Darin Adler  <darin@apple.com>

        <https://webkit.org/b/119941> Make Page::dragController return a reference

        Reviewed by Andreas Kling.

        * page/Page.h:
        (WebCore::Page::dragController): Return a reference instead of a pointer.

        * page/DragController.cpp:
        (WebCore::DragController::concludeEditDrag):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::eventMayStartDrag):
        (WebCore::EventHandler::updateDragSourceActionsAllowed):
        (WebCore::EventHandler::handleDrag):
        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::passSubframeEventToSubframe):
        Updated call sites.

3119
3120
3121
3122
3123
3124
3125
3126
3127
3128
3129
3130
3131
3132
3133
3134
3135
3136
3137
3138
3139
3140
3141
3142
3143
3144
3145
3146
3147
3148
3149
3150
3151
3152
3153
3154
3155
3156
3157
3158
3159