ChangeLog 2.19 MB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
2012-02-24  David Kilzer  <ddkilzer@apple.com>

        Use xcrun to find compiler paths for Generate Derived Sources build phase script
        <http://webkit.org/b/79512>

        Reviewed by Dan Bernstein.

        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
        (Generate Derived Sources): Use xcrun to find the path to the
        compiler since that works on both iOS and OS X.

12
13
14
15
16
17
18
19
20
2012-02-24  James Robinson  <jamesr@chromium.org>

        Create a watchlist for ScrollingCoordinator changes
        https://bugs.webkit.org/show_bug.cgi?id=79511

        Reviewed by Anders Carlsson.

        * Scripts/webkitpy/common/config/watchlist:

21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>

        [EFL][DRT] Implement setValueForUser and setAutofilled.
        https://bugs.webkit.org/show_bug.cgi?id=79237

        Reviewed by Andreas Kling.

        Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
        Those implementations are related with input fields and allow to pass following tests:
        fast/forms/onchange-setvalueforuser.html
        fast/forms/input-autofilled.html
        fast/forms/reset-autofilled.html

        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
        (LayoutTestController::setValueForUser):
        (LayoutTestController::setAutofilled):

38
39
40
41
42
43
44
45
46
47
48
2012-02-24  Zoltan Horvath  <zoltan@webkit.org>

        [Qt] Allow to use WebCore imagedecoders
        https://bugs.webkit.org/show_bug.cgi?id=32410

        Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.

        Reviewed by Simon Hausmann.

        * qmake/mkspecs/features/features.prf:

49
50
51
52
53
54
55
56
57
58
59
60
2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>

        [Qt] Add Qt5 way to force 96 DPI for tests
        https://bugs.webkit.org/show_bug.cgi?id=79364

        Reviewed by Simon Hausmann.

        * DumpRenderTree/qt/main.cpp:
        (main):
        * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
        (WTR::activateFonts):

61
62
63
64
65
66
67
68
69
70
71
72
2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] MiniBrowser should reload the view then the reload button is clicked
        https://bugs.webkit.org/show_bug.cgi?id=79472

        Reviewed by Philippe Normand.

        * MiniBrowser/gtk/BrowserWindow.c:
        (reloadCallback): Call webkit_web_view_reload().
        (browser_window_init): Connect reload item clicked even to
        reloadCallback instead of activateUriEntryCallback.

73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
2012-02-24  Kentaro Hara  <haraken@chromium.org>

        Add performance tests for DOM attribute getters and setters
        https://bugs.webkit.org/show_bug.cgi?id=79208

        Reviewed by Ryosuke Niwa.

        We want to allow perf tests to output info messages
        that do not affect the test results. To accomplish this,
        this patch modifies perftestsrunner.py so that it ignores
        a line that starts from "Info:".

        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
        (PerfTestsRunner):

88
89
90
91
92
93
94
95
96
97
98
2012-02-24  Andrew Lo  <anlo@rim.com>

        [BlackBerry] Enable requestAnimationFrame
        https://bugs.webkit.org/show_bug.cgi?id=79408

        Enable requestAnimationFrame for BlackBerry.

        Reviewed by Rob Buis.

        * Scripts/build-webkit:

99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
2012-02-24  Adam Barth  <abarth@webkit.org>

        style-queue tries to apply the patch twice
        https://bugs.webkit.org/show_bug.cgi?id=79459

        Reviewed by Eric Seidel.

        Previously, we applied the patch using both apply-patch and
        check-style.  This patch introduces a check-style-local to mirror the
        apply-watchlist-local, which operates on the current working diff.

        This patch also cleans up some other bugs I found by running the queue
        locally for a while.  The queue still prints out a slightly
        less-than-ideal message on the bugs when it find an error, but it's ok
        for now.  We'll need to iterate a bit.

        * Scripts/webkitpy/tool/bot/stylequeuetask.py:
        (StyleQueueTask.validate):
        (StyleQueueTask._check_style):
        * Scripts/webkitpy/tool/commands/download.py:
        (CheckStyleLocal):
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        (EarlyWarningSytemTest._default_expected_stderr):
        (EarlyWarningSytemTest._test_testing_ews):
        * Scripts/webkitpy/tool/commands/queues.py:
        (AbstractReviewQueue.handle_script_error):
        (StyleQueue.review_patch):
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/commands/queuestest.py:
        (QueuesTest.assert_queue_outputs):

130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
2012-02-23  Adam Barth  <abarth@webkit.org>

        should_proceed_with_work_item is unused and can be removed
        https://bugs.webkit.org/show_bug.cgi?id=79416

        Reviewed by Eric Seidel.

        We used to use this function to check whether the tree is red.  Now, we
        don't use external measures of whether to proceed with work items.
        Instead, we analyze them with the idea in mind that the tree might be
        red.

        * Scripts/webkitpy/tool/bot/queueengine.py:
        (QueueEngineDelegate.next_work_item):
        (QueueEngine.run):
        * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
        (LoggingDelegate):
        (LoggingDelegate.next_work_item):
        (RaisingDelegate.process_work_item):
        (QueueEngineTest.test_terminating_error):
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (AbstractEarlyWarningSystem.__init__):
        * Scripts/webkitpy/tool/commands/queues.py:
        (AbstractQueue.next_work_item):
        (FeederQueue.next_work_item):
        (CommitQueue.next_work_item):
        (AbstractReviewQueue.next_work_item):
        (StyleQueue.__init__):
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        (FeederQueueTest.test_feeder_queue):
        (CommitQueueTest.test_commit_queue):
        (test_commit_queue_failure):
        (test_commit_queue_failure_with_failing_tests):
        (test_rollout):
        (test_rollout_lands):
        (StyleQueueTest.test_style_queue_with_style_exception):
        (test_style_queue_with_watch_list_exception):
        * Scripts/webkitpy/tool/commands/queuestest.py:
        (QueuesTest.assert_queue_outputs):
        * Scripts/webkitpy/tool/commands/sheriffbot.py:
        (SheriffBot.next_work_item):

172
173
174
175
176
177
2012-02-23  Adrienne Walker  <enne@google.com>

        Unreviewed, add Stephen Chenney to committers.py as a contributor.

        * Scripts/webkitpy/common/config/committers.py:

178
179
180
181
182
183
184
185
186
187
188
189
190
191
2012-02-23  Adam Barth  <abarth@webkit.org>

        style-queue logs bogus messages to the QueueStatusServer
        https://bugs.webkit.org/show_bug.cgi?id=79424

        Reviewed by Eric Seidel.

        Copy/paste error.

        * Scripts/webkitpy/tool/bot/stylequeuetask.py:
        (StyleQueueTask._check_style):
        (StyleQueueTask._apply_watch_list):
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
2012-02-23  Eric Seidel  <eric@webkit.org>

        Use self._filesystem in more places in the SCM classes
        https://bugs.webkit.org/show_bug.cgi?id=79415

        Reviewed by Adam Barth.

        * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
        (SCMDetectorTest.test_detect_scm_system):
        * Scripts/webkitpy/common/checkout/scm/git.py:
        (Git.find_checkout_root):
        (Git.to_object_name):
        * Scripts/webkitpy/common/checkout/scm/scm.py:
        (SCM.__init__):
        (SCM.in_working_directory):
        * Scripts/webkitpy/common/checkout/scm/svn.py:
        (SVN.find_uuid):
        (SVN.find_checkout_root):

211
212
213
214
215
216
217
218
219
220
2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r108685.
        http://trac.webkit.org/changeset/108685
        https://bugs.webkit.org/show_bug.cgi?id=79414

        Broke Chromium builds (Requested by enne on #webkit).

        * qmake/mkspecs/features/features.prf:

221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
2012-02-23  Adam Barth  <abarth@webkit.org>

        style-queue shouldn't spam bugs if it fails to update its working copy
        https://bugs.webkit.org/show_bug.cgi?id=79412

        Reviewed by Eric Seidel.

        This patch moves style-queue over to the new PatchAnalysisTask
        infrastructure, which is smarter about retrying patches when update
        fails.

        * Scripts/webkitpy/common/system/executive_mock.py:
        (MockExecutive.run_and_throw_if_fail):
        * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
        * Scripts/webkitpy/tool/bot/patchanalysistask.py:
        (UnableToApplyPatch):
        (UnableToApplyPatch.__init__):
        (PatchAnalysisTask.__init__):
        * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
        (StyleQueueTaskDelegate):
        (StyleQueueTaskDelegate.parent_command):
        (StyleQueueTask):
        (StyleQueueTask.validate):
        (StyleQueueTask._check_style):
        (StyleQueueTask._apply_watch_list):
        (StyleQueueTask.run):
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        (StyleQueue):
        (StyleQueue.should_proceed_with_work_item):
        (StyleQueue.review_patch):
        (StyleQueue.run_command):
        (StyleQueue.command_passed):
        (StyleQueue.command_failed):
        (StyleQueue.expected_failures):
        (StyleQueue.refetch_patch):
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        (StyleQueueTest.test_style_queue_with_style_exception):
        (test_style_queue_with_watch_list_exception):

261
262
263
264
265
266
267
268
269
270
271
2012-02-23  Zoltan Horvath  <zoltan@webkit.org>

        [Qt] Allow to use WebCore imagedecoders
        https://bugs.webkit.org/show_bug.cgi?id=32410

        Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.

        Reviewed by Simon Hausmann.

        * qmake/mkspecs/features/features.prf:

272
273
274
275
276
277
278
279
280
281
282
283
284
2012-02-23  Eric Seidel  <eric@webkit.org>

        Remove old broken find_checkout_root tests now that find_checkout_root is gone
        https://bugs.webkit.org/show_bug.cgi?id=79405

        Reviewed by Adam Barth.

        * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
        (SCMDetectorTest):
        (SCMDetectorTest.test_find_checkout_root):
        * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
        (SVNTestRepository.tear_down):

285
286
287
288
289
290
291
292
293
294
295
2012-02-23  Michael Brüning  <michael.bruning@nokia.com>

        [Qt][WK2] Implement proxy authentication dialog.
        https://bugs.webkit.org/show_bug.cgi?id=79350

        Reviewed by Simon Hausmann.

        * MiniBrowser/qt/MiniBrowser.qrc:
        * MiniBrowser/qt/qml/BrowserWindow.qml:
        * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.

296
297
298
299
300
301
2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>

        [wx] Build fix, add recently added source dirs.

        * waf/build/settings.py:

302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Add support for touch cancellation
        https://bugs.webkit.org/show_bug.cgi?id=79348

        Reviewed by Kenneth Rohde Christiansen.

        Added straight-forward touch cancellation event sending to Qt WK1 DRT
        and WK2 WTR.

        * DumpRenderTree/qt/EventSenderQt.cpp:
        (EventSender::touchCancel):
        (EventSender::cancelTouchPoint):
        * DumpRenderTree/qt/EventSenderQt.h:
        (EventSender):
        * WebKitTestRunner/EventSenderProxy.h:
        (EventSenderProxy):
        * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
        * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
        (WTR::EventSendingController::touchCancel):
        (WTR):
        (WTR::EventSendingController::cancelTouchPoint):
        * WebKitTestRunner/InjectedBundle/EventSendingController.h:
        (EventSendingController):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
        * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
        (WTR::EventSenderProxy::touchCancel):
        (WTR):
        (WTR::EventSenderProxy::cancelTouchPoint):

333
334
335
336
337
338
339
340
341
342
343
344
345
2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r108626.
        http://trac.webkit.org/changeset/108626
        https://bugs.webkit.org/show_bug.cgi?id=79370

        broke qt-wk2 bot, somehow the workaround does not work on the
        bot (Requested by Ossy on #webkit).

        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
        (WTR::WrapperWindow::handleStatusChanged):
        (WTR::PlatformWebView::resizeTo):

346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>

        [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
        https://bugs.webkit.org/show_bug.cgi?id=78481

        Reviewed by Gustavo Noronha Silva.

        Extracted shareable code from keyDownCallback and then added createKeyPressEvent
        to create gdk press key event.
        Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
        and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.

        * DumpRenderTree/gtk/EventSender.cpp:
        (scheduleAsynchronousClickCallback):
        (createKeyPressEvent):
        (sendKeyDown):
        (keyDownCallback):
        (sendAsynchronousKeyDown):
        (scheduleAsynchronousKeyDownCallback):

366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>

        [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
        https://bugs.webkit.org/show_bug.cgi?id=76546

        Reviewed by Simon Hausmann.

        Co-authored with Simon Hausmann.

        Revert the workaround introduced in r107868 and reintroduce
        the qml binding so we can test the code path that we are more
        interested in. The reason that it did not work before is that
        we don't have an active platform window which we now workaround
        by propagating the resize through QWindowSystemInterface.

        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
        (WTR::WrapperWindow::handleStatusChanged):
        (WTR::PlatformWebView::resizeTo):

385
386
387
388
389
390
391
392
393
394
395
396
397
2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r108577.
        http://trac.webkit.org/changeset/108577
        https://bugs.webkit.org/show_bug.cgi?id=79359

        It doesn't work as expected (Requested by Ossy on #webkit).

        * DumpRenderTree/qt/EventSenderQt.cpp:
        (EventSender::postEvent):
        * DumpRenderTree/qt/EventSenderQt.h:
        (EventSender):

philn@webkit.org's avatar
philn@webkit.org committed
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
2012-02-23  Philippe Normand  <pnormand@igalia.com>

        [GTK] FullScreen signals
        https://bugs.webkit.org/show_bug.cgi?id=76181

        Reviewed by Martin Robinson.

        Use the two new entering/leaving fullscreen signals to hide/show
        the tool bar, the status bar and ask the user's permission before
        entering fullscreen.

        * GtkLauncher/main.c:
        (webViewFullscreenMessageWindowClose):
        (webViewWindowStateEvent):
        (hide_widget):
        (show_widget):
        (webViewEnteringFullScreen):
        (webViewLeavingFullScreen):
        (createBrowser):
        (createWindow):

419
420
421
422
423
424
425
426
427
428
2012-02-22  Dongwoo Im  <dw.im@samsung.com>

        [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
        https://bugs.webkit.org/show_bug.cgi?id=79076

        Reviewed by Andreas Kling.

        * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
        (builtDylibPathForName):

429
430
431
432
433
434
435
436
437
438
439
2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>

        [Qt] Add eventSender.gestureTap
        https://bugs.webkit.org/show_bug.cgi?id=66173

        Reviewed by Kenneth Rohde Christiansen.

        * DumpRenderTree/qt/EventSenderQt.cpp:
        (EventSender::gestureTap):
        * DumpRenderTree/qt/EventSenderQt.h:

440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
2012-02-22  Brady Eidson  <beidson@apple.com>

        <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
        Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs

        Reviewed by Anders Carlsson.

        Update our tools to the new form of the PageLoadClient.

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]): 

        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::initialize):

455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
2012-02-22  Daniel Bates  <dbates@webkit.org>

        new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
        https://bugs.webkit.org/show_bug.cgi?id=79277

        Reviewed by Adam Barth.

        Pass command line argument no-saved-state to run-safari to disable Safari
        state restoration for the session on OS 10.7.

        * Scripts/webkitpy/layout_tests/port/mac.py:
        (MacPort.show_results_html_file):
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        (test_show_results_html_file):

470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
2012-02-22  Kalev Lember  <kalevlember@gmail.com>

        Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
        https://bugs.webkit.org/show_bug.cgi?id=77759

        Reviewed by Tony Chang.

        Fixes build with gcc 4.7.

        r100432 added the include only for ANDROID; this changes the ifdef to
        also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
        longer implicitly includes unistd.h from standard headers and other
        unix platforms are likely to get gcc 4.7 as well in the future.

        * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

486
487
488
489
490
491
492
493
494
495
496
497
2012-02-22  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, rolling out r108522.
        http://trac.webkit.org/changeset/108522
        https://bugs.webkit.org/show_bug.cgi?id=76181

        Broke 4 fullscreen tests on GTK.

        * GtkLauncher/main.c:
        (createBrowser):
        (createWindow):

philn@webkit.org's avatar
philn@webkit.org committed
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
2012-02-20  Philippe Normand  <pnormand@igalia.com>

        [GTK] FullScreen signals
        https://bugs.webkit.org/show_bug.cgi?id=76181

        Reviewed by Martin Robinson.

        Use the two new entering/leaving fullscreen signals to hide/show
        the tool bar, the status bar and ask the user's permission before
        entering fullscreen.

        * GtkLauncher/main.c:
        (webViewFullscreenMessageWindowClose):
        (webViewWindowStateEvent):
        (hide_widget):
        (show_widget):
        (webViewEnteringFullScreen):
        (webViewLeavingFullScreen):
        (createBrowser):
        (createWindow):

519
520
521
522
523
524
525
526
527
2012-02-22  Rob Flack  <flackr@chromium.org>

        Update Linux ChromiumOS builders in flakiness dashboard.
        https://bugs.webkit.org/show_bug.cgi?id=79238

        Reviewed by Ojan Vafai.

        * TestResultServer/static-dashboards/builders.js:

528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
2012-02-22  Dirk Pranke  <dpranke@chromium.org>

        webkitpy: test_function_length_check_definition_huge_lines is slow
        https://bugs.webkit.org/show_bug.cgi?id=79185

        Reviewed by Adam Barth.

        This test takes ~3 seconds to run, apparently because we're
        running a test on a 10,000 line function :). Dropping the
        function length to 640 still exercises the code path and
        provides a 10x speedup.

        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (CppStyleTest):
        (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):

544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
2012-02-22  Dirk Pranke  <dpranke@chromium.org>

        webkitpy: speed up FileLockTest.test_lock_lifecycle
        https://bugs.webkit.org/show_bug.cgi?id=79189

        Reviewed by Adam Barth.

        The unit test had a second lock trying to acquire a
        lock already held, and a hard-coded timeout of one second.
        I have changed the timeouts to a tenth of a second (which
        is probably still fine) and changed the hard-spin on
        the lock to a slow-spin every hundredth of a second.

        * Scripts/webkitpy/common/system/file_lock.py:
        (FileLock.acquire_lock):
        * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
        (FileLockTest.setUp):
        (FileLockTest.test_stuck_lock):

563
564
565
566
567
568
569
570
571
572
573
2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>

        build-webkit should use environment variable at number of CPU
        detection on all platform
        https://bugs.webkit.org/show_bug.cgi?id=79227

        Reviewed by Martin Robinson.

        * Scripts/webkitdirs.pm:
        (determineNumberOfCPUs):

574
575
576
577
578
579
580
581
582
583
2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>

        [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
        https://bugs.webkit.org/show_bug.cgi?id=78960

        Reviewed by Csaba Osztrogonác.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::overridePreference):

584
585
586
587
588
589
590
591
592
593
594
595
596
597
2012-02-22  Hao Zheng  <zhenghao@chromium.org>

        [chromium] Build WebKit with MEDIA_STREAM disabled.
        https://bugs.webkit.org/show_bug.cgi?id=79214

        Reviewed by Kent Tamura.

        * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
        * DumpRenderTree/chromium/WebUserMediaClientMock.h:
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::createMediaPlayer):
        * DumpRenderTree/chromium/WebViewHost.h:
        (WebViewHost):

598
599
600
601
602
603
604
605
606
607
608
609
2012-02-22  Zeno Albisser  <zeno@webkit.org>

        [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
        https://bugs.webkit.org/show_bug.cgi?id=79124

        WebKitTestRunnerPrefix.h should also be included
        when building with clang.

        Reviewed by Kenneth Rohde Christiansen.

        * WebKitTestRunner/Target.pri:

610
611
612
613
614
615
616
617
618
619
620
621
2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>

        <style scoped>: Add runtime-flag
        https://bugs.webkit.org/show_bug.cgi?id=79074

        Enable the runtime-flag for DRT. 

        Reviewed by Dimitri Glazkov.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):

622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed, rolling out r107351.
        http://trac.webkit.org/changeset/107351
        https://bugs.webkit.org/show_bug.cgi?id=53600

        Several issues introduced in WebKitGTK+ API

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (createWebView):
        * GtkLauncher/main.c:
        (createWebViewCb):
        (createBrowser):
        (createWindow):
        (main):

638
639
640
641
642
643
644
645
646
647
648
649
2012-02-21  Filip Pizlo  <fpizlo@apple.com>

        JSC should be a triple-tier VM
        https://bugs.webkit.org/show_bug.cgi?id=75812
        <rdar://problem/10079694>

        Reviewed by Gavin Barraclough.

        Changed EFL's build system to include a new directory in JavaScriptCore.

        * DumpRenderTree/efl/CMakeLists.txt:

650
651
652
653
654
655
656
657
658
659
660
661
662
2012-02-21  Daniel Cheng  <dcheng@chromium.org>

        [chromium] Fix image drag out on Chromium
        https://bugs.webkit.org/show_bug.cgi?id=79158

        Reviewed by Tony Chang.

        * DumpRenderTree/chromium/EventSender.cpp:
        (EventSender::dumpFilenameBeingDragged):
        (EventSender::beginDragWithFiles):
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (addDRTFakeFileToDataObject):

663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
2012-02-21  Dirk Pranke  <dpranke@chromium.org>

        webkitpy: speed up hot filesystem_mock functions
        https://bugs.webkit.org/show_bug.cgi?id=79159

        Reviewed by Adam Barth.

        Profiling run_webkit_tests_integrationtest.py revealed that
        isdir(), normpath(), and join() are called a lot and were very
        slow.This patch speeds them up substantially, shaving 20 seconds
        off of the execution time.

        * Scripts/webkitpy/common/system/filesystem_mock.py:
        (MockFileSystem.isdir):
        (MockFileSystem._slow_but_correct_join):
        (MockFileSystem.join):
        (MockFileSystem.listdir):
        (MockFileSystem._slow_but_correct_normpath):
        (MockFileSystem.normpath):
        (MockFileSystem.write_binary_file):
        * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
        (MockFileSystemTest.quick_check):
        (MockFileSystemTest):
        (MockFileSystemTest.test_join):
        (MockFileSystemTest.test_normpath):
        * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
        (get_test_config): Call write_binary_file() instead of updating
          filesystem.files directly, so that we create directories as
          needed.

693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
2012-02-21  Dirk Pranke  <dpranke@chromium.org>

        nrwt: make the delay between starting workers configurable per-port
        https://bugs.webkit.org/show_bug.cgi?id=79148

        Reviewed by Eric Seidel.

        Because of bug 79147, we have to sleep a bit in between starting
        DRTs; however, doing so across the board slows down the Test
        port. Making this configurable shaves 10 seconds off of
        run_webkit_tests_integrationtest.py
        
        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager._run_tests):
        * Scripts/webkitpy/layout_tests/port/base.py:
        (Port.worker_startup_delay_secs):
        * Scripts/webkitpy/layout_tests/port/test.py:
        (TestPort.worker_startup_delay_secs):

712
713
714
715
716
717
718
719
720
721
722
723
2012-02-21  Jon Lee  <jonlee@apple.com>

        Bring notifications support to WK1 mac
        https://bugs.webkit.org/show_bug.cgi?id=78783
        <rdar://problem/10610578>

        Reviewed by Anders Carlsson.

        * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
        (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
        (-[UIDelegate timerFired]):

724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
2012-02-21  Kentaro Hara  <haraken@chromium.org>

        Enable the IDL attribute checker in run-bindings-tests
        https://bugs.webkit.org/show_bug.cgi?id=79091

        Reviewed by Adam Barth.

        We have enabled the IDL attribute checker in Chromium in r108322.
        This patch enables the IDL attribute checker in run-bindings-tests.

        No tests. I manually checked that [Custommm], [CallWith=],
        [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
        run-bindings-tests failures.

        * Scripts/webkitpy/bindings/main.py:
        (BindingsTests.generate_supplemental_dependency):

741
742
743
744
745
746
747
748
2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>

        Add rafaelw as a committer.

        Unreviewed.

        * Scripts/webkitpy/common/config/committers.py:

749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
2012-02-21  Dirk Pranke  <dpranke@chromium.org>

        webkitpy: update names after deleting message_broker
        https://bugs.webkit.org/show_bug.cgi?id=79000

        Reviewed by Eric Seidel.

        Part 3 of 3 in deleting message_broker.py; this change just
        adjusts the names for the newly merged symbols so that they are
        private as appropriate.

        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
        (get):
        (_Broker):
        (_BrokerConnection):
        (_BrokerConnection.__init__):
        (AbstractWorker.__init__):
        (_ManagerConnection):
        (_ManagerConnection.__init__):
        (_WorkerConnection):
        (_WorkerConnection.__init__):

771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
2012-02-21  Dirk Pranke  <dpranke@chromium.org>

        webkitpy: merge message_broker.py into manager_worker_broker.py
        https://bugs.webkit.org/show_bug.cgi?id=78999

        Reviewed by Tony Chang.

        This is pretty much a straight cut-and-paste of one file into
        another (broken up so that docstrings and imports are in the
        right place).

        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
        (BrokerClient):
        (BrokerClient.is_done):
        (BrokerClient.name):
        (Broker):
        (Broker.__init__):
        (Broker.add_topic):
        (Broker._get_queue_for_topic):
        (Broker.post_message):
        (Broker.run_message_loop):
        (Broker.run_all_pending):
        (Broker._run_loop):
        (Broker._dispatch_message):
        (_Message):
        (_Message.loads):
        (_Message.__init__):
        (_Message.dumps):
        (_Message.__repr__):
        (BrokerConnection):
        (BrokerConnection.__init__):
        (BrokerConnection.run_message_loop):
        (BrokerConnection.post_message):
        (BrokerConnection.raise_exception):
        * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.

807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
2012-02-21  Dirk Pranke  <dpranke@chromium.org>

        webkitpy: prepare to delete message_broker.py
        https://bugs.webkit.org/show_bug.cgi?id=78997

        Reviewed by Eric Seidel.

        This is part 1 of 3 changes to fix bug 78187. This change
        prepares the code for merging message_broker.py into
        manager_worker_broker.py; the tests in message_broker_unittest
        are merged into manager_worker_broker_unittest, the symbols
        needed by the tests are exported from manager_worker_broker.py,
        and manager_worker_broker itself is updated to refer to the
        symbols directly (without the module prefix).

        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
        (get):
        (AbstractWorker):
        (AbstractWorker.__init__):
        (_ManagerConnection):
        (_ManagerConnection.__init__):
        (_WorkerConnection):
        (_WorkerConnection.__init__):
        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
        (InterfaceTest.test_brokerclient_is_abstract):
        (InterfaceTest.test_brokerclient_is_abstract.methods):
        (MessageTest):
        (MessageTest.test__no_body):
        (MessageTest.test__body):
        * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.

838
839
840
841
842
843
844
845
846
2012-02-21  Sam Weinig  <sam@webkit.org>

        Attempt to fix the Snow Leopard build.

        * DumpRenderTree/mac/Configurations/Base.xcconfig:
        * MiniBrowser/Configurations/Base.xcconfig:
        * TestWebKitAPI/Configurations/Base.xcconfig:
        * WebKitTestRunner/Configurations/Base.xcconfig:

847
848
849
850
851
852
853
854
855
856
857
858
2012-02-21  Sam Weinig  <sam@webkit.org>

        Use libc++ when building with Clang on Mac
        https://bugs.webkit.org/show_bug.cgi?id=78981

        Reviewed by Dan Bernstein.

        * DumpRenderTree/mac/Configurations/Base.xcconfig:
        * MiniBrowser/Configurations/Base.xcconfig:
        * TestWebKitAPI/Configurations/Base.xcconfig:
        * WebKitTestRunner/Configurations/Base.xcconfig:

859
860
861
862
863
864
865
866
867
868
2012-02-21  Adam Roben  <aroben@apple.com>

        Roll out r108309, r108323, and r108326

        They broke the 32-bit Lion build.

        Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.

        * DumpRenderTree/efl/CMakeLists.txt:

869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
2012-02-21  Andras Becsi  <andras.becsi@nokia.com>

        [Qt][WK2] Get rid of the dependency to QtWidgets
        https://bugs.webkit.org/show_bug.cgi?id=76276

        Reviewed by Simon Hausmann.

        * MiniBrowser/qt/MiniBrowser.pro:
        * MiniBrowser/qt/MiniBrowserApplication.cpp:
        (MiniBrowserApplication::MiniBrowserApplication):
        (MiniBrowserApplication::notify):
        (MiniBrowserApplication::sendTouchEvent):
        * MiniBrowser/qt/MiniBrowserApplication.h:
        (MiniBrowserApplication):
        * QtTestBrowser/locationedit.h:
        * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
        (WTR::activateFonts):
        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:

888
889
890
891
892
893
894
895
896
897
898
899
900
901
2012-02-20  Adam Barth  <abarth@webkit.org>

        mastercfg_unittest.py fails without simplejson
        https://bugs.webkit.org/show_bug.cgi?id=79070

        Reviewed by Csaba Osztrogonác.

        Now that we require Python 2.6 (and higher) we can import json rather
        than simplejson.  We still need to use the simplejson name because
        that's what the master.cfg script expects.

        * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
        (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):

902
903
904
905
906
907
908
909
910
911
912
913
2012-02-20  Filip Pizlo  <fpizlo@apple.com>

        JSC should be a triple-tier VM
        https://bugs.webkit.org/show_bug.cgi?id=75812
        <rdar://problem/10079694>

        Reviewed by Gavin Barraclough.

        Changed EFL's build system to include a new directory in JavaScriptCore.

        * DumpRenderTree/efl/CMakeLists.txt:

914
915
916
917
918
919
920
921
922
923
924
925
2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>

        Update pywebsocket to 0.7.2
        https://bugs.webkit.org/show_bug.cgi?id=79066

        This version includes vendor-prefixed deflate-frame extension support.

        Reviewed by Kent Tamura.

        * Scripts/webkitpy/thirdparty/__init__.py:
        (AutoinstallImportHook._install_pywebsocket):

926
927
928
929
930
931
932
933
934
935
936
937
938
2012-02-20  Martin Robinson  <mrobinson@igalia.com>

        [UNIX] Plugin information fields are not interpreted as UTF-8
        https://bugs.webkit.org/show_bug.cgi?id=78635

        Reviewed by Gustavo Noronha Silva.

        Interpret plugin metadata as UTF8 aways. This matches the behavior
        of Chromium and the Totem plugin.

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.

939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
2012-02-20  Martin Robinson  <mrobinson@igalia.com>

        [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
        https://bugs.webkit.org/show_bug.cgi?id=78935

        Reviewed by Gustavo Noronha Silva.

        Move the TestNetscapePlugin headers to a more appropriate directory and update
        the build files to match.

        * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
        * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
        * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
        * GNUmakefile.am: Ditto.

955
956
957
958
959
960
961
962
963
2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>

        Add a new API for the Vibration API(W3C).
        https://bugs.webkit.org/show_bug.cgi?id=72010

        Reviewed by Hajime Morita.

        * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.

964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
2012-02-20  János Badics  <dicska@gmail.com>

        [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
        https://bugs.webkit.org/show_bug.cgi?id=71816

        RunQtAPITests will notify if a timeout occurs during testing.
        Added unittest to the master.cfg

        Reviewed by Csaba Osztrogonác.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (RunQtAPITests.evaluateCommand):
        * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
        (RunQtAPITestsTest):
        (RunQtAPITestsTest.assertResults):
        (RunQtAPITestsTest.test_timeout):
        (test_success):
        (test_failure):
        (test_timeout_and_failure):

wingo@igalia.com's avatar
wingo@igalia.com committed
984
985
986
987
988
989
990
991
992
2012-02-20  Andy Wingo  <wingo@igalia.com>

        Add wingo as a committer.

        Unreviewed.

        * Scripts/webkitpy/common/config/committers.py: Add myself to the
        committers list.

993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
2012-02-20  Jochen Eisinger  <jochen@chromium.org>

        [chromium] check that we're not running multiple modal dialogs at the same time
        https://bugs.webkit.org/show_bug.cgi?id=78486

        Reviewed by Kent Tamura.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell::setIsDisplayingModalDialog):
        (TestShell::isDisplayingModalDialog):
        (TestShell):
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::runModal):

1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
2012-02-20  Martin Robinson  <mrobinson@igalia.com>

        Fix WebKit2GTK+ for 'make distcheck'.

        Instead of conditionally including WebKit2 GNUmakefiles, always
        include them and conditionally activate the final targets.

        * MiniBrowser/gtk/GNUmakefile.am:
        * WebKitTestRunner/GNUmakefile.am:

1019
1020
1021
1022
1023
1024
1025
1026
1027
2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Enable video option for EFL port in build-webkit.
        https://bugs.webkit.org/show_bug.cgi?id=79006

        Reviewed by Daniel Bates.

        * Scripts/build-webkit:

1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>

        [EFL] Use modifier keys to execute pre-rendering.
        https://bugs.webkit.org/show_bug.cgi?id=77933

        Reviewed by Chang Shu.

        Use modifier key to execute pre-rendering instead of using reserved function keys.

        * EWebLauncher/main.c:
        (on_key_down):

1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
2012-02-18  Dirk Pranke  <dpranke@chromium.org>

        Fix one more dangling reference to worker_connection.name, delete unused code.

        Unreviewed, build fix.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager.update):
        (_WorkerState.__init__):

1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
2012-02-18  Dirk Pranke  <dpranke@chromium.org>

        Add a change that should've been in r108005.

        Unreviewed, build fix.

        In the refactoring/cleanup in r108005 I should've changed the
        implementation of WorkerConnection to make it match BrokerClient
        (and everything else) so that objects had a name() method
        instead of a name property.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager._run_tests):
        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
        (_WorkerConnection.__init__):
        (_WorkerConnection.name):
        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
        (_TestWorker.__init__):
        (_TestsMixin.name):
        (_TestsMixin.test_name):
        (_TestsMixin.test_cancel):
        (_TestsMixin.test_unknown_message):

1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
2012-02-18  Dirk Pranke  <dpranke@chromium.org>

        webkitpy: remove webkitpy.common.array_stream
        https://bugs.webkit.org/show_bug.cgi?id=78952

        Reviewed by Eric Seidel.

        Turns out array_stream didn't really do anything that StringIO
        didn't do (at least as of Python 2.6). This change removes it
        and updates all of the callers. Where possible, I changed the
        test assertions in order to capture the intent more clearly,
        e.g., instead of calling self.assertTrue('foo' in stream.get()),
        we have self.assertContainsLine(stream, 'foo'), and instead of
        self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
        the latter isn't that much more readable, but StringIO doesn't
        export an empty() method.

        * Scripts/webkitpy/common/array_stream.py: Removed.
        * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
        (passing_run):
        (run_and_capture):
        (StreamTestingMixin):
        (StreamTestingMixin.assertContains):
        (StreamTestingMixin.assertContainsLine):
        (StreamTestingMixin.assertEmpty):
        (StreamTestingMixin.assertNotEmpty):
        (LintTest):
        (LintTest.test_lint_test_files):
        (LintTest.test_lint_test_files__errors):
        (MainTest):
        (MainTest.test_child_process_1):
        (MainTest.test_child_processes_2):
        (MainTest.test_child_processes_min):
        (MainTest.test_help_printing):
        (MainTest.test_hung_thread):
        (MainTest.test_no_tests_found):
        (MainTest.test_no_tests_found_2):
        (MainTest.test_repeat_each_iterations_num_tests):
        (MainTest.test_test_list):
        (MainTest.test_unexpected_failures):
        (MainTest.test_worker_model__inline_with_child_processes):
        (MainTest.test_additional_platform_directory):
        (RebaselineTest):
        (RebaselineTest.assertBaselines):
        (RebaselineTest.test_reset_results):
        (RebaselineTest.test_missing_results):
        (RebaselineTest.test_new_baseline):
        * Scripts/webkitpy/layout_tests/views/metered_stream.py:
        (MeteredStream.update):
        * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
        (TestMeteredStream.test_regular):
        * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
        (TestUtilityFunctions.assertEmpty):
        (TestUtilityFunctions):
        (TestUtilityFunctions.assertNotEmpty):
        (TestUtilityFunctions.assertWritten):
        (TestUtilityFunctions.test_configure_logging):
        (Testprinter.assertEmpty):
        (Testprinter):
        (Testprinter.assertNotEmpty):
        (Testprinter.assertWritten):
        (Testprinter.reset):
        (Testprinter.get_printer):
        (Testprinter.test_help_printer):
        (Testprinter.do_switch_tests.do_helper):
        (Testprinter.test_print_one_line_summary):
        (Testprinter.test_print_test_result):
        (Testprinter.test_print_progress):
        (Testprinter.test_write_nothing):
        (Testprinter.test_write_misc):
        (Testprinter.test_write_everything):
        (Testprinter.test_write_verbose):
        (Testprinter.test_print_unexpected_results):
        * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
        (MainTest.assertWritten):
        (create_runner):
        (test_run_test_set):
        (test_run_test_set_kills_drt_per_run):
        (test_run_test_set_for_parser_tests):
        (test_run_test_set_with_json_output):
        (test_run_test_set_with_json_source):
        (test_run_test_set_with_multiple_repositories):
        (test_upload_json):

1158
1159
1160
1161
1162
1163
2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>

        [wx] Add the WebCore/page/scrolling directory to the build dirs.

        * waf/build/settings.py:

1164
1165
1166
1167
1168
1169
1170
1171
2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>

        [wx] Unreviewed build fix. Don't error out or hang if we have
        downloaded dependencies but server update check fails.

        * waf/build/build_utils.py:
        (download_if_newer):

1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
2012-02-17  Dirk Pranke  <dpranke@chromium.org>

        The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
        https://bugs.webkit.org/show_bug.cgi?id=69444

        Reviewed by Tony Chang.

        Currently if a test's image checksum doesn't match the checksum
        in the baseline, but the images themselves match according to
        ImageDiff, new-run-webkit-tests ignores the problem. This is
        probably bad, but it's not yet clear what the right thing to do
        is. This patch will log a warning to stderr, at least (but the
        test will still pass).

        * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
        (SingleTestRunner._compare_image):
        (SingleTestRunner._run_reftest):
        * Scripts/webkitpy/layout_tests/port/test.py:
        (unit_test_list):
        * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
2012-02-17  Dirk Pranke  <dpranke@chromium.org>

        NRWT does not report failure for a skipped test
        https://bugs.webkit.org/show_bug.cgi?id=78750

        Reviewed by Eric Seidel.

        If a test is listed in a Skipped file and you run it anyway
        with --force, and the test fails, currently NRWT will print
        "test ran as expected"; this is confusing, because you probably
        expect the test to fail and yet this might lead you to think the
        test passed. This patch changes the expected behavior to "PASS",
        so tests that fail will be reported.

        * Scripts/webkitpy/layout_tests/models/test_expectations.py:
        (result_was_expected):
        (TestExpectationParser):
        (TestExpectationParser.expectation_for_skipped_test):
        (TestExpectations):
        * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
        (test_add_skipped_tests):
        * Scripts/webkitpy/layout_tests/port/test.py:
        (unit_test_list): Add some tests that are expected to be in a Skipped file.
        (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.

1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
2012-02-17  Dirk Pranke  <dpranke@chromium.org>

        webkitpy: fix test code after bug 78181
        https://bugs.webkit.org/show_bug.cgi?id=78870

        Reviewed by Adam Barth.

        I forgot to update the test code as per Tony's suggestion in
        bug 78181 (r108005). This change does that, and in doing so
        it revealed a subtle bug in _InlineWorkerConnection.run() that
        I am fixing as part of this (_alive would not be cleared if an
        exception was thrown).

        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
        (_InlineWorkerConnection.run):
        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
        (_TestWorker.__init__):
        (_TestWorker.handle_stop):
        (_TestWorker.handle_test):
        (_TestWorker.run):
        (_TestsMixin.handle_exception):
        (_TestsMixin.test_unknown_message):

1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
2012-02-17  Adam Roben  <aroben@apple.com>

        Mac build fix after r108119

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (runThread):
        (runPthread):
        (testThreadIdentifierMap):
        Updated to match current WTF threading APIs.

1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
2012-02-17  Dirk Pranke  <dpranke@chromium.org>

        revert r107147 - breaks webkit-patch on Mac SL
        https://bugs.webkit.org/show_bug.cgi?id=78866

        Reviewed by Adam Barth.

        It appears that zipfile.ExtractAll is broken on Python 2.6.1,
        which is the version that ships on Mac SL. Reverting this
        change until we no longer have to worry about that version.

        * Scripts/webkitpy/common/system/autoinstall.py:
        (AutoInstaller):
        (AutoInstaller._extract_all): Added a comment about SL.
        (AutoInstaller._unzip):

1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>

        CSS regions enabled by default
        https://bugs.webkit.org/show_bug.cgi?id=78525

        Reviewed by David Hyatt.

        Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
        CSSRegions are still enabled by default.
        In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::overridePreference):
        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::reset):
        (WebPreferences::applyTo):
        * DumpRenderTree/chromium/WebPreferences.h:
        (WebPreferences):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):

1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
2012-02-17  Maciej Stachowiak  <mjs@apple.com>

        Some API tests erroneously use = instead of == (causing build failures)
        https://bugs.webkit.org/show_bug.cgi?id=78915

        Reviewed by Sam Weinig.

        * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
        (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
        (TestWebKitAPI::decidePolicyForNewWindowAction): ditto

1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
2012-02-17  Peter Beverloo  <peter@chromium.org>

        [Chromium] Include TestShellLinux.cpp in the build for Android
        https://bugs.webkit.org/show_bug.cgi?id=78865

        Reviewed by Eric Seidel.

        Android will be re-using the TestShellLinux.cpp file. I already
        added this r104033, but it seems to have gotten lost in the
        recent refactorings.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

1312
1313
1314
1315
1316
1317
1318
2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed, disable video build on EFL until it can be
        supported by EFL build bot.

        * Scripts/build-webkit:

1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Implement zoom in/out in MiniBrowser
        https://bugs.webkit.org/show_bug.cgi?id=75253

        Reviewed by Gustavo Noronha Silva.

        * MiniBrowser/gtk/BrowserWindow.c:
        (browserWindowCanZoomIn):
        (browserWindowCanZoomOut):
        (browserWindowUpdateZoomActions):
        (webViewZoomLevelChanged):
        (zoomInCallback):
        (zoomOutCallback):
        (browser_window_init):
        (browserWindowConstructed):

1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>

        layoutTestController.display() is flaky for SVG tests
        https://bugs.webkit.org/show_bug.cgi?id=78021

        Reviewed by Adam Roben.

        Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
        Size the web view before running the test, not when dumping.
        All platforms handle this correctly now.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (dump):
        (sizeWebViewForCurrentTest):
        (runTest):

1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Make install is broken when building without --enable-gtk-doc
        https://bugs.webkit.org/show_bug.cgi?id=78828

        Reviewed by Martin Robinson.

        * gtk/generate-gtkdoc:
        (rebase_installed_docs): Check documentation has been generated
        before trying to rebase it.

1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
2012-02-16  Dirk Pranke  <dpranke@chromium.org>

        nrwt: simplify worker interface
        https://bugs.webkit.org/show_bug.cgi?id=78181

        Reviewed by Tony Chang.

        This change moves code in name(), is_done(), run(), and cancel()
        from Worker to AbstractWorker, since the logic is pretty much
        boilerplate code that any implementation would want to use.

        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
        (get.should):
        (AbstractWorker.__init__):
        (AbstractWorker):
        (AbstractWorker.name):
        (AbstractWorker.stop_handling_messages):
        (AbstractWorker.run):
        (AbstractWorker.is_done):
        (AbstractWorker.cancel):
        * Scripts/webkitpy/layout_tests/controllers/worker.py:
        (Worker.__init__):
        (Worker.run):
        (Worker.handle_stop):

1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
2012-02-16  Michael Saboff  <msaboff@apple.com>

        ENH: Add ability to run subset of JavaScript layout tests with JSC
        https://bugs.webkit.org/show_bug.cgi?id=78764

        Reviewed by Gavin Barraclough.

        New simple test drive shell script that runs a defined
        list of javascript tests using jsc and the standalone-{pre,post}.js
        wrappers.

        * Scripts/run-fast-jsc: Added.

1401
1402
1403
1404
1405
1406
1407
1408
1409
2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>

        Add new Qt performance tester bot to build.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=78795

        Reviewed by Adam Roben.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

1410
1411
1412
1413
1414
1415
1416
1417
2012-02-16  Patrick Gansterer  <paroga@webkit.org>

        Disable inspector on WinCE.

        Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.

        * Scripts/build-webkit:

1418
1419
1420
1421
1422
1423
1424
1425
2012-02-16  Patrick Gansterer  <paroga@webkit.org>

        WinCE build fix after r107656.

        Disable FTPDIR on WinCE, since it does not compile there.

        * Scripts/build-webkit:

1426
1427
1428
1429
1430
1431
2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>

        Build fix after r107863.

        * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:

1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
2012-02-15  Tony Chang  <tony@chromium.org>

        [chromium] add linux dbg back to garden-o-matic
        https://bugs.webkit.org/show_bug.cgi?id=78752

        Reviewed by Adam Barth.

        This reflects the current linux debug bot name (there's only one bot).
        I'm also remove the mac clang builder since it doesn't exist (mac
        always uses clang now).

        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
        * Scripts/webkitpy/layout_tests/port/builders.py:

1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
2012-02-15  Sam Weinig  <sam@webkit.org>

        Add style check for ctype functions that are generally frowned upon in WebKit
        https://bugs.webkit.org/show_bug.cgi?id=78748

        Reviewed by Anders Carlsson.

        Not every platform has DisallowCType.h to check for uses of the ctype.h
        functions, so add a style check for them as well.

        * Scripts/webkitpy/style/checkers/cpp.py:
        (check_ctype_functions):
        (check_style):
        (CppChecker):
        Add check.

        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (WebKitStyleTest.test_ctype_fucntion):
        Add checker.

1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>

        [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
        https://bugs.webkit.org/show_bug.cgi?id=76546

        Reviewed by Simon Hausmann.

        Resize the web view programatically because the declarative property binding
        does not work. Seems like our qml environment is not initialized fully but it
        needs more investigation.

        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
        (WTR::WrapperWindow::handleStatusChanged):
        (WTR::PlatformWebView::resizeTo):

1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
2012-02-15  Dirk Pranke  <dpranke@chromium.org>

        webkitpy: add a worker_args concept to start_worker()
        https://bugs.webkit.org/show_bug.cgi?id=78572

        Reviewed by Tony Chang.

        This change replaces the three NRWT-specific arguments passed
        through the broker to the worker with a generic WorkerArguments
        wrapper class and a separate set_inline_arguments() call that can
        be used to pass additional data to the worker when it is running
        in the same process as the manager (this is needed for testing).
        With the addition of set_inline_arguments() we also no longer
        need to pass an optional argument to the worker.run() call.

        Note that this method is *only* implemented on inline workers,
        so calling this on a regular (child process) worker will result
        in a runtime error.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager._run_tests):
        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
        (AbstractWorker.__init__):
        (AbstractWorker.run):
        (_ManagerConnection.start_worker):
        (_InlineManager.start_worker):
        (_InlineManager.set_inline_arguments):
        (_InlineManager.run_message_loop):
        (_MultiProcessManager.start_worker): Reworked signature.
        (_WorkerConnection.__init__):
        (_InlineWorkerConnection.__init__):
        (_InlineWorkerConnection.set_inline_arguments): New method.
        (_InlineWorkerConnection):
        (_InlineWorkerConnection.run):
        (_Process.run):
        (_MultiProcessWorkerConnection.__init__):
        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
        (_TestWorker.__init__):
        (_TestWorker.set_inline_arguments):
        (_TestWorker.handle_test):
        (_TestWorker.run):
        (_TestsMixin.test_cancel):
        (_TestsMixin.test_done):
        (_TestsMixin.test_unknown_message):
        (InlineBrokerTests): New class for more testing.
        (InlineBrokerTests.setUp):
        (InlineBrokerTests.test_inline_arguments): New test.
        (InterfaceTest.test_managerconnection_is_abstract):
        (InterfaceTest.test_workerconnection_is_abstract):
        * Scripts/webkitpy/layout_tests/controllers/worker.py:
        (WorkerArguments):
        (WorkerArguments.__init__):
        (Worker.__init__):
        (Worker.set_inline_arguments):
        (Worker):
        (Worker.run):
        * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
        (WorkerTest.test_default_platform_in_worker):

1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
2012-02-15  Adam Klein  <adamk@chromium.org>

        Unreviewed, rolling out r107704.
        http://trac.webkit.org/changeset/107704
        https://bugs.webkit.org/show_bug.cgi?id=78486

        Caused layout test crashes in debug builds.

        Specific crashing tests:

        fast/events/show-modal-dialog-onblur-onfocus.html
        fast/harness/show-modal-dialog.html
        inspector/console/console-long-eval-crash.html

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell):
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::runModal):

1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
2012-02-15  Michael Brüning  <michael.bruning@nokia.com>

        [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
        https://bugs.webkit.org/show_bug.cgi?id=76347

        Reviewed by Kenneth Rohde Christiansen.

        * MiniBrowser/qt/MiniBrowser.qrc:
        * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added. 
        * MiniBrowser/qt/qml/BrowserWindow.qml:
        * MiniBrowser/qt/qml/DialogLineInput.qml:

1573
1574
1575
1576
1577
1578
1579
1580
1581
2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Fix WebGL in QtTestBrowser

        Reviewed by Tor Arne Vestbø.

        * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
        the options for enabling GL we also pass them on properly.

1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
2012-02-14  Sam Weinig  <sam@webkit.org>

        Add #include of unistd.h on the mac for getcwd. 

        Reviewed by Anders Carlsson.

        This is necessary when building with libc++.

        * WebKitTestRunner/TestInvocation.cpp:

1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
2012-02-14  Sam Weinig  <sam@webkit.org>

        In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
        https://bugs.webkit.org/show_bug.cgi?id=78663

        Reviewed by Anders Carlsson.

        * DumpRenderTree/DumpRenderTreePrefix.h:
        * DumpRenderTree/cg/ImageDiffCG.cpp:

1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
2012-02-14  Adam Barth  <abarth@webkit.org>

        Implement an adb-based driver for the ChromiumAndroidPort
        https://bugs.webkit.org/show_bug.cgi?id=78627

        Reviewed by Eric Seidel.

        This driver mostly just wires up the ChromiumDriver through adb.  In
        some cases, it translates protocol elements, such as URIs, so that the
        rest of webkitpy is insulated from the "remoteness" of the target device.

        * Scripts/webkitpy/layout_tests/port/chromium_android.py:
        (ChromiumAndroidPort.start_helper):
        (ChromiumAndroidPort._driver_class):
        (ChromiumAndroidPort._update_version):
        (ChromiumAndroidPort._get_stderr):
        (ChromiumAndroidPort):
        (ChromiumAndroidPort._get_last_stacktrace):
        (ChromiumAndroidPort._teardown_performance):
        (ChromiumAndroidDriver):
        (ChromiumAndroidDriver.__init__):
        (ChromiumAndroidDriver._start):
        (ChromiumAndroidDriver.run_test):
        (ChromiumAndroidDriver.stop):
        (ChromiumAndroidDriver._test_shell_command):
        (ChromiumAndroidDriver._write_command_and_read_line):
        (ChromiumAndroidDriver._output_image):
        (ChromiumAndroidDriver._has_crash_hint):

1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
2012-02-14  Dirk Pranke  <dpranke@chromium.org>

        webkitpy: the real_name() method in the Port class is no longer needed
        https://bugs.webkit.org/show_bug.cgi?id=78651

        Reviewed by Eric Seidel.

        The change in bug 78565 / r107718 made it no longer necessary
        (we can use options.platform instead).

        * Scripts/webkitpy/layout_tests/port/base.py:
        (Port.name):
        * Scripts/webkitpy/layout_tests/port/mock_drt.py:
        (MockDRTPort.__init__):

1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
2012-02-14  Dirk Pranke  <dpranke@chromium.org>

        webkitpy: clean up options, port handling in manager_worker_broker
        https://bugs.webkit.org/show_bug.cgi?id=78568

        Reviewed by Tony Chang.

        manager_worker_broker no longer needs options or port objects
        directly, so we make them only be passed in start_worker().

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager._run_tests):
        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
        (get):
        (_ManagerConnection.__init__):
        (_ManagerConnection.start_worker):
        (_InlineManager.__init__):
        (_InlineManager.start_worker):
        (_InlineManager.run_message_loop):
        (_MultiProcessManager.__init__):
        (_MultiProcessManager):
        (_MultiProcessManager.start_worker):
        (_InlineWorkerConnection.__init__):
        (_InlineWorkerConnection.run):
        (_Process.__init__):
        (_MultiProcessWorkerConnection.__init__):
        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
        (make_broker):
        (_TestWorker.run):
        (_TestsMixin.test_cancel):
        (_TestsMixin.test_done):
        (_TestsMixin.test_unknown_message):
        (MultiProcessBrokerTests.setUp):
        (InterfaceTest.test_managerconnection_is_abstract):
        * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
        (Broker.__init__):

1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
2012-02-14  Dirk Pranke  <dpranke@chromium.org>

        nrwt: add a unit test for regression introduced in bug 78565
        https://bugs.webkit.org/show_bug.cgi?id=78646

        Reviewed by Tony Chang.

        * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
        (FakeConnection):
        (FakeConnection.run_message_loop):
        (FakeConnection.post_message):
        (WorkerTest):
        (WorkerTest.test_default_platform_in_worker):

1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
2012-02-14  Dirk Pranke  <dpranke@chromium.org>

        NRWT is broken for the default port
        https://bugs.webkit.org/show_bug.cgi?id=78640
    
        Reviewed by Tony Chang.

        The change in r107718 (bug 78565) broke NRWT if you didn't
        specify any sort of --platform flag or equivalent. I didn't
        catch this because it's a full integration test (which we don't
        have an automated test for) and I missed this command line
        variant when testing interactively.

        * Scripts/webkitpy/layout_tests/controllers/worker.py:
        (Worker.run):

1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
2012-02-14  Ramya Chandrasekaran  <cramya@google.com>

        Last character display for passwords in Android.
        https://bugs.webkit.org/show_bug.cgi?id=78532

        Reviewed by Adam Barth.

        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::applyTo):

1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
2012-02-14  Adam Barth  <abarth@webkit.org>

        Finish implementing start_helper for ChromiumAndroidPort
        https://bugs.webkit.org/show_bug.cgi?id=78582

        Reviewed by Eric Seidel.

        This patch contains the remaining odds and ends for the start_helper function.

        * Scripts/webkitpy/layout_tests/port/chromium_android.py:
        (ChromiumAndroidPort.start_helper):
        (ChromiumAndroidPort._synchronize_datetime):
        (ChromiumAndroidPort):
        (ChromiumAndroidPort._check_version):
        (ChromiumAndroidPort._run_adb_command):
        (ChromiumAndroidPort._copy_device_file):

1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
2012-02-14  Dirk Pranke  <dpranke@chromium.org>

        webkitpy: create ports in Workers, not in manager_worker_broker
        https://bugs.webkit.org/show_bug.cgi?id=78565

        Reviewed by Tony Chang.

        We will now create the Port object (if necessary) in the Worker
        directly, so that the manager_worker_broker module doesn't need
        all of this layout_test-specific logic. Part of the fixes for
        bug 78171.

        These changes are all well-tested by the existing tests in
        run_webkit_tests_integrationtest.py.

        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
        (_Process.run):
        * Scripts/webkitpy/layout_tests/controllers/worker.py:
        (Worker.__init__):
        (Worker.safe_init):
        (Worker.run):
        (Worker.cleanup):
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        (parse_args):
        (main): Fix a minor bug where running the 'mock-test' port didn't work right.

1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
2012-02-14  Jochen Eisinger  <jochen@chromium.org>

        [chromium] check that we're not running multiple modal dialogs at the same time
        https://bugs.webkit.org/show_bug.cgi?id=78486

        Reviewed by Kent Tamura.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell::setIsDisplayingModalDialog):
        (TestShell::isDisplayingModalDialog):
        (TestShell):
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::runModal):

1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
2012-02-14  Adam Barth  <abarth@webkit.org>

        Enable the GPU codepath in the chromium-android port
        https://bugs.webkit.org/show_bug.cgi?id=78580

        Reviewed by James Robinson.

        Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
        Android always uses the GPU codepath, so we set the GPU flags on the
        main chromium-android port instead.

        * Scripts/webkitpy/layout_tests/port/chromium_android.py:
        (ChromiumAndroidPort.__init__):

1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
2012-02-14  Adam Barth  <abarth@webkit.org>

        NRWT should expose --adb-args flag for Android
        https://bugs.webkit.org/show_bug.cgi?id=78579

        Reviewed by Eric Seidel.

        This flag is already wired up to the ChromiumAndroidPort.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        (parse_args):

1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
2012-02-14  Alexey Proskuryakov  <ap@apple.com>

        [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
        https://bugs.webkit.org/show_bug.cgi?id=78541
        <rdar://problem/10036695>

        Reviewed by Kent Tamura.

        * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
        * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
        After each test, reset to using new protocol.

1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>

        Convert svg/animations to use SMIL methods for driving the timeline
        https://bugs.webkit.org/show_bug.cgi?id=78422

        Reviewed by Dirk Schulze.

        Remove no longer needed SVG specific animation sampling functionality from DRT.
        Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController):
        * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        * DumpRenderTree/chromium/LayoutTestController.h:
        (LayoutTestController):
        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        (LayoutTestController):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:

1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
2012-02-13  Rob Flack  <flackr@chromium.org>

        Add Linux ChromiumOS test results to flakiness dashboard.
        https://bugs.webkit.org/show_bug.cgi?id=78495

        Reviewed by Ojan Vafai.

        * TestResultServer/static-dashboards/builders.js:
        * TestResultServer/static-dashboards/dashboard_base.js:

1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>

        [GTK] Mutation Observers build is broken
        https://bugs.webkit.org/show_bug.cgi?id=78433

        Reviewed by Martin Robinson.

        Enabled mutation observers as a default feature for GTK port, too.

        * Scripts/build-webkit:

1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>

        Allow to configure ENABLE_FTPDIR in build-webkit
        https://bugs.webkit.org/show_bug.cgi?id=65098

        Reviewed by Eric Seidel.

        Allow to disable ENABLE_FTPDIR by command line.
        Remove ENABLE_FTPDIR from --minimal build

        * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
        * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
        as, for Qt platform, build-webkit does not add on command line what it thinks to be default values

1883
1884
1885
1886
1887
1888
1889
1890
2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>

        Add shinyak as committer.

        Unreviewed.

        * Scripts/webkitpy/common/config/committers.py:

1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
2012-02-13  Adam Barth  <abarth@webkit.org>

        Implement start/stop_helper for ChromiumAndroidPort
        https://bugs.webkit.org/show_bug.cgi?id=78558

        Reviewed by Dirk Pranke.

        These functions (and their dependencies) set up the Android device for
        testing.

        This patch also includes a few tweaks on the previous patch recommended
        by dpranke.

        * Scripts/webkitpy/layout_tests/port/chromium_android.py:
        (ChromiumAndroidPort.__init__):
        (ChromiumAndroidPort.start_helper):
        (ChromiumAndroidPort.stop_helper):
        (ChromiumAndroidPort._shut_down_http_server):
        (ChromiumAndroidPort):
        (ChromiumAndroidPort._push_executable):
        (ChromiumAndroidPort._push_fonts):
        (ChromiumAndroidPort._restore_system_font):
        (ChromiumAndroidPort._push_test_resources):
        (ChromiumAndroidPort._push_to_device):
        (ChromiumAndroidPort._pull_from_device):
        (ChromiumAndroidPort._kill_device_process):
        (ChromiumAndroidPort._setup_performance):
        (ChromiumAndroidPort._teardown_performance):
        * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
        (ChromiumAndroidPortTest):
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        (PortTestCase):
        (PortTestCase.make_port):
        (PortTestCase.test_default_worker_model):

1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
2012-02-13  Adam Barth  <abarth@webkit.org>

        Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
        https://bugs.webkit.org/show_bug.cgi?id=78550

        Reviewed by Eric Seidel.

        Much of this code just forwards to the "host" port, which seems like a
        reasonable thing to do.

        * Scripts/webkitpy/layout_tests/port/chromium_android.py:
        (ChromiumAndroidPort.__init__):
        (ChromiumAndroidPort.stop_helper):
        (ChromiumAndroidPort):
        (ChromiumAndroidPort._build_path):
        (ChromiumAndroidPort._path_to_apache):
        (ChromiumAndroidPort._path_to_apache_config_file):
        (ChromiumAndroidPort._path_to_driver):
        (ChromiumAndroidPort._path_to_helper):
        (ChromiumAndroidPort._path_to_image_diff):
        (ChromiumAndroidPort._path_to_lighttpd):
        (ChromiumAndroidPort._path_to_lighttpd_modules):
        (ChromiumAndroidPort._path_to_lighttpd_php):
        (ChromiumAndroidPort._path_to_wdiff):
        (ChromiumAndroidPort._shut_down_http_server):
        * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
        (ChromiumAndroidPortTest):
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        (PortTestCase):
        (PortTestCase.make_port):
        (PortTestCase.test_default_worker_model):

1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
2012-02-13  Adam Barth  <abarth@webkit.org>

        chromium_android.py should implement "virtual" methods from ChromiumPort
        https://bugs.webkit.org/show_bug.cgi?id=78545

        Reviewed by Dirk Pranke.

        This patch adds basic implementations that specialize a bunch of
        functions from ChromiumPort.

        * Scripts/webkitpy/layout_tests/port/chromium_android.py:
        (ChromiumAndroidPort):
        (ChromiumAndroidPort.__init__):
        (ChromiumAndroidPort.default_child_processes):
        (ChromiumAndroidPort.baseline_search_path):
        (ChromiumAndroidPort.check_build):
        (ChromiumAndroidPort.check_sys_deps):
        (ChromiumAndroidPort.default_worker_model):
        (ChromiumAndroidPort.test_expectations):
        (ChromiumAndroidPort.start_http_server):
        (ChromiumAndroidPort.stop_http_server):
        (ChromiumAndroidPort.start_helper):
        (ChromiumAndroidPort.stop_helper):

1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2012-02-13  Adam Barth  <abarth@webkit.org>

        Add a skeleton ChromiumAndroid port to webkitpy
        https://bugs.webkit.org/show_bug.cgi?id=78543

        Reviewed by Eric Seidel.

        This patch just adds an empty ChromiumAndroid port object to webkitpy
        and wires it up to the factory objects.  An actual implementation will
        follow.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        (ChromiumPort):
        * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
        (ChromiumAndroidPort):
        (ChromiumAndroidPort.__init__):
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        (ChromiumPortTest.test_all_test_configurations):
        * Scripts/webkitpy/layout_tests/port/factory.py:
        (PortFactory):

2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2012-02-13  Adam Barth  <abarth@webkit.org>

        NRWT's HTTP servers should support additional directories for resources
        https://bugs.webkit.org/show_bug.cgi?id=78528

        Reviewed by Eric Seidel.

        This functionality will be used by the Chromium-Android port.

        * Scripts/webkitpy/layout_tests/port/base.py:
        (Port.to.start_http_server):
        * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
        (LayoutTestApacheHttpd.__init__):
        * Scripts/webkitpy/layout_tests/servers/http_server.py:
        (Lighttpd.__init__):
        (Lighttpd._prepare_config):

2020
2021
2022
2023
2024
2025
2026
2027
2012-02-13  Ami Fischman  <fischman@chromium.org>

        Add fischman as committer.

        Unreviewed

        * Scripts/webkitpy/common/config/committers.py:

2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>

        [EFL] Drop support for the Curl network backend.
        https://bugs.webkit.org/show_bug.cgi?id=77874

        Reviewed by Eric Seidel.

        Nobody seems to be maintaining the Curl backend in WebCore, the
        EFL port developers all seem to be using the Soup backend and the
        port itself has many features which are only implemented for the
        latter.

        * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
        and always add the required include directories.
        * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
        include directories and link to them.

2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>

        [WebSocket] Update pywebsocket to 0.7.1
        https://bugs.webkit.org/show_bug.cgi?id=78484

        pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.

        Reviewed by Kent Tamura.

        * Scripts/webkitpy/thirdparty/__init__.py:
        (AutoinstallImportHook._install_pywebsocket):

2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2012-02-12  Kangil Han  <kangil.han@samsung.com>

        [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
        https://bugs.webkit.org/show_bug.cgi?id=78091

        Reviewed by Hajime Morita.

        Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
        This patch will activate around 1,900 test cases from skipped list in EFL port.

        * DumpRenderTree/efl/EventSender.cpp:
        (textZoom):
        (pageZoom):
        (textZoomInCallback):
        (textZoomOutCallback):
        (zoomPageInCallback):
        (zoomPageOutCallback):

2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>

        KeywordLookupGenerator.py script fails in some cases
        https://bugs.webkit.org/show_bug.cgi?id=77886

        Reviewed by Benjamin Poulain.

        * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
        * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
        (GlobalVariablesTest.test_path_rules_specifier):

2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2012-02-12  Joe Thomas  <joethomas@motorola.com>

        Add toText and isTextNode helpers in Text class.
        https://bugs.webkit.org/show_bug.cgi?id=78140

        Unit test case for the new style checker introduced.

        Reviewed by Adam Barth.

        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (CppStyleTest):
        (CppStyleTest.test_static_cast_readability): Added a unit test case.

2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Enable features supported by EFL port in build-webkit.
        https://bugs.webkit.org/show_bug.cgi?id=78348

        Reviewed by Ryosuke Niwa.

        Sync build-webkit with OptionEfl.cmake, as some features enabled in
        OptionEfl.cmake are not enabled in build-webkit.

        * Scripts/build-webkit:

2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2012-02-12  Joe Thomas  <joethomas@motorola.com>

        Add toText and isTextNode helpers in Text class.
        https://bugs.webkit.org/show_bug.cgi?id=78140

        Added a style checker to use toText rather than static_cast<Text*>.

        Reviewed by Adam Barth.

        * Scripts/webkitpy/style/checkers/cpp.py:
        (check_language): Style checker for static_cast<Text*>.

2123
2124
2125
2126
2127
2128
2129
2012-02-12  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, disable Mutation observers build on GTK until it can
        actually build.

        * Scripts/build-webkit:

2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2012-02-11  Benjamin Poulain  <benjamin@webkit.org>

        Add back WTFURL to WebKit
        https://bugs.webkit.org/show_bug.cgi?id=77291

        Reviewed by Adam Barth.

        Add a flag to build-webkit to easily build WebKit with WTFURL.

        * Scripts/build-webkit:

2141
2142
2143
2144
2145
2146
2147
2148
2149
2012-02-10  Adam Klein  <adamk@chromium.org>

        Enable MUTATION_OBSERVERS by default on all platforms
        https://bugs.webkit.org/show_bug.cgi?id=78196

        Reviewed by Ojan Vafai.

        * Scripts/build-webkit:

2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2012-02-10  Adam Barth  <abarth@webkit.org>

        Move garden-o-matic's All Failures out of experimental
        https://bugs.webkit.org/show_bug.cgi?id=78395

        Reviewed by Dimitri Glazkov.

        Several folks have tried this feature and found it useful.

        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:

2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2012-02-10  Tim Horton  <timothy_horton@apple.com>

        NRWT should categorize options in --help
        https://bugs.webkit.org/show_bug.cgi?id=76221

        Reviewed by Eric Seidel.
        
        Use optparse's OptionGroup mechanism to logically group NRWT's options,
        providing a better experience when scanning all the options.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        (parse_args):

2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        [Qt][WK2] Refactor on Qt5 Layout tests' structure
        https://bugs.webkit.org/show_bug.cgi?id=77450

        Reviewed by Csaba Osztrogonác.

        Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
        to qt-5.0-wk2 and qt-5.0-wk1.

        * Scripts/old-run-webkit-tests:
        (buildPlatformResultHierarchy):
        (readSkippedFiles):
        * Scripts/webkitpy/layout_tests/port/qt.py:
        (QtPort._wk2_port_name):
        (QtPort._skipped_file_search_paths):
        * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
        (QtPortTest.test_baseline_search_path):
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        (WebKitPort._wk2_port_name):

2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2012-02-09  Philippe Normand  <pnormand@igalia.com>

        [GTK] EWS command-line option to run the tests
        https://bugs.webkit.org/show_bug.cgi?id=78211

        Reviewed by Adam Barth.

        New --run-tests option (defaults to False) for the EWS commands.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (AbstractEarlyWarningSystem):
        (AbstractEarlyWarningSystem.__init__):
        (AbstractEarlyWarningSystem.review_patch):
        (ChromiumLinuxEWS):
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        (EarlyWarningSytemTest._test_builder_ews):

2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2012-02-09  Eric Seidel  <eric@webkit.org>

        Rename compare_text and compare_audio to make it clear that they're !=
        https://bugs.webkit.org/show_bug.cgi?id=78301

        Reviewed by Adam Barth.

        I also removed the maybe_create_directory function which was redundant.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager.set_up_run):
        * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
        (TestResultWriter._make_output_directory):
        * Scripts/webkitpy/layout_tests/port/base.py:
        (Port.do_text_results_differ):
        (Port.do_audio_results_differ):
        (Port.diff_text):
        (Port.driver_name):
        (Port.skips_perf_test):
        * Scripts/webkitpy/layout_tests/port/win.py:
        (WinPort.do_text_results_differ):
        * Scripts/webkitpy/layout_tests/port/win_unittest.py:
        (WinPortTest.test_do_text_results_differ):
        * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
        (LayoutTestApacheHttpd.__init__):
        * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
        (HttpServerBase.__init__):
        * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
        (Rebaseliner._diff_baselines):

2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2012-02-09  Zan Dobersek  <zandobersek@gmail.com>

        [GTK] Add DRT support for modal dialogs
        https://bugs.webkit.org/show_bug.cgi?id=53600

        Reviewed by Martin Robinson.

        Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
        Most significantly, when creating a new web view in GtkLauncher, the window
        of the web view opener is passed around. In DumpRenderTree, the window of
        the main web view is always considered as the opener. This is required so
        the modal dialog's toplevel can be made transient for the opener's toplevel.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewRunModalDialog):
        (createWebView):
        * GtkLauncher/main.c:
        (createWebViewCb):
        (runModalDialogCb):
        (createBrowser):
        (createWindow):
        (main):

2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2012-02-09  Zan Dobersek  <zandobersek@gmail.com>

        [Gtk] security/set-form-autocomplete-attribute.html fails
        https://bugs.webkit.org/show_bug.cgi?id=78261

        Reviewed by Martin Robinson.

        Use the new helper in DumpRenderTreeSupportGtk to properly
        test whether an element performs autocompletion.

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::elementDoesAutoCompleteForElementWithId):

2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2012-02-09  James Robinson  <jamesr@chromium.org>

        [chromium] Enable mock scrollbars for compositing layout tests
        https://bugs.webkit.org/show_bug.cgi?id=78299

        Reviewed by Dirk Pranke.

        This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
        compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
        more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::runFileTest):
        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::reset):
        (WebPreferences::applyTo):
        * DumpRenderTree/chromium/WebPreferences.h:
        (WebPreferences):

2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2012-02-09  Eric Seidel  <eric@webkit.org>

        Remove more uses of "os" from our webkitpy code
        https://bugs.webkit.org/show_bug.cgi?id=78292

        Reviewed by Adam Barth.

        * Scripts/webkitpy/common/checkout/checkout_mock.py:
        (MockCheckout.__init__):
        (MockCheckout.is_path_to_changelog):
        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/common/system/filesystem_mock.py:
        (MockFileSystem._split):
        * Scripts/webkitpy/common/system/zipfileset_unittest.py:
        * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/tool/bot/queueengine.py:
        * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
        * Scripts/webkitpy/tool/commands/download.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        * Scripts/webkitpy/tool/commands/rebaselineserver.py:
        * Scripts/webkitpy/tool/commands/sheriffbot.py:
        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
        * Scripts/webkitpy/tool/commands/upload.py:
        (CreateBug.prompt_for_bug_title_and_comment):
        * Scripts/webkitpy/tool/servers/reflectionhandler.py:
        * Scripts/webkitpy/tool/steps/attachtobug.py:
        (AttachToBug.run):
        * Scripts/webkitpy/tool/steps/checkstyle.py:
        * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
        * Scripts/webkitpy/tool/steps/commit_unittest.py:
        * Scripts/webkitpy/tool/steps/editchangelog.py:
        * Scripts/webkitpy/tool/steps/preparechangelog.py:
        * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
        (PrepareChangeLogTest.test_ensure_bug_url):
        * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
        * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
        * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
        * Scripts/webkitpy/tool/steps/validatereviewer.py:

2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2012-02-09  Eric Seidel  <eric@webkit.org>

        Remove the cr-mac-ews (it's long been dead)
        https://bugs.webkit.org/show_bug.cgi?id=78267

        Reviewed by Adam Barth.

        * QueueStatusServer/model/queues.py:
        (Queue):
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (ChromiumWindowsEWS):
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        (EarlyWarningSytemTest._test_builder_ews):
        (EarlyWarningSytemTest._test_testing_ews):

2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2012-02-09  Dirk Pranke  <dpranke@chromium.org>

        some tests in webkitpy are being run three times
        https://bugs.webkit.org/show_bug.cgi?id=78283

        Reviewed by Ryosuke Niwa.

        It turns out that if you import a class derived from
        unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
        the unittest framework treats it as if the class was defined in
        the file (as well in the original file). This led us to running
        the tests in ChangeLogTest three times.

        * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
        (PrepareChangeLogTest):
        * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
        (_assert_message_for_revert_output):

2371
2372
2373
2374
2375
2376
2377
2378
2012-02-09  Adam Barth  <abarth@webkit.org>

        Remove extraneous line in previous patch.  I forgot to remove this
        before landing.

        * Scripts/webkitpy/layout_tests/port/driver.py:
        (DriverProxy.start):

2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2012-02-09  Adam Barth  <abarth@webkit.org>

        run-perf-tests should have an option to pause before running tests so we can attach Instruments
        https://bugs.webkit.org/show_bug.cgi?id=78271

        Reviewed by Ryosuke Niwa.

        This lets me attach instruments to profile the performance of the test.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        (ChromiumDriver.start):
        * Scripts/webkitpy/layout_tests/port/driver.py:
        (Driver.start):
        (DriverProxy.start):
        * Scripts/webkitpy/layout_tests/port/server_process.py:
        (ServerProcess.start):
        * Scripts/webkitpy/layout_tests/port/test.py:
        (TestDriver.start):
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        (WebKitDriver.start):
        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
        (get_tests_run.RecordingTestDriver.start):
        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
        (PerfTestsRunner._parse_args):
        (PerfTestsRunner._run_tests_set):
        * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
        (start):
        (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
        (test_run_test_set_kills_drt_per_run):
        (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
        (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):

2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2012-02-09  Adam Barth  <abarth@webkit.org>

        run-perf-tests --chromium should run the chromium port
        https://bugs.webkit.org/show_bug.cgi?id=78266

        Reviewed by Ryosuke Niwa.

        This patch makes run-perf-tests work more like run-webkit-tests.

        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
        (PerfTestsRunner._parse_args):

2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2012-02-09  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
        https://bugs.webkit.org/show_bug.cgi?id=77466

        Reviewed by Dirk Pranke.

        Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
        is set or if we should raise an error. A unit test was added.

        * Scripts/webkitpy/layout_tests/port/qt.py:
        (QtPort.operating_system):
        (QtPort):
        (QtPort.check_sys_deps):
        * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
        (QtPortTest.test_operating_system):
        (QtPortTest):
        (QtPortTest.test_check_sys_deps):

2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2012-02-09  Eric Seidel  <eric@webkit.org>

        Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
        https://bugs.webkit.org/show_bug.cgi?id=78263

        Reviewed by Adam Barth.

        * Scripts/webkitpy/common/config/ports.py:
        (DeprecatedPort):
        (DeprecatedPort.name):
        (DeprecatedPort.flag):
        (DeprecatedPort.script_path):
        (DeprecatedPort.script_shell_command):
        (DeprecatedPort.port):
        (DeprecatedPort.makeArgs):
        (DeprecatedPort.update_webkit_command):
        (DeprecatedPort.check_webkit_style_command):
        (DeprecatedPort.prepare_changelog_command):
        (DeprecatedPort.build_webkit_command):
        (DeprecatedPort.run_javascriptcore_tests_command):
        (DeprecatedPort.run_webkit_unit_tests_command):
        (DeprecatedPort.run_webkit_tests_command):
        (DeprecatedPort.run_python_unittests_command):
        (DeprecatedPort.run_perl_unittests_command):
        (DeprecatedPort.layout_tests_results_path):
        (MacPort):
        (WinPort):
        (GtkPort):
        (GtkPort.build_webkit_command):
        (GtkPort.run_webkit_tests_command):
        (QtPort):
        (QtPort.build_webkit_command):
        (EflPort):
        (EflPort.build_webkit_command):
        (ChromiumPort):
        (ChromiumPort.update_webkit_command):
        (ChromiumPort.build_webkit_command):
        (ChromiumPort.run_webkit_tests_command):
        (ChromiumPort.run_javascriptcore_tests_command):
        (ChromiumXVFBPort):
        (ChromiumXVFBPort.run_webkit_tests_command):
        * Scripts/webkitpy/common/config/ports_unittest.py:
        (DeprecatedPortTest):
        (DeprecatedPortTest.test_mac_port):
        (DeprecatedPortTest.test_gtk_port):
        (DeprecatedPortTest.test_qt_port):
        (DeprecatedPortTest.test_chromium_port):
        (DeprecatedPortTest.test_chromium_xvfb_port):
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (AbstractEarlyWarningSystem.__init__):
        * Scripts/webkitpy/tool/commands/sheriffbot.py:
        * Scripts/webkitpy/tool/main.py:
        (WebKitPatch):
        (WebKitPatch.handle_global_options):
        * Scripts/webkitpy/tool/steps/abstractstep.py:
        * Scripts/webkitpy/tool/steps/steps_unittest.py:
        (StepsTest.test_runtests_args):

2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2012-02-09  Jochen Eisinger  <jochen@chromium.org>

        [chromium] always initialize makeArgs in buildChromiumNinja
        https://bugs.webkit.org/show_bug.cgi?id=78231

        Reviewed by Tony Gentilcore.

        * Scripts/webkitdirs.pm:
        (buildChromiumNinja):

2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2012-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Show url of current hovered link in MiniBrowser
        https://bugs.webkit.org/show_bug.cgi?id=78098

        Reviewed by Martin Robinson.

        * MiniBrowser/gtk/BrowserWindow.c:
        (webViewMouseTargetChanged): Check whether hit test result is a
        link and use the url to update the status bar text.
        (browserWindowConstructed): Connect to
        WebKitWebView::mouse-target-changed signal.

2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2012-02-09  Rob Buis  <rbuis@rim.com>

        [BlackBerry] Upstream DumpRenderTreeBlackBerry
        https://bugs.webkit.org/show_bug.cgi?id=78042

        Reviewed by Antonio Gomes.

        Upstream final part of our DRT implementation.

        * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
        * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
        * DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
        * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
        * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.

2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2012-02-09  Ryosuke Niwa  <rniwa@webkit.org>

        kill-old-processes should kill gcc and clang
        https://bugs.webkit.org/show_bug.cgi?id=78189

        Reviewed by Eric Seidel.

        Added a bunch of processes names of gcc and clang to the list.

        * BuildSlaveSupport/kill-old-processes:

2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2012-02-07  MORITA Hajime  <morrita@google.com>

        Replacement text should be available from the marker.
        https://bugs.webkit.org/show_bug.cgi?id=77934

        Made the mock requestCheckingOfText() implementation to return
        a replacement text for each misspelled word if available.

        Reviewed by Kent Tamura.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::finishLastTextCheck):

2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2012-02-08  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
        https://bugs.webkit.org/show_bug.cgi?id=78146

        Reviewed by Ryosuke Niwa.

        Our DumpRenderTree should support --no-timeout and --timeout options in order
        to be able to use run-perf-tests and have a Performance Bot.
        This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
        and the necessary code to handle such command line arguments to our DumpRenderTree.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::setTimeout):
        (WebCore):
        (WebCore::DumpRenderTree::setShouldTimeout):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        (DumpRenderTree):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::waitUntilDone):
        (LayoutTestController::notifyDone):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        (LayoutTestController::setTimeout):
        (LayoutTestController::setShouldTimeout):
        (LayoutTestController):
        * DumpRenderTree/qt/main.cpp:
        (isOption):
        (printUsage):
        (main):

2593
2594
2595
2596
2597
2598
2599
2600
2601
2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>

        Rubber-stamped by Martin Robinson.

        * gtk/common.py:
        (get_build_path): Move test for current directory being a valid
        directory up so it takes precedence over WebKitBuild/Release and
        WebKitBuild/Debug when they exist as well.

2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>

        [GTK] doc rebasing does not respect DESTDIR
        https://bugs.webkit.org/show_bug.cgi?id=78177

        Reviewed by Martin Robinson.

        * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
        calling it for rebasing.
        * gtk/generate-gtkdoc:
        (get_common_options): Handle the new --virtual-root option.
        * gtk/gtkdoc.py:
        (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
        it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.

2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2012-02-08  Adam Barth  <abarth@webkit.org>

        Remove Python 2.5 support from WebKit
        https://bugs.webkit.org/show_bug.cgi?id=71593

        Reviewed by Eric Seidel.

        This is the last vestige of our Python 2.5 support.

        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        (AbstractQueueTest.test_log_from_script_error_for_upload):

2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2012-02-08  Adam Barth  <abarth@webkit.org>

        version_check.py should inform users that we don't support Python 2.5 anymore
        https://bugs.webkit.org/show_bug.cgi?id=78179

        Reviewed by Eric Seidel.

        We don't support Python 2.5 anymore.

        * Scripts/webkitpy/common/version_check.py:

2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2012-02-08  Adam Barth  <abarth@webkit.org>

        test_configuration.py shouldn't re-implement itertools
        https://bugs.webkit.org/show_bug.cgi?id=78178

        Reviewed by Eric Seidel.

        * Scripts/webkitpy/layout_tests/models/test_configuration.py:
        (TestConfigurationConverter.to_specifiers_list):
        (TestConfigurationConverter.to_specifiers_list.try_collapsing):
        (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
        (TestConfigurationConverter):

2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2012-02-08  Adam Barth  <abarth@webkit.org>

        webkitpy should reply upon the multiprocessing package existing
        https://bugs.webkit.org/show_bug.cgi?id=78176

        Reviewed by Eric Seidel.

        Now that we don't support Python 2.5, this import can't fail.

        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
        (get):
        (_Process):
        (_Process.__init__):
        (_Process.run):
        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
        (FunctionTests.test_get__processes):
        (MultiProcessBrokerTests.setUp):
        * Scripts/webkitpy/layout_tests/port/base.py:
        (Port.__init__):
        (Port.default_worker_model):
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        (ChromiumMacPort.check_build):
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        (PortTestCase.test_default_worker_model):
        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

2679
2680
2681
2682
2683
2684
2685
2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>

        Unreviewed typo fix that makes docs build again for the gtk2-based
        library.

        * gtk/generate-gtkdoc:

2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2012-02-08  Adam Barth  <abarth@webkit.org>

        Don't re-implement ZipFile.extractall
        https://bugs.webkit.org/show_bug.cgi?id=78173

        Reviewed by Eric Seidel.

        We can use ZipFile.extractall now that we don't support Python 2.5.

        * Scripts/webkitpy/common/system/autoinstall.py:
        (AutoInstaller._extract_targz):
        (AutoInstaller._unzip):

2699
2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2711
2712
2713
2714
2715
2716
2012-02-08  Adam Barth  <abarth@webkit.org>

        Remove the ospath compat shim from webkitpy
        https://bugs.webkit.org/show_bug.cgi?id=78170

        Reviewed by Eric Seidel.

        We no longer need this compat shim now that we don't support Python 2.5.

        * Scripts/webkitpy/common/checkout/scm/git.py:
        * Scripts/webkitpy/common/checkout/scm/svn.py:
        * Scripts/webkitpy/common/system/filesystem.py:
        (FileSystem.relpath):
        * Scripts/webkitpy/common/system/filesystem_mock.py:
        (MockFileSystem.relpath):
        * Scripts/webkitpy/common/system/ospath.py: Removed.
        * Scripts/webkitpy/common/system/ospath_unittest.py: Removed.

2717
2718
2719
2720
2721
2722
2723
2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix attempt after r107053.

        * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
        (test_collect_tests):

2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2012-02-08  Adam Barth  <abarth@webkit.org>

        Remove simplejson because it's no longer used by webkitpy
        https://bugs.webkit.org/show_bug.cgi?id=78164

        Reviewed by Eric Seidel.

        All the importers of this code were removed in a previous patch.

        * Scripts/webkitpy/thirdparty/simplejson: Removed.
        * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
        * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
        * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
        * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
        * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
        * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
        * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
        * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
        * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
        * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.

2745
2746
2747
2748
2749
2750
2751
2752
2753
2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2766
2012-02-08  Adam Barth  <abarth@webkit.org>

        webkitpy still imports simplejson
        https://bugs.webkit.org/show_bug.cgi?id=78161

        Reviewed by Eric Seidel.

        We no longer support Python 2.5, so we can rely upon Python's built-in
        JSON package.

        * Scripts/webkitpy/common/net/buildbot/buildbot.py:
        * Scripts/webkitpy/common/net/resultsjsonparser.py:
        * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
        * Scripts/webkitpy/layout_tests/models/test_expectations.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
        * Scripts/webkitpy/style/checkers/jsonchecker.py:
        * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
        * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
        * Scripts/webkitpy/tool/servers/reflectionhandler.py:

2767
2768
2769
2770
2771
2772
2773
2774
2775
2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>

        [GTK] Fails to build docs with non-standard build directories
        https://bugs.webkit.org/show_bug.cgi?id=78118

        * gtk/common.py:
        (get_build_path): add comment to document changes done in r107098,
        as requested by the reviewer and forgotten by me.

2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
2812
2012-02-08  Adam Barth  <abarth@webkit.org>

        Stop importing with_statement from the mysterious future
        https://bugs.webkit.org/show_bug.cgi?id=78156

        Reviewed by Eric Seidel.

        The future is now!  (Well, at least 2008, when Python 2.6 was released,
        is no longer the __future__.)

        * Scripts/webkitpy/common/checkout/changelog_unittest.py:
        * Scripts/webkitpy/common/checkout/checkout_unittest.py:
        * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
        * Scripts/webkitpy/common/net/credentials_unittest.py:
        * Scripts/webkitpy/common/net/file_uploader.py:
        * Scripts/webkitpy/common/newstringio_unittest.py:
        * Scripts/webkitpy/common/system/autoinstall.py:
        * Scripts/webkitpy/common/system/crashlogs.py:
        * Scripts/webkitpy/common/system/fileset.py:
        * Scripts/webkitpy/common/system/filesystem.py:
        * Scripts/webkitpy/common/system/filesystem_unittest.py:
        * Scripts/webkitpy/common/system/path.py:
        * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        (of):
        * Scripts/webkitpy/layout_tests/port/gtk.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
        * Scripts/webkitpy/style/filereader_unittest.py:
        * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
        * Scripts/webkitpy/tool/commands/analyzechangelog.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/servers/reflectionhandler.py:
        * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:

2813
2814
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
2012-02-08  Rob Buis  <rbuis@rim.com>

        [BlackBerry] Upstream DumpRenderTreeBlackBerry
        https://bugs.webkit.org/show_bug.cgi?id=78042

        Reviewed by Antonio Gomes.

        Upstream more parts of our DRT implementation.

        * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
        * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
        * DumpRenderTree/blackberry/EventSender.cpp: Added.
        * DumpRenderTree/blackberry/EventSender.h: Added.
        * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
        * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.

2829
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2840
2841
2842
2843
2844
2845
2846
2847
2012-02-08  Dirk Pranke  <dpranke@chromium.org>

        check-webkit-style failing with "Path does not exist."
        https://bugs.webkit.org/show_bug.cgi?id=77873

        Reviewed by Ojan Vafai.

        This change fixes the way the style checker determines which
        Port class to use for a given test_expectations.txt path; the
        previous version used a heuristic that didn't really work in the
        first place.

        * Scripts/webkitpy/style/checkers/test_expectations.py:
        (TestExpectationsChecker._determine_port_from_expectations_path):
        (TestExpectationsChecker.__init__):
        * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
        (TestExpectationsTestCase._expect_port_for_expectations_path):
        (TestExpectationsTestCase.test_determine_port_from_expectations_path):

2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2012-02-08  Fehér Zsolt  <feherzs@inf.u-szeged.hu>

        nrwt: make --skip-pixel-test-if-no-baseline option
        https://bugs.webkit.org/show_bug.cgi?id=70484

        Reviewed by Dirk Pranke.

        * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
        (SingleTestRunner.__init__):
        (SingleTestRunner._should_fetch_expected_checksum):
        * Scripts/webkitpy/layout_tests/controllers/worker.py:
        (Worker.handle_test_list):
        * Scripts/webkitpy/layout_tests/models/test_input.py:
        (TestInput.__init__):
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        (WebKitDriver.cmd_line):
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        (_set_up_derived_options):
        (parse_args):
        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
        (MainTest.test_skip_pixel_test_if_no_baseline_option):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::TestController):
        (WTR::TestController::initialize):
        (WTR::TestController::runTest):
        * WebKitTestRunner/TestController.h:
        (TestController):
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::TestInvocation::TestInvocation):
        (WTR::TestInvocation::setIsPixelTest):
        * WebKitTestRunner/TestInvocation.h:
        (WTR::TestInvocation::setSkipPixelTestOption):
        (TestInvocation):

2882
2883
2884
2885
2886
2887
2888
2889
2890
2891
2892
2893
2012-02-08  Rob Buis  <rbuis@rim.com>

        [BlackBerry] Upstream DumpRenderTreeBlackBerry
        https://bugs.webkit.org/show_bug.cgi?id=78042

        Reviewed by Antonio Gomes.

        Add implementation for our DumpRenderTree solution.

        * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
        * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.

2894
2895
2896
2897
2898
2899
2900
2901
2902
2903
2904
2905
2906