ChangeLog 1.12 MB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
2011-01-20  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: move releaseObjectGroup to the new Runtime agent.
        https://bugs.webkit.org/show_bug.cgi?id=52803
        (accedentally landed as r76231)

        * inspector/InspectorContorller.h:
        * inspector/InspectorContorller.cpp:
        * inspector/InspectorRuntimeAgent.h:
        * inspector/InspectorRuntimeAgent.cpp:

12
13
14
15
16
17
18
19
20
2011-01-20  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: build fix.

        * inspector/InspectorState.h:
        (WebCore::InspectorState::setBoolean):
        (WebCore::InspectorState::setString):
        (WebCore::InspectorState::setLong):

21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
2011-01-20  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: further simplify InspectorState.
        https://bugs.webkit.org/show_bug.cgi?id=52731

        This change moves XHR logging flag into console agent,
        removes InspectorState pushing to the front-end.

        * inspector/Inspector.idl:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
        (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
        (WebCore::InspectorConsoleAgent::addConsoleMessage):
        * inspector/InspectorConsoleAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::state):
        (WebCore::InspectorController::settings):
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::InspectorState):
        (WebCore::InspectorState::registerBoolean):
        (WebCore::InspectorState::registerString):
        (WebCore::InspectorState::registerLong):
        (WebCore::InspectorState::registerObject):
        (WebCore::InspectorState::Property::create):
        * inspector/InspectorState.h:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared):
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.monitoringXHRStateChanged):
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
        (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
        * inspector/front-end/inspector.js:

ossy@webkit.org's avatar
ossy@webkit.org committed
59
60
61
62
63
64
65
66
2011-01-20  Csaba Osztrogonác  <ossy@webkit.org>

        Unreviewed buildfix.

        [Qt][V8] Remove unnecessary files after r76224.

        * WebCore.pro:

67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
2011-01-20  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: prepare for extracting InspectorAgent from InspectorController.
        https://bugs.webkit.org/show_bug.cgi?id=52797

        * inspector/CodeGeneratorInspector.pm:
        * inspector/InspectorController.h:
        (WebCore::InspectorController::inspectorAgent):
        (WebCore::InspectorController::cssAgent):
        (WebCore::InspectorController::injectedScriptAgent):
        (WebCore::InspectorController::resourceAgent):
        (WebCore::InspectorController::runtimeAgent):
        (WebCore::InspectorController::timelineAgent):
        (WebCore::InspectorController::databaseAgent):
        (WebCore::InspectorController::domStorageAgent):
        (WebCore::InspectorController::fileSystemAgent):
        (WebCore::InspectorController::browserDebuggerAgent):
        (WebCore::InspectorController::debuggerAgent):
        (WebCore::InspectorController::profilerAgent):
        (WebCore::InspectorController::applicationCacheAgent):

90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
2011-01-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76215.
        http://trac.webkit.org/changeset/76215
        https://bugs.webkit.org/show_bug.cgi?id=52799

        Caused regressions in Chromium; morrita is going to look at it
        tomrorow (Requested by jorlow on #webkit).

        * dom/TextEvent.h:
        * dom/TextEventInputType.h:
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
        * editing/CompositeEditCommand.h:
        * editing/Editor.cpp:
        (WebCore::Editor::insertTextWithoutSendingTextEvent):
        (WebCore::Editor::confirmComposition):
        (WebCore::Editor::setComposition):
        * editing/Editor.h:
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input):
        * editing/InsertTextCommand.h:
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::TypingCommand):
        (WebCore::TypingCommand::insertText):
        (WebCore::TypingCommand::insertTextRunWithoutNewlines):
        * editing/TypingCommand.h:
        (WebCore::TypingCommand::create):

119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
2010-12-14  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Adam Barth.

        [V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp
        https://bugs.webkit.org/show_bug.cgi?id=51044

        * WebCore.gypi:
        * bindings/v8/V8ConsoleMessage.cpp: Removed.
        * bindings/v8/V8ConsoleMessage.h: Removed.
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::v8UncaughtExceptionHandler):
        (WebCore::reportUnsafeJavaScriptAccess):
        (WebCore::V8DOMWindowShell::initContextIfNeeded):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::addMessageToConsole):
        (WebCore::logInfo):
        (WebCore::V8Proxy::reportUnsafeAccessTo):
        (WebCore::V8Proxy::runScript):
        (WebCore::V8Proxy::callFunction):
        (WebCore::V8Proxy::newInstance):
        * bindings/v8/V8Proxy.h:
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        * bindings/v8/specialization/V8BindingState.cpp:
        (WebCore::::immediatelyReportUnsafeAccessTo):

145
146
147
148
149
150
151
152
153
154
155
156
2011-01-19  MORITA Hajime  <morrita@google.com>

        Reviewed by Eric Seidel.

        ShadowElement::m_shadowParent should be removed
        https://bugs.webkit.org/show_bug.cgi?id=52558

        No new tests. No behavioral change.

        * rendering/ShadowElement.h:
        (WebCore::ShadowElement::ShadowElement):

157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
2011-01-20  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: IDBObjectStore.get should fire onsuccess rather than onerror
        https://bugs.webkit.org/show_bug.cgi?id=52725

        Let IDBObjectStore.get() fire the onsuccess handler with the value
        'undefined' for when an object does not exist in the store.

        Update SerializedScriptValue to provide such an undefined value.

        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::SerializedScriptValue::nullValue):
        (WebCore::SerializedScriptValue::undefinedValue):
        * bindings/v8/SerializedScriptValue.h:
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::getInternal):

176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
2010-12-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
        https://bugs.webkit.org/show_bug.cgi?id=8519

        Uncaught exceptions are propagated to window.onerror hander if one is present.
        The handler is expected to be a function accepting three arguments: error message,
        resource url and line number where the exception occured.

        It was decided to dispatch ErrorEvent to all listeners/handlers no matter if they
        were created in the same isolated world where the exception occured or not.

        Tests: fast/events/window-onerror1.html
               fast/events/window-onerror10.html
               fast/events/window-onerror11.html
               fast/events/window-onerror12.html
               fast/events/window-onerror2.html
               fast/events/window-onerror3.html
               fast/events/window-onerror4.html
               fast/events/window-onerror5.html
               fast/events/window-onerror6.html
               fast/events/window-onerror7.html
               fast/events/window-onerror8.html
               fast/events/window-onerror9.html
               http/tests/security/window-onerror-exception-in-iframe.html
               userscripts/window-onerror-for-isolated-world-1.html
               userscripts/window-onerror-for-isolated-world-2.html

        * Android.jscbindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.order:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::reportException):
        * bindings/js/JSErrorHandler.cpp: Renamed from WebCore/bindings/js/JSWorkerContextErrorHandler.cpp.
        (WebCore::JSErrorHandler::JSErrorHandler):
        (WebCore::JSErrorHandler::~JSErrorHandler):
        (WebCore::JSErrorHandler::handleEvent):
        * bindings/js/JSErrorHandler.h: Copied from WebCore/bindings/js/JSWorkerContextErrorHandler.h.
        (WebCore::JSErrorHandler::create):
        (WebCore::createJSErrorHandler):
        * bindings/js/JSEventListener.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8ConsoleMessage.cpp:
        (WebCore::V8ConsoleMessage::dispatchNow):
        (WebCore::V8ConsoleMessage::handler): the method was changed to use generic WebCore exception
        reporting mechanism which is also used by JSC bindings.
        * bindings/v8/V8ConsoleMessage.h:
        * bindings/v8/V8EventListener.h:
        * bindings/v8/V8WindowErrorHandler.cpp: Renamed from WebCore/bindings/js/JSWorkerContextErrorHandler.h.
        (WebCore::V8WindowErrorHandler::V8WindowErrorHandler):
        (WebCore::V8WindowErrorHandler::callListenerFunction):
        * bindings/v8/V8WindowErrorHandler.h: Copied from WebCore/dom/ErrorEvent.cpp.
        (WebCore::V8WindowErrorHandler::create):
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::v8MessageHandler):
        * bindings/v8/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::evaluate):
        * dom/Document.cpp:
        (WebCore::Document::errorEventTarget):
        (WebCore::Document::logExceptionToConsole):
        (WebCore::Document::addMessage):
        * dom/Document.h:
        * dom/ErrorEvent.cpp:
        * dom/ErrorEvent.h:
        * dom/Event.cpp:
        (WebCore::Event::isErrorEvent):
        * dom/Event.h:
        * dom/ScriptExecutionContext.cpp:
        (WebCore::ScriptExecutionContext::PendingException::PendingException):
        (WebCore::ScriptExecutionContext::ScriptExecutionContext):
        (WebCore::ScriptExecutionContext::reportException): this method is not virtual anymore to
        ensure that error event dispatching algorithm is the same in WorkerContext and in Document.
        (WebCore::ScriptExecutionContext::dispatchErrorEvent):
        * dom/ScriptExecutionContext.h:
        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::connect):
        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::didOpen):
        (WebCore::WebSocketChannel::didFail):
        (WebCore::WebSocketChannel::appendToBuffer):
        * websockets/WebSocketHandshake.cpp:
        (WebCore::WebSocketHandshake::readServerHandshake):
        (WebCore::WebSocketHandshake::readStatusLine):
        (WebCore::WebSocketHandshake::readHTTPHeaders):
        (WebCore::WebSocketHandshake::checkResponseHeaders):
        * workers/DefaultSharedWorkerRepository.cpp:
        (WebCore::postExceptionTask):
        (WebCore::postConsoleMessageTask):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::WorkerContext):
        (WebCore::WorkerContext::errorEventTarget):
        (WebCore::WorkerContext::logExceptionToConsole):
        (WebCore::WorkerContext::addMessage):
        * workers/WorkerContext.h:
        * workers/WorkerMessagingProxy.cpp:
        (WebCore::WorkerExceptionTask::performTask):
        (WebCore::postConsoleMessageTask):
        * xml/XMLHttpRequest.cpp:
        (WebCore::reportUnsafeUsage):

285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
2011-01-19  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        Space and tab characters "sent" by an input method give totally different results than typing them directly
        https://bugs.webkit.org/show_bug.cgi?id=5241
        
        * Introduced TextEvent::InputTypeComposition and TypingCommand::TextCompositionType to 
          distinguish text input which is originated by composition.
        * Generalized rebalanceWhitespaceAt() to rebalanceWhitespaceOnTextSubstring() to rebalancing 
          range of string on text node, instead of surrounding part of that.

        Test: editing/inserting/insert-composition-whitespace.html

        * dom/TextEvent.h:
        (WebCore::TextEvent::isComposition):
        * dom/TextEventInputType.h: Added TextEventInputComposition as a member of TextEvent::InputType
        * editing/CompositeEditCommand.cpp:
        (WebCore::containsOnlyWhitespace):
        (WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor):
        (WebCore::CompositeEditCommand::canRebalance):
        (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
        (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Added: A generalized version of rebalanceWhitespaceAt(), which takes a range inside Text string.
        * editing/CompositeEditCommand.h:
        * editing/Editor.cpp:
        (WebCore::Editor::insertTextForConfirmedComposition): Added.
        (WebCore::Editor::insertTextWithoutSendingTextEvent):
        (WebCore::Editor::confirmComposition): Now uses insertTextForConfirmedComposition().
        (WebCore::Editor::setComposition):
        * editing/Editor.h:
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input):
        * editing/InsertTextCommand.h:
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::TypingCommand):
        (WebCore::TypingCommand::insertText):
        (WebCore::TypingCommand::insertTextRunWithoutNewlines):
        * editing/TypingCommand.h: Added TypingCommand::m_compositionType and TypingCommand::TextCompositionType
        (WebCore::TypingCommand::setCompositionType): Added.
        (WebCore::TypingCommand::create):

326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
2011-01-19  Dominic Cooney  <dominicc@google.com>

        Reviewed by Kent Tamura.

        Make <keygen> no longer appear to be a <select> element to script.
        https://bugs.webkit.org/show_bug.cgi?id=52557

        The intent is to put <keygen> options into shadow DOM. This change
        takes the first step by hiding the <select> element from
        JavaScript.

        Test: fast/dom/HTMLKeygenElement/keygen.html

        * CMakeLists.txt: Adds new IDL-derived wrapper.
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/gobject/GNUmakefile.am:
        * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
        (WebKit::createKeygenWrapper):
        (WebKit::createHTMLElementWrapper):
        * bindings/objc/DOM.mm:
        (WebCore::createElementClassMap): Keygen no longer DOMHTMLSelectElement
        * html/HTMLKeygenElement.h:
        (WebCore::HTMLKeygenElement::willValidate): Now public.
        * html/HTMLKeygenElement.idl: Added.
        * html/HTMLTagNames.in: Keygen's wrapper is HTMLKeygenElement.
        * page/DOMWindow.idl: Add HTMLKeygenElement constructor.

359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
2011-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76203.
        http://trac.webkit.org/changeset/76203
        https://bugs.webkit.org/show_bug.cgi?id=52784

        Broke Win compile on Chromium bots (Requested by dimich on
        #webkit).

        * WebCore.gypi:
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::reportFatalErrorInV8):
        * page/PageGroup.cpp:
        (WebCore::PageGroup::isLinkVisited):
        * platform/android/PlatformBridge.h:
        * platform/audio/chromium/AudioBusChromium.cpp:
        (WebCore::createBusFromInMemoryAudioFile):
        * platform/chromium/ChromiumBridge.h: Added.
        * platform/chromium/ChromiumDataObjectLegacy.cpp:
        (WebCore::ChromiumDataObjectLegacy::getData):
        * platform/chromium/DragDataChromium.cpp:
        (WebCore::DragData::asURL):
        * platform/chromium/FileSystemChromium.cpp:
        (WebCore::deleteFile):
        (WebCore::deleteEmptyDirectory):
        (WebCore::getFileSize):
        (WebCore::getFileModificationTime):
        (WebCore::revealFolderInOS):
        (WebCore::directoryName):
        (WebCore::pathByAppendingComponent):
        (WebCore::makeAllDirectories):
        (WebCore::fileExists):
        (WebCore::openFile):
        (WebCore::closeFile):
        (WebCore::seekFile):
        (WebCore::truncateFile):
        (WebCore::readFromFile):
        (WebCore::writeToFile):
        * platform/chromium/LanguageChromium.cpp:
        (WebCore::platformDefaultLanguage):
        * platform/chromium/LinkHashChromium.cpp:
        (WebCore::visitedLinkHash):
        * platform/chromium/MIMETypeRegistryChromium.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writePlainText):
        (WebCore::Pasteboard::writeURL):
        (WebCore::Pasteboard::writeImage):
        (WebCore::Pasteboard::canSmartReplace):
        (WebCore::Pasteboard::plainText):
        (WebCore::Pasteboard::documentFragment):
        * platform/chromium/PlatformBridge.h:
        * platform/chromium/PlatformScreenChromium.cpp:
        (WebCore::screenDepth):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        (WebCore::screenRect):
        (WebCore::screenAvailableRect):
        * platform/chromium/ReadableDataObject.cpp:
        (WebCore::ReadableDataObject::getData):
        (WebCore::ReadableDataObject::urlTitle):
        (WebCore::ReadableDataObject::htmlBaseUrl):
        (WebCore::ReadableDataObject::filenames):
        (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
        * platform/chromium/SSLKeyGeneratorChromium.cpp:
        (WebCore::signedPublicKeyAndChallengeString):
        * platform/chromium/ScrollbarThemeChromium.cpp:
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
        (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
        (WebCore::ScrollbarThemeChromiumLinux::paintButton):
        (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
        (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
        (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::scrollbarStateToThemeState):
        (WebCore::ScrollbarThemeChromiumMac::paint):
        * platform/chromium/ScrollbarThemeChromiumWin.cpp:
        (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
        (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
        (WebCore::ScrollbarThemeChromiumWin::paintButton):
        (WebCore::ScrollbarThemeChromiumWin::paintThumb):
        (WebCore::ScrollbarThemeChromiumWin::buttonSize):
        * platform/chromium/SharedTimerChromium.cpp:
        (WebCore::setSharedTimerFiredFunction):
        (WebCore::setSharedTimerFireTime):
        (WebCore::stopSharedTimer):
        * platform/chromium/SuddenTerminationChromium.cpp:
        (WebCore::disableSuddenTermination):
        (WebCore::enableSuddenTermination):
        * platform/chromium/SystemTimeChromium.cpp:
        (WebCore::currentTime):
        * platform/chromium/WritableDataObject.cpp:
        (WebCore::WritableDataObject::setData):
        * platform/graphics/chromium/CrossProcessFontLoading.mm:
        * platform/graphics/chromium/FontCacheChromiumWin.cpp:
        (WebCore::fontContainsCharacter):
        (WebCore::FillLogFont):
        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
        (WebCore::FontPlatformData::scriptFontProperties):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::querySystemForRenderStyle):
        * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
        (WebCore::fillBMPGlyphs):
        * platform/graphics/chromium/ImageChromium.cpp:
        (WebCore::Image::loadPlatformResource):
        * platform/graphics/chromium/ImageChromiumMac.mm:
        (WebCore::Image::loadPlatformResource):
        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/graphics/chromium/UniscribeHelperTextRun.cpp:
        (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
        * platform/graphics/skia/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/network/chromium/CookieJarChromium.cpp:
        (WebCore::setCookies):
        (WebCore::cookies):
        (WebCore::cookieRequestHeaderFieldValue):
        (WebCore::cookiesEnabled):
        (WebCore::getRawCookies):
        (WebCore::deleteCookie):
        * platform/network/chromium/DNSChromium.cpp:
        (WebCore::prefetchDNS):
        * platform/qt/PlatformBridge.h:
        * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
        (WebCore::SQLiteFileSystem::deleteDatabaseFile):
        (WebCore::SQLiteFileSystem::getDatabaseFileSize):
        * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
        (chromiumOpen):
        (chromiumDelete):
        (chromiumAccess):
        * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
        * plugins/chromium/PluginDataChromium.cpp:
        (WebCore::PluginCache::plugins):
        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
        (WebCore::RenderThemeChromiumWin::systemColor):
        (WebCore::RenderThemeChromiumWin::paintButton):
        (WebCore::RenderThemeChromiumWin::paintSliderTrack):
        (WebCore::menuListButtonWidth):
        (WebCore::RenderThemeChromiumWin::paintMenuList):
        (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
        (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
        (WebCore::RenderThemeChromiumWin::paintProgressBar):
        * storage/chromium/IDBFactoryBackendInterface.cpp:
        (WebCore::IDBFactoryBackendInterface::create):
        (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
        * storage/chromium/IDBKeyPathBackendImpl.cpp:
        (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):

526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
2011-01-19  Helder Correia  <helder@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] GraphicsContext::strokePath() paints solid shadows with incorrect alpha
        https://bugs.webkit.org/show_bug.cgi?id=52705

        This is related to bug 52611. The shadow color alpha must be multiplied
        by the context pen alpha. Fixing this results in correct behavior for
        Canvas path stroke() and strokeRect() [which relies on stroke()].

        Tests: fast/canvas/canvas-strokePath-alpha-shadow.html
               fast/canvas/canvas-strokeRect-alpha-shadow.html

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::strokePath):

543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
2011-01-19  Darin Fisher  <darin@chromium.org>

        Reviewed by Mihai Parparita.

        Re-initialize the HistoryItem fully when navigating to a HistoryItem,
        or replacing a HistoryItem, results in a different URL.

        https://bugs.webkit.org/show_bug.cgi?id=49654

        This patch also forces all HistoryItems to record the post-redirect
        URL.  Previously, frames would remember the pre-redirect URL.  This is
        problematic since other members of the HistoryItem correspond to the
        post-redirect URL.

        Tests: fast/history/history-replace-updates-current-item.html
               http/tests/navigation/redirect-on-back-updates-history-item.html
               http/tests/navigation/redirect-on-reload-updates-history-item.html

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::HistoryItem):
        (WebCore::HistoryItem::reset):
        * history/HistoryItem.h:
        * loader/HistoryController.cpp:
        (WebCore::HistoryController::updateForBackForwardNavigation):
        (WebCore::HistoryController::updateForReload):
        (WebCore::HistoryController::updateForStandardLoad):
        (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
        (WebCore::HistoryController::initializeItem):
        (WebCore::HistoryController::createItem):
        (WebCore::HistoryController::createItemTree):
        (WebCore::HistoryController::updateCurrentItem):
        * loader/HistoryController.h:

576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
2011-01-19  Adam Klein  <adamk@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Rename ChromiumBridge to PlatformBridge
        https://bugs.webkit.org/show_bug.cgi?id=52471

        No tests added as this is a rename; no change in behavior.

        * WebCore.gypi:
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::reportFatalErrorInV8):
        * page/PageGroup.cpp:
        (WebCore::PageGroup::isLinkVisited):
        * platform/android/PlatformBridge.h:
        * platform/audio/chromium/AudioBusChromium.cpp:
        (WebCore::createBusFromInMemoryAudioFile):
        * platform/chromium/ChromiumBridge.h: Removed.
        * platform/chromium/ChromiumDataObjectLegacy.cpp:
        (WebCore::ChromiumDataObjectLegacy::getData):
        * platform/chromium/DragDataChromium.cpp:
        (WebCore::DragData::asURL):
        * platform/chromium/FileSystemChromium.cpp:
        (WebCore::deleteFile):
        (WebCore::deleteEmptyDirectory):
        (WebCore::getFileSize):
        (WebCore::getFileModificationTime):
        (WebCore::revealFolderInOS):
        (WebCore::directoryName):
        (WebCore::pathByAppendingComponent):
        (WebCore::makeAllDirectories):
        (WebCore::fileExists):
        (WebCore::openFile):
        (WebCore::closeFile):
        (WebCore::seekFile):
        (WebCore::truncateFile):
        (WebCore::readFromFile):
        (WebCore::writeToFile):
        * platform/chromium/LanguageChromium.cpp:
        (WebCore::platformDefaultLanguage):
        * platform/chromium/LinkHashChromium.cpp:
        (WebCore::visitedLinkHash):
        * platform/chromium/MIMETypeRegistryChromium.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writePlainText):
        (WebCore::Pasteboard::writeURL):
        (WebCore::Pasteboard::writeImage):
        (WebCore::Pasteboard::canSmartReplace):
        (WebCore::Pasteboard::plainText):
        (WebCore::Pasteboard::documentFragment):
        * platform/chromium/PlatformBridge.h:
        * platform/chromium/PlatformScreenChromium.cpp:
        (WebCore::screenDepth):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        (WebCore::screenRect):
        (WebCore::screenAvailableRect):
        * platform/chromium/ReadableDataObject.cpp:
        (WebCore::ReadableDataObject::getData):
        (WebCore::ReadableDataObject::urlTitle):
        (WebCore::ReadableDataObject::htmlBaseUrl):
        (WebCore::ReadableDataObject::filenames):
        (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
        * platform/chromium/SSLKeyGeneratorChromium.cpp:
        (WebCore::signedPublicKeyAndChallengeString):
        * platform/chromium/ScrollbarThemeChromium.cpp:
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
        (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
        (WebCore::ScrollbarThemeChromiumLinux::paintButton):
        (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
        (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
        (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::scrollbarStateToThemeState):
        (WebCore::ScrollbarThemeChromiumMac::paint):
        * platform/chromium/ScrollbarThemeChromiumWin.cpp:
        (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
        (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
        (WebCore::ScrollbarThemeChromiumWin::paintButton):
        (WebCore::ScrollbarThemeChromiumWin::paintThumb):
        (WebCore::ScrollbarThemeChromiumWin::buttonSize):
        * platform/chromium/SharedTimerChromium.cpp:
        (WebCore::setSharedTimerFiredFunction):
        (WebCore::setSharedTimerFireTime):
        (WebCore::stopSharedTimer):
        * platform/chromium/SuddenTerminationChromium.cpp:
        (WebCore::disableSuddenTermination):
        (WebCore::enableSuddenTermination):
        * platform/chromium/SystemTimeChromium.cpp:
        (WebCore::currentTime):
        * platform/chromium/WritableDataObject.cpp:
        (WebCore::WritableDataObject::setData):
        * platform/graphics/chromium/CrossProcessFontLoading.mm:
        * platform/graphics/chromium/FontCacheChromiumWin.cpp:
        (WebCore::fontContainsCharacter):
        (WebCore::FillLogFont):
        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
        (WebCore::FontPlatformData::scriptFontProperties):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::querySystemForRenderStyle):
        * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
        (WebCore::fillBMPGlyphs):
        * platform/graphics/chromium/ImageChromium.cpp:
        (WebCore::Image::loadPlatformResource):
        * platform/graphics/chromium/ImageChromiumMac.mm:
        (WebCore::Image::loadPlatformResource):
        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/graphics/chromium/UniscribeHelperTextRun.cpp:
        (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
        * platform/graphics/skia/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/network/chromium/CookieJarChromium.cpp:
        (WebCore::setCookies):
        (WebCore::cookies):
        (WebCore::cookieRequestHeaderFieldValue):
        (WebCore::cookiesEnabled):
        (WebCore::getRawCookies):
        (WebCore::deleteCookie):
        * platform/network/chromium/DNSChromium.cpp:
        (WebCore::prefetchDNS):
        * platform/qt/PlatformBridge.h:
        * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
        (WebCore::SQLiteFileSystem::deleteDatabaseFile):
        (WebCore::SQLiteFileSystem::getDatabaseFileSize):
        * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
        (chromiumOpen):
        (chromiumDelete):
        (chromiumAccess):
        * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
        * plugins/chromium/PluginDataChromium.cpp:
        (WebCore::PluginCache::plugins):
        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
        (WebCore::RenderThemeChromiumWin::systemColor):
        (WebCore::RenderThemeChromiumWin::paintButton):
        (WebCore::RenderThemeChromiumWin::paintSliderTrack):
        (WebCore::menuListButtonWidth):
        (WebCore::RenderThemeChromiumWin::paintMenuList):
        (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
        (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
        (WebCore::RenderThemeChromiumWin::paintProgressBar):
        * storage/chromium/IDBFactoryBackendInterface.cpp:
        (WebCore::IDBFactoryBackendInterface::create):
        (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
        * storage/chromium/IDBKeyPathBackendImpl.cpp:
        (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):

743
744
745
746
747
748
749
750
751
752
753
754
2011-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76187.
        http://trac.webkit.org/changeset/76187
        https://bugs.webkit.org/show_bug.cgi?id=52778

        Broke caret-showing tests on SnowLeopard and Chromium
        (Requested by dimich on #webkit).

        * rendering/RenderText.cpp:
        (WebCore::RenderText::localCaretRect):

755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
2011-01-19  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Kent Tamura.

        Fix for Bug 52279 - WebCore::RenderBlock::updateFirstLetter crashes for anonymous blocks
        https://bugs.webkit.org/show_bug.cgi?id=52279

        In constructing text fragments to handle first-letter rule, first add
        the text for the non-first letters and then remove the original text,
        rather than the other way around. Otherwise, the text can be added to
        an anoymous block that is different from the original one. This breaks
        the assumption that a first letter render object has a non-null sibling
        for the non-first letters and causes a crash.

        Test: fast/css/first-letter-anonymous-block-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter):

774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
2011-01-19  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r76194.
        http://trac.webkit.org/changeset/76194
        https://bugs.webkit.org/show_bug.cgi?id=51218

        Caused mysterious compile failure on the chromium win
        build.webkit.org bots

        * WebCore.gypi:
        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:
        * dom/RequestAnimationFrameCallback.h: Removed.
        * dom/RequestAnimationFrameCallback.idl: Removed.
        * loader/EmptyClients.h:
        * page/Chrome.cpp:
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/DOMWindow.cpp:
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * page/FrameView.cpp:
        * page/FrameView.h:
        * platform/HostWindow.h:

800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
2011-01-19  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        GraphicsLayers in subframes can get sync'd multiple times
        https://bugs.webkit.org/show_bug.cgi?id=52489

        Some cleanup that will work towards fixing this bug.
        
        Tested by existing iframe compositing tests.

        * WebCore.exp.in: syncCompositingStateRecursive()
        was renamed to syncCompositingStateIncludingSubframes().

        * page/FrameView.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::syncCompositingStateForThisFrame): Some
        code cleanup: do all the word we need to do for this frame,
        including the needsLayout() check.
        (WebCore::FrameView::syncCompositingStateIncludingSubframes):
        This is no longer recursive; instead, it iterates over descendant
        frames via the frame tree, calling syncCompositingStateForThisFrame()
        on each Frame's view.

        * rendering/RenderLayerCompositor.h:
        (WebCore::RenderLayerCompositor::isFlushingLayers): Getter for the flag.
        * rendering/RenderLayerCompositor.cpp: 
        (WebCore::RenderLayerCompositor::RenderLayerCompositor):
        (WebCore::RenderLayerCompositor::flushPendingLayerChanges): Maintain
        a flag to say if we're flushing, which allows us to assert on re-entrant flushes.
        (WebCore::RenderLayerCompositor::enclosingCompositorFlushingLayers):
        Add the ability to get the rootmost compositor that is in the middle
        of a flush.

834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
2011-01-19  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Fisher.

        Implement mozilla's requestAnimationFrame API
        https://bugs.webkit.org/show_bug.cgi?id=51218

        This implements mozilla's proposed requestAnimationFrame API.  The idea with this API is that
        an author driving an animation from script could use window.requestAnimationFrame(callback)
        instead of window.setTimeout(callback, 0) to schedule their update logic and let the browser
        decide when to update the animations.  This avoids doing unnecessary work when the page content
        is offscreen or is being displayed at a different framerate than what the page author expects.

        Mozilla's proposal is here: https://developer.mozilla.org/en/DOM/window.mozRequestAnimationFrame
        This implements window.mozRequestAnimationFrame as window.webkitRequestAnimationFrame with the
        following changes:
        *) Only the callback syntax is supported, there is no before paint event
        *) webkitRequestAnimationFrame supports a second parameter Element to let the author indicate
            what content they intend to animate.  That way if the page is being displayed but the element
            in question is offscreen, we can avoid invoking the callback.
        *) No timestamp is provided to the caller and there is no window.animationStartTime property
            (see https://bugs.webkit.org/show_bug.cgi?id=51952 for discussion of this property)
        *) window.webkitRequestAnimationFrame returns a numerical id that can be used to cancel the callback
            using window.cancelWebkitRequestAnimationFrame, to parallel window.setTimeout()/window.clearTime().

        The implementation depends on the embedder scheduling the callbacks since the callback invocation
        depends on the page's visibility and the embedder's paint scheduling, neither of which are exposed
        to WebCore.  The expectation for the embedder is that at some point Chrome::scheduleAnimation() is
        called FrameView::serviceScriptedAnimations() should be called for the associated Page's main frame.
        Ideally serviceScriptedAnimations() would be called prior to rendering - although in practice the
        embedder has to rate limit callbacks and may not be able to tie the callback directly to the
        rendering loop.

        Tests: fast/animation/request-animation-frame-cancel.html
               fast/animation/request-animation-frame-cancel2.html
               fast/animation/request-animation-frame-display.html
               fast/animation/request-animation-frame-within-callback.html
               fast/animation/request-animation-frame.html

        * WebCore.gypi:
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::webkitRequestAnimationFrame):
        (WebCore::Document::webkitCancelRequestAnimationFrame):
        (WebCore::Document::serviceScriptedAnimations):
        * dom/Document.h:
        * dom/RequestAnimationFrameCallback.h: Added.
        (WebCore::RequestAnimationFrameCallback::~RequestAnimationFrameCallback):
        * dom/RequestAnimationFrameCallback.idl: Added.
        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::scheduleAnimation):
        * page/Chrome.cpp:
        (WebCore::Chrome::scheduleAnimation):
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::webkitRequestAnimationFrame):
        (WebCore::DOMWindow::webkitCancelRequestAnimationFrame):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * page/FrameView.cpp:
        (WebCore::FrameView::scheduleAnimation):
        (WebCore::FrameView::serviceScriptedAnimations):
        * page/FrameView.h:
        * platform/HostWindow.h:

900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
2011-01-13  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Daniel Bates.

        [GTK] Move progress bar painting out of gtk2drawing.c
        https://bugs.webkit.org/show_bug.cgi?id=52385

        Move progress bar painting to RenderThemeGtk2 and share some animation
        logic between the GTK+ 2.x and GTK+ 3.x port.

        No new tests. This should not change functionality.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar): Moved from RenderThemeGtk3.
        (WebCore::RenderThemeGtk::animationDurationForProgressBar): Ditto.
        (WebCore::RenderThemeGtk::calculateProgressRect): Calculate the proper rectangle for the
        progress indicator given the rect for the maximum size of the indicator.
        * platform/gtk/RenderThemeGtk.h: Added calculateProgressRect declaration and
        a new widget member for GTK+ 2.x
        * platform/gtk/RenderThemeGtk2.cpp:
        (WebCore::RenderThemeGtk::platformInit): Added initialization for the new widget member.
        (WebCore::RenderThemeGtk::paintProgressBar): Paint the progress bar manually instead of
        calling the old Mozilla code.
        (WebCore::RenderThemeGtk::gtkProgressBar): Added.
        * platform/gtk/RenderThemeGtk3.cpp:
        (WebCore::RenderThemeGtk::paintProgressBar): Call calculateProgressRect now to get
        the area of the progress indicator.
        * platform/gtk/gtk2drawing.c: Remove unused code.
        (moz_gtk_get_widget_border):
        (moz_gtk_widget_paint):
        * platform/gtk/gtkdrawing.h: Ditto.

932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
2011-01-19  Dmitry Titov  <dimich@chromium.org>

        [Chromium] Not reviewed, reverts the following changes:
        http://trac.webkit.org/changeset/76164 (build fix)
        http://trac.webkit.org/changeset/76159 (main change)

        The change broke Chromium Linux-shlib build.

        Original issue:
        Accelerated canvas2D has bad clipping performance.
        https://bugs.webkit.org/show_bug.cgi?id=52627

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::reset):
        (WebCore::CanvasRenderingContext2D::platformLayer):
        * platform/graphics/chromium/DrawingBufferChromium.cpp:
        (WebCore::DrawingBuffer::DrawingBuffer):
        * platform/graphics/chromium/GLES2Canvas.cpp:
        (WebCore::GLES2Canvas::State::State):
        (WebCore::GLES2Canvas::clearRect):
        (WebCore::GLES2Canvas::fillRect):
        (WebCore::GLES2Canvas::restore):
        (WebCore::GLES2Canvas::drawTexturedRect):
        * platform/graphics/chromium/GLES2Canvas.h:
        * platform/graphics/gpu/DrawingBuffer.cpp:
        (WebCore::DrawingBuffer::clear):
        (WebCore::DrawingBuffer::createSecondaryBuffers):
        (WebCore::DrawingBuffer::reset):
        * platform/graphics/gpu/DrawingBuffer.h:
        * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
        (WebCore::SharedGraphicsContext3D::create):
        * platform/graphics/gpu/SharedGraphicsContext3D.h:
        * platform/graphics/gpu/mac/DrawingBufferMac.mm:
        (WebCore::DrawingBuffer::DrawingBuffer):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::canvasClip):
        (WebCore::GraphicsContext::clipOut):
        (WebCore::GraphicsContext::clipPath):
        (WebCore::GraphicsContext::fillPath):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::canAccelerate):
        (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
        * thirdparty/glu/README.webkit:
        * thirdparty/glu/gluos.h:
        * thirdparty/glu/libtess/geom.c:
        * thirdparty/glu/libtess/priorityq.c:
        * thirdparty/glu/libtess/render.c:
        * thirdparty/glu/libtess/sweep.c:
        (IsWindingInside):
        (DoneEdgeDict):

985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
2011-01-19  Levi Weintraub  <leviw@google.com>

        Reviewed by Darin Adler.

        Re-committing this with the proper expected results.

        Changing RenderText::localCaretRect to clip to its containing block's logicalLeft and
        logicalRightLayoutOverflow instead of simply using logicalLeft and logicalRight, as this
        resulted in the caret being placed incorrectly in overflowing editable IFrame content.

        Long lines in non-white-space-pre editable documents show cursor in wrong place
        https://bugs.webkit.org/show_bug.cgi?id=48132

        Test: editing/selection/caret-painting-in-overflowing-autowrap-content.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::localCaretRect):

1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
2011-01-18 MORITA Hajime <morrita@google.com>

        Reviewed by David Levin.

        ElementRareData::m_shadowRoot should not be RefPtr.
        https://bugs.webkit.org/show_bug.cgi?id=51914

        Makes ElementRareData::m_shadowRoot a raw pointer because
        ElementRareData::m_shadowRoot should be like a
        ContaineNode::m_firstChild, which is also a raw pointer.
        pointer. Which also means that both the shadow root and the shadow
        host reference each other as a parent-and-child relationship, via
        a raw pointer.
        
        Note that it is safe not to manipulate the ref-count of
        m_shadowRoot because Node::m_parent of the shadow root points its
        shadow host, and the object isn't deleted even if the refcount is
        zero, as long as the node has non-null m_parent. (See TreeShared.)
        
        The shadow root node is finally destroyed inside
        removeShadowRoot(), where we store the root node into a local
        RefPtr, then make the node's m_parent null, which results the
        destroy the node, at the end of the function, by RefPtr::~RefPtr.
        
        No new tests. No behavioral change.

        * dom/Element.cpp:
        (WebCore::Element::~Element):
        (WebCore::Element::shadowRoot):
        (WebCore::Element::setShadowRoot):
        (WebCore::Element::removeShadowRoot):
        * dom/ElementRareData.h:
        (WebCore::ElementRareData::ElementRareData):
        (WebCore::ElementRareData::~ElementRareData):

1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
2011-01-12  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Move text field painting out of gtk2drawing.c
        https://bugs.webkit.org/show_bug.cgi?id=52327

        No new tests. This should not change behavior.

        * platform/gtk/RenderThemeGtk2.cpp:
        (WebCore::RenderThemeGtk::paintButton): Use the setWidgetHasFocus helper.
        (WebCore::RenderThemeGtk::paintTextField): Do this manually now instead
        of calling into the Mozilla code.
        * platform/gtk/WidgetRenderingContext.cpp: Added a couple more wrappers
        for GTK+ theme functions.
        (WebCore::WidgetRenderingContext::gtkPaintFlatBox):
        (WebCore::WidgetRenderingContext::gtkPaintShadow):
        * platform/gtk/WidgetRenderingContext.h: Added new method declarations.
        * platform/gtk/gtk2drawing.c: Remove unused code.
        (moz_gtk_get_widget_border):
        (moz_gtk_widget_paint):
        * platform/gtk/gtkdrawing.h:

1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
2011-01-19  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver Hunt.

        Cache function offsets to speed up javascript parsing
        https://bugs.webkit.org/show_bug.cgi?id=52622
        
        Use cache to save function offsets and some other info.
        This avoids quite a bit of work when reparsing the source.

        * bindings/js/CachedScriptSourceProvider.h:
        (WebCore::CachedScriptSourceProvider::cache):
        (WebCore::CachedScriptSourceProvider::cacheSizeChanged):
        (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
        * bindings/js/ScriptSourceProvider.h:
        (WebCore::ScriptSourceProvider::ScriptSourceProvider):
        * loader/cache/CachedScript.cpp:
        (WebCore::CachedScript::destroyDecodedData):
        (WebCore::CachedScript::sourceProviderCache):
        (WebCore::CachedScript::sourceProviderCacheSizeChanged):
        * loader/cache/CachedScript.h:

1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
2011-01-11  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Move toggle button rendering out of gtk2drawing.c
        https://bugs.webkit.org/show_bug.cgi?id=52258

        * platform/gtk/RenderThemeGtk.h:
        * platform/gtk/RenderThemeGtk2.cpp:
        (WebCore::RenderThemeGtk::platformInit): Initialize new button members.
        (WebCore::adjustRectForFocus): Added this function which inflates a rect based
        on a widget's exterior focus.
        (WebCore::RenderThemeGtk::adjustRepaintRect): Account for exterior focus.
        (WebCore::setToggleSize): Only listen to indicator-size to properly size
        checkboxes and radio buttons.
        (WebCore::RenderThemeGtk::setCheckboxSize): Call new setToggleSize properly.
        (WebCore::paintToggle): Added.
        (WebCore::RenderThemeGtk::paintCheckbox): Call paintToggle.
        (WebCore::RenderThemeGtk::setRadioSize): Call new setToggleSize properly.
        (WebCore::RenderThemeGtk::paintRadio): Call paintToggle.
        (WebCore::RenderThemeGtk::gtkRadioButton): Added.
        (WebCore::RenderThemeGtk::gtkCheckButton): Added.
        * platform/gtk/WidgetRenderingContext.cpp:
        (WebCore::WidgetRenderingContext::WidgetRenderingContext): Use a static extra space
        variable. This is good enough for all themes that I've tested and prevents having to
        pass information from RenderThemeGtk about every single type of widget.
        (WebCore::WidgetRenderingContext::gtkPaintFocus): Use the paintRect
        to draw instead of m_paintRect. This is important when we're painting
        something that isn't the size of the total rect.
        (WebCore::WidgetRenderingContext::gtkPaintCheck): Added.
        (WebCore::WidgetRenderingContext::gtkPaintOption): Added.
        * platform/gtk/WidgetRenderingContext.h: Updated to reflect new methods.
        * platform/gtk/gtkdrawing.h: Remove newly unused code.
        * platform/gtk/gtk2drawing.c: Ditto.

1118
1119
1120
1121
1122
1123
1124
1125
1126
2011-01-19  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        Build fix for r76170
        https://bugs.webkit.org/show_bug.cgi?id=52758

        * platform/graphics/chromium/UniscribeHelperTextRun.cpp:

1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
2011-01-19  David D. Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/52687> Clean up FrameLoader methods for PLUGIN_PROXY_FOR_VIDEO

        Reviewed by Eric Carlson.

        * loader/FrameLoader.cpp: Declare the methods here.
        (WebCore::FrameLoader::hideMediaPlayerProxyPlugin):
        (WebCore::FrameLoader::showMediaPlayerProxyPlugin):
        * loader/FrameLoader.cpp: Moved methods to here...
        (WebCore::FrameLoader::hideMediaPlayerProxyPlugin):
        (WebCore::FrameLoader::showMediaPlayerProxyPlugin):
        * loader/SubframeLoader.cpp: ...from here.
        (WebCore::FrameLoader::hideMediaPlayerProxyPlugin):
        (WebCore::FrameLoader::showMediaPlayerProxyPlugin):

1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
2011-01-19  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Mihai Parparita.

        Perform some forward declaration
        https://bugs.webkit.org/show_bug.cgi?id=52522

        No new tests because no new functionality.

        * accessibility/AccessibilityObject.h:
        * css/WebKitCSSMatrix.cpp:
        * html/HTMLAreaElement.cpp:
        * html/canvas/CanvasRenderingContext2D.cpp:
        * inspector/InspectorController.cpp:
        * platform/graphics/FloatPoint.cpp:
        * platform/graphics/Font.cpp:
        * platform/graphics/Font.h:
        * platform/graphics/FontFastPath.cpp:
        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/StringTruncator.cpp:
        * platform/graphics/WidthIterator.cpp:
        * platform/graphics/mac/ComplexTextController.cpp:
        * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
        * platform/graphics/mac/FontComplexTextMac.cpp:
        * platform/graphics/transforms/TransformationMatrix.cpp:
        * platform/graphics/transforms/TransformationMatrix.h:
        * rendering/EllipsisBox.cpp:
        * rendering/InlineTextBox.cpp:
        * rendering/RenderBlock.cpp:
        * rendering/RenderBlockLineLayout.cpp:
        * rendering/RenderEmbeddedObject.cpp:
        * rendering/RenderFileUploadControl.cpp:
        * rendering/RenderFlexibleBox.cpp:
        * rendering/RenderImage.cpp:
        * rendering/RenderListBox.cpp:
        * rendering/RenderListMarker.cpp:
        * rendering/RenderMenuList.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderText.cpp:
        * rendering/RenderTextControl.cpp:
        * rendering/svg/SVGInlineTextBox.cpp:
        * rendering/svg/SVGMarkerLayoutInfo.h:
        * rendering/svg/SVGTextMetrics.cpp:
        * svg/SVGFont.cpp:

1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
2011-01-19  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        [chromium] Tiled compositor should use texture manager
        https://bugs.webkit.org/show_bug.cgi?id=52418

        Test: compositing/

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::~LayerRendererChromium):
        (WebCore::LayerRendererChromium::cleanupSharedObjects):
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::LayerTilerChromium):
        (WebCore::LayerTilerChromium::reset):
        (WebCore::LayerTilerChromium::createTile):
        (WebCore::LayerTilerChromium::update):
        (WebCore::LayerTilerChromium::draw):
        * platform/graphics/chromium/LayerTilerChromium.h:
        (WebCore::LayerTilerChromium::Tile::Tile):
        (WebCore::LayerTilerChromium::Tile::texture):

1211
1212
1213
1214
1215
1216
1217
2011-01-19  Stephen White  <senorblanco@chromium.org>

        Unreviewed; build fix for chromium.

        * platform/graphics/chromium/GLES2Canvas.cpp:
        (WebCore::GLES2Canvas::fillPath):

1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
2011-01-18  Stephen White  <senorblanco@chromium.org>

        Reviewed by James Robinson.

        Implement accelerated path drawing and clipping for the Canvas2D GPU
        path.
        https://bugs.webkit.org/show_bug.cgi?id=52627
        
        This is done with a simple curve interpolator and the GLU tesselator,
        which is good enough for a 3-5X speedup on
        http://ie.microsoft.com/testdrive/Performance/Galactic/Default.html.

        Covered by canvas/philip/2d.path.clip.basic.html, and many, many more.
        All tests canvas/philip and fast/canvas paths pass with no
        regressions, although two have minor pixel differences which require
        rebaselining.

        * WebCore.gyp/WebCore.gyp:
        Add internal_glu include path to chromium build.
        * WebCore.gypi:
        Add internal_glu files to chromium build.
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::reset):
        (WebCore::CanvasRenderingContext2D::platformLayer):
        Make CanvasRenderingContext2D more robust against failure to create
        a DrawingBuffer.
        * platform/graphics/chromium/DrawingBufferChromium.cpp:
        (WebCore::DrawingBuffer::DrawingBuffer):
        As in DrawingBufferMac.cpp, call reset() from the constructor.
        Also initialize size to (-1, -1), so reset() doesn't early-out.
        Add initializers for depthBuffer and stencilBuffer, and remove
        multisampleDepthStencilBuffer.
        * platform/graphics/chromium/GLES2Canvas.cpp:
        Remove some unused #includes.
        (WebCore::GLES2Canvas::State::State):
        Add clipping state, and implement save/restore via the copy constructor.
        (WebCore::operator*):
        (WebCore::Quadratic::Quadratic):
        (WebCore::Quadratic::fromBezier):
        (WebCore::Quadratic::evaluate):
        Quadratic Bezier curve class.
        (WebCore::Cubic::Cubic):
        (WebCore::Cubic::fromBezier):
        (WebCore::Cubic::evaluate):
        Cubic Bezier curve class.
        (WebCore::GLES2Canvas::clearRect):
        Add clipping support to clearRect().
        (WebCore::GLES2Canvas::fillPath):
        Implement fillPath().
        (WebCore::GLES2Canvas::fillRect):
        Add clipping support to fillRect().
        (WebCore::GLES2Canvas::clipPath):
        Implement clipPath().
        (WebCore::GLES2Canvas::clipOut):
        Stub out clipOut() (not called by Canvas 2D).
        (WebCore::GLES2Canvas::restore):
        When restoring, draw any remaining clipping paths to the stencil buffer.
        (WebCore::GLES2Canvas::drawTexturedRect):
        Add clipping support.
        (WebCore::interpolateQuadratic):
        (WebCore::interpolateCubic):
        Simple curve interpolation, using the Cubic and Quadratic classes.
        (WebCore::PolygonData::PolygonData):
        A struct to hold the tesselation data for callbacks.
        (WebCore::beginData):
        (WebCore::edgeFlagData):
        (WebCore::vertexData):
        (WebCore::endData):
        (WebCore::combineData):
        internal_glu tesselation callbacks.
        (WebCore::GLES2Canvas::createVertexBufferFromPath):
        Build an interpolated, tesselated vertex buffer and element array buffer from a given path, suitable for filling.
        (WebCore::GLES2Canvas::beginStencilDraw):
        Enable stencilling, and disable draws to the color buffer.
        (WebCore::GLES2Canvas::applyClipping):
        If clipping is enabled, set the appropriate GL state.
        * platform/graphics/chromium/GLES2Canvas.h:
        Document the flavours of drawTexturedRect() a bit, so I don't get confused.
        * platform/graphics/gpu/DrawingBuffer.cpp:
        (WebCore::DrawingBuffer::clear):
        (WebCore::DrawingBuffer::createSecondaryBuffers):
        (WebCore::DrawingBuffer::resizeDepthStencil):
        (WebCore::DrawingBuffer::reset):
        * platform/graphics/gpu/DrawingBuffer.h:
        Unify m_multisampleDepthStencilBuffer with m_depthStencilBuffer. 
        Implement separate depth and stencil buffers for when
        OES_packed_depth_stencil is not available.  Refactor creation of
        multisampled and non-multisampled depth and stencil buffers into
        resizeDepthStencil().
        * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
        (WebCore::SharedGraphicsContext3D::create):
        Turn on stencil, turn off depth, turn off antialiasing (for now).
        (WebCore::SharedGraphicsContext3D::enableStencil):
        * platform/graphics/gpu/SharedGraphicsContext3D.h:
        Implement stencil enable/disable.
        * platform/graphics/gpu/mac/DrawingBufferMac.mm:
        (WebCore::DrawingBuffer::DrawingBuffer):
        Remove m_multisampleDepthStencilBuffer.  Set the size to (-1, -1)
        on creation, so reset() doesn't early-out.  Initialize m_depthBuffer
        and m_stencilBuffer.
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::canvasClip):
        (WebCore::GraphicsContext::clipOut):
        (WebCore::GraphicsContext::clipPath):
        (WebCore::GraphicsContext::fillPath):
        Put in GPU hooks for path clipping, and path drawing.
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::canAccelerate):
        Don't check for clipping paths in canAccelerate() (since we can
        now accelerate them).
        (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
        Don't do clipping when uploading software draws to hardware.
        * thirdparty/glu/README.webkit:
        * thirdparty/glu/gluos.h:
        #undef MIN and MAX, to fix warnings-as-errors in Chrome/Mac build.
        * thirdparty/glu/libtess/geom.c:
        * thirdparty/glu/libtess/priorityq.c:
        * thirdparty/glu/libtess/render.c:
        Use do{}while(0) instead of if(1)else construct in macro.
        * thirdparty/glu/libtess/sweep.c:
        (IsWindingInside):
        (DoneEdgeDict):
        Fix some warnings treated as errors for the Linux Release build.

1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
2011-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76144.
        http://trac.webkit.org/changeset/76144
        https://bugs.webkit.org/show_bug.cgi?id=52737

        Broke tests on multiple bots, mostly Chromium Canaries
        (Requested by dimich on #webkit).

        * rendering/RenderText.cpp:
        (WebCore::RenderText::localCaretRect):

1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
2011-01-19  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adam Roben.

        [CSS Gradients] Crash due to out-of-memory with repeating-linear-gradient and latter stop positioned before former
        https://bugs.webkit.org/show_bug.cgi?id=52732
        
        When repeating gradient stops, make sure that the first and last stops are not at the same
        place, otherwise we'll add stops indefinitely and run out of memory.

        Test: fast/gradients/zero-range-repeating-gradient-hang.html

        * css/CSSGradientValue.cpp:
        (WebCore::CSSGradientValue::addStops):

1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
2011-01-14  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Remove event forwarding logic from input[type=range], simplify event flow and thumb positioning logic.
        https://bugs.webkit.org/show_bug.cgi?id=52464

        This change has two parts:

        1) Utilize shadow DOM event retargeting to get rid of forwarding events
           via render tree;
        2) Move thumb positioning logic from RenderSlider to SliderThumbElement.

        These two are highly co-dependent. It looked ugly when I tried to
        separate them.

        No change in behavior, covered by existing tests.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::defaultEventHandler): Added invocation of
            InputType::handleMouseDownEvent.
        * html/InputType.cpp:
        (WebCore::InputType::handleMouseDownEvent): Added empty decl.
        * html/InputType.h: Added def.
        * html/RangeInputType.cpp:
        (WebCore::RangeInputType::handleMouseDownEvent): Added to handle the case
            when the user clicks on the track of the slider. Also removed the
            forwardEvent method.
        * html/RangeInputType.h: Added/removed defs.
        * html/shadow/SliderThumbElement.cpp:
        (WebCore::SliderThumbElement::dragFrom): Added a helper method to start
            dragging from any position.
        (WebCore::SliderThumbElement::dragTo): Added a helper method to drag to
            specified position.
        (WebCore::SliderThumbElement::setPosition): Collapsed most of the positioning
            logic in RenderSlider into this method, which is now a simple calculation
            and adjusting of thumb position based on supplied coordinates.
        (WebCore::SliderThumbElement::startDragging): Added.
        (WebCore::SliderThumbElement::stopDragging): Added.
        (WebCore::SliderThumbElement::defaultEventHandler): Removed most of the
            old position-sniffing logic and replaced with simple calls to start,
            stop, and drag the thumb.
        * html/shadow/SliderThumbElement.h: Added defs.
        * rendering/RenderSlider.cpp: Removed a bunch of code that is no longer
            necessary.
        * rendering/RenderSlider.h: Removed defs, removed now-unnecessary friendliness.

1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
2011-01-19  Shane Stephens  <shanestephens@google.com>

        Reviewed by Chris Marrin.

        Make AffineTransform and TransformationMatrix do matrix multiplication in the correct order (Column Major)
        https://bugs.webkit.org/show_bug.cgi?id=48031

        Fixed reversal, renamed matrix methods to be clearer, found all examples of operator* and
        operator*= usage and switched operand order.

        No new tests as this refactor doesn't add functionality.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::baseTransform):
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::transform):
        (WebCore::CanvasRenderingContext2D::setTransform):
        * platform/graphics/cg/PatternCG.cpp:
        (WebCore::Pattern::createPlatformPattern):
        * platform/graphics/chromium/GLES2Canvas.cpp:
        (WebCore::GLES2Canvas::fillRect):
        (WebCore::GLES2Canvas::concatCTM):
        (WebCore::GLES2Canvas::drawQuad):
        * platform/graphics/chromium/TransparencyWin.cpp:
        (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
        (WebCore::TransparencyWin::setupTransformForKeepTransform):
        * platform/graphics/transforms/AffineTransform.cpp:
        (WebCore::AffineTransform::multiply):
        (WebCore::AffineTransform::rotate):
        * platform/graphics/transforms/AffineTransform.h:
        (WebCore::AffineTransform::operator*=):
        (WebCore::AffineTransform::operator*):
        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::GraphicsContextPlatformPrivate::concatCTM):
        * platform/graphics/wince/SharedBitmap.cpp:
        (WebCore::SharedBitmap::drawPattern):
        * rendering/svg/RenderSVGResourceContainer.cpp:
        (WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
        * rendering/svg/RenderSVGResourceGradient.cpp:
        (WebCore::clipToTextMask):
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/svg/RenderSVGResourcePattern.cpp:
        (WebCore::RenderSVGResourcePattern::applyResource):
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::localToBorderBoxTransform):
        * rendering/svg/SVGImageBufferTools.cpp:
        (WebCore::SVGImageBufferTools::calculateTransformationToOutermostSVGCoordinateSystem):
        (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
        * rendering/svg/SVGTextLayoutEngine.cpp:
        (WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
        * svg/SVGLocatable.cpp:
        (WebCore::SVGLocatable::computeCTM):
        (WebCore::SVGLocatable::getTransformToElement):
        * svg/SVGMatrix.h:
        (WebCore::SVGMatrix::multiply):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::localCoordinateSpaceTransform):
        (WebCore::SVGSVGElement::viewBoxToViewTransform):
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::animatedLocalTransform):
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::animatedLocalTransform):
        * svg/SVGTransformList.cpp:
        (WebCore::SVGTransformList::concatenate):

1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
2011-01-19  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Darin Adler.

        The return value of contentEditable() function should depend on the DOM attribute
        instead of render style userModify. The code change fixed test cases in the bug
        and partially fixed test cases in other contentEditable bugs;

        https://bugs.webkit.org/show_bug.cgi?id=52056

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::contentEditable):

1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
2011-01-19  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Darin Adler.

        Changing RenderText::localCaretRect to clip to its containing block's logicalLeft and
        logicalRightLayoutOverflow instead of simply using logicalLeft and logicalRight, as this
        resulted in the caret being placed incorrectly in overflowing editable IFrame content.

        Long lines in non-white-space-pre editable documents show cursor in wrong place
        https://bugs.webkit.org/show_bug.cgi?id=48132

        Test: editing/selection/caret-painting-in-overflowing-autowrap-content.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::localCaretRect):

1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
2011-01-19  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        WK2 - Multiple crashes in PlatformCALayer::replaceSublayer
        https://bugs.webkit.org/show_bug.cgi?id=52695

        Added ASSERTs to the places we assume a non-null superlayer.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::ensureStructuralLayer):
        (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):

1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
2011-01-18  Beth Dakin  <bdakin@apple.com>

        Reviewed by Maciej Stachowiak.

        Fix for <rdar://problem/8882916> Overlay scrollers require 
        content to layout underneath the scrollbar area

        The render tree should not include scrollbar size for
        overlay scrollers. This patch will allow scrollers on
        the WebView to behave like overflow:overlay.

        Treat overlay scrollers the same way as the !includeScrollbars
        case.
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::visibleContentRect):

        No corner rect for overlay scrollers.
        (WebCore::ScrollView::scrollCornerRect):

        usesOverlayScrollbars() currently always returns no.
        * platform/ScrollbarTheme.h:
        (WebCore::ScrollbarTheme::usesOverlayScrollbars):
        * platform/mac/ScrollbarThemeMac.h:
        * platform/mac/ScrollbarThemeMac.mm:
        (WebCore::ScrollbarThemeMac::usesOverlayScrollbars):

        includeVerticalScrollbarSize() and includeHorizontalScrollbarSize()
        should return false for overlay scrollers. They already return
        false for overflow:overlay.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::includeVerticalScrollbarSize):
        (WebCore::RenderBox::includeHorizontalScrollbarSize):
        * rendering/RenderBox.h:

        In the render tree, always treat overlay scrollers like
        they have a width and height of 0.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::verticalScrollbarWidth):
        (WebCore::RenderLayer::horizontalScrollbarHeight):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::verticalScrollbarWidth):

1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
2011-01-18  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] simplify complex text code, fixing a handful of layout tests
        https://bugs.webkit.org/show_bug.cgi?id=52661

        Change ComplexTextControllerLinux to lay out RTL text to the left from
        the starting point.  (Previously it always went to the right.)  This allows
        us to map pixel offsets more directly into offsets within the text runs,
        simplifying a few of the text-fiddling functions (they no longer need to
        track the current position, as ComplexTextController now does it).

        * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
        (WebCore::ComplexTextController::ComplexTextController):
        (WebCore::ComplexTextController::reset):
        (WebCore::ComplexTextController::setGlyphXPositions):
        * platform/graphics/chromium/ComplexTextControllerLinux.h:
        (WebCore::ComplexTextController::offsetX):
        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        (WebCore::glyphIndexForXPositionInScriptRun):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):

1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
2011-01-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: move methods from InjectedScript domain into DOM,
        Runtime and Debugger domains. Introduce InspectorRuntimeAgent.
        https://bugs.webkit.org/show_bug.cgi?id=52717

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::evaluateOnCallFrame):
        (WebCore::InjectedScript::getCompletions):
        (WebCore::InjectedScript::getCompletionsOnCallFrame):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::injectedScriptForMainWorld):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptSource.js:
        (.):
        ():
        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::releaseFrontendLifetimeAgents):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::resolveNode):
        (WebCore::InspectorDOMAgent::getNodeProperties):
        (WebCore::InspectorDOMAgent::getNodePrototypes):
        (WebCore::InspectorDOMAgent::injectedScriptForNodeId):
        * inspector/InspectorDOMAgent.h:
        (WebCore::EventListenerInfo::EventListenerInfo):
        (WebCore::InspectorDOMAgent::DOMListener::~DOMListener):
        (WebCore::InspectorDOMAgent::create):
        (WebCore::InspectorDOMAgent::cast):
        (WebCore::InspectorDOMAgent::documents):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
        (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
        (WebCore::InspectorDebuggerAgent::injectedScriptForCallFrameId):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorRuntimeAgent.cpp: Added.
        (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
        (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
        (WebCore::InspectorRuntimeAgent::evaluate):
        (WebCore::InspectorRuntimeAgent::getCompletions):
        (WebCore::InspectorRuntimeAgent::getProperties):
        (WebCore::InspectorRuntimeAgent::setPropertyValue):
        (WebCore::InspectorRuntimeAgent::pushNodeToFrontend):
        (WebCore::InspectorRuntimeAgent::injectedScriptForObjectId):
        * inspector/InspectorRuntimeAgent.h: Copied from Source/WebCore/inspector/InjectedScript.h.
        (WebCore::InspectorRuntimeAgent::create):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.completions):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):

1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
2011-01-18  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add UglifyJS parser and formatter files
        https://bugs.webkit.org/show_bug.cgi?id=51702

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ScriptFormatter.js:
        (WebInspector.ScriptFormatter.positionToLocation):
        (WebInspector.ScriptFormatter.prototype.format.messageHandler):
        (WebInspector.ScriptFormatter.prototype.format):
        (WebInspector.ScriptFormatter.prototype._buildMapping):
        (WebInspector.ScriptFormatter.prototype._convertPosition):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.formatSource.didFormat):
        (WebInspector.SourceFrame.prototype.formatSource):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/parse-js.js: Added. UglifyJS parser.
        * inspector/front-end/process.js: Added. UglifyJS formatter.
        * inspector/front-end/scriptFormatterWorker.js: Added. Worker script that wraps UglifyJS code.
        (onmessage):
        (beautify):
        (loadModule):
        (require):
        * inspector/front-end/utilities.js:
        ():

1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
2011-01-19  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [JSC] scripts have incorrect starting line (always 1).
        https://bugs.webkit.org/show_bug.cgi?id=52721

        Test: inspector/debugger-scripts.html

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::dispatchDidParseSource):
        (WebCore::ScriptDebugServer::dispatchFailedToParseSource):
        (WebCore::ScriptDebugServer::sourceParsed):
        * bindings/js/ScriptDebugServer.h:
        * bindings/js/ScriptSourceCode.h:
        (WebCore::ScriptSourceCode::ScriptSourceCode):
        * bindings/js/StringSourceProvider.h:
        (WebCore::StringSourceProvider::create):
        (WebCore::StringSourceProvider::startPosition):
        (WebCore::StringSourceProvider::StringSourceProvider):

1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
2011-01-19  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Send origin/url as part of speech input requests to the embedder.
        https://bugs.webkit.org/show_bug.cgi?id=52718

        * page/SpeechInput.cpp:
        (WebCore::SpeechInput::startRecognition): Pass up additional origin parameter.
        * page/SpeechInput.h:
        * page/SpeechInputClient.h:
        * platform/mock/SpeechInputClientMock.cpp:
        (WebCore::SpeechInputClientMock::startRecognition): Updated prototype.
        * platform/mock/SpeechInputClientMock.h:
        * rendering/TextControlInnerElements.cpp:
        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): Pass the frame origin to speech input request.

1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
2011-01-19  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Support auto-increment keys
        https://bugs.webkit.org/show_bug.cgi?id=52576

        Add support for auto-increment keys.

        Test: storage/indexeddb/objectstore-autoincrement.html

        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::createObjectStore):
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::genAutoIncrementKey):
        (WebCore::IDBObjectStoreBackendImpl::putInternal):

1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
2011-01-19  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Laszlo Gombos and Tor Arne Vestbø.

        [Qt] Remove unnecessary "../Source" from paths
        after moving source files into Source is finished.

        * WebCore.pri:
        * WebCore.pro:

1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
2011-01-19  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Employ TextPrompt for CSS property name/value autocompletion
        https://bugs.webkit.org/show_bug.cgi?id=52212

        WebInspector.CSSKeywordCompletions contains a hand-written list of accepted CSS property value keywords
        for each property. WebInspector.TextPrompt is used to suggest both the name and value keywords while
        editing styles, in place of the old custom suggestion code.

        * inspector/front-end/CSSCompletions.js:
        (WebInspector.CSSCompletions.prototype.startsWith): Fix array-out-of-bounds error.
        * inspector/front-end/CSSKeywordCompletions.js: Added.
        (WebInspector.CSSKeywordCompletions.forProperty):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
        (WebInspector.StylePropertyTreeElement.prototype):
        ():
        * inspector/front-end/TextPrompt.js:
        (WebInspector.TextPrompt):
        (WebInspector.TextPrompt.prototype.removeFromElement):
        (WebInspector.TextPrompt.prototype._onKeyDown):
        (WebInspector.TextPrompt.prototype.tabKeyPressed):
        (WebInspector.TextPrompt.prototype.upKeyPressed):
        (WebInspector.TextPrompt.prototype.downKeyPressed):
        (WebInspector.TextPrompt.prototype._moveBackInHistory):
        (WebInspector.TextPrompt.prototype._moveForwardInHistory):
        * inspector/front-end/inspector.css:
        (.auto-complete-text, .editing .auto-complete-text):
        * inspector/front-end/inspector.html:

1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
2011-01-19  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        Implement onformchange and onforminput event handlers
        https://bugs.webkit.org/show_bug.cgi?id=26141

        Tests: fast/forms/formchange-event.html
               fast/forms/forminput-event.html

        * bindings/scripts/CodeGeneratorGObject.pm: Added event names.
        * dom/Document.h: Added event definitions.
        * dom/Document.idl: Added event definitions.
        * dom/Element.h: Added event definitions.
        * dom/Element.idl: Added event definitions.
        * dom/Event.cpp:
        (WebCore::Event::fromUserGesture): Added a condition for a formchange event in handling user gestures.
        * dom/EventNames.h: Added event definitions.
        * dom/InputElement.cpp:
        (WebCore::InputElement::setValueFromRenderer): Replaced a direct dispatchEvent() call into dispatchInputEvents(), a virtual function which broadcasts forminput events for HTML elements.
        * dom/Node.cpp:
        (WebCore::Node::dispatchInputEvents): Defined basic dispatchInputEvents() described above.
        (WebCore::Node::dispatchChangeEvents): Defined basic dispatchChangeEvents() described above.
        (WebCore::Node::defaultEventHandler): Replaced a direct dispatchEvent() call into dispatchInputEvents().
        * dom/Node.h:
        * html/FormAssociatedElement.h: Added isResettable() to check the element is resettable or not.
        * html/HTMLAttributeNames.in: Added event names.
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::parseMappedAttribute): Added event handling.
        (WebCore::HTMLElement::shadowAncestorOwnerForm): Added to get an ancestor <form> element from a shadow element.
        (WebCore::HTMLElement::dispatchChangeEvents): Defined dispatchChangeEvents() for HTML elements described above.
        (WebCore::HTMLElement::dispatchInputEvents): Defined dispatchInputEvents() for HTML elements described above.
        * html/HTMLElement.h:
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Added calling dispatchFormChange() to broadcast formchange events.
        (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Defined newly to dispatch an input event with broadcasting forminput events.
        * html/HTMLFormControlElement.h: Added isResettable().
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::broadcastFormEvent): Added to broadcast forminput or formchange events.
        (WebCore::HTMLFormElement::dispatchFormInput): Defined newly to broadcast forminput events.
        (WebCore::HTMLFormElement::dispatchFormChange): Defined newly to broadcast formchange events.
        * html/HTMLFormElement.h:
        * html/HTMLFormElement.idl: Added dispatchFormInput() and dispatchFormChange() DOM API definitions.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::stepUpFromRenderer): Replaced a direct dispatchEvent() call into dispatchInputEvents().
        * html/HTMLInputElement.h: Added isResettable().
        * html/HTMLKeygenElement.h: Added isResettable().
        * html/HTMLObjectElement.h: Added isResettable().
        * html/HTMLOutputElement.h: Added isResettable().
        * html/HTMLSelectElement.h: Added isResettable().
        * html/HTMLTextAreaElement.h: Added isResettable().
        * page/DOMWindow.h: Added event definitions.
        * page/DOMWindow.idl: Added event definitions.
        * rendering/TextControlInnerElements.cpp:
        (WebCore::SearchFieldCancelButtonElement::defaultEventHandler): Replaced a direct dispatchEvent() call into dispatchInputEvents().

1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
2011-01-19  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] delete pending callback from callback map before invoking it
        https://bugs.webkit.org/show_bug.cgi?id=52707

        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI.ExtensionServerClient.prototype._onCallback):

1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
2011-01-19  Levi Weintraub  <leviw@google.com>

        Reviewed by Ryosuke Niwa.

        Replaced rangeCompliantEquivalent with Position::parentAnchoredEquivalent
        and simplified the logic a bit. Unfortunately, Tables and some legacy
        editing positions still need to be handled specifically.

        remove rangeCompliantEquivalent and replace it with Position methods
        https://bugs.webkit.org/show_bug.cgi?id=25057

        No new tests as this is a refactor that doesn't change behavior.

        * WebCore.exp.in:
        * dom/Document.cpp:
        (WebCore::Document::caretRangeFromPoint):
        * dom/Position.cpp:
        (WebCore::Position::parentAnchoredEquivalent):
        * dom/Position.h:
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyBlockStyle):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::insertNodeAt):
        (WebCore::CompositeEditCommand::moveParagraphs):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializePositionData):
        (WebCore::DeleteSelectionCommand::mergeParagraphs):
        * editing/Editor.cpp:
        (WebCore::Editor::textDirectionForSelection):
        (WebCore::Editor::advanceToNextMisspelling):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::shouldUseBreakElement):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::handleStyleSpansBeforeInsertion):
        * editing/VisiblePosition.cpp:
        (WebCore::makeRange):
        (WebCore::setStart):
        (WebCore::setEnd):
        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::firstRange):
        (WebCore::VisibleSelection::toNormalizedRange):
        (WebCore::makeSearchRange):
        * editing/htmlediting.cpp:
        (WebCore::indexForVisiblePosition):
        * editing/htmlediting.h:
        * editing/visible_units.cpp:
        (WebCore::previousBoundary):
        (WebCore::nextBoundary):
        * page/DOMSelection.cpp:
        (WebCore::anchorPosition):
        (WebCore::focusPosition):
        (WebCore::basePosition):
        (WebCore::extentPosition):

1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
2011-01-19  Peter Rybin  <peter.rybin@gmail.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: script column offset is incorrect
        https://bugs.webkit.org/show_bug.cgi?id=52580

        Column is updated in 3 places, 2 less probable places contained error.
        Fixed now.

        * platform/text/SegmentedString.cpp:
        (WebCore::SegmentedString::advanceSlowCase):
        * platform/text/SegmentedString.h:
        (WebCore::SegmentedString::advancePastNewline):

1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
2011-01-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make InjectedScriptAccess API a part of Web Inspector protocol.
        https://bugs.webkit.org/show_bug.cgi?id=52652

        Calls served by the InjectedScript should be first class protocol
        citizens, not dispatched via single protocol message.

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::evaluate):
        (WebCore::InjectedScript::evaluateInCallFrame):
        (WebCore::InjectedScript::evaluateOnSelf):
        (WebCore::InjectedScript::getCompletions):
        (WebCore::InjectedScript::getProperties):
        (WebCore::InjectedScript::pushNodeToFrontend):
        (WebCore::InjectedScript::resolveNode):
        (WebCore::InjectedScript::getNodeProperties):
        (WebCore::InjectedScript::getNodePrototypes):
        (WebCore::InjectedScript::setPropertyValue):
        (WebCore::InjectedScript::makeCall):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::evaluate):
        (WebCore::InjectedScriptHost::evaluateInCallFrame):
        (WebCore::InjectedScriptHost::evaluateOnSelf):
        (WebCore::InjectedScriptHost::getCompletions):
        (WebCore::InjectedScriptHost::getProperties):
        (WebCore::InjectedScriptHost::pushNodeToFrontend):
        (WebCore::InjectedScriptHost::resolveNode):
        (WebCore::InjectedScriptHost::getNodeProperties):
        (WebCore::InjectedScriptHost::getNodePrototypes):
        (WebCore::InjectedScriptHost::setPropertyValue):
        (WebCore::InjectedScriptHost::injectedScriptForObjectId):
        (WebCore::InjectedScriptHost::injectedScriptForNodeId):
        (WebCore::InjectedScriptHost::injectedScriptForMainWorld):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptSource.js:
        (.):
        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        * inspector/InspectorController.h:
        * inspector/InspectorValues.cpp:
        (WebCore::InspectorObject::getNumber):
        * inspector/InspectorValues.h:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.evaluateInTargetWindow):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.completions):
        (WebInspector.ConsoleView.prototype.doEvalInWindow):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
        * inspector/front-end/ExtensionPanel.js:
        (WebInspector.ExtensionWatchSidebarPane.prototype.setExpression):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
        * inspector/front-end/InjectedScriptAccess.js: Removed.
        * inspector/front-end/PropertiesSidebarPane.js:
        (WebInspector.PropertiesSidebarPane.prototype.update.callback):
        (WebInspector.PropertiesSidebarPane.prototype.update):
        * inspector/front-end/RemoteObject.js:
        (WebInspector.RemoteObject.resolveNode):
        (WebInspector.RemoteObject.prototype.getProperties):
        (WebInspector.RemoteObject.prototype.setPropertyValue):
        (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2011-01-18  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        [v8] Minor cleanup: make 2nd argument of removeIfPresnt accept only a value type stored in the DOM map
        https://bugs.webkit.org/show_bug.cgi?id=51683

        Covered by the existing tests.

        * bindings/v8/DOMDataStore.cpp:
        (WebCore::DOMDataStore::weakNodeCallback):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::removeIfPresent):
        * bindings/v8/DOMDataStore.h:
        * bindings/v8/V8DOMMap.h:
        (WebCore::WeakReferenceMap::removeIfPresent):

2008
2009
2011-01-18 MORITA Hajime  <morrita@google.com>

2010
2011
        Reviewed by Ryosuke Niwa.
        
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
        Refactoring: EventHandler::handleTextInputEvent should accept an enum instead of bools.
        https://bugs.webkit.org/show_bug.cgi?id=52608

        No new tests. no behavioral change.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/TextEvent.cpp:
        (WebCore::TextEvent::create):
        (WebCore::TextEvent::createForDrop):
        (WebCore::TextEvent::TextEvent):
        * dom/TextEvent.h:
        (WebCore::TextEvent::isLineBreak):
        (WebCore::TextEvent::isBackTab):
        (WebCore::TextEvent::isPaste):
        (WebCore::TextEvent::isDrop):
        * dom/TextEventInputType.h: Added. Extracted from TextEvent::TextInputType.
        * editing/EditorCommand.cpp:
        (WebCore::executeInsertBacktab):
        (WebCore::executeInsertLineBreak):
        (WebCore::executeInsertNewline):
        (WebCore::executeInsertTab):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleTextInputEvent):
        * page/EventHandler.h:

2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2011-01-18  Ben Vanik  <ben.vanik@gmail.com>

        Reviewed by Kenneth Russell.

        Updating ANGLE in WebKit to r533.
        https://bugs.webkit.org/show_bug.cgi?id=47194

        * platform/graphics/ANGLEWebKitBridge.cpp:
        (WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
        (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge):
        (WebCore::ANGLEWebKitBridge::validateShaderSource):
        Update to new ANGLE API for shader validation.
        * platform/graphics/ANGLEWebKitBridge.h:
        (WebCore::ANGLEWebKitBridge::setResources): 
        Renaming types to new names.
        * platform/graphics/mac/GraphicsContext3DMac.mm:
        (WebCore::GraphicsContext3D::GraphicsContext3D):
        Initialize ANGLEResources with ANGLE init call to prevent uninitialized variables.

2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2011-01-18  MORITA Hajime  <morrita@google.com>

        Reviewed by Simon Fraser.

        Refactoring: Extract RoundedIntRect class
        https://bugs.webkit.org/show_bug.cgi?id=51664

        RoundedIntRect is a pair of rect and four IntSize objects which represent
        corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
        Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
        return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
        and other functions accept RoundedIntRect as an argument.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::addRoundedRectClip):
        (WebCore::GraphicsContext::clipOutRoundedRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/RoundedIntRect.cpp: Added.
        (WebCore::RoundedIntRect::Radii::isZero):
        (WebCore::RoundedIntRect::Radii::scale):
        (WebCore::RoundedIntRect::Radii::expand):
        (WebCore::RoundedIntRect::Radii::includeLogicalEdges):
        (WebCore::RoundedIntRect::Radii::excludeLogicalEdges):
        (WebCore::RoundedIntRect::RoundedIntRect):
        (WebCore::RoundedIntRect::includeLogicalEdges):
        (WebCore::RoundedIntRect::excludeLogicalEdges):
        * platform/graphics/RoundedIntRect.h: Added.
        (WebCore::RoundedIntRect::Radii::Radii):
        (WebCore::RoundedIntRect::Radii::setTopLeft):
        (WebCore::RoundedIntRect::Radii::setTopRight):
        (WebCore::RoundedIntRect::Radii::setBottomLeft):
        (WebCore::RoundedIntRect::Radii::setBottomRight):
        (WebCore::RoundedIntRect::Radii::topLeft):
        (WebCore::RoundedIntRect::Radii::topRight):
        (WebCore::RoundedIntRect::Radii::bottomLeft):
        (WebCore::RoundedIntRect::Radii::bottomRight):
        (WebCore::RoundedIntRect::Radii::expand):
        (WebCore::RoundedIntRect::Radii::shrink):
        (WebCore::RoundedIntRect::rect):
        (WebCore::RoundedIntRect::radii):
        (WebCore::RoundedIntRect::isRounded):
        (WebCore::RoundedIntRect::isEmpty):
        (WebCore::RoundedIntRect::setRect):
        (WebCore::RoundedIntRect::setRadii):
        (WebCore::RoundedIntRect::move):
        (WebCore::RoundedIntRect::inflate):
        (WebCore::RoundedIntRect::inflateWithRadii):
        (WebCore::RoundedIntRect::expandRadii):
        (WebCore::RoundedIntRect::shrinkRadii):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::pushContentsClip):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        (WebCore::RenderBoxModelObject::paintBorder):
        (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
        (WebCore::RenderBoxModelObject::paintBoxShadow):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBoxSideFromPath):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::paint):
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintMenuListButtonGradients):
        (WebCore::RenderThemeMac::paintSliderTrack):
        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
        (WebCore::RenderThemeSafari::paintSliderTrack):
        * rendering/RenderThemeWinCE.cpp:
        (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        * rendering/style/BorderData.h:
        * rendering/style/RenderStyle.cpp:
        (WebCore::calcRadiiFor):
        (WebCore::calcConstraintScaleFor):
        (WebCore::RenderStyle::getRoundedBorderFor):
        (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::setBorderRadius):

2011-01-18  MORITA Hajime  <morrita@google.com>

        Reviewed by Simon Fraser.

        Refactoring: Extract RoundedIntRect class
        https://bugs.webkit.org/show_bug.cgi?id=51664

        RoundedIntRect is a pair of rect and four IntSize objects which represent
        corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
        Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
        return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
        and other functions accept RoundedIntRect as an argument.

        No new tests. No behavioral change.

        * Android.mk:
        * CMakeLists.txt:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::addRoundedRectClip):
        (WebCore::GraphicsContext::clipOutRoundedRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/RoundedIntRect.cpp: Added.
        (WebCore::RoundedIntRect::Radii::isZero):
        (WebCore::RoundedIntRect::Radii::scale):
        (WebCore::RoundedIntRect::Radii::expand):
        (WebCore::RoundedIntRect::Radii::includeLogicalEdges):
        (WebCore::RoundedIntRect::Radii::excludeLogicalEdges):
        (WebCore::RoundedIntRect::RoundedIntRect):
        (WebCore::RoundedIntRect::includeLogicalEdges):
        (WebCore::RoundedIntRect::excludeLogicalEdges):
        * platform/graphics/RoundedIntRect.h: Added.
        (WebCore::RoundedIntRect::Radii::Radii):
        (WebCore::RoundedIntRect::Radii::setTopLeft):
        (WebCore::RoundedIntRect::Radii::setTopRight):
        (WebCore::RoundedIntRect::Radii::setBottomLeft):
        (WebCore::RoundedIntRect::Radii::setBottomRight):
        (WebCore::RoundedIntRect::Radii::topLeft):
        (WebCore::RoundedIntRect::Radii::topRight):
        (WebCore::RoundedIntRect::Radii::bottomLeft):
        (WebCore::RoundedIntRect::Radii::bottomRight):
        (WebCore::RoundedIntRect::Radii::expand):
        (WebCore::RoundedIntRect::Radii::shrink):
        (WebCore::RoundedIntRect::rect):
        (WebCore::RoundedIntRect::radii):
        (WebCore::RoundedIntRect::isRounded):
        (WebCore::RoundedIntRect::isEmpty):
        (WebCore::RoundedIntRect::setRect):
        (WebCore::RoundedIntRect::setRadii):
        (WebCore::RoundedIntRect::move):
        (WebCore::RoundedIntRect::inflate):
        (WebCore::RoundedIntRect::inflateWithRadii):
        (WebCore::RoundedIntRect::expandRadii):
        (WebCore::RoundedIntRect::shrinkRadii):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::pushContentsClip):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        (WebCore::RenderBoxModelObject::paintBorder):
        (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
        (WebCore::RenderBoxModelObject::paintBoxShadow):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBoxSideFromPath):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::paint):
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintMenuListButtonGradients):
        (WebCore::RenderThemeMac::paintSliderTrack):
        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
        (WebCore::RenderThemeSafari::paintSliderTrack):
        * rendering/RenderThemeWinCE.cpp:
        (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        * rendering/style/BorderData.h:
        * rendering/style/RenderStyle.cpp:
        (WebCore::calcRadiiFor):
        (WebCore::calcConstraintScaleFor):
        (WebCore::RenderStyle::getRoundedBorderFor):
        (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::setBorderRadius):

2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2011-01-18  Victoria Kirst  <vrk@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Adding support for YV16 video frame formats.
        https://bugs.webkit.org/show_bug.cgi?id=52345

        * platform/graphics/chromium/VideoLayerChromium.cpp:
        (WebCore::VideoLayerChromium::determineTextureFormat):
        (WebCore::VideoLayerChromium::draw):

2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2011-01-18  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/8479998> REGRESSION (r67660): broken button layout at devforums.apple.com
        
        Exclude floating objects from shrinking to avoid floats.  They should never do this.  Timing-related bugs could
        occur as a result of this mistake, and the change to rewrite pagination to defer layout of floats until they
        got encountered on the correct line exposed this issue.

        Added /fast/block/float/float-overflow-hidden-containing-block-width.html.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::shrinkToAvoidFloats):

2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2011-01-18  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Make CheckedInt<long> and CheckedInt<unsigned long> work
        https://bugs.webkit.org/show_bug.cgi?id=52401

        * html/canvas/CheckedInt.h:
        (WebCore::CheckedInt::CheckedInt): Merge with the patch provided by Benoit Jacob.
        * html/canvas/WebGLBuffer.cpp:
        (WebCore::WebGLBuffer::associateBufferDataImpl): Use CheckedInt<long> instead of CheckedInt<int>.
        (WebCore::WebGLBuffer::associateBufferSubDataImpl): Ditto.

2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2011-01-18  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        Must strip comments from WebGL shaders before enforcing character set
        https://bugs.webkit.org/show_bug.cgi?id=52390

        Strip comments from incoming shaders, preserving line numbers,
        before validating that they conform to the ESSL character set.
        Revert changes from http://trac.webkit.org/changeset/75735 which
        allowed invalid characters to be passed to certain APIs.

        Tested with WebGL layout tests, conformance test suite and several
        WebGL demos in both Safari and Chromium.

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::StripComments::StripComments::process):
        (WebCore::WebGLRenderingContext::shaderSource):

2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2011-01-18  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Stop instantiating legacy editing positions in DeleteSelectionCommand, IndentOudentCommand,
        InsertLineBreakCommand, InsertListCOmmand.cpp, InsertParagraphSeparatorCommand, and htmlediting.cpp
        https://bugs.webkit.org/show_bug.cgi?id=52644

        This is a cleanup to stop instantiating legacy editing positions in the following tests.
        firstDeepEditingPositionForNode and lastDeepEditingPositionForNode in htmlediting.h are not updated
        because doing so requires significant code changes. They are tracked on the bug 52642.

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializeStartEnd):
        (WebCore::updatePositionForNodeRemoval):
        (WebCore::DeleteSelectionCommand::removeNode):
        (WebCore::updatePositionForTextRemoval):
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::outdentParagraph):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply):
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApplyForSingleParagraph):
        (WebCore::InsertListCommand::unlistifyParagraph):
        (WebCore::InsertListCommand::listifyParagraph):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/htmlediting.cpp:
        (WebCore::enclosingBlock):
        (WebCore::enclosingList):
        (WebCore::enclosingListChild):
        (WebCore::indexForVisiblePosition):
        (WebCore::isNodeVisiblyContainedWithin):
        (WebCore::avoidIntersectionWithNode):

2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2011-01-18  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ryosuke Niwa.

        Tweak style in visible_units.cpp and TextIterator.cpp in preparation for another patch
        https://bugs.webkit.org/show_bug.cgi?id=52610

        This is a purely aesthetic change.

        * editing/TextIterator.cpp:
        (WebCore::SimplifiedBackwardsTextIterator::advance):
        * editing/visible_units.cpp:
        (WebCore::previousBoundary):

2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2011-01-18  Adam Klein  <adamk@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Replace ChromiumBridge::widgetSetCursor with ChromeClient::setCursor
        https://bugs.webkit.org/show_bug.cgi?id=42236

        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/WidgetChromium.cpp:
        (WebCore::Widget::setCursor):

2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2011-01-18  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        REGRESSION: A problem with Voiceover and finding links
        https://bugs.webkit.org/show_bug.cgi?id=52324

        Fallout from recent change to make WebCore return its own scroll view.
           1) There were two scroll views in the hierarchy, one which no needed to be ignored.
           2) Hit tests for sub frames needed to be offset.
           3) The check for whether an attachment is ignored must happen earlier than using
              the helpText to determine if an element should be ignored.

        Test: platform/mac/accessibility/iframe-with-title-correct-hierarchy.html

        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::elementAccessibilityHitTest):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
        * accessibility/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper scrollViewParent]):

2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2011-01-18  Adam Roben  <aroben@apple.com>

        Call alternate CFHTTPCookie functions if available

        Fixes <http://webkit.org/b/52637> <rdar://problem/8878984>.

        Reviewed by Darin Adler.

        * platform/network/cf/CookieJarCFNet.cpp: Added soft-linking macros to
        pull in the alternate CFHTTPCookie functions.

        (WebCore::cookieDomain):
        (WebCore::cookieExpirationTime):
        (WebCore::cookieName):
        (WebCore::cookiePath):
        (WebCore::cookieValue):
        Added these wrappers around the CFHTTPCookie functions. We call the
        alternate functions if they exist, otherwise fall back to the current
        functions.

        (WebCore::filterCookies):
        (WebCore::getRawCookies):
        (WebCore::deleteCookie):
        Changed to use the wrapper functions.

2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2011-01-18  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Filenames are converted to URLs during edit drags
        https://bugs.webkit.org/show_bug.cgi?id=52096

        * platform/gtk/DragDataGtk.cpp: Only advertise and deliver filenames as URLs if the
        conversion policy allows it.
        (WebCore::DragData::containsURL): Ditto.
        (WebCore::DragData::asURL): Ditto.

2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2011-01-18  Helder Correia  <helder@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
        https://bugs.webkit.org/show_bug.cgi?id=52611

        This is related to bug 52559. The shadow color alpha must be multiplied
        by the context brush alpha.

        Test: fast/canvas/canvas-fillPath-alpha-shadow.html

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillPath):

2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2011-01-18  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fail resource.requestContent() immediately for WebSocket resources
        https://bugs.webkit.org/show_bug.cgi?id=52628

        * English.lproj/localizedStrings.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
        * inspector/front-end/ExtensionServer.js: Do not expose webInspector.resources.Types in extensions API (obsolete)
        (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.Type.toUIString): Remove ResourceType.Media as it's not used.
        (WebInspector.Resource.Type.toString): ditto.
        (WebInspector.Resource.prototype.requestContent): Fail immediately for WebSocket resources.
        * inspector/front-end/inspector.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)

2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2011-01-18  Helder Correia  <helder@sencha.com>

        Reviewed by Dirk Schulze.

        REGRESSION(75139): SVG gradients are not applied to texts
        https://bugs.webkit.org/show_bug.cgi?id=52531

        r75139 caused a problem with filling and stroking text with a gradient
        fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
        was mixed up.

        Test: svg/css/text-gradient-shadow.svg

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillRect):

2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2011-01-18  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        Unable to indirectly animate visibility of SVGUseElement
        https://bugs.webkit.org/show_bug.cgi?id=50240

        SVGUseElement::recalcStyle should take care of its shadow
        tree's style recalculation when it is called with change >= Inherit
        or when childNeedsStyleRecalc() is true because in these two
        cases needStyleRecalc() may not be true.

        Test: svg/custom/use-inherit-style.svg

        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::recalcStyle):

2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2011-01-18  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: provide script length to frontend.
        https://bugs.webkit.org/show_bug.cgi?id=52620

        * inspector/Inspector.idl:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerDispatcher.prototype.parsedScriptSource):
        * inspector/front-end/Script.js:
        (WebInspector.Script):

zherczeg@webkit.org's avatar
zherczeg@webkit.org committed
2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2011-01-18  Zoltan Herczeg  <zherczeg@webkit.org>

        Rubber-stamped by Csaba Osztrogonác

        Fixing ChangeLog

        Removing a line introduced by
        http://trac.webkit.org/changeset/75743/trunk/Source/WebCore/ChangeLog
        Removing an unnecessary space before a time stamp.

2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2011-01-17  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [refactoring] use events to notify NetworkManager clients
        https://bugs.webkit.org/show_bug.cgi?id=52588

        * inspector/front-end/AuditLauncherView.js:
        (WebInspector.AuditLauncherView): Do not expose public interface to resource count. Do not reset resource count upon reset().
        (WebInspector.AuditLauncherView.prototype._resetResourceCount):
        (WebInspector.AuditLauncherView.prototype._onResourceStarted):
        (WebInspector.AuditLauncherView.prototype._onResourceFinished):
        * inspector/front-end/AuditsPanel.js: Do not expose public interface to resource start/finish events.
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer):
        (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
        (WebInspector.ExtensionServer.prototype.initExtensions):
        * inspector/front-end/NetworkManager.js: Dispatch events rather than directly call clients.
        (WebInspector.NetworkManager):
        (WebInspector.NetworkManager.prototype.willSendRequest):
        (WebInspector.NetworkManager.prototype.markResourceAsCached):
        (WebInspector.NetworkManager.prototype.didReceiveResponse):
        (WebInspector.NetworkManager.prototype.didReceiveContentLength):
        (WebInspector.NetworkManager.prototype.setInitialContent):
        (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
        (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
        (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
        (WebInspector.NetworkManager.prototype._startResource):
        (WebInspector.NetworkManager.prototype._finishResource):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel):
        (WebInspector.NetworkPanel.prototype._onResourceStarted):
        (WebInspector.NetworkPanel.prototype._appendResource):
        (WebInspector.NetworkPanel.prototype._onResourceUpdated):
        (WebInspector.NetworkPanel.prototype._refreshResource):
        (WebInspector.NetworkPanel.prototype._onMainResourceChanged):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel):
        (WebInspector.ResourcesPanel.prototype._refreshResource):

2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2011-01-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: preserve pause on exception state in settings.
        https://bugs.webkit.org/show_bug.cgi?id=52619

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::getInspectorState):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
        (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsState):
        (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):
        * inspector/front-end/inspector.js:
        (WebInspector.doLoadedDone.populateInspectorState):

2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2011-01-18  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [REGRESSION] JavaScript exceptions aren't shown in source frame.
        https://bugs.webkit.org/show_bug.cgi?id=52623

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleMessage):
        (WebInspector.ConsoleMessage.prototype._formatMessage):

2582
2583
2584
2585
2586
2587
2588
2011-01-18  Pavel Feldman  <pfeldman@chromium.org>

        Revert r76017. No need to guard InspectorInstrumentation:: in WebCore.

        * page/Page.cpp:
        (WebCore::networkStateChanged):

2589
2590
2591
2592
2593
2594
2595
2596
2597
2598
2011-01-18  Konstantin Tokarev  <annulen@yandex.ru>

        Reviewed by Kent Tamura.

        Fixed compilation when Inspector is disabled
        https://bugs.webkit.org/show_bug.cgi?id=52564

        * page/Page.cpp:
        (WebCore::networkStateChanged): Added ENABLE(INSPECTOR) guard

2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2011-01-18  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r76004, r76005, r76007, and r76011.
        http://trac.webkit.org/changeset/76004
        http://trac.webkit.org/changeset/76005
        http://trac.webkit.org/changeset/76007
        http://trac.webkit.org/changeset/76011
        https://bugs.webkit.org/show_bug.cgi?id=51664

        The r76004 broke pixel tests.
        (The failure was missed due to the tolerance.)

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::addRoundedRectClip):
        (WebCore::GraphicsContext::clipOutRoundedRect):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/RoundedIntRect.cpp: Removed.
        * platform/graphics/RoundedIntRect.h: Removed.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::pushContentsClip):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        (WebCore::RenderBoxModelObject::paintBorder):
        (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
        (WebCore::uniformlyExpandBorderRadii):
        (WebCore::RenderBoxModelObject::paintBoxShadow):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBoxSideFromPath):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::paint):
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintMenuListButtonGradients):
        (WebCore::RenderThemeMac::paintSliderTrack):
        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
        (WebCore::RenderThemeSafari::paintSliderTrack):
        * rendering/RenderThemeWinCE.cpp:
        (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        * rendering/style/BorderData.h:
        * rendering/style/RenderStyle.cpp:
        (WebCore::constrainCornerRadiiForRect):
        (WebCore::RenderStyle::getBorderRadiiForRect):
        (WebCore::RenderStyle::getInnerBorderRadiiForRectWithBorderWidths):
        * rendering/style/RenderStyle.h:

2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2011-01-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add source column field to debugger call frames.
        https://bugs.webkit.org/show_bug.cgi?id=52443

        * bindings/js/JavaScriptCallFrame.cpp:
        (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
        * bindings/js/JavaScriptCallFrame.h:
        (WebCore::JavaScriptCallFrame::create):
        (WebCore::JavaScriptCallFrame::line):
        (WebCore::JavaScriptCallFrame::column):
        (WebCore::JavaScriptCallFrame::update):
        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
        (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
        (WebCore::ScriptDebugServer::callEvent):
        (WebCore::ScriptDebugServer::atStatement):
        (WebCore::ScriptDebugServer::returnEvent):
        (WebCore::ScriptDebugServer::exception):
        (WebCore::ScriptDebugServer::willExecuteProgram):
        (WebCore::ScriptDebugServer::didExecuteProgram):
        (WebCore::ScriptDebugServer::didReachBreakpoint):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/DebuggerScript.js:
        ():
        * bindings/v8/JavaScriptCallFrame.cpp:
        (WebCore::JavaScriptCallFrame::column):
        * bindings/v8/JavaScriptCallFrame.h:
        * inspector/InjectedScriptSource.js:
        ():
        * inspector/JavaScriptCallFrame.idl:

zherczeg@webkit.org's avatar
zherczeg@webkit.org committed
2690
2011-01-18  Antti Koivisto  <antti@apple.com>
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2746
2747
2748
2749
2750
2751
2752
2753

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=52370
        <rdar://problem/8856808>
        Style sharing optimization no longer works on major web sites
        
        The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated 
        by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
        the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.  
        
        This patch gets the style sharing back to 25-40% range on most web sites.

        * css/CSSMutableStyleDeclaration.h:
        (WebCore::CSSMutableStyleDeclaration::propertiesEqual):
            
            Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.
        
        * css/CSSSelector.h:
        (WebCore::CSSSelector::isSiblingSelector):
        
            Test for selectors that are affected by the sibling elements.
        
        * css/CSSStyleSelector.cpp:
        (WebCore::elementCanUseSimpleDefaultStyle):
        (WebCore::collectSiblingRulesInDefaultStyle):
        (WebCore::assertNoSiblingRulesInDefaultStyle):
            
            Extract sibling rules from the MathML default stylesheet. 
            Assert that no other default stylesheet has them.
            
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::CSSStyleSelector::locateCousinList):
        (WebCore::CSSStyleSelector::matchesSiblingRules):
        (WebCore::CSSStyleSelector::canShareStyleWithElement):
        (WebCore::CSSStyleSelector::locateSharedStyle):
        (WebCore::CSSStyleSelector::styleForElement):
        (WebCore::collectIdsAndSiblingRulesFromList):
        (WebCore::CSSRuleSet::collectIdsAndSiblingRules):

            Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
            where style sharing can't be used.

        * css/CSSStyleSelector.h:
        * dom/NamedNodeMap.cpp:
        (WebCore::NamedNodeMap::mappedMapsEquivalent):
            
            Check also for CSSValue mutation from DOM. 
            
        * mathml/MathMLMathElement.cpp:
        (WebCore::MathMLMathElement::insertedIntoDocument):
        * mathml/MathMLMathElement.h:
        
            MathML default style sheet has sibling rules which don't get noticed by the normal document
            stylesheet parsing.
        
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::setFirstChildState):
        (WebCore::InheritedFlags::setLastChildState):
        (WebCore::InheritedFlags::setChildIndex):
        
            These all make style non-shareable (unique).

2754
2755
2756
2757
2758
2759
2760
2011-01-18  MORITA Hajime  <morrita@google.com>

        Unreviewed crash fix on release builds.

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):

2761
2762
2763
2764
2765
2766
2011-01-18  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, update localizedStrings.js.

        * English.lproj/localizedStrings.js:

2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2011-01-11  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: implement script beautifier prototype.
        https://bugs.webkit.org/show_bug.cgi?id=51588

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ScriptFormatter.js: Added.
        (WebInspector.ScriptFormatter): Implements JavaScript source beautification and conversion between original and
        formatted line numbers
        (WebInspector.ScriptFormatter.findLineEndings):
        (WebInspector.ScriptFormatter.locationToPosition):
        (WebInspector.ScriptFormatter.positionToLocation):
        (WebInspector.ScriptFormatter.upperBound):
        (WebInspector.ScriptFormatter.prototype.format):
        (WebInspector.ScriptFormatter.prototype.originalLineNumberToFormattedLineNumber):
        (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalLineNumber):
        (WebInspector.ScriptFormatter.prototype.originalPositionToFormattedLineNumber):
        (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalPosition):
        (WebInspector.ScriptFormatter.prototype._convertPosition):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected):
        (WebInspector.ScriptsPanel.prototype._formatScript):
        * inspector/front-end/SourceFrame.js: Convert original line numbers to UI line numbers and vice versa
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

2798
2799
2800
2801
2802
2803
2011-01-18  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK build fix as follow-up of r76004.

        * GNUmakefile.am: Include RoundedIntRect files in the build

2804
2805
2806
2807
2808
2809
2810
2811
2812
2813
2814
2011-01-18  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, rolling out r76002.
        http://trac.webkit.org/changeset/76002
        https://bugs.webkit.org/show_bug.cgi?id=49790

        breaks a bunch of fast/forms tests on mac and GTK

        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::setRenderStyle):

2815
2816
2817
2818
2819
2820
2011-01-18 MORITA Hajime <morrita@google.com>

        Unreviewed windows build fix.

        * WebCore.vcproj/WebCore.vcproj:

2821
2822
2823
2824
2825
2826
2827
2828
2829
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2882
2883
2884
2885
2886
2887
2888
2889
2890
2891
2892
2893
2894
2895
2896
2897
2898
2899
2900
2901
2902
2903
2904
2905
2906
2907
2908
2909
2910
2911
2912
2913
2914
2915
2916
2917
2918
2011-01-17  MORITA Hajime  <morrita@google.com>

        Reviewed by Simon Fraser.

        Refactoring: Extract RoundedIntRect class
        https://bugs.webkit.org/show_bug.cgi?id=51664

        RoundedIntRect is a pair of rect and four IntSize objects which represent
        corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
        Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
        return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
        and other functions accept RoundedIntRect as an argument.

        No new tests. No behavioral change.

        * Android.mk:
        * CMakeLists.txt:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::addRoundedRectClip):
        (WebCore::GraphicsContext::clipOutRoundedRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/RoundedIntRect.cpp: Added.
        (WebCore::RoundedIntRect::Radii::isZero):
        (WebCore::RoundedIntRect::Radii::scale):
        (WebCore::RoundedIntRect::Radii::expand):
        (WebCore::RoundedIntRect::Radii::includeLogicalEdges):
        (WebCore::RoundedIntRect::Radii::excludeLogicalEdges):
        (WebCore::RoundedIntRect::RoundedIntRect):
        (WebCore::RoundedIntRect::includeLogicalEdges):
        (WebCore::RoundedIntRect::excludeLogicalEdges):
        * platform/graphics/RoundedIntRect.h: Added.
        (WebCore::RoundedIntRect::Radii::Radii):
        (WebCore::RoundedIntRect::Radii::setTopLeft):
        (WebCore::RoundedIntRect::Radii::setTopRight):
        (WebCore::RoundedIntRect::Radii::setBottomLeft):
        (WebCore::RoundedIntRect::Radii::setBottomRight):
        (WebCore::RoundedIntRect::Radii::topLeft):
        (WebCore::RoundedIntRect::Radii::topRight):
        (WebCore::RoundedIntRect::Radii::bottomLeft):
        (WebCore::RoundedIntRect::Radii::bottomRight):
        (WebCore::RoundedIntRect::Radii::expand):
        (WebCore::RoundedIntRect::Radii::shrink):
        (WebCore::RoundedIntRect::location):
        (WebCore::RoundedIntRect::size):
        (WebCore::RoundedIntRect::x):
        (WebCore::RoundedIntRect::y):
        (WebCore::RoundedIntRect::width):
        (WebCore::RoundedIntRect::height):
        (WebCore::RoundedIntRect::right):
        (WebCore::RoundedIntRect::bottom):
        (WebCore::RoundedIntRect::rect):
        (WebCore::RoundedIntRect::radii):
        (WebCore::RoundedIntRect::isRounded):
        (WebCore::RoundedIntRect::isEmpty):
        (WebCore::RoundedIntRect::setRect):
        (WebCore::RoundedIntRect::setRadii):
        (WebCore::RoundedIntRect::move):
        (WebCore::RoundedIntRect::inflate):
        (WebCore::RoundedIntRect::inflateWithRadii):
        (WebCore::RoundedIntRect::expandRadii):
        (WebCore::RoundedIntRect::shrinkRadii):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::pushContentsClip):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        (WebCore::RenderBoxModelObject::paintBorder):
        (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
        (WebCore::RenderBoxModelObject::paintBoxShadow):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBoxSideFromPath):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::paint):
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintMenuListButtonGradients):
        (WebCore::RenderThemeMac::paintSliderTrack):
        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
        (WebCore::RenderThemeSafari::paintSliderTrack):
        * rendering/RenderThemeWinCE.cpp:
        (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        * rendering/style/BorderData.h:
        * rendering/style/RenderStyle.cpp:
        (WebCore::calcRadiiFor):
        (WebCore::calcConstraintScaleFor):
        (WebCore::RenderStyle::getRoundedBorderFor):
        (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::setBorderRadius):

2919
2920
2921
2922
2923
2924
2925
2926
2927
2928
2929
2930
2931
2932
2933
2934
2011-01-17  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by Kent Tamura.

        Color changes to option elements in a select multiple aren't drawn immediately
        https://bugs.webkit.org/show_bug.cgi?id=49790

        Redirect style changes on <option> element to the owner <select> element.

        Tests: fast/forms/select-option-background-color-change.html
               fast/forms/select-option-color-change.html
               fast/forms/select-option-visibility-change.html

        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::setRenderStyle):

2935
2936
2937
2938
2939
2940
2941
2942
2943
2944
2945
2946
2947
2948
2949
2011-01-17  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r75995.
        http://trac.webkit.org/changeset/75995
        https://bugs.webkit.org/show_bug.cgi?id=51914

        Causes assertion failures.

        * dom/Element.cpp:
        (WebCore::Element::shadowRoot):
        (WebCore::Element::setShadowRoot):
        (WebCore::Element::removeShadowRoot):
        * dom/ElementRareData.h:
        (WebCore::ElementRareData::ElementRareData):

2950
2951
2952
2953
2954
2955
2956
2957
2011-01-17  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r75999.
        http://trac.webkit.org/changeset/75999

        * dom/Element.cpp:
        (WebCore::Element::removeShadowRoot):

2958
2959
2960
2961
2962
2963
2964
2011-01-17 MORITA Hajime  <morrita@google.com>

        Unreviewed crash fix, which introduced at r75995

        * dom/Element.cpp:
        (WebCore::Element::removeShadowRoot):

2965
2966
2967
2968
2969
2970
2971
2972
2973
2974
2975
2976
2977
2978
2979
2980
2981
2982
2983
2984
2011-01-17  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        ElementRareData::m_shadowRoot should not be RefPtr.
        https://bugs.webkit.org/show_bug.cgi?id=51914

        This change makes m_shadowRoot a raw pointer, as Node::m_parent is.
        This change is safe because shadow host pointer is stored as TreeShared::m_parent
        which prevents deletion unless set to null.
        
        No test, no behavioral change.

        * dom/Element.cpp:
        (WebCore::Element::shadowRoot):
        (WebCore::Element::setShadowRoot):
        (WebCore::Element::removeShadowRoot):
        * dom/ElementRareData.h:
        (WebCore::ElementRareData::ElementRareData):

2985
2986
2987
2988
2989
2990
2991
2992
2993
2994
2995
2996
2997
2998
2999
3000
2011-01-17  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Some WebKit2 layout tests crash due to focus being on a frame in the page cache
        https://bugs.webkit.org/show_bug.cgi?id=52607

        No new tests. Existing tests crash in WebKit2 without this fix.
        
        I suspect there are other consequences besides the WebKit2 crash, but I
        was unable to identify any for certain.

        * history/CachedFrame.cpp:
        (WebCore::CachedFrame::CachedFrame): If a frame still has focus when its page
        goes in the page cache, reset focus to the main frame.

3001
3002
3003
3004
3005
3006
3007
3008
3009
3010
3011
3012
3013
3014
3015
3016
3017
3018
3019
3020
3021
3022
3023
3024
3025
3026
3027
3028
3029
3030
3031
3032
3033
3034
3035
3036
3037
3038
3039
3040
3041
3042
3043
3044
3045
2011-01-17  Adam Roben  <aroben@apple.com>

        Simplify WKCACFLayerRenderer's API

        createRenderer/destroyRenderer are now hidden behind setHostWindow.
        WKCACFLayerRendererClient::animationsStarted has been removed, as it
        was never called. (The work it was supposed to do was already being
        accomplished by WKCACFLayerRenderer::render telling each layer that
        animations are starting.)

        Fixes <http://webkit.org/b/52587> WKCACFLayerRenderer is hard to use

        Reviewed by Chris Marrin.

        * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
        (WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Moved the
        call to setHostWindow here from the WM_CREATE handler. The WM_CREATE
        handler was causing the Direct3D device to be created, but MSDN says
        you shouldn't create a device while handling WM_CREATE. Removed
        no-longer-needed call to createRenderer (setHostWindow does this now)
        and the never-needed call to setNeedsDisplay (we never draw into the
        root layer; this was just creating an unnecessary backing store the
        size of the screen!).
        (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Moved WM_CREATE
        code, as described above. Removed call to destroyRenderer when handling
        WM_DESTROY; setHostWindow does this now. Fixed up our WM_PAINT handler
        to do a synchronous paint and to clear our dirty region, while I was in
        here.

        * platform/graphics/win/WKCACFLayerRenderer.cpp:
        (WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Changed to call
        setHostWindow instead of destroyRenderer; the former calls the latter
        if needed.
        (WebCore::WKCACFLayerRenderer::setHostWindow): Moved here from the
        header file. Destroys our old renderer (i.e., IDirect3DDevice9) if
        we're losing our window, or creates a renderer if we're gaining a
        window.
        (WebCore::WKCACFLayerRenderer::createRenderer): Updated for WKSI function rename.
        (WebCore::WKCACFLayerRenderer::destroyRenderer): Changed to clear the
        D3D device from our context before releasing the device.

        * platform/graphics/win/WKCACFLayerRenderer.h: Removed
        WKCACFLayerRendererClient::animationsStarted. Removed setNeedsDisplay.
        Make createRenderer, destroyRenderer, and renderSoon private.

3046
3047
3048
3049
3050
3051
3052
3053
3054
3055
3056
3057
3058
3059
3060
3061
3062
3063
3064
3065
3066
3067
3068
3069
3070
3071
3072
3073
3074
3075
2011-01-17  Adam Roben  <aroben@apple.com>

        Remove special-cased support for providing content for the root layer

        Clients will just have to provide content through the normal
        GraphicsLayer channels now!

        Support for <http://webkit.org/b/52582> WebView should paint directly
        into a GraphicsLayer when in accelerated compositing mode

        Reviewed by Simon Fraser and Chris Marrin.

        * platform/graphics/win/WKCACFLayerRenderer.cpp:
        (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Removed
        initialization of m_backingStoreDirty, which has itself been removed.
        (WebCore::WKCACFLayerRenderer::setNeedsDisplay): Moved code to schedule
        a sync from here to syncCompositingStateSoon. We only need to call
        renderSoon if we don't call syncCompositingStateSoon; the latter
        function calls the former.
        (WebCore::WKCACFLayerRenderer::paint): Removed code to handle
        m_backingStoreDirty. We don't want to know anything about clients'
        backing stores.
        (WebCore::WKCACFLayerRenderer::syncCompositingStateSoon): Added. Code
        came from setNeedsDisplay.

        * platform/graphics/win/WKCACFLayerRenderer.h:
        Removed setRootContents[AndDisplay], setBackingStoreDirty, and
        m_backingStoreDirty. Made paint() public so that clients can force a
        synchronous render (e.g., when handling WM_PAINT).

3076
3077
3078
3079
3080
3081
3082
3083
3084
3085
3086
3087
3088
3089
3090
3091
3092
3093
3094
3095
3096
3097
2011-01-17  Adam Roben  <aroben@apple.com>

        Remove contexts from WKCACFContextFlusher before destroying them

        We aren't really using WKCACFContextFlusher for anything useful at the
        moment, but that will probably change in the near future.

        I couldn't come up with a way to test this because it isn't possible to
        resize a window in DumpRenderTree.

        Fixes <http://webkit.org/b/52573> REGRESSION (r75262): Crash beneath
        WKCACFContextFlusher::flushAllContexts when resizing window on page
        that uses accelerated compositing

        Reviewed by Simon Fraser.

        * platform/graphics/win/WKCACFLayerRenderer.cpp:
        (WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Remove our
        context from WKCACFContextFlusher. (This code was erroneously removed
        from WKCACFLayerRenderer::destroyRenderer in r75262. This is a more
        sensible place for it.)

3098
3099
3100
3101
3102
3103
3104
3105
3106
3107
3108
3109
3110
3111
3112
3113
3114
3115
3116
3117
3118
3119
3120
3121
3122
3123
3124
3125
3126
3127
3128
3129
3130
2011-01-17  Adam Roben  <aroben@apple.com>

        Don't access the CACFLayerRef's sublayers directly from PlatformCALayer

        There might be a secret extra sublayer (the tile parent layer) that
        PlatformCALayer doesn't know about. When PlatformCALayer would
        encounter this, it would try to use the tile parent layer's
        PlatformCALayer wrapper, which was null, and then would crash. We now
        ask PlatformCALayerWinInternal for the sublayer list, since that class
        knows about the tile parent layer and can exclude it from the sublayer
        list.

        Covered by compositing/tiling/huge-layer-resize.html.

        Fixes <http://webkit.org/b/52597> Crash beneath
        PlatformCALayer::adoptSublayers when switching out of tiling mode
        (null-dereference of a PlatformCALayer)

        Reviewed by Darin Adler and Chris Marrin.

        * platform/graphics/ca/win/PlatformCALayerWin.cpp:
        (PlatformCALayer::adoptSublayers):
        (printLayer):
        Changed to use PlatformCALayerWinInternal::getSublayers.

        * platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
        (PlatformCALayerWinInternal::getSublayers): Added. Retrieves the list
        of PlatformCALayers that represent our sublayers. Significantly, this
        code knows about the tile parent layer and can thus exclude it.

        * platform/graphics/ca/win/PlatformCALayerWinInternal.h: Added
        getSublayers.

3131
3132
3133
3134
3135
3136
3137
3138
3139
3140
3141
3142
3143
3144
3145
3146
3147
3148
2011-01-17  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Kent Tamura.

        [Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field.
        https://bugs.webkit.org/show_bug.cgi?id=51382
        http://crbug.com/60427

        Calculate correct location of popup window whenever the items in the window change.

        No new tests, because this fix is for Chromium project and hard to test only in WebKit project

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::layoutAndCalculateWidgetRect): New Function to layout and calculate popup widget rect.
        (WebCore::PopupContainer::showPopup): Move widgetRect calculation logic to calculateWidgetRect().
        (WebCore::PopupContainer::refresh): Add parameter focusRect to take the location and the size of focus text input field to calculate correct popup window location.
        * platform/chromium/PopupMenuChromium.h: Append new input parameter for refresh().

mrowe@apple.com's avatar
mrowe@apple.com committed
3149
3150
3151
3152
3153
3154
2011-01-17  Mark Rowe  <mrowe@apple.com>

        Fix the 32-bit build.

        * WebCore.exp.in:

3155
3156
3157
3158
3159
3160
3161
3162
3163
3164
3165
3166
3167
3168
2011-01-17  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        Use of invalid hash map key in CSSFontFaceSource::getFontData() with 0-sized remote font
        https://bugs.webkit.org/show_bug.cgi?id=52598

        Test: fast/css/font-face-zero-hash-key.html

        * css/CSSFontFaceSource.cpp:
        (WebCore::CSSFontFaceSource::getFontData): Add 1 to the font size to avoid a 0 hash key.
        * css/CSSSegmentedFontFace.cpp:
        (WebCore::CSSSegmentedFontFace::getFontData): Ditto.

3169
3170
3171