ChangeLog-2005-12-19 491 KB
Newer Older
eseidel's avatar
eseidel committed
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
2005-09-18  Eric Seidel  <eseidel@apple.com>

        No review needed, SVG build fix only.

        * WebCore+SVG/DrawDocument.mm:
        (-[DrawView primaryView]): cast to DrawView * (newer gcc fix)
        * kdom/cache/KDOMLoader.cpp:
        (Loader::slotFinished): toLong -> toInt
        * ksvg2/svg/SVGAngleImpl.cpp:
        (SVGAngleImpl::setValueAsString): toFloat -> toDouble
        * ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp:
        (SVGComponentTransferFunctionElementImpl::parseAttribute): ditto
        * ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp:
        (SVGFEGaussianBlurElementImpl::parseAttribute): ditto
        * ksvg2/svg/SVGFEOffsetElementImpl.cpp:
        (SVGFEOffsetElementImpl::parseAttribute): ditto
        * ksvg2/svg/SVGFETurbulenceElementImpl.cpp:
        (SVGFETurbulenceElementImpl::parseAttribute): ditto
        * ksvg2/svg/SVGFitToViewBoxImpl.cpp:
        (SVGFitToViewBoxImpl::parseViewBox): ditto
        * ksvg2/svg/SVGNumberListImpl.cpp:
        (SVGNumberListImpl::parse): ditto
        * ksvg2/svg/SVGStopElementImpl.cpp:
        (SVGStopElementImpl::parseAttribute): ditto

adele's avatar
adele committed
26
27
28
29
30
31
2005-09-16  Adele Peterson  <adele@apple.com>

        Rolling out the fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4924
            QPainter should use CGContext as much as possible rather than NSGraphicsContext 
        since it caused a performance regression.

adele's avatar
adele committed
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
2005-09-16  Adele Peterson  <adele@apple.com>

        Change by Darin, reviewed by me and Maciej.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=4547
        use int instead of long for 32-bit (to prepare for LP64 compiling)

        Changed longs (which IDL files use as 32-bit) to ints

        * ForwardingHeaders/khtml_pagecache.h:
        * khtml/css/css_base.h:
        (DOM::StyleListImpl::length):
        (DOM::StyleListImpl::item):
        * khtml/css/css_computedstyle.cpp:
        (DOM::CSSComputedStyleDeclarationImpl::length):
        (DOM::CSSComputedStyleDeclarationImpl::item):
        * khtml/css/css_computedstyle.h:
        * khtml/css/css_ruleimpl.cpp:
        (CSSMediaRuleImpl::append):
        (CSSMediaRuleImpl::insertRule):
        (CSSMediaRuleImpl::cssText):
        (CSSRuleListImpl::CSSRuleListImpl):
        (CSSRuleListImpl::deleteRule):
        (CSSRuleListImpl::insertRule):
        * khtml/css/css_ruleimpl.h:
        (DOM::CSSRuleListImpl::length):
        (DOM::CSSRuleListImpl::item):
        (DOM::CSSMediaRuleImpl::deleteRule):
        * khtml/css/css_stylesheetimpl.cpp:
        (CSSStyleSheetImpl::insertRule):
        (CSSStyleSheetImpl::addRule):
        (CSSStyleSheetImpl::deleteRule):
        (StyleSheetListImpl::length):
        (StyleSheetListImpl::item):
        * khtml/css/css_stylesheetimpl.h:
        (DOM::MediaListImpl::length):
        (DOM::MediaListImpl::item):
        * khtml/css/css_valueimpl.cpp:
        (DOM::CSSMutableStyleDeclarationImpl::length):
        (DOM::CSSMutableStyleDeclarationImpl::item):
        * khtml/css/css_valueimpl.h:
        (DOM::CSSValueListImpl::length):
        (DOM::CSSValueListImpl::item):
        * khtml/dom/css_rule.h:
        * khtml/dom/css_stylesheet.h:
        * khtml/dom/css_value.h:
        * khtml/dom/dom2_events.cpp:
        (DOM::UIEvent::detail):
        (DOM::UIEvent::initUIEvent):
        (DOM::MouseEvent::screenX):
        (DOM::MouseEvent::screenY):
        (DOM::MouseEvent::clientX):
        (DOM::MouseEvent::clientY):
        (DOM::MouseEvent::initMouseEvent):
        (DOM::KeyboardEvent::keyLocation):
        (DOM::KeyboardEvent::initKeyboardEvent):
        * khtml/dom/dom2_events.h:
        * khtml/dom/dom2_range.h:
        * khtml/dom/dom2_traversal.cpp:
        (DOM::NodeIterator::whatToShow):
        (DOM::TreeWalker::whatToShow):
        * khtml/dom/dom2_traversal.h:
        * khtml/dom/dom_node.h:
        * khtml/ecma/kjs_css.cpp:
        (KJS::DOMCSSStyleDeclaration::getOwnPropertySlot):
        (KJS::DOMStyleSheetList::getOwnPropertySlot):
        (KJS::DOMMediaList::getOwnPropertySlot):
        (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction):
        (KJS::DOMCSSRuleList::getOwnPropertySlot):
        (KJS::DOMCSSValueList::getOwnPropertySlot):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNodeList::getOwnPropertySlot):
        (KJS::DOMNodeList::callAsFunction):
        (KJS::DOMNamedNodeMap::getOwnPropertySlot):
        (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
        * khtml/ecma/kjs_events.cpp:
        (KJS::DOMEvent::getValueProperty):
        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLElement::getOwnPropertySlot):
        (KJS::KJS::HTMLElement::put):
        (KJS::HTMLCollection::getOwnPropertySlot):
        (KJS::KJS::HTMLCollection::callAsFunction):
        (KJS::KJS::HTMLSelectCollection::put):
        * khtml/ecma/kjs_navigator.cpp:
        (KJS::Plugins::getOwnPropertySlot):
        (KJS::MimeTypes::getOwnPropertySlot):
        (KJS::Plugin::getOwnPropertySlot):
        * khtml/editing/apply_style_command.cpp:
        (khtml::ApplyStyleCommand::splitTextAtStartIfNeeded):
        (khtml::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
        (khtml::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
        * khtml/editing/break_blockquote_command.cpp:
        (khtml::BreakBlockquoteCommand::doApply):
        * khtml/editing/composite_edit_command.cpp:
        (khtml::CompositeEditCommand::insertNodeAt):
        (khtml::CompositeEditCommand::splitTextNode):
        (khtml::CompositeEditCommand::splitTextNodeContainingElement):
        (khtml::CompositeEditCommand::insertTextIntoNode):
        (khtml::CompositeEditCommand::deleteTextFromNode):
        (khtml::CompositeEditCommand::replaceTextInNode):
        (khtml::CompositeEditCommand::deleteInsignificantText):
        * khtml/editing/composite_edit_command.h:
        * khtml/editing/delete_from_text_node_command.cpp:
        (khtml::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
        * khtml/editing/delete_from_text_node_command.h:
        (khtml::DeleteFromTextNodeCommand::offset):
        (khtml::DeleteFromTextNodeCommand::count):
        * khtml/editing/insert_into_text_node_command.cpp:
        (khtml::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
        * khtml/editing/insert_into_text_node_command.h:
        (khtml::InsertIntoTextNodeCommand::offset):
        * khtml/editing/insert_paragraph_separator_command.cpp:
        (khtml::InsertParagraphSeparatorCommand::doApply):
        * khtml/editing/insert_text_command.cpp:
        (khtml::InsertTextCommand::input):
        (khtml::InsertTextCommand::insertSpace):
        * khtml/editing/insert_text_command.h:
        (khtml::InsertTextCommand::charactersAdded):
        * khtml/editing/join_text_nodes_command.h:
        * khtml/editing/markup.cpp:
        (khtml::startMarkup):
        (khtml::completeURLs):
        * khtml/editing/move_selection_command.cpp:
        (khtml::MoveSelectionCommand::doApply):
        * khtml/editing/rebalance_whitespace_command.cpp:
        (khtml::RebalanceWhitespaceCommand::doApply):
        * khtml/editing/rebalance_whitespace_command.h:
        * khtml/editing/replace_selection_command.cpp:
        (khtml::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted):
        * khtml/editing/replace_selection_command.h:
        * khtml/editing/selection.cpp:
        (khtml::Selection::debugPosition):
        * khtml/editing/split_text_node_command.cpp:
        (khtml::SplitTextNodeCommand::SplitTextNodeCommand):
        * khtml/editing/split_text_node_command.h:
        (khtml::SplitTextNodeCommand::offset):
        * khtml/editing/split_text_node_containing_element.cpp:
        (khtml::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand):
        * khtml/editing/split_text_node_containing_element_command.h:
        * khtml/editing/visible_position.cpp:
        (khtml::VisiblePosition::VisiblePosition):
        (khtml::VisiblePosition::deepEquivalent):
        (khtml::VisiblePosition::rangeCompliantEquivalent):
        (khtml::VisiblePosition::maxOffset):
        (khtml::VisiblePosition::character):
        (khtml::VisiblePosition::debugPosition):
        * khtml/editing/visible_position.h:
        * khtml/editing/visible_range.h:
        * khtml/editing/visible_text.cpp:
        (khtml::CircularSearchBuffer::length):
        (khtml::TextIterator::TextIterator):
        (khtml::TextIterator::handleTextNode):
        (khtml::TextIterator::handleTextBox):
        (khtml::TextIterator::emitCharacter):
        (khtml::TextIterator::range):
        (khtml::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
        (khtml::SimplifiedBackwardsTextIterator::handleReplacedElement):
        (khtml::SimplifiedBackwardsTextIterator::emitCharacter):
        (khtml::SimplifiedBackwardsTextIterator::emitNewlineForBROrText):
        (khtml::CharacterIterator::range):
        (khtml::CharacterIterator::advance):
        (khtml::CharacterIterator::string):
        (khtml::WordAwareIterator::length):
        (khtml::CircularSearchBuffer::append):
        (khtml::CircularSearchBuffer::neededCharacters):
        (khtml::CircularSearchBuffer::isMatch):
        (khtml::TextIterator::rangeLength):
        (khtml::TextIterator::rangeFromLocationAndLength):
        (khtml::plainText):
        (khtml::findPlainText):
        * khtml/editing/visible_text.h:
        (khtml::TextIterator::length):
        (khtml::SimplifiedBackwardsTextIterator::length):
        (khtml::CharacterIterator::length):
        (khtml::CharacterIterator::characterOffset):
        * khtml/editing/visible_units.cpp:
        (khtml::startOfLine):
        (khtml::endOfLine):
        (khtml::startOfParagraph):
        (khtml::endOfParagraph):
        * khtml/html/html_blockimpl.cpp:
        (HTMLPreElementImpl::width):
        (HTMLPreElementImpl::setWidth):
        * khtml/html/html_blockimpl.h:
        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLFormElementImpl::length):
        (DOM::HTMLGenericFormElementImpl::tabIndex):
        (DOM::HTMLGenericFormElementImpl::setTabIndex):
        (DOM::HTMLInputElementImpl::selectionStart):
        (DOM::HTMLInputElementImpl::selectionEnd):
        (DOM::HTMLInputElementImpl::setSelectionStart):
        (DOM::HTMLInputElementImpl::setSelectionEnd):
        (DOM::HTMLInputElementImpl::setSelectionRange):
        (DOM::HTMLInputElementImpl::setMaxLength):
        (DOM::HTMLInputElementImpl::setSize):
        (DOM::HTMLSelectElementImpl::selectedIndex):
        (DOM::HTMLSelectElementImpl::setSelectedIndex):
        (DOM::HTMLSelectElementImpl::length):
        (DOM::HTMLSelectElementImpl::remove):
        (DOM::HTMLSelectElementImpl::setSize):
        (DOM::HTMLOptionElementImpl::index):
        (DOM::HTMLOptionElementImpl::setIndex):
        (DOM::HTMLTextAreaElementImpl::selectionStart):
        (DOM::HTMLTextAreaElementImpl::selectionEnd):
        (DOM::HTMLTextAreaElementImpl::setSelectionStart):
        (DOM::HTMLTextAreaElementImpl::setSelectionEnd):
        (DOM::HTMLTextAreaElementImpl::setSelectionRange):
        (DOM::HTMLTextAreaElementImpl::setCols):
        (DOM::HTMLTextAreaElementImpl::setRows):
        (DOM::HTMLOptionsCollectionImpl::length):
        (DOM::HTMLOptionsCollectionImpl::setLength):
        (DOM::HTMLOptionsCollectionImpl::item):
        * khtml/html/html_formimpl.h:
        (DOM::HTMLInputElementImpl::maxLength):
        (DOM::HTMLInputElementImpl::maxResults):
        (DOM::HTMLSelectElementImpl::minWidth):
        (DOM::HTMLSelectElementImpl::size):
        (DOM::HTMLTextAreaElementImpl::cols):
        (DOM::HTMLTextAreaElementImpl::rows):
        * khtml/html/html_imageimpl.cpp:
        (HTMLImageElementImpl::width):
        (HTMLImageElementImpl::height):
        (HTMLImageElementImpl::border):
        (HTMLImageElementImpl::setBorder):
        (HTMLImageElementImpl::setHeight):
        (HTMLImageElementImpl::hspace):
        (HTMLImageElementImpl::setHspace):
        (HTMLImageElementImpl::vspace):
        (HTMLImageElementImpl::setVspace):
        (HTMLImageElementImpl::setWidth):
        (HTMLImageElementImpl::x):
        (HTMLImageElementImpl::y):
        (HTMLAreaElementImpl::tabIndex):
        (HTMLAreaElementImpl::setTabIndex):
        * khtml/html/html_imageimpl.h:
        * khtml/html/html_inlineimpl.cpp:
        (DOM::HTMLAnchorElementImpl::tabIndex):
        (DOM::HTMLAnchorElementImpl::setTabIndex):
        * khtml/html/html_inlineimpl.h:
        * khtml/html/html_listimpl.cpp:
        (DOM::HTMLOListElementImpl::setStart):
        (DOM::HTMLLIElementImpl::value):
        (DOM::HTMLLIElementImpl::setValue):
        * khtml/html/html_listimpl.h:
        (DOM::HTMLUListElementImpl::start):
        (DOM::HTMLOListElementImpl::start):
        * khtml/html/html_miscimpl.cpp:
        (DOM::HTMLCollectionImpl::calcLength):
        (DOM::HTMLCollectionImpl::length):
        (DOM::HTMLCollectionImpl::item):
        (DOM::HTMLFormCollectionImpl::calcLength):
        (DOM::HTMLFormCollectionImpl::item):
        * khtml/html/html_miscimpl.h:
        * khtml/html/html_objectimpl.cpp:
        (DOM::HTMLObjectElementImpl::tabIndex):
        (DOM::HTMLObjectElementImpl::setTabIndex):
        * khtml/html/html_objectimpl.h:
        * khtml/html/html_tableimpl.cpp:
        (DOM::HTMLTableElementImpl::insertRow):
        (DOM::HTMLTableElementImpl::deleteRow):
        (DOM::HTMLTableSectionElementImpl::insertRow):
        (DOM::HTMLTableSectionElementImpl::deleteRow):
        (DOM::HTMLTableRowElementImpl::rowIndex):
        (DOM::HTMLTableRowElementImpl::sectionRowIndex):
        (DOM::HTMLTableRowElementImpl::insertCell):
        (DOM::HTMLTableRowElementImpl::deleteCell):
        (DOM::HTMLTableCellElementImpl::cellIndex):
        (DOM::HTMLTableCellElementImpl::setColSpan):
        (DOM::HTMLTableCellElementImpl::setRowSpan):
        (DOM::HTMLTableColElementImpl::setSpan):
        * khtml/html/html_tableimpl.h:
        (DOM::HTMLTableColElementImpl::span):
        * khtml/html/htmlparser.cpp:
        (HTMLParser::handleError):
        * khtml/html/htmltokenizer.cpp:
        (khtml::HTMLTokenizer::processToken):
        * khtml/khtml_events.cpp:
        (khtml::MouseEvent::offset):
        * khtml/khtml_events.h:
        (khtml::MouseReleaseEvent::MouseReleaseEvent):
        * khtml/khtml_part.cpp:
        (KHTMLPart::restoreURL):
        (KHTMLPart::stopLoading):
        (KHTMLPart::receivedFirstData):
        (KHTMLPart::slotFinished):
        (KHTMLPart::begin):
        (KHTMLPart::slotViewFrameSource):
        (KHTMLPart::selectFrameElementInParentIfFullySelected):
        * khtml/khtml_part.h:
        * khtml/khtmlpart_p.h:
        (KHTMLPartPrivate::KHTMLPartPrivate):
        * khtml/misc/loader.h:
        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::positionForRenderer):
        * khtml/rendering/render_br.cpp:
        (RenderBR::caretMinOffset):
        (RenderBR::caretMaxOffset):
        (RenderBR::caretMaxRenderedOffset):
        (RenderBR::inlineBox):
        * khtml/rendering/render_br.h:
        * khtml/rendering/render_form.cpp:
        (RenderLineEdit::selectionStart):
        (RenderLineEdit::selectionEnd):
        (RenderLineEdit::setSelectionStart):
        (RenderLineEdit::setSelectionEnd):
        (RenderLineEdit::setSelectionRange):
        (RenderTextArea::calcMinMaxWidth):
        (RenderTextArea::selectionStart):
        (RenderTextArea::selectionEnd):
        (RenderTextArea::setSelectionStart):
        (RenderTextArea::setSelectionEnd):
        (RenderTextArea::setSelectionRange):
        * khtml/rendering/render_form.h:
        * khtml/rendering/render_frames.cpp:
        (RenderPartObject::updateWidget):
        * khtml/rendering/render_line.cpp:
        (khtml::InlineBox::caretMinOffset):
        (khtml::InlineBox::caretMaxOffset):
        (khtml::InlineBox::caretMaxRenderedOffset):
        * khtml/rendering/render_line.h:
        * khtml/rendering/render_list.cpp:
        (RenderListMarker::calcMinMaxWidth):
        * khtml/rendering/render_list.h:
        (khtml::RenderListItem::value):
        (khtml::RenderListItem::setValue):
        * khtml/rendering/render_object.cpp:
        (RenderObject::caretMinOffset):
        (RenderObject::caretMaxOffset):
        (RenderObject::caretMaxRenderedOffset):
        (RenderObject::previousOffset):
        (RenderObject::nextOffset):
        (RenderObject::inlineBox):
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_replaced.cpp:
        (RenderReplaced::caretMinOffset):
        (RenderReplaced::caretMaxOffset):
        (RenderReplaced::caretMaxRenderedOffset):
        * khtml/rendering/render_replaced.h:
        * khtml/rendering/render_table.h:
        (khtml::RenderTableCell::cellIndex):
        (khtml::RenderTableCell::setCellIndex):
        * khtml/rendering/render_text.cpp:
        (InlineTextBox::paintMarker):
        (InlineTextBox::paintMarkedTextUnderline):
        (InlineTextBox::caretMinOffset):
        (InlineTextBox::caretMaxOffset):
        (InlineTextBox::caretMaxRenderedOffset):
        (RenderText::previousOffset):
        (RenderText::nextOffset):
        (InlineTextBox::positionForOffset):
        (RenderText::caretMinOffset):
        (RenderText::caretMaxOffset):
        (RenderText::caretMaxRenderedOffset):
        (RenderText::inlineBox):
        * khtml/rendering/render_text.h:
        * khtml/xml/dom2_eventsimpl.cpp:
        (DOM::EventImpl::timeStamp):
        (DOM::UIEventImpl::UIEventImpl):
        (DOM::UIEventImpl::initUIEvent):
        (DOM::UIEventImpl::layerX):
        (DOM::UIEventImpl::layerY):
        (DOM::UIEventImpl::pageX):
        (DOM::UIEventImpl::pageY):
        (DOM::UIEventImpl::which):
        (DOM::MouseRelatedEventImpl::MouseRelatedEventImpl):
        (DOM::MouseRelatedEventImpl::pageX):
        (DOM::MouseRelatedEventImpl::pageY):
        (DOM::MouseEventImpl::MouseEventImpl):
        (DOM::MouseEventImpl::initMouseEvent):
        (DOM::MouseEventImpl::which):
        (DOM::KeyboardEventImpl::KeyboardEventImpl):
        (DOM::KeyboardEventImpl::initKeyboardEvent):
        (DOM::KeyboardEventImpl::which):
        (DOM::WheelEventImpl::WheelEventImpl):
        * khtml/xml/dom2_eventsimpl.h:
        (DOM::UIEventImpl::detail):
        (DOM::UIEventWithKeyStateImpl::UIEventWithKeyStateImpl):
        (DOM::MouseRelatedEventImpl::screenX):
        (DOM::MouseRelatedEventImpl::screenY):
        (DOM::MouseRelatedEventImpl::clientX):
        (DOM::MouseRelatedEventImpl::clientY):
        (DOM::MouseRelatedEventImpl::layerX):
        (DOM::MouseRelatedEventImpl::layerY):
        (DOM::KeyboardEventImpl::keyLocation):
        (DOM::WheelEventImpl::wheelDelta):
        * khtml/xml/dom2_rangeimpl.cpp:
        (DOM::RangeImpl::RangeImpl):
        (DOM::RangeImpl::startOffset):
        (DOM::RangeImpl::endOffset):
        (DOM::RangeImpl::setStart):
        (DOM::RangeImpl::setEnd):
        (DOM::RangeImpl::compareBoundaryPoints):
        (DOM::RangeImpl::processContents):
        (DOM::RangeImpl::checkNodeWOffset):
        * khtml/xml/dom2_rangeimpl.h:
        * khtml/xml/dom2_traversalimpl.cpp:
        (DOM::TraversalImpl::TraversalImpl):
        (DOM::TreeWalkerImpl::TreeWalkerImpl):
        * khtml/xml/dom2_traversalimpl.h:
        (DOM::TraversalImpl::whatToShow):
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::createNodeIterator):
        (DocumentImpl::createTreeWalker):
        (DocumentImpl::processHttpEquiv):
        (DocumentImpl::removeMarkers):
        (DocumentImpl::copyMarkers):
        (DocumentImpl::markersForNode):
        (DocumentImpl::shiftMarkers):
        * khtml/xml/dom_docimpl.h:
        * khtml/xml/dom_elementimpl.cpp:
        (ElementImpl::openTagStartToString):
        (NamedAttrMapImpl::item):
        (NamedAttrMapImpl::getAttributeItem):
        (NamedAttrMapImpl::removeAttribute):
        * khtml/xml/dom_elementimpl.h:
        (DOM::NamedAttrMapImpl::length):
        (DOM::NamedAttrMapImpl::attributeItem):
        (DOM::NamedMappedAttrMapImpl::attributeItem):
        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::NodeImpl::normalize):
        (DOM::NodeImpl::nodeIndex):
        (DOM::NodeImpl::childNodeCount):
        (DOM::NodeImpl::childNode):
        (DOM::NodeImpl::maxOffset):
        (DOM::NodeImpl::maxDeepOffset):
        (DOM::NodeImpl::caretMinOffset):
        (DOM::NodeImpl::caretMaxOffset):
        (DOM::NodeImpl::caretMaxRenderedOffset):
        (DOM::NodeImpl::previousOffset):
        (DOM::NodeImpl::nextOffset):
        (DOM::ContainerNodeImpl::childNodeCount):
        (DOM::ContainerNodeImpl::childNode):
        (DOM::NodeListImpl::recursiveLength):
        (DOM::NodeListImpl::recursiveItem):
        (DOM::NodeListImpl::itemById):
        (DOM::ChildNodeListImpl::length):
        (DOM::ChildNodeListImpl::item):
        (DOM::TagNodeListImpl::length):
        (DOM::TagNodeListImpl::item):
        (DOM::NameNodeListImpl::length):
        (DOM::NameNodeListImpl::item):
        * khtml/xml/dom_nodeimpl.h:
        * khtml/xml/dom_position.cpp:
        (DOM::Position::Position):
        (DOM::Position::previous):
        (DOM::Position::next):
        (DOM::Position::renderedOffset):
        (DOM::Position::equivalentRangeCompliantPosition):
        (DOM::Position::rendersInDifferentPosition):
        (DOM::Position::trailingWhitespacePosition):
        (DOM::Position::debugPosition):
        * khtml/xml/dom_position.h:
        (DOM::Position::offset):
        * khtml/xml/dom_textimpl.cpp:
        (CharacterDataImpl::length):
        (CharacterDataImpl::substringData):
        (CharacterDataImpl::insertData):
        (CharacterDataImpl::deleteData):
        (CharacterDataImpl::replaceData):
        (CharacterDataImpl::checkCharDataOperation):
        (CharacterDataImpl::maxOffset):
        (CharacterDataImpl::caretMinOffset):
        (CharacterDataImpl::caretMaxOffset):
        (CharacterDataImpl::caretMaxRenderedOffset):
        (TextImpl::splitText):
        * khtml/xml/dom_textimpl.h:
        * kwq/DOM-CSS.mm:
        (-[DOMStyleSheetList length]):
        (-[DOMStyleSheetList item:]):
        (-[DOMCSSStyleSheet insertRule::]):
        (-[DOMCSSStyleSheet deleteRule:]):
        (-[DOMMediaList length]):
        (-[DOMMediaList item:]):
        (-[DOMCSSRuleList length]):
        (-[DOMCSSRuleList item:]):
        (-[DOMCSSMediaRule insertRule::]):
        (-[DOMCSSMediaRule deleteRule:]):
        (-[DOMCSSStyleDeclaration length]):
        (-[DOMCSSStyleDeclaration item:]):
        (-[DOMCSSValueList length]):
        (-[DOMCSSValueList item:]):
        * kwq/DOM.mm:
        (-[DOMNamedNodeMap item:]):
        (-[DOMNamedNodeMap length]):
        (-[DOMNodeList item:]):
        (-[DOMNodeList length]):
        (-[DOMCharacterData length]):
        (-[DOMCharacterData substringData::]):
        (-[DOMCharacterData insertData::]):
        (-[DOMCharacterData deleteData::]):
        (-[DOMCharacterData replaceData:::]):
        (-[DOMText splitText:]):
        (-[DOMRange description]):
        (-[DOMRange startOffset]):
        (-[DOMRange endOffset]):
        (-[DOMRange setStart::]):
        (-[DOMRange setEnd::]):
        (-[DOMNodeIterator whatToShow]):
        (-[DOMTreeWalker whatToShow]):
        (-[DOMDocument createNodeIterator::::]):
        (-[DOMDocument createTreeWalker::::]):
        * kwq/DOMCSS.h:
        * kwq/DOMCore.h:
        * kwq/DOMEvents.h:
        (-[DOMMouseEvent initMouseEvent:::::::::::::::]):
        * kwq/DOMEvents.mm:
        (-[DOMMouseEvent screenX]):
        (-[DOMMouseEvent screenY]):
        (-[DOMMouseEvent clientX]):
        (-[DOMMouseEvent clientY]):
        (-[DOMMouseEvent initMouseEvent:::::::::::::::]):
        (-[DOMUIEvent detail]):
        (-[DOMUIEvent initUIEvent:::::]):
        * kwq/DOMExtensions.h:
        * kwq/DOMHTML.h:
        * kwq/DOMHTML.mm:
        (-[DOMHTMLCollection length]):
        (-[DOMHTMLCollection item:]):
        (-[DOMHTMLOptionsCollection length]):
        (-[DOMHTMLOptionsCollection setLength:]):
        (-[DOMHTMLOptionsCollection item:]):
        (-[DOMHTMLFormElement length]):
        (-[DOMHTMLSelectElement selectedIndex]):
        (-[DOMHTMLSelectElement setSelectedIndex:]):
        (-[DOMHTMLSelectElement length]):
        (-[DOMHTMLSelectElement setLength:]):
        (-[DOMHTMLSelectElement size]):
        (-[DOMHTMLSelectElement setSize:]):
        (-[DOMHTMLSelectElement tabIndex]):
        (-[DOMHTMLSelectElement setTabIndex:]):
        (-[DOMHTMLSelectElement remove:]):
        (-[DOMHTMLOptionElement index]):
        (-[DOMHTMLInputElement maxLength]):
        (-[DOMHTMLInputElement setMaxLength:]):
        (-[DOMHTMLInputElement size]):
        (-[DOMHTMLInputElement setSize:]):
        (-[DOMHTMLInputElement tabIndex]):
        (-[DOMHTMLInputElement setTabIndex:]):
        (-[DOMHTMLTextAreaElement cols]):
        (-[DOMHTMLTextAreaElement setCols:]):
        (-[DOMHTMLTextAreaElement rows]):
        (-[DOMHTMLTextAreaElement setRows:]):
        (-[DOMHTMLTextAreaElement tabIndex]):
        (-[DOMHTMLTextAreaElement setTabIndex:]):
        (-[DOMHTMLButtonElement tabIndex]):
        (-[DOMHTMLButtonElement setTabIndex:]):
        (-[DOMHTMLOListElement start]):
        (-[DOMHTMLOListElement setStart:]):
        (-[DOMHTMLLIElement value]):
        (-[DOMHTMLLIElement setValue:]):
        (-[DOMHTMLPreElement width]):
        (-[DOMHTMLPreElement setWidth:]):
        (-[DOMHTMLAnchorElement tabIndex]):
        (-[DOMHTMLAnchorElement setTabIndex:]):
        (-[DOMHTMLImageElement height]):
        (-[DOMHTMLImageElement setHeight:]):
        (-[DOMHTMLImageElement hspace]):
        (-[DOMHTMLImageElement setHspace:]):
        (-[DOMHTMLImageElement vspace]):
        (-[DOMHTMLImageElement setVspace:]):
        (-[DOMHTMLImageElement width]):
        (-[DOMHTMLImageElement setWidth:]):
        (-[DOMHTMLObjectElement hspace]):
        (-[DOMHTMLObjectElement setHspace:]):
        (-[DOMHTMLObjectElement tabIndex]):
        (-[DOMHTMLObjectElement setTabIndex:]):
        (-[DOMHTMLObjectElement vspace]):
        (-[DOMHTMLObjectElement setVspace:]):
        (-[DOMHTMLAppletElement hspace]):
        (-[DOMHTMLAppletElement setHspace:]):
        (-[DOMHTMLAppletElement vspace]):
        (-[DOMHTMLAppletElement setVspace:]):
        (-[DOMHTMLAreaElement tabIndex]):
        (-[DOMHTMLAreaElement setTabIndex:]):
        (-[DOMHTMLTableSectionElement insertRow:]):
        (-[DOMHTMLTableSectionElement deleteRow:]):
        (-[DOMHTMLTableElement insertRow:]):
        (-[DOMHTMLTableElement deleteRow:]):
        (-[DOMHTMLTableColElement span]):
        (-[DOMHTMLTableColElement setSpan:]):
        (-[DOMHTMLTableRowElement rowIndex]):
        (-[DOMHTMLTableRowElement sectionRowIndex]):
        (-[DOMHTMLTableRowElement insertCell:]):
        (-[DOMHTMLTableRowElement deleteCell:]):
        (-[DOMHTMLTableCellElement cellIndex]):
        (-[DOMHTMLTableCellElement colSpan]):
        (-[DOMHTMLTableCellElement setColSpan:]):
        (-[DOMHTMLTableCellElement rowSpan]):
        (-[DOMHTMLTableCellElement setRowSpan:]):
        (-[DOMHTMLEmbedElement height]):
        (-[DOMHTMLEmbedElement setHeight:]):
        (-[DOMHTMLEmbedElement width]):
        (-[DOMHTMLEmbedElement setWidth:]):
        * kwq/DOMRange.h:
        * kwq/DOMStylesheets.h:
        * kwq/DOMTraversal.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::advanceToNextMisspelling):
        (KWQKHTMLPart::openURLFromPageCache):
        (KWQKHTMLPart::markMisspellings):
        * kwq/KWQString.h:
        * kwq/KWQString.mm:
        (QString::toShort):
        (QString::toUShort):
        (QString::toInt):
        (QString::toUInt):
        * kwq/KWQTextEdit.h:
        * kwq/KWQTextEdit.mm:
        (QTextEdit::selectionStart):
        (QTextEdit::selectionEnd):
        (QTextEdit::setSelectionStart):
        (QTextEdit::setSelectionEnd):
        (QTextEdit::setSelectionRange):
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge convertToNSRange:DOM::]):

648
649
650
651
652
653
654
655
656
657
658
659
660
661
2005-09-16  Tim Omernick  <tomernick@apple.com>

        Reviewed by Dave Hyatt.  Test case reviewed by Vicki Murley.

	<rdar://problem/3572507> Flash in div with display:none style will not redraw when style changed to display:block (3479)

        Test cases added:
        * manual-tests/show-hide-object.html: Added.
        * manual-tests/resources/spinbox.swf: Added.

        * khtml/html/html_objectimpl.cpp:
        (DOM::HTMLObjectElementImpl::detach):
	Set needWidgetUpdate to true so that the widget is updated on the next attach().

eseidel's avatar
eseidel committed
662
663
664
665
666
667
668
669
670
671
672
673
2005-09-15  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Test cases added:
        None, to-be-landed xhtml dom tests already cover this.

        * khtml/xml/dom_textimpl.cpp:
        (TextImpl::rendererIsNeeded):
        One line change to prevent adding text objects as direct
        children to FrameSet objects in the render tree. 

harrison's avatar
harrison committed
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
2005-09-15  David Harrison  <harrison@apple.com>

        Reviewed by Dave Hyatt.

        <rdar://problem/4244976> reproducible hang at ocharleys.com in VisiblePosition::initDownstream
        
        Problem is that RenderText::nextOffset() passes an empty string the UBreakIterator, which returns
        UBRK_DONE (-1) from ubrk_following, and that -1 is used without question as return result of
        nextOffset().  Fixed by checking for UBRK_DONE and returning offset+1 in that case.  Similar
        change in RenderText::previousOffset().

        Test cases added:
        * layout-tests/editing/selection/extend-by-word-002-expected.checksum: Added.
        * layout-tests/editing/selection/extend-by-word-002-expected.png: Added.
        * layout-tests/editing/selection/extend-by-word-002-expected.txt: Added.
        * layout-tests/editing/selection/extend-by-word-002.html: Added.

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::updateFirstLetter):
        Added comments.  Slight format adjustments.
        
        * khtml/rendering/render_text.cpp:
        (getCharacterBreakIterator):
        Slight format adjustment.
        
        (RenderText::previousOffset):
        (RenderText::nextOffset):
        Check for UBRK_DONE.
        
        (RenderTextFragment::RenderTextFragment)
        (RenderTextFragment::RenderTextFragment)
        Fixed parameter names.

        (m_generatedContentStr):
        * khtml/rendering/render_text.h:
        Fixed parameter names in the two RenderTextFragment constructors.

711
712
713
714
715
716
717
718
719
720
721
722
723
2005-09-14  Alexey Proskuryakov  <ap@nypop.com>

        Reviewed, tweaked, and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3809
          Should default to UTF-8 or UTF-16 for application/xml documents with omitted charset and encoding declaration

        Test cases added:
        * layout-tests/fast/encoding/xml-utf-8-default.xml: Added.
        * layout-tests/fast/encoding/xml-utf-8-default-expected.txt: Added.

        * khtml/misc/decoder.cpp: (Decoder::decode): Always set encoding when we see an XML header.

724
725
726
727
728
2005-09-14  Darin Adler  <darin@apple.com>

        * layout-tests/fast/dom/set-innerHTML-expected.txt: Updated test result now that DumpRenderTree handles
        this case properly. The old expected result just had the word "error"!

justing's avatar
justing committed
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
2005-09-14  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by john
        
        Test cases added: none, method rename
        
        Part of fix for <rdar://problem/4237479> REGRESSION (Cambridge-Denver): old QuickTime movie continues to play sound after reload

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge handleFallbackContent]):
        Renamed bridge method mainResourceError to handleFallbackContent, since there are some 
        main resource errors for which we should not render fallback content.  E.G user cancels 
        and the cancel we do to prevent loading plugin content twice (see <rdar://problem/4258008>)

harrison's avatar
harrison committed
744
745
746
747
748
749
750
751
752
753
754
755
756
2005-09-14  David Harrison  <harrison@apple.com>

        Reviewed by Eric.

        <rdar://problem/4057623> AX: Dictionary Panel crash in AXAttributeStringSetStyle in Safari (Dictionary has workaround)

        Test cases added: None.  Manual testing is way to awkward, and automated testing
        is not possible.  Filed following bug to get automation.
        <rdar://problem/4256882> Need automated testing support for accessibility APIs

        * kwq/KWQAccObject.mm:
        (AXAttributedStringAppendText):

vicki's avatar
vicki committed
757
758
759
760
761
762
763
764
765
2005-09-14 Vicki Murley  <vicki@apple.com>

        Reviewed by Dave Hyatt.
 
	- fixed <rdar://problem/4255274> REGRESSION: in some cases, link jumping to images is broken (4964)

        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::ContainerNodeImpl::getUpperLeftCorner): 

darin's avatar
darin committed
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
2005-09-14  Darin Adler  <darin@apple.com>

        Reviewed by John.

        No easy way to test this in layout tests, so no test added.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4984
          REGRESSION placeholder border left behind after image finishes loading

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4985
          REGRESSION assertion failure in KWQPainter.mm:841

        * kwq/KWQPainter.mm:
        (QPainter::save): Do nothing if painting is disabled.
        (QPainter::restore): Ditto.
        (QPainter::drawRect): Inset so that we "frame" the rectangle rather than "stroking" the
        rectangle. The former draws inside the rectangle but the latter draws centered on the
        edge of the rectangle.

darin's avatar
darin committed
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
2005-09-14  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4924
          QPainter should use CGContext as much as possible rather than NSGraphicsContext

        * kwq/KWQPainter.h: Made no-op xForm be an inline. Reformatted to remove extraneous spaces.
        Removed clearFocusRing. Changed the name of various private functions to remove underscore
        prefix, and reorganize them.

        * kwq/KWQPainter.mm:
        (QPainterPrivate::QPainterPrivate): Remove the NSBezierPath for focus.
        (QPainterPrivate::~QPainterPrivate): Ditto.
        (QPainter::save): Use CGContext instead of NSGraphicsContext.
        (QPainter::restore): Ditto.
        (QPainter::drawRect): Use CGContextFillRect instead of _fillRectXX, and
        CGContextStrokeRect instead of NSFrameRect.
        (QPainter::setFillColor): Added. Sets CGContext fill color based on brush.
        (QPainter::setFillColorFromCurrentBrush): Added. Sets CGContext fill color based on QPainter's
        current brush.
        (QPainter::setFillColorFromCurrentPen): Added. Sets CGContext fill color based on QPainter's
        current pen.
        (QPainter::setStrokeColorAndLineWidthFromCurrentPen): Added. Set CGContext stroke color and
        line width based on QPainter's current pen.
        (QPainter::drawLine): Use CGContextStrokeLineSegments instead of NSBezierPath.
        (QPainter::drawEllipse): Use CGContextFillEllipseInRect instead of CGContextFillPath and
        CGContextStrokeEllipseInRect instead of CGContextStrokePath.
        (QPainter::drawArc): Removed some uneeded type casts, changed to call the new private functions,
        currentContext and setStrokeColorAndLineWidthFromCurrentPen.
        (QPainter::drawConvexPolygon): Use new private functions, also use CGContextDrawPath in the
        case where we want to both fill and stroke the polygon.
        (QPainter::getCompositeOperation): Remove unneeded cast.
        (QPainter::setCompositeOperation): Map from name to operation here rather than relying on the
        code on the WebKit side to do it (allows us to remove names entirely from the WebKit side).
        (QPainter::compositeOperatorFromString): Remove a local variable and some casts.
        (getBlendedColorComponent): Rewrote to do the same computation without any conversion to float.
        (QPainter::fillRect): Use CGContextFillRect instead of _fillRectXXX.
        (QPainter::addClip): Use CGContextClipToRect instead of NSBezierPath.
        (QPainter::addRoundedRectClip): Add missing call to CGContextBeginPath.
        (QPainter::beginTransparencyLayer): Use CGContextSaveGState instead of NSGraphicsContext.
        (QPainter::endTransparencyLayer): Use CGContextRestoreGState instead of NSGraphicsContext.
        (QPainter::initFocusRing): Use CGContextBeginPath instead of creating an NSBezierPath.
        (QPainter::addFocusRingRect): Use CGContextAddRect instead of NSBezierPath.
        (QPainter::drawFocusRing): Use CGContextFillPath instead of NSBezierPath.

        * khtml/rendering/render_flow.cpp: (RenderFlow::paintFocusRing): Remove call to clearFocusRing. No longer exists.
        * khtml/rendering/render_object.cpp: (RenderObject::paintOutline): Ditto.

        * kwq/WebCoreImageRendererFactory.h: Remove setCGCompositeOperationFromString method.

harrison's avatar
harrison committed
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
2005-09-13  David Harrison  <harrison@apple.com>

        Reviewed by Justin.

        <rdar://problem/4204892> Correcting incorrect spelling in Mail causes others to lose their red squiggles

        Fixed by having SplitTextNodeCommand::doApply copy the markers to the new node, and having SplitTextNodeCommand::doUnapply
        copy the markers from the merged-in node to the combined node.
        
        btw - filed <rdar://problem/4256492> "WebCore editing automated layout tests verify spelling markers"
        so that we can automate tests for this.
        
        Test cases added:
        * manual-tests/keep_spelling_markers.html: Added.

        * khtml/editing/split_text_node_command.cpp:
        (khtml::SplitTextNodeCommand::doApply):
        (khtml::SplitTextNodeCommand::doUnapply):
        Call new copyMarkers() function.

        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::removeMarkers):
        (DocumentImpl::addMarker):
        (DocumentImpl::copyMarkers):
        (DocumentImpl::markersForNode):
        (DocumentImpl::shiftMarkers):
        * khtml/xml/dom_docimpl.h:
        (DOM::DocumentMarker::):
        Added copyMarkers() function.  Reorganized code for clarity.

        * khtml/xml/dom_textimpl.cpp:
        (CharacterDataImpl::setData):
        (CharacterDataImpl::deleteData):
        (CharacterDataImpl::replaceData):
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::respondToChangedSelection):
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge unmarkAllMisspellings]):
        Update calls to marker functions.
        
eseidel's avatar
eseidel committed
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
2005-09-12  Eric Seidel  <eseidel@apple.com>

        No review, build fix, only affects SVG.

        Fixes build after qstring() -> string() rename this weekend.

        * kdom/Helper.cpp:
        (parseLength):
        * kdom/core/DOMStringImpl.cpp:
        (DOMStringImpl::toInt):
        * kdom/core/DocumentImpl.cpp:
        (DocumentImpl::getId):
        * kdom/css/CSSStyleSelector.cpp:
        (checkPseudoState):

darin's avatar
darin committed
891
892
893
894
895
896
897
898
899
900
901
902
903
904
2005-09-11  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - fixed <rdar://problem/4126166> using JavaScript-assigned accesskeys crashes Safari - DOM::NodeImpl::dispatchEvent

        Test cases added:
        * layout-tests/fast/events/access-key-self-destruct.html: Added.
        * layout-tests/fast/events/access-key-self-destruct-expected.txt: Added.

        * khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchMouseEvent): Ref the node for the duration
        with a SharedPtr; this helps in cases where the last reference to the node goes away inside the
        event handler.

darin's avatar
darin committed
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
2005-09-11  Darin Adler  <darin@apple.com>

        Reviewed by Eric.

        - changed back the name of a couple of string() functions that were renamed to qstring() by accident

        * kwq/KWQString.h: (QConstString::string): Changed function name back to string() from qstring().
        This is a function from Qt, so the name needs to match Qt -- that's just how KWQ works.

        * khtml/xml/dom_atomicstringlist.h: Changed the name of the function that returns the current
        AtomicString to string() back from qstring()!

        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::matchRules): Use string() instead of qstring().
        (khtml::checkPseudoState): Ditto.
        (khtml::CSSStyleSelector::checkOneSelector): Ditto.
        * khtml/dom/dom_string.cpp: (DOM::DOMString::percentage): Ditto.
        * khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::finish): Ditto.
        * khtml/xml/dom_stringimpl.cpp:
        (DOM::DOMStringImpl::DOMStringImpl): Small tweak to streamline a tiny bit by using an already-computed
        boolean instead of re-checking a couple of data members.
        (DOM::parseLength): Use string() instead of qstring().
        (DOM::DOMStringImpl::toInt): Ditto.

        - removed some dead code

        * khtml/xml/dom_elementimpl.cpp: Removed XMLElementImpl.

darin's avatar
darin committed
933
934
935
936
937
938
939
940
941
942
943
944
945
946
2005-09-10  Alexey Proskuryakov  <ap@nypop.com>

        Reviewed and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4820
          hexadecimal HTML entities split across TCP packets are not parsed correctly

        Wasn't able to make a layout test for this because there's no easy way to
        simulate separate writes to the tokenizer.

        * khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseEntity):
        Rolled back to code more like the original KDE stuff -- our change broke this --
        but changed the limit so it works with 8-character entities.

947
948
949
950
951
952
953
2005-09-10  Darin Adler  <darin@apple.com>

        - remove test case I just added -- it's not working

        * layout-tests/fast/dom/document-write-infinite-recursion-expected.txt: Removed.
        * layout-tests/fast/dom/document-write-infinite-recursion.html: Removed.

darin's avatar
darin committed
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
2005-09-10  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4806
          REGRESSION <area> elements misnested inside <div> elements not working

        Test cases added:
        * layout-tests/fast/parser/area-in-div.html: Added.
        * layout-tests/fast/parser/area-in-div-expected.txt: Added.

        * khtml/html/htmlparser.h: Declared mapCreateErrorCheck.
        * khtml/html/htmlparser.cpp:
        (HTMLParser::handleError): Fix formatting and indentation.
        (HTMLParser::formCreateErrorCheck): Added code to create the form too, so we can
        squirrel the form pointer away. Return false to prevent the factory from creating it.
        (HTMLParser::mapCreateErrorCheck): Added. Same kind of thing here, but without the logic
        that prevents creating a form if there's already a form open.
        (HTMLParser::getNode): Added the code to put the map function into the table. Also
        removed the form special-case code here that accomplishes what is now done inside the
        formCreateErrorCheck above instead.

darin's avatar
darin committed
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
2005-09-10  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4367
          Crash when executing setTimeout / Date / document.write Javascript (bugtraq)

        Test cases added:
        * layout-tests/fast/dom/document-write-infinite-recursion.html: Added.
        * layout-tests/fast/dom/document-write-infinite-recursion-expected.txt: Added.

        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::implicitClose): Simplify a bit to make more readable. Remove the
        code to delete the tokenizer an extra time -- that can end up deleting the newly
        created tokenizer that's still needed for the newly opened page.
        (DocumentImpl::write): Added an assertion to catch the badness that caused
        infinite recursion so it's easier to recognize next time.

994
995
996
997
998
999
2005-09-10  Darin Adler  <darin@apple.com>

        - add expected success result for newly-enabled test

        * layout-tests/dom/html/level2/html/HTMLIFrameElement11-expected.txt: Added.

vicki's avatar
vicki committed
1000
2005-09-09  Vicki Murley  <vicki@apple.com>
For faster browsing, not all history is shown. View entire blame