ChangeLog 5.16 MB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17
2012-09-04  Joanmarie Diggs  <jdiggs@igalia.com>

        [GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
        https://bugs.webkit.org/show_bug.cgi?id=95740

        Reviewed by Martin Robinson.

        Added sanity check to be sure we have a render object prior to seeing if
        said object is an anonymous block.

        Testing via unit test because a non-flaky layout test crasher could not
        be found.

        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
        Sanity check for render object added.

18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43
2012-09-04  Christophe Dumez  <christophe.dumez@intel.com>

        Automatic features should work in sandboxed iframes if "allow-scripts" flag is set
        https://bugs.webkit.org/show_bug.cgi?id=93961

        Reviewed by Adam Barth.

        Allow automatic features (video autoplay and form control
        autofocus) in a sandboxed iframe that has "allow-scripts"
        flag set. This behavior is according to the latest
        specification at:
        http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin

        This sandboxed automatic features browsing context flag is
        relaxed by the same keyword as scripts, because when
        scripts are enabled these features are trivially possible
        anyway, and it would be unfortunate to force authors to
        use script to do them when sandboxed rather than allowing
        them to use the declarative features.

        Tests: fast/forms/autofocus-in-sandbox-with-allow-scripts.html
               media/auto-play-in-sandbox-with-allow-scripts.html

        * dom/SecurityContext.cpp:
        (WebCore::SecurityContext::parseSandboxPolicy):

44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90
2012-09-04  Sami Kyostila  <skyostil@google.com>

        Register scrolling layers with ScrollingCoordinator
        https://bugs.webkit.org/show_bug.cgi?id=78862

        Reviewed by James Robinson.

        In order to allow scrollable child layers to be scrolled off the main
        thread, register them with the ScrollingCoordinator. These layers are
        also removed from the non-fast scrollable region.

        Whenever the scroll offset or other scroll geometry related attribute of
        a compositor scrolled layer changes, the ScrollingCoordinator is
        informed to allow it to update its internal representation of the
        scrollable layer.

        No tests because the ScrollingCoordinator is currently not testable.

        * page/scrolling/ScrollingCoordinator.cpp:
        (WebCore::computeNonFastScrollableRegion): Composited scrolling layers
        can be scrolled off the main thread.
        (WebCore):
        (WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
        Callback to ScrollingCoordinator about changes the composited scrolling layers.
        * page/scrolling/ScrollingCoordinator.h:
        (WebCore):
        (ScrollingCoordinator):
        * page/scrolling/ScrollingCoordinatorNone.cpp:
        (WebCore):
        (WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
        * platform/ScrollableArea.h:
        (WebCore::ScrollableArea::usesCompositedScrolling):
        * rendering/RenderLayer.cpp:
        (WebCore):
        (WebCore::RenderLayer::usesCompositedScrolling):
        * rendering/RenderLayer.h:
        (RenderLayer):
        (WebCore::RenderLayer::usesCompositedScrolling):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
        (WebCore::RenderLayerBacking::updateScrollingLayers):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::scrollingLayerDidChange):
        (WebCore):
        * rendering/RenderLayerCompositor.h:
        (RenderLayerCompositor):

91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120
2012-09-04  Brian Anderson  <brianderson@chromium.org>

        [chromium] Do not allow infinite pending frames in CCFrameRateController
        https://bugs.webkit.org/show_bug.cgi?id=94254

        Reviewed by James Robinson.

        Removes support for infinite pending frames in CCFrameRateController
        if swap acks are available.        

        Functionality covered by existing tests.

        * platform/graphics/chromium/cc/CCFrameRateController.cpp:
        (WebCore::CCFrameRateController::CCFrameRateController):
        (WebCore::CCFrameRateController::setMaxFramesPending):
        (WebCore::CCFrameRateController::setSwapBuffersCompleteSupported):
        (WebCore):
        (WebCore::CCFrameRateController::onTimerTick):
        (WebCore::CCFrameRateController::didBeginFrame):
        (WebCore::CCFrameRateController::didFinishFrame):
        * platform/graphics/chromium/cc/CCFrameRateController.h:
        (CCFrameRateController):
        * platform/graphics/chromium/cc/CCScheduler.cpp:
        (WebCore::CCScheduler::setSwapBuffersCompleteSupported):
        (WebCore):
        * platform/graphics/chromium/cc/CCScheduler.h:
        (CCScheduler):
        * platform/graphics/chromium/cc/CCThreadProxy.cpp:
        (WebCore::CCThreadProxy::initializeRendererOnImplThread):

121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148
2012-09-04  Tim Horton  <timothy_horton@apple.com>

        ASSERTion failure when SVG element is removed from document and readded
        https://bugs.webkit.org/show_bug.cgi?id=95517
        <rdar://problem/12175583>

        Reviewed by Brady Eidson.

        Previously, SVG animations would cease to animate when their parent
        <svg> element was removed and re-added to the document.

        Instead, to match Firefox and Opera, we should continue the animation
        with the same beginTime (i.e. the animation continues as if it had never
        been removed from the document).

        Test: svg/animations/reinserting-svg-into-document.html

        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::insertedInto): Don't call begin() on an already-started SMILTimeContainer().
        * svg/animation/SMILTimeContainer.cpp: 
        (WebCore::SMILTimeContainer::isStarted): Added.
        * svg/animation/SMILTimeContainer.h: Add isStarted().
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::insertedInto): Always reschedule SVGSMILElements with
        their parent SMILTimeContainer when they are inserted into the document, otherwise
        they are lost (and never again update) when their subtree is removed and then
        readded to the document.

149 150 151 152 153 154 155 156 157 158 159 160 161 162
2012-09-04  Andrei Bucur  <abucur@adobe.com>

        [CSS Regions] Destroying a render named flow thread without unregistering left-over content nodes triggered an assertion.
        https://bugs.webkit.org/show_bug.cgi?id=95645

        Reviewed by Abhishek Arya.

        This patch cleans up the render named flow thread before destruction by unregistering left-over content nodes.

        Tests: fast/regions/moved-content-node-crash.html

        * rendering/RenderNamedFlowThread.cpp:
        (WebCore::RenderNamedFlowThread::~RenderNamedFlowThread):

163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178
2012-09-04  Koji Ishii  <kojiishi@gmail.com>

        [chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium
        https://bugs.webkit.org/show_bug.cgi?id=95744

        Patch by Koji Ishii <kojiishi@gmail.com> on 2012-09-04
        Unreviewed build fix, verified by Scott Graham.

        The addition of 'platform/graphics/opentype/*' to webcore_platform in WebCore.gyp was redundant
        because '/opentype/' was already included to webcore_remaining.
        It was not only redundant but also breaks incremental linking.

        No new tests are required because no behavior changes.

        * WebCore.gyp/WebCore.gyp: Removed platform/graphics/opentype/* from webcore_platform.

179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202
2012-09-04  Otto Derek Cheung  <otcheung@rim.com>

        [BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection
        https://bugs.webkit.org/show_bug.cgi?id=95747

        PR199729

        Reviewed by Rob Buis.
        Internally Reviewed by Joe Mason.

        If the browser has never saved a secure protocol cookie in its mapping before,
        and it tries to set and retreive a secure cookie over a non-secure
        protocol, it will not show up because the link between the secure and
        non-secure mapping isn't created until a cookie (sent through secure) is set.

        The fix is to also check for the linkage in getRawCookies. Note that we cannot
        map the secure CookieMap to the non-secure one because getRawCookies is a const
        function.

        Manually tested using our Browser Test suite.

        * platform/blackberry/CookieManager.cpp:
        (WebCore::CookieManager::getRawCookies):

203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221
2012-09-04  Philippe Normand  <pnormand@igalia.com>

        [GStreamer] 0.11 build breaks due to rename of gst_message_new_duration
        https://bugs.webkit.org/show_bug.cgi?id=95751

        Reviewed by Martin Robinson.

        In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45
        gst_message_new_duration was renamed to
        gst_message_new_duration_changed.

        However the only place where we used this is in the HTTP source
        element and only if appsrc < 0.10.27 is used at runtime. In the
        case of GStreamer 1.0 this condition will be always false so we
        can disable this code at build time.

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (StreamingClient::didReceiveResponse):

222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281
2012-09-04  Andrei Poenaru  <poenaru@adobe.com>

        Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
        https://bugs.webkit.org/show_bug.cgi?id=93443

        Reviewed by Pavel Feldman.

        Added "regionLayoutUpdate" event to the protocol.

        Removed "getFlowByName" from protocol.

        The front-end keeps in sync the requested Named Flow Collections.

        Modified existing test: inspector/styles/protocol-css-regions-commands.html

        * dom/NamedFlowCollection.cpp:
        (WebCore::NamedFlowCollection::ensureFlowWithName):
        (WebCore::NamedFlowCollection::discardNamedFlow):
        * inspector/Inspector.json:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::didCreateNamedFlow):
        (WebCore::InspectorCSSAgent::willRemoveNamedFlow):
        (WebCore):
        (WebCore::InspectorCSSAgent::didUpdateRegionLayout):
        (WebCore::InspectorCSSAgent::getNamedFlowCollection):
        (WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):
        * inspector/InspectorCSSAgent.h:
        (InspectorCSSAgent):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore):
        (WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
        (WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
        (WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):
        * inspector/InspectorInstrumentation.h:
        (InspectorInstrumentation):
        (WebCore::InspectorInstrumentation::didCreateNamedFlow):
        (WebCore::InspectorInstrumentation::willRemoveNamedFlow):
        (WebCore):
        (WebCore::InspectorInstrumentation::didUpdateRegionLayout):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel):
        (WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
        (WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
        (WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
        (WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
        (WebInspector.CSSStyleModel.prototype._namedFlowCreated):
        (WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
        (WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
        (WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
        (WebInspector.CSSDispatcher.prototype.namedFlowCreated):
        (WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
        (WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
        (WebInspector.NamedFlow):
        (WebInspector.NamedFlowCollection):
        (WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
        (WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
        (WebInspector.NamedFlowCollection.prototype.flowByName):
        * rendering/RenderNamedFlowThread.cpp:
        (WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

282 283 284 285 286 287 288 289 290 291 292 293 294 295 296
2012-09-04  Jonathan Liu  <net147@gmail.com>

        Fix IDL dependency generation correctly
        https://bugs.webkit.org/show_bug.cgi?id=95730

        Reviewed by Csaba Osztrogonác.

        IDL dependency generation is still not working after
        https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces
        added after the filename in an echo command end up being added to the
        file which isn't handled correctly by preprocess-idls.pl. The problem
        is fixed by removing the space after the filename.

        * DerivedSources.pri:

297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312
2012-09-04  Mario Sanchez Prada  <msanchez@igalia.com>

        [Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
        https://bugs.webkit.org/show_bug.cgi?id=95618

        Reviewed by Martin Robinson.

        Make sure we only emit the the signal for menu lists and list
        boxes rendered from actual HTML select elements.

        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (WebCore::notifyChildrenSelectionChange): We support accessibility
        ListBoxes and MenuLists only here, assuming they represent HTML
        select elements, which might be not always true (e.g. ARIA). Thus,
        check if that condition is true, early returning in other case.

313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329
2012-09-04  Martin Robinson  <mrobinson@igalia.com>

        [Cairo] [TextureMapper] Assertion failure in TextureMapperGL
        https://bugs.webkit.org/show_bug.cgi?id=95713

        Reviewed by Noam Rosenthal.

        Fix an assertion failure by returning a valid context always for GraphicsContext3D::platformContext.
        This is important because TextureMapperGL uses the platform context to perform hashing.

        No new tests. This is covered by existing accelerated compositing tests.

        * platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
        (WebCore::GraphicsContext3DPrivate::platformContext): Return the current GLContext
        when getting the platform context for private GraphicsContext3DPrivates that render
        to the currently active context.

330 331 332 333 334 335 336 337 338 339 340 341 342
2012-09-04  Alexander Shalamov  <alexander.shalamov@intel.com>

        [EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash
        https://bugs.webkit.org/show_bug.cgi?id=86961

        Reviewed by Kenneth Rohde Christiansen.

        Add ecore_x initialisation check before calling ecore_x_bell
        to avoid crashes when X server is not running.

        * platform/efl/SoundEfl.cpp:
        (WebCore::systemBeep):

343 344 345 346 347 348 349 350 351 352 353 354 355
2012-09-04  Alexander Shalamov  <alexander.shalamov@intel.com>

        [EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash
        https://bugs.webkit.org/show_bug.cgi?id=86961

        Reviewed by Kenneth Rohde Christiansen.

        Add ecore_x initialisation check before calling ecore_x_bell
        to avoid crashes when X server is not running.

        * platform/efl/SoundEfl.cpp:
        (WebCore::systemBeep):

356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379
2012-09-04  Alexander Shalamov  <alexander.shalamov@intel.com>

        [EFL][WK2] CSS3 Media Queries functionality is broken
        https://bugs.webkit.org/show_bug.cgi?id=95680

        Reviewed by Kenneth Rohde Christiansen.

        In WK2, WebProcess doesn't have access to ewk_view evas object.
        Methods that get screen rect or screen depth either return incorrect value or crash.
        This patch removes dependency to ewk_view evas object and relies on ecore_x_* functions
        to get screen rectangle or color depth of the screen.

        * platform/efl/EflScreenUtilities.cpp: removed unused getPixelDepth method definition
        * platform/efl/EflScreenUtilities.h: removed unsused getPixelDepth method declaration
        (WebCore):
        * platform/efl/PlatformScreenEfl.cpp:
        (WebCore):
        (WebCore::screenHorizontalDPI):
        (WebCore::screenVerticalDPI):
        (WebCore::screenDepth):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        (WebCore::screenRect):

380 381 382 383 384 385 386 387 388 389 390 391
2012-09-04  Michał Pakuła vel Rutka  <m.pakula@samsung.com>

        [EFL] Context menu restore.
        https://bugs.webkit.org/show_bug.cgi?id=74179

        Reviewed by Gyuyoung Kim.

        Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
        approach, the same as used in WebKit2.

        * PlatformEfl.cmake: Removed -DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1

392 393 394 395 396 397 398 399 400 401 402 403
2012-09-04  Andrey Adaikin  <aandrey@chromium.org>

        Web Inspector: [WebGL] Bugfix: wrong texture binding target in replay for 3D textures
        https://bugs.webkit.org/show_bug.cgi?id=95687

        Reviewed by Vsevolod Vlasov.

        gl.bindTexture accepts either TEXTURE_2D or TEXTURE_CUBE_MAP targets, but we tried to replay with TEXTURE_CUBE_MAP_POSITIVE_X and others for 3D textures.

        * inspector/InjectedScriptWebGLModuleSource.js:
        (.):

404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442
2012-09-04  Allan Sandfeld Jensen  <allan.jensen@nokia.com>

        Allow child-frame content in hit-tests.
        https://bugs.webkit.org/show_bug.cgi?id=95204

        Reviewed by Antonio Gomes.

        Refactors how EventHandler::hitTestResultAtPoint handles child-frame content,
        it is now handled by the hit test itself controlled by the AllowChildFrameContent
        flag in HitTestRequest.

        Tests: fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html
               touchadjustment/iframe-boundary.html

        * WebCore.exp.in:
        * WebCore.order:
        * dom/Document.cpp:
        (WebCore::Document::nodesFromRect):
        * dom/Document.h:
        (Document):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::hitTestResultAtPoint):
        * rendering/HitTestRequest.h:
        (WebCore::HitTestRequest::allowChildFrameContent):
        (WebCore::HitTestRequest::childFrameHitTest):
        (WebCore::HitTestRequest::testChildFrameScrollBars):
        * rendering/RenderFrameBase.cpp:
        (WebCore::RenderFrameBase::nodeAtPoint):
        (WebCore):
        * rendering/RenderFrameBase.h:
        (RenderFrameBase):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTest):
        * testing/Internals.cpp:
        (WebCore::Internals::nodesFromRect):
        * testing/Internals.h:
        (Internals):
        * testing/Internals.idl:

443 444 445 446 447 448 449 450 451 452 453 454 455 456 457
2012-09-04  Christophe Dumez  <christophe.dumez@intel.com>

        [EFL] Fix build error in NetworkStateNotifierEfl.cpp
        https://bugs.webkit.org/show_bug.cgi?id=95724

        Unreviewed EFL build fix.

        Make sure <sys/socket.h> is included before
        <linux/netlink.h> to fix build errors on some
        systems (e.g. Ubuntu 11.10).

        No new tests, no behavior change.

        * platform/network/efl/NetworkStateNotifierEfl.cpp:

458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513
2012-09-04  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Create JavaScriptSources based on network resources.
        https://bugs.webkit.org/show_bug.cgi?id=95352

        Reviewed by Pavel Feldman.

        Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
        RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
        Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
        Removed rawSourceCode as it was not needed anymore.

        Tests: inspector/debugger/network-uisourcecode-provider.html
               inspector/debugger/resource-script-mapping.html

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/compile-front-end.py:
        * inspector/front-end/CompilerScriptMapping.js:
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerDispatcher.prototype.scriptFailedToParse):
        * inspector/front-end/JavaScriptSource.js:
        (WebInspector.JavaScriptSource):
        * inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.
        (WebInspector.NetworkUISourceCodeProvider):
        (WebInspector.NetworkUISourceCodeProvider.prototype._populate):
        (WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
        (WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
        (WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
        (WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
        (WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
        (WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
        (WebInspector.NetworkUISourceCodeProvider.prototype._reset):
        * inspector/front-end/RawSourceCode.js:
        * inspector/front-end/ResourceScriptMapping.js:
        (WebInspector.ResourceScriptMapping):
        (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
        (WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
        (WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
        (WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
        (WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
        (WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
        (WebInspector.ResourceScriptMapping.prototype._reset):
        * inspector/front-end/ScriptSnippetModel.js:
        (WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
        (WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
        (WebInspector.SnippetJavaScriptSource):
        * inspector/front-end/UISourceCode.js:
        (WebInspector.UISourceCode):
        (WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
        (WebInspector.UISourceCode.prototype.setSourceMapping):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/Workspace.js: Drive-by: fixed duplicating uiSourceCodes in workspace.
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:

514 515 516 517 518 519 520 521 522 523 524 525
2012-09-04  Andrey Adaikin  <aandrey@chromium.org>

        Web Inspector: [WebGL] Save gl.getError() status before taking a WebGL state snapshot and restore it afterwards
        https://bugs.webkit.org/show_bug.cgi?id=95443

        Reviewed by Vsevolod Vlasov.

        Save gl.getError() status before taking the GL snapshot and restore it afterwards.

        * inspector/InjectedScriptWebGLModuleSource.js:
        (.):

526 527 528 529 530 531 532 533 534 535 536
2012-09-04  Alexander Pavlov  <apavlov@chromium.org>

        Web Inspector: More directional control characters for debugging in inspector
        https://bugs.webkit.org/show_bug.cgi?id=95696

        Reviewed by Vsevolod Vlasov.

        Entities for text directionality-related characters added (LRE, RLE, LRO, RLO, PDF).

        * inspector/front-end/ElementsTreeOutline.js:

537 538 539 540 541 542 543 544 545 546 547 548
2012-09-04  Yury Semikhatsky  <yurys@chromium.org>

        Web Inspector: new CPU Profiles are not shown after reattach
        https://bugs.webkit.org/show_bug.cgi?id=95686

        Reviewed by Vsevolod Vlasov.

        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::restore): set m_headersRequested flags
        to true and clear all profiles on the front-end since there are no
        collected profiles yet immediately after render process sitching.

549 550 551 552 553 554 555 556 557 558 559 560 561
2012-09-04  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: NMI: cosmetic change, rename m_domMemoryUsage to m_memoryInstrumentation.
        https://bugs.webkit.org/show_bug.cgi?id=95716

        Also m_memoryInstrumentation became a reference to external object because it has other life time than domNodeVisitor.

        Reviewed by Yury Semikhatsky.

        * inspector/InspectorMemoryAgent.cpp:
        (WebCore):
        (WebCore::collectDomTreeInfo):

562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598
2012-08-31  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Port the Qt pixmap JS bindings to use the JSC C API
        https://bugs.webkit.org/show_bug.cgi?id=94702

        Reviewed by Kenneth Rohde Christiansen.

        Based on patch by Noam Rosenthal.

        The conversion uses a simple JSClassRef based binding and only a few
        uses of private JSC API for the HTML element DOM bindings remain.

        This is essentially used for wrapping QPixmap and QImage types in
        JavaScript and the other way around, for retrieving the image data
        out of a HTML image element when converting from JS/DOM to Qt.

        * bridge/qt/qt_pixmapruntime.cpp:
        (JSC::Bindings::copyPixels):
        (JSC::Bindings::toPixmap):
        (JSC::Bindings::toImage):
        (JSC::Bindings::imageSizeForVariant):
        (JSC::Bindings::getPixmapWidth):
        (JSC::Bindings::getPixmapHeight):
        (JSC::Bindings::assignToHTMLImageElement):
        (JSC::Bindings::pixmapToImageData):
        (JSC::Bindings::pixmapToDataUrl):
        (JSC::Bindings::pixmapToString):
        (JSC::Bindings::QtPixmapRuntime::toJS):
        (JSC::Bindings::QtPixmapRuntime::toQt):
        (JSC::Bindings::QtPixmapRuntime::canHandle):
        (JSC::Bindings::QtPixmapRuntime::getClassRef):
        * bridge/qt/qt_pixmapruntime.h:
        (QtPixmapRuntime):
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertValueToQVariant):
        (JSC::Bindings::convertQVariantToValue):

599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636
2012-09-03  Andreas Kling  <kling@webkit.org>

        Share immutable ElementAttributeData between elements with identical attributes.
        <http://webkit.org/b/94990>

        Reviewed by Antti Koivisto.

        Keep a cache of ElementAttributeData objects for a given set of attributes and reuse
        them in elements with identical attribute maps. ElementAttributeData is made ref-counted
        to facilitate this. A copy-on-write mechanism is already in place, since mutating call
        sites have to go via Element::mutableAttributeData().

        The cache is held by Document and cleared in Document::finishedParsing() since the vast
        majority of immutable ElementAttributeData will be constructed during parsing.

        On the HTML5 spec at <http://whatwg.org/c/>, we get a cache hit rate of nearly 80%,
        translating into a 3.5MB reduction in memory use.

        * dom/Document.cpp:
        (WebCore::Document::finishedParsing):
        (ImmutableAttributeDataCacheKey):
        (WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
        (WebCore::ImmutableAttributeDataCacheKey::operator!=):
        (WebCore::ImmutableAttributeDataCacheKey::hash):
        (ImmutableAttributeDataCacheEntry):
        (WebCore::Document::cachedImmutableAttributeData):
        * dom/Document.h:
        * dom/Element.cpp:
        (WebCore::Element::parserSetAttributes):
        * dom/Element.h:
        * dom/ElementAttributeData.cpp:
        (WebCore::ElementAttributeData::createImmutable):
        (WebCore::ElementAttributeData::ElementAttributeData):
        * dom/ElementAttributeData.h:
        (WebCore::ElementAttributeData::create):
        (ElementAttributeData):
        (WebCore::ElementAttributeData::makeMutable):

637 638 639 640 641 642 643 644 645 646 647 648 649 650
2012-09-03  Peter Wang  <peter.wang@torchmobile.com.cn>

        Web Inspector: the URL of worker inspector window sometimes is invalid
        https://bugs.webkit.org/show_bug.cgi?id=95334

        Reviewed by Pavel Feldman.

        In "_openInspectorWindow", before "&dedicatedWorkerId=" should have a '?' to make the whole URL valid.

        No new tests case for this bug.

        * inspector/front-end/WorkerManager.js:
        (WebInspector.WorkerManager.prototype._openInspectorWindow):

651 652 653 654 655 656 657 658 659 660 661 662 663 664 665
2012-09-03  Jinwoo Song  <jinwoo7.song@samsung.com>

        [EFL] Fix e_dbus_shutdown() error when exiting the Minibrowser
        https://bugs.webkit.org/show_bug.cgi?id=95636

        Reviewed by Gyuyoung Kim.

        Check if the m_timer is active in stopUpdating()
        to know the BatteryProvider is updating or not.
        By checking the timer, stopUpdating() will be called 
        only BatteryProviderEfl is updating.

        * platform/efl/BatteryProviderEfl.cpp:
        (WebCore::BatteryProviderEfl::stopUpdating):

666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716
2012-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r127427.
        http://trac.webkit.org/changeset/127427
        https://bugs.webkit.org/show_bug.cgi?id=95695

        Breaks some inspector/debugger tests on JSC (Requested by
        vsevik on #webkit).

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/compile-front-end.py:
        * inspector/front-end/CompilerScriptMapping.js:
        * inspector/front-end/JavaScriptSource.js:
        (WebInspector.JavaScriptSource):
        * inspector/front-end/NetworkUISourceCodeProvider.js: Removed.
        * inspector/front-end/RawSourceCode.js:
        (WebInspector.RawSourceCode):
        (WebInspector.RawSourceCode.prototype.addScript):
        (WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
        (WebInspector.RawSourceCode.prototype._createUISourceCode):
        (WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
        (WebInspector.RawSourceCode.prototype.uiSourceCode):
        (WebInspector.RawSourceCode.prototype._finishedLoading):
        * inspector/front-end/ResourceScriptMapping.js:
        (WebInspector.ResourceScriptMapping):
        (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
        (WebInspector.ResourceScriptMapping.prototype.addScript):
        (WebInspector.ResourceScriptMapping.prototype._shouldBindScriptToContentProvider):
        (WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
        (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
        (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
        (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
        (WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):
        (WebInspector.ResourceScriptMapping.prototype._reset):
        * inspector/front-end/ScriptSnippetModel.js:
        (WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
        (WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
        (WebInspector.SnippetJavaScriptSource):
        * inspector/front-end/StylesUISourceCodeProvider.js: Added.
        (WebInspector.StylesUISourceCodeProvider):
        (WebInspector.StylesUISourceCodeProvider.prototype._populate):
        (WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
        (WebInspector.StylesUISourceCodeProvider.prototype._reset):
        * inspector/front-end/UISourceCode.js:
        (WebInspector.UISourceCode):
        (WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:

717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769
2012-09-03  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Create JavaScriptSources based on network resources.
        https://bugs.webkit.org/show_bug.cgi?id=95352

        Reviewed by Pavel Feldman.

        Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
        RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
        Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
        Removed rawSourceCode as it was not needed anymore.

        Tests: inspector/debugger/network-uisourcecode-provider.html
               inspector/debugger/resource-script-mapping.html

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/compile-front-end.py:
        * inspector/front-end/CompilerScriptMapping.js:
        * inspector/front-end/JavaScriptSource.js:
        (WebInspector.JavaScriptSource):
        * inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.
        (WebInspector.NetworkUISourceCodeProvider):
        (WebInspector.NetworkUISourceCodeProvider.prototype._populate):
        (WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
        (WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
        (WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
        (WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
        (WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
        (WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
        (WebInspector.NetworkUISourceCodeProvider.prototype._reset):
        * inspector/front-end/RawSourceCode.js:
        * inspector/front-end/ResourceScriptMapping.js:
        (WebInspector.ResourceScriptMapping):
        (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
        (WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
        (WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
        (WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
        (WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
        (WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
        (WebInspector.ResourceScriptMapping.prototype._reset):
        * inspector/front-end/ScriptSnippetModel.js:
        (WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
        (WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
        (WebInspector.SnippetJavaScriptSource):
        * inspector/front-end/UISourceCode.js:
        (WebInspector.UISourceCode):
        (WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
        (WebInspector.UISourceCode.prototype.setSourceMapping):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:

770 771 772 773 774 775 776 777 778 779 780 781 782 783
2012-09-03  Andrey Adaikin  <aandrey@chromium.org>

        Web Inspector: [WebGL] Make the injected __resourceObject property non-enumerable
        https://bugs.webkit.org/show_bug.cgi?id=95682

        Reviewed by Pavel Feldman.

        Make the injected auxiliary property __resourceObject non-enumerable to hide it from for..in iterations.
        Ideally this property should be completely hidden from the user's code.
        Drive-by: Fix couple of small FIXME's.

        * inspector/InjectedScriptWebGLModuleSource.js:
        (.):

784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856
2012-09-03  Tommy Widenflycht  <tommyw@google.com>

        MediaStream API: Add Ice-related functionality to RTCPeerConnection
        https://bugs.webkit.org/show_bug.cgi?id=95565

        Reviewed by Adam Barth.

        Adds all Ice-related functionality to RTCPeerConnection, including
        events, callbacks and methods.

        Test: fast/mediastream/RTCPeerConnection-ice.html

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * Modules/mediastream/RTCIceCandidateEvent.cpp: Added.
        (WebCore):
        (WebCore::RTCIceCandidateEvent::create):
        (WebCore::RTCIceCandidateEvent::RTCIceCandidateEvent):
        (WebCore::RTCIceCandidateEvent::~RTCIceCandidateEvent):
        (WebCore::RTCIceCandidateEvent::candidate):
        (WebCore::RTCIceCandidateEvent::interfaceName):
        * Modules/mediastream/RTCIceCandidateEvent.h: Added.
        (WebCore):
        (RTCIceCandidateEvent):
        * Modules/mediastream/RTCIceCandidateEvent.idl: Added.
        * Modules/mediastream/RTCPeerConnection.cpp:
        (WebCore::RTCPeerConnection::RTCPeerConnection):
        (WebCore::RTCPeerConnection::updateIce):
        (WebCore):
        (WebCore::RTCPeerConnection::addIceCandidate):
        (WebCore::RTCPeerConnection::iceState):
        (WebCore::RTCPeerConnection::close):
        (WebCore::RTCPeerConnection::didGenerateIceCandidate):
        (WebCore::RTCPeerConnection::didChangeIceState):
        (WebCore::RTCPeerConnection::stop):
        (WebCore::RTCPeerConnection::changeIceState):
        * Modules/mediastream/RTCPeerConnection.h:
        (RTCPeerConnection):
        * Modules/mediastream/RTCPeerConnection.idl:
        * WebCore.gypi:
        * dom/EventNames.h:
        (WebCore):
        * dom/EventNames.in:
        * platform/chromium/support/WebRTCICECandidateDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp.
        (WebKit):
        (WebKit::WebRTCICECandidateDescriptor::WebRTCICECandidateDescriptor):
        (WebKit::WebRTCICECandidateDescriptor::assign):
        (WebKit::WebRTCICECandidateDescriptor::reset):
        (WebKit::WebRTCICECandidateDescriptor::initialize):
        (WebKit::WebRTCICECandidateDescriptor::operator PassRefPtr<WebCore::RTCIceCandidateDescriptor>):
        (WebKit::WebRTCICECandidateDescriptor::candidate):
        (WebKit::WebRTCICECandidateDescriptor::sdpMid):
        (WebKit::WebRTCICECandidateDescriptor::sdpMLineIndex):
        * platform/mediastream/RTCIceCandidateDescriptor.h:
        (WebCore::RTCIceCandidateDescriptor::candidate):
        (WebCore::RTCIceCandidateDescriptor::sdpMid):
        (WebCore::RTCIceCandidateDescriptor::sdpMLineIndex):
        * platform/mediastream/RTCPeerConnectionHandler.h:
        (WebCore):
        (RTCPeerConnectionHandler):
        * platform/mediastream/RTCPeerConnectionHandlerClient.h:
        (WebCore):
        (RTCPeerConnectionHandlerClient):
        * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
        (WebCore::RTCPeerConnectionHandlerChromium::updateIce):
        (WebCore):
        (WebCore::RTCPeerConnectionHandlerChromium::addIceCandidate):
        (WebCore::RTCPeerConnectionHandlerChromium::didGenerateICECandidate):
        (WebCore::RTCPeerConnectionHandlerChromium::didChangeICEState):
        * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
        (WebKit):
        (RTCPeerConnectionHandlerChromium):

857 858 859 860 861 862 863
2012-09-03  Allan Sandfeld Jensen  <allan.jensen@nokia.com>

        Unreviewed build fix after r127421

        * rendering/HitTestResult.cpp:
        (WebCore::HitTestLocation::HitTestLocation):

864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912
2012-09-03  Allan Sandfeld Jensen  <allan.jensen@nokia.com>

        Move AllowShadowContent flag to HitTestRequest 
        https://bugs.webkit.org/show_bug.cgi?id=95685

        Reviewed by Antonio Gomes.

        Moves the flag and updates the interface for HitTestResult::addNodeToRectBasedTestResult so that
        it can read the flag from HitTestRequest instead of from HitTestResult.

        No change in functionality. No new tests.

        * dom/Document.cpp:
        (WebCore::Document::nodesFromRect):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::hitTestResultAtPoint):
        * rendering/HitTestRequest.h:
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestLocation::HitTestLocation):
        (WebCore::HitTestResult::HitTestResult):
        (WebCore::HitTestResult::operator=):
        (WebCore::HitTestResult::addNodeToRectBasedTestResult):
        * rendering/HitTestResult.h:
        (HitTestLocation):
        (HitTestResult):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::nodeAtPoint):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::nodeAtPoint):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::nodeAtPoint):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::nodeAtPoint):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::nodeAtPoint):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::RenderLayer::hitTestList):
        * rendering/RenderMultiColumnSet.cpp:
        (WebCore::RenderMultiColumnSet::nodeAtPoint):
        * rendering/RenderRegion.cpp:
        (WebCore::RenderRegion::nodeAtPoint):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::nodeAtPoint):
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::nodeAtPoint):
        * rendering/svg/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::nodeAtPoint):

913 914 915 916 917 918 919 920 921 922 923 924
2012-09-03  Alexander Pavlov  <apavlov@chromium.org>

        Web Inspector: Unhide hidden characters
        https://bugs.webkit.org/show_bug.cgi?id=93888

        Reviewed by Pavel Feldman.

        Certain invisible characters will be rendered as HTML entity references in the DOM tree to make them visible to the user.

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._startEditingTextNode):

925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950
2012-09-03  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: rename JavaScriptContextManager to RuntimeModel for consistency.
        https://bugs.webkit.org/show_bug.cgi?id=95677

        Reviewed by Yury Semikhatsky.

        - renamed the file and the usages
        - renamed isolatedContextCreated to executionContextCreated for consistency.

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/Inspector.json:
        * inspector/PageRuntimeAgent.cpp:
        (WebCore::PageRuntimeAgent::notifyContextCreated):
        * inspector/compile-front-end.py:
        * inspector/front-end/RuntimeModel.js: Renamed from Source/WebCore/inspector/front-end/JavaScriptContextManager.js.
        (WebInspector.RuntimeModel):
        (WebInspector.RuntimeModel.prototype._frameAdded):
        (WebInspector.RuntimeModel.prototype._frameDetached):
        (WebInspector.RuntimeModel.prototype._executionContextCreated):
        (WebInspector.RuntimeDispatcher):
        (WebInspector.RuntimeDispatcher.prototype.executionContextCreated):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

951 952 953 954 955 956 957 958 959 960 961 962 963 964
2012-09-03  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: use linkifyResourceAsNode, not linkifyLocation when linkifying resources in Timeline
        https://bugs.webkit.org/show_bug.cgi?id=95540

        Reviewed by Pavel Feldman.

        Linkify recource details using WebInspector.linkifyResourceAsNode(), so these bypass linkifier. Also
        fix closure compiler warning.

        * inspector/front-end/TimelinePresentationModel.js:
        (WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
        (WebInspector.TimelinePresentationModel.Record.prototype._linkifyLocation):

965 966 967 968 969 970 971 972
2012-09-03  'Pavel Feldman'  <pfeldman@chromium.org>

        Web Inspector: fixed front-end compilation warnings.
        Not reviewed.

        * inspector/front-end/FilteredItemSelectionDialog.js:
        * inspector/front-end/HeapSnapshotView.js:

973 974 975 976 977 978 979 980 981 982 983
2012-09-03  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: paint grid on top of box highlight.
        https://bugs.webkit.org/show_bug.cgi?id=95676

        Reviewed by Alexander Pavlov.

        Otherwise, ruler numbers are not visible when selecting body.

        * inspector/InspectorOverlayPage.html:

984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019
2012-08-31  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: get rid of context execution id fallback.
        https://bugs.webkit.org/show_bug.cgi?id=95567

        Reviewed by Yury Semikhatsky.

        We now assign execution context id upon changes in the UI.

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.get statusBarItems):
        (WebInspector.ConsoleView.prototype._contextAdded):
        (WebInspector.ConsoleView.prototype._addContextList):
        (WebInspector.ConsoleView.prototype._contextListRemoved):
        (WebInspector.ConsoleView.prototype._updateExecutionContextSelector):
        (WebInspector.ConsoleView.prototype._appendExecutionContextOption):
        (WebInspector.ConsoleView.prototype._executionContextChanged):
        (WebInspector.ConsoleView.prototype._contextListUpdated):
        (WebInspector.ConsoleView.prototype._addedExecutionContext):
        (WebInspector.ConsoleView.prototype.evalInInspectedWindow.evalCallback):
        (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
        (WebInspector.ConsoleView.prototype._enterKeyPressed):
        * inspector/front-end/JavaScriptContextManager.js:
        (WebInspector.JavaScriptContextManager):
        (WebInspector.JavaScriptContextManager.prototype.contextLists):
        (WebInspector.JavaScriptContextManager.prototype.contextByFrameAndSecurityOrigin):
        (WebInspector.JavaScriptContextManager.prototype._frameAdded):
        (WebInspector.JavaScriptContextManager.prototype._frameNavigated):
        (WebInspector.JavaScriptContextManager.prototype._frameDetached):
        (WebInspector.JavaScriptContextManager.prototype.isolatedContextCreated):
        (WebInspector.FrameExecutionContextList):
        (WebInspector.FrameExecutionContextList.prototype._frameNavigated):
        (WebInspector.FrameExecutionContextList.prototype._addExecutionContext):
        (WebInspector.FrameExecutionContextList.prototype.executionContexts):
        (WebInspector.FrameExecutionContextList.prototype.contextBySecurityOrigin):

1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037
2012-09-03  Grzegorz Czajkowski  <g.czajkowski@samsung.com>

        [GTK][EFL] 'dictIter' iterator is not initialized for an inner loop
        https://bugs.webkit.org/show_bug.cgi?id=95436

        Reviewed by Gustavo Noronha Silva.

        The 'checkSpellingOfString' method assumes that the given string is concatenation of words.
        To properly handle spellchecking of each word we need to iterate over the all available
        dictionaries ('dictIter').

        To allow spellchecking for multiple words, 'dictIter' should be initialized at the beginning
        of vector while spellchecking of the word. This ensures performing of spelling for word based on
        at least one dictionary.

        * platform/text/enchant/TextCheckerEnchant.cpp:
        (TextCheckerEnchant::checkSpellingOfString): Moved initialization of 'dictIter' to an inner loop.

1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065
2012-09-02  Yoshifumi Inoue  <yosin@chromium.org>

        [Forms] Empty visible value of AM/PM field of multiple fields time input UI should display variable number of "-" based on maximum number of labels
        https://bugs.webkit.org/show_bug.cgi?id=95660

        Reviewed by Kent Tamura.

        This patch changes visible empty value of AM/PM field in multiple
        fields time input UI to "-", "--", "---", and so on based on maximum
        length of AM/PM labels. In current implementation, it is always "--"
        regardless locale, although on Arabic, AM/PM are represented in one
        character.

        This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
        ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

        No new tests. Once multiple field time input UI uses "lang" HTML
        attribute to take time format, we can write a test for this patch.

        * html/shadow/DateTimeSymbolicFieldElement.cpp:
        (makeVisibleEmptyValue): Build visible empty value from maximum length
        of labels.
        (WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Changed to
        use m_visibleEmptyValue.
        * html/shadow/DateTimeSymbolicFieldElement.h:
        (WebCore::DateTimeSymbolicFieldElement): Added new member variable
        m_visibleEmptyValue to hold visible empty value.

1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092
2012-09-02  Yoshifumi Inoue  <yosin@chromium.org>

        [Forms] AM/PM field of multiple fields time input UI should be fixed width
        https://bugs.webkit.org/show_bug.cgi?id=95542

        Reviewed by Kent Tamura.

        This patch changes width of AM/PM field of multiple field time input
        UI fixed as maximum width of labels or "--".

        This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
        ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

        No new tests. Once multiple field time input UI uses "lang" HTML
        attribute to take time format, we can write a test for this patch.

        * css/html.css:
        (input::-webkit-datetime-edit-ampm-field): Added "display" property to "inline-block" for setting width.
        Added "text-align" property to "center".
        * html/shadow/DateTimeSymbolicFieldElement.cpp:
        (WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement): Changed to call setHasCustomCallback().
        (WebCore::DateTimeSymbolicFieldElement::customStyleForRenderer): Added for setting field with from maximum width of labels.
        * html/shadow/DateTimeSymbolicFieldElement.h:
        (WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Added for using visible empty value in customStyleForRenderer() and visibleValue().
        (WebCore::DateTimeSymbolicFieldElement::visibleValue): Changed to call visibleEmptyValue() instead of using literal "--".
        (DateTimeSymbolicFieldElement): Added a declaration of customStyleForRenderer().

1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110
2012-09-02  Benjamin Poulain  <bpoulain@apple.com>

        Improve the way we use convertedSpaceString() in convertHTMLTextToInterchangeFormat()
        https://bugs.webkit.org/show_bug.cgi?id=95301

        Reviewed by Darin Adler.

        The static string convertedSpaceString() had a couple of annoying side effects:
        -The string was 16bits due to noBreakSpace, which forced any input to be converted to 16bits.
        -The string was kept in the heap for no particular reason.

        This patch redefines convertedSpaceString as a constant literal so that we can use it efficiently.

        The patch also make the binary a tiny bit smaller (700 bytes).

        * editing/HTMLInterchange.cpp:
        (WebCore::convertHTMLTextToInterchangeFormat):

1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122
2012-09-02  Mike West  <mkwst@chromium.org>

        Build is broken when SVG is disabled.
        https://bugs.webkit.org/show_bug.cgi?id=95653

        Reviewed by Dirk Schulze.

        Adding CSSPropertyWebkitClipPath to the massive switch statement in StyleResolver.

        * css/StyleResolver.cpp:
        (WebCore::StyleResolver::collectMatchingRulesForList):

1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167
2012-08-31  Antti Koivisto  <antti@apple.com>

        Repaints should not be deferred after initial page load is complete
        https://bugs.webkit.org/show_bug.cgi?id=95480

        Reviewed by Simon Fraser

        Any dynamically triggered resource loading currently sends us back to deferred paint mode, making animation choppy. 
        This is not the intention of this code.

        This patch adds an additional condition that prevents page from re-entering deferred repaint mode after the initial
        load has completed. It also cleans up the code slightly.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkCompleted):
        
            Add additional call to checkStopDelayingDeferredRepaints() after a frame load completes as the
            new condition in shouldUseLoadTimeDeferredRepaintDelay() looks for this change too.

        * page/FrameView.cpp:
        (WebCore):
        
            Reduced the normal delay from 25ms to 16ms to not interfere with full framerate animation.

        (WebCore::FrameView::syncCompositingStateForThisFrame):
        (WebCore::FrameView::checkFlushDeferredRepaintsAfterLoadComplete):
        
            Ensure the repaint delay is reset after load completes even if we don't currently need a repaint.

        (WebCore::FrameView::flushDeferredRepaints):
        
            We had to identical functions, flushDeferredRepaints() and stopDelayingDeferredRepaints(). Remove
            the latter.

        (WebCore::FrameView::shouldUseLoadTimeDeferredRepaintDelay):
        
            Factor the test for using load time repaint timings to a functions. The test for
            initial page load having completed is new.

        (WebCore::FrameView::updateDeferredRepaintDelay):
        (WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
        (WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelay):
        * page/FrameView.h:
        (FrameView):

1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183
2012-09-02  Filip Pizlo  <fpizlo@apple.com>

        Don't create access error strings if there is no access error
        https://bugs.webkit.org/show_bug.cgi?id=95652

        Reviewed by Adam Barth.
        
        This undoes the 50% performance regression in pdfjs caused by
        http://trac.webkit.org/changeset/126165

        No new tests because behavior is unchanged.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::shouldAllowAccessToFrame):
        (WebCore::shouldAllowAccessToDOMWindow):

1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240
2012-08-31  Dirk Schulze  <krit@webkit.org>

        Use -webkit-clip-path shapes to clip SVG elements
        https://bugs.webkit.org/show_bug.cgi?id=95620

        Reviewed by Rob Buis.

        This patch adds a path segment for a BasicShape to a given Path object. This
        path and it's wind rule are used to clip the context of the SVG element.

        Tests: svg/clip-path/clip-path-shape-circle-1-expected.svg
               svg/clip-path/clip-path-shape-circle-1.svg
               svg/clip-path/clip-path-shape-circle-2-expected.svg
               svg/clip-path/clip-path-shape-circle-2.svg
               svg/clip-path/clip-path-shape-ellipse-1-expected.svg
               svg/clip-path/clip-path-shape-ellipse-1.svg
               svg/clip-path/clip-path-shape-ellipse-2-expected.svg
               svg/clip-path/clip-path-shape-ellipse-2.svg
               svg/clip-path/clip-path-shape-polygon-1-expected.svg
               svg/clip-path/clip-path-shape-polygon-1.svg
               svg/clip-path/clip-path-shape-polygon-2-expected.svg
               svg/clip-path/clip-path-shape-polygon-2.svg
               svg/clip-path/clip-path-shape-polygon-3-expected.svg
               svg/clip-path/clip-path-shape-polygon-3.svg
               svg/clip-path/clip-path-shape-rounded-rect-1-expected.svg
               svg/clip-path/clip-path-shape-rounded-rect-1.svg
               svg/clip-path/clip-path-shape-rounded-rect-2-expected.svg
               svg/clip-path/clip-path-shape-rounded-rect-2.svg

        * rendering/style/BasicShapes.cpp: Added helper functions that apply path segments to a given path.
        (WebCore::BasicShapeRectangle::path):
        (WebCore::BasicShapeCircle::path):
        (WebCore::BasicShapeEllipse::path):
        (WebCore::BasicShapePolygon::path):
        * rendering/style/BasicShapes.h: Make BasicShape virtualized again, since new virtual functions were added.
        (WebCore::BasicShape::~BasicShape):
        (BasicShape):
        (WebCore::BasicShape::windRule): Will return the wind rule of the shape - nonzero by default.
        (WebCore::BasicShape::BasicShape):
        (BasicShapeRectangle):
        (WebCore::BasicShapeRectangle::type): Removed member variable and return type per inheriting class directly.
        (WebCore::BasicShapeRectangle::BasicShapeRectangle):
        (BasicShapeCircle):
        (WebCore::BasicShapeCircle::type): Ditto.
        (WebCore::BasicShapeCircle::BasicShapeCircle):
        (BasicShapeEllipse):
        (WebCore::BasicShapeEllipse::type): Ditto.
        (WebCore::BasicShapeEllipse::BasicShapeEllipse):
        (BasicShapePolygon):
        (WebCore::BasicShapePolygon::windRule):
        (WebCore::BasicShapePolygon::type): Ditto.
        (WebCore::BasicShapePolygon::BasicShapePolygon):
        * rendering/svg/SVGRenderingContext.cpp: If -webkit-clip-path was defined, clip the context to the shape.
        Right now -webkit-clip-path overrides clip-path, so that people don't use both at the same time. Current
        clip-path property will be replaced, once -webkit-clip-path gets unprefixed.
        (WebCore::SVGRenderingContext::prepareToRenderSVGContent):

1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273
2012-09-01  Ned Holbrook  <nholbrook@apple.com>

        Regression(r126763): Heap-use-after-free in WebCore::nextBreakablePosition
        https://bugs.webkit.org/show_bug.cgi?id=95229

        Reviewed by Dan Bernstein.

        TextLayout and LazyLineBreakIterator cache a RenderText's string during line breaking but RenderCounter
        and RenderQuote can replace that string during preferred width calculation. This patch adds a non-virtual member
        function to RenderText named updateTextIfNeeded() that triggers immediate string replacement by calling
        the new virtual updateText() if necessary, which in turn calls computePreferredLogicalWidths(). In this way
        RenderBlock::LineBreaker::nextLineBreak() can ensure a RenderText's string is current before caching it.

        Test: fast/css/content/content-quotes-crash.html

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::dirtyLineBoxesForRenderer): Drive-by: replace existing code with the equivalent updateTextIfNeeded().
        (WebCore::RenderBlock::LineBreaker::nextLineBreak): Use updateTextIfNeeded() prior to caching RenderText string.
        * rendering/RenderCounter.cpp:
        (WebCore::RenderCounter::updateText): Call computePreferredLogicalWidths().
        (WebCore):
        * rendering/RenderCounter.h:
        (RenderCounter):
        * rendering/RenderQuote.cpp:
        (WebCore::RenderQuote::updateText): Call computePreferredLogicalWidths().
        (WebCore):
        * rendering/RenderQuote.h:
        (RenderQuote):
        * rendering/RenderText.h:
        (WebCore::RenderText::updateTextIfNeeded): Only call virtual updateText() if necessary.
        (RenderText):
        (WebCore::RenderText::updateText): Add no-op default implementation for new virtual member function.

1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289
2012-09-01  Li Yin  <li.yin@intel.com>

        fast/events/message-port-clone.html hits ASSERT in Debug (usually in later tests)
        https://bugs.webkit.org/show_bug.cgi?id=85811

        Reviewed by Kenneth Rohde Christiansen.

        When MessagePort invoked close function, the close status is needed to set,
        regardless of whether the port is cloned or not.

        Tests: fast/events/message-port-clone.html
               fast/events/message-port-close.html

        * dom/MessagePort.cpp:
        (WebCore::MessagePort::close): Must set m_closed to be true.

1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308
2012-09-01  Andreas Kling  <kling@webkit.org>

        Share inline style between cloned Nodes (copy on write.)
        <http://webkit.org/b/95451>

        Reviewed by Antti Koivisto.

        When cloning a Node, use an immutable StylePropertySet for the new Node's inline style.
        If the old Node already had an immutable inline style, we now reuse that, avoiding a copy.
        Copying is deferred until mutation (either via CSSOM or setting of the style attribute.)

        * dom/ElementAttributeData.cpp:
        (WebCore::ElementAttributeData::cloneDataFrom):
        * css/StylePropertySet.h:
        * css/StylePropertySet.cpp:
        (WebCore::StylePropertySet::immutableCopyIfNeeded):

            Added. Simply returns 'this' if the object is already immutable, otherwise creates a new one.

1309 1310 1311 1312 1313 1314 1315 1316 1317
2012-09-01  Dirk Schulze  <krit@webkit.org>

        [Qt] Fix the --minimal build after r127327
        https://bugs.webkit.org/show_bug.cgi?id=95639

        Unreviewed attempt to fix Qt minimal build.

        * css/StyleBuilder.cpp:

1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339
2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>

        [Gtk] No accessible caret-moved events found in certain content
        https://bugs.webkit.org/show_bug.cgi?id=72811

        Part of the bug was due to expected accessible objects of DivRole
        and ParagraphRole being ignored, in favor of including child blocks.

        Reviewed by Chris Fleizach.

        Test: platform/gtk/accessibility/spans-paragraphs-and-divs.html

        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::firstAnonymousBlockChild):
        (WebCore):
        * accessibility/AccessibilityObject.h:
        (AccessibilityObject):
        New method to return the first child which is an anonymous block.
        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
        Include paragraphs and divs which contain a non-nested anonymous block.

1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358
2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>

        [Gtk] No accessible caret-moved events found in certain content
        https://bugs.webkit.org/show_bug.cgi?id=72811

        Part of the bug was due to extraneous accessible objects resulting
        from unignored inline and block spans.

        Reviewed by Chris Fleizach.

        Test: platform/gtk/accessibility/spans.html

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Ignore objects that have spanTag tag name.
        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Ignore most anonymous blocks.
        * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
        (roleIsTextType): Add ListItem to the roles which should implement AtkText.

1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378
2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>

        [Gtk] Incorrect/unexpected characters in the text of certain accessibles
        https://bugs.webkit.org/show_bug.cgi?id=95180

        Reviewed by Chris Fleizach.

        The bug was caused by failing to properly handle anonymous block text
        which had object replacement characters (multibyte) in it. Calculating
        the string length based on the UTF-8 string meant that we were returning
        more characters than were there and in danger of splitting a multibyte
        character.

        Tests: platform/gtk/accessibility/entry-and-password.html
               platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html

        * accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
        (webkitAccessibleTextGetText): Convert the text returned by textForObject()
        to Unicode before calculating its length.

1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446
2012-09-01  Adam Barth  <abarth@webkit.org>

        Remove all-but-one use of WTF::String::operator+= from WebCore
        https://bugs.webkit.org/show_bug.cgi?id=95508

        Reviewed by Benjamin Poulain.

        This patch removes all the uses of WTF::String::operator+= from
        WebCore, except those in WorkerScriptLoader (which need a more delicate
        patch). There were actually a handful of legitimate use cases for += in
        this group. I've replaced them with calls to String::append rather than
        += so that we can remove += and encourage most contributors to use
        more efficient string idioms.

        (There are likely some more uses in WebCore hiding in port-specific
        code---this patch covers only those call sites found when compiling the
        chromium-mac port.)

        * inspector/InspectorStyleTextEditor.cpp:
        (WebCore::InspectorStyleTextEditor::insertProperty):
            - This complicated function looks really inefficient, but I didn't
              have the heart to rewrite it.
        * inspector/NetworkResourcesData.cpp:
        (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
        * loader/cache/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::sheetText):
        (WebCore::CachedCSSStyleSheet::data):
        * loader/cache/CachedFont.cpp:
        (WebCore::CachedFont::ensureSVGFontData):
        * loader/cache/CachedScript.cpp:
        (WebCore::CachedScript::script):
        * loader/cache/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::data):
            - This decoder/flush pattern can probably be improved by combining
              the decode and flush operations, but I didn't do that in this
              patch.
        * page/FrameTree.cpp:
        (WebCore::FrameTree::uniqueChildName):
            - I found this code very amusing. It's worried enough about
              efficiency to give a big speech about why snprintf is safe, but
              then it implicitly performs a large number of mallocs and memcpy
              operations.
        * page/Page.cpp:
        (WebCore::Page::userStyleSheet):
        * platform/chromium/support/WebHTTPLoadInfo.cpp:
        (WebKit::addHeader):
        * platform/chromium/support/WebURLResponse.cpp:
        (WebKit::WebURLResponse::addHTTPHeaderField):
            - This header-appending idiom looks like a reasonable use case for
              String::append.
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::setRequestHeaderInternal):
        * xml/XPathFunctions.cpp:
        (WebCore::XPath::FunTranslate::evaluate):
            - Fixes 6 year old FIXME.
        * xml/parser/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::append):
        * xml/parser/XMLDocumentParser.h:
        (XMLDocumentParser):
        * xml/parser/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::doEnd):
        * xml/parser/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::doEnd):
            - Changed m_originalSourceForTransform to a SegmentedString so that
              we don't need to malloc and copy the entire document every time
              we get more data from the network.

1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499
2012-09-01  Tommy Widenflycht  <tommyw@google.com>

        MediaStream API: Add MediaStream management to RTCPeerConnection
        https://bugs.webkit.org/show_bug.cgi?id=95543

        Reviewed by Adam Barth.

        This includes addStream/removeStream to RTCPeerConnection,
        as well as didAddRemoteStream/didRemoveRemoteStream to RTCPeerConnectionHandlerClient.

        Test: fast/mediastream/RTCPeerConnection-AddRemoveStream.html

        * Modules/mediastream/RTCPeerConnection.cpp:
        (WebCore::RTCPeerConnection::parseConfiguration):
        (WebCore::RTCPeerConnection::RTCPeerConnection):
        (WebCore::RTCPeerConnection::addStream):
        (WebCore):
        (WebCore::RTCPeerConnection::removeStream):
        (WebCore::RTCPeerConnection::localStreams):
        (WebCore::RTCPeerConnection::remoteStreams):
        (WebCore::RTCPeerConnection::didAddRemoteStream):
        (WebCore::RTCPeerConnection::didRemoveRemoteStream):
        * Modules/mediastream/RTCPeerConnection.h:
        (RTCPeerConnection):
        * Modules/mediastream/RTCPeerConnection.idl:
        * bindings/js/Dictionary.cpp:
        (WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
        (WebCore::Dictionary::getOwnPropertyNames):
        * bindings/v8/Dictionary.cpp:
        (WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
        (WebCore::Dictionary::getOwnPropertyNames):
        * bindings/v8/Dictionary.h:
        (Dictionary):
        * platform/mediastream/RTCPeerConnectionHandler.cpp:
        (RTCPeerConnectionHandlerDummy):
        (WebCore::RTCPeerConnectionHandlerDummy::addStream):
        (WebCore):
        (WebCore::RTCPeerConnectionHandlerDummy::removeStream):
        * platform/mediastream/RTCPeerConnectionHandler.h:
        (RTCPeerConnectionHandler):
        * platform/mediastream/RTCPeerConnectionHandlerClient.h:
        (WebCore):
        (RTCPeerConnectionHandlerClient):
        * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
        (WebCore::RTCPeerConnectionHandlerChromium::addStream):
        (WebCore):
        (WebCore::RTCPeerConnectionHandlerChromium::removeStream):
        (WebCore::RTCPeerConnectionHandlerChromium::didAddRemoteStream):
        (WebCore::RTCPeerConnectionHandlerChromium::didRemoveRemoteStream):
        * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
        (WebKit):
        (RTCPeerConnectionHandlerChromium):

1500 1501 1502 1503 1504 1505 1506
2012-09-01  Kent Tamura  <tkent@chromium.org>

        Touch a file so that Chromium-win bots correctly re-build for OPENTYPE_VERTICAL
        https://bugs.webkit.org/show_bug.cgi?id=51450

        * platform/graphics/opentype/OpenTypeVerticalData.cpp:

1507 1508 1509 1510 1511 1512 1513 1514 1515 1516
2012-08-31  Kent Tamura  <tkent@chromium.org>

        Touch some files so that Chromium-win bots correctly re-build
        files for OPENTYPE_VERTICAL.
        https://bugs.webkit.org/show_bug.cgi?id=51450

        * platform/graphics/FontCache.h:
        * platform/graphics/SimpleFontData.h:
        * platform/graphics/opentype/OpenTypeTypes.h:

1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535
2012-08-31  Chris Hutten-Czapski  <chutten@rim.com>

        -webkit-flex: 0 in inspector.css is confusing
        https://bugs.webkit.org/show_bug.cgi?id=95568

        Reviewed by Tony Chang.

        The initial value of -webkit-flex results in the same layout as
        -webkit-flex: 0; but does not depend on the new initial value of auto
        for min-width.

        This increases the support for the new Web Inspector style to renderers
        built before rev 122264 but after 117385.

        No new tests (has no effect except to out-of-date renderers)

        * inspector/front-end/inspector.css:
        (.status-bar-item):

1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547
2012-08-31  Filip Pizlo  <fpizlo@apple.com>

        JSArray::putDirectIndex should by default behave like JSObject::putDirect
        https://bugs.webkit.org/show_bug.cgi?id=95630

        Reviewed by Gavin Barraclough.

        No new tests because no change in behavior.

        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::CloneDeserializer::putProperty):

1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565
2012-08-31  Nate Chapin  <japhet@chromium.org>

        fast/loader/document-destruction-within-unload.html causes assertion failures on mac and qt.
        https://bugs.webkit.org/show_bug.cgi?id=66783

        Reviewed by Darin Adler.

        This was a not-quite-regression from trac.webkit.org/changeset/93521, in that we hit asserts
        in a case where we previously were use-after-freeing. Tweak how we handle cases where a Document
        is cleared from within an unload handler.

        No new tests, fixing fast/loader/document-destruction-within-unload.html on mac and qt.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::setDocumentLoader): Instead of trying to reattach a partially removed
            DocumentLoader if it is detached before being fully added, leave the old one in place, completed.
        (WebCore::FrameLoader::transitionToCommitted):

1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596
2012-08-31  Tony Chang  <tony@chromium.org>

        Make computeBlockDirectionMargins const
        https://bugs.webkit.org/show_bug.cgi?id=95595

        Reviewed by Ojan Vafai.

        This is a step in making computeLogicalHeight const.
        Refactor RenderBox::computeBlockDirectionMargins and make it const.
        Add a helper method computeAndSetBlockDirectionMargins for the callers outside of
        computeLogicalHeight that are calling this.

        No new tests, this is already covered by tests in fast/writing-mode and fast/multicol.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::marginBeforeEstimateForChild): Switch to computeAndSetBlockDirectionMargins
        (WebCore::RenderBlock::layoutBlockChild): Switch to computeAndSetBlockDirectionMargins
        (WebCore::RenderBlock::insertFloatingObject): Switch to computeAndSetBlockDirectionMargins
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::computeLogicalHeight): Use const version and fill in a MarginValues struct (to be merged in the next patch).
        (WebCore::RenderBox::computeBlockDirectionMargins): Pass in out params.
        (WebCore):
        (WebCore::RenderBox::computeAndSetBlockDirectionMargins): Does the same as the old computeBlockDirectionMargins.
        * rendering/RenderBox.h:
        (RenderBox):
        * rendering/RenderDeprecatedFlexibleBox.cpp:
        (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox): Switch to computeAndSetBlockDirectionMargins
        (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): Switch to computeAndSetBlockDirectionMargins
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::layout): Switch to computeAndSetBlockDirectionMargins

1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639
2012-08-30  Dirk Schulze  <krit@webkit.org>

        Introduce new CSS property for clip-path
        https://bugs.webkit.org/show_bug.cgi?id=95474

        Reviewed by Tim Horton.

        This path introduces the new, prefixed CSS property 'clip-path' from the
        CSS Masking specification. In a first step the property just accepts
        'none' and the the basic shapes from CSS Exclusion. Later it will also be
        possible to reference SVG 'clipPath' elements - like Firefox already does.
        To enable the parsing of the shapes, the exclusion compiler flags
        around the shape parser were removed.

        http://dvcs.w3.org/hg/FXTF/raw-file/tip/masking/index.html

        Test: fast/masking/parsing-clip-path-shape.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return CSSValue for CSSPropertyWebkitClipPath.
        * css/CSSParser.cpp: 
        (WebCore::CSSParser::parseValue): Add CSSPropertyWebkitClipPath.
        (WebCore::CSSParser::parseBasicShape): Modify parser function to accept CSSPropertyWebkitClipPath as well.
        * css/CSSParser.h:
        * css/CSSProperty.cpp:
        (WebCore::CSSProperty::isInheritedProperty):
        * css/CSSPropertyNames.in: Added property name -webkit-clip-path.
        * css/StyleBuilder.cpp:
        (ApplyPropertyClipPath): New property applier just for -webkit-clip-path.
        (WebCore::ApplyPropertyClipPath::setValue):
        (WebCore::ApplyPropertyClipPath::applyValue):
        (WebCore::ApplyPropertyClipPath::createHandler):
        (WebCore::StyleBuilder::StyleBuilder):
        * rendering/style/RenderStyle.cpp: Repaint if there is a difference between two BasicShapes.
        (WebCore::RenderStyle::diff):
        * rendering/style/RenderStyle.h:
        * rendering/style/StyleRareNonInheritedData.cpp: 
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        (WebCore::StyleRareNonInheritedData::operator==):
        (WebCore::StyleRareNonInheritedData::reportMemoryUsage):
        * rendering/style/StyleRareNonInheritedData.h: Add new member variable for clip shape.
        (StyleRareNonInheritedData):

1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655
2012-08-31  Joshua Netterfield  <jnetterfield@rim.com>

        [BlackBerry] Eliminate WebGL IT policy
        https://bugs.webkit.org/show_bug.cgi?id=95604
        Internal RIM PR #198764

        Reviewed by Rob Buis.

        This is no longer a requirement for the BlackBerry port.

        No new tests, because this introduces no new functionality.

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore):
        (WebCore::WebGLRenderingContext::create):

1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669
2012-08-31  Jon Lee  <jonlee@apple.com>

        ondisplay event handlers are not called
        https://bugs.webkit.org/show_bug.cgi?id=95263
        <rdar://problem/12193359>

        Reviewed by Alexey Proskuryakov.

        To support the legacy API, we conflate ondisplay and onshow.

        * Modules/notifications/Notification.h:
        (WebCore::Notification::ondisplay): Use display event as an alias for the show event.
        (WebCore::Notification::setOndisplay):

1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715
2012-08-31  Tony Chang  <tony@chromium.org>

        Remove ENABLE_CSS3_FLEXBOX compile time flag
        https://bugs.webkit.org/show_bug.cgi?id=95382

        Reviewed by Ojan Vafai.

        Everyone is already enabling this by default and the spec has stablized.

        No new tests, shouldn't change anything.

        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * GNUmakefile.features.am:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::isValidKeywordPropertyAndValue): Expand check range to include flex and inline-flex.
        (WebCore::isKeywordPropertyID):
        (WebCore::CSSParser::parseValue):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        * css/CSSProperty.cpp:
        (WebCore::CSSProperty::isInheritedProperty):
        * css/CSSPropertyNames.in:
        * css/CSSValueKeywords.in:
        * css/StyleBuilder.cpp:
        (WebCore::StyleBuilder::StyleBuilder):
        * css/StylePropertySet.cpp:
        (WebCore::StylePropertySet::getPropertyValue):
        (WebCore::StylePropertySet::asText):
        * css/StylePropertyShorthand.cpp:
        (WebCore::webkitFlexShorthand):
        (WebCore::shorthandForProperty):
        * css/StylePropertyShorthand.h:
        (WebCore):
        * css/StyleResolver.cpp:
        (WebCore::StyleResolver::collectMatchingRulesForList):
        * page/animation/CSSPropertyAnimation.cpp:
        (WebCore::CSSPropertyAnimation::ensurePropertyMap):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createObject):
        * rendering/style/RenderStyle.h:
        * rendering/style/RenderStyleConstants.h:

1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759
2012-08-31  Christopher Cameron  <ccameron@chromium.org>

        [chromium] Add main versus impl thread asserts
        https://bugs.webkit.org/show_bug.cgi?id=95596

        Reviewed by James Robinson.

        Add asserts to prioritized texture manager that specify that a
        function be called on the main or impl thread.

        Add debug signs that the main thread is blocked to the threaded
        proxy.

        Add a mechanism to simultaneously set the thread to the impl thread
        and indicate that the main thread is blocked.

        Update tests that hit asserts in the prioritized texture manager to
        set their impl thread and main thread blocked state correctly.

        * platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:
        (WebCore::CCPrioritizedTextureManager::prioritizeTextures):
        (WebCore::CCPrioritizedTextureManager::clearPriorities):
        (WebCore::CCPrioritizedTextureManager::requestLate):
        (WebCore::CCPrioritizedTextureManager::acquireBackingTextureIfNeeded):
        (WebCore::CCPrioritizedTextureManager::reduceMemory):
        (WebCore::CCPrioritizedTextureManager::registerTexture):
        (WebCore::CCPrioritizedTextureManager::unregisterTexture):
        (WebCore::CCPrioritizedTextureManager::returnBackingTexture):
        (WebCore::CCPrioritizedTextureManager::createBacking):
        (WebCore::CCPrioritizedTextureManager::assertInvariants):
        * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
        (WebCore):
        (DebugScopedSetImplThreadAndMainThreadBlocked):
        * platform/graphics/chromium/cc/CCThreadProxy.cpp:
        (WebCore::CCThreadProxy::compositeAndReadback):
        (WebCore::CCThreadProxy::finishAllRendering):
        (WebCore::CCThreadProxy::setVisible):
        (WebCore::CCThreadProxy::initializeRenderer):
        (WebCore::CCThreadProxy::recreateContext):
        (WebCore::CCThreadProxy::implSideRenderingStats):
        (WebCore::CCThreadProxy::start):
        (WebCore::CCThreadProxy::forceSerializeOnSwapBuffers):
        (WebCore::CCThreadProxy::acquireLayerTextures):

1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792
2012-08-30  James Robinson  <jamesr@chromium.org>

        [chromium] Put compositor client interfaces in separate headers, normalize naming
        https://bugs.webkit.org/show_bug.cgi?id=95522

        Reviewed by Adam Barth.

        Client interfaces should be in their own headers so code implementing these interfaces do not have to
        transitively #include all of the compositor internals.

        We call things 'clients' not 'delegates' in the compositor.

        * WebCore.gypi:
        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerPainter::ContentLayerPainter):
        (WebCore::ContentLayerPainter::create):
        (WebCore::ContentLayerPainter::paint):
        (WebCore::ContentLayerChromium::create):
        (WebCore::ContentLayerChromium::ContentLayerChromium):
        (WebCore::ContentLayerChromium::drawsContent):
        (WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
        * platform/graphics/chromium/ContentLayerChromium.h:
        (WebCore):
        (ContentLayerPainter):
        (ContentLayerChromium):
        (WebCore::ContentLayerChromium::clearClient):
        * platform/graphics/chromium/TextureLayerChromium.cpp:
        * platform/graphics/chromium/TextureLayerChromium.h:
        (WebCore):
        * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
        * platform/graphics/chromium/cc/CCLayerTreeHost.h:
        (WebCore):

1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804
2012-08-31  Benjamin Poulain  <bpoulain@apple.com>

        Fix the Debug builds after r127277

        Unreviewed.

        One assertion was not updated in r127277. The encapsulation of CSSParserString's length
        has changed and now use an accessor.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::storeVariableDeclaration):

1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829
2012-08-31  Simon Fraser  <simon.fraser@apple.com>

        (Regression: r126774): Fix crash when scrolling after removing inline sticky element
        https://bugs.webkit.org/show_bug.cgi?id=95584

        Reviewed by Dave Hyatt.

        Move fixed/sticky registration and unregistration with the FrameView from
        RenderBox and RenderInline into RenderBoxModelObject, which also
        fixes the issue that inlines didn't unregister themselves on destruction.

        Test: fast/css/sticky/remove-inline-sticky-crash.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::willBeDestroyed): Code moved to RenderBoxModelObject. No need
        to null-check style.
        (WebCore::RenderBox::styleWillChange): Code moved to RenderBoxModelObject.
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::willBeDestroyed): Remove fixed objects. Check
        isPositioned() to avoid this work for most non-positioned renderers.
        (WebCore::RenderBoxModelObject::styleWillChange): Register and unregister fixed
        and sticky objects with the FrameView.
        * rendering/RenderInline.cpp: styleWillChange() is no longer needed.
        * rendering/RenderInline.h: Ditto.

1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918
2012-08-31  Nikhil Bhargava  <nbhargava@google.com>

        Remove extraneous includes (Node.h, Document.h, Element.h, RenderObject.h)
        https://bugs.webkit.org/show_bug.cgi?id=95259

        Reviewed by Sam Weinig.

        Node.h, Document.h, Element.h, and RenderObject.h are four of the most
        expensive headers to include. This patch removes them from many of the
        places they are not needed. There is a minor compile-time performance
        boost.

        * dom/ElementShadow.h:
        * dom/Range.h:
        (WebCore):
        * dom/TreeScopeAdopter.h:
        (WebCore):
        * editing/VisiblePosition.h:
        (WebCore):
        * html/HTMLCollection.h:
        (WebCore):
        * html/parser/HTMLElementStack.h:
        * html/parser/HTMLTreeBuilder.h:
        (WebCore):
        * html/track/WebVTTParser.h:
        (WebCore):
        * inspector/InspectorCSSAgent.h:
        (WebCore):
        * inspector/InspectorInstrumentation.h:
        (WebCore):
        * inspector/InspectorOverlay.h:
        * loader/ImageLoader.h:
        * loader/TextTrackLoader.h:
        (WebCore):
        * platform/chromium/PopupListBox.cpp:
        * platform/chromium/PopupListBox.h:
        (WebCore):
        * platform/graphics/MediaPlayer.h:
        (WebCore):
        * rendering/FilterEffectRenderer.h:
        * rendering/InlineFlowBox.cpp:
        * rendering/RenderCounter.cpp:
        * rendering/RenderGeometryMap.h:
        (WebCore):
        * rendering/RenderInputSpeech.h:
        (WebCore):
        * rendering/RenderMediaControls.h:
        (WebCore):
        * rendering/RenderMediaControlsChromium.h:
        (WebCore):
        * rendering/RenderQuote.cpp:
        * rendering/RenderQuote.h:
        (WebCore):
        * rendering/RenderScrollbar.h:
        (WebCore):
        * rendering/RenderText.h:
        (WebCore):
        * rendering/RenderTheme.h:
        (WebCore):
        * rendering/RenderThemeChromiumSkia.h:
        (WebCore):
        * rendering/svg/RenderSVGResourceMarker.h:
        (WebCore):
        * svg/graphics/filters/SVGFilterBuilder.h:
        (WebCore):
        * xml/NativeXPathNSResolver.h:
        (WebCore):
        (NativeXPathNSResolver):
        (WebCore::NativeXPathNSResolver::create):
        * xml/XPathStep.h:
        (WebCore):
        (XPath):
        (Step):
        (NodeTest):
        (WebCore::XPath::Step::NodeTest::NodeTest):
        (WebCore::XPath::Step::NodeTest::kind):
        (WebCore::XPath::Step::NodeTest::data):
        (WebCore::XPath::Step::NodeTest::namespaceURI):
        (WebCore::XPath::Step::NodeTest::mergedPredicates):
        (WebCore::XPath::Step::axis):
        (WebCore::XPath::Step::nodeTest):
        * xml/parser/NewXMLDocumentParser.cpp:
        * xml/parser/NewXMLDocumentParser.h:
        (WebCore):
        * xml/parser/XMLToken.h:
        * xml/parser/XMLTreeBuilder.cpp:
        * xml/parser/XMLTreeBuilder.h:
        (WebCore):

1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935
2012-08-31  David Hyatt  <hyatt@apple.com>

        [New Multicolumn] Implement column repainting.
        https://bugs.webkit.org/show_bug.cgi?id=95593

        Reviewed by Dan Bernstein.
        
        Make the new columns repaint properly. Note this code is a significant improvement over the
        old multicolumn code in that repaints are properly issued per-column, i.e., no more fuzzy
        uniting of rects.

        * rendering/RenderMultiColumnSet.cpp:
        (WebCore::RenderMultiColumnSet::columnIndexAtOffset):
        (WebCore):
        (WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
        * rendering/RenderMultiColumnSet.h:

1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952
2012-08-31  Alok Priyadarshi  <alokp@chromium.org>

        [chromium] Layout tests svg-filters.html and alpha.html are crashing intermittently
        https://bugs.webkit.org/show_bug.cgi?id=92660

        Reviewed by James Robinson.

        We use two GL contexts to create and upload tile textures.
        One context creates the texture, while another uploads it.
        Even though the texture is shared by the two contexts, it is not
        available to the uploading context immediately after creation,
        unless the creating context is flushed. 

        * platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
        (WebCore::createAcceleratedCanvas):
        (WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993
2012-08-31  David Hyatt  <hyatt@apple.com>

        [New Multicolumn] Refactor flow thread repainting.
        https://bugs.webkit.org/show_bug.cgi?id=95586

        Reviewed by Simon Fraser.

        Refactor flow thread repainting in regions to delegate the work to the region. This allows subclasses
        to customize how the repainting happens so that individual repaints can be issued for columns and pages
        inside sets.
        
        repaintFlowThreadContent is the new virtual function that can be subclassed by sets to customize
        the repaint process.
        
        repaintFlowThreadContentRectangle is a parameterized helper that will be called for each individual
        column and page in a set.

        * WebCore.exp.in:
        Change repaintRectangle's signature to be const.

        * rendering/RenderFlowThread.cpp:
        (WebCore::RenderFlowThread::repaintRectangleInRegions):
        Now delegates the work for each region to RenderRegion::repaintFlowThreadContent.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintUsingContainer):
        (WebCore::RenderObject::repaint):
        (WebCore::RenderObject::repaintRectangle):
        (WebCore::RenderObject::isRooted):
        * rendering/RenderObject.h:
        Change a bunch of functions to be const.

        * rendering/RenderRegion.cpp:
        (WebCore::RenderRegion::repaintFlowThreadContent):
        (WebCore):
        (WebCore::RenderRegion::repaintFlowThreadContentRectangle):
        * rendering/RenderRegion.h:
        (RenderRegion):
        Add the two new functions (the virtual repaintFlowThreadContent and the helper it
        uses, repaintFlowThreadContentRectangle).

1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009
2012-08-31  Yong Li  <yoli@rim.com>

        [BlackBerry] Disable GCController timer for PLATFORM(BLACKBERRY)
        https://bugs.webkit.org/show_bug.cgi?id=93007

        Reviewed by Rob Buis.

        Disable GCController timer.

        * bindings/js/GCController.cpp:
        (WebCore::GCController::GCController):
        (WebCore::GCController::garbageCollectSoon):
        (WebCore):
        * bindings/js/GCController.h:
        (GCController):

2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163
2012-08-31  Michael Saboff  <msaboff@apple.com>

        CSS Parser should directly parse 8 bit source strings
        https://bugs.webkit.org/show_bug.cgi?id=95207

        Reviewed by Geoffrey Garen.

        Changed CSSParser to handle 8 bit strings directly. Templatized most private parsing methods
        and helper methods by character type. Introduced several templatized helper methods for
        parsing methods. Some of these helper methods have independent source and destination template
        types to handle that an 8 bit source string when parsed produces a 16 bit result. This is due
        to unicode escapes. Renamed the lex method "realLex" and made it a templated method. The lex
        method that is called by cssyylex(), which is now inlined, invokes the correct instance of realLex
        via a member function pointer.

        Split out the encoding part of parseEscape() into a new templated UnicodeToChars() method.

        Added 8/16 bit switching to CSSParserString as well as added initialization, setters and getters.
        Note that CSSParserString must have a default constructor as it is part of the YYLVAL union.
        Therefore created init() methods instead of constructors. Many of the parser function now directly
        modify the instance in yylval. Made supporting changes in other webcore classes that are used
        directly by CSSParser.

        Test: fast/css/unicode-escape-in-8bit-string.html

        * css/CSSGrammar.y: Removed cssyylex() and changed manipulation of CSSParserString objects to
        use newly written methods instead of direct manipulation of attributes.

        * css/CSSParser.cpp:
        Templatized new or existing helper methods
        (WebCore::makeLower):
        (WebCore::isCSSLetter):
        (WebCore::isCSSEscape):
        (WebCore::isURILetter):
        (WebCore::isIdentifierStartAfterDash):
        (WebCore::isEqualToCSSIdentifier):
        (WebCore::checkAndSkipEscape):
        (WebCore::checkForValidDouble):
        (WebCore::parseDouble):
        (WebCore::parseColorIntOrPercentage):
        (WebCore::isTenthAlpha):
        (WebCore::parseAlphaValue):
        (WebCore::mightBeRGBA):
        (WebCore::mightBeRGB):
        (WebCore::fastParseColorInternal):
        (WebCore::CSSParser::fastParseColor):
        (WebCore::CSSParser::parseImageSet):
        (WebCore::skipWhiteSpace):
        (WebCore::CSSParser::currentCharacter16):
        (WebCore::CSSParser::isIdentifierStart):
        (WebCore::CSSParser::checkAndSkipString):
        (WebCore::CSSParser::parseUnicodeRange):
        (WebCore::CSSParser::parseNthChild):
        (WebCore::CSSParser::parseNthChildExtra):
        (WebCore::CSSParser::detectFunctionTypeToken):
        (WebCore::CSSParser::detectMediaQueryToken):
        (WebCore::CSSParser::detectNumberToken):
        (WebCore::CSSParser::detectDashToken):
        (WebCore::CSSParser::detectAtToken):
        (WebCore::CSSParser::setRuleHeaderEnd):
        (WebCore::cssPropertyID):
        (WebCore::isCSSTokenizerIdentifier):
        (WebCore::isCSSTokenizerURL):

        (WebCore::CSSParser::CSSParser): Updated constructor for initializing new attributes.

        (WebCore::CSSParserString::lower): Calls new makeLower() template helper.

        (WebCore::CSSParser::setupParser): Added 8 bit path and set up parser appropriate to
        string type.

        (WebCore::equal): Updated to use CSSParserString getters and StringImpl::equal
        (WebCore::equalIgnoringCase): Updated to use CSSParserString getters and
        StringImpl::equalIgnoringCase
        (WebCore::parseColorValue): Updated to use new CSSParserString::init()
        (WebCore::parseSimpleLength):
        (WebCore::parseKeywordValue): Updated to use new CSSParserString::init()
        (WebCore::parseTransformArguments):
        (WebCore::CSSParser::parseSystemColor): Updated to use new CSSParserString::init()
        (WebCore::CSSParser::storeVariableDeclaration): Create right character sized AtomicString.
        (WebCore::FontFamilyValueBuilder::add):
        (WebCore::TransformOperationInfo::TransformOperationInfo):
        (WebCore::CSSParser::parseFontFeatureTag):

        (WebCore::CSSParser::parseEscape): Now only parses an escape and returns the resulting
        Unicode value as an unsigned.
        (WebCore::CSSParser::UnicodeToChars): New method to write out unicode character(s)
        based on character type.
        (WebCore::CSSParser::parseIdentifierInternal): Templated helper.
        (WebCore::CSSParser::parseIdentifier): Parses identifiers, possibly upconverting
        the result when a unicode escape is found in an 8 bit source.
        (WebCore::CSSParser::parseStringInternal): Templated helper.
        (WebCore::CSSParser::parseString): Parses strings, possibly upconverting
        the result when a unicode escape is found in an 8 bit source.
        (WebCore::CSSParser::parseURIInternal): Templated helper.
        (WebCore::CSSParser::parseURI): Templated and split logic out to parseURIInternal.
        Reparses a parsed identifier to see if it is a URI.  This method doesn't need to up
        convert from 8 to 16 bits since that would have been done in parseIdentfier().
        (WebCore::CSSParser::realLex): Lot of template related changes.  Removed yylval->string
        ASSERT checks at the end, since they are too naive to handle upconverted identifier,
        string and URIs.  They compared source pointers (m_tokenStart) with resulting strings.
        (WebCore::fixUnparsedProperties):
        (WebCore::CSSParser::fixUnparsedPropertyRanges): Added new template helper with same name.
        (WebCore::CSSParser::markRuleHeaderStart):
        (WebCore::CSSParser::markRuleHeaderEnd):
        (WebCore::CSSParser::markRuleBodyStart):
        (WebCore::CSSParser::markRuleBodyEnd):
        (WebCore::CSSParser::markPropertyStart):
        (WebCore::CSSParser::markPropertyEnd):
        (WebCore::cssValueKeywordID):

        * css/CSSParser.h:
        (CSSParser):
        (WebCore::CSSParser::lex): Made this inline helper that calls correct realLex().
        (WebCore::CSSParser::is8BitSource):
        (WebCore::CSSParser::tokenStartOffset): Templated method returning offset in source
        of the current token start.
        (WebCore::CSSParser::tokenStartChar): Templated access to m_tokenStart.
        (WebCore::cssyylex): Made this inline to avoid call.
        * css/CSSParserValues.h:
        (WebCore::CSSParserString::init): Added three new initialization methods.

        New setters, getters and helper methods.
        (WebCore::CSSParserString::clear):
        (WebCore::CSSParserString::is8Bit):
        (WebCore::CSSParserString::characters8):
        (WebCore::CSSParserString::characters16):
        (WebCore::CSSParserString::length):
        (WebCore::CSSParserString::setLength):
        (WebCore::CSSParserString::operator[]):
        (WebCore::CSSParserString::equalIgnoringCase):
        (WebCore::CSSParserString::operator String):
        (WebCore::CSSParserString::operator AtomicString):

        Other methods templatized to support changes in CSSParser.
        * platform/graphics/Color.cpp:
        (WebCore::parseHexColorInternal):
        (WebCore::Color::parseHexColor): New LChar flavor
        (WebCore::Color::Color):
        * platform/graphics/Color.h:
        (Color):
        * platform/text/TextEncoding.cpp:
        (WebCore::TextEncoding::TextEncoding):
        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::atomicCanonicalTextEncodingName):
        * platform/text/TextEncodingRegistry.h:
        * svg/SVGParserUtilities.cpp:
        (WebCore::genericParseNumber):
        (WebCore::parseSVGNumber):
        * svg/SVGParserUtilities.h:
        (WebCore::isSVGSpace):
        (WebCore::skipOptionalSVGSpaces):
        (WebCore::skipOptionalSVGSpacesOrDelimiter):

2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177
2012-08-31  David Hyatt  <hyatt@apple.com>

        [New Multicolumn] Make RenderFlowThreads into selection roots.
        https://bugs.webkit.org/show_bug.cgi?id=95580

        Reviewed by Dan Bernstein.

        Make RenderFlowThreads selection roots so that they paint their own selection gaps.
        This fixes multicolumn selection rendering so that the gaps paint correctly and stop
        at the edge of the flow thread instead of going out to the edges of enclosing blocks.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::isSelectionRoot):

2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205
2012-08-31  Andrei Bucur  <abucur@adobe.com>

        [CSS Regions] It should be possible to specify ::BEFORE/AFTER as regions
        https://bugs.webkit.org/show_bug.cgi?id=90079

        Reviewed by David Hyatt.

        The calls for RenderRegion::node() have been replaced with RenderRegion::generatingNode() to allow pseudo-elements to have RenderRegion renderers.
        The compare function that establishes the region order was adapted to take into account pseudo-regions.
        A renderer for the pseudo-element is now generated if it's a region even though there's no content property specified.

        Test: fast/regions/content-flowed-into-pseudo-regions.html

        * rendering/RenderFlowThread.cpp:
        (WebCore::RenderFlowThread::computeOverflowStateForRegions):
        * rendering/RenderNamedFlowThread.cpp:
        (WebCore::compareRenderRegions):
        * rendering/RenderObjectChildList.cpp:
        (WebCore::ensureBeforeAfterContainer):
        (WebCore):
        (WebCore::RenderObjectChildList::updateBeforeAfterContent):
        * rendering/RenderRegion.cpp:
        (WebCore::RenderRegion::nodeAtPoint):
        (WebCore::RenderRegion::checkRegionStyle):
        (WebCore::RenderRegion::computeStyleInRegion):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeRenderNamedFlowThreads):

2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299
2012-08-30  David Hyatt  <hyatt@apple.com>

        [New Multicolumn] Implement unforced breaking in the new column layout.
        https://bugs.webkit.org/show_bug.cgi?id=95498

        Reviewed by Dan Bernstein.

        This patch implements unforced breaking for lines and objects inside columns. Forced breaks are
        not yet handled properly and will be covered in a separate patch.

        * rendering/LayoutState.cpp:
        (WebCore::LayoutState::LayoutState):
        Eliminate the flow thread constructor for LayoutState. Flow threads were doing a double push of
        layout states, once in RenderFlowThread::layout() and then again in RenderBlock::layout(). This
        double push was unnecessary, so I refactored the code to ensure the RenderBlock push does the
        right thing for RenderFlowThreads.

        (WebCore):
        * rendering/LayoutState.h:
        (LayoutState):
        Eliminate the flow thread constructor for LayoutState.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::checkForPaginationLogicalHeightChange):
        This function now handles RenderFlowThreads and properly sets a non-zero page height as well
        as querying the flow thread to ask if the pagination logical height has changed. The flow thread
        has a new member that it sets in layout() so that it can answer this question.

        (WebCore::RenderBlock::hasNextPage):
        Make sure RenderRegionSets always claim to have a next page when they are the last region, since
        we know columns/pages can always generate additional boxes as needed.

        * rendering/RenderFlowThread.cpp:
        (WebCore::RenderFlowThread::RenderFlowThread):
        Add the m_pageLogicalHeightChanged member variable for tracking whether regions changed dimensions,
        thus forcing us to repaginate everything.

        (WebCore::RenderFlowThread::layout):
        Remove the redundant push of layout state now that RenderBlock's covers it.

        (WebCore::RenderFlowThread::regionAtBlockOffset):
        Always return the last region if it's a set, regardless of the extendLastRegion boolean.
        This reflects the fact that the last region set can always generate new page/column boxes.

        (WebCore::RenderFlowThread::pageLogicalTopForOffset):
        Refactored to call into the region it finds for a given offset, so that the region itself
        can answer the question of where the top of the page is. This enables sets to return the top of
        specific columns/pages within the set.

        (WebCore::RenderFlowThread::pageRemainingLogicalHeightForOffset):
        Changed to be written in terms of pageLogicalTop and pageLogicalHeight so that it correctly uses
        only the current column/page when determining remaining height.

        * rendering/RenderFlowThread.h:
        Added pageLogicalHeightChanged() so that RenderBlock can ask the flow thread if its regions changed
        dimensions.

        * rendering/RenderMultiColumnBlock.cpp:
        (WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
        Tweaked to no longer turn on pagination, since the RenderMultiColumnFlowThread does that and we
        want to avoid a double push of paginated states. Instead it now just sets the column height ahead
        of time so that the RenderMultiColumnSets know how big their columns are.

        * rendering/RenderMultiColumnSet.cpp:
        (WebCore::RenderMultiColumnSet::pageLogicalTopForOffset):
        Subclassed to return the top of a specific column.

        (WebCore):
        * rendering/RenderMultiColumnSet.h:
        Add the subclassed method for pageLogicalTopForOffset.
        
        * rendering/RenderRegion.cpp:
        (WebCore::RenderRegion::pageLogicalTopForOffset):
        The code from RenderFlow::pageLogicalTopForOffset moved here. Just returns the top of the flow
        thread portion rect in the region (same as before).

        (WebCore::RenderRegion::layout):
        Changed to check only the page logical width and height, since we only consider a region as
        invalidating how you break if there is an actual page height change.

        * rendering/RenderRegion.h:
        (WebCore::RenderRegion::isRenderRegionSet):
        Added an isRenderRegionSet() virtual function so that we can test for sets.

        * rendering/RenderRegionSet.h:
        (WebCore::RenderRegionSet::isRenderRegionSet):
        Subclassed isRenderRegionSet() to return true.

        * rendering/RenderView.cpp:
        * rendering/RenderView.h:
        (LayoutStateMaintainer):
        (WebCore::LayoutStateMaintainer::push):
        Remove the pushes of LayoutState that were specific to RenderFlowThreads.

2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312
2012-08-31  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: Update $ to alias to querySelector rather than getElementById
        https://bugs.webkit.org/show_bug.cgi?id=92648

        Reviewed by Yury Semikhatsky.

        Completed implementation started by Addy Osmani. Updates $ to alias to querySelector
        with more flexible handling of selectors. Also adds a warning about the change (as per Firebug).

        * inspector/InjectedScriptSource.js:
        (.):

2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324
2012-08-31  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: disable popover on click outside of popover anchor
        https://bugs.webkit.org/show_bug.cgi?id=95564

        Reviewed by Yury Semikhatsky.

        Immediately hide popover when receiving a click outside of popover anchor.

        * inspector/front-end/Popover.js:
        (WebInspector.PopoverHelper.prototype._mouseDown):

2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356
2012-08-31  Christophe Dumez  <christophe.dumez@intel.com>

        [EFL] Add proper support for navigator.onLine and associated events
        https://bugs.webkit.org/show_bug.cgi?id=95532

        Reviewed by Kenneth Rohde Christiansen.

        Add support for detecting online state in EFL port and
        monitor state changes. The EFL port now has proper
        support for navigator.onLine and associated events.

        The implementation is based on Eeze library for
        detecting network interfaces and their configuration.
        Detection of online state changes relies on rtnetlink.

        No new tests, no behavior change for layout tests.

        * PlatformEfl.cmake: Link unconditionally against Eeze
        library now.
        * platform/network/NetworkStateNotifier.cpp:
        (WebCore):
        * platform/network/NetworkStateNotifier.h:
        (NetworkStateNotifier):
        (WebCore):
        * platform/network/efl/NetworkStateNotifierEfl.cpp: Added.
        (WebCore):
        (WebCore::NetworkStateNotifier::updateState):
        (WebCore::NetworkStateNotifier::networkInterfaceChanged):
        (WebCore::readSocketCallback):
        (WebCore::NetworkStateNotifier::~NetworkStateNotifier):
        (WebCore::NetworkStateNotifier::NetworkStateNotifier):

2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367
2012-08-31  Milian Wolff  <milian.wolff@kdab.com>

        [Qt] QNX build fails due to missing OpenGL ES defines
        https://bugs.webkit.org/show_bug.cgi?id=95554

        Reviewed by Simon Hausmann.

        Apply the fix of bug 91030 to all platforms running on QNX.

        * platform/graphics/opengl/Extensions3DOpenGLES.h:

2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380
2012-08-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>

        [CMake] Changes on the bindings generator does not trigger generation of the bindings
        https://bugs.webkit.org/show_bug.cgi?id=95552

        Reviewed by Kenneth Rohde Christiansen.

        Added the engine especific part of the generator to the dependency
        list.

        * UseJSC.cmake:
        * UseV8.cmake:

2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401
2012-08-31  Andrey Adaikin  <aandrey@chromium.org>

        Web Inspector: [WebGL] Link WebGL calls to the source code where it was made
        https://bugs.webkit.org/show_bug.cgi?id=95426

        Reviewed by Vsevolod Vlasov.

        Save a stack trace for every call we capture and report to the frontend sourceURL,lineNumber,columnNumber were the call was made from.
        Right now, this will work only with V8.

        * inspector/InjectedScriptExterns.js:
        (CallSite.prototype.getFileName):
        (CallSite.prototype.getLineNumber):
        (CallSite.prototype.getColumnNumber):
        * inspector/InjectedScriptWebGLModuleSource.js:
        (.):
        * inspector/Inspector.json:
        * inspector/front-end/WebGLProfileView.js:
        (WebInspector.WebGLProfileView):
        (WebInspector.WebGLProfileView.prototype._showTraceLog):

2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427
2012-08-31  Patrick Dubroy  <dubroy@chromium.org>

        Web Inspector: Add high-DPI images for status bar glyphs
        https://bugs.webkit.org/show_bug.cgi?id=95471

        Reviewed by Pavel Feldman.

        Add the new 2x resolution image for the status bar glyphs, and add
        media queries to use the images on high-DPI devices.

        * inspector/front-end/Images/statusbarButtonGlyphs2x.png: Added.
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        (.long-click-glyph):
        (@media (-webkit-min-device-pixel-ratio: 1.5)):
        (.status-bar-item > .glyph):
        * inspector/front-end/scriptsPanel.css:
        (.toggle-breakpoints .glyph):
        (@media (-webkit-min-device-pixel-ratio: 1.5)):
        (.status-bar-item.scripts-navigator-show-hide-button > .glyph):
        (.status-bar-item.scripts-debugger-show-hide-button > .glyph):
        * WebCore.gypi
        * inspector/front-end/timelinePanel.css:
        (#timeline-overview-sidebar .icon):
        (@media (-webkit-min-device-pixel-ratio: 1.5)):

2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461
2012-08-30  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: render box model elements and grid on inspector overlay
        https://bugs.webkit.org/show_bug.cgi?id=95456

        Reviewed by Vsevolod Vlasov.

        This change migrates native rendering for box model to the InspectorOverlay.

        * inspector/InspectorInstrumentation.cpp:
        (WebCore):
        (WebCore::InspectorInstrumentation::didScrollImpl):
        * inspector/InspectorInstrumentation.h:
        (InspectorInstrumentation):
        (WebCore::InspectorInstrumentation::didScroll):
        (WebCore):
        * inspector/InspectorOverlay.cpp:
        (WebCore::InspectorOverlay::drawNodeHighlight):
        (WebCore::InspectorOverlay::drawRectHighlight):
        (WebCore::InspectorOverlay::overlayPage):
        (WebCore::InspectorOverlay::evaluateInOverlay):
        * inspector/InspectorOverlay.h:
        (WebCore::Highlight::setColors):
        (Highlight):
        (InspectorOverlay):
        * inspector/InspectorOverlayPage.html:
        * inspector/InspectorPageAgent.cpp:
        (WebCore::InspectorPageAgent::didLayout):
        (WebCore):
        (WebCore::InspectorPageAgent::didScroll):
        * inspector/InspectorPageAgent.h:
        * page/Chrome.cpp:
        (WebCore::Chrome::scroll):

2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474
2012-08-31  Andrey Adaikin  <aandrey@chromium.org>

        Web Inspector: [WebGL] Make wrap functions initialization lazy
        https://bugs.webkit.org/show_bug.cgi?id=95533

        Reviewed by Vsevolod Vlasov.

        WebGL wrap functions initialization is not always needed to be executed: for example, when we will instrument a 2D canvas.
        Drive-by: fixed variable namings, moved duplicated code into a small auxiliary function.

        * inspector/InjectedScriptWebGLModuleSource.js:
        (.):

2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507
2012-08-31  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Port convertValueToQVariant to use the JSC C API
        https://bugs.webkit.org/show_bug.cgi?id=94695

        Reviewed by Kenneth Rohde Christiansen.

        Most of the code is portable to the C API, with a few exceptions for internal
        types such as byte arrays, dates or when unboxing primitive types.

        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtField::setValueToInstance):
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::operator<<):
        (JSC::Bindings::isJSUint8ClampedArray):
        (JSC::Bindings::isJSArray):
        (Bindings):
        (JSC::Bindings::isJSDate):
        (JSC::Bindings::isQtObject):
        (JSC::Bindings::valueRealType):
        (JSC::Bindings::toString):
        (JSC::Bindings::unwrapBoxedPrimitive):
        (JSC::Bindings::convertValueToQVariantMap):
        (JSC::Bindings::convertToList):
        (JSC::Bindings::toQString):
        (JSC::Bindings::getGregorianDateTimeUTC):
        (JSC::Bindings::toQDateTimeUTC):
        (JSC::Bindings::convertValueToQVariant):
        (JSC::Bindings::findMethodIndex):
        (JSC::Bindings::QtConnectionObject::execute):
        * bridge/qt/qt_runtime.h:
        (Bindings):

2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533
2012-08-31  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: render path to file and line number as subtitles in selector dialog.
        https://bugs.webkit.org/show_bug.cgi?id=95481

        Reviewed by Vsevolod Vlasov.

        In case several files have matching names, we should render the path next to it.
        Using the same subtitle field, we now also render line number for JS and Style outlines.

        * inspector/front-end/FilteredItemSelectionDialog.js:
        (WebInspector.FilteredItemSelectionDialog.prototype.get _itemsLoaded):
        (WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
        (WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
        (WebInspector.SelectionDialogContentProvider.prototype.itemSuffixAt):
        (WebInspector.JavaScriptOutlineDialog.prototype.itemSuffixAt):
        (WebInspector.JavaScriptOutlineDialog.prototype.itemSubtitleAt):
        (WebInspector.OpenResourceDialog.prototype.itemSuffixAt):
        (WebInspector.OpenResourceDialog.prototype.itemSubtitleAt):
        * inspector/front-end/StyleSheetOutlineDialog.js:
        (WebInspector.StyleSheetOutlineDialog.prototype.itemSuffixAt):
        (WebInspector.StyleSheetOutlineDialog.prototype.itemSubtitleAt):
        * inspector/front-end/filteredItemSelectionDialog.css:
        (.js-outline-dialog > .container > div.item):
        (.js-outline-dialog span.subtitle):

2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556
2012-08-31  Yoshifumi Inoue  <yosin@chromium.org>

        [Forms] Left/Right keys in multiple fields time input UI should move focus physical left/right instead of logical left/right regardless text direction.
        https://bugs.webkit.org/show_bug.cgi?id=95434

        Reviewed by Kent Tamura.

        This patch also changes handling of Left/Right keys to aware text
        direction ("dir" attribute"). Left/Right keys should move focus
        physical right/left instead of logical right/left.

        This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
        ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

        No new tests. This patch adds a test case into fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html

        * html/shadow/DateTimeFieldElement.cpp:
        (WebCore::DateTimeFieldElement::defaultKeyboardEventHandler): Changed to check isRTL() for Left/Right keys then we call
        appropriate focus motion function.
        (WebCore::DateTimeFieldElement::isRTL): Added for checking text direction is right-to-left or not.
        * html/shadow/DateTimeFieldElement.h:
        (DateTimeFieldElement): Added declaration of isRTL().