ChangeLog 373 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
2008-10-29  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        https://bugs.webkit.org/show_bug.cgi?id=21952
        
        Address an outstanding FIXME by removing unused SPI

        * History/WebHistory.mm:
        (-[WebHistory _addItemForURL:title:]): Fold addItem: into this method

        * History/WebHistoryPrivate.h: Removed unused/unneccessary SPI

justin.garcia@apple.com's avatar
justin.garcia@apple.com committed
14
15
16
17
18
19
20
21
22
2008-10-28  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin Adler.
        
        <rdar://problem/5188560> REGRESSION: Spell checker doesn't clear spelling/grammar marker after error is marked as Ignored

        * WebView/WebHTMLView.mm: IgnoreSpelling is now a WebCore command.  That command handles
        calling back into WebKit to perform the cross platform work that was removed in this change.

23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
2008-10-28  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Mark Rowe.

        Move ForwardingHeaders to their correct location after the creation of
        the runtime directory in JavaScriptCore.

        * ForwardingHeaders/kjs/JSFunction.h: Removed.
        * ForwardingHeaders/kjs/JSObject.h: Removed.
        * ForwardingHeaders/kjs/JSString.h: Removed.
        * ForwardingHeaders/kjs/JSValue.h: Removed.
        * ForwardingHeaders/runtime: Added.
        * ForwardingHeaders/runtime/JSFunction.h: Copied from ForwardingHeaders/kjs/JSFunction.h.
        * ForwardingHeaders/runtime/JSObject.h: Copied from ForwardingHeaders/kjs/JSObject.h.
        * ForwardingHeaders/runtime/JSString.h: Copied from ForwardingHeaders/kjs/JSString.h.
        * ForwardingHeaders/runtime/JSValue.h: Copied from ForwardingHeaders/kjs/JSValue.h.
        * WebView/WebScriptDebugDelegate.mm:
        * WebView/WebScriptDebugger.mm:
        * WebView/WebView.mm:

adele@apple.com's avatar
adele@apple.com committed
43
44
45
46
47
48
49
50
51
52
2008-10-28  Adele Peterson  <adele@apple.com>

        Reviewed by John Sullivan.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
        "files" string for multifile uploads needs to be localized

        * WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory multipleFileUploadTextForNumberOfFiles:]):
        Added.

53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
2008-10-28  Timothy Hatcher  <timothy@apple.com>

        Add WebInspector methods to enable the profiler.

        https://bugs.webkit.org/show_bug.cgi?id=21927

        <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
        not slow down JavaScript all the time

        Reviewed by Darin Adler and Kevin McCullough.

        * WebInspector/WebInspector.h:
        * WebInspector/WebInspector.mm:
        (-[WebInspector isJavaScriptProfilingEnabled]): Added. Calls InspectorController::profilerEnabled.
        (-[WebInspector setJavaScriptProfilingEnabled:]): Added. Call InspectorController's disableProfiler
        or enableProfiler methods.

70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
2008-10-27  Timothy Hatcher  <timothy@apple.com>

        Rename a few methods related to attaching and detaching the debugger.

        * Rename attachDebugger to enableDebugger.
        * Rename detachDebugger to disableDebugger.
        * Rename the debuggerAttached getter to debuggerEnabled.

        Reviewed by Darin Adler.

        * WebInspector/WebInspector.mm:
        (-[WebInspector isDebuggingJavaScript]):
        (-[WebInspector startDebuggingJavaScript:]):
        (-[WebInspector stopDebuggingJavaScript:]):

85
86
87
88
89
90
91
92
93
94
2008-10-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej Stachowiak.

        Use the C++ stream object for JS requests as well.
        
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
        (-[WebBaseNetscapePluginView destroyStream:reason:]):

95
96
2008-10-27  Anders Carlsson  <andersca@apple.com>

97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
        Reviewed by Dan Bernstein.
        
        Use the C++ stream object in WebBaseNetscapePluginView. Use a HashSet of RefPtrs to keep track of the streams.
        
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::~WebNetscapePluginStream):
        (WebNetscapePluginStream::setPlugin):
        (WebNetscapePluginStream::startStream):
        (WebNetscapePluginStream::destroyStream):
        (WebNetscapePluginStream::destroyStreamWithReason):
        (WebNetscapePluginStream::cancelLoadAndDestroyStreamWithError):
        (WebNetscapePluginStream::deliverData):
        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView stop]):
        (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
        (-[WebBaseNetscapePluginView disconnectStream:]):
        (-[WebBaseNetscapePluginView dealloc]):
        (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
        (-[WebBaseNetscapePluginView pluginView:receivedData:]):
        (-[WebBaseNetscapePluginView pluginView:receivedError:]):
        (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]):
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

2008-10-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.
124
125
126
127
128
129
130
131
132
        
        Move code from dealloc and finalize to the WebNetscapePluginStream destructor.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::~WebNetscapePluginStream):
        (-[WebBaseNetscapePluginStream dealloc]):
        (-[WebBaseNetscapePluginStream finalize]):

133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
2008-10-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Get rid of WebNetscapePlugInStreamLoaderClient, the plug-in stream is its own client.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::WebNetscapePluginStream):
        (-[WebBaseNetscapePluginStream dealloc]):
        (-[WebBaseNetscapePluginStream finalize]):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView pluginView:receivedError:]):
        (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]):
        (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
        (-[WebBaseNetscapePluginView destroyStream:reason:]):

150
151
152
153
154
155
156
157
158
159
160
161
162
2008-10-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Change the Obj-C init methods to simply call WebNetscapePluginStream::create.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        (WebNetscapePluginStream::create):
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream initWithFrameLoader:]):
        (WebNetscapePluginStream::WebNetscapePluginStream):
        (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):

163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
2008-10-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Convert more code over to C++.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        (WebNetscapePluginStream::plugin):
        (WebNetscapePluginStream::setRequestURL):
        Convert to C++.

        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::start):
        (WebNetscapePluginStream::stop):
        Ditto.
        
        (WebNetscapePluginStream::startStreamWithResponse):
        Ditto.
        
        (-[WebBaseNetscapePluginStream startStreamWithResponse:]):
        Call the C++ version.
        
        (-[WebBaseNetscapePluginStream impl]):
        New accessor for the C++ class.
        
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView pluginView:receivedData:]):
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
        (-[WebBaseNetscapePluginView destroyStream:reason:]):
        Call the C++ methods.

weinig@apple.com's avatar
weinig@apple.com committed
194
195
196
197
198
199
200
201
202
203
204
2008-10-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Fix https://bugs.webkit.org/show_bug.cgi?id=21759
        Layering violation: FileChooser should not depend on Document/Frame/Page

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::runOpenPanel):

205
206
207
208
209
210
2008-10-24  Anders Carlsson  <andersca@apple.com>

        Fix Tiger build.
        
        * WebView/WebUIDelegate.h:

andersca@apple.com's avatar
andersca@apple.com committed
211
212
213
214
215
216
217
218
219
220
221
2008-10-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/5440917> Support NPN_Construct
        
        Set construct.
        
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage load]):

222
223
224
225
226
227
228
229
2008-10-24  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Tim Hatcher.

        <rdar://problem/6119711> Remove the dependency on Foundation's private __COCOA_FORMAL_PROTOCOLS__ define.

        * Misc/EmptyProtocolDefinitions.h:

adele@apple.com's avatar
adele@apple.com committed
230
231
232
233
234
235
236
237
238
239
240
2008-10-24  Adele Peterson  <adele@apple.com>

        Reviewed by Sam Weinig.

        WebKit part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::runOpenPanel):
        (-[WebOpenPanelResultListener chooseFilenames:]):
        * WebView/WebUIDelegate.h:

241
242
243
244
245
246
247
248
249
250
251
2008-10-24  Timothy Hatcher  <timothy@apple.com>

        Implement new InspectorClient methods to work with Settings.

        https://bugs.webkit.org/show_bug.cgi?id=21856

        Reviewed by Darin Adler.

        * WebCoreSupport/WebInspectorClient.h: Add the new methods and
        guard the ObjC parts of the header.

darin@apple.com's avatar
darin@apple.com committed
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
2008-10-24  Darin Adler  <darin@apple.com>

        - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

        * WebView/WebFrame.mm:
        (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptCallFrame _convertValueToObjcValue:]):
        (-[WebScriptCallFrame exception]):
        (-[WebScriptCallFrame evaluateWebScript:]):
        * WebView/WebView.mm:
        (aeDescFromJSValue):
        (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
        Use JSValue* instead of JSValuePtr.

mrowe@apple.com's avatar
mrowe@apple.com committed
267
268
269
270
271
272
273
2008-10-23  Mark Rowe  <mrowe@apple.com>

        Build fix.

        * Misc/WebKitErrors.m:
        (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]):

weinig@apple.com's avatar
weinig@apple.com committed
274
275
276
277
278
279
280
281
282
2008-10-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:

ap@webkit.org's avatar
ap@webkit.org committed
283
284
285
286
287
288
289
290
291
292
2008-10-20  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Oliver Hunt.

        <rdar://problem/6277777> REGRESSION (r36954): XMLHttpRequest not working when
        certain WebView delegate actions are taken

        * WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]): Don't accidentally create
        a window shell if there is none yet.

darin@apple.com's avatar
darin@apple.com committed
293
294
295
296
297
298
299
300
301
302
303
304
305
306
2008-10-19  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
          improve performance by eliminating JSValue as a base class for JSCell

        Remove most uses of JSValue, which will be removed in a future patch.

        * WebView/WebFrame.mm:
        (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
        Use JSValuePtr instead of JSValue.
        * WebView/WebScriptDebugger.h: Removed declaration of JSValue.

darin@apple.com's avatar
darin@apple.com committed
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
2008-10-18  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
          improve performance by eliminating JSValue as a base class for JSCell

        Tweak a little more to get closer to where we can make JSValuePtr a class.

        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptCallFrame _convertValueToObjcValue:]): Use JSValuePtr.
        (-[WebScriptCallFrame exception]): Ditto.
        (-[WebScriptCallFrame evaluateWebScript:]): Ditto. And noValue.
        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::WebScriptDebugger): Use new DebuggerCallFrame
        constructor that doesn't require explicitly passing an exception.
        * WebView/WebView.mm:
        (aeDescFromJSValue): Use JSValuePtr.
        (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.

mitz@apple.com's avatar
mitz@apple.com committed
327
328
329
330
331
332
333
334
335
336
337
2008-10-18  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        - WebKit/mac part of https://bugs.webkit.org/show_bug.cgi?id=21736
          Long-dead decoded image data make up for most of the object cache's memory use over time

        * WebView/WebView.mm:
        (+[WebView _setCacheModel:]): In the primary web browser model, set the
        cache's dead decoded data deletion interval to 60 seconds.

338
339
340
341
342
343
344
345
346
347
2008-10-15  Mark Rowe  <mrowe@apple.com>

        Reviewed by Jon Honeycutt.

        Fix a leak of a CFStringRef reported by the build bot.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): Use a autoreleased
        NSString rather than manually releasing a CFStringRef when we're done with it.

348
349
350
351
352
353
354
355
356
357
358
2008-10-15  Kenneth Russell  <kenneth.russell@sun.com>

        Reviewed and landed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=21572
        
        Initialize pluginFunc.size to the correct size before calling NP_GetEntryPoints.
        
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage load]):

359
360
361
362
363
364
365
366
367
368
369
370
2008-10-15  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6272508> Crash occurs after loading flash content at http://www.macrumors.com/

        Restore some code related to the CoreGraphics drawing model that was misplaced in r37131.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView invalidateRegion:]):
        (-[WebBaseNetscapePluginView setVariable:value:]):

ggaren@apple.com's avatar
ggaren@apple.com committed
371
372
373
374
375
376
377
378
379
380
2008-10-15  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Fixed https://bugs.webkit.org/show_bug.cgi?id=21345
        Start the debugger without reloading the inspected page

        * WebInspector/WebInspector.mm:
        (-[WebInspector startDebuggingJavaScript:]): Updated for rename.

bdakin@apple.com's avatar
bdakin@apple.com committed
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
2008-10-14  Maxime Britto  <britto@apple.com>

        Reviewed by Darin Adler.

        Added SPI to use WebCore's TextIterator with WebKit.

        * WebView/WebTextIterator.h: Added.
        * WebView/WebTextIterator.mm: Added.
        (-[WebTextIteratorPrivate dealloc]):
        (-[WebTextIterator dealloc]):
        (-[WebTextIterator initWithRange:]): Creates a TextIterator 
        instance
        (-[WebTextIterator advance]): Asks the iterator to advance() .
        (-[WebTextIterator currentNode]): Returns the current DOMNode from 
        the iterator
        (-[WebTextIterator currentText]): Returns the current text from the 
        iterator
        (-[WebTextIterator atEnd]): Indicated whether the iterator has 
        reached the end of the range.
        * WebView/WebView.h:
        * WebView/WebView.mm:
        (-[WebView textIteratorForRect:]): Returns a WebTextIterator with 
        the DOMRange contained in the rectangle given as a parameter.

405
406
407
408
409
410
411
412
413
414
415
416
417
2008-10-15  Timothy Hatcher  <timothy@apple.com>

        Clean up user agent generation to simplify the _standardUserAgentWithApplicationName:
        class method to not require a WebKit version.

        Reviewed by Darin Adler.

        * WebView/WebView.mm:
        (+[WebView _standardUserAgentWithApplicationName:]): Create the WebKit version.
        (-[WebView WebCore::_userAgentForURL:]): Use the simplified _standardUserAgentWithApplicationName:.
        Remove code that created the WebKit version.
        * WebView/WebViewPrivate.h: Change the method name of _standardUserAgentWithApplicationName:.

418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
2008-10-14  Timothy Hatcher  <timothy@apple.com>

        Make the user agent generation method a class method and cache the WebKit
        version in a static to prevent generating it every time. This is needed
        clean up to fix <rdar://problem/6292331>. Moved all code to WebPrivate so
        the class method can be in the WebViewPrivate.h header.

        Reviewed by John Sullivan.

        * WebView/WebView.mm:
        (callGestalt): Moved. Same code.
        (createMacOSXVersionString): Moved. Same code.
        (createUserVisibleWebKitVersionString): Moved from _userVisibleBundleVersionFromFullVersion:
        and returns a copied string.
        (+[WebView _standardUserAgentWithApplicationName:andWebKitVersion:]): Made into a class method.
        (-[WebView WebCore::_userAgentForURL:]): Changed to cache the WebKit version.
        * WebView/WebViewPrivate.h: Added +_standardUserAgentWithApplicationName:andWebKitVersion:.

mjs@apple.com's avatar
mjs@apple.com committed
436
437
438
439
440
441
442
443
2008-10-13  Maciej Stachowiak  <mjs@apple.com>

        Rubber stamped by Mark Rowe.
        
        - use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default

        * Configurations/DebugRelease.xcconfig:

mitz@apple.com's avatar
mitz@apple.com committed
444
445
446
447
448
449
450
451
452
453
454
455
456
2008-10-11  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        - rename _setAlwaysUseATSU to _setAlwaysUsesComplexTextCodePath and
          update it for the renamed WebCoreTextRenderer method; keep the old
          method around for clients that use it

        * WebView/WebView.mm:
        (+[WebView _setAlwaysUseATSU:]):
        (+[WebView _setAlwaysUsesComplexTextCodePath:]):
        * WebView/WebViewPrivate.h:

457
458
459
460
461
462
463
464
465
466
2008-10-09  Timothy Hatcher  <timothy@apple.com>

        Don't convert JavaScriptCore header include paths to WebKit paths. This was needed
        back when NPAPI and WebScriptObject migrated from JavaScriptCore. Also remove
        JavaScriptCore from the VPATH.

        Reviewed by Sam Weinig.

        * MigrateHeaders.make:

darin@apple.com's avatar
darin@apple.com committed
467
468
469
470
471
472
473
474
475
476
2008-10-08  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        - https://bugs.webkit.org/show_bug.cgi?id=21403
          Bug 21403: use new CallFrame class rather than Register* for call frame manipulation

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::WebScriptDebugger): Update since DebuggerCallFrame is simpler now.

477
478
479
480
481
482
2008-10-08  Timothy Hatcher  <timothy@apple.com>

        Roll out r37427 because it causes an infinite recursion loading about:blank.

        https://bugs.webkit.org/show_bug.cgi?id=21476

darin@apple.com's avatar
darin@apple.com committed
483
484
485
486
487
488
489
490
491
492
2008-10-08  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        - https://bugs.webkit.org/show_bug.cgi?id=21403
          Bug 21403: use new CallFrame class rather than Register* for call frame manipulation

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::WebScriptDebugger): Update since DebuggerCallFrame is simpler now.

493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
2008-10-07  David Hyatt  <hyatt@apple.com>

        Move viewless WebKit methods that Safari needs from WebViewInternal to WebViewPrivate.

        Reviewed by Tim Hatcher

        * WebView/WebView.mm:
        (WebKitInitializeApplicationCachePathIfNecessary):
        (-[WebView _registerDraggedTypes]):
        (-[WebView _usesDocumentViews]):
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
        (-[WebView isFlipped]):
        (-[WebView viewWillDraw]):
        * WebView/WebViewInternal.h:
        * WebView/WebViewPrivate.h:

510
511
512
513
514
515
516
517
518
519
2008-10-07  David Hyatt  <hyatt@apple.com>

        Fix crash in isFlipped.  Null check _private since isFlipped can get called from within AppKit
        machinery during teardown of the WebView.

        Reviewed by Adam Roben

        * WebView/WebView.mm:
        (-[WebView isFlipped]):

520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
2008-10-07  David Hyatt  <hyatt@apple.com>

        Make viewless WebKit update focused and active state when the window becomes and loses key.
        The focus controller has been patched to understand that in viewless mode it can recur down and
        update all of the frames, which is why this code works now when placed just on the WebView.

        Reviewed by Adam Roben

        * WebView/WebView.mm:
        (-[WebView addWindowObservers]):
        (-[WebView removeWindowObservers]):
        (-[WebView viewWillMoveToWindow:]):
        (-[WebView viewDidMoveToWindow]):
        (-[WebView _updateFocusedAndActiveState]):
        (-[WebView _windowDidBecomeKey:]):
        (-[WebView _windowDidResignKey:]):
        (-[WebView _windowWillOrderOnScreen:]):

538
539
540
541
542
543
544
545
546
547
2008-10-07  David Hyatt  <hyatt@apple.com>

        Make sure the parent visibility state is set up properly on the outermost ScrollView widget.
        This fixes the repainting issues with viewless WebKit on Mac.

        Reviewed by Sam Weinig

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::transitionToCommittedForNewPage):

548
549
550
551
552
553
554
555
556
2008-10-07  David Hyatt  <hyatt@apple.com>

        Make sure viewless Mac WebKit does a layout if needed before drawing.

        Reviewed by Sam Weinig

        * WebView/WebView.mm:
        (-[WebView viewWillDraw]):

557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
2008-10-07  David Hyatt  <hyatt@apple.com>

        Make sure observers get hooked up to watch for size changes in viewless WebKit mode.

        Reviewed by Sam Weinig

        * ChangeLog:
        * WebView/WebFrame.mm:
        (-[WebFrame _drawRect:contentsOnly:]):
        * WebView/WebView.mm:
        (-[WebView viewWillDraw]):
        (-[WebView _boundsChanged]):
        (-[WebView addSizeObservers]):
        (-[WebView viewDidMoveToWindow]):
        (-[WebView viewDidMoveToSuperview]):

2008-10-07  David Hyatt  <hyatt@apple.com>

        Make sure WebView listens for size changes and resizes the frame view in viewless mode.

        Reviewed by Sam Weinig

        * WebView/WebView.mm:
        (-[WebView addSizeObservers]):
        (-[WebView viewDidMoveToWindow]):
        (-[WebView viewDidMoveToSuperview]):

hyatt@apple.com's avatar
hyatt@apple.com committed
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
2008-10-06  David Hyatt  <hyatt@apple.com>

        Enable viewless Mac WebKit to paint some basic pages.
        
        Reviewed by Sam Weinig

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::windowResizerRect):
        (WebChromeClient::repaint):
        (WebChromeClient::screenToWindow):
        (WebChromeClient::windowToScreen):
        (WebChromeClient::platformWindow):
        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::forceLayoutForNonHTML):
        (WebFrameLoaderClient::dispatchDidCommitLoad):
        (WebFrameLoaderClient::transitionToCommittedForNewPage):
        (WebFrameLoaderClient::createFrame):
        * WebView/WebFrame.mm:
        (-[WebFrame _drawRect:contentsOnly:]):
        * WebView/WebFrameInternal.h:
        * WebView/WebFrameView.mm:
        * WebView/WebFrameViewInternal.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawSingleRect:]):
        (-[WebHTMLView drawRect:]):
        * WebView/WebView.mm:
        (-[WebView isFlipped]):
        (-[WebView _boundsChanged]):
        (-[WebView _mustDrawUnionedRect:singleRects:count:]):
        (-[WebView drawSingleRect:]):
        (-[WebView drawRect:]):
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        (-[WebView initWithFrame:frameName:groupName:]):
        (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
        (-[WebView initWithCoder:]):
        (-[WebView removeSizeObservers]):
        (-[WebView viewWillMoveToWindow:]):
        (-[WebView viewWillMoveToSuperview:]):
        (-[WebView _usesDocumentViews]):
        * WebView/WebViewInternal.h:

626
627
628
629
630
631
632
633
634
635
636
637
638
639
2008-10-06  Kevin Decker  <kdecker@apple.com>

        Rubber-stamped by Anders Carlsson.

        Rename _webkit_applicationCacheDirectoryWithBundleIdentifier to _webkit_localCacheDirectoryWithBundleIdentifier.
        
        * Misc/WebKitNSStringExtras.h:
        * Misc/WebKitNSStringExtras.m:
        (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
        * WebView/WebDataSource.mm:
        (-[WebDataSource _transferApplicationCache:]):
        * WebView/WebView.mm:
        (WebKitInitializeApplicationCachePathIfNecessary):

640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
2008-10-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Make WebNetscapePluginStream a WebCore::NetscapePlugInStreamLoaderClient.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        (WebNetscapePluginStream::~WebNetscapePluginStream):
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::didReceiveResponse):
        (-[WebBaseNetscapePluginStream startStreamWithResponse:]):
        (WebNetscapePluginStream::wantsAllStreams):
        (-[WebBaseNetscapePluginStream wantsAllStreams]):
        (WebNetscapePluginStream::didFail):
        (-[WebBaseNetscapePluginStream destroyStreamWithError:]):
        (WebNetscapePluginStream::didFinishLoading):
        (-[WebBaseNetscapePluginStream finishedLoading]):
        (WebNetscapePluginStream::didReceiveData):
        (-[WebBaseNetscapePluginStream receivedData:]):

660
661
662
663
664
665
666
667
668
2008-10-06  Anders Carlsson  <andersca@apple.com>

        Bring back the stop method. It was called through performSelector, which
        is why I couldn't find any references to it.

        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream stop]):

669
670
671
672
673
674
675
676
677
678
679
680
681
2008-10-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        More conversion and cleanup.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::startStream):
        (-[WebBaseNetscapePluginStream startStreamWithResponse:]):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):

682
683
684
685
686
687
688
689
690
691
2008-10-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Fold initWithRequestURL into initWithRequest.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):

692
693
694
695
696
697
698
699
700
701
702
703
704
705
2008-10-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Change the init methods not to return nil on failures. (These failures never occur anyway)
        
        Use initWithRequest as the initializer, initWithRequestURL is going to be merged with it.
        
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
        (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):

706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
2008-10-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt.

        Convert more methods over to C++.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::ownerForStream):
        (WebNetscapePluginStream::pluginCancelledConnectionError):
        (WebNetscapePluginStream::errorForReason):
        (-[WebBaseNetscapePluginStream errorForReason:]):
        (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
        (WebNetscapePluginStream::cancelLoadAndDestroyStreamWithError):
        (-[WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError:]):
        (WebNetscapePluginStream::deliverData):
        (WebNetscapePluginStream::deliverDataTimerFired):
        (WebNetscapePluginStream::deliverDataToFile):
        (-[WebBaseNetscapePluginStream finishedLoading]):
        (-[WebBaseNetscapePluginStream receivedData:]):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView destroyStream:reason:]):

729
730
731
732
733
734
735
736
737
738
2008-10-06  David Hyatt  <hyatt@apple.com>

        Add SPI for a new viewless WebKit mode.  The idea is that when this flag is set there will be no
        views created except for the outermost WebView.

        Reviewed by Tim Hatcher

        * WebView/WebView.mm:
        * WebView/WebViewInternal.h:

739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
2008-10-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt.

        Convert more methods over to C++.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::reasonForError):
        (WebNetscapePluginStream::destroyStreamWithReason):
        (WebNetscapePluginStream::cancelLoadWithError):
        (-[WebBaseNetscapePluginStream cancelLoadWithError:]):
        (WebNetscapePluginStream::destroyStreamWithError):
        (-[WebBaseNetscapePluginStream destroyStreamWithError:]):
        (-[WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError:]):
        (-[WebBaseNetscapePluginStream _deliverDataToFile:]):
        (-[WebBaseNetscapePluginStream finishedLoading]):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithError:]):

darin@apple.com's avatar
darin@apple.com committed
759
760
761
762
763
764
765
766
767
768
2008-10-04  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        - https://bugs.webkit.org/show_bug.cgi?id=21295
          Bug 21295: Replace ExecState with a call frame Register pointer

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::WebScriptDebugger): Remove 0 passed for ExecState.

769
770
771
772
773
774
775
776
2008-10-03  John Sullivan  <sullivan@apple.com>

        Fixed Release build

        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::destroyStream):
        added !LOG_DISABLED guard around declaration of npErr used only in LOG

777
778
779
780
781
782
783
784
785
786
787
788
2008-10-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt.
        
        Convert destroyStream over to C++.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::destroyStream):
        (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]):
        (-[WebBaseNetscapePluginStream _deliverData]):

789
790
791
792
793
794
795
796
797
798
799
800
801
2008-10-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt.

        Use a Timer instead of -[NSObject performSelector:withObject:afterDelay];
        
        * Plugins/WebBaseNetscapePluginStream.h:
        (WebNetscapePluginStream::WebNetscapePluginStream):
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream _destroyStream]):
        (-[WebBaseNetscapePluginStream _deliverData]):
        (WebNetscapePluginStream::deliverDataTimerFired):

802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
2008-10-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt.

        More plug-in stream cleanup.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        (WebNetscapePluginStream::create):
        (WebNetscapePluginStream::WebNetscapePluginStream):
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream initWithFrameLoader:]):
        (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
        (-[WebBaseNetscapePluginStream dealloc]):
        (-[WebBaseNetscapePluginStream finalize]):
        (-[WebBaseNetscapePluginStream setPlugin:]):
        (WebNetscapePluginStream::setPlugin):
        (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
        (-[WebBaseNetscapePluginStream _destroyStream]):

hyatt@apple.com's avatar
hyatt@apple.com committed
821
822
823
824
825
826
827
828
829
2008-10-03  David Hyatt  <hyatt@apple.com>

        Remove addToDirtyRegion.
        
        Reviewed by Oliver Hunt
        
        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:

hyatt@apple.com's avatar
hyatt@apple.com committed
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
2008-10-02  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21328
        
        Make widget invalidation more cross-platform.
        
        (1) Make invalidateRect a pure virtual function on Widget.  All leaf widgets must now implement this function.
        
        (2) Scrollbars now send invalidations through the ScrollbarClient.  windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
        This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.
        
        (3) Plugins now have the native window invalidation code for windowed plugins.  Windowless plugins do a repaintRectangle on the plugin's renderer.
        
        (4) FrameViews now do a repaintRectangle on their owner element's renderer.

        Reviewed by Sam Weinig

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (PluginWidget::PluginWidget):
        (PluginWidget::invalidateRect):
        (NetscapePluginWidget::NetscapePluginWidget):
        (WebFrameLoaderClient::createPlugin):

darin@apple.com's avatar
darin@apple.com committed
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
2008-10-02  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        - https://bugs.webkit.org/show_bug.cgi?id=21321
          Bug 21321: speed up JavaScriptCore by inlining Heap in JSGlobalData

        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics javaScriptObjectsCount]): Use heap. instead of heap-> to
        work with the heap.
        (+[WebCoreStatistics javaScriptGlobalObjectsCount]): Ditto.
        (+[WebCoreStatistics javaScriptProtectedObjectsCount]): Ditto.
        (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]): Ditto.
        (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Ditto.
        (+[WebCoreStatistics javaScriptReferencedObjectsCount]): Ditto.

hyatt@apple.com's avatar
hyatt@apple.com committed
869
870
871
872
873
874
875
876
877
878
879
880
881
2008-10-02  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21314
        
        Make scrollBackingStore cross-platform.

        Reviewed by Sam Weinig

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::repaint):
        (WebChromeClient::scroll):

ggaren@apple.com's avatar
ggaren@apple.com committed
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
2008-10-01  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler and Cameron Zwarich.

        Updated for JavaScriptCore API changes: use a SourceCode instead of
        broken out parameters; treat sourceId as intptr_t.
        
        We still treat sourceId as int in some cases because of DashCode. See
        <rdar://problem/6263293> WebScriptDebugDelegate should use intptr_t for
        sourceId, not int.

        * WebView/WebScriptDebugger.h:
        * WebView/WebScriptDebugger.mm:
        (toNSString):
        (WebScriptDebugger::sourceParsed):
        (WebScriptDebugger::callEvent):
        (WebScriptDebugger::atStatement):
        (WebScriptDebugger::returnEvent):
        (WebScriptDebugger::exception):
        (WebScriptDebugger::willExecuteProgram):
        (WebScriptDebugger::didExecuteProgram):
        (WebScriptDebugger::didReachBreakpoint):

hyatt@apple.com's avatar
hyatt@apple.com committed
905
906
907
908
909
910
911
912
913
2008-10-01  David Hyatt  <hyatt@apple.com>

        Move prohibitsScrolling from the Frame to the ScrollView.

        Reviewed by Sam Weinig

        * WebView/WebView.mm:
        (-[WebView setProhibitsMainFrameScrolling:]):

hyatt@apple.com's avatar
hyatt@apple.com committed
914
915
916
917
918
919
920
921
922
923
924
925
926
927
2008-10-01  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21282
        
        Make contentsToScreen/screenToContents cross-platform.  Only implemented by Mac/Win right now.
        
        Reviewed by Adam Roben

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::repaint):
        (WebChromeClient::screenToWindow):
        (WebChromeClient::windowToScreen):

928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
2008-09-30   Dave Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21269
  
        This patch makes the ScrollView::paint method cross-platform.  The paint method calls the base class
        Widget paint on platforms with native widgets (Mac and wx).  Otherwise it calls a virtual function,
        paintContents, to paint the ScrollView's contents, and then it paints each of the two scrollbars and
        the scrollbar corner.
        
        The scrollbar themes are now responsible for painting scrollbar corners.  At the moment ScrollbarThemeWin still
        paints white (which is incorrect), so a future patch will actually implement proper native scroll corner painting
        for Windows.
        
        paintContents is implemented by FrameView, and replaces Frame::paint.  All of the FramePrivate member
        variables used by Frame::paint have moved to FrameViewPrivate instead.  All callers of Frame::paint have
        been patched to use FrameView::paintContents instead.
       
        Reviewed by Darin Adler

        * WebView/WebFrame.mm:
        (-[WebFrame _drawRect:]):

950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
2008-09-30  Kevin Decker  <kdecker@apple.com>

        Reviewed by Anders Carlsson.

        Remove the NPDrawingModelOpenGL entirely. To my knowledge no shipping plug-in ever used it, and no other browser engine
        ever supported it.
                              
        * Plugins/WebBaseNetscapePluginView.h: Removed AGL.h import and OpenGL related ivars.
        * Plugins/WebBaseNetscapePluginView.mm: Removed soft linking for OpenGL and AGL frameworks. 
        Also removed many methods AGL/CGL support methods that are no longer necessary.
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed NPDrawingModelOpenGL related code.
        (-[WebBaseNetscapePluginView restorePortState:]): Ditto.
        (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): Ditto.
        (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): Ditto.
        (-[WebBaseNetscapePluginView setWindowIfNecessary]): Ditto.
        (-[WebBaseNetscapePluginView stop]): Ditto.
        (-[WebBaseNetscapePluginView dealloc]): Ditto.
        (-[WebBaseNetscapePluginView drawRect:]): 
        (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): Ditto.
        (-[WebBaseNetscapePluginView invalidateRegion:]): Ditto.
        (-[WebBaseNetscapePluginView getVariable:value:]): Tell plug-ins WebKit does not support NPDrawingModelOpenGL.
        (-[WebBaseNetscapePluginView setVariable:value:]): Removed NPDrawingModelOpenGL related code. 
        (-[WebBaseNetscapePluginView _viewHasMoved]): Ditto.

974
975
976
977
978
979
980
981
982
983
984
985
986
2008-09-30  Dave Hyatt  <hyatt@apple.com>

        http://bugs.webkit.org/show_bug.cgi?id=21250
        
        Rename updateContents to repaintContentRectangle and make it cross-platform by always sending
        repaints up through the ChromeClient.
        
        Reviewed by Darin Adler

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::repaint):

987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
2008-09-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark Rowe and Adam Roben.

        No need to use pointers to store C++ objects as pointers in WebViewPrivate, we can just
        store them directly.
        
        * Configurations/Base.xcconfig:
        Set GCC_OBJC_CALL_CXX_CDTORS to YES.
        
        * WebView/WebView.mm:
        (-[WebViewPrivate init]):
        (-[WebViewPrivate dealloc]):
        (-[WebViewPrivate finalize]):
        (-[WebView _preferencesChangedNotification:]):
        (-[WebView setApplicationNameForUserAgent:]):
        (-[WebView setCustomUserAgent:]):
        (-[WebView customUserAgent]):
        (-[WebView WebCore::_userAgentForURL:WebCore::]):
        (-[WebView _addObject:forIdentifier:]):
        (-[WebView _objectForIdentifier:]):
        (-[WebView _removeObjectForIdentifier:]):

1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
2008-09-29  Thiago Macieira  <thiago.macieira@nokia.com>

        Reviewed by Simon.

        Changed copyright from Trolltech ASA to Nokia.
        
        Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
        

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:

1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
2008-09-28  Timothy Hatcher  <timothy@apple.com>

        Improves the Web Inspector node highlight so it does not scroll
        to reveal the node in the page. This makes the highlight less
        invasive and causes less things to change on screen. Also makes
        the highlight redraw when the WebView draws, so it stays current
        if the node changes on the page for any reason.

        <rdar://problem/6115804> Don't scroll when highlighting (21000)
        https://bugs.webkit.org/show_bug.cgi?id=21000

        Reviewed by Dan Bernstein.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController highlightNode:]): Call setNeedsDisplay:YES
        if there is an existing highlight.
        (-[WebInspectorWindowController didAttachWebNodeHighlight:]): Set the current
        highlight node on the inspected WebView.
        (-[WebInspectorWindowController willDetachWebNodeHighlight:]): Set the current
        highlight node on the inspected WebView to nil.
        * WebInspector/WebNodeHighlight.m:
        (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Disable screen updates
        until flush for the inspected window. Invalidate the whole highlight view since
        we don't know the rect that needs updated since the highlight can be larger than
        the highlighted element due to the margins and other factors.
        * WebInspector/WebNodeHighlightView.m:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawSingleRect:]): Call setNeedsUpdateInTargetViewRect: on the
        current highlight node.
        * WebView/WebView.mm:
        (-[WebViewPrivate dealloc]): Release the current highlight node.
        (-[WebView setCurrentNodeHighlight:]): Set the current highlight node.
        (-[WebView currentNodeHighlight]): Return the current highlight node.
        * WebView/WebViewInternal.h:

1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
2008-09-28  David Kilzer  <ddkilzer@apple.com>

        Fix build warning in WebDefaultUIDelegate.m

        Reviewed by Dan Bernstein.

        This fixes a warning noticed by the clang static analyzer:
        .../WebDefaultUIDelegate.m: In function ‘-[WebDefaultUIDelegate webViewFirstResponder:]’:
        .../WebDefaultUIDelegate.m:92: warning: initialization from distinct Objective-C type

        Note that this doesn't actually cause any change in behavior since
        the gcc compiler ignores the semi-colon anyway.

        * DefaultDelegates/WebDefaultUIDelegate.m:
        (-[WebDefaultUIDelegate webViewFirstResponder:]): Removed semi-colon
        from method signature.

1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
2008-09-27  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=21182

        Make sure Mac null checks the view like the other platforms do now that Mac goes through WebCore
        to call setAllowsScrolling.

        Reviewed by Mark Rowe

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createFrame):

andersca@apple.com's avatar
andersca@apple.com committed
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
2008-09-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21178
        <rdar://problem/6248651>

        Check if the plug-in is allowed to load the resource. This matches Firefox.
        
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

pewtermoose@webkit.org's avatar
pewtermoose@webkit.org committed
1100
1101
1102
1103
1104
1105
1106
1107
2008-09-26  Matt Lilek  <webkit@mattlilek.com>

        Reviewed by Tim Hatcher.

        Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.

        * Configurations/WebKit.xcconfig:

hyatt@apple.com's avatar
hyatt@apple.com committed
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
2008-09-26  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21164

        Rework concept of allowsScrolling/setAllowsScrolling to be cross-platform.

        Reviewed by Sam Weinig

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createFrame):
        * WebView/WebDynamicScrollBarsView.h:
        * WebView/WebDynamicScrollBarsView.m:
        * WebView/WebDynamicScrollBarsViewInternal.h:
        * WebView/WebFrameView.mm:
        (-[WebFrameView setAllowsScrolling:]):
        (-[WebFrameView allowsScrolling]):

hyatt@apple.com's avatar
hyatt@apple.com committed
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
2008-09-26  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21149

        More refactoring to make scrollbar modes cross-platform.  Reduce the protocol that
        WebDynamicScrollBarsView has to implement for communicating with WebCore to just three methods.

        Reviewed by Sam Weinig

        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]):
        (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]):
        (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]):
        (-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
        * WebView/WebDynamicScrollBarsViewInternal.h:
        * WebView/WebFrameView.mm:
        (-[WebFrameView setAllowsScrolling:]):
        * WebView/WebView.mm:
        (-[WebView setAlwaysShowVerticalScroller:]):
        (-[WebView setAlwaysShowHorizontalScroller:]):

1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
2008-09-26  David Kilzer  <ddkilzer@apple.com>

        Fix Mac build with XSLT disabled

        Reviewed by Alexey.

        * Misc/WebCache.mm:
        (+[WebCache statistics]): Populate xslStyleSheet statistics with
        zeros if XSLT is disabled.

1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
2008-09-25  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21101

        Fix the updating of the active state to not be dumb, so that viewless scrollbars repaint properly.

        Reviewed by Tim Hatcher

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _updateFocusedAndActiveState]):

1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
2008-09-24  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        - https://bugs.webkit.org/show_bug.cgi?id=21079
          <rdar://problem/6203938> Disallow embedding Safari-generated pages
          (e.g bookmarks collection) in subframes

        * DefaultDelegates/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
        Use the new +[WebView _canHandleRequest:forMainFrame:] so we can give
        a different answer for the main frame and subframes.
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::canHandleRequest): Ditto.

        * WebView/WebView.mm:
        (+[WebView _canHandleRequest:forMainFrame:]): Added forMainFrame. Only look
        for scheme-specific representations for the main frame, not subframes. 
        (+[WebView _canHandleRequest:]): Give answer for main frame -- calls the
        method above with YES for main frame.

        * WebView/WebViewInternal.h: Added _canHandleRequest:forMainFrame:.

hyatt@apple.com's avatar
hyatt@apple.com committed
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
2008-09-23  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21039

        Teach the viewless Mac scrollbar how to avoid the NSWindow resizer.

        Reviewed by Sam Weinig

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::windowResizerRect):

mitz@apple.com's avatar
mitz@apple.com committed
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
2008-09-23  Dan Bernstein  <mitz@apple.com>

        Reviewed by Beth Dakin.

        - fix <rdar://problem/6233388> Crash beneath -[WebFrameView keyDown:]

        Test: fast/events/keydown-remove-frame.html

        * WebView/WebFrameView.mm:
        (-[WebFrameView keyDown:]): Added a null check.

1212
1213
2008-09-21  Dirk Schulze  <vbs85@gmx.de>

1214
1215
1216
1217
        Reviewed and landed by Eric Seidel.

        Moved CGFloat definition to WebKitPrefix so CGFloat can be used more
        freely throughout WebCore without worrying about breaking Tiger.
1218

1219
1220
        * Misc/WebTypesInternal.h: Removed it from here.
        * WebKitPrefix.h: Added it here.
1221

1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
2008-09-20  Matt Lilek  <webkit@mattlilek.com>

        Reviewed by Tim Hatcher.

        Revert r35688. We use a textured window on Leopard, which does not have the
        square corners of the standard Aqua window on Tiger.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController window]): Add back the call to WKNSWindowMakeBottomCornersSquare.

1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
2008-09-19  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        - speculative fix for https://bugs.webkit.org/show_bug.cgi?id=20943
          Assertion failure in RefCountedLeakCounter::cancelMessageSuppression() when closing a window

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]): Moved call to
        RefCountedLeakCounter::suppressMessages in here.
        (-[WebView initWithFrame:frameName:groupName:]): Moved it out of here.

1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
2008-09-18  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        Add SPI to WebView to allow DRT to clear the main frame's name between tests.

        * WebView/WebView.mm:
        (-[WebView _clearMainFrameName]):
        * WebView/WebViewPrivate.h:

1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
2008-09-18  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        - fix https://bugs.webkit.org/show_bug.cgi?id=20925
          LEAK messages appear every time I quit

        * WebView/WebPreferences.mm:
        (-[WebPreferences setFullDocumentTeardownEnabled:]): Removed unneeded call
        to setLogLeakMessages.
        * WebView/WebView.mm:
        (-[WebView _closeWithFastTeardown]): Call RefCountedLeakCounter::suppressMessages,
        telling it that we can't track leaks because at least one WebView was closed with
        fast teardown.
        (-[WebView _close]): Removed unneeded call to setLogLeakMessages. Added a call to
        cancelMessageSuppression since the WebView is no longer open.
        Added an explicit garbage collect to help with the case where we're closing during
        the quit process -- the garbageCollectSoon() calls done inside WebCore won't help
        us in that case.
        (-[WebView initWithFrame:frameName:groupName:]): Call
        RefCountedLeakCounter::suppressMessages telling it that we can't track leaks
        because at least one WebView is currently open.

1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
2008-09-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Move the remainder of the stream ivars to the C++ object.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        (WebNetscapePluginStream::WebNetscapePluginStream):
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream _pluginCancelledConnectionError]):
        (-[WebBaseNetscapePluginStream initWithFrameLoader:]):
        (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
        (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
        (-[WebBaseNetscapePluginStream dealloc]):
        (-[WebBaseNetscapePluginStream finalize]):
        (-[WebBaseNetscapePluginStream setPlugin:]):
        (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
        (-[WebBaseNetscapePluginStream start]):
        (-[WebBaseNetscapePluginStream stop]):
        (-[WebBaseNetscapePluginStream wantsAllStreams]):
        (-[WebBaseNetscapePluginStream _destroyStream]):
        (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]):
        (-[WebBaseNetscapePluginStream cancelLoadWithError:]):
        (-[WebBaseNetscapePluginStream _deliverData]):

hyatt@apple.com's avatar
hyatt@apple.com committed
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
2008-09-17  David Hyatt  <hyatt@apple.com>

        Make the notion of Widget having an underlying native widget cross-platform.

        Reviewed by Sam Weinig

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (NetscapePluginWidget::handleEvent):
        * WebView/WebFrame.mm:
        (-[WebFrame _dragSourceMovedTo:]):
        (-[WebFrame _dragSourceEndedAt:operation:]):
        * WebView/WebFrameView.mm:
        (-[WebFrameView _install]):
        * WebView/WebRenderNode.mm:
        (copyRenderNode):

1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
2008-09-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Cameron Zwarich.

        Move more instance variables down to the C++ class.

        * Plugins/WebBaseNetscapePluginStream.h:
        (WebNetscapePluginStream::WebNetscapePluginStream):
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
        (-[WebBaseNetscapePluginStream dealloc]):
        (-[WebBaseNetscapePluginStream finalize]):
        (-[WebBaseNetscapePluginStream transferMode]):
        (-[WebBaseNetscapePluginStream plugin]):
        (-[WebBaseNetscapePluginStream setPlugin:]):
        (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
        (-[WebBaseNetscapePluginStream wantsAllStreams]):
        (-[WebBaseNetscapePluginStream _destroyStream]):
        (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]):
        (-[WebBaseNetscapePluginStream _deliverData]):
        (-[WebBaseNetscapePluginStream _deliverDataToFile:]):
        (-[WebBaseNetscapePluginStream finishedLoading]):
        (-[WebBaseNetscapePluginStream receivedData:]):

1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
2008-09-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dave Hyatt.

        Move a bunch of instance variables into the C++ class.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream _pluginCancelledConnectionError]):
        (-[WebBaseNetscapePluginStream errorForReason:]):
        (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
        (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
        (-[WebBaseNetscapePluginStream dealloc]):
        (-[WebBaseNetscapePluginStream setRequestURL:]):
        (-[WebBaseNetscapePluginStream setResponseURL:]):
        (-[WebBaseNetscapePluginStream setMIMEType:]):
        (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
        (-[WebBaseNetscapePluginStream _destroyStream]):
        (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]):
        (-[WebBaseNetscapePluginStream _deliverData]):
        (-[WebBaseNetscapePluginStream receivedData:]):

1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
2008-09-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dave Hyatt.

        Add a new WebNetscapePluginStream C++ class. The idea is that it is supposed to replace the Obj-C 
        WebBaseNetscapePluginStream class. The plan is to gradually move/rewrite code from the Obj-C class to the C++ class
        until the C++ class can replace the Obj-C class.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        (WebNetscapePluginStream::create):
        (WebNetscapePluginStream::WebNetscapePluginStream):
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream initWithFrameLoader:]):
        (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
        (-[WebBaseNetscapePluginStream dealloc]):
        (-[WebBaseNetscapePluginStream finalize]):

1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
2008-09-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dave Hyatt.

        Instead of storing a pointer to NPP method individually, just store a pointer to the NPNetscapeFuncs vtable.
        
        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream setPlugin:]):
        (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
        (-[WebBaseNetscapePluginStream wantsAllStreams]):
        (-[WebBaseNetscapePluginStream _destroyStream]):
        (-[WebBaseNetscapePluginStream _deliverData]):
        * Plugins/WebNetscapePluginPackage.h:
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage pluginFuncs]):

1398
1399
1400
1401
1402
1403
1404
1405
1406
2008-09-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dave Hyatt.

        Remove references to WebNetscapePluginStream.
        
        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebNetscapePluginEmbeddedView.h:

mitz@apple.com's avatar
mitz@apple.com committed
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
2008-09-15  Dan Bernstein  <mitz@apple.com>

        Reviewed by Dave Hyatt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=20860
          REGRESSION: Crash in RenderLayer::hasVisibleContent() loading wavy.com

        * WebView/WebFrame.mm:
        (-[WebFrame _getVisibleRect:]): Changed to check if the RenderPart has
        layout before accessing it, instead of checking if the frame inside it
        has layout.

1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
2008-09-15  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler, Beth Dakin

        Support strings for AXLists

        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory AXDefinitionListTermText]):
        (-[WebViewFactory AXDefinitionListDefinitionText]):

andersca@apple.com's avatar
WebKit:    
andersca@apple.com committed
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
2008-09-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Merge WebNetscapePluginStream into WebBaseNetscapePluginStream.

        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream initWithFrameLoader:]):
        (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
        (-[WebBaseNetscapePluginStream dealloc]):
        (-[WebBaseNetscapePluginStream finalize]):
        (-[WebBaseNetscapePluginStream start]):
        (-[WebBaseNetscapePluginStream stop]):
        (-[WebBaseNetscapePluginStream cancelLoadWithError:]):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
        * Plugins/WebNetscapePluginEmbeddedView.mm:
        * Plugins/WebNetscapePluginStream.h: Removed.
        * Plugins/WebNetscapePluginStream.mm: Removed.

1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
2008-09-12  John Sullivan  <sullivan@apple.com>

        Fixed <rdar://problem/6110941> Clicking the print button in PDF content does nothing

        Reviewed by Darin Adler

        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewPerformPrint:]):
        Implemented PDFKit delegate method that's called after a Print action in the PDF content

mitz@apple.com's avatar
mitz@apple.com committed
1461
1462
1463
1464
1465
1466
1467
1468
1469
2008-09-12  Dan Bernstein  <mitz@apple.com>

        Reviewed by John Sullivan.

        - fix a crash in -visibleRect when it is called during WebFrameView deallocation

        * WebView/WebFrameView.mm:
        (-[WebFrameView visibleRect]): Added an early return if _private is 0.

mitz@apple.com's avatar
mitz@apple.com committed
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
2008-09-11  Dan Bernstein  <mitz@apple.com>

        Reviewed by John Sullivan.

        - eliminate excessive repainting when a clipped iframe is moved (noticed in <rdar://problem/6204032>)

        * WebView/WebFrame.mm:
        (-[WebFrame _getVisibleRect:]): Added. If the frame is in a RenderPart
        and has layout, gets the visible rect of the RenderPart and returns
        YES. Returns NO otherwise.
        * WebView/WebFrameInternal.h:
        * WebView/WebFrameView.mm:
        (-[WebFrameView visibleRect]): Added. Overrides this NSView method to
        take clipping in the render tree into account.

mitz@apple.com's avatar
mitz@apple.com committed
1485
1486
1487
1488
1489
1490
1491
2008-09-09  Dan Bernstein  <mitz@apple.com>

        - Tiger build fix

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):

mitz@apple.com's avatar
mitz@apple.com committed
1492
1493
1494
1495
1496
1497
1498
1499
1500
2008-09-09  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        - WebKit part of <rdar://problem/6206244> Use alternate character-to-glyph interface on Leopard

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):

1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
2008-09-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej Stachowiak.

        Bug 20704: Replace the KJS namespace
        <https://bugs.webkit.org/show_bug.cgi?id=20704>

        Rename the KJS namespace to JSC.

        * Misc/WebCoreStatistics.mm:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream wantsAllStreams]):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
        (-[WebBaseNetscapePluginView setWindowIfNecessary]):
        (-[WebBaseNetscapePluginView start]):
        (-[WebBaseNetscapePluginView createPluginScriptableObject]):
        (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
        (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
        (-[WebBaseNetscapePluginView loadPluginRequest:]):
        (-[WebBaseNetscapePluginView _printedPluginBitmap]):
        * Plugins/WebPluginController.mm:
        (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
        (-[WebPluginController startAllPlugins]):
        (-[WebPluginController stopAllPlugins]):
        (-[WebPluginController addPlugin:]):
        (-[WebPluginController destroyPlugin:]):
        (-[WebPluginController destroyAllPlugins]):
        * WebView/WebFrame.mm:
        * WebView/WebScriptDebugDelegate.mm:
        * WebView/WebScriptDebugger.h:
        * WebView/WebScriptDebugger.mm:
        * WebView/WebView.mm:
        (-[WebViewPrivate init]):

1536
1537
1538
1539
1540
1541
1542
1543
2008-09-05  Timothy Hatcher  <timothy@apple.com>

        Correct a typo in the setApplicationChromeModeEnabledEnabled:
        method name, remove the extra "Enabled".

        * WebView/WebPreferences.mm:
        * WebView/WebPreferencesPrivate.h:

1544
1545
1546
1547
1548
1549
1550
1551
1552
2008-09-04  Mark Rowe  <mrowe@apple.com>

        Reviewed by Eric Seidel.

        Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
        Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE

        * Configurations/WebKit.xcconfig: Remove ENABLE_DASHBOARD_SUPPORT from FEATURE_DEFINES.

eric@webkit.org's avatar
eric@webkit.org committed
1553
1554
1555
1556
1557
1558
1559
1560
1561
2008-09-03  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)

        * Configurations/WebKit.xcconfig:
        * WebKitPrefix.h: add rules for V8_BINDINGS

abarth@webkit.org's avatar
abarth@webkit.org committed
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
2008-09-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=19760

        Add a linked-on-or-after check to prevent substitute data from loading
        local resources on newer users of WebKit.

        * Misc/WebKitVersionChecks.h:
        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]):

beidson@apple.com's avatar
beidson@apple.com committed
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
2008-08-29  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Fix regression I introducted in 35946
        Already covered by media/video-click-dlbclick-standalone.html

        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation receivedData:withDataSource:]): Cancel the load here after
          calling [WebFrame _receivedData:] which more closely follows the path taken by PluginDocuments

1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
2008-08-28  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff.

        <rdar://problem/6095949> REGRESSION (5525.8-6527.1?): "this" is null
        when you first hit a breakpoint in Dashcode
        - We wanted to reset the callframe whenever eval() was called but
        dashcode uses eval() when broken to evaluate the state of the current
        call frame.

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::willExecuteProgram):
        (WebScriptDebugger::didExecuteProgram):

weinig@apple.com's avatar
weinig@apple.com committed
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
2008-08-27  Robert Kroeger  <rjkroege@liqui.org>

        Tweaked by Sam Weinig.

        Reviewed by Eric Seidel.

        Fix https://bugs.webkit.org/show_bug.cgi?id=6595
        <rdar://problem/4432150>
        Right-click does not fire mouseup event

        Adds a rightMouseUp handler to the WebHTMLView.

        The added method generates mouseup events for button 2.  The result
        is that webkit will deliver mousedown and mouseup events for button
        2 in a fashion identical to FireFox and will retain event ordering
        identical to Internet Explorer.

        Test: fast/events/mouseup-from-button2.html

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView rightMouseUp:]):

1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
2008-08-27  Timothy Hatcher  <timothy@apple.com>

        Add support for support for -webkit-appearance: default-button on the Mac platform.

        <rdar://problem/6173530>

        Reviewed by Dave Hyatt.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Init AdvanceDefaultButtonPulseAnimation.
        * WebView/WebPreferenceKeysPrivate.h: Added WebKitApplicationChromeModeEnabledPreferenceKey.
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]): Set WebKitApplicationChromeModeEnabledPreferenceKey to NO.
        (-[WebPreferences applicationChromeModeEnabled]): Added.
        (-[WebPreferences setApplicationChromeModeEnabledEnabled:]): Added.
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Call Settings::setApplicationChromeMode
        with the value of -[WebPreferences applicationChromeModeEnabled].

beidson@apple.com's avatar
beidson@apple.com committed
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
2008-08-27  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        <rdar://problem/6134133> - Crash when loading large movie as a standalone document

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::pluginWillHandleLoadError):

mitz@apple.com's avatar
mitz@apple.com committed
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
2008-08-20  Dan Bernstein  <mitz@apple.com>

        Rubber-stamped by John Sullivan.

        - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen,
          rename related methods and variables accordingly, and make
          -setShouldUpdateWhileOffscreen: and -shouldUpdateWhileOffscreen
          WebView API.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::transitionToCommittedForNewPage):
        * WebView/WebFrame.mm:
        (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView windowWillOrderOnScreen:]):
        * WebView/WebView.h:
        * WebView/WebView.mm:
        (-[WebViewPrivate init]):
        (-[WebView setBackgroundColor:]):
        (-[WebView setDrawsBackground:]):
        (-[WebView setShouldUpdateWhileOffscreen:]):
        (-[WebView shouldUpdateWhileOffscreen]):
        * WebView/WebViewPrivate.h:

1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
2008-08-18  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin Adler.

        Switch to non-deprecated NSFileManager API.

        In order to minimize #if's the new NSFileManager APIs have been implemented for
        Tiger and call sites updated to use the new methods.

        * Misc/WebIconDatabase.mm:
        (importToWebCoreFormat):
        * Misc/WebKitNSStringExtras.m:
        (-[NSString _webkit_fixedCarbonPOSIXPath]):
        * Misc/WebKitSystemBits.m:
        * Misc/WebNSFileManagerExtras.h:
        * Misc/WebNSFileManagerExtras.m: Remove implementations of methods that are not used.
        (-[NSFileManager _webkit_backgroundRemoveFileAtPath:]):
        (-[NSFileManager attributesOfFileSystemForPath:error:]): Implement new API for Tiger in terms of Tiger API.
        (-[NSFileManager contentsOfDirectoryAtPath:error:]): Ditto.
        (-[NSFileManager moveItemAtPath:toPath:error:]): Ditto.
        (-[NSFileManager removeItemAtPath:error:]): Ditto.
        * Plugins/WebPluginDatabase.mm:
        (-[WebPluginDatabase _scanForNewPlugins]):

andersca@apple.com's avatar
andersca@apple.com committed
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
2008-08-20  Josh Aas  <joshmoz@gmail.com>

        Reviewed and landed by Anders.

        <rdar://problem/6163636> 
        rename NPCocoaEvent's "event" struct to "data" (20446)

        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::drawRect):
        (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
        (WebNetscapePluginEventHandlerCocoa::flagsChanged):
        (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
        (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
        (WebNetscapePluginEventHandlerCocoa::focusChanged):

bdakin@apple.com's avatar
bdakin@apple.com committed
1716
1717
2008-08-20  Beth Dakin  <bdakin@apple.com>

1718
        Reviewed by Darin Adler.
bdakin@apple.com's avatar
bdakin@apple.com committed
1719
1720
1721
1722
1723
1724
1725
1726
1727

        Fix for <rdar://problem/6145626>
        Allows a WebKit client to mark a frame as not-text-searchable 
        through SPI.

        * WebView/WebFrame.mm:
        (-[WebFrame _setExcludeFromTextSearch:]):
        * WebView/WebFramePrivate.h:

ap@webkit.org's avatar
ap@webkit.org committed
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
2008-08-19  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Geoff Garen.

        Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.

        * ForwardingHeaders/kjs/JSLock.h: Added.
        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics javaScriptObjectsCount]):
        (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
        (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
        (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
        (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
        (+[WebCoreStatistics shouldPrintExceptions]):
        (+[WebCoreStatistics setShouldPrintExceptions:]):
        (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream wantsAllStreams]):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
        (-[WebBaseNetscapePluginView setWindowIfNecessary]):
        (-[WebBaseNetscapePluginView start]):
        (-[WebBaseNetscapePluginView createPluginScriptableObject]):
        (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
        (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
        (-[WebBaseNetscapePluginView loadPluginRequest:]):
        (-[WebBaseNetscapePluginView _printedPluginBitmap]):
        * Plugins/WebPluginController.mm:
        (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
        (-[WebPluginController startAllPlugins]):
        (-[WebPluginController stopAllPlugins]):
        (-[WebPluginController addPlugin:]):
        (-[WebPluginController destroyPlugin:]):
        (-[WebPluginController destroyAllPlugins]):
        * WebView/WebFrame.mm:
        (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptCallFrame evaluateWebScript:]):
        * WebView/WebView.mm:
        (-[WebView aeDescByEvaluatingJavaScriptFromString:]):

1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
2008-08-19  Timothy Hatcher  <timothy@apple.com>

        Fixes the Web Inspector flashing white while resizing after
        highlighting a page element. Calling disableScreenUpdatesUntilFlush
        when attaching and detaching the Inspector page highlight is bad,
        since the browser window might not flush again for a while. So screen
        updates could be disabled for long periods of time, causing backing store
        flashing while resizing. There is no need to call disableScreenUpdatesUntilFlush
        when attaching or detaching the child window.

        Reviewed by John Sullivan and Kevin McCullough.

        * WebInspector/WebNodeHighlight.m:
        (-[WebNodeHighlight attach]): Remove the call to disableScreenUpdatesUntilFlush.
        (-[WebNodeHighlight detach]): Ditto.

1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
2008-08-19  Timothy Hatcher  <timothy@apple.com>

        Correctly remembers the attached state of the Web Inspector so
        it opens in that state for the next window, or next launch.

        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController attach]): Set WebKitInspectorAttachedKey
        to YES in the user defaults.
        (-[WebInspectorWindowController detach]): Set WebKitInspectorAttachedKey
        to NO in the user defaults.

ap@webkit.org's avatar
ap@webkit.org committed
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
2008-08-18  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=19347
        <rdar://problem/5977562> Input methods do not work after switching to a password field
        and back.

        Fix <rdar://problem/5522011> (The content of the password field of Safari is displayed by
        reconversion) in a different way which doesn't conflict with context caching performed
        by AppKit.

        This original bug does not really occur in ToT or shipping Safari under Mac OS X 10.5.4,
        because input methods are disabled in password fields. Attempting to reconvert text typed
        with Romaji only yields a string of bullets. Still, it is probably better to match Cocoa
        password field behavior and disable reconversion completely.

        * WebView/WebHTMLView.mm:
        (isInPasswordField): Factored out code to determine that the current selection is in
        a password field.
        (inputContext): Removed a hack that was breaking TSMGetActiveDocument().
        (-[WebHTMLView attributedSubstringFromRange:]): Check for password fields.
        (-[WebHTMLView textStorage]): Ditto.

darin@apple.com's avatar
darin@apple.com committed
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
2008-08-12  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - eliminate JSValue::type()

        * WebView/WebView.mm:
        (aeDescFromJSValue): Rewrite to use the JSValue::is functions instead
        of a switch on JSValue::type().

ggaren@apple.com's avatar
ggaren@apple.com committed
1832
1833
1834
1835
1836
1837
1838
1839
2008-08-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Made room for a free word in JSCell.
        
        (Updated for JavaScriptCore changes.)

1840
1841
1842
1843
1844
1845
1846
1847
1848
2008-08-15  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Geoff Garen.

        <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework

        * Configurations/Base.xcconfig: Factor out the debug-only settings so that they can shared
        between the Debug configuration and debug Production variant.

weinig@apple.com's avatar
weinig@apple.com committed
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
2008-08-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen and Timothy Hatcher.

        Add WebView SPI to set HTMLTokenizer yielding parameters.

        * WebView/WebView.mm:
        (-[WebView _setCustomHTMLTokenizerTimeDelay:]):
        (-[WebView _setCustomHTMLTokenizerChunkSize:]):
        * WebView/WebViewPrivate.h:

1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
2008-08-13  Timothy Hatcher  <timothy@apple.com>

        Fixes a bug where Safari's find banner would be permanently hidden
        when attaching or closing the Web Inspector while attached.

        https://bugs.webkit.org/show_bug.cgi?id=20376

        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController close]):
        Carefully manipulate the WebFrameView's frame when closing to
        not assume the WebFrameView's frame fills the inspected WebView.
        (-[WebInspectorWindowController setAttachedWindowHeight:]):
        Carefully manipulate the WebFrameView's frame when docking to
        not assume the WebFrameView plus the Web Inspector WebViews fills
        the full inspected WebView.

1878
1879
1880
1881
1882
1883
2008-08-13  Stephanie Lewis  <slewis@apple.com>

        fix 64bit build

        * WebCoreSupport/WebInspectorClient.mm:

1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
2008-08-13  Timothy Hatcher  <timothy@apple.com>

        Remember the docked state of the Web Inspector, so it can be
        reopened docked if it was last docked.

        https://bugs.webkit.org/show_bug.cgi?id=14271

        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController init]): Initialize _shouldAttach
        to the value stored in the user defaults. If there has never
        been a value stored, default to being attached.
        (-[WebInspectorWindowController showWindow:]): Pass the attached
        state to InspectorController::setWindowVisible.

1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Remove the Inspector's WebView for the view hierarchy when closed
        while attached. This prevents it from showing in the background
        while the page changes.

        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController close:]): Call removeFromSuperview
        on the Inspector's WebView if it isn't attached, so it will not
        be visible when navigating pages while closed.

1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Make the docked Web Inspector resizable.

        https://bugs.webkit.org/show_bug.cgi?id=14282

        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.h:
        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::setAttachedWindowHeight): Call setAttachedWindowHeight:
        on the WebInspectorWindowController.
        (-[WebInspectorWindowController showWindow:]): Call setAttachedWindowHeight:.
        (-[WebInspectorWindowController setAttachedWindowHeight:]): Moved code
        from showWindow: and generalized to allow being called multiple times.
        Remembers the last height passed, which is used by showWindow: the next
        time the Inspector attaches.

1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Remove unneeded header imports from some Web Inspector files.

        Reviewed by Adam Roben.

        * WebCoreSupport/WebInspectorClient.mm:
        * WebInspector/WebInspector.mm:
        * WebInspector/WebNodeHighlightView.m:

1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Remove the call to WKNSWindowMakeBottomCornersSquare on the
        Web Inspector's window. This isn't needed anymore since the
        window style masks used always have square bottom corners.

        Reviewed by Adam Roben.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController window]): Remove the call
        to WKNSWindowMakeBottomCornersSquare.

1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Make attaching and detaching the Web Inspector instantaneous.
        This also preserves the current view, other state, and keeps
        the script debugger attached.

        https://bugs.webkit.org/show_bug.cgi?id=19301

        Reviewed by Adam Roben.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController close]): Only call setWindowVisible(false)
        when not moving windows.

mitz@apple.com's avatar
mitz@apple.com committed
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
2008-08-12  Dan Bernstein  <mitz@apple.com>

        Reviewed by John Sullivan.

        - replace -[WebPreferences updatesWhenOffscreen] with -[WebView shouldUpdateWhileHidden]

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::transitionToCommittedForNewPage):
        * WebView/WebFrame.mm:
        (-[WebFrame _updateBackgroundAndUpdatesWhileHidden]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView windowWillOrderOnScreen:]):
        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebViewPrivate init]):
        (-[WebView _preferencesChangedNotification:]):
        (-[WebView setBackgroundColor:]):
        (-[WebView setDrawsBackground:]):
        (-[WebView shouldUpdateWhileHidden]):
        (-[WebView setShouldUpdateWhileHidden:]):
        * WebView/WebViewPrivate.h:

mitz@apple.com's avatar
mitz@apple.com committed
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2008-08-08  Dan Bernstein  <mitz@apple.com>

        Reviewed by John Sullivan.

        - fix <rdar://problem/6130216> Exception "windowRegionBeingDrawn != nil" in NSView when caching image of a subframe

        This change reintroduces <https://bugs.webkit.org/show_bug.cgi?id=5195> on Leopard.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Removed an
        unsuccessful workaround for <rdar://problem/5668489>, because invoking
        layout may change the view hierarchy during the drawing operation,
        which is not supported on Leopard.

2007
2008
2009
2010
2011
2012
2013
2008-08-08  Maxime Britto  <britto@apple.com>

        Reviewed by Adele.

        * WebView/WebFrame.mm:
        (-[WebFrame _scrollDOMRangeToVisible:]):

2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2008-08-08  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Fix for <rdar://problem/5865504>

        This bug was actually *largely* fixed by http://trac.webkit.org/changeset/35538.
        But with that same patch, it became possible for a WebResource to fail to initialize.  
        Therefore we were trying to add nil to an NSCFArray for certain situations, which is bad.
        Lets fix that, shall we?

        * WebView/WebArchive.mm:
        (-[WebArchive subresources]): 

2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2008-08-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Cameron Zwarich.

        Move more methods from Frame into ScriptController
        https://bugs.webkit.org/show_bug.cgi?id=20294

        The WebKit side of this move.  Calls to frame() are now frame()->script()

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView getVariable:value:]):
        (-[WebBaseNetscapePluginView _destroyPlugin]):
        * Plugins/WebPluginController.mm:
        (-[WebPluginController destroyPlugin:]):
        (-[WebPluginController destroyAllPlugins]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        * WebView/WebFrame.mm:
        (-[WebFrame windowObject]):
        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::callEvent):
        * WebView/WebView.mm:
        (-[WebView windowScriptObject]):

mitz@apple.com's avatar
mitz@apple.com committed
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2008-08-06  Dan Bernstein  <mitz@apple.com>

        Reviewed by Mark Rowe.

        - fix an assertion failure in Cache::setCapacities()

        * Misc/WebKitSystemBits.h: Changed the return type of WebMemorySize()
        to uint64_t.
        * Misc/WebKitSystemBits.m:
        (WebMemorySize):
        * WebView/WebView.mm:
        (+[WebView _setCacheModel:]):

2064
2065
2066
2067
2068
2069
2070
2008-08-05  Anders Carlsson  <andersca@apple.com>

        Pass in the correct class here.
        
        * WebView/WebResource.mm:
        (-[WebResourcePrivate dealloc]):

andersca@apple.com's avatar
andersca@apple.com committed
2071
2072
2008-08-05  Anders Carlsson  <andersca@apple.com>

2073
        Reviewed by Darin Adler.
andersca@apple.com's avatar
andersca@apple.com committed
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101

        <rdar://problem/6037398>
        ER: Deallocate WebKit objects on the main thread, even if released on secondary thread
        
        Add calls to WebCoreObjCScheduleDeallocateOnMainThread in dealloc methods of objects we expose.

        * Carbon/CarbonWindowAdapter.m:
        (-[CarbonWindowAdapter dealloc]):
        * History/WebBackForwardList.mm:
        (-[WebBackForwardList dealloc]):
        * History/WebHistoryItem.mm:
        (-[WebHistoryItem dealloc]):
        * Misc/WebElementDictionary.mm:
        (+[WebElementDictionary initialize]):
        (-[WebElementDictionary dealloc]):
        * WebCoreSupport/WebEditorClient.mm:
        (-[WebEditCommand dealloc]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        * WebView/WebArchive.mm:
        (-[WebArchivePrivate dealloc]):
        * WebView/WebDataSource.mm:
        (-[WebDataSourcePrivate dealloc]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLViewPrivate dealloc]):
        (-[WebHTMLView dealloc]):
        * WebView/WebResource.mm:
        (-[WebResourcePrivate dealloc]):

2102
2103
2008-08-05  Anders Carlsson  <andersca@apple.com>

2104
        Reviewed by Darin Adler.
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114

        Remove MainThreadObjectDeallocator.{h|mm}.

        * WebView/MainThreadObjectDeallocator.h: Removed.
        * WebView/MainThreadObjectDeallocator.mm: Removed.
        
        * WebView/WebView.mm:
        (-[WebView dealloc]):
        Call WebCoreObjCScheduleDeallocateOnMainThread instead.

2115
2116
2008-08-05  Anders Carlsson  <andersca@apple.com>

2117
        Reviewed by Darin Adler.
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132

        Make the main thread object deallocator work with subclasses.
        
        * WebView/MainThreadObjectDeallocator.h:
        * WebView/MainThreadObjectDeallocator.mm:
        (deallocCallback):
        Call the correct dealloc method.
                
        (scheduleDeallocateOnMainThread):
        Store both the class and the instance, so we know which dealloc method to call.
        
        * WebView/WebView.mm:
        (-[WebViewPrivate dealloc]):
        Schedule deallocation on the main thread.

2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2008-08-05  Dan Bernstein  <mitz@apple.com>

        Reviewed by Mark Rowe and Anders Carlsson.

        - fix WebMemorySize() reporting a value capped at 2GB

        * misc/WebKitSystemBits.m:
        (WebMemorySize): Changed to return the max_mem field, which, unlike
        memory_size, is not capped at 2GB.
        * WebView/WebView.mm:
        (+[WebView _setCacheModel:]): Made the cache sizes for over 2GB RAM the
        same as for 2GB, so that behavior on machines that have more than 2GB
        RAM is not affected by the fix to WebMemorySize().

mrowe@apple.com's avatar
mrowe@apple.com committed
2147
2148
2149
2150
2151
2152
2008-08-04  Mark Rowe  <mrowe@apple.com>

        Build fix.

        * WebView/WebHTMLView.mm:

2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2008-08-04  Mark Rowe  <mrowe@apple.com>

        Reviewed by Kevin Decker.

        Adopt the formal protocols where necessary.
        Final part of fix for <rdar://problem/5853147>.

        * WebCoreSupport/WebInspectorClient.mm:
        * WebView/WebHTMLView.mm:
        * WebView/WebView.mm:
        (-[WebView _openFrameInNewWindowFromMenu:]):

2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2008-08-04  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin Adler.

        Declare empty protocols when using versions of AppKit that do not use formal protocols for delegates and data sources.
        Part one of fix for <rdar://problem/5853147>.

        * Misc/EmptyProtocolDefinitions.h:
        * WebKitPrefix.h:

2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2008-08-04  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel

        Fix <rdar://problem/5820157> - Saving WebArchives of Mail attachments broken.

        This broke in r31355 when we stopped returning nil WebResources when there was nil
        resource data.

        * WebView/WebResource.mm:
        (-[WebResource _initWithCoreResource:]): Restore previous behavior of returning nil
          when the resource data is null.

2188
2189
2190
2191
2192
2193
2194
2195
2196
2008-08-02  Matt Lilek  <webkit@mattlilek.com>

        Reviewed by Tim Hatcher.

        Update the window gradient offset to match the inspector toolbar's new height.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController window]):

2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2008-08-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jon.

        <rdar://problem/6120206>
        Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.
        
        Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.

        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream wantsAllStreams]):

2209
2210
2008-07-31  Anders Carlsson  <andersca@apple.com>

2211
        Reviewed by Darin Adler.
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229

        <rdar://problem/5949410>
        Add the ability to transfer a given application cache to a new database.

        * Misc/WebKitNSStringExtras.h:
        * Misc/WebKitNSStringExtras.m:
        (+[NSString _webkit_applicationCacheDirectoryWithBundleIdentifier:]):
        New method which returns the appopriate cache directory for a given bundle identifier.
        
        * WebView/WebDataSource.mm:
        (-[WebDataSource _transferApplicationCache:]):
        Transfer the application cache.
        
        * WebView/WebDataSourcePrivate.h:
        * WebView/WebView.mm:
        (WebKitInitializeApplicationCachePathIfNecessary):
        Change this to use _webkit_applicationCacheDirectoryWithBundleIdentifier.

sullivan@apple.com's avatar
sullivan@apple.com committed
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2008-07-31  John Sullivan  <sullivan@apple.com>

        WebKit part of <rdar://problem/6116650> Text-only zoom setting should be stored in WebKit prefs

        Reviewed by Hyatt

        * WebView/WebPreferenceKeysPrivate.h:
        added WebKitZoomsTextOnlyPreferenceKey
        
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        default value of YES for WebKitZoomsTextOnlyPreferenceKey
        (-[WebPreferences zoomsTextOnly]):
        getter for WebKitZoomsTextOnlyPreferenceKey
        (-[WebPreferences setZoomsTextOnly:]):
        setter for WebKitZoomsTextOnlyPreferenceKey
        
        * WebView/WebPreferencesPrivate.h:
        declare zoomsTextOnly/setZoomsTextOnly:
        
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):
        update WebCore::Settings value for zoomsTextOnly

2254
2255
2256
2257
2008-07-31  David D. Kilzer  <ddkilzer@webkit.org>

        Fix layout test results for webarchive/test-xml-stylesheet.xml

2258
        Reviewed by Darin Adler.
2259
2260
2261
2262
2263
2264

        Needed to expose -[WebHTMLRepresentation supportedNonImageMIMETypes]
        for DumpRenderTree.

        * WebView/WebHTMLRepresentationInternal.h: Added.

ap@webkit.org's avatar
ap@webkit.org committed
2265
2266
2267
2268
2269
2270
2271
2008-07-31  Alexey Proskuryakov  <ap@webkit.org>

        Release build fix.

        * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView setWindowIfNecessary]):
        Don't define to npErr in release builds, as it is only used for logging.

2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2008-07-31  John Sullivan  <sullivan@apple.com>

        Fixed <https://bugs.webkit.org/show_bug.cgi?id=5195>
        drawing with cacheDisplayInRect:toBitmapImageRep: doesn't trigger layout on Leopard

        Reviewed by Dan

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
        include Leopard in the #ifdef that forces a layout if needed

beidson@apple.com's avatar
beidson@apple.com committed
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2008-07-30  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam and Hyatt

        Fix for <rdar://problem/6099748>

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Set the "don't enforce CSS mime type in strict mode" 
          quirk when running under iWeb 2

ap@webkit.org's avatar
ap@webkit.org committed
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2008-07-31  Alexey Proskuryakov  <ap@webkit.org>

        Rubber-stamped by Maciej.

        Eliminate JSLock (it was already disabled, removing the stub implementaion and all
        call sites now).

        * ForwardingHeaders/kjs/JSLock.h: Removed.
        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics javaScriptObjectsCount]):
        (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
        (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
        (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
        (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
        (+[WebCoreStatistics shouldPrintExceptions]):
        (+[WebCoreStatistics setShouldPrintExceptions:]):
        (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream wantsAllStreams]):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
        (-[WebBaseNetscapePluginView setWindowIfNecessary]):
        (-[WebBaseNetscapePluginView start]):
        (-[WebBaseNetscapePluginView createPluginScriptableObject]):
        (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
        (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
        (-[WebBaseNetscapePluginView loadPluginRequest:]):
        (-[WebBaseNetscapePluginView _printedPluginBitmap]):
        * Plugins/WebPluginController.mm:
        (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
        (-[WebPluginController startAllPlugins]):
        (-[WebPluginController stopAllPlugins]):
        (-[WebPluginController addPlugin:]):
        (-[WebPluginController destroyPlugin:]):
        (-[WebPluginController destroyAllPlugins]):
        * WebView/WebFrame.mm:
        (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptCallFrame evaluateWebScript:]):
        * WebView/WebView.mm:
        (-[WebView aeDescByEvaluatingJavaScriptFromString:]):

bdakin@apple.com's avatar
bdakin@apple.com committed
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2008-07-30  Beth Dakin  <bdakin@apple.com>

        Reviewed by Anders Carlsson.

        Fixes <rdar://problem/6041390>

        Adds the ability to have a frame that is "disconnected" from the 
        main frame from the perspective of top and parent in 
        Javascript.

        * WebView/WebFrame.mm:
        (-[WebFrame _setIsDisconnectedFrame]):
        * WebView/WebFramePrivate.h:

2349
2350
2351
2352
2353
2354
2355
2008-07-29  Mark Rowe  <mrowe@apple.com>

        Tweak to the build fix to keep Dan happy.

        * Plugins/WebBaseNetscapePluginView.mm:
        * WebView/WebHTMLView.mm:

mrowe@apple.com's avatar
mrowe@apple.com committed
2356
2357
2358
2359
2360
2361
2362
2363
2008-07-29  Mark Rowe  <mrowe@apple.com>

        Build fix.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView inputContext]):
        * WebView/WebHTMLView.mm:

2364
2365
2366
2367
2368
2369
2370
2008-07-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Based on a patch by Dimcho Balev.
        
        https://bugs.webkit.org/show_bug.cgi?id=18676
andersca@apple.com's avatar
andersca@apple.com committed
2371
        <rdar://problem/6106578>
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
        Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs

        * Plugins/WebBaseNetscapePluginStream.h:
        Add NPP_GetValue pointer.
        
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream setPlugin:]):
        Initialize NPP_GetValue.
        
        (-[WebBaseNetscapePluginStream wantsAllStreams]):
        Call NPP_GetValue.
        
        * Plugins/WebPlugInStreamLoaderDelegate.h:
        * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h:
        * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm:
        (WebNetscapePlugInStreamLoaderClient::wantsAllStreams):
        Implement this and call down to the stream.

2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2008-07-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        <rdar://problem/6105529> 
        https://bugs.webkit.org/show_bug.cgi?id=19659
        Turning off plugins causes crash
        
        When an active page has plug-ins, and plug-ins are disabled, they will be stopped and will
        end up in a state where they don't have an event handler. Because of this, we need to 
        check that the plug-in has been started before calling the event handler.
        
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView sendActivateEvent:]):
        (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
        (-[WebBaseNetscapePluginView setHasFocus:]):
        (-[WebBaseNetscapePluginView mouseDown:]):
        (-[WebBaseNetscapePluginView mouseUp:]):
        (-[WebBaseNetscapePluginView mouseEntered:]):
        (-[WebBaseNetscapePluginView mouseExited:]):
        (-[WebBaseNetscapePluginView handleMouseMoved:]):
        (-[WebBaseNetscapePluginView mouseDragged:]):
        (-[WebBaseNetscapePluginView scrollWheel:]):
        (-[WebBaseNetscapePluginView keyUp:]):
        (-[WebBaseNetscapePluginView keyDown:]):
        (-[WebBaseNetscapePluginView flagsChanged:]):
        (-[WebBaseNetscapePluginView cut:]):
        (-[WebBaseNetscapePluginView copy:]):
        (-[WebBaseNetscapePluginView paste:]):
        (-[WebBaseNetscapePluginView selectAll:]):
        (-[WebBaseNetscapePluginView drawRect:]):
        (-[WebBaseNetscapePluginView inputContext]):

2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2008-07-26  Daniel Jalkut  <jalkut@red-sweater.com>

        Reviewed by Geoff Garen.

        Changes to accommodate newly named/signatured loading methods in WebCore.

        * Plugins/WebNetscapePluginStream.mm:
        (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
        * Plugins/WebPluginContainerCheck.mm:
        (-[WebPluginContainerCheck _isForbiddenFileLoad]):
        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewWillClickOnLink:withURL:]):

2436
2437
2438
2439
2440
2441
2442
2443
2444
2008-07-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/6091287> Revamp the handling of CFBundleShortVersionString to be fixed at the major component of the version number.

        * Configurations/Version.xcconfig:
        * Info.plist:

andersca@apple.com's avatar
andersca@apple.com committed
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2008-07-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff.

        <rdar://problem/5820667> 
        CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load
        
        Don't allow URLs to be loaded in response to an NPP_DestroyStream that happens when tearing down the plug-in.
        
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2008-07-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Adam Roben.

        <rdar://problem/5624143> WebView printing doesn't work correctly in x86_64

        Fix the return type of an NSView method that we override so that the correct data type is used in 64-bit.
        This prevents a garbage value being used for the scale factor that the NSView print machinery applies.

        * WebView/WebHTMLView.mm:

2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2008-07-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Adam Roben.

        Fix CallDelegateReturningFloat for x86_64.  The x86_64 Objective-C runtime
        only uses objc_msgSend_fpret for long double return values.  For float return
        values the standard objc_msgSend is used, as on ppc and ppc64.

        * WebView/WebView.mm: Use objc_msgSend_float_return as the name of our version of
        objc_msgSend with the correct return type.  We can no longer call it objc_msgSend_fpret
        as that method is defined by the Objective-C runtime for x86_64.
        (CallDelegateReturningFloat):

mitz@apple.com's avatar
mitz@apple.com committed
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2008-07-14  Dan Bernstein  <mitz@apple.com>

        Reviewed by John Sullivan.

        - WebKit part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Changed
        to account for the case of being drawn into a bitmap context that is not
        a window's backing store. In that case, there are no valid "rects being
        drawn" to clip to.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
        Added an override of this NSView method which is used in for
        -cacheDisplayInRect:toBitmapImageRep:. Like two existing NSView drawing
        machinery overrides, it sets subviews aside before invoking the
        superclass implementation. On Tiger, it also updates the layout.

ap@webkit.org's avatar
ap@webkit.org committed
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2008-07-14  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Geoff Garen.

        Eliminate per-thread JavaScript global data instance support and make arbitrary
        global data/global object combinations possible.

        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics javaScriptObjectsCount]):
        (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
        (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
        (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
        (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
        (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
        Ask WebCore for its instance of JSGlobalData, now that it is not in per-thread storage.

2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2008-07-11  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Darin Adler.

        Disable WTF leak messages when using fast teardown.  Use full document teardown while running in debug.

        * WebView/WebPreferences.m: Removed.
        * WebView/WebPreferences.mm: Copied from http:/svn.webkit.org/repository/webkit/trunk/WebKit/mac/WebView/WebPreferences.m.
        (+[WebPreferences initialize]): if running in Default enable full  document teardown
        (-[WebPreferences editableLinkBehavior]):
        (-[WebPreferences setFullDocumentTeardownEnabled:]):
        * WebView/WebView.mm:
        (-[WebView _close]): disable leak messages if using fast teardown

2529
2530
2531
2532
2533
2534
2535
2536
2008-07-10  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig.

        Define WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST when building WebKit to ensure that no symbols end up with the weak_import attribute.

        * Configurations/WebKit.xcconfig:

2537
2538
2539
2540
2541
2542
2543
2544
2545
2546
2008-07-10  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig.

        Fix the Tiger build by omitting annotations from methods declared in categories when using old versions of GCC.

        * Plugins/WebPlugin.h: Wrap annotations on methods declared in categories in the WEBKIT_CATEGORY_METHOD_ANNOTATION macro.
        * WebView/WebFrameLoadDelegate.h: Ditto.
        * WebView/WebUIDelegate.h: Ditto.

2547
2548
2549
2550
2551
2552
2553
2554
2555
2008-07-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.
        
        Add availability macros for the new WebPlugin methods.

        * Plugins/WebPlugin.h:
        * Plugins/WebPluginViewFactory.h:

2556
2557
2558
2559
2560
2561
2562
2563
2564
2008-07-09  Mark Rowe  <mrowe@apple.com>

        Reviewed by Geoff Garen.

        Don't warn about deprecated functions in production builds.

        * Configurations/Base.xcconfig:
        * Configurations/DebugRelease.xcconfig:

beidson@apple.com's avatar
beidson@apple.com committed
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2595
2008-07-09  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        <rdar://problem/5823684> - Crash manipulating frame tree of a new frame before the new frame
        has been installed in a frame tree.

        The root of this problem was that calling init() on a new frame could end up calling arbitrary
        javascript that might end up removing the frame from the tree.  This opened up a small can of worms
        such as the frame not having yet been installed in its frame tree, and other assumed behavior while
        destroying the frame.

        Note that each platforms WebKit API layer needs to make this new guarantee:
        "The new Frame must be installed in its FrameTree before newCoreFrame->init() is called"
        I am fixing Mac, and Windows and GTK already have this property.  Wx currently has subframes disabled
        but will need to add this guarantee when re-enabling, and Qt is currently vulnerable to this same bug.

        Alternately, the way frames are created right now is roundabout and asinine, and this is a key
        architectural improvement we can make in the future so the individual platform clients are no longer
        vulnerable to this problem, which should really have been a WebCore issue.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createFrame):  Don't bother null checking the newCoreFrame - can't be NULL.
          Don't appendChild() the new frame here.
          Null-check the new frame's page before loading the URL into it, as it might already have been
          removed from the page.

        * WebView/WebFrame.mm:
        (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):  If there is an ownerElement,
          go ahead and install the new frame in the frame tree *before* calling init() on it.

2596
2597
2008-07-09  Anders Carlsson  <andersca@apple.com>

2598
        Reviewed by Darin Adler.
andersca@apple.com's avatar
<