ChangeLog 2.44 MB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Adds an overlay window that covers the scripts panel and
        informs the user that they need to attach the debugger.
        Provides an "Attach Debugger" button below the info text.

        Reviewed by Dan Bernstein.

        * English.lproj/localizedStrings.js: New strings.
        * page/inspector/ScriptsPanel.js:
        (WebInspector.ScriptsPanel): Create the overlay elements and
        append to the main panel element.
        * page/inspector/inspector.css: New styles for the over lay elements.

15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Fixes the assertion and crash that would happen when inspecting a element from a frame.
        This change makes JSInspectedObjectWrapper pass unwrapped objects around for global objects
        that share the same page group identifier. Also returns jsUndefined() instead of 0 to prevent
        crashing in release builds if the page groups don't match.

        Passes all the tests in: manual-tests/inspector-wrappers

        Reviewed by Adam Roben.

        * bindings/js/JSInspectedObjectWrapper.cpp:
        (WebCore::JSInspectedObjectWrapper::prepareIncomingValue): Return jsUndefined() instead of 0.
        Call allowsUnwrappedAccessFrom instead of unwrappedExecStateMatches.
        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Renamed from unwrappedExecStateMatches.
        Return true if the pageGroupIdentifier of both wrappers match.
        (WebCore::JSQuarantinedObjectWrapper::callAsFunction): Return jsUndefined() instead of 0.
        * bindings/js/JSQuarantinedObjectWrapper.h: Renamed unwrappedExecStateMatches to allowsUnwrappedAccessFrom.

35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Fixes the hang that could happen when option-clicking to expand
        a disclosure triangle in the Properties pane. This change limits
        the recursion depth when expanding the tree elements.

        <rdar://problem/5847681> Safari hangs when option-clicking a
        disclosure triangle in the Inspector's Properties pane

        Reviewed by John Sullivan.

        * page/inspector/treeoutline.js:
        (TreeElement.prototype.expandRecursively): Pass an empty info object to
        traverseNextTreeElement to get the depthChange value. This is used to
        compute a current depth. If the depth exceeds the maxDepth argument, the
        item isn't expanded and children wont be populated when traverseNextTreeElement
        is called until the depth goes below the maxDepth.
        (TreeElement.prototype.traverseNextTreeElement): Added a new info
        argument that can be optionally used to return extra info like depth change.

55 56 57 58 59 60 61 62 63 64 65 66 67 68 69
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Adds info text to panes and sections in the Inspector's sidebars
        that would normally be empty. These help the user know why there
        is nothing in these sections.

        Reviewed by John Sullivan.

        * English.lproj/localizedStrings.js: Add strings.
        * page/inspector/BreakpointsSidebarPane.js: Adds "No Breakpoints".
        * page/inspector/CallStackSidebarPane.js: Adds "Not Paused".
        * page/inspector/ObjectPropertiesSection.js: Adds "No Properties".
        * page/inspector/ScopeChainSidebarPane.js: Adds "Not Paused".
        * page/inspector/inspector.css: Adds style rules for the info elements.

70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Implements the rest of the Scripts panel to get the debugger
        mostly working. "Basic debugging seems to work."

        Reviewed by Geoff Garen.

        * English.lproj/localizedStrings.js: Adds new strings.
        * page/inspector/Resource.js:
        (WebInspector.Resource.prototype.get scripts): Returns _scripts and 
        creates it lazily.
        (WebInspector.Resource.prototype.addScript): Add the script object to the
        front of the _scripts array.
        (WebInspector.Resource.prototype.removeAllScripts): Removed all the scripts
        and removes the resource back-reference.
        (WebInspector.Resource.prototype.removeScript): Removes the script and
        breaks the resource back-reference.
        * page/inspector/ResourceView.js:
        (WebInspector.ResourceView): Adds a reminder comment.
        (WebInspector.ResourceView.prototype.get headersVisible): Returns _headersVisible. 
        (WebInspector.ResourceView.prototype.set headersVisible): Stubs out
        a setter that currently just sets _headersVisible. Has a comment that
        points out this needs implemented when network headers are added.
        * page/inspector/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.show): Sets the headersVisible property of
        the visible view to true and shows it again, in case it was being shown in Scripts.
        (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
        Copies the headersVisible property from the old view to the new view.
        (WebInspector.ResourcesPanel.prototype.showResource): Sets the headersVisible
        property to true before showing.
        * page/inspector/ScriptView.js:
        (WebInspector.ScriptView): Passes in _addBreakpoint for the add breakpoint delegate.
        (WebInspector.ScriptView.prototype._addBreakpoint): Calls ScriptsPanel's addBreakpoint
        for the current Script.sourceID and line.
        * page/inspector/ScriptsPanel.js:
        (WebInspector.ScriptsPanel): 
        (WebInspector.ScriptsPanel.prototype.show): Sets the headersVisible property of
        the visible view to false and shows it again, in case it was being shown in Resources.
        (WebInspector.ScriptsPanel.prototype.addScript): Makes a new Script object and
        adds it to a Resource if one is found. Registers any breakpoint that match
        the new Script's source URL, and sets the sourceID of the breakpoints.
        (WebInspector.ScriptsPanel.prototype.addBreakpoint): Adds the breakpoint to the
        BreakpointsSidebarPane. Also adds it to _breakpointsURLMap so it can be found
        later in addScript by URL. Finally adds the breakpoint to the SourceFrame that
        represents the resources or script.
        (WebInspector.ScriptsPanel.prototype.removeBreakpoint): Removes the breakpoint from
        the BreakpointsSidebarPane, _breakpointsURLMap and SourceFrame.
        (WebInspector.ScriptsPanel.prototype.debuggerPaused): Update the debugger
        state variables, the buttons and the CallStackSidebarPane.
        (WebInspector.ScriptsPanel.prototype.reset): Clears and resets debugger
        and interface state.
        (WebInspector.ScriptsPanel.prototype.get visibleView): Returns _visibleView.
        (WebInspector.ScriptsPanel.prototype.set visibleView): Sets _visibleView and
        calls hide on the old view and show on the new view.
        (WebInspector.ScriptsPanel.prototype.showScript): Calls _showScriptOrResource.
        (WebInspector.ScriptsPanel.prototype.showResource): Ditto.
        (WebInspector.ScriptsPanel.prototype.scriptViewForScript): Lazily creates a
        ScriptView for the Script and returns it. 
        (WebInspector.ScriptsPanel.prototype.sourceFrameForScript): Returns the SourceFrame
        for the Script.
        (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource): Returns the
        SourceFrame based on the type of object passed in.
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource): Shows the view based on
        the type of object passed in. If the object is a resource and there are breakpoints
        defined for that Resource URL, then populate the SourceFrame with the breakpoints.
        (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): Adds a script to the 
        files menu. If the Script is part of a resource, that resource is added.
        (WebInspector.ScriptsPanel.prototype._removeScriptFromFilesMenu): Remove a script from
        the files menu. If that script is part of a resource and it is the last script of that
        resource, then remove the whole resource.
        (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine): Clears the execution
        line from the SourceFrame that is showing it.
        (WebInspector.ScriptsPanel.prototype._callFrameSelected): Event listener for when the
        call frame changes in the CallStackSidebarPane. Triggers updates to the ScopeChainSidebarPane
        and the visible view.
        (WebInspector.ScriptsPanel.prototype._changeVisibleFile): Event listener for the change state
        of the files select element.
        (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Update more of the 
        buttons to reflect the current debugger state. Updates the status text too.
        (WebInspector.ScriptsPanel.prototype._toggleDebugging): Reset the UI and state when
        the debugger is attached/detached.
        (WebInspector.ScriptsPanel.prototype._togglePause): Call InspectorController.resumeDebugger or
        InspectorController.pauseInDebugger depending on the paused state.
        (WebInspector.ScriptsPanel.prototype._stepOverClicked): Call InspectorController.stepOverStatementInDebugger.
        (WebInspector.ScriptsPanel.prototype._stepIntoClicked): Call InspectorController.stepIntoStatementInDebugger.
        (WebInspector.ScriptsPanel.prototype._stepOutClicked): InspectorController.stepOutOfFunctionInDebugger.
        * page/inspector/SourceView.js:
        (WebInspector.SourceView): Passes in _addBreakpoint for the add breakpoint delegate.
        (WebInspector.SourceView.prototype._addBreakpoint): Calls ScriptsPanel's addBreakpoint
        for the nearest Script's sourceID and passed in line.
        * page/inspector/inspector.css: New style rules for the UI changes.
        * page/inspector/inspector.js:
        (WebInspector.loaded): Add the ScriptsPanel to the panels list.
        (WebInspector.parsedScriptSource): Call ScriptsPanel.addScript.
        (WebInspector.failedToParseScriptSource): Ditto.
        (WebInspector.pausedScript): Call ScriptsPanel.debuggerPaused.

167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Adds implementations of the Scope Chain and Call Stack sidebar panes.
        These panes use the JSJavaScriptCallFrame object that will be passed
        to the update functions.

        Reviewed by Kevin McCullough.

        * English.lproj/localizedStrings.js: Adds new strings.
        * WebCore.vcproj/WebCore.vcproj: Adds new files.
        * page/inspector/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane.prototype.update): Walk the 
        caller chain of the call frame and make placards for each.
        (WebInspector.CallStackSidebarPane.prototype.get selectedCallFrame):
        Return _selectedCallFrame. 
        (WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame):
        Set _selectedCallFrame and dispatch the "call frame selected" event.
        (WebInspector.CallStackSidebarPane.prototype._placardSelected):
        Set the selectedCallFrame based on the clicked placard.
        * page/inspector/Placard.js: Added. A user interface object that can
        be used to show a title and a subtitle block with a selected state.
        * page/inspector/ScopeChainSidebarPane.js: Added.
        (WebInspector.ScopeChainSidebarPane): Call the base object and set the title.
        (WebInspector.ScopeChainSidebarPane.prototype.update): Iterate over the
        call frame's scope chain and make ObjectPropertiesSections for each.
        * page/inspector/SidebarPane.js:
        (WebInspector.SidebarPane.prototype): Inherit from WebInspector.Object.
        * page/inspector/WebKit.qrc: Add new files.
        * page/inspector/inspector.css: Add placard styles.
        * page/inspector/inspector.html: Add new files.

198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Fixes the bug where SourceViews would be blank if shown before
        the Resource finished loading.

        <rdar://problem/5807420> Safari's Web Inspector won't display the
        contents of some CSS and JS files

        Reviewed by Kevin McCullough.

        * page/inspector/Resource.js:
        (WebInspector.Resource.prototype.set finished): Dispatch the finished event
        (WebInspector.Resource.prototype): Inherit from WebInspector.Object.prototype.
        * page/inspector/SourceView.js:
        (WebInspector.SourceView): Register for the finished event on the resource.
        When the event fires, setup the source frame and deregister the event.

215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Factored most of SourceView out into SourceFrame so it can be shared
        by the new ScriptView. Added the ScriptView class to be used for
        scripts that arn't Resources (like eval code.) Added a simple Script
        object that hold the data from the debugger parsedSource hooks. A
        ScriptView holds a Script object, and uses it for source data.

        Added breakpoint and execution line support to the SourceFrame
        where they are visually represented in the source.

        Reviewed by Kevin McCullough.

        * page/inspector/inspector.js:
        (WebInspector.performSearch): Change the caller of sourceFrameForResource
        to use the SourceFrame result's element property.
        * page/inspector/ResourcesPanel.js: Use the new SourceFrame.
        * page/inspector/Script.js: Added.
        * page/inspector/ScriptView.js: Added.
        * page/inspector/SourceFrame.js: Added.
        * page/inspector/SourceView.js: Use the new SourceFrame.
        * WebCore.vcproj/WebCore.vcproj: Add new files.
        * page/inspector/WebKit.qrc: Ditto.
        * page/inspector/inspector.html: Ditto.

240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Adds a Breakpoint object and basic add/remove functions on
        BreakpointsSidebarPane that call the InspectorController to
        add/remove the breakpoint.

        Reviewed by Kevin McCullough.

        * page/inspector/Breakpoint.js:
        (WebInspector.Breakpoint): 
        (WebInspector.Breakpoint.prototype.get enabled): Return _enabled.
        (WebInspector.Breakpoint.prototype.set enabled): Set _enabled and
        dispatch the enabled/disabled event to listeners.
        * page/inspector/BreakpointsSidebarPane.js:
        (WebInspector.BreakpointsSidebarPane): Add a breakpoints array.
        (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
        Adds the breakpoint to the breakpoints array. Registers for the disabled
        and enabled event types. Call InspectorController.addBreakpoint if attached.
        (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
        Removes the breakpoint from the breakpoints array. Deregisters for the disabled
        and enabled event types. Call InspectorController.removeBreakpoint if attached.
        (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
        Call InspectorController.addBreakpoint or InspectorController.removeBreakpoint
        depending on the enabled state of the breakpoint.
        * WebCore.vcproj/WebCore.vcproj: Add new files.
        * page/inspector/WebKit.qrc: Ditto.
        * page/inspector/inspector.html: Ditto.

268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Make addSourceToFrame not dependent on InspectorResource so it
        can be used to add source of a passed in string and mime-type to
        a frame. Added addResourceSourceToFrame for use by SourceView.

        Also fixes an assertion because of an incorrect static_cast of identifiers
        to unsigned long long, when they can be unsigned.

        Reviewed by Geoff Garen.

        * page/InspectorController.cpp:
        (WebCore::addSourceToFrame): Helper function used by addSourceToFrame
        and addResourceSourceToFrame.
        (WebCore::addSourceToFrame): Generalized to take a source and mime-type string.
        (WebCore::addResourceSourceToFrame): Renamed from addSourceToFrame.
        (WebCore::getResourceDocumentNode): Fixes the static_cast to be long long.
        (WebCore::InspectorController::windowScriptObjectAvailable): Adds
        addResourceSourceToFrame to the JavaScript class.
        * page/inspector/SourceView.js: Use the new addResourceSourceToFrame.

289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Add debugger related functions to the InspectorController and
        expose them to the JavaScript side of InspectorController.

        Reviewed by Geoff Garen.

        * page/InspectorController.cpp:
        (WebCore::jsStringRef): Added helper to convert a UString to a JSStringRef.
        (WebCore::currentCallFrame): Call InspectorController::currentCallFrame.
        (WebCore::pauseInDebugger): Call InspectorController::pauseInDebugger.
        (WebCore::resumeDebugger): Call InspectorController::resumeDebugger.
        (WebCore::stepOverStatementInDebugger): Call InspectorController::stepOverStatementInDebugger.
        (WebCore::stepIntoStatementInDebugger): Call InspectorController::stepIntoStatementInDebugger.
        (WebCore::stepOutOfFunctionInDebugger): Call InspectorController::stepOutOfFunctionInDebugger.
        (WebCore::addBreakpoint): Call InspectorController::addBreakpoint.
        (WebCore::removeBreakpoint): Call InspectorController::removeBreakpoint.
        (WebCore::InspectorController::windowScriptObjectAvailable): Add the new functions to the
        InspectorController JavaScript class.
        (WebCore::InspectorController::startDebuggingAndReloadInspectedPage): Clear breakpoints.
        (WebCore::InspectorController::currentCallFrame): Return the currentCallFrame from the
        JavaScriptDebugServer.
        (WebCore::InspectorController::pauseInDebugger): Call JavaScriptDebugServer's pauseOnNextStatement.
        (WebCore::InspectorController::resumeDebugger): Call JavaScriptDebugServer's resume.
        (WebCore::InspectorController::stepOverStatementInDebugger):  Call JavaScriptDebugServer's stepOverStatement.
        (WebCore::InspectorController::stepIntoStatementInDebugger): Call JavaScriptDebugServer's stepIntoStatement.
        (WebCore::InspectorController::stepOutOfFunctionInDebugger): Call JavaScriptDebugServer's stepOutOfFunction.
        (WebCore::InspectorController::addBreakpoint): Call JavaScriptDebugServer's addBreakpoint.
        (WebCore::InspectorController::removeBreakpoint): Call JavaScriptDebugServer's removeBreakpoint.
        (WebCore::InspectorController::didParseSource): Call into the Inspector's JavaScript.
        (WebCore::InspectorController::failedToParseSource): Ditto.
        (WebCore::InspectorController::didPause): Ditto.
        * page/InspectorController.h: Add new functions.

323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Implements more debugger APIs on JavaScriptDebugServer and reduces
        the number of callbacks to JavaScriptDebugListeners. These changes
        will better facilitate debugger optimizations when SquirrelFish merges.

        Reviewed by Kevin McCullough.

        * page/InspectorController.cpp:
        (WebCore::InspectorController::didParseSource): Removed the ExecState.
        (WebCore::InspectorController::failedToParseSource): Ditto.
        (WebCore::InspectorController::didPause): Added.
        * page/InspectorController.h: Changed the JavaScriptDebugListener functions.
        * page/JavaScriptDebugListener.h: Removed some callbacks and added didPause.
        * page/JavaScriptDebugServer.cpp:
        (WebCore::JavaScriptDebugServer::JavaScriptDebugServer): Initialize new data members.
        (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer): Delete all values of m_breakpoints.
        (WebCore::JavaScriptDebugServer::removeListener): Call resume if the last listener was removed.
        (WebCore::JavaScriptDebugServer::hasListenersInterestedInPage): Returns true if there are any
        global listeners or a listener for the page.
        (WebCore::JavaScriptDebugServer::addBreakpoint): Adds and entry to m_breakpoints.
        (WebCore::JavaScriptDebugServer::removeBreakpoint): Removes a entry in m_breakpoints.
        (WebCore::JavaScriptDebugServer::hasBreakpoint):  Checks if there is a breakpoint for the
        sourceID and line.
        (WebCore::JavaScriptDebugServer::clearBreakpoints): Removed all breakpoints.
        (WebCore::JavaScriptDebugServer::pauseOnNextStatement): Sets m_pauseOnNextStatement to true.
        (WebCore::JavaScriptDebugServer::resume): Sets m_paused to false.
        (WebCore::JavaScriptDebugServer::stepIntoStatement): Calls resume and sets
        m_pauseOnNextStatement to true.
        (WebCore::JavaScriptDebugServer::stepOverStatement): Calls resume and sets m_pauseOnExecState to
        the current call frame's ExecState.
        (WebCore::JavaScriptDebugServer::stepOutOfFunction): Calls resume and sets m_pauseOnExecState to
        the current call frame's caller ExecState.
        (WebCore::JavaScriptDebugServer::currentCallFrame): Returns m_currentCallFrame if paused.
        (WebCore::dispatchDidParseSource): Removed the ExecState argument.
        (WebCore::dispatchFailedToParseSource): Ditto.
        (WebCore::JavaScriptDebugServer::sourceParsed): Doesn't pass the ExecState to dispatchDidParseSource
        or dispatchFailedToParseSource.
        (WebCore::dispatchFunctionToListeners):
        (WebCore::JavaScriptDebugServer::dispatchFunctionToListeners): Removes all the arguments passed
        to the callback.
        (WebCore::JavaScriptDebugServer::setJavaScriptPaused): Various overloaded functions
        to pause parts of WebCore to prevent JavaScript execution while paused.
        (WebCore::JavaScriptDebugServer::pauseIfNeeded): Decides if the debugger should pause based
        on the passed in ExecState, source ID and line number. This checks for breakpoints, stepping, etc.
        Calls didPause on all the listeners and spins a EventLoop until resume is called.
        (WebCore::JavaScriptDebugServer::callEvent): Call pauseIfNeeded.
        (WebCore::JavaScriptDebugServer::atStatement): Ditto.
        (WebCore::JavaScriptDebugServer::returnEvent): Ditto.
        (WebCore::JavaScriptDebugServer::exception): Ditto.
        * page/JavaScriptDebugServer.h: Added new functions.

375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Change View.show to call detach if the parentNode dosen't
        match before appending to the passed in parent element.
        This also prevents appending to the same parent element
        multiple times.

        Reviewed by John Sullivan.

        * page/inspector/FontView.js:
        (WebInspector.FontView.prototype.show): Pass the parent element to View.show.
        * page/inspector/ResourceView.js: Optimize the attach method to no append if
        there is a parentNode already.
        * page/inspector/SourceView.js: Ditto.
        * page/inspector/View.js: Call detach before appending if the parentNode
        doesn't match the passed in element.

392 393 394 395 396 397 398 399 400 401 402
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Optimize the panel attach method to no append if there is a
        parentNode already.

        Reviewed by Adam Roben.

        * page/inspector/Panel.js:
        (WebInspector.Panel.prototype.attach): Don't append to main-panels
        if the panel element already has a parentNode.

403 404 405 406 407 408 409 410 411 412 413
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Add Widget::isPluginView so the JavaScriptDebugServer can identify
        plugins that need to be paused during debugging. This will be used
        in a upcoming commit.

        Reviewed by Kevin McCullough.

        * platform/Widget.h: Add isPluginView. Return false.
        * plugins/PluginView.h: Add isPluginView. Return true.

414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Adds an event loop abstraction to platform. This abstraction will be
        used by the JavaScriptDebugServer to implement pausing.

        Reviewed by Kevin McCullough.

        * platform/EventLoop.h: Added.
        (WebCore::EventLoop::EventLoop):
        (WebCore::EventLoop::ended): Return m_ended.
        * platform/mac/EventLoopMac.mm: Added.
        (WebCore::EventLoop::cycle): Call nextEventMatchingMask and then sendEvent.
        * platform/win/EventLoopWin.cpp: Added.
        (WebCore::EventLoop::cycle): Call GetMessage, TranslateMessage and DispatchMessage.
        * WebCore.xcodeproj/project.pbxproj: Add new files.
        * WebCore.vcproj/WebCore.vcproj: Ditto.

431 432 433 434 435 436 437 438 439 440 441 442 443 444
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Breaks out ObjectPropertiesSection from PropertiesSidebarPane
        so it can be used by the Scripts panel's Scope Chain pane.

        Rubber-stamped by Adam Roben.

        * page/inspector/ObjectPropertiesSection.js: Added.
        * page/inspector/PropertiesSidebarPane.js: Moved ObjectPropertiesSection
        to ObjectPropertiesSection.js.
        * WebCore.vcproj/WebCore.vcproj: Add the new file.
        * page/inspector/WebKit.qrc: Ditto.
        * page/inspector/inspector.html: Ditto.

445 446 447 448 449 450 451 452 453 454 455 456
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Add a helper function to the Inspector's Array prototype
        that will remove any identical values/objects from the array.

        Reviewed by Kevin McCullough.

        * page/inspector/utilities.js:
        (Array.prototype.remove): Iterate over the array and strict
        compare to the passed in value. If they match, splice that index
        out of the array. If onlyFirst is true, return after the first splice.

457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Adds a JavaScriptCallFrame object and JavaScript binding with an IDL.
        This object will expose the stack to the Inspector's debugger.

        Reviewed by Adam Roben.

        * DerivedSources.make: Add JavaScriptCallFrame.
        * bindings/js/JSJavaScriptCallFrameCustom.cpp: Added.
        (WebCore::JSJavaScriptCallFrame::evaluate): Calls impl evaluate and returns the result.
        (WebCore::JSJavaScriptCallFrame::scopeChain): Makes an array of the ScopeChain.
        * page/JavaScriptCallFrame.cpp: Added.
        (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
        (WebCore::JavaScriptCallFrame::caller): Returns m_caller.
        (WebCore::JavaScriptCallFrame::functionName): Returns the function
        name from the ExecState if this is not global code or anonymous.
        (WebCore::JavaScriptCallFrame::evaluate): Evaluates a script string
        in the scope of the call frame.
        * page/JavaScriptCallFrame.h: Added.
        (WebCore::JavaScriptCallFrame::create): Call the ctor can return in a PassRefPtr.
        (WebCore::JavaScriptCallFrame::invalidate): Sets m_mexec to 0. This prevents a
        stale ExecState from being accessed after the lifetime of the ExecState.
        (WebCore::JavaScriptCallFrame::isValid): Checks if m_exec is 0.
        (WebCore::JavaScriptCallFrame::execState): Returns m_exec.
        (WebCore::JavaScriptCallFrame::sourceIdentifier): Returns m_sourceID.
        (WebCore::JavaScriptCallFrame::line): Returns m_line.
        (WebCore::JavaScriptCallFrame::setLine): Sets m_line.
        (WebCore::JavaScriptCallFrame::scopeChain): Returns by reference m_exec->scopeChain().
        * page/JavaScriptCallFrame.idl: Added.
        * WebCore.xcodeproj/project.pbxproj: Add new files.
        * WebCore.vcproj/WebCore.vcproj: Ditto.

489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Add a new WebInspector.Object base class that will be used for
        a few objects in the Web Inspector to support listeners on any
        object. This will help add more abstraction to the Inspector.

        Reviewed by Adam Roben.

        * page/inspector/Object.js: Added.
        (WebInspector.Object): Does nothing.
        (WebInspector.Object.prototype.addEventListener): Adds the listener to
        the _listeners map by type. Supports a this object argument, for easy
        addition of listeners without the need for bind.
        (WebInspector.Object.prototype.removeEventListener): Remove the listener
        from the _listeners map. If the listener is null and the thisObject was
        passed, remove any listener for that thisObject.
        (WebInspector.Object.prototype.dispatchEventToListeners): Sends an event
        for a type to all listeners for that type. Mimics some of the DOMEvent
        methods and properties for the event object passed to the listeners.
        * WebCore.vcproj/WebCore.vcproj: Add new files.
        * page/inspector/WebKit.qrc: Ditto.
        * page/inspector/inspector.html: Ditto.

512 513 514 515 516 517 518 519
2008-05-13  Timothy Hatcher  <timothy@apple.com>

        Update the view source CSS to better match the new Inspector mock-ups.

        Reviewed by Kevin McCullough.

        * css/view-source.css:

sullivan@apple.com's avatar
sullivan@apple.com committed
520 521 522 523 524 525 526 527 528 529 530 531 532
2008-05-13  John Sullivan  <sullivan@apple.com>

        Reviewed by Dan Bernstein and Kevin Decker
        
        - fixed <rdar://problem/5879597> reproducible crash in HTMLSelectElement::typeAheadFind

        Test: fast/forms/select-type-ahead-list-box-no-selection.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::typeAheadFind):
        When there's no initially-selected element, we were accessing index -1. Check for this
        case and start at 0.

533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550
2008-05-13  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Small cleanup to XMLHttpRequest in preparation for Access Control changes.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::XMLHttpRequest):
        (WebCore::XMLHttpRequest::~XMLHttpRequest):
        (WebCore::XMLHttpRequest::open):
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::internalAbort):
        (WebCore::XMLHttpRequest::processSyncLoadResults):
        (WebCore::XMLHttpRequest::didFinishLoading):
        (WebCore::XMLHttpRequest::didReceiveResponse):
        (WebCore::XMLHttpRequest::didReceiveData):
        * xml/XMLHttpRequest.h:

551 552 553 554 555 556 557 558 559
2008-05-13  chris fleizach  <cfleizach@apple.com>

        Beth Dakin

        <rdar://problem/5701210> VO: If image is missing, VoiceOver does not speak the alternative text.

        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

560 561 562 563 564 565 566 567 568 569
2008-05-13  chris fleizach  <cfleizach@apple.com>

        Beth Dakin

        <rdar://problem/5908446> AX: webkit needs to return blockquote information for all AX objects, not just in AXTextMarker info

        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

ap@webkit.org's avatar
ap@webkit.org committed
570 571 572 573 574 575 576 577 578 579 580 581 582 583 584
2008-05-13  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by John Sullivan.

        <rdar://problem/4852077> REGRESSION: The content of the HTML file which is saved as Thai
        (ISO 8859-11) disappear.

        <rdar://problem/5842597> Thai ISO-8859-11 should be upgraded to Windows-874

        Test: fast/encoding/char-decoding.html

        * platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
        Register ISO-8859-11, which doesn't have a standard IANA name, despite following
        the usual 8859 naming scheme. Also, made TIS-620 map to windows-874-2000 explicitly.

585 586 587 588 589 590 591 592 593
2008-05-13  chris fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin

        <rdar://problem/5471973> Some AXLinks are not getting AXTitles though there is title text

        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::title):

ap@webkit.org's avatar
ap@webkit.org committed
594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618
2008-05-13  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=18681
        <rdar://problem/5888130> WebKit should not remove BOM characters from content.

        We were only trying to match Firefox, and it doesn't do this any more.

        Tests: fast/encoding/bom-in-content.html
               fast/encoding/bom-in-content-utf16.html

        * platform/text/TextDecoder.cpp: (WebCore::TextDecoder::checkForBOM): Skip the BOM if it's
        at the start of input stream.

        * platform/text/TextCodec.cpp:
        * platform/text/TextCodec.h:
        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::decode):
        * platform/text/TextCodecUTF16.cpp:
        (WebCore::TextCodecUTF16::decode):
        * platform/text/mac/TextCodecMac.cpp:
        (WebCore::TextCodecMac::decode):
        Don't remove the BOM.

andersca@apple.com's avatar
andersca@apple.com committed
619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637
2008-05-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Don't crash when a document loader is destroyed while an initial caching attempt
        is in progress.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup):
        Stop loading.
        
        (WebCore::ApplicationCacheGroup::stopLoading):
        New method that stops a cache update.
        
        (WebCore::ApplicationCacheGroup::documentLoaderDestroyed):
        Delete ourselves here.
        
        * loader/appcache/ApplicationCacheGroup.h:

ap@webkit.org's avatar
ap@webkit.org committed
638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653
2008-05-13  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin.

        <rdar://problem/5841351> Turkish ISO 8859-9 encoding should be treated as windows-1254

        Match IE and upgrade ISO-8859-9 to windows-1254, which is its strict superset.

        Test: fast/encoding/char-decoding.html

        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::registerExtendedEncodingNames): Register the standard name
        unconditionally. Previously, we registered windows-949-2000 as a special case that lacked 
        an IANA standard name, and got away with not registering GBK because it happened
        to be reported by ICU normally earlier than any encoding upgraded to it.

654 655 656 657 658 659 660 661 662 663
2008-05-13  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Fix QtWebKit build on Qt embedded.

        * WebCore.pro:
        * platform/FileSystem.h:
        * platform/qt/FileSystemQt.cpp:

664 665 666 667 668 669 670 671 672 673
2008-05-13  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        For Gtk/X11 and Qt/X11, use a more extensive plug-ins scan directories set

        * plugins/PluginDatabase.cpp:
        (WebCore::addMozillaPluginDirectories):
        (WebCore::PluginDatabase::isPreferredPluginDirectory):

674 675 676 677 678 679 680 681 682 683
2008-05-12  Adam Roben  <aroben@apple.com>

        Turn on warnings as errors in WebCore.vcproj

        Rubberstamped by Anders Carlsson.

        * WebCore.vcproj/WebCore.vcproj: Also let VS reformat the file as it
        saw fit. The important part is the removal of the WarnAsError="false"
        lines.

weinig@apple.com's avatar
weinig@apple.com committed
684 685 686 687 688 689 690 691 692 693 694 695
2008-05-09  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18958
        NULL pointer dereference in NamedAttrMap::setNamedItem

        Test: fast/dom/NamedNodeMap-setNamedItem-crash.html

        * dom/NamedAttrMap.cpp:
        (WebCore::NamedAttrMap::setNamedItem): Null check the argument.

696 697 698 699 700 701 702
2008-05-09  Kevin McCullough  <kmccullough@apple.com>

        Build fix.

        * page/Console.cpp:
        (WebCore::Console::profile):

weinig@apple.com's avatar
weinig@apple.com committed
703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731
2008-05-09  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Mark Rowe.

        Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.

        * Configurations/WebCore.xcconfig:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/build-generated-files.sh:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::customGetOwnPropertySlot):
        (WebCore::JSDOMWindow::postMessage):
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/objc/DOMEvents.mm:
        (+[DOMEvent _wrapEvent:WebCore::]):
        * dom/Document.cpp:
        (WebCore::Document::createEvent):
        * dom/Event.cpp:
        (WebCore::Event::isMessageEvent):
        * dom/Event.h:
        * dom/MessageEvent.cpp:
        * dom/MessageEvent.h:
        * dom/MessageEvent.idl:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::postMessageTimerFired):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

weinig@apple.com's avatar
weinig@apple.com committed
732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748
2008-05-09  Adam Barth  <abarth-webkit@adambarth.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=18771

        Make postMessage generate an event on the window instead of the
        document.

        Test: http/tests/messaging/cross-domain-message-event-dispatch.html

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchWindowEvent):
        * dom/EventTargetNode.h:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::postMessageTimerFired):

749 750 751 752 753 754 755 756 757 758
2008-05-09  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Replaced all instances of qDebug() with LOG(Media, ...)
        in MediaPlayerPrivatePhonon.

        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
        (WebCore::MediaPlayerPrivate::updateStates):

759 760 761 762 763 764 765 766
2008-05-09  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Fix the Qt/Mac build.

        * platform/qt/FileSystemQt.cpp:

767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790
2008-05-08  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Rename the XMLHttpRequestState enum values to match the spec.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::responseXML):
        (WebCore::XMLHttpRequest::XMLHttpRequest):
        (WebCore::XMLHttpRequest::callReadyStateChangeListener):
        (WebCore::XMLHttpRequest::open):
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::abort):
        (WebCore::XMLHttpRequest::setRequestHeader):
        (WebCore::XMLHttpRequest::getAllResponseHeaders):
        (WebCore::XMLHttpRequest::getResponseHeader):
        (WebCore::XMLHttpRequest::status):
        (WebCore::XMLHttpRequest::statusText):
        (WebCore::XMLHttpRequest::processSyncLoadResults):
        (WebCore::XMLHttpRequest::didFinishLoading):
        (WebCore::XMLHttpRequest::didReceiveData):
        * xml/XMLHttpRequest.h:
        (WebCore::):

mitz@apple.com's avatar
mitz@apple.com committed
791 792 793 794 795 796 797 798 799 800 801 802 803 804
2008-05-08  Dan Bernstein  <mitz@apple.com>

        Reviewed by Mark Rowe.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18818
          <rdar://problem/5901544> REGRESSION (3.1.1-TOT): Character order (float:left ordered after the first letter)

        Test: fast/css/first-letter-float-after-float.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter): Changed to add the first
        letter container right before the rest of the text it is taken from,
        instead of at the beginning of the block.

805 806 807 808 809 810 811 812 813 814
2008-05-08  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5921046> AX: list box options have wrong AXPosition

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::documentFrameView):
        * page/AccessibilityObject.h:

815 816 817 818 819 820 821 822 823 824 825 826 827
2008-05-08  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Bug 18916: make_names.pl --factory needs to support custom c++ guard

        Add --guardFactoryWith to handle the cpp guard around generated factories.

        * DerivedSources.make: Set the guardFactoryWith variable for SVG factory.
        * GNUmakefile.am: Ditto.
        * WebCore.pro: Ditto.
        * dom/make_names.pl: Add guardFactoryWith option.

828 829 830 831 832 833 834 835 836 837 838 839 840 841
2008-05-08  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Adam Roben.

        wx & Gtk build fix.

        Should also fix the cURL backend for the Windows port.

        * WebCore.vcproj/WebCore.vcproj: Add FormDataStreamCurl information.
        * platform/network/curl/FormDataStreamCurl.h: Include stdio.h which
        fixes the build on some machine.

        * webcore-wx.bkl: Add FormDataStreamCurl.cpp.

842 843 844 845 846 847 848 849 850 851 852
2008-05-08  Timothy Hatcher  <timothy@apple.com>

        Fixes the bug where the Web Inspector could not
        find any localization strings.

        Reviewed by Mark Rowe.

        * WebCore.xcodeproj/project.pbxproj: Add the localizedStrings.js
        file to the WebCore Copy Resources phase. Also removes an idl from
        the Copy Resources phase.

mitz@apple.com's avatar
mitz@apple.com committed
853 854 855 856 857 858 859 860 861 862
2008-05-08  Dan Bernstein  <mitz@apple.com>

        Reviewed by Adam Roben.

        - fix <rdar://problem/5697957> "No recent searches" label in a narrow search field's history popup is truncated

        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::calculatePositionAndSize): Changed to use a bold
        font for measuring labels.

mitz@apple.com's avatar
mitz@apple.com committed
863 864 865 866 867 868 869 870 871 872
2008-05-08  Dan Bernstein  <mitz@apple.com>

        Reviewed by Geoffrey Garen.

        - cross-platform fix for http://bugs.webkit.org/show_bug.cgi?id=17590 
          ASSERTION FAILED: subject in jsRegExpExecute()

        * page/Frame.cpp:
        (WebCore::Frame::matchLabelsAgainstElement):

873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895
2008-05-08  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        Simple ImageBuffer::image implementation.

        In contrast to cg and cairo we do not use a special BitmapImage because
        the ownership of the FrameData inside the BitmapImage is a bit backward
        (actually owned by the ImageDecoderQt...). Further work is needed for image
        and pixmap handling in the qt port...

        * WebCore.pro:
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::ImageBuffer::image):
        * platform/graphics/qt/ImageQt.cpp:
        * platform/graphics/qt/StillImageQt.cpp: Added.
        (WebCore::StillImage::StillImage):
        (WebCore::StillImage::size):
        (WebCore::StillImage::getPixmap):
        (WebCore::StillImage::draw):
        * platform/graphics/qt/StillImageQt.h: Added.

896 897 898 899 900 901 902 903
2008-05-08  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        Update the WebKit.qrc of the inspector to be functional again

        * page/inspector/WebKit.qrc:

904 905 906 907 908 909 910 911
2008-05-08  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Fix the Qt/Mac build.

        * platform/FileSystem.h:

912 913 914 915 916 917 918 919 920 921 922 923
2008-05-08  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Use native Windows library handling (instead of QLibrary) 
        for Qt/Win32's PlatformModule.

        * platform/FileSystem.h:
        (WebCore::PlatformModuleVersion::PlatformModuleVersion):
        * platform/qt/FileSystemQt.cpp:
        (WebCore::unloadModule):

924 925 926 927 928 929 930 931 932
2008-05-08  Simon Hausmann  <hausmann@webkit.org>

        Reviewed and found by Holger.

        Include .css in the list of extensions for text/css. Fixes
        fast/loader/local-css-allowed-in-strict-mode.html.

        * platform/qt/MIMETypeRegistryQt.cpp:

933 934 935 936 937 938 939
2008-05-08  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt and Wx build when compiling without offline app support.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::canCachePage):

940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955
2008-05-07  Sam Weinig  <sam@webkit.org>

        Reviewed by Adele Peterson

        Update MessageEvent to match the latest version of the HTML5 spec,
        adding the lastEventId attribute.

        * dom/MessageEvent.cpp:
        (WebCore::MessageEvent::MessageEvent):
        (WebCore::MessageEvent::initMessageEvent):
        * dom/MessageEvent.h:
        (WebCore::MessageEvent::lastEventId):
        * dom/MessageEvent.idl:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::postMessage):

956 957 958 959 960 961 962 963 964 965 966 967 968 969 970
2008-05-07  Stephanie Lewis <slewis@apple.com>

        Reviewed by Maciej.

        remove non-functioning code.  If onunload should be fired from these nodes then
        a WindowEventListener needs to be set.  However, Firefox and IE also do not
        fire onunload events for these cases.

        Test: fast/events/onunload-not-on-body.html 
        
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::parseMappedAttribute):
        * html/HTMLObjectElement.cpp
        (WebCore::HTMLObjectElement::parseMappedAttribute):

mitz@apple.com's avatar
mitz@apple.com committed
971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987
2008-05-07  Dan Bernstein  <mitz@apple.com>

        Reviewed by John Sullivan.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18909
          <rdar://problem/5914165> REGRESSION (r31872-r31878): Viewed photos not closing completely at indycar.com

        Test: fast/dynamic/positioned-movement-with-positioned-children.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutOnlyPositionedObjects): Cover the case of
        a positioned object that has only moved and has only positioned children
        that have changed.
        * rendering/RenderObject.h:
        (WebCore::RenderObject::needsPositionedMovementLayout): Added this
        accessor.

988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007
2008-05-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by John.

        When no document loaders are associated with an application cache group,
        release the reference to the newest cache group. This prevents reference cycles.
        
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
        (WebCore::ApplicationCacheGroup::documentLoaderDestroyed):
        (WebCore::ApplicationCacheGroup::cacheDestroyed):
        * loader/appcache/ApplicationCacheGroup.h:
        
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::cacheGroupForURL):
        Return early if the datbase wasn't open.
        
        (WebCore::ApplicationCacheStorage::loadCache):
        Add error.

1008 1009 1010 1011 1012 1013 1014 1015 1016
2008-05-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Don't put pages with an application cache in the BF cache.
        
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::canCachePage):

justin.garcia@apple.com's avatar
justin.garcia@apple.com committed
1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034
2008-05-07  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/5666354> Crashes in Mail at WebCore::RemoveNodeCommand::doApply
        
        When a single tab or series of tabs was copied, we weren't putting them into a 
        tab span.  On Paste, we would be given a text node with a single tab or series
        of tabs in it, and we would crash when inserting it at the start of a block
        (where that kind of text becomes completely unrendered).

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Clean
        up correctly and early return if we removed everything that was inserted.
        * editing/markup.cpp:
        (WebCore::createMarkup):  Include the tab span when the only thing copied
        was a tab or a series of tabs.

1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046
2008-05-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Adam Roben.

        wx & Gtk build fix.

        * platform/network/curl/FormDataStreamCurl.cpp: Added stdint.h include. We need to define
        __STDC_LIMIT_MACROS to have SIZE_MAX exported.
        * platform/network/curl/FormDataStreamCurl.h: Removed cstdint include (replaced by stdint.h)
        as it is not present on the build bots.
        * plugins/gtk/PluginDatabaseGtk.cpp: Added missing #endif.

ddkilzer@apple.com's avatar
ddkilzer@apple.com committed
1047 1048 1049 1050
2008-05-07  David Kilzer  <ddkilzer@apple.com>

        Bug 18900: Password field has focus but can't type text (i.rememberthemilk.com)
        <https://bugs.webkit.org/show_bug.cgi?id=18900>
1051
        <rdar://problem/5912383>
ddkilzer@apple.com's avatar
ddkilzer@apple.com committed
1052 1053 1054 1055 1056 1057 1058 1059 1060 1061

        Original patch by Aaron Golden and Tim Omernick.  Reviewed by Adele.

        Test: fast/forms/textfield-to-password-on-focus.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType): If the current node has
        focus, call updateFocusAppearance() to make sure its state is correct
        after changing its type.

1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081
2008-05-07  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Alice Liu

        <rdar://problem/4867889> REGRESSION: "Choose File.." buttons are exposed as AXGroup instead of AXButton

        * page/AccessibilityObject.h:
        (WebCore::AccessibilityObject::isFileUploadButton):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isFileUploadButton):
        (WebCore::AccessibilityRenderObject::actionElement):
        (WebCore::AccessibilityRenderObject::textUnderElement):
        (WebCore::AccessibilityRenderObject::stringValue):
        (WebCore::AccessibilityRenderObject::roleValue):
        * page/AccessibilityRenderObject.h:
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::buttonValue):
        (WebCore::RenderFileUploadControl::fileTextValue):
        * rendering/RenderFileUploadControl.h:

1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107
2008-05-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Bug 17971: [Curl] FormData processing should be moved to its own class

        Move FormData treatment into FormDataStream. The aim is to have FormDataStream behave like a stream that cURL
        could manipulate.

        First step into having complete file uploading facility in cURL.

        No test case as it is only code refactoring.

        * GNUmakefile.am: Add FormDataStreamCurl.cpp
        * platform/network/ResourceHandleInternal.h: Move code to FormStreamDataCurl.h
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/curl/FormDataStreamCurl.cpp: Added.
        (WebCore::FormDataStream::~FormDataStream):
        (WebCore::FormDataStream::read):
        * platform/network/curl/FormDataStreamCurl.h: Added.
        (WebCore::FormDataStream::FormDataStream):
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::readCallback): Move code to FormDataStreamCurl.cpp

1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119
2008-05-07  Adam Treat  <treat@kde.org>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=18898

        Fixed wrong transform being used for creating the pixmap for a new
        transparency layer. This fixes the popup menus on dell.com.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::beginTransparencyLayer):

1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135
2008-05-07  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Share the plug-in directories between Gtk and Qt/X11 port.

        * platform/qt/FileSystemQt.cpp:
        (WebCore::homeDirectoryPath): Implement it for Qt.
        * plugins/PluginDatabase.cpp:
        (WebCore::addMozillaPluginDirectories): Shared code.
        (WebCore::PluginDatabase::defaultPluginDirectories):
        (WebCore::PluginDatabase::isPreferredPluginDirectory): Shared code.
        * plugins/gtk/PluginDatabaseGtk.cpp:
        (WebCore::PluginDatabase::isPreferredPluginDirectory): Refactored.
        * plugins/qt/PluginDatabaseQt.cpp: Refactored.

1136 1137 1138 1139 1140 1141 1142 1143 1144 1145
2008-05-07  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Fix build issues on Mac and refeactor the .pro file a bit.

        * WebCore.pro:
        * platform/qt/TemporaryLinkStubs.cpp:
        (PluginPackage::fetchInfo):

1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157
2008-05-07  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Draw scrollview corners (between scrollbars) using the Qt style.

        https://bugs.webkit.org/show_bug.cgi?id=18894

        * platform/qt/ScrollViewQt.cpp:
        (WebCore::drawScrollbarCorner):
        (WebCore::ScrollView::paint):

1158 1159 1160 1161 1162 1163 1164
2008-05-07  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt build, added AccessibilityListBox and ListBoxOption.cpp to
        the build.

        * WebCore.pro:

1165 1166 1167 1168 1169 1170 1171 1172 1173
2008-05-07  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Holger.

        Fix building without storage support.

        * page/PageGroup.cpp:
        (WebCore::PageGroup::closeLocalStorage): proper #if

1174 1175 1176 1177 1178 1179 1180 1181 1182
2008-05-07  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Oliver Hunt.

        Fix building without accessibility.

        * page/AXObjectCache.cpp:
        (WebCore::AXObjectCache::selectedChildrenChanged): proper #if

mitz@apple.com's avatar
mitz@apple.com committed
1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193
2008-05-06  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        - fix <rdar://problem/5914544> Crash in layoutInlineChildren()

        Test: fast/block/float/float-on-zero-height-line.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::markLinesDirtyInVerticalRange):

alice.liu@apple.com's avatar
alice.liu@apple.com committed
1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216
2008-05-06  Alice Liu  <alice.liu@apple.com>

        Reviewed by Adele Peterson and John Sullivan.

        changes needed to build on Windows after r32911 and r32927

        * WebCore.vcproj/WebCore.vcproj:
        * page/AXObjectCache.cpp:
        (WebCore::AXObjectCache::selectedChildrenChanged):
        * page/AccessibilityObject.h:
        (WebCore::AccessibilityObject::document):
        (WebCore::AccessibilityObject::topDocumentFrameView):
        (WebCore::AccessibilityObject::documentFrameView):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::document):
        (WebCore::AccessibilityRenderObject::topDocumentFrameView):
        (WebCore::AccessibilityRenderObject::documentFrameView):
        * page/AccessibilityRenderObject.h:
        * page/mac/AXObjectCacheMac.mm:
        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper position]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Fix a few bugs with the final sync'ing of LocalStorageAreas when the thread is shut down.
        1 - A sync task actually needs to be scheduled for each LocalStorageArea when the shut down occurs.
        2 - Pending sync timers all need to be cancelled.

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea):
        (WebCore::LocalStorage::close): Tell each LocalStorageArea to schedule it's final sync before scheduling
          thread termination.
        * storage/LocalStorage.h:  Change the map to be of LocalStorageAreas instead of StorageAreas

        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::LocalStorageArea):
        (WebCore::LocalStorageArea::~LocalStorageArea): ASSERT the timer has been cancelled, but make SURE it is
          in release builds.
        (WebCore::LocalStorageArea::scheduleFinalSync): Cancel the sync timer, schedule the final sync, and set the
          "final sync scheduled" flag
        (WebCore::LocalStorageArea::scheduleItemForSync): ASSERT that the final sync hasn't already been scheduled
        (WebCore::LocalStorageArea::scheduleClear): Ditto
        * storage/LocalStorageArea.h:

1241 1242 1243 1244 1245 1246
2008-05-06  Kevin Ollivier  <kevino@theolliviers.com>

        wx build fix. Adding files added in  r32925 to the bakefiles.

        * WebCoreSources.bkl:

1247 1248 1249 1250 1251 1252 1253
2008-05-06  Alp Toker  <alp@nuanti.com>

        GTK+ build fix. Add empty stub to keep non-accessible ports building.

        * page/AXObjectCache.h:
        (WebCore::AXObjectCache::selectedChildrenChanged):

1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298
2008-05-06  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin.

        Fix for <rdar://problem/5907916> Implement 'aria-labeledby' and 
        'aria-describedby' attributes.

        * html/HTMLAttributeNames.in: Added new attributes. Added both the 
        British spelling (since that is what is specified in the spec), and 
        the American spelling (since the bug filer and I are two Americans 
        who keep spelling it the American way by accident). 
        * page/AccessibilityObject.cpp: Added empty wrappers. These 
        functions can't do anything meaningful without a renderer.
        (WebCore::AccessibilityObject::ariaAccessiblityName):
        (WebCore::AccessibilityObject::ariaLabeledByAttribute):
        (WebCore::AccessibilityObject::ariaDescribedByAttribute):
        * page/AccessibilityObject.h:

        Here is where the real work is done.
        * page/AccessibilityRenderObject.h:
        * page/AccessibilityRenderObject.cpp:
        (WebCore::accessibleNameForNode): Takes a node and finds its 
        contribution to the accessible name, as defined by the Mozilla ARIA 
        Implementer's Guide. 
        (WebCore::AccessibilityRenderObject::ariaAccessiblityName): Takes a 
        string of space-separated IDs, fetches the corresponding element 
        for each ID, and concatenates an accessible name based on the 
        elements.
        (WebCore::AccessibilityRenderObject::ariaLabeledByAttribute): 
        Retrieve the labeledby attribute and send its contents to 
        ariaAccessibilityName().
        (WebCore::AccessibilityRenderObject::title): Return the ARIA 
        labeledby value if one exists.
        (WebCore::AccessibilityRenderObject::ariaDescribedByAttribute): 
        Retrieve the describedby attribute and send its contents to 
        ariaAccessibilityName().
        (WebCore::AccessibilityRenderObject::accessibilityDescription): 
        Return the ARIA describedby attribute if one exists. 

        These are two bugs I spotted. 
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Don't 
        ignore anything with an ARIA role.
        (WebCore::AccessibilityRenderObject::roleValue): Button tags maps 
        to ButtonRole.

1299 1300 1301 1302
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

andersca@apple.com's avatar
andersca@apple.com committed
1303
        Support reading back app caches from the database.
1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341
    
        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::ApplicationCache):
        Initialize m_storageID to 0.
        
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::cacheDestroyed):
        If the cache being destroyed is not the newest cache, it should no longer be 
        stored in the database. Remove it.
        
        (WebCore::ApplicationCacheGroup::setNewestCache):
        Don't store the cache here.
        
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
        Store it here instead.
        
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::loadCacheGroup):
        New method that loads a cache group with a given manifest URL (or returns 0 if the load fails).
        
        (WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
        Search for the group in the database.
        
        (WebCore::ApplicationCacheStorage::loadManifestHostHashes):
        New method that loads the host hashes from the database.
        
        (WebCore::ApplicationCacheStorage::cacheGroupForURL):
        Search in the database for a cache that contains the resource.
        
        (WebCore::ApplicationCacheStorage::loadCache):
        New method that loads a cache with a given ID.
        
        (WebCore::ApplicationCacheStorage::remove):
        New method that removes a cache.
        
        * loader/appcache/ApplicationCacheStorage.h:
        Add definitions.

1342 1343 1344 1345 1346 1347 1348 1349 1350
2008-05-06  Alp Toker  <alp@nuanti.com>

        Partial GTK+ build fix. Add files from r32925 to the build and replace
        'nil' return with 0.

        * GNUmakefile.am:
        * page/AccessibilityListBoxOption.cpp:
        (WebCore::AccessibilityListBoxOption::parentObject):

1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Make LocalStorage persistent using a SQLite database.

        There's a few things going on here.  Whenever an item is changed, we add it to a set of
        "items to be sync'ed."  Instead of immediately scheduling the sync'ing on the background
        thread, we set a "sync timer" instead.  This is to shield against a series of rapid changes
        to avoid thread churn.

        When the sync timer fires, we move the "items to be sync'ed" set to a background thread set
        and schedule the sync task which is where the items are actually committed to disk.

        Current design for reading items back in from disk is to be as aggressive as possible.
        When a page first accesses it's LocalStorage area, we begin to import all items in from disk so
        they are immediately available.  A future enhancement will be to being this pre-fetching the
        moment we start loading a page when we know that page has LocalStorage.

        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::LocalStorageArea):
        (WebCore::LocalStorageArea::length): Return the length, or wait for the import to complete then return it.
        (WebCore::LocalStorageArea::key): Return the key, or wait for the import to complete then return it.
        (WebCore::LocalStorageArea::getItem): Return the item, or wait for the import to complete then return it.
        (WebCore::LocalStorageArea::setItem): Set the item, or hold the import lock and set it.  The second case is
          because if the item is set while the import is still in progress, the new value should override whatever
          the imported value is.
        (WebCore::LocalStorageArea::removeItem): Remove the item, or hold the import lock and remove it.  See the 
          explanation for setItem()
        (WebCore::LocalStorageArea::contains): Return whether or not the item is contained.  Do the same dance with
          the import flag, import lock, and import condition that the above methods do.

        (WebCore::LocalStorageArea::itemChanged): Schedule the item for sync'ing
        (WebCore::LocalStorageArea::itemRemoved): Schedule the removal of the item for sync'ing
        (WebCore::LocalStorageArea::areaCleared): Schedule the clear for sync'ing, and clear all previously 
          scheduled items.

        (WebCore::LocalStorageArea::scheduleItemForSync): Add an item to the sync set.
        (WebCore::LocalStorageArea::scheduleClear): Set a bool flag denoting "All items removed."  If any
          items are later set before the actual removal takes place, they will be written *after* the removal.
        (WebCore::LocalStorageArea::syncTimerFired): Move the current sync-set to the background thread sync set, then 
          schedule a sync task.  Also transfer the "items cleared" flag to the "background thread items cleared" flag
        (WebCore::LocalStorageArea::performImport): Import all items from disk, then signal the import complete.
        (WebCore::LocalStorageArea::markImported): Set the imported flag and signal the import complete
        (WebCore::LocalStorageArea::performSync): If the clear flag is set then drop all items.  Then update or delete 
          each item waiting to be sync'ed
        * storage/LocalStorageArea.h:

1399 1400 1401 1402 1403 1404 1405
2008-05-06  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Mitz Pettel RTL

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::fullDatabaseFilename): Filename extensions for localstorage = all lowercase

1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin, Sam Weinig, and Anders

        Preparation for upcoming work making LocalStorage persistent.

        The final step before code that actually does storage and retrieval of LocalStorage items.

        The LocalStorage set is responsible for controlling the path and filenames that individual
        LocalStorageAreas will use for their persistent store.  This adds the ability to return that
        filename.

        Also, add the scheduling methods that LocalStorageArea will use for importing and syncing 
        it's persistent items.

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea):  Add some comments re: the future direction of this
          method once we actually do quota tracking.
        (WebCore::LocalStorage::fullDatabaseFilename):
        (WebCore::LocalStorage::scheduleImport):
        (WebCore::LocalStorage::scheduleSync):
        * storage/LocalStorage.h:

1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497
2008-05-06  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        rdar://problem/5408464> REGRESSION: Unable to use Voiceover on combo boxes (disneyjobs.com)

        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLOptGroupElement.cpp:
        (WebCore::HTMLOptGroupElement::ownerSelectElement):
        (WebCore::HTMLOptGroupElement::accessKeyAction):
        * html/HTMLOptGroupElement.h:
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::accessKeyAction):
        (WebCore::HTMLOptionElement::index):
        (WebCore::HTMLOptionElement::setSelected):
        (WebCore::HTMLOptionElement::childrenChanged):
        (WebCore::HTMLOptionElement::ownerSelectElement):
        (WebCore::HTMLOptionElement::insertedIntoDocument):
        * html/HTMLOptionElement.h:
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::childrenChanged):
        (WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
        * html/HTMLSelectElement.h:
        * page/AXObjectCache.cpp:
        (WebCore::AXObjectCache::get):
        * page/AccessibilityListBox.cpp: Added.
        (WebCore::AccessibilityListBox::AccessibilityListBox):
        (WebCore::AccessibilityListBox::~AccessibilityListBox):
        (WebCore::AccessibilityListBox::create):
        (WebCore::AccessibilityListBox::addChildren):
        (WebCore::AccessibilityListBox::selectedChildren):
        (WebCore::AccessibilityListBox::visibleChildren):
        (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):
        (WebCore::AccessibilityListBox::doAccessibilityHitTest):
        * page/AccessibilityListBox.h: Added.
        (WebCore::AccessibilityListBox::accessibilityShouldUseUniqueId):
        (WebCore::AccessibilityListBox::isListBox):
        (WebCore::AccessibilityListBox::canSetFocusAttribute):
        (WebCore::AccessibilityListBox::roleValue):
        (WebCore::AccessibilityListBox::accessibilityIsIgnored):
        * page/AccessibilityListBoxOption.cpp: Added.
        (WebCore::AccessibilityListBoxOption::AccessibilityListBoxOption):
        (WebCore::AccessibilityListBoxOption::~AccessibilityListBoxOption):
        (WebCore::AccessibilityListBoxOption::create):
        (WebCore::AccessibilityListBoxOption::isEnabled):
        (WebCore::AccessibilityListBoxOption::isSelected):
        (WebCore::AccessibilityListBoxOption::elementRect):
        (WebCore::AccessibilityListBoxOption::title):
        (WebCore::AccessibilityListBoxOption::size):
        (WebCore::AccessibilityListBoxOption::actionElement):
        (WebCore::AccessibilityListBoxOption::parentObject):
        (WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
        (WebCore::AccessibilityListBoxOption::listBoxOptionIndex):
        * page/AccessibilityListBoxOption.h: Added.
        (WebCore::AccessibilityListBoxOption::setHTMLElement):
        (WebCore::AccessibilityListBoxOption::roleValue):
        (WebCore::AccessibilityListBoxOption::accessibilityIsIgnored):
        (WebCore::AccessibilityListBoxOption::isListBoxOption):
        * page/AccessibilityObject.h:
        (WebCore::AccessibilityObject::isListBox):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::selectionChanged):
        * rendering/RenderListBox.h:

1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508
2008-05-06  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

         <rdar://problem/5455287> AXWebArea should include AXURL

        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::url):
        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):

1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519
2008-05-06  Alice Liu  <alice.liu@apple.com>

        Rubber-stamped by Beth
        
        stab-in-the-dark attempt at fixing non-mac builds.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCoreSources.bkl:

1520 1521 1522 1523 1524 1525 1526 1527 1528
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Only use the toplevel application cache when loading subframes.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::load):

weinig@apple.com's avatar
weinig@apple.com committed
1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552
2008-05-06  Adam Barth  <abarth-webkit@adambarth.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=18725
        Implement asynchronous postMessage.
        MessageEvent no longer bubbles as per r1237 in the HTML 5 working draft.

        Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.

        Test: http/tests/security/postMessage/delivery-order.html

        * dom/MessageEvent.cpp:
        (WebCore::MessageEvent::MessageEvent):
        * page/DOMWindow.cpp:
        (WebCore::PostMessageTimer::PostMessageTimer):
        (WebCore::PostMessageTimer::event):
        (WebCore::PostMessageTimer::targetOrigin):
        (WebCore::PostMessageTimer::fired):
        (WebCore::DOMWindow::postMessage):
        (WebCore::DOMWindow::postMessageTimerFired):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        
1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        Store cache to the database.

        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::addResource):
        If the cache has been saved to disk, save the resource as well.
        
        * loader/appcache/ApplicationCache.h:
        (WebCore::ApplicationCache::onlineWhitelist):
        New method which returns the online whitelist.

        (WebCore::ApplicationCache::setStorageId):
        (WebCore::ApplicationCache::storageId):
        Setter/getter for the application cache storage ID.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
        Save the cache/group to disk.
        
        * loader/appcache/ApplicationCacheGroup.h:
        (WebCore::ApplicationCacheGroup::setStorageID):
        (WebCore::ApplicationCacheGroup::storageID):
        Setter/getter for the application cache group storage ID.
        
        * loader/appcache/ApplicationCacheResource.cpp:
        (WebCore::ApplicationCacheResource::addType):
        We can't add a new type if the resource has been saved to disk.
        
        * loader/appcache/ApplicationCacheResource.h:
        (WebCore::ApplicationCacheResource::setStorageID):
        (WebCore::ApplicationCacheResource::storageID):
        Setter/getter for the application cache resource storage ID.

        * loader/appcache/ApplicationCacheStorage.cpp:
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::executeSQLCommand):
        New method for executing SQL and logging any errors.
        
        (WebCore::ApplicationCacheStorage::openDatabase):
        Create new tables.
        
        (WebCore::ApplicationCacheStorage::executeStatement):
        New method for executing an SQL statement and logging any errors.
        
        (WebCore::ApplicationCacheStorage::store):
        New methods for storing a cache group, cache and cache resource to the store.

        (WebCore::ApplicationCacheStorage::storeNewestCache):
        New method which stores the newest cache and updates the newest cache field in the cache group.
        
        * loader/appcache/ApplicationCacheStorage.h:
        Add new methods.
        
        * platform/sql/SQLiteStatement.h:
        (WebCore::SQLiteStatement::query):
        Getter for the SQL query.

1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Preparation for upcoming work making LocalStorage persistent.

        Writing persistent values for LocalStorage will take place on a background thread.
        Here is that background thread, as well as most of the hooks that will be utilized to
        make the whole song and dance work.

        The thread itself is very simple and MessageQueue based.  LocalStorageTasks are what 
        mark the work that needs to be done and come in 5 flavors:  Import and Sync a LocalStorage set,
        Import and Sync a LocalStorageArea, and terminate the thread.

        This patch accomplished 2 things:
        
        1 - Each PageGroup has its own LocalStorage set.  Upon its creation its LocalStorageThread is 
            created and started.

        2 - At application shutdown, each thread is synchronously terminated.

        What happens between steps 1 and 2 will come later.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:

        * storage/LocalStorage.cpp: Add some threading ASSERTs to make it clear which thread each
          method is meant to be called from.
        (WebCore::LocalStorage::LocalStorage):
        (WebCore::LocalStorage::storageArea):
        (WebCore::LocalStorage::performImport): Placeholder for importing known origins and quotas
        (WebCore::LocalStorage::performSync): Placeholder for writing out updated origins and quotas
        (WebCore::LocalStorage::close): Synchronously terminate the thread.
        * storage/LocalStorage.h:

        * storage/LocalStorageArea.cpp: Add some threading ASSERTs to make it clear which thread each
          method is meant to be called from.
        (WebCore::LocalStorageArea::itemChanged):
        (WebCore::LocalStorageArea::itemRemoved):
        (WebCore::LocalStorageArea::areaCleared):
        (WebCore::LocalStorageArea::dispatchStorageEvent):
        (WebCore::LocalStorageArea::performImport): Placeholder for importing all items for this 
          LocalStorageArea to prime the page before the items are needed
        (WebCore::LocalStorageArea::performSync): Placeholder for writing out dirty items to disk
        * storage/LocalStorageArea.h:

        * storage/LocalStorageTask.cpp: Added.
        (WebCore::LocalStorageTask::LocalStorageTask):
        (WebCore::LocalStorageTask::performTask):
        * storage/LocalStorageTask.h: Added.
        (WebCore::LocalStorageTask::):
        (WebCore::LocalStorageTask::createImport):
        (WebCore::LocalStorageTask::createSync):
        (WebCore::LocalStorageTask::createTerminate):

        * storage/LocalStorageThread.cpp: Added.
        (WebCore::LocalStorageThread::create):
        (WebCore::LocalStorageThread::LocalStorageThread):
        (WebCore::LocalStorageThread::start):
        (WebCore::LocalStorageThread::localStorageThreadStart):
        (WebCore::LocalStorageThread::localStorageThread):
        (WebCore::LocalStorageThread::scheduleImport):
        (WebCore::LocalStorageThread::scheduleSync):
        (WebCore::LocalStorageThread::terminate): 
        (WebCore::LocalStorageThread::performTerminate):
        * storage/LocalStorageThread.h: Added.

1683 1684 1685 1686 1687 1688 1689 1690 1691
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add NPN_PopUpContextMenu.
        
        * bridge/npapi.h:
        * plugins/npfunctions.h:

1692 1693 1694 1695 1696 1697
2008-05-06  Alp Toker  <alp@nuanti.com>

        GTK+ build fix. Add file from r32911 to the build.

        * GNUmakefile.am:

1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708
2008-05-06  Gwenole Beauchesne  <gbeauchesne@splitted-desktop.org>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18906
        [GTK] Fix varargs terminator in g_build_filename()

        * plugins/gtk/PluginDatabaseGtk.cpp:
        (WebCore::PluginDatabase::isPreferredPluginDirectory): Fix varargs
        terminator.

1709 1710 1711 1712 1713 1714
2008-05-06  Kevin McCullough  <kmccullough@apple.com>

        - Forgot to update localized Strings from previous checkin.

        * English.lproj/localizedStrings.js:

1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966
2008-05-06  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin

        <rdar://problem/5408464> REGRESSION: Unable to use Voiceover on combo boxes (disneyjobs.com)
        <rdar://problem/5895634> AX: AccessibilityObjectWrapper is being leaked all over the place
        <rdar://problem/5893907> CrashTracer: [REGRESSION] 44 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityObject::clearChildren + 9
        
        Initial prep work to support accessibility objects that do not have renderers. 

        * WebCore.xcodeproj/project.pbxproj:
        * page/AXObjectCache.cpp:
        (WebCore::AXObjectCache::~AXObjectCache):
        (WebCore::AXObjectCache::get):
        (WebCore::AXObjectCache::remove):
        (WebCore::AXObjectCache::getAXID):
        (WebCore::AXObjectCache::removeAXID):
        (WebCore::AXObjectCache::childrenChanged):
        * page/AXObjectCache.h:
        (WebCore::AXObjectCache::isIDinUse):
        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::AccessibilityObject):
        (WebCore::AccessibilityObject::create):
        (WebCore::AccessibilityObject::detach):
        (WebCore::AccessibilityObject::firstChild):
        (WebCore::AccessibilityObject::lastChild):
        (WebCore::AccessibilityObject::previousSibling):
        (WebCore::AccessibilityObject::nextSibling):
        (WebCore::AccessibilityObject::parentObject):
        (WebCore::AccessibilityObject::layoutCount):
        (WebCore::AccessibilityObject::text):
        (WebCore::AccessibilityObject::helpText):
        (WebCore::AccessibilityObject::textUnderElement):
        (WebCore::AccessibilityObject::isARIAInput):
        (WebCore::AccessibilityObject::isARIAControl):
        (WebCore::AccessibilityObject::intValue):
        (WebCore::AccessibilityObject::stringValue):
        (WebCore::AccessibilityObject::title):
        (WebCore::AccessibilityObject::accessibilityDescription):
        (WebCore::AccessibilityObject::boundingBoxRect):
        (WebCore::AccessibilityObject::elementRect):
        (WebCore::AccessibilityObject::size):
        (WebCore::AccessibilityObject::linkedUIElement):
        (WebCore::AccessibilityObject::textLength):
        (WebCore::AccessibilityObject::ariaSelectedTextDOMRange):
        (WebCore::AccessibilityObject::selectedText):
        (WebCore::AccessibilityObject::accessKey):
        (WebCore::AccessibilityObject::selection):
        (WebCore::AccessibilityObject::selectedTextRange):
        (WebCore::AccessibilityObject::setSelectedTextRange):
        (WebCore::AccessibilityObject::url):
        (WebCore::AccessibilityObject::setFocused):
        (WebCore::AccessibilityObject::setValue):
        (WebCore::AccessibilityObject::axObjectCache):
        (WebCore::AccessibilityObject::getDocumentLinks):
        (WebCore::AccessibilityObject::widget):
        (WebCore::AccessibilityObject::widgetForAttachmentView):
        (WebCore::AccessibilityObject::anchorElement):
        (WebCore::AccessibilityObject::actionElement):
        (WebCore::AccessibilityObject::visiblePositionRange):
        (WebCore::AccessibilityObject::doAXTextMarkerRangeForLine):
        (WebCore::AccessibilityObject::visiblePositionForIndex):
        (WebCore::AccessibilityObject::indexForVisiblePosition):
        (WebCore::AccessibilityObject::doAXBoundsForTextMarkerRange):
        (WebCore::AccessibilityObject::doSetAXSelectedTextMarkerRange):
        (WebCore::AccessibilityObject::doAXTextMarkerForPosition):
        (WebCore::AccessibilityObject::textMarkerForIndex):
        (WebCore::AccessibilityObject::rangeForTextMarkerRange):
        (WebCore::AccessibilityObject::indexForTextMarker):
        (WebCore::AccessibilityObject::doAXRangeForLine):
        (WebCore::AccessibilityObject::doAXRangeForPosition):
        (WebCore::AccessibilityObject::doAXRangeForIndex):
        (WebCore::AccessibilityObject::doAXStyleRangeForIndex):
        (WebCore::AccessibilityObject::doAXStringForRange):
        (WebCore::AccessibilityObject::doAXBoundsForRange):
        (WebCore::AccessibilityObject::doAccessibilityHitTest):
        (WebCore::AccessibilityObject::focusedUIElement):
        (WebCore::AccessibilityObject::observableObject):
        (WebCore::AccessibilityObject::roleValue):
        (WebCore::AccessibilityObject::ariaRoleAttribute):
        (WebCore::AccessibilityObject::childrenChanged):
        (WebCore::AccessibilityObject::addChildren):
        (WebCore::AccessibilityObject::removeAXObjectID):
        * page/AccessibilityObject.h:
        (WebCore::):
        (WebCore::PlainTextRange::PlainTextRange):
        (WebCore::PlainTextRange::isNull):
        (WebCore::AccessibilityObject::isAccessibilityRenderObject):
        (WebCore::AccessibilityObject::isAnchor):
        (WebCore::AccessibilityObject::isAttachment):
        (WebCore::AccessibilityObject::isHeading):
        (WebCore::AccessibilityObject::isLink):
        (WebCore::AccessibilityObject::isImage):
        (WebCore::AccessibilityObject::isNativeImage):
        (WebCore::AccessibilityObject::isImageButton):
        (WebCore::AccessibilityObject::isPasswordField):
        (WebCore::AccessibilityObject::isTextControl):
        (WebCore::AccessibilityObject::isNativeTextControl):
        (WebCore::AccessibilityObject::isWebArea):
        (WebCore::AccessibilityObject::isCheckboxOrRadio):
        (WebCore::AccessibilityObject::isChecked):
        (WebCore::AccessibilityObject::isEnabled):
        (WebCore::AccessibilityObject::isSelected):
        (WebCore::AccessibilityObject::isFocused):
        (WebCore::AccessibilityObject::isHovered):
        (WebCore::AccessibilityObject::isIndeterminate):
        (WebCore::AccessibilityObject::isLoaded):
        (WebCore::AccessibilityObject::isMultiSelect):
        (WebCore::AccessibilityObject::isOffScreen):
        (WebCore::AccessibilityObject::isPressed):
        (WebCore::AccessibilityObject::isReadOnly):
        (WebCore::AccessibilityObject::isVisited):
        (WebCore::AccessibilityObject::canSetFocusAttribute):
        (WebCore::AccessibilityObject::canSetTextRangeAttributes):
        (WebCore::AccessibilityObject::canSetValueAttribute):
        (WebCore::AccessibilityObject::hasIntValue):
        (WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
        (WebCore::AccessibilityObject::accessibilityIsIgnored):
        (WebCore::AccessibilityObject::children):
        (WebCore::AccessibilityObject::hasChildren):
        (WebCore::AccessibilityObject::setWrapper):
        (WebCore::AccessibilityObject::isDetached):
        * page/AccessibilityRenderObject.cpp: Added.
        (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
        (WebCore::AccessibilityRenderObject::~AccessibilityRenderObject):
        (WebCore::AccessibilityRenderObject::create):
        (WebCore::AccessibilityRenderObject::detach):
        (WebCore::AccessibilityRenderObject::firstChild):
        (WebCore::AccessibilityRenderObject::lastChild):
        (WebCore::AccessibilityRenderObject::previousSibling):
        (WebCore::AccessibilityRenderObject::nextSibling):
        (WebCore::AccessibilityRenderObject::parentObject):
        (WebCore::AccessibilityRenderObject::isWebArea):
        (WebCore::AccessibilityRenderObject::isImageButton):
        (WebCore::AccessibilityRenderObject::isAnchor):
        (WebCore::AccessibilityRenderObject::isNativeTextControl):
        (WebCore::AccessibilityRenderObject::isTextControl):
        (WebCore::AccessibilityRenderObject::isNativeImage):
        (WebCore::AccessibilityRenderObject::isImage):
        (WebCore::AccessibilityRenderObject::isAttachment):
        (WebCore::AccessibilityRenderObject::isPasswordField):
        (WebCore::AccessibilityRenderObject::isCheckboxOrRadio):
        (WebCore::AccessibilityRenderObject::isPressed):
        (WebCore::AccessibilityRenderObject::isIndeterminate):
        (WebCore::AccessibilityRenderObject::isChecked):
        (WebCore::AccessibilityRenderObject::isHovered):
        (WebCore::AccessibilityRenderObject::isMultiSelect):
        (WebCore::AccessibilityRenderObject::isReadOnly):
        (WebCore::AccessibilityRenderObject::isOffScreen):
        (WebCore::AccessibilityRenderObject::headingLevel):
        (WebCore::AccessibilityRenderObject::isHeading):
        (WebCore::AccessibilityRenderObject::isLink):
        (WebCore::AccessibilityRenderObject::anchorElement):
        (WebCore::AccessibilityRenderObject::actionElement):
        (WebCore::AccessibilityRenderObject::mouseButtonListener):
        (WebCore::AccessibilityRenderObject::helpText):
        (WebCore::AccessibilityRenderObject::textUnderElement):
        (WebCore::AccessibilityRenderObject::hasIntValue):
        (WebCore::AccessibilityRenderObject::intValue):
        (WebCore::AccessibilityRenderObject::stringValue):
        (WebCore::labelForElement):
        (WebCore::AccessibilityRenderObject::title):
        (WebCore::AccessibilityRenderObject::accessibilityDescription):
        (WebCore::AccessibilityRenderObject::boundingBoxRect):
        (WebCore::AccessibilityRenderObject::elementRect):
        (WebCore::AccessibilityRenderObject::size):
        (WebCore::AccessibilityRenderObject::linkedUIElement):
        (WebCore::AccessibilityRenderObject::accessibilityShouldUseUniqueId):
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
        (WebCore::AccessibilityRenderObject::isLoaded):
        (WebCore::AccessibilityRenderObject::layoutCount):
        (WebCore::AccessibilityRenderObject::text):
        (WebCore::AccessibilityRenderObject::textLength):
        (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
        (WebCore::AccessibilityRenderObject::selectedText):
        (WebCore::AccessibilityRenderObject::accessKey):
        (WebCore::AccessibilityRenderObject::selection):
        (WebCore::AccessibilityRenderObject::selectedTextRange):
        (WebCore::AccessibilityRenderObject::setSelectedTextRange):
        (WebCore::AccessibilityRenderObject::url):
        (WebCore::AccessibilityRenderObject::isVisited):
        (WebCore::AccessibilityRenderObject::isSelected):
        (WebCore::AccessibilityRenderObject::isFocused):
        (WebCore::AccessibilityRenderObject::setFocused):
        (WebCore::AccessibilityRenderObject::setValue):
        (WebCore::AccessibilityRenderObject::isEnabled):
        (WebCore::AccessibilityRenderObject::topRenderer):
        (WebCore::AccessibilityRenderObject::widget):
        (WebCore::AccessibilityRenderObject::axObjectCache):
        (WebCore::AccessibilityRenderObject::getDocumentLinks):
        (WebCore::AccessibilityRenderObject::widgetForAttachmentView):
        (WebCore::AccessibilityRenderObject::frameViewIfRenderView):
        (WebCore::AccessibilityRenderObject::visiblePositionRange):
        (WebCore::AccessibilityRenderObject::doAXTextMarkerRangeForLine):
        (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
        (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
        (WebCore::AccessibilityRenderObject::doAXBoundsForTextMarkerRange):
        (WebCore::AccessibilityRenderObject::doSetAXSelectedTextMarkerRange):
        (WebCore::AccessibilityRenderObject::doAXTextMarkerForPosition):
        (WebCore::AccessibilityRenderObject::textMarkerForIndex):
        (WebCore::AccessibilityRenderObject::indexForTextMarker):
        (WebCore::AccessibilityRenderObject::doAXRangeForLine):
        (WebCore::AccessibilityRenderObject::doAXRangeForIndex):
        (WebCore::AccessibilityRenderObject::doAXStringForRange):
        (WebCore::AccessibilityRenderObject::doAXBoundsForRange):
        (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
        (WebCore::AccessibilityRenderObject::focusedUIElement):
        (WebCore::AccessibilityRenderObject::observableObject):
        (WebCore::createARIARoleMap):
        (WebCore::RoleEntry::):
        (WebCore::ariaRoleToWebCoreRole):
        (WebCore::AccessibilityRenderObject::ariaRoleAttribute):
        (WebCore::AccessibilityRenderObject::roleValue):
        (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
        (WebCore::AccessibilityRenderObject::canSetValueAttribute):
        (WebCore::AccessibilityRenderObject::canSetTextRangeAttributes):
        (WebCore::AccessibilityRenderObject::childrenChanged):
        (WebCore::AccessibilityRenderObject::children):
        (WebCore::AccessibilityRenderObject::addChildren):
        (WebCore::AccessibilityRenderObject::removeAXObjectID):
        (WebCore::AccessibilityRenderObject::actionVerb):
        * page/AccessibilityRenderObject.h: Added.
        (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
        (WebCore::AccessibilityRenderObject::areaElement):
        (WebCore::AccessibilityRenderObject::setRenderer):
        (WebCore::AccessibilityRenderObject::renderer):
        (WebCore::AccessibilityRenderObject::setRenderObject):
        (WebCore::AccessibilityRenderObject::isDetached):
        * page/mac/AXObjectCacheMac.mm:
        (WebCore::AXObjectCache::detachWrapper):
        (WebCore::AXObjectCache::selectedChildrenChanged):
        (WebCore::AXObjectCache::postNotification):
        * page/mac/AccessibilityObjectWrapper.mm:
        (textMarkerForVisiblePosition):
        (CreateCGColorIfDifferent):
        (AXAttributeStringSetHeadingLevel):
        (AXLinkElementForNode):
        (AXAttributeStringSetElement):
        (AXAttributedStringAppendText):
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
        (-[AccessibilityObjectWrapper documentFrameView:]):
        (-[AccessibilityObjectWrapper position]):
        (RoleEntry::):
        (-[AccessibilityObjectWrapper roleDescription]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
        (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
        (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
        (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
        (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
        (-[AccessibilityObjectWrapper doAXAttributedStringForRange:]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

rwlbuis@webkit.org's avatar
rwlbuis@webkit.org committed
1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977
2008-05-06  Jonathan Haas  <myrdred@gmail.com>

        Reviewed by Rob Buis.

        https://bugs.webkit.org/show_bug.cgi?id=18859\
        Prevented SVGRootInlineBox from static_casting a
        node to a class it doesn't inherit
        
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::buildTextChunks):

beidson@apple.com's avatar
beidson@apple.com committed
1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Preparation for upcoming work making LocalStorage persistent.

        When the application terminates, all pending local storage writes need to be
        sync'ed out to disk.
        This works n combination with platform specific code in WebKit that calls it.

        * WebCore.base.exp:

        * page/PageGroup.cpp:
        (WebCore::PageGroup::closeLocalStorage): Close all open LocalStorage objects
        * page/PageGroup.h:

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::close): Placeholder for what will sync and terminate the
          local storage thread in the future.
        * storage/LocalStorage.h:

1999 2000 2001 2002 2003 2004
2008-05-06  Brady Eidson  <beidson@apple.com>

        Rubberstamped by David Kilzer

        * WebCore.base.exp:  Sort this mess!

2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017
2008-05-05  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        Fix 60 crashes seen on the buildbots that were misreported as hangs.

        * dom/Document.cpp:
        (WebCore::Document::detachNodeIterator): Null-check page() before dereferencing it.
        (WebCore::Document::nodeWillBeRemoved): Ditto.
        (WebCore::Document::textInserted): Ditto.
        (WebCore::Document::textNodesMerged): Ditto.
        (WebCore::Document::textRemoved): Ditto.

2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel RTL

        Preparation for upcoming work making LocalStorage persistent.

        The other half of the StorageMap::importItem() addition.

        * storage/StorageArea.cpp:
        (WebCore::StorageArea::importItem):
        * storage/StorageArea.h:

2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel RTL

        Preparation for upcoming work making LocalStorage persistent.

        - Create the LocalStorage object for a PageGroup the moment the first Page is added to it
          The Settings of the first Page define what persistent path the LocalStorage will use
        - Add a Frame argument for the LocalStorageArea request - this will allow a client object
          to be queried before the LocalStorageArea is established

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::localStorage):

        * page/PageGroup.cpp:
        (WebCore::PageGroup::addPage):
        (WebCore::PageGroup::localStorage):

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::LocalStorage): Take the path as a constructor argument.  Deep copy
          the path as it will be used from another thread.
        (WebCore::LocalStorage::storageArea):
        * storage/LocalStorage.h:
        (WebCore::LocalStorage::create):

2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel RTL

        Preparation for upcoming work making LocalStorage persistent.

        StorageMaps normally have copy-on-write semantics to help support SessionStorage.
        For LocalStorage, we never want this behavior.  When we forcefully import items into 
        a StorageMap from the LocalStorage background thread, this new import method will be used.

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::importItem): Add a deep-copy of the item to the map without worrying
          about copy-on-write.
        * storage/StorageMap.h:

2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092
2008-05-05  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        -Begininings of a UI for the Profiler in the WebInspector.

        * English.lproj/InspectorLocalizedStrings.js: Add new strings to be
        localized.
        * page/inspector/DatabasesPanel.js: Changed the name of the Databae's
        results table to be more generic as it is now also used by the profiler.
        * page/inspector/Images/glossySelected.png: Added.
        * page/inspector/Images/profilesIcon.png: Added.
        * page/inspector/Images/treeUpTriangleBlack.png: Added.
        * page/inspector/Images/treeUpTriangleWhite.png: Added.
        * page/inspector/ProfileView.js: Added. Sets up the header of the table.
        * page/inspector/ProfilesPanel.js: Added.
        * page/inspector/ProfilesPanel.js: Added. Sets up the containers of the
        profiler's content.
        * page/inspector/inspector.css: Change database-result-table to be more
        generic as well as add the styles needed by the profiler.
        * page/inspector/inspector.html: Add profiler support.

2093 2094 2095 2096 2097 2098 2099 2100 2101
2008-05-05  Brady Eidson  <beidson@apple.com>

        Change by Darin, reviewed by Brady

        Small efficiency improvement Darin just spotted

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::setItem):

2102 2103 2104 2105 2106 2107 2108 2109 2110 2111
2008-05-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Anders.

        Fix https://bugs.webkit.org/show_bug.cgi?id=18899
        Bug 18899: REGRESSION (r32871): Non-Safari crash in WTF::HashTable on startup

        * loader/loader.cpp:
        (WebCore::Loader::Loader):

2112 2113 2114 2115 2116 2117 2118 2119 2120 2121
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Fix a bug in StorageMap iterator tracking where the iterator was not successfully
        invalidated at an appropriate time.

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::setItem): ALWAYS invalidate it here

justin.garcia@apple.com's avatar
justin.garcia@apple.com committed
2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144
2008-05-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
        
        Disable Range mutation on document modifications in Tiger and Leopard Mail,
        since they do their own mutation which interferes with ours.

        * WebCore.base.exp:
        * dom/Document.cpp:
        (WebCore::Document::nodeChildrenChanged):
        (WebCore::Document::nodeWillBeRemoved):
        (WebCore::Document::textInserted):
        (WebCore::Document::textRemoved):
        (WebCore::Document::textNodesMerged):
        (WebCore::Document::textNodeSplit):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::disableRangeMutationForOldAppleMail):
        * page/Settings.h:
        (WebCore::Settings::rangeMutationDisabledForOldAppleMail):

weinig@apple.com's avatar
weinig@apple.com committed
2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156
2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Tim Hatcher.

        Make the Inspector's localizable strings file match the format used by Dashboard widgets.

        * English.lproj/InspectorLocalizedStrings.js: Removed.
        * English.lproj/localizedStrings.js: Added.
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/inspector/inspector.js:

2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194
2008-05-05  Steve Falkenburg  <sfalken@apple.com>

        Add support for default button appearance.
        Add WebCore setting for app chrome mode.
        
        Reviewed by Dave Hyatt.

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        * css/CSSValueKeywords.in: Added default-button value keyword.
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setApplicationChromeMode):
        * page/Settings.h:
        (WebCore::Settings::inApplicationChromeMode):
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::RenderButton):
        (WebCore::RenderButton::setStyle):
        (WebCore::RenderButton::timerFired):
        * rendering/RenderButton.h:
        * rendering/RenderStyle.h:
        (WebCore::):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle):
        (WebCore::RenderTheme::paint):
        (WebCore::RenderTheme::paintBorderOnly):
        (WebCore::RenderTheme::paintDecorations):
        (WebCore::RenderTheme::isControlStyled):
        (WebCore::RenderTheme::isDefault):
        * rendering/RenderTheme.h:
        (WebCore::):
        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::determineState):
        (WebCore::RenderThemeSafari::adjustRepaintRect):
        (WebCore::RenderThemeSafari::adjustButtonStyle):
        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::supportsFocus):

ap@webkit.org's avatar
ap@webkit.org committed
2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213
2008-05-05  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=11947
        nbsps should be converted to entities in innerHTML

        https://bugs.webkit.org/show_bug.cgi?id=18769
        replacing &nbsp; with spaces using regexp creates inconsistent result

        Tests: fast/dom/innerHTML-nbsp.html
               fast/dom/innerHTML-escaping-attribute.html

        * editing/markup.cpp:
        (WebCore::appendAttributeValue):
        (WebCore::escapeContentText):
        (WebCore::appendEscapedContent):
        Added U+00a0/nbsp to the list of characters to escape.

hyatt@apple.com's avatar
hyatt@apple.com committed
2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225
2008-05-05  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18821.  Fix some bugs in both get/PutImageData of <canvas>.

        Reviewed by Eric

        New tests added in fast/canvas/

        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::getImageData):
        (WebCore::ImageBuffer::putImageData):

mitz@apple.com's avatar
mitz@apple.com committed
2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240
2008-05-05  Dan Bernstein  <mitz@apple.com>

        Reviewed by Dave Hyatt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18809
          Forms with block level generated content and absolutely positioned labels break inline layout (fixed on reflow)

        Test: fast/block/basic/adding-near-anonymous-block.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addChildToFlow): When adding a floating or
        positioned object, if it follows an anonymous block, put it
        inside the anonymous block. When adding an inline, check if it comes
        after an anonymous block and put it in the anonymous block.

2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259
2008-05-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin.

        Speculative fix for <rdar://problem/5906790> 
        Crash in Loader::servePendingRequests() due to hash table being modified during iteration
        
        I don't know how to reproduce this. It would require the load to fail (or succeed)
        synchronously, something that should not usually happen.

        * loader/loader.cpp:
        (WebCore::Loader::Loader):
        (WebCore::Loader::load):
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::cancelRequests):
        (WebCore::Loader::Host::Host):
        * loader/loader.h:
        (WebCore::Loader::Host::name):

2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270
2008-05-05  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Disable SVG As Image support in the Qt port again, as it
        requires more work. Right now the chrome client is
        assumed to be a ChromeClientQt, which the SVG Image support
        changes.

        * WebCore.pro:

2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286
2008-05-02  Antti Koivisto  <antti@apple.com>

        Reviewed by Mitz.

        Fix <rdar://problem/5840475>
        CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::RenderBlock::insertPositionedObject
        
        Non-block objects can have transforms so containingBlock() could end up returning null. 
        RenderObject::container() needs to match.

        Test: fast/transforms/container-transform-crash.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::containingBlock):
        (WebCore::RenderObject::container):

2287 2288 2289 2290 2291 2292 2293 2294
2008-05-04  Sam Weinig  <sam@webkit.org>

        Roll out r32851.  It broke tiger builds.

        * bindings/objc/DOMUtility.mm:
        (KJS::createDOMWrapper):
        (WebCore::createDOMWrapper):

mitz@apple.com's avatar
mitz@apple.com committed
2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310
2008-05-04  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18879
          <rdar://problem/5909481> Reproducible crash when removing a gradient

        Test: fast/gradients/crash-on-remove.html

        * css/CSSImageGeneratorValue.cpp:
        (WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue):
        (WebCore::CSSImageGeneratorValue::addClient): Added a call to ref() the
        value.
        (WebCore::CSSImageGeneratorValue::removeClient): Added code to deref()
        the value.

2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321
2008-05-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Move createDOMWrapper(JSObject* object) out of the KJS namespace and into
        the WebCore namespace now that the required compilers don't freak out about
        this anymore.

        * bindings/objc/DOMUtility.mm:
        (WebCore::createDOMWrapper):

rwlbuis@webkit.org's avatar
rwlbuis@webkit.org committed
2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334
2008-05-03  Rob Buis  <buis@kde.org>

        Reviewed by Sam.

        https://bugs.webkit.org/show_bug.cgi?id=18652
        onchange events don't seem to fire for input[type=range] controls.

        Fire changeEvent when clicking the slider outside the current
        thumb position.

        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::setValueForPosition):

2335 2336 2337 2338 2339 2340 2341 2342 2343
2008-05-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Remove unused enums from JSDOMWindowBase.

        * bindings/js/JSDOMWindowBase.h:
        (WebCore::JSDOMWindowBase::):

2344 2345 2346 2347 2348 2349
2008-05-03  Sam Weinig  <sam@webkit.org>

        Real build fix.

        * WebCore.xcodeproj/project.pbxproj:

2350 2351 2352 2353 2354 2355 2356
2008-05-03  Sam Weinig  <sam@webkit.org>

        Build fix.

        * bindings/js/kjs_events.cpp:
        (WebCore::JSAbstractEventListener::handleEvent):

2357 2358 2359 2360 2361 2362
2008-05-03  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Geoffrey Garen.

        Rename JSDOMWindowWrapper to JSDOMWindowShell.

rwlbuis@webkit.org's avatar
rwlbuis@webkit.org committed
2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381
2008-05-01  Rob Buis  <buis@kde.org>

        Reviewed by Eric.

        https://bugs.webkit.org/show_bug.cgi?id=18568
        background: currentColor fails

        Implement currentColor from CSS3 color module.

        Tests: fast/css/background-currentcolor.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseBackgroundColor):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
        * css/CSSValueKeywords.in:
        * css/SVGCSSValueKeywords.in:

andersca@apple.com's avatar
andersca@apple.com committed
2382 2383 2384 2385 2386 2387 2388 2389 2390 2391
2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        Turns out calling locationInWindow on keyboard events will not throw an exception,
        but the point returned is completely bogus, so remove coordinates from the keyboard event struct.
        
        * bridge/npapi.h:
        (_NPCocoaEvent::):

2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404
2008-05-02  Benjamin Otte  <otte@gnome.org>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18856
        [GTK] variable initialization missing

        Not initializing the m_needsXEmbed variable could have very funny
        results. Most often those results would be crashes.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::PluginView):

2405 2406 2407 2408 2409 2410