ChangeLog 3.6 MB
Newer Older
ggaren@apple.com's avatar
ggaren@apple.com committed
1 2 3 4 5 6 7 8 9 10 11 12 13 14
2009-05-21  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.
        
        Test for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
        Incorrect URL returned to the DOM while the user drags a file

        * page/DragController.cpp:
        (WebCore::DragController::dragExited):
        (WebCore::DragController::tryDHTMLDrag): Don't base our decision on KURL,
        since that only looks at the text of the document's URL. Do base our
        decision on the securityOrigin(), which knows more about the document's
        actual origin.

15 16 17 18 19 20 21 22
2009-05-21  Dan Bernstein  <mitz@apple.com>

        Rubber-stamped by Mark Rowe.

        - fix https://bugs.webkit.org/show_bug.cgi?id=25947
          Assertion failure in FrameLoader::transitionToCommitted on launch in
          Safari with r43985

mitz@apple.com's avatar
mitz@apple.com committed
23
        Rolled out r43979.
24 25 26 27 28

        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeSupportedNonImageMimeTypes):
        (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):

29 30 31 32 33 34 35 36 37 38 39 40 41
2009-05-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Brady Eidson and Mark Rowe.

        Fix for <rdar://problem/6901522>
        REGRESSION: Office 2008: Preview with browser is not shown, and Finder window is in the front of Safari

        If the NSURLRequest is annotated with a "ForceHTMLMIMEType" property, force
        the MIME type to be text/html.

        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

42 43 44 45 46 47 48
2009-05-21  Kevin Ollivier  <kevino@theolliviers.com>

        Blind windows fix after last commit.

        * platform/Logging.cpp:
        (WebCore::getChannelFromName):

49 50 51 52 53 54 55 56 57 58 59 60 61 62 63
2009-05-21  Kevin Watters  <kevinwatters@gmail.com>

        Reviewed by Kevin Ollivier.

        Use an environment variable to control which logs are on and off.
        Also, make a generic function for translating channel name to its log.
        
        https://bugs.webkit.org/show_bug.cgi?id=25936

        * platform/Logging.cpp:
        (WebCore::getChannelFromName):
        * platform/Logging.h:
        * platform/wx/LoggingWx.cpp:
        (WebCore::InitializeLoggingChannelsIfNecessary):

64 65 66 67 68 69 70 71 72 73 74 75 76 77
2009-05-21  David Levin  <levin@chromium.org>

        Reviewed by Darin Fisher.

        Bug 25946: Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation.
        https://bugs.webkit.org/show_bug.cgi?id=25946

        A very simple implementation to keep it working.  A bug has been filed in the chromium db
        (http://code.google.com/p/chromium/issues/detail?id=12441) to investigate doing something more
        complete.

        * platform/chromium/MimeTypeRegistryChromium.cpp:
        (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension):

78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99
2009-05-20  Siddhartha Chattopadhyaya  <sidchat@google.com>

        Reviewed by Justin Garcia.
        
        Add automatic spell correction support in WebKit

        https://bugs.webkit.org/show_bug.cgi?id=24953

        * editing/Editor.cpp:
        (WebCore::findFirstMisspellingInRange):
        (WebCore::Editor::advanceToNextMisspelling):
        (WebCore::Editor::markMisspellingsAfterTypingToPosition):
        (WebCore::markAllMisspellingsInRange):
        (WebCore::markMisspellingsOrBadGrammar):
        (WebCore::Editor::markMisspellings):
        (WebCore::Editor::markBadGrammar):
        (WebCore::Editor::markMisspellingsAndBadGrammar):
        * editing/Editor.h:
        * loader/EmptyClients.h:
        (WebCore::EmptyEditorClient::getAutoCorrectSuggestionForMisspelledWord):
        * page/EditorClient.h:

100 101 102 103 104 105 106 107 108 109 110 111 112
2009-05-21  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Darin Adler.

        Text files which have sub MIME types are treated as not displayable
        http://bugs.webkit.org/show_bug.cgi?id=24903

        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeSupportedNonImageMimeTypes):
        (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): Regard any
        MIME type beginning with "text/" as supported and remove all "text/"
        types from the list.

ap@webkit.org's avatar
ap@webkit.org committed
113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137
2009-05-21  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=25890
        Implement Network logging channel on Mac

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::~ResourceHandle):
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::cancel):
        (WebCore::ResourceHandle::setDefersLoading):
        (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
        (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
        (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
        (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
        (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
        (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
        (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
        (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
        Added logging for async requests (as these are most interesting).

138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163
2009-05-21  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by David Kilzer.

        <rdar://problem/6902197> WebCore doesn't know about all of the MIME types supported by QTKit
        
        Add a static table to map from some common file extensions to their MIME types so it
        is possible to detect support even when the platform mapping is incomplete. Use the
        table to lookup types not found by UTI on the OSX, and when looking for a media engine
        with a generic or missing type.

        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeMediaTypeMaps): New, initialize the mediaMIMETypeForExtensionMap.
        (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): New. Look for the specified
        MIME type in the static mapping table if the platform specific getMIMETypeForExtension
        doesn't find a match.
        * platform/MIMETypeRegistry.h: Declare getMediaMIMETypeForExtension.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::load): When the type passed is empty, "application/octet-stream", or
        "text/plain", try to look it up based on the file extension with getMediaMIMETypeForExtension.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::addFileTypesToCache): See if getMediaMIMETypeForExtension can map from file extension
        to MIME type if UTI fails.

164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203
2009-05-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Clean up DragController
        https://bugs.webkit.org/show_bug.cgi?id=25926

        I renamed m_document to m_documentUnderMouse to better document what it does
        I could call it m_lastDocumentUnderMouse to be most-accurate, but this seemed
        long enough.

        I also saw copy/paste code involving clearing the selection when moving out of
        one document and into another.  I moved that code into a function called
        mouseMovedIntoDocument.

        I also got rid of a couple needless null-checks after confirming via source
        inspection they were not ever possible.
        In Mac WebKit it's not possible to have a Page that doesn't have a mainFrame()
        I left an ASSERT(m_page->mainFrame()) in case some other port ever violates this.
        It's also not possible to return a document from documentAtPoint that is not
        in a frame (as such a document would not be rendered).

        No functional changes, thus no tests.

        * page/DragController.cpp:
        (WebCore::DragController::DragController):
        (WebCore::DragController::dragIsMove):
        (WebCore::DragController::dragExited):
        (WebCore::DragController::performDrag):
        (WebCore::DragController::mouseMovedIntoDocument):
        (WebCore::DragController::dragEnteredOrUpdated):
        (WebCore::DragController::tryDocumentDrag):
        (WebCore::DragController::operationForLoad):
        (WebCore::DragController::concludeEditDrag):
        (WebCore::DragController::canProcessDrag):
        (WebCore::DragController::tryDHTMLDrag):
        (WebCore::DragController::placeDragCaret):
        * page/DragController.h:
        (WebCore::DragController::documentUnderMouse):

204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224
2009-05-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename DragController::dragOperation() to sourceDragOperation() for clarity
        Remove unused setDragOperation()

        There are two times DragOperation is used.  The source specifies
        what drag operations it supports (in a mask) and the destination
        picks a subset of those as DragOperations it supports if a drop were
        to occur.  I was confused when I first saw this accessor as to which
        it meant.  It turns out that this is only used when WebKit starts a
        drag, and we keep it around so that we can provide this information
        to other Mac OS X applications when they ask.  I've renamed the method
        for clarity so the next person in this code will be less confused.

        No functional changes, thus no tests.

        * page/DragController.h:
        (WebCore::DragController::sourceDragOperation):

mitz@apple.com's avatar
mitz@apple.com committed
225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256
2009-05-21  Dan Bernstein  <mitz@apple.com>

        Reviewed by Anders Carlsson.

        - WebCore part of <rdar://problem/6901751> REGRESSION (r35515): Tiger
          crash painting the selection on registration page of car2go.com

        A bug in old versions of Core Graphics causes memory corruption to occur
        when clipping under certain conditions. Make the clipping functions
        fail silently under those conditions.

        Test: fast/block/float/selection-gap-clip-out-tiger-crash.html

        * WebCore.Tiger.exp: Added wkCGContextIsSafeToClip
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::safeCGContextClip): Added a wrapper around CGContextClip that,
        on Tiger, bails out if wkCGContextIsSafeToClip() returns false.
        (WebCore::safeCGContextEOClip): Ditto for CGContextEOClip.
        (WebCore::safeCGContextClipToRect): Ditto for CGContextClipToRect.
        (WebCore::GraphicsContext::fillPath): Changed to call the safe variants
        of CGContextClip, CGContextEOClip and CGContextClipToRect.
        (WebCore::GraphicsContext::strokePath): Ditto.
        (WebCore::GraphicsContext::fillRect): Ditto.
        (WebCore::GraphicsContext::clip): Ditto.
        (WebCore::GraphicsContext::clipOut): Ditto.
        (WebCore::GraphicsContext::clipOutEllipseInRect): Ditto.
        (WebCore::GraphicsContext::clipPath): Ditto.
        (WebCore::GraphicsContext::addInnerRoundedRectClip): Ditto.
        (WebCore::GraphicsContext::strokeRect): Ditto.
        * platform/mac/WebCoreSystemInterface.h: Added wkCGContextIsSafeToClip.
        * platform/mac/WebCoreSystemInterface.mm: Added wkCGContextIsSafeToClip.

257 258 259 260 261 262 263 264 265 266 267 268
2009-05-21  Xan Lopez  <xlopez@igalia.com>

        Unreviewed build fix.

        https://bugs.webkit.org/show_bug.cgi?id=25910
        WebkitGTK r43960 cannot compile

        Do not include local copy of guriescape header, which was
        removed. We now use the copy in glib.

        * platform/gtk/FileSystemGtk.cpp:

269 270 271 272 273 274 275 276 277 278 279 280 281
2009-05-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25706

        It turns out the CurrentContext wasn't currect either because it gave
        us the frame for the write() function itself.  We actually want the
        *calling* context.

        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):

282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303
2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Gustavo Noronha.

        [GTK] Implement Image::loadPlatformResource.

        Install the four resources we are using. For the icons
        where an icon name is specified by freedeskop.org try to
        map the WebCore name to that name and fallback to the
        internal icon. For everything else use the internal icon
        name. Remove the temporary link stub as this is not
        required any more.

        * GNUmakefile.am: Install the png files, set DATA_DIR again
        * Resources/panIcon.png: Copied from WebKit/win/WebKit.vcproj/panIcon.png.
        * platform/graphics/gtk/ImageGtk.cpp:
        (WTF::GtkIconInfo): Add template specialization for GtkIconInfo
        (WebCore::getIconFileNameOrFallback): Use GtkIconTheme to get the icon
        (WebCore::loadResourceIntoSharedBuffer):
        (WebCore::Image::loadPlatformResource): Implement
        * platform/gtk/TemporaryLinkStubs.cpp: Remove link stub

304 305 306 307 308 309 310 311 312 313 314
2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=19357

        [GTK] The Gtk+ port wants to have a themable
        urlIcon too.

        * loader/icon/IconDatabase.cpp:

315 316 317 318 319 320
2009-05-20  Stephanie Lewis  <slewis@apple.com>

        Update the order files.  <rdar://problem/6881750> Generate new order files.

        * WebCore.order:

321 322 323 324 325 326 327 328 329 330 331
2009-05-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Gavin Barraclough.

        Fix some assertion failures in plug-in tests on the Windows debug build bot.

        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::startStream): Switch to using protocolIsJavaScript.
        * plugins/PluginView.cpp:
        (WebCore::scriptStringIfJavaScriptURL): Ditto.

beidson@apple.com's avatar
beidson@apple.com committed
332 333 334 335 336 337 338 339 340
2009-05-20  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        More protocolInHTTPFamily() cleanup.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::send):

341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356
2009-05-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Fix for <rdar://problem/6905475>
        Office 2008: Entourage: Crash when you switch to "My Day" view

        The host function callback callObjCFallbackObject was not annotated
        with JSC_HOST_CALL which meant that when it was called by the JIT, which
        expects the JSC_HOST_CALL calling convention, the arguments are not in the
        expected places.

        * bridge/objc/objc_runtime.mm:
        (JSC::Bindings::callObjCFallbackObject): Added missing JSC_HOST_CALL
        annotation on callObjCFallbackObject.

357 358 359 360 361 362 363 364 365
2009-05-20  David Levin  <levin@chromium.org>

        Not Reviewed, build fix.

        Need to disable this assert while the chormium code is fixed for it.

        * platform/KURLGoogle.cpp:
        (WebCore::KURL::protocolIs):

366 367 368 369 370 371 372 373 374 375 376
2009-05-20  David Levin  <levin@chromium.org>

        Not Reviewed, build fix.

        Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
        http://trac.webkit.org/changeset/43929.  Fix assert placement.

        * platform/KURLGoogle.cpp:
        (WebCore::KURL::protocolIs):
        (WebCore::protocolIs):

377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394
2009-05-20  Nate Chapin  <japhet@google.com>

        Reviewed by Dimitri Glazkov.

        Upstream V8 bindings for V8DomWindow.
        https://bugs.webkit.org/show_bug.cgi?id=25869

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8Custom::WindowSetTimeoutImpl): Moved from v8_custom.cpp.
        (WebCore::isAscii): Moved from v8_custom.cpp.
        (WebCore::convertBase64): Moved from v8_custom.cpp.
        (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp.
        (WebCore::eventNameFromAttributeName): Moved from v8_custom.cpp.
        (WebCore::ACCESSOR_SETTER): Moved from v8_custom.cpp.
        (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp.
        (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp.
        (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp.

395 396 397 398 399 400 401
2009-05-21  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Jan Alonzo.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::parseDataUrl): Always use Glib Base64 decoding.

402 403 404 405 406 407 408
2009-05-21  Christian Dywan  <christian@twotoasts.de>

        Rubberstamped by Gustavo Noronha.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::parseDataUrl): Remove Gtk/ Glib Base64 decoding.

409 410 411 412 413 414 415 416 417
2009-05-20  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha.

        * GNUmakefile.am:
        * platform/gtk/guriescape.c:
        * platform/gtk/guriescape.h: Remove copies of g_uri_escape_string and
        g_uri_unescape_string now that we require Glib 2.16.

418 419 420 421 422 423 424 425 426 427 428
2009-05-20  David Levin  <levin@chromium.org>

        Not Reviewed, build fix.

        Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
        http://trac.webkit.org/changeset/43929.

        * platform/KURLGoogle.cpp:
        (WebCore::protocolIsJavaScript):
        (WebCore::protocolIs):

429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449
2009-05-20  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Sam Weinig

        At all call sites that check if a KURL has either the http or https protocol,
        use the KURL::protocolInHTTPFamily() accessor, instead.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::iconURL):
        (WebCore::FrameLoader::didOpenURL):
        (WebCore::FrameLoader::open):

        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):

        * loader/loader.cpp:
        (WebCore::Loader::load):

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::send):

beidson@apple.com's avatar
beidson@apple.com committed
450 451 452 453 454 455 456 457 458 459
2009-05-20  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300

        KURL parsing changes back in r30243 and r30815 made javascript urls that use the form
        "javascript://" be detected as invalid hierarchical URLs.  When a KURL is marked as
        invalid, you can no longer ask it a question such as "is your protocol javascript?"
        Therefore FrameLoader wouldn't recognize them as javascript URLs and instead try to
beidson@apple.com's avatar
beidson@apple.com committed
460
        navigate to them.
beidson@apple.com's avatar
beidson@apple.com committed
461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501

        URL parsing rules aside, such URLs are in use in the wild (Microsoft's Virtual Earth 
        being a high profile example) and actually represent valid javascript.

        Whenever checking for javascript urls, the new protocolIsJavaScript() should be used
        as it functions on a String which doesn't have to pass KURLs parsing rules. 

        Test: fast/loader/javascript-url-hierarchical-execution.html

        * bindings/js/JSAttrCustom.cpp:
        (WebCore::JSAttr::setValue): Use protocolIsJavaScript().
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setLocation): Ditto.
        (WebCore::createWindow): Ditto.
        (WebCore::JSDOMWindow::open): Ditto.
        * bindings/js/JSElementCustom.cpp:
        (WebCore::allowSettingSrcToJavascriptURL): Ditto.
        * bindings/js/JSHTMLFrameElementCustom.cpp:
        (WebCore::allowSettingJavascriptURL): Ditto.
        * bindings/js/JSHTMLIFrameElementCustom.cpp:
        (WebCore::JSHTMLIFrameElement::setSrc): Ditto.
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::navigateIfAllowed): Ditto.
        (WebCore::JSLocation::reload): Ditto.
        * editing/markup.cpp:
        (WebCore::appendQuotedURLAttributeValue): Ditto.
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::parseMappedAttribute): Ditto.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::requestFrame): Ditto.
        (WebCore::FrameLoader::submitForm): Ditto.
        (WebCore::FrameLoader::executeIfJavaScriptURL): Ditto.
        
        * platform/KURL.cpp:
        (WebCore::KURL::init): Use protocolIsJavaScript().
        (WebCore::KURL::protocolIs): ASSERT that the protocol being asked about is not javascript.
           Such checks should go through protocolIsJavaScript() instead.
        (WebCore::encodeRelativeString): Use protocolIsJavaScript().
        (WebCore::protocolIsJavaScript):
        * platform/KURL.h:

502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517
2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=24510

        Fix a bug where the browserfuncs were not properly assigned,
        make hasproperty use _NP_HasProperty and hasmethod _NP_HasMethod.

        Test: plugins/netscape-invoke-browserfuncs.html

        * plugins/gtk/PluginPackageGtk.cpp:
        (WebCore::PluginPackage::load): Fix assignment
        * plugins/qt/PluginPackageQt.cpp:
        (WebCore::PluginPackage::load): Fix assignment

518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533
2009-05-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Timothy Hatcher.

        Make absoluteRectsForRange and absoluteQuadsForRange non-virtual
        and only exist on RenderText.

        * dom/Range.cpp:
        (WebCore::Range::textRects):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::drawNodeHighlight): Use absoluteQuads instead
        of absoluteQuadsForRange since no range is being specifiec.
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderText.h:

534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553
2009-05-20  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Implement AtkObject::focus-event and
        AtkObject::state-changed:focused signal emission.

        Adds a new handleFocusedUIElementChangedWithRenderers, only in the
        GTK port, called at the same point than
        handleFocusedUIElementChanged but with two parameters, the old and
        the newly focused RenderObjects. We need this, since the ATK
        signals require us to pass the objects involved in the focus
        change as arguments.

        * accessibility/AXObjectCache.h:
        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (WebCore::AXObjectCache::handleFocusedUIElementChangedWithRenderers):
        * dom/Document.cpp:
        (WebCore::Document::setFocusedNode):

554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576
2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25834

        Make ChromeClient a interface again

        With recent additions to ChromeClient.h empty defaults were
        added. This is bad for porters as these changes go unnoticed
        and at runtime no notImplemented warning is logged and grepping
        for notImplemented will not show anything. Change this Client
        to be like the other Clients again and always have pure virtuals
        (but for stuff inside #ifdef PLATFORM(MAC)).

        Update the various WebKit/* implementations to compile again.

        * loader/EmptyClients.h: Add empty defaults
        (WebCore::EmptyChromeClient::setCursor):
        (WebCore::EmptyChromeClient::scrollRectIntoView):
        (WebCore::EmptyChromeClient::requestGeolocationPermissionForFrame):
        * page/ChromeClient.h: Make methods pure virtual

577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592
2009-05-19  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Simon Hausmann.

        Fix a bug where a non visible plugin would show it self in a
        sibling frame. The problem was due to our clipping. In Qt,
        if setMask is set with an empty QRegion, no clipping will
        be performed, so in that case we hide the PluginContainer

        Added manual test.

        * plugins/qt/PluginContainerQt.cpp:
        (PluginContainerQt::adjustGeometry):
        * manual-tests/qt/plugin-sibling-frame-include.html
        * manual-tests/qt/plugin-sibling-frame.html

593 594 595 596 597 598 599 600 601 602 603 604 605
2009-05-19  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Simon Hausmann.

        Do not call the parent implementation (Widget::) in show() and hide()
        of the PluginViewQt, as it always changes the visible state of the
        platformWidget (equal to the platformPluginWidget in the Qt port),
        thus ignoring the isParentVisible() test.

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::show):
        (WebCore::PluginView::hide):

606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621
2009-05-20  Yichao Yin  <yichao.yin@torchmobile.com.cn>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=23452
        Change the implementation of HTMLNoScriptElement to avoid the pain of 
        adding virtual function for XHTMLMP support

        Includes changes suggested by Simon Fraser.

        * dom/Node.cpp:
        (WebCore::Node::styleForRenderer):
        * dom/Node.h:
        * html/HTMLNoScriptElement.cpp:
        * html/HTMLNoScriptElement.h:

622 623 624 625 626 627 628
2009-05-20  Kevin Ollivier  <kevino@theolliviers.com>

        CURL backend build fix. Make sure URL is always set.
        
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::downloadTimerCallback):

629 630 631 632 633 634 635 636
2009-05-20  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by George Staikos.

        Fix Qt WebKit build break in Mac OS.

        * platform/FileSystem.h:

637 638 639 640 641 642 643 644 645 646 647
2009-05-20  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Eric Seidel.

        Enable code that was commented out waiting for a way to get a
        GdkPixbuf from an image, effectively enabling copying images to
        the clipboard.

        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::writeImage):

648 649 650 651 652 653 654 655 656 657 658 659
2009-05-20  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=25414
        [GTK] ROLE_PANEL should not be used for paragraphs and list items.

        Implement Atk list item role for list items.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_get_role):

660 661 662 663 664 665 666 667 668 669 670 671
2009-05-20  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=25414
        [GTK] ROLE_PANEL should not be used for paragraphs and list items.

        Implement Atk paragraph role for paragraph elements.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_get_role):

672 673 674 675 676
2009-05-20  Eric Seidel  <eric@webkit.org>

        Fix bug URL in ChangeLogs in r43903.
        https://bugs.webkit.org/show_bug.cgi?id=25742

677 678 679 680 681
2009-05-20  Takeshi Yoshino <tyoshino@google.com>

        Reviewed by Eric Seidel.

        Bug 24539: Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image.
682
        https://bugs.webkit.org/show_bug.cgi?id=25742
683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705

        Fix RenderThemeChromiumWin::paintTextFieldInternal().

        We shouldn't paint the content area of text fields when o->style() has
        background image or transparent background color. paintTextFieldInternal() is
        used for painting inner area of HTML option elements by Chromium.

        When we pass fillContentArea = true to ChromiumBridge::paintTextField, it hides
        the background image rendered by RenderBoxModelObject. So, we should set
        fillContentArea = false in such case.

        Besides, when background-color:transparent is specified for CSS property,
        o->style().backgroundColor returns black color with alpha channel == 0. But
        since ThemeEngine for Windows behind ChromiumBridge::paintTextField cannot
        recognize alpha channel, it fills the rect with black. I made workaround to set
        fillContentArea = false when alpha channel == 0 to avoid this.

        And more, I'd like to fallback the color passed to ChromiumBridge to white when
        o->style()->backgroundColor() is invalid.

        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):

706 707 708 709 710 711 712 713 714 715 716 717
2009-05-20  Shinichiro Hamaji  <hamaji@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25417
        Map CompositeCopy to Skia's kSrc_Mode composite operation.

        Test: fast/canvas/canvas-composite-alpha.html

        * platform/graphics/skia/SkiaUtils.cpp:
        (WebCore::):

718 719 720 721 722 723 724 725
2009-05-20  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Rubber-stamped by Xan Lopez.

        Remove misplaced extern "C"

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

726 727 728 729 730 731 732 733 734 735 736 737
2009-05-20  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [GTK] Expose password field with role of PASSWORD_TEXT
        https://bugs.webkit.org/show_bug.cgi?id=25682

        Check if input type is a password field and return
        ATK_ROLE_PASSWORD_TEXT if it is.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

738 739 740 741 742 743 744 745 746
2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by George Staikos.

        BUG 25845: [Qt] Fix QtWebKit pkgconfig dependencies
        <https://bugs.webkit.org/show_bug.cgi?id=25845>

        * WebCore.pro: Remove QtDBus; remove QtXml if Qt >= 4.4

747 748 749 750 751 752 753 754 755
2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by George Staikos.

        BUG 25843: [Qt] Remove qt-port build flag
        <https://bugs.webkit.org/show_bug.cgi?id=25843>

        * bridge/testbindings.pro:

756 757 758 759 760 761 762 763 764 765 766
2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=25824

        [Qt] Cleanup - move files exclusive to JAVASCRIPT_DEBUGGER
        and WORKERS under the appropriate build section

        * WebCore.pro:

767 768 769 770 771 772
2009-05-20  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Unreviewed Qt build fix, after r43892.

        * platform/graphics/qt/ImageQt.cpp: included ImageObservser.h

773 774 775 776 777 778 779 780 781 782 783
2009-05-20  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=25856
        [Qt] notify an image has been drawn, to help Cache purge alive decoded data.

        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::Image::drawPattern):
        (WebCore::BitmapImage::draw):

784
2009-05-20  David Levin  <levin@chromium.org>
785

786
        Reviewed by NOBODY, layout tests fix.
787 788

        https://bugs.webkit.org/show_bug.cgi?id=23727
789
        This reverts commit r43888.
790

791 792
        Once that change was checked in many of the fast/flexbox0*.html        
        tests (and others) started failing.
793 794 795 796 797 798 799 800 801 802 803 804

        * WebCore.pro:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * css/CSSValueKeywords.in:
        * rendering/RenderMarquee.cpp:
        (WebCore::RenderMarquee::updateMarqueePosition):
        (WebCore::RenderMarquee::timerFired):

805 806 807 808 809 810 811 812 813 814 815 816 817
2009-05-19  Yichao Yin <yichao.yin@torchmobile.com.cn>

        Reviewed by George Staikos.

        Add XHTMLMP support to Webkit
        Update the configure files for building XHTMLMP-enabled WebKit on different platform
        https://bugs.webkit.org/show_bug.cgi?id=23452

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCoreSources.bkl:

antti@apple.com's avatar
antti@apple.com committed
818 819 820 821 822 823
2009-05-19  Antti Koivisto  <antti@apple.com>

        I can't figure out how to make this not timing dependent, making it manual test instead.

        * manual-tests/preload-scanner-entities.html: Added.

824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846
2009-05-19  Brady Eidson  <beidson@apple.com>

        Reviewed by Antti Koivisto. 

        <rdar://problem/6886382> REGRESSION (Safari 4PB -> ToT): HTTP cache revalidation broken.

        This was caused in http://trac.webkit.org/changeset/41425, which fixed an image caching bug
        in QuickLooks (rdar://problem/6619630).

        We need to respect the DocumentLoader's request cache policy when deciding the cache policy
        for subresources, but the check (originally removed in r39304 and added back in in the same
        place in r41424) needs to be tweaked and relocated a bit.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::subresourceCachePolicy): Renamed from cachePolicy().  Move checking
          the DocumentLoader's request to a more appropriate place. Add code to handle the recently 
          added FIXME regarding POSTs. Add a new FIXME describing a great way to make this code 
          cleaner in the future.
        * loader/FrameLoader.h:

        * loader/DocLoader.cpp:
        (WebCore::DocLoader::cachePolicy): Calls the newly renamed subresourceCachePolicy().

847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865
2009-05-19  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        Bug 25872: aria-labeledby appends all siblings instead of all children to aria name
        https://bugs.webkit.org/show_bug.cgi?id=25872

        When setting the aria-labeledby text it should stay within the element identified by the id
        when searching through the sibling list.
  
        This also removes an outdated assert in getDocumentLinks. Its possible for the document to
        think an element is a link, but accessibility can treat it differently (eg. its ARIA role is different).

        Test: accessibility/aria-labelledby-stay-within.html

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::ariaAccessiblityName):
        (WebCore::AccessibilityRenderObject::getDocumentLinks):

antti@apple.com's avatar
antti@apple.com committed
866 867 868 869 870 871 872 873 874 875 876 877 878
2009-05-19  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin Adler).
        
        <rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)
        
        Push characters back in correct order when entity parsing fails after 3 characters.

        Test: fast/tokenizer/preload-scanner-entities.html

        * html/PreloadScanner.cpp:
        (WebCore::PreloadScanner::consumeEntity):

879 880 881 882 883 884 885 886 887 888 889
2009-05-19  Paul Godavari  <paul@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix a crash in Mac Chromium when displaying an HTML select element
        with no items.
        https://bugs.webkit.org/show_bug.cgi?id=25874

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::showExternal):

890
2009-05-19  Nate Chapin  <japhet@google.com>
891

892
        Reviewed by Darin Fisher.
893

894 895
        Upstream V8 bindings for CanvasRenderingContext2D.
        https://bugs.webkit.org/show_bug.cgi?id=25858
896

897
        * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Moved bindings from v8_custom.cpp.
898

899 900 901 902 903 904 905 906
2009-05-19  Jessie Berlin  <jberlin@apple.com>

        Reviewed by Mark Rowe.

        Windows Build Fix.

        * WebCore.vcproj/WebCore.vcproj: Copy accessibility headers from WebCore.

907 908 909 910 911 912 913 914 915
2009-05-19  Timothy Hatcher  <timothy@apple.com>

        <rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not
        loaded because willSendRequest doesn't happen immediately

        Reviewed by Antti Koivisto.

        * WebCore.base.exp: Export Loader::servePendingRequests().

916 917 918 919 920 921 922 923 924 925 926
2009-05-19  David Levin  <levin@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 25859: Need to upstream ScriptController.* for v8.
        https://bugs.webkit.org/show_bug.cgi?id=25859

        Fixing the header file (which I accidentally made identical to the cpp file).

        * bindings/v8/ScriptController.h:

927 928 929 930
2009-05-19  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin Adler and Brady Eidson.

ap@webkit.org's avatar
ap@webkit.org committed
931
        <rdar://problem/6900582> REGRESSION (r42446?): UA Profiler in http://stevesouders.com/ua/ stalls
932 933 934 935 936 937 938 939 940 941 942

        The problem was that Document::removeAllEventListeners() was called for a wrong document
        when a CachedFrame was destroyed.

        Cannot be tested automatically, because DRT doesn't have a b/f cache.

        * dom/Document.cpp: (WebCore::Document::domWindow): Make sure that this doesn't return an
        unrelated window even if document's m_frame pointer is stale.

        * history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Added a FIXME about strange behavior.

943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035
2009-05-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Split InspectorController into InspectorController and InspectorFrontend. Latter encapsulates all frontend interaction and is the only entity allowed to make ScriptFunctionCalls. The further plan is to serialize these script function calls.

        https://bugs.webkit.org/show_bug.cgi?id=25419

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToConsole):
        * inspector/ConsoleMessage.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::inspect):
        (WebCore::InspectorController::focusNode):
        (WebCore::InspectorController::setWindowVisible):
        (WebCore::InspectorController::addConsoleMessage):
        (WebCore::InspectorController::setAttachedWindow):
        (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
        (WebCore::InspectorController::scriptObjectReady):
        (WebCore::InspectorController::showPanel):
        (WebCore::InspectorController::close):
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::resetScriptObjects):
        (WebCore::InspectorController::pruneResources):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::didLoadResourceFromMemoryCache):
        (WebCore::InspectorController::identifierForInitialRequest):
        (WebCore::InspectorController::willSendRequest):
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didReceiveContentLength):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):
        (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorController::scriptImported):
        (WebCore::InspectorController::didOpenDatabase):
        (WebCore::InspectorController::didUseDOMStorage):
        (WebCore::InspectorController::addScriptProfile):
        (WebCore::InspectorController::toggleRecordButton):
        (WebCore::InspectorController::enableProfiler):
        (WebCore::InspectorController::disableProfiler):
        (WebCore::InspectorController::enableDebugger):
        (WebCore::InspectorController::disableDebugger):
        (WebCore::InspectorController::didParseSource):
        (WebCore::InspectorController::failedToParseSource):
        (WebCore::InspectorController::didPause):
        (WebCore::InspectorController::didContinue):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMStorageResource.cpp:
        (WebCore::InspectorDOMStorageResource::bind):
        * inspector/InspectorDOMStorageResource.h:
        * inspector/InspectorDatabaseResource.cpp:
        (WebCore::InspectorDatabaseResource::bind):
        * inspector/InspectorDatabaseResource.h:
        * inspector/InspectorFrontend.cpp: Added.
        (WebCore::callSimpleFunction):
        (WebCore::InspectorFrontend::InspectorFrontend):
        (WebCore::InspectorFrontend::~InspectorFrontend):
        (WebCore::InspectorFrontend::newJSONObject):
        (WebCore::InspectorFrontend::addMessageToConsole):
        (WebCore::InspectorFrontend::addResource):
        (WebCore::InspectorFrontend::updateResource):
        (WebCore::InspectorFrontend::removeResource):
        (WebCore::InspectorFrontend::updateFocusedNode):
        (WebCore::InspectorFrontend::setAttachedWindow):
        (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared):
        (WebCore::InspectorFrontend::showPanel):
        (WebCore::InspectorFrontend::populateInterface):
        (WebCore::InspectorFrontend::reset):
        (WebCore::InspectorFrontend::debuggerWasEnabled):
        (WebCore::InspectorFrontend::debuggerWasDisabled):
        (WebCore::InspectorFrontend::profilerWasEnabled):
        (WebCore::InspectorFrontend::profilerWasDisabled):
        (WebCore::InspectorFrontend::parsedScriptSource):
        (WebCore::InspectorFrontend::failedToParseScriptSource):
        (WebCore::InspectorFrontend::addProfile):
        (WebCore::InspectorFrontend::setRecordingProfile):
        (WebCore::InspectorFrontend::pausedScript):
        (WebCore::InspectorFrontend::resumedScript):
        (WebCore::InspectorFrontend::addDatabase):
        (WebCore::InspectorFrontend::addDOMStorage):
        * inspector/InspectorFrontend.h: Added.
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::createScriptObject):
        (WebCore::InspectorResource::updateScriptObject):
        (WebCore::InspectorResource::releaseScriptObject):
        * inspector/InspectorResource.h:

1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065
2009-05-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Introduce JSONObject that wraps ScriptObject and ScriptState* for further serialization

        https://bugs.webkit.org/show_bug.cgi?id=25419

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToConsole):
        * inspector/InspectorDOMStorageResource.cpp:
        (WebCore::InspectorDOMStorageResource::bind):
        * inspector/InspectorDatabaseResource.cpp:
        (WebCore::InspectorDatabaseResource::bind):
        * inspector/InspectorResource.cpp:
        (WebCore::populateHeadersObject):
        (WebCore::InspectorResource::createScriptObject):
        (WebCore::InspectorResource::updateScriptObject):
        * inspector/JSONObject.cpp: Added.
        (WebCore::JSONObject::JSONObject):
        (WebCore::JSONObject::set):
        (WebCore::JSONObject::scriptObject):
        (WebCore::JSONObject::createNew):
        * inspector/JSONObject.h: Added.

1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110
2009-05-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Refactor InpectorController so that it does not instantiate resource/console/database/domresource javascript objects. Move instantiation into the javascript.

        https://bugs.webkit.org/show_bug.cgi?id=25419

        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToConsole):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didReceiveContentLength):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):
        (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorController::scriptImported):
        * inspector/InspectorDOMStorageResource.cpp:
        (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
        (WebCore::InspectorDOMStorageResource::bind):
        (WebCore::InspectorDOMStorageResource::unbind):
        * inspector/InspectorDOMStorageResource.h:
        * inspector/InspectorDatabaseResource.cpp:
        (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
        (WebCore::InspectorDatabaseResource::bind):
        (WebCore::InspectorDatabaseResource::unbind):
        * inspector/InspectorDatabaseResource.h:
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::InspectorResource):
        (WebCore::populateHeadersObject):
        (WebCore::InspectorResource::createScriptObject):
        (WebCore::InspectorResource::updateScriptObject):
        (WebCore::InspectorResource::releaseScriptObject):
        * inspector/InspectorResource.h:
        * inspector/front-end/Console.js:
        (WebInspector.ConsoleMessage):
        * inspector/front-end/inspector.js:
        (WebInspector.addResource):
        (WebInspector.updateResource):
        (WebInspector.removeResource):
        (WebInspector.addDatabase):
        (WebInspector.addDOMStorage):
        (WebInspector.reset):
        (WebInspector.addMessageToConsole):

1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133
2009-05-19  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Ariya Hidayat.

        The Qt port has code that disables scrolling optimizations
        when the root contains native windows, such as windowed plugins.

        This code broke when detaching iframes containing windowed
        plugins.

        Each ScrollView now knows how many native windows it and its
        children contain, and when it is detached, that number is
        substracted from its old parents.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollContents):
        (WebCore::ScrollView::setParent):
        * platform/ScrollView.h:
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::adjustWidgetsPreventingBlittingCount):
        (WebCore::ScrollView::platformAddChild):
        (WebCore::ScrollView::platformRemoveChild):

1134 1135 1136 1137 1138 1139 1140 1141
2009-05-18  David Kilzer  <ddkilzer@apple.com>

        Tiger build fix for r43850

        * platform/mac/ClipboardMac.mm: Added typedef for NSUinteger
        when building on Tiger.

2009-05-18  Eric Seidel  <eric@webkit.org>
1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170

        Reviewed by Darin Adler.

        ClipboardMac cleanup
        https://bugs.webkit.org/show_bug.cgi?id=25847

        I'm mostly just moving code, however there are 3 changes I made while moving, detailed below.

        No functional changes, so no tests.

        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::clearData):
        (WebCore::absoluteURLsFromPasteboardFilenames):
          Broke out logic for filenames into its own function to make the caller more readable.
        (WebCore::absoluteURLsFromPasteboard):
          Broke out logic from getData into absoluteURLsFromPasteboard. This returns an NSArray
          so that we can use -[NSArray componentsJoinedByString] in the caller (which is
          cleaner than the manual "\n" addition before).
          This also access to the full list of file urls for future callers.
        (WebCore::ClipboardMac::getData):
          unsigned count = (type == "URL") ? 1 : [fileList count]; is now an
          explicit check for "URL", before it was a check for != "text/uri-list" which
          was much more confusing in my opinion.  text/uri-list and URL are the only
          two types which map to NSURLPboardType in cocoaTypeFromMIMEType().
        (WebCore::ClipboardMac::types):
          I removed an extra if (!types) check, right before [types count].  In Obj-C
          messaging nil will return 0 (size of a pointer), so it's safe to message nil
          here and expect it to return 0.

1171 1172 1173 1174 1175 1176 1177 1178 1179 1180
2009-05-18  David Levin  <levin@chromium.org>

        Reviewed by Darin Fisher.

        Bug 25859: Need to upstream ScriptController.* for v8.
        https://bugs.webkit.org/show_bug.cgi?id=25859

        * bindings/v8/ScriptController.cpp: Added.
        * bindings/v8/ScriptController.h: Added.

1181 1182 1183 1184 1185
2009-05-18  Yichao Yin  <yichao.yin@torchmobile.com.cn>

        Reviewed by George Staikos.

        Change ScriptElement to support XHTMLMP in a better way
1186
        https://bugs.webkit.org/show_bug.cgi?id=23452
1187 1188 1189 1190 1191 1192

        * dom/ScriptElement.h:
        * html/HTMLScriptElement.h:
        * svg/SVGScriptElement.h:
        (WebCore::SVGScriptElement::shouldExecuteAsJavaScript):

1193 1194 1195 1196 1197 1198
2009-05-18  Kevin Ollivier  <kevino@theolliviers.com>

        wx build fix, finish up changes after the accessibility dir split.

        * webcore-base.bkl:

1199 1200 1201 1202 1203
2009-05-18  Yichao Yin  <yichao.yin@torchmobile.com.cn>

        Reviewed by George Staikos (and others).

        Add XHTMLMP support to Webkit
1204
        https://bugs.webkit.org/show_bug.cgi?id=23452
1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273
        XHTMLMP is a strict subset of XHTML 1.1. It extends XHTML Basic and add enhanced
        functionality. Most of the functionalities have already been implemented by Webkit.
        
        The changes include:
        1) Adding <noscript> support
        2) Document conformance validation
        3) User Agent conformance validation
 
        refer to the specification: OMA-WAP-XHTMLMP-V1_1-20061020-A.pdf

        Tests: fast/xhtmlmp/check-doctype-declaration.xhtml
               fast/xhtmlmp/check-rootelement.xhtml
               fast/xhtmlmp/noscript-in-multiscripts.xhtml
               fast/xhtmlmp/noscript-nested.xhtml
               fast/xhtmlmp/noscript.xhtml

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::isXHTMLMPDocument):
        * dom/Document.h:
        (WebCore::Document::shouldProcessNoscriptElement):
        (WebCore::Document::setShouldProcessNoscriptElement):
        * dom/Node.cpp:
        (WebCore::Node::createRendererIfNeeded):
        * dom/Node.h:
        * dom/XMLTokenizer.h:
        (WebCore::XMLTokenizer::setIsXHTMLMPDocument):
        (WebCore::XMLTokenizer::isXHTMLMPDocument):
        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::XMLTokenizer):
        (WebCore::XMLTokenizer::startElementNs):
        (WebCore::XMLTokenizer::endElementNs):
        (WebCore::XMLTokenizer::endDocument):
        (WebCore::XMLTokenizer::internalSubset):
        (WebCore::getEntityHandler):
        (WebCore::externalSubsetHandler):
        * dom/XMLTokenizerQt.cpp:
        (WebCore::XMLTokenizer::XMLTokenizer):
        (WebCore::XMLTokenizer::parse):
        (WebCore::XMLTokenizer::parseStartElement):
        (WebCore::XMLTokenizer::parseEndElement):
        (WebCore::):
        * dom/make_names.pl:
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::rendererIsNeeded):
        * html/HTMLNoScriptElement.cpp: Added.
        (WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
        (WebCore::HTMLNoScriptElement::~HTMLNoScriptElement):
        (WebCore::HTMLNoScriptElement::checkDTD):
        (WebCore::HTMLNoScriptElement::attach):
        (WebCore::HTMLNoScriptElement::recalcStyle):
        (WebCore::HTMLNoScriptElement::childShouldCreateRenderer):
        (WebCore::HTMLNoScriptElement::styleForRenderer):
        * html/HTMLNoScriptElement.h: Added.
        (WebCore::HTMLNoScriptElement::rendererIsNeeded):
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::getNode):
        (WebCore::HTMLParser::isInline):
        * html/HTMLTagNames.in:
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptHandler):
        (WebCore::HTMLTokenizer::notifyFinished):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::addExtraFieldsToRequest):
        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeSupportedNonImageMimeTypes):

mrowe@apple.com's avatar
mrowe@apple.com committed
1274 1275 1276 1277 1278 1279
2009-05-18  Mark Rowe  <mrowe@apple.com>

        Fix the build.

        * WebCore.xcodeproj/project.pbxproj:

1280 1281 1282 1283 1284 1285 1286 1287 1288
2009-05-18  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Rubber-stamped by Gustavo Noronha.

        Fixed build for the Qt port by adding the WebCore/accessibility
        directory to the includepath.

        * WebCore.pro:

1289 1290 1291 1292 1293 1294 1295 1296 1297
2009-05-18  Chris Fleizach  <cfleizach@apple.com>

        Bug 25776: accessibility should have its own folder in WebCore project
        https://bugs.webkit.org/show_bug.cgi?id=25776
   
        Speculative fix for windows build failure.

        * WebCore.vcproj/WebCoreCommon.vsprops:

1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314
2009-05-18  David Kilzer  <ddkilzer@apple.com>

        Bug 20652: WebKit doesn't display favicons with MIME type image/vnd.microsoft.icon

        <https://bugs.webkit.org/show_bug.cgi?id=20652>

        Reviewed by Darin Adler.

        Test: http/tests/misc/favicon-as-image.html

        * inspector/front-end/inspector.js: Added
        image/vnd.microsoft.icon to WebInspector.MIMETypes.
        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeSupportedImageMIMETypes): Added
        image/vnd.microsoft.icon to list of supported image and image
        resource MIME types.

1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426
2009-05-18  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Sam Weinig.

        Bug 25776: accessibility should have its own folder in WebCore project
        https://bugs.webkit.org/show_bug.cgi?id=25776

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * accessibility: Added.
        * accessibility/AXObjectCache.cpp: Copied from WebCore/page/AXObjectCache.cpp.
        * accessibility/AXObjectCache.h: Copied from WebCore/page/AXObjectCache.h.
        * accessibility/AccessibilityAriaGrid.cpp: Copied from WebCore/page/AccessibilityAriaGrid.cpp.
        * accessibility/AccessibilityAriaGrid.h: Copied from WebCore/page/AccessibilityAriaGrid.h.
        * accessibility/AccessibilityAriaGridCell.cpp: Copied from WebCore/page/AccessibilityAriaGridCell.cpp.
        * accessibility/AccessibilityAriaGridCell.h: Copied from WebCore/page/AccessibilityAriaGridCell.h.
        * accessibility/AccessibilityAriaGridRow.cpp: Copied from WebCore/page/AccessibilityAriaGridRow.cpp.
        * accessibility/AccessibilityAriaGridRow.h: Copied from WebCore/page/AccessibilityAriaGridRow.h.
        * accessibility/AccessibilityImageMapLink.cpp: Copied from WebCore/page/AccessibilityImageMapLink.cpp.
        * accessibility/AccessibilityImageMapLink.h: Copied from WebCore/page/AccessibilityImageMapLink.h.
        * accessibility/AccessibilityList.cpp: Copied from WebCore/page/AccessibilityList.cpp.
        * accessibility/AccessibilityList.h: Copied from WebCore/page/AccessibilityList.h.
        * accessibility/AccessibilityListBox.cpp: Copied from WebCore/page/AccessibilityListBox.cpp.
        * accessibility/AccessibilityListBox.h: Copied from WebCore/page/AccessibilityListBox.h.
        * accessibility/AccessibilityListBoxOption.cpp: Copied from WebCore/page/AccessibilityListBoxOption.cpp.
        * accessibility/AccessibilityListBoxOption.h: Copied from WebCore/page/AccessibilityListBoxOption.h.
        * accessibility/AccessibilityObject.cpp: Copied from WebCore/page/AccessibilityObject.cpp.
        * accessibility/AccessibilityObject.h: Copied from WebCore/page/AccessibilityObject.h.
        * accessibility/AccessibilityRenderObject.cpp: Copied from WebCore/page/AccessibilityRenderObject.cpp.
        * accessibility/AccessibilityRenderObject.h: Copied from WebCore/page/AccessibilityRenderObject.h.
        * accessibility/AccessibilityTable.cpp: Copied from WebCore/page/AccessibilityTable.cpp.
        * accessibility/AccessibilityTable.h: Copied from WebCore/page/AccessibilityTable.h.
        * accessibility/AccessibilityTableCell.cpp: Copied from WebCore/page/AccessibilityTableCell.cpp.
        * accessibility/AccessibilityTableCell.h: Copied from WebCore/page/AccessibilityTableCell.h.
        * accessibility/AccessibilityTableColumn.cpp: Copied from WebCore/page/AccessibilityTableColumn.cpp.
        * accessibility/AccessibilityTableColumn.h: Copied from WebCore/page/AccessibilityTableColumn.h.
        * accessibility/AccessibilityTableHeaderContainer.cpp: Copied from WebCore/page/AccessibilityTableHeaderContainer.cpp.
        * accessibility/AccessibilityTableHeaderContainer.h: Copied from WebCore/page/AccessibilityTableHeaderContainer.h.
        * accessibility/AccessibilityTableRow.cpp: Copied from WebCore/page/AccessibilityTableRow.cpp.
        * accessibility/AccessibilityTableRow.h: Copied from WebCore/page/AccessibilityTableRow.h.
        * accessibility/chromium: Added.
        * accessibility/chromium/AXObjectCacheChromium.cpp: Copied from WebCore/page/chromium/AXObjectCacheChromium.cpp.
        * accessibility/chromium/AccessibilityObjectChromium.cpp: Copied from WebCore/page/chromium/AccessibilityObjectChromium.cpp.
        * accessibility/chromium/AccessibilityObjectWrapper.h: Copied from WebCore/page/chromium/AccessibilityObjectWrapper.h.
        * accessibility/gtk: Added.
        * accessibility/gtk/AXObjectCacheAtk.cpp: Copied from WebCore/page/gtk/AXObjectCacheAtk.cpp.
        * accessibility/gtk/AccessibilityObjectAtk.cpp: Copied from WebCore/page/gtk/AccessibilityObjectAtk.cpp.
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: Copied from WebCore/page/gtk/AccessibilityObjectWrapperAtk.cpp.
        * accessibility/gtk/AccessibilityObjectWrapperAtk.h: Copied from WebCore/page/gtk/AccessibilityObjectWrapperAtk.h.
        * accessibility/mac: Added.
        * accessibility/mac/AXObjectCacheMac.mm: Copied from WebCore/page/mac/AXObjectCacheMac.mm.
        * accessibility/mac/AccessibilityObjectMac.mm: Copied from WebCore/page/mac/AccessibilityObjectMac.mm.
        * accessibility/mac/AccessibilityObjectWrapper.h: Copied from WebCore/page/mac/AccessibilityObjectWrapper.h.
        * accessibility/mac/AccessibilityObjectWrapper.mm: Copied from WebCore/page/mac/AccessibilityObjectWrapper.mm.
        * accessibility/qt: Added.
        * accessibility/qt/AccessibilityObjectQt.cpp: Copied from WebCore/page/qt/AccessibilityObjectQt.cpp.
        * accessibility/win: Added.
        * accessibility/win/AXObjectCacheWin.cpp: Copied from WebCore/page/win/AXObjectCacheWin.cpp.
        * accessibility/win/AccessibilityObjectWin.cpp: Copied from WebCore/page/win/AccessibilityObjectWin.cpp.
        * accessibility/win/AccessibilityObjectWrapperWin.h: Copied from WebCore/page/win/AccessibilityObjectWrapperWin.h.
        * accessibility/wx: Added.
        * accessibility/wx/AccessibilityObjectWx.cpp: Copied from WebCore/page/wx/AccessibilityObjectWx.cpp.
        * page/AXObjectCache.cpp: Removed.
        * page/AXObjectCache.h: Removed.
        * page/AccessibilityAriaGrid.cpp: Removed.
        * page/AccessibilityAriaGrid.h: Removed.
        * page/AccessibilityAriaGridCell.cpp: Removed.
        * page/AccessibilityAriaGridCell.h: Removed.
        * page/AccessibilityAriaGridRow.cpp: Removed.
        * page/AccessibilityAriaGridRow.h: Removed.
        * page/AccessibilityImageMapLink.cpp: Removed.
        * page/AccessibilityImageMapLink.h: Removed.
        * page/AccessibilityList.cpp: Removed.
        * page/AccessibilityList.h: Removed.
        * page/AccessibilityListBox.cpp: Removed.
        * page/AccessibilityListBox.h: Removed.
        * page/AccessibilityListBoxOption.cpp: Removed.
        * page/AccessibilityListBoxOption.h: Removed.
        * page/AccessibilityObject.cpp: Removed.
        * page/AccessibilityObject.h: Removed.
        * page/AccessibilityRenderObject.cpp: Removed.
        * page/AccessibilityRenderObject.h: Removed.
        * page/AccessibilityTable.cpp: Removed.
        * page/AccessibilityTable.h: Removed.
        * page/AccessibilityTableCell.cpp: Removed.
        * page/AccessibilityTableCell.h: Removed.
        * page/AccessibilityTableColumn.cpp: Removed.
        * page/AccessibilityTableColumn.h: Removed.
        * page/AccessibilityTableHeaderContainer.cpp: Removed.
        * page/AccessibilityTableHeaderContainer.h: Removed.
        * page/AccessibilityTableRow.cpp: Removed.
        * page/AccessibilityTableRow.h: Removed.
        * page/chromium/AXObjectCacheChromium.cpp: Removed.
        * page/chromium/AccessibilityObjectChromium.cpp: Removed.
        * page/chromium/AccessibilityObjectWrapper.h: Removed.
        * page/gtk/AXObjectCacheAtk.cpp: Removed.
        * page/gtk/AccessibilityObjectAtk.cpp: Removed.
        * page/gtk/AccessibilityObjectWrapperAtk.cpp: Removed.
        * page/gtk/AccessibilityObjectWrapperAtk.h: Removed.
        * page/mac/AXObjectCacheMac.mm: Removed.
        * page/mac/AccessibilityObjectMac.mm: Removed.
        * page/mac/AccessibilityObjectWrapper.h: Removed.
        * page/mac/AccessibilityObjectWrapper.mm: Removed.
        * page/qt/AccessibilityObjectQt.cpp: Removed.
        * page/win/AXObjectCacheWin.cpp: Removed.
        * page/win/AccessibilityObjectWin.cpp: Removed.
        * page/win/AccessibilityObjectWrapperWin.h: Removed.
        * page/wx/AccessibilityObjectWx.cpp: Removed.

1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439
2009-05-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=25854
        [GTK] Should tell servers we only support identity as content encoding

        Let servers know we only support identity as content
        encoding. We will implement this in libsoup.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::startHttp):

ap@webkit.org's avatar
ap@webkit.org committed
1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459
2009-05-18  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin Adler.

        <rdar://problem/6881160> REGRESSION (r41425): Unable to create battle.net account due to
        CAPTCHA failure.

        The problem was that after loading and displaying a CAPTCHA image, it was loaded from
        the server again due to preloading. So, the server expected the last loaded (invisible)
        CAPTCHA text to be typed and posted back.

        I don't know how to make tests for preloading.

        * loader/DocLoader.cpp: (WebCore::DocLoader::checkForPendingPreloads): There is never a reason
        to preload after loading for real - and if cache policy is CachePolicyReload, that actually
        results in another load from network layer.

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): It's not good for cachePolicy()
        to lie, but I don't know how to re-do r41425 properly. Added a FIXME.

1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475
2009-05-18  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Hausmann.

        Done together with Balazs Kelemen  <kelemen.balazs@stud.u-szeged.hu>.

        https://bugs.webkit.org/show_bug.cgi?id=24551

        [Qt] Reuse FontPlatformData for the same FontDescription.
        This effectively prevents growing heap usage for loading every web page.

        * platform/graphics/qt/FontCacheQt.cpp:
        (WebCore::qHash): Necessary for FontPlatformDataCache.
        (WebCore::FontCache::getCachedFontPlatformData): Reuse the instance if
        it exists, otherwise create a new one and insert it in the cache.

1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490
2009-05-18  Balazs Kelemen  <kelemen.balazs@stud.u-szeged.hu>

        Reviewed by Ariya Hidayat.

        https://bugs.webkit.org/show_bug.cgi?id=24551

        [Qt] Fix the leak in FontFallbackList::fontDataAt() function.
        When creating a new instance of SimpleFontData, put it in the font list
        so that it can deleted later on.

        * platform/graphics/qt/FontFallbackListQt.cpp:
        (WebCore::FontFallbackList::invalidate):
        (WebCore::FontFallbackList::releaseFontData):
        (WebCore::FontFallbackList::fontDataAt):

1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501
2009-05-15  Jan Michael Alonzo  <jmalonzo@webkit.org>

         Reviewed by Xan Lopez.

         [Gtk] Various autotools build refactoring and fixes
         https://bugs.webkit.org/show_bug.cgi?id=25286

         Style fixes

         * GNUmakefile.am:

1502 1503 1504 1505 1506 1507 1508 1509 1510
2009-05-17  George Staikos  <george.staikos@torchmobile.com>

        Not reviewed - build fix.

        Fix typo: constr -> const.

        * wml/WMLInputElement.h:
        (WebCore::WMLInputElement::setPlaceholder):

1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522
2009-05-17  Darin Adler  <darin@apple.com>

        Fix done by Simon Fraser (reviewed by me).

        <rdar://problem/6893775> Page with screen-only stylesheet with overflow and height
        transitions has bad layout and overlapping garbled text when printing

        * manual-tests/print-with-height-transition-in-screen-stylesheet.html: Added.

        * page/animation/AnimationController.cpp:
        (WebCore::AnimationController::updateAnimations): Don't run transitions when printing.

1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534
2009-05-17  Darin Adler  <darin@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6870241> REGRESSION: Programmatically selected popup menu item not shown

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setSelectedIndex): Added a call to updateFromElement and
        also a type check on the selected index to avoid a bad cast to HTMLOptionElement.

        * manual-tests/select-option-in-onload.html: Added.

1535 1536 1537 1538 1539 1540 1541 1542 1543
2009-05-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        Rename local variables for readability.
        
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBorder):

1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564
2009-05-17  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Bug 25840: fix some warnings seen on the GTK bot
        https://bugs.webkit.org/show_bug.cgi?id=25840

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::platformScrollbarModes): Initialize results here.
        This is really just to quiet warnings. I think this code is unreachable.
        Someone could put ASSERT_NOT_REACHED() in here too at some point.

        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::startStream): Use proper printf format for int
        here, %d, not %lu. This could cause a real problem when compiled 64-bit,
        so it's good to fix.

        * rendering/RenderTextControl.cpp:
        (WebCore::getNextSoftBreak): Initialize breakOffset to 0 here. This is
        really just to quiet the warning, but still seems like a good idea.

1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576
2009-05-17  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Bug 25769: Fix accessibility warnings on GTK
        https://bugs.webkit.org/show_bug.cgi?id=25769

        * page/AccessibilityTable.cpp:
        (WebCore::AccessibilityTable::columnCount): Get rid of excess const.
        (WebCore::AccessibilityTable::rowCount): Ditto.
        * page/AccessibilityTable.h: Ditto.

darin@apple.com's avatar
darin@apple.com committed
1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588
2009-05-17  Kai Brüning  <kai@granus.net>

        Reviewed by Darin Adler.

        bug 25822: DOM normalize does not remove empty text node between element nodes
        https://bugs.webkit.org/show_bug.cgi?id=25822

        Test: fast/dom/Node/normalize.html

        * dom/Node.cpp:
        (WebCore::Node::normalize): Changed to remove any empty text nodes.

1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605
2009-05-16  Dave Moore  <davemoore@google.com>

        Reviewed by Darin Adler.

        Allow Strings to be created with one malloc node with no copying
        https://bugs.webkit.org/show_bug.cgi?id=25779

        Add new methods to String and StringImpl, refactoring existing
        methods in StringImpl to use new createUninitialized() method.

        * platform/text/PlatformString.h:
        (WebCore::String::createUninitialized):
        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::createUninitialized):
        (WebCore::StringImpl::create):
        * platform/text/StringImpl.h:

1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622
2009-05-16  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6827041> WebCore should stop throwing away the CGImageSourceRef to
        dramatically improve animated GIF decoding performance

        Recent versions of ImageIO discard previously decoded image frames if the client
        application no longer holds references to them, so there's no need to throw away
        the decoder unless we're explicitly asked to destroy all of the frames.

        This drops peak CPU usage when displaying <http://www.aintitcool.com/files/HoD2.gif>
        from over 90% to below 3%.

        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::ImageSource::clear):

mitz@apple.com's avatar
mitz@apple.com committed
1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641
2009-05-16  Dan Bernstein  <mitz@apple.com>

        Reviewed by Alexey Proskuryakov.

        - fix <rdar://problem/6873305> Two distinct characters are not displayed
          correctly with 2 of the font selections from the stickies widget

        Test: platform/mac/editing/pasteboard/text-precomposed.html

        Ensure that "text/plain" data retrieved from the clipboard is always
        precomposed. This makes Clipboard::getData() and
        Pasteboard::documentFragment() consistent with Pasteboard::plainText()
        and -[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:].

        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::getData):
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::documentFragment):

mrowe@apple.com's avatar
mrowe@apple.com committed
1642 1643 1644 1645 1646 1647 1648
2009-05-16  Mark Rowe  <mrowe@apple.com>

        Build fix.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForFamily): Declare valueForFamily as static.

darin@apple.com's avatar
darin@apple.com committed
1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666
2009-05-15  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
        only the generic font, if any generic font is in the family list

        Test: fast/css/getComputedStyle/computed-style-font-family.html

        * css/CSSComputedStyleDeclaration.cpp:
        Sorted computedProperties alphabetically. Added CSSPropertyClip and CSSPropertyWordBreak.
        (WebCore::identifierForFamily): Added. Maps internal font family names to identifiers.
        (WebCore::valueForFamily): Added. Creates either an identifier or a string as appropriate.
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implemented the font-family
        property as specified in the CSS standard. Fixed clip to return "auto" when there is no
        clip set instead of nothing at all. Gave inheritableProperties and numInheritableProperties
        internal linkage since there was no reason for them to have external linkage.

abarth@webkit.org's avatar
abarth@webkit.org committed
1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680
2009-05-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=25741

        Append instead of throwing when insertItemBefore gets an out-of-bound
        index.

        Test: svg/dom/svglist-insertItemBefore-appends.html

        * svg/SVGList.h:
        (WebCore::SVGList::insertItemBefore):

1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693
2009-05-15  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler
        
        https://bugs.webkit.org/show_bug.cgi?id=25829
        
        Fix -webkit-background-clip:text when the renderer had a non (0,0) x, y offset.

        Test: fast/backgrounds/background-clip-text.html

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):

mitz@apple.com's avatar
mitz@apple.com committed
1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712
2009-05-15  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        - fix <rdar://problem/6888244> REGRESSION: Using the Up or Down keyboard
          arrows, I can't navigate caret between To Do items in a Note message

        Test: editing/selection/move-by-line-004.html

        * editing/visible_units.cpp:
        (WebCore::enclosingNodeWithNonInlineRenderer): Added this helper
        function.
        (WebCore::previousLinePosition): When advancing to the next candidate
        node, stop when leaving the closest ancestor of the original node that
        is not an inline. The code, incorrectly, was trying to exit the closest
        ancestor of that type which was editable, and therefore missing other
        blocks in the same editable root.
        (WebCore::nextLinePosition): Ditto.

1713 1714 1715 1716 1717 1718 1719 1720 1721 1722
2009-05-15  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Jan Alonzo.

        Converting filename to uri by concatenating strings is broken
        on Windows. So, don't do it for that platform.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::startGio):

1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738
2009-05-15  Nate Chapin  <japhet@google.com>

        Reviewed by Dimitri Glazkov.

        Upstream V8 bindings for HTMLOptionsCollection and HTMLSelectElementCollection.
        https://bugs.webkit.org/show_bug.cgi?id=25739

        * bindings/v8/V8Collection.cpp: Added.
        (WebCore::toOptionsCollectionSetter): Moved from v8_custom.cpp.
        * bindings/v8/V8Collection.h: Added prototype for toOptionsCollectionSetter().
        * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
        (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
        * bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Added.
        (WebCore::NAMED_PROPERTY_GETTER):  Moved from v8_custom.cpp.
        (WebCore::INDEXED_PROPERTY_SETTER):  Moved from v8_custom.cpp.

1739 1740 1741 1742 1743 1744 1745 1746 1747 1748
2009-05-15  David Kilzer  <ddkilzer@apple.com>

        <rdar://problem/6649936> Add *.exp export files to WebCore Xcode project

        Reviewed by Darin Adler and Timothy Hatcher.

        * WebCore.xcodeproj/project.pbxproj: Added Exports group, moved
        WebCore.base.exp into the group, and added 10 other *.exp files
        in WebCore.

1749 1750 1751 1752 1753 1754 1755 1756 1757
2009-05-15  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        https://bugs.webkit.org/show_bug.cgi?id=25826
        Change type to only have custom getter in JCS.

        * html/HTMLInputElement.idl: Changed CustomGetter attribute to JSCCustomGetter.

1758 1759 1760 1761 1762 1763 1764 1765 1766 1767
2009-05-15  Antti Koivisto  <antti@apple.com>

        Reviewed by Dave Kilzer.

        Add a settings entry to en/disable web font support
        https://bugs.webkit.org/show_bug.cgi?id=25239

        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule):

1768 1769 1770 1771 1772 1773 1774 1775 1776
2009-05-15  Sam Weinig  <sam@webkit.org>

        Reviewed by Steve Falkenburg.

        Remove dead youtube site specific hack that was commented out.

        * bindings/js/JSNavigatorCustom.cpp:
        * page/Navigator.idl:

1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791
2009-05-15  Sam Weinig  <sam@webkit.org>

        Reviewed by Beth Dakin.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=25826
        <rdar://problem/6884742> 
        REGRESSION: In Gmail's Edit Link dialog, I can't type in the Link To: field (due to <input type=url> support)

        Added a site specific quirk for mail.google.com which returns "text" when getting the type of an <input type=url>

        * bindings/js/JSHTMLInputElementCustom.cpp:
        (WebCore::needsGmailQuirk):
        (WebCore::JSHTMLInputElement::type):
        * html/HTMLInputElement.idl:

1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810
2009-05-14  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25810
        Upstream V8 DOM Wrapper map declarations.

        No behavior change, so no tests.

        * bindings/v8/V8DOMMap.h:
        (WebCore::WeakReferenceMap::WeakReferenceMap): Added.
        (WebCore::WeakReferenceMap::~WeakReferenceMap): Added.
        (WebCore::WeakReferenceMap::get): Added.
        (WebCore::WeakReferenceMap::set): Added.
        (WebCore::WeakReferenceMap::forget): Added.
        (WebCore::WeakReferenceMap::contains): Added.
        (WebCore::WeakReferenceMap::impl): Added.
        (WebCore::DOMWrapperMap::DOMWrapperMap): Added.

1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840
2009-05-15  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt
        
        https://bugs.webkit.org/show_bug.cgi?id=25773
        
        Rename GraphicsLayer::graphicsContextsFlipped() to 
        GraphicsLayer::compositingCoordinatesOrientation() in order to clarify the usage.

        Clean up code around the GraphicsLayer "contents" layer that makes use of this
        flag, by removing the setHasContentsLayer() method, and just using setContentsLayer(),
        which can then always do the flipping if necessary.

        Only affects ACCELERATED_COMPOSITING builds.
        
        * platform/graphics/GraphicsLayer.h:
        (WebCore::GraphicsLayer::):
        * platform/graphics/mac/GraphicsLayerCA.h:
        (WebCore::GraphicsLayerCA::contentsLayer):
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayer::compositingCoordinatesOrientation):
        (WebCore::GraphicsLayerCA::setBackgroundColor):
        (WebCore::GraphicsLayerCA::clearBackgroundColor):
        (WebCore::GraphicsLayerCA::setContentsToImage):
        (WebCore::GraphicsLayerCA::clearContents):
        (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
        (WebCore::GraphicsLayerCA::setContentsLayer):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):

1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854
2009-05-15  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=25765

        Avoid calling setNeedsStyleRecalc() when we are
        putting an animated page in the cache. This avoids
        the assert and subsequent problems with a dirty 
        page going into the cache.

        * page/animation/KeyframeAnimation.cpp:
        (WebCore::KeyframeAnimation::endAnimation):

1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866
2009-05-15  Francisco Tolmasky  <francisco@280north.com>

        BUG 25467: JavaScript debugger should use function.displayName as the function's name in the call stack
        <https://bugs.webkit.org/show_bug.cgi?id=25467>
        
        Reviewed by Adam Roben.

        * inspector/JavaScriptCallFrame.cpp:
        (WebCore::JavaScriptCallFrame::functionName): Use calculatedFunctionName which takes into account displayName
        * inspector/front-end/CallStackSidebarPane.js: Remove "|| anonymous function" since it is handled internally just like in profiles
        (WebInspector.CallStackSidebarPane.prototype.update):

1867 1868 1869 1870 1871 1872 1873 1874 1875 1876
2009-05-15  Alexey Proskuryakov  <ap@webkit.org>

        Windows build fix (and a matching Mac change, to avoid unnecessarily diverging the implementations).

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::start):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):
        Check strings with isEmpty(), not relying on any implicit conversions.

1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898
2009-05-15  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin Adler, Brady Eidson and Eric Carlson.

        <rdar://problem/6875643> REGRESSION: Unable to download file with FTP URL that includes
        username and password (Lightwave 9.6 for Mac from Newtek site)

        CFNetwork only invokes didReceiveAuthenticationChallenge for HTTP requests. Credentials
        for other protocols (including FTP) should be included as part of the URL.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::start):
        (WebCore::WebCoreSynchronousLoader::load):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):
        (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):
        Put credentials in URL for non-HTTP requests.

        * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest):
        Bail out quickly if the URL is non-HTTP. Cross-origin requests require specific HTTP
        headers to be received, so they cannot work with other protocols.

1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911
2009-05-15  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] In the image decoder, remove the raw image data represented as QImage
        once the image is converted to QPixmap and inserted in the pixmap cache.
        This effectively reduces the heap usage when running on graphics system
        other than raster (i.e the case where QImage != QPixmap).

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::imageAtIndex): Nullified the image on purpose.
        * platform/graphics/qt/ImageDecoderQt.h: Made m_imageList mutable.

1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925
2009-05-15  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] Refactor alpha channel detection the image decoder.
        Sets the boolean flag as soon as the image is being read.

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::ImageDecoderQt): Initialized m_hasAlphaChannel.
        (WebCore::ImageDecoderQt::setData): Set the flag when appropriate.
        (WebCore::ImageDecoderQt::supportsAlpha): Simplified.
        (WebCore::ImageDecoderQt::reset): Resetted the flag.
        * platform/graphics/qt/ImageDecoderQt.h: Added m_hasAlphaChannel.

1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949
2009-05-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        Finish support for disabling the JavaScript Debugger and Profiler 
        at compile time in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=24917

        * bindings/js/JSInspectorControllerCustom.cpp: ENABLE_JAVASCRIPT_DEBUGGER guard
        * bindings/js/JSJavaScriptCallFrameCustom.cpp: Ditto.
        * inspector/JavaScriptCallFrame.cpp: Ditto.
        * inspector/JavaScriptCallFrame.h: Ditto.
        * inspector/JavaScriptCallFrame.idl: Ditto.
        * inspector/JavaScriptDebugListener.h: Ditto.
        * inspector/JavaScriptDebugServer.cpp: Ditto.
        * inspector/JavaScriptDebugServer.h: Ditto.
        * inspector/JavaScriptProfile.cpp: Ditto.
        * inspector/JavaScriptProfile.h: Ditto.
        * inspector/JavaScriptProfileNode.cpp: Ditto.
        * inspector/JavaScriptProfileNode.h: Ditto.
        * page/Console.cpp: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of USE(JSC)
        * page/Console.h: Ditto.
        * page/Console.idl: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of !defined(V8_BINDING)

1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968
2009-05-15  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Dimitri Glazkov

        http://bugs.webkit.org/show_bug.cgi?id=25464

        Improve the font fallback for characters belonging to 'common' scripts
        in ChromiumWin port. Make characters like Danda, Double Danda (punctuation
        marks in North Indian scripts) and currency signs (e.g. Thai Baht)
        rendered correctly in Chromium on Win. 

        Tests: fast/text/international/danda-space.html
               fast/text/international/thai-baht-space.html

        * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
        (WebCore::FontMap::getScriptBasedOnUnicodeBlock):
        (WebCore::FontMap::getScript):
        (WebCore::getFallbackFamily):

1969 1970 1971 1972 1973 1974 1975 1976 1977 1978
2009-05-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=25731
        [Qt] Cleanup - move files exclusive to XPATH and XSLT under the
        appropriate build section

        * WebCore.pro:

1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989
2009-05-14  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel and Darin Fisher.

        Fix a font-related leak in Chromium's Skia backend found by Valgrind.
        https://bugs.webkit.org/show_bug.cgi?id=25760

        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
        Use caches instead of "new" on every call.

1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004
2009-05-14  Rahul Kuchhal  <kuchhal@chromium.org>

        Reviewed by Eric Seidel.

        Initialize m_spreadMethod in the second constructor too. Not sure if
        a test case can be written, so no test case.
        https://bugs.webkit.org/show_bug.cgi?id=25814

        No test possible: spreadMethod() is only used by SVG, doesn't seem possible to hit
        this case, since several other SVG tests already should be calling
        spreadMethod().

        * platform/graphics/Gradient.cpp:
        (WebCore::Gradient::Gradient):

2005 2006 2007 2008 2009 2010 2011 2012 2013 2014
2009-05-14  Simon Fraser  <simon.fraser@apple.com>

        No review.

        Fix Windows build after renaming MediaControlElements to MediaControlElementType.

        * rendering/RenderMediaControls.cpp:
        (WebCore::RenderMediaControls::paintMediaControlsPart):
        * rendering/RenderMediaControls.h:

2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051
2009-05-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler
        
        <rdar://problem/6739671> Movie controller’s play button does not change into a pause
        button

        Fix a controls repaint issue when the playing state of a video changes by
        educating the MediaControlInputElements about the state they are currently
        displaying, and making them repaint when that state changes. This applies
        to the play/pause and mute/unmute buttons, which both have two states.
        
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlInputElement::MediaControlInputElement):
        (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
        (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
        Pass in and initialize the MediaControlElementType.
        
        (WebCore::MediaControlInputElement::update):
        Update the display type too
        
        (WebCore::MediaControlInputElement::setDisplayType):
        (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
        (WebCore::MediaControlMuteButtonElement::updateDisplayType):
        Choose muted vs. unmuted display.
        
        (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
        (WebCore::MediaControlPlayButtonElement::updateDisplayType):
        Choose play vs. paused display.

        * rendering/MediaControlElements.h:
        Renamed the MediaControlElements enum to MediaControlElementType.
        (WebCore::MediaControlInputElement::updateDisplayType):
        Add a MediaControlElementType member variable with a setter to allow
        the element to know what type it is displaying.

2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072
2009-05-14  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=25197

        Add support for aspect-ratio and orientation
        media queries.

        Tests: fast/media/mq-aspect-ratio.html
               fast/media/mq-orientation.html

        * css/MediaFeatureNames.h:
        * css/MediaQueryEvaluator.cpp:
        (WebCore::orientationMediaFeatureEval):
        (WebCore::aspect_ratioMediaFeatureEval):
        (WebCore::min_aspect_ratioMediaFeatureEval):
        (WebCore::max_aspect_ratioMediaFeatureEval):
        * css/MediaQueryExp.h:
        (WebCore::MediaQueryExp::isViewportDependent):

kmccullough@apple.com's avatar
kmccullough@apple.com committed
2073 2074 2075 2076 2077 2078 2079 2080 2081
2009-05-14  Kevin McCullough  <kmccullough@apple.com>

        - Resubmitting previous patch, correctly this time.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::splitTreeToNode):
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::outdentParagraph):

kmccullough@apple.com's avatar
kmccullough@apple.com committed
2082 2083 2084 2085 2086 2087 2088 2089 2090
2009-05-14  Kevin McCullough  <kmccullough@apple.com>

        - Rolling out to fix a bug and the build

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::splitTreeToNode):
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::outdentParagraph):

kmccullough@apple.com's avatar
kmccullough@apple.com committed
2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114
2009-05-14  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6510362> In some situations message content is messed up
        when indentation is decreased

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::splitTreeToNode): Calling recursively
        here served to do nothing because this function will return if the
        second argument is the parent of the first.  Not only does this now work
        as intended, but is necessary for the rest of this fix.
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::outdentParagraph): To determine if we 
        are the last node in a <blockquote>, and can therefore remove the
        <blockquote> we need the endOfEnclosingBlock to extend to the end of
        the <blockquote> not just the next block, which could be a <div>, for
        example. 
        - Also If a <blockquote> is removed, but it's the child of another
        <blockquote> then its children are now children of the top <blockquote>.
        In this case we want to split the parent <blockquote> because the next
        paragraph assumes that it is the first node in its <blockquote> and if
        that is not true, various bugs arise.

2115 2116 2117 2118 2119 2120 2121
2009-05-14  Brady Eidson  <beidson@apple.com>

        Build fix.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::setDefaultMIMEType):

2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132
2009-05-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam Roben.

        Fix http/tests/xmlhttprequest/cache-override.html on Windows

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::setDefaultMIMEType): Modify the previous response so it maintains all of its data.
        (WebCore::didReceiveResponse): Call setDefaultMIMEType() when needed.
        (WebCore::WebCoreSynchronousLoader::load): Ditto.

2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150
2009-05-14  Paul Godavari  <paul@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug: Mac Chromium popup menus are not positioned correctly
        on scrolled pages:
        https://bugs.webkit.org/show_bug.cgi?id=25772

        Fix Mac Chromium popup menu placement by taking into
        account any scrolling in the current window. This mirrors
        the positioning done in PopupContainer::show(), which is
        used on Chromium Windows and linux.

        Also fixed indenting for this method.

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::showExternal):

2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162
2009-05-14  Drew Wilson  <atwilson@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25774
        Upstream V8MessagePortCustom.cpp from the chromium repository.

        * bindings/v8/custom/V8MessagePortCustom.cpp: Added.
        (WebCore::ACCESSOR_GETTER):
        (WebCore::ACCESSOR_SETTER):
        (WebCore::CALLBACK_FUNC_DECL):

2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177
2009-05-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=25777
        
        StyleGeneratedImage::imageSize() needs to take zooming into account for
        fixed-size images (i.e. canvas) so that canvas-as-image-background
        renders correctly with zooming.

        Test: fast/canvas/canvas-bg-zoom.html

        * rendering/style/StyleGeneratedImage.cpp:
        (WebCore::StyleGeneratedImage::imageSize):

ap@webkit.org's avatar
ap@webkit.org committed
2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191
2009-05-14  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin Adler.

        Patch originally by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25796
        <rdar://problem/6886654> Shouldn't set referer and origin in Loader::Host::servePendingRequests().

        Test: http/tests/security/credentials-in-referer.html

        * loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): This will be done in
        SubresourceLoader::create() anyway.

2192 2193 2194 2195 2196 2197 2198 2199 2200 2201
2009-05-14  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Bug 25797: Pages with image maps are not properly read with Voiceover
        https://bugs.webkit.org/show_bug.cgi?id=25797

        * page/AccessibilityImageMapLink.h:
        (WebCore::AccessibilityImageMapLink::isEnabled):

beidson@apple.com's avatar
beidson@apple.com committed
2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217
2009-05-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790 

        Nuke the bogus ASSERT and add a legitimate ASSERT with a little help from a new accessor.

        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::shouldContentSniff):
        * platform/network/ResourceHandle.h:

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::createCFURLResponseWithDefaultMIMEType):
        (WebCore::didReceiveResponse):

2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243
2009-05-14  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25791
        Bug 25791: HTMLMediaElement: implement 'startTime' attribute
        
        Support the recently added HTMLMediaElement 'startTime' attribute. This is a read-only 
        value that only the media engine can know, so we just need to add the attribute 
        to HTMLMediaElement and add methods to MediaPlayer and MediaPlayerPrivateInterface so 
        the engine can make it available.

        Test: media/media-startTime.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::startTime): New.
        * html/HTMLMediaElement.h:
        * html/HTMLMediaElement.idl:

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::startTime): New.
        * platform/graphics/MediaPlayer.h:

        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::startTime): New.

2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257
2009-05-14  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Ariya Hidayat.

        Only create a QWidget wrapper for the plugin in the case it is not
        in the Qt window mapper, and thus receiving events from the Qt
        event system. Native Qt based plugins running in process, will
        already be in the window mapper, and thus creating a wrapper,
        stops them from getting events from Qt, as they are redirected
        to the wrapper.

        * plugins/qt/PluginContainerQt.cpp:
        (PluginContainerQt::on_clientIsEmbedded):

ap@webkit.org's avatar
ap@webkit.org committed
2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273
2009-05-14  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25784
        Leaks seen on HTTP tests

        We should change ResourceHandleMac.mm to use smart pointers some day, but this is a minimal fix.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::loadResourceSynchronously): Release mutable request copy made for
        disabling content sniffing, matching the normal code path.
        (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Release m_user