ChangeLog 325 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14
2010-08-25  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Changed the initial and subsequent allocation of vector storage to
        Array()s. The changes are to limit sparse arrays to 100000 entries
        and fixed the sparse map to vector storage conversion to use the 
        minimum amount of memory needed to store the current number of entries.
        These changes address https://bugs.webkit.org/show_bug.cgi?id=43707

        * runtime/JSArray.cpp:
        (JSC::JSArray::putSlowCase):
        (JSC::JSArray::getNewVectorLength):

15 16 17 18 19 20 21 22 23 24 25 26
2010-08-16  Gabor Loki  <loki@webkit.org>

        Reviewed by Gavin Barraclough.

        Avoid increasing required alignment of target type warning
        https://bugs.webkit.org/show_bug.cgi?id=43963

        Fix platform independent alignment warnings.

        * wtf/ListHashSet.h:
        (WTF::ListHashSetNodeAllocator::pool):

27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48
2010-08-19  Gabor Loki  <loki@webkit.org>

        Reviewed by Gavin Barraclough.

        Enable truncated floating point feature on ARM
        https://bugs.webkit.org/show_bug.cgi?id=44233

        Enable truncated floating point feature with the help of VCVTR.S32.F64
        instruction. If VCVTR.S32.F64 can't fit the result into a 32-bit
        integer/register, it saturates at INT_MAX or INT_MIN. Testing this
        looks quicker than testing FPSCR for exception.

        Inspired by Jacob Bramley's patch from JaegerMonkey

        * assembler/ARMAssembler.h:
        (JSC::ARMAssembler::):
        (JSC::ARMAssembler::cmn_r):
        (JSC::ARMAssembler::vcvtr_s32_f64_r):
        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
        (JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):

barraclough@apple.com's avatar
barraclough@apple.com committed
49 50 51 52 53 54
2010-08-24  Gavin Barraclough  <barraclough@apple.com>

        Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

barraclough@apple.com's avatar
barraclough@apple.com committed
55 56 57 58 59 60 61 62 63 64
2010-08-24  Gavin Barraclough  <barraclough@apple.com>

        Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * wtf/DecimalNumber.h:
        (WTF::DecimalNumber::intPow10):
        * wtf/dtoa.cpp:
        * wtf/dtoa.h:

65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130
2010-08-23  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=44487

        Number.toExponential/toFixed/toPrecision all contain a spaghetti of duplicated
        code & unnecessary complexity. Add a new DecimalNumber class to encapsulate
        double to string conversion, share the implementations of rounding &
        decimal-fraction/exponential formatting.

        * JavaScriptCore.exp:
            Update exports.

        * runtime/NumberPrototype.cpp:
        (JSC::toThisNumber):
        (JSC::getIntegerArgumentInRange):
            Helper methods used in implementing toExponential/toFixed/toString.
        (JSC::numberProtoFuncToExponential):
        (JSC::numberProtoFuncToFixed):
        (JSC::numberProtoFuncToPrecision):
            Reimplemented using new DecimalNumber class.
            
        * runtime/UString.cpp:
        (JSC::UString::number):
            Updated to call numberToString.

        * wtf/DecimalNumber.h: Added.
        (WTF::):
        (WTF::DecimalNumber::DecimalNumber):
        (WTF::DecimalNumber::toStringDecimal):
        (WTF::DecimalNumber::toStringExponential):
        (WTF::DecimalNumber::sign):
        (WTF::DecimalNumber::exponent):
        (WTF::DecimalNumber::significand):
        (WTF::DecimalNumber::precision):
        (WTF::DecimalNumber::init):
        (WTF::DecimalNumber::isZero):
        (WTF::DecimalNumber::roundToPrecision):
            New class to perform double to string conversion.
            Has three constructors, which allow conversion with no rounding,
            rounding to significant-figures, or rounding to decimal-places,
            and two methods for formatting strings, either using decimal
            fraction or exponential encoding. Internal implementation uses
            pre-rounding of the values before calling dtoa rather than
            relying on dtoa to correctly round, which does not produce
            fully accurate results. Hopefully we can address this in the
            near future.

        * wtf/dtoa.cpp:
        (WTF::intPow10):
        * wtf/dtoa.h:
            intPow10 is used internally by DecimalNumber.
            
        * wtf/text/WTFString.cpp:
        (WTF::copyToString):
        (WTF::nanOrInfToString):
            Used internally in numberToString for NaN/Infinity handling.
        (WTF::numberToString):
            Added new method to convert doubles to strings.

        * wtf/text/WTFString.h:
            Added declaration for numberToString. This is here because
            we should switch over to using this for all double to string
            conversion in WebCore (see section 2.4.4.3 of the HTML5 spec).

131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151
2010-08-24  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoff Garen.

        Don't seed the JS random number generator from time()
        https://bugs.webkit.org/show_bug.cgi?id=41868
        <rdar://problem/8171025>

        Switch to using the secure random number generator to
        seed the fast random generator, and make the generator
        be per global object.

        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        * runtime/JSGlobalData.h:
        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
        (JSC::JSGlobalObject::weakRandomNumber):
        * runtime/MathObject.cpp:
        (JSC::mathProtoFuncRandom):

152 153 154 155 156 157 158 159 160 161 162 163 164
2010-08-24  Oliver Hunt  <oliver@apple.com>

        Reviewed by Beth Dakin.

        Make overflow guards in UString::utf8 explicit
        https://bugs.webkit.org/show_bug.cgi?id=44540

        Add an explicit overflow check prior to allocating our buffer,
        rather than implicitly relying on the guard in convertUTF16ToUTF8.

        * runtime/UString.cpp:
        (JSC::UString::utf8):

165 166 167 168 169 170 171 172 173 174 175 176 177
2010-08-24  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Simon Hausmann.

        [Symbian] Fix commit/decommit of system memory using RChunk

        Swap accidentially reversed start and m_base values for determining the
        offset within the RChunk.

        * wtf/PageReservation.h:
        (WTF::PageReservation::systemCommit):
        (WTF::PageReservation::systemDecommit):

178 179 180 181 182 183 184 185 186 187 188
2010-08-23  Patrick Gansterer  <paroga@paroga.com>

        Rubber-stamped by Gabor Loki.

        [WINCE] Buildfix for GeneratedJITStubs after r64818
        https://bugs.webkit.org/show_bug.cgi?id=44469

        Use " THUNK_RETURN_ADDRESS_OFFSET" instead of "#offset#".

        * jit/JITStubs.cpp:

189 190 191 192 193 194 195 196 197 198 199 200 201 202
2010-08-23  Oliver Hunt  <oliver@apple.com>

        Reviewed by Darin Adler.

        [REGRESSION] Interpreter incorrectly excludes prototype chain when validating put_by_id_transition
        https://bugs.webkit.org/show_bug.cgi?id=44240
        <rdar://problem/8328995>

        Fix an error I introduced when cleaning up the interpreter side of the logic
        to prevent setters being called in object initialisers.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):

203 204 205 206 207 208 209 210 211 212 213 214 215
2010-08-23  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        Fixed case where a single character search string in a string.replace()
        did not properly handle back reference replacement.  The fix is to 
        check for a '$' as part of the check to see if we can execute the
        single character replace optimization.
        https://bugs.webkit.org/show_bug.cgi?id=44067

        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncReplace):

216 217 218 219 220 221 222 223 224 225 226 227 228 229
2010-08-23  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        JSON.stringify is much slower than Firefox on particular pathological input
        https://bugs.webkit.org/show_bug.cgi?id=44456

        Make StringBuilder::reserveCapacity reserve additional space so we don't end up
        repeatedly copying the entire result string.

        * runtime/StringBuilder.h:
        (JSC::StringBuilder::append):
        (JSC::StringBuilder::reserveCapacity):

jianli@chromium.org's avatar
jianli@chromium.org committed
230 231 232 233 234 235 236 237 238
2010-08-23  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        Handle blob resource.
        https://bugs.webkit.org/show_bug.cgi?id=43941

        * JavaScriptCore.exp: Add an export that is neede by BlobResourceHandle.

239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255
2010-08-19  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Geoffrey Garen.

        JSC: Move the static_cast into to(U)Int32 fast case
        https://bugs.webkit.org/show_bug.cgi?id=44037

        Do the static_cast<(u)int32_t> inline to avoid the function call overhead
        for easily converted values (within (u)int32_t range.)

        * runtime/JSValue.cpp:
        (JSC::toInt32SlowCase):
        (JSC::toUInt32SlowCase):
        * runtime/JSValue.h:
        (JSC::JSValue::toInt32):
        (JSC::JSValue::toUInt32):

256 257 258 259 260 261 262 263 264 265 266 267
2010-08-18  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Geoffrey Garen.

        REGRESSION(r58469): Math.pow() always returns double-backed JSValue which is extremely slow as array subscript
        https://bugs.webkit.org/show_bug.cgi?id=43742

        Add codegen for pow() to return Int32 values when possible.

        * jit/ThunkGenerators.cpp:
        (JSC::powThunkGenerator):

268 269 270 271 272 273 274 275 276 277 278 279 280 281
2010-08-18  Gabor Loki  <loki@webkit.org>

        Reviewed by Gavin Barraclough.

        The JITStackFrame is wrong using Thumb-2 JIT with JSVALUE32_64
        https://bugs.webkit.org/show_bug.cgi?id=43897

        A 64 bits wide member in a structure is aligned to 8 bytes on ARM by
        default, but this is not taken into account in the offset defines of
        JITStackFrame.

        * jit/JITStubs.cpp:
        * jit/JITStubs.h:

282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318
2010-08-18  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Sam Weinig.

        Rename UString::substr to substringSharingImpl, add to WTF::String.
        Now WTF::String can do everything that JSC::UString can do!

        * JavaScriptCore.exp:
        * bytecode/CodeBlock.cpp:
        (JSC::escapeQuotes):
        * bytecompiler/NodesCodegen.cpp:
        (JSC::substitute):
        * parser/SourceProvider.h:
        (JSC::UStringSourceProvider::getRange):
        * runtime/FunctionPrototype.cpp:
        (JSC::insertSemicolonIfNeeded):
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::parseInt):
        * runtime/JSONObject.cpp:
        (JSC::gap):
        (JSC::Stringifier::indent):
        (JSC::Stringifier::unindent):
        * runtime/JSString.cpp:
        (JSC::JSString::replaceCharacter):
        * runtime/NumberPrototype.cpp:
        (JSC::numberProtoFuncToFixed):
        (JSC::numberProtoFuncToPrecision):
        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncReplace):
        (JSC::trimString):
        * runtime/UString.cpp:
        (JSC::UString::substringSharingImpl):
        * runtime/UString.h:
        * wtf/text/WTFString.cpp:
        (WTF::String::substringSharingImpl):
        * wtf/text/WTFString.h:

barraclough@apple.com's avatar
barraclough@apple.com committed
319 320 321 322 323 324 325
2010-08-18  Gavin Barraclough  <barraclough@apple.com>

        Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.xcodeproj/project.pbxproj:

barraclough@apple.com's avatar
barraclough@apple.com committed
326 327 328 329 330 331 332
2010-08-18  Gavin Barraclough  <barraclough@apple.com>

        Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.xcodeproj/project.pbxproj:

333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410
2010-08-17  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig.

        Bug 44146 - Remove toDouble/toUInt32 methods from UString.

        These methods all implement JavaScript language specific behaviour, and as such
        are not suited to being on a generic string object.  They are also inefficient
        and incorrectly used, refactor & cleanup.  Uses of these methods really divide
        out into two cases.

        ToNumber:
        Uses of toDouble from JSString and from parseFloat are implementing ecma's
        ToNumber conversion from strings (see ecma-262 9.3.1), so UString::toDouble
        should largely just be moved out to a global jsToNumber function.  ToNumber is
        capable of recognizing either decimal or hexadecimal numbers, but parseFloat
        should only recognize decimal values.  This is currently handled by testing for
        hexadecimal before calling toDouble, which should unnecessary - instead we can
        just split out the two parts to the grammar into separate functions. Also,
        strtod recognizes a set of literals (nan, inf, and infinity - all with any
        capitalization) - which are not defined by any of the specs we are implementing.
        To handle this we need to perform additional work in toDouble to convert the
        unsupported cases of infinities back to NaNs.  Instead we should simply remove
        support for this literals from strtod.  This should provide a more desirable
        behaviour for all clients of strtod.

        Indexed properties:
        Uses of the toStrictUInt32 methods are were all converting property names to
        indices, and all uses of toUInt32 were incorrect; in all cases we should have
        been calling toUInt32.  This error results in some incorrect behaviour in the
        DOM (accessing property "0 " of a NodeList should fail; it currently does not).
        Move this method onto Identifier (our canonical property name), and make it
        always perform a strict conversion. Add a layout test to check NodeList does
        convert indexed property names correctly.

        * JavaScriptCore.exp:
        * runtime/Arguments.cpp:
        (JSC::Arguments::getOwnPropertySlot):
        (JSC::Arguments::getOwnPropertyDescriptor):
        (JSC::Arguments::put):
        (JSC::Arguments::deleteProperty):
        * runtime/Identifier.cpp:
        (JSC::Identifier::toUInt32):
        * runtime/Identifier.h:
        (JSC::Identifier::toUInt32):
        * runtime/JSArray.cpp:
        (JSC::JSArray::getOwnPropertySlot):
        (JSC::JSArray::getOwnPropertyDescriptor):
        (JSC::JSArray::put):
        (JSC::JSArray::deleteProperty):
        * runtime/JSArray.h:
        (JSC::Identifier::toArrayIndex):
        * runtime/JSByteArray.cpp:
        (JSC::JSByteArray::getOwnPropertySlot):
        (JSC::JSByteArray::getOwnPropertyDescriptor):
        (JSC::JSByteArray::put):
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::isInfinity):
        (JSC::jsHexIntegerLiteral):
        (JSC::jsStrDecimalLiteral):
        (JSC::jsToNumber):
        (JSC::parseFloat):
        * runtime/JSGlobalObjectFunctions.h:
        * runtime/JSString.cpp:
        (JSC::JSString::getPrimitiveNumber):
        (JSC::JSString::toNumber):
        (JSC::JSString::getStringPropertyDescriptor):
        * runtime/JSString.h:
        (JSC::JSString::getStringPropertySlot):
        * runtime/ObjectPrototype.cpp:
        (JSC::ObjectPrototype::put):
        * runtime/StringObject.cpp:
        (JSC::StringObject::deleteProperty):
        * runtime/UString.cpp:
        * runtime/UString.h:
        * wtf/dtoa.cpp:
        (WTF::strtod):

411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427
2010-08-17  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig.

        Bug 44099 - REGRESSION(r65468): Crashes in StringImpl::find

        Bug 44080 introuduced a couple of cases in which array bounds could be overrun.
        One of these was fixed in r65493, this patch fixes the other and address the
        concerns voiced in comment #6 by restructuring the loops to remove the code
        dupliction without introducing an additional if check.

        * wtf/text/StringImpl.cpp:
        (WTF::StringImpl::find):
        (WTF::StringImpl::findIgnoringCase):
        (WTF::StringImpl::reverseFind):
        (WTF::StringImpl::reverseFindIgnoringCase):

428 429 430 431 432 433 434 435 436
2010-08-17  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Move the accelerated compositing build flag to the right place
        https://bugs.webkit.org/show_bug.cgi?id=43882

        * wtf/Platform.h:

437 438 439 440 441 442 443 444 445 446 447 448
2010-08-17  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Avoid uninitialized memory read in StringImpl::find().

        REGRESSION(r65468): Crashes in StringImpl::find
        https://bugs.webkit.org/show_bug.cgi?id=44099

        * wtf/text/StringImpl.cpp:
        (WTF::StringImpl::find):

449 450 451 452 453 454 455 456 457 458 459 460 461
2010-08-16  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Sam Weinig

        Add VectorTraits to String & DefaultHash traits to UString to unify behaviour.

        * runtime/UString.h:
        (JSC::UStringHash::hash):
        (JSC::UStringHash::equal):
        (WTF::):
        * wtf/text/WTFString.h:
        (WTF::):

462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479
2010-08-16  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Sam Weinig

        Remove unnecessary includes from UString.h, add new includes as necessary.

        * profiler/CallIdentifier.h:
        * profiler/ProfileNode.h:
        * runtime/DateConversion.cpp:
        * runtime/Identifier.h:
        (JSC::IdentifierRepHash::hash):
        * runtime/RegExpCache.h:
        * runtime/RegExpKey.h:
        * runtime/UString.cpp:
        (JSC::UString::substr):
        * runtime/UString.h:
        * wtf/text/WTFString.h:

480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551
2010-08-16  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig

        Bug 44080 - String find/reverseFind methods need tidying up
        These methods have a couple of problems with their interface, and implementation.

        These methods take and int index, and return an int - however this is problematic
        since on 64-bit string indices may have a full 32-bit range.  This spills out into
        surrounding code, which unsafely casts string indices from unsigned to int. Code
        checking the result of these methods check for a mix of "== -1", "< 0", and
        "== notFound".  Clean this up by changing these methods to take an unsigned
        starting index, and return a size_t. with a failed match indicated by notFound.
        reverseFind also has a special meaning for the starting index argument, in that a
        negative index is interpreted as an offset back from the end of the string. Remove
        this functionality, in the (1!) case where it is used we should just calculate the
        offset by subtracting from the string's length.

        The implementation has a few problems too.  The code is not in webkit style, in
        using assorted abbreviations in variable names, and implementations of similar
        find methods with differing argument types were unnecessarily inconsistent. When
        find is passed const char* data the string would be handled as latin1 (zero
        extended to UTF-16) for all characters but the first; this is sign extended.
        Case-insensitive find is broken for unicode strings; the hashing optimization is
        not unicode safe, and could result in false negatives.

        Unify UString find methods to match String.

        * JavaScriptCore.exp:
        * bytecode/CodeBlock.cpp:
        (JSC::escapeQuotes):
        * bytecompiler/NodesCodegen.cpp:
        (JSC::substitute):
        * runtime/JSString.cpp:
        (JSC::JSString::replaceCharacter):
        * runtime/RegExp.cpp:
        (JSC::RegExp::RegExp):
        * runtime/RegExpKey.h:
        (JSC::RegExpKey::getFlagsValue):
        * runtime/StringPrototype.cpp:
        (JSC::substituteBackreferencesSlow):
        (JSC::substituteBackreferences):
        (JSC::stringProtoFuncReplace):
        (JSC::stringProtoFuncIndexOf):
        (JSC::stringProtoFuncLastIndexOf):
        (JSC::stringProtoFuncSplit):
        * runtime/UString.cpp:
        * runtime/UString.h:
        (JSC::UString::find):
        (JSC::UString::reverseFind):
        * wtf/text/AtomicString.h:
        (WTF::AtomicString::find):
        * wtf/text/StringImpl.cpp:
        (WTF::StringImpl::find):
        (WTF::StringImpl::findCaseInsensitive):
        (WTF::StringImpl::reverseFind):
        (WTF::StringImpl::reverseFindCaseInsensitive):
        (WTF::StringImpl::endsWith):
        (WTF::StringImpl::replace):
        * wtf/text/StringImpl.h:
        (WTF::StringImpl::startsWith):
        * wtf/text/WTFString.cpp:
        (WTF::String::split):
        * wtf/text/WTFString.h:
        (WTF::String::find):
        (WTF::String::reverseFind):
        (WTF::String::findCaseInsensitive):
        (WTF::String::reverseFindCaseInsensitive):
        (WTF::String::contains):
        (WTF::find):
        (WTF::reverseFind):

552 553 554 555 556 557 558 559
2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>

        [wx] Build fix, do not build WebCore as a convenience library as this leads to
        errors in the Win build w/export symbols and causes problems with DOM bindings
        debugging in gdb. 

        * wscript:

560 561 562 563 564 565 566 567 568
2010-08-16  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Build fix after r65366.

        * CMakeLists.txt: Use if (VAR) instead of if (${VAR}) to check if
        they're empty.
        * jsc/CMakeLists.txt: Ditto.
        * wtf/CMakeLists.txt: Ditto.

569 570 571 572 573 574
2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>

        [wx] Build fix, don't build intermediate source in DerivedSources dir.

        * wscript:

575 576 577 578 579 580 581 582 583
2010-08-14  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kenneth Rohde Christiansen.

        [CMake] Add preprocessor detection for generator scripts
        https://bugs.webkit.org/show_bug.cgi?id=43984

        * CMakeLists.txt:

584 585 586 587 588 589 590 591 592 593 594
2010-08-14  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kenneth Rohde Christiansen.

        [CMake] Set target properties only if available
        https://bugs.webkit.org/show_bug.cgi?id=43978

        * CMakeLists.txt:
        * jsc/CMakeLists.txt:
        * wtf/CMakeLists.txt:

595 596 597 598 599 600
2010-08-13  Kevin Ollivier  <kevino@theolliviers.com>

        [wx] Build fix, add CString to the list of forwards.

        * wtf/Forward.h:

barraclough@apple.com's avatar
barraclough@apple.com committed
601 602 603 604 605 606
2010-08-13  Gavin Barraclough  <barraclough@apple.com>

        Windows build fix

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

barraclough@apple.com's avatar
barraclough@apple.com committed
607 608 609 610 611 612
2010-08-13  Gavin Barraclough  <barraclough@apple.com>

        Windows build fix

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

barraclough@apple.com's avatar
barraclough@apple.com committed
613 614 615 616 617 618
2010-08-13  Gavin Barraclough  <barraclough@apple.com>

        Windows build fix

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650
2010-08-13  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Sam Weinig.
        Switch String::/UString::ascii() to return a CString.

        * JavaScriptCore.exp:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        * bytecode/SamplingTool.cpp:
        (JSC::SamplingTool::dump):
        * interpreter/CallFrame.cpp:
        (JSC::CallFrame::dumpCaller):
        * jsc.cpp:
        (runWithScripts):
        (runInteractive):
        * runtime/Identifier.h:
        (JSC::Identifier::ascii):
        * runtime/ScopeChain.cpp:
        (JSC::ScopeChainNode::print):
        * runtime/UString.cpp:
        (JSC::UString::ascii):
        (JSC::UString::latin1):
        * runtime/UString.h:
        * wtf/text/StringImpl.cpp:
        (WTF::StringImpl::asciiOLD):
        * wtf/text/StringImpl.h:
        * wtf/text/WTFString.cpp:
        (WTF::String::ascii):
        (WTF::String::latin1):
        * wtf/text/WTFString.h:

651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696
2010-08-13  Gabor Loki  <loki@webkit.org>

        Reviewed by Gavin Barraclough.

        Avoid increasing required alignment of target type warning on ARM
        https://bugs.webkit.org/show_bug.cgi?id=38045

        The reinterpret_cast<Type1*>([pointer to Type2]) expressions - where
        sizeof(Type1) > sizeof(Type2) - cause the following warning on ARM:
        increases required alignment of target type warnings.
        Casting the type of [pointer to Type2] object to void* bypasses the
        warning.

        * assembler/ARMAssembler.cpp:
        (JSC::ARMAssembler::executableCopy):
        * assembler/AssemblerBuffer.h:
        (JSC::AssemblerBuffer::putShortUnchecked):
        (JSC::AssemblerBuffer::putIntUnchecked):
        (JSC::AssemblerBuffer::putInt64Unchecked):
        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::RegisterFile):
        (JSC::RegisterFile::grow):
        * jit/JITStubs.cpp:
        * pcre/pcre_compile.cpp:
        (jsRegExpCompile):
        * runtime/JSArray.cpp:
        (JSC::JSArray::putSlowCase):
        (JSC::JSArray::increaseVectorLength):
        (JSC::JSArray::increaseVectorPrefixLength):
        (JSC::JSArray::shiftCount):
        (JSC::JSArray::unshiftCount):
        * wtf/FastMalloc.cpp:
        (WTF::PageHeapAllocator::New):
        (WTF::TCMalloc_Central_FreeList::Populate):
        * wtf/MD5.cpp:
        (WTF::reverseBytes):
        (WTF::MD5::addBytes):
        (WTF::MD5::checksum):
        * wtf/StdLibExtras.h:
        (isPointerTypeAlignmentOkay):
        (reinterpret_cast_ptr):
        * wtf/Vector.h:
        (WTF::VectorBuffer::inlineBuffer):
        * wtf/qt/StringQt.cpp:
        (WTF::String::String):

697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773
2010-08-13  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig

        Unify UString::UTF8String() & String::utf8() methods,
        remove UString::cost() & make atArrayIndex a free function.

        * JavaScriptCore.exp:
        * bytecode/CodeBlock.cpp:
        (JSC::constantName):
        (JSC::idName):
        (JSC::CodeBlock::registerName):
        (JSC::regexpName):
        (JSC::printGlobalResolveInfo):
        (JSC::printStructureStubInfo):
        (JSC::CodeBlock::printStructure):
        (JSC::CodeBlock::printStructures):
        * jsc.cpp:
        (functionPrint):
        (functionDebug):
        (runInteractive):
        (fillBufferWithContentsOfFile):
        * pcre/pcre_exec.cpp:
        (Histogram::~Histogram):
        * profiler/CallIdentifier.h:
        (JSC::CallIdentifier::c_str):
        * profiler/Profile.cpp:
        (JSC::Profile::debugPrintDataSampleStyle):
        * profiler/ProfileGenerator.cpp:
        (JSC::ProfileGenerator::willExecute):
        (JSC::ProfileGenerator::didExecute):
        * profiler/ProfileNode.cpp:
        (JSC::ProfileNode::debugPrintData):
        (JSC::ProfileNode::debugPrintDataSampleStyle):
        * runtime/Arguments.cpp:
        (JSC::Arguments::getOwnPropertySlot):
        (JSC::Arguments::getOwnPropertyDescriptor):
        (JSC::Arguments::put):
        (JSC::Arguments::deleteProperty):
        * runtime/DateConversion.cpp:
        (JSC::parseDate):
        * runtime/Identifier.h:
        (JSC::Identifier::toStrictUInt32):
        * runtime/JSArray.cpp:
        (JSC::JSArray::getOwnPropertySlot):
        (JSC::JSArray::getOwnPropertyDescriptor):
        (JSC::JSArray::put):
        (JSC::JSArray::deleteProperty):
        * runtime/JSArray.h:
        (JSC::toArrayIndex):
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::encode):
        (JSC::parseInt):
        (JSC::globalFuncJSCPrint):
        * runtime/JSString.h:
        (JSC::RopeBuilder::JSString):
        * runtime/UString.cpp:
        (JSC::UString::toDouble):
        (JSC::putUTF8Triple):
        (JSC::UString::utf8):
        * runtime/UString.h:
        (JSC::UString::~UString):
        (JSC::UString::isNull):
        (JSC::UString::isEmpty):
        (JSC::UString::impl):
        * wtf/text/WTFString.cpp:
        (WTF::String::utf8):
        * wtf/text/WTFString.h:
        (WTF::String::~String):
        (WTF::String::swap):
        (WTF::String::isNull):
        (WTF::String::isEmpty):
        (WTF::String::impl):
        (WTF::String::length):
        (WTF::String::String):
        (WTF::String::isHashTableDeletedValue):

774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811
2010-08-12  Zoltan Herczeg  <zherczeg@webkit.org>

        Reviewed by Gavin Barraclough.

        Refactoring the fpu code generator for the ARM port
        https://bugs.webkit.org/show_bug.cgi?id=43842

        Support up to 32 double precision registers, and the
        recent VFP instruction formats. This patch is mainly
        a style change which keeps the current functionality.

        * assembler/ARMAssembler.h:
        (JSC::ARMRegisters::):
        (JSC::ARMAssembler::):
        (JSC::ARMAssembler::emitInst):
        (JSC::ARMAssembler::emitDoublePrecisionInst):
        (JSC::ARMAssembler::emitSinglePrecisionInst):
        (JSC::ARMAssembler::vadd_f64_r):
        (JSC::ARMAssembler::vdiv_f64_r):
        (JSC::ARMAssembler::vsub_f64_r):
        (JSC::ARMAssembler::vmul_f64_r):
        (JSC::ARMAssembler::vcmp_f64_r):
        (JSC::ARMAssembler::vsqrt_f64_r):
        (JSC::ARMAssembler::vmov_vfp_r):
        (JSC::ARMAssembler::vmov_arm_r):
        (JSC::ARMAssembler::vcvt_f64_s32_r):
        (JSC::ARMAssembler::vcvt_s32_f64_r):
        (JSC::ARMAssembler::vmrs_apsr):
        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::addDouble):
        (JSC::MacroAssemblerARM::divDouble):
        (JSC::MacroAssemblerARM::subDouble):
        (JSC::MacroAssemblerARM::mulDouble):
        (JSC::MacroAssemblerARM::sqrtDouble):
        (JSC::MacroAssemblerARM::convertInt32ToDouble):
        (JSC::MacroAssemblerARM::branchDouble):
        (JSC::MacroAssemblerARM::branchConvertDoubleToInt32):

812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889
2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65295.
        http://trac.webkit.org/changeset/65295
        https://bugs.webkit.org/show_bug.cgi?id=43950

        It broke 4 sputnik tests (Requested by Ossy on #webkit).

        * JavaScriptCore.exp:
        * bytecode/CodeBlock.cpp:
        (JSC::constantName):
        (JSC::idName):
        (JSC::CodeBlock::registerName):
        (JSC::regexpName):
        (JSC::printGlobalResolveInfo):
        (JSC::printStructureStubInfo):
        (JSC::CodeBlock::printStructure):
        (JSC::CodeBlock::printStructures):
        * jsc.cpp:
        (functionPrint):
        (functionDebug):
        (runInteractive):
        (fillBufferWithContentsOfFile):
        * pcre/pcre_exec.cpp:
        (Histogram::~Histogram):
        * profiler/CallIdentifier.h:
        (JSC::CallIdentifier::c_str):
        * profiler/Profile.cpp:
        (JSC::Profile::debugPrintDataSampleStyle):
        * profiler/ProfileGenerator.cpp:
        (JSC::ProfileGenerator::willExecute):
        (JSC::ProfileGenerator::didExecute):
        * profiler/ProfileNode.cpp:
        (JSC::ProfileNode::debugPrintData):
        (JSC::ProfileNode::debugPrintDataSampleStyle):
        * runtime/Arguments.cpp:
        (JSC::Arguments::getOwnPropertySlot):
        (JSC::Arguments::getOwnPropertyDescriptor):
        (JSC::Arguments::put):
        (JSC::Arguments::deleteProperty):
        * runtime/DateConversion.cpp:
        (JSC::parseDate):
        * runtime/Identifier.h:
        (JSC::Identifier::Identifier):
        (JSC::Identifier::toArrayIndex):
        * runtime/JSArray.cpp:
        (JSC::JSArray::getOwnPropertySlot):
        (JSC::JSArray::getOwnPropertyDescriptor):
        (JSC::JSArray::put):
        (JSC::JSArray::deleteProperty):
        * runtime/JSArray.h:
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::encode):
        (JSC::parseInt):
        (JSC::globalFuncJSCPrint):
        * runtime/JSString.h:
        (JSC::RopeBuilder::JSString):
        * runtime/UString.cpp:
        (JSC::UString::toDouble):
        (JSC::UString::UTF8String):
        * runtime/UString.h:
        (JSC::UString::isNull):
        (JSC::UString::isEmpty):
        (JSC::UString::impl):
        (JSC::UString::cost):
        (JSC::UString::~UString):
        (JSC::UString::toArrayIndex):
        * wtf/text/WTFString.cpp:
        (WTF::String::utf8):
        * wtf/text/WTFString.h:
        (WTF::String::String):
        (WTF::String::isHashTableDeletedValue):
        (WTF::String::length):
        (WTF::String::operator[]):
        (WTF::String::isNull):
        (WTF::String::isEmpty):
        (WTF::String::impl):

barraclough@apple.com's avatar
barraclough@apple.com committed
890 891 892 893 894 895
2010-08-12  Gavin Barraclough  <barraclough@apple.com>

        Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972
2010-08-12  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig

        Unify UString::UTF8String() & String::utf8() methods,
        remove UString::cost() & make atArrayIndex a free function.

        * JavaScriptCore.exp:
        * bytecode/CodeBlock.cpp:
        (JSC::constantName):
        (JSC::idName):
        (JSC::CodeBlock::registerName):
        (JSC::regexpName):
        (JSC::printGlobalResolveInfo):
        (JSC::printStructureStubInfo):
        (JSC::CodeBlock::printStructure):
        (JSC::CodeBlock::printStructures):
        * jsc.cpp:
        (functionPrint):
        (functionDebug):
        (runInteractive):
        (fillBufferWithContentsOfFile):
        * pcre/pcre_exec.cpp:
        (Histogram::~Histogram):
        * profiler/CallIdentifier.h:
        (JSC::CallIdentifier::c_str):
        * profiler/Profile.cpp:
        (JSC::Profile::debugPrintDataSampleStyle):
        * profiler/ProfileGenerator.cpp:
        (JSC::ProfileGenerator::willExecute):
        (JSC::ProfileGenerator::didExecute):
        * profiler/ProfileNode.cpp:
        (JSC::ProfileNode::debugPrintData):
        (JSC::ProfileNode::debugPrintDataSampleStyle):
        * runtime/Arguments.cpp:
        (JSC::Arguments::getOwnPropertySlot):
        (JSC::Arguments::getOwnPropertyDescriptor):
        (JSC::Arguments::put):
        (JSC::Arguments::deleteProperty):
        * runtime/DateConversion.cpp:
        (JSC::parseDate):
        * runtime/Identifier.h:
        (JSC::Identifier::toStrictUInt32):
        * runtime/JSArray.cpp:
        (JSC::JSArray::getOwnPropertySlot):
        (JSC::JSArray::getOwnPropertyDescriptor):
        (JSC::JSArray::put):
        (JSC::JSArray::deleteProperty):
        * runtime/JSArray.h:
        (JSC::toArrayIndex):
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::encode):
        (JSC::parseInt):
        (JSC::globalFuncJSCPrint):
        * runtime/JSString.h:
        (JSC::RopeBuilder::JSString):
        * runtime/UString.cpp:
        (JSC::UString::toDouble):
        (JSC::putUTF8Triple):
        (JSC::UString::utf8):
        * runtime/UString.h:
        (JSC::UString::~UString):
        (JSC::UString::isNull):
        (JSC::UString::isEmpty):
        (JSC::UString::impl):
        * wtf/text/WTFString.cpp:
        (WTF::String::utf8):
        * wtf/text/WTFString.h:
        (WTF::String::~String):
        (WTF::String::swap):
        (WTF::String::isNull):
        (WTF::String::isEmpty):
        (WTF::String::impl):
        (WTF::String::length):
        (WTF::String::String):
        (WTF::String::isHashTableDeletedValue):

973 974 975 976 977 978 979 980 981
2010-08-12  Gavin Barraclough  <barraclough@apple.com>

        Eeerk! - revert accidentally committed changes in UString!

        * JavaScriptCore.exp:
        * runtime/UString.cpp:
        (JSC::UString::UString):
        * runtime/UString.h:

982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012
2010-08-12  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig

        Change UString constructors to match those in WTF::String.
        This changes behaviour of UString((char*)0) to create null
        strings, akin to UString() rather than UString::empty().
        (This matches String).  Remove unused constructors from
        UString, and add null-terminated UTF-16 constructor, to
        match String.  Move String's constructor into the .cpp to
        match UString.

        * JavaScriptCore.exp:
        * debugger/DebuggerCallFrame.cpp:
        (JSC::DebuggerCallFrame::calculatedFunctionName):
        * runtime/RegExpKey.h:
        (JSC::RegExpKey::RegExpKey):
        * runtime/SmallStrings.cpp:
        (JSC::SmallStrings::createSingleCharacterString):
        * runtime/UString.cpp:
        (JSC::UString::UString):
        * runtime/UString.h:
        (JSC::UString::UString):
        (JSC::UString::swap):
        (JSC::UString::adopt):
        (JSC::UString::operator[]):
        * wtf/text/WTFString.h:
        (WTF::String::String):
        (WTF::String::adopt):
        (WTF::String::operator[]):

1013 1014 1015 1016 1017 1018
2010-08-12  David Levin  <levin@chromium.org>

        Reviewed by NOBODY (build fix).

        * runtime/UString.h: Removed unneccessary #include.

1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032
2010-08-12  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig

        Revert changes to ALWAYS_INLINEness of a couple of functions in UString.
        This appears to have degraded performance.

        * runtime/UString.cpp:
        (JSC::UString::ascii):
        * runtime/UString.h:
        (JSC::UString::length):
        (JSC::UString::isEmpty):
        (JSC::UString::~UString):

1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049
2010-08-12  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] Fix warnings: unknown conversion type character 'l' in format
        https://bugs.webkit.org/show_bug.cgi?id=43359

        Qt port doesn't call any printf in String::format(...), consequently
        using __attribute__((format(printf,m,n))) is incorrect and causes
        false positive warnings on Windows if you build with MinGW.

        Qt port calls QString::vsprintf(...) , which is platform
        independent, and handles %lli, %llu and %llx on all platforms.
        (http://trac.webkit.org/changeset/35712)

        * wtf/text/WTFString.h:

1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061
2010-08-12  Gabor Loki  <loki@webkit.org>

        Reviewed by Geoffrey Garen.

        Fix the array subscript is above array bounds warning in ByteArray on ARM.
        https://bugs.webkit.org/show_bug.cgi?id=43358

        The warning is very similar to this one: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37861

        * wtf/ByteArray.cpp:
        (WTF::ByteArray::create):

1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074
2010-08-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Use GSettings to save/restore Web Inspector settings
        https://bugs.webkit.org/show_bug.cgi?id=43512

        * wtf/gobject/GRefPtr.cpp: Added support for GVariant, used by our
        GSettings support.
        (WTF::refGPtr):
        (WTF::derefGPtr):
        * wtf/gobject/GRefPtr.h:

1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087
2010-08-12  Gabor Loki  <loki@webkit.org>

        Reviewed by Simon Hausmann.

        The scratch register should be saved in YARR with ARM JIT
        https://bugs.webkit.org/show_bug.cgi?id=43910

        Reported by Jocelyn Turcotte.

        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::generateEnter):
        (JSC::Yarr::RegexGenerator::generateReturn):

barraclough@apple.com's avatar
barraclough@apple.com committed
1088 1089 1090 1091 1092 1093 1094
2010-08-11  Gavin Barraclough  <barraclough@apple.com>

        Windows build fix.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/Forward.h:

1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106
2010-08-11  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Geoffrey Garen.

        Date("") should be an invalid date. For IE, Firefox and Chrome, Date("") is invalid date,
        which means isNaN(new Date("")) should return true.
        https://bugs.webkit.org/show_bug.cgi?id=43793
        Tests: fast/js/date-constructor.html

        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::resetDateCache):

1107 1108 1109 1110 1111 1112 1113 1114 1115
2010-08-11  Gavin Barraclough  <barraclough@apple.com>

        Windows & !JIT build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/RegExp.cpp:
        (JSC::RegExp::match):

1116 1117 1118 1119 1120 1121 1122 1123 1124
2010-08-11  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamp by sam weinig

        Touch a file to stop the bot rolling a bit change out!

        * runtime/UString.cpp:
        (JSC::UString::ascii):

1125 1126 1127 1128 1129 1130
2010-08-11  Kevin Ollivier  <kevino@theolliviers.com>

        [wx] Build fix for wx and WebDOM bindings, add CString classes to the list of forwards.

        * wtf/Forward.h:

1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296
2010-08-11  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamps by Darin Adler & Sam Weinig.

        Bug 43867 - Some UString cleanup

        Change JSC::UString data(), size(), and from(), to characters(), length(), and number() to match WTF::String.
        Move string concatenation methods to a new header to simplify down UString.h.  Remove is8Bit().

        * API/JSClassRef.cpp:
        (OpaqueJSClass::~OpaqueJSClass):
        (OpaqueJSClass::className):
        * API/OpaqueJSString.cpp:
        (OpaqueJSString::create):
        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bytecode/CodeBlock.cpp:
        (JSC::constantName):
        (JSC::idName):
        (JSC::CodeBlock::registerName):
        (JSC::regexpName):
        * bytecode/EvalCodeCache.h:
        (JSC::EvalCodeCache::get):
        * bytecompiler/NodesCodegen.cpp:
        (JSC::ResolveNode::emitBytecode):
        (JSC::FunctionCallResolveNode::emitBytecode):
        (JSC::ReadModifyResolveNode::emitBytecode):
        (JSC::processClauseList):
        * parser/ASTBuilder.h:
        (JSC::ASTBuilder::createRegex):
        * parser/ParserArena.h:
        (JSC::IdentifierArena::makeNumericIdentifier):
        * parser/SourceProvider.h:
        (JSC::UStringSourceProvider::data):
        (JSC::UStringSourceProvider::length):
        * profiler/Profiler.cpp:
        * runtime/Arguments.cpp:
        (JSC::Arguments::getOwnPropertySlot):
        (JSC::Arguments::getOwnPropertyNames):
        (JSC::Arguments::put):
        (JSC::Arguments::deleteProperty):
        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncToString):
        * runtime/DatePrototype.cpp:
        (JSC::formatLocaleDate):
        * runtime/ExceptionHelpers.cpp:
        * runtime/FunctionConstructor.cpp:
        * runtime/FunctionPrototype.cpp:
        (JSC::insertSemicolonIfNeeded):
        * runtime/Identifier.h:
        (JSC::Identifier::characters):
        (JSC::Identifier::length):
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::decode):
        (JSC::parseInt):
        (JSC::parseFloat):
        (JSC::globalFuncEscape):
        (JSC::globalFuncUnescape):
        * runtime/JSNumberCell.cpp:
        (JSC::JSNumberCell::toString):
        * runtime/JSONObject.cpp:
        (JSC::gap):
        (JSC::Stringifier::appendQuotedString):
        (JSC::Stringifier::appendStringifiedValue):
        (JSC::Stringifier::indent):
        (JSC::Stringifier::unindent):
        (JSC::Walker::walk):
        * runtime/JSString.cpp:
        (JSC::JSString::replaceCharacter):
        (JSC::JSString::getIndexSlowCase):
        * runtime/JSString.h:
        (JSC::RopeBuilder::JSString):
        (JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
        (JSC::RopeBuilder::fiberCount):
        (JSC::jsSingleCharacterSubstring):
        (JSC::jsNontrivialString):
        (JSC::JSString::getIndex):
        (JSC::jsString):
        (JSC::jsStringWithFinalizer):
        (JSC::jsSubstring):
        (JSC::jsOwnedString):
        * runtime/JSStringBuilder.h:
        (JSC::JSStringBuilder::append):
        * runtime/LiteralParser.h:
        (JSC::LiteralParser::Lexer::Lexer):
        * runtime/NumberPrototype.cpp:
        (JSC::numberProtoFuncToString):
        (JSC::numberProtoFuncToFixed):
        (JSC::numberProtoFuncToExponential):
        (JSC::numberProtoFuncToPrecision):
        * runtime/NumericStrings.h:
        (JSC::NumericStrings::add):
        (JSC::NumericStrings::lookupSmallString):
        * runtime/Operations.h:
        (JSC::jsString):
        * runtime/RegExp.cpp:
        (JSC::RegExp::match):
        * runtime/RegExpCache.cpp:
        (JSC::RegExpCache::lookupOrCreate):
        (JSC::RegExpCache::create):
        * runtime/RegExpConstructor.cpp:
        (JSC::RegExpConstructor::getRightContext):
        * runtime/RegExpObject.cpp:
        (JSC::RegExpObject::match):
        * runtime/RegExpPrototype.cpp:
        (JSC::regExpProtoFuncToString):
        * runtime/StringBuilder.h:
        (JSC::StringBuilder::append):
        * runtime/StringConcatenate.h: Copied from JavaScriptCore/runtime/UString.h.
        (JSC::):
        (JSC::sumWithOverflow):
        (JSC::tryMakeString):
        (JSC::makeString):
        * runtime/StringObject.cpp:
        (JSC::StringObject::getOwnPropertyNames):
        * runtime/StringPrototype.cpp:
        (JSC::substituteBackreferencesSlow):
        (JSC::localeCompare):
        (JSC::jsSpliceSubstringsWithSeparators):
        (JSC::stringProtoFuncReplace):
        (JSC::stringProtoFuncCharAt):
        (JSC::stringProtoFuncCharCodeAt):
        (JSC::stringProtoFuncIndexOf):
        (JSC::stringProtoFuncLastIndexOf):
        (JSC::stringProtoFuncSlice):
        (JSC::stringProtoFuncSplit):
        (JSC::stringProtoFuncSubstr):
        (JSC::stringProtoFuncSubstring):
        (JSC::stringProtoFuncToLowerCase):
        (JSC::stringProtoFuncToUpperCase):
        (JSC::stringProtoFuncFontsize):
        (JSC::stringProtoFuncLink):
        (JSC::trimString):
        * runtime/UString.cpp:
        (JSC::UString::number):
        (JSC::UString::ascii):
        (JSC::UString::operator[]):
        (JSC::UString::toDouble):
        (JSC::UString::find):
        (JSC::UString::rfind):
        (JSC::UString::substr):
        (JSC::operator==):
        (JSC::operator<):
        (JSC::operator>):
        (JSC::UString::UTF8String):
        * runtime/UString.h:
        (JSC::UString::UString):
        (JSC::UString::adopt):
        (JSC::UString::length):
        (JSC::UString::characters):
        (JSC::UString::isNull):
        (JSC::UString::isEmpty):
        (JSC::UString::impl):
        (JSC::UString::cost):
        (JSC::operator==):
        (JSC::operator!=):
        (JSC::codePointCompare):
        (JSC::UString::toArrayIndex):
        (JSC::IdentifierRepHash::hash):
        (WTF::):
        * yarr/RegexJIT.cpp:
        (JSC::Yarr::jitCompileRegex):
        * yarr/RegexParser.h:
        (JSC::Yarr::Parser::Parser):

1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308
2010-08-11  Gabor Loki  <loki@webkit.org>

        Qt build fix (ARMv7).

        Fix invalid conversion from int to Condition.
        Add ARMv7Assembler.cpp to JavaScriptCore.pro.

        * JavaScriptCore.pro:
        * assembler/ARMv7Assembler.h:
        (JSC::ARMv7Assembler::):
        (JSC::ARMv7Assembler::JmpSrc::JmpSrc):

1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325
2010-08-11  Nathan Lawrence  <nlawrence@apple.com>

        Reviewed by Geoffrey Garen.

        At collection time, we frequently want to mark a cell, while checking
        whether it was originally checked.  Previously, this was a get
        operation follwed by a set operation.  Fusing the two saves
        computation and gives a 0.5% sunspider speedup.

        * runtime/Collector.h:
        (JSC::CollectorBitmap::getset):
        (JSC::Heap::checkMarkCell):
        * runtime/JSArray.h:
        (JSC::MarkStack::drain):
        * runtime/JSCell.h:
        (JSC::MarkStack::append):

1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338
2010-08-11  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Improve vsprops copying for Windows build
        https://bugs.webkit.org/show_bug.cgi?id=41982

        When we detect a new SDK, always copy a new set of vsprops files.
        Previously, if someone updated their SDK after updating their sources,
        they could end up with out-of-date vsprops files.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:

1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367
2010-08-10  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Add leakRef and clear to all RefPtr variants
        https://bugs.webkit.org/show_bug.cgi?id=42389

        * API/JSRetainPtr.h: Changed all uses of "template <...>" to instead do
        "template<...>". We should probably put this in the style guide and do it
        consitently. Fixed other minor style issues. Defined many of the inlined
        functions outside the class definition, to avoid style checker warnings
        about multiple statements on a single line and for slightly better clarity
        of the class definition itself. Renamed releaseRef to leakRef. Added a
        releaseRef that calls leakRef so we don't have to rename all callers oat
        once. Added a clear function.

        * wtf/PassRefPtr.h: Changed all uses of releaseRef to leakRef.

        * wtf/RefPtr.h: Changed all uses of "template <...>" to instead do
        "template<...>". Tidied up declarations and comments a bit.
         Changed all uses of releaseRef to leakRef.

        * wtf/RetainPtr.h: Changed all uses of "template <...>" to instead do
        "template<...>". Defined many of the inlined functions outside the class
        definition, to avoid style checker warnings about multiple statements on
        a single line and for slightly better clarity of the class definition itself.
        Renamed releaseRef to leakRef. Added a releaseRef that calls leakRef so we
        don't have to rename all callers at once. Added a clear function.

1368 1369 1370 1371 1372 1373 1374
2010-08-10  Dumitru Daniliuc  <dumi@chromium.org>

        Unreviewed, reverting an unintentional change to a file submitted in r65108.

        * bytecode/CodeBlock.h:
        (JSC::binaryChop):

1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556
2010-08-10  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Sam Weinig

        Bug 43817 - Remove UString::Rep
        UString::Rep has for a long time been replaced by UStringImpl (Rep
        remaining as a typedef).  UStringImpl has since been removed too
        (unified with StringImpl). Remove Rep, rename rep() to impl() and
        m_rep to m_impl.  Also add impl() method to Identifier, and rename
        its UString member from _ustring to m_string.

        * API/JSCallbackObject.h:
        (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty):
        (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
        (JSC::JSCallbackObjectData::JSPrivatePropertyMap::deletePrivateProperty):
        * API/JSCallbackObjectFunctions.h:
        (JSC::::getOwnPropertySlot):
        (JSC::::put):
        (JSC::::deleteProperty):
        (JSC::::getOwnPropertyNames):
        (JSC::::staticValueGetter):
        (JSC::::staticFunctionGetter):
        * API/JSClassRef.cpp:
        (tryCreateStringFromUTF8):
        (OpaqueJSClass::OpaqueJSClass):
        (OpaqueJSClass::~OpaqueJSClass):
        (OpaqueJSClassContextData::OpaqueJSClassContextData):
        * API/JSClassRef.h:
        * API/OpaqueJSString.cpp:
        (OpaqueJSString::ustring):
        * bytecode/EvalCodeCache.h:
        (JSC::EvalCodeCache::get):
        * bytecode/JumpTable.h:
        (JSC::StringJumpTable::offsetForValue):
        (JSC::StringJumpTable::ctiForValue):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::addVar):
        (JSC::BytecodeGenerator::addGlobalVar):
        (JSC::BytecodeGenerator::BytecodeGenerator):
        (JSC::BytecodeGenerator::addParameter):
        (JSC::BytecodeGenerator::registerFor):
        (JSC::BytecodeGenerator::willResolveToArguments):
        (JSC::BytecodeGenerator::uncheckedRegisterForArguments):
        (JSC::BytecodeGenerator::constRegisterFor):
        (JSC::BytecodeGenerator::isLocal):
        (JSC::BytecodeGenerator::isLocalConstant):
        (JSC::BytecodeGenerator::addConstant):
        (JSC::BytecodeGenerator::emitLoad):
        (JSC::BytecodeGenerator::findScopedProperty):
        (JSC::keyForCharacterSwitch):
        (JSC::prepareJumpTableForStringSwitch):
        * bytecompiler/BytecodeGenerator.h:
        * bytecompiler/NodesCodegen.cpp:
        (JSC::processClauseList):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):
        * parser/JSParser.cpp:
        (JSC::JSParser::parseStrictObjectLiteral):
        * pcre/pcre_exec.cpp:
        (Histogram::add):
        * profiler/CallIdentifier.h:
        (JSC::CallIdentifier::Hash::hash):
        * profiler/Profile.cpp:
        * profiler/ProfileNode.cpp:
        (JSC::ProfileNode::debugPrintDataSampleStyle):
        * profiler/ProfileNode.h:
        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncToString):
        * runtime/Identifier.cpp:
        (JSC::Identifier::equal):
        (JSC::IdentifierCStringTranslator::hash):
        (JSC::IdentifierCStringTranslator::equal):
        (JSC::IdentifierCStringTranslator::translate):
        (JSC::Identifier::add):
        (JSC::IdentifierUCharBufferTranslator::hash):
        (JSC::IdentifierUCharBufferTranslator::equal):
        (JSC::IdentifierUCharBufferTranslator::translate):
        (JSC::Identifier::addSlowCase):
        * runtime/Identifier.h:
        (JSC::Identifier::Identifier):
        (JSC::Identifier::ustring):
        (JSC::Identifier::impl):
        (JSC::Identifier::data):
        (JSC::Identifier::size):
        (JSC::Identifier::ascii):
        (JSC::Identifier::isNull):
        (JSC::Identifier::isEmpty):
        (JSC::Identifier::toUInt32):
        (JSC::Identifier::toStrictUInt32):
        (JSC::Identifier::toArrayIndex):
        (JSC::Identifier::toDouble):
        (JSC::Identifier::equal):
        (JSC::Identifier::add):
        * runtime/InitializeThreading.cpp:
        (JSC::initializeThreadingOnce):
        * runtime/InternalFunction.cpp:
        (JSC::InternalFunction::displayName):
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::displayName):
        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::addStaticGlobals):
        * runtime/JSStaticScopeObject.h:
        (JSC::JSStaticScopeObject::JSStaticScopeObject):
        * runtime/JSString.h:
        (JSC::):
        (JSC::RopeBuilder::appendStringInConstruct):
        (JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
        (JSC::jsSingleCharacterSubstring):
        (JSC::jsSubstring):
        * runtime/JSVariableObject.cpp:
        (JSC::JSVariableObject::deleteProperty):
        (JSC::JSVariableObject::symbolTableGet):
        * runtime/JSVariableObject.h:
        (JSC::JSVariableObject::symbolTableGet):
        (JSC::JSVariableObject::symbolTablePut):
        (JSC::JSVariableObject::symbolTablePutWithAttributes):
        * runtime/Lookup.cpp:
        (JSC::HashTable::createTable):
        (JSC::HashTable::deleteTable):
        * runtime/Lookup.h:
        (JSC::HashEntry::initialize):
        (JSC::HashEntry::setKey):
        (JSC::HashEntry::key):
        (JSC::HashTable::entry):
        * runtime/PropertyMapHashTable.h:
        (JSC::PropertyMapEntry::PropertyMapEntry):
        * runtime/PropertyNameArray.cpp:
        (JSC::PropertyNameArray::add):
        * runtime/PropertyNameArray.h:
        (JSC::PropertyNameArray::add):
        (JSC::PropertyNameArray::addKnownUnique):
        * runtime/RegExp.cpp:
        (JSC::RegExp::match):
        * runtime/RegExpCache.cpp:
        (JSC::RegExpCache::create):
        * runtime/RegExpKey.h:
        (JSC::RegExpKey::RegExpKey):
        * runtime/SmallStrings.cpp:
        (JSC::SmallStringsStorage::rep):
        (JSC::SmallStrings::singleCharacterStringRep):
        * runtime/SmallStrings.h:
        * runtime/StringPrototype.cpp:
        (JSC::jsSpliceSubstringsWithSeparators):
        (JSC::stringProtoFuncMatch):
        (JSC::stringProtoFuncSearch):
        * runtime/Structure.cpp:
        (JSC::Structure::~Structure):
        (JSC::Structure::despecifyDictionaryFunction):
        (JSC::Structure::addPropertyTransitionToExistingStructure):
        (JSC::Structure::addPropertyTransition):
        (JSC::Structure::copyPropertyTable):
        (JSC::Structure::get):
        (JSC::Structure::despecifyFunction):
        (JSC::Structure::put):
        (JSC::Structure::hasTransition):
        (JSC::Structure::remove):
        (JSC::Structure::checkConsistency):
        * runtime/Structure.h:
        (JSC::Structure::get):
        (JSC::Structure::hasTransition):
        * runtime/StructureTransitionTable.h:
        * runtime/SymbolTable.h:
        * runtime/UString.cpp:
        (JSC::UString::UString):
        (JSC::UString::toStrictUInt32):
        (JSC::UString::substr):
        * runtime/UString.h:
        (JSC::UString::UString):
        (JSC::UString::adopt):
        (JSC::UString::data):
        (JSC::UString::size):
        (JSC::UString::isNull):
        (JSC::UString::isEmpty):
        (JSC::UString::impl):
        (JSC::UString::cost):
        (JSC::operator==):
        (JSC::codePointCompare):
        (JSC::IdentifierRepHash::hash):
        (WTF::):

1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597
2010-08-10  Gavin Barraclough  <barraclough@apple.com>

        Bug 43816 - Remove UStringImpl
        The class was actually removed a long time ago, replaced by StringImpl.
        UStringImpl is just a typedef onto StringImpl.  Remove this.

        * API/JSClassRef.cpp:
        (OpaqueJSClass::OpaqueJSClass):
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/JSString.cpp:
        (JSC::JSString::resolveRope):
        (JSC::JSString::replaceCharacter):
        * runtime/JSString.h:
        (JSC::RopeBuilder::RopeIterator::operator*):
        (JSC::RopeBuilder::JSString):
        (JSC::RopeBuilder::appendStringInConstruct):
        (JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
        (JSC::jsSingleCharacterSubstring):
        (JSC::jsSubstring):
        * runtime/JSStringBuilder.h:
        (JSC::jsMakeNontrivialString):
        * runtime/RopeImpl.cpp:
        (JSC::RopeImpl::derefFibersNonRecursive):
        * runtime/RopeImpl.h:
        (JSC::RopeImpl::deref):
        * runtime/SmallStrings.cpp:
        (JSC::SmallStringsStorage::SmallStringsStorage):
        * runtime/StringConstructor.cpp:
        (JSC::stringFromCharCodeSlowCase):
        * runtime/StringPrototype.cpp:
        (JSC::jsSpliceSubstringsWithSeparators):
        (JSC::stringProtoFuncFontsize):
        (JSC::stringProtoFuncLink):
        * runtime/UString.cpp:
        (JSC::initializeUString):
        * runtime/UString.h:
        (JSC::UString::adopt):
        (JSC::tryMakeString):
        (JSC::makeString):
        * runtime/UStringImpl.h: Removed.

1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608
2010-08-10  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Eric Seidel.

        Make FastMalloc more portable.
        https://bugs.webkit.org/show_bug.cgi?id=41790

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_Central_FreeList::Populate):
        (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619
2010-08-10  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by David Levin.

        [WINCE] Buildfix for CE 6.0
        https://bugs.webkit.org/show_bug.cgi?id=43027

        CE 6.0 doesn't define localtime in the system include files.

        * wtf/Platform.h: Include ce_time.h on all OS(WINCE).

1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633
2010-08-10  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Sam Weinig.

        Bug 43786 - Move AtomicStringHash from WebCore to WTF
        Also remove deprecated string headers from WebCore/platform/text.

        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/text/AtomicString.h:
        * wtf/text/AtomicStringHash.h: Copied from WebCore/platform/text/AtomicStringHash.h.

1634 1635 1636 1637 1638 1639
2010-08-09  Oliver Hunt  <oliver@apple.com>

        Fix Qt/ARM again, this time including the other changed file.

        * jit/JIT.h:

oliver@apple.com's avatar
oliver@apple.com committed
1640 1641 1642 1643 1644 1645 1646 1647 1648 1649
2010-08-09  Oliver Hunt  <oliver@apple.com>

        Fix Qt/ARM

        C++ overload resolution I stab at thee

        * jit/JITInlineMethods.h:
        (JSC::JIT::beginUninterruptedSequence):
        (JSC::JIT::endUninterruptedSequence):

1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780
2010-08-09  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Allow an assembler/macroassembler to compact branches to more concise forms when linking
        https://bugs.webkit.org/show_bug.cgi?id=43745

        This patch makes it possible for an assembler to convert jumps into a different
        (presumably more efficient) form at link time.  Currently implemented in the
        ARMv7 JIT as that already had logic to delay linking of jumps until the end of
        compilation already.  The ARMv7 JIT chooses between either a 4 byte short jump
        or a full 32-bit offset (and rewrites ITTT instructions as appropriate), so does
        not yet produce the most compact form possible.  The general design of the linker
        should make it relatively simple to introduce new branch types with little effort,
        as the linker has no knowledge of the exact form of any of the branches.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * assembler/ARMv7Assembler.cpp: Added.
        (JSC::):
          Record jump sizes

        * assembler/ARMv7Assembler.h:
        (JSC::ARMv7Assembler::LinkRecord::LinkRecord):
        (JSC::ARMv7Assembler::LinkRecord::from):
        (JSC::ARMv7Assembler::LinkRecord::setFrom):
        (JSC::ARMv7Assembler::LinkRecord::to):
        (JSC::ARMv7Assembler::LinkRecord::type):
        (JSC::ARMv7Assembler::LinkRecord::linkType):
        (JSC::ARMv7Assembler::LinkRecord::setLinkType):
          Encapsulate LinkRecord fields so we can compress the values somewhat

        (JSC::ARMv7Assembler::JmpSrc::JmpSrc):
          Need to record the jump type now

        (JSC::ARMv7Assembler::b):
        (JSC::ARMv7Assembler::blx):
        (JSC::ARMv7Assembler::bx):
          Need to pass the jump types

        (JSC::ARMv7Assembler::executableOffsetFor):
        (JSC::ARMv7Assembler::jumpSizeDelta):
        (JSC::ARMv7Assembler::linkRecordSourceComparator):
        (JSC::ARMv7Assembler::computeJumpType):
        (JSC::ARMv7Assembler::convertJumpTo):
        (JSC::ARMv7Assembler::recordLinkOffsets):
        (JSC::ARMv7Assembler::jumpsToLink):
        (JSC::ARMv7Assembler::link):
        (JSC::ARMv7Assembler::unlinkedCode):
          Helper functions for the linker

        (JSC::ARMv7Assembler::linkJump):
        (JSC::ARMv7Assembler::canBeShortJump):
        (JSC::ARMv7Assembler::linkLongJump):
        (JSC::ARMv7Assembler::linkShortJump):
        (JSC::ARMv7Assembler::linkJumpAbsolute):
           Moving code around for the various jump linking functions

        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::beginUninterruptedSequence):
        (JSC::AbstractMacroAssembler::endUninterruptedSequence):
          We have to track uninterrupted sequences in any assembler that compacts
          branches as that's not something we're allowed to do in such sequences.
          AbstractMacroAssembler has a nop version of these functions as it makes the
          code elsewhere nicer.

        * assembler/LinkBuffer.h:
        (JSC::LinkBuffer::LinkBuffer):
        (JSC::LinkBuffer::link):
        (JSC::LinkBuffer::patch):
        (JSC::LinkBuffer::locationOf):
        (JSC::LinkBuffer::locationOfNearCall):
        (JSC::LinkBuffer::returnAddressOffset):
        (JSC::LinkBuffer::trampolineAt):
          Updated these functions to adjust for any changed offsets in the linked code

        (JSC::LinkBuffer::applyOffset):
          A helper function to deal with the now potentially moved labels

        (JSC::LinkBuffer::linkCode):
          The new and mighty linker function

        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::MacroAssemblerARMv7):
        (JSC::MacroAssemblerARMv7::beginUninterruptedSequence):
        (JSC::MacroAssemblerARMv7::endUninterruptedSequence):
        (JSC::MacroAssemblerARMv7::jumpsToLink):
        (JSC::MacroAssemblerARMv7::unlinkedCode):
        (JSC::MacroAssemblerARMv7::computeJumpType):
        (JSC::MacroAssemblerARMv7::convertJumpTo):
        (JSC::MacroAssemblerARMv7::recordLinkOffsets):
        (JSC::MacroAssemblerARMv7::jumpSizeDelta):
        (JSC::MacroAssemblerARMv7::link):
        (JSC::MacroAssemblerARMv7::jump):
        (JSC::MacroAssemblerARMv7::branchMul32):
        (JSC::MacroAssemblerARMv7::breakpoint):
        (JSC::MacroAssemblerARMv7::nearCall):
        (JSC::MacroAssemblerARMv7::call):
        (JSC::MacroAssemblerARMv7::ret):
        (JSC::MacroAssemblerARMv7::tailRecursiveCall):
        (JSC::MacroAssemblerARMv7::executableOffsetFor):
        (JSC::MacroAssemblerARMv7::inUninterruptedSequence):
        (JSC::MacroAssemblerARMv7::makeJump):
        (JSC::MacroAssemblerARMv7::makeBranch):
           All branches need to pass on their type now

        * jit/ExecutableAllocator.h:
        (JSC::ExecutablePool::returnLastBytes):
           We can't know ahead of time how much space will be necessary to
           hold the linked code if we're compacting branches, this new
           function allows us to return the unused bytes at the end of linking

        * jit/JIT.cpp:
        (JSC::JIT::JIT):
        (JSC::JIT::privateCompile):
        * jit/JIT.h:
        (JSC::JIT::compile):
           The JIT class now needs to take a linker offset so that recompilation
           can generate the same jumps when using branch compaction.
        * jit/JITArithmetic32_64.cpp:
        (JSC::JIT::emitSlow_op_mod):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        (JSC::JIT::privateCompileCTINativeCall):
          Update for new trampolineAt changes

        * wtf/FastMalloc.cpp:
        (WTF::TCMallocStats::):
        * wtf/Platform.h:

barraclough@apple.com's avatar
barraclough@apple.com committed
1781 1782 1783 1784 1785 1786
2010-08-09  Gavin Barraclough  <barraclough@apple.com>

        Qt build fix III.

        * wtf/text/WTFString.h:

barraclough@apple.com's avatar
barraclough@apple.com committed
1787 1788 1789 1790 1791 1792
2010-08-09  Gavin Barraclough  <barraclough@apple.com>

        Qt build fix.

        * wtf/qt/StringQt.cpp:

1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803
2010-08-06  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Sam Weinig

        Bug 43594 - Add string forwards to Forward.h
        This allows us to remove forward declarations for these classes from
        WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/Forward.h:

1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861
2010-08-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r64938.
        http://trac.webkit.org/changeset/64938
        https://bugs.webkit.org/show_bug.cgi?id=43685

        Did not compile on several ports (Requested by abarth on
        #webkit).

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * assembler/AbstractMacroAssembler.h:
        * assembler/MacroAssembler.h:
        * assembler/MacroAssemblerX86.h:
        (JSC::MacroAssemblerX86::load32):
        (JSC::MacroAssemblerX86::store32):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::movl_rm):
        (JSC::X86Assembler::movl_mr):
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::markAggregate):
        * bytecode/Instruction.h:
        (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::):
        (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
        (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
        * bytecode/StructureStubInfo.cpp:
        (JSC::StructureStubInfo::deref):
        * bytecode/StructureStubInfo.h:
        (JSC::StructureStubInfo::initGetByIdProto):
        (JSC::StructureStubInfo::initGetByIdChain):
        (JSC::StructureStubInfo::):
        * jit/JIT.h:
        * jit/JITMarkObjects.cpp: Removed.
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::compileGetDirectOffset):
        (JSC::JIT::testPrototype):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::compileGetDirectOffset):
        (JSC::JIT::testPrototype):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/JITStubs.cpp:
        (JSC::setupPolymorphicProtoList):
        * wtf/Platform.h:

1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946
2010-08-07  Nathan Lawrence  <nlawrence@apple.com>

        Reviewed by Geoffrey Garen.

        The JIT code contains a number of direct references to GC'd objects.
        When we have movable objects, these references will need to be
        updated.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::int32AtLocation):
        (JSC::AbstractMacroAssembler::pointerAtLocation):
        (JSC::AbstractMacroAssembler::jumpTarget):
        * assembler/MacroAssembler.h:
        (JSC::MacroAssembler::loadPtrWithPatch):
            Normally, loadPtr will optimize when the register is eax.  Since
            the slightly smaller instruction changes the offsets, it messes up
            our ability to repatch the code.  We added this new instruction
            that garuntees a constant size.
        * assembler/MacroAssemblerX86.h:
        (JSC::MacroAssemblerX86::load32WithPatch):
            Changed load32 in the same way described above.
        (JSC::MacroAssemblerX86::load32):
            Moved the logic to optimize laod32 from movl_mr to load32
        (JSC::MacroAssemblerX86::store32):
            Moved the logic to optimize store32 from movl_rm to store32
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::movl_rm):
        (JSC::X86Assembler::movl_mr):
        (JSC::X86Assembler::int32AtLocation):
        (JSC::X86Assembler::pointerAtLocation):
        (JSC::X86Assembler::jumpTarget):
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::markAggregate):
        * bytecode/Instruction.h:
            As described in StructureStubInfo.h, we needed to add additional
            fields to both StructureStubInfo and
            PolymorphicAccessStructureList so that we can determine the
            structure of the JITed code at patch time.
        (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
        (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
        * bytecode/StructureStubInfo.cpp:
        (JSC::StructureStubInfo::markAggregate):
            Added this function to mark the JITed code that correosponds to
            this structure stub info.
        * bytecode/StructureStubInfo.h:
        (JSC::StructureStubInfo::initGetByIdProto):
        (JSC::StructureStubInfo::initGetByIdChain):
        (JSC::StructureStubInfo::):
        * jit/JIT.h:
        * jit/JITMarkObjects.cpp: Added.
        (JSC::JIT::patchPrototypeStructureAddress):
        (JSC::JIT::patchGetDirectOffset):
        (JSC::JIT::markGetByIdProto):
        (JSC::JIT::markGetByIdChain):
        (JSC::JIT::markGetByIdProtoList):
        (JSC::JIT::markPutByIdTransition):
        (JSC::JIT::markGlobalObjectReference):
        * jit/JITPropertyAccess.cpp:
            Added asserts for the patch offsets.
        (JSC::JIT::compileGetDirectOffset):
        (JSC::JIT::testPrototype):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::compileGetDirectOffset):
        (JSC::JIT::testPrototype):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/JITStubs.cpp:
        (JSC::setupPolymorphicProtoList):
        * wtf/Platform.h:
            Added ENABLE_MOVABLE_GC_OBJECTS flag

1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995
2010-08-07  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Revert JSArray to point to the beginning of the contained ArrayStorage
        struct.  This is described in
        https://bugs.webkit.org/show_bug.cgi?id=43526.

        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::emit_op_get_by_val):
        (JSC::JIT::emit_op_put_by_val):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::emit_op_get_by_val):
        (JSC::JIT::emit_op_put_by_val):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        * runtime/JSArray.cpp:
        (JSC::JSArray::JSArray):
        (JSC::JSArray::~JSArray):
        (JSC::JSArray::getOwnPropertySlot):
        (JSC::JSArray::getOwnPropertyDescriptor):
        (JSC::JSArray::put):
        (JSC::JSArray::putSlowCase):
        (JSC::JSArray::deleteProperty):
        (JSC::JSArray::getOwnPropertyNames):
        (JSC::JSArray::getNewVectorLength):
        (JSC::JSArray::increaseVectorLength):
        (JSC::JSArray::increaseVectorPrefixLength):
        (JSC::JSArray::setLength):
        (JSC::JSArray::pop):
        (JSC::JSArray::push):
        (JSC::JSArray::shiftCount):
        (JSC::JSArray::unshiftCount):
        (JSC::JSArray::sortNumeric):
        (JSC::JSArray::sort):
        (JSC::JSArray::fillArgList):
        (JSC::JSArray::copyToRegisters):
        (JSC::JSArray::compactForSorting):
        (JSC::JSArray::subclassData):
        (JSC::JSArray::setSubclassData):
        (JSC::JSArray::checkConsistency):
        * runtime/JSArray.h:
        (JSC::JSArray::length):
        (JSC::JSArray::canGetIndex):
        (JSC::JSArray::getIndex):
        (JSC::JSArray::setIndex):
        (JSC::JSArray::uncheckedSetIndex):
        (JSC::JSArray::markChildrenDirect):

1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006
2010-08-07  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        Add ENABLE(YARR) guard around JSGlobalData::m_regexAllocator
        https://bugs.webkit.org/show_bug.cgi?id=43399

        m_regexAllocator is used only by RegExp::compile which is guarded with ENABLE(YARR).

        * runtime/JSGlobalData.h:

2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017
2010-08-07  Patrick Roland Gansterer  <paroga@paroga.com>

        Reviewed by Eric Seidel.

        [Qt] Enable JIT on WinCE
        https://bugs.webkit.org/show_bug.cgi?id=43303

        Add ExtraCompiler for generating GeneratedJITStubs_MSVC.asm.

        * DerivedSources.pro:

2018 2019 2020 2021 2022 2023 2024 2025 2026 2027
2010-08-07  Dan Bernstein  <mitz@apple.com>

        Reviewed by Anders Carlsson.

        Created a separate SimpleFontData constructor exclusively for SVG fonts and moved the CTFontRef
        from SimpleFontData to FontPlatformData.
        https://bugs.webkit.org/show_bug.cgi?id=43674

        * wtf/Platform.h: Moved definitions of WTF_USE_CORE_TEXT and WTF_USE_ATSUI here from WebCore/config.h.

2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043
2010-08-07  Zoltan Herczeg  <zherczeg@webkit.org>

        Reviewed by Eric Seidel.

        Bitmap.h has no default constructor
        https://bugs.webkit.org/show_bug.cgi?id=43619

        Without a constructor, the initial bits of the Bitmap class
        are undefinied. If only a few, or zero bits are 0, the memory
        area provided by AlignedMemoryAllocator can be easly exhausted.

        Csaba Osztrogonác helped to find this bug.

        * wtf/Bitmap.h:
        (WTF::::Bitmap):

2044 2045 2046 2047 2048 2049
2010-08-06  Rafael Antognolli  <antognolli@profusion.mobi>

        [EFL] Build fix.

        * CMakeLists.txt: add runtime/CGHandle.cpp.

2050 2051 2052 2053 2054 2055 2056 2057
2010-08-06  Jessie Berlin  <jberlin@apple.com>

        Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
        Unreviewed.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/Forward.h:

2058 2059 2060 2061 2062 2063
2010-08-06  Jessie Berlin  <jberlin@apple.com>

        Windows Build Fix (continued). Unreviewed.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

2064 2065 2066 2067 2068 2069 2070
2010-08-06  Jessie Berlin  <jberlin@apple.com>

        Windows Build Fix. Unreviewed.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        Add GCHandle.h and GCHandle.cpp.

2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120
2010-08-06  Nathan Lawrence  <nlawrence@apple.com>

        Reviewed by Geoffrey Garen.

        https://bugs.webkit.org/show_bug.cgi?id=43207

        WeakGCPtr's should instead of directly pointing to the GC'd object
        should be directed to an array of pointers that can be updated for
        movable objects.

        * Android.mk:
        * GNUmakefile.am:
        * JavaScriptCore.exp:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/Collector.cpp:
        (JSC::Heap::destroy):
        (JSC::Heap::allocateBlock):
        (JSC::Heap::freeBlock):
        (JSC::Heap::updateWeakGCHandles):
        (JSC::WeakGCHandlePool::update):
        (JSC::Heap::addWeakGCHandle):
        (JSC::Heap::markRoots):
        * runtime/Collector.h:
        (JSC::Heap::weakGCHandlePool):
        * runtime/GCHandle.cpp: Added.
        (JSC::WeakGCHandle::pool):
        (JSC::WeakGCHandlePool::WeakGCHandlePool):
        (JSC::WeakGCHandlePool::allocate):
        (JSC::WeakGCHandlePool::free):
        (JSC::WeakGCHandlePool::operator new):
        * runtime/GCHandle.h: Added.
        (JSC::WeakGCHandle::isValidPtr):
        (JSC::WeakGCHandle::isPtr):
        (JSC::WeakGCHandle::isNext):
        (JSC::WeakGCHandle::invalidate):
        (JSC::WeakGCHandle::get):
        (JSC::WeakGCHandle::set):
        (JSC::WeakGCHandle::getNextInFreeList):
        (JSC::WeakGCHandle::setNextInFreeList):
        (JSC::WeakGCHandlePool::isFull):
        * runtime/WeakGCPtr.h:
        (JSC::WeakGCPtr::WeakGCPtr):
        (JSC::WeakGCPtr::~WeakGCPtr):
        (JSC::WeakGCPtr::get):
        (JSC::WeakGCPtr::clear):
        (JSC::WeakGCPtr::assign):
        (JSC::get):

2121 2122 2123 2124 2125 2126 2127 2128
2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Fix warnings about difference in symbol visiblity on Mac OS X

        * jsc.pro:

2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146
2010-08-06  Zoltan Herczeg  <zherczeg@webkit.org>

        Reviewed by Darin Adler.

        Refactor identifier parsing in lexer
        https://bugs.webkit.org/show_bug.cgi?id=41845

        The code is refactored to avoid gotos. The new code
        has the same performance as the old one.

        SunSpider --parse-only: no change (from 34.0ms to 33.6ms)
        SunSpider: no change (from 523.2ms to 523.5ms)

        * parser/Lexer.cpp:
        (JSC::Lexer::parseIdent):
        (JSC::Lexer::lex):
        * parser/Lexer.h:

2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162
2010-08-06  Gabor Loki  <loki@webkit.org>

        Reviewed by Gavin Barraclough.

        The ARM JIT does not support JSValue32_64 with RVCT
        https://bugs.webkit.org/show_bug.cgi?id=43411

        JSValue32_64 is enabled for RVCT by default.

        * create_jit_stubs:
        * jit/JITStubs.cpp:
        (JSC::ctiTrampoline):
        (JSC::ctiVMThrowTrampoline):
        (JSC::ctiOpThrowNotCaught):
        * wtf/Platform.h:

2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175
2010-08-05  Chao-ying Fu  <fu@mips.com>

        Reviewed by Darin Adler.

        Define WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER for MIPS
        https://bugs.webkit.org/show_bug.cgi?id=43514

        MIPS needs to define WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER, so that
        RenderArena::allocate() can return 8-byte aligned memory to avoid
        exceptions on sdc1/ldc1.

        * wtf/Platform.h:

2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186
2010-08-05  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Sam Weinig

        Bug 43594 - Add string forwards to Forward.h
        This allows us to remove forward declarations for these classes from
        WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/Forward.h:

2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198
2010-08-05  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Mark Rowe.

        Fixed leak seen on buildbot.

        * runtime/GCActivityCallbackCF.cpp:
        (JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
        (JSC::DefaultGCActivityCallback::~DefaultGCActivityCallback):
        (JSC::DefaultGCActivityCallback::operator()): Make out timer a RetainPtr,
        since anything less would be uncivilized.