ChangeLog 1.46 MB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
2013-04-07  David Kilzer  <ddkilzer@apple.com>

        Remove the rest of SVG_DOM_OBJC_BINDINGS
        <http://webkit.org/b/114112>

        Reviewed by Geoffrey Garen.

        * Scripts/webkitperl/FeatureList.pm:
        - Remove --svg-dom-objc-bindings switch.
        * qmake/mkspecs/features/features.pri:
        - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.

13 14 15 16 17 18 19 20 21 22 23 24 25 26 27
2013-04-07  Ed Bartosh  <bartosh@gmail.com>

        [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
        https://bugs.webkit.org/show_bug.cgi?id=114089

        Reviewed by Chris Fleizach.

        Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
        * DumpRenderTree/AccessibilityController.cpp:
        * DumpRenderTree/AccessibilityUIElement.cpp:
        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
        (DumpRenderTreeChrome::DumpRenderTreeChrome):
        * DumpRenderTree/efl/DumpRenderTreeChrome.h:
        (DumpRenderTreeChrome):

28 29 30 31 32 33 34 35 36 37
2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>

        Build fix after r147857, remove remaining USE(JSC) guards.

        Unreviewed.

        * DumpRenderTree/config.h:
        * TestWebKitAPI/config.h:
        * WebKitTestRunner/config.h:

38 39 40 41 42 43 44 45 46 47 48 49 50
2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>

        Rename sheriffbot to webkitbot
        https://bugs.webkit.org/show_bug.cgi?id=114109

        Reviewed by Benjamin Poulain.

        Renamed since sheriffbot will be used in Blink.

        * Scripts/webkitpy/tool/commands/sheriffbot.py:
        (SheriffBot):
        (SheriffBot.begin_work_queue):

51 52 53 54 55 56 57 58 59 60 61 62
2013-04-06  Oliver Hunt  <oliver@apple.com>

        Unify the many and varied stack trace mechanisms, and make the result sane.
        https://bugs.webkit.org/show_bug.cgi?id=114072

        Reviewed by Filip Pizlo.

        The commandline jsc executable no longer requires arguments, so
        I've made run-jsc work without them.

        * Scripts/run-jsc:

63 64 65 66 67 68 69 70 71
2013-04-06  Ed Bartosh  <bartosh@gmail.com>

        [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
        https://bugs.webkit.org/show_bug.cgi?id=114086

        Reviewed by Tim Horton.

        * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h

72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87
2013-04-06  Zan Dobersek  <zdobersek@igalia.com>

        Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=114083

        Reviewed by Ryosuke Niwa.

        Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
        in TestWebKitAPI and WebKitTestRunner.

        * TestWebKitAPI/config.h:
        * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
        (TestWebKitAPI::InjectedBundleController::platformInitialize):
        * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
        (WTR::InjectedBundle::platformInitialize):

88 89 90 91 92 93 94 95 96
2013-04-06  Geoffrey Garen  <ggaren@apple.com>

        Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
        https://bugs.webkit.org/show_bug.cgi?id=114094

        Reviewed by Anders Carlsson.

        * Scripts/run-jsc:

97 98 99 100 101 102 103 104 105 106 107 108 109 110 111
2013-04-05  Ojan Vafai  <ojan@chromium.org>

        Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
        https://bugs.webkit.org/show_bug.cgi?id=114080

        Reviewed by Ryosuke Niwa.

        This way, the WebKit and Blink dashboard code can change as appropriate without
        needing to consider the other project's needs. This still doesn't update the
        buildbots to upload to the new location, or the dashboard code to pull the
        results.json files from the new location, but it at least allows for changing the
        UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).

        * TestResultServer/app.yaml:

112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127
2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>

        Re-enable testing on the commit queue
        https://bugs.webkit.org/show_bug.cgi?id=114078

        Reviewed by Darin Adler.

        Re-enabled the feature and the associated tests.

        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        (CommitQueueTask.run):
        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        (CommitQueueTaskTest._run_through_task):
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        (CommitQueueTest._mock_test_result):

128 129 130 131 132 133 134 135 136 137 138 139
2013-04-05  Oliver Hunt  <oliver@apple.com>

        Unify the many and varied stack trace mechanisms, and make the result sane.
        https://bugs.webkit.org/show_bug.cgi?id=114072

        Reviewed by Filip Pizlo.

        The commandline jsc executable no longer requires arguments, so
        I've made run-jsc work without them.

        * Scripts/run-jsc:

140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155
2013-04-05  Chris Fleizach  <cfleizach@apple.com>

        AX: Make SVG Group containers accessible elements
        https://bugs.webkit.org/show_bug.cgi?id=113939

        Reviewed by Simon Fraser.

        Implement axController.elementAtPoint for iOS.
        Implement a correct version of clickPoint for iOS.

        * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
        (AccessibilityController::elementAtPoint):
        * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
        (AccessibilityUIElement::clickPointX):
        (AccessibilityUIElement::clickPointY):

156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174
2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r147773 and r147774.
        http://trac.webkit.org/changeset/147773
        http://trac.webkit.org/changeset/147774
        https://bugs.webkit.org/show_bug.cgi?id=114056

        Causing some exceptions on AppEngine I don't understand
        (Requested by rniwa on #webkit).

        * QueueStatusServer/config/queues.py:
        * QueueStatusServer/model/queues.py:
        (Queue.short_name):
        (Queue.display_name):
        * QueueStatusServer/model/queues_unittest.py:
        (QueueTest.test_short_name):
        (QueueTest.test_display_name):
        (QueueTest.test_name_with_underscores):

175 176 177 178 179 180 181 182 183 184
2013-04-05  Geoffrey Garen  <ggaren@apple.com>

        Fixed run-bindings-tests by removing V8
        https://bugs.webkit.org/show_bug.cgi?id=114053

        Reviewed by Benjamin Poulain.

        * Scripts/run-bindings-tests:
        (main):

rniwa@webkit.org's avatar
rniwa@webkit.org committed
185 186 187 188 189 190 191 192
2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix.

        * QueueStatusServer/model/queues.py:
        (Queue.short_name):
        (Queue.display_name):

193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210
2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>

        Remove Chromium EWS bots from the queue status server
        https://bugs.webkit.org/show_bug.cgi?id=113988

        Reviewed by Benjamin Poulain.

        Removed Chromium EWS bots.

        * QueueStatusServer/config/queues.py:
        * QueueStatusServer/model/queues.py:
        (Queue.short_name):
        (Queue.display_name):
        * QueueStatusServer/model/queues_unittest.py:
        (QueueTest.test_short_name):
        (QueueTest.test_display_name):
        (QueueTest.test_name_with_underscores):

211 212 213 214 215 216 217 218 219
2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>

        [EFL] Enable indexed database
        https://bugs.webkit.org/show_bug.cgi?id=107248

        Reviewed by Alexis Menard.

        * Scripts/webkitperl/FeatureList.pm:

220 221 222 223 224 225 226 227 228
2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Remove vestiges of Chromium bits from watchlists.
        https://bugs.webkit.org/show_bug.cgi?id=114047

        Reviewed by Ryosuke Niwa.

        * Scripts/webkitpy/common/config/watchlist: Removed vestiges.

229 230 231 232 233 234
2013-04-05  Chris Fleizach  <cfleizach@apple.com>

        Add James Craig to the contributors list.

        * Scripts/webkitpy/common/config/committers.py:

235 236 237 238 239 240
2013-04-04  Kent Tamura  <tkent@chromium.org>

        Remove ChromiumPublicApi pattern, and cc/message rules for it.

        * Scripts/webkitpy/common/config/watchlist:

241 242 243 244 245 246 247 248 249 250 251 252 253 254 255
2013-04-04  Benjamin Poulain  <bpoulain@apple.com>

        Temporarily disable the Python unittests broken by the commit queue not running layout tests
        https://bugs.webkit.org/show_bug.cgi?id=113997

        Reviewed by Ryosuke Niwa.

        Disable the tests until Ryosuke gets the time and hardware to have
        a testing commit-queue.

        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        (CommitQueueTaskTest):
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        (CommitQueueTest):

256 257 258 259 260 261 262 263 264 265 266 267
2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>

        Remove Chromium builders from build.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=113990

        Reviewed by Benjamin Poulain.

        Land the part to disable triggering of Chromium builders first so that we may start
        deleting more Chromium code that breaks the update step.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

268 269 270 271 272 273 274 275 276 277 278 279
2013-04-04  Benjamin Poulain  <bpoulain@apple.com>

        Remove Chromium's DumpRenderTree
        https://bugs.webkit.org/show_bug.cgi?id=113989

        Reviewed by Kent Tamura.

        On second thought, let's not go to Camelot. It is a silly place.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):

280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397
2013-04-04  Geoffrey Garen  <ggaren@apple.com>

        Nixed the defunct chromium folder from DumpRenderTree
        https://bugs.webkit.org/show_bug.cgi?id=113993

        Reviewed by Ryosuke Niwa.

        * DumpRenderTree/chromium: Removed.
        * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
        * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
        * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
        * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
        * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
        * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
        * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
        * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
        * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
        * DumpRenderTree/chromium/MockPlatform.h: Removed.
        * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
        * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
        * DumpRenderTree/chromium/Task.cpp: Removed.
        * DumpRenderTree/chromium/Task.h: Removed.
        * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
        * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
        * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
        * DumpRenderTree/chromium/TestNavigationController.h: Removed.
        * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
        * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
        * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
        * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
        * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
        * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
        * DumpRenderTree/chromium/TestRunner: Removed.
        * DumpRenderTree/chromium/TestRunner/public: Removed.
        * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
        * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
        * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
        * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
        * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
        * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
        * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src: Removed.
        * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
        * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
        * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
        * DumpRenderTree/chromium/TestShell.cpp: Removed.
        * DumpRenderTree/chromium/TestShell.h: Removed.
        * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
        * DumpRenderTree/chromium/TestShellMac.mm: Removed.
        * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
        * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
        * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
        * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
        * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
        * DumpRenderTree/chromium/WebViewHost.h: Removed.
        * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
        * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
        * DumpRenderTree/chromium/config.h: Removed.
        * DumpRenderTree/chromium/fonts.conf: Removed.

398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423
2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>

        Remove the rebaseline queue server since nobody except maybe one person from Google uses it.

        Rubber stamped by Benjamin Poulain.

        * RebaselineQueueServer: Removed.
        * RebaselineQueueServer/app.yaml: Removed.
        * RebaselineQueueServer/handlers: Removed.
        * RebaselineQueueServer/handlers/__init__.py: Removed.
        * RebaselineQueueServer/handlers/builderqueue.py: Removed.
        * RebaselineQueueServer/handlers/pages.py: Removed.
        * RebaselineQueueServer/index.yaml: Removed.
        * RebaselineQueueServer/main.py: Removed.
        * RebaselineQueueServer/model: Removed.
        * RebaselineQueueServer/model/__init__.py: Removed.
        * RebaselineQueueServer/model/queueentry.py: Removed.
        * RebaselineQueueServer/static: Removed.
        * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
        * RebaselineQueueServer/static/styles.css: Removed.
        * RebaselineQueueServer/templates: Removed.
        * RebaselineQueueServer/templates/builder-picker.html: Removed.
        * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
        * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
        * RebaselineQueueServer/templates/home.html: Removed.

424 425 426 427 428 429 430 431 432 433 434 435 436 437
2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>

        Fix setup-commit-queue and temporarily disable testing on commit-queue
        https://bugs.webkit.org/show_bug.cgi?id=113979

        Reviewed by Benjamin Poulain.

        Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
        and temporarily disable tests in commit-queue as we don't have enough resources at the moment.

        * EWSTools/setup-commit-queue.sh:
        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        (CommitQueueTask.run):

438 439 440 441 442 443 444 445 446 447 448 449 450 451
2013-04-04  Dirk Pranke  <dpranke@chromium.org>

        temporarily make flakiness dashboard work again webkit.org bots
        https://bugs.webkit.org/show_bug.cgi?id=113972

        Reviewed by Ojan Vafai.

        This patch disables the chromium.org layout test bots TestExpectations
        parsing temporarily until we can work out the right way to split into
        two instances for webkit.org and chromium.org and figure out which
        code to delete where :).

        * TestResultServer/static-dashboards/flakiness_dashboard.js:

452 453 454 455 456 457 458 459
2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>

        Fix webkitpy tests after r147678.

        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        (CommitQueueTest.test_commit_queue):
        (test_manual_reject_during_processing):

460 461 462 463 464 465 466 467 468 469 470
2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>

        The commit queue should use Mac MountainLion port
        https://bugs.webkit.org/show_bug.cgi?id=113971

        Reviewed by Lucas Forschler.

        * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
        * Scripts/webkitpy/tool/commands/queues.py:
        (CommitQueue):

471 472 473 474 475 476 477 478 479 480 481 482 483 484
2013-04-04  Dirk Pranke  <dpranke@chromium.org>

        turn off running tests on chromium linux EWS bots
        https://bugs.webkit.org/show_bug.cgi?id=113959

        Reviewed by Geoffrey Garen.

        Now that the Chromium port is no longer being maintained
        there's little point in running the tests. Soon we should
        just shut this bot off altogether.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (ChromiumLinuxEWS):

485 486 487 488 489 490
2013-04-04  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.

        * Scripts/webkitpy/common/config/watchlist:

491 492 493 494 495 496 497 498 499 500
2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>

        Indentation fix to get webkit-patch working again after r147625

        Unreviewed.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (MacEWS):
        (MacWK2EWS):

501 502 503 504 505 506 507 508 509 510
2013-04-04  Lucas Forschler  <lforschler@apple.com>

        Turn tests back on for Mac WK1/WK2 EWS.
        
        Unreviewed.
        
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (MacEWS):
        (MacWK2EWS):

511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535
2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>

        [GTK][WK2] MiniBrowser custom URI scheme support
        https://bugs.webkit.org/show_bug.cgi?id=112419

        Reviewed by Carlos Garcia Campos.

        Add support for about URIs in MiniBrowser. An example about page is show
        with URI "about:minibrowser", the rest of the cases it will show a
        proper message explaining that the about page didn't exist.

        Internally it uses "minibrowser-about" prefix instead of "about", but
        from the user point of view it works with "about" prefix.

        * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
        (getInternalURI): Method to convert URIs from "about" prefix to
        "minibrowser-about".
        (getExternalURI): Opposite method.
        (webViewURIChanged): Use "about" prefix to show the URI to users.
        (webViewEnterFullScreen): Ditto.
        (browser_window_load_uri): Use "minibrowser-about" prefix internally.
        * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
        (aboutURISchemeRequestCallback): Callback to manage about calls.
        (main): Register the URI scheme to manage about URIs.

roger_fong@apple.com's avatar
roger_fong@apple.com committed
536 537 538 539 540 541 542
2013-04-03  Roger Fong  <roger_fong@apple.com>

        Re-enable WinEWS tests.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (WinEWS):

543 544 545 546 547 548 549 550 551 552 553
2013-04-03  Zan Dobersek  <zdobersek@igalia.com>

        [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
        https://bugs.webkit.org/show_bug.cgi?id=113883

        Reviewed by Martin Robinson.

        * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
        * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
        The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.

554 555 556 557 558 559 560 561 562 563 564 565
2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>

        [GTK] Include Pango in jhbuild-optional.modules
        https://bugs.webkit.org/show_bug.cgi?id=113878

        Reviewed by Martin Robinson.

        Since r147547 Pango 1.32.0 is required. Including the module in the
        JHBuild optional moduleset.

        * gtk/jhbuild-optional.modules: Add Pango module.

566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588
2013-04-03  Zeno Albisser  <zeno@webkit.org>

        [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
        https://bugs.webkit.org/show_bug.cgi?id=113864

        Moving setDefersLoading from TestRunnerQt to TestRunner
        requires access to the non-Qt TestRunner.
        As long as we instantiate both TestRunner and TestRunnerQt,
        we need a separate getter for the non-Qt TestRunner instance.

        Reviewed by Simon Hausmann.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebPage::resetSettings):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        (DumpRenderTree::jscTestRunner):
        * DumpRenderTree/qt/TestRunnerQt.cpp:
        (TestRunner::setDefersLoading):
            Moving setDefersLoading from TestRunnerQt
            to TestRunner.
        * DumpRenderTree/qt/TestRunnerQt.h:
        (TestRunnerQt):

589 590 591 592 593 594 595 596 597 598 599
2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>

        [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
        https://bugs.webkit.org/show_bug.cgi?id=104779

        Reviewed by Carlos Garcia Campos.

        * Scripts/run-gtk-tests:
        (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
        passing in current trunk.

600 601 602 603 604 605 606 607 608 609 610 611
2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>

        Fix HAVE(QTTESTSUPPORT) logic

        build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
        resulting in HAVE(QTTESTSUPPORT) never being true.
        Move that logic down in sanitizeFeatures.

        Rubber-stamped by Tor Arne Vestbø.

        * qmake/mkspecs/features/features.prf:

612 613 614 615 616 617 618 619 620
2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Bump required versions of some dependencies
        https://bugs.webkit.org/show_bug.cgi?id=113282

        Reviewed by Martin Robinson.

        * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.

621 622 623 624 625 626 627 628 629 630 631 632 633
2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>

        [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
        https://bugs.webkit.org/show_bug.cgi?id=113809

        Reviewed by Philippe Normand.

        Newer Linux kernels have removed some deprecated macros from v4l2
        headers, causing gst-plugins-good's build to break. We don't need it
        right now, so just disable it.

        * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.

634 635 636 637 638 639 640 641 642 643 644
2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
        https://bugs.webkit.org/show_bug.cgi?id=113535

        Reviewed by Simon Hausmann.

        Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.

        * qmake/mkspecs/features/features.prf:

645 646 647 648 649 650 651 652 653 654 655 656 657 658 659
2013-04-03  Zeno Albisser  <zeno@webkit.org>

        [Qt] Move logic of simple forwarding functions to TestRunner.
        https://bugs.webkit.org/show_bug.cgi?id=113863

        Reviewed by Simon Hausmann.

        * DumpRenderTree/qt/TestRunnerQt.cpp:
        (TestRunner::setTextDirection):
        (TestRunner::goBack):
        (TestRunner::evaluateScriptInIsolatedWorld):
        (TestRunner::addUserStyleSheet):
        * DumpRenderTree/qt/TestRunnerQt.h:
        (TestRunnerQt):

660 661 662 663 664 665 666 667 668 669 670 671
2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>

        [Qt] Disable media support using QuickTime if deployment target != SDK

        We link to a single libWebKitSystemInterface static lib, so unless the
        deployment target matches the SDK let's not pretend like we'll be able
        to run on anything lower than the SDK version.

        Reviewed by Simon Hausmann.

        * qmake/mkspecs/features/features.prf:

672 673 674 675 676 677 678 679 680 681 682
2013-04-02  James Craig  <james@cookiecrook.com>

        AXRoleDescripton for DL is "list"; should be "description list"
        https://bugs.webkit.org/show_bug.cgi?id=111665

        Reviewed by Chris Fleizach.

        Defining the role and description strings.

        * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

683 684 685 686 687 688 689
2013-04-02  Roger Fong  <roger_fong@apple.com>

        Unreviewed. Disable running tests on Win EWS queue.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (WinEWS):

690 691 692 693 694 695 696 697 698
2013-04-02  Lucas Forschler  <lforschler@apple.com>

        Disable running tests on the MAC WK2 EWS queue.
        
        Unreviewed.
        
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (MacWK2EWS):

699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740
2013-04-02  Julie Parent  <jparent@chromium.org>

        Dashboard refactor: Move dashboard specific history related features to History.
        https://bugs.webkit.org/show_bug.cgi?id=113717

        Reviewed by Ojan Vafai.
        
        Each dashboard now creates its own History object, with a custom
        configuration. This changes from just overriding global functions
        to passing in callbacks for generatePage, handleValidHashParameter,
        and handleQueryParameterChange. Same with passing in defaultStateValues
        and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
        variables.
        
        All functions related to these features are now (mostly) private
        function on History. 
        
        Loader no longer needs a loadingComplete callback, since it can just
        initialize the history object itself.

        * TestResultServer/static-dashboards/aggregate_results.js:
        (handleValidHashParameter):
        * TestResultServer/static-dashboards/dashboard_base.js:
        * TestResultServer/static-dashboards/flakiness_dashboard.js:
        (generatePage):
        (.switch.return):
        (handleQueryParameterChange):
        * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
        (resetGlobals):
        * TestResultServer/static-dashboards/history.js:
        (.):
        * TestResultServer/static-dashboards/loader.js:
        (.):
        * TestResultServer/static-dashboards/loader_unittests.js:
        * TestResultServer/static-dashboards/timeline_explorer.js:
        (generatePage):
        (initCurrentBuilderTestResults):
        * TestResultServer/static-dashboards/treemap.js:
        (generatePage):
        (.switch.return):
        (handleQueryParameterChange):

741 742 743 744 745 746 747 748 749 750 751 752
2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r147401.
        http://trac.webkit.org/changeset/147401
        https://bugs.webkit.org/show_bug.cgi?id=113767

        The patch makes it extremely hard to set up the dependencies
        properly on the GTK builders (Requested by zdobersek on
        #webkit).

        * gtk/jhbuild.modules:

753 754 755 756 757 758 759 760 761 762 763 764
2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>

        [EFL][WK2] Empty tooltip shown when hovering over popup menu items
        https://bugs.webkit.org/show_bug.cgi?id=113382

        Reviewed by Gyuyoung Kim.

        Do not show the empty tooltip box if the text is null.

        * MiniBrowser/efl/main.c:
        (popup_menu_populate):

765 766 767 768 769 770 771 772 773
2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Bump required versions of some dependencies
        https://bugs.webkit.org/show_bug.cgi?id=113282

        Reviewed by Martin Robinson.

        * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.

774 775 776 777 778 779 780 781 782 783 784 785
2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r147319.
        http://trac.webkit.org/changeset/147319
        https://bugs.webkit.org/show_bug.cgi?id=113707

        The unit test is still failing on the buildbot (Requested by
        zdobersek on #webkit).

        * Scripts/run-gtk-tests:
        (TestRunner):

786 787 788 789 790 791 792 793 794 795 796
2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>

        [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
        https://bugs.webkit.org/show_bug.cgi?id=104779

        Reviewed by Carlos Garcia Campos.

        * Scripts/run-gtk-tests:
        (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
        passing in current trunk.

797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814
2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r147289.
        http://trac.webkit.org/changeset/147289
        https://bugs.webkit.org/show_bug.cgi?id=113678

        broke Win7 (dbg) build (Requested by shinyak|gardener on
        #webkit).

        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
        (WebTestRunner):
        (WebUserMediaClientMock):
        (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
        (WebTestRunner::WebUserMediaClientMock::taskList):
        * Scripts/webkitpy/style/checkers/cpp.py:
        (check_function_definition):

815 816 817 818 819 820 821 822 823 824 825 826 827
2013-03-31  Adam Barth  <abarth@webkit.org>

        configure-svn-config.sh fails
        https://codereview.chromium.org/13392007/

        Reviewed by Eric Seidel.

        This script was trying to use "svn checkout" to dowload a file from
        svn.webkit.org, but "svn checkout" only works with directories.
        Instead, we should use "svn export".

        * EWSTools/configure-svn-config.sh:

828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844
2013-03-31  Wei Jia  <wjia@chromium.org>

        Allow WebUserMediaClientMock to be used by client
        https://bugs.webkit.org/show_bug.cgi?id=113633

        Reviewed by Adam Barth.

        Export WebUserMediaClientMock.
        Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.

        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
        (WebUserMediaClientMock):
        * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
        * Scripts/webkitpy/style/checkers/cpp.py:
        (check_function_definition):

845 846 847 848 849 850 851 852 853 854
2013-03-29  Alexey Proskuryakov  <ap@apple.com>

        Expose FeatureObserver data to WebKit clients
        https://bugs.webkit.org/show_bug.cgi?id=113613

        Reviewed by Sam Weinig.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.

855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887
2013-03-29  Greg Hughes  <ghughes@apple.com>

        Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
        https://bugs.webkit.org/show_bug.cgi?id=112276

        Reviewed by Chris Fleizach.

        Added support to test accessibility search predicates with multiple keys.  

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (uiElementForSearchPredicateCallback):
        * DumpRenderTree/AccessibilityUIElement.h:
        (AccessibilityUIElement):
        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
        (AccessibilityUIElement::uiElementForSearchPredicate):
        * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
        (AccessibilityUIElement::uiElementForSearchPredicate):
        * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
        (AccessibilityUIElement::uiElementForSearchPredicate):
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::uiElementForSearchPredicate):
        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (AccessibilityUIElement::uiElementForSearchPredicate):
        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
        (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
        (AccessibilityUIElement):
        * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
        * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
        (WTR::AccessibilityUIElement::uiElementForSearchPredicate):

888 889 890 891 892 893 894
2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>

        Fix a typo in r147147 to fix Mac EWS.

        * Scripts/webkitpy/tool/commands/queues.py:
        (PatchProcessingQueue._new_port_name_from_old):

895 896 897 898 899 900 901 902 903 904
2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>

        [EFL] Build break with latest EFL libraries after r146265
        https://bugs.webkit.org/show_bug.cgi?id=113558

        Unreviewed build fix.

        * TestWebKitAPI/PlatformWebView.h:
        * WebKitTestRunner/PlatformWebView.h:

905 906 907 908 909 910 911
2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed. Fix build break when running --update-efl in WebKit EFL.

        * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
        in libgcrypt build.

912 913 914 915 916 917 918 919 920
2013-03-28  Lucas Forschler  <lforschler@apple.com>

        Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.

        Unreviewed.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (MacEWS):

921 922 923 924 925 926 927 928 929 930 931
2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>

        Use the right OS name on Mac EWS instead of mac-future.

        Rubber-stamped by Dirk Pranke.

        * Scripts/webkitpy/tool/commands/queues.py:
        (PatchProcessingQueue._new_port_name_from_old):
        (PatchProcessingQueue.begin_work_queue):
        (PatchProcessingQueue._upload_results_archive_for_patch):

932 933 934 935 936 937 938 939 940 941
2013-03-28  Zan Dobersek  <zdobersek@igalia.com>

        [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
        https://bugs.webkit.org/show_bug.cgi?id=112546

        Reviewed by Martin Robinson.

        * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
        moved back to Source/WebCore/platform. Fix an indentation issue as well.

942 943 944 945 946 947 948 949 950 951 952 953 954
2013-03-28  Ming Xie  <mxie@blackberry.com>

        [BlackBerry] Committer Email Updates
        https://bugs.webkit.org/show_bug.cgi?id=113435

        Reviewed by Rob Buis.

        Add the @blackberry.com email address for all our BlackBerry
        WebKit committers. This is the first step for our email address
        migration.

        * Scripts/webkitpy/common/config/committers.py:

955 956 957 958 959 960 961 962 963 964 965 966 967 968
2013-03-28  Philippe Normand  <pnormand@igalia.com>

        [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
        https://bugs.webkit.org/show_bug.cgi?id=113508

        Reviewed by Martin Robinson.

        Prevent the GStreamer plugin scanner to load system-wide
        plugins. Only the ones built in JHBuild should be loaded and used
        at runtime.

        * efl/jhbuildrc:
        * gtk/jhbuildrc:

969 970 971 972 973 974 975 976 977 978 979 980
2013-03-27  Philippe Normand  <pnormand@igalia.com>

        [GTK] run-launcher --gtk -2 fails on a WK2-only build
        https://bugs.webkit.org/show_bug.cgi?id=113386

        Reviewed by Carlos Garcia Campos.

        * Scripts/webkitdirs.pm:
        (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
        version to 3.0. Reflect this change so the builtDylibPathForName
        function doesn't fail to report the library as found.

981 982 983 984 985 986 987 988 989 990 991 992
2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>

        [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
        https://bugs.webkit.org/show_bug.cgi?id=113484

        Unreviewed build fix.

        Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.

        * TestWebKitAPI/CMakeLists.txt:
        * WebKitTestRunner/CMakeLists.txt:

993 994 995 996 997 998 999 1000 1001 1002 1003 1004
2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>

        Revision for the internal jhbuild is too old
        https://bugs.webkit.org/show_bug.cgi?id=113324

        Reviewed by Martin Robinson.

        Update the minimum required version to a point where jhbuild won't
        fail installing packages when trying to remove a symlink to a directory.

        * jhbuild/jhbuild-wrapper: Updated revision.

1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019
2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>

        [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
        https://bugs.webkit.org/show_bug.cgi?id=113203

        Reviewed by Philippe Normand.

        We build our libsoup without GNOME support. gst-plugins-good does separate
        pkg-config checks for libsoup-gnome and libsoup, causing the build to use
        libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
        build failures as the headers of those diverge. We do not use souphttpsrc, so
        disable it when building gst-plugins-good.

        * gtk/jhbuild.modules: disable soup support in gst-plugins-good.

1020 1021 1022 1023 1024 1025
2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix after r146852. Please another reference to the Lion leaks builder.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042
2013-03-27  Zan Dobersek  <zdobersek@igalia.com>

        [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
        https://bugs.webkit.org/show_bug.cgi?id=113421

        Reviewed by Dirk Pranke.

        When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
        This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
        equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
        in the GTK-specific TestExpectations files.

        To avoid this only enable the warnings only when not using WKTR.

        * Scripts/webkitpy/layout_tests/port/gtk.py:
        (GtkPort.warn_if_bug_missing_in_test_expectations):

antti@apple.com's avatar
antti@apple.com committed
1043 1044 1045 1046 1047 1048
2013-03-27  Antti Koivisto  <antti@apple.com>

        Fix Zalan's email.

        * Scripts/webkitpy/common/config/committers.py:

ossy@webkit.org's avatar
ossy@webkit.org committed
1049 1050 1051 1052 1053 1054 1055 1056 1057 1058
2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>

        master.cfg cleanup
        https://bugs.webkit.org/show_bug.cgi?id=113195

        Reviewed by Ryosuke Niwa.

        * BuildSlaveSupport/build.webkit.org-config/config.json:
        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074
2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>

        master.cfg fine-tuning for Qt Mountain Lion Release bot
        https://bugs.webkit.org/show_bug.cgi?id=113191

        Reviewed by Ryosuke Niwa.

        * BuildSlaveSupport/build.webkit.org-config/config.json:
          - Rename the slave due to its location change.
          - Update the platform of the slave.
        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (RunQtAPITests): Enable running WK2 API tests on Qt.
        (RunQtAPITests.start):
        (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
        (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)

1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092
2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>

        [EFL][jhbuild] Evas fails to build when Wayland is present on the system
        https://bugs.webkit.org/show_bug.cgi?id=113403

        Reviewed by Kenneth Rohde Christiansen.

        As of Evas 1.7.5, when Wayland is detected on the system, support for
        both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
        The code, however, seems to depend on a few other flags which must be
        explicitly enabled.

        If those additional GL-related options are passed, we end up
        having issues on the WebKit side, so disable Wayland support for
        now.

        * efl/jhbuild.modules:

1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103
2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r146864.
        http://trac.webkit.org/changeset/146864
        https://bugs.webkit.org/show_bug.cgi?id=113391

        causes crashes on Wk2 EFL release bot (Requested by drott on
        #webkit).

        * Scripts/webkitperl/FeatureList.pm:

1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121
2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>

        [jhbuild] Correctly specify an alternate number of make jobs.
        https://bugs.webkit.org/show_bug.cgi?id=113396

        Reviewed by Philippe Normand.

        So far, we were using the `MAKEFLAGS' environment variable to pass the
        number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
        other hand, prefers to use the `jobs' variable from jhbuildrc for that.

        We now behave more closely to the rest of the WebKit tools by first
        checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
        not set, just letting jhbuild itself figure out how many jobs to use.

        * efl/jhbuildrc:
        * gtk/jhbuildrc:

1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153
2013-03-27  Zeno Albisser  <zeno@webkit.org>

        [Qt] Remove Qt specific WorkQueueItem definitions.
        https://bugs.webkit.org/show_bug.cgi?id=112891

        This patch is preparation work for removing
        WorkQueue related code from TestRunnerQt and
        replacing it with generic TestRunner code.

        Reviewed by Benjamin Poulain.

        * DumpRenderTree/qt/TestRunnerQt.cpp:
        (TestRunnerQt::queueBackNavigation):
        (TestRunnerQt::queueForwardNavigation):
        (TestRunnerQt::queueLoadHTMLString):
        (TestRunnerQt::queueReload):
        (TestRunnerQt::queueLoadingScript):
        (TestRunnerQt::queueNonLoadingScript):
        (TestRunner::queueLoad):
        * DumpRenderTree/qt/TestRunnerQt.h:
        (TestRunnerQt):
        * DumpRenderTree/qt/WorkQueueItemQt.cpp:
        (LoadItem::invoke):
        (LoadHTMLStringItem::invoke):
        (LoadAlternateHTMLStringItem::invoke):
        (ReloadItem::invoke):
        (ScriptItem::invoke):
        (BackForwardItem::invoke):
        * DumpRenderTree/qt/WorkQueueItemQt.h:
        (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
        (LoadAlternateHTMLStringItem):

1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170
2013-03-26  Julie Parent  <jparent@chromium.org>

        Flakiness dashboard: simplify logic around which tests to show.
        https://bugs.webkit.org/show_bug.cgi?id=113250

        Reviewed by Ojan Vafai.
        
        The different filters for showing results are only used for layout
        tests, otherwise, we show everything.
        
        Change the defaults to false (what layout tests used), and only
        look at the values when viewing layout tests.

        * TestResultServer/static-dashboards/flakiness_dashboard.js:
        (htmlForTestsWithExpectationsButNoFailures):
        (shouldHideTest):

1171 1172 1173 1174 1175 1176 1177 1178 1179
2013-03-26  Isaac Levy  <ilevy@google.com>

        Update bots on test-results.appspot
        https://bugs.webkit.org/show_bug.cgi?id=113333

        Reviewed by Ojan Vafai.

        * TestResultServer/static-dashboards/builders.jsonp:

1180 1181 1182 1183 1184 1185 1186
2013-03-26  Zan Dobersek  <zdobersek@igalia.com>

        Unreviewed GTK gardening.

        * Scripts/run-gtk-tests:
        (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.

1187 1188 1189 1190 1191 1192 1193 1194 1195 1196
2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>

        [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=113287

        Reviewed by Jocelyn Turcotte.

        * Scripts/run-qtwebkit-tests:
        (Options.__init__):

1197 1198 1199 1200 1201 1202 1203 1204 1205 1206
2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>

        [EFL] Enable IndexedDB by default
        https://bugs.webkit.org/show_bug.cgi?id=107248

        Reviewed by Laszlo Gombos.

        * Scripts/webkitperl/FeatureList.pm:
        Enable IndexedDB by default on EFL.

1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221
2013-03-26  Alan Cutter  <alancutter@chromium.org>

        Sheriffbot should explain rollout failures in a human readable form.
        https://bugs.webkit.org/show_bug.cgi?id=107092

        Reviewed by Ryosuke Niwa.

        Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).

        * Scripts/webkitpy/tool/bot/irc_command.py:
        (Rollout._check_diff_failure):
        (Rollout.execute):
        * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
        (IRCCommandTest.test_rollout):

1222 1223 1224 1225 1226 1227 1228
2013-03-26  Zan Dobersek  <zdobersek@igalia.com>

        Unreviewed GTK gardening.

        * Scripts/run-gtk-tests:
        (TestRunner): Skipping a failing unit test after r146518.

rniwa@webkit.org's avatar
rniwa@webkit.org committed
1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239
2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>

        Remove Lion leaks builder
        https://bugs.webkit.org/show_bug.cgi?id=113252

        Reviewed by Andreas Kling.

        Removed.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253
2013-03-25  Kent Tamura  <tkent@chromium.org>

        Rename ENABLE_INPUT_TYPE_DATETIME
        https://bugs.webkit.org/show_bug.cgi?id=113254

        Reviewed by Kentaro Hara.

        Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
        Actually I'd like to remove the code, but we shouldn't remove it yet
        because we shipped products with it on some platforms.

        * Scripts/webkitperl/FeatureList.pm:
        * qmake/mkspecs/features/features.pri:

1254 1255 1256 1257 1258 1259 1260
2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>

        Remove one more line that was intended to be removed in r146657.

        * Scripts/webkitpy/layout_tests/models/test_run_results.py:
        (summarize_results):

1261 1262 1263 1264 1265 1266 1267 1268 1269 1270
2013-03-25  Roger Fong  <roger_fong@apple.com>

        No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
        Re-enable WinEWS tests.

        * Scripts/webkitpy/common/config/ports.py:
        (WinPort.run_bindings_tests_command):
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (WinEWS):

1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281
2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r146793.
        http://trac.webkit.org/changeset/146793
        https://bugs.webkit.org/show_bug.cgi?id=113248

        Fix did not work (Requested by rfong on #webkit).

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (WinEWS):

1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336
2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>

        REGRESSION(r146657): Test failures reported incorrectly
        https://bugs.webkit.org/show_bug.cgi?id=113223

        Reviewed by Dirk Pranke.

        The bug was caused by BuildBotPrinter not taking the new behavior into account.

        Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
        treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager.run):

        * Scripts/webkitpy/layout_tests/models/test_run_results.py:
        (RunDetails.__init__):
        (summarize_results): Remove the line I intended to remove in r146657.

        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
        (logging_run): Return details instead of the exit code.
        (run_and_capture): Ditto.

        (RunTest.test_full_results_html):
        (RunTest.test_hung_thread):
        (RunTest.test_no_tests_found):
        (RunTest.test_no_tests_found_2):
        (RunTest.test_repeat_each_iterations_num_tests):
        (RunTest.test_run_singly_actually_runs_tests):
        (RunTest.test_test_list):
        (RunTest.test_missing_and_unexpected_results):
        (RunTest.test_pixel_test_directories):
        (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
        (RunTest.test_crash_with_stderr):
        (RunTest.test_no_image_failure_with_image_diff):
        (RunTest.test_crash_log):
        (RunTest.test_exit_after_n_failures_upload):
        (RunTest.test_results_directory_absolute):
        (RunTest.test_results_directory_relative):
        (RunTest.test_retrying_and_flaky_tests):
        (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
        (RunTest.test_retrying_uses_retries_directory):
        (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
        (RunTest.test_output_diffs):
        (EndToEndTest.test_reftest_with_two_notrefs):
        (RebaselineTest.test_reset_results):
        (RebaselineTest.test_missing_results):
        (RebaselineTest.test_new_baseline):

        * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
        (BuildBotPrinter.print_results):
        (BuildBotPrinter.print_unexpected_results):
        (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
        when we forced pixel tests in retry (i.e. pixel test was initially disabled).

1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417
2013-03-25  Julie Parent  <jparent@chromium.org>

        Dashboard refactor: Move cross dashboard history related code into history.js.
        https://bugs.webkit.org/show_bug.cgi?id=113104

        Reviewed by Ojan Vafai.

        All functions relating to cross dashboard behavior move from being
        globals to methods on the history.History object. Names stay the same,
        except many are made private, ones that should have been constants now
        are, and the long standing TODO to change "currentState" to 
        dashboardSpecificState is done.
        
        We now create a global history object in dashboard_base, as an 
        intermediate measure.  Once the dashboard specific code is
        added to history, each DB will need to create its own, and this
        global will be eliminated.
        
        * TestResultServer/static-dashboards/aggregate_results.js:
        (handleValidHashParameter):
        (htmlForBuilder):
        (rawValuesHTML):
        * TestResultServer/static-dashboards/dashboard_base.js:
        (parseDashboardSpecificParameters):
        (defaultValue):
        (currentBuilderGroupCategory):
        (currentBuilderGroupName):
        (handleLocationChange):
        (expectationsMap):
        * TestResultServer/static-dashboards/flakiness_dashboard.js:
        (generatePage):
        (.switch.return):
        (platformAndBuildType):
        (individualTests):
        (substringList):
        (processMissingAndExtraExpectations):
        (pathToFailureLog):
        (showPopupForBuild):
        (htmlForTestsWithExpectationsButNoFailures):
        (shouldHideTest):
        (isCrossBuilderView):
        (tableHeaders):
        (htmlForSingleTestRow):
        (htmlForTableColumnHeader):
        (generatePageForExpectationsUpdate):
        (handleUpdate):
        (nextUpdate):
        (setUpdateIndex):
        (htmlForIndividualTestOnAllBuildersWithResultsLinks):
        (.appendExpectationsItem):
        (loadExpectations):
        (.dummyNode.onload):
        (loadExpectationsLayoutTests):
        (appendExpectations):
        (htmlForNavBar):
        (checkBoxToToggleState):
        (linkHTMLToToggleState):
        (generatePageForBuilder):
        (isInvalidKeyForCrossBuilderView):
        (handleQueryParameterChange):
        (showLegend):
        * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
        (resetGlobals):
        (test):
        * TestResultServer/static-dashboards/history.js:
        (.):
        * TestResultServer/static-dashboards/history_unittests.js:
        * TestResultServer/static-dashboards/loader.js:
        (.):
        * TestResultServer/static-dashboards/loader_unittests.js:
        * TestResultServer/static-dashboards/timeline_explorer.js:
        (generatePage):
        (initCurrentBuilderTestResults):
        (selectBuild):
        (showResultsDelta):
        * TestResultServer/static-dashboards/treemap.js:
        (generatePage):
        (.switch.return):
        (handleFocus):
        * TestResultServer/static-dashboards/ui.js:

1418 1419 1420 1421 1422 1423 1424
2013-03-25  Roger Fong  <roger_fong@apple.com>

        Unreviewed. Enable WinEWS tests again.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (WinEWS):

1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440
2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>

        [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
        https://bugs.webkit.org/show_bug.cgi?id=112166

        HarfBuzz 0.9.14 merged my patch for icu detection without
        pkg-config files, as needed by for example Ubuntu 12.04.
        This obsoletes our local workaround. Removed it for GTK and EFL.

        Reviewed by Martin Robinson.

        * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
        * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
        * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
        * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.

1441 1442 1443 1444 1445 1446
2013-03-22  Kiran Muppala  <cmuppala@apple.com>

        Unreviewed.  Move self from contributor to committer list.

        * Scripts/webkitpy/common/config/committers.py:

1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475
2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>

        EWS should use a human readable port name when uploading layout test archives
        https://bugs.webkit.org/show_bug.cgi?id=113099

        Reviewed by Dirk Pranke.

        Use new port's object's name() method to report human readable port names.
        This will also help us resolving the bug to apply layout test results posted by EWS.

        * Scripts/webkitpy/tool/bot/botinfo.py:
        (BotInfo.__init__): Take port's name.
        (BotInfo.summary_text):

        * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
        (BotInfoTest.test_summary_text):

        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.

        * Scripts/webkitpy/tool/commands/queues.py:
        (PatchProcessingQueue.__init__): Initialize self._port.
        (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
        and use that for the attachment filename and the comment posted.

        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
        "mac-snowleopard" as expected for TestPort.

1476 1477 1478 1479 1480 1481 1482 1483
2013-03-22  Roger Fong  <roger_fong@apple.com>

        Unreviewed. Turn off EWS test on Win again.
        The battle continues.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (WinEWS):

1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520
2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>

        NRWT: Enable pixel tests when retrying tests
        https://bugs.webkit.org/show_bug.cgi?id=112898

        Reviewed by Dirk Pranke.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
        if we've forced pixel tests in the retry.
        (Manager._run_tests):
        (Manager._clean_up_run): Fixed the capitalizations.
        (Manager._force_pixel_tests_if_needed): Added.

        * Scripts/webkitpy/layout_tests/models/test_run_results.py:
        (_interpret_test_failures): Now that this function maybe called multiple times, only set
        'image_diff_percent' if it doesn't already exist.

        (summarize_results): When the first attempt resulted in a text failure and the second attempt
        resulted in image and text failures and we've forced to run pixel tests in the retry run,
        treat this as a regular regression instead of a flakiness.

        Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
        run had image diffs.

        * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
        (summarized_results):

        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
        (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
        Also removed some dead code.

        (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
        pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
        is set and pixel_tests_enabled is set to false.
        (EndToEndTest.test_reftest_with_two_notrefs):

1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541
2013-03-22  Tim Horton  <timothy_horton@apple.com>

        Make it possible to run layout tests on Retina MBP
        https://bugs.webkit.org/show_bug.cgi?id=93673

        Reviewed by Ryosuke Niwa.

        Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
        windows on 2x machines still run at 1x.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (createWebViewAndOffscreenWindow):
        Reset the window resolution to 1x on creation.
        * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
        * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
        (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
        * WebKitTestRunner/mac/PlatformWebViewMac.mm:
        (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
        (WTR::PlatformWebView::PlatformWebView):
        Add NSWindow details, reset the window resolution to 1x on creation.

rniwa@webkit.org's avatar
rniwa@webkit.org committed
1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556
2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>

        Leak bots shouldn't build
        https://bugs.webkit.org/show_bug.cgi?id=112774

        Reviewed by Simon Fraser.

        Since leak bots use regular debug builds, there is no need to build on these bots.
        Simply downloading builds will dramatically improve the cycle time of these bots.

        * BuildSlaveSupport/build.webkit.org-config/config.json:
        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
        TestFactory instead of BuildAndTestFactory.

1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574
2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>

        [Qt] Fix the TestWebKitAPI build
        https://bugs.webkit.org/show_bug.cgi?id=113044

        Reviewed by Tor Arne Vestbø.

        The generate-forwarding-headers script would only be run
        after the targets in InjectedBundle.pri since the second
        addStrictSubdirOrderBetween call in
        Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
        the derived_sources -> injected_bundle order in SUBDIRS.

        Fix it by only moving the dependent target at the end of
        SUBDIRS, don't touch its dependency.

        * qmake/mkspecs/features/functions.prf:

1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588
2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>

        [EFL][WK2] View is not focused when fullscreen mode toggled
        https://bugs.webkit.org/show_bug.cgi?id=113009

        Reviewed by Laszlo Gombos.

        Set focus on view when fullscreen mode enabled/disabled
        by FullScreen API.

        * MiniBrowser/efl/main.c:
        (on_fullscreen_accept):
        (on_fullscreen_deny):

1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618
2013-03-21  Dirk Pranke  <dpranke@chromium.org>

        nrwt is no longer saving retry results in the retries/ subdirectory
        https://bugs.webkit.org/show_bug.cgi?id=112995

        Reviewed by Ojan Vafai.

        I think this has been broken a long time, unfortunately. This
        patch should fix that.

        In order to do so, I had to pass the directory to use from
        the Worker object through the SingleTestWriter to the
        TestResultWriter. While I was plumbing that through, I rationalized
        the order of the parameter arguments a bit ...

        * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
        (Worker._run_single_test):
        * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
        (run_single_test):
        (SingleTestRunner.__init__):
        (SingleTestRunner._run_compare_test):
        (SingleTestRunner._run_rebaseline):
        (SingleTestRunner._run_reftest):
        * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
        (write_test_result):
        * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
        (TestResultWriterTest.test_reftest_diff_image):
        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
        (RunTest.test_retrying_uses_retries_directory):

1619 1620 1621 1622 1623 1624 1625 1626 1627
2013-03-21  Filip Pizlo  <fpizlo@apple.com>

        JSC profiler should have an at-a-glance report of the success of DFG optimization
        https://bugs.webkit.org/show_bug.cgi?id=112988

        Reviewed by Geoffrey Garen.

        * Scripts/display-profiler-output:

1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644
2013-03-21  Dirk Pranke  <dpranke@chromium.org>

        [chromium] Linux ASAN WebKit canary is running out of memory
        https://bugs.webkit.org/show_bug.cgi?id=112978

        Reviewed by Tony Chang.

        Running the AddressSanitizer on a crash takes a lot of
        memory, so we should serialize access to it to avoid running
        out of memory on a machine.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        (ChromiumPort._get_crash_log):
        * Scripts/webkitpy/layout_tests/port/http_lock.py:
        (HttpLock.__init__):
        (HttpLock.wait_for_httpd_lock):

1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660
2013-03-21  Min Qin  <qinmin@chromium.org>

        Cleanup android media layout test code
        https://bugs.webkit.org/show_bug.cgi?id=112944

        Reviewed by Adam Barth.

        Chromium change: https://codereview.chromium.org/12892010/
        The current android layout tests are using WebmediaPlayerInProcessAndroid class.
        The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
        It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
        Instead, we should switch to use content shell for layout tests.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetTestController):

1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676
2013-03-21  Dirk Pranke  <dpranke@chromium.org>

        [chromium] add missing project dependencies to DRT to fix Mac Valgrind
        https://bugs.webkit.org/show_bug.cgi?id=112953

        Reviewed by Tony Chang.

        When I created the DumpRenderTree_resources target in r144863 I
        forgot to declare the needed dependencies on the other resource
        targets. Due to a quirk of ordering, this appears to have been fine
        w/ ninja but not w/ Xcode (which is still being used on the chromium
        mac valgrind bots). Declaring the dependencies fixes the build
        failures.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687
2013-03-21  Brent Fulgham  <bfulgham@webkit.org>

        [WinCairo] Correct assert in Empty BitmapImage Test.
        https://bugs.webkit.org/show_bug.cgi?id=112934

        Reviewed by Tim Horton.

        * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
        (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
        to avoid ref counting assertion when leaving test scope.

1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701
2013-03-21  Zan Dobersek  <zdobersek@igalia.com>

        [GTK] generate-feature-defines-files is incompatible with Python3
        https://bugs.webkit.org/show_bug.cgi?id=112956

        Reviewed by Martin Robinson.

        Make the generate-feature-defines-files compatible with Python3 by calling the items()
        method on the dictionary objects when iterating through said dictionaries.

        * gtk/generate-feature-defines-files:
        (write_feature_defines_header):
        (write_flattened_feature_defines_file):

1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716
2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>

        kill-old-processes spits out error messages on Mac
        https://bugs.webkit.org/show_bug.cgi?id=112878

        Reviewed by Jessie Berlin.

        Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
        included in the list of options grep --help shows.

        Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.

        * BuildSlaveSupport/kill-old-processes:
        (main):

1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731
2013-03-21  Alberto Garcia  <agarcia@igalia.com>

        [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
        https://bugs.webkit.org/show_bug.cgi?id=112597

        Reviewed by Xan Lopez.

        These were introduced for the Chromium port in r105295. We need
        dummy implementations in order to compile the BlackBerry port.

        * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
        (AccessibilityUIElement::scrollToMakeVisible):
        (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
        (AccessibilityUIElement::scrollToGlobalPoint):

1732 1733 1734 1735 1736 1737 1738
2013-03-21  Roger Fong  <roger_fong@apple.com>

        Re-enable WinEWS tests following r146376.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (WinEWS):

1739 1740 1741 1742 1743 1744
2013-03-21  Zoltan Horvath  <zoltan@webkit.org>

        Unreviewed. Add Bem Jones-Bey to the list of contributors.

        * Scripts/webkitpy/common/config/committers.py:

1745 1746 1747 1748 1749 1750 1751 1752 1753
2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>

        [GTK] Missing atk in install-dependencies script
        https://bugs.webkit.org/show_bug.cgi?id=112272

        Reviewed by Gustavo Noronha Silva.

        * gtk/install-dependencies: Add missing atk dependency.

1754 1755 1756 1757 1758 1759 1760 1761 1762 1763
2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>

        [GTK] Missing backslash in install-dependencies script
        https://bugs.webkit.org/show_bug.cgi?id=112907

        Reviewed by Philippe Normand.

        * gtk/install-dependencies: Add missing backslash to dependencies
        list.

1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799
2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>

        EWS bots have stopped uploading results to bugzilla
        https://bugs.webkit.org/show_bug.cgi?id=101091

        Reviewed by Adam Barth.

        The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
        to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
        this relative file path resoled to a file inside a non-existent directory for "zip".

        Fixed the bug by resolving both test results directory and zip archive paths in
        LayoutTestResultsReader.archive.

        Also made workspace.create_zip print the source_path so that we may debug these issues more easily
        in the future.

        * Scripts/webkitpy/common/system/filesystem_mock.py:
        (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".

        * Scripts/webkitpy/common/system/workspace.py:
        (Workspace.create_zip): Log the source path when "zip" failed.

        * Scripts/webkitpy/common/system/workspace_mock.py:
        (MockWorkspace.create_zip): Record zip_path and source_path for testing.

        * Scripts/webkitpy/common/system/workspace_unittest.py:
        (WorkspaceTest.test_create_zip_exception): Test that.

        * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
        (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
        This is the actual bug fix.

        * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
        (test_archive_last_layout_test_results_with_relative_path): Added a test case.

1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875
2013-03-20  Jochen Eisinger  <jochen@chromium.org>

        [chromium] move WebThemeEngine implementations to TestRunner library
        https://bugs.webkit.org/show_bug.cgi?id=112751

        Reviewed by Adam Barth.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
        (WebKit):
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
        (WebTestRunner::TestInterfaces::themeEngine):
        (WebTestRunner):
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
        (WebKit):
        (TestInterfaces):
        * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
        (WebTestRunner::WebTestInterfaces::themeEngine):
        (WebTestRunner):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
        (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
        (WebTestRunner):
        (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
        (WebTestRunner::WebTestThemeControlWin::box):
        (WebTestRunner::WebTestThemeControlWin::line):
        (WebTestRunner::WebTestThemeControlWin::triangle):
        (WebTestRunner::WebTestThemeControlWin::roundRect):
        (WebTestRunner::WebTestThemeControlWin::oval):
        (WebTestRunner::WebTestThemeControlWin::circle):
        (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
        (WebTestRunner::WebTestThemeControlWin::markState):
        (WebTestRunner::WebTestThemeControlWin::draw):
        (WebTestRunner::WebTestThemeControlWin::drawTextField):
        (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
        (WebTestRunner):
        (WebTestThemeControlWin):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
        (WebTestRunner):
        (WebTestThemeEngineMac):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
        (+[FakeActiveWindow alwaysActiveWindow]):
        (+[FakeActiveWindow alwaysInactiveWindow]):
        (-[FakeActiveWindow initWithActiveControls:]):
        (-[FakeActiveWindow _hasActiveControls]):
        (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
        (WebTestRunner):
        (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
        (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
        (WebTestRunner::WebTestThemeEngineWin::paintButton):
        (WebTestRunner):
        (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
        (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
        (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
        (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
        (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
        (WebTestRunner::WebTestThemeEngineWin::paintTextField):
        (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
        (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
        (WebTestRunner::WebTestThemeEngineWin::getSize):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
        (WebTestRunner):
        (WebTestThemeEngineWin):
        (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::initialize):
        * DumpRenderTree/chromium/TestShell.h:
        (WebKit):
        * DumpRenderTree/chromium/TestShellMac.mm:
        (platformInit):
        * DumpRenderTree/chromium/TestShellWin.cpp:
        (platformInit):
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.

1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887
2013-03-20  Brent Fulgham  <bfulgham@webkit.org>

        [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010

        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
        New property sheet that does not link against CoreFoundation and
        CFNetwork.
        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
        Use new TestWebKitAPICommonWinCairo property sheet.
        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
        Ditto.

1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901
2013-03-20  Brent Fulgham  <bfulgham@webkit.org>

        [WinCairo] Unreviewed build fix for VS2010.

        Had to add WinCairo-specific property sheets to deal with some
        library and path differences with the main Apple port.

        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
        * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
        * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
        * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.

1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912
2013-03-20  Benjamin Poulain  <bpoulain@apple.com>

        [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=112849

        Reviewed by Sam Weinig.

        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        * WebKitTestRunner/InjectedBundle/TestRunner.h:

1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942
2013-03-20  Brent Fulgham  <bfulgham@webkit.org>

        [WinCairo] Build WebKit Tools under VS2010
        https://bugs.webkit.org/show_bug.cgi?id=112821

        Reviewed by Tim Horton.

        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
        Add WinCairo-specific build target.
        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
        * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
        Add WinCairo-specific build target.
        * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
        * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
        Add WinCairo-specific build target.
        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
        WinCairo-specific build target.
        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
        * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
        specific build target.
        * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
        WinCairo-specific build target.
        * win/record-memory/record-memory.vcxproj: Add WinCairo target.
        * win/record-memory/record-memoryDebugWinCairo.props: Added.
        * win/record-memory/record-memoryReleaseWinCairo.props: Added.

1943 1944 1945 1946 1947 1948 1949 1950 1951
2013-03-20  Roger Fong  <roger_fong@apple.com>

        API test gardening AppleWin port.

        The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.

        * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
        * TestWebKitAPI/win/TestWebKitAPI.vcproj:

1952 1953 1954 1955 1956 1957
2013-03-20  Roger Fong  <roger_fong@apple.com>

        Test fix for Win EWS bots, catch various errors and restart script if necessary.

        * EWSTools/start-queue-win.sh:

1958 1959 1960 1961
2013-03-20  Sami Kyostila  <skyostil@chromium.org>

        Unreviewed, add myself to committers.py.

1962 1963 1964 1965 1966 1967
2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Unreviewed. Adding another email for me.

        * Scripts/webkitpy/common/config/committers.py:

1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990
2013-03-20  Justin Novosad  <junov@google.com>

        [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
        https://bugs.webkit.org/show_bug.cgi?id=112605

        Reviewed by James Robinson.

        Deleting all the code that was used for propagating and supporting
        the Chromium setting for disabling deferred 2d canvas rendering.

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (main):
        * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
        * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
        (WebTestRunner::WebPreferences::reset):
        (WebTestRunner::WebPreferences::applyTo):
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        (TestShell::resetWebSettings):
        (TestShell::runFileTest):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell):

1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005
2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>

        [Qt] Qt 4.8 tool related stuff removal from webkitpy.
        https://bugs.webkit.org/show_bug.cgi?id=112699.

        Reviewed by Adam Barth.

        * Scripts/webkitpy/layout_tests/port/qt.py:
        (QtPort._search_paths):
        (QtPort._port_specific_expectations_files):
        * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
        (QtPortTest):
        (QtPortTest._assert_search_path):
        (QtPortTest._assert_expectations_files):

2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020
2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        [Qt] Enable kerning by default
        https://bugs.webkit.org/show_bug.cgi?id=112704

        Reviewed by Jocelyn Turcotte.

        Disable kerning by default, since some reference test expectations
        expect kerning to be default off.

        * DumpRenderTree/qt/TestRunnerQt.cpp:
        (TestRunnerQt::reset):
        * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
        (WTR::activateFonts):

2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037
2013-03-20  Zeno Albisser  <zeno@webkit.org>

        [Qt] Remove empty function stubs from TestRunnerQt.
        https://bugs.webkit.org/show_bug.cgi?id=112799

        We are reducing the code in TestRunnerQt step by step,
        in order to finally replace all of it with the generic
        TestRunner implementation.
        This patch removes several simple function stubs that
        currently do not implement any actual functionality.

        Reviewed by Kenneth Rohde Christiansen.

        * DumpRenderTree/qt/TestRunnerQt.cpp:
        * DumpRenderTree/qt/TestRunnerQt.h:
        (TestRunnerQt):

2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049
2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>

        [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
        https://bugs.webkit.org/show_bug.cgi?id=112687

        Reviewed by Kenneth Rohde Christiansen.

        Hide the SearchBar by default on window creation.

        * MiniBrowser/efl/main.c:
        (window_create):

2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121
2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r146304.
        http://trac.webkit.org/changeset/146304
        https://bugs.webkit.org/show_bug.cgi?id=112788

        to many expectations to update (Requested by antonm on
        #webkit).

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
        (WebKit):
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
        (TestInterfaces):
        * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::initialize):
        * DumpRenderTree/chromium/TestShell.h:
        (WebKit):
        * DumpRenderTree/chromium/TestShellMac.mm:
        (platformInit):
        * DumpRenderTree/chromium/TestShellWin.cpp:
        (platformInit):
        * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
        (WebThemeControlDRTWin::WebThemeControlDRTWin):
        (WebThemeControlDRTWin::~WebThemeControlDRTWin):
        (WebThemeControlDRTWin::box):
        (WebThemeControlDRTWin::line):
        (WebThemeControlDRTWin::triangle):
        (WebThemeControlDRTWin::roundRect):
        (WebThemeControlDRTWin::oval):
        (WebThemeControlDRTWin::circle):
        (WebThemeControlDRTWin::nestedBoxes):
        (WebThemeControlDRTWin::markState):
        (WebThemeControlDRTWin::draw):
        (WebThemeControlDRTWin::drawTextField):
        (WebThemeControlDRTWin::drawProgressBar):
        * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
        (WebThemeControlDRTWin):
        * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
        (WebThemeEngineDRTMac):
        * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
        (+[FakeActiveWindow alwaysActiveWindow]):
        (+[FakeActiveWindow alwaysInactiveWindow]):
        (-[FakeActiveWindow initWithActiveControls:]):
        (-[FakeActiveWindow _hasActiveControls]):
        (WebThemeEngineDRTMac::paintScrollbarThumb):
        (stateToHIEnableState):
        (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
        (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
        (webRectToSkIRect):
        (drawControl):
        (drawTextField):
        (drawProgressBar):
        (WebThemeEngineDRTWin::paintButton):
        (WebThemeEngineDRTWin::paintMenuList):
        (WebThemeEngineDRTWin::paintScrollbarArrow):
        (WebThemeEngineDRTWin::paintScrollbarThumb):
        (WebThemeEngineDRTWin::paintScrollbarTrack):
        (WebThemeEngineDRTWin::paintSpinButton):
        (WebThemeEngineDRTWin::paintTextField):
        (WebThemeEngineDRTWin::paintTrackbar):
        (WebThemeEngineDRTWin::paintProgressBar):
        (WebThemeEngineDRTWin::getSize):
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
        (WebThemeEngineDRTWin):
        (WebThemeEngineDRTWin::WebThemeEngineDRTWin):

2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133
2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        [Qt] Support -webkit-font-smoothing
        https://bugs.webkit.org/show_bug.cgi?id=106009

        Reviewed by Jocelyn Turcotte.

        Set shouldUseFontSmoothing to false to match WebKitTestRunner.

        * DumpRenderTree/qt/TestRunnerQt.cpp:
        (TestRunnerQt::reset):

2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149
2013-03-20  Krzysztof Czech  <k.czech@samsung.com>

        [GTK] accessibility/aria-scrollbar-role.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=98358

        Reviewed by Martin Robinson.

        Adds support for checking accessibility object's orientation.
        Orientation is checked by retrieving proper state of accessibility object.

        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
        (checkElementState):
        (AccessibilityUIElement::orientation):
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        (WTR::AccessibilityUIElement::orientation):

2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225
2013-03-19  Jochen Eisinger  <jochen@chromium.org>

        [chromium] move WebThemeEngine implementations to TestRunner library
        https://bugs.webkit.org/show_bug.cgi?id=112751

        Reviewed by Adam Barth.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
        (WebKit):
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
        (WebTestRunner::TestInterfaces::themeEngine):
        (WebTestRunner):
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
        (WebKit):
        (TestInterfaces):
        * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
        (WebTestRunner::WebTestInterfaces::themeEngine):
        (WebTestRunner):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
        (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
        (WebTestRunner):
        (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
        (WebTestRunner::WebTestThemeControlWin::box):
        (WebTestRunner::WebTestThemeControlWin::line):
        (WebTestRunner::WebTestThemeControlWin::triangle):
        (WebTestRunner::WebTestThemeControlWin::roundRect):
        (WebTestRunner::WebTestThemeControlWin::oval):
        (WebTestRunner::WebTestThemeControlWin::circle):
        (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
        (WebTestRunner::WebTestThemeControlWin::markState):
        (WebTestRunner::WebTestThemeControlWin::draw):
        (WebTestRunner::WebTestThemeControlWin::drawTextField):
        (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
        (WebTestRunner):
        (WebTestThemeControlWin):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
        (WebTestRunner):
        (WebTestThemeEngineMac):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
        (+[FakeActiveWindow alwaysActiveWindow]):
        (+[FakeActiveWindow alwaysInactiveWindow]):
        (-[FakeActiveWindow initWithActiveControls:]):
        (-[FakeActiveWindow _hasActiveControls]):
        (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
        (WebTestRunner):
        (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
        (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
        (WebTestRunner::WebTestThemeEngineWin::paintButton):
        (WebTestRunner):
        (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
        (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
        (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
        (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
        (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
        (WebTestRunner::WebTestThemeEngineWin::paintTextField):
        (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
        (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
        (WebTestRunner::WebTestThemeEngineWin::getSize):
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
        (WebTestRunner):
        (WebTestThemeEngineWin):
        (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::initialize):
        * DumpRenderTree/chromium/TestShell.h:
        (WebKit):
        * DumpRenderTree/chromium/TestShellMac.mm:
        (platformInit):
        * DumpRenderTree/chromium/TestShellWin.cpp:
        (platformInit):
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.

2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240
2013-03-19  Tony Chang  <tony@chromium.org>

        Move testRunner.setTouchDragDropEnabled to internals.settings
        https://bugs.webkit.org/show_bug.cgi?id=112739

        Reviewed by Adam Barth.

        * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
        (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
        * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
        (TestRunner): Remove unnecessary code.
        * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
        (WebTestRunner::WebPreferences::reset):
        (WebTestRunner::WebPreferences::applyTo): Always set to false.

2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254
2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>

        [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
        https://bugs.webkit.org/show_bug.cgi?id=112754

        Reviewed by Darin Fisher.

        Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
        now that it's always defined.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        * DumpRenderTree/chromium/WebViewHost.h:
        (WebViewHost):

2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325
2013-03-19  Kenneth Russell  <kbr@google.com>

        Unreviewed, rolling out r146290.
        http://trac.webkit.org/changeset/146290
        https://bugs.webkit.org/show_bug.cgi?id=112751

        Broke Chromium Mac build.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
        (WebKit):
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
        * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
        (TestInterfaces):
        * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
        * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::initialize):
        * DumpRenderTree/chromium/TestShell.h:
        (WebKit):
        * DumpRenderTree/chromium/TestShellMac.mm:
        (platformInit):
        * DumpRenderTree/chromium/TestShellWin.cpp:
        (platformInit):
        * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
        (WebThemeControlDRTWin::WebThemeControlDRTWin):
        (WebThemeControlDRTWin::~WebThemeControlDRTWin):
        (WebThemeControlDRTWin::box):
        (WebThemeControlDRTWin::line):
        (WebThemeControlDRTWin::triangle):
        (WebThemeControlDRTWin::roundRect):
        (WebThemeControlDRTWin::oval):
        (WebThemeControlDRTWin::circle):
        (WebThemeControlDRTWin::nestedBoxes):
        (WebThemeControlDRTWin::markState):
        (WebThemeControlDRTWin::draw):
        (WebThemeControlDRTWin::drawTextField):
        (WebThemeControlDRTWin::drawProgressBar):
        * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
        (WebThemeControlDRTWin):
        * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
        (WebThemeEngineDRTMac):
        * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
        (+[FakeActiveWindow alwaysActiveWindow]):
        (+[FakeActiveWindow alwaysInactiveWindow]):
        (-[FakeActiveWindow initWithActiveControls:]):
        (-[FakeActiveWindow _hasActiveControls]):
        (WebThemeEngineDRTMac::paintScrollbarThumb):
        (stateToHIEnableState):
        (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
        (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
        (webRectToSkIRect):
        (drawControl):
        (drawTextField):
        (drawProgressBar):
        (WebThemeEngineDRTWin::paintButton):
        (WebThemeEngineDRTWin::paintMenuList):
        (WebThemeEngineDRTWin::paintScrollbarArrow):
        (WebThemeEngineDRTWin::paintScrollbarThumb):
        (WebThemeEngineDRTWin::paintScrollbarTrack):
        (WebThemeEngineDRTWin::paintSpinButton):
        (WebThemeEngineDRTWin::paintTextField):
        (WebThemeEngineDRTWin::paintTrackbar):
        (WebThemeEngineDRTWin::paintProgressBar):
        (WebThemeEngineDRTWin::getSize):
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
        (WebThemeEngineDRTWin):
        (WebThemeEngineDRTWin::WebThemeEngineDRTWin):

2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341
2013-03-19  Krzysztof Czech  <k.czech@samsung.com>

        [EFL] canvas-fallback-content.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=111998

        Reviewed by Chris Fleizach.

        Adds support for getting platform name.

        * DumpRenderTree/TestRunner.cpp:
        (TestRunner::staticValues):
        * DumpRenderTree/TestRunner.h:
        (TestRunner):
        * DumpRenderTree/efl/TestRunnerEfl.cpp:
        (TestRunner::platformName):

2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369