ChangeLog 1.12 MB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
2013-12-01  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r159764.
        http://trac.webkit.org/changeset/159764
        https://bugs.webkit.org/show_bug.cgi?id=125055

        appears to hurt html5-full-render times (Requested by kling on
        #webkit).

        * html/parser/HTMLConstructionSite.cpp:
        (WebCore::HTMLConstructionSite::insertTextNode):
        * html/parser/HTMLConstructionSite.h:

14
15
16
17
18
19
20
21
22
23
2013-12-01  Andreas Kling  <akling@apple.com>

        Make more computed style helpers return PassRef.
        <https://webkit.org/b/125043>

        Reduce branchiness in computed style code by making more of the
        file-local helpers return PassRef instead of PassRefPtr.

        Reviewed by Anders Carlsson.

24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
2013-11-30  Ryuan Choi  <ryuan.choi@samsung.com>

        [EFL] Implement scrollbarThickness for opaque scrollbar
        https://bugs.webkit.org/show_bug.cgi?id=125034

        Reviewed by Gyuyoung Kim.

        Implemented scrollbarThickness to support opaque scrollbar.
        Now, edj can decide whether to support opaque scrollbar by adding scrollbar.thickness.
        In addition, added OVERRIDE/FINAL keyword and removed unnecessary destructor
        in ScrollbarThemeEfl.cpp.

        No new tests, no behavior changes with default theme.

        * platform/efl/RenderThemeEfl.cpp:
        (WebCore::RenderThemeEfl::loadTheme):
        Update thickness of scrollbar when theme was loaded.
        * platform/efl/ScrollbarThemeEfl.cpp:
        * platform/efl/ScrollbarThemeEfl.h:
        (WebCore::ScrollbarThemeEfl::setScrollbarThickness):
        (WebCore::ScrollbarThemeEfl::scrollbarThickness):
        (WebCore::ScrollbarThemeEfl::registerScrollbar):
        (WebCore::ScrollbarThemeEfl::unregisterScrollbar):

48
49
50
51
52
53
54
55
56
57
58
2013-11-29  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>

        Remove Symbian specific code.
        https://bugs.webkit.org/show_bug.cgi?id=124939

        Reviewed by Zoltan Herczeg.

        Symbian is not supported, remove leftover code.

        * plugins/npapi.h:

59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
2013-11-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Rename InlineIterator::m_obj and make it private
        https://bugs.webkit.org/show_bug.cgi?id=124837

        Reviewed by Antti Koivisto.

        InlineIterator has been exported m_obj as public though there is a getter function.
        Besides *object* name isn't ambigious. So, changed it with m_renderer and renderer().
        Additionally, setRenderer() is added as well.

        No new tests, no behavior changes.

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::setObject):
        (WebCore::operator==):
        (WebCore::operator!=):
        (WebCore::InlineBidiResolver::appendRun):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlockFlow::appendRunsForObject):
        (WebCore::constructBidiRunsForLine):
        (WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns):
        (WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
        (WebCore::RenderBlockFlow::matchedEndLine):
        * rendering/line/BreakingContextInlineHeaders.h:
        (WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):
        (WebCore::BreakingContext::BreakingContext):
        (WebCore::BreakingContext::currentObject):
        (WebCore::BreakingContext::initializeForCurrentObject):
        (WebCore::BreakingContext::handleBR):
        (WebCore::BreakingContext::handleOutOfFlowPositioned):
        (WebCore::BreakingContext::handleFloat):
        (WebCore::BreakingContext::handleEmptyInline):
        (WebCore::BreakingContext::handleReplaced):
        (WebCore::iteratorIsBeyondEndOfRenderCombineText):
        (WebCore::ensureCharacterGetsLineBox):
        (WebCore::BreakingContext::handleText):
        (WebCore::BreakingContext::canBreakAtThisPosition):
        (WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
        (WebCore::checkMidpoints):
        (WebCore::BreakingContext::handleEndOfLine):
        * rendering/line/LineBreaker.cpp:
        (WebCore::LineBreaker::skipTrailingWhitespace):
        (WebCore::LineBreaker::skipLeadingWhitespace):
        * rendering/line/LineInlineHeaders.h:
        (WebCore::skipNonBreakingSpace):
        (WebCore::requiresLineBox):

107
108
109
110
111
112
113
114
115
2013-11-28  Antti Koivisto  <antti@apple.com>

        Rename StylePropertySet to StyleProperties
        https://bugs.webkit.org/show_bug.cgi?id=124990
        
        Reviewed by Andreas Kling.

        "Set" does not add useful information here. Use less clunky plural name.

116
117
118
119
120
121
122
123
124
125
126
127
2013-11-28  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>

        Nix Upstream: Adding EditorNix to WebCore
        https://bugs.webkit.org/show_bug.cgi?id=124984

        Reviewed by Csaba Osztrogonác.

        No new tests needed.

        * PlatformNix.cmake:
        * editing/nix/EditorNix.cpp: Added.

128
129
130
131
132
133
134
135
136
137
138
139
140
2013-11-28  Zoltan Horvath  <zoltan@webkit.org>

        [Win] Update vcxproj.filters, since LineInfo.h and LineLayoutState.h have been moved to rendering/line
        https://bugs.webkit.org/show_bug.cgi?id=124959

        Reviewed by Brent Fulgham.

        Update WebCore.vcxproj.filters, since LineInfo.h (r155628) and LineLayoutState.h (158121) have been moved to rendering/line.

        No new tests, no behavior change.

        * WebCore.vcxproj/WebCore.vcxproj.filters:

141
142
143
144
145
146
147
148
149
150
151
152
2013-11-28  Laszlo Vidacs  <lac@inf.u-szeged.hu>

        RenderTableSection Blink merge asserting
        https://bugs.webkit.org/show_bug.cgi?id=124857

        Reviewed by Csaba Osztrogonác.

        Use border spacing at the end of all sections.

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::calcRowLogicalHeight):

153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
2013-11-28  Antti Koivisto  <antti@apple.com>

        Remove feature: CSS variables
        https://bugs.webkit.org/show_bug.cgi?id=114119

        Reviewed by Andreas Kling.
        
        The feature is unmaintained and it is getting in the way of refactoring. Code quality is not up to
        WebKit standards either.

        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.list.am:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSBasicShapes.cpp:
        * css/CSSBasicShapes.h:
        * css/CSSCalculationValue.cpp:
        (WebCore::unitCategory):
        (WebCore::hasDoubleValue):
        (WebCore::CSSCalcPrimitiveValue::toCalcValue):
        (WebCore::CSSCalcPrimitiveValue::computeLengthPx):
        (WebCore::determineCategory):
        (WebCore::CSSCalcBinaryOperation::primitiveType):
        * css/CSSCalculationValue.h:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::ComputedStyleExtractor::propertyValue):
        * css/CSSGrammar.y.in:
        * css/CSSParser.cpp:
        (WebCore::CSSParserContext::CSSParserContext):
        (WebCore::operator==):
        (WebCore::filterProperties):
        (WebCore::CSSParser::createStylePropertySet):
        (WebCore::CSSParser::addProperty):
        (WebCore::CSSParser::validCalculationUnit):
        (WebCore::CSSParser::validUnit):
        (WebCore::CSSParser::createPrimitiveNumericValue):
        (WebCore::CSSParser::parseValidPrimitive):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseReflect):
        (WebCore::CSSParser::detectDashToken):
        (WebCore::CSSParser::realLex):
        * css/CSSParser.h:
        * css/CSSParserMode.h:
        * css/CSSParserValues.cpp:
        (WebCore::CSSParserValue::createCSSValue):
        * css/CSSParserValues.h:
        * css/CSSPrimitiveValue.cpp:
        (WebCore::isValidCSSUnitTypeForDoubleConversion):
        (WebCore::CSSPrimitiveValue::primitiveType):
        (WebCore::CSSPrimitiveValue::cleanup):
        (WebCore::CSSPrimitiveValue::getStringValue):
        (WebCore::CSSPrimitiveValue::customCSSText):
        (WebCore::CSSPrimitiveValue::equals):
        * css/CSSPrimitiveValue.h:
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::convertToLength):
        * css/CSSProperty.cpp:
        * css/CSSProperty.h:
        (WebCore::CSSProperty::CSSProperty):
        * css/CSSReflectValue.cpp:
        * css/CSSReflectValue.h:
        * css/CSSValue.cpp:
        (WebCore::CSSValue::equals):
        (WebCore::CSSValue::cssText):
        (WebCore::CSSValue::destroy):
        * css/CSSValue.h:
        (WebCore::CSSValue::setCssText):
        * css/CSSValueList.cpp:
        * css/CSSValueList.h:
        * css/CSSVariableValue.h: Removed.
        * css/Pair.h:
        * css/Rect.h:
        * css/StylePropertySet.cpp:
        (WebCore::StylePropertySet::asText):
        (WebCore::StylePropertySet::PropertyReference::cssName):
        * css/StyleResolver.cpp:
        (WebCore::StyleResolver::styleForPage):
        (WebCore::StyleResolver::applyProperties):
        (WebCore::StyleResolver::applyMatchedProperties):
        (WebCore::StyleResolver::applyProperty):
        * css/StyleResolver.h:
        * css/WebKitCSSTransformValue.cpp:
        * css/WebKitCSSTransformValue.h:
        (WebCore::WebKitCSSTransformValue::equals):
        * css/makeprop.pl:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
        * rendering/style/RenderStyle.h:
        * rendering/style/StyleRareInheritedData.cpp:
        (WebCore::StyleRareInheritedData::StyleRareInheritedData):
        (WebCore::StyleRareInheritedData::operator==):
        * rendering/style/StyleRareInheritedData.h:
        * rendering/style/StyleVariableData.h: Removed.
        * testing/InternalSettings.cpp:
        (WebCore::InternalSettings::Backup::Backup):
        (WebCore::InternalSettings::Backup::restoreTo):
        * testing/InternalSettings.h:
        * testing/InternalSettings.idl:

252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
2013-11-28  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>

        Updating RTCPeerConnectionHandlerMock after r159769
        https://bugs.webkit.org/show_bug.cgi?id=124947

        Reviewed by Philippe Normand.

        Adding its create function back, in order to run RTCPeerConnection LayoutTests.

        No new tests needed.

        * platform/mock/RTCPeerConnectionHandlerMock.cpp:
        (WebCore::RTCPeerConnectionHandlerMock::create):
        * platform/mock/RTCPeerConnectionHandlerMock.h:

267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
2013-11-27  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>

        [GTK] Support custom types for drag and drop data
        https://bugs.webkit.org/show_bug.cgi?id=124659

        Reviewed by Martin Robinson.

        Covered by fast/events/drag-customData.html.

        * platform/gtk/DataObjectGtk.cpp:
        (WebCore::DataObjectGtk::unknownTypes): returns a hash map with all custom types set.
        (WebCore::DataObjectGtk::clearAllExceptFilenames): clear custom types.
        * platform/gtk/DataObjectGtk.h:
        (WebCore::DataObjectGtk::hasUnknownTypeData): returns whether custom types are set.
        (WebCore::DataObjectGtk::unknownTypeData): returns the data for a custom type.
        (WebCore::DataObjectGtk::setUnknownTypeData): sets the data for a custom type.
        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::writeString): handle unknown types as custom.
        (WebCore::Pasteboard::writePasteboard): ditto.
        (WebCore::Pasteboard::hasData): also check for custom types.
        (WebCore::Pasteboard::types): also obtain the list of custom types.
        (WebCore::Pasteboard::readString): handle unknown types as custom.
        * platform/gtk/PasteboardHelper.cpp:
        (WebCore::initGdkAtoms): new unknown atom.
        (WebCore::PasteboardHelper::PasteboardHelper): add custom type to the list of targets.
        (WebCore::PasteboardHelper::fillSelectionData): turns any custom types' data into a GVariant, which
        is in turn serialized to a single string for GtkSelectionData to hold.
        (WebCore::PasteboardHelper::targetListForDataObject): add custom data to the target list if any is
        set.
        (WebCore::PasteboardHelper::fillDataObjectFromDropData): retrieve the custom types and their data
        from the serialized GVariant string held by GtkSelectionData.
        (WebCore::PasteboardHelper::dropAtomsForContext): handle custom types.

300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
2013-11-27  Eric Carlson  <eric.carlson@apple.com>

        Allow the QuickTime plug-in to be replaced by script in an isolated word
        https://bugs.webkit.org/show_bug.cgi?id=124900

        Reviewed by Dean Jackson.

        Test: plugins/quicktime-plugin-replacement.html

        * CMakeLists.txt: Add new Modules path.
        * DerivedSources.make: Add new files.
        * GNUmakefile.am: Add new Modules path.
        * GNUmakefile.list.am: Add new header.
        * WebCore.vcxproj/WebCore.vcxproj: Add new header.
        * WebCore.vcxproj/WebCoreCommon.props: Add new Modules path.
        * WebCore.xcodeproj/project.pbxproj: Add new files.

        * Modules/plugins: Added.
        * Modules/plugins/PluginReplacement.h: Added. Defines the interface for a plug-in replacement.

        Create a replacement for the QuickTime plug-in.
        * Modules/plugins/QuickTimePluginReplacement.cpp: Added.
        * Modules/plugins/QuickTimePluginReplacement.css: Added.
        * Modules/plugins/QuickTimePluginReplacement.h: Added.
        * Modules/plugins/QuickTimePluginReplacement.idl: Added.
        * Modules/plugins/QuickTimePluginReplacement.js: Added.

        Allow plug-in replacement to be enabled at runtime.
        * bindings/generic/RuntimeEnabledFeatures.h:
        (WebCore::RuntimeEnabledFeatures::setPluginReplacementEnabled):
        (WebCore::RuntimeEnabledFeatures::pluginReplacementEnabled):

        * bindings/js/JSDOMBinding.h:
        (WebCore::toJS): Add toJS(... const String& ...).

        * bindings/js/JSPluginElementFunctions.cpp:
        (WebCore::pluginScriptObject): Give a plug-in replacement a first shot at defining the
            script interface.

        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::updateWidget): Call base class requestObject.

        * html/HTMLMediaElement.cpp:
        (HTMLMediaElement::fileSize): New, passthrough to media engine.
        * html/HTMLMediaElement.h:

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::updateWidget): Call base class requestObject.

        Moved some logic that was previously used only for creating a plug-in snapshot to the base
        class so it can be shared by a plug-in replacement.
        * html/HTMLPlugInElement.cpp:
        (WebCore::HTMLPlugInElement::HTMLPlugInElement): Initialize timer used to swap renderers.
        (WebCore::HTMLPlugInElement::createRenderer): Allow plug-in replacement to create the renderer.
        (WebCore::HTMLPlugInElement::swapRendererTimerFired): Create a shadow root.
        (WebCore::HTMLPlugInElement::setDisplayState): Set the new state, prime the swap renderer 
            timer if necessary.
        (WebCore::HTMLPlugInElement::didAddUserAgentShadowRoot): Tell the plug-in replacement to
            install itself in the new shadow DOM.
        (WebCore::registeredPluginReplacements): Return vector of all registered plug-in replacements.
        (WebCore::registerPluginReplacement): Add a plug-in replacement.
        (WebCore::pluginReplacementForType): Find a plug-in replacement for a MIME type.
        (WebCore::HTMLPlugInElement::requestObject): If there is a plug-in replacement for the MIME type,
            create it and set the display state.
        (WebCore::HTMLPlugInElement::scriptObjectForPluginReplacement): Return the script object for 
            the current plug-in replacement, if any.
        * html/HTMLPlugInElement.h:

        Move some plug-in snapshot code into the base class.
        * html/HTMLPlugInImageElement.cpp:
        (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): No need to initialize timer.
        (WebCore::HTMLPlugInImageElement::setDisplayState): Call base class.
        (WebCore::HTMLPlugInImageElement::createRenderer): Ditto.
        (WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Ditto.
        (WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Remove unnecessary class name.
        (WebCore::HTMLPlugInImageElement::requestObject): New.
        * html/HTMLPlugInImageElement.h:

        * html/HTMLVideoElement.h: Make createRenderer public so the QuickTime plug-in replacement can
            call it.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::fileSize): New.
        * platform/graphics/MediaPlayer.h:
        * platform/graphics/MediaPlayerPrivate.h:

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
        (WebCore::MediaPlayerPrivateAVFoundation::extraMemoryCost): totalBytes returns an unsigned long long.
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
        (WebCore::MediaPlayerPrivateAVFoundation::fileSize):

        * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
        (WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes): Return an unsigned long long.
        * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:

        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::totalBytes): Ditto.

        * testing/InternalSettings.cpp:
        (WebCore::InternalSettings::Backup::Backup): Backup the plug-in replacement runtime setting.
        (WebCore::InternalSettings::Backup::restoreTo): Restore it.
        (WebCore::InternalSettings::setPluginReplacementEnabled): Set it.
        * testing/InternalSettings.h:
        * testing/InternalSettings.idl:

406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
2013-11-27  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>

        Adding MediaConstraintsMock class
        https://bugs.webkit.org/show_bug.cgi?id=124902

        Reviewed by Eric Carlson.

        Validate constraints used in RTCPeerConnection LayoutTests

        Existing test was updated.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * platform/mock/MediaConstraintsMock.cpp: Added.
        * platform/mock/MediaConstraintsMock.h: Added.
        * platform/mock/MockMediaStreamCenter.cpp:
        (WebCore::MockMediaStreamCenter::validateRequestConstraints): Now using MediaConstraintsMock
        (WebCore::MockMediaStreamCenter::createMediaStream): Ditto.
        * platform/mock/RTCPeerConnectionHandlerMock.cpp:
        (WebCore::RTCPeerConnectionHandlerMock::initialize): Ditto.

427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
2013-11-27  Bear Travis  <betravis@adobe.com>

        [CSS Shapes] Shape-Inside Should Default to 'auto'
        https://bugs.webkit.org/show_bug.cgi?id=124851

        Reviewed by Alexandru Chiculita.

        The current shape-inside specification has the property default to the 'auto'
        value, not 'outside-shape'.

        Updated tests are under fast/shapes.

        * rendering/style/RenderStyle.cpp:
        * rendering/style/RenderStyle.h:

442
443
444
445
446
447
448
449
450
451
452
453
454
455
2013-11-27  Hans Muller  <hmuller@adobe.com>

        [CSS Shapes] shape-inside rectangle layout can fail
        https://bugs.webkit.org/show_bug.cgi?id=124784

        Reviewed by Andreas Kling.

        Apply LayoutUnit::fromFloatCeil() consistently in RectangleShape::firstIncludedIntervalLogicalTop().

        Test: fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html

        * rendering/shapes/RectangleShape.cpp:
        (WebCore::RectangleShape::firstIncludedIntervalLogicalTop):

456
457
458
459
460
461
462
463
464
465
466
2013-11-27  Nick Diego Yamane  <nick.yamane@openbossa.org>

        Remove Qt-specific .qrc files
        https://bugs.webkit.org/show_bug.cgi?id=124944

        Reviewed by Andreas Kling.

        No new tests needed.

        * WebCore.qrc: Removed.

467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
2013-11-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>

        [GStreamer] Invalid command line error when visiting www.chessbase.com
        https://bugs.webkit.org/show_bug.cgi?id=124715

        Reviewed by Philippe Normand.

        We were not handling the HTTP errors in the WebKit GStreamer
        source and therefore the 404 error page was being 'decoded'. As no
        decoder could be found (for obvious reasons), playback failed, but
        it should be failing for the source not being found instead of the
        decoding problem.

        Test: http/tests/media/video-error-does-not-exist.html

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (StreamingClient::handleResponseReceived): Handle HTTP errors in
        the source and raise a GStreamer error to the pipeline.

486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
2013-11-14  Sergio Villar Senin  <svillar@igalia.com>

        [CSS Grid Layout] Fix positioning of grid items with margins
        https://bugs.webkit.org/show_bug.cgi?id=124345

        Reviewed by David Hyatt.

        From Blink r157925 and r158041 by <jchaffraix@chromium.org>

        Test: fast/css-grid-layout/grid-item-margin-resolution.html

        Adds margin start/before to the positions of grid items (removing
        several FIXME's in the current code). This means calling
        findChildLogicalPosition() after the layout in order to have the
        right values for the margins.

        In order to match flexbox and author's intents we're also
        including the margins of grid items in the intrinsic size of the
        grid. That's why flexbox's marginLogicalPositionForChild() is
        moved up to RenderBlock in order to share it with RenderGrid.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::marginIntrinsicLogicalWidthForChild): Moved
        from RenderFlexibleBox::marginLogicalWidthForChild().
        * rendering/RenderBlock.h:
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
        * rendering/RenderGrid.cpp:
        (WebCore::RenderGrid::computePreferredTrackWidth):
        (WebCore::RenderGrid::layoutGridItems):
        (WebCore::RenderGrid::findChildLogicalPosition):

518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
2013-11-26  Sergio Villar Senin  <svillar@igalia.com>

        [CSS Grid Layout] Support grid-definition-{rows|columns} repeat() syntax
        https://bugs.webkit.org/show_bug.cgi?id=103312

        Reviewed by Andreas Kling.

        Added support for the repeat() syntax inside
        grid-definition-{rows|columns} by just adding the repeated values
        to our list of column|row definitions.

        The parsing of <track-name> was refactored in a new function as
        it's used now in three different places. The <track-size> parsing
        was also refactored to share it with the repeat() parsing.

        Test: fast/css-grid-layout/grid-element-repeat-get-set.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseGridTrackNames):
        (WebCore::CSSParser::parseGridTrackList):
        (WebCore::CSSParser::parseGridTrackRepeatFunction):
        (WebCore::CSSParser::parseGridTrackSize):
        * css/CSSParser.h:

543
544
545
546
547
548
549
550
551
552
553
554
2013-11-26  Marcelo Lira  <marcelo.lira@openbossa.org>

        Nix upstreaming - Adding build files and supporting scripts
        https://bugs.webkit.org/show_bug.cgi?id=118367

        Reviewed by Ryosuke Niwa.

        No new tests needed.

        * CMakeLists.txt:
        * PlatformNix.cmake: Added.

555
556
557
558
559
560
561
562
563
564
565
566
567
2013-11-26  Tim Horton  <timothy_horton@apple.com>

        Don't parent the TileController root layer in two places
        https://bugs.webkit.org/show_bug.cgi?id=124873

        Reviewed by Brent Fulgham.

        * platform/graphics/ca/mac/TileController.mm:
        (WebCore::TileController::TileController):
        The TileController's layer is already parented by callers of
        TileController::create, and in a special way. TileController
        shouldn't parent itself, anyway...

568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
2013-11-26  Nick Diego Yamane  <nick.yamane@openbossa.org>

        [MediaStream API] HTMLMediaElement should be able to use MediaStream as source
        https://bugs.webkit.org/show_bug.cgi?id=121943

        Reviewed by Eric Carlson.

        Implement MediaStream direct assignment to Media Elements using the new 'srcObject'
        attribute: http://www.w3.org/TR/mediacapture-streams/#direct-assignment-to-media-elements

        Test: fast/mediastream/MediaStream-MediaElement-srcObject.html

        * CMakeLists.txt: Added new HTMLMediaElementMediaStream.h and .cpp to cmake build.
        * DerivedSources.make: Added HTMLMediaElementMediaStream.idl.
        * GNUmakefile.list.am: Added new HTMLMediaElementMediaStream* to autotools build.
        * WebCore.xcodeproj/project.pbxproj: Added new files.
        * Modules/mediastream/HTMLMediaElementMediaStream.cpp: Added.
        (WebCore::HTMLMediaElementMediaStream::srcObject): implements srcObject getter.
        (WebCore::HTMLMediaElementMediaStream::setSrcObject): implements srcObject setter.
        * Modules/mediastream/HTMLMediaElementMediaStream.h: Added.
        * Modules/mediastream/HTMLMediaElementMediaStream.idl: Added.
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setSrcObject): This is an initial implementation, and
        is still incomplete, that will be addressed in a separate bug: https://webkit.org/b/124896
        * html/HTMLMediaElement.h: Added m_mediaStreamSrcObject class variable
        and its corresponding getter.

595
596
597
598
599
600
601
602
603
604
2013-11-26  Andreas Kling  <akling@apple.com>

        Use child iterator to find operators in RenderMathMLRow::layout().
        <https://webkit.org/b/124108>

        Replace manual children walk with childrenOfType<RenderMathMLBlock>.
        Minor update to fix build.

        Reviewed by Martin Robinson.

605
606
607
608
609
610
611
612
613
614
2013-11-26  Andreas Kling  <akling@apple.com>

        RenderObject: Inline isBody() and isHR().
        <https://webkit.org/b/124901>

        Together these account for ~0.3% of samples on HTML5-8266.
        Almost all of it is call overhead.

        Reviewed by Anders Carlsson.

615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
2013-11-26  Bear Travis  <betravis@adobe.com>

        [CSS Shapes] Layout using [<box> || <shape>] value
        https://bugs.webkit.org/show_bug.cgi?id=124428

        Reviewed by David Hyatt.

        When a box value is supplied, use it to size and position the shape. Otherwise,
        use a default value (content-box for shape-inside, margin-box for shape-outside).
        This patch extends the sizing and positioning code used for the box patch (Bug 124227)
        to also apply to shapes. With this patch, we also no longer use the box-sizing
        property to size and position shapes.

        Tests: fast/shapes/shape-outside-floats/shape-outside-shape-boxes-001.html
               fast/shapes/shape-outside-floats/shape-outside-shape-boxes-002.html
               fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::ComputedStyleExtractor::propertyValue): Adjust for ShapeValues storing
        BasicShape::ReferenceBox as their box value, rather than a CSSValueID.
        * css/DeprecatedStyleBuilder.cpp:
        (WebCore::ApplyPropertyShape::applyValue): Ditto.
        * rendering/shapes/ShapeInfo.h:
        (WebCore::ShapeInfo::setShapeSize): Adjust for BasicShapes with reference boxes
        as well as plain box values. Also, remove old box-sizing code.
        (WebCore::ShapeInfo::logicalTopOffset): Ditto.
        (WebCore::ShapeInfo::logicalLeftOffset): Ditto.
        * rendering/shapes/ShapeInsideInfo.h:
        * rendering/shapes/ShapeOutsideInfo.h:
        * rendering/style/ShapeValue.h:
        (WebCore::ShapeValue::createBoxValue): Adjust for boxes being stored as
        BasicShape::ReferenceBoxes.
        (WebCore::ShapeValue::box): Ditto.
        (WebCore::ShapeValue::ShapeValue): Ditto.

650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
2013-11-26  Brian J. Burg  <burg@cs.washington.edu>

        ImageBuffer::create should return a std::unique_ptr instead of OwnPtr.
        https://bugs.webkit.org/show_bug.cgi?id=124822

        Reviewed by Andreas Kling.

        Replace all uses of OwnPtr<ImageBuffer> and PassOwnPtr<ImageBuffer> with
        std::unique_ptr<ImageBuffer>. Replace calls to OwnPtr::clear() and
        OwnPtr::release() with reset() and std::move(). Remove unnecessary includes.

        No new tests. This is a mechanical refactoring.

        * css/CSSFilterImageValue.cpp:
        (WebCore::CSSFilterImageValue::image):
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::setSurfaceSize):
        * html/HTMLCanvasElement.h:
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::createCompositingBuffer):
        (WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
        (WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):
        (WebCore::CanvasRenderingContext2D::drawTextInternal):
        * html/canvas/CanvasRenderingContext2D.h:
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache):
        (WebCore::WebGLRenderingContext::LRUImageBufferCache::imageBuffer):
        * html/canvas/WebGLRenderingContext.h:
        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
        * page/Frame.cpp:
        (WebCore::Frame::nodeImage):
        (WebCore::Frame::dragImageForSelection):
        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::drawPattern):
        * platform/graphics/CrossfadeGeneratedImage.cpp:
        (WebCore::CrossfadeGeneratedImage::drawPattern):
        * platform/graphics/GradientImage.h:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::createCompatibleBuffer):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/ImageBuffer.cpp:
        (WebCore::ImageBuffer::createCompatibleBuffer):
        * platform/graphics/ImageBuffer.h:
        (WebCore::ImageBuffer::create):
        * platform/graphics/ShadowBlur.cpp:
        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::putByteArray):
        * platform/graphics/cg/PDFDocumentImage.h:
        * platform/graphics/filters/FETile.cpp:
        (WebCore::FETile::platformApplySoftware):
        * platform/graphics/filters/Filter.h:
        (WebCore::Filter::setSourceImage):
        * platform/graphics/filters/FilterEffect.cpp:
        (WebCore::FilterEffect::clearResult):
        * platform/graphics/filters/FilterEffect.h:
        * platform/graphics/texmap/TextureMapper.cpp:
        (WebCore::BitmapTexture::updateContents):
        * platform/graphics/texmap/TextureMapperImageBuffer.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintDecoration):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintProgressBar):
        * rendering/shapes/Shape.cpp:
        (WebCore::Shape::createShape):
        * rendering/svg/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::invalidateBufferedForeground):
        * rendering/svg/RenderSVGImage.h:
        * rendering/svg/RenderSVGResourceClipper.cpp:
        (WebCore::RenderSVGResourceClipper::applyClippingToContext):
        * rendering/svg/RenderSVGResourceClipper.h:
        * rendering/svg/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::applyResource):
        (WebCore::RenderSVGResourceFilter::postApplyResource):
        * rendering/svg/RenderSVGResourceFilter.h:
        * rendering/svg/RenderSVGResourceGradient.cpp: Remove method parameter wrapping/indentation.
        (WebCore::createMaskAndSwapContextForTextGradient):
        (WebCore::clipToTextMask):
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/svg/RenderSVGResourceGradient.h:
        * rendering/svg/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::applyResource):
        * rendering/svg/RenderSVGResourceMasker.h:
        * rendering/svg/RenderSVGResourcePattern.cpp: Remove method parameter wrapping/indentation.
        (WebCore::RenderSVGResourcePattern::buildPattern):
        (WebCore::RenderSVGResourcePattern::createTileImage):
        * rendering/svg/RenderSVGResourcePattern.h: Remove method parameter wrapping/indentation.
        * rendering/svg/SVGRenderingContext.cpp:
        (WebCore::SVGRenderingContext::createImageBuffer):
        (WebCore::SVGRenderingContext::createImageBufferForPattern):
        (WebCore::SVGRenderingContext::clipToImageBuffer):
        (WebCore::SVGRenderingContext::bufferForeground):
        * rendering/svg/SVGRenderingContext.h:
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::nativeImageForCurrentFrame):
        (WebCore::SVGImage::drawPatternForContainer):

749
750
751
752
753
754
755
756
757
758
759
760
761
2013-11-26  Eric Carlson  <eric.carlson@apple.com>

        video.currentSrc should return empty when no resource is loaded
        https://bugs.webkit.org/show_bug.cgi?id=124898

        Reviewed by Dan Bernstein.

        Test: media/video-currentsrc-cleared.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::prepareForLoad): Set m_currentSrc to empty in 
            preparation for attempting to load a new url.

762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
2013-11-26  Hans Muller  <hmuller@adobe.com>

        [CSS Shapes] Support for shape-margin in BoxShape
        https://bugs.webkit.org/show_bug.cgi?id=124788

        Reviewed by Andreas Kling.

        Corrected BoxShape's internal shape-margin/padding bounds FloatRoundedRect
        initialization. Tests for the padding bounds will be added when the rest of
        shape-padding for box shapes implementation is ready.

        Tests: fast/shapes/shape-outside-floats/shape-outside-margin-boxes-001.html
               fast/shapes/shape-outside-floats/shape-outside-margin-boxes-002.html

        * rendering/shapes/BoxShape.cpp: Use constructor shape-margin,shape-padding parameters.
        (WebCore::BoxShape::BoxShape):
        * rendering/shapes/BoxShape.h:
        * rendering/shapes/Shape.cpp:
        (WebCore::createBoxShape): Pass the shape-margin and shape-padding values along to the BoxShape constructor.
        (WebCore::Shape::createShape): Ditto.

783
784
785
786
787
788
789
790
791
792
793
794
2013-11-26  Nick Diego Yamane  <nick.yamane@openbossa.org>

        Remove unnecessary webaudio include from MediaStreamSource header
        https://bugs.webkit.org/show_bug.cgi?id=124897

        Reviewed by Eric Carlson.

        AudioDestinationConsumer.h is included but not used anywhere in
        MediaStreamSource implementation.

        * platform/mediastream/MediaStreamSource.h:

795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
2013-11-26  Andreas Kling  <akling@apple.com>

        Avoid unnecessary copy-on-write in FillLayer style application.
        <https://webkit.org/b/124878>

        We ended up with a lot of cloned StyleBackgroundData objects on
        HTML5-8266. This happened because we always forced a copy-on-write
        when applying background-image:inherit / background-image:initial.

        This patch adds early returns to both functions. In the "inherit"
        case, we bail early if the target style already has the same fill
        layer data as its parent style.

        In the "initial" case, we optimize for the single-FillLayer case
        and add an early return if the relevant value is either unset or
        equal to the templatized initial value.

        2.46 MB progression on HTML5-8266 locally.

        Reviewed by Antti Koivisto.

816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
2013-11-26  Antoine Quint  <graouts@apple.com>

        Web Inspector: Allow showing a context menu on all mouse events.
        https://bugs.webkit.org/show_bug.cgi?id=124747

        Reviewed by Joseph Pecoraro.

        Add a new InspectorFrontendHost::dispatchEventAsContextMenuEvent(Event*) method
        to let the inspector front-end dispatch a native contextmenu event that will allow
        for a context menu to be shown from within a non-contextmenu event handler.

        * inspector/InspectorFrontendHost.cpp:
        (WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent):
        Check that we're dealing with a mouse event, get the frame for the event target
        and the event's location to call ContextMenuController::showContextMenuAt()
        which will handle the new contextmenu event dispatch to the original event target.

        * inspector/InspectorFrontendHost.h:
        * inspector/InspectorFrontendHost.idl:

836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
2013-11-25  Sam Weinig  <sam@webkit.org>

        Convert some Shape code to use references
        https://bugs.webkit.org/show_bug.cgi?id=124876

        Reviewed by Andreas Kling.

        * inspector/InspectorOverlay.cpp:
        * rendering/FloatingObjects.cpp:
        * rendering/LayoutState.cpp:
        * rendering/RenderBlock.cpp:
        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        * rendering/RenderBox.cpp:
        * rendering/RenderBox.h:
        * rendering/line/BreakingContextInlineHeaders.h:
        * rendering/line/LineWidth.cpp:
        * rendering/shapes/ShapeInfo.cpp:
        * rendering/shapes/ShapeInfo.h:
        * rendering/shapes/ShapeInsideInfo.cpp:
        * rendering/shapes/ShapeInsideInfo.h:
        * rendering/shapes/ShapeOutsideInfo.cpp:
        * rendering/shapes/ShapeOutsideInfo.h:
        Replace yet more pointers with references.

861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
2013-11-25  Simon Pena  <simon.pena@samsung.com>

        [EFL] X11Helper::createPixmap doesn't initialise out value handleId
        https://bugs.webkit.org/show_bug.cgi?id=124722

        Reviewed by Gyuyoung Kim.

        The overloaded functions X11Helper::createPixmap don't initialise out
        value handleId, and they do early returns on error situations. Since
        the functions are void and they don't communicate their failure in any
        way, returning an out value without initialising it could make the
        error go farther unnoticed. With the variable being initialised, it can
        be reliably checked for errors when the function returns.

        * platform/graphics/surfaces/glx/X11Helper.cpp:
        (WebCore::X11Helper::createPixmap): Initialise handleId to 0.

878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
2013-11-25  Nick Diego Yamane  <nick.yamane@openbossa.org>

        Mark URLRegistry's lookup() as const and its child classes as final
        https://bugs.webkit.org/show_bug.cgi?id=124865

        Reviewed by Eric Carlson.

        No new tests needed. No behavior changes.

        * Modules/mediasource/MediaSourceRegistry.cpp:
        (WebCore::MediaSourceRegistry::lookup): marked as const.
        * Modules/mediasource/MediaSourceRegistry.h: MediaSourceRegistry
        marked as final.
        * Modules/mediastream/MediaStreamRegistry.cpp:
        (WebCore::MediaStreamRegistry::lookup): marked as const.
        * Modules/mediastream/MediaStreamRegistry.h: MediaStreamRegistry
        marked as final.
        * fileapi/Blob.cpp:
        * html/URLRegistry.h: lookup() marked as const.
        (WebCore::URLRegistry::lookup): marked as const.

899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
2013-11-25  Sergio Correia  <sergio.correia@openbossa.org>

        [MediaStream] Use std::unique_ptr instead of OwnPtr/PassOwnPtr
        https://bugs.webkit.org/show_bug.cgi?id=124858

        Reviewed by Eric Carlson.

        Another step of the OwnPtr/PassOwnPtr => std::unique_ptr conversion,
        now targeting mediastream-related code.

        No new tests, covered by existing ones.

        * Modules/mediastream/RTCDTMFSender.cpp:
        * Modules/mediastream/RTCDTMFSender.h:
        * Modules/mediastream/RTCDataChannel.cpp:
        * Modules/mediastream/RTCDataChannel.h:
        * Modules/mediastream/RTCPeerConnection.cpp:
        * Modules/mediastream/RTCPeerConnection.h:
        * platform/mediastream/MediaStreamSource.cpp:
        * platform/mediastream/RTCPeerConnectionHandler.cpp:
        * platform/mediastream/RTCPeerConnectionHandler.h:
        * platform/mediastream/RTCPeerConnectionHandlerClient.h:
        * platform/mock/RTCNotifiersMock.cpp:
        * platform/mock/RTCPeerConnectionHandlerMock.cpp:
        * platform/mock/RTCPeerConnectionHandlerMock.h:

925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
2013-11-25  Nick Diego Yamane  <nick.yamane@openbossa.org>

        MediaStreamRegistry should store MediaStreams instead of MediaStreamPrivates
        https://bugs.webkit.org/show_bug.cgi?id=124860

        Reviewed by Eric Carlson.

        MediaStreamRegistry::lookup() should return a MediaStream instead of MediaStreamPrivate.

        No new tests needed. No behavior changes.

        * Modules/mediastream/MediaStreamRegistry.cpp:
        (WebCore::MediaStreamRegistry::registerURL): m_privateStreams -> m_mediaStreams
        (WebCore::MediaStreamRegistry::unregisterURL): Ditto.
        (WebCore::MediaStreamRegistry::lookup): Override URLRegistry::lookup() instead of add a
        new method MediaStream::lookupMediaStreamPrivate().
        * Modules/mediastream/MediaStreamRegistry.h:
        * html/HTMLMediaElement.cpp:
        (HTMLMediaElement::loadResource): call lookup() instead of lookupMediaStreamPrivate()

945
946
947
948
949
950
951
952
953
2013-11-25  peavo@outlook.com  <peavo@outlook.com>

        [WinCairo] Compile fails when GSTREAMER is not used.
        https://bugs.webkit.org/show_bug.cgi?id=124853

        Reviewed by Philippe Normand.

        * platform/graphics/gstreamer/GStreamerUtilities.cpp: Don't include GStreamerUtilities.h when GSTREAMER is not used.

954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
2013-11-25  Andreas Kling  <akling@apple.com>

        Deduplicate shortish Text node strings during tree construction.
        <https://webkit.org/b/124855>

        Let HTMLConstructionSite keep a hash set of already seen strings over
        its lifetime. Use this to deduplicate the strings inside Text nodes
        for any string up to 64 characters of length.

        This optimization already sort-of existed for whitespace-only Texts,
        but those are laundered in the AtomicString table which we definitely
        don't want to pollute with every single Text. It might be a good idea
        to stop using the AtomicString table for all-whitespace Text too.

        3.82 MB progression on HTML5-8266 locally.

        Reviewed by Anders Carlsson.

972
973
974
975
976
977
978
979
980
981
982
2013-11-25  Nick Diego Yamane  <nick.yamane@openbossa.org>

        Remove unnecessary MediaStreamTrackDescriptor forward declaration
        https://bugs.webkit.org/show_bug.cgi?id=124854

        Reviewed by Eric Carlson.

        No new tests needed. No behavior changed.

        * Modules/mediastream/VideoStreamTrack.h:

983
984
985
986
987
988
989
990
991
992
993
994
2013-11-25  Robert Hogan  <robert@webkit.org>

        Remove code now unnecessary after r159575
        https://bugs.webkit.org/show_bug.cgi?id=124809

        Reviewed by Antti Koivisto.

        Covered by existing tests fast/block/margin-collapse/self-collapsing-block-with-float*

        * rendering/line/LineBreaker.cpp:
        (WebCore::LineBreaker::skipLeadingWhitespace):

995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
2013-11-25  Laszlo Vidacs  <lac@inf.u-szeged.hu>

        Vertical border spacing is doubled between table row groups
        https://bugs.webkit.org/show_bug.cgi?id=20040

        Reviewed by Csaba Osztrogonác.

        Based on Chromium fix https://chromium.googlesource.com/chromium/blink/+/eb615069267f895c59bc576f9d65b3fa5add41e9

        Rebaseline needed for table related tests (100+).

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::calcRowLogicalHeight):

1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
2013-11-25  Andres Gomez  <agomez@igalia.com>

        [GStreamer] Seeking fails on media content provided by servers not supporting Range requests
        https://bugs.webkit.org/show_bug.cgi?id=85994

        Reviewed by Philippe Normand.

        Based on the patch written by Andre Moreira Magalhaes.

        When the GStreamer web source was doing a "Range" request we were
        expecting to receive a 206 status reply with the "Content-Range"
        header and just the requested data. Supporting "Range" requests is
        not mandatory so, for the servers not supporting it they will be
        replying with a 200 status and the whole content of the media
        element. Now, we are properly handling these replies too.

        Test: http/tests/media/media-seeking-no-ranges-server.html

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (StreamingClient::handleResponseReceived): Do not fail when
        receiving 200 as response for HTTP range requests.
        (StreamingClient::handleDataReceived): Manually seek on stream
        when receiving the full data after a seek.

1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
2013-11-25  Radu Stavila  <stavila@adobe.com>

        Removed obsolete FIXME after the landing of visual overflow patch (https://bugs.webkit.org/show_bug.cgi?id=118665).
        https://bugs.webkit.org/show_bug.cgi?id=124833

        Reviewed by Mihnea Ovidenie.

        * rendering/RenderRegion.cpp:
        (WebCore::RenderRegion::layoutBlock):

1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
2013-11-18  Sergio Villar Senin  <svillar@igalia.com>

        [CSS Grid Layout] Cache several vectors to avoid malloc/free churn
        https://bugs.webkit.org/show_bug.cgi?id=123995

        Reviewed by Dean Jackson.

        From Blink r158228 by <jchaffraix@chromium.org>

        Laying-out the grid items means a lot of calls to
        distributeSpaceToTracks() and
        resolveContentBasedTrackSizingFunctionsForItems() as they're
        called in a loop. This means that there is a lot of malloc/free
        going on there. By moving the vectors used by these methods to a
        new class which is kept during the whole layout process we save a
        lot of those calls.

        This obviously mean that the price we pay for a significant
        perfomance improvement is that we keep the maximum allocation till
        the end of each layout, but it's an amount of memory that we have
        to allocate anyway. The improvement in the
        auto-grid-lots-of-data.html perf test is ~24% (165 runs/s vs 207
        runs/s).

        No new tests required as we're just refactoring code to a new
        helper class. Nevertheless the performance improvement is backed
        by the perf test mentioned above.

        * rendering/RenderGrid.cpp:
        (WebCore::RenderGrid::GridSizingData::GridSizingData):
        (WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
        (WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
        (WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
        (WebCore::RenderGrid::distributeSpaceToTracks):
        (WebCore::RenderGrid::layoutGridItems):
        (WebCore::RenderGrid::findChildLogicalPosition):
        * rendering/RenderGrid.h:

1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
2013-11-24  Brady Eidson  <beidson@apple.com>

        DatabaseProcess: Add "UniqueIDBDatabase" that multiple WebProcesses can connect to
        https://bugs.webkit.org/show_bug.cgi?id=124819

        Reviewed by Dan Bernstein.

        * Modules/indexeddb/IDBDatabaseBackend.cpp:
        (WebCore::IDBDatabaseBackend::~IDBDatabaseBackend): Unregister from the IDBFactory.

1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
2013-11-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Generate toHTMLMarquee|OListElement() to cleanup static_cast<>
        https://bugs.webkit.org/show_bug.cgi?id=124707

        Reviewed by Darin Adler.

        As a step to use toFoo(), we need to generate toHTMLMarquee|OListElement().
        Besides this patch cleans up remaining static_cast<> usage.

        No new tests, no behavior changes.

        * css/StyleResolver.cpp:
        (WebCore::StyleResolver::State::initElement):
        (WebCore::StyleResolver::locateCousinList):
        (WebCore::StyleResolver::findSiblingForStyleSharing):
        * dom/Attr.cpp:
        (WebCore::Attr::style):
        * dom/Element.cpp:
        (WebCore::Element::removeAttribute):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
        (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::wrappingStyleForSerialization):
        * editing/Editor.cpp:
        (WebCore::Editor::applyEditingStyleToElement):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
        * html/HTMLMarqueeElement.h:
        * html/HTMLOListElement.h:
        * html/HTMLTagNames.in:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
        * inspector/InspectorOverlay.cpp:
        (WebCore::buildObjectForElementInfo):
        * page/PageSerializer.cpp:
        (WebCore::PageSerializer::serializeFrame):
        * rendering/RenderCounter.cpp:
        (WebCore::planCounter):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::resize):
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::calcValue):
        (WebCore::RenderListItem::updateListMarkerNumbers):
        * rendering/RenderMarquee.cpp:
        (WebCore::RenderMarquee::marqueeSpeed):

1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
2013-11-24  Tim Horton  <timothy_horton@apple.com>

        REGRESSION (r156291): TileController tiles don't always repaint when they resize
        https://bugs.webkit.org/show_bug.cgi?id=124796

        Reviewed by Simon Fraser.

        In removing platformCALayerDidCreateTiles, r156291 also removed
        the call to setNeedsDisplay when tiles are resized, without
        putting it somewhere else.

        * platform/graphics/ca/mac/TileController.mm:
        (WebCore::TileController::setNeedsDisplay):
        Use hasStaleContent when invalidating a whole tile, just
        like we do for partial tile repaints.

        (WebCore::TileController::setTileNeedsDisplayInRect):
        Mark hasStaleContent for any unparented layers, so they'll be painted
        when they are reparented.

        (WebCore::TileController::ensureTilesForRect):
        Invalidate the whole tile when it changes size.

1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
2013-11-23  Xabier Rodriguez Calvar  <calvaris@igalia.com>

        [GStreamer] Remove 0.10 codepath
        https://bugs.webkit.org/show_bug.cgi?id=124534

        Reviewed by Philippe Normand.

        All GStreamer ports are using 1.0 now so we remove the 0.10
        codepath.

        * GNUmakefile.list.am:
        * PlatformEfl.cmake:
        * PlatformGTK.cmake:
        * WebCore.vcxproj/WebCore.vcxproj:
        * WebCore.vcxproj/WebCore.vcxproj.filters: Removed
        GStreamerVersioning.
        * platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
        (onGStreamerWavparsePadAddedCallback): Removed.
        (WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
        Replaced webkitGstPipelineGetBus and removed 0.10 codepath.
        (WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
        Replaced webkitGstPipelineGetBus.
        * platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
        (WebCore::copyGstreamerBuffersToAudioChannel):
        (WebCore::onAppsinkPullRequiredCallback): Removed 0.10 codepath.
        (WebCore::AudioFileReader::~AudioFileReader): Replaced
        webkitGstPipelineGetBus and removed 0.10 codepath.
        (WebCore::AudioFileReader::handleSample): Left as only codepath.
        (WebCore::AudioFileReader::handleBuffer): Removed.
        (WebCore::AudioFileReader::handleNewDeinterleavePad): Removed 0.10
        codepath.
        (WebCore::AudioFileReader::plugDeinterleave): Replaced
        getGstAudioCaps.
        (WebCore::AudioFileReader::decodeAudioForBusCreation): Replaced
        webkitGstPipelineGetBus.
        (WebCore::AudioFileReader::createBus): Removed 0.10 codepath.
        * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
        (getGStreamerMonoAudioCaps):
        (webKitWebAudioGStreamerChannelPosition): Removed 0.10 codepath.
        (webkit_web_audio_src_class_init): Replaced
        setGstElementClassMetadata.
        (webkit_web_audio_src_init):
        (webKitWebAudioSrcConstructed):
        (webKitWebAudioSrcFinalize):
        (webKitWebAudioSrcLoop): Removed 0.10 codepath.
        * platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
        * platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
        Removed checks for 1.0 as it is the only codepath now.
        * platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
        (WTF::GstElement):
        (WTF::GstPad):
        (WTF::GstPadTemplate):
        (WTF::GstTask):
        (WTF::GstBus):
        (WTF::GstElementFactory):
        (WTF::adoptGRef): Replaced gstObjectIsFloating.
        (WTF::refGRef): Replaced webkitGstObjectRefSink.
        (WTF::GstTagList):
        (WTF::GstSample): Removed checks for 1.0 as it is the only
        codepath now.
        * platform/graphics/gstreamer/GRefPtrGStreamer.h: Removed checks
        for 1.0 as it is the only codepath now.
        * platform/graphics/gstreamer/GStreamerUtilities.cpp:
        (WebCore::webkitGstGhostPadFromStaticTemplate):
        (WebCore::getVideoSizeAndFormatFromCaps):
        (WebCore::createGstBuffer):
        (WebCore::createGstBufferForData):
        (WebCore::getGstBufferDataPointer):
        (WebCore::mapGstBuffer):
        (WebCore::unmapGstBuffer): Moved here from GstVersioning and added
        to WebCore namespace.
        * platform/graphics/gstreamer/GStreamerUtilities.h:
        (WebCore::webkitGstCheckVersion): Moved here from GstVersioning
        and added to WebCore namespace.
        * platform/graphics/gstreamer/GStreamerVersioning.cpp: Removed.
        * platform/graphics/gstreamer/GStreamerVersioning.h: Removed.
        * platform/graphics/gstreamer/ImageGStreamer.h: Removed checks for
        1.0 as it is the only codepath now.
        * platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
        (ImageGStreamer::ImageGStreamer): Removed 0.10 codepath.
        (ImageGStreamer::~ImageGStreamer): Removed checks for 1.0 as it is
        the only codepath now.
        * platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:
        * platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
        * platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
        Removed checks for 1.0 as it is the only codepath now.
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::setAudioStreamPropertiesCallback): Removed 0.10 codepath.
        (WebCore::mediaPlayerPrivateTextChangedCallback): Removed checks
        for 1.0 as it is the only codepath now.
        (WebCore::MediaPlayerPrivateGStreamer::isAvailable): Replaced
        gPlaybinName.
        (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
        Removed checks for 1.0 and replaced webkitGstPipelineGetBus.
        (WebCore::MediaPlayerPrivateGStreamer::duration): Removed 0.10
        codepath.
        (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
        (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
        (WebCore::MediaPlayerPrivateGStreamer::textChanged):
        Removed checks for 1.0 as it is the only codepath now.
        (WebCore::MediaPlayerPrivateGStreamer::buffered): Replaced
        gPercentMax.
        (WebCore::MediaPlayerPrivateGStreamer::handleMessage): Removed
        0.10 codepath.
        (WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):
        Removed checks for 1.0 as it is the only codepath now.
        (WebCore::MediaPlayerPrivateGStreamer::totalBytes): Removed 0.10
        codepath.
        (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Replaced
        gPlaybinName and webkitGstPipelineGetBus and removed checks for
        1.0.
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
        Removed checks for 1.0 as it is the only codepath now.
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
        (WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
        (WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
        (WebCore::MediaPlayerPrivateGStreamerBase::paint): Removed 0.10
        codepath.
        * platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
        * platform/graphics/gstreamer/TextCombinerGStreamer.h:
        * platform/graphics/gstreamer/TextSinkGStreamer.cpp:
        * platform/graphics/gstreamer/TextSinkGStreamer.h:
        * platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
        * platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Removed
        checks for 1.0 as it is the only codepath now.
        * platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
        (webkitVideoSinkRender): Removed 0.10 codepath and added WebCore
        as createGstBuffer namespace.
        (webkitVideoSinkSetCaps): Removed 0.10 codepath.
        (webkitVideoSinkProposeAllocation): Removed checks for 1.0 as it
        is the only codepath now.
        (webkitVideoSinkMarshalVoidAndMiniObject): Removed as it was 0.10.
        (webkit_video_sink_class_init): Removed 0.10 codepath and replaced
        setGstElementClassMetadata.
        * platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
        * platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
        Removed checks for 1.0 as it is the only codepath now.
        * platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:
        (webkit_media_src_class_init): Replaced
        setGstElementClassMetadata.
        (webKitMediaSrcAddSrc): Added WebCore namespace to
        webkitGstGhostPadFromStaticTemplate.
        (MediaSourceClientGstreamer::didReceiveData): Added WebCore
        namespace to createGstBufferForData.
        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        Removed 0.10 codepath.
        (webKitWebSrcQuery): Removed as it was 0.10 only.
        (void webkit_web_src_class_init): Replaced setGstElementClassMetadata.
        (webkit_web_src_init): Removed haveAppSrc27 private attribute and
        0.10 codepath.
        (webKitWebSrcStop): Removed checks for 1.0 as it is the only
        codepath now.
        (webKitWebSrcSetProperty):
        (webKitWebSrcUriGetType):
        (webKitWebSrcGetProtocols):
        (webKitWebSrcGetUri):
        (webKitWebSrcSetUri): Removed 0.10 codepath.
        (StreamingClient::createReadBuffer): Removed checks for 1.0 and
        replaced getGstBufferSize.
        (StreamingClient::handleResponseReceived): Removed 0.10 codepath
        and replaced notifyGstTagsOnPad.
        (StreamingClient::handleDataReceived): Removed 0.10 codepath and
        replaced setGstBufferSize and gst_buffer_get_size.

1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
2013-11-22  Jer Noble  <jer.noble@apple.com>

        [Mac] Can't drag full-screen video to another monitor
        https://bugs.webkit.org/show_bug.cgi?id=124798

        Reviewed by Geoffrey Garen.

        Make full screen windows movable by default. Previously, we wanted non-movable full screen
        windows since they were in the same space and were just placed atop non-full screen windows.
        Now that all our supported Mac platforms have explicit full screen support, we can remove this
        non-movable restriction.

        * platform/mac/WebCoreFullScreenWindow.mm:
        (-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):

1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
2013-11-22  Brent Fulgham  <bfulgham@apple.com>

        [Win] Clean up ColorSpace handling in Windows code
        https://bugs.webkit.org/show_bug.cgi?id=124795

        Reviewed by Tim Horton.

        Functionality covered by existing fast/css/color test suite.

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::safeRGBColorSpaceRef): Handle case of Windows CG implementation not
        handling sRGB correctly.
        (WebCore::sRGBColorSpaceRef): Use new helper function.
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs): Pass correct color space to fill functions.
        * platform/graphics/win/GraphicsContextCGWin.cpp:
        (WebCore::GraphicsContext::platformInit): Initialize color space to value passed
        via the style to the constructor.

1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
2013-11-22  Alexey Proskuryakov  <ap@apple.com>

        WebCrypto algorithms should check that key algorithm matches
        https://bugs.webkit.org/show_bug.cgi?id=123628

        Reviewed by Anders Carlsson.

        No change in behavior yet, because we have one algorithm per key class.
        Will be tested once more algorithms are added.

        * WebCore.xcodeproj/project.pbxproj: Updated for file renames.

        * bindings/js/JSCryptoAlgorithmDictionary.cpp:
        (WebCore::createRsaKeyParamsWithHash):
        (WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
        * bindings/js/JSCryptoKeySerializationJWK.cpp:
        (WebCore::createRSAKeyParametersWithHash):
        (WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
        * crypto/CryptoAlgorithmParameters.h:
        (WebCore::CryptoAlgorithmParameters::ENUM_CLASS):
        * crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h: Copied from Source/WebCore/crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h.
        * crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h: Removed.
        Renamed RsaSsaKeyParams to RsaKeyParamsWithHash, because other algorithms (like RSA-OAEP)
        are in the same boat. Depending on where the spec goes, we might need to introduce
        algorithm specific RSA parameter classes later, but let's reduce copy/pasted code at
        least for now.

        * crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Moved to the correct directory.
        * crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Copied from Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp.
        (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign): Factored out Mac specific
        code, leaving type casting to cross-platform files.
        (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify): Ditto.

        * crypto/CryptoAlgorithmRegistry.h:
        (WebCore::CryptoAlgorithmRegistry::registerAlgorithm):
        * crypto/mac/CryptoAlgorithmRegistryMac.cpp:
        (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
        Reduce copy/pasting in registration code.

        * crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
        (WebCore::CryptoAlgorithmAES_CBC::keyAlgorithmMatches): Check key type and algorithm.
        (WebCore::CryptoAlgorithmAES_CBC::encrypt): Cross platform type casting code.
        Maybe we'll find a way to autogenerate or eliminate it one day.
        (WebCore::CryptoAlgorithmAES_CBC::decrypt): Ditto.

        * crypto/algorithms/CryptoAlgorithmAES_CBC.h:
        * crypto/algorithms/CryptoAlgorithmHMAC.cpp:
        (WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches):
        (WebCore::CryptoAlgorithmHMAC::sign):
        (WebCore::CryptoAlgorithmHMAC::verify):
        * crypto/algorithms/CryptoAlgorithmHMAC.h:
        * crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
        (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::keyAlgorithmMatches):
        (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
        (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
        (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):
        * crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
        * crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
        (WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
        (WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
        * crypto/mac/CryptoAlgorithmHMACMac.cpp:
        (WebCore::CryptoAlgorithmHMAC::platformSign):
        (WebCore::CryptoAlgorithmHMAC::platformVerify):
        Same changes for all algorithms that have keys.

1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
2013-11-22  Brendan Long  <b.long@cablelabs.com>

        Fire "change" event on TextTrackList when a TextTrack's mode changes
        https://bugs.webkit.org/show_bug.cgi?id=124789

        Reviewed by Eric Carlson.

        Since AudioTrackList and VideoTrackList already have this event, the
        interesting bits are in TrackListBase::scheduleChangeEvent(), and we
        just need to call it for TextTrackList changes.

        Test: media/track/track-change-event.html

        * html/HTMLMediaElement.cpp:
        (HTMLMediaElement::textTrackModeChanged): Call TrackListBase::scheduleChangeEvent().
        * html/track/TextTrackList.idl: Add onchange event listener.

1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
2013-11-22  Brendan Long  <b.long@cablelabs.com>

        Add TextTrackList::getTrackById().
        https://bugs.webkit.org/show_bug.cgi?id=124785

        Reviewed by Eric Carlson.

        Test: media/track/track-id.html

        * html/track/TextTrackList.cpp: Add getTrackById()
        (TextTrackList::getTrackById):
        * html/track/TextTrackList.h: Same.
        * html/track/TextTrackList.idl: Same.

1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
2013-11-22  Hans Muller  <hmuller@adobe.com>

        [CSS Shapes] When the <box> value is set, derive radii from border-radius
        https://bugs.webkit.org/show_bug.cgi?id=124228

        Reviewed by Dean Jackson.

        Add support for BoxShape elliptical corners.

        Tests: fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001.html
               fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002.html

        * platform/graphics/FloatRoundedRect.h:
        (WebCore::FloatRoundedRect::bottomLeftCorner): Corrected a copy-and-pasteO.
        * rendering/shapes/BoxShape.cpp:
        (WebCore::BoxShape::getExcludedIntervals): Returned interval now depends on the top and bottom of the line.
        * rendering/shapes/Shape.cpp:
        (WebCore::Shape::createShape): Rounded rect parameters are now specified with a RoundedRect parameter.
        * rendering/shapes/Shape.h:
        * rendering/shapes/ShapeInfo.cpp:
        (WebCore::::computedShape): Pass style's rounded border to createShape().

1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
2013-11-22  Andres Gomez  <agomez@igalia.com>

        Several missing/incorrect guards for LOG_DISABLED=0 against Release build (Mac)
        https://bugs.webkit.org/show_bug.cgi?id=78735

        Reviewed by Mario Sanchez Prada.

        In a "Debug" build the CString.h header comes from another
        indirect dependency. Now, we explicitly add this missing include.

        * page/CaptionUserPreferencesMediaAF.cpp: Explicitly adding
        missing include.

1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
2013-11-22  Robert Sipka  <sipka@inf.u-szeged.hu>

        [curl] Fix of SSL certificate chain storage
        https://bugs.webkit.org/show_bug.cgi?id=124768

        Reviewed by Brent Fulgham.

        Change the certificates storage type into ListHashSet
        from HashSet to keep the chain order in each case.
        This ensures that there is no difference between the stored
        and the recieved certificate chain.

        * platform/network/curl/SSLHandle.cpp:
        (WebCore::allowsAnyHTTPSCertificateHosts):
        (WebCore::sslIgnoreHTTPSCertificate):
        (WebCore::pemData):
        (WebCore::certVerifyCallback):

1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
2013-11-22  Brent Fulgham  <bfulgham@apple.com>

        [Win] Avoid deadlock when interacting with some AVFoundationCF content
        <rdar://problem/15482977> and https://bugs.webkit.org/show_bug.cgi?id=124752

        Prevent deadlock caused by conflict over the "mapLock" mutex. Notification handling in the file,
        which modify assets and make other changes, are required to happen on the main thread. This
        patch enforces this requirement.

        Reviewed by Eric Carlson.

        * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
        (WebCore::NotificationCallbackData::NotificationCallbackData): Added
        (WebCore::AVFWrapper::processNotification): Moved logic from 'notificationCallback', which was
        sometimes happening on a background thread.
        (WebCore::AVFWrapper::notificationCallback): Dispatch calls to main thread.

1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
2013-11-22  peavo@outlook.com  <peavo@outlook.com>

        [WinCairo] Compile error when ACCELERATED_COMPOSITING is not used.
        https://bugs.webkit.org/show_bug.cgi?id=124773

        Reviewed by Brent Fulgham.

        * rendering/RenderView.cpp:
        (WebCore::RenderView::paintBoxDecorations): Added USE(ACCELERATED_COMPOSITING) guard.

1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
2013-11-18  Sergio Villar Senin  <svillar@igalia.com>

        [CSS Grid Layout] Improve content-sized track layout
        https://bugs.webkit.org/show_bug.cgi?id=124408

        Reviewed by Dean Jackson.

        Test: fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html

        From Blink r156122 & r157633 by <jchaffraix@chromium.org>

        Added a couple of optimizations to speed up the layout of content
        based tracks. The idea is to narrow down the conditions for
        relayouting when the height of a grid area changes. We basically
        just need to layout tracks with percentage heights as they're the
        only ones that change.

        A new performance test is attached to demonstrate the effect of
        these optimizations. We get a ~1000% improvement on a i7 M620
        going from 14.5 runs/s to 165 runs/s.

        * rendering/RenderGrid.cpp:
        (WebCore::RenderGrid::logicalContentHeightForChild):
        (WebCore::RenderGrid::layoutGridItems):

1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
2013-11-08  Sergio Villar Senin  <svillar@igalia.com>

        [CSS Grid Layout] Run the content-sized tracks sizing algorithm only when required
        https://bugs.webkit.org/show_bug.cgi?id=124039

        Reviewed by Dean Jackson.

        The current code runs the content sized track sizing algorithm all
        the time, which forces a layout even when the track is not
        content-sized. This change improves the situation by applying two
        optimizations. In the first one, we bail out the algorithm if we
        detect that we don't need to run it. And by the second one we
        reduce the amount of recomputations by only iterating over the
        content sized tracks instead of all of them. Both changes follow
        the ideas introduced in Blink r156028 and r156168 by
        <jchaffraix@chromium.org>.

        As we changed the way we iterate over children (we use the
        GridIterator now) the way they're stored in the RenderGrid changes
        too. If a item spans through several "cells" inside the grid, we
        will have a reference to it on each of them.

        These two changes account for a ~3200% improvement on a i7 M620 in
        the test that accompanies this change (15.5 vs 520 run/s).

        New perf test: PerformanceTests/Layout/fixed-grid-lots-of-data.html

        * rendering/RenderGrid.cpp:
        (WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Keep track
        of content sized tracks and only iterate over them.
        (WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
        (WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
        Early return if there are no tracks to pass to the algorithm.
        * rendering/RenderGrid.h:
        * rendering/style/GridLength.h:
        (WebCore::GridLength::isContentSized):
        * rendering/style/GridTrackSize.h:
        (WebCore::GridTrackSize::isContentSized):

1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
2013-11-22  Manuel Rego Casasnovas  <rego@igalia.com>

        [CSS Regions] Move code after early break in RenderRegion::repaintFlowThreadContentRectangle
        https://bugs.webkit.org/show_bug.cgi?id=124743

        Reviewed by Mihnea Ovidenie.

        No new tests, covered by existing tests.

        * rendering/RenderRegion.cpp:
        (WebCore::RenderRegion::repaintFlowThreadContentRectangle): Variable
        flippedFlowThreadPortionRect is not used before the early break, so we
        can move it after and save some unneeded operations.

1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
2013-11-22  Manuel Rego Casasnovas  <rego@igalia.com>

        [CSS Regions] Use hasOverflowClip() in RenderRegion
        https://bugs.webkit.org/show_bug.cgi?id=124746

        Reviewed by Mihnea Ovidenie.

        Implement the suggested FIXME in RenderRegion using hasOverflowClip().

        No new tests, covered by existing tests.

        * rendering/RenderRegion.cpp:
        (WebCore::RenderRegion::overflowRectForFlowThreadPortion): Use
        hasOverflowClip().
        (WebCore::RenderRegion::rectFlowPortionForBox): Ditto.

1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
2013-11-21  Frédéric Wang  <fred.wang@free.fr>

        Map the dir attribute to the CSS direction property.
        https://bugs.webkit.org/show_bug.cgi?id=124572.

        Reviewed by Darin Adler.

        Test: mathml/presentation/mstyle-css-attributes.html

        * mathml/MathMLElement.cpp:
        (WebCore::MathMLElement::isPresentationAttribute): reorder attributes
        (WebCore::MathMLElement::collectStyleForPresentationAttribute): reorder tags that accept dir
        (WebCore::MathMLElement::isMathMLToken): add an inline function to test that a tag corresponds to a MathML Token Element.
        * mathml/MathMLElement.h:

        Follow-up work to address Darin's comments.

1647
1648
1649
1650
1651
1652
1653
2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>

        Remove ENABLE_WORKERS
        https://bugs.webkit.org/show_bug.cgi?id=105784

        Reviewed by Darin Adler.

1654
1655
1656
1657
1658
1659
1660
1661
2013-11-21  Alex Christensen  <achristensen@webkit.org>

        [Win] Unreviewed build fix after r159632.

        * platform/network/curl/SSLHandle.cpp:
        (WebCore::certVerifyCallback):
        Fixed template syntax.

1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
2013-11-21  Bear Travis  <betravis@adobe.com>

        Web Inspector: [CSS Shapes] Refactor highlighting code to decrease Shapes API surface
        https://bugs.webkit.org/show_bug.cgi?id=124737

        Reviewed by Timothy Hatcher.

        Add a virtual method to Shapes, buildPath, that can be used to build the
        path (in the Shape coordinate system) for display in the Inspector. This allows us
        to remove methods such as type(), polygon(), and logicalRx/Ry() which exposed the
        inner workings of the Shapes classes. Also covers the addition of the BoxShape type.

        Refactoring, existing test is inspector-protocol/model/highlight-shape-outside.html.

        * inspector/InspectorOverlay.cpp:
        (WebCore::appendPathCommandAndPoints): Points need to be translated from shape space
        to renderer space using ShapeInfo.
        (WebCore::buildObjectForShapeOutside): Add the ShapeOutsideInfo to the path info struct.
        * rendering/shapes/BoxShape.cpp:
        (WebCore::BoxShape::buildPath): Build the path for a BoxShape.
        * rendering/shapes/BoxShape.h:
        * rendering/shapes/PolygonShape.cpp:
        (WebCore::PolygonShape::buildPath): Build the path for a PolygonShape.
        * rendering/shapes/PolygonShape.h:
        * rendering/shapes/RasterShape.h:
        * rendering/shapes/RectangleShape.cpp:
        (WebCore::RectangleShape::buildPath): Build the path for a RectangleShape.
        * rendering/shapes/RectangleShape.h:
        * rendering/shapes/Shape.h:

1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
2013-11-21  Mark Rowe  <mrowe@apple.com>

        <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.

        All modern versions of Xcode set it appropriately for our needs.

        Reviewed by Alexey Proskuryakov.

        * Configurations/Base.xcconfig:

1702
1703
1704
1705
1706
1707
2013-11-21  Gwang Yoon Hwang  <ryumiel@company100.net>

        [GTK] Unreviewed buildfix after r159614 and r159656.

        * bindings/gobject/WebKitDOMCustom.cpp: Add missing header

1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
2013-11-21  Laszlo Vidacs  <lac@inf.u-szeged.hu>

        Fix WinCairo unreachable code warnings in SimpleLineLayout.cpp
        https://bugs.webkit.org/show_bug.cgi?id=124704

        Reviewed by Antti Koivisto.

        Fix unreachable code warnings using conditional directives.

        * rendering/SimpleLineLayout.cpp:
        (WebCore::SimpleLineLayout::canUseFor):

1720
1721
1722
1723
1724
1725
1726
1727
2013-11-21  Mark Rowe  <mrowe@apple.com>

        <https://webkit.org/b/124701> Fix an error in a few Xcode configuration setting files.

        Reviewed by Alexey Proskuryakov.

        * Configurations/Base.xcconfig:

1728
1729
1730
1731
1732
1733
1734
1735
1736
2013-11-21  Mark Rowe  <mrowe@apple.com>

        <https://webkit.org/b/124700> Fix some deprecation warnings.

        Reviewed by Anders Carlsson.

        * platform/mac/HTMLConverter.mm:
        (fileWrapperForURL): Move off a deprecated NSFileWrapper method.

1737
1738
1739
1740
1741
1742
1743
1744
2013-11-21  Daniel Bates  <dabates@apple.com>

        [iOS] Build fix; export symbol for WebCore::provideDeviceOrientationTo()

        Add the symbol __ZN7WebCore26provideDeviceOrientationToEPNS_4PageEPNS_23DeviceOrientationClientE.

        * WebCore.exp.in:

1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
2013-11-21  Daniel Bates  <dabates@apple.com>

        Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard
        https://bugs.webkit.org/show_bug.cgi?id=124741

        Reviewed by Alexey Proskuryakov.

        Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard around code that is unused
        when building with feature NETWORK_CFDATA_ARRAY_CALLBACK.

        Additionally, add a declaration for allocateSegment() with attribute WARN_UNUSED_RETURN
        to have the compiler warn when the return value of this function is unused. Together with
        warnings treated as errors this change will prevent a memory leak.

        * platform/SharedBuffer.cpp:

1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
2013-11-21  Daniel Bates  <dabates@apple.com>

        Remove unused functions from WebCore and WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=124739

        Reviewed by Alexey Proskuryakov.

        * editing/markup.cpp: Remove unused functions isHTMLBlockElement and
        ancestorToRetainStructureAndAppearanceWithNoRenderer.
        * rendering/InlineElementBox.cpp: Append newline to the end of the file.

1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
2013-11-21  Daniel Bates  <dabates@apple.com>

        Only generate isObservable() when IDL specifies GenerateIsReachable
        https://bugs.webkit.org/show_bug.cgi?id=124729

        Reviewed by Geoffrey Garen.

        We should only generate the static inline function isObservable() when the IDL
        specifies GenerateIsReachable. Otherwise, this function is unused.

        Added a new test IDL TestGenerateIsReachable.idl and expected results to test that
        we generate isObservable() when an IDL specifies GenerateIsReachable. Additionally,
        rebased existing test results.

        * bindings/scripts/CodeGeneratorJS.pm:
        (GenerateImplementation):
        * bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.cpp: Added.
        * bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.h: Added.
        * bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.cpp: Added.
        * bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.h: Added.
        * bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachablePrivate.h: Added.
        * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Removed unused function isObservable().
        * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestException.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp: Added.
        * bindings/scripts/test/JS/JSTestGenerateIsReachable.h: Added.
        * bindings/scripts/test/JS/JSTestInterface.cpp: Removed unused function isObservable().
        * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestTypedefs.cpp: Ditto.
        * bindings/scripts/test/JS/JSattribute.cpp: Ditto.
        * bindings/scripts/test/JS/JSreadonly.cpp: Ditto.
        * bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.h: Added.
        * bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.mm: Added.
        * bindings/scripts/test/ObjC/DOMTestGenerateIsReachableInternal.h: Added.
        * bindings/scripts/test/TestGenerateIsReachable.idl: Added.

1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
2013-11-21  Beth Dakin  <bdakin@apple.com>

        Add a new mode to extend the tile cache beyond the page
        https://bugs.webkit.org/show_bug.cgi?id=124216

        Reviewed by Simon Fraser.

        This patch makes it possible to give the tile cache a margin of tiles. If there is 
        a margin of tiles, this patch paints those tiles with the background color. Note 
        that this patch does not actually give the tile cache a margin at this time.

        You opt into a margined tiled cache by called setTileMargins() with number of 
        pixels that the margin on that side should be. 
        * platform/graphics/TiledBacking.h:
        * platform/graphics/ca/mac/TileController.h:
        * platform/graphics/ca/mac/TileController.mm:
        (WebCore::TileController::TileController):
        (WebCore::TileController::tilesWouldChangeForVisibleRect):

        TileController::bounds() now computes the bounds INCLUDING the margin.
        (WebCore::TileController::bounds):

        adjustRectAtTileIndexForMargin() is a new function that is required to get the 
        rect size for tiles in the margin right. rectForTileIndex() assumes all tiles 
        strive to be the size of m_tileSize, but now margin tiles will be whatever the 
        margin sizes were set to.
        (WebCore::TileController::adjustRectAtTileIndexForMargin):
        (WebCore::TileController::rectForTileIndex):

        This is another instance where m_tileSize is not always the right size to use.
        (WebCore::TileController::getTileIndexRangeForRect):

        The tile coverage rect now might include the margin tiles. Only include them in 
        slow-scrolling mode if the current position is within one tile of the edge.
        (WebCore::TileController::computeTileCoverageRect):

        tileSizeForCoverageRect() does not make sense in a world where the coverage rect 
        will include margin. Instead, this patch implements the current strategy more 
        explicitly by returning the visibleRect in the slow scrolling case, and in the 
        process this patch also re-names tileSizeForCoverageRect() to computeTileSize() 
        since it no longer takes a coverageRect.
        (WebCore::TileController::computeTileSize):
        (WebCore::TileController::revalidateTiles):

        New setters and getters for the tile margins on each side.
        (WebCore::TileController::setTileMargins):
        (WebCore::TileController::hasMargins):
        (WebCore::TileController::topMarginHeight):
        (WebCore::TileController::bottomMarginHeight):
        (WebCore::TileController::leftMarginWidth):
        (WebCore::TileController::rightMarginWidth):

        New function to add margin onto the composited bounds if there is one.
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::tiledBackingHasMargin):
        (WebCore::RenderLayerBacking::paintContents):
        (WebCore::RenderLayerBacking::compositedBoundsIncludingMargin):
        * rendering/RenderLayerBacking.h:

        Do not set masks to bounds if there is a margin on the root layer.
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateBacking):
        (WebCore::RenderLayerCompositor::mainFrameBackingIsTiledWithMargin):
        * rendering/RenderLayerCompositor.h:

        Allow background color to paint into the margin tiles.
        * rendering/RenderView.cpp:
        (WebCore::RenderView::paintBoxDecorations):

ap@apple.com's avatar
ap@apple.com committed
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
2013-11-21  Alexey Proskuryakov  <ap@apple.com>

        Implement WebCrypto wrapKey
        https://bugs.webkit.org/show_bug.cgi?id=124738

        Reviewed by Anders Carlsson.

        Tests: crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html
               crypto/subtle/aes-cbc-wrap-rsa.html

        * bindings/js/JSSubtleCryptoCustom.cpp:
        (WebCore::exportKey): Factored out the actual operation that can be chained with
        encryption for wrapKey.
        (WebCore::JSSubtleCrypto::exportKey):
        (WebCore::JSSubtleCrypto::wrapKey):
        (WebCore::JSSubtleCrypto::unwrapKey): Fixed a memory leak in failure code path.

        * crypto/SubtleCrypto.idl: Added wrapKey.

ap@apple.com's avatar
ap@apple.com committed
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
2013-11-21  Alexey Proskuryakov  <ap@apple.com>

        Implement WebCrypto unwrapKey
        https://bugs.webkit.org/show_bug.cgi?id=124725

        Reviewed by Anders Carlsson.

        Tests: crypto/subtle/aes-cbc-unwrap-failure.html
               crypto/subtle/aes-cbc-unwrap-rsa.html

        * bindings/js/JSCryptoAlgorithmDictionary.cpp:
        * bindings/js/JSCryptoAlgorithmDictionary.h:
        Removed calls for wrap/unwrap parameter parsing, these are just the same as encrypt/decrypt.

        * bindings/js/JSCryptoOperationData.cpp:
        (WebCore::cryptoOperationDataFromJSValue):
        * bindings/js/JSCryptoOperationData.h:
        * crypto/CryptoKeySerialization.h:
        More Vector<char> elimination.

        * bindings/js/JSDOMPromise.cpp:
        * bindings/js/JSDOMPromise.h:
        Removed unneccessary copy constructor and assignment operator, they are no diffdrent
        than compiler generated ones.

        * bindings/js/JSSubtleCryptoCustom.cpp:
        (WebCore::cryptoKeyUsagesFromJSValue): Minor style fixes.
        (WebCore::JSSubtleCrypto::encrypt): Ditto.
        (WebCore::JSSubtleCrypto::decrypt): Ditto.
        (WebCore::JSSubtleCrypto::sign): Ditto.
        (WebCore::JSSubtleCrypto::verify): Ditto.
        (WebCore::JSSubtleCrypto::generateKey): Ditto.
        (WebCore::importKey): Separated actual import operation and the parts that read
        arguments from ExecState, and call the promise. Logically, this should be outside
        of bindings code even, but JWK makes that quite challenging.
        (WebCore::JSSubtleCrypto::importKey): This only does the more mundane arguments
        and return parts now.
        (WebCore::JSSubtleCrypto::exportKey): Minor style fixes.
        (WebCore::JSSubtleCrypto::unwrapKey): Chain decrypt and import.

        * crypto/CryptoAlgorithm.cpp:
        (WebCore::CryptoAlgorithm::encryptForWrapKey):
        (WebCore::CryptoAlgorithm::decryptForUnwrapKey):
        * crypto/CryptoAlgorithm.h:
        There are algorithms that expose wrap/unwrap, but not encrypt/decrypt. These will
        override these new functions, and leave encrypt/decrypt to raise NOT_SUPPORTED_ERR.

        * crypto/SubtleCrypto.idl: Added unwrapKey.

1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
2013-11-21  Robert Sipka  <sipka@inf.u-szeged.hu>

        [curl]Improve ssl certificate storage and check
        https://bugs.webkit.org/show_bug.cgi?id=124569

        Reviewed by Brent Fulgham.

        Storage and check the whole certificate chain, not just the root certificate.

        * platform/network/curl/SSLHandle.cpp:
        (WebCore::allowsAnyHTTPSCertificateHosts):
        (WebCore::sslIgnoreHTTPSCertificate):
        (WebCore::pemData):
        (WebCore::certVerifyCallback):

1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
2013-11-21  Mihai Maerean  <mmaerean@adobe.com>

        Fix hover area for divs with css transforms
        https://bugs.webkit.org/show_bug.cgi?id=124647

        Reviewed by Allan Sandfeld Jensen.

        Non transformed layers are now being hit last, not through or in-between transformed layers.
        The paint order says that the divs creating stacking contexts (including transforms) are painted after the
        other siblings so they should be hit tested in the reverse order. Also, a rotated div in a non-rotated parent
        should be hit in its entire area, not hit its parent's background, even if the z-coordinate is negative where
        the mouse is located.

        Test: transforms/3d/hit-testing/hover-rotated-negative-z.html

        * rendering/RenderLayer.cpp:
        (WebCore::computeZOffset):

1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
2013-11-21  Andres Gomez  <agomez@igalia.com>

        [GTK] Release compilation fails when defining "LOG_DISABLED=0"
        https://bugs.webkit.org/show_bug.cgi?id=124661

        Reviewed by Mario Sanchez Prada.

        In a "Debug" build the CString.h header comes from another
        indirect dependency. Now, we explicitly add this missing include.

        * html/HTMLTrackElement.cpp: Explicitly adding missing include.

1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>

        Fix Range.insertNode when the inserted node is in the same container as the Range
        https://bugs.webkit.org/show_bug.cgi?id=123957

        Reviewed by Antti Koivisto.

        Inspired by https://chromium.googlesource.com/chromium/blink/+/fb6ca1f488703e8d4f20ce6449cc8ea210be6edb

        When a node from the same container is inserted, we can't simply adjust m_end with the offset.
        Compute m_start and m_end from the inserted nodes instead.

        Also, don't adjust m_start and m_end to nodes outside of the document if the inserted nodes had been
        removed by mutation events.

        Test: fast/dom/Range/range-insertNode-same-container.html

        * dom/Range.cpp:
        (WebCore::Range::insertNode):

2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>

        nextBoundary and previousBoundary are very slow when there is a password field
        https://bugs.webkit.org/show_bug.cgi?id=123973

        Reviewed by Antti Koivisto.

        Merge https://chromium.googlesource.com/chromium/blink/+/57366eec5e3edea54062d4e74c0e047f8681dbad

        When iterating through DOM nodes nextBoundary and previousBoundary convert the contents of nodes using
        text security to a sequence of 'x' characters. The SimplifiedBackwardsTextIterator and TextIterator
        may iterate past node boundaries. Before this patch, the transformation was done looking at the starting
        node rather than the current node. In some situations, this replaced all boundaries with 'x' and caused
        the text iterator to continue iterating and transforming until the extent of the document.

        Test: editing/deleting/password-delete-performance.html

        * editing/TextIterator.h:
        (WebCore::SimplifiedBackwardsTextIterator::node):
        * editing/VisibleUnits.cpp:
        (WebCore::previousBoundary):
        (WebCore::nextBoundary):

2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>

        HTML parser should not associate elements inside templates with forms
        https://bugs.webkit.org/show_bug.cgi?id=117779

        Reviewed by Antti Koivisto.

        Merge https://chromium.googlesource.com/chromium/blink/+/45aadf7ee7ee010327eb692066cf013315ef3ed7

        When parsing <form><template><input>, the previous behavior was to associate the <input> with the <form>,
        even though they're not in the same tree (or even the same document).

        This patch changes that by checking, prior to creating a form control element, whether the element to be
        created lives in a document with a browsing context.

        We don't update m_form as needed to faithfully match the HTML5 specification's form element pointer
        http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#form-element-pointer
        and its algorithm for creating and inserting nodes:
        http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#creating-and-inserting-nodes

        While this leaves isindex's reference to form element pointer stale:
        http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#isindex
        The HTML5 specification matches the behaviors of Chrome and Firefox so we leave it as is.

        Test: fast/dom/HTMLTemplateElement/no-form-association.html

        * html/parser/HTMLConstructionSite.cpp:
        (WebCore::HTMLConstructionSite::createHTMLElement):

2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Cannot scroll in option menu when it larger than the screen
        https://bugs.webkit.org/show_bug.cgi?id=124671

        Reviewed by Martin Robinson.

        The problem is that the popup menu is not resized to fit in the
        screen, so it doesn't scroll and some of the items are offscreen
        so they can't be selected either. GTK+ automatically resizes the
        popup menus to fit in the work area, but only when the menu is
        already positioned.

        * platform/gtk/GtkPopupMenu.cpp:
        (WebCore::GtkPopupMenu::popUp): Schedule a resize of the popup
        menu right after showing it once it has a position.

2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Mark all deprecated symbols in GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=124406

        Reviewed by Gustavo Noronha Silva.

        Move deprecated API from WebKitDOMCustom to a new file
        WebKitDOMDeprecated leaving in WebKitDOMCustom only the
        non-deprecated API that is not autogenerated. Also added the
        deprecation decorations and tags in the documentation.

        * bindings/gobject/GNUmakefile.am:
        * bindings/gobject/WebKitDOMCustom.cpp:
        * bindings/gobject/WebKitDOMCustom.h:
        * bindings/gobject/WebKitDOMCustom.symbols:
        * bindings/gobject/WebKitDOMDeprecated.cpp: Copied from Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp.
        (webkit_dom_blob_webkit_slice):
        (webkit_dom_html_element_get_id):
        (webkit_dom_html_element_set_id):
        (webkit_dom_html_element_get_class_name):
        (webkit_dom_html_element_set_class_name):
        (webkit_dom_html_element_get_class_list):
        (webkit_dom_html_form_element_dispatch_form_change):
        (webkit_dom_html_form_element_dispatch_form_input):
        (webkit_dom_webkit_named_flow_get_overflow):
        (webkit_dom_element_get_webkit_region_overflow):
        (webkit_dom_webkit_named_flow_get_content_nodes):
        (webkit_dom_webkit_named_flow_get_regions_by_content_node):
        (webkit_dom_bar_info_get_property):
        (webkit_dom_bar_info_class_init):
        (webkit_dom_bar_info_init):
        (webkit_dom_bar_info_get_visible):
        (webkit_dom_console_get_memory):
        (webkit_dom_css_style_declaration_get_property_css_value):
        (webkit_dom_document_get_webkit_hidden):
        (webkit_dom_document_get_webkit_visibility_state):
        (webkit_dom_html_document_open):
        (webkit_dom_html_element_set_item_id):
        (webkit_dom_html_element_get_item_id):
        (webkit_dom_html_element_get_item_ref):
        (webkit_dom_html_element_get_item_prop):
        (webkit_dom_html_element_set_item_scope):
        (webkit_dom_html_element_get_item_scope):
        (webkit_dom_html_element_get_item_type):
        (webkit_dom_html_style_element_set_scoped):
        (webkit_dom_html_style_element_get_scoped):
        (webkit_dom_html_properties_collection_get_property):
        (webkit_dom_html_properties_collection_class_init):
        (webkit_dom_html_properties_collection_init):
        (webkit_dom_html_properties_collection_item):
        (webkit_dom_html_properties_collection_named_item):
        (webkit_dom_html_properties_collection_get_length):
        (webkit_dom_html_properties_collection_get_names):
        (webkit_dom_node_get_attributes):
        (webkit_dom_node_has_attributes):
        (webkit_dom_memory_info_get_property):
        (webkit_dom_memory_info_class_init):
        (webkit_dom_memory_info_init):
        (webkit_dom_memory_info_get_total_js_heap_size):
        (webkit_dom_memory_info_get_used_js_heap_size):
        (webkit_dom_memory_info_get_js_heap_size_limit):
        (webkit_dom_micro_data_item_value_class_init):
        (webkit_dom_micro_data_item_value_init):
        (webkit_dom_performance_get_memory):
        (webkit_dom_property_node_list_get_property):
        (webkit_dom_property_node_list_class_init):
        (webkit_dom_property_node_list_init):
        (webkit_dom_property_node_list_item):
        (webkit_dom_property_node_list_get_length):
        (webkit_dom_html_media_element_get_start_time):
        (webkit_dom_html_media_element_get_initial_time):
        (webkit_dom_html_head_element_get_profile):
        (webkit_dom_html_head_element_set_profile):
        (webkit_dom_processing_instruction_get_data):
        (webkit_dom_processing_instruction_set_data):
        * bindings/gobject/WebKitDOMDeprecated.h: Copied from Source/WebCore/bindings/gobject/WebKitDOMCustom.h.
        * bindings/gobject/WebKitDOMDeprecated.symbols: Copied from Source/WebCore/bindings/gobject/WebKitDOMCustom.symbols.
        * bindings/scripts/CodeGeneratorGObject.pm:
        (GenerateFunction): Do not include deprecation guards in the cpp file.
        * bindings/scripts/gobject-generate-headers.pl: Do not create
        fordward declarations for non-existent classes like Custom and
        Deprecated.
        * bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
        (webkit_dom_test_event_target_dispatch_event):

2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2013-11-20  Jae Hyun Park  <jae.park@company100.net>

        [CoordinatedGraphics] Use std::unique_ptrs rather than OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=124692

        Reviewed by Noam Rosenthal.

        No new tests, covered by existing ones.

        * platform/graphics/TiledBackingStore.cpp:
        (WebCore::TiledBackingStore::TiledBackingStore):
        * platform/graphics/TiledBackingStore.h:
        * platform/graphics/TiledBackingStoreBackend.h:
        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
        (WebCore::CoordinatedGraphicsLayer::createBackingStore):
        * platform/graphics/texmap/coordinated/CoordinatedTile.h:

2188
2189
2190
2191
2192
2193
2194
2195
2196
2013-11-20  Brady Eidson  <beidson@apple.com>

        Add more infrastructure for ServerConnection communication between Web and Database processes
        https://bugs.webkit.org/show_bug.cgi?id=124693

        Reviewed by Anders Carlsson.

        * WebCore.exp.in:

2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2013-11-20  Ryosuke Niwa  <rniwa@webkit.org>

        Hoist <template> to head when found between </head> and <body> for consistency with <script>
        https://bugs.webkit.org/show_bug.cgi?id=123949

        Reviewed by Antti Koivisto.

        Merge https://chromium.googlesource.com/chromium/blink/+/835fb468fd211054a920fb7612a6dc5043662495

        Move template elements between head and body elements into the head to be consistent with script elements.
        The HTML5 specification was changed in http://html5.org/tools/web-apps-tracker?from=8217&to=8218.

        Inline comments below are cited from https://www.w3.org/Bugs/Public/show_bug.cgi?id=23002
        and https://codereview.chromium.org/25900003 for clarity.

        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag): Add the template element to the list of elements to be hoisted into
        the head element.
        (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):

        Replace the assertion that isParsingFragment is true when item->node() == m_tree.openElements()->rootNode() since,
        with this change, we can now invoke resetInsertionMode when parsing a normal document (not fragment) and there is
        only the html element on the stack of open elements.

        For the second change, consider: <head></head><template>

        This example breaks in the old HTML parser because the template element is handled by "after head" state which
        pushes the head element back on, processes the template element for "in head", then pops the head element off.
        EOF is reached, which processes a fake close tag for the template element, which pops the template element off
        and resets the insertion mode appropriately

        The problem here is that "reset the insertion mode" is going to inspect the bottom-most element on the stack which
        is now the html element and it will set the mode to "before head". Nothing good happens after this.

        We fix this problem by having the reset algorithm check if the head element pointer is set, and if so, go to after
        head instead of before head.

2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2013-11-20  Radu Stavila  <stavila@adobe.com>

        [CSS Regions] Implement visual overflow for first & last regions
        https://bugs.webkit.org/show_bug.cgi?id=118665

        In order to properly propagate the visual overflow of elements flowed inside regions, 
        the responsiblity of painting and hit-testing content inside flow threads has been
        moved to the flow thread layer's level.
        Each region keeps the associated overflow with each box in the RenderBoxRegionInfo
        structure, including one for the flow thread itself. This data is used during
        painting and hit-testing.

        Reviewed by David Hyatt.

        Tests: fast/regions/overflow-first-and-last-regions-in-container-hidden.html
               fast/regions/overflow-first-and-last-regions.html
               fast/regions/overflow-nested-regions.html
               fast/regions/overflow-region-float.html
               fast/regions/overflow-region-inline.html
               fast/regions/overflow-region-transform.html

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::setLayoutOverflow):
        (WebCore::InlineFlowBox::setVisualOverflow):
        * rendering/InlineFlowBox.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addOverflowFromChildren):
        (WebCore::RenderBlock::paint):
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::estimateRegionRangeForBoxChild):
        (WebCore::RenderBlock::updateRegionRangeForBoxChild):
        * rendering/RenderBlockFlow.cpp:
        (WebCore::RenderBlockFlow::hasNextPage):
        (WebCore::RenderBlockFlow::relayoutForPagination):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlockFlow::positionNewFloatOnLine):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::borderBoxRectInRegion):
        (WebCore::RenderBox::computeRectForRepaint):
        (WebCore::RenderBox::addLayoutOverflow):
        (WebCore::RenderBox::addVisualOverflow):
        (WebCore::RenderBox::isUnsplittableForPagination):
        (WebCore::RenderBox::overflowRectForPaintRejection):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::canHaveOutsideRegionRange):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderBoxRegionInfo.h:
        (WebCore::RenderBoxRegionInfo::createOverflow):
        * rendering/RenderFlowThread.cpp:
        (WebCore::RenderFlowThread::objectShouldPaintInFlowRegion):
        (WebCore::RenderFlowThread::mapFromLocalToFlowThread):
        (WebCore::RenderFlowThread::mapFromFlowThreadToLocal):
        (WebCore::RenderFlowThread::decorationsClipRectForBoxInRegion):
        (WebCore::RenderFlowThread::flipForWritingModeLocalCoordinates):
        (WebCore::RenderFlowThread::addRegionsOverflowFromChild):
        (WebCore::RenderFlowThread::addRegionsVisualOverflow):
        (WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
        * rendering/RenderFlowThread.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):
        (WebCore::expandClipRectForRegionAndReflection):
        (WebCore::expandClipRectForDescendantsAndReflection):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::paintLayerContents):
        (WebCore::RenderLayer::updatePaintingInfoForFragments):
        (WebCore::RenderLayer::paintForegroundForFragments):
        (WebCore::RenderLayer::hitTest):
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
        (WebCore::RenderLayer::calculateClipRects):
        (WebCore::RenderLayer::parentClipRects):
        (WebCore::RenderLayer::calculateRects):
        (WebCore::RenderLayer::intersectsDamageRect):
        (WebCore::RenderLayer::updateDescendantsLayerListsIfNeeded):
        (WebCore::RenderLayer::repaintIncludingDescendants):
        (WebCore::RenderLayer::paintNamedFlowThreadInsideRegion):
        (WebCore::RenderLayer::paintFlowThreadIfRegion):
        (WebCore::RenderLayer::hitTestFlowThreadIfRegion):
        * rendering/RenderLayer.h:
        (WebCore::ClipRect::inflateX):
        (WebCore::ClipRect::inflateY):
        (WebCore::ClipRect::inflate):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::computeCompositingRequirements):
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::addOverflowFromChildren):
        * rendering/RenderMultiColumnSet.cpp:
        (WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
        (WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
        * rendering/RenderMultiColumnSet.h:
        * rendering/RenderNamedFlowFragment.cpp:
        (WebCore::RenderNamedFlowFragment::createStyle):
        (WebCore::RenderNamedFlowFragment::namedFlowThread):
        * rendering/RenderNamedFlowFragment.h:
        * rendering/RenderOverflow.h:
        * rendering/RenderRegion.cpp:
        (WebCore::RenderRegion::flowThreadPortionOverflowRect):
        (WebCore::RenderRegion::flowThreadPortionLocation):
        (WebCore::RenderRegion::regionContainerLayer):
        (WebCore::RenderRegion::overflowRectForFlowThreadPortion):
        (WebCore::RenderRegion::computeOverflowFromFlowThread):
        (WebCore::RenderRegion::repaintFlowThreadContent):
        (WebCore::RenderRegion::repaintFlowThreadContentRectangle):
        (WebCore::RenderRegion::insertedIntoTree):
        (WebCore::RenderRegion::ensureOverflowForBox):
        (WebCore::RenderRegion::rectFlowPortionForBox):
        (WebCore::RenderRegion::addLayoutOverflowForBox):
        (WebCore::RenderRegion::addVisualOverflowForBox):
        (WebCore::RenderRegion::layoutOverflowRectForBox):
        (WebCore::RenderRegion::visualOverflowRectForBox):
        (WebCore::RenderRegion::visualOverflowRectForBoxForPropagation):
        * rendering/RenderRegion.h:
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::shouldPaint):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::paint):

2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2013-11-20  Ryosuke Niwa  <rniwa@webkit.org>

        [HTML parser] reset insertion mode appropriate must check for "in select in table" mode
        https://bugs.webkit.org/show_bug.cgi?id=123850

        Reviewed by Antti Koivisto.

        Merge https://chromium.googlesource.com/chromium/blink/+/2cb7523df57dfb48111f6aa16b7138cd54024ba7

        The HTML specification has been updated to detect encountering a template element inside of a select element,
        which in turn is inside of a table element. In this case, the select element will cause the parser to be in
        "InSelectInTable" mode. Thus when the template element closes, it should return to that mode.

        The fix here is that resetInsertionModeAppropriately must continue looking up the stack if the first node is
        select element to see whether the select element is inside of a table element.

        See also: http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#reset-the-insertion-mode-appropriately

        Test: html5lib/resources/template.dat

        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):

2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2013-11-20  Mark Lam  <mark.lam@apple.com>

        Build fix for last commit.
        https://bugs.webkit.org/show_bug.cgi?id=124634.

        Not reviewed.

        No new tests.

        * bindings/js/JSCryptoAlgorithmBuilder.cpp:

2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2013-11-20  Mark Lam  <mark.lam@apple.com>

        Introducing VMEntryScope to update the VM stack limit.
        https://bugs.webkit.org/show_bug.cgi?id=124634.

        Reviewed by Geoffrey Garen.

        No new tests.

        Renamed dynamicGlobalObject() to vmEntryGlobalObject().
        Replaced uses of DynamicGlobalObjectScope with VMEntryScope.

        * ForwardingHeaders/runtime/VMEntryScope.h: Added.
        * WebCore.vcxproj/WebCore.vcxproj:
        * WebCore.vcxproj/WebCore.vcxproj.filters:
        * bindings/js/JSCryptoAlgorithmBuilder.cpp:
        (WebCore::JSCryptoAlgorithmBuilder::add):
        * bindings/js/JSCustomXPathNSResolver.cpp:
        (WebCore::JSCustomXPathNSResolver::create):
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::firstDOMWindow):
        * bindings/js/JSErrorHandler.cpp:
        (WebCore::JSErrorHandler::handleEvent):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::handleEvent):
        * bindings/js/JavaScriptCallFrame.h:
        (WebCore::JavaScriptCallFrame::vmEntryGlobalObject):
        * bindings/js/PageScriptDebugServer.cpp:
        (WebCore::PageScriptDebugServer::recompileAllJSFunctions):
        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::evaluateBreakpointAction):
        (WebCore::ScriptDebugServer::handlePause):
        * bindings/js/WorkerScriptDebugServer.cpp:
        (WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
        * bindings/objc/WebScriptObject.mm:
        (WebCore::addExceptionToConsole):
        * bridge/c/c_utility.cpp:
        (JSC::Bindings::convertValueToNPVariant):
        * bridge/objc/objc_instance.mm:
        (ObjcInstance::moveGlobalExceptionToExecState):
        * bridge/objc/objc_runtime.mm:
        (JSC::Bindings::convertValueToObjcObject):
        * bridge/objc/objc_utility.mm:
        (JSC::Bindings::convertValueToObjcValue):

2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2013-11-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Generate toHTMLFooElement() to clean up static_cast<>
        https://bugs.webkit.org/show_bug.cgi?id=124571

        Reviewed by Ryosuke Niwa.

        Though there are a lot of clean up commits before, there are still
        use of static_cast<HTMLFooElement*>. To clean up them, we need to generate
        toHTMLDetails|Meta|Summary|TableCaptionElement().

        Additionally, other static_cast<> are removed as well.

        No new tests, no behavior changes.

        * html/HTMLDetailsElement.h:
        * html/HTMLMediaElement.cpp:
        (HTMLMediaElement::selectNextSourceChild):
        * html/HTMLMetaElement.h:
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk):
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::isDisabledFormControl):
        * html/HTMLPlugInImageElement.cpp:
        (WebCore::HTMLPlugInImageElement::updateWidgetCallback):
        * html/HTMLSummaryElement.cpp:
        (WebCore::HTMLSummaryElement::detailsElement):
        * html/HTMLSummaryElement.h:
        * html/HTMLTableCaptionElement.h:
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::caption):
        * html/HTMLTagNames.in:
        * html/MediaDocument.cpp:
        (WebCore::MediaDocumentParser::createDocumentStructure):
        * html/shadow/DetailsMarkerControl.cpp:
        (WebCore::DetailsMarkerControl::summaryElement):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::handleFallbackContent):
        * loader/ImageLoader.cpp:
        (WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
        * page/DragController.cpp:
        (WebCore::DragController::canProcessDrag):
        * page/Frame.cpp:
        (WebCore::Frame::searchForLabelsBeforeElement):
        * page/SpatialNavigation.cpp:
        (WebCore::frameOwnerElement):

2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2013-11-20  Ryosuke Niwa  <rniwa@webkit.org>

        Clear TemplateContentDocumentFragment::m_host when HTMLTemplateElement is destroyed
        https://bugs.webkit.org/show_bug.cgi?id=122806

        Reviewed by Antti Koivisto.

        Merge https://chromium.googlesource.com/chromium/blink/+/858ed5f6341de9d900768c1f4668fcfce870c52e

        The document fragment of a template element outlives the element itself.
        Clear the host property on the document fragment when that happens.

        Test: fast/dom/HTMLTemplateElement/content-outlives-template-crash.html

        * dom/TemplateContentDocumentFragment.h:
        * html/HTMLTemplateElement.cpp:
        (WebCore::HTMLTemplateElement::~HTMLTemplateElement):
        * html/HTMLTemplateElement.h:

2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2013-11-20  Chris Fleizach  <cfleizach@apple.com>

        AX: Implement CSS -webkit-alt property (text alternative for generated content pseudo-elements ::before and ::after)
        https://bugs.webkit.org/show_bug.cgi?id=120188

        Reviewed by Dean Jackson.

        Add a -webkit-alt CSS property that can be used to label Image content or Text content for accessibility clients.

        To accomplish this, it sets the string in the RenderStyle. Then when the ContentData creates an anonymous renderer,
        it sets that string on the TextFragment or RenderImage, which can be queried by accessibility code.

        Test: platform/mac/accessibility/webkit-alt-for-css-content.html

        * accessibility/AccessibilityNodeObject.cpp:
        (WebCore::AccessibilityNodeObject::alternativeText):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::textUnderElement):
        (WebCore::objectInclusionFromAltText):
        (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::altTextToCSSValue):
        (WebCore::ComputedStyleExtractor::propertyValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseAlt):
        * css/CSSParser.h:
        * css/CSSPropertyNames.in:
        * css/StyleResolver.cpp:
        (WebCore::StyleResolver::applyProperty):
        * rendering/RenderImage.h:
        (WebCore::RenderImage::altText):
        (WebCore::RenderImage::setAltText):
        * rendering/RenderTextFragment.h:
        * rendering/style/ContentData.cpp:
        (WebCore::ImageContentData::createRenderer):
        (WebCore::TextContentData::createRenderer):
        * rendering/style/ContentData.h:
        (WebCore::ContentData::setAltText):
        (WebCore::ContentData::altText):
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::setContent):
        (WebCore::RenderStyle::setContentAltText):
        (WebCore::RenderStyle::contentAltText):
        * rendering/style/RenderStyle.h:
        * rendering/style/StyleRareNonInheritedData.h:

2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2013-11-20  Roger Fong  <roger_fong@apple.com>

        Use compile flag SH_UNFOLD_SHORT_CIRCUIT when compiling shaders.
        https://bugs.webkit.org/show_bug.cgi?id=124684.

        Reviewed by Brent Fulgham.

        Existing test webgl/1.0.2/conformance/glsl/misc/shader-with-short-circuiting-operators.html

        * platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
        (WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2013-11-20  Robert Sipka  <sipka@inf.u-szeged.hu>

        [curl] Improve detecting and handling of SSL related errors
        https://bugs.webkit.org/show_bug.cgi?id=119436

        Reviewed by Brent Fulgham.

        Set the exact SSL verification error on CURL
        and store the enabled domain with certificate.

        * WebCore.vcxproj/WebCore.vcxproj:
        * WebCore.vcxproj/WebCore.vcxproj.filters:
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/curl/ResourceError.h:
        (WebCore::ResourceError::ResourceError):
        (WebCore::ResourceError::sslErrors):
        (WebCore::ResourceError::setSSLErrors):
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate):
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::downloadTimerCallback):
        (WebCore::ResourceHandleManager::initializeHandle):
        * platform/network/curl/SSLHandle.cpp: Added.
        (WebCore::allowsAnyHTTPSCertificateHosts):
        (WebCore::sslIgnoreHTTPSCertificate):
        (WebCore::sslCertificateFlag):
        (WebCore::pemData):
        (WebCore::certVerifyCallback):
        (WebCore::sslctxfun):
        (WebCore::setSSLVerifyOptions):
        * platform/network/curl/SSLHandle.h: Added.

2592
2593
2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2013-11-20  Bem Jones-Bey  <bjonesbe@adobe.com>

        [css shapes] Parse new circle shape syntax
        https://bugs.webkit.org/show_bug.cgi?id=124618

        Reviewed by Antti Koivisto.

        Implement parsing of the new cicle shape syntax. The implementation of
        the old syntax has been move aside as deprecated, and will be removed
        once the new syntax is stable.

        Updated existing parsing tests to cover this.

        * css/BasicShapeFunctions.cpp:
        (WebCore::valueForCenterCoordinate): Create a CSSPrimitiveValue from a
            BasicShapeCenterCoordinate.
        (WebCore::valueForBasicShape): Convert new basic shape and rename old
            one.
        (WebCore::convertToCenterCoordinate): Create a
            BasicShapeCenterCoordinate from a CSSPrimitiveValue.
        (WebCore::basicShapeForValue): Convert new shape value and rename old
            one.
        * css/CSSBasicShapes.cpp:
        (WebCore::buildCircleString): Build a new circle string.
        (WebCore::CSSBasicShapeCircle::cssText): Serialize the new circle
            shape.
        (WebCore::CSSBasicShapeCircle::equals): Compare new circle shapes.
        (WebCore::CSSBasicShapeCircle::serializeResolvingVariables):
        * css/CSSBasicShapes.h:
        (WebCore::CSSBasicShapeCircle::CSSBasicShapeCircle): Add class for new
            circle shape.
        (WebCore::CSSDeprecatedBasicShapeCircle::create): Renamed to move out
            of the way of the new circle implementation.
        (WebCore::CSSDeprecatedBasicShapeCircle::centerX): Ditto.
        (WebCore::CSSDeprecatedBasicShapeCircle::centerY): Ditto.
        (WebCore::CSSDeprecatedBasicShapeCircle::radius): Ditto.
        (WebCore::CSSDeprecatedBasicShapeCircle::setCenterX): Ditto.
        (WebCore::CSSDeprecatedBasicShapeCircle::setCenterY): Ditto.
        (WebCore::CSSDeprecatedBasicShapeCircle::setRadius): Ditto.
        (WebCore::CSSDeprecatedBasicShapeCircle::CSSDeprecatedBasicShapeCircle): Ditto.
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseShapeRadius): Parse the radius for the new
            circle syntax. Will also be used by the new ellipse syntax.
        (WebCore::CSSParser::parseBasicShapeCircle): Parse the new circle
            syntax.
        (WebCore::CSSParser::parseDeprecatedBasicShapeCircle): Rename to make
            way for the new implementation.
        (WebCore::isDeprecatedBasicShape): Check if we have a new circle or an
            old circle.
        (WebCore::CSSParser::parseBasicShape): Update to parse the new circle
            syntax.
        * css/CSSParser.h:
        * css/CSSValueKeywords.in: Add support for the new circle keywords.
        * rendering/shapes/Shape.cpp:
        (WebCore::Shape::createShape): 
        * rendering/style/BasicShapes.cpp: Deprecate old circle and add stub
            for layout code.
        (WebCore::DeprecatedBasicShapeCircle::path): Rename to make way for
            the new implementation.
        (WebCore::DeprecatedBasicShapeCircle::blend): Rename to make way for
            the new implementation.
        (WebCore::BasicShapeCircle::path): Create path for new circle shape.
        (WebCore::BasicShapeCircle::blend): Interpolate the new circle shape.
        * rendering/style/BasicShapes.h:
        (WebCore::BasicShapeCenterCoordinate::BasicShapeCenterCoordinate):
            Represent an x or y coordinate for the center of a new circle,
            since it can be either a keyword along with an offset that cannot
            be resolved until layout time or an ordinary Length. This will
            also be used by the new ellipse implementation.
        (WebCore::BasicShapeCenterCoordinate::keyword):
        (WebCore::BasicShapeCenterCoordinate::length):
        (WebCore::BasicShapeCenterCoordinate::blend): Interpolate.
        (WebCore::BasicShapeRadius::BasicShapeRadius): Represent the radius of
            a new circle shape since it can either be a straightforward Length or
            a keyword that cannot be resolved until layout time.
        (WebCore::BasicShapeRadius::value):
        (WebCore::BasicShapeRadius::type):
        (WebCore::BasicShapeRadius::blend): Interpolate.
        (WebCore::BasicShapeCircle::centerX):
        (WebCore::BasicShapeCircle::centerY):
        (WebCore::BasicShapeCircle::radius):
        (WebCore::BasicShapeCircle::setCenterX):
        (WebCore::BasicShapeCircle::setCenterY):
        (WebCore::BasicShapeCircle::setRadius):
        (WebCore::BasicShapeCircle::BasicShapeCircle): New circle class.
        (WebCore::DeprecatedBasicShapeCircle::create): Rename to make room for
            new circle implementation.
        (WebCore::DeprecatedBasicShapeCircle::DeprecatedBasicShapeCircle): Ditto.

2681
2682
2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2746
2747
2748
2013-11-20  Hans Muller  <hmuller@adobe.com>

        [CSS Shapes] Add BoxShape and FloatRoundingRect classes
        https://bugs.webkit.org/show_bug.cgi?id=124368

        Reviewed by Dean Jackson.

        Added the BoxShape class. It's now used to represent shape-outside box
        values: [margin/border/padding/content]-box. BoxShape depends on a new
        FloatRoundedRect class, which is a float analog of the existing (int)
        RoundedRect class. The FloatRoundedRect class contains the same basic
        methods and accessors as BorderRect and adds a set of four methods,
        for example topLeftCorner(), that return a FloatRect that represents the
        bounds of one elliptical corner. I also added a method, xInterceptsAtY()
        that returns two X coordinates of the intersection between a horizontal
        line and the rounded rectangle.

        No new tests, this is just an internal refactoring.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.vcxproj/WebCore.vcxproj:
        * WebCore.vcxproj/WebCore.vcxproj.filters:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/FloatRoundedRect.cpp: Added.
        (WebCore::FloatRoundedRect::FloatRoundedRect):
        (WebCore::FloatRoundedRect::Radii::isZero):
        (WebCore::FloatRoundedRect::Radii::scale):
        (WebCore::FloatRoundedRect::Radii::expand):
        (WebCore::cornerRectIntercept):
        (WebCore::FloatRoundedRect::xInterceptsAtY):
        * platform/graphics/FloatRoundedRect.h: Added.
        (WebCore::FloatRoundedRect::Radii::Radii):
        (WebCore::FloatRoundedRect::Radii::setTopLeft):
        (WebCore::FloatRoundedRect::Radii::setTopRight):
        (WebCore::FloatRoundedRect::Radii::setBottomLeft):
        (WebCore::FloatRoundedRect::Radii::setBottomRight):
        (WebCore::FloatRoundedRect::Radii::topLeft):
        (WebCore::FloatRoundedRect::Radii::topRight):
        (WebCore::FloatRoundedRect::Radii::bottomLeft):
        (WebCore::FloatRoundedRect::Radii::bottomRight):
        (WebCore::FloatRoundedRect::Radii::expand):
        (WebCore::FloatRoundedRect::Radii::shrink):
        (WebCore::FloatRoundedRect::rect):
        (WebCore::FloatRoundedRect::radii):
        (WebCore::FloatRoundedRect::isRounded):
        (WebCore::FloatRoundedRect::isEmpty):
        (WebCore::FloatRoundedRect::setRect):
        (WebCore::FloatRoundedRect::setRadii):
        (WebCore::FloatRoundedRect::move):
        (WebCore::FloatRoundedRect::inflate):
        (WebCore::FloatRoundedRect::expandRadii):
        (WebCore::FloatRoundedRect::shrinkRadii):
        (WebCore::FloatRoundedRect::topLeftCorner):
        (WebCore::FloatRoundedRect::topRightCorner):
        (WebCore::FloatRoundedRect::bottomLeftCorner):
        (WebCore::FloatRoundedRect::bottomRightCorner):
        (WebCore::operator==):
        * rendering/shapes/BoxShape.cpp: Added.
        (WebCore::BoxShape::BoxShape):
        (WebCore::BoxShape::getExcludedIntervals):
        (WebCore::BoxShape::getIncludedIntervals):
        (WebCore::BoxShape::firstIncludedIntervalLogicalTop):
        * rendering/shapes/BoxShape.h: Added.
        * rendering/shapes/Shape.cpp:
        (WebCore::createBoxShape):
        (WebCore::Shape::createShape):

2749
2750
2751
2752
2753
2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
2780
2781
2013-11-20  Antti Koivisto  <antti@apple.com>

        Simple line layout should support floats
        https://bugs.webkit.org/show_bug.cgi?id=124666

        Reviewed by Dave Hyatt.

        Tests: fast/text/simple-lines-float-compare.html
               fast/text/simple-lines-float.html

        * rendering/line/LineWidth.h:
        (WebCore::LineWidth::logicalLeftOffset):
        
            Expose the left offset so we don't need to recompute it.

        * rendering/SimpleLineLayout.cpp:
        (WebCore::SimpleLineLayout::canUseFor):
        (WebCore::SimpleLineLayout::computeLineLeft):
        
            Include the left offset from floats.

        (WebCore::SimpleLineLayout::createTextRuns):
        
            Keep the flow height updated during the loop as LineWidth reads the current position from there.

        * rendering/SimpleLineLayoutResolver.h:
        (WebCore::SimpleLineLayout::RunResolver::Run::rect):
        (WebCore::SimpleLineLayout::RunResolver::Run::baseline):
        (WebCore::SimpleLineLayout::RunResolver::RunResolver):
        (WebCore::SimpleLineLayout::RunResolver::lineIndexForHeight):
        
            We now bake the border and the padding to the line left offset. No need to add it during resolve.

2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
2812
2813
2814
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
2829
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2013-11-20  Alexey Proskuryakov  <ap@apple.com>

        Use std::function callbacks in CryptoAlgorithm instead of JS promises
        https://bugs.webkit.org/show_bug.cgi?id=124673

        Reviewed by Anders Carlsson.

        To implement key wrapping/unwrapping, we'll need to chain existing operations.
        It's much easier to do with C++ callbacks than with functions fulfilling JS
        promises directly.

        Also, this will decouple CryptoAlgorithm from JS, which is nice.

        SubtleCrypto IDL says that all functions return Promise<any>, but in reality,
        there is very little polymorphism, the only function whose return type depends
        on algorithm is generateKey (it can create a Key or a KeyPair).

        * bindings/js/JSDOMPromise.cpp:
        (WebCore::PromiseWrapper::PromiseWrapper):
        (WebCore::PromiseWrapper::operator=):
        * bindings/js/JSDOMPromise.h:
        Made it copyable, as each crypto function wraps the promise in success and failure
        functional objects now.

        * bindings/js/JSSubtleCryptoCustom.cpp:
        (WebCore::JSSubtleCrypto::encrypt):
        (WebCore::JSSubtleCrypto::decrypt):
        (WebCore::JSSubtleCrypto::sign):
        (WebCore::JSSubtleCrypto::verify):
        (WebCore::JSSubtleCrypto::digest):
        (WebCore::JSSubtleCrypto::generateKey):
        (WebCore::JSSubtleCrypto::importKey):
        (WebCore::JSSubtleCrypto::exportKey):
        * crypto/CryptoAlgorithm.cpp:
        (WebCore::CryptoAlgorithm::encrypt):
        (WebCore::CryptoAlgorithm::decrypt):
        (WebCore::CryptoAlgorithm::sign):
        (WebCore::CryptoAlgorithm::verify):
        (WebCore::CryptoAlgorithm::digest):
        (WebCore::CryptoAlgorithm::generateKey):
        (WebCore::CryptoAlgorithm::deriveKey):
        (WebCore::CryptoAlgorithm::deriveBits):
        (WebCore::CryptoAlgorithm::importKey):
        * crypto/CryptoAlgorithm.h:
        * crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
        (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
        (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
        * crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
        (WebCore::CryptoAlgorithmAES_CBC::generateKey):
        (WebCore::CryptoAlgorithmAES_CBC::importKey):
        * crypto/algorithms/CryptoAlgorithmAES_CBC.h:
        * crypto/algorithms/CryptoAlgorithmHMAC.cpp:
        (WebCore::CryptoAlgorithmHMAC::generateKey):
        (WebCore::CryptoAlgorithmHMAC::importKey):
        * crypto/algorithms/CryptoAlgorithmHMAC.h:
        * crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
        (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::generateKey):
        (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):
        * crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
        * crypto/algorithms/CryptoAlgorithmSHA1.cpp:
        (WebCore::CryptoAlgorithmSHA1::digest):
        * crypto/algorithms/CryptoAlgorithmSHA1.h:
        * crypto/algorithms/CryptoAlgorithmSHA224.cpp:
        (WebCore::CryptoAlgorithmSHA224::digest):
        * crypto/algorithms/CryptoAlgorithmSHA224.h:
        * crypto/algorithms/CryptoAlgorithmSHA256.cpp:
        (WebCore::CryptoAlgorithmSHA256::digest):
        * crypto/algorithms/CryptoAlgorithmSHA256.h:
        * crypto/algorithms/CryptoAlgorithmSHA384.cpp:
        (WebCore::CryptoAlgorithmSHA384::digest):
        * crypto/algorithms/CryptoAlgorithmSHA384.h:
        * crypto/algorithms/CryptoAlgorithmSHA512.cpp:
        (WebCore::CryptoAlgorithmSHA512::digest):
        * crypto/algorithms/CryptoAlgorithmSHA512.h:
        * crypto/keys/CryptoKeyRSA.h:
        * crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
        (WebCore::transformAES_CBC):
        (WebCore::CryptoAlgorithmAES_CBC::encrypt):
        (WebCore::CryptoAlgorithmAES_CBC::decrypt):
        * crypto/mac/CryptoAlgorithmHMACMac.cpp:
        (WebCore::CryptoAlgorithmHMAC::sign):
        (WebCore::CryptoAlgorithmHMAC::verify):
        * crypto/mac/CryptoKeyRSAMac.cpp:
        (WebCore::CryptoKeyRSA::generatePair):

2867
2868
2869
2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2882
2883
2884
2885
2886
2013-11-20  Robert Hogan  <robert@webkit.org>

        REGRESSION(r127163): Respect clearance set on ancestors when placing floats
        https://bugs.webkit.org/show_bug.cgi?id=119979

        Reviewed by David Hyatt.

        Refactor the way self-collapsing blocks with clearance are positioned so that they
        get the correct logical-top position during margin-collapsing.

        Test: fast/block/margin-collapse/self-collapsing-block-with-float-descendants.html

        * rendering/RenderBlockFlow.cpp:
        (WebCore::RenderBlockFlow::clearFloats):
        (WebCore::RenderBlockFlow::marginOffsetForSelfCollapsingBlock):
        (WebCore::RenderBlockFlow::collapseMargins):
        (WebCore::RenderBlockFlow::clearFloatsIfNeeded):
        (WebCore::RenderBlockFlow::handleAfterSideOfBlock):
        * rendering/RenderBlockFlow.h:

2887
2888
2889
2890
2891
2892
2893
2894
2895
2896
2897
2898
2899
2900
2901
2902
2013-11-20  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>

        [GTK] Remove Chromium as user agent and claim to be Safari in OS X
        https://bugs.webkit.org/show_bug.cgi?id=124229

        Reviewed by Martin Robinson.

        http://www.duolingo.com/ doesn't get render correctly because it uses
        Chrome/Chromium specific variables, added after it was forked. Because
        of this, it is necessary to remove the Chrome/Chromium identification
        in the user agent. Also, from now on, by default, The GTK+ port will
        claim to be Safari in OS X to avoid loading wrong resources.

        * platform/gtk/UserAgentGtk.cpp:
        (WebCore::standardUserAgent):

2903
2904
2905
2906
2907
2908
2909
2910
2911
2912
2913
2914
2915
2916
2917
2918
2919
2920
2921
2922
2923
2924
2925
2926
2927
2928
2929
2930
2931
2932
2933
2934
2935
2936
2937
2938
2939
2940
2941
2942
2943
2944
2945
2946
2947
2948
2013-11-20  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r159551.
        http://trac.webkit.org/changeset/159551
        https://bugs.webkit.org/show_bug.cgi?id=124669

        made many tests asserts (Requested by anttik on #webkit).

        * html/HTMLDetailsElement.h:
        * html/HTMLMediaElement.cpp:
        (HTMLMediaElement::selectNextSourceChild):
        * html/HTMLMetaElement.h:
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk):
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::isDisabledFormControl):
        * html/HTMLPlugInImageElement.cpp:
        (WebCore::HTMLPlugInImageElement::updateWidgetCallback):
        * html/HTMLSummaryElement.cpp:
        (WebCore::HTMLSummaryElement::detailsElement):
        * html/HTMLSummaryElement.h:
        * html/HTMLTableCaptionElement.h:
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::caption):
        (WebCore::HTMLTableElement::tHead):
        (WebCore::HTMLTableElement::tFoot):
        (WebCore::HTMLTableElement::lastBody):
        * html/HTMLTableRowElement.cpp:
        (WebCore::HTMLTableRowElement::rowIndex):
        * html/HTMLTableSectionElement.h:
        * html/HTMLTagNames.in:
        * html/MediaDocument.cpp:
        (WebCore::MediaDocumentParser::createDocumentStructure):
        * html/shadow/DetailsMarkerControl.cpp:
        (WebCore::DetailsMarkerControl::summaryElement):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::handleFallbackContent):
        * loader/ImageLoader.cpp:
        (WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
        * page/DragController.cpp:
        (WebCore::DragController::canProcessDrag):
        * page/Frame.cpp:
        (WebCore::Frame::searchForLabelsBeforeElement):
        * page/SpatialNavigation.cpp:
        (WebCore::frameOwnerElement):

2949
2950
2951
2952
2953
2954
2955
2956
2957
2958
2959
2960
2961
2962
2963
2964
2965
2966
2967
2968
2969
2970
2971
2972
2973
2974
2975
2976
2977
2978
2979
2980
2981
2982
2983
2984
2985
2986
2013-11-20  Zoltan Horvath  <zoltan@webkit.org>

        Move LineWidth.{h,cpp} into rendering/line
        <https://webkit.org/b/124448>

        Reviewed by David Hyatt.

        In r159354 I introduced line directory. Now it's time to move the helper classes of RenderBlockLineLayout into 'line' subdirectory.

        No new tests, no behavior change.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.vcxproj/WebCore.vcxproj:
        * WebCore.vcxproj/WebCore.vcxproj.filters:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/line/LineWidth.cpp: Renamed from Source/WebCore/rendering/LineWidth.cpp.
        (WebCore::LineWidth::LineWidth):
        (WebCore::LineWidth::fitsOnLine):
        (WebCore::LineWidth::fitsOnLineIncludingExtraWidth):
        (WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
        (WebCore::LineWidth::updateAvailableWidth):
        (WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
        (WebCore::LineWidth::commit):
        (WebCore::LineWidth::applyOverhang):
        (WebCore::LineWidth::fitBelowFloats):
        (WebCore::LineWidth::setTrailingWhitespaceWidth):
        (WebCore::LineWidth::updateCurrentShapeSegment):
        (WebCore::LineWidth::computeAvailableWidthFromLeftAndRight):
        (WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):
        * rendering/line/LineWidth.h: Renamed from Source/WebCore/rendering/LineWidth.h.
        (WebCore::LineWidth::currentWidth):
        (WebCore::LineWidth::uncommittedWidth):
        (WebCore::LineWidth::committedWidth):
        (WebCore::LineWidth::availableWidth):
        (WebCore::LineWidth::addUncommittedWidth):
        (WebCore::LineWidth::shouldIndentText):

2987
2988
2989
2990
2991
2992
2993
2994
2995
2996
2997
2998
2999
2013-11-20  Brady Eidson  <beidson@apple.com>

        Alphabetization followup to r159567

        Reviewed by style-bot  :(

        * Modules/indexeddb/IDBDatabaseBackend.h:
        * Modules/indexeddb/IDBIndex.h:
        * Modules/indexeddb/IDBObjectStore.h:
        * Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
        * Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
        * inspector/InspectorIndexedDBAgent.cpp:

3000
3001
3002
3003
3004
3005
3006
3007
3008
3009
3010
3011
3012
3013
3014
3015
3016
3017
3018
3019
3020
3021
3022
3023
3024
3025
3026
2013-11-20  Brady Eidson  <beidson@apple.com>

        Rename IDBMetadata.h to IDBDatabaseMetadata.h
        https://bugs.webkit.org/show_bug.cgi?id=124668

        Reviewed by Dean Jackson.

        * GNUmakefile.list.am:
        * WebCore.xcodeproj/project.pbxproj:

        * Modules/indexeddb/IDBDatabase.h:
        * Modules/indexeddb/IDBDatabaseBackend.h:

        * Modules/indexeddb/IDBDatabaseMetadata.h: Renamed from Source/WebCore/Modules/indexeddb/IDBMetadata.h.
        (WebCore::IDBIndexMetadata::IDBIndexMetadata):
        (WebCore::IDBObjectStoreMetadata::IDBObjectStoreMetadata):
        (WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):

        * Modules/indexeddb/IDBIndex.h:
        * Modules/indexeddb/IDBObjectStore.h:
        * Modules/indexeddb/IDBServerConnection.h:
        * Modules/indexeddb/IDBTransaction.h:
        * Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
        * Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
        * Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.h:
        * inspector/InspectorIndexedDBAgent.cpp:

3027
3028
3029
3030
3031
3032
3033
3034
3035
3036
3037
3038
3039
3040
2013-11-20  Ryosuke Niwa  <rniwa@webkit.org>

        Remove bogus assertions in updateNameForTreeScope and updateNameForDocument
        https://bugs.webkit.org/show_bug.cgi?id=124639

        Reviewed by Darin Adler.

        Removed assertions. We can't assert that the element in a tree scope or a document
        since these two functions are called from removedFrom.

        * dom/Element.cpp:
        (WebCore::Element::updateNameForTreeScope):
        (WebCore::Element::updateNameForDocument):

3041
3042
3043
3044
3045
3046
3047
3048
3049
3050
3051
3052
3053
3054
3055
3056
3057
3058
3059
3060
3061
3062
3063
2013-11-20  Brady Eidson  <beidson@apple.com>

        Cleanup getOrEstablishIDBDatabaseMetadata and stub it out in WK2
        https://bugs.webkit.org/show_bug.cgi?id=124635

        Reviewed by Tim Horton.

        getOrEstablishIDBDatabaseMetadata() should not have to take a database name parameter because the 
        server connection should already know what database name it represents.

        * Modules/indexeddb/IDBDatabaseBackend.cpp:
        (WebCore::IDBDatabaseBackend::openInternalAsync):

        * Modules/indexeddb/IDBServerConnection.h:
        * Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
        (WebCore::IDBServerConnectionLevelDB::IDBServerConnectionLevelDB):
        (WebCore::IDBServerConnectionLevelDB::getOrEstablishIDBDatabaseMetadata):
        * Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:

        * Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
        (WebCore::IDBFactoryBackendLevelDB::deleteDatabase):
        (WebCore::IDBFactoryBackendLevelDB::open):

3064
3065
3066
3067
3068
3069
3070
3071
3072
3073
3074
3075
2013-11-20  Andrzej Badowski  <a.badowski@samsung.com>

        [EFL] <video> and <audio> should be accessible.
        https://bugs.webkit.org/show_bug.cgi?id=124494

        Reviewed by Gyuyoung Kim.

        Adding descriptions of media-element controls.

        * platform/efl/LocalizedStringsEfl.cpp:
        (WebCore::localizedMediaControlElementString):

3076
3077
3078
3079
3080
3081
3082
3083
3084
3085
3086
3087
3088
3089
3090
3091
3092
3093
3094
3095
3096
3097
3098
3099
3100
3101
3102
3103
3104
3105
3106
3107
3108
3109
3110
3111
3112
3113
3114
3115
3116
3117
3118
3119
3120
2013-11-20  Antti Koivisto  <antti@apple.com>

        Don't paint simple text runs outside the paint rect
        https://bugs.webkit.org/show_bug.cgi?id=124651

        Reviewed by Anders Carlsson.
        
        This speeds up partial paints for long text paragraphs. 
        Also add the same optimization for hit testing.

        * rendering/SimpleLineLayoutFunctions.cpp:
        (WebCore::SimpleLineLayout::paintFlow):
        
            Iterate over the run range that needs painting.

        (WebCore::SimpleLineLayout::hitTestFlow):
        
            Iterate over the line range that needs painting.

        * rendering/SimpleLineLayoutResolver.h:
        (WebCore::SimpleLineLayout::Range::Range):
        (WebCore::SimpleLineLayout::Range::begin):
        (WebCore::SimpleLineLayout::Range::end):
        
            Add Range type.

        (WebCore::SimpleLineLayout::RunResolver::Iterator::Iterator):
        (WebCore::SimpleLineLayout::RunResolver::Iterator::operator++):
        (WebCore::SimpleLineLayout::RunResolver::Iterator::advance):
        (WebCore::SimpleLineLayout::RunResolver::Iterator::advanceLines):
        
            Optimize case where runCount==lineCount. In this case we can just directly jump
            to the right run/line.

        (WebCore::SimpleLineLayout::RunResolver::begin):
        (WebCore::SimpleLineLayout::RunResolver::end):
        (WebCore::SimpleLineLayout::RunResolver::lineIndexForHeight):
        (WebCore::SimpleLineLayout::RunResolver::rangeForRect):
        
            Get the range corresponding to a rect. This currently cares about y coordinates only.

        (WebCore::SimpleLineLayout::LineResolver::Iterator::operator++):
        (WebCore::SimpleLineLayout::LineResolver::Iterator::operator*):
        (WebCore::SimpleLineLayout::LineResolver::rangeForRect):

3121
3122
3123
3124
3125
3126
3127
3128
3129
3130
3131
3132
3133
3134
3135
3136
3137
3138
2013-11-20  Antoine Quint  <graouts@apple.com>

        Cannot animate "points" attribute for <svg:polygon>
        https://bugs.webkit.org/show_bug.cgi?id=21371

        Reviewed by Antti Koivisto.

        Ensure we use animated list of points for SVG <polygon> and <polyline> elements
        when we build the path used to draw them, otherwise the animated changes won't
        be rendered and the base value will be used.

        Tests: svg/animations/polygon-set.svg
               svg/animations/polyline-set.svg

        * rendering/svg/SVGPathData.cpp:
        (WebCore::updatePathFromPolygonElement):
        (WebCore::updatePathFromPolylineElement):

3139
3140
3141
3142
3143
3144
3145
3146
3147
3148
3149
3150
3151
3152
3153
3154
3155
3156
3157
3158
3159
3160