ChangeLog 756 KB
Newer Older
mjs's avatar
WebKit:    
mjs committed
1
2
3
4
5
6
7
8
9
10
2002-11-13  Maciej Stachowiak  <mjs@apple.com>

	Pass mime type instead of full response to content policy delegate
	method, in preparation for merging it with the file URL policy.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:didReceiveResponse:]):

darin's avatar
darin committed
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
2002-11-13  Darin Adler  <darin@apple.com>

	- fixed 3083982 -- Logging into AOL gives null view

	Turns out AOL was using a refresh header, which we were not supporting.

        * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):
	Call openURL: and pass headers in.

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:isFormSubmission:]):
	Pass nil for headers in this case, since we know it's just an anchor change.

	- other things

        * WebCoreSupport.subproj/WebBridge.h: Remove dataSourceChanged and dataSource
	methods. We try to keep the bridge methods down to actual bridging.
        * WebCoreSupport.subproj/WebBridge.m: Remove dataSourceChanged altogether,
	and move dataSource up in the file.

        * WebView.subproj/WebHTMLRepresentation.m:
        (-[WebHTMLRepresentation setDataSource:]): Keep the data source around, so we
	don't need to ask the bridge for it.
        (-[WebHTMLRepresentation documentSource]): Use it here.

36
37
38
39
40
41
42
43
44
45
46
2002-11-13  Trey Matteson  <trey@apple.com>

	Fixed 3100084 - REGRESSION: web page is not first responder after visiting web page

        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _commitIfReady]):  Make the rep before _transitionToCommitted.  This is the way it used to be.
        (-[WebDataSource _makeRepresentation]):  Don't make the docView here.

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted]):  Make the docView here, after we save the scroll state but before notifying the delegate.

47
48
49
50
51
52
53
54
55
56
2002-11-13  Darin Adler  <darin@apple.com>

	- fixed 3100013 -- REGRESSION: Can't get results from i-Bench anymore

        * WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]):
	Don't set the state to WebFrameStateComplete if it has already been set
	to WebFrameStateProvisional. If it has, that means we already began a new
	load; that one is not yet complete.

2002-11-13  John Sullivan  <sullivan@apple.com>
57
58
59
60
61
62
63
64
65
66
67

	- fixed 3099922 -- REGRESSION: Back button always pops up menu

        * Misc.subproj/WebNSViewExtras.h:
        * Misc.subproj/WebNSViewExtras.m:
        (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]:
	Fixed a copy/paste error I made yesterday -- this method was never
	noticing the mouse-up events because it was checking the event type
	against the wrong number. Also changed the hysteresis values from
	unsigneds to floats (unsigned was just wrong).

mjs's avatar
mjs committed
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
2002-11-13  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3050447 - Policy handlers have no way of telling client
	that the proposed navigation is a form post

	Now we pass form submissions through all the normal policy steps.
	
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]):
        (-[WebBridge postWithURL:data:contentType:triggeringEvent:]):
        (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _setTriggeringAction:]):
        (-[WebDataSource _triggeringAction]):
        (-[WebDataSource _lastCheckedRequest]):
        (-[WebDataSource _setLastCheckedRequest:]):
        * WebView.subproj/WebFrame.m:
        (-[WebFrame setProvisionalDataSource:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _shouldShowRequest:]):
        (-[WebFrame _loadRequest:triggeringAction:]):
        (-[WebFrame _actionInformationForNavigationType:event:]):
        (-[WebFrame _continueAfterNavigationPolicyForRequest:dataSource:]):
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:isFormSubmission:]):
        (-[WebFrame _loadURL:intoChild:]):
        (-[WebFrame _postWithURL:data:contentType:triggeringEvent:]):

mjs's avatar
WebKit:    
mjs committed
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
2002-11-12  Maciej Stachowiak  <mjs@apple.com>

	Combine click policy and URL policy into navigation policy.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate navigationPolicyForAction:andRequest:inFrame:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _shouldShowRequest:]):
        (-[WebFrame _actionInformationForNavigationType:event:]):
        (-[WebFrame _continueAfterFileURLPolicyForRequest:]):
        (-[WebFrame _continueAfterNavigationPolicyForRequest:event:]):
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):

114
115
116
117
118
119
120
121
122
123
124
2002-11-12  Trey Matteson  <trey@apple.com>

	fixed 3096030 - Crash in -[WebBackForwardList goToEntry:] when playing with SnapBack and dictionary.com

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _isLoadComplete]):  Set state=completed only after we tell the bridge to
	end the load.  This allows client redirects to be processed before we think we're complete.
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):
	Only process client redirects as such if we are not already complete.  This makes JS driven
	navigations after load-time work like the user would expect, as normal navigations.

125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
2002-11-12  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3099487 - REGRESSION: dragging an image always puts it in
	the download directory
	
        * WebView.subproj/WebControllerPrivate.h:
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _downloadURL:]): Call _downloadURL:toPath: with nil path.
	(-[WebController _downloadURL:toPath:]): New method that
	predetermines the path to download to (needed for DnD).
        * WebView.subproj/WebHTMLView.m:
	(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use
	_downloadURL:toPath:
        * WebView.subproj/WebImageView.m:
	(-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): Use
	_downloadURL:toPath:
        * WebView.subproj/WebMainResourceClient.m:
	(-[WebMainResourceClient handle:didReceiveResponse:]): Don't ask
	delegate for download path if we already have one.

145
146
147
148
149
150
151
152
2002-11-12  Richard Williamson  <rjw@apple.com>

        Fixed likely cause of 3099047 (and others).  Width buffer could underrun in
        some situations.
        
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]):

sullivan's avatar
WebKit:    
sullivan committed
153
154
155
156
157
158
159
160
161
2002-11-12  John Sullivan  <sullivan@apple.com>

        * Misc.subproj/WebNSViewExtras.h:
        * Misc.subproj/WebNSViewExtras.m:
        (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]):
	new method
        (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:]):
	now calls the new method, passing the default hysteresis values

162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
2002-11-12  Richard Williamson  <rjw@apple.com>

        Implemented letter-spacing and word-spacing CSS properties.

        * Misc.subproj/WebStringTruncator.m:
        (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
        (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
        * WebCoreSupport.subproj/WebTextRenderer.h:
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer widthForCharacters:length:]):
        (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:letterSpacing:wordSpacing:]):
        (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]):
        (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]):
        (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:letterSpacing:wordSpacing:]):
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]):

mjs's avatar
WebKit:    
mjs committed
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
2002-11-12  Maciej Stachowiak  <mjs@apple.com>

	Removed policy classes and instead use the policy enums directly,
	since we no longer hold the path in the enum.
	
        * Downloads.subproj/WebDownloadHandler.m:
        * WebKit.exp:
        * WebKit.pbproj/project.pbxproj:
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebControllerPolicyDelegate.m:
        * WebView.subproj/WebControllerPolicyDelegatePrivate.h: Removed.
        * WebView.subproj/WebControllerPrivate.m:
        * WebView.subproj/WebDefaultPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (+[WebDefaultPolicyDelegate defaultURLPolicyForRequest:]):
        (-[WebDefaultPolicyDelegate URLPolicyForRequest:inFrame:]):
        (-[WebDefaultPolicyDelegate fileURLPolicyForMIMEType:andRequest:inFrame:]):
        (-[WebDefaultPolicyDelegate unableToImplementPolicy:error:forURL:inFrame:]):
        (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame handleUnimplementablePolicy:errorCode:forURL:]):
        (-[WebFrame _shouldShowRequest:]):
        (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:didReceiveResponse:]):

204
205
206
207
208
209
210
211
212
213
2002-11-12  Maciej Stachowiak  <mjs@apple.com>

	Keep the triggering event around on the data source, so it can be
	used with redirects.

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _loadRequest:triggeringEvent:]):
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):
        (-[WebFrame _postWithURL:data:contentType:]):

darin's avatar
darin committed
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
2002-11-12  Darin Adler  <darin@apple.com>

	- improved the code that manages observing the window and superview

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView addSuperviewObservers]): Added.
        (-[WebHTMLView removeSuperviewObservers]): Added.
        (-[WebHTMLView addWindowObservers]): Added.
        (-[WebHTMLView removeWindowObservers]): Added.
        (-[WebHTMLView viewWillMoveToSuperview:]): Call removeSuperviewObservers.
        (-[WebHTMLView viewDidMoveToSuperview]): Call addSuperviewObservers.
        (-[WebHTMLView viewWillMoveToWindow:]): Call removeWindowObservers and
	removeSuperviewObservers.
        (-[WebHTMLView viewDidMoveToWindow]): Call addWindowObservers and
	addSuperviewObservers.

mjs's avatar
WebKit:    
mjs committed
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
2002-11-11  Maciej Stachowiak  <mjs@apple.com>

	Remove contentPolicy parameter from _downloadURL, and remove
	remaining traces of path from policy object.

        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebControllerPolicyDelegate.m:
        (-[WebPolicyPrivate dealloc]):
        (+[WebURLPolicy webPolicyWithURLAction:]):
        (+[WebFileURLPolicy webPolicyWithFileAction:]):
        (+[WebContentPolicy webPolicyWithContentAction:]):
        (+[WebClickPolicy webPolicyWithClickAction:]):
        * WebView.subproj/WebControllerPolicyDelegatePrivate.h:
        * WebView.subproj/WebControllerPrivate.h:
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _downloadURL:]):
        * WebView.subproj/WebDefaultContextMenuDelegate.m:
        (-[WebDefaultContextMenuDelegate downloadURL:]):
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
        * WebView.subproj/WebImageView.m:
        (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]):
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:didReceiveResponse:]):

darin's avatar
darin committed
259
260
261
262
263
264
265
266
2002-11-11  Darin Adler  <darin@apple.com>

        * Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
        Use fileSystemRepresentationWithPath, not cString, to turn a path into something
        to pass to FSPathMakeRef.

        * English.lproj/StringsNotToBeLocalized.txt: Update.

darin's avatar
darin committed
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
2002-11-11  Darin Adler  <darin@apple.com>

	- tighten up cursor handling a bit more

        * WebView.subproj/WebDynamicScrollBarsView.m:
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView addMouseMovedObserver]): Call _frameOrBoundsChanged
	so we emit a mouse moved event right away.
        (-[WebHTMLView viewWillMoveToSuperview:]): Remove the colon since I
	removed the parameter from _frameOrBoundsChanged.

        * WebView.subproj/WebHTMLViewPrivate.h: Declare _frameOrBoundsChanged.
        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLView _frameOrBoundsChanged]): Remove parameter.

282
283
284
285
286
287
288
289
2002-11-11  Trey Matteson  <trey@apple.com>

        Fixed 3015884 - Reloading a page should remember the scroll position

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted]):  Save scroll position on reload
        (-[WebFrame _isLoadComplete]):  Restore position on reload

290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
2002-11-11  Trey Matteson  <trey@apple.com>

        * History.subproj/WebBackForwardList.m:
        (-[WebBackForwardList addEntry:]):  Yank code to avoid adding a duplicate entry, to catch the
	refresh case.  That's dealt with in WebFramePrivate now.
        (-[WebBackForwardList description]):  Enhanced to print more info.

        * History.subproj/WebHistoryItem.h:
	History items now hold an array of subitems to mirror the frame tree.  One item in the tree
	is designated the target of the navigation.
        * History.subproj/WebHistoryItem.m:
        (-[WebHistoryItem dealloc]):  Release new ivars.
        (-[WebHistoryItem isTargetItem]):
        (-[WebHistoryItem setIsTargetItem:]):
	New setter and setter.
        (-[WebHistoryItem _recurseToFindTargetItem]):
        (-[WebHistoryItem targetItem]):
	Search the tree to find the target item.
        (-[WebHistoryItem children]):
        (-[WebHistoryItem addChildItem:]):
        (-[WebHistoryItem childItemWithName:]):
	Maintain and search new child item list.
        (-[WebHistoryItem description]):
	Enhanced to print out the tree of items.
        (-[WebHistoryItem dictionaryRepresentation]):
        (-[WebHistoryItem initFromDictionaryRepresentation:]):
	Save and load the new state.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge generateFrameName]):  New call from KWQ, just forwards to Frame.
        (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
	Call new frame method dedicated to this case.
        (-[WebBridge saveDocumentState:]):
        (-[WebBridge documentState]):
	Call frame methods to get the right item to save/restore to/from.

        * WebView.subproj/WebController.m:
        (-[WebController _goToItem:withLoadType:]):  Stop any current loading before going to a new item.
        (-[WebController goBack]):
        (-[WebController goForward]):
        (-[WebController goBackOrForwardToItem:]):  Name change of private method (for consistency)

        * WebView.subproj/WebDataSourcePrivate.h:
	ProvisionalItem and PreviousItem are moved back up to WebFrame, where we know more about the
	state transitions that happen during loading.
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSourcePrivate dealloc]): Don't release removed ivars.
        (-[WebDataSource _commitIfReady]): Make the view representations -after- the transition to committed.
	This allows us to save away the scroll location successfully, since making the view was resetting it.
        * WebView.subproj/WebFrame.h:
        * WebView.subproj/WebFrame.m:
        (-[WebFrame setProvisionalDataSource:]):  Saving the scroll location has moved elsewhere to handle frames.
        (-[WebFrame stopLoading]):  Skip all the work if we're already state=complete.

        * WebView.subproj/WebFramePrivate.h:
	The frame now holds a ref to the current, previous and provisional back-forward items.
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFramePrivate dealloc]):  Release new state.
        (-[WebFramePrivate setProvisionalItem:]):
        (-[WebFramePrivate setPreviousItem:]):
        (-[WebFramePrivate setCurrentItem:]):	New setters (1 line getters were missed by script)
        (-[WebFrame _addBackForwardItemClippedAtTarget:]):  Adds a BF item to the top of the BF list.
        (-[WebFrame _createItem]):  Create a single BF item.
        (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):  Create a tree of BF items, which
	mirror the frame tree.
        (-[WebFrame _immediateChildFrameNamed:]):  New frame search utility (doesn't recurse)
        (-[WebFrame _detachFromParent]):  Save the scroll position when detaching a frame.
        (-[WebFrame _transitionToCommitted]):  Maintain new item ivars.  Save scroll position when
	appropriate.  Hook up items for child frames to their parent, as they are created.
        (-[WebFrame _setState:]):  Clear previousItem whenever we reach committed.
        (-[WebFrame _isLoadComplete]):  Clear previousItem if we are committed.
        (-[WebFrame _childFramesMatchItem:]):  Does the frame's frame tree match the one held by the item?
        (-[WebFrame _loadItem:fromItem:withLoadType:]):  Only do simple anchor navigation if the frame
	has no children (fixes oddball corner case with a frame reloading itself).  Set provisional item.
        (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):  Heart of returning to an item that had
	frames.  We either find that the existing content is good, or initiate a load.
        (-[WebFrame _goToItem:withLoadType:]):  Adjust the BF list cursor, and recurse to do the work.
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):  Only do anchor-style nav if
	the destination URL has a fragment.  Save scroll position.
        (-[WebFrame _loadURL:intoChild:]):  If returning to an item with frames, possibly replace the
	new content with the stuff that was there at the time, substituting the URL.
        (-[WebFrame _saveScrollPositionToItem:]):  Don't croak on nil item or view.
        (-[WebFrame _restoreScrollPosition]):  Do croak (ASSERT) on nil item.
        (-[WebFrame _scrollToTop]):  Nit cleanup.
        (-[WebFrame _addFramePathToString:]):  Add a component for our frame to the frame name we're generating.
        (-[WebFrame _generateFrameName]):  Generate a frame name that is repeatable.
        (-[WebFrame _itemForSavingDocState]):  Returns correct item to use for formstate save.
        (-[WebFrame _itemForRestoringDocState]):  Returns correct item to use for formstate restore

mjs's avatar
WebKit:    
mjs committed
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
2002-11-11  Maciej Stachowiak  <mjs@apple.com>

	Store path and the fact that we're downloading in the data source,
	instead of storing the content policy.
	
        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler cleanUpAfterFailure]):
        (-[WebDownloadHandler createFileIfNecessary]):
        (-[WebDownloadHandler finishedLoading]):
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _downloadURL:withContentPolicy:]):
        * WebView.subproj/WebDataSource.h:
        * WebView.subproj/WebDataSource.m:
        (+[WebDataSource registerRepresentationClass:forMIMEType:]):
        (-[WebDataSource isDownloading]):
        (-[WebDataSource downloadPath]):
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _commitIfReady]):
        (-[WebDataSource _setIsDownloading:]):
        (-[WebDataSource _setDownloadPath:]):
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient receivedError:]):
        (-[WebMainResourceClient handle:didReceiveResponse:]):
        (-[WebMainResourceClient handleDidFinishLoading:]):

mjs's avatar
WebKit:    
mjs committed
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
2002-11-11  Maciej Stachowiak  <mjs@apple.com>

	Don't ask for the content policy any more if the previous policies
	said to save - in effect this means to ask only if the previous
	policies said to use the content policy. Also, remove now-useless
	previous content policy parameter from content policy delegate.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
	(-[WebDataSource _setContentPolicy:]): Retain new policy before
	releasing the old one.
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        * WebView.subproj/WebMainResourceClient.m:
	(-[WebMainResourceClient handle:didReceiveResponse:]): Don't ask
	for content policy if the delegate already decided to save.

mjs's avatar
WebKit:    
mjs committed
422
423
424
425
426
427
428
429
430
431
432
2002-11-11  Maciej Stachowiak  <mjs@apple.com>

	Added new policy delegate callback to get the filename - this
	won't be up to the content policy any more.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate saveFilenameForResponse:andRequest:]):
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:didReceiveResponse:]):

darin's avatar
darin committed
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
2002-11-11  Darin Adler  <darin@apple.com>

	- made some improvements to cursor setting for greater speed and correctness

        * WebView.subproj/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView setCursor:]): Just use setDocumentCursor: instead of
	our own logic. This allows us to remove code and may fix some bugs or anomalies as well.
        (-[WebDynamicScrollBarsView dealloc]): Release the cursor. I think we were leaking before.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView viewWillMoveToSuperview:]): Use _frameOrBoundsChanged: method now, which
	has been moved into the private file.
        (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Don't bother finding
	topmost WebHTMLView to call _updateMouseoverWithEvent: on; now it works fine no matter
	which level it's called at.

        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLView _frameOrBoundsChanged:]): Moved the code here that was formerly in the
	_setNeedsLayoutIfSizeChanged method, also added code that does _updateMouseoverWithEvent:
	so that we get properly updated cursor when we scroll.
        (-[WebHTMLView _updateMouseoverWithEvent:]): Remove unneeded assert. This method works
	equally well no matter which WebHTMLView calls it; everything is done at the window and
	controller level.

        * WebView.subproj/WebControllerPrivate.h: Added lastElementWasNotNil field and
	_mouseDidMoveOverElement:modifierFlags: method.
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _mouseDidMoveOverElement:modifierFlags:]): Call through to the delegate,
	but don't do multiple calls if they are all nil.

        * WebCoreSupport.subproj/WebBridge.m: Remove unused modifierTrackingEnabled method.
        * WebView.subproj/WebHTMLViewPrivate.h: Remove unused _setModifierTrackingEnabled and
	_modifierTrackingEnabled methods.

darin's avatar
darin committed
467
468
469
470
2002-11-10  Darin Adler  <darin@apple.com>

        * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

cblu's avatar
cblu committed
471
472
473
474
475
476
477
478
479
2002-11-10  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3021681 - downloaded files' creation and modification dates are not set

        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler createFileIfNecessary]): call [response creationDate] and [response lastModifiedDate] when setting file attributes.
        * Plugins.subproj/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream setResponse:]): call [response lastModifiedDate] when giving content to plug-ins.

480
481
482
483
2002-11-10  Darin Adler  <darin@apple.com>

        * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
2002-11-09  Darin Adler  <darin@apple.com>

	- fixed 3095156 -- reproducible leak of WebDataSource due to bad URL in stylesheet

        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
	Check for errors by looking at the return value from loadWithRequest: rather than
	making a separate call to canInitWithRequest.

        * WebView.subproj/WebBaseResourceHandleDelegate.h: Add boolean success/failure result
	loadWithRequest:.
        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate loadWithRequest:]): Return NO if we fail to make a handle.

        * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]):
	Check result of loadWithRequest: and complain if it's NO.

        * WebView.subproj/WebMainResourceClient.m: Tweak whitespace.

cblu's avatar
WebKit:    
cblu committed
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
2002-11-09  Chris Blumenberg  <cblu@apple.com>

	Fixed: 2991610 - Alexander should support services, including Speech

        * WebView.subproj/WebHTMLView.m:
        (+[WebHTMLView initialize]): register for service types
        (-[WebHTMLView dealloc]): moved to top of file
        (-[WebHTMLView copy:]): call _writeSelectionToPasteboard
        (-[WebHTMLView writeSelectionToPasteboard:types:]): call _writeSelectionToPasteboard
        (-[WebHTMLView validRequestorForSendType:returnType:]): return self for our pboard types
        * WebView.subproj/WebHTMLViewPrivate.h:
        * WebView.subproj/WebHTMLViewPrivate.m:
        (+[WebHTMLView _pasteboardTypes]): new, returns the array of supported pboard types 
        (-[WebHTMLView _writeSelectionToPasteboard:]): new, adds data to pboard
        * WebView.subproj/WebImageView.m:
        (-[WebImageView initialize]): register for service types
        (-[WebImageView validateUserInterfaceItem:]): respond to copy
        (-[WebImageView validRequestorForSendType:returnType:]): return self for images
        (-[WebImageView writeImageToPasteboard:]): writes image data to pboard
        (-[WebImageView copy:]): calls writeImageToPasteboard
        (-[WebImageView writeSelectionToPasteboard:types:]): calls writeImageToPasteboard

darin's avatar
darin committed
525
526
527
528
529
530
531
532
2002-11-08  Darin Adler  <darin@apple.com>

        * History.subproj/WebHistoryItem.m:
        (-[WebHistoryItem setTitle:]): Use display title if it matches, so
	we don't end up with two identical strings, as when reading from
	the property list.
        (-[WebHistoryItem setDisplayTitle:]): The same thing, the other way round.

533
534
535
536
537
538
539
540
541
542
2002-11-08  Darin Adler  <darin@apple.com>

	- fixed 3095078 -- image loop counts still not handled right

        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer blockHasGIFExtensionSignature:length:]): Look for the tag
	"NETSCAPE2.0", not "NETSCAPE1.0".
        (-[WebImageRenderer nextFrame:]): Remove special handling for last frames with
	a duration of 0. That was just a misunderstanding.

543
544
545
546
547
2002-11-08  Darin Adler  <darin@apple.com>

        * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]):
	Slightly better fix. Essentially just take out the assert.

darin's avatar
darin committed
548
549
550
551
552
553
2002-11-08  Darin Adler  <darin@apple.com>

	- fixed an assert I am seeing a lot

        * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]): Oops.

554
555
556
557
558
559
560
561
562
563
564
2002-11-08  Richard Williamson   <rjw@apple.com>

        Solved missing glyph problem, but it's very slow, so
        it's disabled for now.  I'll turn back on after extending
        the character to glyph map in each renderer to include
        substituted font.
        
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer substituteFontForString:]):
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
2002-11-08  Darin Adler  <darin@apple.com>

	- separate WebBaseNetscapePluginStream more cleanly from its subclasses
	by making most fields private

        * Plugins.subproj/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream setResponse:]):
        * Plugins.subproj/WebNetscapePluginStream.h:
        * Plugins.subproj/WebNetscapePluginStream.m:
        (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]):
        (-[WebNetscapePluginStream dealloc]):
        (-[WebNetscapePluginStream start]):
        (-[WebNetscapePluginStream handle:didReceiveData:]):
        (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (-[WebSubresourceClient handle:didReceiveResponse:]):
        (-[WebSubresourceClient handle:didReceiveData:]):
        (-[WebSubresourceClient handleDidFinishLoading:]):
        (-[WebSubresourceClient handle:didFailLoadingWithError:]):
        (-[WebSubresourceClient cancel]):
        * WebView.subproj/WebBaseResourceHandleDelegate.h:
        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):
        (-[WebBaseResourceHandleDelegate handle:didFailLoadingWithError:]):
        (-[WebBaseResourceHandleDelegate _cancelWithError:]):
        (-[WebBaseResourceHandleDelegate cancel]):
        (-[WebBaseResourceHandleDelegate cancelQuietly]):
        (-[WebBaseResourceHandleDelegate cancelledError]):
        (-[WebBaseResourceHandleDelegate notifyDelegatesOfInterruptionByPolicyChange]):
        * WebView.subproj/WebMainResourceClient.h:
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient cancel]):
        (-[WebMainResourceClient handle:willSendRequest:]):
        (-[WebMainResourceClient notifyDelegatesOfInterruptionByPolicyChange]):
        (-[WebMainResourceClient handle:didReceiveResponse:]):
        (-[WebMainResourceClient handle:didReceiveData:]):
        (-[WebMainResourceClient handleDidFinishLoading:]):

darin's avatar
Tools:    
darin committed
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
2002-11-08  Darin Adler  <darin@apple.com>

	- changed persistent dictionaries to use NSString instead of NSURL
	because of impact on memory footprint

	Also changed WebIconDatabase code to verify what it reads from disk,
	and ignore it if it can't verify the format.

        * Misc.subproj/WebIconDatabase.m:
        (-[WebIconDatabase iconForSiteURL:withSize:cache:]):
        (-[WebIconDatabase retainIconForSiteURL:]):
        (-[WebIconDatabase releaseIconForSiteURL:]):
        (-[WebIconDatabase _iconDictionariesAreGood]):
        (-[WebIconDatabase _loadIconDictionaries]):
        (-[WebIconDatabase _updateFileDatabase]):
        (-[WebIconDatabase _hasIconForSiteURL:]):
        (-[WebIconDatabase _iconsForIconURLString:]):
        (-[WebIconDatabase _setIcon:forIconURL:]):
        (-[WebIconDatabase _setIconURL:forSiteURL:]):
        (-[WebIconDatabase _setBuiltInIconAtPath:forHost:]):
        (-[WebIconDatabase _retainIconForIconURLString:]):
        (-[WebIconDatabase _releaseIconForIconURLString:]):
        (-[WebIconDatabase _retainFutureIconForSiteURL:]):
        (-[WebIconDatabase _releaseFutureIconForSiteURL:]):
        (-[WebIconDatabase _retainOriginalIconsOnDisk]):
        (-[WebIconDatabase _releaseOriginalIconsOnDisk]):
        (-[NSEnumerator _web_isAllStrings]):
        * Panels.subproj/WebStandardPanels.m:
        (-[WebStandardPanels didStartLoadingURL:inWindow:]):
        (-[WebStandardPanels didStopLoadingURL:inWindow:]):
        (-[WebStandardPanels _didStartLoadingURL:inController:]):
        (-[WebStandardPanels _didStopLoadingURL:inController:]):
        (-[WebStandardPanels frontmostWindowLoadingURL:]):

637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
2002-11-08  Darin Adler  <darin@apple.com>

	- fixed crash on boot that Don was seeing

        * History.subproj/WebHistoryItem.m:
        (-[WebHistoryItem URL]): Make this work when _URLString is nil.
        (-[WebHistoryItem initFromDictionaryRepresentation:]): Make this work for nil URL.

	- my own private war on the cString method

        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler initWithDataSource:]): Use %@ in LOG to avoid cString.
        (-[WebDownloadHandler finishedLoading]): Ditto.
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _commitIfReady]): Ditto.
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _timedLayout:]): Ditto.
        (-[WebFrame _setState:]): More of the same.
        (-[WebFrame _isLoadComplete]): Ditto.

657
658
659
660
661
662
663
664
665
2002-11-08  Ken Kocienda  <kocienda@apple.com>

	Fix deployment build breaker: a variable was used only in a 
	LOG statement, causing the variable to become usused when
	building with the Deployment build style. 

        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler finishedLoading])

666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
2002-11-07  Darin Adler  <darin@apple.com>

        * History.subproj/WebHistoryItem.h: Replace _URL with _URLString.

        * History.subproj/WebHistoryItem.m:
        (-[WebHistoryItem _retainIconInDatabase:]): Get the URL with [self URL].
        (-[WebHistoryItem initWithURL:target:parent:title:]): Set up _URLString.
        (-[WebHistoryItem dealloc]): Release _URLString.
        (-[WebHistoryItem URL]): Make a URL from _URLString.
        (-[WebHistoryItem icon]): Use [self URL] instead of _URL.
        (-[WebHistoryItem setURL:]): Store a URL string.
        (-[WebHistoryItem hash]): Use the URL string's hash.
        (-[WebHistoryItem isEqual:]): Compare the URL strings.
        (-[WebHistoryItem description]): Use _URLString.
        (-[WebHistoryItem dictionaryRepresentation]): Use _URLString.
        (-[WebHistoryItem initFromDictionaryRepresentation:]): Call through to
	the other init functions so we have only one designated initializer.
	Leave the date as nil if there's no date in the dictionary instead of
	setting the date to 0.

mjs's avatar
WebKit:    
mjs committed
686
687
688
689
690
691
692
693
694
695
696
697
698
699
2002-11-07  Maciej Stachowiak  <mjs@apple.com>

	Removed SaveAndOpenExternally policy.
	
        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler finishedLoading]):
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient receivedError:]):
        (-[WebMainResourceClient handle:didReceiveResponse:]):
        (-[WebMainResourceClient handleDidFinishLoading:]):

cblu's avatar
WebKit:    
cblu committed
700
701
702
703
2002-11-07  Chris Blumenberg  <cblu@apple.com>

        * WebKit.pbproj/project.pbxproj:

rjw's avatar
rjw committed
704
705
706
707
708
2002-11-07  Richard Williamson  <rjw@apple.com>

        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer stopAnimation]):

709
710
711
712
713
714
715
716
717
718
2002-11-07  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3095628 - REGRESSION: exception when clicking on link to load content into iframe
	
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _actionInformationForNavigationType:event:]): Get the
	element info from the HTML view where the click originally
	happened, not the current document view. Add some asserts to make
	sure this is working.

719
720
721

2002-11-07  Richard Williamson  <rjw@apple.com>

rjw's avatar
rjw committed
722
723
        Tweaks
        
724
725
726
727
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer convertCharacters:length:toGlyphs:skipControlCharacters:]):
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

sheridan's avatar
sheridan committed
728
729
=== Alexander-31 ===

730
731
732
733
734
735
736
737
738
739
740
2002-11-07  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3094778 - REGRESSION: Assert on logout from schwab.com

	(probably fixed it anyway - I'm flying blind on this one)
	
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge createWindowWithURL:frameName:]): Use a nil request
	if the URL was nil, instead of making a request that contains a
	nil URL.

mjs's avatar
WebKit:    
mjs committed
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
2002-11-07  Maciej Stachowiak  <mjs@apple.com>

	Changed things so that creating a window takes a request rather
	than a URL and referrer.
	
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge createWindowWithURL:frameName:]):
        * WebView.subproj/WebControllerPrivate.h:
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _openNewWindowWithRequest:behind:]):
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _setTriggeringEvent:]):
        (-[WebDataSource _triggeringEvent]):
        * WebView.subproj/WebDefaultContextMenuDelegate.m:
        (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
        * WebView.subproj/WebFrame.m:
        (-[WebFrame setProvisionalDataSource:]):
        (-[WebFrame findOrCreateFramedNamed:]):
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
        * WebView.subproj/WebWindowOperationsDelegate.h:

765
766
767
768
769
770
771
772
773
774
775
776
2002-11-06  Darin Adler  <darin@apple.com>

	- fixed problem where files small enough to fit entirely in the buffer
	(8K or less) would not be decoded

        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler decodeData:]): Added. Moved most of the code from
	receivedData into here.
        (-[WebDownloadHandler receivedData:]): Changed to call decodeData.
        (-[WebDownloadHandler finishedLoading]): Call decodeData on any remaining
	bytes rather than writing them straight out to the data fork.

777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
2002-11-06  Richard Williamson  <rjw@apple.com>

        More work on rendering scripts. Now most complex scripts render correctly.
        Working new features include:
        bidi, diacriticals, cursive forms, and arabic ligatures.
        Selection of text rendered in these scripts, is however, not working. 
        Also, line height is incorrect when renderering combined below glyphs.
        ajami is, sadly, horrendously broken.

        * Misc.subproj/WebUnicode.m:
        (glyphVariantLogical):
        (shapedString):
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]):
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

sullivan's avatar
WebKit:    
sullivan committed
793
794
795
796
797
798
2002-11-06  John Sullivan  <sullivan@apple.com>

        * Bookmarks.subproj/WebBookmark.m:
        (+[WebBookmark bookmarkOfType:]):
	made this handle WebBookmarkTypeProxy

799
800
801
802
803
804
805
806
807
808
809
2002-11-06  Darin Adler  <darin@apple.com>

	- fixed bug that affected BinHex-encoded files with no resource fork

        * Downloads.subproj/WebBinHexDecoder.m:
        (-[WebBinHexDecoder decodeData:dataForkData:resourceForkData:]):
	Don't decode the resource fork unless done with the data fork.

        * Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedData:]):
	Set the forks to nil before calling through.

810
811
812
813
814
815
816
2002-11-06  Darin Adler  <darin@apple.com>

        * Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]):
	Fix == 129 check that was supposed to be <= 129.

        * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

817
818
819
820
821
822
823
2002-11-06  Darin Adler  <darin@apple.com>

        * Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeIntoBuffer:size:]):
	Fix an off-by-one error handling repeat counts.

        * WebKit.pbproj/project.pbxproj: Fix group name I accidentally mangled.

824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
2002-11-06  Darin Adler  <darin@apple.com>

	- added a BinHex decoder and did a little work on the MacBinary decoder
        
        I'm not supposed to be working on this, but I didn't feel like doing "real" work.

        * Downloads.subproj/WebBinHexDecoder.h: Added.
        * Downloads.subproj/WebBinHexDecoder.m: Added.
        * WebKit.pbproj/project.pbxproj: Added WebBinHexDecoder.

        * Downloads.subproj/WebDownloadDecoder.h: Added WEB_DOWNLOAD_DECODER_MINIMUM_HEADER_LENGTH.
        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler closeFile]): Check to be sure we don't close the same file twice.

        * Downloads.subproj/WebMacBinaryDecoder.h: Added _scriptCode.
        * Downloads.subproj/WebMacBinaryDecoder.m:
        (+[WebMacBinaryDecoder canDecodeHeaderData:]): Added check of MacBinary version field.
        (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Added MacBinary III
	part that gets the script code.
        (-[WebMacBinaryDecoder filename]): Use the script code.

mjs's avatar
WebKit:    
mjs committed
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
2002-11-06  Maciej Stachowiak  <mjs@apple.com>

	Took URL field out of click policy - open in new window policy
	will always open the request URL.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebControllerPolicyDelegate.m:
        (-[WebPolicyPrivate dealloc]):
        (+[WebURLPolicy webPolicyWithURLAction:]):
        (+[WebFileURLPolicy webPolicyWithFileAction:]):
        (+[WebContentPolicy webPolicyWithContentAction:andPath:]):
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueAfterClickPolicyForEvent:request:]):

861
862
863
864
865
866
867
2002-11-06  Chris Blumenberg  <cblu@apple.com>

	Support MacBinary I by checking that bytes 99-127 are 0. Also check byte 82 for all formats.

        * Downloads.subproj/WebMacBinaryDecoder.m:
        (+[WebMacBinaryDecoder canDecodeHeaderData:]):

kocienda's avatar
kocienda committed
868
869
870
871
872
873
874
875
876
877
878
879
2002-11-06  Ken Kocienda  <kocienda@apple.com>

	Call new WebHTTPResourceRequest method to set the amount of time
	to cache a 404 response when trying to fetch a favicon.

	This change helps to fix this bug:

	Radar 3004422 (Loader should cache misses)

        * Misc.subproj/WebIconLoader.m:
        (-[WebIconLoader startLoading])

mjs's avatar
WebKit:    
mjs committed
880
881
882
883
884
885
886
887
888
889
890
891
892
893
2002-11-05  Maciej Stachowiak  <mjs@apple.com>

	Reworked clickPolicy arguments to be closer to proposed version.
	
        * WebKit.exp:
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebControllerPolicyDelegate.m:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _actionInformationForNavigationType:event:]):
        (-[WebFrame _continueAfterClickPolicyForEvent:request:]):

894
895
896
897
898
2002-11-05  Darin Adler  <darin@apple.com>

        * WebCoreSupport.subproj/WebTextRenderer.m: Made a slightly simpler and faster
	version of the new "lose precision" CEIL_TO_INT macro.

899
900
901
902
903
904
905
906
907
908
909
2002-11-05  Richard Williamson  <rjw@apple.com>

        Fixed a couple of issues that Dave highlighted w/ his whitespace
        fixes.  CG sometimes introduces very small 'error' in metrics, specifically
        we saw character widths of 20.0000019 that should have been 20.  As a 
        work-around we loose precision beyond the 1000th place.  Also, always
        ceil spaces.
                
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

910
911
912
913
914
915
916
917
918
2002-11-05  Darin Adler  <darin@apple.com>

	- fixed 3084704 -- crash in HTMLTokenizer on page with JavaScript
	HTMLDocument::Close inside a <script>

        * WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]):
	We need to stop loading here. Otherwise we might do loading after closeURL,
	which could lead to a problem like the one above.

919
920
921
922
923
924
925
926
927
928
929
930
931
932
2002-11-05  Darin Adler  <darin@apple.com>

	- changed our MacBinary decoding to not pay any attention to the comment

	Before we would "fail to decode" if the comment was truncated, now we just
	don't worry about it.

        * Downloads.subproj/WebMacBinaryDecoder.h: Remove _commentLength and _commentEnd.
        * Downloads.subproj/WebMacBinaryDecoder.m:
        (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Remove code
	to get _commentLength and code to compute _commentEnd.
        (-[WebMacBinaryDecoder finishDecoding]): Check offset against the resource fork
	end rather than the comment end to see if we got enough data.

sullivan's avatar
WebKit:    
sullivan committed
933
934
935
936
937
938
939
2002-11-05  John Sullivan  <sullivan@apple.com>

        * Resources/url_icon.tiff:
	reverted generic URL icon back to the one that
	looks like a document until we get something from
	HI that SJ likes

cblu's avatar
WebKit:    
cblu committed
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
2002-11-05  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3074108 - Decode macbinary files during download

        * Downloads.subproj/WebDownloadDecoder.h:
        * Downloads.subproj/WebDownloadHandler.h:
        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler initWithDataSource:]):
        (-[WebDownloadHandler dealloc]):
        (-[WebDownloadHandler decodeHeaderData:dataForkData:resourceForkData:]):
        (-[WebDownloadHandler decodeData:dataForkData:resourceForkData:]):
        (-[WebDownloadHandler closeFile]):
        (-[WebDownloadHandler cleanUpAfterFailure]):
        (-[WebDownloadHandler createFileIfNecessary]):
        (-[WebDownloadHandler writeData:toFork:]):
        (-[WebDownloadHandler writeDataForkData:resourceForkData:]):
        (-[WebDownloadHandler dataIfDoneBufferingData:]):
        (-[WebDownloadHandler receivedData:]):
        (-[WebDownloadHandler finishDecoding]):
        (-[WebDownloadHandler finishedLoading]):
        (-[WebDownloadHandler cancel]):
        * Downloads.subproj/WebMacBinaryDecoder.h:
        * Downloads.subproj/WebMacBinaryDecoder.m:
        (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]):
        (-[WebMacBinaryDecoder fileAttributes]):
        (-[WebMacBinaryDecoder filename]):
        * Misc.subproj/WebKitErrors.h: added new errors
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:didReceiveResponse:]): don't send response to download handler
        (-[WebMainResourceClient handle:didReceiveData:]): watch for decoding errors

kocienda's avatar
kocienda committed
971
972
973
974
975
976
977
978
979
980
981
982
983
2002-11-05  Ken Kocienda  <kocienda@apple.com>

	Fix for this bug:

	Radar 3092747 (javascript cookieEnabled property returns incorrect value)

	Now, we return "true" for navigator.cookieEnabled when 
	"Only accept cookies from the same domain as the current page" option
	is selected is user preferences.

        * WebCoreSupport.subproj/WebCookieAdapter.m:
        (-[WebCookieAdapter cookiesEnabled])

sullivan's avatar
WebKit:    
sullivan committed
984
985
986
987
988
989
990
991
2002-11-05  John Sullivan  <sullivan@apple.com>

	- fixed 3091271 -- missing plug-in icon is on white
	background, not transparent.

        * Resources/nullplugin.tiff: Photoshopped the white away. It's
	still ugly, but that's a separate bug (3091274)

992
993
994
995
996
997
998
999
1000
1001
2002-11-05  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3083732 - SJ: window comes out blank on samsung site
	
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
	Don't start loading if the URL is exactly the same as the parent
	URL. We may need a more stringent check, but this seems to match
	the tolerance of other browsers OK.

mjs's avatar
WebKit:    
mjs committed
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
2002-11-05  Maciej Stachowiak  <mjs@apple.com>

	Added request and frame to click policy callback.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate clickPolicyForElement:button:modifierFlags:request:inFrame:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):

1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
2002-11-04  Richard Williamson  <rjw@apple.com>

        Changes to support cursive letter forms.  It works, but I've
        disabled it for now.  It's buggy and needs cleanup.
        Arabic now renders correctly except for ligature substitution.
        
        * Misc.subproj/WebUnicode.h:
        * Misc.subproj/WebUnicode.m:
        (_unicodeIsMark):
        (getShape):
        (prevChar):
        (nextChar):
        (prevLogicalCharJoins):
        (nextLogicalCharJoins):
        (glyphVariantLogical):
        (shapedString):
        * Misc.subproj/WebUnicodeTables.m:
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]):
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):
        * WebKitPrefix.h:

1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
2002-11-04  Maciej Stachowiak  <mjs@apple.com>

	Changes to send NSEvents all the way through WebCore and then pass
	them back out to WebKit, so that click policy can have a
	WebResourceRequest added.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge loadURL:reload:triggeringEvent:]):
        (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueAfterClickPolicyForEvent:]):
        (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView mouseUp:]):
        * WebView.subproj/WebHTMLViewPrivate.h:
        * WebView.subproj/WebHTMLViewPrivate.m:

1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
2002-11-04  Chris Blumenberg  <cblu@apple.com>

	Fixed - 3091658: REGRESSION: cmd-left for back doesn't work in plain-text viewer

	We now pass text field key events to the next responder which would be WebView in this case.

        * WebView.subproj/WebTextView.m:
        (-[WebTextView keyDown:]):
        (-[WebTextView keyUp:]):

1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
2002-11-04  Darin Adler  <darin@apple.com>

	- fixed 3090257 -- "leak the world" using the Wallace and Gromit "console"

        * Plugins.subproj/WebNetscapePluginStream.m: Update for changes to the base delegate.
        (-[WebNetscapePluginStream start]): Use loadWithRequest:.
        (-[WebNetscapePluginStream stop]): Call cancel instead of just canceling the handle
	directly. This fixes the world leak.
        (-[WebNetscapePluginStream cancel]): Do some of the work that was formerly in "stop".

        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:willSendRequest:]): Call the "stop loading URL" whenever
	we cancel I/O, so we don't leak the world.
        (-[WebMainResourceClient handle:didReceiveResponse:]): Ditto.

        * WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:response:size:]):
        * WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:]):
        * WebView.subproj/WebControllerPrivate.h:
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _finishedLoadingResourceFromDataSource:]):
	Fix a typo in the word "finished".

        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): Tweak.
        (-[WebBaseResourceHandleDelegate cancel]): Tweak.

        * Panels.subproj/WebStandardPanels.m:
        (-[WebStandardPanels didStartLoadingURL:inWindow:]): Add assertions.
        (-[WebStandardPanels didStopLoadingURL:inWindow:]): Ditto.
        (-[WebStandardPanels _didStartLoadingURL:inController:]): Ditto.
        (-[WebStandardPanels _didStopLoadingURL:inController:]): Ditto.

1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
2002-11-04  Darin Adler  <darin@apple.com>

        * Downloads.subproj/WebMacBinaryDecoder.h: Removed many unneeded fields.
        * Downloads.subproj/WebMacBinaryDecoder.m:
        (+[WebMacBinaryDecoder canDecodeHeaderData:]): Added comments. Changed maximum filename
	length to 63 as the format supports, rather than the 31 that's based on historical
	HFS limitations. Fix endian dependency in CRC check.
        (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Simplified this,
	and removed the state machine and the accumulator. Also added some asserts. Fixed endian
	dependency in the code to extract the header.
        (-[WebMacBinaryDecoder finishDecoding]): New simpler check now that we don't have a
	_streamComplete boolean.
        (-[WebMacBinaryDecoder fileAttributes]): Rewrote to take advantage of the above changes,
	and also to use kCFAbsoluteTimeIntervalSince1904 rather than parsing a date string.

        * Downloads.subproj/crc16.h: Tweaks.
        * Downloads.subproj/crc16.m: Tweaks.

darin's avatar
WebKit:    
darin committed
1114
1115
1116
1117
1118
2002-11-04  Darin Adler  <darin@apple.com>

        * WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer dealloc]):
	Replaced a useless call to stopAnimation with a couple of asserts.

sullivan's avatar
WebKit:    
sullivan committed
1119
1120
1121
1122
1123
1124
2002-11-04  John Sullivan  <sullivan@apple.com>

        * Resources/url_icon.tiff:
	new "generic URL" icon from HI -- this one looks like
	a red ribbon (!)

darin's avatar
WebKit:    
darin committed
1125
1126
1127
1128
1129
1130
2002-11-03  Darin Adler  <darin@apple.com>

        * Plugins.subproj/WebPluginError.h:
        * Plugins.subproj/WebPluginError.m:
	Not __MyCompanyName__, but rather Apple Computer.

darin's avatar
darin committed
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
2002-11-03  Darin Adler  <darin@apple.com>

        * Plugins.subproj/WebPlugin.h: Fix comment.

        * Plugins.subproj/WebPluginError.m: (-[WebPluginErrorPrivate dealloc]):
	Fix leak by calling [super dealloc].

        * WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): Remove the
	timer invalidate since, as Trey pointed out, it's pointless to invalidate a
	timer in dealloc if it's retaining this object while valid.

cblu's avatar
WebKit:    
cblu committed
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
2002-11-03  Chris Blumenberg  <cblu@apple.com>

	- Added MacBinary decoding code. Not yet used.

        * Downloads.subproj/WebMacBinaryDecoder.h: Added.
        * Downloads.subproj/WebMacBinaryDecoder.m: Added.
        (+[WebMacBinaryDecoder canDecodeHeaderData:]):
        (-[WebMacBinaryDecoder init]):
        (-[WebMacBinaryDecoder dealloc]):
        (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]):
        (-[WebMacBinaryDecoder finishDecoding]):
        (-[WebMacBinaryDecoder fileAttributes]):
        * Downloads.subproj/crc16.h: Added.
        * Downloads.subproj/crc16.m: Added.
        (CRC16):
        * Plugins.subproj/WebPluginPackage.m:
        (-[WebPluginPackage isLoaded]): 
        * WebKit.pbproj/project.pbxproj:

darin's avatar
Tools:    
darin committed
1161
1162
1163
1164
1165
2002-11-03  Darin Adler  <darin@apple.com>

        * English.lproj/StringsNotToBeLocalized.txt: Update for recent
	changes both to the code here and to the extract script.

darin's avatar
darin committed
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
2002-11-03  Darin Adler  <darin@apple.com>

	- fixed 3091300 -- "prelighting" on local page is still slow, despite recent bug fix

	Turns out all updating would be slow if any resources on the page failed to load.

        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
	Call the new reportError instead of cancel.
        (-[WebSubresourceClient handle:didFailLoadingWithError:]): Ditto.

1177
1178
1179
1180
1181
2002-11-02  Darin Adler  <darin@apple.com>

        * Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]):
	Do the previous fix one better by using _web_hostWithPort.

1182
1183
1184
1185
1186
1187
1188
2002-11-02  Darin Adler  <darin@apple.com>

	- fixed bug where the address of an NSNumber object would be used for the port number

        * Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]):
	Call intValue on the object returned from [NSURL port].

1189
1190
1191
1192
1193
2002-11-01  Darin Adler  <darin@apple.com>

        * Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]):
	Fixed uninitialized variable problem.

1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
2002-11-01  Darin Adler  <darin@apple.com>

	- fixed 3090239 -- crash on window close

        * WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): Nil out the bridge and
	release it so we don't close the URL twice.

	- fixed 3058598 -- animated gif animates repeatedly in Alex, but only once in other browsers

        * WebCoreSupport.subproj/WebImageRenderer.h: Added fields used by bug workaround.
        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer blockHasGIFExtensionSignature:length:]): Helper method for bug workaround.
        (-[WebImageRenderer checkDataForGIFExtensionSignature:]): Checks incoming data for the GIF
	extension signatures.
        (-[WebImageRenderer initWithData:]): Override to call checkDataForGIFExtensionSignature.
        (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): Call checkDataForGIFExtensionSignature.
        (-[WebImageRenderer repetitionCount]): Return 1 if we were going to return 0, but we didn't see a
	GIF extension signature. This workaround can be removed once we require a system new enough to have
	the bug fix for bug 3090341.
        (-[WebImageRenderer nextFrame:]): Stop on last frame, don't wrap around to first.

        * WebCoreSupport.subproj/WebImageRendererFactory.h: Update for changes to WebCore.
        * WebCoreSupport.subproj/WebImageRendererFactory.m: Tweaks.

        * WebView.subproj/WebImageRepresentation.m: Update imports.
        * WebView.subproj/WebImageView.m: Update imports.

rjw's avatar
rjw committed
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
2002-11-01  Richard Williamson   <rjw@apple.com>

        Implemented rendering of diacriticals.
        
        * Misc.subproj/WebUnicode.h:
        * Misc.subproj/WebUnicode.m:
        (_unicodeDigitValue):
        (_unicodeCategory):
        (_unicodeDirection):
        (_unicodeJoining):
        (_unicodeDecompositionTag):
        (_unicodeMirrored):
        (_unicodeCombiningClass):
        (_unicodeLower):
        (_unicodeUpper):
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]):
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):
        (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]):

darin's avatar
darin committed
1241
1242
1243
1244
2002-11-01  Darin Adler  <darin@apple.com>

        * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

cblu's avatar
WebKit:    
cblu committed
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
2002-11-01  Chris Blumenberg  <cblu@apple.com>

	Check that the plug-in is loaded before calling it.

        * Plugins.subproj/WebBaseNetscapePluginStream.h:
        * Plugins.subproj/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream dealloc]):
        (-[WebBaseNetscapePluginStream setPluginPointer:]):
        (-[WebBaseNetscapePluginStream setResponse:]):
        (-[WebBaseNetscapePluginStream receivedData:]):
        (-[WebBaseNetscapePluginStream destroyStreamWithReason:]):
        (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
        * Plugins.subproj/WebBasePluginPackage.h:
        * Plugins.subproj/WebBasePluginPackage.m:
        (-[WebBasePluginPackage isLoaded]):
        * Plugins.subproj/WebNetscapePluginDocumentView.m:
        (-[WebNetscapePluginDocumentView setDataSource:]):
        * Plugins.subproj/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage isLoaded]):
        * Plugins.subproj/WebNetscapePluginRepresentation.m:
        (-[WebNetscapePluginRepresentation receivedData:withDataSource:]):

cblu's avatar
cblu committed
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
2002-11-01  Chris Blumenberg  <cblu@apple.com>

	- Moved plug-in error handling to WebResourceLoadDelegate
	- Report plug-in load failure, java load failure, and plug-in not found errors.
	- Added WebPluginError, subclass of WebError.
	- Attempted fix: 3090675 - Standalone WMP (Window Media Player) content crashes Alexander

        * English.lproj/Localizable.strings:
        * Misc.subproj/WebKitErrors.h:
        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView sendEvent:]): don't send event to null function
        * Plugins.subproj/WebNetscapePluginDocumentView.m:
        (-[WebNetscapePluginDocumentView setDataSource:]): report plug-in load failure
        * Plugins.subproj/WebNullPluginView.h:
        * Plugins.subproj/WebNullPluginView.m: take a WebPluginError
        (-[WebNullPluginView dealloc]):
        (-[WebNullPluginView viewDidMoveToWindow]):
        * Plugins.subproj/WebPluginError.h: Added.
        * Plugins.subproj/WebPluginError.m: Added.
        (-[WebPluginErrorPrivate dealloc]):
        (-[WebPluginError dealloc]):
        (-[WebPluginError pluginPageURL]):
        (-[WebPluginError pluginName]):
        (-[WebPluginError MIMEType]):
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): report plug-in load failure
        (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): report plug-in load failure
        * WebKit.pbproj/project.pbxproj:
        * WebView.subproj/WebController.m:
        (-[WebResourceLoadDelegate pluginFailedWithError:dataSource:]): added, does nothing
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebResourceLoadDelegate.h:
        * WebView.subproj/WebView.m:
        (+[WebView initialize]): added new error strings

sullivan's avatar
WebKit:    
sullivan committed
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
2002-11-01  John Sullivan  <sullivan@apple.com>

	- some weaning of WebBookmark API from WebBookmarkGroup

        * Bookmarks.subproj/WebBookmark.m:
        (-[WebBookmark dealloc]):
	set group to nil instead of asserting that it's non-nil

        * Bookmarks.subproj/WebBookmarkGroup.h:
	removed obsolete ivar _bookmarksByID
        * Bookmarks.subproj/WebBookmarkGroup.m:
        (-[WebBookmarkGroup initWithFile:]):
	removed obsolete ivar _bookmarksByID
        (-[WebBookmarkGroup dealloc]):
	removed obsolete ivar _bookmarksByID
        (-[WebBookmarkGroup removeBookmark:]):
	removed this unnecessary method; callers need to use
	[[bookmark parent] removeChild:bookmark] instead

1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
2002-11-01  Trey Matteson  <trey@apple.com>

	Moved involved code for loading URLs from WebBridge up to WebFrame, with a little
	consolidation along the way.  I need to get all this stuff in one place in prep
	for doing back-forward properly with frames.  There should be no change in
	functionality as a result of these changes.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge loadURL:reload:]):
        (-[WebBridge postWithURL:data:contentType:]):
        (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
	Much of the guts of these is moved to WebFramePrivate.
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _setIsClientRedirect:]):
        (-[WebDataSource _isClientRedirect]):
	Keep state of whether we're processing a redirect in DataSource.  I had previously
	to do this with a loadType, but that failed because cliRedir is orthogonal.
        * WebView.subproj/WebFramePrivate.h:
	WebFrameLoadTypeClientRedirect is gone.
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFramePrivate init]):
	Initialize loadType explicitly.
        (-[WebFrame _transitionToCommitted]):
	Test [dataSource _isClientRedirect] instead of looking at loadType.
        (-[WebFrame _isLoadComplete]):
	Nuke WebFrameLoadTypeClientRedirect
        (-[WebFrame _goToItem:withFrameLoadType:]):
	Nuke WebFrameLoadTypeClientRedirect.
        (-[WebFrame _loadRequest:]):
	Helper method moved from WebBridge.
        (-[WebFrame _loadURL:loadType:clientRedirect:]):
	Core impl moved up from WebBridge.
        (-[WebFrame _postWithURL:data:contentType:]):
	Core impl moved up from WebBridge.

darin's avatar
darin committed
1357
1358
1359
1360
1361
1362
1363
1364
1365
2002-11-01  Darin Adler  <darin@apple.com>

	- implemented loop counts

        * WebCoreSupport.subproj/WebImageRenderer.h: Added repetitionsComplete field.
        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer repetitionCount]): Get NSImageLoopCount.
        (-[WebImageRenderer nextFrame:]): Check repetitionCount and stop once we hit it.

1366
1367
1368
1369
1370
2002-10-31  Darin Adler  <darin@apple.com>

        * WebView.subproj/WebFrame.m: (-[WebFrame setController:]): Add an assert,
	hoping to catch a reported bug earlier or disprove one theory.

1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
2002-10-31  Trey Matteson  <trey@apple.com>

	Added API to support 3072505 - SnapBack for user-entered page address
	Refixed 3041616 - Extra page added in back button history
	Previous fix was stepped on by a later checkin.  Re-established that fix, then
	went on to make sure we have the final URL and title in the BF item in the
	case of a client redirect.  Also handles redirects that happen within frames.
	Fixed 3078560 - div added to "back" list

        * History.subproj/WebBackForwardList.h:
        * History.subproj/WebBackForwardList.m:
        (-[WebBackForwardList containsEntry:]):
	Added new API for 3072505.
        * WebCoreSupport.subproj/WebBridge.h:
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge reportClientRedirectTo:delay:fireDate:]):
        (-[WebBridge reportClientRedirectCancelled]):
        (-[WebBridge loadURL:reload:]):
	Added logging.  Renamed flag.  Establish the right loadtype and set BF items
	from the old dataSource onto the new dataSource in the case of a client redirect.
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _setRequest:]):
	Add logging.
        (-[WebDataSource _addBackForwardItem:]):
        (-[WebDataSource _addBackForwardItems:]):
        (-[WebDataSource _backForwardItems]):
	New setters/getters to support setting up the new dataSource of a client redirect.
        * WebView.subproj/WebFramePrivate.h:
	New loadType WebFrameLoadTypeClientRedirect.
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted]):
	Update the URL in the BF list in the client redirect case.
        (-[WebFrame _isLoadComplete]):
	NOP case for WebFrameLoadTypeClientRedirect
        (-[WebFrame _goToItem:withFrameLoadType:]):
	ASSERT_NOT_REACHED case for WebFrameLoadTypeClientRedirect

1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
2002-10-31  Richard Williamson  <rjw@apple.com>

        Corrected extern definitions of lookup tables.
        
        * Misc.subproj/WebUnicode.h:
        * Misc.subproj/WebUnicode.m:
        (_unicodeDirection):
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (+[WebTextRenderer initialize]):

1419
=== Alexander-30 ===
sheridan's avatar
sheridan committed
1420

1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
2002-10-30  Richard Williamson  <rjw@apple.com>

        More work on bidi and contextual forms.
        Table lookup code for unicode characters attributes.

        * Misc.subproj/WebUnicode.h: Added.
        * Misc.subproj/WebUnicode.m: Added.
        (_unicodeDigitValue):
        (_unicodeCategory):
        (_unicodeDirection):
        (_unicodeJoining):
        (_unicodeDecompositionTag):
        (_unicodeMirrored):
        (_unicodeMirroredChar):
        (_unicodeCombiningClass):
        (_unicodeLower):
        (_unicodeUpper):
        (WebKitInitializeUnicode):
        * Misc.subproj/WebUnicodeTables.m: Added.
        * WebKit.pbproj/project.pbxproj:

        Additional logging parameter.
        
        * Misc.subproj/WebKitLogging.h:
        * Misc.subproj/WebKitLogging.m:

mjs's avatar
WebKit:    
mjs committed
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
2002-10-30  Maciej Stachowiak  <mjs@apple.com>

	Pass WebResourceRequest rather than just NSURL to URL policy
	delegate method.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (+[WebDefaultPolicyDelegate defaultURLPolicyForRequest:]):
        (-[WebDefaultPolicyDelegate URLPolicyForRequest:inFrame:]):
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _shouldShowRequest:]):

darin's avatar
darin committed
1460
1461
1462
1463
2002-10-30  Darin Adler  <darin@apple.com>

        * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

1464
1465
1466
1467
1468
1469
1470
2002-10-30  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3088122 - Assertion failure/crash closing window with QuickTime streaming in

        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _setMainDocumentError:]): call receivedError on the representation.

1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
2002-10-30  Darin Adler  <darin@apple.com>

	- fixed memory leaks in plugin package creation code

        * Plugins.subproj/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage initWithPath:]): Rearrange this code, and make sure
	that it does a [self release] if it's going to return nil instead of self.
        (-[WebNetscapePluginPackage unload]): Set bundle to 0 when we release it.
        (-[WebNetscapePluginPackage dealloc]): Release the bundle if it's not 0.

        * Plugins.subproj/WebPluginPackage.m:
        (-[WebPluginPackage initWithPath:]): Rearrange this code, and make sure
	that it does a [self release] if it's going to return nil instead of self.

darin's avatar
darin committed
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
2002-10-30  Darin Adler  <darin@apple.com>

	- fixed 3086564 -- REGRESSION: meta-refresh to the same page doesn't refresh

	The key is to respect the new reload: parameter from the bridge.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge loadURL:reload:]): Don't ever treat a reload as a redirect.
	Set the cache policy to WebRequestCachePolicyLoadFromOrigin if it's a reload.

	- fixed 3087214 -- REGRESSION: <WebKit/WebKit.h> contains #import of non-existent header

        * Misc.subproj/WebKit.h: Removed import of WebControllerSets.h, which is private.

mjs's avatar
WebKit:    
mjs committed
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
2002-10-30  Maciej Stachowiak  <mjs@apple.com>

	Another step towards the policy API change - add request argument
	to file URL policy and remove isDirectory argument.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate fileURLPolicyForMIMEType:andRequest:inFrame:]):
        * WebView.subproj/WebFrame.m:
        (-[WebFrame setProvisionalDataSource:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _shouldShowRequest:]):
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:willSendRequest:]):

mjs's avatar
WebKit:    
mjs committed
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
2002-10-29  Maciej Stachowiak  <mjs@apple.com>

	First step towards policy API change. Pass request instead of URL
	to content policy delegate method.
	
        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:didReceiveResponse:]):

1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
2002-10-29  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3087548 - REGRESSION: two windows open for netflix confirmation
	
        * WebView.subproj/WebControllerPrivate.h:
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _findFrameInThisWindowNamed:]): Added this function back,
	and added check for top-level frame name.
        (-[WebController _findFrameNamed:]): Use
	_findFrameInThisWindowNamed: to make sure top-level frame names
	get checked.

1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
2002-10-29  Chris Blumenberg  <cblu@apple.com>

	Created Downloads.subproj to hold the to-be-implemented download decoders.

        * Downloads.subproj/WebDownloadDecoder.h: Added.
        * Downloads.subproj/WebDownloadHandler.h: Added.
        * Downloads.subproj/WebDownloadHandler.m: Added.
        (-[WebDownloadHandler initWithDataSource:]):
        (-[WebDownloadHandler dealloc]):
        (-[WebDownloadHandler errorWithCode:]):
        (-[WebDownloadHandler receivedResponse:]):
        (-[WebDownloadHandler receivedData:]):
        (-[WebDownloadHandler finishedLoading]):
        (-[WebDownloadHandler cancel]):
        * Misc.subproj/WebDownloadHandler.h: Removed.
        * Misc.subproj/WebDownloadHandler.m: Removed.
        * WebKit.pbproj/project.pbxproj:

darin's avatar
darin committed
1555
1556
1557
1558
1559
1560
1561
1562
2002-10-28  Darin Adler  <darin@apple.com>

	- fixed crash I just introduced

        * Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]):
	Remove the release call here. When I added the autorelease, I didn't realize that
	the caller was doing a release.

1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
2002-10-28  Trey Matteson  <trey@apple.com>

	Fixed 3041616 - Extra page added in back button history

	Client-side redirects would always put an extra item in the backforward list.
	According to Darin this is a regression all the way back from functionality moving
	from WebBrowser to WebKit.	

        * WebCoreSupport.subproj/WebBridge.h:
	Added state to know if we're doing an "internal" type of load
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge reportClientRedirectTo:delay:fireDate:]):
	Set internalLoad bit if delay==0
        (-[WebBridge reportClientRedirectCancelled]):
	Clear internalLoad
        (-[WebBridge loadURL:]):
	Set frame's loadType if doing an internal load (similar to what we do when loading
	child frames)

darin's avatar
darin committed
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
2002-10-28  Darin Adler  <darin@apple.com>

	- fixed storage leak of WebNetscapePluginPackage objects

        * Plugins.subproj/WebBasePluginPackage.m:
        (+[WebBasePluginPackage pluginWithPath:]): Add missing autorelease.

        * Plugins.subproj/WebBasePluginPackage.h:
        * Plugins.subproj/WebPluginController.h:
        * Plugins.subproj/WebPluginController.m:
        * Plugins.subproj/WebPluginPackage.h:
        * Plugins.subproj/WebPluginPackage.m:
	Not __MyCompanyName__, but rather Apple Computer.

darin's avatar
darin committed
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
2002-10-28  Darin Adler  <darin@apple.com>

	- fixed bug that caused us to leak all WebResourceHandles used for subresources

        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (-[WebSubresourceClient dealloc]): Remove bogus "currentURL == nil" assert.
        (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
	Use the new loadWithRequest: call instead of making handle and doing loadWithDelegate:.
	This is where the leak was, because no one ever released the handle, but releasing it
	right away would be too soon.

        * WebView.subproj/WebBaseResourceHandleDelegate.h: Added defersCallbacks field,
	loadWithRequest: method, and setDefersCallbacks: method. Removed handle method.
        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate loadWithRequest:]): New method. Sets up the handle,
	set the defersCallbacks state on it, and calls loadWithDelegate:.
        (-[WebBaseResourceHandleDelegate setDefersCallbacks:]): Stores defersCallbacks state,
	and also sets it on the handle, if any.
        (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): Remove code to set up
	the handle, since we now do that at loadWithRequest: time.

        * WebView.subproj/WebDataSourcePrivate.h: Remove mainHandle field.
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSourcePrivate dealloc]): Don't release mainHandle.
        (-[WebDataSource _setPrimaryLoadComplete:]): Ditto.
        (-[WebDataSource _startLoading]): Use loadWithRequest: on the client, no need to deal
	with the handle directly at all.
        (-[WebDataSource _addSubresourceClient:]): Call setDefersCallbacks: on the client.
        (-[WebDataSource _defersCallbacksChanged]): Ditto.

        * WebView.subproj/WebControllerPrivate.m: Remove unneeded include.
        * WebView.subproj/WebMainResourceClient.m: Ditto.

cblu's avatar
cblu committed
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
2002-10-28  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3056726 - View Source window always displays the source in current system encoding
	Fixed: 3019352 - Text encoding is not handled when viewing plain text

        * WebView.subproj/WebDataSource.h:
        * WebView.subproj/WebDataSource.m:
        (-[WebDataSource stringWithData:]): added, creates a string using the specified encoding.
        * WebView.subproj/WebHTMLRepresentation.m:
        (-[WebHTMLRepresentation documentSource]): uses the bridge specified encoding when creating the string
        * WebView.subproj/WebTextView.h:
        * WebView.subproj/WebTextView.m:
        (-[WebTextView dataSourceUpdated:]): use stringWithData: 
        (-[WebTextView supportsTextEncoding]): Yup

rjw's avatar
rjw committed
1644
1645
1646
1647
1648
1649
1650
2002-10-28  Richard Williamson   <rjw@apple.com>

        Fixed crasher.
        
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

sullivan's avatar
WebKit:    
sullivan committed
1651
1652
1653
1654
1655
1656
1657
2002-10-28  John Sullivan  <sullivan@apple.com>

        * Bookmarks.subproj/WebBookmark.h:
        * Bookmarks.subproj/WebBookmark.m:
        (-[WebBookmark contentMatches:]): new method, returns YES if
	two bookmarks are the same, ignoring group and parent.

trey's avatar
WebKit:    
trey committed
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
2002-10-28  Trey Matteson  <trey@apple.com>

	Finished 2998200 - access to most-recent in submenu of back & forward buttons

        * WebView.subproj/WebDataSourcePrivate.h:
	The BF items we are going to and from were moved here from
	WebFrame because of timing problems among multiple data sources
	when using the BF buttons during a load.
	In addition, the datasource has a list of relevant BF items for
	which it keeps their titles up to date.
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSourcePrivate dealloc]):
	Free new state.
        (-[WebDataSource _setTitle:]):
	Update titles of BF items.
        (-[WebDataSource _provisionalBackForwardItem]):
        (-[WebDataSource _setProvisionalBackForwardItem:]):
        (-[WebDataSource _previousBackForwardItem]):
        (-[WebDataSource _setPreviousBackForwardItem:]):
        (-[WebDataSource _addBackForwardItem:]):
	Maintain new state.
        (-[WebDataSource _commitIfReady]):
	Free up previous and provisional BF items after commit.
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge loadURL:]):
	Add the new BF item to the datasource.
        (-[WebBridge saveDocumentState:]):
	Use the right BF item to save the doc state.
        * WebView.subproj/WebFramePrivate.h:
	Previous and provisional BF are moved to datasource.
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted]):
	Use provisional BF from datasource to set position in BF list.
	Add new BF item to datasource.
        (-[WebFrame _isLoadComplete]):
        (-[WebFrame _checkLoadComplete]):
	Comments, whitespace.
        (-[WebFrame _goToItem:withFrameLoadType:]):
	Set item we will use to saveDocState at commit time.

darin's avatar
darin committed
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
2002-10-27  Darin Adler  <darin@apple.com>

	- WebKit part of filename width fix

        * WebCoreSupport.subproj/WebFileButton.m:
        (-[WebFileButton drawRect:]): Compute left position by starting at
	the right side of the button frame rather than by starting at the right
	side of the overall bounds. Removes dependency on fixed-width filename area.
        (-[WebFileButton updateLabel]): Added. Computes ellipsized filename.
        (-[WebFileButton setFilename:]): Use updateLabel instead of code in line here.
        (-[WebFileButton setFrameSize:]): Call updateLabel.
        (-[WebFileButton bestVisualFrameSizeForCharacterCount:]): Compute a width based
	on the count passed in rather than a hardcoded 200-pixel constant.

1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
2002-10-27  Darin Adler  <darin@apple.com>

	- fixed 3037369 -- Status text not cleared after start of drag from page

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
	Find the highest-level enclosing WebHTMLView, and call _updateMouseoverWithEvent:
	with the mouseUp event after the drag is done.
        (-[WebHTMLView mouseMovedNotification:]): Just call _updateMouseoverWithEvent:,
	the code from here was moved into there.

        * WebView.subproj/WebHTMLViewPrivate.h: Declare _updateMouseoverWithEvent.
        * WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _updateMouseoverWithEvent:]):
	Moved all the code from mouseMovedNotification: in here so it could be used twice.

gramps's avatar
gramps committed
1727
1728
1729
1730
1731
1732
1733
2002-10-27  Don Melton  <gramps@apple.com>

        * WebView.subproj/WebController.m:
        (-[WebController userAgentForURL:]):

	Changed default user agent to Mozilla 1.1.

darin's avatar
darin committed
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
2002-10-27  Darin Adler  <darin@apple.com>

        * Bookmarks.subproj/WebBookmarkProxy.m: (-[WebBookmarkProxy dealloc]):
	Added, so we don't leak the title.

        * Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup removeBookmark:]):
        * Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList removeChild:]):
	Added retain/release pairs so we don't use an object after it's deallocated.
	In practice this doesn't happen the way these are used by Alex since they are
	in an array, but they have windows of vulnerability depending on exactly how
	they are used.

darin's avatar
darin committed
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
2002-10-26  Darin Adler  <darin@apple.com>

        * WebCoreSupport.subproj/WebViewFactory.m:
        (-[WebViewFactory inputElementAltText]): Added.
        (-[WebViewFactory resetButtonDefaultLabel]): Added.
        (-[WebViewFactory searchableIndexIntroduction]): Added.
        (-[WebViewFactory submitButtonDefaultLabel]): Added.
        (-[WebViewFactory defaultLanguageCode]): Added.

        * English.lproj/Localizable.strings: Update.
        * English.lproj/StringsNotToBeLocalized.txt: Update.

darin's avatar
darin committed
1758
1759
1760
1761
1762
1763
1764
1765
1766
2002-10-25  Darin Adler  <darin@apple.com>

        * WebCoreSupport.subproj/WebViewFactory.m:
        (-[WebViewFactory runJavaScriptAlertPanelWithMessage:]): Added.
        (-[WebViewFactory runJavaScriptConfirmPanelWithMessage:]): Added.

        * English.lproj/Localizable.strings: Update.
        * English.lproj/StringsNotToBeLocalized.txt: Update.

1767
1768
1769
1770
1771
1772
1773
1774
2002-10-25  Richard Williamson   <rjw@apple.com>

        Implemented support for bidi text layout.
        
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (_drawGlyphs):
        (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]):

1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
2002-10-25  Chris Blumenberg  <cblu@apple.com>

	Made frameNamed private in WebController and renamed it to _findFrameNamed. Got rid of _frameInThisWindowNamed in WebController because it isn't needed anymore.

        * WebView.subproj/WebController.h:
        * WebView.subproj/WebController.m:
        (-[WebController _goToItem:withFrameLoadType:]): call _findFrameNamed
        * WebView.subproj/WebControllerPrivate.h:
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _findFrameNamed:]): renamed, made private, got rid of call to _frameInThisWindowNamed as it is not needed
        * WebView.subproj/WebFrame.m:
        (-[WebFrame findFrameNamed:]): call [WebController _findFrameNamed:]

1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
2002-10-25  Chris Blumenberg  <cblu@apple.com>

	- Fix case where we would name a new window _blank
	- If a data source can't be created for a plug-in request, don't create the frame or open a window.
	- cleaned up plug-in stream notifications

        * Plugins.subproj/WebBaseNetscapePluginView.h:
        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView initWithFrame:]): create streamNotifications dict
        (-[WebBaseNetscapePluginView dealloc]): release streamNotifications dict
        (-[WebBaseNetscapePluginView frameStateChanged:]): cleaned up
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): create data source before frame
        * Plugins.subproj/WebPluginController.m:
        (-[WebPluginController showURL:inFrame:]): create data source before frame
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _setTopLevelFrameName:]): don't allow _blank frames
        * WebView.subproj/WebFrame.m:
        (-[WebFrame findOrCreateFramedNamed:]): no need to check for _blank

darin's avatar
WebKit:    
darin committed
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
2002-10-25  Darin Adler  <darin@apple.com>

        Tighten up the code that observes mouse moved events.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView initWithFrame:]): Don't set up observers here.
        (-[WebHTMLView addMouseMovedObserver]): Added some assertions.
        (-[WebHTMLView viewWillMoveToWindow:]): Stop observing the "become main" and "resign main"
	notifications here.
        (-[WebHTMLView viewDidMoveToWindow]): Start observing them here.
        (-[WebHTMLView windowDidBecomeMain:]): Assert that the notification is for this window,
	instead of checking with if.
        (-[WebHTMLView windowDidResignMain:]): Assert that the notification is for this window.

cblu's avatar
cblu committed
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
2002-10-25  Chris Blumenberg  <cblu@apple.com>

	Cleaned up the frame searching shenanigans. Things are much cleaner and clearer now.

        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): call findOrCreateFramedNamed
        * Plugins.subproj/WebPluginController.m:
        (-[WebPluginController showURL:inFrame:]): call findOrCreateFramedNamed
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge childFrames]): moved
        (-[WebBridge mainFrame]): moved
        (-[WebBridge findOrCreateFramedNamed:]): call findOrCreateFramedNamed on the frame
        (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): call _pluginController
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _frameInThisWindowNamed:]): call _descendantFrameNamed
        * WebView.subproj/WebFrame.h:
        * WebView.subproj/WebFrame.m:
        (-[WebFrame findFrameNamed:]): was frameNamed. First checks special-case frame names, descendant frames, then the whole controller, then other controllers.
        (-[WebFrame findOrCreateFramedNamed:]): calls findFrameNamed, opens new window if necessary 
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _descendantFrameNamed:]): searches children, children's children etc.
        (-[WebFrame _pluginController]): this method needed an "_"
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView addSubview:]): call _pluginController
        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLView _elementAtPoint:]): no need to special case for "_blank" since findFrameNamed will return nil for that name

trey's avatar
WebKit:    
trey committed
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
2002-10-25  Trey Matteson  <trey@apple.com>
	
	2919039 - Implement limit on back/forward history list
	2998200 - access to most-recent in submenu of back & forward buttons
	3022566 - need WebKit API for accessing and visiting back/forward list items
	3084051 - forward button incorrectly enabled after going forward all the way

	Remaining issues at this point are getting the title of the pages
	into the menu items (instead of the URL), and saving document
	state properly when you jump around in the list.  Solutions are
	known and coming soon.

        * History.subproj/WebBackForwardList.h:
	Added doc comments to API.  Made ivars private.  Replaced index-
	based API with item-based API.  Added a sizelimit to the overall
	list.  Tweaked API to get back and forward lists.
        * History.subproj/WebBackForwardList.m:
	Straightforward impl of the above, with the note that I dumped
	WebHistoryList from the API and impl in favor of an NSArray,
	which is efficient for this sort of use (queue, stack).
        (-[WebBackForwardList init]):
        (-[WebBackForwardList dealloc]):
        (-[WebBackForwardList goBack]):
        (-[WebBackForwardList goForward]):
        (-[WebBackForwardList goToEntry:]):
        (-[WebBackForwardList backEntry]):
        (-[WebBackForwardList forwardEntry]):
        (-[WebBackForwardList maximumSize]):
        (-[WebBackForwardList setMaximumSize:]):
        (-[WebBackForwardList description]):
        * History.subproj/WebHistoryList.h: Removed.
	Nuked from API, per above.
        * History.subproj/WebHistoryList.m: Removed.
        * Misc.subproj/WebKit.h:
	WebHistoryList gone from API.
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge loadURL:]):
	Use if/else instead of buried "return;", so next person doesn;t
	make the same mis-read I did.
        (-[WebBridge saveDocumentState:]):
	Site of future work.
        * WebKit.pbproj/project.pbxproj:
	Nuked WebHistoryList.
        * WebView.subproj/WebController.h:
        * WebView.subproj/WebController.m:
        (-[WebController goBackOrForwardToItem:]):
	New method to support random access nav in backforward list.
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _setTitle:]):
	Site of future work (fixing title in items)
        * WebView.subproj/WebFramePrivate.h:
	WebFrameLoadTypeIndexedBack/WebFrameLoadTypeIndexedForward are
	collapsed into WebFrameLoadTypeIndexedBackForward.  Vestigial
	WebFrameLoadTypeIntermediateBack is nuked.
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFramePrivate setBackForwardItem:]):
        (-[WebFrame _setBackForwardItem:]):
        (-[WebFrame _backForwardItem]):
	Must remember the BF item we're going to so we can update the
	BF list on commit.
        (-[WebFrame _transitionToCommitted]):
	Update the BF list on commit.
        (-[WebFrame _isLoadComplete]):
        (-[WebFrame _goToItem:withFrameLoadType:]):
	Update BF list on within-page nav.
	Remember BF item we are going to for later update on commit.

cblu's avatar
cblu committed
1916
1917
1918
1919
1920
1921
1922
2002-10-25  Chris Blumenberg  <cblu@apple.com>

	Minor non-mentionable clean-up.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]):

1923
1924
1925
1926
1927
1928
1929
1930
2002-10-25  Chris Blumenberg  <cblu@apple.com>

	Cleaned up the plug-in API headers so they can be sent to other groups.

        * Plugins.subproj/WebPlugin.h:
        * Plugins.subproj/WebPluginContainer.h:
        * Plugins.subproj/WebPluginViewFactory.h:

1931
1932
1933
2002-10-24  Richard Williamson   <rjw@apple.com>

        Fixed many font substitution related bugs, at least including:
rjw's avatar
rjw committed
1934
1935
1936
1937
        3006966, 3026675, 3071106, and more... (each of these bugs
        has a list of related bugs). 
        
        Needs little more cleanup to correctly deal with non base characters.
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
        
        * WebCoreSupport.subproj/WebTextRenderer.h:
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:]):
        (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:]):
        (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):
        
        Against Darin's better judgement prevent extra layout when not in live resize.  If
        this introduces any regressions I owe darin a good bottle of wine.
        
        * WebView.subproj/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView updateScrollers]):

1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
2002-10-24  Chris Blumenberg  <cblu@apple.com>

	New Java plug-in works! Much faster to load and no spinny cursor! Unfortunately, it very unstable.

        * Plugins.subproj/WebPluginController.m: cleaned-up the logging messages.
        (-[WebPluginController addPluginView:]):
        (-[WebPluginController didAddPluginView:]):
        (-[WebPluginController startAllPlugins]):
        (-[WebPluginController stopAllPlugins]):
        (-[WebPluginController destroyAllPlugins]):
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): make height and width an attribute.

cblu's avatar
cblu committed
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
2002-10-24  Chris Blumenberg  <cblu@apple.com>

	Some clean-up and bug fixes for new plug-in support.

        * Plugins.subproj/WebPluginController.m:
        (-[WebPluginController initWithWebFrame:]): need a colon after windowWillClose
        (-[WebPluginController addPluginView:]): added logging
        (-[WebPluginController didAddPluginView:]): added logging
        (-[WebPluginController startAllPlugins]): added logging
        (-[WebPluginController stopAllPlugins]): added logging
        (-[WebPluginController destroyAllPlugins]): added logging
        * Plugins.subproj/WebPluginPackage.m:
        (-[WebPluginPackage getMIMEInformation]): use correct dict key for getting MIME descriptions
        * WebCoreSupport.subproj/WebBridge.m: no more didAddSubview
        * WebView.subproj/WebFramePrivate.h: no more didAddSubview
        * WebView.subproj/WebFramePrivate.m: no more didAddSubview
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView addSubview:]): call didAddPluginView on WebPluginController

sullivan's avatar
WebKit:    
sullivan committed
1983
1984
1985
1986
1987
1988
1989
2002-10-24  John Sullivan  <sullivan@apple.com>

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge objectLoadedFromCache:response:size:]):
	added ASSERT(response != nil), leftover from debugging
	session on Tuesday, seems worth leaving in.

darin's avatar
darin committed
1990
1991
1992
1993
2002-10-24  Darin Adler  <darin@apple.com>

        * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

cblu's avatar
WebKit:    
cblu committed
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2002-10-24  Chris Blumenberg  <cblu@apple.com>

	Changed some method names in WebPluginController.

        * Plugins.subproj/WebPluginController.h:
        * Plugins.subproj/WebPluginController.m:
        (-[WebPluginController didAddPluginView:]):
        (-[WebPluginController startAllPlugins]):
        (-[WebPluginController stopAllPlugins]):
        (-[WebPluginController destroyAllPlugins]):
        (-[WebPluginController windowWillClose:]):
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted]):
        (-[WebFrame _didAddSubview:]):

sheridan's avatar
sheridan committed
2009
2010
=== Alexander-29 ===

rjw's avatar
rjw committed
2011
2012
2013
2014
2015
2016
2017
2002-10-24  Richard Williamson   <rjw@apple.com>

        Don't leak request.
        
        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):

2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2002-10-24  Richard Williamson   <rjw@apple.com>

        Always copy request, we can't count on it being immutable.
        This was the cause of the ASSERT from last night's checkin.
        
        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):
        
        Only send serverRedirectedForDataSource: if URL changed.
        
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _setRequest:]):

cblu's avatar
cblu committed
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2002-10-24  Chris Blumenberg  <cblu@apple.com>
	
	- Use "MIMEType" instead of "serviceType".

        * Plugins.subproj/WebBasePluginPackage.h:
        * Plugins.subproj/WebBasePluginPackage.m:
        (-[WebBasePluginPackage load]):
        (-[WebBasePluginPackage dealloc]):
        (-[WebBasePluginPackage filename]):
        (-[WebBasePluginPackage setPath:]):
        * Plugins.subproj/WebNetscapePluginEmbeddedView.h:
        * Plugins.subproj/WebNetscapePluginEmbeddedView.m:
        (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributes:]):
        * Plugins.subproj/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage getMIMEInformation]): changed name.
        (-[WebNetscapePluginPackage initWithPath:]):
        * Plugins.subproj/WebNullPluginView.h:
        * Plugins.subproj/WebNullPluginView.m:
        (-[WebNullPluginView initWithFrame:MIMEType:attributes:]):
        (-[WebNullPluginView dealloc]):
        (-[WebNullPluginView viewDidMoveToWindow]): send missing plug-ins notification here
        * Plugins.subproj/WebPluginPackage.m:
        (-[WebPluginPackage getMIMEInformation]): new, gets MIME info from plist
        (-[WebPluginPackage initWithPath:]):
        (-[WebPluginPackage dealloc]):
        (-[WebPluginPackage viewFactory]):
        (-[WebPluginPackage load]):
        (-[WebPluginPackage unload]):
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]):
        (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):

2063
2064
2065
2066
2067
2068
2069
2070
2071
2002-10-24  Richard Williamson   <rjw@apple.com>

        Flag error instead of ASSERTing as a result of fix to 3083013.
        Not clear why this condition occurs, but better than ASSERTing
        for Alex 29.
        
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _setRequest:]):

2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2002-10-24  Darin Adler  <darin@apple.com>

	- fixed a crash I ran into in the new delegate code

        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate _releaseResources]): Retain self across this
	deallocation to avoid reentering and being deallocated midstream. This happens
	because the handle holds the only reference to us, and we may be releasing the
	last reference to it.
        (-[WebBaseResourceHandleDelegate dealloc]): Add call to [super dealloc].

        * Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]):
	Add call to [super dealloc].

        * WebView.subproj/WebMainResourceClient.m: Tweak.

2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2002-10-23  Darin Adler  <darin@apple.com>

	- fixed 3083013 -- REGRESSION: Cookie refused at http://directory/ even on reload

	Restore a bit of the cruft.

        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:willSendRequest:]):
	We need to change the request on the data source when a redirect happens,
	because the data source goes on to ultimately communicate this to WebCore.
	Restored the code that did that, with some changes to fit into the new regime.

2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2002-10-23  Richard Williamson  <rjw@apple.com>

        Cleaned up months of accumulated cruft.
        Added base class to the three WebResourceHandleDelegate implementors.
        Removed superfluous handle references to controller callbacks.
        More can still be done.
        All in the name of fixing 3076050.
        
        * Misc.subproj/WebKitErrors.h:
        * Plugins.subproj/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream setResponse:]):
        * Plugins.subproj/WebNetscapePluginRepresentation.m:
        (-[WebNetscapePluginRepresentation receivedData:withDataSource:]):
        (-[WebNetscapePluginRepresentation receivedError:withDataSource:]):
        (-[WebNetscapePluginRepresentation finishedLoadingWithDataSource:]):
        * Plugins.subproj/WebNetscapePluginStream.h:
        * Plugins.subproj/WebNetscapePluginStream.m:
        (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]):
        (-[WebNetscapePluginStream dealloc]):
        (-[WebNetscapePluginStream start]):
        (-[WebNetscapePluginStream stop]):
        (-[WebNetscapePluginStream handle:willSendRequest:]):
        (-[WebNetscapePluginStream handle:didReceiveResponse:]):
        (-[WebNetscapePluginStream handle:didReceiveData:]):
        (-[WebNetscapePluginStream handleDidFinishLoading:]):
        (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge reportBadURL:]):
        * WebCoreSupport.subproj/WebSubresourceClient.h:
        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (-[WebSubresourceClient initWithLoader:dataSource:]):
        (-[WebSubresourceClient dealloc]):
        (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
        (-[WebSubresourceClient receivedError:]):
        (-[WebSubresourceClient handle:willSendRequest:]):
        (-[WebSubresourceClient handle:didReceiveResponse:]):
        (-[WebSubresourceClient handle:didReceiveData:]):
        (-[WebSubresourceClient handleDidFinishLoading:]):
        (-[WebSubresourceClient handle:didFailLoadingWithError:]):
        (-[WebSubresourceClient cancel]):
        * WebView.subproj/WebBaseResourceHandleDelegate.h:
        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate init]):
        (-[WebBaseResourceHandleDelegate _releaseResources]):
        (-[WebBaseResourceHandleDelegate dealloc]):
        (-[WebBaseResourceHandleDelegate setDataSource:]):
        (-[WebBaseResourceHandleDelegate dataSource]):
        (-[WebBaseResourceHandleDelegate resourceLoadDelegate]):
        (-[WebBaseResourceHandleDelegate downloadDelegate]):
        (-[WebBaseResourceHandleDelegate setIsDownload:]):
        (-[WebBaseResourceHandleDelegate isDownload]):
        (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):
        (-[WebBaseResourceHandleDelegate handle:didReceiveResponse:]):
        (-[WebBaseResourceHandleDelegate handle:didReceiveData:]):
        (-[WebBaseResourceHandleDelegate handleDidFinishLoading:]):
        (-[WebBaseResourceHandleDelegate handle:didFailLoadingWithError:]):
        (-[WebBaseResourceHandleDelegate cancel]):
        (-[WebBaseResourceHandleDelegate handle]):
        * WebView.subproj/WebControllerPrivate.h:
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _mainReceivedBytesSoFar:fromDataSource:complete:]):
        (-[WebController _receivedError:fromDataSource:]):
        (-[WebController _mainReceivedError:fromDataSource:]):
        * WebView.subproj/WebDataSource.h:
        * WebView.subproj/WebDataSource.m:
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _startLoading]):
        (-[WebDataSource _stopLoading]):
        (-[WebDataSource _clearErrors]):
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _isLoadComplete]):
        * WebView.subproj/WebMainResourceClient.h:
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient initWithDataSource:]):
        (-[WebMainResourceClient dealloc]):
        (-[WebMainResourceClient receivedError:]):
        (-[WebMainResourceClient cancel]):
        (-[WebMainResourceClient handle:willSendRequest:]):
        (-[WebMainResourceClient _notifyDelegatesOfInterruptionByPolicyChange]):
        (-[WebMainResourceClient handle:didReceiveResponse:]):
        (-[WebMainResourceClient handle:didReceiveData:]):
        (-[WebMainResourceClient handleDidFinishLoading:]):
        (-[WebMainResourceClient handle:didFailLoadingWithError:]):
        * WebView.subproj/WebResourceLoadDelegate.h:

cblu's avatar
cblu committed
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2002-10-23  Chris Blumenberg  <cblu@apple.com>

	Support for new plug-in API. This is about as much as I can do without the new java plug-in and java root.

        * Plugins.subproj/WebPluginController.h:
        * Plugins.subproj/WebPluginController.m:
        (-[WebPluginController initWithWebFrame:]): observe window close changes
        (-[WebPluginController dealloc]): remove observer, assert if we're still tracking plug-ins
        (-[WebPluginController didAddSubview:]): start the plug-in
        (-[WebPluginController stopAllPlugins]): stop and destroy all plug-ins.
        (-[WebPluginController windowWillClose:]): call stopAllPlugins if the window in question is closing
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted]): call stopAllPlugins on WebPluginController

cblu's avatar
cblu committed
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2002-10-23  Chris Blumenberg  <cblu@apple.com>

	Changed the plug-in package API to return key enumerators instead dictionaries.

        * Plugins.subproj/WebBasePluginPackage.h:
        * Plugins.subproj/WebBasePluginPackage.m:
        (-[WebBasePluginPackage initWithPath:]):
        (-[WebBasePluginPackage load]):
        (-[WebBasePluginPackage unload]):
        (-[WebBasePluginPackage dealloc]):
        (-[WebBasePluginPackage extensionEnumerator]):
        (-[WebBasePluginPackage MIMETypeEnumerator]):
        (-[WebBasePluginPackage descriptionForMIMEType:]):
        (-[WebBasePluginPackage MIMETypeForExtension:]):
        (-[WebBasePluginPackage extensionsForMIMEType:]):
        (-[WebBasePluginPackage setName:]):
        (-[WebBasePluginPackage setPath:]):
        (-[WebBasePluginPackage setFilename:]):
        (-[WebBasePluginPackage setPluginDescription:]):
        (-[WebBasePluginPackage setMIMEToDescriptionDictionary:]):
        (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]):
        * Plugins.subproj/WebNetscapePluginPackage.h:
        * Plugins.subproj/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage getPluginInfo]):
        (-[WebNetscapePluginPackage pathByResolvingSymlinksAndAliasesInPath:]):
        (-[WebNetscapePluginPackage initWithPath:]):
        (-[WebNetscapePluginPackage executableType]):
        * Plugins.subproj/WebPluginController.h:
        * Plugins.subproj/WebPluginController.m:
        (-[WebPluginController didAddSubview:]):
        * Plugins.subproj/WebPluginDatabase.h:
        * Plugins.subproj/WebPluginDatabase.m:
        (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
        (-[WebPluginDatabase pluginForMIMEType:]):
        (-[WebPluginDatabase pluginForExtension:]):
        (-[WebPluginDatabase MIMETypes]):
        (-[WebPluginDatabase init]):
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge viewForPluginWithURL:attributes:baseURL:serviceType:]):
        (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):
        (-[WebBridge didAddSubview:]): new
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _didAddSubview:]): new 

darin's avatar
darin committed
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2002-10-23  Darin Adler  <darin@apple.com>

	- finished up the job of moving the file button here from WebCore.

	I did this mainly for localization reasons.

        * WebCoreSupport.subproj/WebFileButton.m:
        (-[WebFileButton initWithFrame:]): Set up button control size, font, bezel style,
	target, and action. Also add it as a subview.
        (-[WebFileButton drawRect:]): Center icon in the "visual frame" part of the view,
	not the entire bounds.
        (-[WebFileButton setFilename:]): Don't show any icon when the filename is empty.
        (-[WebFileButton bestVisualFrameSize]): Implemented this.
        (-[WebFileButton visualFrame]): Ditto.
        (-[WebFileButton setVisualFrame:]): Ditto.
        (-[WebFileButton baseline]): Ditto.
        (-[WebFileButton beginSheet]): Added. Shared between button presses and other clicks.
        (-[WebFileButton chooseButtonPressed:]): Call beginSheet.
        (-[WebFileButton mouseDown:]): Ditto.
        (-[WebFileButton openPanelDidEnd:returnCode:contextInfo:]): Send the notification,
	WebCoreFileButtonFilenameChanged, when the filename is changed.

        * WebView.subproj/WebController.m: (-[WebController policyDelegate]):
	Add a FIXME about the leak I found here.

cblu's avatar
cblu committed
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2002-10-23  Chris Blumenberg  <cblu@apple.com>

	Call the arguments for plug-ins "attributes" everywhere.

        * Plugins.subproj/WebBaseNetscapePluginView.h:
        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView setAttributes:]):
        * Plugins.subproj/WebNetscapePluginEmbeddedView.h:
        * Plugins.subproj/WebNetscapePluginEmbeddedView.m:
        (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:mime:attributes:]):
        * Plugins.subproj/WebNullPluginView.h:
        * Plugins.subproj/WebNullPluginView.m:
        (-[WebNullPluginView initWithFrame:mimeType:attributes:]):
        (-[WebNullPluginView drawRect:]):
        * Plugins.subproj/WebPluginController.h:
        * Plugins.subproj/WebPluginController.m:
        (-[WebPluginController initWithWebFrame:]):
        (-[WebPluginController dealloc]):
        (-[WebPluginController addPluginView:]):
        * Plugins.subproj/WebPluginPackage.h:
        * Plugins.subproj/WebPluginPackage.m:
        (-[WebPluginPackage viewFactory]):
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge pluginViewWithPackage:attributes:baseURL:]):
        (-[WebBridge viewForPluginWithURL:attributes:baseURL:serviceType:]):
        (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):

cblu's avatar
cblu committed
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2002-10-23  Chris Blumenberg  <cblu@apple.com>

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge requestedURL]):
        (-[WebBridge viewForPluginWithURL:serviceType:arguments:baseURL:]):
        (-[WebBridge viewForJavaAppletWithFrame:baseURL:parameters:]):
        * WebCoreSupport.subproj/WebViewFactory.m:
        (-[WebViewFactory fileButton]):
        (-[WebViewFactory pluginsInfo]):

2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2002-10-23  Darin Adler  <darin@apple.com>

	- fix bug where plugins crashed closing a stream that was never opened

        * Plugins.subproj/WebBaseNetscapePluginStream.h: Change type for parameter of
	receivedError: to NPReason. It's not NPError.
        * Plugins.subproj/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream dealloc]): Assert that stream is destroyed by
	checking stream.ndata.
        (-[WebBaseNetscapePluginStream setResponse:]): Set stream.ndata to nil if the
	stream is not successfully created by NPP_NewStream.
        (-[WebBaseNetscapePluginStream destroyStreamWithReason:]): Added. Destroys the
	stream, but only if it's present. Also set stream.ndata to nil. This was the bug fix.
        (-[WebBaseNetscapePluginStream receivedError:]): Call destroyStreamWithReason:.
        (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Call destroyStreamWithReason:.

        * English.lproj/Localizable.strings: Update.
        * English.lproj/StringsNotToBeLocalized.txt: Update.

2327
2328
2329
2330
2331
2332
2002-10-23  Chris Blumenberg  <cblu@apple.com>

	Forgot to add WebPluginController back to the project after I had a project conflict.

        * WebKit.pbproj/project.pbxproj:

2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2002-10-23  Chris Blumenberg  <cblu@apple.com>

	Added WebPluginController which controls and reacts to plug-in requests. Its owned by the WebFrame.

        * Plugins.subproj/WebPluginController.h: Added.
        * Plugins.subproj/WebPluginController.m: Added.
        (-[WebPluginController initWithWebFrame:]):
        (-[WebPluginController showURL:inFrame:]):
        (-[WebPluginController showStatus:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFramePrivate dealloc]):
        (-[WebFrame pluginController]):

darin's avatar
darin committed
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2002-10-23  Darin Adler  <darin@apple.com>

	Add WebFileButton, to be used by WebCore soon. It's about 1/2
	done right now. Compiles but not used yet.

        * WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory fileButton]): Added.

        * WebCoreSupport.subproj/WebFileButton.h: Added.
        * WebCoreSupport.subproj/WebFileButton.m: Added.
        * WebKit.pbproj/project.pbxproj: Added WebFileButton files.

        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (-[WebSubresourceClient handle:didReceiveResponse:]): Add an assertion.

2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2002-10-23  Maciej Stachowiak  <mjs@apple.com>

        - fixed 2876448 - The authentication panel should give a note when
	the user tried to log in and failed

	Also, made the message different (and more helpful) when the
	authentication is for a proxy server.
	
        * Panels.subproj/WebAuthenticationPanel.m:
        (-[WebAuthenticationPanel setUpForRequest:]): Use different
	messages depending on proxy and previous failure count.

	Updated localized strings:
	
	* English.lproj/Localizable.strings:
        * English.lproj/StringsNotToBeLocalized.txt:

2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2002-10-23  Maciej Stachowiak  <mjs@apple.com>

	- fixed 2876446 - The label in the authentication panel needs to
	adjust its height depending on content

	Also improved [NSControl sizeToFitAndAdjustWindowHeight] method.
	
        * Panels.subproj/English.lproj/WebAuthenticationPanel.nib: Adjusted
	springs.
        * Panels.subproj/WebAuthenticationPanel.m:
	(-[WebAuthenticationPanel setUpForRequest:]): Use
	sizeToFitAndAdjustWindowHeight on main label.
	
        * Misc.subproj/WebNSControlExtras.m:
        (-[NSControl sizeToFitAndAdjustWindowHeight]): Improved the logic
	so the best height is picked while leaving the width
	alone. Before, the label would always come out to be a very wide
	single line.

2397
2398
2399
2400
2401
2402
2002-10-22  Maciej Stachowiak  <mjs@apple.com>

        * WebKit.pbproj/project.pbxproj: Made WebControllerSets.h
	private. Also alphabetized headers in target pane and subproject
	folders.

2403
2404
2405
2406
2407
2408
2409
2410
2002-10-22  Chris Blumenberg  <cblu@apple.com>

	load and unload is only a WebNetscapePluginPackage thing since you can't unload an NSBundle.

        * Plugins.subproj/WebBasePluginPackage.h:
        * Plugins.subproj/WebBasePluginPackage.m:
        * Plugins.subproj/WebNetscapePluginPackage.h:

2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2002-10-22  Chris Blumenberg  <cblu@apple.com>

	More moving stuff around for the new plug-in API. Added WebBasePluginPackage and added subclass WebPluginPackage. Also made WebNetscapePluginPackage a subclass of WebBasePluginPackage. 

        * Plugins.subproj/WebBasePluginPackage.h: Added.
        * Plugins.subproj/WebBasePluginPackage.m: Added.
        (+[WebBasePluginPackage pluginWithPath:]): creates a WebPluginPackage or WebNetscapePluginPackage
        (-[WebBasePluginPackage initWithPath:]):
        (-[WebBasePluginPackage name]):
        (-[WebBasePluginPackage path]):
        (-[WebBasePluginPackage filename]):
        (-[WebBasePluginPackage pluginDescription]):
        (-[WebBasePluginPackage extensionToMIMEDictionary]):
        (-[WebBasePluginPackage MIMEToExtensionsDictionary]):
        (-[WebBasePluginPackage MIMEToDescriptionDictionary]):
        (-[WebBasePluginPackage load]):
        (-[WebBasePluginPackage unload]):
        (-[WebBasePluginPackage isLoaded]):
        (-[WebBasePluginPackage description]):
        * Plugins.subproj/WebNetscapePluginDocumentView.m:
        (-[WebNetscapePluginDocumentView setDataSource:]):
        * Plugins.subproj/WebNetscapePluginPackage.h:
        * Plugins.subproj/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage initWithPath:]):
        * Plugins.subproj/WebPluginDatabase.h:
        * Plugins.subproj/WebPluginDatabase.m:
        (-[WebPluginDatabase pluginForMIMEType:]):
        (-[WebPluginDatabase pluginForExtension:]):
        (-[WebPluginDatabase pluginForFilename:]):
        (-[WebPluginDatabase MIMETypes]):
        (-[WebPluginDatabase init]):
        * Plugins.subproj/WebPluginPackage.h: Added.
        * Plugins.subproj/WebPluginPackage.m: Added.
        (-[WebPluginPackage initWithPath:]):
        * WebCoreSupport.subproj/WebViewFactory.m:
        (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): check the class of the plug-in when deciding which view to create.
        (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]): same here.
        * WebKit.pbproj/project.pbxproj:

2450
2451
2452
2453
2454
2455
2456
2002-10-22  David Hyatt  <hyatt@apple.com>

	Getting XML docs at least made for XML files...
	
        * WebView.subproj/WebHTMLRepresentation.m:
        (-[WebHTMLRepresentation setDataSource:]):

cblu's avatar
cblu committed
2457
2458
2459
2460
2461
2462
2002-10-22  Chris Blumenberg  <cblu@apple.com>

	Made new plug-in API headers private.

        * WebKit.pbproj/project.pbxproj:

darin's avatar
WebKit:    
darin committed
2463
2464
2465
2466
2467
2468
2469
2470
2471
2002-10-22  Darin Adler  <darin@apple.com>

        * Misc.subproj/WebKitErrors.h:
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:willSendRequest:]):
        (-[WebMainResourceClient handle:didReceiveResponse:]):
	Rename WebErrorLocationChangeInterruptedByURLPolicyChange to
	WebErrorLocationChangeInterruptedByPolicyChange.

2472
2473
2474
2475
2476
2477
2478
2002-10-22  Darin Adler  <darin@apple.com>

        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:didReceiveResponse:]):
	Send the new error whenever a policy change happens. The old code was
	sending a successful completion in the download and ignore cases.

sullivan's avatar
WebKit:    
sullivan committed
2479
2480
2481
2482
2483
2484
2485
2486
2487
2002-10-22  John Sullivan  <sullivan@apple.com>

	- fixed 3080873 -- Error in console when no bookmark file 
	found -[WebBookmarkGroup _loadBookmarkGroupGuts]

        * Bookmarks.subproj/WebBookmarkGroup.m:
        (-[WebBookmarkGroup _loadBookmarkGroupGuts]):
	removed ERROR that was useful only long ago.

2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2002-10-22  Richard Williamson  <rjw@apple.com>

        Added stubs from common WebResourceHandleDelegate base
        class.
        
        * Plugins.subproj/WebBaseNetscapePluginStream.h:
        * Plugins.subproj/WebNetscapePluginStream.h:
        * WebCoreSupport.subproj/WebSubresourceClient.h:
        * WebKit.pbproj/project.pbxproj:
        * WebView.subproj/WebBaseResourceHandleDelegate.h: Added.
        * WebView.subproj/WebBaseResourceHandleDelegate.m: Added.
        * WebView.subproj/WebMainResourceClient.h:

2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2002-10-22  Darin Adler  <darin@apple.com>

	Make the panel position itself above the main window.
	Too bad we can't use a sheet, but this is better than a random position.

        * WebCoreSupport.subproj/WebJavaScriptTextInputPanel.m:
        (-[WebJavaScriptTextInputPanel initWithPrompt:text:]):
	Use the new [NSWindow sizeToFitAndAdjustWindowHeight]
	and [NSControl sizeToFitAndAdjustWindowHeight].

        * Misc.subproj/WebNSControlExtras.h: Added.
        * Misc.subproj/WebNSControlExtras.m: Added.
        * Misc.subproj/WebNSWindowExtras.h: Added.
        * Misc.subproj/WebNSWindowExtras.m: Added.
        * WebKit.pbproj/project.pbxproj: Added above files.

        * English.lproj/StringsNotToBeLocalized.txt: Update.

kocienda's avatar
WebKit:    
kocienda committed
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2002-10-22  Ken Kocienda  <kocienda@apple.com>

        * Misc.subproj/WebKitErrors.h: Add new error code to signify that a location
	change has been interrupted by a change in the URLPolicy governing the load.
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:willSendRequest:]): Add code to check the URLPolicy
	for the URL in the request that is submitted to us in this delegate method. Send
	a locationChangeDone:forDataSource: message with an error using the newly-defined
	code in cases where the location change should be cancelled.

2529
2530
2531
2532
2533
2534
2535
2536
2537
2002-10-22  Chris Blumenberg  <cblu@apple.com>

	Added protocol headers for new plug-in API.

        * Plugins.subproj/WebPlugin.h: Added.
        * Plugins.subproj/WebPluginContainer.h: Added.
        * Plugins.subproj/WebPluginViewFactory.h: Added.
        * WebKit.pbproj/project.pbxproj:

2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2002-10-22  Chris Blumenberg  <cblu@apple.com>

	- Moved things around to make room for new plug-in API.
	- Renamed WebNetscapePlugin to WebNetscapePluginPackage.
	- Renamed WebNetscapePluginDatabase to WebPluginDatabase.

        * Plugins.subproj/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream setPluginPointer:]):
        * Plugins.subproj/WebBaseNetscapePluginView.h:
        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView plugin]):
        * Plugins.subproj/WebNetscapePluginDocumentView.m:
        (-[WebNetscapePluginDocumentView setDataSource:]):
        * Plugins.subproj/WebNetscapePluginEmbeddedView.h:
        * Plugins.subproj/WebNetscapePluginEmbeddedView.m:
        (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:mime:arguments:]):
        * Plugins.subproj/WebNetscapePluginNullEventSender.h: Added.
        * Plugins.subproj/WebNetscapePluginNullEventSender.m: Added.
        (-[WebNetscapePluginNullEventSender initWithPluginView:]):
        (-[WebNetscapePluginNullEventSender dealloc]):
        (-[WebNetscapePluginNullEventSender sendNullEvents]):
        (-[WebNetscapePluginNullEventSender stop]):
        * Plugins.subproj/WebNetscapePluginPackage.h: Added.
        * Plugins.subproj/WebNetscapePluginPackage.m: Added.
        (-[WebNetscapePluginPackage openResourceFile]):
        (-[WebNetscapePluginPackage closeResourceFile:]):
        (-[WebNetscapePluginPackage stringForStringListID:andIndex:]):
        (-[WebNetscapePluginPackage getPluginInfo]):
        (-[WebNetscapePluginPackage stringByResolvingSymlinksAndAliasesInPath:]):
        (-[WebNetscapePluginPackage initWithPath:]):
        (-[WebNetscapePluginPackage load]):
        (-[WebNetscapePluginPackage unload]):
        (-[WebNetscapePluginPackage NPP_SetWindow]):
        (-[WebNetscapePluginPackage NPP_New]):
        (-[WebNetscapePluginPackage NPP_Destroy]):
        (-[WebNetscapePluginPackage NPP_NewStream]):
        (-[WebNetscapePluginPackage NPP_StreamAsFile]):
        (-[WebNetscapePluginPackage NPP_DestroyStream]):
        (-[WebNetscapePluginPackage NPP_WriteReady]):
        (-[WebNetscapePluginPackage NPP_Write]):
        (-[WebNetscapePluginPackage NPP_HandleEvent]):
        (-[WebNetscapePluginPackage NPP_URLNotify]):
        (-[WebNetscapePluginPackage NPP_GetValue]):
        (-[WebNetscapePluginPackage NPP_SetValue]):
        (-[WebNetscapePluginPackage NPP_Print]):
        (-[WebNetscapePluginPackage MIMEToExtensionsDictionary]):
        (-[WebNetscapePluginPackage extensionToMIMEDictionary]):
        (-[WebNetscapePluginPackage MIMEToDescriptionDictionary]):
        (-[WebNetscapePluginPackage name]):
        (-[WebNetscapePluginPackage filename]):
        (-[WebNetscapePluginPackage path]):
        (-[WebNetscapePluginPackage isLoaded]):
        (-[WebNetscapePluginPackage pluginDescription]):
        (-[WebNetscapePluginPackage description]):
        (functionPointerForTVector):
        (tVectorForFunctionPointer):
        * Plugins.subproj/WebPlugin.h: Removed.
        * Plugins.subproj/WebPlugin.m: Removed.
        * Plugins.subproj/WebPluginDatabase.h:
        * Plugins.subproj/WebPluginDatabase.m:
        (+[WebPluginDatabase installedPlugins]):
        (-[WebPluginDatabase pluginForMIMEType:]):
        (-[WebPluginDatabase pluginForExtension:]):
        (-[WebPluginDatabase pluginForFilename:]):
        (-[WebPluginDatabase MIMETypes]):
        (-[WebPluginDatabase init]):
        * Plugins.subproj/WebPluginNullEventSender.h: Removed.
        * Plugins.subproj/WebPluginNullEventSender.m: Removed.
        * WebCoreSupport.subproj/WebViewFactory.m:
        (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]):
        (-[WebViewFactory pluginsInfo]):
        (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
        * WebKit.pbproj/project.pbxproj:
        * WebView.subproj/WebController.m:
        (+[WebController canShowMIMEType:]):

2614
2615
2616
2617
2002-10-22  Darin Adler  <darin@apple.com>

        * WebCoreSupport.subproj/WebJavaScriptTextInputPanel.m: Added missing import.

2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2002-10-22  Darin Adler  <darin@apple.com>

	- fixed 3077305 -- js dialog not yet implemented - crash (fatal error)

        * WebCoreSupport.subproj/WebViewFactory.m:
        (-[WebViewFactory runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]):
	Create a WebJavaScriptTextInputPanel and run it.

        * English.lproj/WebJavaScriptTextInputPanel.nib: Added.
        * WebCoreSupport.subproj/WebJavaScriptTextInputPanel.h: Added.
        * WebCoreSupport.subproj/WebJavaScriptTextInputPanel.m: Added.
        * WebKit.pbproj/project.pbxproj: Added 

2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2002-10-22  Chris Blumenberg  <cblu@apple.com>

	Use the mouseDown point instead of the mouseDragged point to determine the mouseOffset when dragging images. When you drag an image now, the point where you clicked is the point where the cursor is in relation to the drag image.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView mouseDown:]): retain the mouse down event
        (-[WebHTMLView mouseDragged:]): use the mouse down event
        * WebView.subproj/WebHTMLViewPrivate.h:
        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLViewPrivate dealloc]): release the mouse down event

darin's avatar
darin committed
2642
2643
2644
2645
2646
2647
2648
2002-10-21  Darin Adler  <darin@apple.com>

        * WebCoreSupport.subproj/WebViewFactory.h: Changed to use new protocol scheme so we
	get an error if we forget to implement something.
        * WebCoreSupport.subproj/WebViewFactory.m:
        (-[WebViewFactory runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): Stub.

rjw's avatar
rjw committed
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2002-10-21  Richard Williamson   <rjw@apple.com>

        More incremental tweaks.  Will be factoring common
        handle delegate behavior into base class.
        
        * Plugins.subproj/WebNetscapePluginStream.m:
        (-[WebNetscapePluginStream handle:didReceiveData:]):
        (-[WebNetscapePluginStream handleDidFinishLoading:]):
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge objectLoadedFromCache:response:size:]):
        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
        (-[WebSubresourceClient handle:didReceiveData:]):
        (-[WebSubresourceClient handleDidFinishLoading:]):
        * WebView.subproj/WebControllerPrivate.h:
        * WebView.subproj/WebControllerPrivate.m:
        (-[WebController _finsishedLoadingResourceFromDataSource:]):

trey's avatar
trey committed
2667
2668
2669
2670
2671
2672
2002-10-21  Trey Matteson  trey@apple.com

	Fixed typos and other doc comment errors found during API review.

        * WebView.subproj/WebController.h:

2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2002-10-21  Richard Williamson   <rjw@apple.com>

        Changed WebResourceLoadDelegate methods to include an identifier
        as first parameter.  This will help clients track callbacks relating
        to a particular resource.  Added identifierForInitialRequest:fromDataSource:
        so clients can create their own identifier.
        
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge objectLoadedFromCache:response:size:]):
        * WebCoreSupport.subproj/WebSubresourceClient.h:
        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (-[WebSubresourceClient handle:willSendRequest:]):
        (-[WebSubresourceClient handle:didReceiveResponse:]):
        (-[WebSubresourceClient handle:didReceiveData:]):
        (-[WebSubresourceClient handleDidFinishLoading:]):
        (-[WebSubresourceClient handle:didFailLoadingWithError:]):
        * WebView.subproj/WebController.m:
        (-[WebResourceLoadDelegate identifierForInitialRequest:fromDataSource:]):
        (-[WebResourceLoadDelegate resource:willSendRequest:fromDataSource:]):
        (-[WebResourceLoadDelegate resource:didReceiveResponse:fromDataSource:]):
        (-[WebResourceLoadDelegate resource:didReceiveContentLength:fromDataSource:]):
        (-[WebResourceLoadDelegate resource:didFinishLoadingFromDataSource:]):
        (-[WebResourceLoadDelegate resource:didFailLoadingWithError:fromDataSource:]):
        * WebView.subproj/WebMainResourceClient.h:
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient receivedError:forHandle:]):
        (-[WebMainResourceClient handleDidFinishLoading:]):
        (-[WebMainResourceClient handle:willSendRequest:]):
        (-[WebMainResourceClient handle:didReceiveResponse:]):
        (-[WebMainResourceClient handle:didReceiveData:]):
        (-[WebMainResourceClient handle:didFailLoadingWithError:]):
        * WebView.subproj/WebResourceLoadDelegate.h:

cblu's avatar
cblu committed
2706
2707
2708
2709
2710
2711
2712
2713
2714
2002-10-21  Chris Blumenberg  <cblu@apple.com>

	Changed content policy API to pass a response instead of MIME type so client can get the mime type and filename from one class.

        * WebView.subproj/WebControllerPolicyDelegate.h:
        * WebView.subproj/WebDefaultPolicyDelegate.m:
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient handle:didReceiveResponse:]):

2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2002-10-21  Darin Adler  <darin@apple.com>

	- fixed 3080512 -- REGRESSION: moving from old page to new one, we get blank white
	before the new one is ready

	Roll out a bunch of my changes, because they weren't complete. Added FIXMEs for the
	problems I was unsuccessfully trying to fix.

        * WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]):
        * WebView.subproj/WebView.m:
        (-[WebView initWithFrame:]), (-[WebView isOpaque]), (-[WebView drawRect:]):
	Roll back.

2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2002-10-21  Darin Adler  <darin@apple.com>

	- fixed 3080246 -- REGRESSION: Animated GIFs sometimes disappear after drag or scroll

	Once more, with feeling.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _setNeedsLayoutIfSizeChanged:]): Added setNeedsDisplay:YES here. The lack
	of this is what caused the bug. But also don't do any work when the size doesn't change.
	This prevents this from being called at all in the scrolling case, which is what we want.
        (-[WebHTMLView viewWillMoveToSuperview:]): Just the name change.
        (-[WebHTMLView layout]): Store the layout size for the above methods.
        * WebView.subproj/WebHTMLViewPrivate.h: Add a place to store the size.

        * WebView.subproj/WebImageView.m: (-[WebImageView layout]):
	Roll this change back in.

2002-10-21  Darin Adler  <darin@apple.com>
2746
2747
2748
2749
2750
2751
2752

	- fixed 3080246 -- REGRESSION: Animated GIFs sometimes disappear after drag or scroll

        * WebView.subproj/WebImageView.m: (-[WebImageView layout]):
	My change to this caused the regression. Not sure why, but I'll just back out
	because the change wasn't important.

2753