ChangeLog-2002-12-03 684 KB
Newer Older
rjw's avatar
rjw committed
1 2 3 4 5 6 7
2002-11-21  Richard Williamson   <rjw@apple.com>

        Fixed performance regression!  Argh.
        
        * khtml/rendering/font.cpp:
        (Font::width):

darin's avatar
darin committed
8 9 10 11 12
2002-11-21  Darin Adler  <darin@apple.com>

        * force-js-clean-timestamp: Trigger a rebuild because of the
	size change in ValueImp.

13 14 15 16 17 18 19 20 21
2002-11-21  Darin Adler  <darin@apple.com>

	- fixed 3107286 -- REGRESSION: unrepro assertion failure in KWQKHTMLPart.mm keyEvent

        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent):
	Handle case of nil document as well as case of nil focus node.

        * kwq/WebCoreBridge.mm: Tweak whitespace.

darin's avatar
darin committed
22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38
2002-11-20  Darin Adler  <darin@apple.com>

	- fixed 3107383 -- clicking link on cnet.com leads to assertion failure

	When we removed a frame, we were leaving behind an empty WebView. Yuck.

        * kwq/KWQScrollView.mm:
        (QScrollView::addChild): Use the new getOuterView.
        (QScrollView::removeChild): Ditto. This was the bug fix.
        * kwq/KWQWidget.h: Add getOuterView.
        * kwq/KWQWidget.mm:
        (QWidget::frameGeometry): Use the new getOuterView.
        (QWidget::setFrameGeometry): Ditto.
        (QWidget::getOuterView): Added. Does the WebCoreFrameView magic to find
	the WebView instead of the WebHTMLView. Yuck.
        (QWidget::paint): Use the new getOuterView.

darin's avatar
darin committed
39 40 41 42
2002-11-20  Darin Adler  <darin@apple.com>

        * force-js-clean-timestamp: Again.

43 44 45 46 47 48 49 50
2002-11-20  David Hyatt  <hyatt@apple.com>

	Fix the mac.com line-breaking bug.  This was not a regression
	but was present in Konq.
	
        * khtml/rendering/bidi.cpp:
        (RenderFlow::findNextLineBreak):

mjs's avatar
mjs committed
51 52 53 54
2002-11-20  Maciej Stachowiak  <mjs@apple.com>

        * force-js-clean-timestamp: Work around PB lameness yet again.

55 56 57 58
2002-11-19  Darin Adler  <darin@apple.com>

        * force-js-clean-timestamp: Make other people's builds work.

59 60 61 62 63 64 65
2002-11-19  David Hyatt  <hyatt@apple.com>

	I screwed up the line breaking for inline replaced elements.
	
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::calcInlineMinMaxWidth):

66 67 68 69 70 71 72 73 74
2002-11-19  Darin Adler  <darin@apple.com>

	- another atomic identifier scrub pass; make the conversion to Identifier explicit

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLCollection::tryCall): Add explicit Identifier() conversion.
        (KJS::HTMLCollectionProtoFunc::tryCall): Ditto.
        * khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): And again.

75 76 77 78 79 80 81 82 83 84 85 86 87 88
2002-11-19  David Hyatt  <hyatt@apple.com>

	Fix for 3049663.  Table cells don't grow to accommodate block
	overflow.
	
        * khtml/rendering/bidi.cpp:
        (RenderFlow::layoutInlineChildren):
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::RenderFlow):
        (RenderFlow::layout):
        (RenderFlow::layoutBlockChildren):
        * khtml/rendering/render_flow.h:
        * khtml/rendering/render_object.h:

darin's avatar
darin committed
89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130
2002-11-19  Darin Adler  <darin@apple.com>

	- next step towards atomic identifiers; Identifier is no longer derived from UString

        * khtml/ecma/kjs_binding.cpp:
        (Identifier::string): Added.
        (Identifier::qstring): Added.

        * khtml/ecma/kjs_binding.h:
        * khtml/ecma/kjs_css.cpp:
        (jsNameToProp):
        (DOMCSSStyleDeclaration::tryPut):
        (DOMStyleSheet::tryPut):
        (DOMStyleSheetList::tryGet):
        (DOMMediaList::tryGet):
        (DOMCSSRuleList::tryGet):
        (DOMCSSValueList::tryGet):
        * khtml/ecma/kjs_dom.cpp:
        (DOMNodeList::hasProperty):
        (DOMNodeList::tryGet):
        (DOMNodeListFunc::DOMNodeListFunc):
        (DOMElement::tryGet):
        (DOMNamedNodeMap::hasProperty):
        (DOMNamedNodeMap::tryGet):
        (DOMNamedNodesCollection::tryGet):
        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLDocument::tryGet):
        (HTMLElementFunction::HTMLElementFunction):
        (KJS::HTMLElement::putValue):
        (KJS::HTMLCollection::hasProperty):
        (KJS::HTMLCollection::tryGet):
        (KJS::HTMLSelectCollection::tryPut):
        (OptionConstructorImp::OptionConstructorImp):
        * khtml/ecma/kjs_navigator.cpp:
        (Plugins::get):
        (MimeTypes::get):
        (Plugin::get):
        * khtml/ecma/kjs_window.cpp:
        (WindowFunc::tryCall):
        (FrameArray::get):
	Use lengthPropertyName instead of "length" for better speed.

131 132 133 134 135 136
2002-11-19  David Hyatt  <hyatt@apple.com>

	Fix backgrounds not painting in deployment builds.
        * khtml/rendering/render_box.cpp:
        (RenderBox::paintBackground):

darin's avatar
darin committed
137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164
2002-11-19  Darin Adler  <darin@apple.com>

	- a first step towards atomic identifiers in JavaScript

	Most places that work with identifiers now use Identifier
	instead of UString.

        * khtml/ecma/kjs_binding.cpp:
        * khtml/ecma/kjs_binding.h:
        * khtml/ecma/kjs_css.cpp:
        * khtml/ecma/kjs_css.h:
        * khtml/ecma/kjs_dom.cpp:
        * khtml/ecma/kjs_dom.h:
        * khtml/ecma/kjs_events.cpp:
        * khtml/ecma/kjs_events.h:
        * khtml/ecma/kjs_html.cpp:
        * khtml/ecma/kjs_html.h:
        * khtml/ecma/kjs_navigator.cpp:
        * khtml/ecma/kjs_navigator.h:
        * khtml/ecma/kjs_range.cpp:
        * khtml/ecma/kjs_range.h:
        * khtml/ecma/kjs_traversal.cpp:
        * khtml/ecma/kjs_traversal.h:
        * khtml/ecma/kjs_views.cpp:
        * khtml/ecma/kjs_views.h:
        * khtml/ecma/kjs_window.cpp:
        * khtml/ecma/kjs_window.h:

darin's avatar
darin committed
165 166 167 168
2002-11-18  Darin Adler  <darin@apple.com>

        * force-js-clean-timestamp: Another Object change.

169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239
2002-11-18  David Hyatt  <hyatt@apple.com>

	Implement phased painting to correct the paint order of blocks,
	floats, and inlines.
	
        * khtml/rendering/render_body.cpp:
        (RenderBody::paintBoxDecorations):
        * khtml/rendering/render_body.h:
        * khtml/rendering/render_box.cpp:
        (RenderBox::paint):
        (RenderBox::paintBoxDecorations):
        (RenderBox::paintBackground):
        * khtml/rendering/render_box.h:
        * khtml/rendering/render_br.h:
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::paint):
        (RenderFlow::paintObject):
        (RenderFlow::paintFloats):
        (RenderFlow::addChild):
        * khtml/rendering/render_flow.h:
        * khtml/rendering/render_html.cpp:
        (RenderHtml::setStyle):
        (RenderHtml::paint):
        (RenderHtml::paintBoxDecorations):
        * khtml/rendering/render_html.h:
        * khtml/rendering/render_image.cpp:
        (RenderImage::setStyle):
        (RenderImage::paintObject):
        * khtml/rendering/render_image.h:
        * khtml/rendering/render_layer.cpp:
        (RenderLayer::paint):
        (RenderLayer::nodeAtPoint):
        * khtml/rendering/render_list.cpp:
        (RenderListItem::paint):
        (RenderListItem::paintObject):
        (RenderListMarker::paint):
        (RenderListMarker::paintObject):
        * khtml/rendering/render_list.h:
        * khtml/rendering/render_object.cpp:
        (RenderObject::RenderObject):
        (RenderObject::paintBorder):
        (RenderObject::paintOutline):
        (RenderObject::paint):
        (RenderObject::dump):
        (RenderObject::setStyle):
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_replaced.cpp:
        (RenderReplaced::paint):
        (RenderWidget::setStyle):
        (RenderWidget::paintObject):
        * khtml/rendering/render_replaced.h:
        * khtml/rendering/render_root.cpp:
        (RenderRoot::paint):
        (RenderRoot::paintObject):
        * khtml/rendering/render_root.h:
        * khtml/rendering/render_table.cpp:
        (RenderTable::paint):
        (RenderTableCell::RenderTableCell):
        (RenderTableCell::setStyle):
        (RenderTableCell::paint):
        (RenderTableCell::paintBoxDecorations):
        * khtml/rendering/render_table.h:
        * khtml/rendering/render_text.cpp:
        (TextSlave::paintSelection):
        (TextSlave::paintDecoration):
        (TextSlave::paintBoxDecorations):
        (RenderText::paintObject):
        (RenderText::paint):
        (RenderText::paintTextOutline):
        * khtml/rendering/render_text.h:

240 241 242 243
2002-11-18  Darin Adler  <darin@apple.com>

        * force-js-clean-timestamp: I changed the size of ObjectImp.

244 245 246 247 248 249 250 251 252 253 254
2002-11-18  David Hyatt  <hyatt@apple.com>

	Fix crazyapplerumors.com.  I had the logic backwards. CSS
	padding beats cellpadding.
	
        * khtml/rendering/render_table.cpp:
        (RenderTableCell::paddingTop):
        (RenderTableCell::paddingBottom):
        (RenderTableCell::paddingLeft):
        (RenderTableCell::paddingRight):

hyatt's avatar
hyatt committed
255 256 257 258 259 260 261
2002-11-18  David Hyatt  <hyatt@apple.com>

	Fix crash on espn.com.
	
        * khtml/rendering/render_object.cpp:
        (RenderObject::setLayouted):

262 263 264 265 266 267 268
2002-11-18  David Hyatt  <hyatt@apple.com>

	Fix my <konqblock> regression on ign.com.
	
        * khtml/html/htmlparser.cpp:
        (KHTMLParser::insertNode):

mjs's avatar
mjs committed
269 270 271 272
2002-11-18  Maciej Stachowiak  <mjs@apple.com>

        * force-js-clean-timestamp: Rebuild for JSC changes.

273 274 275 276
2002-11-18  Darin Adler  <darin@apple.com>

        * force-js-clean-timestamp: Touch files to make the build work.

277 278 279 280 281 282 283 284
2002-11-18  Richard Williamson   <rjw@apple.com>

        Fixed 3103004.  REGRESSION: word-spacing/letter-spacing applied when they shouldn't be
        This was actually NOT a regression.  khtml wasn't recognizing the 'normal' value for the
        word and letter spacing properties.  So it incorrectly substituted a -1 spacing.

        * khtml/css/cssstyleselector.cpp:

hyatt's avatar
hyatt committed
285 286 287 288 289 290 291 292
2002-11-18  David Hyatt  <hyatt@apple.com>

	Fix render_body's repaint method.
	
        * khtml/rendering/render_body.cpp:
        (RenderBody::repaint):
        * khtml/rendering/render_body.h:

293 294 295 296 297 298 299 300 301
2002-11-18  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3103711 - Alexander does not complete JavaScript iBench
	
        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLDocument::putValue): Resolve URL for location property
	relative to the base URL of the frame where the JavaScript is
	executing, not the target frame.

302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318
2002-11-18  David Hyatt  <hyatt@apple.com>

	Yay! Found the main cause of :hover feedback being so
	slow on links.  The diff function for styles was
	considering a color change as a containing block layout
	instead of just a repaint.  With this fix, we will no
	longer lay out when you hover over a link whose color
	is different (remember that laying out causes the whole
	page to repaint).

	There's still some work to do to optimize this further,
	since we do repaint the containing block still, but this
	should be good enough for beta.
	
        * khtml/rendering/render_style.cpp:
        (RenderStyle::diff):

319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335
2002-11-17  David Hyatt  <hyatt@apple.com>

	Don't use the immediate painting code for now.  Revert
	to non-immediate code.  Using the non-immediate path I
	have managed to fix all the regressions except for 
	mrskin losing updates in its marquee (this works only with
	immediate painting) and the general scrollbar regression 
	(which I just don't understand).
	
        * khtml/html/html_documentimpl.cpp:
        (HTMLDocumentImpl::close):
        * khtml/rendering/render_object.cpp:
        (RenderObject::setLayouted):
        * khtml/rendering/render_root.cpp:
        (RenderRoot::repaintRectangle):
        (RenderRoot::repaint):

336 337 338 339 340 341 342 343 344 345 346
2002-11-17  David Hyatt  <hyatt@apple.com>

	More refinements to immediate painting code.  Still doesn't
	fix the scrollbar problem though. :(
	
        * khtml/html/html_documentimpl.cpp:
        (HTMLDocumentImpl::close):
        * khtml/khtmlview.cpp:
        (KHTMLView::init):
        (KHTMLView::timerEvent):

347 348 349 350 351 352 353 354 355 356 357 358
2002-11-17  David Hyatt  <hyatt@apple.com>

	Make immediate repainting of the root element more robust.
	
        * khtml/html/html_documentimpl.cpp:
        (HTMLDocumentImpl::close):
        * khtml/khtmlview.cpp:
        (KHTMLView::unscheduleRepaint):
        * khtml/khtmlview.h:
        * khtml/rendering/render_root.cpp:
        (RenderRoot::repaint):

darin's avatar
darin committed
359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405
2002-11-17  Darin Adler  <darin@apple.com>

	- moved all NSURL and CFURL use out of WebCore

        * kwq/KWQKURL.h: Remove getNSURL() and getNSURLFromString().
        * kwq/KWQKURL.mm: Ditto.

        * kwq/KWQKCookieJar.mm:
        (KWQKCookieJar::cookie): Pass an NSString instead of an NSURL.
        (KWQKCookieJar::setCookie): Ditto.
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::openURL): Ditto.
        (KWQKHTMLPart::openURLRequest): Ditto.
        (KWQKHTMLPart::submitForm): Ditto.
        (KWQKHTMLPart::urlSelected): Ditto.
        (KWQKHTMLPart::createPart): Ditto.
        (KWQKHTMLPart::redirectionTimerStartedOrStopped): Ditto.
        (KWQKHTMLPart::userAgent): Ditto.
        (KWQKHTMLPart::requestedURLString): Receive an NSString instead of an NSURL.
        * kwq/KWQKHTMLPartBrowserExtension.mm:
        (KHTMLPartBrowserExtension::createNewWindow): Pass an NSString instead of an NSURL.
        (KHTMLPartBrowserExtension::setIconURL): Ditto.
        (KHTMLPartBrowserExtension::setTypedIconURL): Ditto.
        * kwq/KWQKJavaAppletWidget.h: Remove use of NSURL, just use QString instead.
        * kwq/KWQKJavaAppletWidget.mm:
        (KJavaAppletWidget::KJavaAppletWidget): No need to set the QString to nil.
        (KJavaAppletWidget::~KJavaAppletWidget): No need to release the QString.
        (KJavaAppletWidget::showApplet): Pass an NSString instead of an NSURL.
        * kwq/KWQLoader.mm:
        (KWQServeRequest): Pass an NSString instead of an NSURL.
        (KWQCheckCacheObjectStatus): Ditto.
        * kwq/WebCoreBridge.h: Change all methods to use NSString instead of NSURL.
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge openURL:reload:headers:]): Receive an NSString instead of an NSURL.
        (-[WebCoreBridge completeURLForDOMString:]): Return an NSString instead of an NSURL.
        (-[WebCoreBridge elementAtPoint:]): WebCoreElementLinkURL and WebCoreElementImageURL
	are now strings.
        (-[WebCoreBridge URL]): Return an NSString instead of an NSURL.
        * kwq/WebCoreCookieAdapter.h: Change all methods to use NSString instead of NSURL.
        * kwq/WebCoreCookieAdapter.m:
        (-[WebCoreCookieAdapter cookiesForURL:]): Ditto.
        (-[WebCoreCookieAdapter setCookies:forURL:policyBaseURL:]): Ditto.

        * khtml/rendering/render_applet.cpp: (RenderApplet::processArguments):
	Tweaked this file a tiny bit, mainly because header dependencies weren't working
	and we need this file to be recompiled due to inline function changes.

406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440
2002-11-17  David Hyatt  <hyatt@apple.com>

	Add support for specifying whether repaint should be immediate or
	not.  Default to async for now to maintain current behavior.

	For clipped object repainting (e.g., livepage.apple.com and mrskin)
	switch to immediate repainting, since this makes the marquees
	faster, stops dropping updates, and keeps the hover effects and
	painting on the rest of the page fast (since the marquee rect doesn't
	get unioned with links or images that you roll over).
	
        * khtml/rendering/render_box.cpp:
        (RenderBox::repaint):
        (RenderBox::repaintRectangle):
        * khtml/rendering/render_box.h:
        * khtml/rendering/render_html.cpp:
        (RenderHtml::repaint):
        * khtml/rendering/render_html.h:
        * khtml/rendering/render_object.cpp:
        (RenderObject::setLayouted):
        (RenderObject::repaintRectangle):
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_root.cpp:
        (RenderRoot::repaintRectangle):
        (RenderRoot::repaint):
        * khtml/rendering/render_root.h:
        * khtml/rendering/render_table.cpp:
        (RenderTableRow::repaint):
        (RenderTableCell::repaintRectangle):
        (RenderTableCell::repaint):
        * khtml/rendering/render_table.h:
        * khtml/rendering/render_text.cpp:
        (RenderText::repaint):
        * khtml/rendering/render_text.h:

mjs's avatar
mjs committed
441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469
2002-11-17  Maciej Stachowiak  <mjs@apple.com>

	- fixed 2949193 - implement onKeyDown, onKeyPress, and onKeyUp event handlers
	
        * khtml/html/html_formimpl.cpp:
        (HTMLGenericFormElementImpl::defaultEventHandler):
        * kwq/KWQEvent.h:
        * kwq/KWQEvent.mm:
        (QKeyEvent::QKeyEvent): Implemented.
        (QKeyEvent::key): Likewise.
        (QKeyEvent::state): Likewise.
        (QKeyEvent::accept): Likewise.
        (QKeyEvent::ignore): Likewise.
        (QKeyEvent::isAutoRepeat): Likewise.
        (QKeyEvent::text): Likewise.
        (QKeyEvent::ascii): Likewise.
        (QKeyEvent::count): Likewise.
        (QKeyEvent::isAccepted): Likewise.
        * kwq/KWQKHTMLPart.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::keyEvent): Translate the event to a QEvent and send
	it through the DOM event mechanism.
        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge interceptKeyEvent:toView:]): Pass event to the
	KWQ part.
	* kwq/WebCoreBridgePrivate.h: Added.
        * WebCore.pbproj/project.pbxproj: Added new file.

470 471 472 473 474 475 476 477
2002-11-17  David Hyatt  <hyatt@apple.com>

	Don't discard linefeeds after elements with no close tag
	(e.g., <img> or <input>).
	
        * khtml/html/htmltokenizer.cpp:
        (HTMLTokenizer::parseTag):

478 479 480 481 482 483 484 485 486
2002-11-17  David Hyatt  <hyatt@apple.com>

	Fix for slashdot table mispositioning in the upper right.
	Now that we fixed <td> to set to -konq-center when align="center"
	is specified, the style rules are no longer necessary in
	html4.css (and are in fact harmful).
	
        * khtml/css/html4.css:

487 488 489 490 491 492 493 494
2002-11-17  David Hyatt  <hyatt@apple.com>

	Fix for 3038168.  Duh.  Remember to be case-insensitive when
	checking the type of the <style> attribute.
	
        * khtml/html/html_headimpl.cpp:
        (HTMLStyleElementImpl::parseAttribute):

495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525
2002-11-17  David Hyatt  <hyatt@apple.com>

	This is a fix for bug 3058470.  The bug was that replaced elements
	were computing their min and max widths wrong.  Specifically they
	were not adding in borders and padding!  This means that any image
	with a border around it would potentially break to another line
	too early.

	Once I fixed this for replaced elements I then went in and
	fixed form controls.  I added two APPLE_CHANGES features for
	our form controls.  First I overrode the border/padding functions
	to always return 0 for all form controls, since no Aqua control
	honors border/padding (nor should it).  This fixes the menulist
	at the top of wired.com.

	Second I made sure that certain controls will ignore CSS-specified
	heights and always use their intrinsic heights.  These include
	<select size=1> (combobox), single line text fields, and buttons.
	I allow listboxes and textareas to honor height.
	
        * khtml/rendering/render_box.cpp:
        (RenderBox::contentWidth):
        (RenderBox::contentHeight):
        (RenderBox::calcWidth):
        (RenderBox::calcHeight):
        * khtml/rendering/render_form.h:
        * khtml/rendering/render_image.h:
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_replaced.cpp:
        (RenderReplaced::calcMinMaxWidth):

526 527 528 529 530 531 532
2002-11-16  David Hyatt  <hyatt@apple.com>

	Fix for 3078240, <pre> should not establish its own text-align,
	but should instead inherit from its parent.
	
        * khtml/css/html4.css:

533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555
2002-11-16  David Hyatt  <hyatt@apple.com>

	Rewrite the calculation of min and max width for <pre>s.  This
	is the second stage of the whitespace rewrite (third stage
	will be to stop morphing newlines).

	This should fix a bunch of bugs, e.g., especially if you ever
	did the following: 
	<td><pre><span>foo</span>
	   more text after the newline</pre></td>

	The new code now properly handles building up the correct min/max
	width for the <pre>.

	If anyone recalls seeing any bugs like this, let me know and
	I can close them.
	
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::calcInlineMinMaxWidth):
        * khtml/rendering/render_text.cpp:
        (RenderText::trimmedMinMaxWidth):
        (RenderText::calcMinMaxWidth):

556 557 558 559 560 561 562 563
2002-11-16  David Hyatt  <hyatt@apple.com>

	Fix more edge cases with whitespace handling that caused some
	lines to be too long (and unselectable).
	
        * khtml/rendering/bidi.cpp:
        (appendRunsForObject):

564 565 566 567 568 569 570 571 572 573
2002-11-16  David Hyatt  <hyatt@apple.com>

	Make <caption> error-handling more robust.

	Specifically, handle <tr> and <td> misplaced inside
	<caption>s and still make them be part of the table.
	
        * khtml/html/htmlparser.cpp:
        (KHTMLParser::insertNode):

574 575 576 577 578 579 580 581 582 583 584 585
2002-11-16  David Hyatt  <hyatt@apple.com>

	Implement the collapsing top margin quirk for <body> (the same
	quirk used for table cells) and make sure it works even when the
	<body> has margins of its own.

	Fixes www.eflightpacks.com (the top frame was shoved down because
	the <p> margin didn't collapse away).
	
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::layoutBlockChildren):

586 587 588 589 590 591 592 593 594 595 596 597
2002-11-16  David Hyatt  <hyatt@apple.com>

	Sigh. Amazingly enough, all other browsers seem to treat
	stray </p>s as <p></p> (Mac IE treats it as <br>, but
	I'm going with the WinIE/Gecko behavior of <p></p>).

	This fixes bug 3063699.
	
        * khtml/html/htmlparser.cpp:
        (KHTMLParser::processCloseTag):
        (KHTMLParser::popBlock):

598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623
2002-11-15  David Hyatt  <hyatt@apple.com>

	Fix for livepage.apple.com slowness.  Ensure that 
	clipped regions only paint their own rectangles
	when they or any children inside of them need to
	be reflowed.

	This fix is intended as an interim band-aid for a much
	larger problem (that all of layout doesn't just auto-invalidate
	the regions it needs to, and that DHTML doesn't have
	specialized behavior to avoid async repainting or even
	relayout when only a repaint is required).
	
        * khtml/khtmlview.cpp:
        (KHTMLView::timerEvent):
        * khtml/rendering/render_container.cpp:
        (RenderContainer::removeChildNode):
        (RenderContainer::appendChildNode):
        (RenderContainer::insertChildNode):
        (RenderContainer::layout):
        * khtml/rendering/render_object.cpp:
        (RenderObject::setLayouted):
        (RenderObject::scheduleRelayout):
        * khtml/rendering/render_root.cpp:
        (RenderRoot::repaintRectangle):

624 625 626 627 628 629 630 631
2002-11-15  David Hyatt  <hyatt@apple.com>

	Fix the problem where the last lines of paragrpahs were getting
	justified incorrectly.
	
        * khtml/rendering/bidi.cpp:
        (RenderFlow::findNextLineBreak):

632 633 634 635 636 637 638 639
2002-11-15  David Hyatt  <hyatt@apple.com>

	Fix bustage with <nobr> tags.  Inline nowrap elements were
	breaking on images when they shouldn't have.
	
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::calcInlineMinMaxWidth):

kocienda's avatar
kocienda committed
640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658
2002-11-15  Ken Kocienda  <kocienda@apple.com>

	Fix for this bug:

	Radar 3102708 (REGRESSION: assertion failure backing up to page)

	KWQCheckCacheObjectStatus did not create an NSURL in a way that 
	dealt with the fact that we handle non-NSURL-compliant URL strings.
	I have fixed it so it does, and in the process, factored out
	the code to do it into a new KURL static function (KURL::getNSURLFromString).

        * kwq/KWQKURL.h:
        * kwq/KWQKURL.mm:
        (KURL::getNSURL): Now calls through to KURL::getNSURLFromString
        (KURL::encode_string)
        (KURL::getNSURLFromString): New function to handle NSURL creation
        * kwq/KWQLoader.mm:
        (KWQCheckCacheObjectStatus)

hyatt's avatar
hyatt committed
659 660 661 662 663 664 665
2002-11-15  David Hyatt  <hyatt@apple.com>

	Fix asserts in tables.
	
        * khtml/rendering/render_table.cpp:
        (RenderTableRow::layout):

666 667 668 669 670 671 672 673
2002-11-15  David Hyatt  <hyatt@apple.com>

	Fix for whitespace regressions that caused text overlapping
	and text spilling.
	
        * khtml/rendering/bidi.cpp:
        (appendRunsForObject):

674 675 676 677 678 679 680 681 682 683
2002-11-15  David Hyatt  <hyatt@apple.com>

	Fix newlines getting stripped out of textareas by not making
	rendertext objects for children of textareas.
	
        * khtml/rendering/render_form.h:
        * khtml/rendering/render_object.h:
        * khtml/xml/dom_textimpl.cpp:
        (TextImpl::attach):

684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708
2002-11-15  David Hyatt  <hyatt@apple.com>

	Make <form> inside <table> stay inside the <table> but demote
	itself to a leaf.  Then the children of the <form> are treated
	as though they occurred underneath the <table> itself.  Everything
	KHTML does with this is completely wrong but this band-aid should
	hopefully suffice until 1.0.

	Also allowing <input type="hidden"> to be constructed and attached
	under <table>s.  Since they have no render objects this is safe.
	Again, total hack, since CSS2 anonymous table construction should be
	implemented and that would have fixed all this.

	This collection of hacks makes travelocity render correctly on the
	PLT.
	
        * khtml/css/html4.css:
        * khtml/html/dtd.cpp:
        (DOM::checkChild):
        * khtml/html/html_tableimpl.cpp:
        (HTMLTableElementImpl::addChild):
        * khtml/html/htmlparser.cpp:
        (KHTMLParser::parseToken):
        (KHTMLParser::insertNode):

709 710 711 712 713 714 715 716 717
2002-11-15  David Hyatt  <hyatt@apple.com>

	Fix Hixie's blog.  Background images can be transparent, so
	if the root's color isn't valid always do a fixup even if you
	have a valid background image.
	
        * khtml/rendering/render_html.cpp:
        (RenderHtml::printBoxDecorations):

718 719 720 721 722
2002-11-15  Darin Adler  <darin@apple.com>

        * kwq/KWQWindowWidget.mm: (KWQWindowWidget::setFrameGeometry):
	Oops. Make that display:YES.

723 724 725 726 727 728 729
2002-11-15  Darin Adler  <darin@apple.com>

	- fixed 3090219 -- Window jumps up and down when loading nikon page

        * kwq/KWQWindowWidget.mm: (KWQWindowWidget::setFrameGeometry):
	Don't pass display:NO when resizing the window.

730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747
2002-11-15  Ken Kocienda  <kocienda@apple.com>

	Remove characters RFC 2396 describes as "unwise" from the
	BadChar character class. This causes them to remain unescaped
	in KURL objects. As a result, some extra escaping needed to 
	be added into the getNSURL() function to enable NSURL 
	objects to be created using a KURL.

	This enables me to fix this bug:
	Radar 3050437 (Clicking link leads to page with garbled content)

	Note, however, that my fix for 3050437 relies on this bug remaining unfixed:

	Radar 3102332 (Square bracket characters "sneak through" CFURL illegal character checks)

        * kwq/KWQKURL.mm:
        (KURL::getNSURL)

darin's avatar
Tools:  
darin committed
748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769
2002-11-15  Darin Adler  <darin@apple.com>

	- fixed 3027460 -- text areas don't have focus rectangles
	- fixed 2937204 -- text areas have solid black borders

        * kwq/KWQSignal.mm: (KWQSignal::disconnect):
	Add a special case so we don't hear about finishedParsing all the time.

        * kwq/KWQTextArea.mm:
        (-[KWQTextArea initWithFrame:]): Use a bezel border, not a line border.
        (-[KWQTextArea getCursorPositionAsIndex:inParagraph:]): Fix bug where it would
	return a bogus value for an empty text area.
        (-[KWQTextArea setCursorPositionToIndex:inParagraph:]): Use setSelectedRange:
	ratherr than setMarkedText:selectedRange:.
        (-[KWQTextArea drawRect:]): Draw a focus ring if our text view is first responder.
        (-[KWQTextArea _KWQ_setKeyboardFocusRingNeedsDisplay]): Added.
        (-[KWQTextAreaTextView becomeFirstResponder]): Call _KWQ_setKeyboardFocusRingNeedsDisplay.
        (-[KWQTextAreaTextView resignFirstResponder]): Call _KWQ_setKeyboardFocusRingNeedsDisplay.
        (-[NSView _KWQ_setKeyboardFocusRingNeedsDisplay]): Calls the same thing on parent.

        * WebCore.pbproj/project.pbxproj: PB is a cruel master.

mjs's avatar
mjs committed
770 771 772 773 774
2002-11-15  Maciej Stachowiak  <mjs@apple.com>

        * khtml/html/html_formimpl.cpp:
        (HTMLInputElementImpl::attach): Removed a stray printf.

darin's avatar
darin committed
775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791
2002-11-14  Darin Adler  <darin@apple.com>

	- fixed most of the problems with OPTGROUP

        * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
	Make OPTGROUPs pop out of other unclosed OPTGROUPs, not just out of options.

        * kwq/KWQListBox.h: Add private member function.
        * kwq/KWQListBox.mm:
        (QListBox::insertItem): Use shared insertItem function.
        (QListBox::insertGroupLabel): Create an attributed string for the group label,
	with bold font.
        (-[KWQListBoxTableViewDelegate tableView:shouldSelectRow:]): Return YES only
	for the plain strings, that way you can't select the group labels.

        * WebCore.pbproj/project.pbxproj: Let PB do its thing.

792 793 794 795 796 797 798 799 800 801
2002-11-14  David Hyatt  <hyatt@apple.com>

	Fix spinner.com mislayout on the PLT.  Make sure 
	<input type=image> honors the width attribute and
	make sure that its render object calls updateFromElement.
	
        * khtml/html/html_formimpl.cpp:
        (HTMLInputElementImpl::parseAttribute):
        (HTMLInputElementImpl::attach):

802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820
2002-11-14  David Hyatt  <hyatt@apple.com>

	Move text measurement and layout beyond onload.  This
	shoudl speed up i-bench substantially and morrison's
	PLT test slightly.

	Also allow <table>s as children of <p> and <h1>-<h6>.
	This fixes floats on slashdot.org (the left side) and
	the floating tables in articles on wired.com.
	
        * khtml/html/dtd.cpp:
        (DOM::checkChild):
        * khtml/html/html_documentimpl.cpp:
        (HTMLDocumentImpl::HTMLDocumentImpl):
        (HTMLDocumentImpl::close):
        * khtml/html/html_documentimpl.h:
        * khtml/html/htmlparser.cpp:
        (KHTMLParser::insertNode):

821 822 823 824 825 826 827 828 829 830
2002-11-14  Richard Williamson  <rjw@apple.com>

        Fixed 3099505.  With the recent white space changes, multiple slaves may
        be created for contiguous text on the same line.  The fix changes the
        iteration order of over the slave array.  Now, when searching for the end
        point of a line we'll always find the last slave on a line first.
        
        * khtml/khtml_part.cpp:
        (lastSlaveAt):

831 832 833 834 835 836 837
2002-11-14  Darin Adler  <darin@apple.com>

	- fixed 3095854 -- small select boxes get no scrollbar

        * kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines):
	Always use a minimum of 4 lines.

sheridan's avatar
sheridan committed
838 839
=== Alexander-32 ===

darin's avatar
darin committed
840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856
2002-11-14  Darin Adler  <darin@apple.com>

	- fixed 3099240 -- REGRESSION: repro assert d->m_doc->parsing

	Don't force all redirects to be reloads, because the ones from JavaScript must
	not be. Maybe a better solution post-Alex-32 will be to pass a flag that distinguishes
	redirects from other location changes.

        * khtml/khtml_part.cpp: (KHTMLPart::slotRedirect): Don't ignore the anchor when
	comparing URLs to see if they should be a reload. We'll still do a reload if the URLs
	are actually equal, but if they differ in anchor we will just go to the anchor.
	This is the bug fix.

        * kwq/WebCoreBridge.h: Add reload parameter.
        * kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:headers:]): Stuff the reload
	parameter into the URLArgs.

darin's avatar
darin committed
857 858 859 860 861 862 863 864 865 866 867
2002-11-14  Darin Adler  <darin@apple.com>

	- fixed 3100235 -- nil-deference in khtml::RenderTable at money.cnn.com

        * kwq/WebCoreBridge.h: Add needsLayout.
        * kwq/WebCoreBridge.mm: (-[WebCoreBridge needsLayout]): Return true if the render
	tree root says "layouted" is false. It would be more elegant to use more of this
	WebCore layout logic and have less of our own on the WebKit side.

        * WebCore.pbproj/project.pbxproj: Oh, that Project Builder.

868 869 870 871 872 873 874 875 876
2002-11-13  Darin Adler  <darin@apple.com>

	- fixed 3100895 -- REGRESSION: Crash (was assertion) on http://www.w3.org/Style/CSS/

        * khtml/rendering/render_text.h: Add an optional arena parameter to deleteSlaves.
        * khtml/rendering/render_text.cpp:
        (RenderText::detach): Pass the render arena in to deleteSlaves.
        (RenderText::deleteSlaves): Use the passed-in arena.

darin's avatar
darin committed
877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899
2002-11-13  Darin Adler  <darin@apple.com>

	- fixed another crash on http://www.w3.org/Style/CSS/, but still not done

        * khtml/rendering/render_box.cpp: (RenderBox::setStyle): Call renderArena()
	from RenderObject rather than going at the document directly. Safer because
	it works even when we don't have a node yet.
        * khtml/rendering/render_flow.cpp: (RenderFlow::addChild): Ditto.
        * khtml/rendering/render_layer.cpp:
        (RenderLayer::paint): Ditto.
        (RenderLayer::nodeAtPoint): Ditto.
        (RenderLayer::constructZTree): Ditto.
        * khtml/rendering/render_list.cpp:
        (RenderListItem::setStyle): Ditto.
        * khtml/rendering/render_text.cpp:
        (RenderText::deleteSlaves): Ditto.
        (RenderText::position): Ditto. This is the one that actually crashed.

        * khtml/misc/makeattrs: Fixed handling of failure case.
        * khtml/misc/maketags: Ditto.

        * WebCore.pbproj/project.pbxproj: Project Builder wanted to touch this.

900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920
2002-11-13  Darin Adler  <darin@apple.com>

	- fixed 3100895 -- REGRESSION: Assertion on http://www.w3.org/Style/CSS/

	A few arena-related fixes.

        * khtml/rendering/bidi.h: Don't define the operator new without the arena parameter.
	That way, we get a link failure if we use it by accident, rather than an assert at runtime.
	It would be even better to get a compile-time error, but I don't know how to make that happen.
        * khtml/rendering/render_layer.h: Ditto.
        * khtml/rendering/render_object.h: Ditto.
        * khtml/rendering/render_text.h: Ditto.

        * khtml/rendering/render_container.cpp:
        (RenderContainer::addChild): Create the RenderTable with the appropriate arena.
        (RenderContainer::insertPseudoChild): Create the RenderFlow objects with the appropriate arena.

        * khtml/rendering/render_text.cpp: (RenderText::deleteSlaves): Don't try to get the arena
	when there are no slaves. This can happen after the element is nil, and in that case we will
	do a nil-dereference.

darin's avatar
darin committed
921 922 923 924 925 926 927 928
2002-11-13  Darin Adler  <darin@apple.com>

        * kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
	Use the "0" instead of the "x" as the canonical character for width.
	This is slightly wider and is better for credit card numbers, for example.

        * WebCore.pbproj/project.pbxproj: Tweak.

darin's avatar
darin committed
929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961
2002-11-13  Darin Adler  <darin@apple.com>

	- fixed 3083982 -- Logging into AOL gives null view

	Turns out AOL was using a refresh header, which we were not supporting.

        * khtml/khtml_part.h: Declare receivedFirstData, a private member function.
        * khtml/khtml_part.cpp:
        (KHTMLPart::receivedFirstData): Separate out the part of slotData we
	want to share, which really seems kinda separate anyway.
        (KHTMLPart::slotData): More of the same.

        * kwq/KWQKHTMLPart.h: Declare addMetaData.
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::slotData): Call receivedFirstData instead of doing the same
	thing ourselves.
        (KWQKHTMLPart::addMetaData): Added. Puts metadata into the job.

        * kwq/KWQKHTMLPartBrowserExtension.mm:
        (KHTMLPartBrowserExtension::createNewWindow): Fix bug where this was calling
	openURL: but meant to call loadURL:.

        * kwq/WebCoreBridge.h: Add headers to openURL method. Remove setContentType.
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge openURL:withHeaders:]): Handle Content-Type and Refresh.
	This method is big enough that I should probably move the guts to KWQKHTMLPart.

	- other things

        * kwq/KWQListImpl.mm: (KWQListImpl::~KWQListImpl): I overlooked something
	while doing my "bug fix" in here a while back. Change an assignment statement
	to an assert.

962 963 964 965 966 967 968 969
2002-11-13  David Hyatt  <hyatt@apple.com>

	Fix for floats. Force relayout if collapsing margins
	have to adjust the position of an object.
	
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::layoutBlockChildren):

970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000
2002-11-13  David Hyatt  <hyatt@apple.com>

	Rewrite cellpadding to not use the style system at all and
	to make table cells just get the padding from the table
	itself (overriding style).
	
        * khtml/html/html_tableimpl.cpp:
        (HTMLTableElementImpl::HTMLTableElementImpl):
        (HTMLTableElementImpl::attach):
        (HTMLTableElementImpl::parseAttribute):
        (HTMLTableCellElementImpl::init):
        * khtml/html/html_tableimpl.h:
        * khtml/rendering/bidi.cpp:
        (RenderFlow::layoutInlineChildren):
        * khtml/rendering/render_box.cpp:
        (RenderBox::contentWidth):
        (RenderBox::contentHeight):
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::layoutBlockChildren):
        (RenderFlow::leftOffset):
        (RenderFlow::rightOffset):
        (RenderFlow::calcMinMaxWidth):
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_table.cpp:
        (RenderTable::RenderTable):
        (RenderTableCell::paddingTop):
        (RenderTableCell::paddingBottom):
        (RenderTableCell::paddingLeft):
        (RenderTableCell::paddingRight):
        * khtml/rendering/render_table.h:

1001 1002 1003 1004 1005 1006
2002-11-13  Ken Kocienda  <kocienda@apple.com>

	Bump WebCore cache to 4 MB (was 1 MB).

        * khtml/misc/loader.cpp

mjs's avatar
mjs committed
1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024
2002-11-13  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3050447 - Policy handlers have no way of telling client
	that the proposed navigation is a form post
	
        * khtml/khtml_part.cpp:
        (KHTMLPart::submitForm): Call kwq->submitForm
        * kwq/KWQKHTMLPart.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::openURL): Adjusted for bridge API change.
        (KWQKHTMLPart::openURLRequest): Removed POST handling.
	(KWQKHTMLPart::submitForm): Added this back, because we need to
	know what URL navigations are caused by form submission, even if
	they are not POSTs.
        (KWQKHTMLPart::urlSelected): Adjusted for bridge API change.
        * kwq/WebCoreBridge.h: Add triggeringEvent: parameter to postURL:
	and isFormSubmission: parameter to loadURL:.

1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035
2002-11-12  David Hyatt  <hyatt@apple.com>

	Fix for 3032869, the background image for the body was being
	propagated up to the root properly but was not being tiled over
	the whole canvas.
	
        * khtml/rendering/render_box.cpp:
        (RenderBox::printBackground):
        * khtml/rendering/render_html.cpp:
        (RenderHtml::printBoxDecorations):

1036 1037 1038 1039 1040 1041 1042 1043 1044
2002-11-12  David Hyatt  <hyatt@apple.com>

	Fix the top of moveabletype.org.  The maxwidth/minwidth
	calculation for blocks with inline content did not properly
	deal with margins and padding on inline elements like <a>.
	
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::calcInlineMinMaxWidth):

1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056
2002-11-12  David Hyatt  <hyatt@apple.com>

	Fix for 2953367, padding is incorrectly inherited into table cells
	and also incorrectly overrides cellpadding on the table itself.
	Fixes dailyf1.com.
	
        * khtml/css/html4.css:
        * khtml/html/html_tableimpl.cpp:
        (HTMLTableElementImpl::parseAttribute):
        (HTMLTableCellElementImpl::init):
        * khtml/html/html_tableimpl.h:

1057 1058 1059 1060 1061 1062 1063 1064 1065 1066
2002-11-12  David Hyatt  <hyatt@apple.com>

	For now make text/xml files use HTML parsing/documents.
	This avoids the infinite loop we get into when loading
	text/xml.  If/when we finally support XML, we can undo
	this change.
	
        * khtml/khtml_part.cpp:
        (KHTMLPart::begin):

1067 1068 1069 1070 1071 1072 1073 1074 1075 1076
2002-11-12  David Hyatt  <hyatt@apple.com>

	Fix for 3086321, stylesheets not loading if titles are
	specified.  Note that 4 of the pages on the PLT were
	affected by this, so I fully expect a slight performance
	degradation (the boost from the regression was artificial).
	
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::recalcStyleSelector):

rjw's avatar
rjw committed
1077 1078 1079 1080 1081 1082 1083
2002-11-12  Richard Williamson  <rjw@apple.com>

        Oops, removed debugging.
        
        * khtml/rendering/font.cpp:
        (Font::drawText):

1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101
2002-11-12  Richard Williamson  <rjw@apple.com>

        Implemented letter-spacing and word-spacing CSS properties.
        
        * khtml/rendering/font.cpp:
        (Font::drawText):
        (Font::floatWidth):
        (Font::floatCharacterWidths):
        * kwq/KWQFontMetrics.h:
        * kwq/KWQFontMetrics.mm:
        (QFontMetrics::width):
        (QFontMetrics::floatWidth):
        (QFontMetrics::floatCharacterWidths):
        * kwq/KWQPainter.h:
        * kwq/KWQPainter.mm:
        (QPainter::drawText):
        * kwq/WebCoreTextRenderer.h:

1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120
2002-11-12  David Hyatt  <hyatt@apple.com>

	Revert floats so that they don't use layers any more.
	Floats have to be able to paint in between the background
	and foreground of inlines, so they can't have layers.
	
        * khtml/rendering/render_box.cpp:
        (RenderBox::setStyle):
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::printObject):
        (RenderFlow::paintFloats):
        (RenderFlow::addOverHangingFloats):
        (RenderFlow::nodeAtPoint):
        * khtml/rendering/render_flow.h:
        * khtml/rendering/render_layer.cpp:
        (RenderLayer::constructZTree):
        * khtml/rendering/render_list.cpp:
        (RenderListItem::printObject):

1121 1122 1123 1124 1125
2002-11-12  Darin Adler  <darin@apple.com>

        * kwq/KWQCursor.mm: (QCursor::QCursor): Use nil instead of [NSCursor arrowCursor].
	This will probably fix the performance regression.

1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138
2002-11-12  Darin Adler  <darin@apple.com>

	- fixed 3080250 -- Hands-free crash at wired.com in
	KHTMLPart::slotChildStarted

        * kwq/KWQListImpl.mm:
        (KWQListImpl::~KWQListImpl): Set the node of each iterator to NULL too,
	not just the list. This is the bug fix for the bug above.
        (KWQListIteratorImpl::toFirst): Check for list of NULL.
        (KWQListIteratorImpl::toLast): ditto.

        * kwq/KWQSlot.mm: Tweaks.

1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298
2002-11-12  David Hyatt  <hyatt@apple.com>

	This patch lands a rewrite of whitespace-handling in the
	layout engine and adds support for the CSS2 white-space
	property.  

	It also includes a rewrite of inlines' min/max width 
	calculations (for both flow inlines and raw text).

	A problem with <form> margins has been fixed (this is a
	regression I caused with my collapsing margin checkin).

        * WebCore.pbproj/project.pbxproj:
        * khtml/css/html4.css:
        * khtml/html/dtd.cpp:
        (DOM::checkChild):
        * khtml/html/html_baseimpl.cpp:
        (HTMLBodyElementImpl::attach):
        (HTMLFrameElementImpl::attach):
        (HTMLFrameSetElementImpl::attach):
        (HTMLHtmlElementImpl::attach):
        (HTMLIFrameElementImpl::attach):
        * khtml/html/html_formimpl.cpp:
        (HTMLFormElementImpl::HTMLFormElementImpl):
        (HTMLInputElementImpl::attach):
        (HTMLSelectElementImpl::attach):
        (HTMLTextAreaElementImpl::attach):
        * khtml/html/html_formimpl.h:
        * khtml/html/html_imageimpl.cpp:
        (HTMLImageElementImpl::attach):
        * khtml/html/html_inlineimpl.cpp:
        (HTMLBRElementImpl::attach):
        * khtml/html/html_objectimpl.cpp:
        (HTMLAppletElementImpl::attach):
        (HTMLEmbedElementImpl::attach):
        (HTMLObjectElementImpl::attach):
        * khtml/html/htmlparser.cpp:
        (KHTMLParser::reset):
        (KHTMLParser::parseToken):
        (KHTMLParser::insertNode):
        (KHTMLParser::popBlock):
        (KHTMLParser::popOneBlock):
        * khtml/html/htmlparser.h:
        * khtml/html/htmltokenizer.cpp:
        (HTMLTokenizer::addPending):
        (HTMLTokenizer::write):
        * khtml/misc/arena.cpp: Added.
        (CeilingLog2):
        (InitArenaPool):
        (ArenaAllocate):
        (ArenaGrow):
        (FreeArenaList):
        (ArenaRelease):
        (FreeArenaPool):
        (FinishArenaPool):
        (ArenaFinish):
        * khtml/misc/arena.h: Added.
        * khtml/rendering/bidi.cpp:
        (BidiIterator::detach):
        (throw):
        (BidiIterator::operator delete):
        (appendRunsForObject):
        (appendRun):
        (RenderFlow::bidiReorderLine):
        (deleteMidpoints):
        (RenderFlow::layoutInlineChildren):
        (RenderFlow::findNextLineBreak):
        * khtml/rendering/bidi.h:
        * khtml/rendering/render_arena.cpp: Added.
        (RenderArena::RenderArena):
        (RenderArena::~RenderArena):
        (RenderArena::allocate):
        (RenderArena::free):
        * khtml/rendering/render_arena.h: Added.
        * khtml/rendering/render_box.cpp:
        (RenderBox::setStyle):
        (RenderBox::~RenderBox):
        (RenderBox::detach):
        * khtml/rendering/render_box.h:
        * khtml/rendering/render_br.cpp:
        (RenderBR::RenderBR):
        * khtml/rendering/render_container.cpp:
        (RenderContainer::~RenderContainer):
        (RenderContainer::detach):
        * khtml/rendering/render_container.h:
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::setStyle):
        (RenderFlow::layout):
        (RenderFlow::calcInlineMinMaxWidth):
        (RenderFlow::calcBlockMinMaxWidth):
        (RenderFlow::calcMinMaxWidth):
        (RenderFlow::addChild):
        (RenderFlow::makeChildrenNonInline):
        * khtml/rendering/render_flow.h:
        * khtml/rendering/render_html.cpp:
        (RenderHtml::RenderHtml):
        * khtml/rendering/render_layer.cpp:
        (RenderLayer::~RenderLayer):
        (throw):
        (RenderLayer::operator delete):
        (RenderLayer::detach):
        (RenderLayer::paint):
        (RenderLayer::nodeAtPoint):
        (RenderLayer::constructZTree):
        (RenderLayer::RenderLayerElement::operator delete):
        (RenderLayer::RenderLayerElement::detach):
        (RenderLayer::RenderZTreeNode::operator delete):
        (RenderLayer::RenderZTreeNode::detach):
        * khtml/rendering/render_layer.h:
        * khtml/rendering/render_list.cpp:
        (RenderListItem::setStyle):
        * khtml/rendering/render_object.cpp:
        (throw):
        (RenderObject::operator delete):
        (RenderObject::createObject):
        (RenderObject::renderArena):
        (RenderObject::detach):
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_replaced.cpp:
        (RenderWidget::detach):
        * khtml/rendering/render_replaced.h:
        * khtml/rendering/render_root.cpp:
        (RenderRoot::RenderRoot):
        * khtml/rendering/render_table.cpp:
        (RenderTable::addChild):
        (RenderTable::calcWidth):
        (RenderTable::setCellWidths):
        (RenderTableSection::addChild):
        (RenderTableRow::addChild):
        * khtml/rendering/render_text.cpp:
        (TextSlave::detach):
        (throw):
        (TextSlave::operator delete):
        (TextSlaveArray::TextSlaveArray):
        (RenderText::RenderText):
        (RenderText::~RenderText):
        (RenderText::detach):
        (RenderText::deleteSlaves):
        (RenderText::trimmedMinMaxWidth):
        (RenderText::calcMinMaxWidth):
        (RenderText::position):
        * khtml/rendering/render_text.h:
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::DocumentImpl):
        (DocumentImpl::~DocumentImpl):
        (DocumentImpl::attach):
        (DocumentImpl::detach):
        * khtml/xml/dom_docimpl.h:
        * khtml/xml/dom_nodeimpl.cpp:
        (NodeImpl::detach):
        (NodeImpl::isReadOnly):
        (NodeImpl::previousRenderer):
        * khtml/xml/dom_nodeimpl.h:
        * khtml/xml/dom_stringimpl.cpp:
        * khtml/xml/dom_stringimpl.h:
        * khtml/xml/dom_textimpl.cpp:
        (CharacterDataImpl::containsOnlyWhitespace):
        (TextImpl::attach):
        * khtml/xml/dom_textimpl.h:

1299 1300 1301 1302 1303 1304 1305
2002-11-12  Darin Adler  <darin@apple.com>

	- fixed 3094819 -- Crash in -[KWQObjectTimerTarget timerFired]

        * kwq/KWQObject.mm: (QObject::~QObject): Call the _destroyed signal.
        (QObject::killTimers): Simplify the code a bit using makeObjectsPerformSelector:.

1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324
2002-11-12  Darin Adler  <darin@apple.com>

	- fixed 3079499 -- blank page at http://www.sonyericsson.com/T68i/

        * khtml/misc/loader.cpp:
        (CachedCSSStyleSheet::checkNotify): Copy the clients list before iterating
	over it, since clients can move around in the list or be removed.
        (CachedScript::checkNotify): Ditto.
        (CachedImage::do_notify): Ditto.
        (CachedImage::movieStatus): Ditto.

	- fixed double calls to openURL I noticed

        * khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest):
	Don't call openURL here at all. That happens indirectly as a result
	of the load we kick off.

        * kwq/KWQKHTMLPart.mm: Tweaks.

darin's avatar
darin committed
1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337
2002-11-12  Darin Adler  <darin@apple.com>

	- fixed 3083043 -- Alex doesn't decode % sequences in javascript: URLs

	Some places here did KURL::decode_string, but others didn't.

        * khtml/khtml_part.cpp:
        (KHTMLPart::slotShowDocument): Added call to KURL::decode_string.
        (KHTMLPart::overURL): Ditto.
        (KHTMLPart::urlSelected): Ditto.
        (KHTMLPart::requestFrame): Ditto.
        (KHTMLPart::slotChildURLRequest): Ditto.

darin's avatar
darin committed
1338 1339 1340 1341 1342
2002-11-11  Darin Adler  <darin@apple.com>

        * kwq/KWQWidget.mm: (QWidget::setCursor): Remove printf I left
	in by accident.

darin's avatar
darin committed
1343 1344 1345 1346 1347 1348 1349 1350 1351 1352
2002-11-11  Darin Adler  <darin@apple.com>

	- tighten up cursor handling a bit more

        * kwq/KWQWidget.mm:
        (QWidget::setCursor): Use setDocumentCursor: instead of our own protocol.
        (QWidget::cursor): Use documentCursor instead of storing our own cursor.

        * kwq/WebCoreFrameView.h: Remove setCursor: method.

1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370
2002-11-11  Darin Adler  <darin@apple.com>

	- fixed 3084704 -- crash in HTMLTokenizer on page with JavaScript
	HTMLDocument::Close inside a <script>

	I think it's going to work this time. The key was to hook up the
	KHTML submitFormAgain machinery.

        * khtml/khtml_part.cpp: (KHTMLPart::submitForm): Take out the APPLE_CHANGES
	ifdef that was disabling the submitFormAgain logic.
        * kwq/KWQKHTMLPart.h: Remove submitForm(), because openURLRequest() handles it fine.
        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLRequest): Move the logic for handling
	POST here from submitForm() and remove submitForm().

        * kwq/KWQSlot.mm:
        (KWQSlot::KWQSlot): Add support for the submitFormAgain slot.
        (KWQSlot::call): Ditto.

1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396
2002-11-11  Darin Adler  <darin@apple.com>

	- fixed 3092421 -- javascript: URL that opens window crashes Alex if typed into empty window

        * kwq/KWQKHTMLPart.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::KWQKHTMLPart): Set _ownsView to false.
        (KWQKHTMLPart::~KWQKHTMLPart): Delete the view if we own it. Also release
	_currentEvent to fix a leak.
        (KWQKHTMLPart::setView): Delete the old view if we own it. Also, set the
	_ownsView flag.
        (KWQKHTMLPart::createDummyDocument): Create a dummy view too.

        * kwq/KWQDummyView.h: Added.
        * kwq/KWQDummyView.m: Added.
        * WebCore.pbproj/project.pbxproj: Added KWQDummyView.

        * kwq/WebCoreBridge.h: Remove bridgeOwnsKHTMLView and currentEvent.
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge createKHTMLViewWithNSView:marginWidth:marginHeight:]):
	Pass true to setView instead of setting bridgeOwnsKHTMLView.
        (-[WebCoreBridge removeFromFrame]): Just call setView on the part. It
	knows how to handle ownership now.
        (-[WebCoreBridge installInFrame:]): Call setOwnsView instead of setting
	bridgeOwnsKHTMLView.

1397 1398 1399 1400 1401 1402 1403 1404 1405
2002-11-11  Trey Matteson  <trey@apple.com>

        * khtml/khtml_part.cpp:
        (KHTMLPart::requestFrameName):  Call through bridge to get generated frame name.
        * kwq/KWQKHTMLPart.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::generateFrameName):  New call that just forwards through the bridge.
        * kwq/WebCoreBridge.h:

1406 1407 1408 1409 1410 1411 1412 1413
2002-11-11  Darin Adler  <darin@apple.com>

	- fixed 3097253 -- text tagged <small> inside <h1> is too small

        * khtml/css/html4.css: Change BIG to use "font-size: larger" rather
	than "font-size: large" and SMALL to use "font-size: smaller" rather
	than "font-size: small".

darin's avatar
darin committed
1414 1415 1416 1417
2002-11-11  Darin Adler  <darin@apple.com>

        * kwq/WebCoreBridge.h: Remove unused modifierTrackingEnabled method.

1418 1419 1420 1421 1422 1423 1424 1425 1426
2002-11-08  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3096451 - REGRESSION: clicking on link to open window only
	works when pop-up suppression is off
	
        * khtml/ecma/kjs_binding.cpp:
        (ScriptInterpreter::ScriptInterpreter): Initialize m_timerCallback
	to false.

1427 1428 1429 1430 1431
b2002-11-08  Darin Adler  <darin@apple.com>

        * kwq/KWQComboBox.mm: Bump fudge factor up one pixel. You could see
	it was wrong with strings like "0".

1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443
2002-11-08  Darin Adler  <darin@apple.com>

	- fixed 3090452 -- REGRESSION: orbitz Box extends way over margins

        * kwq/KWQComboBox.h: Added _width and _widthGood.
        * kwq/KWQComboBox.mm:
        (QComboBox::QComboBox): Set _widthGood to false.
        (QComboBox::insertItem): Set _widthGood to false.
        (QComboBox::sizeHint): Compute the width by measuring the text ourselves.
	Turns out the cell isn't helpful for that.
        (QComboBox::clear): Set _widthGood to false.

1444 1445 1446 1447 1448 1449 1450 1451 1452
2002-11-08  Richard Williamson   <rjw@apple.com>

        Cleanup of fix to 3083281.  Never call stopAnimating from
        QPixmap's destructor.  With the fix it wouldn't have been
        called anyway.
        
        * kwq/KWQPixmap.mm:
        (QPixmap::~QPixmap):

1453 1454 1455 1456
2002-11-08  Darin Adler  <darin@apple.com>

        * kwq/WebCoreBridge.mm: (attributedString): Remove some dead code.

1457 1458 1459 1460 1461
2002-11-07  Darin Adler  <darin@apple.com>

        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::slotData):
	Add an assert in the hopes of catching bug 3084704 a little earlier.

1462 1463 1464 1465 1466 1467 1468
2002-11-07  Richard Williamson  <rjw@apple.com>

        Don't stop animating unless we're the last referee. (3083281)
        
        * kwq/KWQPixmap.mm:
        (QPixmap::~QPixmap):

sheridan's avatar
sheridan committed
1469 1470
=== Alexander-31 ===

1471 1472 1473 1474 1475 1476 1477 1478 1479
2002-11-06  Richard Williamson  <rjw@apple.com>

        Use our notion of unicode whitespace from lookup tables
        and isspace for latin1.  This is more correct than CF.
        Fixed issues Dave ran into with whitespace calculations.
        
        * kwq/KWQChar.mm:
        (QChar::isSpace):

darin's avatar
darin committed
1480 1481 1482 1483 1484 1485 1486
2002-11-05  Darin Adler  <darin@apple.com>

	- fixed 3092722 -- assertion failed

        * kwq/KWQResourceLoader.mm: (-[KWQResourceLoader reportError]):
	Removed the assertion. It wasn't needed.

1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512
2002-11-05  Darin Adler  <darin@apple.com>

	- re-fixed 3070484 -- icon rollovers are very slow on Mac OS X website

	Had to roll back some of the files I changed yesterday. I had missed the
	one line of useful code among much stuff we don't need.

        * khtml/khtml_part.cpp:
        (KHTMLPart::init):
        (KHTMLPart::~KHTMLPart):
        (KHTMLPart::slotLoaderRequestStarted):
        (KHTMLPart::slotLoaderRequestDone):
        * kwq/KWQSignal.h:
        * kwq/KWQSignal.mm:
        (KWQSignal::call):
        * kwq/KWQSignalStubs.mm:
        (Loader::requestDone):
        (Loader::requestFailed):
        (Loader::requestStarted):
        * kwq/KWQSlot.h:
        * kwq/KWQSlot.mm:
        (KWQSlot::KWQSlot):
        (KWQSlot::call):
	Just roll back all the changes from my 3091714 check-in below, except
	for the bug fix itself in loader.cpp and KWQResourceLoader.mm.

1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524
2002-11-05  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3027404 - pop-up ads not always suppressed
	
        * khtml/ecma/kjs_binding.cpp:
        (ScriptInterpreter::isWindowOpenAllowed): Don't allow opening if
	we are in a timer callback - for reasons unexplained this will
	always show up as an inline script.
        * khtml/ecma/kjs_binding.h:
        * khtml/ecma/kjs_window.cpp:
        (ScheduledAction::execute): Note that we're in a timer callback.

1525 1526 1527 1528 1529 1530 1531
2002-11-04  Richard Williamson  <rjw@apple.com>

        Changes to support cursive letter forms.
        
        * kwq/KWQChar.mm:
        * kwq/WebCoreUnicode.h:

1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564
2002-11-04  Darin Adler  <darin@apple.com>

	- fixed 3091714 -- reproducible assert cachedObject->response
	in KWQCheckCacheObjectStatus

        * khtml/misc/loader.cpp: (Loader::slotFinished):
	For APPLE_CHANGES, don't finish the load if it's an error.

        * kwq/KWQResourceLoader.mm:
        (-[KWQResourceLoader finishJobAndHandle]): Shared code for the
	three following methods.
        (-[KWQResourceLoader cancel]): Use setError(1) again instead of
	just keeping the load around forever.
        (-[KWQResourceLoader reportError]): Ditto.
        (-[KWQResourceLoader finish]): Use finishJobAndHandle to share
	code with the two above.

        * khtml/khtml_part.cpp:
        (KHTMLPart::init): Put the slotLoaderRequestStarted and
	slotLoaderRequestDone connect lines inside ifdefs.
        (KHTMLPart::~KHTMLPart): Same for disconnect.

        * kwq/KWQSignal.h: Remove code for the DocLoader signals.
        * kwq/KWQSignal.mm: (KWQSignal::call): Ditto.
        * kwq/KWQSignalStubs.mm:
        (Loader::requestDone): Ditto.
        (Loader::requestFailed): Ditto.
        (Loader::requestStarted): Ditto.
        * kwq/KWQSlot.h: Ditto.
        * kwq/KWQSlot.mm:
        (KWQSlot::KWQSlot): Ditto.
        (KWQSlot::call): Ditto.

1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583
2002-11-04  Maciej Stachowiak  <mjs@apple.com>

	Changes to send NSEvents all the way through WebCore and then pass
	them back out to WebKit, so that click policy can have a
	WebResourceRequest added.
	
        * kwq/KWQKHTMLPart.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::KWQKHTMLPart):
        (KWQKHTMLPart::openURL):
        (KWQKHTMLPart::openURLRequest):
        (KWQKHTMLPart::urlSelected):
        (KWQKHTMLPart::submitForm):
        (KWQKHTMLPart::createDummyDocument):
        (KWQKHTMLPart::setCurrentEvent):
        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge mouseUp:]):

darin's avatar
darin committed
1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594
2002-11-03  Darin Adler  <darin@apple.com>

	- fixed 3091300 -- "prelighting" on local page is still slow, despite recent bug fix

	Turns out all updating would be slow if any resources on the page failed to load.

        * kwq/WebCoreResourceLoader.h: Add reportError, distinct from
	cancel and finish.
        * kwq/KWQResourceLoader.mm: (-[KWQResourceLoader reportError]):
	Set the error boolean on the job and then call through to [finish].

1595 1596 1597 1598 1599 1600 1601 1602 1603
2002-11-03  Darin Adler  <darin@apple.com>

	- fixed 3091275 -- can't type into Answer field in RealOne Player order form

        * khtml/rendering/render_form.cpp:
        (RenderLineEdit::updateFromElement): Treat 0 as max (1024) as other browsers do.
        (RenderFileButton::updateFromElement): Ditto, although this is in !APPLE_CHANGES code
	that we don't use in WebCore.

1604 1605 1606 1607 1608 1609 1610 1611
2002-11-01  Darin Adler  <darin@apple.com>

	- applied the same "subclass responsibility" pattern here as in
	some of the other WebCore classes

        * kwq/WebCoreImageRendererFactory.h: Move the subclass responsibility into a protocol.
        * kwq/WebCoreImageRendererFactory.m: Remove now-unneeded stubs.

rjw's avatar
rjw committed
1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622
2002-11-01  Richard Williamson   <rjw@apple.com>

        Removed old implementation.
        
        * kwq/KWQChar.mm:
        (QChar::direction):
        
        Renamed JoiningCenter -> JoiningCausing.
        
        * kwq/WebCoreUnicode.h:

1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643
2002-11-01  Darin Adler  <darin@apple.com>

	- fixed 3062598 -- meta refresh of 0.1s fails

	KHTML was using an integer for the delay.

        * khtml/khtml_part.h: Make scheduleRedirection take a double.
        * khtml/khtmlpart_p.h: Make m_delayRedirect be a double.
        * khtml/khtml_part.cpp:
        (KHTMLPart::slotData): Use a double when parsing meta refresh.
        (KHTMLPart::checkCompleted): Cast to int when passing to timer start.
        (KHTMLPart::scheduleRedirection): Cast to int when passing to timer
	start; also check for absurd values and do nothing.
        (KHTMLPart::slotParentCompleted): Cast to int when passing to timer start.

        * khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv):
	Use a double when parsing meta refresh.

        * kwq/KWQKDebug.h: Add overloads for unsigned int and double to keep us
	compiling now that we use a double in one place.

1644 1645 1646 1647 1648 1649 1650 1651 1652
2002-11-01  Darin Adler  <darin@apple.com>

	- fixed 3090249 -- random crash on page load
	- fixed 3090286 -- assert _job in KWQResourceLoader cancel

        * kwq/KWQResourceLoader.mm: (-[KWQResourceLoader cancel]):
	This function needs to handle the case where the load is already cancelled.
	I think this also caused Avie's crash.

1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670
2002-10-31  Darin Adler  <darin@apple.com>

	- fixed huge leak when doing page load test

        * khtml/ecma/kjs_binding.h:
        * khtml/ecma/kjs_binding.cpp: Remove ScriptInterpreter::mark().
	We don't want to mark the elements of m_domObjects, because we don't want
	to keep them around the entire lifetime of the interpreter. This is fine
	because we already have forgetDOMObject(), which takes care of when they
	are deallocated.

        * khtml/ecma/kjs_dom.cpp:
        * khtml/ecma/kjs_dom.h:
        * khtml/ecma/kjs_html.cpp:
        * khtml/ecma/kjs_html.h:
	Changed lots of parameters to pass by const reference for a bit of a code
	size and performance gain.

1671 1672 1673 1674 1675 1676 1677 1678 1679
2002-10-31  Richard Williamson  <rjw@apple.com>

        Turned on use of lookup tables.
        
        * kwq/KWQChar.mm:
        (QChar::direction):
        (QChar::mirrored):
        (QChar::mirroredChar):

1680 1681 1682 1683 1684 1685 1686 1687 1688 1689
2002-10-31  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3075803 - yahoo customize layout - delete, ordering of items doesn't work
	
        * khtml/html/html_formimpl.h:
        * khtml/html/html_formimpl.cpp:
        (HTMLSelectElementImpl::recalcStyle): New method to insure the
	select element updates if the contents of the option subelements
	are changed.

1690
=== Alexander-30 ===
sheridan's avatar
sheridan committed
1691

1692 1693 1694 1695 1696 1697 1698 1699
2002-10-30  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3049853 - Javascript: setInterval incorrectly acts as single shot
	
        * kwq/KWQObject.mm:
        (QObject::startTimer): Set a recurring timer instead of
	single-shot, to match QObject semantics.

1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715
2002-10-30  Richard Williamson  <rjw@apple.com>

        More work on bidi and contextual forms.
        Table lookup code is up in WebKit. Function
        pointers are used to isolate WebCore from private
        implementation in WebKit.  Needs to be fast, so
        the usual ObjC abstraction won't work.
        
        * WebCore.exp:
        * WebCore.pbproj/project.pbxproj:
        * kwq/KWQChar.mm:
        (QChar::direction):
        * kwq/KWQString.h:
        * kwq/WebCoreUnicode.cpp: Added.
        * kwq/WebCoreUnicode.h: Added.

1716 1717 1718 1719 1720 1721
2002-10-30  Darin Adler  <darin@apple.com>

	- fixed crash when you open an empty window and just hit tab, tab, tab

        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Check for nil.

1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741
2002-10-30  Darin Adler  <darin@apple.com>

	- fixed 3083982 -- Logging into AOL gives null view, crash

	I fixed the crash part. Not the "gives null view" part.
	The key was to disentangle the references and lifetimes of the transfer job class,
	and the resource loader object that KWQ uses to connect it with WebKit.

        * kwq/KWQKJobClasses.h: Change the job to keep a loader reference, not a
	handle reference. The job needs to inform the loader when it's being deallocated.
        * kwq/KWQKJobClasses.mm: Use jobWillBeDeallocated instead of cancel when the
	job is deallocated.

        * kwq/KWQLoader.mm: (KWQServeRequest): Use KWQResourceLoader, now with a home in
	a separate file.

        * kwq/KWQResourceLoader.h: Added.
        * kwq/KWQResourceLoader.mm: Added.
        * WebCore.pbproj/project.pbxproj: Added KWQResourceLoader files.

darin's avatar
darin committed
1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816
2002-10-30  Darin Adler  <darin@apple.com>

	- fixed 3086564 -- REGRESSION: meta-refresh to the same page doesn't refresh

	The key is to get args.reload passed through to the bridge.

        * kwq/WebCoreBridge.h: Add reload parameter to loadURL:.

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::openURL): Pass NO for reload.
        (KWQKHTMLPart::openURLRequest): Pass args.reload for reload.
        (KWQKHTMLPart::urlSelected): Pass args.reload for reload.
        (KWQKHTMLPart::submitForm): Pass args.reload for reload.
        
	- fixed a memory problem with the use of NSBrowser in KWQListBox
        - fixed 2863040 -- multiple default items in select list not selected

	Switched to use NSTableView instead of NSBrowser. This should also create
	a measurable speedup due to other changes to this class.

        * kwq/KWQListBox.h: Remove firstItem(), the insertItem() that takes a QListBoxItem
	parameter, and deleteItems(). Add _items, _width, and _widthGood. Removed _head.
	Removed the QListBoxItem and QListBoxText classes.
        * kwq/KWQListBox.mm:
        (QListBox::QListBox): Create a KWQListBoxScrollView and put an NSTableView
	inside it. Also create an NSMutableArray to hold the items.
        (QListBox::~QListBox): Disconnect the table view from the delegate before
	releasing it. Also release the items array.
        (QListBox::count): Return the array count.
        (QListBox::clear): Do a reloadData here instead of loadColumnZero.
        (QListBox::setSelectionMode): Update for table view.
        (QListBox::insertItem): Update for table view.
        (QListBox::insertGroupLabel): Just calls insertItem for now.
        (QListBox::endBatchInsert): Update for table view.
        (QListBox::setSelected): Update for table view, including support for multiple
	selection.
        (QListBox::isSelected): Update for table view.
        (QListBox::sizeForNumberOfLines): Use the table view cell for width, and
	cache it so we don't have to measure all the strings over and over again.
        (-[KWQListBoxScrollView setFrameSize:]): Resize the table view column whenever
	the entire scroll view is resized.
        (-[KWQListBoxTableViewDelegate initWithListBox:]): Store box pointer and
        pointer to items array.
        (-[KWQListBoxTableViewDelegate numberOfRowsInTableView:]): Return count.
        (-[KWQListBoxTableViewDelegate tableView:objectValueForTableColumn:row:]):
	Get the data from the items array.
        (-[KWQListBoxTableViewDelegate tableViewSelectionDidChange:]): Call both the
	selection-changed signal and the clicked signal.

        * khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement):
	Get rid of the one place here that gets at a list box item by calling a KWQ
	function insertGroupLabel instead of making a QListBoxText. Also call
        beginBatchInsert() before clear() for a slight additional speed boost.

	- fixed 3067572 -- javascript: URLs typed into page address field or
	bookmarks don't work in empty window

	We needed a document for DOM, so we make a dummy one. This works for an empty
	window, and also for a window with non-HTML content.

        * kwq/KWQKHTMLPart.h: Added createDummyDocument().
        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createDummyDocument): Create an empty
	DOM document if there isn't one already.

        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge stringByEvaluatingJavaScriptFromString:]): Call the new
	createDummyDocument() instead of checking and doing nothing if there is no
	document present when this is called.

	- other stuff

        * kwq/WebCoreBridge.mm: (-[WebCoreBridge DOMDocument]): Removed a stray printf.

        * kwq/KWQTextArea.mm: Tweaked code a little.

1817 1818 1819 1820 1821
2002-10-28  Darin Adler  <darin@apple.com>

        * khtml/khtml_part.cpp: (KHTMLPart::checkCompleted):
	Update so it handles nil for the view.

1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864
2002-10-28  Darin Adler  <darin@apple.com>

	- fixed 3070484 -- icon rollovers are very slow on Mac OS X website

	The problem was simply that the part didn't know it was complete.
	To let it know, I hooked up some loader signals, and now it works.

        * khtml/khtml_part.cpp:
        (KHTMLPart::init): Create the KWQKHTMLPart a little earlier so we have
	a chance to initialize the cache before it's used.
        (KHTMLPart::slotLoaderRequestStarted): Take this out of ifdefs.
        (KHTMLPart::slotLoaderRequestDone): Ditto.

        * khtml/misc/loader.h: Add a KWQLoader pointer to the loader.
        * khtml/misc/loader.cpp:
        (Loader::Loader): Create a KWQLoader;
        (Loader::~Loader): Destroy the KWQLoader.
        (Loader::load): Take out ifdefs around code that emits requestStarted.

        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Call Cache::init().

        * kwq/KWQLoader.h: Add a class KWQLoader, with three signals in it.
        * kwq/KWQLoader.mm: (KWQLoader::KWQLoader): Initialize the three signals.

        * kwq/KWQSignalStubs.mm:
        (Loader::requestDone): Emit the signal using KWQLoader.
        (Loader::requestFailed): Ditto.
        (Loader::requestStarted): Ditto.

        * kwq/KWQSlot.h: Add an overload for slots with loader and cached object
	parameters so we can handle the new slots.
        * kwq/KWQSlot.mm:
        (KWQSlot::KWQSlot): Added slotLoaderRequestDone and slotLoaderRequestStarted.
        (KWQSlot::call): Added the new overload to handle those two signals.

        * kwq/KWQSignal.h: Add an overload for signals with loader and cached object
	parameters so we can handle the new signals.
        * kwq/KWQSignal.mm: (KWQSignal::call): Ditto.

        * kwq/KWQObject.mm: (QObject::connect): Remove the special casing that
	prevents complaints about slotLoaderRequestDone and slotLoaderRequestStarted,
	since we support those now.

darin's avatar
darin committed
1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875
2002-10-28  Darin Adler  <darin@apple.com>

	- fixed storage leak of items in QListBox

        * kwq/KWQListBox.h: Added private deleteItems method.
        * kwq/KWQListBox.mm:
        (QListBox::~QListBox): Call deleteItems().
        (QListBox::deleteItems): Move the code to delete all the items
	here from clear(), since clear() is not called on destruction.
        (QListBox::clear): Call deleteItems().

cblu's avatar
cblu committed
1876 1877 1878 1879 1880 1881 1882
2002-10-28  Chris Blumenberg  <cblu@apple.com>

	Lowercase the text encoding name.

        * kwq/KWQCharsets.mm:
        (KWQCFStringEncodingFromIANACharsetName):

1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895
2002-10-28  Richard Williamson   <rjw@apple.com>
    
        Fixed 3086188 - REGRESSION: Justified text is broken
        
        Bogus special case for DirW(hite)S(pace).  This
        should be correctly detected by CF, but is not.
        Revert to explicit checking for ' ' character.  This'll
        work most of the time.  All the more reason to do
        our own unicode attribute database.
        
        * kwq/KWQChar.mm:
        (QChar::direction):

cblu's avatar
cblu committed
1896 1897 1898 1899 1900 1901 1902 1903 1904 1905
2002-10-28  Chris Blumenberg  <cblu@apple.com>

	Fixed: 3056726 - View Source window always displays the source in current system encoding
	Fixed: 3019352 - Text encoding is not handled when viewing plain text

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (+[WebCoreBridge stringWithData:textEncoding:]): added, creates a string with data using the WebCore's decoding logic.
        (+[WebCoreBridge stringWithData:textEncodingName:]): added, calls stringWithData:textEncoding: after getting the encoding for a text encoding name

gramps's avatar
gramps committed
1906 1907 1908 1909 1910 1911 1912 1913 1914 1915
2002-10-28  Don Melton  <gramps@apple.com>

        * khtml/html/htmlparser.cpp:
        (KHTMLParser::insertNode):
        * khtml/html/htmltokenizer.cpp:
        (HTMLTokenizer::write):

	Backed our Dave's whitespace hack because it was adding newlines, i.e.
	vertical margins, to web pages all over.

darin's avatar
Tests:  
darin committed
1916 1917 1918 1919 1920 1921 1922 1923 1924
2002-10-28  Darin Adler  <darin@apple.com>

	- fixed 3015800 -- bad URL error - unescaped # in URL

	Actually this has to be fixed both here and in NSURLExtras.

        * kwq/KWQKURL.mm: Set the "BadChar" flag for "#" so we escape any
	"#" characters we see after the first one.

darin's avatar
darin committed
1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943
2002-10-27  Darin Adler  <darin@apple.com>

	- fixed 3058845 -- <input type=file> uses hard-coded width of 200
	pixels for filename

        * khtml/rendering/render_form.cpp:
        (RenderLineEdit::calcMinMaxWidth): Use a default of 20 "x-widths" wide, to
	match Mozilla, rather than the 17 that is in KHTML by default.
        (RenderFileButton::calcMinMaxWidth): Pass in a character width here, using
	the same 20-character rule as above.
        * kwq/KWQFileButton.h: Replace sizeHint() with sizeForCharacterWidth(int).
        * kwq/KWQFileButton.mm:
        (KWQFileButton::sizeForCharacterWidth): Pass character count to the WebCoreFileButton.
        (KWQFileButton::baselinePosition): Fix baseline computation. It was computing some huge
	negative number before and was obviously broken.
        * kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): Add an assertion.
        * kwq/WebCoreViewFactory.h: Replace bestVisualFrameSize with
	bestVisualFrameSizeForCharacterCount:.

gramps's avatar
gramps committed
1944 1945 1946 1947 1948 1949 1950
2002-10-27  Don Melton  <gramps@apple.com>

        * khtml/ecma/kjs_navigator.cpp:
        (Navigator::getValueProperty):

	Tweaked AppName, Product, and Vendor logic.

darin's avatar
darin committed
1951 1952 1953 1954 1955
2002-10-27  Darin Adler  <darin@apple.com>

        * kwq/KWQLoader.mm: (KWQServeRequest): Add a missing "delete job" for one
	particular failure case.

1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992
2002-10-26  Darin Adler  <darin@apple.com>

	- fixed a bug in the WebCore cache that caused it to not cache very much after
        a while, and also caused a crash I saw twice on my machine

	Adjust total size of items in the LRU list, when the size of one of the
	items that's in the list is changed.

        * khtml/misc/loader.h: Added a size parameter (default 0) to the CachedObject
	constructor. Added a protected CachedObject::setSize() and made m_size private.
	Added Cache::adjustSize() and Cache::checkLRUAndUncacheableListIntegrity().
        * khtml/misc/loader.cpp:
        (CachedObject::setSize): Added. This is now the only legal way to change
	the size of a cached object, and it calls Cache::adjustSize.
        (CachedCSSStyleSheet::CachedCSSStyleSheet): Pass the length into the base
	class's constructor instead of setting m_size.
        (CachedCSSStyleSheet::data): Call setSize() instead of setting m_size.
	Also get the size back with size() rather than m_size.
        (CachedScript::CachedScript): Pass the length into the base class's
	constructor instead of setting m_size.
        (CachedScript::data): Call setSize() instead of setting m_size. Also get
	the size back with size() rather than m_size.
        (CachedImage::CachedImage): Don't set m_size to 0, since the base class's
	constructor does that already.
        (CachedImage::clear): Use setSize() to set the size to 0 instead of setting
	m_size directly.
        (CachedImage::data): Use setSize() instead of setting m_size directly.
        (Cache::checkLRUAndUncacheableListIntegrity): Useful debugging function.
	Left in but ifdef'd out.
        (Cache::adjustSize): Added. Changes the "total LRU list size" by the
	passed-in delta, but only if the passed-in object is in the LRU list.

        * kwq/KWQLineEdit.mm:
        * kwq/KWQTextField.h:
        * kwq/KWQTextField.mm:
	Renamed the Objective C class KWQNSTextField to KWQTextField.

darin's avatar
Tools:  
darin committed
1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019
2002-10-26  Darin Adler  <darin@apple.com>

	- removed forwarding headers that are not actually needed

        * ForwardingHeaders/kcmdlineargs.h: Removed.
        * ForwardingHeaders/kinstance.h: Removed.
        * ForwardingHeaders/kio/kprinter.h: Removed.
        * ForwardingHeaders/kio/ktrader.h: Removed.
        * ForwardingHeaders/kio/scheduler.h: Removed.
        * ForwardingHeaders/kparts/factory.h: Removed.
        * ForwardingHeaders/kparts/historyprovider.h: Removed.
        * ForwardingHeaders/kstddirs.h: Removed.
        * ForwardingHeaders/qarray.h: Removed.
        * ForwardingHeaders/qbrush.h: Removed.
        * ForwardingHeaders/qbutton.h: Removed.
        * ForwardingHeaders/qcollection.h: Removed.
        * ForwardingHeaders/qcombobox.h: Removed.
        * ForwardingHeaders/qframe.h: Removed.
        * ForwardingHeaders/qglobal.h: Removed.
        * ForwardingHeaders/qiodevice.h: Removed.
        * ForwardingHeaders/qlineedit.h: Removed.
        * ForwardingHeaders/qnamespace.h: Removed.
        * ForwardingHeaders/qpen.h: Removed.
        * ForwardingHeaders/qprinter.h: Removed.
        * ForwardingHeaders/qsize.h: Removed.
        * ForwardingHeaders/qstack.h: Removed.

2020 2021 2022 2023 2024 2025 2026 2027 2028
2002-10-26  Darin Adler  <darin@apple.com>

	- fixed a couple of files accidentally checked in with KWQQ names

        * ForwardingHeaders/qasyncio.h: Change names.
        * ForwardingHeaders/qstylesheet.h: Ditto.
        * WebCore.pbproj/project.pbxproj: Ditto.
        * kwq/KWQMovie.h: Ditto.

2029 2030 2031 2032 2033 2034 2035 2036
2002-10-26  Darin Adler  <darin@apple.com>

	- changed to use #if APPLE_CHANGES and #if !APPLE_CHANGES consistently

	We no longer do #ifdef APPLE_CHANGES or #ifndef APPLE_CHANGES.

        * lots of files

2037 2038 2039
2002-10-26  Darin Adler  <darin@apple.com>

        - changed naming scheme in KWQ for files like qstring.h
2040 2041

        Now use names like KWQString.h and a forwarding header called qstring.h.
2042 2043 2044
        
        * tons of files

darin's avatar
darin committed
2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097
2002-10-26  Darin Adler  <darin@apple.com>

	- fixed 3068404 -- eliminate all user-visible messages from WebCore

        * khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Use runJavaScriptPrompt
	function instead of the more generic QInputDialog.

        * khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::altText): Get
	submit alt text for input element from the view factory, rather than using
	i18n, since we don't support that.
        * khtml/html/htmlparser.cpp: (KHTMLParser::handleIsindex): Ditto, for the
	intro that says "This is a searchable index".
        * khtml/rendering/render_form.cpp:
        (RenderSubmitButton::defaultLabel): Ditto, for "Submit".
        (RenderResetButton::defaultLabel): Ditto, for "Reset".
        (RenderFileButton::slotClicked): Ifdef'd out this unused code that had i18n text in it.

        * khtml/xml/xml_tokenizer.cpp:
        (XMLHandler::errorString): Put in an ifdef and a FIXME to avoid i18n.
        (XMLHandler::fatalError): Ditto.
        (XMLTokenizer::finish): Ditto.

        * khtml/misc/decoder.cpp: (Decoder::decode): Ifdef'd the check for the first
	language being "ja", since that's not how we're going to trigger Japanese
	auto-detect.

        * khtml/rendering/render_applet.cpp: (RenderEmptyApplet::RenderEmptyApplet):
	Turned off the code that does the empty applet label. I don't think it worked,
	and it used i18n. We'll have to tackle this eventually.

        * kwq/KWQKHTMLPartImpl.h: Added runJavaScriptPrompt.
        * kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::runJavaScriptPrompt): Moved the code
	here that used to be in KWQInputDialog.

        * kwq/kdecore/klocale.h: Remove i18n() and KLocale::languageList(), added the functions
	that are listed below.
        * kwq/KWQKLocale.mm:
        (inputElementAltText): Added specific function for getting one of the very few
	translated strings that we need in WebCore.
        (resetButtonDefaultLabel): Ditto.
        (searchableIndexIntroduction): Ditto.
        (submitButtonDefaultLabel): Ditto.
        (KLocale::language): Use the view factory to ask for the language code, since there's no
	public API to get it that WebCore can use.

        * kwq/WebCoreViewFactory.h: Add new API for above.

        * ForwardingHeaders/qinputdialog.h: Added empty file.

        * kwq/qt/qinputdialog.h: Removed.
        * kwq/KWQInputDialog.mm: Removed.
        * WebCore.pbproj/project.pbxproj: Removed QInputDialog files.

darin's avatar
darin committed
2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127
2002-10-25  Darin Adler  <darin@apple.com>

	Remove some user-visible strings. We can't have any strings that need
	localization in WebCore, given our translation strategy.

        * khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::encoding):
	Put APPLE_CHANGES around some i18n dialog code.
        * khtml/khtml_part.cpp: (KHTMLPart::submitForm): Ditto.
        * khtml/rendering/render_frames.cpp:
        (RenderPartObject::slotPartLoadingErrorNotify): Ditto.
        * khtml/ecma/kjs_window.cpp:
        (Window::get): Ditto.
        (Window::scheduleClose): Ditto.
        (WindowFunc::tryCall): Put APPLE_CHANGES in to use JavaScript-specific methods
        in the part of calling the generic ones from KMessageBox.

        * ForwardingHeaders/kmessagebox.h: Added (empty file).

        * kwq/KWQKHTMLPartImpl.h: Added new runJavaScript functions.
        * kwq/KWQKHTMLPartImpl.mm:
        (KWQKHTMLPartImpl::runJavaScriptAlert): Added.
        (KWQKHTMLPartImpl::runJavaScriptConfirm): Added.

        * kwq/WebCoreViewFactory.h: Added runJavaScriptAlertPanelWithMessage and
	runJavaScriptConfirmPanelWithMessage.

        * kwq/kdeui/kmessagebox.h: Removed.
        * kwq/KWQKMessageBox.mm: Removed.
        * WebCore.pbproj/project.pbxproj: Removed the KMessageBox files.

rjw's avatar
rjw committed
2128 2129 2130 2131 2132 2133 2134
2002-10-25  Richard Williamson   <rjw@apple.com>

        Removed debug logging.
        
        * khtml/rendering/font.cpp:
        (Font::drawText):

2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149
2002-10-25  Richard Williamson   <rjw@apple.com>

        Implemented support for bidi text layout.  WebCore
        temporarily depends on SPI to get unicode character
        attribute from CF.  This will change shortly.
        
        * khtml/rendering/font.cpp:
        (Font::drawText):
        * kwq/KWQChar.mm:
        (QChar::direction):
        * kwq/KWQPainter.mm:
        (QPainter::drawText):
        * kwq/WebCoreTextRenderer.h:
        * kwq/qt/qpainter.h:

cblu's avatar
cblu committed
2150 2151 2152 2153 2154 2155 2156 2157 2158 2159
2002-10-25  Chris Blumenberg  <cblu@apple.com>

	Cleaned up the frame searching shenanigans. Things are much cleaner and clearer now.

        * kwq/KWQKHTMLPartBrowserExtension.mm:
        (KHTMLPartBrowserExtension::createNewWindow): call findFrameNamed
        * kwq/KWQKHTMLPartImpl.mm:
        (KWQKHTMLPartImpl::bridgeForFrameName): call findOrCreateFramedNamed
        * kwq/WebCoreBridge.h:

2160 2161 2162 2163 2164 2165 2166 2167
2002-10-25  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3065638 - "undefined" output to screen on empty document.write()
	
        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLDocFunction::tryCall): Don;t assume there is at least
	one argument.

2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178
2002-10-25  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3048031 - innerHTML is incorrectly null
	
        * kwq/KWQString.mm:
        (QString::isNull): Check for NULL by comparing to
	shared_null_handle instead of checking for 0 length, so
	garden-variety empty strings don't show as NULL.
        (QString::QString): Make sure that string created with a NULL char
	* uses the shared null handle, so it's properly NULL.

2179 2180 2181 2182 2183 2184 2185 2186
2002-10-24  Richard Williamson   <rjw@apple.com>

        Updated to reflect new calling parameter semantic of floatCharacterWidths(),
        which now returns the entire array of widths up the last character requested.
        
        * khtml/rendering/render_text.cpp:
        (TextSlave::checkSelectionPoint):

2187 2188 2189 2190 2191 2192 2193
2002-10-24  David Hyatt  <hyatt@apple.com>

	<pre>, <xmp> and <plaintext> should all have a top margin of 1em.
	Fixes a bunch of sites that use <pre>.
	
        * khtml/css/html4.css:

cblu's avatar
cblu committed
2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205
2002-10-24  Chris Blumenberg  <cblu@apple.com>

	Removed didAddSubview calls because that can easily be done in WebKit. Duh!

        * khtml/rendering/render_frames.cpp:
        (RenderPart::setWidget):
        * kwq/KWQKHTMLPartImpl.h:
        * kwq/KWQKHTMLPartImpl.mm:
        * kwq/KWQKJavaAppletWidget.mm:
        (KJavaAppletWidget::showApplet):
        * kwq/WebCoreBridge.h:

2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271
2002-10-24  Darin Adler  <darin@apple.com>

	A step in the direction of making KWQ headers much nicer.
	Move all empty headers out of kwq, and into ForwardingHeaders.

        * ForwardingHeaders/kcmdlineargs.h: Added.
        * ForwardingHeaders/kdatastream.h: Added.
        * ForwardingHeaders/khtml_iface.h: Added.
        * ForwardingHeaders/khtml_printsettings.h: Added.
        * ForwardingHeaders/khtml_run.h: Added.
        * ForwardingHeaders/kio/kprinter.h: Added.
        * ForwardingHeaders/kio/kprotocolmanager.h:
        * ForwardingHeaders/kio/ktrader.h: Added.
        * ForwardingHeaders/kio/scheduler.h: Added.
        * ForwardingHeaders/kmultipledrag.h: Added.
        * ForwardingHeaders/kprinter.h: Added.
        * ForwardingHeaders/kprotocolmanager.h: Added.
        * ForwardingHeaders/ksslcertchain.h: Added.
        * ForwardingHeaders/ksslinfodlg.h: Added.
        * ForwardingHeaders/kstdaction.h: Added.
        * ForwardingHeaders/ktempfile.h: Added.
        * ForwardingHeaders/ktrader.h: Added.
        * ForwardingHeaders/kurldrag.h: Added.
        * ForwardingHeaders/kxmlguifactory.h: Added.
        * ForwardingHeaders/qasyncimageio.h: Added.
        * ForwardingHeaders/qbitmap.h: Added.
        * ForwardingHeaders/qclipboard.h: Added.
        * ForwardingHeaders/qfontdatabase.h: Added.
        * ForwardingHeaders/qglobal.h: Added.
        * ForwardingHeaders/qhbox.h: Added.
        * ForwardingHeaders/qintcache.h: Added.
        * ForwardingHeaders/qintdict.h: Added.
        * ForwardingHeaders/qmetaobject.h: Added.
        * ForwardingHeaders/qobjectlist.h: Added.
        * ForwardingHeaders/scheduler.h: Added.

        * kwq/dcop/kdatastream.h: Removed.
        * kwq/kdecore/kcmdlineargs.h: Removed.
        * kwq/kdecore/kmultipledrag.h: Removed.
        * kwq/kdecore/ktempfile.h: Removed.
        * kwq/kdecore/kurldrag.h: Removed.
        * kwq/kdeui/kstdaction.h: Removed.
        * kwq/kdeui/kxmlguifactory.h: Removed.
        * kwq/khtml/khtml_iface.h: Removed.
        * kwq/khtml/khtml_printsettings.h: Removed.
        * kwq/khtml/khtml_run.h: Removed.
        * kwq/kio/kprinter.h: Removed.
        * kwq/kio/kprotocolmanager.h: Removed.
        * kwq/kio/kssl/ksslcertchain.h: Removed.
        * kwq/kio/kssl/ksslinfodlg.h: Removed.
        * kwq/kio/ktrader.h: Removed.
        * kwq/kio/scheduler.h: Removed.
        * kwq/qt/qasyncimageio.h: Removed.
        * kwq/qt/qbitmap.h: Removed.
        * kwq/qt/qclipboard.h: Removed.
        * kwq/qt/qfontdatabase.h: Removed.
        * kwq/qt/qglobal.h: Removed.
        * kwq/qt/qhbox.h: Removed.
        * kwq/qt/qintcache.h: Removed.
        * kwq/qt/qintdict.h: Removed.
        * kwq/qt/qmetaobject.h: Removed.
        * kwq/qt/qobjectlist.h: Removed.

        * WebCore.pbproj/project.pbxproj: Removed all the above headers from
	the project.

2272 2273 2274 2275 2276
2002-10-24  Darin Adler  <darin@apple.com>

        * ForwardingHeaders/private/qucomextra_p.h: Emptied this out.
        * kwq/qt/private/qucomextra_p.h: Removed.

2277 2278 2279 2280 2281 2282 2283 2284 2285 2286
2002-10-24  David Hyatt  <hyatt@apple.com>

	Make sure that KHTML's initial layout happens after KHTML
	fires the onload.  This means that in the case where we
	beat the timer, we will now fire the onload before both
	the initial layout and the initial paint.
	
        * khtml/html/html_documentimpl.cpp:
        (HTMLDocumentImpl::close):

sheridan's avatar
sheridan committed
2287 2288
=== Alexander-29 ===

cblu's avatar
cblu committed
2289 2290 2291 2292 2293 2294 2295 2296
2002-10-24  Chris Blumenberg  <cblu@apple.com>

	Use "MIMEType" instead of "serviceType".

        * kwq/KWQKHTMLPartImpl.mm:
        (KWQKHTMLPartImpl::createPart):
        * kwq/WebCoreBridge.h:

2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310
2002-10-24  Darin Adler  <darin@apple.com>

        * kwq/KWQKLocale.mm: (i18n): Make it obvious when non-localized
	strings from WebCore show up in the UI, but putting the string
	"not localized: " in front.

        * kwq/KWQKMessageBox.mm:
        (KMessageBox::error): Fix use of NSRunAlertPanel so that we won't
	accidentally try to interpret % sequences in the messages we are displaying.
        (KMessageBox::warningYesNo): Ditto.
        (KMessageBox::questionYesNo): Ditto.
        (KMessageBox::sorry): Ditto.
        (KMessageBox::information): Ditto.

cblu's avatar
cblu committed
2311 2312 2313 2314 2315 2316 2317 2318 2319 2320
2002-10-23  Chris Blumenberg  <cblu@apple.com>

	WebKit now gets called when render_frame subviews are added.

        * khtml/rendering/render_frames.cpp:
        (RenderPart::setWidget): call didAddWidget on the part
        * kwq/KWQKHTMLPartImpl.h:
        * kwq/KWQKHTMLPartImpl.mm:
        (KWQKHTMLPartImpl::didAddWidget): added, calls didAddSubview on the bridge

cblu's avatar
cblu committed
2321 2322 2323 2324 2325